Michael Hohn
495b52661e
add viewer configuration
Run CLI tests / Find Nightly Release (push) Has been cancelled
Run CLI tests / Set Matrix for cli-test (push) Has been cancelled
Run CLI tests / CLI Test (push) Has been cancelled
Run CLI tests / Report failure on the default branch (push) Has been cancelled
Update Node version / Create PR (push) Has been cancelled
Bump CLI version / Build (push) Has been cancelled
Code Scanning - CodeQL / codeql (push) Has been cancelled
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2025-08-19 11:24:15 -07:00
Michael Hohn
9a6aa52a40
fix: reconciled status names between server/agent/vscode-codeql
Update Node version / Create PR (push) Has been cancelled
Run CLI tests / Find Nightly Release (push) Has been cancelled
Run CLI tests / Set Matrix for cli-test (push) Has been cancelled
Run CLI tests / CLI Test (push) Has been cancelled
Run CLI tests / Report failure on the default branch (push) Has been cancelled
Code Scanning - CodeQL / codeql (push) Has been cancelled
Bump CLI version / Build (push) Has been cancelled
2025-03-14 12:45:36 -07:00
Michael Hohn
c106903f01
wip: update settings, push new images
2025-02-20 10:30:22 -08:00
Nicolas Will
d40cda150c
WIP: standalone MRVA
2024-07-01 18:20:23 +02:00
Nora
d4df484acb
Merge pull request #3645 from github/dependabot/npm_and_yarn/extensions/ql-vscode/storybook-445e2aa325
...
Bump the storybook group in /extensions/ql-vscode with 12 updates
2024-06-21 09:26:31 +02:00
Nora
3e1d924110
Merge pull request #3646 from github/dependabot/npm_and_yarn/extensions/ql-vscode/testing-library-f694122557
...
Bump @testing-library/jest-dom from 6.4.5 to 6.4.6 in /extensions/ql-vscode in the testing-library group
2024-06-21 09:26:06 +02:00
dependabot[bot]
cc4666a614
Bump @testing-library/jest-dom
...
Bumps the testing-library group in /extensions/ql-vscode with 1 update: [@testing-library/jest-dom](https://github.com/testing-library/jest-dom ).
Updates `@testing-library/jest-dom` from 6.4.5 to 6.4.6
- [Release notes](https://github.com/testing-library/jest-dom/releases )
- [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/jest-dom/compare/v6.4.5...v6.4.6 )
---
updated-dependencies:
- dependency-name: "@testing-library/jest-dom"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: testing-library
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-20 13:19:50 +00:00
dependabot[bot]
51906bbcee
Bump the storybook group in /extensions/ql-vscode with 12 updates
...
Bumps the storybook group in /extensions/ql-vscode with 12 updates:
| Package | From | To |
| --- | --- | --- |
| [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y ) | `8.1.8` | `8.1.10` |
| [@storybook/addon-actions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/actions ) | `8.1.8` | `8.1.10` |
| [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/essentials ) | `8.1.8` | `8.1.10` |
| [@storybook/addon-interactions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/interactions ) | `8.1.8` | `8.1.10` |
| [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/links ) | `8.1.8` | `8.1.10` |
| [@storybook/blocks](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/blocks ) | `8.1.8` | `8.1.10` |
| [@storybook/components](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/components ) | `8.1.8` | `8.1.10` |
| [@storybook/manager-api](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/manager-api ) | `8.1.8` | `8.1.10` |
| [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/react ) | `8.1.8` | `8.1.10` |
| [@storybook/react-vite](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-vite ) | `8.1.8` | `8.1.10` |
| [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/theming ) | `8.1.8` | `8.1.10` |
| [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli ) | `8.1.8` | `8.1.10` |
Updates `@storybook/addon-a11y` from 8.1.8 to 8.1.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.10/code/addons/a11y )
Updates `@storybook/addon-actions` from 8.1.8 to 8.1.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.10/code/addons/actions )
Updates `@storybook/addon-essentials` from 8.1.8 to 8.1.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.10/code/addons/essentials )
Updates `@storybook/addon-interactions` from 8.1.8 to 8.1.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.10/code/addons/interactions )
Updates `@storybook/addon-links` from 8.1.8 to 8.1.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.10/code/addons/links )
Updates `@storybook/blocks` from 8.1.8 to 8.1.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.10/code/ui/blocks )
Updates `@storybook/components` from 8.1.8 to 8.1.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.10/code/ui/components )
Updates `@storybook/manager-api` from 8.1.8 to 8.1.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.10/code/lib/manager-api )
Updates `@storybook/react` from 8.1.8 to 8.1.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.10/code/renderers/react )
Updates `@storybook/react-vite` from 8.1.8 to 8.1.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.10/code/frameworks/react-vite )
Updates `@storybook/theming` from 8.1.8 to 8.1.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.10/code/lib/theming )
Updates `storybook` from 8.1.8 to 8.1.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.10/code/lib/cli )
---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-actions"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-essentials"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-interactions"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-links"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/blocks"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/components"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/manager-api"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/react"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/react-vite"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/theming"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: storybook
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-20 13:19:27 +00:00
Robert
fcfa6979e2
Merge pull request #3643 from github/robertbrignull/re-enable-short-paths
...
Re-enable windows 8.3 paths in tests
2024-06-19 10:20:24 +01:00
Andrew Eisenberg
f0783ed274
Merge pull request #3644 from github/dependabot/npm_and_yarn/extensions/ql-vscode/ws-8.17.1
...
Bump ws from 8.15.0 to 8.17.1 in /extensions/ql-vscode
2024-06-18 14:33:18 -07:00
dependabot[bot]
fe45e00fb3
Bump ws from 8.15.0 to 8.17.1 in /extensions/ql-vscode
...
Bumps [ws](https://github.com/websockets/ws ) from 8.15.0 to 8.17.1.
- [Release notes](https://github.com/websockets/ws/releases )
- [Commits](https://github.com/websockets/ws/compare/8.15.0...8.17.1 )
---
updated-dependencies:
- dependency-name: ws
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-18 21:07:21 +00:00
Robert
4a317d33a9
Enable 8.3 paths in unit tests
2024-06-18 10:08:18 +00:00
Robert
ffc7135c1f
Revert "Remove short-paths.test.ts"
...
This reverts commit 10f4b47019 .
2024-06-18 09:31:33 +00:00
Nora
c805b48f18
Merge pull request #3640 from github/nora/update-pr-template
...
Update vscode-codeql PR template
2024-06-17 17:32:50 +02:00
Nora
e1b95c2f7c
Merge pull request #3641 from github/nora/update-outdated-readme-links
...
Update outdated links in VS Code extension README
2024-06-17 16:54:07 +02:00
Nora
481d2f5404
Remove language preference
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2024-06-17 09:22:55 +02:00
Nora
15fa23acb4
Fix grammatical issue
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2024-06-17 09:22:27 +02:00
Nora
a625d9aabe
Update old links
2024-06-14 15:11:47 +00:00
Nora
cd70b19bb3
Add changelog reminder to PR submit guidance
2024-06-14 14:52:58 +00:00
Nora
7a58084df9
Remove checklist but keep a note on the changelog
2024-06-14 14:50:18 +00:00
Nora
916d16126b
Merge pull request #3633 from github/github-action/bump-node-version
...
Bump Node version to v20.9.0
2024-06-14 14:42:54 +02:00
Nora
a5eb915267
Merge pull request #3632 from github/dependabot/npm_and_yarn/extensions/ql-vscode/ts-unused-exports-10.1.0
...
Bump ts-unused-exports from 10.0.1 to 10.1.0 in /extensions/ql-vscode
2024-06-14 14:42:44 +02:00
dependabot[bot]
a5440ef482
Bump ts-unused-exports from 10.0.1 to 10.1.0 in /extensions/ql-vscode
...
Bumps [ts-unused-exports](https://github.com/pzavolinsky/ts-unused-exports ) from 10.0.1 to 10.1.0.
- [Changelog](https://github.com/pzavolinsky/ts-unused-exports/blob/master/CHANGELOG.md )
- [Commits](https://github.com/pzavolinsky/ts-unused-exports/commits )
---
updated-dependencies:
- dependency-name: ts-unused-exports
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-14 12:26:39 +00:00
Nora
fc86be7687
Merge branch 'main' into github-action/bump-node-version
2024-06-14 12:24:20 +00:00
Nora
f0909a9d67
Merge pull request #3636 from github/github-action/bump-cli
...
Bump CLI Version to v2.17.5 for integration tests
2024-06-14 14:23:19 +02:00
Nora
40b5b5ba7e
Merge pull request #3639 from github/dependabot/npm_and_yarn/extensions/ql-vscode/storybook-f899e8f28b
...
Bump the storybook group in /extensions/ql-vscode with 12 updates
2024-06-13 15:50:42 +02:00
dependabot[bot]
fa85bcfad6
Bump the storybook group in /extensions/ql-vscode with 12 updates
...
Bumps the storybook group in /extensions/ql-vscode with 12 updates:
| Package | From | To |
| --- | --- | --- |
| [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y ) | `8.1.6` | `8.1.8` |
| [@storybook/addon-actions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/actions ) | `8.1.6` | `8.1.8` |
| [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/essentials ) | `8.1.6` | `8.1.8` |
| [@storybook/addon-interactions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/interactions ) | `8.1.6` | `8.1.8` |
| [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/links ) | `8.1.6` | `8.1.8` |
| [@storybook/blocks](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/blocks ) | `8.1.6` | `8.1.8` |
| [@storybook/components](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/components ) | `8.1.6` | `8.1.8` |
| [@storybook/manager-api](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/manager-api ) | `8.1.6` | `8.1.8` |
| [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/react ) | `8.1.6` | `8.1.8` |
| [@storybook/react-vite](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-vite ) | `8.1.6` | `8.1.8` |
| [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/theming ) | `8.1.6` | `8.1.8` |
| [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli ) | `8.1.6` | `8.1.8` |
Updates `@storybook/addon-a11y` from 8.1.6 to 8.1.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.8/code/addons/a11y )
Updates `@storybook/addon-actions` from 8.1.6 to 8.1.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.8/code/addons/actions )
Updates `@storybook/addon-essentials` from 8.1.6 to 8.1.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.8/code/addons/essentials )
Updates `@storybook/addon-interactions` from 8.1.6 to 8.1.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.8/code/addons/interactions )
Updates `@storybook/addon-links` from 8.1.6 to 8.1.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.8/code/addons/links )
Updates `@storybook/blocks` from 8.1.6 to 8.1.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.8/code/ui/blocks )
Updates `@storybook/components` from 8.1.6 to 8.1.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.8/code/ui/components )
Updates `@storybook/manager-api` from 8.1.6 to 8.1.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.8/code/lib/manager-api )
Updates `@storybook/react` from 8.1.6 to 8.1.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.8/code/renderers/react )
Updates `@storybook/react-vite` from 8.1.6 to 8.1.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.8/code/frameworks/react-vite )
Updates `@storybook/theming` from 8.1.6 to 8.1.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.8/code/lib/theming )
Updates `storybook` from 8.1.6 to 8.1.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.8/code/lib/cli )
---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-actions"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-essentials"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-interactions"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-links"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/blocks"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/components"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/manager-api"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/react"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/react-vite"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/theming"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: storybook
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-13 13:36:58 +00:00
Chris Smowton
dd1b054f26
Merge branch 'main' into github-action/bump-cli
2024-06-13 14:33:51 +01:00
Kasper Svendsen
b96cd6c7e1
Merge pull request #3635 from github/kaspersv/clear-pkg-cache-on-dbscheme-changes
...
Clear query server package cache on dbscheme edits
2024-06-13 13:47:16 +02:00
Kasper Svendsen
b466d2aa36
Merge branch 'main' into kaspersv/clear-pkg-cache-on-dbscheme-changes
2024-06-13 13:34:18 +02:00
Robert
7f6c1ad7f7
Merge pull request #3637 from github/robertbrignull/remove_path_tests
...
Remove short-paths.test.ts
2024-06-13 12:26:39 +01:00
Robert
10f4b47019
Remove short-paths.test.ts
2024-06-13 11:03:37 +00:00
github-actions[bot]
b31a769fdd
Bump CLI version from v2.17.4 to v2.17.5 for integration tests
2024-06-12 17:18:50 +00:00
github-actions[bot]
c4e2f11372
Bump Node version to v20.9.0
2024-06-12 12:25:46 +00:00
Kasper Svendsen
9494d32144
Clear query server package cache on dbscheme edits
2024-06-11 10:55:42 +00:00
Andrew Eisenberg
12555d90c1
Merge pull request #3630 from github/dependabot/npm_and_yarn/extensions/ql-vscode/storybook-a6a5a2e80a
...
Bump the storybook group in /extensions/ql-vscode with 13 updates
2024-06-06 09:48:18 -07:00
dependabot[bot]
d46e03b4cc
Bump the storybook group in /extensions/ql-vscode with 13 updates
...
Bumps the storybook group in /extensions/ql-vscode with 13 updates:
| Package | From | To |
| --- | --- | --- |
| [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y ) | `8.1.5` | `8.1.6` |
| [@storybook/addon-actions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/actions ) | `8.1.5` | `8.1.6` |
| [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/essentials ) | `8.1.5` | `8.1.6` |
| [@storybook/addon-interactions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/interactions ) | `8.1.5` | `8.1.6` |
| [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/links ) | `8.1.5` | `8.1.6` |
| [@storybook/blocks](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/blocks ) | `8.1.5` | `8.1.6` |
| [@storybook/components](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/components ) | `8.1.5` | `8.1.6` |
| [@storybook/csf](https://github.com/ComponentDriven/csf ) | `0.1.7` | `0.1.8` |
| [@storybook/manager-api](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/manager-api ) | `8.1.5` | `8.1.6` |
| [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/react ) | `8.1.5` | `8.1.6` |
| [@storybook/react-vite](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-vite ) | `8.1.5` | `8.1.6` |
| [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/theming ) | `8.1.5` | `8.1.6` |
| [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli ) | `8.1.5` | `8.1.6` |
Updates `@storybook/addon-a11y` from 8.1.5 to 8.1.6
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.6/code/addons/a11y )
Updates `@storybook/addon-actions` from 8.1.5 to 8.1.6
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.6/code/addons/actions )
Updates `@storybook/addon-essentials` from 8.1.5 to 8.1.6
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.6/code/addons/essentials )
Updates `@storybook/addon-interactions` from 8.1.5 to 8.1.6
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.6/code/addons/interactions )
Updates `@storybook/addon-links` from 8.1.5 to 8.1.6
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.6/code/addons/links )
Updates `@storybook/blocks` from 8.1.5 to 8.1.6
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.6/code/ui/blocks )
Updates `@storybook/components` from 8.1.5 to 8.1.6
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.6/code/ui/components )
Updates `@storybook/csf` from 0.1.7 to 0.1.8
- [Release notes](https://github.com/ComponentDriven/csf/releases )
- [Changelog](https://github.com/ComponentDriven/csf/blob/v0.1.8/CHANGELOG.md )
- [Commits](https://github.com/ComponentDriven/csf/compare/v0.1.7...v0.1.8 )
Updates `@storybook/manager-api` from 8.1.5 to 8.1.6
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.6/code/lib/manager-api )
Updates `@storybook/react` from 8.1.5 to 8.1.6
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.6/code/renderers/react )
Updates `@storybook/react-vite` from 8.1.5 to 8.1.6
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.6/code/frameworks/react-vite )
Updates `@storybook/theming` from 8.1.5 to 8.1.6
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.6/code/lib/theming )
Updates `storybook` from 8.1.5 to 8.1.6
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.6/code/lib/cli )
---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-actions"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-essentials"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-interactions"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-links"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/blocks"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/components"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/csf"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/manager-api"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/react"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/react-vite"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/theming"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: storybook
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-06 14:20:38 +00:00
dependabot[bot]
f0e2285122
Bump @testing-library/react ( #3631 )
...
Bumps the testing-library group in /extensions/ql-vscode with 1 update: [@testing-library/react](https://github.com/testing-library/react-testing-library ).
Updates `@testing-library/react` from 15.0.7 to 16.0.0
- [Release notes](https://github.com/testing-library/react-testing-library/releases )
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/react-testing-library/compare/v15.0.7...v16.0.0 )
---
updated-dependencies:
- dependency-name: "@testing-library/react"
dependency-type: direct:development
update-type: version-update:semver-major
dependency-group: testing-library
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-06 15:16:43 +01:00
Koen Vlaswinkel
f4d0d23170
Merge pull request #3629 from github/github-action/bump-cli
...
Bump CLI Version to v2.17.4 for integration tests
2024-06-04 10:06:27 +02:00
github-actions[bot]
513fb65560
Bump CLI version from v2.17.3 to v2.17.4 for integration tests
2024-06-03 16:10:31 +00:00
Koen Vlaswinkel
7d353ced9b
Merge pull request #3626 from github/dependabot/npm_and_yarn/extensions/ql-vscode/storybook-d4cb5c71ab
...
Bump the storybook group in /extensions/ql-vscode with 12 updates
2024-05-31 10:09:46 +02:00
dependabot[bot]
be3506d987
Bump the storybook group in /extensions/ql-vscode with 12 updates
...
Bumps the storybook group in /extensions/ql-vscode with 12 updates:
| Package | From | To |
| --- | --- | --- |
| [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y ) | `8.1.3` | `8.1.5` |
| [@storybook/addon-actions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/actions ) | `8.1.3` | `8.1.5` |
| [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/essentials ) | `8.1.3` | `8.1.5` |
| [@storybook/addon-interactions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/interactions ) | `8.1.3` | `8.1.5` |
| [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/links ) | `8.1.3` | `8.1.5` |
| [@storybook/blocks](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/blocks ) | `8.1.3` | `8.1.5` |
| [@storybook/components](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/components ) | `8.1.3` | `8.1.5` |
| [@storybook/manager-api](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/manager-api ) | `8.1.3` | `8.1.5` |
| [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/react ) | `8.1.3` | `8.1.5` |
| [@storybook/react-vite](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-vite ) | `8.1.3` | `8.1.5` |
| [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/theming ) | `8.1.3` | `8.1.5` |
| [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli ) | `8.1.3` | `8.1.5` |
Updates `@storybook/addon-a11y` from 8.1.3 to 8.1.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.5/code/addons/a11y )
Updates `@storybook/addon-actions` from 8.1.3 to 8.1.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.5/code/addons/actions )
Updates `@storybook/addon-essentials` from 8.1.3 to 8.1.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.5/code/addons/essentials )
Updates `@storybook/addon-interactions` from 8.1.3 to 8.1.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.5/code/addons/interactions )
Updates `@storybook/addon-links` from 8.1.3 to 8.1.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.5/code/addons/links )
Updates `@storybook/blocks` from 8.1.3 to 8.1.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.5/code/ui/blocks )
Updates `@storybook/components` from 8.1.3 to 8.1.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.5/code/ui/components )
Updates `@storybook/manager-api` from 8.1.3 to 8.1.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.5/code/lib/manager-api )
Updates `@storybook/react` from 8.1.3 to 8.1.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.5/code/renderers/react )
Updates `@storybook/react-vite` from 8.1.3 to 8.1.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.5/code/frameworks/react-vite )
Updates `@storybook/theming` from 8.1.3 to 8.1.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.5/code/lib/theming )
Updates `storybook` from 8.1.3 to 8.1.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.5/code/lib/cli )
---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-actions"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-essentials"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-interactions"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-links"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/blocks"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/components"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/manager-api"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/react"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/react-vite"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/theming"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: storybook
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-30 14:06:20 +00:00
dependabot[bot]
3fa6304050
Bump @babel/core from 7.24.4 to 7.24.6 in /extensions/ql-vscode ( #3628 )
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.24.4 to 7.24.6.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.24.6/packages/babel-core )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-30 07:03:18 -07:00
dependabot[bot]
bb40e5bcad
Bump ts-jest from 29.1.2 to 29.1.4 in /extensions/ql-vscode ( #3627 )
...
Bumps [ts-jest](https://github.com/kulshekhar/ts-jest ) from 29.1.2 to 29.1.4.
- [Release notes](https://github.com/kulshekhar/ts-jest/releases )
- [Changelog](https://github.com/kulshekhar/ts-jest/blob/main/CHANGELOG.md )
- [Commits](https://github.com/kulshekhar/ts-jest/compare/v29.1.2...v29.1.4 )
---
updated-dependencies:
- dependency-name: ts-jest
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-30 07:02:48 -07:00
Koen Vlaswinkel
e2a8ae318b
Merge pull request #3625 from github/koesie10/update-test-plan
...
Update test plan
2024-05-29 11:46:43 +02:00
Koen Vlaswinkel
79867e2f9d
Merge pull request #3624 from github/version/bump-to-v1.13.2
...
Bump version to v1.13.2
2024-05-29 11:46:29 +02:00
Koen Vlaswinkel
1bc13d70ce
Update test plan
...
This fixes the model pack query to account for the new MAD ID in the
`sinkModel` and removes the LLM section.
2024-05-29 11:22:04 +02:00
github-actions[bot]
0bd359997d
Bump version to v1.13.2
2024-05-29 09:17:05 +00:00
Koen Vlaswinkel
28a7d1cf34
Merge pull request #3623 from github/v1.13.1
...
v1.13.1
2024-05-29 11:15:50 +02:00
Koen Vlaswinkel
1572c095ca
v1.13.1
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2024-05-29 10:43:56 +02:00
Nick Rolfe
83df05e731
Merge pull request #3622 from github/nickrolfe/eval-log-progress
...
Report progress for post-evaluation actions
2024-05-28 17:38:56 +01:00
Nick Rolfe
b43b1d4c8e
Update changelog for progress reporting on post-evaluation steps
2024-05-28 11:06:00 +00:00
Nick Rolfe
79ff9e0378
Report progress for post-evaluation actions
...
Generating and parsing log summaries can be quite slow, so we should update the progress window with messages about what's being worked on.
2024-05-28 11:05:34 +00:00
Andrew Eisenberg
d7a82cc686
Merge pull request #3616 from github/aeisenberg/flush-cache-on-db-remove
...
Fix bug with reimporting test cases
2024-05-23 08:55:23 -07:00
Andrew Eisenberg
39ad5b28c7
Fix typo in comment
...
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com >
2024-05-23 08:43:03 -07:00
Robert
68c159f1fe
Merge pull request #3619 from github/dependabot/npm_and_yarn/extensions/ql-vscode/storybook-23a9a17fad
...
Bump the storybook group in /extensions/ql-vscode with 12 updates
2024-05-23 15:55:29 +01:00
Robert
355a6fc552
Merge pull request #3621 from github/dependabot/npm_and_yarn/extensions/ql-vscode/markdownlint-cli2-formatter-pretty-0.0.6
...
Bump markdownlint-cli2-formatter-pretty from 0.0.5 to 0.0.6 in /extensions/ql-vscode
2024-05-23 14:52:49 +01:00
dependabot[bot]
6f54bebe35
Bump markdownlint-cli2-formatter-pretty in /extensions/ql-vscode
...
Bumps [markdownlint-cli2-formatter-pretty](https://github.com/DavidAnson/markdownlint-cli2 ) from 0.0.5 to 0.0.6.
- [Changelog](https://github.com/DavidAnson/markdownlint-cli2/blob/main/CHANGELOG.md )
- [Commits](https://github.com/DavidAnson/markdownlint-cli2/compare/v0.0.5...v0.0.6 )
---
updated-dependencies:
- dependency-name: markdownlint-cli2-formatter-pretty
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-23 13:40:16 +00:00
dependabot[bot]
bea108a412
Bump the storybook group in /extensions/ql-vscode with 12 updates
...
Bumps the storybook group in /extensions/ql-vscode with 12 updates:
| Package | From | To |
| --- | --- | --- |
| [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y ) | `8.1.1` | `8.1.3` |
| [@storybook/addon-actions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/actions ) | `8.1.1` | `8.1.3` |
| [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/essentials ) | `8.1.1` | `8.1.3` |
| [@storybook/addon-interactions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/interactions ) | `8.1.1` | `8.1.3` |
| [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/links ) | `8.1.1` | `8.1.3` |
| [@storybook/blocks](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/blocks ) | `8.1.1` | `8.1.3` |
| [@storybook/components](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/components ) | `8.1.1` | `8.1.3` |
| [@storybook/manager-api](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/manager-api ) | `8.1.1` | `8.1.3` |
| [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/react ) | `8.1.1` | `8.1.3` |
| [@storybook/react-vite](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-vite ) | `8.1.1` | `8.1.3` |
| [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/theming ) | `8.1.1` | `8.1.3` |
| [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli ) | `8.1.1` | `8.1.3` |
Updates `@storybook/addon-a11y` from 8.1.1 to 8.1.3
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.3/code/addons/a11y )
Updates `@storybook/addon-actions` from 8.1.1 to 8.1.3
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.3/code/addons/actions )
Updates `@storybook/addon-essentials` from 8.1.1 to 8.1.3
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.3/code/addons/essentials )
Updates `@storybook/addon-interactions` from 8.1.1 to 8.1.3
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.3/code/addons/interactions )
Updates `@storybook/addon-links` from 8.1.1 to 8.1.3
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.3/code/addons/links )
Updates `@storybook/blocks` from 8.1.1 to 8.1.3
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.3/code/ui/blocks )
Updates `@storybook/components` from 8.1.1 to 8.1.3
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.3/code/ui/components )
Updates `@storybook/manager-api` from 8.1.1 to 8.1.3
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.3/code/lib/manager-api )
Updates `@storybook/react` from 8.1.1 to 8.1.3
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.3/code/renderers/react )
Updates `@storybook/react-vite` from 8.1.1 to 8.1.3
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.3/code/frameworks/react-vite )
Updates `@storybook/theming` from 8.1.1 to 8.1.3
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.3/code/lib/theming )
Updates `storybook` from 8.1.1 to 8.1.3
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.3/code/lib/cli )
---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-actions"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-essentials"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-interactions"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-links"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/blocks"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/components"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/manager-api"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/react"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/react-vite"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/theming"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: storybook
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-23 13:39:25 +00:00
Andrew Eisenberg
088d2fa91e
Fix failing tests
...
Also:
- Address comments in PR
- Add changelog note
2024-05-22 23:05:12 +00:00
Andrew Eisenberg
6c92a5b800
Merge remote-tracking branch 'upstream/main' into aeisenberg/flush-cache-on-db-remove
2024-05-22 22:42:54 +00:00
Robert
db0d062443
Merge pull request #3618 from github/robertbrignull/delete-ghec-dr-flag
...
Remove the enableGhecDr flag
2024-05-22 11:47:11 +01:00
Robert
673ea13af8
Remove the enableGhecDr flag
2024-05-22 10:42:47 +01:00
Koen Vlaswinkel
2208b42485
Merge pull request #3615 from github/github-action/bump-cli
...
Bump CLI Version to v2.17.3 for integration tests
2024-05-21 10:47:38 +02:00
Andrew Eisenberg
376d6b75d6
Fix bug with reimporting test cases
...
When re-importing a test database, if the source archive for that
database is not in the workspace, then old source code will be seen when
inspected.
To reproduce:
1. Run a ql test file with a failure (I'm using a javascript DB).
2. Right click and import on the db that sticks around.
3. Change the JS source file for the test.
4. Re-run and still have a failure.
5. Re-import the database
6. Run the query under test
7. Click on a result item
8. **BUG:** The source code is old
The problem is that the source archive cache is not being flushed in
this case. I added a case to flush the source archive when the archive
was imported into the workspace as a folder, but not when the archive is
external.
The fix is to listen for database remove events in the archive
filesystem provider and flush the associated database source
archive.
There is a complication:
The database remove event didn't emit the removed database. This is
because the only place that consumed the event didn't need it.
To get around this, I changed the structure of the events. I added a
new `fullRefresh` boolean. If true, then the original database change
handler will ensure the entire tree is refreshed. If false, only the
selected database.
2024-05-17 23:10:56 +00:00
dependabot[bot]
d8a7dcd7d2
Bump react-dom and @types/react-dom in /extensions/ql-vscode ( #3614 )
...
Bumps [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom ) and [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom ). These dependencies needed to be updated together.
Updates `react-dom` from 18.2.0 to 18.3.1
- [Release notes](https://github.com/facebook/react/releases )
- [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md )
- [Commits](https://github.com/facebook/react/commits/v18.3.1/packages/react-dom )
Updates `@types/react-dom` from 18.2.18 to 18.3.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom )
---
updated-dependencies:
- dependency-name: react-dom
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: "@types/react-dom"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-17 15:53:59 -07:00
github-actions[bot]
580257f024
Bump CLI version from v2.17.2 to v2.17.3 for integration tests
2024-05-17 17:05:04 +00:00
dependabot[bot]
233cb1cd41
Bump semver from 7.6.0 to 7.6.2 in /extensions/ql-vscode ( #3613 )
...
Bumps [semver](https://github.com/npm/node-semver ) from 7.6.0 to 7.6.2.
- [Release notes](https://github.com/npm/node-semver/releases )
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md )
- [Commits](https://github.com/npm/node-semver/compare/v7.6.0...v7.6.2 )
---
updated-dependencies:
- dependency-name: semver
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-16 09:34:12 -07:00
dependabot[bot]
d9fcfa0374
Bump the storybook group in /extensions/ql-vscode with 12 updates ( #3612 )
...
Bumps the storybook group in /extensions/ql-vscode with 12 updates:
| Package | From | To |
| --- | --- | --- |
| [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y ) | `8.0.10` | `8.1.1` |
| [@storybook/addon-actions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/actions ) | `8.0.10` | `8.1.1` |
| [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/essentials ) | `8.0.10` | `8.1.1` |
| [@storybook/addon-interactions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/interactions ) | `8.0.10` | `8.1.1` |
| [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/links ) | `8.0.10` | `8.1.1` |
| [@storybook/blocks](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/blocks ) | `8.0.10` | `8.1.1` |
| [@storybook/components](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/components ) | `8.0.10` | `8.1.1` |
| [@storybook/manager-api](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/manager-api ) | `8.0.10` | `8.1.1` |
| [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/react ) | `8.0.10` | `8.1.1` |
| [@storybook/react-vite](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-vite ) | `8.0.10` | `8.1.1` |
| [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/theming ) | `8.0.10` | `8.1.1` |
| [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli ) | `8.0.10` | `8.1.1` |
Updates `@storybook/addon-a11y` from 8.0.10 to 8.1.1
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.1/code/addons/a11y )
Updates `@storybook/addon-actions` from 8.0.10 to 8.1.1
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.1/code/addons/actions )
Updates `@storybook/addon-essentials` from 8.0.10 to 8.1.1
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.1/code/addons/essentials )
Updates `@storybook/addon-interactions` from 8.0.10 to 8.1.1
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.1/code/addons/interactions )
Updates `@storybook/addon-links` from 8.0.10 to 8.1.1
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.1/code/addons/links )
Updates `@storybook/blocks` from 8.0.10 to 8.1.1
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.1/code/ui/blocks )
Updates `@storybook/components` from 8.0.10 to 8.1.1
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.1/code/ui/components )
Updates `@storybook/manager-api` from 8.0.10 to 8.1.1
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.1/code/lib/manager-api )
Updates `@storybook/react` from 8.0.10 to 8.1.1
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.1/code/renderers/react )
Updates `@storybook/react-vite` from 8.0.10 to 8.1.1
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.1/code/frameworks/react-vite )
Updates `@storybook/theming` from 8.0.10 to 8.1.1
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.1/code/lib/theming )
Updates `storybook` from 8.0.10 to 8.1.1
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.1.1/code/lib/cli )
---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: storybook
- dependency-name: "@storybook/addon-actions"
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: storybook
- dependency-name: "@storybook/addon-essentials"
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: storybook
- dependency-name: "@storybook/addon-interactions"
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: storybook
- dependency-name: "@storybook/addon-links"
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: storybook
- dependency-name: "@storybook/blocks"
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: storybook
- dependency-name: "@storybook/components"
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: storybook
- dependency-name: "@storybook/manager-api"
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: storybook
- dependency-name: "@storybook/react"
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: storybook
- dependency-name: "@storybook/react-vite"
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: storybook
- dependency-name: "@storybook/theming"
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: storybook
- dependency-name: storybook
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: storybook
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-16 09:33:50 -07:00
Ben Ahmady
1dc48b3309
Update links in VS Marketplace README ( #3611 )
2024-05-15 08:52:15 +00:00
Angela P Wen
2babb0b106
Handle exit and error events for query server child processes ( #3610 )
2024-05-14 18:48:29 -07:00
Koen Vlaswinkel
247df2e1f9
Merge pull request #3607 from github/koesie10/ghec-dr-variant-analysis
...
Add GHEC-DR support
2024-05-14 10:40:28 +02:00
Koen Vlaswinkel
ba9007e426
Fix typo in comment
...
Co-authored-by: Robert <robertbrignull@github.com >
2024-05-14 09:42:04 +02:00
Koen Vlaswinkel
616b613fbd
Merge pull request #3608 from github/koesie10/fix-supported-cli-version-warning
...
Fix incorrect supported CLI version warning
2024-05-13 16:57:50 +02:00
Koen Vlaswinkel
47ae0fe9f5
Fix incorrect supported CLI version warning
2024-05-13 16:44:03 +02:00
Nora
9d6b4e8e5a
Merge pull request #3603 from github/dependabot/npm_and_yarn/extensions/ql-vscode/storybook-7db07c6d5e
...
Bump the storybook group in /extensions/ql-vscode with 13 updates
2024-05-13 16:32:04 +02:00
Nora
5ae70696a8
Merge pull request #3604 from github/dependabot/npm_and_yarn/extensions/ql-vscode/testing-library-66b9683d1a
...
Bump the testing-library group in /extensions/ql-vscode with 2 updates
2024-05-13 16:30:18 +02:00
dependabot[bot]
712dd525ee
Bump the storybook group in /extensions/ql-vscode with 13 updates
...
Bumps the storybook group in /extensions/ql-vscode with 13 updates:
| Package | From | To |
| --- | --- | --- |
| [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y ) | `8.0.9` | `8.0.10` |
| [@storybook/addon-actions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/actions ) | `8.0.9` | `8.0.10` |
| [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/essentials ) | `8.0.9` | `8.0.10` |
| [@storybook/addon-interactions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/interactions ) | `8.0.9` | `8.0.10` |
| [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/links ) | `8.0.9` | `8.0.10` |
| [@storybook/blocks](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/blocks ) | `8.0.9` | `8.0.10` |
| [@storybook/components](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/components ) | `8.0.9` | `8.0.10` |
| [@storybook/csf](https://github.com/ComponentDriven/csf ) | `0.1.6` | `0.1.7` |
| [@storybook/manager-api](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/manager-api ) | `8.0.9` | `8.0.10` |
| [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/react ) | `8.0.9` | `8.0.10` |
| [@storybook/react-vite](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-vite ) | `8.0.9` | `8.0.10` |
| [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/theming ) | `8.0.9` | `8.0.10` |
| [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli ) | `8.0.9` | `8.0.10` |
Updates `@storybook/addon-a11y` from 8.0.9 to 8.0.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.10/code/addons/a11y )
Updates `@storybook/addon-actions` from 8.0.9 to 8.0.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.10/code/addons/actions )
Updates `@storybook/addon-essentials` from 8.0.9 to 8.0.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.10/code/addons/essentials )
Updates `@storybook/addon-interactions` from 8.0.9 to 8.0.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.10/code/addons/interactions )
Updates `@storybook/addon-links` from 8.0.9 to 8.0.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.10/code/addons/links )
Updates `@storybook/blocks` from 8.0.9 to 8.0.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.10/code/ui/blocks )
Updates `@storybook/components` from 8.0.9 to 8.0.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.10/code/ui/components )
Updates `@storybook/csf` from 0.1.6 to 0.1.7
- [Release notes](https://github.com/ComponentDriven/csf/releases )
- [Changelog](https://github.com/ComponentDriven/csf/blob/v0.1.7/CHANGELOG.md )
- [Commits](https://github.com/ComponentDriven/csf/compare/v0.1.6...v0.1.7 )
Updates `@storybook/manager-api` from 8.0.9 to 8.0.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.10/code/lib/manager-api )
Updates `@storybook/react` from 8.0.9 to 8.0.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.10/code/renderers/react )
Updates `@storybook/react-vite` from 8.0.9 to 8.0.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.10/code/frameworks/react-vite )
Updates `@storybook/theming` from 8.0.9 to 8.0.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.10/code/lib/theming )
Updates `storybook` from 8.0.9 to 8.0.10
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.10/code/lib/cli )
---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-actions"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-essentials"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-interactions"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-links"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/blocks"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/components"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/csf"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/manager-api"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/react"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/react-vite"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/theming"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: storybook
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-13 14:19:37 +00:00
Nora
fdc5645928
Merge pull request #3606 from github/dependabot/npm_and_yarn/extensions/ql-vscode/eslint-plugin-github-4.10.2
...
Bump eslint-plugin-github from 4.10.1 to 4.10.2 in /extensions/ql-vscode
2024-05-13 16:18:42 +02:00
dependabot[bot]
5c81c0e9bf
Bump the testing-library group in /extensions/ql-vscode with 2 updates
...
Bumps the testing-library group in /extensions/ql-vscode with 2 updates: [@testing-library/jest-dom](https://github.com/testing-library/jest-dom ) and [@testing-library/react](https://github.com/testing-library/react-testing-library ).
Updates `@testing-library/jest-dom` from 6.4.2 to 6.4.5
- [Release notes](https://github.com/testing-library/jest-dom/releases )
- [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/jest-dom/compare/v6.4.2...v6.4.5 )
Updates `@testing-library/react` from 15.0.6 to 15.0.7
- [Release notes](https://github.com/testing-library/react-testing-library/releases )
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/react-testing-library/compare/v15.0.6...v15.0.7 )
---
updated-dependencies:
- dependency-name: "@testing-library/jest-dom"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: testing-library
- dependency-name: "@testing-library/react"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: testing-library
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-13 14:17:39 +00:00
dependabot[bot]
0e07e5e3eb
Bump eslint-plugin-github from 4.10.1 to 4.10.2 in /extensions/ql-vscode
...
Bumps [eslint-plugin-github](https://github.com/github/eslint-plugin-github ) from 4.10.1 to 4.10.2.
- [Release notes](https://github.com/github/eslint-plugin-github/releases )
- [Commits](https://github.com/github/eslint-plugin-github/compare/v4.10.1...v4.10.2 )
---
updated-dependencies:
- dependency-name: eslint-plugin-github
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-13 14:05:08 +00:00
Koen Vlaswinkel
c90acdb4e1
Merge pull request #3600 from github/github-action/bump-cli
...
Bump CLI Version to v2.17.2 for integration tests
2024-05-13 13:17:54 +02:00
Koen Vlaswinkel
dad37f202d
Merge pull request #3599 from github/koesie10/upgrade-publish-vsce
...
Use @vscode/vsce when publishing the extension
2024-05-13 13:04:42 +02:00
Koen Vlaswinkel
1f937ad208
Do not import from config in unit tests
2024-05-13 12:15:27 +02:00
Koen Vlaswinkel
086d8e2104
Update prompts to use GHEC-DR URL
2024-05-13 11:19:31 +02:00
Koen Vlaswinkel
c2ddd680c1
Use GHEC-DR URL in Octokit instance
2024-05-13 11:19:31 +02:00
Koen Vlaswinkel
9a14896a4e
Use GHE auth provider if GHEC-DR URI is set
2024-05-13 11:19:31 +02:00
Koen Vlaswinkel
871fc0b817
Use GHEC-DR URL in file blob URL
2024-05-13 11:19:31 +02:00
Koen Vlaswinkel
ca092a1623
Use GHEC-DR URL in Actions workflow run URL
2024-05-13 11:19:30 +02:00
Koen Vlaswinkel
529bbe3ffa
Handle GHEC-DR repository URLs
2024-05-13 11:19:30 +02:00
Koen Vlaswinkel
31b2d24ca9
Update custom errors to use GHEC-DR URL
2024-05-13 11:19:30 +02:00
github-actions[bot]
f54cace05b
Bump CLI version from v2.17.1 to v2.17.2 for integration tests
2024-05-07 11:22:36 +00:00
Koen Vlaswinkel
f773f9f675
Use @vscode/vsce when publishing the extension
2024-05-06 15:31:05 +02:00
dependabot[bot]
67aa216ea1
Bump react and @types/react in /extensions/ql-vscode ( #3596 )
...
Bumps [react](https://github.com/facebook/react/tree/HEAD/packages/react ) and [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react ). These dependencies needed to be updated together.
Updates `react` from 18.2.0 to 18.3.1
- [Release notes](https://github.com/facebook/react/releases )
- [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md )
- [Commits](https://github.com/facebook/react/commits/v18.3.1/packages/react )
Updates `@types/react` from 18.2.43 to 18.3.1
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react )
---
updated-dependencies:
- dependency-name: react
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: "@types/react"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-02 15:56:40 +01:00
dependabot[bot]
4b67f4dd54
Bump vite from 5.2.6 to 5.2.11 in /extensions/ql-vscode ( #3597 )
...
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite ) from 5.2.6 to 5.2.11.
- [Release notes](https://github.com/vitejs/vite/releases )
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md )
- [Commits](https://github.com/vitejs/vite/commits/v5.2.11/packages/vite )
---
updated-dependencies:
- dependency-name: vite
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-02 15:37:22 +01:00
dependabot[bot]
572a8b7828
Bump styled-components from 6.1.8 to 6.1.9 in /extensions/ql-vscode ( #3598 )
...
Bumps [styled-components](https://github.com/styled-components/styled-components ) from 6.1.8 to 6.1.9.
- [Release notes](https://github.com/styled-components/styled-components/releases )
- [Commits](https://github.com/styled-components/styled-components/compare/v6.1.8...v6.1.9 )
---
updated-dependencies:
- dependency-name: styled-components
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-02 15:36:08 +01:00
dependabot[bot]
b7d6aeda3c
Bump @testing-library/react ( #3595 )
...
Bumps the testing-library group in /extensions/ql-vscode with 1 update: [@testing-library/react](https://github.com/testing-library/react-testing-library ).
Updates `@testing-library/react` from 15.0.5 to 15.0.6
- [Release notes](https://github.com/testing-library/react-testing-library/releases )
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/react-testing-library/compare/v15.0.5...v15.0.6 )
---
updated-dependencies:
- dependency-name: "@testing-library/react"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: testing-library
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-02 15:35:27 +01:00
github-actions[bot]
2da77acd9e
Bump CLI version from v2.17.0 to v2.17.1 for integration tests ( #3577 )
...
Co-authored-by: github-actions[bot] <github-actions@github.com >
2024-05-02 10:00:37 +00:00
Anders Starcke Henriksen
607a8380cc
Merge pull request #3581 from github/dependabot/npm_and_yarn/extensions/ql-vscode/ts-json-schema-generator-2.1.1
...
Bump ts-json-schema-generator from 2.0.1 to 2.1.1 in /extensions/ql-vscode
2024-05-02 09:19:22 +02:00
Koen Vlaswinkel
f698ac321f
Add back ts-node for Gulp
2024-05-01 14:59:02 +02:00
Koen Vlaswinkel
85abd9a1ac
Switch from ts-node to vite-node
...
vite-node seems to have better support for mixed ESM and CJS modules and
makes the scripts work with both kinds of packages without having to
change the project configuration.
2024-05-01 14:50:12 +02:00
Anders Starcke Henriksen
329eba9536
Merge pull request #3592 from github/release-token
...
Update release with new PAT lifetime.
2024-05-01 14:49:03 +02:00
Anders Starcke Henriksen
733a0328d0
Merge pull request #3594 from github/version/bump-to-v1.13.1
...
Bump version to v1.13.1
2024-05-01 14:32:42 +02:00
dependabot[bot]
1c7f92b503
Bump ts-json-schema-generator in /extensions/ql-vscode
...
Bumps [ts-json-schema-generator](https://github.com/vega/ts-json-schema-generator ) from 2.0.1 to 2.1.1.
- [Release notes](https://github.com/vega/ts-json-schema-generator/releases )
- [Changelog](https://github.com/vega/ts-json-schema-generator/blob/v2.1.1/CHANGELOG.md )
- [Commits](https://github.com/vega/ts-json-schema-generator/compare/v2.0.1...v2.1.1 )
---
updated-dependencies:
- dependency-name: ts-json-schema-generator
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-01 12:13:48 +00:00
github-actions[bot]
884ec21e5a
Bump version to v1.13.1
2024-05-01 11:44:41 +00:00
Anders Starcke Henriksen
35c533606f
Merge pull request #3593 from github/v1.13.0
...
v1.13.0
2024-05-01 13:42:53 +02:00
Anders Starcke Henriksen
4adf60a978
v1.13.0
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2024-05-01 10:36:40 +02:00
Koen Vlaswinkel
69775414f0
Merge pull request #3591 from github/koesie10/update-changelog
...
Add Ruby model editor support to CHANGELOG
2024-05-01 09:54:47 +02:00
Anders Starcke Henriksen
10c74d5d8c
Update release with new PAT lifetime.
2024-05-01 09:54:04 +02:00
Koen Vlaswinkel
325f5d6667
Move up changelog entry
2024-05-01 09:42:03 +02:00
Koen Vlaswinkel
e968c226ba
Add Ruby model editor support to CHANGELOG
2024-05-01 09:33:22 +02:00
dependabot[bot]
44429c2513
Bump husky from 8.0.3 to 9.0.11 in /extensions/ql-vscode ( #3590 )
...
Bumps [husky](https://github.com/typicode/husky ) from 8.0.3 to 9.0.11.
- [Release notes](https://github.com/typicode/husky/releases )
- [Commits](https://github.com/typicode/husky/compare/v8.0.3...v9.0.11 )
---
updated-dependencies:
- dependency-name: husky
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-30 09:26:20 -07:00
dependabot[bot]
96881f2bf2
Bump the testing-library group in /extensions/ql-vscode with 2 updates ( #3589 )
...
Bumps the testing-library group in /extensions/ql-vscode with 2 updates: [@testing-library/dom](https://github.com/testing-library/dom-testing-library ) and [@testing-library/react](https://github.com/testing-library/react-testing-library ).
Updates `@testing-library/dom` from 10.0.0 to 10.1.0
- [Release notes](https://github.com/testing-library/dom-testing-library/releases )
- [Changelog](https://github.com/testing-library/dom-testing-library/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/dom-testing-library/compare/v10.0.0...v10.1.0 )
Updates `@testing-library/react` from 15.0.4 to 15.0.5
- [Release notes](https://github.com/testing-library/react-testing-library/releases )
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/react-testing-library/compare/v15.0.4...v15.0.5 )
---
updated-dependencies:
- dependency-name: "@testing-library/dom"
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: testing-library
- dependency-name: "@testing-library/react"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: testing-library
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-30 09:25:56 -07:00
dependabot[bot]
06f4e33719
Bump @storybook/csf in /extensions/ql-vscode in the storybook group ( #3588 )
...
Bumps the storybook group in /extensions/ql-vscode with 1 update: [@storybook/csf](https://github.com/ComponentDriven/csf ).
Updates `@storybook/csf` from 0.1.4 to 0.1.6
- [Release notes](https://github.com/ComponentDriven/csf/releases )
- [Changelog](https://github.com/ComponentDriven/csf/blob/v0.1.6/CHANGELOG.md )
- [Commits](https://github.com/ComponentDriven/csf/compare/v0.1.4...v0.1.6 )
---
updated-dependencies:
- dependency-name: "@storybook/csf"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-30 09:25:14 -07:00
Koen Vlaswinkel
570e410e06
Merge pull request #3587 from github/koesie10/upgrade-e2e-tests
...
Upgrade E2E test dependencies
2024-04-30 17:24:33 +02:00
Koen Vlaswinkel
1d5b4f3fbb
Merge pull request #3586 from github/koesie10/fix-e2e-tests
...
Always use the latest released CodeQL version in E2E tests
2024-04-30 16:30:42 +02:00
Koen Vlaswinkel
0e5b460e67
Upgrade Alpine to 3.19.1
2024-04-30 16:20:19 +02:00
Koen Vlaswinkel
a39f4582e3
Enable Dependabot for E2E docker image
2024-04-30 16:19:13 +02:00
Koen Vlaswinkel
18f12e53c9
Upgrade E2E tests to VS Code v1.88.1
2024-04-30 16:17:51 +02:00
Koen Vlaswinkel
ac8dd9189e
Always use the latest released CodeQL version in E2E tests
2024-04-30 16:11:19 +02:00
Koen Vlaswinkel
7d564b50e7
Merge pull request #3584 from github/koesie10/add-ruby-as-supported-model-editor-language
...
Add Ruby as a fully-supported model editor language
2024-04-30 12:42:52 +02:00
Koen Vlaswinkel
013bf65c0a
Merge pull request #3585 from github/koesie10/fix-modeled-method-fs-test
...
Fix modeled method FS test
2024-04-30 12:42:44 +02:00
Koen Vlaswinkel
bd6862efda
Fix modeled method FS test
2024-04-30 11:53:15 +02:00
Koen Vlaswinkel
64f0115070
Add Ruby as a fully-supported model editor language
2024-04-26 17:00:06 +02:00
dependabot[bot]
596049a8cb
Bump @testing-library/react ( #3580 )
...
Bumps the testing-library group in /extensions/ql-vscode with 1 update: [@testing-library/react](https://github.com/testing-library/react-testing-library ).
Updates `@testing-library/react` from 15.0.2 to 15.0.4
- [Release notes](https://github.com/testing-library/react-testing-library/releases )
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/react-testing-library/compare/v15.0.2...v15.0.4 )
---
updated-dependencies:
- dependency-name: "@testing-library/react"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: testing-library
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-25 15:00:47 +00:00
dependabot[bot]
58a5a43609
Bump the storybook group in /extensions/ql-vscode with 12 updates ( #3579 )
...
Bumps the storybook group in /extensions/ql-vscode with 12 updates:
| Package | From | To |
| --- | --- | --- |
| [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y ) | `8.0.8` | `8.0.9` |
| [@storybook/addon-actions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/actions ) | `8.0.8` | `8.0.9` |
| [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/essentials ) | `8.0.8` | `8.0.9` |
| [@storybook/addon-interactions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/interactions ) | `8.0.8` | `8.0.9` |
| [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/links ) | `8.0.8` | `8.0.9` |
| [@storybook/blocks](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/blocks ) | `8.0.8` | `8.0.9` |
| [@storybook/components](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/components ) | `8.0.8` | `8.0.9` |
| [@storybook/manager-api](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/manager-api ) | `8.0.8` | `8.0.9` |
| [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/react ) | `8.0.8` | `8.0.9` |
| [@storybook/react-vite](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-vite ) | `8.0.8` | `8.0.9` |
| [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/theming ) | `8.0.8` | `8.0.9` |
| [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli ) | `8.0.8` | `8.0.9` |
Updates `@storybook/addon-a11y` from 8.0.8 to 8.0.9
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.9/code/addons/a11y )
Updates `@storybook/addon-actions` from 8.0.8 to 8.0.9
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.9/code/addons/actions )
Updates `@storybook/addon-essentials` from 8.0.8 to 8.0.9
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.9/code/addons/essentials )
Updates `@storybook/addon-interactions` from 8.0.8 to 8.0.9
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.9/code/addons/interactions )
Updates `@storybook/addon-links` from 8.0.8 to 8.0.9
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.9/code/addons/links )
Updates `@storybook/blocks` from 8.0.8 to 8.0.9
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.9/code/ui/blocks )
Updates `@storybook/components` from 8.0.8 to 8.0.9
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.9/code/ui/components )
Updates `@storybook/manager-api` from 8.0.8 to 8.0.9
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.9/code/lib/manager-api )
Updates `@storybook/react` from 8.0.8 to 8.0.9
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.9/code/renderers/react )
Updates `@storybook/react-vite` from 8.0.8 to 8.0.9
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.9/code/frameworks/react-vite )
Updates `@storybook/theming` from 8.0.8 to 8.0.9
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.9/code/lib/theming )
Updates `storybook` from 8.0.8 to 8.0.9
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.9/code/lib/cli )
---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-actions"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-essentials"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-interactions"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-links"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/blocks"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/components"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/manager-api"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/react"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/react-vite"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/theming"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: storybook
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-25 15:46:04 +01:00
dependabot[bot]
67ad9cb6ce
Bump nanoid from 5.0.6 to 5.0.7 in /extensions/ql-vscode ( #3582 )
...
Bumps [nanoid](https://github.com/ai/nanoid ) from 5.0.6 to 5.0.7.
- [Release notes](https://github.com/ai/nanoid/releases )
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md )
- [Commits](https://github.com/ai/nanoid/compare/5.0.6...5.0.7 )
---
updated-dependencies:
- dependency-name: nanoid
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-25 14:59:18 +01:00
Robert
29c36584f8
Merge pull request #3576 from github/robertbrignull/disable-llm-proxima
...
Disable LLM model generation when not using github.com
2024-04-22 16:47:56 +01:00
Robert
e59145372e
Disable LLM model generation when not using github.com
2024-04-22 16:28:52 +01:00
Robert
ad17a4f828
Merge pull request #3570 from github/robertbrignull/disable_top1000
...
Hide system defined lists when enterprise URI is set
2024-04-22 10:12:19 +01:00
dependabot[bot]
f17319a5cf
Bump markdownlint-cli2 from 0.12.1 to 0.13.0 in /extensions/ql-vscode ( #3571 )
...
Bumps [markdownlint-cli2](https://github.com/DavidAnson/markdownlint-cli2 ) from 0.12.1 to 0.13.0.
- [Changelog](https://github.com/DavidAnson/markdownlint-cli2/blob/main/CHANGELOG.md )
- [Commits](https://github.com/DavidAnson/markdownlint-cli2/compare/v0.12.1...v0.13.0 )
---
updated-dependencies:
- dependency-name: markdownlint-cli2
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-18 13:12:06 -07:00
dependabot[bot]
0d52be1dbf
Bump @babel/preset-react from 7.23.3 to 7.24.1 in /extensions/ql-vscode ( #3575 )
...
Bumps [@babel/preset-react](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-react ) from 7.23.3 to 7.24.1.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.24.1/packages/babel-preset-react )
---
updated-dependencies:
- dependency-name: "@babel/preset-react"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-18 13:11:46 -07:00
dependabot[bot]
13a61094c1
Bump @babel/preset-env from 7.24.0 to 7.24.4 in /extensions/ql-vscode ( #3574 )
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.24.0 to 7.24.4.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.24.4/packages/babel-preset-env )
---
updated-dependencies:
- dependency-name: "@babel/preset-env"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-18 19:40:48 +00:00
dependabot[bot]
230cdd024c
Bump @babel/core from 7.24.0 to 7.24.4 in /extensions/ql-vscode ( #3573 )
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.24.0 to 7.24.4.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.24.4/packages/babel-core )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-18 12:26:36 -07:00
dependabot[bot]
29a47305a9
Bump eslint-plugin-react from 7.33.2 to 7.34.1 in /extensions/ql-vscode ( #3572 )
...
Bumps [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react ) from 7.33.2 to 7.34.1.
- [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases )
- [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/v7.34.1/CHANGELOG.md )
- [Commits](https://github.com/jsx-eslint/eslint-plugin-react/compare/v7.33.2...v7.34.1 )
---
updated-dependencies:
- dependency-name: eslint-plugin-react
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-18 12:26:18 -07:00
Robert
26ec371730
move onDidChangeConfiguration to be the last field in VariantAnalysisConfig
2024-04-18 09:59:50 +01:00
Robert
58de4864c0
Pass VariantAnalysisConfig into DbManager to avoid vscode dependency
2024-04-18 09:55:21 +01:00
Robert
17ff592a60
Hide system defined lists when enterprise URI is set
2024-04-17 14:31:14 +01:00
Robert
1c267e4c28
Merge pull request #3569 from github/robertbrignull/ghec_dr_mode
...
Detect when the github-enterprise.uri setting is set
2024-04-17 11:06:26 +01:00
Robert
2f67ccea56
Cover all cases of URIs and feature flags
2024-04-17 10:53:17 +01:00
Robert
b3fdb3a126
Use endsWith instead of regex
2024-04-17 09:37:53 +01:00
Robert
07ba537590
Make config field use camel-case
2024-04-17 09:37:38 +01:00
Robert
8abde36dcb
Detect when the github-enterprise.uri setting is set
2024-04-16 17:18:49 +01:00
dependabot[bot]
27d6a749f8
Bump @floating-ui/react from 0.26.10 to 0.26.12 in /extensions/ql-vscode ( #3567 )
...
Bumps [@floating-ui/react](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/react ) from 0.26.10 to 0.26.12.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Changelog](https://github.com/floating-ui/floating-ui/blob/master/packages/react/CHANGELOG.md )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/react@0.26.12/packages/react )
---
updated-dependencies:
- dependency-name: "@floating-ui/react"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-16 16:39:37 +01:00
dependabot[bot]
e7af631737
Bump @testing-library/react ( #3565 )
...
Bumps the testing-library group in /extensions/ql-vscode with 1 update: [@testing-library/react](https://github.com/testing-library/react-testing-library ).
Updates `@testing-library/react` from 15.0.1 to 15.0.2
- [Release notes](https://github.com/testing-library/react-testing-library/releases )
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/react-testing-library/compare/v15.0.1...v15.0.2 )
---
updated-dependencies:
- dependency-name: "@testing-library/react"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: testing-library
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-16 16:24:37 +01:00
dependabot[bot]
cdd889452a
Bump @storybook/csf in /extensions/ql-vscode in the storybook group ( #3564 )
...
Bumps the storybook group in /extensions/ql-vscode with 1 update: [@storybook/csf](https://github.com/ComponentDriven/csf ).
Updates `@storybook/csf` from 0.1.3 to 0.1.4
- [Release notes](https://github.com/ComponentDriven/csf/releases )
- [Changelog](https://github.com/ComponentDriven/csf/blob/v0.1.4/CHANGELOG.md )
- [Commits](https://github.com/ComponentDriven/csf/compare/v0.1.3...v0.1.4 )
---
updated-dependencies:
- dependency-name: "@storybook/csf"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-16 16:19:11 +01:00
dependabot[bot]
4abaa22f62
Bump ts-json-schema-generator in /extensions/ql-vscode ( #3568 )
...
Bumps [ts-json-schema-generator](https://github.com/vega/ts-json-schema-generator ) from 1.5.0 to 2.0.1.
- [Release notes](https://github.com/vega/ts-json-schema-generator/releases )
- [Changelog](https://github.com/vega/ts-json-schema-generator/blob/v2.0.1/CHANGELOG.md )
- [Commits](https://github.com/vega/ts-json-schema-generator/compare/v1.5.0...v2.0.1 )
---
updated-dependencies:
- dependency-name: ts-json-schema-generator
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-16 16:12:31 +01:00
dependabot[bot]
df322ce17d
Bump applicationinsights from 2.9.4 to 2.9.5 in /extensions/ql-vscode ( #3566 )
...
Bumps [applicationinsights](https://github.com/microsoft/ApplicationInsights-node.js ) from 2.9.4 to 2.9.5.
- [Release notes](https://github.com/microsoft/ApplicationInsights-node.js/releases )
- [Commits](https://github.com/microsoft/ApplicationInsights-node.js/compare/2.9.4...2.9.5 )
---
updated-dependencies:
- dependency-name: applicationinsights
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-16 15:30:48 +01:00
Charis Kyriakou
0df508d1c6
Remove support for CodeQL CLI versions older than 2.14.6 ( #3562 )
2024-04-16 15:27:32 +01:00
Charis Kyriakou
2e7586c39f
Exclude major version updates for the octokit group in dependabot ( #3563 )
...
* Exclude major version updates for the octokit group in dependabot
* Commit unstaged changes 🤦
2024-04-16 14:29:17 +01:00
Charis Kyriakou
f854ab50d5
Move octokit throttling plugin dependency out of dev dependencies ( #3561 )
2024-04-16 11:52:01 +00:00
Andrew Eisenberg
3cc4005500
Merge pull request #3556 from github/dependabot/npm_and_yarn/extensions/ql-vscode/msw-2.2.13
...
Bump msw from 2.0.13 to 2.2.13 in /extensions/ql-vscode
2024-04-16 01:24:44 -07:00
Koen Vlaswinkel
0d4a95d08e
Merge pull request #3552 from github/koesie10/remove-enable-type-models
...
Remove `codeQL.model.showTypeModels` config
2024-04-16 10:16:52 +02:00
Koen Vlaswinkel
d67cf4b9f7
Remove codeQL.model.showTypeModels config
...
This removes the `codeQL.model.showTypeModels` setting. We will now
always show type models in the model editor. This also means that the
"auto-generation mode" needs to change to `models` to ensure that the
type models are actually shown to the user. This is done for Ruby, which
is currently the only language to show type models.
2024-04-15 16:52:27 +02:00
Koen Vlaswinkel
c37bd9969c
Merge pull request #3550 from github/koesie10/separate-file
...
Add auto-model generation mode without separate file
2024-04-15 16:52:13 +02:00
Andrew Eisenberg
1dac41d8ea
Merge pull request #3558 from github/dependabot/npm_and_yarn/extensions/ql-vscode/testing-library-0922f3acd1
...
Bump the testing-library group in /extensions/ql-vscode with 2 updates
2024-04-11 11:14:36 -07:00
dependabot[bot]
48a03bd383
Bump the testing-library group in /extensions/ql-vscode with 2 updates
...
Bumps the testing-library group in /extensions/ql-vscode with 2 updates: [@testing-library/dom](https://github.com/testing-library/dom-testing-library ) and [@testing-library/react](https://github.com/testing-library/react-testing-library ).
Updates `@testing-library/dom` from 9.3.4 to 10.0.0
- [Release notes](https://github.com/testing-library/dom-testing-library/releases )
- [Changelog](https://github.com/testing-library/dom-testing-library/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/dom-testing-library/compare/v9.3.4...v10.0.0 )
Updates `@testing-library/react` from 14.2.2 to 15.0.1
- [Release notes](https://github.com/testing-library/react-testing-library/releases )
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/react-testing-library/compare/v14.2.2...v15.0.1 )
---
updated-dependencies:
- dependency-name: "@testing-library/dom"
dependency-type: direct:development
update-type: version-update:semver-major
dependency-group: testing-library
- dependency-name: "@testing-library/react"
dependency-type: direct:development
update-type: version-update:semver-major
dependency-group: testing-library
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-11 17:31:55 +00:00
dependabot[bot]
b6897e4faf
Bump the storybook group in /extensions/ql-vscode with 12 updates ( #3557 )
...
Bumps the storybook group in /extensions/ql-vscode with 12 updates:
| Package | From | To |
| --- | --- | --- |
| [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y ) | `8.0.5` | `8.0.8` |
| [@storybook/addon-actions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/actions ) | `8.0.5` | `8.0.8` |
| [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/essentials ) | `8.0.5` | `8.0.8` |
| [@storybook/addon-interactions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/interactions ) | `8.0.5` | `8.0.8` |
| [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/links ) | `8.0.5` | `8.0.8` |
| [@storybook/blocks](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/blocks ) | `8.0.5` | `8.0.8` |
| [@storybook/components](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/components ) | `8.0.5` | `8.0.8` |
| [@storybook/manager-api](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/manager-api ) | `8.0.5` | `8.0.8` |
| [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/react ) | `8.0.5` | `8.0.8` |
| [@storybook/react-vite](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-vite ) | `8.0.5` | `8.0.8` |
| [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/theming ) | `8.0.5` | `8.0.8` |
| [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli ) | `8.0.5` | `8.0.8` |
Updates `@storybook/addon-a11y` from 8.0.5 to 8.0.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.8/code/addons/a11y )
Updates `@storybook/addon-actions` from 8.0.5 to 8.0.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.8/code/addons/actions )
Updates `@storybook/addon-essentials` from 8.0.5 to 8.0.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.8/code/addons/essentials )
Updates `@storybook/addon-interactions` from 8.0.5 to 8.0.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.8/code/addons/interactions )
Updates `@storybook/addon-links` from 8.0.5 to 8.0.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.8/code/addons/links )
Updates `@storybook/blocks` from 8.0.5 to 8.0.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.8/code/ui/blocks )
Updates `@storybook/components` from 8.0.5 to 8.0.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.8/code/ui/components )
Updates `@storybook/manager-api` from 8.0.5 to 8.0.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.8/code/lib/manager-api )
Updates `@storybook/react` from 8.0.5 to 8.0.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.8/code/renderers/react )
Updates `@storybook/react-vite` from 8.0.5 to 8.0.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.8/code/frameworks/react-vite )
Updates `@storybook/theming` from 8.0.5 to 8.0.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.8/code/lib/theming )
Updates `storybook` from 8.0.5 to 8.0.8
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.8/code/lib/cli )
---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-actions"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-essentials"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-interactions"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-links"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/blocks"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/components"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/manager-api"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/react"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/react-vite"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/theming"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: storybook
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-11 10:30:00 -07:00
dependabot[bot]
d20a1eb61b
Bump ts-jest from 29.1.1 to 29.1.2 in /extensions/ql-vscode ( #3555 )
...
Bumps [ts-jest](https://github.com/kulshekhar/ts-jest ) from 29.1.1 to 29.1.2.
- [Release notes](https://github.com/kulshekhar/ts-jest/releases )
- [Changelog](https://github.com/kulshekhar/ts-jest/blob/main/CHANGELOG.md )
- [Commits](https://github.com/kulshekhar/ts-jest/compare/v29.1.1...v29.1.2 )
---
updated-dependencies:
- dependency-name: ts-jest
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-11 10:05:22 -07:00
dependabot[bot]
8ef3ae0ff5
Bump msw from 2.0.13 to 2.2.13 in /extensions/ql-vscode
...
Bumps [msw](https://github.com/mswjs/msw ) from 2.0.13 to 2.2.13.
- [Release notes](https://github.com/mswjs/msw/releases )
- [Changelog](https://github.com/mswjs/msw/blob/main/CHANGELOG.md )
- [Commits](https://github.com/mswjs/msw/compare/v2.0.13...v2.2.13 )
---
updated-dependencies:
- dependency-name: msw
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-11 13:40:56 +00:00
Koen Vlaswinkel
c7a048b0dc
Merge pull request #3548 from github/koesie10/remove-access-path-suggestions-ff
...
Remove `codeQL.model.enableAccessPathSuggestions` config
2024-04-11 14:29:50 +02:00
Nora
9026076635
Merge pull request #3547 from github/version/bump-to-v1.12.6
...
Bump version to v1.12.6
2024-04-10 17:16:19 +02:00
Shati Patel
135dc7084a
Remove rogue semmle link ( #3549 )
2024-04-10 15:05:20 +00:00
Koen Vlaswinkel
8c784d8391
Merge pull request #3543 from github/koesie10/pack-name-config
...
Add `codeQL.model.packName` setting
2024-04-10 17:03:36 +02:00
Koen Vlaswinkel
fed30b6fed
Add auto-model generation mode without separate file
2024-04-10 16:46:45 +02:00
Koen Vlaswinkel
232d4c3f41
Remove unnecessary access path progress for unsupported languages
2024-04-10 16:05:56 +02:00
Koen Vlaswinkel
acb6b8b490
Remove enableAccessPathSuggestions config
...
Access path suggestions will now be enabled for all languages which
support it (which is currently only Ruby).
2024-04-10 15:46:29 +02:00
Koen Vlaswinkel
3f4ed48787
Trim whitespace and slashes in pack names
2024-04-10 15:08:35 +02:00
github-actions[bot]
e1d9aa813d
Bump version to v1.12.6
2024-04-09 12:29:43 +00:00
Nora
8a3a6d7e7e
Merge pull request #3546 from github/v1.12.5
...
v1.12.5
2024-04-09 14:27:59 +02:00
Nora
5b89b9608f
Update changelog
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2024-04-09 09:08:47 +00:00
Nora
999c73d05d
Update version number in changelog
2024-04-09 08:54:07 +00:00
Charis Kyriakou
070df13947
Rename vscode-app -> extension-app file to match convention ( #3545 )
2024-04-08 16:11:22 +01:00
Koen Vlaswinkel
0c5b39945c
Merge pull request #3544 from github/koesie10/python-parsing-unit-tests
...
Add unit tests for Python argument options
2024-04-08 16:36:40 +02:00
Koen Vlaswinkel
8e231d7b1d
Add unit tests for Python argument options
2024-04-08 14:49:09 +02:00
Koen Vlaswinkel
bf9bfb13b7
Add codeQL.model.packName setting
2024-04-08 14:42:47 +02:00
Koen Vlaswinkel
4dc126d56d
Merge pull request #3539 from github/koesie10/pack-location-config
...
Add `codeQL.model.packLocation` setting
2024-04-08 14:11:46 +02:00
Koen Vlaswinkel
9e729ba054
Merge pull request #3540 from github/koesie10/python-model-editor-args
...
Improve support for Python arguments
2024-04-08 13:59:45 +02:00
Koen Vlaswinkel
6146d7d78a
Fix numbering in comment
2024-04-08 13:58:13 +02:00
Charis Kyriakou
6d8de1b3b8
Remove mocking of modeling events ( #3542 )
2024-04-08 11:19:02 +01:00
Nora
24e08f768c
Merge pull request #3534 from github/dependabot/npm_and_yarn/extensions/ql-vscode/floating-ui/react-0.26.10
...
Bump @floating-ui/react from 0.26.9 to 0.26.10 in /extensions/ql-vscode
2024-04-08 10:35:52 +02:00
Nora
62e051b3d1
Merge pull request #3535 from github/dependabot/npm_and_yarn/extensions/ql-vscode/github/markdownlint-github-0.6.2
...
Bump @github/markdownlint-github from 0.6.0 to 0.6.2 in /extensions/ql-vscode
2024-04-08 10:16:20 +02:00
Koen Vlaswinkel
b6931dd79a
Merge pull request #3541 from github/koesie10/upgrade-ts-eslint
...
Upgrade typescript-eslint to v7
2024-04-05 16:49:52 +02:00
Koen Vlaswinkel
70009cdc32
Upgrade typescript-eslint to v7
2024-04-05 16:21:16 +02:00
Koen Vlaswinkel
b3276f5cf5
Merge pull request #3538 from github/github-action/bump-node-version
...
Bump Node version to v18.18.2
2024-04-05 16:15:54 +02:00
Koen Vlaswinkel
1e3cb0772e
Improve support for Python arguments
2024-04-05 15:39:44 +02:00
Koen Vlaswinkel
5fbd912abd
Add codeQL.model.packLocation setting
...
This adds the `codeQL.model.packLocation` setting, which allows users to
specify the location of the CodeQL extension pack. This setting replaces
the `codeQL.model.extensionsDirectory` setting, which has been removed.
The pack location supports variable substitutions and supports both
absolute and relative paths. The default value is
`.github/codeql/extensions/${name}-${language}` which matches the
previous defaults.
2024-04-05 15:04:29 +02:00
github-actions[bot]
03c8748981
Bump Node version to v18.18.2
2024-04-05 12:25:06 +00:00
Koen Vlaswinkel
351bc648ef
Merge pull request #3530 from github/koesie10/config-template
...
Add helper for substituting config variables
2024-04-05 11:15:33 +02:00
dependabot[bot]
8ccca1381a
Bump eslint-plugin-jest-dom from 5.1.0 to 5.2.0 in /extensions/ql-vscode ( #3536 )
...
Bumps [eslint-plugin-jest-dom](https://github.com/testing-library/eslint-plugin-jest-dom ) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/testing-library/eslint-plugin-jest-dom/releases )
- [Commits](https://github.com/testing-library/eslint-plugin-jest-dom/compare/v5.1.0...v5.2.0 )
---
updated-dependencies:
- dependency-name: eslint-plugin-jest-dom
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-04 13:28:39 -07:00
dependabot[bot]
85953ec9c3
Bump d3 from 7.8.5 to 7.9.0 in /extensions/ql-vscode ( #3533 )
...
Bumps [d3](https://github.com/d3/d3 ) from 7.8.5 to 7.9.0.
- [Release notes](https://github.com/d3/d3/releases )
- [Changelog](https://github.com/d3/d3/blob/main/CHANGES.md )
- [Commits](https://github.com/d3/d3/compare/v7.8.5...v7.9.0 )
---
updated-dependencies:
- dependency-name: d3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-04 11:07:16 -07:00
github-actions[bot]
4a303fa48d
Bump CLI version from v2.16.6 to v2.17.0 for integration tests ( #3537 )
...
Co-authored-by: github-actions[bot] <github-actions@github.com >
2024-04-04 15:53:15 +00:00
dependabot[bot]
48e66cbe25
Bump @github/markdownlint-github in /extensions/ql-vscode
...
Bumps [@github/markdownlint-github](https://github.com/github/markdownlint-github ) from 0.6.0 to 0.6.2.
- [Release notes](https://github.com/github/markdownlint-github/releases )
- [Commits](https://github.com/github/markdownlint-github/compare/0.6.0...v0.6.2 )
---
updated-dependencies:
- dependency-name: "@github/markdownlint-github"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-04 13:56:17 +00:00
dependabot[bot]
8787fcdd96
Bump @floating-ui/react from 0.26.9 to 0.26.10 in /extensions/ql-vscode
...
Bumps [@floating-ui/react](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/react ) from 0.26.9 to 0.26.10.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Changelog](https://github.com/floating-ui/floating-ui/blob/master/packages/react/CHANGELOG.md )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/react@0.26.10/packages/react )
---
updated-dependencies:
- dependency-name: "@floating-ui/react"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-04 13:56:05 +00:00
Nora
20cc5ad988
Merge pull request #3531 from github/dependabot/npm_and_yarn/extensions/ql-vscode/vite-5.2.6
...
Bump vite from 5.2.0 to 5.2.6 in /extensions/ql-vscode
2024-04-04 10:34:30 +02:00
dependabot[bot]
ecae6bdd99
Bump vite from 5.2.0 to 5.2.6 in /extensions/ql-vscode
...
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite ) from 5.2.0 to 5.2.6.
- [Release notes](https://github.com/vitejs/vite/releases )
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md )
- [Commits](https://github.com/vitejs/vite/commits/v5.2.6/packages/vite )
---
updated-dependencies:
- dependency-name: vite
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-03 16:47:45 +00:00
Andrew Eisenberg
00c0e70626
Merge pull request #3527 from aeisenberg/aeisenberg/fix-qlpack-schema
...
Fix the qlpack json schema
2024-04-03 09:46:11 -07:00
Koen Vlaswinkel
8cb2b34992
Add helper for substituting config variables
2024-04-03 14:42:31 +02:00
Robert
7da3740828
Merge pull request #3517 from github/robertbrignull/fix-token-alerts
...
Mark progress bars as cancellable where it appears we are respecting the token
2024-04-03 11:30:30 +01:00
Andrew Eisenberg
44c3c29857
Update changelog
2024-04-03 03:21:25 +00:00
Andrew Eisenberg
e6ebcf4245
Fix the qlpack json schema
...
This schema was incorrectly tagging `defaultSuite` properties that
aren't arrays as errors.
I think there are more, similar errors in this schema, but I only fixed
this one so that I can get `github/semmle-code` working with test
discovery.
2024-04-02 20:21:21 -07:00
Robert
4e43a07fb5
Merge branch 'main' into robertbrignull/fix-token-alerts
2024-04-02 17:27:53 +01:00
Charis Kyriakou
3508dc6d8c
Tidy up some functions in the model evaluator ( #3529 )
...
* Rename model evaluator's updateVariantAnalysis -> setVariantAnalysis
* Merge updateRepoResults and updateReposResults into single setReposResults function
2024-04-02 12:32:50 +01:00
Koen Vlaswinkel
ff6f6cdf8a
Merge pull request #3515 from github/koesie10/tee-logger-file-handle
...
Use file handle in TeeLogger
2024-04-02 10:02:41 +02:00
Robert
a5239fbede
Merge pull request #3458 from github/robertbrignull/database-prompting
...
Refactor database-fetcher.ts into a class and simplify
2024-03-28 18:05:54 +00:00
Robert
7d259a9322
Fix dodgy imports
2024-03-28 17:51:22 +00:00
Koen Vlaswinkel
6f7b7cf84f
Merge pull request #3525 from github/dependabot/npm_and_yarn/extensions/ql-vscode/types/semver-7.5.8
...
Bump @types/semver from 7.5.6 to 7.5.8 in /extensions/ql-vscode
2024-03-28 14:57:58 +01:00
Koen Vlaswinkel
c6865de312
Merge pull request #3526 from github/dependabot/npm_and_yarn/extensions/ql-vscode/express-4.19.2
...
Bump express from 4.18.2 to 4.19.2 in /extensions/ql-vscode
2024-03-28 14:57:18 +01:00
dependabot[bot]
133d5899af
Bump @types/semver from 7.5.6 to 7.5.8 in /extensions/ql-vscode
...
Bumps [@types/semver](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/semver ) from 7.5.6 to 7.5.8.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/semver )
---
updated-dependencies:
- dependency-name: "@types/semver"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-28 13:43:46 +00:00
dependabot[bot]
8d7d469803
Bump express from 4.18.2 to 4.19.2 in /extensions/ql-vscode
...
Bumps [express](https://github.com/expressjs/express ) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases )
- [Changelog](https://github.com/expressjs/express/blob/master/History.md )
- [Commits](https://github.com/expressjs/express/compare/4.18.2...4.19.2 )
---
updated-dependencies:
- dependency-name: express
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-28 13:43:32 +00:00
Koen Vlaswinkel
7575beac6b
Merge pull request #3524 from github/dependabot/npm_and_yarn/extensions/ql-vscode/lint-staged-15.2.2
...
Bump lint-staged from 15.2.0 to 15.2.2 in /extensions/ql-vscode
2024-03-28 14:43:09 +01:00
Koen Vlaswinkel
9e5d0ae7c2
Merge pull request #3522 from github/dependabot/npm_and_yarn/extensions/ql-vscode/storybook-5df8c90cc2
...
Bump the storybook group in /extensions/ql-vscode with 12 updates
2024-03-28 14:42:31 +01:00
dependabot[bot]
ae6b9df9e7
Bump lint-staged from 15.2.0 to 15.2.2 in /extensions/ql-vscode
...
Bumps [lint-staged](https://github.com/okonet/lint-staged ) from 15.2.0 to 15.2.2.
- [Release notes](https://github.com/okonet/lint-staged/releases )
- [Changelog](https://github.com/lint-staged/lint-staged/blob/master/CHANGELOG.md )
- [Commits](https://github.com/okonet/lint-staged/compare/v15.2.0...v15.2.2 )
---
updated-dependencies:
- dependency-name: lint-staged
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-28 13:29:17 +00:00
dependabot[bot]
5ff353962f
Bump the storybook group in /extensions/ql-vscode with 12 updates
...
Bumps the storybook group in /extensions/ql-vscode with 12 updates:
| Package | From | To |
| --- | --- | --- |
| [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y ) | `8.0.2` | `8.0.5` |
| [@storybook/addon-actions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/actions ) | `8.0.2` | `8.0.5` |
| [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/essentials ) | `8.0.2` | `8.0.5` |
| [@storybook/addon-interactions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/interactions ) | `8.0.2` | `8.0.5` |
| [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/links ) | `8.0.2` | `8.0.5` |
| [@storybook/blocks](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/blocks ) | `8.0.2` | `8.0.5` |
| [@storybook/components](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/components ) | `8.0.2` | `8.0.5` |
| [@storybook/manager-api](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/manager-api ) | `8.0.2` | `8.0.5` |
| [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/react ) | `8.0.2` | `8.0.5` |
| [@storybook/react-vite](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-vite ) | `8.0.2` | `8.0.5` |
| [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/theming ) | `8.0.2` | `8.0.5` |
| [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli ) | `8.0.2` | `8.0.5` |
Updates `@storybook/addon-a11y` from 8.0.2 to 8.0.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.5/code/addons/a11y )
Updates `@storybook/addon-actions` from 8.0.2 to 8.0.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.5/code/addons/actions )
Updates `@storybook/addon-essentials` from 8.0.2 to 8.0.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.5/code/addons/essentials )
Updates `@storybook/addon-interactions` from 8.0.2 to 8.0.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.5/code/addons/interactions )
Updates `@storybook/addon-links` from 8.0.2 to 8.0.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.5/code/addons/links )
Updates `@storybook/blocks` from 8.0.2 to 8.0.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.5/code/ui/blocks )
Updates `@storybook/components` from 8.0.2 to 8.0.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.5/code/ui/components )
Updates `@storybook/manager-api` from 8.0.2 to 8.0.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.5/code/lib/manager-api )
Updates `@storybook/react` from 8.0.2 to 8.0.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.5/code/renderers/react )
Updates `@storybook/react-vite` from 8.0.2 to 8.0.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.5/code/frameworks/react-vite )
Updates `@storybook/theming` from 8.0.2 to 8.0.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.5/code/lib/theming )
Updates `storybook` from 8.0.2 to 8.0.5
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.5/code/lib/cli )
---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-actions"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-essentials"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-interactions"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/addon-links"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/blocks"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/components"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/manager-api"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/react"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/react-vite"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: "@storybook/theming"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
- dependency-name: storybook
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-28 13:28:32 +00:00
Robert
3cae3ccc3c
Merge branch 'main' into robertbrignull/database-prompting
2024-03-28 13:12:00 +00:00
Shati Patel
7a41d9c605
Add unit test for createModeledMethodKey ( #3521 )
2024-03-28 11:32:34 +00:00
Robert
d3476259b3
Unexport ProgressTask
2024-03-28 11:07:57 +00:00
Robert
28bf345ea8
Make trim cache not cancellable
2024-03-28 10:58:42 +00:00
Robert
e23d4a9d9f
Make restarting the query server not cancellable, because in practice it wasn't
2024-03-28 10:51:00 +00:00
Robert
47a5993333
Make clearCacheInDatabase not take a cancellation token
2024-03-28 10:45:17 +00:00
Shati Patel
45e20f405b
Link from alerts indicator to model alerts view ( #3520 )
2024-03-28 10:31:29 +00:00
Shati Patel
fcf74b337f
Refactor: extract function for canonicalising modeled methods ( #3518 )
2024-03-27 14:40:57 +00:00
Shati Patel
c84fa538ba
Fire an event when clicking the "model alerts indicator" button ( #3516 )
2024-03-27 12:47:22 +00:00
Shati Patel
317d3b3c0e
Fix "View" link in model alerts view ( #3519 )
2024-03-27 12:16:09 +00:00
Koen Vlaswinkel
e52a08db4d
Safely close file handle in all cases
2024-03-27 10:46:56 +01:00
Koen Vlaswinkel
139c4555d9
Use Disposable type instead of isDisposable function
2024-03-27 10:43:31 +01:00
Shati Patel
a502e52d37
Add "view" button in model alerts view ( #3514 )
2024-03-26 17:51:37 +00:00
Robert
6b0f7e86fa
Mark progress bars as cancellable where it appears we are respecting the token
2024-03-26 17:05:22 +00:00
Andrew Eisenberg
5d45a114be
Merge pull request #3510 from github/aeisenberg/flush-archive-files
...
Flush archive file systems when removed
2024-03-26 08:11:36 -07:00
Koen Vlaswinkel
b53b33e3b6
Use file handle in TeeLogger
...
This switches the `TeeLogger` from using the `appendFile` function to
manually opening and closing a file handle and calling `appendFile` on
the file handle. This results in a more efficient implementation as the
file handle is only opened once and closed once, instead of being
opened and closed for every log message. This should result in less
"too many open files" errors.
2024-03-26 15:58:44 +01:00
Shati Patel
ccd53133a9
Use wider type for "reveal in model editor" ( #3512 )
2024-03-26 13:54:42 +00:00
Koen Vlaswinkel
38e862c1e0
Merge pull request #3513 from github/github-action/bump-cli
...
Bump CLI Version to v2.16.6 for integration tests
2024-03-26 14:12:44 +01:00
Koen Vlaswinkel
8de85453ec
Merge pull request #3511 from github/koesie10/update-kinds
...
Update supported sink and source kinds in the model editor
2024-03-26 13:54:16 +01:00
github-actions[bot]
6d535ab0ad
Bump CLI version from v2.16.5 to v2.16.6 for integration tests
2024-03-26 12:24:52 +00:00
Koen Vlaswinkel
61fa841784
Update CHANGELOG
2024-03-26 12:20:45 +01:00
Koen Vlaswinkel
b3c83d175a
Update supported sink and source kinds
2024-03-26 12:09:51 +01:00
Koen Vlaswinkel
bd57005832
Split Java and C# model editor languages
2024-03-26 11:55:20 +01:00
Andrew Eisenberg
e939750822
Flush archive file systems when removed
...
This change will remove a file system archive from the cache when the associated folder is removed from the workspace.
This avoids the following bug:
1. Import a database and add its source folder
2. Remove the database (source folder is removed as well automatically).
3. Change the source code and recreate the database
4. Reimport the database and source folder
5. BUG: You see the original source folder, not the new source folder
2024-03-25 16:29:02 -07:00
Charis Kyriakou
21c33b762c
Added filtering and sorting in the model alerts view ( #3509 )
2024-03-25 17:18:09 +00:00
Charis Kyriakou
8b6a9352f6
Update model alert processing to track repo results ( #3508 )
2024-03-25 12:15:16 +00:00
Charis Kyriakou
dea68e928a
Extract re-usable SearchBox component ( #3507 )
2024-03-25 10:34:23 +00:00
Charis Kyriakou
a6b3d38939
Re-use setRepoResults instead of having a setReposResult message ( #3506 )
2024-03-22 16:01:02 +00:00
Koen Vlaswinkel
1739af4013
Merge pull request #3505 from github/koesie10/fix-python-model-editor
...
Fix detection of Python instance methods
2024-03-22 15:39:58 +01:00
Charis Kyriakou
cbc6b73759
Wire up processing model evaluation run results and showing alerts ( #3503 )
2024-03-22 14:33:36 +00:00
Koen Vlaswinkel
5c43018692
Merge pull request #3504 from github/koesie10/downgrade-typescript-eslint
...
Downgrade `@typescript-eslint/eslint-plugin` to v6
2024-03-22 13:10:03 +01:00
Koen Vlaswinkel
895673188f
Fix detection of Python instance methods
2024-03-22 13:09:21 +01:00
Koen Vlaswinkel
38327c7b7f
Downgrade @typescript-eslint/eslint-plugin to v6
...
Version 7 of `@typescript-eslint` is not compatible with Node 18.17 and
requires Node 18.18+ or Node 20. The latest minor/patch version of v7
started enforcing this requirement, but this was already part of the
breaking changes for v7.
2024-03-22 12:21:32 +01:00
Koen Vlaswinkel
161fe3d5a7
Merge pull request #3502 from github/dependabot/npm_and_yarn/extensions/ql-vscode/vscode/debugprotocol-1.65.0
...
Bump @vscode/debugprotocol from 1.64.0 to 1.65.0 in /extensions/ql-vscode
2024-03-21 14:48:18 +01:00
Koen Vlaswinkel
b99caf7bc1
Merge pull request #3499 from github/dependabot/npm_and_yarn/extensions/ql-vscode/storybook-e497c5f385
...
Bump the storybook group in /extensions/ql-vscode with 1 update
2024-03-21 14:47:21 +01:00
Koen Vlaswinkel
bd7d8ddaf0
Merge pull request #3501 from github/dependabot/npm_and_yarn/extensions/ql-vscode/typescript-eslint-09a1cc5d51
...
Bump the typescript-eslint group in /extensions/ql-vscode with 1 update
2024-03-21 14:47:05 +01:00
Koen Vlaswinkel
5c0ecd4041
Merge pull request #3500 from github/dependabot/npm_and_yarn/extensions/ql-vscode/testing-library-79d2cbd4c7
...
Bump the testing-library group in /extensions/ql-vscode with 1 update
2024-03-21 14:46:43 +01:00
dependabot[bot]
bfdb04bf69
Bump @vscode/debugprotocol in /extensions/ql-vscode
...
Bumps [@vscode/debugprotocol](https://github.com/microsoft/vscode-debugadapter-node ) from 1.64.0 to 1.65.0.
- [Commits](https://github.com/microsoft/vscode-debugadapter-node/compare/v1.64.0...v1.65.0 )
---
updated-dependencies:
- dependency-name: "@vscode/debugprotocol"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-21 13:33:52 +00:00
dependabot[bot]
c8f9381af2
Bump the typescript-eslint group in /extensions/ql-vscode with 1 update
...
Bumps the typescript-eslint group in /extensions/ql-vscode with 1 update: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin ).
Updates `@typescript-eslint/eslint-plugin` from 7.2.0 to 7.3.1
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases )
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md )
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.3.1/packages/eslint-plugin )
---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: typescript-eslint
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-21 13:33:38 +00:00
dependabot[bot]
189a460621
Bump the testing-library group in /extensions/ql-vscode with 1 update
...
Bumps the testing-library group in /extensions/ql-vscode with 1 update: [@testing-library/react](https://github.com/testing-library/react-testing-library ).
Updates `@testing-library/react` from 14.2.1 to 14.2.2
- [Release notes](https://github.com/testing-library/react-testing-library/releases )
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/react-testing-library/compare/v14.2.1...v14.2.2 )
---
updated-dependencies:
- dependency-name: "@testing-library/react"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: testing-library
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-21 13:33:15 +00:00
dependabot[bot]
79967b8aed
Bump the storybook group in /extensions/ql-vscode with 1 update
...
Bumps the storybook group in /extensions/ql-vscode with 1 update: [@storybook/csf](https://github.com/ComponentDriven/csf ).
Updates `@storybook/csf` from 0.1.2 to 0.1.3
- [Release notes](https://github.com/ComponentDriven/csf/releases )
- [Changelog](https://github.com/ComponentDriven/csf/blob/v0.1.3/CHANGELOG.md )
- [Commits](https://github.com/ComponentDriven/csf/compare/v0.1.2...v0.1.3 )
---
updated-dependencies:
- dependency-name: "@storybook/csf"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: storybook
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-21 13:32:57 +00:00
Arthur Baars
cdacde3121
Merge pull request #3498 from github/github-action/bump-cli
...
Bump CLI Version to v2.16.5 for integration tests
2024-03-21 14:29:09 +01:00
github-actions[bot]
219840200c
Bump CLI version from v2.16.4 to v2.16.5 for integration tests
2024-03-21 12:36:34 +00:00
Charis Kyriakou
175907d39c
Add React components for showing model alert results ( #3495 )
2024-03-20 15:00:33 +00:00
Charis Kyriakou
a8a63a4633
Remove repoStates state tracking from model evaluation ( #3496 )
2024-03-20 14:59:58 +00:00
Shati Patel
83b0614162
Fix code scanning alert about duplicate command usage ( #3497 )
2024-03-20 14:37:45 +00:00
Koen Vlaswinkel
9e1ca91676
Merge pull request #3480 from github/dependabot/npm_and_yarn/extensions/ql-vscode/storybook-ea1bb043e9
...
Bump the storybook group in /extensions/ql-vscode with 11 updates
2024-03-20 14:50:38 +01:00
Charis Kyriakou
6c3b0b5bb1
Move AnalysisAlert mock creation to a factory module ( #3493 )
2024-03-20 12:03:06 +00:00
Robert
e7d2a59756
Merge pull request #3478 from github/robertbrignull/token-query
...
Simplify query now we've deleted withInheritedProgress
2024-03-20 11:38:42 +00:00
Koen Vlaswinkel
8c3d3b62f5
Move @storybook/icons to devDependencies
2024-03-20 12:28:47 +01:00
Koen Vlaswinkel
c110fd3e0b
Switch from Webpack to Vite for Storybook
...
This simplifies the setup and makes it more similar to the "real"
extension setup since it also uses ESBuild (which is also used by Vite).
2024-03-20 12:26:59 +01:00
Koen Vlaswinkel
47cdd109a4
Merge pull request #3494 from github/version/bump-to-v1.12.5
...
Bump version to v1.12.5
2024-03-20 12:13:49 +01:00
Koen Vlaswinkel
c553b1cb1d
Run storybook migrate mdx-to-csf
2024-03-20 12:08:36 +01:00
Koen Vlaswinkel
ee4b13c9e9
Fix deprecation warning
2024-03-20 12:06:08 +01:00
github-actions[bot]
1982ad45b8
Bump version to v1.12.5
2024-03-20 10:54:17 +00:00
Koen Vlaswinkel
fb77d628f1
Merge pull request #3492 from github/v1.12.4
...
v1.12.4
2024-03-20 11:52:56 +01:00
Shati Patel
36236680a4
Add model alerts stats to the view ( #3481 )
2024-03-20 10:14:39 +00:00
Koen Vlaswinkel
876af669cb
v1.12.4
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2024-03-20 10:28:24 +01:00
Charis Kyriakou
3519139e68
Update MethodName component to receive specific props ( #3491 )
2024-03-20 09:03:13 +00:00
Charis Kyriakou
724370fb40
Fix ModelAlerts view stories ( #3490 )
2024-03-19 16:07:39 +00:00
Andrew Eisenberg
4deae2f79d
Merge pull request #3486 from github/aeisenberg/ignore-missing-database
...
Three minor improvements to `testproj` import
2024-03-18 12:47:43 -07:00
Charis Kyriakou
3f817b3c0f
Don't show notification after local query cancellation ( #3489 )
...
* Don't show notification after local query cancellation
* Update CHANGELOG
2024-03-18 15:57:21 +00:00
Charis Kyriakou
2d1c2349f8
Add 'stop evaluation' action to Model Alerts view ( #3487 )
2024-03-18 15:41:33 +00:00
Charis Kyriakou
46efb7c971
Center align model evaluation run link ( #3488 )
2024-03-18 13:56:51 +00:00
Charis Kyriakou
79d4e8cb78
Wire up variant analysis updates to Model Alerts view ( #3485 )
2024-03-18 11:35:45 +00:00
Andrew Eisenberg
31cfaebb59
Ensure database sources are zipped on re-import
2024-03-17 11:51:58 -07:00
Andrew Eisenberg
fe957db17a
When importing from a directory, check for testproj
...
Use the testproj style import when using the folder icon to import a
database. This means that if the database directory ends with `testproj`
copy the database into workspace storage and make it available for
re-importing when the origin database changes.
2024-03-17 11:27:35 -07:00
Andrew Eisenberg
d57255152c
Safely check for out of date databases
...
When checking to re-import test databases, if the target database is
missing or otherwise unavailable, avoid the check and just continue.
This avoids a bug where a user would delete a test database and there
would be an error when trying to run a query.
2024-03-17 11:25:05 -07:00
Charis Kyriakou
752ec04400
Added error handling on webview message processing ( #3470 )
2024-03-15 12:27:26 +00:00
dependabot[bot]
ec31b97de8
Bump @types/jest from 29.5.11 to 29.5.12 in /extensions/ql-vscode ( #3483 )
...
Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest ) from 29.5.11 to 29.5.12.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest )
---
updated-dependencies:
- dependency-name: "@types/jest"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-14 10:45:42 -07:00
dependabot[bot]
c447548db3
Bump the typescript-eslint group in /extensions/ql-vscode with 1 update ( #3482 )
...
Bumps the typescript-eslint group in /extensions/ql-vscode with 1 update: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin ).
Updates `@typescript-eslint/eslint-plugin` from 6.19.0 to 7.2.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases )
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md )
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.2.0/packages/eslint-plugin )
---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
dependency-type: direct:development
update-type: version-update:semver-major
dependency-group: typescript-eslint
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-14 10:45:11 -07:00
dependabot[bot]
f5c3502202
Bump @babel/preset-env from 7.23.9 to 7.24.0 in /extensions/ql-vscode ( #3475 )
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.23.9 to 7.24.0.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.24.0/packages/babel-preset-env )
---
updated-dependencies:
- dependency-name: "@babel/preset-env"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-14 10:43:59 -07:00
Charis Kyriakou
5427c169b9
Show model packs in Model Alerts view ( #3484 )
2024-03-14 17:11:14 +00:00
dependabot[bot]
de2fc2966d
Bump the storybook group in /extensions/ql-vscode with 11 updates
...
Bumps the storybook group in /extensions/ql-vscode with 11 updates:
| Package | From | To |
| --- | --- | --- |
| [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y ) | `7.6.15` | `8.0.0` |
| [@storybook/addon-actions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/actions ) | `7.6.4` | `8.0.0` |
| [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/essentials ) | `7.6.4` | `8.0.0` |
| [@storybook/addon-interactions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/interactions ) | `7.6.4` | `8.0.0` |
| [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/links ) | `7.6.4` | `8.0.0` |
| [@storybook/components](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/components ) | `7.6.17` | `8.0.0` |
| [@storybook/manager-api](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/manager-api ) | `7.6.7` | `8.0.0` |
| [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/react ) | `7.6.12` | `8.0.0` |
| [@storybook/react-webpack5](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-webpack5 ) | `7.6.12` | `8.0.0` |
| [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/theming ) | `7.6.17` | `8.0.0` |
| [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli ) | `7.6.15` | `8.0.0` |
Updates `@storybook/addon-a11y` from 7.6.15 to 8.0.0
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.0/code/addons/a11y )
Updates `@storybook/addon-actions` from 7.6.4 to 8.0.0
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.0/code/addons/actions )
Updates `@storybook/addon-essentials` from 7.6.4 to 8.0.0
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.0/code/addons/essentials )
Updates `@storybook/addon-interactions` from 7.6.4 to 8.0.0
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.0/code/addons/interactions )
Updates `@storybook/addon-links` from 7.6.4 to 8.0.0
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.0/code/addons/links )
Updates `@storybook/components` from 7.6.17 to 8.0.0
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.0/code/ui/components )
Updates `@storybook/manager-api` from 7.6.7 to 8.0.0
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.0/code/lib/manager-api )
Updates `@storybook/react` from 7.6.12 to 8.0.0
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.0/code/renderers/react )
Updates `@storybook/react-webpack5` from 7.6.12 to 8.0.0
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.0/code/frameworks/react-webpack5 )
Updates `@storybook/theming` from 7.6.17 to 8.0.0
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.0/code/lib/theming )
Updates `storybook` from 7.6.15 to 8.0.0
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v8.0.0/code/lib/cli )
---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
dependency-type: direct:development
update-type: version-update:semver-major
dependency-group: storybook
- dependency-name: "@storybook/addon-actions"
dependency-type: direct:development
update-type: version-update:semver-major
dependency-group: storybook
- dependency-name: "@storybook/addon-essentials"
dependency-type: direct:development
update-type: version-update:semver-major
dependency-group: storybook
- dependency-name: "@storybook/addon-interactions"
dependency-type: direct:development
update-type: version-update:semver-major
dependency-group: storybook
- dependency-name: "@storybook/addon-links"
dependency-type: direct:development
update-type: version-update:semver-major
dependency-group: storybook
- dependency-name: "@storybook/components"
dependency-type: direct:development
update-type: version-update:semver-major
dependency-group: storybook
- dependency-name: "@storybook/manager-api"
dependency-type: direct:development
update-type: version-update:semver-major
dependency-group: storybook
- dependency-name: "@storybook/react"
dependency-type: direct:development
update-type: version-update:semver-major
dependency-group: storybook
- dependency-name: "@storybook/react-webpack5"
dependency-type: direct:development
update-type: version-update:semver-major
dependency-group: storybook
- dependency-name: "@storybook/theming"
dependency-type: direct:development
update-type: version-update:semver-major
dependency-group: storybook
- dependency-name: storybook
dependency-type: direct:development
update-type: version-update:semver-major
dependency-group: storybook
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-14 16:19:27 +00:00
Koen Vlaswinkel
f06bc88b59
Merge pull request #3477 from github/koesie10/grouped-dependabot-updates
...
Group some npm dependency updates
2024-03-14 17:15:15 +01:00
Robert
d65e6bea53
Simplify now we've deleted withInheritedProgress
2024-03-14 16:02:37 +00:00
Charis Kyriakou
115ff838c5
Add model packs to variant analyses ( #3472 )
2024-03-14 14:39:30 +00:00
Koen Vlaswinkel
41524cf45c
Group some npm dependency updates
2024-03-14 15:05:29 +01:00
Robert
9777cb1c66
Merge pull request #3464 from github/robertbrignull/token-not-used
...
Create token-not-used.ql to catch cases where we aren't using the progress bar token correctly
2024-03-14 13:46:30 +00:00
Robert
d9ac8744b6
Merge pull request #3466 from github/robertbrignull/remove_withInheritedProgress
...
Delete withInheritedProgress and ProgressContext
2024-03-14 13:44:22 +00:00
Robert
fffb0349a6
Apply suggestions from code review
...
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com >
2024-03-14 13:33:06 +00:00
Robert
0454130821
Merge branch 'main' into robertbrignull/remove_withInheritedProgress
2024-03-14 13:24:36 +00:00
Shati Patel
06f9f2c687
Add title to model alerts view ( #3465 )
2024-03-14 11:46:36 +00:00
Charis Kyriakou
dd90e38b7a
Add new ModelPacks component ( #3469 )
2024-03-14 11:34:34 +00:00
Charis Kyriakou
aa2f371583
Close Model Alerts view when Model editor closes ( #3468 )
2024-03-14 10:39:44 +00:00
Charis Kyriakou
bbc881e7c7
Move LinkIconButton to common dir ( #3467 )
2024-03-14 09:39:59 +00:00
Andrew Eisenberg
4cdbdd0d7d
Merge pull request #3433 from github/aeisenberg/re-import-test-db
...
Import testproj databases into workspace storage
2024-03-13 12:34:01 -07:00
Robert
ff889b73e1
Make documentation of fields more consistent
2024-03-13 18:09:51 +00:00
Robert
834b6a649e
Use jest.MockedFunction
2024-03-13 18:06:44 +00:00
Robert
16b8f848b5
Delete ProgressContext
2024-03-13 17:57:08 +00:00
Robert
bf58e311dd
Delete withInheritedProgress because we always have a progress context
2024-03-13 17:37:21 +00:00
Robert
84df4b64d8
Update messages/descriptions with how to fix the alert
2024-03-13 17:24:09 +00:00
Robert
4346cc6e98
Link to cancellable property
2024-03-13 17:08:55 +00:00
Robert
73bece6f38
Add query for using token when not cancellable
2024-03-13 16:43:59 +00:00
Robert
280bf8b7b2
Convert to an abstract class
2024-03-13 16:43:42 +00:00
Koen Vlaswinkel
a559a0a3e2
Merge pull request #3454 from github/koesie10/cancellable-variant-analysis
...
Make the "Run variant analysis against published pack" command cancellable
2024-03-13 16:10:18 +01:00
Koen Vlaswinkel
695cf340b7
Do not make model evaluator cancellable
2024-03-13 15:48:52 +01:00
Shati Patel
84a8ffdad2
Only allow one open model alerts view ( #3461 )
2024-03-13 14:05:47 +00:00
Koen Vlaswinkel
d56f71710e
Use MultiCancellationToken in model evaluator
2024-03-13 13:03:46 +01:00
Robert
826175ccd5
Create token-not-used.ql
2024-03-13 11:32:57 +00:00
Shati Patel
3005dacf4e
Use VSCodeBadge component ( #3462 )
2024-03-13 10:12:48 +00:00
Koen Vlaswinkel
8bb0085992
Enable forceExit for CLI tests
2024-03-13 10:20:55 +01:00
Koen Vlaswinkel
992a836ccb
Use tree-kill for killing CLI process
2024-03-13 10:19:39 +01:00
Andrew Eisenberg
2d85018d1d
Add better log messages
2024-03-12 16:32:24 -07:00
Andrew Eisenberg
f84f792c5f
Merge remote-tracking branch 'upstream/main' into aeisenberg/re-import-test-db
2024-03-12 14:50:50 -07:00
Robert
55b9b2e891
Use mocks instead of spies in tests
2024-03-12 15:44:17 +00:00
Robert
ec42728367
Only construct DatabaseFetcher once in extension.ts
2024-03-12 15:38:27 +00:00
Robert
9fa6d99f09
Have the skeleton query wizard call promptImportGithubDatabase so we can make more methods private
2024-03-12 15:32:44 +00:00
Robert
f29aff6303
Inline isFile
2024-03-12 15:32:44 +00:00
Robert
3ee081e8c6
Move commonly-used field to DatabaseFetcher constructor
2024-03-12 15:32:40 +00:00
Robert
18f1a46493
Naively convert DatabaseFetcher to a class
2024-03-12 15:14:00 +00:00
Shati Patel
eb1a5cfba3
Add "model alerts indicator" component ( #3441 )
2024-03-12 14:08:49 +00:00
Koen Vlaswinkel
0cbd96ff7c
Add error listener
2024-03-12 13:43:15 +01:00
Koen Vlaswinkel
3050437cab
Clean up process
2024-03-12 13:43:15 +01:00
Koen Vlaswinkel
27bb46ab4c
Make more parts of running a variant analysis cancellable
2024-03-12 13:43:14 +01:00
Koen Vlaswinkel
24b7adfb92
Allow cancelling pack download
2024-03-12 13:42:40 +01:00
Koen Vlaswinkel
97eaaacce6
Run pack bundle in separate process and allow cancelling it
2024-03-12 13:42:24 +01:00
Koen Vlaswinkel
b961a7ae55
Extract RunOptions
2024-03-12 13:42:24 +01:00
Koen Vlaswinkel
23003ec8bf
Extract process output handling in CLI server
2024-03-12 13:42:24 +01:00
Koen Vlaswinkel
c32065e895
Merge pull request #3457 from github/koesie10/query-suite-code-scanning
...
Use suite file instead of manually filtering queries
2024-03-12 13:06:12 +01:00
Koen Vlaswinkel
b71a536e00
Use include instructions for suite file
2024-03-12 11:44:30 +01:00
Andrew Eisenberg
fd3acfb1c9
Address pull request comments
2024-03-11 16:01:25 -07:00
github-actions[bot]
66de756d88
Bump CLI Version to v2.16.4 for integration tests ( #3459 )
...
* Bump CLI version from v2.16.3 to v2.16.4 for integration tests
* Remove extraneous `v2.16.2` from supported list
We only need to keep the most recent patch version for each minor version.
---------
Co-authored-by: github-actions[bot] <github-actions@github.com >
Co-authored-by: Angela P Wen <angelapwen@github.com >
2024-03-11 14:10:03 -07:00
Koen Vlaswinkel
16a0fce7ce
Merge pull request #3456 from github/koesie10/unique-database-names
...
Make database storage paths more unique
2024-03-11 16:40:46 +01:00
Koen Vlaswinkel
0feef365d9
Clean up temporary file in finally block
2024-03-11 14:39:07 +01:00
Koen Vlaswinkel
e003175f76
Reduce nanoid tries
2024-03-11 14:17:16 +01:00
Koen Vlaswinkel
0e3665b5fc
Improve readability of duplicate filename logic
2024-03-11 14:16:53 +01:00
Koen Vlaswinkel
7681a56a16
Fix location of removing dots
2024-03-11 14:14:28 +01:00
Koen Vlaswinkel
bbc09f3ae5
Merge remote-tracking branch 'origin/main' into koesie10/unique-database-names
2024-03-11 12:49:32 +01:00
Koen Vlaswinkel
fe0136091d
Use readdir instead of repeated pathExists calls
2024-03-11 12:41:26 +01:00
Koen Vlaswinkel
1ab3deab4d
Merge pull request #3455 from github/koesie10/extension-managed-location
...
Fix incomplete removal of databases
2024-03-11 12:20:14 +01:00
Robert
650b09cf6a
Merge pull request #3444 from github/robertbrignull/start-modeling-test
...
Add tests of MethodModelingViewProvider.viewLoaded
2024-03-11 11:18:56 +00:00
Robert
18f9b5fe15
Use jest.MockedFunction
2024-03-11 11:04:58 +00:00
Robert
dbd5d0f406
Remove unused arguments from resolveWebviewView
2024-03-11 11:02:37 +00:00
Robert
b436fbd73b
Merge pull request #3453 from github/robertbrignull/convertGithubNwoToDatabaseUrl
...
Move convertGithubNwoToDatabaseUrl to databases/github-databases/api.ts
2024-03-11 10:58:15 +00:00
Robert
5402cab05a
Merge pull request #3452 from github/robertbrignull/findDirWithFile
...
Move findDirWithFile to files.ts
2024-03-11 10:57:36 +00:00
Koen Vlaswinkel
e8efbbb9fd
Introduce createFilenameFromString function
2024-03-11 11:31:43 +01:00
Koen Vlaswinkel
82741e95c3
Add test for extension-managed db location
2024-03-11 11:15:15 +01:00
Koen Vlaswinkel
35267bb3fd
Use suite file instead of manually filtering queries
2024-03-08 16:12:56 +01:00
Koen Vlaswinkel
2c35a97b09
Make database storage paths more unique
2024-03-08 14:56:06 +01:00
Koen Vlaswinkel
f426178b96
Fix incomplete removal of databases
2024-03-08 13:45:59 +01:00
Shati Patel
dbd5078424
Fix warning in package.json about "editor.wordBasedSuggestions" ( #3451 )
2024-03-07 16:48:29 +00:00
Robert
66879ef626
Move convertGithubNwoToDatabaseUrl to databases/github-databases/api.ts
2024-03-07 16:36:29 +00:00
Robert
fe6dc8a7a3
Move findDirWithFile to files.ts
2024-03-07 16:31:01 +00:00
Robert
8b2355acc3
Merge pull request #3447 from github/dependabot/npm_and_yarn/extensions/ql-vscode/vscode/vsce-2.24.0
...
Bump @vscode/vsce from 2.22.0 to 2.24.0 in /extensions/ql-vscode
2024-03-07 14:12:01 +00:00
dependabot[bot]
be06026832
Bump @vscode/vsce from 2.22.0 to 2.24.0 in /extensions/ql-vscode
...
Bumps [@vscode/vsce](https://github.com/Microsoft/vsce ) from 2.22.0 to 2.24.0.
- [Release notes](https://github.com/Microsoft/vsce/releases )
- [Commits](https://github.com/Microsoft/vsce/compare/v2.22.0...v2.24.0 )
---
updated-dependencies:
- dependency-name: "@vscode/vsce"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-07 13:58:43 +00:00
Robert
d7ef716d63
Merge pull request #3446 from github/dependabot/npm_and_yarn/extensions/ql-vscode/vscode/test-electron-2.3.9
...
Bump @vscode/test-electron from 2.3.8 to 2.3.9 in /extensions/ql-vscode
2024-03-07 13:57:22 +00:00
Robert
cd9a0287fb
Merge pull request #3448 from github/dependabot/npm_and_yarn/extensions/ql-vscode/nanoid-5.0.6
...
Bump nanoid from 5.0.4 to 5.0.6 in /extensions/ql-vscode
2024-03-07 13:56:03 +00:00
Robert
4187fd6e91
Merge pull request #3445 from github/dependabot/npm_and_yarn/extensions/ql-vscode/tar-stream-3.1.7
...
Bump tar-stream from 3.1.6 to 3.1.7 in /extensions/ql-vscode
2024-03-07 13:55:38 +00:00
dependabot[bot]
651a9a627e
Bump nanoid from 5.0.4 to 5.0.6 in /extensions/ql-vscode
...
Bumps [nanoid](https://github.com/ai/nanoid ) from 5.0.4 to 5.0.6.
- [Release notes](https://github.com/ai/nanoid/releases )
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md )
- [Commits](https://github.com/ai/nanoid/compare/5.0.4...5.0.6 )
---
updated-dependencies:
- dependency-name: nanoid
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-07 13:37:01 +00:00
dependabot[bot]
cd2fdf9d2e
Bump @vscode/test-electron from 2.3.8 to 2.3.9 in /extensions/ql-vscode
...
Bumps [@vscode/test-electron](https://github.com/Microsoft/vscode-test ) from 2.3.8 to 2.3.9.
- [Changelog](https://github.com/microsoft/vscode-test/blob/main/CHANGELOG.md )
- [Commits](https://github.com/Microsoft/vscode-test/commits/v2.3.9 )
---
updated-dependencies:
- dependency-name: "@vscode/test-electron"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-07 13:36:36 +00:00
dependabot[bot]
7ad9507910
Bump tar-stream from 3.1.6 to 3.1.7 in /extensions/ql-vscode
...
Bumps [tar-stream](https://github.com/mafintosh/tar-stream ) from 3.1.6 to 3.1.7.
- [Commits](https://github.com/mafintosh/tar-stream/compare/v3.1.6...v3.1.7 )
---
updated-dependencies:
- dependency-name: tar-stream
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-07 13:36:25 +00:00
Robert
54cf5c55a8
Add tests of MethodModelingViewProvider viewLoaded
2024-03-07 10:10:33 +00:00
Robert
659da6cee1
Merge pull request #3440 from github/robertbrignull/database-download-creds
...
Push decision to use credentials or not down to where the creds are used
2024-03-06 16:43:19 +00:00
Robert
707cdec1ec
Update CHANGELOG.md
2024-03-06 16:28:37 +00:00
Robert
ee5ccecbd3
Merge pull request #3443 from github/robertbrignull/delete_hasStateForActiveDb
...
Delete hasStateForActiveDb as it is unused
2024-03-06 16:26:33 +00:00
Robert
4a662eabfa
Merge pull request #3442 from github/robertbrignull/cancellationTokenSource
...
Use CancellationTokenSource instead of casting dummy objects
2024-03-06 16:18:59 +00:00
Robert
0cdcd2ce67
Delete hasStateForActiveDb as it is unused
2024-03-06 14:52:48 +00:00
Robert
2bc261eacf
Use CancellationTokenSource instead of casting dummy objects
2024-03-06 12:28:30 +00:00
Robert
83a6b5a054
Merge pull request #3439 from github/robertbrignull/modeling-mode
...
Refactor events to fix the method modeling panel getting stuck showing "start modeling"
2024-03-06 12:06:22 +00:00
Robert
5d263bb1a3
Push decision to use credentials or not down to where the creds are used
2024-03-05 15:11:00 +00:00
Shati Patel
cffecafb61
Add a new "model alerts" webview (for showing results from model evaluation) ( #3436 )
2024-03-05 14:39:30 +00:00
Rasmus Wriedt Larsen
6f1504aaff
Merge pull request #3438 from github/RasmusWL/fix-quick-eval-counts
...
Fix `isQuickEvalCount` logic
2024-03-05 13:34:00 +01:00
Robert
ce12c67469
Merge pull request #3437 from github/robertbrignull/testplan-table-query
...
Avoid using a @treemap query in testplan
2024-03-05 12:14:12 +00:00
Robert
dc08da924f
Inline showMethod
2024-03-05 11:56:37 +00:00
Robert
fdd45e8dbd
Make revealItem private by listening to onSelectedMethodChanged
2024-03-05 11:56:31 +00:00
Robert
2f49ac83de
Remove setMethod which was only called from onSelectedMethodChanged which we already listen to
2024-03-05 11:05:07 +00:00
Rasmus Wriedt Larsen
c69cea1f8e
Apply suggestions from code review
...
Co-authored-by: Robert <robertbrignull@github.com >
2024-03-05 11:51:51 +01:00
Rasmus Wriedt Larsen
e6b1d8d616
Fix isQuickEvalCount logic
...
Since `false !== undefined` evaluates to true, we would assign the wrong
value to `isQuickEvalCount` when
`selectedQuery.quickEval?.quickEvalCount` is false
2024-03-05 11:21:43 +01:00
Robert
08c6c8a50c
Introduce SetNoMethodSelectedMessage
2024-03-05 09:57:01 +00:00
Robert
d4413424c1
Rewrite setInitialState to always set all fields
2024-03-05 09:57:01 +00:00
Robert
a82be4258c
Pull out setSelectedMethod method
2024-03-05 09:57:01 +00:00
Robert
b946f3a509
Pull out setDatabaseItem method
2024-03-05 09:57:00 +00:00
Robert
6402f05624
Avoid using a @treemap query in testplan
2024-03-05 09:42:07 +00:00
Shati Patel
ad9f78ca2b
Add link to open "Evaluation Run" from the model editor ( #3435 )
2024-03-04 17:07:32 +00:00
Robert
54737a0221
Merge pull request #3434 from github/robertbrignull/node-version-workflow
...
Mention that an automated workflow exists for updating the node version
2024-03-04 16:04:01 +00:00
Robert
ff664dd18c
Mention that an automated workflow exists for updating the node version
2024-03-04 11:14:50 +00:00
Andrew Eisenberg
0ed9242b81
Try waiting a few seconds before renaming
2024-03-02 20:43:55 -08:00
Andrew Eisenberg
3497219c68
Use unzipToDirectoryConcurrently instead of the unzipper package
2024-03-01 16:16:59 -05:00
Andrew Eisenberg
4450237612
Add changelog note
...
And fix linting error.
2024-03-01 15:41:26 -05:00
Koen Vlaswinkel
b7be98b627
Merge pull request #3414 from github/koesie10/verify-valid-sarif
...
Add check for id property when running variant analysis
2024-03-01 11:20:42 +01:00
Charis Kyriakou
96b7722f26
Add logic to stop an evaluation run ( #3421 )
2024-03-01 09:25:03 +00:00
Andrew Eisenberg
361fed622b
Ask user if they want to re-import outdated testproj dbs
...
Before running a query now, do the following:
1. Check if the selected database is imported from a testproj
2. If so, check the last modified time of the `codeql-datase.yml` file
of the imported database with that of its origin.
3. If the origin database has a file that is newer, assume that the
database has been recreated since the last time it was imported.
4. If newer, then ask the user if they want to re-import before running
the query.
Also, this change appends the `(test)` label to all test databases in
the database list.
2024-03-01 10:16:16 +01:00
Shati Patel
df782592bc
Extract "ModelEvaluation" component ( #3432 )
2024-02-29 16:42:38 +00:00
dependabot[bot]
30fd1226d5
Bump @babel/core from 7.23.6 to 7.24.0 in /extensions/ql-vscode ( #3429 )
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.23.6 to 7.24.0.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.24.0/packages/babel-core )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-29 06:47:04 -08:00
dependabot[bot]
d810ed823a
Bump eslint-plugin-storybook in /extensions/ql-vscode ( #3431 )
...
Bumps [eslint-plugin-storybook](https://github.com/storybookjs/eslint-plugin-storybook ) from 0.6.15 to 0.8.0.
- [Release notes](https://github.com/storybookjs/eslint-plugin-storybook/releases )
- [Changelog](https://github.com/storybookjs/eslint-plugin-storybook/blob/main/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/eslint-plugin-storybook/compare/v0.6.15...v0.8.0 )
---
updated-dependencies:
- dependency-name: eslint-plugin-storybook
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-29 06:23:01 -08:00
dependabot[bot]
567a0bb194
Bump applicationinsights from 2.9.2 to 2.9.4 in /extensions/ql-vscode ( #3430 )
...
Bumps [applicationinsights](https://github.com/microsoft/ApplicationInsights-node.js ) from 2.9.2 to 2.9.4.
- [Release notes](https://github.com/microsoft/ApplicationInsights-node.js/releases )
- [Commits](https://github.com/microsoft/ApplicationInsights-node.js/compare/2.9.2...2.9.4 )
---
updated-dependencies:
- dependency-name: applicationinsights
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-29 06:22:37 -08:00
Charis Kyriakou
f283df0225
Update model evaluation notification ( #3426 )
2024-02-29 14:19:34 +00:00
dependabot[bot]
a70fd835f1
Bump mini-css-extract-plugin in /extensions/ql-vscode ( #3428 )
...
Bumps [mini-css-extract-plugin](https://github.com/webpack-contrib/mini-css-extract-plugin ) from 2.8.0 to 2.8.1.
- [Release notes](https://github.com/webpack-contrib/mini-css-extract-plugin/releases )
- [Changelog](https://github.com/webpack-contrib/mini-css-extract-plugin/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/mini-css-extract-plugin/compare/v2.8.0...v2.8.1 )
---
updated-dependencies:
- dependency-name: mini-css-extract-plugin
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-29 06:12:11 -08:00
Charis Kyriakou
a51bd76392
Skip logging warning for multi-query variant analyses ( #3425 )
2024-02-29 13:50:19 +00:00
Charis Kyriakou
1ac92ad79c
Don't open variant analysis view when running a model evaluation run ( #3424 )
2024-02-29 13:38:21 +00:00
Koen Vlaswinkel
b168ce708b
Check against problem and path-problem aliases
2024-02-29 14:01:32 +01:00
Anders Starcke Henriksen
fc5d462dc5
Merge pull request #3423 from github/version/bump-to-v1.12.4
...
Bump version to v1.12.4
2024-02-29 12:17:11 +01:00
github-actions[bot]
30da5d5b62
Bump version to v1.12.4
2024-02-29 10:42:04 +00:00
Anders Starcke Henriksen
b301c4a08c
Merge pull request #3422 from github/v1.12.3
...
v1.12.3
2024-02-29 11:40:21 +01:00
Anders Starcke Henriksen
bb796b0c27
v1.12.3
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2024-02-29 10:24:32 +01:00
Koen Vlaswinkel
f73ea67967
Merge pull request #3413 from github/koesie10/fix-tests-with-warnings
...
Show test results for tests with warnings
2024-02-28 16:02:32 +01:00
Koen Vlaswinkel
eaa432b9d7
Add tests for new test warning behavior
2024-02-28 14:01:06 +01:00
Charis Kyriakou
23bbff230f
Update variant analysis monitor to get the whole variant analysis object ( #3415 )
2024-02-28 12:12:27 +00:00
Charis Kyriakou
b884cff14d
Some restructuring around variant analysis mapper functions ( #3412 )
2024-02-28 11:45:49 +00:00
Koen Vlaswinkel
359ee76d52
Merge pull request #3401 from github/koesie10/hide-generated-type-models
...
Generate separate file for generated type models in Ruby by default
2024-02-28 11:47:58 +01:00
Koen Vlaswinkel
5521c00346
Add check for id property when running variant analysis
2024-02-28 11:17:15 +01:00
Koen Vlaswinkel
eb71df84a7
Move query metadata retrieval before pack bundling
2024-02-28 11:15:00 +01:00
Koen Vlaswinkel
d14c7b4114
Show test results for tests with warnings
2024-02-28 10:47:29 +01:00
Charis Kyriakou
ab36153511
Minor renames in variant analysis monitor tests ( #3411 )
...
* Rename mockGetVariantAnalysis -> mockGetVariantAnalysisFromApi
* Rename mockEecuteCommand -> mockExecuteCommand
2024-02-28 09:12:26 +00:00
Koen Vlaswinkel
0599adccc0
Fix generated text
...
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com >
2024-02-28 09:58:33 +01:00
Charis Kyriakou
e86127672a
Drop async from some functions that are not async ( #3410 )
2024-02-27 16:57:53 +00:00
Charis Kyriakou
040c7fc726
Add support for 'canceling' status for variant analysis ( #3405 )
2024-02-27 16:32:24 +00:00
Charis Kyriakou
5f047386c9
Rename getVariantAnalysis to tryGetVariantAnalysis ( #3409 )
2024-02-27 14:31:43 +00:00
Charis Kyriakou
a416bcf544
Rename variable in variant analysis manager ( #3408 )
2024-02-27 14:07:12 +00:00
Robert
c45a8158a3
Merge pull request #3395 from github/robertbrignull/set-modeled-and-modified-methods
...
Set modeled methods and modified methods together
2024-02-26 13:24:39 +00:00
Robert
a74e36314c
Update extensions/ql-vscode/test/__mocks__/model-editor/modelingEventsMock.ts
...
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com >
2024-02-26 13:11:22 +00:00
Robert
7fac0405b3
Remove dedicated modified methods event
2024-02-26 11:22:46 +00:00
Robert
7c77b39d30
Rename to ModeledAndModifiedMethodsChanged
2024-02-26 11:22:44 +00:00
Robert
1567d83463
modifiedMethodSignatures is always defined
2024-02-26 11:22:41 +00:00
Koen Vlaswinkel
7dceded98c
Use showTypeModels setting instead of canary mode
2024-02-26 12:11:16 +01:00
Robert
ec67df3373
Merge branch 'main' into robertbrignull/set-modeled-and-modified-methods
2024-02-26 11:06:34 +00:00
Robert
6e61ddb0f2
Merge pull request #3398 from github/robertbrignull/sort-in-modeling-store
...
Move all sorting to the modeling store, and then all views preserve the sorting
2024-02-26 11:05:59 +00:00
Koen Vlaswinkel
32d981ace4
Merge remote-tracking branch 'origin/main' into koesie10/hide-generated-type-models
2024-02-26 11:59:23 +01:00
Koen Vlaswinkel
1da465f7df
Merge pull request #3399 from github/koesie10/hide-type-models-non-canary
...
Hide type models for Ruby by default
2024-02-26 11:58:30 +01:00
Koen Vlaswinkel
713ca9f785
Fix test names
2024-02-26 11:45:23 +01:00
Robert
9a5654648d
Rename to createGroups
2024-02-26 10:35:51 +00:00
Robert
a1c84ac689
Reorder expected test data
2024-02-26 10:32:46 +00:00
Koen Vlaswinkel
7591c65db2
Add showTypeModels setting
2024-02-26 11:19:23 +01:00
Koen Vlaswinkel
c8ec1d6ea3
Merge remote-tracking branch 'origin/main' into koesie10/hide-type-models-non-canary
2024-02-26 11:07:54 +01:00
Andrew Eisenberg
ca21ed18d0
Import testproj databases into workspace storage
...
If a folder that ends with `.testproj` is encountered, assume it is a
database created by a codeql test. When the user wants to import this
database, copy it into workspace storage. The database can be
re-imported, which first removes the old version before importing it
again.
2024-02-25 18:39:41 -05:00
Koen Vlaswinkel
8063d6c46b
Merge pull request #3402 from github/koesie10/simplify-multiple-modeled-methods-panel-spec
...
Reduce repetition in `MultipleModeledMethodsPanel.spec.tsx`
2024-02-23 16:32:45 +01:00
Koen Vlaswinkel
48718ca2e6
Reduce repetition in MultipleModeledMethodsPanel.spec.tsx
2024-02-23 15:47:40 +01:00
Koen Vlaswinkel
22024462fb
Generate separate file for generated type models in Ruby
2024-02-23 15:38:12 +01:00
Koen Vlaswinkel
b4a9ef0d4c
Merge pull request #3400 from github/koesie10/refactor-yaml-save
...
Extract saving of model extension YAML file
2024-02-23 15:24:16 +01:00
Koen Vlaswinkel
5468aef458
Extract saving of model extension YAML file
2024-02-23 14:38:12 +01:00
Charis Kyriakou
f4a866b04b
Add logic to trigger model evaluation run ( #3397 )
2024-02-23 11:17:25 +00:00
Koen Vlaswinkel
f57d4418c7
Hide type models for Ruby in non-canary mode
2024-02-23 10:32:17 +01:00
Chris Smowton
a62522ec67
Merge pull request #3388 from github/github-action/bump-cli
...
Bump CLI Version to v2.16.3 for integration tests
2024-02-23 09:28:01 +00:00
Koen Vlaswinkel
6031d9b496
Merge pull request #3394 from github/koesie10/auto-run-generate-ruby-type-models
...
Auto-generate type models for Ruby
2024-02-23 10:15:05 +01:00
Koen Vlaswinkel
c216b52c8d
Merge pull request #3370 from github/koesie10/model-pack-mrva-test
...
Add test for model packs in MRVA to test plan
2024-02-23 10:14:55 +01:00
Robert
ff685f0233
Move all sorting to the modeling store, and then all views preserve the sorting
2024-02-22 17:20:36 +00:00
Charis Kyriakou
948c1e2eb7
Add model evaluation run to store and view ( #3385 )
2024-02-22 16:28:32 +00:00
Robert
5ce09e6ccc
Include modifiedMethodSignatures in SetModeledMethodsMessage
2024-02-22 15:45:57 +00:00
Robert
8832655c2f
Add modifiedMethodSignatures to ModeledMethodsChangedEvent
2024-02-22 15:45:53 +00:00
Koen Vlaswinkel
e408c0ac95
Auto-generate type models for Ruby
2024-02-22 16:44:03 +01:00
dependabot[bot]
07d9c4efc4
Bump @storybook/components from 7.6.7 to 7.6.17 in /extensions/ql-vscode ( #3393 )
...
Bumps [@storybook/components](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/components ) from 7.6.7 to 7.6.17.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.17/code/ui/components )
---
updated-dependencies:
- dependency-name: "@storybook/components"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-22 06:23:26 -08:00
dependabot[bot]
98491fb1dc
Bump @typescript-eslint/parser in /extensions/ql-vscode ( #3392 )
...
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser ) from 6.16.0 to 6.21.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases )
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md )
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.21.0/packages/parser )
---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-22 06:23:05 -08:00
dependabot[bot]
5c305f96de
Bump @faker-js/faker from 8.3.1 to 8.4.1 in /extensions/ql-vscode ( #3391 )
...
Bumps [@faker-js/faker](https://github.com/faker-js/faker ) from 8.3.1 to 8.4.1.
- [Release notes](https://github.com/faker-js/faker/releases )
- [Changelog](https://github.com/faker-js/faker/blob/next/CHANGELOG.md )
- [Commits](https://github.com/faker-js/faker/compare/v8.3.1...v8.4.1 )
---
updated-dependencies:
- dependency-name: "@faker-js/faker"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-22 06:22:45 -08:00
dependabot[bot]
4b64e98e9f
Bump @testing-library/react in /extensions/ql-vscode ( #3390 )
...
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library ) from 14.1.2 to 14.2.1.
- [Release notes](https://github.com/testing-library/react-testing-library/releases )
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/react-testing-library/compare/v14.1.2...v14.2.1 )
---
updated-dependencies:
- dependency-name: "@testing-library/react"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-22 06:22:18 -08:00
dependabot[bot]
2b14639c80
Bump chokidar from 3.5.3 to 3.6.0 in /extensions/ql-vscode ( #3389 )
...
Bumps [chokidar](https://github.com/paulmillr/chokidar ) from 3.5.3 to 3.6.0.
- [Release notes](https://github.com/paulmillr/chokidar/releases )
- [Commits](https://github.com/paulmillr/chokidar/compare/3.5.3...3.6.0 )
---
updated-dependencies:
- dependency-name: chokidar
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-22 06:21:58 -08:00
Koen Vlaswinkel
b826ed3d9c
Merge pull request #3373 from github/koesie10/download-timeout
...
Add timeouts to downloading databases and the CLI
2024-02-22 13:39:38 +01:00
Robert
63de6cece5
Allow changeModeledMethods to also call fireModifiedMethodsChangedEvent
2024-02-22 12:36:06 +00:00
Robert
59118f63aa
Change addModeledMethods and updateModeledMethods to also set methods as modified
2024-02-22 12:31:17 +00:00
Robert
91e59323f3
Delete setModifiedMethods as it is unused
2024-02-22 12:31:17 +00:00
Koen Vlaswinkel
54e1275f68
Merge pull request #3387 from github/koesie10/update-ruby-generate-query-constraints
...
Update Ruby model generation query constraints
2024-02-22 13:27:43 +01:00
Koen Vlaswinkel
9437cd094b
Update CHANGELOG
2024-02-22 13:25:03 +01:00
github-actions[bot]
6161c7d3d4
Bump CLI version from v2.16.2 to v2.16.3 for integration tests
2024-02-22 11:54:32 +00:00
Koen Vlaswinkel
873ccaa7fd
Update Ruby model generation query constraints
2024-02-22 12:09:00 +01:00
Robert
7a2688edac
Merge pull request #3382 from github/robertbrignull/automodel-sort-order
...
Update method sort order to place auto-model predictions earlier
2024-02-22 11:00:51 +00:00
Koen Vlaswinkel
bf35909375
Merge pull request #3380 from github/koesie10/processed-method-modeling
...
Add processed by auto model state to method modeling panel
2024-02-22 09:34:55 +01:00
Robert
4096ded330
Merge branch 'main' into robertbrignull/automodel-sort-order
2024-02-21 17:38:50 +00:00
Robert
fee7eae702
Merge pull request #3377 from github/robertbrignull/disable-automodel-button
...
Disable the automodel button if there are no methods that can be modeled
2024-02-21 16:11:21 +00:00
Koen Vlaswinkel
2c6eb3c832
Fix incorrect modelPending prop
2024-02-21 16:24:11 +01:00
Robert
2fdafaf616
Move getCandidates to the shared directory
2024-02-21 12:29:43 +00:00
Robert
b59437e7dc
Cover in unit test that unmodeled and unsaved manual models are sorted together
2024-02-21 11:49:13 +00:00
Charis Kyriakou
e78f7e62fb
Moved logic to get standard pack for variant analysis ( #3384 )
2024-02-21 11:42:08 +00:00
Robert
759f8d4768
Give test methods signatures that'll be easier to identify
2024-02-21 11:39:54 +00:00
Robert
3ca4c7623e
Update sort order for supported methods and unsaved manual models
2024-02-21 11:38:58 +00:00
Robert
7a68fcd05d
Add comment explaining sort order more
2024-02-21 10:40:38 +00:00
Robert
1bad26a67d
Merge branch 'main' into robertbrignull/automodel-sort-order
2024-02-21 10:33:27 +00:00
Koen Vlaswinkel
db73cfeb76
Merge pull request #3378 from github/koesie10/ignore-more-location-indexes
...
Ignore more location indexes in SARIF comparison
2024-02-21 10:37:47 +01:00
Koen Vlaswinkel
3d2d86bf6e
Merge pull request #3379 from github/koesie10/italic-model-pending
...
Show auto-model negative predictions in italics
2024-02-21 09:55:29 +01:00
Charis Kyriakou
0533dad9ea
Add progress ring in 'stop evaluation' button ( #3383 )
2024-02-20 16:44:47 +00:00
Robert
95fd015414
Add unit tests of method sorting
2024-02-20 16:07:03 +00:00
Robert
70a64886d6
Rename + expand existing helper for shuffling lists
2024-02-20 15:19:01 +00:00
Charis Kyriakou
46a15bfdd6
Add dummy model evaluation buttons to model editor ( #3381 )
2024-02-20 14:50:15 +00:00
Robert
14dbb65f50
Change sort order to place AI predictions at the start
2024-02-20 14:38:30 +00:00
Robert
8f3ab61422
Perform filtering before sorting when determining auto-model candidates
2024-02-20 14:24:13 +00:00
Koen Vlaswinkel
409c89653c
Add processed by auto model state to method modeling panel
2024-02-20 15:05:49 +01:00
Robert
3598b1871f
Merge pull request #3376 from github/robertbrignull/dont-model-twice
...
Don't send methods to AutoModel more than once
2024-02-20 13:57:17 +00:00
Robert
e3d9efef06
Use anonymous function instead of direct function reference
2024-02-20 13:35:27 +00:00
Koen Vlaswinkel
694bb21713
Ignore more location indexes in SARIF comparison
2024-02-20 14:32:41 +01:00
Robert
d6c5ebe73a
Pass methodSignatures to getProcessedByAutoModelMethods
2024-02-20 13:27:09 +00:00
Koen Vlaswinkel
899b159209
Use auto-model status for determining model pending
2024-02-20 14:22:31 +01:00
Koen Vlaswinkel
545311f26d
Switch from model accepted to model pending
2024-02-20 14:17:25 +01:00
Robert
d9ae0c6d17
Disable the automodel button if there are no methods that can be modeled
2024-02-20 12:34:49 +00:00
Koen Vlaswinkel
4727e0ecab
Merge pull request #3375 from github/koesie10/react-processed-by-auto-model
...
Add `processedByAutoModelMethods` state to React view
2024-02-20 13:11:24 +01:00
Robert
dbdb561598
Don't send methods to AutoModel more than once
2024-02-20 12:06:07 +00:00
Koen Vlaswinkel
bca4910bf2
Add processedByAutoModelMethods state to React view
2024-02-20 12:15:57 +01:00
Robert
3b30f22143
Merge pull request #3374 from github/robertbrignull/sentToLLMMethods
...
Add sentToLLM to ModelingStore
2024-02-20 10:05:27 +00:00
Robert
67f46b7fb2
Add processedByAUtoModel to modelingEventsMock
2024-02-20 09:47:37 +00:00
Robert
f98c5319cb
Rename to processedByAutoModel
2024-02-20 09:44:25 +00:00
Koen Vlaswinkel
7cd43cd894
Merge pull request #3369 from github/koesie10/stream-cli-output
...
Stream CLI server command stderr instead of buffering
2024-02-20 09:29:39 +01:00
Robert
4c4820f76a
add sentToLLM to ModelingStore
2024-02-19 16:48:40 +00:00
Koen Vlaswinkel
1b66767d43
Simplify stderr buffers and EOL splitting
...
Co-authored-by: Robert <robertbrignull@github.com >
2024-02-19 16:40:28 +01:00
Koen Vlaswinkel
1a9c792756
Extract timeout and apply to it to CLI downloads
2024-02-19 16:11:53 +01:00
Koen Vlaswinkel
feeb9d68b7
Add timeout to downloading databases
2024-02-19 14:10:28 +01:00
Robert
58b26d2b41
Merge pull request #3363 from github/robertbrignull/database-picker
...
Small usability improvements to database picker
2024-02-19 10:52:31 +00:00
Robert
0f18c841dc
Update placeholder text
2024-02-19 10:39:29 +00:00
Koen Vlaswinkel
67870cac08
Merge pull request #3372 from github/koesie10/upgrade-ip
...
Upgrade ip package
2024-02-19 10:37:33 +01:00
Koen Vlaswinkel
3de57d82ab
Upgrade ip package
2024-02-19 09:44:30 +01:00
Charis Kyriakou
60e497a763
Remove support for CodeQL CLI v2.12.7 and v2.11.6 ( #3371 )
2024-02-16 16:22:02 +00:00
Koen Vlaswinkel
abda1baca7
Add test for model packs in MRVA to test plan
2024-02-16 13:45:35 +01:00
Koen Vlaswinkel
5ddc3c11d3
Stream CLI server command stderr instead of buffering
2024-02-16 13:14:39 +01:00
dependabot[bot]
d2f4cd12a1
Bump @storybook/addon-a11y in /extensions/ql-vscode ( #3364 )
...
Bumps [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y ) from 7.6.13 to 7.6.15.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.15/code/addons/a11y )
---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-16 02:26:16 -08:00
dependabot[bot]
01b53f1709
Bump @testing-library/jest-dom in /extensions/ql-vscode ( #3368 )
...
Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom ) from 6.2.0 to 6.4.2.
- [Release notes](https://github.com/testing-library/jest-dom/releases )
- [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/jest-dom/compare/v6.2.0...v6.4.2 )
---
updated-dependencies:
- dependency-name: "@testing-library/jest-dom"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-16 08:42:03 +00:00
dependabot[bot]
2224ff936f
Bump storybook from 7.6.10 to 7.6.15 in /extensions/ql-vscode ( #3366 )
...
Bumps [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli ) from 7.6.10 to 7.6.15.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.15/code/lib/cli )
---
updated-dependencies:
- dependency-name: storybook
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-16 08:40:59 +00:00
dependabot[bot]
29cbe9a273
Bump mini-css-extract-plugin in /extensions/ql-vscode ( #3365 )
...
Bumps [mini-css-extract-plugin](https://github.com/webpack-contrib/mini-css-extract-plugin ) from 2.7.7 to 2.8.0.
- [Release notes](https://github.com/webpack-contrib/mini-css-extract-plugin/releases )
- [Changelog](https://github.com/webpack-contrib/mini-css-extract-plugin/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/mini-css-extract-plugin/compare/v2.7.7...v2.8.0 )
---
updated-dependencies:
- dependency-name: mini-css-extract-plugin
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-16 08:40:26 +00:00
Shati Patel
f1cc347e2a
Add "short-paths" test ( #3350 )
2024-02-15 16:09:35 +00:00
Shati Patel
b7010aa102
Replace deprecated telemetry setting in the tests ( #3362 )
2024-02-15 10:22:08 +00:00
Charis Kyriakou
574ba177cd
Tidy up auto-modeling rate limit error message ( #3361 )
2024-02-15 08:28:50 +00:00
Robert
d440c1080c
Make placeholder messages more descriptive
2024-02-14 17:08:43 +00:00
Robert
bb1bd5ce8b
Add test for when there are no databases
2024-02-14 16:44:37 +00:00
Robert
dd98a968ce
Fix naming in test databases
2024-02-14 16:41:07 +00:00
Robert
8c87493d76
Don't offer existing databases if there aren't any
2024-02-14 16:30:58 +00:00
Koen Vlaswinkel
0f4a7788a7
Merge pull request #3360 from github/koesie10/remove-any-from-gulpfile
...
Add types to TextMate gulp step
2024-02-14 14:59:49 +01:00
Robert
f12629ec4a
Merge pull request #3359 from github/robertbrignull/resultsapp
...
Remove cases from ResultsApp that seem to be impossible
2024-02-14 13:52:37 +00:00
Koen Vlaswinkel
3cb92233ac
Add types to TextMate gulp step
2024-02-14 14:26:42 +01:00
Robert
51c81f9172
Move setState call later
2024-02-14 12:41:18 +00:00
Robert
9eb7f96ac0
Remove impossible cases because resultsInfo cannot be null
2024-02-14 12:40:10 +00:00
Robert
9f4b82710a
Merge pull request #3354 from github/robertbrignull/multi-mrva-test
...
Add a CLI test for MRVA with multiple queries
2024-02-14 12:23:56 +00:00
Charis Kyriakou
715b2004f7
Make some clarifications in the test plan ( #3358 )
2024-02-14 12:05:24 +00:00
Robert
2138f859f5
Skip test when CLI version is not high enough
2024-02-14 11:48:58 +00:00
Robert
9e2b16afe3
Merge pull request #3353 from github/robertbrignull/eslint_no_any
...
Enable no-explicit-any throughout production code
2024-02-14 11:25:46 +00:00
Robert
93e6c53c8d
Merge eslintrc files
2024-02-14 11:10:35 +00:00
Koen Vlaswinkel
f4eed4d6a0
Merge pull request #3352 from github/koesie10/python-mad-format
...
Add support for Python in the model editor
2024-02-14 12:04:09 +01:00
Charis Kyriakou
c9a7c11731
Merge pull request #3357 from github/version/bump-to-v1.12.3
...
Bump version to v1.12.3
2024-02-14 10:47:37 +00:00
github-actions[bot]
701539fb7f
Bump version to v1.12.3
2024-02-14 10:29:50 +00:00
Charis Kyriakou
2ca61fb2d3
Merge pull request #3356 from github/v1.12.2
...
v1.12.2
2024-02-14 10:28:25 +00:00
Robert
d1ba99f2b4
Add test files 🤦
2024-02-14 10:07:29 +00:00
Charis Kyriakou
ad98388b66
v1.12.2
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2024-02-14 09:24:55 +00:00
Koen Vlaswinkel
38816b9f52
Merge pull request #3355 from github/koesie10/fix-view-compilation
...
Recompile view when shared files change
2024-02-14 10:04:08 +01:00
Koen Vlaswinkel
1ce652629c
Recompile view when shared files change
2024-02-14 09:46:58 +01:00
Robert
644f917b67
Add CLI test of multiple queries
2024-02-13 17:39:56 +00:00
Robert
e16468754a
Convert doVariantAnalysisTest to take multiple queries
2024-02-13 17:22:01 +00:00
Robert
ed96cbb2c9
Use as unknown as ResultsPaths in ResultsApp.tsx
2024-02-13 14:59:17 +00:00
Robert
ac707ff75c
Ignore any in useEffectEvent.ts
2024-02-13 14:59:14 +00:00
Robert
334dbf57ef
Ignore any in CommandManager.ts
2024-02-13 14:53:15 +00:00
Robert
a4294e2e28
Disable no-explicit-any in gulpfile.ts directory
2024-02-13 14:53:15 +00:00
Robert
e3a6678dc7
Disable no-explicit-any in test directory
2024-02-13 14:53:15 +00:00
Robert
55c86016a3
Disallow use of any by default
2024-02-13 14:38:43 +00:00
Koen Vlaswinkel
070af9eb42
Add support for Python in the model editor
2024-02-13 15:22:37 +01:00
Shati Patel
70b8ddfa37
Add feature flag for Python model editor ( #3351 )
2024-02-13 14:02:13 +00:00
Robert
923a480ddd
Merge pull request #3349 from github/robertbrignull/add_types
...
Add new type parameters to functions where possible
2024-02-13 14:02:04 +00:00
Robert
cd0d64605a
Change registerCommandWithErrorHandling from two type args to one
2024-02-13 12:35:04 +00:00
Robert
fcc5f6967e
Add generic types to registerCommandWithErrorHandling
2024-02-13 11:10:16 +00:00
Robert
74070fbc1a
Add type information to Memento.update
2024-02-13 11:10:16 +00:00
Robert
f8e825287c
Add typing to readJsonlFile
...
We're still not verifying the actual object returned by JSON.parse so
this isn't any safer at runtime than using 'any', but it helps add more
static typing to the code calling readJsonlFile.
2024-02-13 11:10:16 +00:00
Koen Vlaswinkel
d7e9606bfa
Merge pull request #3331 from github/koesie10/endpoint-type-supported
...
Add supported endpoint types to predicates
2024-02-13 12:04:45 +01:00
Robert
be6166497f
Merge pull request #3342 from github/robertbrignull/cached_operation
...
Give more types to CachedOperation to avoid use of any
2024-02-13 10:48:31 +00:00
Robert
01f6884b6c
Undo changes to comment
2024-02-13 10:17:15 +00:00
Koen Vlaswinkel
8d1480ab35
Merge pull request #3348 from github/koesie10/ruby-canary
...
Remove `enableRuby` feature flag
2024-02-13 11:06:59 +01:00
Robert
4ed6a7b95b
Merge pull request #3346 from github/robertbrignull/telemetry-unknown
...
Avoid use of any in TelemetryListener
2024-02-13 09:37:34 +00:00
Koen Vlaswinkel
00076a9538
Remove enableRuby feature flag
2024-02-13 10:18:50 +01:00
Dave Bartolomeo
3f02ff4151
Merge pull request #3347 from github/github-action/bump-cli
...
Bump CLI Version to v2.16.2 for integration tests
2024-02-12 10:37:37 -08:00
github-actions[bot]
9e7fefe724
Bump CLI version from v2.16.1 to v2.16.2 for integration tests
2024-02-12 18:23:59 +00:00
Robert
0f6afac222
Use type import
2024-02-12 17:16:34 +00:00
Robert
f7731e2e12
Merge pull request #3344 from github/robertbrignull/correct-types
...
Use correct types where possible instead of any
2024-02-12 16:51:06 +00:00
Robert
f4edc6e5a9
Merge pull request #3345 from github/robertbrignull/addWatcher-unknown
...
Use bind instead of thisArg parameter in MultiFileSystemWatcher
2024-02-12 16:37:21 +00:00
Robert
478d41648e
Use type import
2024-02-12 16:32:42 +00:00
Robert
6472ea8fde
Merge pull request #3341 from github/robertbrignull/unknown_type_checking
...
Use unknown instead of any in type functions
2024-02-12 15:57:23 +00:00
Robert
5a80d02a91
Merge pull request #3343 from github/robertbrignull/use-unknown
...
Use unknown instead of any where possible
2024-02-12 15:56:42 +00:00
Robert
939616372c
Use correct type for envelope argument
2024-02-12 15:39:23 +00:00
Robert
bfe78eba9a
Use string index notation instead of as any
2024-02-12 15:39:23 +00:00
Robert
8a389f2eb7
Remove thisArg from addWatcher and use bind instead
2024-02-12 15:38:26 +00:00
Robert
1004f16b10
Change addWatcher listener to return void
2024-02-12 15:38:26 +00:00
Robert
e5961f2967
Use Record<string, unknown> for additionalRunQueryArgs
2024-02-12 15:37:46 +00:00
Robert
25f179ca0e
Use unknown in QLDebugSession.customRequest
2024-02-12 15:37:46 +00:00
Robert
e7adfdc8bc
Use unknown for extension type
2024-02-12 15:37:45 +00:00
Robert
281242fa3f
Use unknown in Disposable
2024-02-12 15:37:45 +00:00
Robert
4b832bd85c
Use QlPackFile type in quick-query.ts
2024-02-12 15:36:43 +00:00
Robert
7af65ed86a
Use computed type instead of any for listCodeqlDatabases response
...
This endpoint actually has the correct type already. We could explicitly
declare it as
RestEndpointMethodTypes["codeScanning"]["listCodeqlDatabases"]["response"]["data"][0]
but this seems unnecessary given how ugly that type is. If we just do nothing
then typescript already computes the correct type for us.
2024-02-12 15:36:22 +00:00
Robert
116aceffc1
Use correct type for octokit options
2024-02-12 15:36:13 +00:00
Robert
f6efcd5a21
onCancellationRequested listener should not return anything (I think)
2024-02-12 15:34:19 +00:00
Robert
bdbd123d32
Give type information to convertedLabelArray
2024-02-12 15:33:49 +00:00
Robert
f0ce52d01a
Remove use of any in scripts/source-map.ts
2024-02-12 15:32:42 +00:00
Robert
31ff3577c4
Remove use of any in scripts/add-fields-to-scenarios.ts
2024-02-12 15:32:33 +00:00
Robert
98c96b09ee
Give CachedOperation a type parameter for its args
2024-02-12 15:15:58 +00:00
Robert
f4727fe7b5
Convert CachedOperation callbacks to use Error type
2024-02-12 15:15:58 +00:00
Robert
e943e7fa2e
Convert isTabInputText to use unknown
2024-02-12 15:15:33 +00:00
Robert
6e53f28972
Convert isIOError to use unknown
2024-02-12 15:15:32 +00:00
Robert
3b366a6f51
Convert isErrorLike to use unknown
2024-02-12 15:15:32 +00:00
Shati Patel
c906e76214
Update databases README ( #3340 )
2024-02-12 12:15:37 +00:00
Koen Vlaswinkel
aedc063d1a
Merge pull request #3326 from github/koesie10/add-endpoint-type
...
Add endpoint type to method definition
2024-02-12 12:34:22 +01:00
Charis Kyriakou
ecea102292
Merge pull request #3333 from github/dependabot/npm_and_yarn/extensions/ql-vscode/floating-ui/react-0.26.9
...
Bump @floating-ui/react from 0.26.5 to 0.26.9 in /extensions/ql-vscode
2024-02-09 11:43:03 +00:00
Koen Vlaswinkel
59e20f0fcb
Select option before accepting it
...
In the new version of Floating UI, it corrects that the JSDOM click was
seen as a "mobile" click. Since [`focusItemOnOpen`](https://floating-ui.com/docs/useListNavigation#focusitemonopen )
is set to `auto`, this results in selecting the first option when the
suggest box was opened. Now that JSDOM is correctly detected as a keyboard
input device, it will not select the first option when the suggest box is
opened. The tests have been updated to account for this by always first
selecting the first option before accepting it.
2024-02-09 12:00:53 +01:00
dependabot[bot]
1135f7a7f8
Bump @storybook/addon-a11y from 7.6.9 to 7.6.13 in /extensions/ql-vscode ( #3332 )
...
Bumps [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y ) from 7.6.9 to 7.6.13.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.13/code/addons/a11y )
---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-08 15:58:11 +00:00
Robert
d6bd482c89
Merge pull request #3330 from github/robertbrignull/debug_configuration_makearray
...
Remove use of any and make typing clearer in debugger code
2024-02-08 15:52:10 +00:00
Charis Kyriakou
11e5db9aca
Merge branch 'main' into dependabot/npm_and_yarn/extensions/ql-vscode/floating-ui/react-0.26.9
2024-02-08 15:29:29 +00:00
Koen Vlaswinkel
0b4c611a5f
Add supported endpoint types
2024-02-08 16:27:41 +01:00
dependabot[bot]
39cbe3b373
Bump semver from 7.5.4 to 7.6.0 in /extensions/ql-vscode ( #3335 )
...
Bumps [semver](https://github.com/npm/node-semver ) from 7.5.4 to 7.6.0.
- [Release notes](https://github.com/npm/node-semver/releases )
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md )
- [Commits](https://github.com/npm/node-semver/compare/v7.5.4...v7.6.0 )
---
updated-dependencies:
- dependency-name: semver
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-08 15:26:48 +00:00
dependabot[bot]
d62ac97a7b
Bump prettier from 3.2.4 to 3.2.5 in /extensions/ql-vscode ( #3336 )
...
Bumps [prettier](https://github.com/prettier/prettier ) from 3.2.4 to 3.2.5.
- [Release notes](https://github.com/prettier/prettier/releases )
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/prettier/compare/3.2.4...3.2.5 )
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-08 15:24:08 +00:00
dependabot[bot]
6615c3df84
Bump @floating-ui/react from 0.26.5 to 0.26.9 in /extensions/ql-vscode
...
Bumps [@floating-ui/react](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/react ) from 0.26.5 to 0.26.9.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Changelog](https://github.com/floating-ui/floating-ui/blob/master/packages/react/CHANGELOG.md )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/react@0.26.9/packages/react )
---
updated-dependencies:
- dependency-name: "@floating-ui/react"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-02-08 13:48:25 +00:00
Robert
db5293a142
Convert makeArray to use NotArray
2024-02-08 12:06:20 +00:00
Robert
e93ef98a67
Convert debug-protocol and friends to use unknown instead of any
2024-02-08 12:03:06 +00:00
Robert
bd823b5745
Merge pull request #3329 from github/robertbrignull/asString
...
Use type 'string | Buffer' for process stdout/stderr
2024-02-08 10:56:27 +00:00
Robert
3e716e91c8
Merge pull request #3327 from github/robertbrignull/VsCodeWindow
...
Introduce VsCodeWindow to provide types for the fields we're reading/writing
2024-02-08 10:32:48 +00:00
Robert
58a06191c0
Use type of 'string | Buffer'
2024-02-08 10:26:32 +00:00
Robert
dd74372702
Merge pull request #3328 from github/robertbrignull/ref_types
...
Provide types for all react refs
2024-02-08 10:02:53 +00:00
Koen Vlaswinkel
6fd628b49c
Add endpointType in tests
2024-02-08 11:02:09 +01:00
Robert
4f11f7560b
Introduce VsCodeWindow to provide types for the fields we're reading/writing
2024-02-07 17:35:50 +00:00
Robert
388f4299b0
Introduce asString to call toString() safely on process stdout/stderr
2024-02-07 17:21:32 +00:00
Robert
b577576b00
Add typing to useScrollIntoView ref
2024-02-07 17:20:32 +00:00
Robert
126acc3979
Add typing to RawTableRow ref and friends
2024-02-07 17:20:31 +00:00
Robert
c6e6b5736c
Add typing to AlertTableResultRow ref and friends
2024-02-07 17:20:31 +00:00
Robert
5fe5f70867
Merge pull request #3325 from github/robertbrignull/delete-additional-typings
...
Delete src/additional-typings.d.ts
2024-02-07 17:14:37 +00:00
Koen Vlaswinkel
c9be2ce32c
Add endpoint type to method definition
...
This adds an `endpointType` property to method definitions since we
already have different endpoints (for example methods and modules in
Ruby) and it would be useful to make a distinction between these (it's
not possible to model a module as a source/sink/summary, but it should
be possible to model as a type).
2024-02-07 16:49:40 +01:00
Koen Vlaswinkel
bbfc5d88dd
Merge pull request #3324 from github/koesie10/access-path-suggest-box
...
Extract `AccessPathSuggestBox` component
2024-02-07 16:34:14 +01:00
Shati Patel
b418f479d6
Don't try to parse output of codeql pack add as JSON ( #3323 )
2024-02-07 15:07:55 +00:00
Koen Vlaswinkel
f2eea4025a
Merge pull request #3322 from github/koesie10/suggest-box-command-palette
...
Fix not being able to open command palette in suggest box
2024-02-07 14:36:19 +01:00
Koen Vlaswinkel
fdb4d42bf3
Add comment about returnFocus
2024-02-07 14:22:47 +01:00
Koen Vlaswinkel
688aa304f5
Extract AccessPathSuggestBox component
...
This extracts all common functionality from the various model editor
suggest box components into a single component that can be shared by
the model editor suggest box components to make improvements easier.
2024-02-07 14:00:08 +01:00
Robert
65a84f940d
Delete src/additional-typings.d.ts
2024-02-07 12:50:52 +00:00
Koen Vlaswinkel
b74306249e
Fix not being able to open command palette in suggest box
2024-02-07 13:41:29 +01:00
Shati Patel
57faebd5b9
Minor changelog update ( #3321 )
2024-02-06 16:28:02 +00:00
Koen Vlaswinkel
303e04ba64
Merge pull request #3320 from github/koesie10/access-paths-query-bqrs
...
Parse new access paths query BQRS output
2024-02-06 17:03:02 +01:00
Shati Patel
cc2e28c886
CodeQL model editor: Always show the "Generate" button for Ruby DBs ( #3319 )
2024-02-06 15:27:42 +00:00
Koen Vlaswinkel
c6e7bcd8fa
Merge branch 'main' into koesie10/access-paths-query-bqrs
2024-02-06 16:21:11 +01:00
Koen Vlaswinkel
a03863cd4b
Merge pull request #3317 from github/koesie10/sarif-comparison
...
Fix bug in SARIF comparison
2024-02-06 16:15:35 +01:00
Shati Patel
19d85a73e1
CodeQL model editor: Use suggest box for type path suggestions ( #3316 )
2024-02-06 15:11:56 +00:00
Koen Vlaswinkel
6030137f43
Merge pull request #3318 from github/koesie10/access-paths-configurable-query-constraints
...
Make query constraints for access paths query configurable
2024-02-06 15:38:43 +01:00
Koen Vlaswinkel
11e0f49135
Parse new access paths query BQRS output
2024-02-06 15:09:46 +01:00
Shati Patel
b35d6cbb3a
Don't select a model editor row when you click the suggest box ( #3307 )
2024-02-06 14:01:21 +00:00
Koen Vlaswinkel
0477a9dee3
Make query constraints for access paths query configurable
2024-02-06 14:07:06 +01:00
Koen Vlaswinkel
c5db597676
Add tests for SARIF diff
2024-02-06 13:48:37 +01:00
Koen Vlaswinkel
73b6cc475c
Fix bug in SARIF comparison
...
The SARIF comparison code was comparing the index of the artifact
location, which is not useful for comparison and may differ between runs
of very similar queries. This adds a function to convert a SARIF result
to a canonical form, which removes the index from the artifact location.
2024-02-06 13:40:09 +01:00
Shati Patel
7c233db4eb
CodeQL model editor: Show access path suggestions in the webview ( #3305 )
2024-02-05 14:16:38 +00:00
Koen Vlaswinkel
ad5ae27a0d
Merge pull request #3315 from github/koesie10/nightly-distribution-check
...
Execute a distribution check when changing the CLI channel
2024-02-05 14:36:02 +01:00
Koen Vlaswinkel
e9c7331c29
Execute a distribution check when changing the CLI channel
2024-02-05 13:16:17 +01:00
Charis Kyriakou
bc4d74246a
Stop allowing running MRVA with query outside of workspace ( #3302 )
2024-02-05 11:17:11 +00:00
Koen Vlaswinkel
70171807c7
Merge pull request #3314 from github/koesie10/skip-tab-tests
...
Skip suggest box tests using Tab
2024-02-05 09:41:32 +01:00
Koen Vlaswinkel
490b7fbe70
Merge pull request #3313 from github/github-action/bump-node-version
...
Bump Node version to v18.17.1
2024-02-02 16:30:11 +01:00
Koen Vlaswinkel
d1b81b3f86
Skip suggest box tests using Tab
2024-02-02 15:59:43 +01:00
github-actions[bot]
7f975cc696
Bump Node version to v18.17.1
2024-02-02 12:25:12 +00:00
dependabot[bot]
89ce6cfde9
Bump @storybook/react-webpack5 in /extensions/ql-vscode ( #3311 )
...
Bumps [@storybook/react-webpack5](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-webpack5 ) from 7.6.7 to 7.6.12.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.12/code/frameworks/react-webpack5 )
---
updated-dependencies:
- dependency-name: "@storybook/react-webpack5"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-01 16:06:42 +00:00
dependabot[bot]
3aea6874b5
Bump mini-css-extract-plugin in /extensions/ql-vscode ( #3308 )
...
Bumps [mini-css-extract-plugin](https://github.com/webpack-contrib/mini-css-extract-plugin ) from 2.7.6 to 2.7.7.
- [Release notes](https://github.com/webpack-contrib/mini-css-extract-plugin/releases )
- [Changelog](https://github.com/webpack-contrib/mini-css-extract-plugin/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/mini-css-extract-plugin/compare/v2.7.6...v2.7.7 )
---
updated-dependencies:
- dependency-name: mini-css-extract-plugin
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-01 14:30:43 +00:00
dependabot[bot]
ae173f24f0
Bump @storybook/theming from 7.6.9 to 7.6.12 in /extensions/ql-vscode ( #3309 )
...
Bumps [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/theming ) from 7.6.9 to 7.6.12.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.12/code/lib/theming )
---
updated-dependencies:
- dependency-name: "@storybook/theming"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-01 14:15:49 +00:00
dependabot[bot]
ed2698ff01
Bump css-loader from 6.9.0 to 6.10.0 in /extensions/ql-vscode ( #3310 )
...
Bumps [css-loader](https://github.com/webpack-contrib/css-loader ) from 6.9.0 to 6.10.0.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases )
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v6.9.0...v6.10.0 )
---
updated-dependencies:
- dependency-name: css-loader
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-01 14:15:05 +00:00
dependabot[bot]
7151a498c8
Bump @babel/preset-env from 7.23.7 to 7.23.9 in /extensions/ql-vscode ( #3312 )
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.23.7 to 7.23.9.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.23.9/packages/babel-preset-env )
---
updated-dependencies:
- dependency-name: "@babel/preset-env"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-01 14:14:50 +00:00
Robert
e582e63685
Merge pull request #3299 from github/robertbrignull/releases_tests
...
Use slightly more realistic tests data for ReleasesApiConsumer
2024-02-01 13:00:28 +00:00
Robert
600a5de0e9
Unexport unused type
2024-02-01 12:41:41 +00:00
Koen Vlaswinkel
f24487833e
Merge pull request #3306 from github/koesie10/remove-bundled-ruby-query
...
Remove bundled Ruby queries
2024-02-01 12:45:18 +01:00
Koen Vlaswinkel
4e967d8111
Fix tests when there are no bundled queries
2024-02-01 12:10:46 +01:00
Koen Vlaswinkel
15c3805ad3
Remove bundled Ruby queries
...
This removes the bundled Ruby queries since these queries are in a
CodeQL release now, so we should never find that the queries don't
exist.
2024-02-01 12:01:40 +01:00
Shati Patel
cab963cc88
Send access path suggestions to the model editor view ( #3304 )
2024-02-01 09:49:05 +00:00
Shati Patel
c6c27f4ca3
Add access path suggestions to MaD model for Ruby ( #3303 )
2024-01-31 16:15:41 +00:00
Koen Vlaswinkel
b7ee9f9dd4
Merge pull request #3297 from github/koesie10/more-consistency-information
...
Add more information for consistency check errors
2024-01-31 16:26:45 +01:00
Koen Vlaswinkel
b3284d6760
Merge pull request #3298 from github/koesie10/try-fix-flaky-suggestbox-tab
...
Wait for options to be shown and to be removed when pressing Tab
2024-01-31 16:26:33 +01:00
Koen Vlaswinkel
e9e98403a9
Merge pull request #3301 from github/koesie10/improve-ruby-access-path-parsing
...
Fix Ruby method parsing for methods containing brackets
2024-01-31 16:26:10 +01:00
Charis Kyriakou
74c101bb51
Improve handling of unknown QL pack roots for multi-query MRVAs ( #3289 )
2024-01-31 13:53:07 +00:00
github-actions[bot]
ca8c48418f
Bump version to v1.12.2 ( #3300 )
...
Co-authored-by: github-actions[bot] <github-actions@github.com >
2024-01-31 13:14:58 +00:00
Koen Vlaswinkel
8c72fe0f8d
Fix Ruby method parsing for methods containing brackets
...
This fixes parsing of access paths for Ruby methods that contain square
brackets, such as `Liquid::Context#[]`. The previous implementation
would incorrectly stop capturing at the `]` character, resulting in a
method name of `[` for an access path of `Method[[]].ReturnValue`. This
fixes it by switching to the shared access path parsing code, which
correctly handles square brackets.
2024-01-31 14:07:54 +01:00
Shati Patel
9cd6dafdf4
Functions for running "access path suggestions" queries ( #3294 )
2024-01-31 13:04:08 +00:00
Koen Vlaswinkel
08dfd1a211
Add more information for consistency check errors
2024-01-31 13:59:32 +01:00
Shati Patel
9b07be00c7
v1.12.1 ( #3296 )
2024-01-31 12:52:43 +00:00
Koen Vlaswinkel
820989a8c5
Wait for option to not be present
2024-01-31 13:29:28 +01:00
Robert
9401c34509
Convert "gets correct assets for a release" to use the same example response as the other tests
2024-01-31 11:58:35 +00:00
Robert
750c0973a9
Populate name field in test data
2024-01-31 11:55:56 +00:00
Koen Vlaswinkel
6bd8c8ee78
Wait for options to be shown before pressing Tab
2024-01-31 12:36:09 +01:00
Shati Patel
841efbf826
Add AccessPathSuggestions to "models as data" model ( #3295 )
2024-01-31 10:15:07 +00:00
Shati Patel
8c679ab569
CodeQL model editor: Add functions for parsing complex access path suggestion options ( #3292 )
2024-01-30 16:17:40 +00:00
Robert
0391f972ad
Merge pull request #3287 from github/robertbrignull/move_language_pack
...
Move language and pack to top level of variant analysis object
2024-01-30 15:22:06 +00:00
Koen Vlaswinkel
e3a9c06e3c
Merge pull request #3288 from github/koesie10/suggest-box-tab
...
Allow using Tab to select the active option in the suggest box
2024-01-30 15:47:56 +01:00
Robert
a76dc8f0de
Merge branch 'main' into robertbrignull/move_language_pack
2024-01-30 14:32:53 +00:00
Robert
222d3edaff
Merge pull request #3293 from github/robertbrignull/variant-analysis-history-test-dto
...
Don't compare internal and dto types in variant-analysis-history.test.ts
2024-01-30 14:32:39 +00:00
Robert
31ea6aded7
Change test data so variant analyses have different IDs
2024-01-30 12:39:15 +00:00
Robert
b92e98fce4
Don't compare internal and dto types
2024-01-30 12:13:06 +00:00
Robert
a228dba0ee
Merge branch 'main' into robertbrignull/move_language_pack
2024-01-29 16:34:13 +00:00
Robert
5367bdea9c
Merge pull request #3290 from github/robertbrignull/history-tests-dtos
...
Don't accidentally mix DTO and non-DTO types in query-history-store.test.ts
2024-01-29 16:33:37 +00:00
Koen Vlaswinkel
978e48fe2c
Merge pull request #3259 from github/koesie10/improve-error-message
...
Improve CLI error messages
2024-01-29 17:29:51 +01:00
Robert
98764a156a
Introduce writeRawQueryHistory to ensure we're always writing Dto types
2024-01-29 15:53:39 +00:00
Robert
a85989e202
Change let to const where possible
2024-01-29 15:52:55 +00:00
Koen Vlaswinkel
8c696e10af
Allow using Tab to select the active option
2024-01-29 14:53:36 +01:00
Koen Vlaswinkel
dc8062b784
Merge pull request #3242 from github/koesie10/suggest-box-open-key
...
Open suggest box with Ctrl + Space
2024-01-29 14:49:23 +01:00
Koen Vlaswinkel
ac5ed7b30c
Merge remote-tracking branch 'origin/main' into koesie10/improve-error-message
2024-01-29 14:47:36 +01:00
Koen Vlaswinkel
c5e9ef15f2
Fix order of args and stderr in error message
2024-01-29 14:46:52 +01:00
Robert
e70b083828
Move language and pack to top level of variant analysis object
2024-01-29 12:11:22 +00:00
Charis Kyriakou
1b84906bce
Add basic multi-query support to MRVA results view header ( #3286 )
2024-01-29 12:00:39 +00:00
Nora
1f24cd1a7f
Merge pull request #3275 from github/nora/add-eslint-deprecation
...
Start using eslint-plugin-deprecation to find deprecated code
2024-01-26 11:46:12 +01:00
Nora
e126dfbe36
Remove 0 for parseInt
2024-01-25 16:19:31 +00:00
Charis Kyriakou
0e2c03f572
Rename queryPackDir -> targetPackPath ( #3284 )
2024-01-25 15:44:25 +00:00
Henry Mercer
95b082d56a
Merge pull request #3283 from github/github-action/bump-cli
...
Bump CLI Version to v2.16.1 for integration tests
2024-01-25 15:28:04 +00:00
github-actions[bot]
56dd102db8
Bump CLI version from v2.16.0 to v2.16.1 for integration tests
2024-01-25 14:06:36 +00:00
dependabot[bot]
f5b6b4a9f2
Bump zip-a-folder from 3.1.5 to 3.1.6 in /extensions/ql-vscode ( #3282 )
...
Bumps [zip-a-folder](https://github.com/maugenst/zip-a-folder ) from 3.1.5 to 3.1.6.
- [Commits](https://github.com/maugenst/zip-a-folder/commits )
---
updated-dependencies:
- dependency-name: zip-a-folder
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-25 13:35:57 +00:00
dependabot[bot]
5fc88bed32
Bump @types/react-dom from 18.2.17 to 18.2.18 in /extensions/ql-vscode ( #3280 )
...
Bumps [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom ) from 18.2.17 to 18.2.18.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom )
---
updated-dependencies:
- dependency-name: "@types/react-dom"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-25 13:35:24 +00:00
dependabot[bot]
05e5e32854
Bump markdownlint-cli2 from 0.11.0 to 0.12.1 in /extensions/ql-vscode ( #3279 )
...
Bumps [markdownlint-cli2](https://github.com/DavidAnson/markdownlint-cli2 ) from 0.11.0 to 0.12.1.
- [Changelog](https://github.com/DavidAnson/markdownlint-cli2/blob/main/CHANGELOG.md )
- [Commits](https://github.com/DavidAnson/markdownlint-cli2/compare/v0.11.0...v0.12.1 )
---
updated-dependencies:
- dependency-name: markdownlint-cli2
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-25 13:35:08 +00:00
dependabot[bot]
554d8854a1
Bump styled-components from 6.1.1 to 6.1.8 in /extensions/ql-vscode ( #3281 )
...
Bumps [styled-components](https://github.com/styled-components/styled-components ) from 6.1.1 to 6.1.8.
- [Release notes](https://github.com/styled-components/styled-components/releases )
- [Commits](https://github.com/styled-components/styled-components/compare/v6.1.1...v6.1.8 )
---
updated-dependencies:
- dependency-name: styled-components
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-25 13:34:25 +00:00
dependabot[bot]
c9cb7eaa38
Bump storybook from 7.6.7 to 7.6.10 in /extensions/ql-vscode ( #3278 )
...
Bumps [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli ) from 7.6.7 to 7.6.10.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.10/code/lib/cli )
---
updated-dependencies:
- dependency-name: storybook
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-25 13:33:34 +00:00
Nora
70461d857c
Use nanoid
2024-01-25 13:17:12 +00:00
Charis Kyriakou
e1ff113701
Fix version used in multi-query pack create constraint ( #3277 )
2024-01-25 12:40:23 +00:00
Charis Kyriakou
2f66be3fcc
Tidy up uses of QueryPackDetail object fields ( #3276 )
2024-01-25 11:01:11 +00:00
Nora
12a3af0a75
Make random number bigger than 1000
2024-01-25 09:47:19 +00:00
Charis Kyriakou
594f422510
Add support for running multiple queries in MRVA ( #3274 )
2024-01-25 09:12:50 +00:00
Nora
d5932fc1de
Use storybook type
2024-01-25 08:25:33 +00:00
Nora
8397f58d0b
Disable rule for storybook types
2024-01-24 17:27:52 +00:00
Nora
dd9ca80820
Solution for unique numbers
2024-01-24 17:20:05 +00:00
Nora
deab3e6175
Update simple deprecations
2024-01-24 16:53:47 +00:00
Nora
a3f9518b78
Set up deprecation plugin
2024-01-24 16:45:02 +00:00
Charis Kyriakou
79fd44f696
Add run-remote-query.ts to CLI tests workflow triggers ( #3272 )
2024-01-24 12:27:25 +00:00
Robert
69ff7cb0e8
Merge pull request #3273 from github/robertbrignull/uri_fspath
...
Use Uri to convert paths to platform specific fs paths
2024-01-24 12:11:12 +00:00
Nora
3daefcdffc
Merge pull request #3215 from github/nora/add-e2e-tests
...
E2E test prototype
2024-01-24 12:59:50 +01:00
Nora
a6f7ee3df8
Remove scheduled runs
2024-01-24 11:35:12 +00:00
Robert
92c4532cc2
Use Uri to convert paths to platform specific fs paths
2024-01-24 11:23:54 +00:00
Charis Kyriakou
0265befb26
Move query language to the QlPackDetails ( #3270 )
2024-01-23 16:13:06 +00:00
Charis Kyriakou
aada35187f
Move QL pack file path to the QlPackDetails ( #3269 )
2024-01-23 14:54:42 +00:00
Charis Kyriakou
e612764c59
Move findPackRoot to ql.ts ( #3268 )
2024-01-23 13:29:46 +00:00
Shati Patel
e834d32a29
Add new feature flag for "access path suggestions" ( #3266 )
2024-01-23 12:04:22 +00:00
Charis Kyriakou
67e2ff3d4e
Move QL pack root path to the QlPackDetails ( #3267 )
2024-01-23 12:00:09 +00:00
Charis Kyriakou
9285b0272d
Push QL pack details creation to commands ( #3262 )
2024-01-23 10:17:13 +00:00
Dave Bartolomeo
445aa81f5a
Merge pull request #3263 from github/dbartol/extensible-failure
2024-01-22 13:29:35 -05:00
Dave Bartolomeo
2cd1a99273
Fix another missing await
2024-01-22 13:08:39 -05:00
Dave Bartolomeo
b6bf683852
Fix PR feedback
2024-01-22 12:50:58 -05:00
Charis Kyriakou
5bb724b5be
Rename getQlPackPath to getQlPackFilePath ( #3265 )
2024-01-22 16:49:42 +00:00
Shati Patel
5664844aba
CodeQL model editor: Don't highlight row when clicking inside text box ( #3264 )
2024-01-22 16:29:24 +00:00
Charis Kyriakou
9644e5daee
Stop variant analysis from published pack if no language selected ( #3261 )
2024-01-22 15:59:50 +00:00
Dave Bartolomeo
d7f01dcb29
Add missing await
2024-01-22 10:37:22 -05:00
Dave Bartolomeo
509e273108
Fix MRVA integration test failure
2024-01-22 10:21:35 -05:00
Nora
5c513bc821
Add note to readme
2024-01-22 14:15:27 +00:00
Nora
342dbfb5a9
Silence output
2024-01-22 14:05:57 +00:00
Charis Kyriakou
28aadb183b
Use object for pack generation details ( #3260 )
2024-01-22 13:59:41 +00:00
Nora
6bf73dc196
Fix typo
2024-01-22 13:07:21 +00:00
Shati Patel
83148f6d57
Add test for "promptForDatabase" ( #3248 )
2024-01-22 11:09:12 +00:00
Nora
988a113cb3
Shorten playwright config
2024-01-19 17:42:41 +00:00
Nora
5136c95da7
Run E2E every night of the week, on merge to main and push to main
2024-01-19 17:38:18 +00:00
Nora
6741f0c431
Merge branch 'main' into nora/add-e2e-tests
2024-01-19 18:32:37 +01:00
Koen Vlaswinkel
ebf06b9af6
Update CHANGELOG
2024-01-19 12:28:04 +01:00
Koen Vlaswinkel
a85a4b41f5
Improve CLI error messages
2024-01-19 12:07:42 +01:00
Nora
8690f76968
Merge pull request #3255 from github/dependabot/npm_and_yarn/extensions/ql-vscode/prettier-3.2.4
...
Bump prettier from 3.1.1 to 3.2.4 in /extensions/ql-vscode
2024-01-19 11:40:30 +01:00
Nora
fc41360bad
Check in npm run format
2024-01-19 10:15:00 +00:00
dependabot[bot]
a2ebc69d3a
Bump prettier from 3.1.1 to 3.2.4 in /extensions/ql-vscode
...
Bumps [prettier](https://github.com/prettier/prettier ) from 3.1.1 to 3.2.4.
- [Release notes](https://github.com/prettier/prettier/releases )
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/prettier/compare/3.1.1...3.2.4 )
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-01-18 20:58:32 +00:00
dependabot[bot]
f1a915e46c
Bump css-loader from 6.8.1 to 6.9.0 in /extensions/ql-vscode ( #3256 )
...
Bumps [css-loader](https://github.com/webpack-contrib/css-loader ) from 6.8.1 to 6.9.0.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases )
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v6.8.1...v6.9.0 )
---
updated-dependencies:
- dependency-name: css-loader
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-18 12:56:46 -08:00
Nora
2d1663d046
Merge pull request #3253 from github/dependabot/npm_and_yarn/extensions/ql-vscode/typescript-eslint/eslint-plugin-6.19.0
...
Bump @typescript-eslint/eslint-plugin from 6.18.0 to 6.19.0 in /extensions/ql-vscode
2024-01-18 16:11:27 +01:00
Nora
66be432610
Merge pull request #3254 from github/dependabot/npm_and_yarn/extensions/ql-vscode/storybook/addon-a11y-7.6.9
...
Bump @storybook/addon-a11y from 7.6.4 to 7.6.9 in /extensions/ql-vscode
2024-01-18 16:10:52 +01:00
Nora
4ae4745a86
Merge pull request #3257 from github/dependabot/npm_and_yarn/extensions/ql-vscode/storybook/theming-7.6.9
...
Bump @storybook/theming from 7.6.7 to 7.6.9 in /extensions/ql-vscode
2024-01-18 16:10:14 +01:00
Dave Bartolomeo
fef394b79d
Merge pull request #3233 from github/dbartol/mrva-multi-bundle
...
Use CLI to bundle packs for MRVA
2024-01-18 09:10:21 -05:00
dependabot[bot]
ccfba04d97
Bump @storybook/theming from 7.6.7 to 7.6.9 in /extensions/ql-vscode
...
Bumps [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/theming ) from 7.6.7 to 7.6.9.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.9/code/lib/theming )
---
updated-dependencies:
- dependency-name: "@storybook/theming"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-01-18 13:49:17 +00:00
dependabot[bot]
c89382ceb7
Bump @storybook/addon-a11y from 7.6.4 to 7.6.9 in /extensions/ql-vscode
...
Bumps [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y ) from 7.6.4 to 7.6.9.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.9/code/addons/a11y )
---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-01-18 13:48:04 +00:00
dependabot[bot]
8beaa7cbc0
Bump @typescript-eslint/eslint-plugin in /extensions/ql-vscode
...
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin ) from 6.18.0 to 6.19.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases )
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md )
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.19.0/packages/eslint-plugin )
---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-01-18 13:47:43 +00:00
Nora
477c6b3819
Merge pull request #3252 from github/dependabot/github_actions/actions/dependency-review-action-4
...
Bump actions/dependency-review-action from 3 to 4
2024-01-18 14:43:21 +01:00
dependabot[bot]
978e00a252
Bump actions/dependency-review-action from 3 to 4
...
Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action ) from 3 to 4.
- [Release notes](https://github.com/actions/dependency-review-action/releases )
- [Commits](https://github.com/actions/dependency-review-action/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: actions/dependency-review-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-01-18 13:28:48 +00:00
Koen Vlaswinkel
5c132884a4
Merge remote-tracking branch 'origin/main' into koesie10/suggest-box-open-key
2024-01-18 10:25:26 +01:00
Koen Vlaswinkel
8e1fc2ca96
Merge pull request #3247 from github/koesie10/suggest-box-diagnostics
...
Add diagnostics to suggest box
2024-01-18 10:24:37 +01:00
Koen Vlaswinkel
d6e4b7ef56
Merge remote-tracking branch 'origin/main' into koesie10/suggest-box-diagnostics
2024-01-18 10:04:52 +01:00
Koen Vlaswinkel
4e81d41086
Add comment about Storybook test diagnostics
2024-01-18 10:03:45 +01:00
Koen Vlaswinkel
ac5038cf50
Merge pull request #3244 from github/koesie10/suggest-box-highlight
...
Add highlighting to items in suggest box
2024-01-18 10:02:17 +01:00
Dave Bartolomeo
d7e5552481
Fix broken test code
2024-01-17 17:48:44 -05:00
Dave Bartolomeo
65fbb6bca8
Fix PR feedback
2024-01-17 14:20:14 -05:00
Dave Bartolomeo
1d275985d0
Fix PR feedback
2024-01-17 12:49:20 -05:00
Dave Bartolomeo
55306c9a93
Fix PR feedback
2024-01-17 12:47:06 -05:00
Robert
ec6a725715
Merge pull request #3251 from github/robertbrignull/test_published_pack
...
Add an integration test of runVariantAnalysisFromPublishedPack
2024-01-17 16:15:23 +00:00
Robert
6b1a056ae6
Avoid using path separator in test data
2024-01-17 15:51:27 +00:00
Koen Vlaswinkel
75065f3148
Merge pull request #3230 from github/koesie10/suggest-box
...
Create `SuggestBox` component
2024-01-17 15:56:51 +01:00
Robert
1010239c29
Add a test of runVariantAnalysisFromPublishedPack
2024-01-17 14:31:06 +00:00
Koen Vlaswinkel
2b6ec73147
Merge pull request #3250 from github/koesie10/rename-ide-server
...
Remove outdated IDE server name in favor of language client
2024-01-17 15:08:25 +01:00
Charis Kyriakou
97980371c8
Skip multi-query MRVAs from query history ( #3249 )
2024-01-17 13:52:03 +00:00
Koen Vlaswinkel
479aa683ee
Rename IDE server to language client
2024-01-17 11:40:00 +01:00
Koen Vlaswinkel
1cb46d2604
Rename ide-server.ts to language-client.ts
2024-01-17 11:37:07 +01:00
Shati Patel
be22964113
Send telemetry for addDatabaseSourceToWorkspace setting ( #3238 )
2024-01-16 17:05:59 +00:00
Robert
db3550a18c
Merge pull request #3245 from github/robertbrignull/multi-query-published-pack
...
Add prototype implementation for codeQL.runVariantAnalysisPublishedPack
2024-01-16 16:54:04 +00:00
Robert
91a96da2ad
Start progress bar earlier
2024-01-16 16:39:30 +00:00
Robert
9dc37ebf33
Return when we detect no queries
2024-01-16 16:33:16 +00:00
Robert
ff8def3e7d
Use join instead of slash
2024-01-16 16:32:09 +00:00
Koen Vlaswinkel
39c17291aa
Add diagnostics to suggest box
...
This adds the ability for consumers of the suggest box to add
diagnostics to the suggest box. When a diagnostic is returned for a
value, the input will be shown with a red border.
2024-01-16 16:56:32 +01:00
Nora
a6a7a5c5cb
Merge pull request #3246 from github/nora/remove-deprecated-jest-syntax
...
Remove deprecated jest syntac
2024-01-16 16:44:09 +01:00
Nora
70ce93cbb3
Replace toBeCalledTimes
2024-01-16 15:28:51 +00:00
Nora
abc71b5102
Replace toBeCalledWith
2024-01-16 15:28:07 +00:00
Nora
fed110f65f
Replace toBeCalled
2024-01-16 15:26:41 +00:00
Robert
174a38a16a
Make placeholder text more general
2024-01-16 15:11:38 +00:00
Robert
b4250218d5
Implement the command to download a published pack
2024-01-16 15:11:38 +00:00
github-actions[bot]
5948008c99
Bump CLI version from v2.15.5 to v2.16.0 for integration tests ( #3243 )
...
Co-authored-by: github-actions[bot] <github-actions@github.com >
2024-01-16 15:09:30 +00:00
Koen Vlaswinkel
070f0ca9b7
Add highlighting to items in suggest box
...
This adds highlighting of the currently typed text into the shown items
of the suggest box.
2024-01-16 16:05:51 +01:00
Charis Kyriakou
318136f5e5
Allow multiple file URIs to be passed into prepareRemoteQueryRun ( #3241 )
2024-01-16 15:05:24 +00:00
Koen Vlaswinkel
a3ade9984d
Make mocking helpers independent of vscode
2024-01-16 15:39:14 +01:00
Koen Vlaswinkel
4429385dfd
Open suggest box with Ctrl + Space
...
This adds a keyboard shortcut to open the suggest box when it's closed.
This matches the behavior in VS Code itself.
2024-01-16 14:24:09 +01:00
Shati Patel
f993258a27
CodeQL model editor: Make Type a selectable model kind for Ruby ( #3224 )
2024-01-16 13:17:26 +00:00
Shati Patel
c5517e0aea
CodeQL model editor: Add support for free text input in type models ( #3217 )
2024-01-16 13:03:53 +00:00
Charis Kyriakou
8c0a8e07b2
Tidy up variant analysis commands ( #3240 )
2024-01-16 12:19:37 +00:00
Robert
a1572463a6
Merge pull request #3239 from github/robertbrignull/multi-query-commands
...
Add stubs of commands for multi-query support
2024-01-16 10:24:29 +00:00
Koen Vlaswinkel
545902843d
Merge pull request #3222 from github/koesie10/suggest-box-helper-functions
...
Add helper functions for suggestion box
2024-01-16 09:35:12 +01:00
Robert
1a7981a22d
Add codeQL.runVariantAnalysisPublishedPack command
2024-01-15 17:08:18 +00:00
Robert
1bc560518f
Add codeQL.runVariantAnalysisContextExplorer command
2024-01-15 17:07:41 +00:00
Shati Patel
281f8eeb7a
CodeQL model editor: support saving single/selected models ( #3156 )
2024-01-15 16:51:46 +00:00
Dave Bartolomeo
f53826c09d
Better dependency version assertions
2024-01-14 10:20:55 -05:00
Dave Bartolomeo
b16aeb3887
Fix property name, and expand another path
2024-01-14 10:17:35 -05:00
Dave Bartolomeo
ee73639720
Expand short paths before calling codeql pack bundle
2024-01-13 14:30:01 -05:00
Dave Bartolomeo
9d2190a88d
Add text if pack is empty
2024-01-12 13:03:21 -05:00
Dave Bartolomeo
6d308f8688
Add missing change
2024-01-12 12:44:16 -05:00
Dave Bartolomeo
61933c34d5
Dump pack contents when expected file not found
2024-01-12 12:41:36 -05:00
Dave Bartolomeo
e03c2b132c
Custom message for assertions about files existing in packs
2024-01-12 10:42:34 -05:00
Dave Bartolomeo
9c42c6a851
Allow CodeQL checkout to be named ql
...
This makes it easier for cross-repo development with `semmle-code`, where the `codeql` repo is in a submodule in a directory named `ql`.
2024-01-12 09:30:13 -05:00
Nora
283d0070f7
Ignore playwright config on dead code
2024-01-12 14:05:51 +00:00
Nora
d3c7241854
fix new config location in workflow
2024-01-12 13:52:39 +00:00
Nora
0b9e4e33b2
move config and fix tsconfig error
2024-01-12 13:36:11 +00:00
Nora
b4a66a7690
Update readme
2024-01-12 13:35:51 +00:00
Koen Vlaswinkel
ea1419add2
Merge pull request #3234 from github/koesie10/remove-jest-runner-installed-extensions
...
Simplify custom Jest test runner
2024-01-12 11:26:18 +01:00
Koen Vlaswinkel
0534cb7514
Simplify custom Jest test runner
...
The custom Jest test runner was originally written to install the
required extensions for the CLI integration tests. This is no longer
necessary as of https://github.com/github/vscode-codeql/pull/3232 , so
we can remove all code that deals with downloading VS Code and
installing extensions. The download of VS Code will now be handled by
the base `VSCodeTestRunner`.
2024-01-12 09:49:20 +01:00
Dave Bartolomeo
2aacea4176
Fix test expectation
2024-01-11 18:58:44 -05:00
Dave Bartolomeo
2ccd99fc5b
Don't use ${workspace} in test pack
2024-01-11 18:40:03 -05:00
Dave Bartolomeo
bdc94a3b23
Remove unused export
2024-01-11 18:05:00 -05:00
Dave Bartolomeo
29d8c65b59
Use codeql pack create --mrva if available
2024-01-11 17:43:42 -05:00
Dave Bartolomeo
fb63ec7db0
Consume codeql version JSON output for feature capabilities
2024-01-11 21:59:54 +00:00
Dave Bartolomeo
b67efeeacd
Merge pull request #3232 from github/dbartol/new-test-api
...
Switch to built-in VS Code test UI unconditionally
2024-01-11 16:48:56 -05:00
Dave Bartolomeo
4b3a008a45
Merge branch 'main' into dbartol/new-test-api
2024-01-11 12:22:18 -05:00
Dave Bartolomeo
1186026315
Remove old unit tests
2024-01-11 11:56:51 -05:00
Dave Bartolomeo
2ba23ceead
Fold TestManagerBase and related functions into TestManager
2024-01-11 11:48:54 -05:00
dependabot[bot]
c065c44ff3
Bump applicationinsights from 2.9.1 to 2.9.2 in /extensions/ql-vscode ( #3228 )
...
Bumps [applicationinsights](https://github.com/microsoft/ApplicationInsights-node.js ) from 2.9.1 to 2.9.2.
- [Release notes](https://github.com/microsoft/ApplicationInsights-node.js/releases )
- [Commits](https://github.com/microsoft/ApplicationInsights-node.js/compare/2.9.1...2.9.2 )
---
updated-dependencies:
- dependency-name: applicationinsights
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-11 08:44:11 -08:00
dependabot[bot]
0d2b7916ee
Bump msw from 2.0.11 to 2.0.13 in /extensions/ql-vscode ( #3227 )
...
Bumps [msw](https://github.com/mswjs/msw ) from 2.0.11 to 2.0.13.
- [Release notes](https://github.com/mswjs/msw/releases )
- [Changelog](https://github.com/mswjs/msw/blob/main/CHANGELOG.md )
- [Commits](https://github.com/mswjs/msw/compare/v2.0.11...v2.0.13 )
---
updated-dependencies:
- dependency-name: msw
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-11 08:43:49 -08:00
dependabot[bot]
766f54b76e
Bump @storybook/manager-api from 7.6.6 to 7.6.7 in /extensions/ql-vscode ( #3226 )
...
Bumps [@storybook/manager-api](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/manager-api ) from 7.6.6 to 7.6.7.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.7/code/lib/manager-api )
---
updated-dependencies:
- dependency-name: "@storybook/manager-api"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-11 08:43:22 -08:00
dependabot[bot]
c485e39b07
Bump @testing-library/dom from 9.3.3 to 9.3.4 in /extensions/ql-vscode ( #3225 )
...
Bumps [@testing-library/dom](https://github.com/testing-library/dom-testing-library ) from 9.3.3 to 9.3.4.
- [Release notes](https://github.com/testing-library/dom-testing-library/releases )
- [Changelog](https://github.com/testing-library/dom-testing-library/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/dom-testing-library/compare/v9.3.3...v9.3.4 )
---
updated-dependencies:
- dependency-name: "@testing-library/dom"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-11 08:42:57 -08:00
Dave Bartolomeo
d8968db1b9
Changelog entry
2024-01-11 11:34:35 -05:00
Charis Kyriakou
40ba2c03d3
Rename variant analysis mapping functions ( #3231 )
2024-01-11 16:11:01 +00:00
Dave Bartolomeo
ac93074f94
Merge remote-tracking branch 'origin/main' into dbartol/new-test-api
2024-01-11 15:48:17 +00:00
Dave Bartolomeo
1dc6111fba
Switch to built-in VS Code test UI unconditionally
2024-01-11 10:47:48 -05:00
Nora
f9166f304b
Merge pull request #3229 from github/dependabot/npm_and_yarn/extensions/ql-vscode/eslint-plugin-prettier-5.1.3
...
Bump eslint-plugin-prettier from 5.0.1 to 5.1.3 in /extensions/ql-vscode
2024-01-11 15:55:26 +01:00
Koen Vlaswinkel
6ec727a8a2
Add tests for SuggestBox component
2024-01-11 15:28:21 +01:00
dependabot[bot]
b4da6c71f3
Bump eslint-plugin-prettier from 5.0.1 to 5.1.3 in /extensions/ql-vscode
...
Bumps [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier ) from 5.0.1 to 5.1.3.
- [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases )
- [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md )
- [Commits](https://github.com/prettier/eslint-plugin-prettier/compare/v5.0.1...v5.1.3 )
---
updated-dependencies:
- dependency-name: eslint-plugin-prettier
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-01-11 13:58:28 +00:00
Nora
f43c5274cf
Merge pull request #3223 from github/version/bump-to-v1.12.1
...
Bump version to v1.12.1
2024-01-11 14:37:52 +01:00
Nora
1a135c501d
Move changelog entry to correct section
2024-01-11 13:23:00 +00:00
Koen Vlaswinkel
0df0cca9d8
Create SuggestBox component
2024-01-11 14:13:02 +01:00
Koen Vlaswinkel
519833e7a4
Merge pull request #3218 from github/koesie10/parse-access-paths
...
Add functions for parsing and validating access paths
2024-01-11 13:34:01 +01:00
github-actions[bot]
d77261aaa5
Bump version to v1.12.1
2024-01-11 12:25:03 +00:00
Nora
24dff5981e
Merge pull request #3221 from github/v1.12.0
...
v1.12.0
2024-01-11 13:23:32 +01:00
Koen Vlaswinkel
7f730d24b0
Add helper functions for suggestion box
...
This adds some helper functions that will be used for a suggestion box
in the future. There is one helper function for highlighting part of a
text case-insensitively. Another helper function will try to find
followup options based on a list of tokens.
The tests for these functions use access paths as input, but these
functions are not intended to be specific to access paths. They can be
used for any list of options/string.
2024-01-11 12:09:13 +01:00
Nora
8834111f57
Update changelog release date
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2024-01-11 10:08:16 +00:00
Nora
3d5ef60fe0
Update extensions/ql-vscode/CHANGELOG.md
...
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com >
2024-01-11 10:50:11 +01:00
Nora
6ab1f4c7ee
v1.12.0
2024-01-11 09:48:17 +00:00
Shati Patel
77f84c6ca9
Improve user experience when no database is selected ( #3214 )
2024-01-11 09:41:44 +00:00
Koen Vlaswinkel
d0a12753d8
Merge pull request #3216 from github/koesie10/move-ruby-access-paths
...
Move Ruby access paths functions to separate file
2024-01-11 09:49:48 +01:00
Koen Vlaswinkel
ea6e148df9
Add functions for parsing and validating access paths
...
This adds functions for parsing and validating access paths to prepare
for future functionality where we're going to be parsing and validating
access paths.
2024-01-10 16:20:13 +01:00
Koen Vlaswinkel
ac745a6955
Move Ruby access paths functions
2024-01-10 15:54:17 +01:00
Nora
d022623a9d
fix artifacts path
2024-01-10 10:42:40 +00:00
Nora
c7a1cf7236
Add test, config and action
2024-01-10 10:01:59 +00:00
Shati Patel
1b737678ba
Update broken badge in README ( #3213 )
2024-01-09 14:09:50 +00:00
Koen Vlaswinkel
19b24f87ec
Merge pull request #3212 from github/koesie10/eslint-rules
...
Remove more ESLint rule overrides
2024-01-09 11:31:10 +01:00
Koen Vlaswinkel
38743c6180
wip: move CLI installation
2024-01-09 10:56:22 +01:00
Koen Vlaswinkel
d1a26d3893
wip: add Docker Compose configuration for code server
2024-01-09 10:41:38 +01:00
Koen Vlaswinkel
b2bdcdbcb8
Merge pull request #3210 from github/koesie10/no-cycle
...
Remove all dependency cycles
2024-01-09 09:31:31 +01:00
dependabot[bot]
37c3b03e9a
Bump @typescript-eslint/eslint-plugin in /extensions/ql-vscode ( #3209 )
...
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin ) from 6.16.0 to 6.18.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases )
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md )
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.18.0/packages/eslint-plugin )
---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-08 08:49:31 -08:00
Koen Vlaswinkel
c7c79175d2
Remove non-existent filenames/match-regexp ESLint rule
2024-01-08 16:54:07 +01:00
Koen Vlaswinkel
01e7b3fc0e
Remove camelcase ESLint rule override
2024-01-08 16:52:03 +01:00
Koen Vlaswinkel
58ea742e85
Enable func-style ESLint rule
2024-01-08 16:47:28 +01:00
Koen Vlaswinkel
188bc53761
Enable no-useless-escape ESLint rule
...
These fixes maintain the current functionality and do not make any
changes to the matching of the regular expressions.
2024-01-08 16:44:41 +01:00
Koen Vlaswinkel
26e619ba71
Enable no-fallthrough ESLint rule
2024-01-08 16:40:45 +01:00
Koen Vlaswinkel
00707fca4b
Merge pull request #3211 from github/koesie10/remove-disabled-eslint-rules
...
Remove disabled ESLint rules without linting errors
2024-01-08 16:17:30 +01:00
Koen Vlaswinkel
51627ad971
Remove disabled ESLint rules without linting errors
...
This removes some ESLint rules that do not give any linting errors when
removing the rule overrides from the config file. This could be because
there are no instances of the rule being violated, or because the rule
is already disabled by some other configuration.
2024-01-08 15:04:55 +01:00
Koen Vlaswinkel
f21ee5173c
Enable import/no-cycle ESLint rule
2024-01-08 13:49:26 +01:00
Koen Vlaswinkel
397693a2cb
Remove import cycle for results view
2024-01-08 13:49:26 +01:00
Koen Vlaswinkel
0648ce8ae6
Remove import cycle for query history dto mappers
2024-01-08 13:49:26 +01:00
Koen Vlaswinkel
183de7b6a1
Remove import cycle for query history domain mappers
2024-01-08 13:49:26 +01:00
Koen Vlaswinkel
b6f32ec5d7
Remove import cycle for model editor queries
2024-01-08 13:49:26 +01:00
Koen Vlaswinkel
70c2beb510
Remove import cycle for distribution manager
2024-01-08 13:49:25 +01:00
Koen Vlaswinkel
31c90a5068
Remove import cycle for CLI server
2024-01-08 13:37:21 +01:00
Koen Vlaswinkel
2ce6fd3bb1
Merge pull request #3203 from github/koesie10/consistent-type-imports
...
Enforce consistent type imports
2024-01-08 13:27:42 +01:00
Koen Vlaswinkel
da5852cfbb
Merge pull request #3185 from github/koesie10/node-version-action
...
Add GitHub Actions workflow for updating Node version
2024-01-08 13:07:35 +01:00
Koen Vlaswinkel
5c83c94335
Merge pull request #3202 from github/koesie10/missing-promise-await
...
Fix missing `await` in `prepareModelEditorQueries`
2024-01-08 10:00:02 +01:00
Koen Vlaswinkel
21faed0191
Enforce consistent type specifiers
2024-01-05 17:15:58 +01:00
Koen Vlaswinkel
9d6962ede2
Enforce consistent type imports
2024-01-05 17:13:45 +01:00
Koen Vlaswinkel
d6d5d27d70
Fix missing await in prepareModelEditorQueries
...
This fixes a missing `await` in `prepareModelEditorQueries` that caused
the function to potentially return before the query files were written.
2024-01-05 16:31:07 +01:00
Koen Vlaswinkel
5c7efe5116
Merge pull request #3200 from github/koesie10/remove-namespace-imports
...
Remove unnecessary namespace imports
2024-01-05 14:53:29 +01:00
Nora
1d42d4848b
Merge pull request #3189 from github/nora/make-model-editor-open-cancellable
...
CodeQL model editor: user should be able to stop modeling before the main editor view is open
2024-01-05 13:50:08 +01:00
Nora
745544cd9c
Use error type and error code
2024-01-05 12:37:44 +00:00
Koen Vlaswinkel
38a3778fe1
Fix Storybook React runtime
2024-01-05 11:09:53 +01:00
Koen Vlaswinkel
50df8cd376
Remove dead code
...
After removing all namespace imports, the dead code detection is now
more accurate, so we can remove some more dead code.
2024-01-05 10:42:39 +01:00
Koen Vlaswinkel
034bfc230c
Remove unnecessary namespace imports
...
This removes all unnecessary namespace imports. The only namespace
imports that are left are those that are needed for spying on functions
in tests.
2024-01-05 10:42:36 +01:00
Koen Vlaswinkel
d342b060ed
Merge pull request #3187 from github/koesie10/update-vscode-version-docs
...
Update outdated VS Code version docs
2024-01-05 09:49:42 +01:00
Koen Vlaswinkel
45fe4aa1d4
Merge pull request #3186 from github/koesie10/generate-chromium-version
...
Rename update Chromium version script to generate Chromium version
2024-01-05 09:49:34 +01:00
dependabot[bot]
902074f7a5
Bump msw from 2.0.10 to 2.0.11 in /extensions/ql-vscode ( #3198 )
...
Bumps [msw](https://github.com/mswjs/msw ) from 2.0.10 to 2.0.11.
- [Release notes](https://github.com/mswjs/msw/releases )
- [Changelog](https://github.com/mswjs/msw/blob/main/CHANGELOG.md )
- [Commits](https://github.com/mswjs/msw/compare/v2.0.10...v2.0.11 )
---
updated-dependencies:
- dependency-name: msw
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-04 10:34:59 -08:00
dependabot[bot]
fd8f88890e
Bump @babel/preset-env from 7.23.6 to 7.23.7 in /extensions/ql-vscode ( #3196 )
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.23.6 to 7.23.7.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.23.7/packages/babel-preset-env )
---
updated-dependencies:
- dependency-name: "@babel/preset-env"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-04 10:34:14 -08:00
dependabot[bot]
db842dea7c
Bump @testing-library/jest-dom in /extensions/ql-vscode ( #3195 )
...
Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom ) from 6.1.6 to 6.2.0.
- [Release notes](https://github.com/testing-library/jest-dom/releases )
- [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/jest-dom/compare/v6.1.6...v6.2.0 )
---
updated-dependencies:
- dependency-name: "@testing-library/jest-dom"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-04 10:33:44 -08:00
Nora
eb59ead817
Catch request cancelled error
2024-01-04 15:19:10 +00:00
Nora
d0e81124ac
Merge pull request #3199 from github/dependabot/npm_and_yarn/extensions/ql-vscode/types/tmp-0.2.6
...
Bump @types/tmp from 0.1.0 to 0.2.6 in /extensions/ql-vscode
2024-01-04 15:00:05 +01:00
dependabot[bot]
8697dcc80d
Bump @types/tmp from 0.1.0 to 0.2.6 in /extensions/ql-vscode
...
Bumps [@types/tmp](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/tmp ) from 0.1.0 to 0.2.6.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/tmp )
---
updated-dependencies:
- dependency-name: "@types/tmp"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-01-04 13:45:03 +00:00
Nora
ad8dc1e906
Update Changelog
2024-01-04 10:52:42 +00:00
dependabot[bot]
ceb8b1f9c1
Bump storybook from 7.6.6 to 7.6.7 in /extensions/ql-vscode ( #3194 )
...
Bumps [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli ) from 7.6.6 to 7.6.7.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.7/code/lib/cli )
---
updated-dependencies:
- dependency-name: storybook
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-03 15:44:51 -08:00
dependabot[bot]
b77acc5468
Bump @storybook/theming from 7.6.6 to 7.6.7 in /extensions/ql-vscode ( #3193 )
...
Bumps [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/theming ) from 7.6.6 to 7.6.7.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.7/code/lib/theming )
---
updated-dependencies:
- dependency-name: "@storybook/theming"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-03 14:51:53 -08:00
dependabot[bot]
555fa6cf78
Bump @storybook/react-webpack5 in /extensions/ql-vscode ( #3192 )
...
Bumps [@storybook/react-webpack5](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-webpack5 ) from 7.6.6 to 7.6.7.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.7/code/frameworks/react-webpack5 )
---
updated-dependencies:
- dependency-name: "@storybook/react-webpack5"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-03 14:38:09 -08:00
dependabot[bot]
f7de8e5d09
Bump @testing-library/user-event in /extensions/ql-vscode ( #3191 )
...
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event ) from 14.5.1 to 14.5.2.
- [Release notes](https://github.com/testing-library/user-event/releases )
- [Changelog](https://github.com/testing-library/user-event/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/user-event/compare/v14.5.1...v14.5.2 )
---
updated-dependencies:
- dependency-name: "@testing-library/user-event"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-03 14:37:44 -08:00
dependabot[bot]
299280cd08
Bump @storybook/components from 7.6.4 to 7.6.7 in /extensions/ql-vscode ( #3190 )
...
Bumps [@storybook/components](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/components ) from 7.6.4 to 7.6.7.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.7/code/ui/components )
---
updated-dependencies:
- dependency-name: "@storybook/components"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-03 14:37:12 -08:00
Robert
92bebef49d
Merge pull request #3188 from github/robertbrignull/releases-refactor
...
Move ReleasesApiConsumer to a separate file and do simple refactors
2024-01-03 16:24:28 +00:00
Robert
1ce2b365a6
Move files to codeql-cli/distribution directory
2024-01-03 16:10:08 +00:00
Koen Vlaswinkel
47929943ba
Merge pull request #3184 from github/koesie10/node-version
...
Use semver range for `@types/node`
2024-01-03 16:42:50 +01:00
Nora
0b27912314
Make model editor open progress bar cancellable
2024-01-03 15:15:56 +00:00
Nora
6a65094720
Make preparation progress bar cancellable
2024-01-03 15:15:17 +00:00
Robert
6746b07879
Merge ownerName and repositoryName into one field because we no longer need to be able to specify them independently
2024-01-03 11:32:46 +00:00
Koen Vlaswinkel
593c01388b
Update outdated VS Code version docs
...
There were still references to a pinned version of VS Code used in the
integration tests, but this was resolved in https://github.com/github/vscode-codeql/pull/2877 .
2024-01-03 12:20:24 +01:00
Koen Vlaswinkel
dbee8dd57a
Remove troubleshooting steps for Chromium version
...
ESBuild doesn't use `browserslist` or `caniuse-lite`, so this step
isn't necessary.
2024-01-03 12:01:12 +01:00
Robert
426ab98623
Move fields to top of class definition
2024-01-03 10:54:17 +00:00
Robert
9fd8c1c3e0
Convert other fields to not use underscore prefix
2024-01-03 10:54:17 +00:00
Robert
b8cbd75737
Use "private readonly" modifier on constructor args
2024-01-03 10:54:17 +00:00
Robert
c575edec71
Move releases-api-consumer.test.ts from no-workspace to unit-tests
2024-01-03 10:54:17 +00:00
Robert
337e5f81ea
Adjust comments in releases-api-consumer.ts
2024-01-03 10:46:18 +00:00
Robert
6d1cf0887a
Pull out ReleasesApiConsumer to its own file
2024-01-03 10:46:15 +00:00
Robert
bc7c956d6d
Pull out GithubApiError and GithubRateLimitedError to a separate file
2024-01-03 10:46:15 +00:00
Robert
90d72cec78
Add more comments to Release and ReleaseAsset
2024-01-03 10:46:15 +00:00
Robert
2f9c8d1bfa
Move Release and ReleaseAsset to their own files
2024-01-03 10:46:11 +00:00
Koen Vlaswinkel
4b49a8f9bb
Update VS Code version documentation
2024-01-03 11:44:19 +01:00
Koen Vlaswinkel
9718aa5806
Rename update Chromium version to generate
...
This also adds the script as a script in the `package.json` with the
naming such that `npm generate` will re-generate the Chromium version
file. This will ensure that the CI checks fail when the Chromium version
doesn't match the minimum supported VS Code version.
2024-01-03 11:42:20 +01:00
Koen Vlaswinkel
7444605970
Add GitHub Actions workflow for updating Node version
2024-01-03 11:38:15 +01:00
Koen Vlaswinkel
cce0e146ff
Merge pull request #3182 from github/koesie10/vscode-versions
...
Add scripts for updating the Node and Chromium versions
2024-01-03 11:36:35 +01:00
Koen Vlaswinkel
de24e25486
Use semver range for @types/node
...
According to the DefinitelyTyped documentation, the patch version of
the type declaration package is unrelated to the library patch version.
Therefore, we should use an X-range for `@types/node` to allow
newer patch versions to be installed automatically.
2024-01-03 11:08:44 +01:00
Nora
8daf3374bf
Merge pull request #3181 from github/nora/adjust-log-messages
...
Remove ambiguity from 'View logs' messages
2024-01-03 10:53:47 +01:00
Robert
b27d8a1000
Merge pull request #3183 from github/robertbrignull/remove_releases_repo_config
...
Remove ownerName and repositoryName from DistributionConfig
2024-01-03 09:46:45 +00:00
Koen Vlaswinkel
1ad20fa354
Merge pull request #3163 from github/koesie10/queries-panel-no-cli-server
...
Do not use the CLI server to determine query pack language
2024-01-03 09:36:20 +01:00
Robert
b082455604
Remove ownerName and repositoryName from DistributionConfig
2024-01-02 16:56:20 +00:00
Koen Vlaswinkel
ed4b296e41
Allow empty qlpack files
2024-01-02 16:58:56 +01:00
Koen Vlaswinkel
cf00f8f191
Update Chromium version documentation
2024-01-02 16:28:31 +01:00
Koen Vlaswinkel
dc3e1ce096
Add script for updating Chromium version
2024-01-02 16:28:27 +01:00
Koen Vlaswinkel
e5ffdd0fbc
Use correct types for qlpack file
...
The qlpack file is allowed to have null values for fields, instead of
them being absent. This adds the correct types to the qlpack file
schema.
2024-01-02 16:27:42 +01:00
Koen Vlaswinkel
2c7b67e2a4
Log errors during query pack discovery
2024-01-02 16:27:42 +01:00
Koen Vlaswinkel
4129962fa0
Use generated schema to validate qlpack file
2024-01-02 16:19:11 +01:00
Koen Vlaswinkel
e79f732b84
Update Node version documentation
2024-01-02 16:00:55 +01:00
Koen Vlaswinkel
49deb2e756
Add script for updating Node version
2024-01-02 16:00:55 +01:00
Koen Vlaswinkel
0be60f3e8f
Extract functions to separate file
2024-01-02 16:00:55 +01:00
Koen Vlaswinkel
e294dfdf4a
Add simple script for finding VS Code versions
2024-01-02 16:00:55 +01:00
Koen Vlaswinkel
870874d7f3
Merge pull request #3174 from github/koesie10/view-esbuild
...
Switch view to ESBuild and JSX runtime
2024-01-02 16:00:42 +01:00
Robert
856f97f859
Merge pull request #3129 from github/robertbrignull/test-issue
...
Create issue when CLI tests fail on the default branch
2024-01-02 14:27:44 +00:00
Nora
cfbc44311b
Adjust actions log messages
2024-01-02 13:52:08 +00:00
Koen Vlaswinkel
27a326ab3e
Add documentation for updating the ESBuild target
2024-01-02 14:33:59 +01:00
Nora
91ab97e923
Adjust extension log messages
2024-01-02 13:23:00 +00:00
Koen Vlaswinkel
fa7ecb782e
Merge pull request #3175 from github/koesie10/rename-new-messages
...
Remove remaining references to new messages/new query server
2024-01-02 13:44:00 +01:00
Robert
f5dbcc8cc1
Merge pull request #3127 from github/robertbrignull/nightly-codeql
...
Provide option to point ReleasesApiConsumer at nightly builds repo
2024-01-02 12:21:38 +00:00
Robert
c423505c04
Update extensions/ql-vscode/test/vscode-tests/no-workspace/codeql-cli/distribution.test.ts
...
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com >
2024-01-02 12:05:43 +00:00
Koen Vlaswinkel
e7eb33e0cf
Enable jsx-runtime configuration for linting
2024-01-02 10:42:06 +01:00
Koen Vlaswinkel
528f8b951b
Remove unnecessary React imports from stories
2024-01-02 10:42:06 +01:00
Koen Vlaswinkel
74568b86b1
Remove unnecessary React imports from view code
2024-01-02 10:42:06 +01:00
Koen Vlaswinkel
039077467a
Set correct JSX mode in tsconfig.json
2024-01-02 10:42:05 +01:00
Koen Vlaswinkel
ef28154b95
Improve ESBuild globs
2024-01-02 10:42:05 +01:00
Koen Vlaswinkel
47cabbb331
Remove webpack packages
2024-01-02 10:42:05 +01:00
Koen Vlaswinkel
c1a3c2f6e5
Switch view to ESBuild
...
This switches the view code from Webpack to ESBuild to unify the build
systems for the extension and view code. There are no changes in
behavior, except that some features are now not supported (like dynamic
require/import) and importing the `classnames` package fails. However,
these were really easy to fix and don't hinder the further development
of the view code, so I've just fixed those instances.
2024-01-02 10:42:03 +01:00
dependabot[bot]
c210a7fdf4
Bump @storybook/theming from 7.6.4 to 7.6.6 in /extensions/ql-vscode ( #3180 )
...
Bumps [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/theming ) from 7.6.4 to 7.6.6.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.6/code/lib/theming )
---
updated-dependencies:
- dependency-name: "@storybook/theming"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-28 12:43:25 -08:00
dependabot[bot]
184a98531f
Bump @typescript-eslint/eslint-plugin in /extensions/ql-vscode ( #3179 )
...
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin ) from 6.15.0 to 6.16.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases )
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md )
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.16.0/packages/eslint-plugin )
---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-28 12:43:03 -08:00
dependabot[bot]
9a6d44b86a
Bump @storybook/manager-api from 7.6.4 to 7.6.6 in /extensions/ql-vscode ( #3178 )
...
Bumps [@storybook/manager-api](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/manager-api ) from 7.6.4 to 7.6.6.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.6/code/lib/manager-api )
---
updated-dependencies:
- dependency-name: "@storybook/manager-api"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-28 11:37:03 -08:00
dependabot[bot]
d0df81c524
Bump @typescript-eslint/parser in /extensions/ql-vscode ( #3177 )
...
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser ) from 6.15.0 to 6.16.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases )
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md )
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.16.0/packages/parser )
---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-28 11:36:43 -08:00
dependabot[bot]
ba8788e0a5
Bump @testing-library/jest-dom in /extensions/ql-vscode ( #3176 )
...
Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom ) from 6.1.5 to 6.1.6.
- [Release notes](https://github.com/testing-library/jest-dom/releases )
- [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/jest-dom/compare/v6.1.5...v6.1.6 )
---
updated-dependencies:
- dependency-name: "@testing-library/jest-dom"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-28 11:36:21 -08:00
Koen Vlaswinkel
767c3cc35c
Remove references to new query server
2023-12-22 16:51:26 +01:00
Koen Vlaswinkel
a6d9b6bbec
Rename new-query.test.ts to query-server-client.test.ts
2023-12-22 16:20:21 +01:00
Koen Vlaswinkel
f139f1ebf8
Rename new-messages.ts to messages.ts
2023-12-22 16:18:30 +01:00
Koen Vlaswinkel
d227af4c7b
Merge pull request #3172 from github/koesie10/remove-legacy-messages
...
Remove legacy messages
2023-12-22 16:14:45 +01:00
Koen Vlaswinkel
2b625c85e8
Merge pull request #3173 from github/koesie10/eslint-plugin-import
...
Add `eslint-plugin-import`
2023-12-22 16:08:46 +01:00
Koen Vlaswinkel
5ea1438036
Merge pull request #3171 from github/koesie10/remove-new-query-runner-abstraction
...
Remove `QueryRunner` abstraction
2023-12-22 09:44:11 +01:00
Koen Vlaswinkel
7a7092de0d
Add eslint-plugin-import
...
It seems like we had some rules that disabled rules of this plugin, but
we didn't actually have it installed. I've now installed it, used the
recommended configuration, and removed our own disable rules. I've fixed
any errors that this introduced.
2023-12-21 17:02:37 +01:00
Koen Vlaswinkel
2ba39647f2
Remove statusString method
2023-12-21 16:59:39 +01:00
Koen Vlaswinkel
48ff62f474
Make message and succesful required
2023-12-21 16:57:46 +01:00
Koen Vlaswinkel
82c7dd52be
Remove legacy messages
2023-12-21 16:19:22 +01:00
Koen Vlaswinkel
d0f122ad87
Remove formatLegacyMessage
2023-12-21 16:11:47 +01:00
Koen Vlaswinkel
ef575acd59
Remove legacy result from query history items
...
The legacy result was populated based on information that is already
present in `CompletedQueryInfo` anyway. Old history items which only
have the legacy result populated have not been created for at least 30
days now since the legacy query runner hasn't been used for quite a
while now.
2023-12-21 16:08:39 +01:00
Koen Vlaswinkel
785a5fa48a
Remove QueryRunner abstraction
...
Since we're only supporting the new query server, we can remove the
`QueryRunner` abstraction and just use the `NewQueryRunner` as a
concrete `QueryRunner` without an abstract base class. This simplifies
the code of the query server and removes some unnecessary indirection.
2023-12-21 16:03:28 +01:00
Koen Vlaswinkel
43ea7eb41d
Merge pull request #3170 from github/dependabot/npm_and_yarn/extensions/ql-vscode/storybook/react-webpack5-7.6.6
...
Bump @storybook/react-webpack5 from 7.6.4 to 7.6.6 in /extensions/ql-vscode
2023-12-21 15:25:55 +01:00
Koen Vlaswinkel
4b27d0d59c
Merge pull request #3169 from github/dependabot/npm_and_yarn/extensions/ql-vscode/typescript-eslint/eslint-plugin-6.15.0
...
Bump @typescript-eslint/eslint-plugin from 6.13.2 to 6.15.0 in /extensions/ql-vscode
2023-12-21 15:25:39 +01:00
dependabot[bot]
1df2e54074
Bump @storybook/react-webpack5 in /extensions/ql-vscode
...
Bumps [@storybook/react-webpack5](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-webpack5 ) from 7.6.4 to 7.6.6.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.6/code/frameworks/react-webpack5 )
---
updated-dependencies:
- dependency-name: "@storybook/react-webpack5"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-21 14:13:27 +00:00
dependabot[bot]
b7eba71ab6
Bump @typescript-eslint/eslint-plugin in /extensions/ql-vscode
...
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin ) from 6.13.2 to 6.15.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases )
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md )
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.15.0/packages/eslint-plugin )
---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-21 14:12:54 +00:00
Koen Vlaswinkel
7375fce82d
Merge pull request #3167 from github/dependabot/npm_and_yarn/extensions/ql-vscode/storybook-7.6.6
...
Bump storybook from 7.6.4 to 7.6.6 in /extensions/ql-vscode
2023-12-21 15:11:58 +01:00
Koen Vlaswinkel
eac3836535
Merge pull request #3168 from github/dependabot/npm_and_yarn/extensions/ql-vscode/eslint-8.56.0
...
Bump eslint from 8.55.0 to 8.56.0 in /extensions/ql-vscode
2023-12-21 15:11:36 +01:00
Koen Vlaswinkel
e8f750776b
Merge pull request #3166 from github/dependabot/npm_and_yarn/extensions/ql-vscode/typescript-eslint/parser-6.15.0
...
Bump @typescript-eslint/parser from 6.14.0 to 6.15.0 in /extensions/ql-vscode
2023-12-21 15:11:05 +01:00
Koen Vlaswinkel
91a542dce6
Merge pull request #3165 from github/dependabot/github_actions/actions/download-artifact-4
...
Bump actions/download-artifact from 3 to 4
2023-12-21 15:01:44 +01:00
Koen Vlaswinkel
b902bfd71d
Merge pull request #3164 from github/dependabot/github_actions/actions/upload-artifact-4
...
Bump actions/upload-artifact from 3 to 4
2023-12-21 15:01:27 +01:00
dependabot[bot]
6dd6460b33
Bump eslint from 8.55.0 to 8.56.0 in /extensions/ql-vscode
...
Bumps [eslint](https://github.com/eslint/eslint ) from 8.55.0 to 8.56.0.
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/compare/v8.55.0...v8.56.0 )
---
updated-dependencies:
- dependency-name: eslint
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-21 13:59:34 +00:00
dependabot[bot]
36d23e7eec
Bump storybook from 7.6.4 to 7.6.6 in /extensions/ql-vscode
...
Bumps [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli ) from 7.6.4 to 7.6.6.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.6/code/lib/cli )
---
updated-dependencies:
- dependency-name: storybook
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-21 13:59:09 +00:00
dependabot[bot]
b65f0490f2
Bump @typescript-eslint/parser in /extensions/ql-vscode
...
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser ) from 6.14.0 to 6.15.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases )
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md )
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.15.0/packages/parser )
---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-21 13:58:37 +00:00
Koen Vlaswinkel
a8dd368578
Merge pull request #3157 from github/koesie10/yauzl-progress
...
Add progress reporting for unzipping files
2023-12-21 14:40:53 +01:00
dependabot[bot]
4d130bc2fa
Bump actions/download-artifact from 3 to 4
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](https://github.com/actions/download-artifact/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-21 13:02:31 +00:00
dependabot[bot]
1b526783e2
Bump actions/upload-artifact from 3 to 4
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-21 13:02:28 +00:00
Koen Vlaswinkel
4e4345f0c2
Merge remote-tracking branch 'origin/main' into koesie10/yauzl-progress
2023-12-21 13:41:43 +01:00
Koen Vlaswinkel
b2df8b6971
Move readableBytesMb to common/bytes
2023-12-21 13:41:22 +01:00
Koen Vlaswinkel
91ea2f089e
Extract calculateTotalUncompressedByteSize function
2023-12-21 13:39:09 +01:00
Koen Vlaswinkel
fbaf3d1cdf
Merge pull request #3162 from github/koesie10/yauzl-changelog
...
Add CHANGELOG entry for `yauzl` migration
2023-12-21 12:34:07 +01:00
Koen Vlaswinkel
7bcf62c6fe
Merge pull request #3161 from github/koesie10/github-databases-package-json
...
Remove missed feature flag reference from package.json
2023-12-21 12:33:59 +01:00
Koen Vlaswinkel
f7c0d4dc91
Merge pull request #3160 from github/koesie10/github-databases-tests
...
Add tests and test plan for GitHub database download
2023-12-21 12:33:51 +01:00
Koen Vlaswinkel
e81f1a1fde
Extract getQlPackLanguage function
2023-12-21 12:30:26 +01:00
Koen Vlaswinkel
c14fa63321
Remove resolveLibraryPath method
2023-12-21 12:20:44 +01:00
Koen Vlaswinkel
7554c415af
Do not use the CLI server to determine query pack language
...
This removes the use of the CLI `codeql resolve library-path` command to
detect the language of a query pack. Instead, it uses the `qlpack.yml`
file to determine the language. This is slightly less correct since it
only works for `codeql/${language}-all` dependencies, but it is much
faster and more reliable. It also doesn't result in the CLI server
restarting for invalid query packs (such as in the `github/codeql`
repository or in any workspaces containing it).
2023-12-21 12:20:12 +01:00
Koen Vlaswinkel
bbdad0fe2c
Add CHANGELOG entry for yauzl migration
2023-12-21 11:30:11 +01:00
Koen Vlaswinkel
b3da120d70
Add GitHub database download to test plan
2023-12-21 11:23:15 +01:00
Koen Vlaswinkel
3689f84612
Remove missed feature flag reference from package.json
2023-12-21 11:06:50 +01:00
Koen Vlaswinkel
f99432153b
Add tests for promptGitHubRepositoryDownload
2023-12-21 10:56:34 +01:00
Koen Vlaswinkel
704895ba6c
Merge pull request #3159 from github/github-action/bump-cli
...
Bump CLI Version to v2.15.5 for integration tests
2023-12-21 09:54:15 +01:00
Koen Vlaswinkel
f3780c6305
Merge pull request #3158 from github/koesie10/fix-qltest-discovery-watcher
...
Do not reregister watchers on every file change for qltests
2023-12-21 09:49:58 +01:00
github-actions[bot]
bb3ec207e3
Bump CLI version from v2.15.4 to v2.15.5 for integration tests
2023-12-20 19:08:03 +00:00
Robert
e56503249d
Add tests that cover the new semver options
2023-12-20 16:25:57 +00:00
Robert
37b2e422cd
Use stable instead of released
2023-12-20 16:25:57 +00:00
Robert
4140303b5c
Fix arguemnts to calls to getLatestRelease
2023-12-20 16:25:54 +00:00
Koen Vlaswinkel
218be87e88
Do not reregister watchers on every file change for qltests
...
During the qltest discovery, we were recreating the watchers for qltests
on every file change. This was causing the watchers to be recreated
on each change, while there were no functional changes to the watchers
themselves.
This commit moves the creation of the watchers to the constructor of
the QLTestDiscovery class, and removes the creation of the watchers
from the discover() method. The behavior should be the same.
2023-12-20 13:29:40 +01:00
Robert
c7e2d69daa
Define nightly by whether the value matches the default
2023-12-20 11:38:58 +00:00
Robert
ba2f44b8ae
Change to using getter for no-args methods
2023-12-20 11:37:11 +00:00
Koen Vlaswinkel
2267e9d4db
Add tests for unzip progress reporting
2023-12-20 10:30:59 +01:00
Koen Vlaswinkel
6f85894a11
Report progress while extracting CodeQL CLI distribution
2023-12-20 10:24:07 +01:00
Koen Vlaswinkel
8cbd77cf65
Report progress while extracting CodeQL CLI distribution in tests
2023-12-20 10:24:07 +01:00
Koen Vlaswinkel
641f714fa4
Extract downloadWithProgress function in ensureCli
2023-12-20 10:24:07 +01:00
Koen Vlaswinkel
216f10d327
Add progress reporting for intermediate bytes extracted
2023-12-20 10:24:07 +01:00
Koen Vlaswinkel
5045b2df60
Add progress reporting for bytes extracted
2023-12-20 10:24:07 +01:00
Koen Vlaswinkel
857a997037
Add progress reporting for extracted files
2023-12-20 10:24:07 +01:00
Koen Vlaswinkel
262744e6e5
Merge pull request #3155 from github/koesie10/yauzl-concurrent
...
Add concurrency to unzipping using `yauzl`
2023-12-20 10:23:55 +01:00
Koen Vlaswinkel
4444951093
Merge remote-tracking branch 'origin/main' into koesie10/yauzl-concurrent
2023-12-20 10:10:47 +01:00
Koen Vlaswinkel
e824fda9e7
Merge pull request #3153 from github/koesie10/yauzl-unzip-tests
...
Add simple tests for `yauzl`-based unzip functions
2023-12-20 10:01:45 +01:00
Koen Vlaswinkel
ef8bf9fd1b
Merge pull request #3154 from github/koesie10/source-map-fix
...
Switch to `yauzl` for source map script
2023-12-20 09:56:23 +01:00
Robert
69dea08c47
Don't check semver for nightly releases
2023-12-19 18:47:43 +00:00
Robert
0360bf294f
Merge branch 'main' into robertbrignull/nightly-codeql
2023-12-19 17:39:29 +00:00
Robert
996e8036c1
Merge branch 'main' into robertbrignull/test-issue
2023-12-19 16:20:14 +00:00
Robert
2e51c1a657
Fix workflow after testing it
2023-12-19 16:19:59 +00:00
Koen Vlaswinkel
f1fe4a20f2
chmod tmp dir before cleanup
...
This should fix any permissions errors we get due to the ZIP file
containing files with different permissions.
2023-12-19 15:27:07 +01:00
Koen Vlaswinkel
be4059864e
Do not test file modes on Windows
2023-12-19 15:18:35 +01:00
Koen Vlaswinkel
a80098d7df
Fix race condition in unzip tests
2023-12-19 15:17:57 +01:00
Koen Vlaswinkel
f45b790591
Fix file path in tests on Windows
2023-12-19 15:14:13 +01:00
Koen Vlaswinkel
7a1f157225
Extract common functionality between unzip implementations
2023-12-19 15:00:13 +01:00
Koen Vlaswinkel
ba9b284606
Add tests for unzipToDirectory
2023-12-19 14:58:16 +01:00
Koen Vlaswinkel
1055515d59
Use different ZIP file for unzip tests
2023-12-19 14:43:49 +01:00
Koen Vlaswinkel
4eee14be61
Merge remote-tracking branch 'origin/main' into koesie10/yauzl-unzip-tests
2023-12-19 14:37:03 +01:00
Koen Vlaswinkel
7c00768c90
Extract unzipFile function
2023-12-19 14:27:51 +01:00
Koen Vlaswinkel
9038586aab
Rename unzipToDirectory to unzipToDirectorySequentially
2023-12-19 14:26:03 +01:00
Koen Vlaswinkel
800890443e
Add concurrent unzip implementation
2023-12-19 14:25:44 +01:00
Koen Vlaswinkel
0dcc814953
Remove unzipper
2023-12-19 14:20:42 +01:00
Koen Vlaswinkel
64ad40e369
Switch to yauzl for the source map script
2023-12-19 14:20:17 +01:00
Koen Vlaswinkel
f736adc4f1
Merge pull request #3152 from github/koesie10/distribution-yauzl
...
Switch to `yauzl` for CodeQL CLI
2023-12-19 14:18:59 +01:00
Koen Vlaswinkel
e89a04d442
Merge pull request #3151 from github/koesie10/variant-analysis-yauzl
...
Switch to `yauzl` for variant analysis results
2023-12-19 14:18:49 +01:00
Koen Vlaswinkel
2e6eb1c7bc
Add simple tests for yauzl-based unzip functions
2023-12-19 13:19:48 +01:00
Koen Vlaswinkel
fdc36ad36b
Switch to yauzl for CodeQL CLI
...
This switches the CodeQL CLI download to `yauzl` instead of `unzipper`.
There should be no changes in behavior. I tested this manually on
Insiders by removing the distribution directory and this successfully
downloaded and extracted the CLI.
2023-12-19 13:07:31 +01:00
Koen Vlaswinkel
3f6c1055e4
Merge remote-tracking branch 'origin/main' into koesie10/variant-analysis-yauzl
2023-12-19 13:03:54 +01:00
Koen Vlaswinkel
b833591d1e
Merge pull request #3150 from github/koesie10/archive-filesystem-yauzl
...
Switch to `yauzl` in the archive filesystem provider
2023-12-19 12:14:31 +01:00
Koen Vlaswinkel
82f17c4e53
Merge pull request #3148 from github/koesie10/model-editor-capitalization
...
Fix incorrect model files on case-insensitive file systems
2023-12-18 16:34:12 +01:00
Koen Vlaswinkel
790503bd60
Merge pull request #3149 from github/koesie10/database-unbundle
...
Remove fallback behavior for database unbundle
2023-12-18 15:13:55 +01:00
Koen Vlaswinkel
770834756a
Switch to yauzl for variant analysis results
2023-12-18 15:10:36 +01:00
Koen Vlaswinkel
bc0506d058
Switch to yauzl in the archive filesystem provider
2023-12-18 14:22:22 +01:00
Koen Vlaswinkel
14b2282015
Remove fallback behavior for database unbundle
...
The CodeQL CLI always supports the `database unbundle` command since
140d369098
so we can remove the fallback behavior.
There were some places which were not passing in the CodeQL CLI server,
but these always have access to the CLI server, so this just passes them
in.
The only change in behavior (in terms of the fallback behavior) is in
the `new-query.test.ts` test.
2023-12-18 14:19:59 +01:00
Koen Vlaswinkel
12ea1b9598
Remove unnecessary check
2023-12-18 13:49:04 +01:00
Koen Vlaswinkel
6cfa0a93c9
Merge pull request #3141 from github/koesie10/model-editor-consistency-check
...
Add a consistency check for the model editor
2023-12-15 15:11:04 +01:00
Koen Vlaswinkel
ef2f9d9c90
Fix incorrect model files on case-insensitive file systems
...
This fixes some incorrect model files on case-insensitive file systems
when the package names are the same but the capitalization is different.
For example, when there are two packages `Volo.Abp.TestApp.MongoDb` and
`Volo.Abp.TestApp.MongoDB`, there would be 1 model file for each
package. However, on case-insensitive file systems, the second file
would overwrite the first file. This results in missing models. This
fixes it by canonicalizing the filenames to lowercase and writing all
files with the same package name to the same file.
2023-12-15 15:06:22 +01:00
Koen Vlaswinkel
1891763d64
Remove enableConsistencyCheck feature flag
2023-12-15 14:48:35 +01:00
Koen Vlaswinkel
0b4fc76fdb
Update inconsistent support message
2023-12-15 14:47:11 +01:00
Koen Vlaswinkel
d036e8144d
Do not expect type models to be supported
2023-12-15 14:43:55 +01:00
Koen Vlaswinkel
4f2d768e07
Update message to mention model editor
2023-12-15 14:43:08 +01:00
Koen Vlaswinkel
60d777abf1
Merge pull request #3113 from github/koesie10/compare-interpreted
...
Add SARIF result comparison to compare view
2023-12-15 10:56:04 +01:00
Koen Vlaswinkel
34bd7c21a6
Merge pull request #3147 from github/koesie10/remove-immutable
...
Remove immutable package
2023-12-15 09:49:03 +01:00
Koen Vlaswinkel
6cf8d0be4f
Merge pull request #3145 from github/dependabot/npm_and_yarn/extensions/ql-vscode/tmp-0.2.1
...
Bump tmp from 0.1.0 to 0.2.1 in /extensions/ql-vscode
2023-12-14 16:28:02 +01:00
Koen Vlaswinkel
b340b1a740
Merge branch 'main' into dependabot/npm_and_yarn/extensions/ql-vscode/tmp-0.2.1
2023-12-14 16:13:18 +01:00
Koen Vlaswinkel
ce83d1df23
Replace tmp package for modeled-method-fs.test.ts
2023-12-14 16:09:30 +01:00
Koen Vlaswinkel
d63b756520
Set unsafeCleanup for all test tmp directories
...
We want to remove the tmp directories after tests, even if they are not
empty.
2023-12-14 15:08:45 +01:00
Koen Vlaswinkel
47fbf3428f
Remove immutable package
2023-12-14 15:03:34 +01:00
dependabot[bot]
889055ee19
Bump tmp from 0.1.0 to 0.2.1 in /extensions/ql-vscode
...
Bumps [tmp](https://github.com/raszi/node-tmp ) from 0.1.0 to 0.2.1.
- [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md )
- [Commits](https://github.com/raszi/node-tmp/compare/v0.1.0...v0.2.1 )
---
updated-dependencies:
- dependency-name: tmp
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-14 13:44:44 +00:00
Koen Vlaswinkel
c7f08e328d
Merge pull request #3144 from github/dependabot/npm_and_yarn/extensions/ql-vscode/p-queue-8.0.1
...
Bump p-queue from 7.4.1 to 8.0.1 in /extensions/ql-vscode
2023-12-14 14:44:39 +01:00
Koen Vlaswinkel
0273be9710
Merge pull request #3143 from github/dependabot/npm_and_yarn/extensions/ql-vscode/vscode/codicons-0.0.35
...
Bump @vscode/codicons from 0.0.31 to 0.0.35 in /extensions/ql-vscode
2023-12-14 14:44:12 +01:00
Koen Vlaswinkel
e94da0e765
Merge pull request #3142 from github/dependabot/npm_and_yarn/extensions/ql-vscode/gulp-esbuild-0.12.0
...
Bump gulp-esbuild from 0.10.8 to 0.12.0 in /extensions/ql-vscode
2023-12-14 14:43:10 +01:00
Koen Vlaswinkel
cb15c8dbeb
Remove direct esbuild dependency
...
ESBuild is a dependency of `gulp-esbuild`, so we don't need the direct
dependency.
2023-12-14 14:29:56 +01:00
dependabot[bot]
c7173e86a2
Bump p-queue from 7.4.1 to 8.0.1 in /extensions/ql-vscode
...
Bumps [p-queue](https://github.com/sindresorhus/p-queue ) from 7.4.1 to 8.0.1.
- [Release notes](https://github.com/sindresorhus/p-queue/releases )
- [Commits](https://github.com/sindresorhus/p-queue/compare/v7.4.1...v8.0.1 )
---
updated-dependencies:
- dependency-name: p-queue
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-14 13:19:19 +00:00
dependabot[bot]
b3c8c25572
Bump @vscode/codicons from 0.0.31 to 0.0.35 in /extensions/ql-vscode
...
Bumps [@vscode/codicons](https://github.com/microsoft/vscode-codicons ) from 0.0.31 to 0.0.35.
- [Release notes](https://github.com/microsoft/vscode-codicons/releases )
- [Commits](https://github.com/microsoft/vscode-codicons/compare/0.0.31...0.0.35 )
---
updated-dependencies:
- dependency-name: "@vscode/codicons"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-14 13:18:45 +00:00
dependabot[bot]
2bad58be71
Bump gulp-esbuild from 0.10.8 to 0.12.0 in /extensions/ql-vscode
...
Bumps [gulp-esbuild](https://github.com/ym-project/gulp-esbuild ) from 0.10.8 to 0.12.0.
- [Release notes](https://github.com/ym-project/gulp-esbuild/releases )
- [Commits](https://github.com/ym-project/gulp-esbuild/compare/v0.10.8...v0.12.0 )
---
updated-dependencies:
- dependency-name: gulp-esbuild
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-14 13:18:21 +00:00
Koen Vlaswinkel
fe4116fe05
Merge pull request #3140 from github/koesie10/remove-bundled-queries
...
Remove bundled Java and C# model editor queries
2023-12-14 13:19:37 +01:00
Koen Vlaswinkel
b9b16a8beb
Add a consistency check for the model editor
2023-12-14 12:07:59 +01:00
Koen Vlaswinkel
c3b30a30e8
Merge pull request #3139 from github/koesie10/upgrade-markdownlint
...
Upgrade Markdownlint packages
2023-12-14 11:50:04 +01:00
Koen Vlaswinkel
04e4efb26b
Remove bundled Java and C# model editor queries
2023-12-14 11:38:04 +01:00
Koen Vlaswinkel
8d1c8bc725
Add alt text to Overview.stories.mdx
2023-12-14 10:50:16 +01:00
Koen Vlaswinkel
eb1bf8fd69
Merge pull request #3138 from github/koesie10/remove-github-databases-enable-ff
...
Remove GitHub database download feature flag
2023-12-14 10:48:56 +01:00
Koen Vlaswinkel
9a77748a59
Fix auto-fixable markdownlint violations
...
This fixes all violations that can be fixed by using
`npm run lint:markdown -- --fix`.
This also updates the markdownlint configuration to require dashes in
unstyled lists. This results in the least amount of changes to Markdown
files. The default setting results in rewriting the complete CHANGELOG
file.
2023-12-14 10:47:39 +01:00
Koen Vlaswinkel
d77a08fc37
Upgrade markdownlint packages
2023-12-14 10:42:05 +01:00
Koen Vlaswinkel
cb2e5026a1
Update CHANGELOG
2023-12-14 10:27:54 +01:00
Koen Vlaswinkel
d4a4536d40
Improve performance of compare view using Promise.all
2023-12-14 10:22:10 +01:00
Koen Vlaswinkel
ab1966abf1
Add comparison of SARIF results in compare view
...
This wires up the comparison of SARIF results in the compare view. It
uses the same diffing algorithm as the raw results, but it uses the
SARIF results instead of the raw results.
2023-12-14 10:22:10 +01:00
Koen Vlaswinkel
6de954143c
Read raw result sets in compareResults
...
This moves reading of the result sets to the `compareResults` method
since raw result sets don't need to be read for interpreted results and
the `findResultSetsToCompare` method is shared between the two types
of results.
2023-12-14 10:22:10 +01:00
Koen Vlaswinkel
109766d411
Add alerts table to compare view if available
...
This adds the `alerts` result set to the compare view if an interpreted
result is available. This assumes that the user has opened the query
in the results view before opening the compare view. It will not
interpret the results if the interpreted results are not available.
2023-12-14 10:22:09 +01:00
Koen Vlaswinkel
4bd1981a34
Update CHANGELOG
2023-12-14 10:10:14 +01:00
Koen Vlaswinkel
0415ac539c
Merge pull request #3112 from github/koesie10/compare-sarif-view
...
Add interpreted results table to compare view
2023-12-14 10:10:07 +01:00
Koen Vlaswinkel
cf50a71a16
Remove GitHub database download feature flag
...
This removes the `codeQL.githubDatabase.enable` setting and always
enables the GitHub database download feature.
2023-12-14 10:08:14 +01:00
Charis Kyriakou
598f2eb3f2
Allow the CodeQL CLI path to be set from an environment variable ( #3118 )
2023-12-14 09:03:25 +00:00
Koen Vlaswinkel
480f90ac2f
Merge remote-tracking branch 'origin/main' into koesie10/compare-sarif-view
2023-12-14 09:54:50 +01:00
Andrew Eisenberg
e15f15358b
Merge pull request #3125 from github/aeisenberg/no-multi-token
...
Avoid creating a multitoken when finding definitions
2023-12-13 15:07:52 -08:00
Andrew Eisenberg
8516940e64
Add changelog note
2023-12-13 22:52:19 +00:00
Andrew Eisenberg
ef69a51741
Avoid creating a multitoken when finding definitions
...
This will avoid showing a query-server popup on hovers. When someone
does CTRL+hover on source code in a database archive, the definitions
provider is triggered. The first time this is run, there will be a query that
is invoked in order to find definitions. This can be a long process.
Previously, this query brought up a popup window that could be cancelled.
However, this is confusing users since the query is automatically cancelled
when the mouse hovers away from the element.
The downside of this PR is that even when find definitions is explicitly invoked,
(using F12), there will still be no hover.
I think this is an improvement, but I am happy to discuss if others disagree.
2023-12-13 22:50:37 +00:00
Koen Vlaswinkel
9594a5e951
Merge pull request #3136 from github/dependabot/npm_and_yarn/extensions/ql-vscode/types/tar-stream-3.1.3
...
Bump @types/tar-stream from 2.2.3 to 3.1.3 in /extensions/ql-vscode
2023-12-13 16:55:25 +01:00
Koen Vlaswinkel
7b9c7f4e21
Merge pull request #3135 from github/dependabot/npm_and_yarn/extensions/ql-vscode/markdownlint-cli2-formatter-pretty-0.0.5
...
Bump markdownlint-cli2-formatter-pretty from 0.0.4 to 0.0.5 in /extensions/ql-vscode
2023-12-13 16:07:39 +01:00
Koen Vlaswinkel
25ff95a2f3
Merge pull request #3134 from github/dependabot/npm_and_yarn/extensions/ql-vscode/typescript-eslint/parser-6.14.0
...
Bump @typescript-eslint/parser from 6.13.2 to 6.14.0 in /extensions/ql-vscode
2023-12-13 16:07:31 +01:00
dependabot[bot]
25779b4db1
Bump @types/tar-stream from 2.2.3 to 3.1.3 in /extensions/ql-vscode
...
Bumps [@types/tar-stream](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/tar-stream ) from 2.2.3 to 3.1.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/tar-stream )
---
updated-dependencies:
- dependency-name: "@types/tar-stream"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-13 14:53:46 +00:00
dependabot[bot]
611f55b9cd
Bump markdownlint-cli2-formatter-pretty in /extensions/ql-vscode
...
Bumps [markdownlint-cli2-formatter-pretty](https://github.com/DavidAnson/markdownlint-cli2 ) from 0.0.4 to 0.0.5.
- [Changelog](https://github.com/DavidAnson/markdownlint-cli2/blob/main/CHANGELOG.md )
- [Commits](https://github.com/DavidAnson/markdownlint-cli2/compare/v0.0.4...v0.0.5 )
---
updated-dependencies:
- dependency-name: markdownlint-cli2-formatter-pretty
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-13 14:53:27 +00:00
dependabot[bot]
b8558a67a3
Bump @typescript-eslint/parser in /extensions/ql-vscode
...
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser ) from 6.13.2 to 6.14.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases )
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md )
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.14.0/packages/parser )
---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-13 14:53:12 +00:00
Koen Vlaswinkel
3d65ecaac9
Merge pull request #3126 from github/koesie10/remove-types-classnames
...
Remove `@types/classnames` package
2023-12-13 15:51:39 +01:00
Koen Vlaswinkel
61c9503d52
Merge pull request #3132 from github/koesie10/dependabot-all
...
Do not ignore patch/minor updates in Dependabot configuration
2023-12-13 15:51:26 +01:00
Koen Vlaswinkel
01f5a65f7d
Remove @types/classnames package
...
`classnames` provides its own type definitions, so we do not need to
have this installed.
2023-12-13 15:33:17 +01:00
Koen Vlaswinkel
612499916d
Do not ignore patch/minor updates in Dependabot configuration
2023-12-13 15:03:10 +01:00
Koen Vlaswinkel
a2294bb5cc
Merge pull request #3122 from github/koesie10/npm-upgrade
...
Run `npm upgrade`
2023-12-13 14:57:29 +01:00
Koen Vlaswinkel
0b7b6f1b13
Merge remote-tracking branch 'origin/main' into koesie10/npm-upgrade
2023-12-13 14:40:30 +01:00
Koen Vlaswinkel
8b2fd1a630
Merge pull request #3131 from github/version/bump-to-v1.11.1
...
Bump version to v1.11.1
2023-12-13 14:39:00 +01:00
Koen Vlaswinkel
4bb25a7d69
Merge pull request #3093 from github/koesie10/separate-bqrs-types
...
Create separate types for raw results sets
2023-12-13 14:27:45 +01:00
github-actions[bot]
83bdb54047
Bump version to v1.11.1
2023-12-13 13:17:03 +00:00
Koen Vlaswinkel
0d380736b3
Merge pull request #3130 from github/v1.11.0
...
v1.11.0
2023-12-13 14:15:23 +01:00
Koen Vlaswinkel
0655e10db5
Remove canary requirement for CodeQL Methods Usage panel
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2023-12-13 12:10:34 +01:00
Koen Vlaswinkel
fb713f733d
Upgrade @vscode/test-electron
...
This upgrades this package to fix tests on Windows. It seems like the
extraction of the VS Code archive is failing, which is fixed in the
newest version.
2023-12-13 10:16:26 +01:00
Koen Vlaswinkel
15cc559792
v1.11.0
2023-12-13 09:48:49 +01:00
Koen Vlaswinkel
a2f3f5fbe3
Merge pull request #3128 from github/koesie10/feature-flags-1.11.0
...
Remove feature flags for release v1.11.0
2023-12-13 09:39:27 +01:00
Robert
54a03c8839
Create issue when CLI tests fail on the default branch
2023-12-12 16:43:03 +00:00
Koen Vlaswinkel
ce84fed6ab
Update CHANGELOG
2023-12-12 14:57:01 +01:00
Koen Vlaswinkel
6ecad9db03
Remove modeled-methods-legacy file
2023-12-12 14:51:38 +01:00
Koen Vlaswinkel
9543d14840
Remove unnecessary ModeledMethodsPanel
2023-12-12 14:49:19 +01:00
Koen Vlaswinkel
6eee7983b0
Remove showMultipleModels props
2023-12-12 14:48:45 +01:00
Koen Vlaswinkel
6ec0f51a54
Remove showMultipleModels from view states
2023-12-12 14:43:42 +01:00
Koen Vlaswinkel
5a29d35c98
Remove showMultipleModels config
2023-12-12 14:35:15 +01:00
Koen Vlaswinkel
16ebac12a1
Move showMultipleModels out of canary
2023-12-12 14:33:57 +01:00
Koen Vlaswinkel
2b6fe94cd3
Move codeQLMethodModeling out of canary
2023-12-12 14:33:38 +01:00
Koen Vlaswinkel
bc1c08c653
Merge remote-tracking branch 'origin/main' into koesie10/separate-bqrs-types
2023-12-12 14:15:24 +01:00
Robert
66c0714606
Point ReleasesApiConsumer at nightly repo if config value is set
2023-12-12 10:43:03 +00:00
Shati Patel
9cb4d233d9
CodeQL model editor: Make "add" and "delete" buttons more intuitive ( #3123 )
2023-12-12 10:42:32 +00:00
Koen Vlaswinkel
8fac9b1413
Merge pull request #3124 from github/github-action/bump-cli
...
Bump CLI Version to v2.15.4 for integration tests
2023-12-12 10:23:57 +01:00
Nora
6c76218b21
Merge pull request #3106 from github/nora/remove-local-db-code
...
Delete local db functionality
2023-12-12 09:38:16 +01:00
github-actions[bot]
d4a4cbb4f1
Bump CLI version from v2.15.3 to v2.15.4 for integration tests
2023-12-11 16:54:11 +00:00
Koen Vlaswinkel
3a8beb9ab9
Suppress github/a11y-no-title-attribute violation
...
This requires more work, but for now we just suppress the violation.
2023-12-11 17:05:39 +01:00
Koen Vlaswinkel
afdd20a957
Fix github/a11y-svg-has-accessible-name violation
2023-12-11 17:03:21 +01:00
Koen Vlaswinkel
bf5398bfc9
Fix import/no-named-as-default violations
2023-12-11 17:02:20 +01:00
Koen Vlaswinkel
01085e75ba
Automatically fix ESLint violations
2023-12-11 17:00:16 +01:00
Koen Vlaswinkel
7f332e3374
Add retryCount to mocked Octokit responses
2023-12-11 16:41:15 +01:00
Koen Vlaswinkel
39229c26d4
Run npm upgrade
2023-12-11 16:41:15 +01:00
Kasper Svendsen
0f437f7a92
Merge pull request #3121 from github/kaspersv/port-dca-ra-parser-updates
...
Port DCA join-order badness RA parser changes
2023-12-11 15:40:08 +01:00
Kasper Svendsen
0df9a54d89
Port DCA join-order badness RA parser changes
2023-12-11 09:50:09 +01:00
Nora
4f85ac11a9
Merge pull request #3120 from github/nora/make-top-banner-sticky
...
Make model editor top banner sticky
2023-12-08 16:24:31 +01:00
Nora
118ad9d530
Fix background color
2023-12-08 15:09:36 +00:00
Nora
2a44bf78c8
Update Changelog
2023-12-08 14:13:05 +00:00
Nora
cf301aa338
Make header sticky
2023-12-08 14:10:09 +00:00
Nora
0e96941c89
Move save-refresh buttons to Header
2023-12-08 14:09:50 +00:00
Koen Vlaswinkel
f596f7ee74
Merge pull request #3117 from github/koesie10/fix-ruby-modules
...
Add support for models on types for Ruby
2023-12-08 14:42:23 +01:00
Koen Vlaswinkel
87e42b499d
Merge pull request #3119 from github/koesie10/update-ruby-query
...
Update model editor Ruby queries
2023-12-08 14:00:07 +01:00
Nora
8acff5ce72
Remove from other files
2023-12-08 12:42:27 +00:00
Koen Vlaswinkel
47797eb7e6
Update model editor Ruby queries
2023-12-08 11:47:52 +01:00
Koen Vlaswinkel
0a4d28e9f0
Fix empty method names in output for Ruby
...
This fixes the output of the Ruby MaD models when the method name is
empty which can happen when the model applies to a type rather than to
a method.
2023-12-07 16:51:58 +01:00
Koen Vlaswinkel
01956072b3
Fix rendering of method names
...
This fixes the rendering of method names when either the type or method
name is empty. This can happen when the method is a not in a class or
when the method is a synthetic method and the properties actually apply
to the type.
2023-12-07 16:51:58 +01:00
Koen Vlaswinkel
49114cc143
Add interpreted results table to compare view
2023-12-07 10:56:51 +01:00
Koen Vlaswinkel
789719a26c
Merge pull request #3115 from github/koesie10/compare-messages
...
Split compare view messages
2023-12-07 10:54:23 +01:00
Koen Vlaswinkel
8d711624bb
Merge remote-tracking branch 'origin/main' into koesie10/compare-messages
2023-12-07 10:39:28 +01:00
Koen Vlaswinkel
7b6b303040
Merge pull request #3111 from github/koesie10/compare-raw
...
Add interpreted results type to compare view
2023-12-07 10:35:41 +01:00
Koen Vlaswinkel
86aa4ffb6f
Merge pull request #3114 from github/koesie10/compare-default
...
Change compare view default selected result set
2023-12-07 10:21:24 +01:00
Koen Vlaswinkel
1235172147
Rename type to kind
2023-12-07 10:20:00 +01:00
Koen Vlaswinkel
4873d7eb12
Fix postMessage beint sent before webview is loaded
2023-12-06 16:21:16 +01:00
Koen Vlaswinkel
27418898b0
Cache common result set names
...
This caches the common result set names and moves the common result set
names from the `SetComparisonsMessage` to the
`SetComparisonQueryInfoMessage`.
2023-12-06 16:08:25 +01:00
Koen Vlaswinkel
3554bceac0
Split compare view messages
...
This splits the compare view messages into two different messages. One
contains the metadata that doesn't change when the user selects a
different result set, and the other contains the actual results.
2023-12-06 16:07:26 +01:00
Koen Vlaswinkel
71d4fd7b0a
Change compare view default result set name
...
This changes the default result set that is selected in the compare view
to the same as the default result set in the results view. This will
select `#select` by default for most queries, rather than the first
result set, which could be `edges` or `nodes` for some queries.
2023-12-06 15:10:49 +01:00
Koen Vlaswinkel
151c031732
Merge pull request #3110 from github/koesie10/result-styled
...
Switch to styled-components for some components in the results view
2023-12-06 14:35:20 +01:00
Koen Vlaswinkel
af68d99509
Add interpreted results type to compare view
2023-12-06 12:33:18 +01:00
Koen Vlaswinkel
3f2114a7f0
Extract octicons to components
2023-12-06 11:59:01 +01:00
Koen Vlaswinkel
4f14592dd7
Extract vscode-codeql__vertical-rule class to component
2023-12-06 11:58:32 +01:00
Koen Vlaswinkel
acca6b34f8
Remove vscode-codeql__title class
2023-12-06 11:58:32 +01:00
Koen Vlaswinkel
f847c36fb7
Remove vscode-codeql__result-table-location-link class
...
This seems to be unused.
2023-12-06 11:58:31 +01:00
Koen Vlaswinkel
1ed72c6bbe
Switch to styled-components for EmptyQueryResultsMessage
2023-12-06 11:58:20 +01:00
Koen Vlaswinkel
d72f3f40d2
Merge pull request #3108 from github/koesie10/compare-styled
...
Switch to styled-components for compare components
2023-12-06 11:57:27 +01:00
Koen Vlaswinkel
4a46873dd3
Merge remote-tracking branch 'origin/main' into koesie10/compare-styled
2023-12-06 11:42:29 +01:00
Nora
acbd973bd2
db-manager: remove tests and functionality
2023-12-06 10:36:50 +00:00
Koen Vlaswinkel
4a321708db
Merge pull request #3107 from github/koesie10/fix-compare-loading-message
...
Fix loading message for compare view
2023-12-06 11:33:52 +01:00
Charis Kyriakou
3f07082e55
Add note in Model with AI test case in test plan ( #3109 )
2023-12-06 10:23:33 +00:00
Koen Vlaswinkel
80081af377
Merge pull request #3105 from github/koesie10/create-raw-compare-result-table
...
Extract `RawCompareResultTable` component
2023-12-06 11:21:19 +01:00
Koen Vlaswinkel
a42e9ebbf1
Update CHANGELOG
2023-12-06 11:19:04 +01:00
Nora
9f667ef2d2
db-panel: remove tests and functionality
2023-12-06 10:18:35 +00:00
Koen Vlaswinkel
b421a1916c
Switch to styled-components for compare components
2023-12-06 11:04:45 +01:00
Koen Vlaswinkel
ddf4407c8c
Fix loading message for compare view
2023-12-06 10:59:30 +01:00
Koen Vlaswinkel
aa9cb89369
Extract RawCompareResultTable component
2023-12-06 10:51:03 +01:00
Koen Vlaswinkel
cce858561f
Merge pull request #3103 from github/koesie10/compare-view-results
...
Move columns in compare view to result
2023-12-06 09:57:30 +01:00
Koen Vlaswinkel
f4cc9f9fbb
Move columns in compare view to result
...
The columns are part of the result, so they should be moved there. This
is in preparation of showing SARIF results in the same view, which don't
have columns.
2023-12-05 16:55:54 +01:00
Koen Vlaswinkel
9c200e036a
Merge pull request #3102 from github/koesie10/refactor-compare-view
...
Refactor compare view
2023-12-05 16:49:45 +01:00
Koen Vlaswinkel
3020bf711b
Merge pull request #3094 from github/koesie10/remove-legacy-query-server
...
Remove the legacy query server
2023-12-05 12:08:54 +01:00
Koen Vlaswinkel
b1289a4598
Rename findCommonResultSetNames to findResultSetsToCompare
2023-12-05 11:02:27 +01:00
Koen Vlaswinkel
da8d32c4bc
Return object from findCommonResultSetNames
2023-12-05 11:02:27 +01:00
Koen Vlaswinkel
f3a0ad2e18
Use BQRS types for compare view
2023-12-05 11:02:27 +01:00
Koen Vlaswinkel
331d39afcf
Cache BQRS schemas in compare view
2023-12-05 10:26:24 +01:00
Koen Vlaswinkel
b6ba0bbcb9
Create showResultsInternal method
2023-12-05 10:24:15 +01:00
Koen Vlaswinkel
496d05c900
Create findResultSetNames function
2023-12-05 10:21:57 +01:00
Koen Vlaswinkel
76534bccd7
Add comment to formatLegacyMessage
2023-12-04 10:58:57 +01:00
dependabot[bot]
d28cc6e3f2
Bump @adobe/css-tools from 4.3.1 to 4.3.2 in /extensions/ql-vscode ( #3098 )
...
Bumps [@adobe/css-tools](https://github.com/adobe/css-tools ) from 4.3.1 to 4.3.2.
- [Changelog](https://github.com/adobe/css-tools/blob/main/History.md )
- [Commits](https://github.com/adobe/css-tools/commits )
---
updated-dependencies:
- dependency-name: "@adobe/css-tools"
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-01 09:45:35 -08:00
dependabot[bot]
a6703e11e3
Bump cosmiconfig from 8.2.0 to 9.0.0 in /extensions/ql-vscode ( #3095 )
...
Bumps [cosmiconfig](https://github.com/cosmiconfig/cosmiconfig ) from 8.2.0 to 9.0.0.
- [Release notes](https://github.com/cosmiconfig/cosmiconfig/releases )
- [Changelog](https://github.com/cosmiconfig/cosmiconfig/blob/main/CHANGELOG.md )
- [Commits](https://github.com/cosmiconfig/cosmiconfig/compare/v8.2.0...v9.0.0 )
---
updated-dependencies:
- dependency-name: cosmiconfig
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-30 10:00:28 -08:00
Koen Vlaswinkel
cf6abc43b1
Remove unused legacy messages
2023-11-28 16:35:30 +01:00
Koen Vlaswinkel
ce20c7f6a4
Remove legacy query server
2023-11-28 16:11:26 +01:00
Koen Vlaswinkel
b8ec847253
Add tests for bqrsToResultSet
2023-11-27 14:25:59 +01:00
Koen Vlaswinkel
a0c85b78c5
Rename bqrs-result to bqrs-raw-results-mapper
2023-11-27 14:14:55 +01:00
Koen Vlaswinkel
f0a354917e
Fix tests
2023-11-27 14:14:04 +01:00
Koen Vlaswinkel
082c5e4a31
Prefix BQRS types with Bqrs
2023-11-27 13:38:04 +01:00
Koen Vlaswinkel
439cfcc023
Remove getResultSetSchema function
2023-11-27 13:38:04 +01:00
Koen Vlaswinkel
297f5a9f67
Remove schema from interpreted results type
2023-11-27 13:38:04 +01:00
Koen Vlaswinkel
e7c79f04c6
Remove dead code
2023-11-27 13:38:04 +01:00
Koen Vlaswinkel
76529572f5
Switch AST viewer to use new result types
2023-11-27 13:38:04 +01:00
Koen Vlaswinkel
63d6793795
Remove some unused BQRS methods/argument type unions
2023-11-27 13:38:04 +01:00
Koen Vlaswinkel
fc2e6d0432
Use new raw result types in result and compare views
2023-11-27 13:38:04 +01:00
Koen Vlaswinkel
cb707aea50
Use new raw result types for variant analyses
2023-11-27 13:38:04 +01:00
Koen Vlaswinkel
cd26f27e6e
Introduce raw result types
2023-11-27 13:38:04 +01:00
Robert
3c98f94d3e
Merge pull request #3091 from MathiasVP/autocomplete-to-new-dataflow-and-taint-tracking
...
Change dataflow and taint-tracking snippets to match the module-based API
2023-11-27 11:55:45 +00:00
Mathias Vorreiter Pedersen
558f7f6dbf
No need for a whitespace on a blank line.
2023-11-27 10:55:32 +00:00
Mathias Vorreiter Pedersen
0d4dbb059b
Update change log.
2023-11-24 18:02:40 +00:00
Mathias Vorreiter Pedersen
291bdbec8d
Change dataflow and taint-tracking snippets to match the module-based API.
2023-11-24 17:51:56 +00:00
Koen Vlaswinkel
98b30af0a0
Merge pull request #3090 from github/koesie10/silent-resolve-tests
...
Silence `resolve tests` command
2023-11-24 16:56:56 +01:00
Koen Vlaswinkel
992079d99f
Merge pull request #3089 from github/koesie10/eslint-curly
...
Enable ESLint `curly` rule
2023-11-24 16:08:22 +01:00
Koen Vlaswinkel
d5e7e54293
Merge pull request #3086 from github/koesie10/fix-cli-tests
...
Fix tests with `workspaceContains:.git` activation event
2023-11-24 15:57:23 +01:00
Koen Vlaswinkel
d0d12b78b2
Merge pull request #3081 from github/koesie10/github-databases-directory
...
Move GitHub databases files to separate directory
2023-11-24 15:44:56 +01:00
Koen Vlaswinkel
2e06fa3f5f
Remove ensureDir call
2023-11-24 15:38:22 +01:00
Koen Vlaswinkel
cab510f2dd
Introduce forceUpdateConfiguration method
2023-11-24 15:36:27 +01:00
Koen Vlaswinkel
5e6b7d846e
Rename GitHubDatabaseModule to GitHubDatabasesModule
2023-11-24 15:31:33 +01:00
Koen Vlaswinkel
85d7b9b2fe
Merge pull request #3088 from github/koesie10/locations-preserve-focus
...
Preserve focus on results viewer when showing location
2023-11-24 15:04:27 +01:00
Koen Vlaswinkel
08721179dc
Silence resolve tests command
...
This hides that the `resolve tests` command is run from the user, as it
is run as part of a background process and spams the log.
2023-11-24 14:46:12 +01:00
Koen Vlaswinkel
918661e5ce
Enable ESLint curly rule
...
This enables [the ESLint `curly` rule](https://eslint.org/docs/latest/rules/curly )
with its options set to `all`. This enforces curly braces around all
blocks, even single-line ones.
I've used `npm run lint -- --fix` to fix all occurences.
2023-11-24 14:38:32 +01:00
Koen Vlaswinkel
6324a19729
Update CHANGELOG
2023-11-24 14:21:03 +01:00
Koen Vlaswinkel
bbc77c0519
Preserve focus on results viewer when showing location
...
This preserves the focus on the results viewer when showing a location
to ensure that the user can navigate to the next result without having
to click or change the focus to the results viewer first. This allows
the user to quickly navigate through the results.
2023-11-24 14:19:20 +01:00
Koen Vlaswinkel
54be065f3e
Fix tests with workspaceContains:.git activation event
...
It seems like changes to the CLI path setting are not picked up by the
extension when it is already activated. This is probably because the
`workspace.onDidChangeConfiguration` event is not fired when the update
is made programmatically.
This fixes it by manually firing the event so that all listeners (CLI
server, query server, IDE server) can pick up the change.
2023-11-24 11:15:54 +01:00
Koen Vlaswinkel
829607f044
Move GitHub databases files to separate directory
2023-11-24 10:34:49 +01:00
Koen Vlaswinkel
c3425b5146
Merge pull request #3087 from github/koesie10/drop-support-cli
...
Drop support for CLI versions < v2.11.6
2023-11-24 10:32:12 +01:00
Koen Vlaswinkel
ec192affdc
Update CHANGELOG
2023-11-23 14:04:50 +01:00
Koen Vlaswinkel
66ae46f67c
Drop support for CLI versions < v2.11.6
2023-11-23 14:04:50 +01:00
Shati Patel
424e8d3145
Discourage use of "Quick query" in single-folder workspaces ( #3082 )
2023-11-23 11:22:44 +00:00
Koen Vlaswinkel
208efb57d3
Merge pull request #3079 from github/koesie10/update-github-databases
...
Add prompt for updating GitHub databases
2023-11-23 12:16:58 +01:00
Koen Vlaswinkel
4f988de36d
Update tests for isNewerDatabaseAvailable
2023-11-23 10:27:28 +01:00
Koen Vlaswinkel
e66d76aca8
Consider created_at for database updates
2023-11-23 10:17:07 +01:00
Koen Vlaswinkel
5d1b2926cc
Add comment about update check
2023-11-23 10:14:04 +01:00
Koen Vlaswinkel
7b3a55e2bf
Refactor handling of updateStatus
2023-11-23 10:11:36 +01:00
Koen Vlaswinkel
560008c55e
Merge pull request #3085 from github/koesie10/remove-activation-event
...
Remove workspaceContains:.git activation event
2023-11-23 09:51:04 +01:00
Koen Vlaswinkel
b81061a8a1
Remove workspaceContains:.git activation event
2023-11-23 09:37:09 +01:00
Florin Coada
c09c26d2b3
Update CHANGELOG.md ( #3084 )
...
Updated documentation link. Original was not working.
2023-11-22 15:24:55 +00:00
github-actions[bot]
7970b09134
Bump CLI version from v2.15.2 to v2.15.3 for integration tests ( #3083 )
2023-11-22 14:59:42 +00:00
Koen Vlaswinkel
0523d2a63d
Merge pull request #3073 from github/koesie10/download-multiple-github-databases
...
Allow downloading multiple databases from GitHub
2023-11-21 11:42:06 +01:00
Nora
8aae7d30d3
Merge pull request #3078 from github/dependabot/npm_and_yarn/extensions/ql-vscode/adobe/css-tools-4.3.1
...
Bump @adobe/css-tools from 4.0.1 to 4.3.1 in /extensions/ql-vscode
2023-11-20 16:29:45 +01:00
Koen Vlaswinkel
a0295d62f8
Add prompt for updating GitHub databases
2023-11-20 14:52:47 +01:00
Koen Vlaswinkel
4f51445609
Merge remote-tracking branch 'origin/main' into koesie10/download-multiple-github-databases
2023-11-20 14:47:18 +01:00
Koen Vlaswinkel
01d24e06f3
Merge pull request #3072 from github/koesie10/download-github-database-authentication
...
Use credentials for database download in non-canary mode
2023-11-20 14:40:06 +01:00
Koen Vlaswinkel
b83ef4ed68
Split up listing of databases to separate function
2023-11-20 14:20:48 +01:00
Koen Vlaswinkel
9dd061b2c8
Rename github-database-prompt to github-database-download
2023-11-20 13:37:05 +01:00
Koen Vlaswinkel
feca898c85
Merge remote-tracking branch 'origin/main' into koesie10/download-github-database-authentication
2023-11-20 11:14:13 +01:00
Koen Vlaswinkel
422f0eb7e4
Merge pull request #3071 from github/koesie10/download-github-database
...
Prompt user for database download on startup
2023-11-20 11:08:32 +01:00
Koen Vlaswinkel
5c03f5b43e
Do not split up message
2023-11-20 10:27:18 +01:00
Koen Vlaswinkel
9ca138dc8e
Rename function to promptAndDownloadGitHubDatabase
2023-11-20 10:23:16 +01:00
dependabot[bot]
40b1755868
Bump @adobe/css-tools from 4.0.1 to 4.3.1 in /extensions/ql-vscode
...
Bumps [@adobe/css-tools](https://github.com/adobe/css-tools ) from 4.0.1 to 4.3.1.
- [Changelog](https://github.com/adobe/css-tools/blob/main/History.md )
- [Commits](https://github.com/adobe/css-tools/commits )
---
updated-dependencies:
- dependency-name: "@adobe/css-tools"
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-11-20 08:40:18 +00:00
Koen Vlaswinkel
d0488ddda9
Allow downloading multiple databases from GitHub
...
This adds the option to download multiple databases from GitHub in the
initial GitHub database download prompt. The databases will be
downloaded concurrently.
Unfortunately it doesn't seem possible to change the "OK" text in the
quick pick to "Download", so I've left it as "OK" for now.
2023-11-17 14:50:59 +01:00
Koen Vlaswinkel
5d42cbc1c8
Also use credentials in non-canary mode
...
We want users to be able to download databases from private/internal
repositories without using canary mode. This will change the prompt to
ask for credentials in non-canary mode as well.
2023-11-17 14:47:43 +01:00
Koen Vlaswinkel
636f8f1b5f
Prompt user for database download on startup
2023-11-17 14:45:35 +01:00
Koen Vlaswinkel
c0db180200
Merge pull request #3068 from github/koesie10/find-github-repository
...
Add finding of GitHub repositories in workspace
2023-11-17 14:37:53 +01:00
github-actions[bot]
383a1215b4
Bump version to v1.10.1 ( #3077 )
2023-11-16 18:20:26 +00:00
Shati Patel
0994c3e95f
Merge pull request #3076 from github/v1.10.0
...
v1.10.0
2023-11-16 15:51:25 +00:00
Koen Vlaswinkel
fe0c10aa89
Merge remote-tracking branch 'origin/main' into koesie10/find-github-repository
2023-11-16 16:49:35 +01:00
Koen Vlaswinkel
5db1f76c55
Add tests for more Git state scenarios
2023-11-16 16:49:02 +01:00
Koen Vlaswinkel
779faa324c
Improve heuristic and comments
2023-11-16 16:42:09 +01:00
Koen Vlaswinkel
f23bc81712
Add comment about initialize method
2023-11-16 16:37:25 +01:00
Koen Vlaswinkel
704894471b
Fix error when Git extension is disabled
2023-11-16 16:37:25 +01:00
Koen Vlaswinkel
a04f70e162
Fix error logging
2023-11-16 16:37:25 +01:00
Koen Vlaswinkel
a150643cdf
Change log message when repository is not found
2023-11-16 16:37:24 +01:00
shati-patel
bb9a808019
v1.10.0
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2023-11-16 14:22:20 +00:00
Koen Vlaswinkel
0323325015
Improve comments on findRemote
2023-11-16 13:37:01 +01:00
Shati Patel
d3608159b8
Remove feature flags for queries panel + language selector ( #3075 )
2023-11-16 10:55:24 +00:00
Koen Vlaswinkel
ec7640f337
Merge pull request #3074 from github/koesie10/octokit-rest-codeql-databases
...
Use Octokit REST for listing CodeQL databases
2023-11-16 09:23:46 +01:00
Koen Vlaswinkel
f8fa863b93
Use Octokit REST for listing CodeQL databases
...
This switches the request to the GitHub API for listing CodeQL databases
from a custom request to the Octokit REST API. This allows us to be more
type-safe without introducing our own types.
The update to `@octokit/openapi-types` was necessary to have access to
the `commit_oid` field.
2023-11-15 17:11:24 +01:00
Koen Vlaswinkel
6fc567b5b9
Merge pull request #3066 from github/koesie10/add-database-source
...
Add origin metadata to database items
2023-11-15 16:12:32 +01:00
Koen Vlaswinkel
7fe707a42d
Add database id and created_at to origin
2023-11-15 14:54:00 +01:00
Shati Patel
a271f7b36e
Fix minor bugs with queries panel + language selector ( #3070 )
2023-11-14 13:29:41 +00:00
Shati Patel
144033967d
Rename "allowHttp" setting ( #3069 )
2023-11-14 11:44:46 +00:00
Charis Kyriakou
be2891dfba
Replace ModelEditorViewTracker with modeling store and events ( #3065 )
2023-11-14 11:38:28 +00:00
Koen Vlaswinkel
0b964f06d8
Merge remote-tracking branch 'origin/main' into koesie10/add-database-source
2023-11-14 10:06:27 +01:00
Koen Vlaswinkel
5df9dfc78a
Rename source to origin
2023-11-14 10:04:05 +01:00
Shati Patel
9e914c9ba1
Don't add database source archive folders by default ( #3047 )
2023-11-13 16:04:53 +00:00
Koen Vlaswinkel
019195b38c
Add finding of GitHub repositories in workspace
2023-11-13 17:04:08 +01:00
github-actions[bot]
5770eda466
Bump CLI version from v2.15.1 to v2.15.2 for integration tests ( #3067 )
2023-11-13 15:16:43 +00:00
Charis Kyriakou
3ac8a816ef
Update provenance when inputs change ( #3064 )
2023-11-13 14:55:20 +00:00
Robert
ab4717c540
Merge pull request #3060 from github/robertbrignull/noUnusedParameters
...
Enable noUnusedParameters for the view code
2023-11-13 11:24:11 +00:00
Shati Patel
934ed82786
Don't create QL pack if user escapes out of prompt ( #3062 )
2023-11-13 10:44:21 +00:00
Koen Vlaswinkel
bca7ecb782
Add source to database item
...
This adds a source property to the database item to store the source of
the database, for example GitHub or an internet URL. This will be used
to automatically check for updates to GitHub-downloaded databases in the
future.
2023-11-13 11:13:41 +01:00
Koen Vlaswinkel
bc2847a12e
Merge pull request #3057 from github/koesie10/contextual-no-submodule
...
Make contextual queries work for fresh installs
2023-11-13 09:41:06 +01:00
Charis Kyriakou
28994b7bd8
Merge pull request #3059 from github/charisk/accepted-models
...
Differentiate between suggestions and accepted models
2023-11-10 10:25:28 +00:00
Charis Kyriakou
6de96b46ec
Take into account that not all modeled methods have provenance
2023-11-10 09:35:37 +00:00
Charis Kyriakou
692dd02652
Add logic to change style for non-accepted suggestions
2023-11-10 09:35:05 +00:00
Charis Kyriakou
271808a635
Pass modeling status down to drop-down components
2023-11-10 09:34:38 +00:00
Koen Vlaswinkel
64a073368f
Merge pull request #3048 from github/koesie10/type-model
...
Add `type` as modeled method type
2023-11-10 10:21:29 +01:00
Koen Vlaswinkel
ddaabfa0cc
Merge remote-tracking branch 'origin/main' into koesie10/type-model
2023-11-10 09:47:57 +01:00
Charis Kyriakou
f9e06540e4
Merge pull request #3063 from github/robertbrignull/releasing
...
Add instructions for releasing from a branch other than main
2023-11-10 08:24:22 +00:00
Shati Patel
b5b1106e85
Minor tidy-up for local-databases tests ( #3058 )
2023-11-10 08:23:58 +00:00
Robert
3d124f71d3
Remove trailing spaces
2023-11-09 09:39:12 +00:00
Robert
784cff4746
Add note to make sure main is up to date
2023-11-08 18:03:54 +00:00
Robert
5fa5ca3799
Add blank lines around fenced code blocks
2023-11-08 18:02:28 +00:00
Robert
4aee6633b8
Add note about conflicts in the changelog
2023-11-08 17:01:41 +00:00
Robert
d02b1e4dcb
Remove branching instructions for regular/minimal releases
2023-11-08 16:40:36 +00:00
Robert
e90b136e22
Include git command for creating release branch off of previous release tag
2023-11-08 16:39:41 +00:00
Robert
c9f9f62bc7
Add instructions for releasing from a branch other than main
2023-11-08 12:38:26 +00:00
Robert
6af9e7bf4a
Enabled noUnusedParameters in src/view/tsconfig.json
2023-11-07 16:18:15 +00:00
Robert
9c51d1b54f
Remove title prop from ClickableLocation
2023-11-07 16:17:54 +00:00
Robert
814ba246f8
Remove unused parameter from listerer
2023-11-07 16:17:23 +00:00
Robert
427940d3d6
Remove unused index from map call
2023-11-07 16:17:08 +00:00
Robert
9cabb1f460
Remove packageName prop from ModeledMethodDataGrid
2023-11-07 16:15:52 +00:00
Robert
350e5aebd6
Remove label prop from DeterminateProgressRing
2023-11-07 16:14:53 +00:00
Shati Patel
429f9a17d4
Sort databases by name if their languages are the same ( #3055 )
2023-11-06 16:03:33 +00:00
Anders Starcke Henriksen
1c19d7a2e1
Merge pull request #3056 from github/version/bump-to-v1.9.5
...
Bump version to v1.9.5
2023-11-06 16:15:29 +01:00
Koen Vlaswinkel
8464892ac0
Make contextual queries work for fresh installs
...
This fixes the contextual queries when you are not in a workspace with
the submodule and do not have any downloaded packs in the package cache.
In that case, the contextual queries would fail because they weren't
able to determine which pack belonged to the database.
This fixes it by downloading the `codeql/${language}-all` pack in case
no dbscheme is found for the database. After the download is complete,
it will return the expected value for the qlpacks. This should work in
almost all cases (at least for standard languages).
2023-11-06 15:58:07 +01:00
github-actions[bot]
a392a179f9
Bump version to v1.9.5
2023-11-06 14:32:49 +00:00
Anders Starcke Henriksen
69ff2ed30c
Merge pull request #3054 from github/v1.9.4
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.9.4
2023-11-06 15:04:41 +01:00
Anders Starcke Henriksen
0884eb83ec
v1.9.4
2023-11-06 14:41:42 +01:00
Kasper Svendsen
1fa7a93ec7
Merge pull request #3051 from github/kaspersv/parse-quoted-ra-idents
...
Extend join order badness RA parser
2023-11-06 13:50:46 +01:00
Koen Vlaswinkel
18d7fae817
Merge pull request #3053 from github/koesie10/ruby-arguments
...
Add support for Ruby keyword arguments
2023-11-06 10:59:27 +01:00
Koen Vlaswinkel
b3c5afbe4e
Merge pull request #3052 from github/koesie10/argument-self
...
Extract creation of method argument options to languages
2023-11-06 10:59:20 +01:00
Koen Vlaswinkel
557110d71d
Use readonly dropdowns for showing type models
2023-11-03 15:57:09 +01:00
Koen Vlaswinkel
5f2a32ac8e
Add support for Ruby keyword arguments
...
Ruby keyword arguments are represented differently than positional
arguments in the MaD format: they are represented as `Method[key:]`. The
framework endpoints query also returns the name as `key:`, so we can
detect these and format them as such.
2023-11-03 14:08:04 +01:00
Koen Vlaswinkel
b348356876
Extract creation of method argument options to languages
...
This moves the creation of possible method argument options from the
view to the languages. This allows differentiating between the
languages, for example by using `Argument[self]` for Ruby instead of
`Argument[this]`.
2023-11-03 13:50:13 +01:00
Koen Vlaswinkel
146732fa29
Merge pull request #3049 from github/koesie10/styled-transient-props
...
Use transient props for all styled components
2023-11-03 13:14:10 +01:00
Charis Kyriakou
3cc4f5c4a4
Remove logic that sets neutral models during automodeling ( #3050 )
2023-11-03 10:38:50 +00:00
Koen Vlaswinkel
261f8b3b2c
Add type as modeled method type
...
This adds support for modeling types. A MaD language can now optionally
define a `type` predicate. This allows internally propagating these
models. The UI will now simply show a label "type" for type models
without any way to edit these.
2023-11-03 11:32:49 +01:00
Koen Vlaswinkel
4673bf56bd
Merge pull request #3043 from github/koesie10/generate-model-unify
...
Unify model generation query execution
2023-11-03 11:27:36 +01:00
Koen Vlaswinkel
2f9f2f3d39
Merge remote-tracking branch 'origin/main' into koesie10/generate-model-unify
2023-11-03 11:08:01 +01:00
Koen Vlaswinkel
acc9ab30ed
Add back 0
2023-11-03 10:48:11 +01:00
Kasper Svendsen
053708ab3b
Extend join order badness RA parser
2023-11-03 10:10:39 +01:00
Koen Vlaswinkel
45f0669b85
Use transient prop for MethodModeling component
2023-11-02 14:16:34 +01:00
Koen Vlaswinkel
65f02f1c6f
Use transient prop for CodeSnippetMessage component
2023-11-02 14:09:35 +01:00
Koen Vlaswinkel
fb45a0d409
Use transient prop for VerticalSpace component
2023-11-02 14:09:01 +01:00
Koen Vlaswinkel
3cd06021d3
Use transient prop for TextButton component
2023-11-02 14:08:29 +01:00
Koen Vlaswinkel
cd0b2fba8a
Use transient prop for HorizontalSpace component
2023-11-02 14:07:55 +01:00
Koen Vlaswinkel
1cc63382c9
Remove unnecessary props type for Dropdown
...
This removes the `disabled` prop from the `Dropdown` component. This is
already included in the default HTML props of the `select` component,
so it's not necessary to add it again.
2023-11-02 14:06:03 +01:00
Koen Vlaswinkel
8e8399988e
Use transient props for Alert component
2023-11-02 14:05:11 +01:00
Koen Vlaswinkel
eaf3a1ce1b
Merge pull request #3031 from github/koesie10/modeled-method-union
...
Switch `ModeledMethod` to union of types
2023-11-02 09:52:33 +01:00
Koen Vlaswinkel
ccaf2ad0b6
Merge remote-tracking branch 'origin/main' into koesie10/modeled-method-union
2023-11-02 09:31:15 +01:00
Charis Kyriakou
7adc114002
Remove unnecessary ModelKindDropdown input ( #3046 )
2023-11-01 15:20:50 +00:00
Charis Kyriakou
3f90564ee3
Add telemetry for method modeling panel ( #3041 )
2023-11-01 15:15:22 +00:00
Koen Vlaswinkel
5378f1afa4
Merge remote-tracking branch 'origin/main' into koesie10/modeled-method-union
2023-11-01 16:11:21 +01:00
Koen Vlaswinkel
b47c561dfa
Merge pull request #3044 from github/koesie10/fix-query-storage-path
...
Fix queries always being created in qlpack root
2023-11-01 16:02:17 +01:00
Charis Kyriakou
2f39364191
Merge pull request #3045 from github/charis/fix-broken-stories
...
Fix some broken storybook stories
2023-11-01 14:59:53 +00:00
Koen Vlaswinkel
ab67060279
Remove provenance from none modeling
2023-11-01 15:58:50 +01:00
Koen Vlaswinkel
dd8d7dfd58
Remove unnecessary nullish coalescing
2023-11-01 15:52:10 +01:00
Koen Vlaswinkel
e25398d1fa
Use createEmptyModeledMethod in more places
2023-11-01 15:51:25 +01:00
Koen Vlaswinkel
5f25fe42c3
Change error message to be distinct
2023-11-01 15:49:01 +01:00
Charis Kyriakou
5ae136bc15
Fix some broken storybook stories
2023-11-01 14:39:09 +00:00
Koen Vlaswinkel
0bec013b73
Fix queries always being created in qlpack root
...
This passes through the query storage path to the qlpack generator so
it's able to create the query in the correct selected folder.
2023-11-01 15:13:43 +01:00
Koen Vlaswinkel
ccb08e19d7
Merge pull request #3040 from github/koesie10/duplicate-query-packs
...
Prevent duplicate query packs when creating a query
2023-11-01 15:02:18 +01:00
Koen Vlaswinkel
693adb5512
Remove separation between generate queries options
2023-11-01 14:55:49 +01:00
Koen Vlaswinkel
71f59b19b4
Move model generation functions to language definition
2023-11-01 14:53:05 +01:00
Koen Vlaswinkel
2a477140a6
Move language files to separate directories
2023-11-01 14:19:01 +01:00
Koen Vlaswinkel
9387d55263
Unify model generation query running
2023-11-01 14:19:00 +01:00
Koen Vlaswinkel
8a8a85fb9a
Merge pull request #3033 from github/koesie10/generate-model
...
Add generation of Ruby models
2023-11-01 14:17:10 +01:00
Charis Kyriakou
978d8d38f1
Minor test plan fixes ( #3042 )
2023-11-01 12:17:59 +00:00
Koen Vlaswinkel
456163aba5
Prevent duplicate query packs when creating a query
...
This prevents the creation of duplicate query pack names when creating a
query in the following ways:
- When you have selected a folder, the query pack name will include the
name of the folder. This should prevent duplicate query pack names
when creating queries in different folders.
- When the folder name includes `codeql` or `queries`, we will not
add `codeql-extra-queries-` since that would be redundant.
- After generating the query pack name, we will resolve all qlpacks and
check if one with this name already exists. If it does, we will start
adding an index to the name until we find a unique name.
2023-11-01 11:03:20 +01:00
Charis Kyriakou
fe212c315c
Merge pull request #3039 from github/charisk/method-modeling-language
...
Update method modeling panel language when new db opened
2023-11-01 09:31:53 +00:00
Charis Kyriakou
57fbb8e2e6
Update method modeling panel database item when new db opened
2023-11-01 09:09:25 +00:00
Koen Vlaswinkel
6685883ebf
Merge pull request #3035 from github/koesie10/fix-ref
...
Fix scroll into view not working when revealing method
2023-11-01 09:56:44 +01:00
Koen Vlaswinkel
ad121a5f93
Merge pull request #3037 from github/koesie10/detect-language
...
Detect existing query packs when creating skeleton query
2023-11-01 09:56:24 +01:00
Charis Kyriakou
02c1d7ef9e
Add ability to use a dev endpoint for auto-model ( #3038 )
2023-11-01 08:55:56 +00:00
Charis Kyriakou
e9fb9f52d8
Update method modeling panel language when new db opened
2023-11-01 08:52:44 +00:00
Charis Kyriakou
2988aceddf
Change auto-model default batch size ( #3036 )
2023-10-31 14:46:01 +00:00
Koen Vlaswinkel
abafefdb5e
Detect existing query packs when creating skeleton query
...
This will change the skeleton query wizard to detect existing query
packs when creating a skeleton query. This allows the user to create a
query in an existing query pack that is not named
`codeql-custom-queries-{language}`.
2023-10-31 15:45:48 +01:00
Koen Vlaswinkel
d24352be0a
Merge pull request #3034 from github/koesie10/remove-extlogger-model-editor
...
Remove `extLogger` imports from model editor
2023-10-31 12:55:49 +01:00
Koen Vlaswinkel
50ae7d5b73
Fix scroll into view not working when revealing method
...
This fixes a bug where the method row would not scroll into view when
revealing a method. The problem was that the `DataGridRow` component
on which the `ref` was set is a `display: contents` element, which
does not have a visual representation in the DOM. Therefore, it wasn't
possible to scroll the method row into view. This fixes it by moving
the ref to the `DataGridCell` component of the first column, which is
a normal element.
2023-10-31 11:54:26 +01:00
Koen Vlaswinkel
8e4da4a20e
Remove extLogger imports from model editor
...
We shouldn't be directly using the `extLogger` if we have access to the
app logger (either directly or by passing it in as a parameter). This
removes all imports of `extLogger` from the model editor directory.
2023-10-31 11:32:29 +01:00
Koen Vlaswinkel
2dbc50e009
Remove use of extLogger from generate model queries
2023-10-31 11:04:17 +01:00
Koen Vlaswinkel
5c2050d9bb
Extract addModeledMethodsFromArray method
2023-10-31 10:31:54 +01:00
Koen Vlaswinkel
bb104b53ba
Rename showFlowGeneration to showGenerateButton
2023-10-31 10:31:54 +01:00
Koen Vlaswinkel
474ec197a0
Add generation of Ruby models
...
This adds the ability to generate Ruby models from a database. It uses
the `GenerateModel.ql` query to do this. The query will essentially
return data in the data extensions format, so this will just parse it
and return it as `ModeledMethod` objects.
2023-10-31 10:23:36 +01:00
Shati Patel
135bce889e
Minor fixes to testing.md ( #3032 )
2023-10-30 16:15:39 +00:00
Koen Vlaswinkel
b1aa5914c2
Merge pull request #3017 from hmac/hmac-model-editor-ruby
...
Add experimental model editor support for Ruby
2023-10-30 16:36:15 +01:00
Koen Vlaswinkel
80ae27a453
Extract isSupportedLanguage function
2023-10-30 16:08:00 +01:00
Koen Vlaswinkel
ba1bdacb50
Use INITIAL_MODE instead of hardcoding mode
2023-10-30 15:58:20 +01:00
Koen Vlaswinkel
98b0850f68
Switch ModeledMethod to union of types
...
This allows more disjointed models to be represented more accurately,
such as type models.
2023-10-30 14:26:47 +01:00
Koen Vlaswinkel
c482f2a058
Merge pull request #3025 from github/dependabot/npm_and_yarn/extensions/ql-vscode/msw-2.0.0
...
Bump msw from 0.0.0-fetch.rc-9 to 2.0.0 in /extensions/ql-vscode
2023-10-30 13:07:56 +01:00
Koen Vlaswinkel
f0efebbbc4
Merge pull request #3026 from github/koesie10/ask-for-display-language
...
Use language display name when asking for language
2023-10-30 11:58:57 +01:00
Koen Vlaswinkel
5e0caded52
Merge pull request #3016 from github/koesie10/improve-skeleton-db-download
...
Improve database download prompt when creating query
2023-10-30 11:58:01 +01:00
Koen Vlaswinkel
0951dde2c4
Implement changes for MSW 2.0.0
2023-10-30 11:28:51 +01:00
Nora
33992129ed
Merge pull request #3029 from github/nora/progress-reporting-code-search
...
Code Search: use withProgress to indicate api request progress
2023-10-27 17:09:57 +02:00
Nora
5caf11e7b7
Polish naming
2023-10-27 14:51:16 +00:00
Koen Vlaswinkel
43e60b20db
Merge pull request #3030 from github/koesie10/fix-data-flow-paths-dropdown
...
Fix data flow path dropdown not updating
2023-10-27 16:48:02 +02:00
Koen Vlaswinkel
c77a57f383
Store available modes per language
2023-10-27 15:50:46 +02:00
Koen Vlaswinkel
92ad718df1
Fix data flow path dropdown not updating
2023-10-27 14:40:19 +02:00
Nora
5c3c8ffa1b
use withProgress
2023-10-27 12:28:47 +00:00
Koen Vlaswinkel
712b55768f
Hide "Model as application" button for Ruby
2023-10-27 12:42:09 +02:00
Koen Vlaswinkel
8c7273efc6
Add Ruby queries as included queries for model editor
...
This adds the current version of the queries for Ruby to the model
editor included queries. This makes it work without needing to check out
a separate branch of the CodeQL repository/submodule. I've removed most
commented out code from the queries, but the other parts should match.
2023-10-27 12:39:59 +02:00
Koen Vlaswinkel
dde417ea7d
Start model editor in framework mode for Ruby
2023-10-27 12:38:13 +02:00
Koen Vlaswinkel
b023431626
Add feature flag for Ruby in the model editor
...
This only makes Ruby available in the model editor when the following
is set in the settings.json (workspace or user) file:
```json5
{
"codeQL.model.enableRuby": true,
}
```
2023-10-27 12:37:14 +02:00
Harry Maclean
9c5a963495
Add experimental model editor support for Ruby
...
Make the minimum changes necessary for prototype Ruby support in the
model editor.
This consists of:
- Reading/writing modelled methods from/to data extensions in the
dynamic languages format
- Special-casing Ruby in a few places where Java/C# was previously
assumed.
2023-10-27 12:36:22 +02:00
Koen Vlaswinkel
a3735c21a1
Use language display name for downloading databases
2023-10-27 12:32:34 +02:00
Koen Vlaswinkel
5ca084be91
Use language display name when asking for language
2023-10-27 12:08:46 +02:00
Koen Vlaswinkel
f4a2d8572c
Merge pull request #3028 from github/koesie10/bqrs-decode-languages
...
Use MaD definition when decoding BQRS
2023-10-27 11:58:48 +02:00
Koen Vlaswinkel
ecb2503992
Use MaD definition when decoding BQRS
...
This will use the MaD's definition of a method signature when decoding
BQRS files. This will allow us to change the method signature definition
for dynamic languages.
2023-10-27 11:39:46 +02:00
Koen Vlaswinkel
b9fa79a76e
Move predicates into a separate property
2023-10-27 11:29:29 +02:00
Koen Vlaswinkel
14c6f98289
Merge pull request #3027 from github/koesie10/flow-generation-button
...
Only show flow generation button when supported
2023-10-27 11:12:32 +02:00
Koen Vlaswinkel
05e3f2cba6
Only show flow generation button when supported
2023-10-27 10:46:54 +02:00
Koen Vlaswinkel
1404ab45fb
Merge pull request #3020 from github/koesie10/refactor-predicates
...
Refactor model editor predicates
2023-10-27 10:39:52 +02:00
Koen Vlaswinkel
fa12671f4a
Merge remote-tracking branch 'origin/main' into koesie10/improve-skeleton-db-download
2023-10-27 10:22:31 +02:00
Koen Vlaswinkel
a8404a5b01
Throw from getModelsAsDataLanguage
2023-10-27 10:18:38 +02:00
Koen Vlaswinkel
8a87db6cb4
Use URI for open file link
2023-10-27 10:15:58 +02:00
Koen Vlaswinkel
1151432ca2
Use language display name in notifications
2023-10-27 10:07:22 +02:00
Koen Vlaswinkel
42f1e81fdc
Handle errors when downloading database
2023-10-27 10:04:37 +02:00
Koen Vlaswinkel
edbc65886d
Use tryGetQueryLanguage function
2023-10-27 09:50:08 +02:00
Koen Vlaswinkel
407825e1cf
Merge pull request #3021 from github/koesie10/external-api-to-model-editor
...
Rename external API methods/files/errors to model editor
2023-10-27 09:37:49 +02:00
dependabot[bot]
325cc05f36
Bump actions/setup-node from 3 to 4 ( #3024 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](https://github.com/actions/setup-node/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-26 11:02:49 -07:00
dependabot[bot]
721d971a66
Bump msw from 0.0.0-fetch.rc-9 to 2.0.0 in /extensions/ql-vscode
...
Bumps [msw](https://github.com/mswjs/msw ) from 0.0.0-fetch.rc-9 to 2.0.0.
- [Release notes](https://github.com/mswjs/msw/releases )
- [Changelog](https://github.com/mswjs/msw/blob/main/CHANGELOG.md )
- [Commits](https://github.com/mswjs/msw/compare/v0.0.0-fetch.rc-9...v2.0.0 )
---
updated-dependencies:
- dependency-name: msw
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-26 13:28:50 +00:00
github-actions[bot]
cc8bcbbc5d
Bump version to v1.9.4 ( #3023 )
...
Co-authored-by: github-actions[bot] <github-actions@github.com >
2023-10-26 11:20:22 +00:00
Charis Kyriakou
5375fcb26a
v1.9.3 ( #3022 )
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2023-10-26 11:11:17 +01:00
Koen Vlaswinkel
f5d86777ae
Update synthetic query pack name
2023-10-26 11:57:50 +02:00
Koen Vlaswinkel
ff36088ecc
Merge pull request #3012 from github/koesie10/use-selected-queries-item
...
Create new queries in selected folder of queries panel
2023-10-26 11:55:42 +02:00
Koen Vlaswinkel
b19e970ec5
Fix error message when running model editor queries
2023-10-26 11:43:05 +02:00
Koen Vlaswinkel
f379036c18
Fix error message for bundled model editor queries
2023-10-26 11:42:41 +02:00
Koen Vlaswinkel
30daf49cb8
Rename external-api-usage-queries.ts to model-editor-queries.ts
2023-10-26 11:41:56 +02:00
Koen Vlaswinkel
ea2999fcc7
Rename model-editor-queries.ts to model-editor-queries-setup.ts
2023-10-26 11:41:32 +02:00
Koen Vlaswinkel
c548aa0ff9
Remove unnecessary nesting in external-api-usage-query.test.ts
2023-10-26 11:40:58 +02:00
Koen Vlaswinkel
e70bceb6dd
Rename runExternalApiQueries to runModelEditorQueries
2023-10-26 11:40:26 +02:00
Koen Vlaswinkel
818e93e86b
Rename prepareExternalApiQuery to prepareModelEditorQueries
2023-10-26 11:39:06 +02:00
Koen Vlaswinkel
322b376a2c
Remove unused predicates file
2023-10-26 11:34:46 +02:00
Koen Vlaswinkel
0744b25a47
Use new language definitions for the view
2023-10-26 11:33:36 +02:00
Koen Vlaswinkel
8e721a6670
Use new language definitions for reading/writing
2023-10-26 11:33:34 +02:00
Koen Vlaswinkel
df3b94c081
Add language to model editor view
2023-10-26 11:33:10 +02:00
Koen Vlaswinkel
8a77a1fba2
Introduce separate files for predicate definitions
2023-10-26 11:33:08 +02:00
Koen Vlaswinkel
c9d1a6b447
Move predicates file to languages folder
2023-10-26 11:23:51 +02:00
Charis Kyriakou
234498a33e
Enable multiple models feature ( #3019 )
2023-10-26 09:13:25 +00:00
Koen Vlaswinkel
40a77dfd4a
Merge pull request #3018 from github/koesie10/fix-empty-location
...
Fix empty message with empty SARIF path
2023-10-26 11:04:45 +02:00
Koen Vlaswinkel
06b6595980
Update CHANGELOG
2023-10-26 10:42:11 +02:00
Shati Patel
9a97b7b0be
Deselect current db when the language context changes ( #3007 )
2023-10-25 14:54:01 +01:00
Koen Vlaswinkel
6622d5e114
Fix empty message with empty SARIF path
2023-10-25 14:55:15 +02:00
Koen Vlaswinkel
f0f5538b51
Remove check for isFolderAlreadyInWorkspace
2023-10-25 14:37:11 +02:00
Nora
3f8302796f
Merge pull request #3010 from github/nora/modeling-flow-testplan
...
Add method modeling flow to test plan
2023-10-25 14:28:59 +02:00
Koen Vlaswinkel
a3fad49577
Fix creation of nested query packs
...
Before, if you had selected a folder or file within for example
`codeql-custom-queries-java` and selected `java` as the language, it
would create a nested folder within `codeql-custom-queries-java` with
the name `codeql-custom-queries-java`. This is unexpected for the user,
who would expect a new query to be created within
`codeql-custom-queries-java`. This fixes that by checking for this
specific condition. It does not fix it for all scenarios, such as where
the selected file/folder is nested multiple levels deep within the
`codeql-custom-queries-java` folder.
2023-10-25 14:28:50 +02:00
Koen Vlaswinkel
68ab2fda2d
Create new queries in selected folder of queries panel
...
This will change the behavior of the "Create new query" command to
create the new query in the same folder as the first selected item in
the queries panel. If no items are selected, the behavior is the same
as before.
I've used events to communicate the selection from the queries panel to
the local queries module. This is some more code and some extra
complexity, but it ensures that we don't have a dependency from the
local queries module to the queries panel module. This makes testing
easier.
2023-10-25 14:28:48 +02:00
Koen Vlaswinkel
f3eefc9418
Add tests for prompting for database download
2023-10-25 14:22:55 +02:00
Koen Vlaswinkel
15a8655931
Do not prompt for database download by default
...
This changes the skeleton query wizard to not prompt for database
download after creating a query by default. Instead, it will show a
message with a button to download a database which will launch the same
prompt.
2023-10-25 14:22:55 +02:00
Koen Vlaswinkel
fb33879a95
Merge pull request #3015 from github/koesie10/reveal-file-in-queries-panel
...
Reveal opened files in queries panel
2023-10-25 13:58:08 +02:00
Nora
0e5306742d
Move test cases to optional and polish
2023-10-25 08:57:34 +00:00
Koen Vlaswinkel
3a07fa9e39
Show initially open file in queries panel
2023-10-25 10:13:48 +02:00
Koen Vlaswinkel
b6f7755908
Create subscribeToTreeSelectionEvents method
2023-10-25 10:06:14 +02:00
Koen Vlaswinkel
368f9c38ef
Only change selection when tree view is visible
2023-10-25 10:04:31 +02:00
Koen Vlaswinkel
1e58e5a723
Reveal opened file in queries panel
2023-10-25 10:04:31 +02:00
Robert
2ebccd532f
Merge pull request #3014 from github/robertbrignull/hidden_methods
...
Use the same logic for hiding methods in model editor and usages panel
2023-10-25 09:04:06 +01:00
Robert
231dcc0c55
Improve tests to cover showing supported modeled methods
2023-10-24 16:49:21 +01:00
Robert
675e2ec9f2
Use the same condition for hiding methods in model editor and usages panel
2023-10-24 16:34:39 +01:00
Shati Patel
f0f13f3569
Create query: open new query in editor before downloading DB ( #3009 )
2023-10-24 13:30:01 +00:00
Robert
8d336930c8
Merge pull request #3008 from github/robertbrignull/modeled_row_styling
...
Fix styling of "already modeled" rows when showing multiple methods
2023-10-24 14:13:18 +01:00
Koen Vlaswinkel
043cdab297
Merge pull request #3013 from github/koesie10/use-selected-language
...
Use selected language when creating query
2023-10-24 15:02:05 +02:00
Charis Kyriakou
b1172d7d64
Activate method modeling panel when model editor is opened ( #3011 )
2023-10-24 12:55:19 +01:00
Koen Vlaswinkel
8b5329fe08
Use selected language when creating query
...
This will change the "Create new query" command to use the selected
language when creating a new query. If no language is selected, it will
still prompt the user to pick a language.
2023-10-24 13:41:37 +02:00
Nora
7bade3e382
Include model panels in mandatory tests
2023-10-24 10:03:54 +00:00
Robert
eb42beee23
Move method classifications to start
2023-10-24 10:12:05 +01:00
Robert
2405628bcc
Fix span size
2023-10-24 10:11:50 +01:00
Robert
0a75a0e835
Merge pull request #2983 from github/robertbrignull/remove_selected_model
...
Handle when the number of modeled methods decreases
2023-10-23 14:34:17 +01:00
Robert
07a4ffb306
Add tests that pagination is updated when a model is removed
2023-10-23 13:50:29 +01:00
Robert
1424afc7a4
Add tests that pagination is updated when add a new model
2023-10-23 13:46:10 +01:00
Koen Vlaswinkel
c62c054b95
Merge pull request #3001 from github/koesie10/validation-errors-focus
...
Add higlight on modeled method row when clicking in validation error
2023-10-23 13:17:59 +02:00
Koen Vlaswinkel
41aeb47a4e
Merge pull request #3004 from github/koesie10/redactable-error-stack
...
Show stack for redactable error in log
2023-10-23 12:04:08 +02:00
Koen Vlaswinkel
4ca14f89df
Revert "Use os.EOL for separating stack in error"
...
This reverts commit b33b5bb7c4 .
The errors module is also imported in the webview, so we can't actually
use it.
2023-10-23 11:43:15 +02:00
Koen Vlaswinkel
8011481de2
Merge pull request #2996 from github/koesie10/query-save-dir
...
Fix results directory and evaluator log for cancelled queries
2023-10-23 10:45:41 +02:00
Koen Vlaswinkel
d682c520d5
Add tests for fullMessageWithStack
2023-10-23 10:44:25 +02:00
Koen Vlaswinkel
b33b5bb7c4
Use os.EOL for separating stack in error
2023-10-23 10:37:10 +02:00
Charis Kyriakou
1ab198fe49
Move modeling events to new ModelingEvents class ( #3005 )
2023-10-23 08:57:48 +01:00
Koen Vlaswinkel
48df8de2c2
Merge pull request #3003 from github/koesie10/fix-error-no-workspace-folders
...
Show error message for no workspace folders with model editor
2023-10-20 17:31:37 +02:00
Koen Vlaswinkel
78f832a73f
Show stack for redactable error in log
...
When calling for example `showAndLogExceptionWithTelemetry`, the stack
trace would be sent to Application Insights, but there was no way to
see the stack trace from within VS Code. This will add the stack trace
to the log by returning it from `fullMessageWithStack` and using it in
the appropriate places.
2023-10-20 16:49:36 +02:00
Koen Vlaswinkel
8c594239cd
Merge pull request #3002 from github/koesie10/jsx-key-rule
...
Enable `react/jsx-key` for fragment shorthands
2023-10-20 16:44:37 +02:00
Koen Vlaswinkel
89ccd70752
Show error message for no workspace folders with model editor
...
It is possible to open the model editor without opening a folder, but
this gave an unhelpful error message. This commit adds a more helpful
error message.
2023-10-20 16:43:58 +02:00
Koen Vlaswinkel
c928b1eb86
Enable react/jsx-key for fragment shorthands
2023-10-20 16:03:30 +02:00
Koen Vlaswinkel
faffe4590b
Add focus on modeled method row on error click
2023-10-20 11:20:14 +02:00
Koen Vlaswinkel
91f6772ab9
Add interaction to MethodRow stories
2023-10-20 10:38:44 +02:00
Dave Bartolomeo
d20cf92eea
Merge pull request #3000 from github/github-action/bump-cli
...
Bump CLI Version to v2.15.1 for integration tests
2023-10-19 13:57:08 -04:00
dependabot[bot]
1f34330052
Bump lint-staged from 14.0.0 to 15.0.2 in /extensions/ql-vscode ( #2999 )
...
Bumps [lint-staged](https://github.com/okonet/lint-staged ) from 14.0.0 to 15.0.2.
- [Release notes](https://github.com/okonet/lint-staged/releases )
- [Changelog](https://github.com/lint-staged/lint-staged/blob/master/CHANGELOG.md )
- [Commits](https://github.com/okonet/lint-staged/compare/v14.0.0...v15.0.2 )
---
updated-dependencies:
- dependency-name: lint-staged
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-19 10:39:57 -07:00
Robert
acb687cee7
Merge pull request #2997 from github/robertbrignull/model-table-validation
...
Show validation results in the model editor
2023-10-19 16:55:54 +01:00
github-actions[bot]
221b4392d3
Bump CLI version from v2.15.0 to v2.15.1 for integration tests
2023-10-19 15:44:43 +00:00
Robert
31d654d33d
Add tests of showing validation errors
2023-10-19 16:26:08 +01:00
Robert
553435d5b7
Add stories for validation errors in MethodRow
2023-10-19 16:14:41 +01:00
Robert
0af77d086a
Display validation errors in model editor
2023-10-19 12:52:45 +01:00
Robert
c69a310110
Add <> around inputs
2023-10-19 12:52:18 +01:00
Robert
1606829ceb
Make setSelectedIndex optional
2023-10-19 12:47:50 +01:00
Robert
86b50560a4
Merge pull request #2995 from github/robertbrignull/model-table-multirow
...
Use one grid cell per model input, and have the method name span multiple rows
2023-10-19 12:40:03 +01:00
Robert
50f77e7918
Use Fragment to add key to map output
2023-10-19 10:53:06 +01:00
Robert
947f495d0b
Merge pull request #2990 from github/robertbrignull/model-table-alignment
...
Use custom grid element instead of VSCodeDataGrid
2023-10-19 09:57:26 +01:00
Koen Vlaswinkel
18646ab637
Update CHANGELOG
2023-10-19 10:04:08 +02:00
Koen Vlaswinkel
046bc13fc3
Try generating evaluation log summary after failed query
...
When a local query fails (for example, if it is cancelled), it may still
have an evaluation log. We weren't generating evaluation log summaries
in these cases, so the options to view the summary text and to use the
evaluation log viewer would not be available. This fixes it by also
trying to generate the summary in the case of a failed query.
2023-10-19 10:04:08 +02:00
Koen Vlaswinkel
226274cb4e
Fix showing of raw evaluator log for cancelled items
...
This will ensure that when "Show Evaluator Log (Raw JSON)" is used on a
cancelled query history item, we will still show it if it exists. This
changes the error messages on other cases to be more specific.
2023-10-19 10:04:08 +02:00
Koen Vlaswinkel
9928c338e9
Store query output dir on history items
...
This will add the `QueryOutputDir` to the `InitialQueryInfo` and
populate it when creating a local query history item. This will allow us
to open the results directory or show the evaluator log without a
completed query.
2023-10-19 10:04:08 +02:00
Andrew Eisenberg
df55e039a1
Merge pull request #2984 from github/aeisenberg/fix-log-path
2023-10-18 15:36:10 -07:00
Andrew Eisenberg
2e2051af6d
Merge branch 'main' into aeisenberg/fix-log-path
2023-10-18 15:04:12 -07:00
Andrew Eisenberg
4ad3d962ec
Add change note
...
Also, avoid a code scanning warning.
2023-10-18 15:03:16 -07:00
Robert
ec0e74bd9a
Merge pull request #2992 from github/robertbrignull/columnCount
...
Add $ to columnCount prop used by styled component
2023-10-18 18:29:02 +01:00
dependabot[bot]
8a1da313ae
Bump @babel/traverse from 7.22.8 to 7.23.2 in /extensions/ql-vscode ( #2994 )
...
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse ) from 7.22.8 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse )
---
updated-dependencies:
- dependency-name: "@babel/traverse"
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-18 16:50:14 +01:00
Robert
c88ecf76aa
Add documentation to all DataGrid components
2023-10-18 16:42:50 +01:00
Robert
93de35e7a3
Rename HiddenMethodsText => HiddenMethodsCell
2023-10-18 16:30:30 +01:00
Robert
8c339d07e8
Pass rowType to styled component instead of using another class name
2023-10-18 16:29:48 +01:00
Robert
cead0ea52e
Import ReactNode
2023-10-18 16:26:37 +01:00
Robert
db67d93f83
Extract DataGridRow props in params
2023-10-18 16:24:34 +01:00
Robert
a79867732c
Make gridTemplateColumns just a string
2023-10-18 16:21:04 +01:00
Robert
09a8d29ea5
Use one grid cell per input
2023-10-18 15:17:07 +01:00
Shati Patel
a2f85877a8
Add option to sort DB panel by language ( #2993 )
2023-10-18 14:58:39 +01:00
Robert
c528a389e5
Use forwardRef for DataGridRow
2023-10-18 14:41:26 +01:00
Robert
48f719fa9d
Pass through data-testid explicitly
2023-10-18 14:35:49 +01:00
Robert
cac9efa41b
Introduce wrapper component for DataGridRow
2023-10-18 14:20:19 +01:00
Robert
56d0f28814
Add styling for header rows
2023-10-18 14:20:16 +01:00
Robert
298656444f
Make gridRow and gridColumn optional
2023-10-18 14:10:16 +01:00
Koen Vlaswinkel
30b51d98c8
Merge pull request #2988 from github/koesie10/error-default-branch
...
Add custom error handler for missing default branch
2023-10-18 14:12:03 +02:00
Robert
6c2718927e
Adjust styling to not use --design-unit
2023-10-18 13:02:34 +01:00
Robert
579042cf84
Extract props in parameters instead of as statement
2023-10-18 12:22:06 +01:00
Robert
2c70c0b792
Remove unnecessary aria label
2023-10-18 12:15:17 +01:00
Robert
ec64b59b96
Pass className through DataGridCell
2023-10-18 12:07:10 +01:00
Robert
f886cd0dc8
Add $ to props used by styled component
2023-10-18 11:52:01 +01:00
Robert
20469b0da4
Merge branch 'main' into robertbrignull/remove_selected_model
2023-10-18 11:43:12 +01:00
Robert
26fcef8f5d
Introduce selectNewMethod ref
2023-10-18 11:43:05 +01:00
Charis Kyriakou
96fb0046c5
Style update to in-progress drop-down ( #2986 )
2023-10-18 08:45:49 +01:00
Koen Vlaswinkel
903b272952
Merge pull request #2989 from github/koesie10/usage-panel-tree-items-reference
...
Keep reference to original items in usage data provider
2023-10-18 09:23:30 +02:00
Robert
54db867d15
Use custom grid element instead of VSCodeDataGrid
2023-10-17 17:38:06 +01:00
Koen Vlaswinkel
a852f16eb1
Keep reference to original items in usage data provider
...
This changes the usage data provider tree items to keep a reference to
the method and usage instead of only including their properties in the
tree item. This makes it easier to find the original method and usage
when revealing an item in the tree. It also removes the `getParent` call
in `getTreeItem`.
The main reason for this fix is to ensure
`codeQLModelEditor.jumpToMethod` gets the correct `usage` argument.
It received the tree item before, but now we can actually pass the
usage that was clicked on.
2023-10-17 16:03:57 +02:00
Koen Vlaswinkel
a7f8019bf4
Merge pull request #2987 from github/koesie10/source-map-fix
...
Fix decoding source map with VS Code internal files
2023-10-17 15:40:38 +02:00
Koen Vlaswinkel
2d5caa77bc
Remove unnecessary casting
2023-10-17 15:19:04 +02:00
Koen Vlaswinkel
82c2952059
Add custom error handler for missing default branch
...
When the GitHub API returns an error for a missing default branch, we
will now show a custom error message. This custom error message includes
a link to the page to create the branch. The error is detected using the
`errors` field on the response that is now being returned.
2023-10-17 14:57:19 +02:00
Koen Vlaswinkel
67f6f8f160
Fix decoding source map with VS Code internal files
...
This makes it possible to decode source maps containing references to
code that is not part of the extension. If it finds any such references,
it will simply not decode the source map and use the original stack
trace instead.
2023-10-17 13:34:11 +02:00
Charis Kyriakou
abde8f3fae
Make automodel batch size configurable ( #2985 )
2023-10-17 12:07:30 +01:00
Robert
8d5574e468
Merge pull request #2982 from github/robertbrignull/add-remove-models
...
Implement onClick for the add/remove model buttons in the model editor
2023-10-17 10:29:16 +01:00
Andrew Eisenberg
cc0e850c72
Ensure the logFileLocation is set
...
`logFileLocation` was not set after a query finishes running. I don't
know when this bug was introduced. I think it goes as far back as
the refactor to remove the old query server.
2023-10-16 16:44:49 -07:00
Robert
46e7dda6a6
Don't bother using slice when creating handlers
2023-10-16 16:29:36 +01:00
Robert
d937934737
Use the onChange handler in tests
2023-10-16 16:27:23 +01:00
Robert
96c0feb3e6
Handle when the number of modeled methods decreases
2023-10-16 16:00:49 +01:00
Robert
0ff523a64b
Add tests for for the add/remove model buttons
2023-10-16 15:36:46 +01:00
Robert
1d0a1f56b1
Implment onClick handlers for add/remove model buttons
2023-10-16 15:07:44 +01:00
Koen Vlaswinkel
fca68edbb3
Merge pull request #2969 from github/koesie10/fix-unmodeled-unsaved
...
Fix unmodeled methods always being marked as unsaved
2023-10-16 15:07:18 +02:00
Charis Kyriakou
b9279dc64f
Simplify modeling in progress state ( #2980 )
2023-10-16 12:54:13 +00:00
Koen Vlaswinkel
00b6ccdfe0
Simplify condition in useEffect
2023-10-16 13:53:53 +02:00
Koen Vlaswinkel
688b9863da
Merge pull request #2981 from github/koesie10/fix-failing-test
...
Fix failing test
2023-10-16 13:47:01 +02:00
Koen Vlaswinkel
c80641866c
Fix failing test
2023-10-16 13:25:35 +02:00
Koen Vlaswinkel
6a7ce9f4d2
Merge pull request #2976 from github/koesie10/methods-usage-panel-parent
...
Introduce separate tree item types in the methods usage panel
2023-10-16 13:25:05 +02:00
Koen Vlaswinkel
d0e0237b9e
Merge pull request #2965 from github/koesie10/modeled-method-validation-neutral
...
Fix neutral model validation to consider kind
2023-10-16 13:23:26 +02:00
Anders Starcke Henriksen
e57f04e6b1
Merge pull request #2975 from github/starcke/remove-old-language-filter
...
Remove old language context filter.
2023-10-16 13:06:40 +02:00
Charis Kyriakou
b87dfa4471
Show in-progress state in method modeling panel ( #2979 )
2023-10-16 11:47:31 +01:00
Robert
b1a4586791
Merge pull request #2977 from github/robertbrignull/fix_jump_to_usage
...
Revert changes to codeQLModelEditor.jumpToMethod to allow jumping to usages other than the first usage
2023-10-16 11:21:18 +01:00
Robert
aa8896e553
Merge pull request #2964 from github/robertbrignull/enable-add-multiple-models
...
Enable/disable the add/remove model buttons at the right times
2023-10-16 11:04:06 +01:00
Robert
9134e0e917
Add comment explaining caveats of setSelectedMethod
2023-10-16 11:03:19 +01:00
Robert
1259a3e61d
Use 'import type' in commands.ts
2023-10-16 10:59:12 +01:00
Robert
7aa0fe32c2
Revert changes to codeQLModelEditor.jumpToMethod
2023-10-16 10:42:18 +01:00
Anders Starcke Henriksen
cc2eec78bd
Merge branch 'main' into starcke/remove-old-language-filter
2023-10-16 11:27:56 +02:00
Koen Vlaswinkel
d715ceea10
Introduce separate tree item types in the methods usage panel
...
This creates new tree item types for methods and usages such that these
can contain references to their parent and children. This allows us to
easily find the parent of a usage and to find the children of a method.
This removes an expensive `find` call in `getParent`.
2023-10-16 11:18:27 +02:00
Anders Starcke Henriksen
8b3786c621
Remove old language context filter.
2023-10-16 10:30:26 +02:00
Koen Vlaswinkel
39a9f4ce1e
Merge pull request #2974 from github/koesie10/changelog-install-workspace-packs
...
Add CHANGELOG entry for #2960
2023-10-16 10:09:48 +02:00
Koen Vlaswinkel
b2de9e94cd
Add CHANGELOG entry for #2960
2023-10-16 09:53:22 +02:00
Charis Kyriakou
23dc8f16c3
Move in-progress methods state to modeling store ( #2971 )
2023-10-16 08:51:46 +01:00
Koen Vlaswinkel
d78a4d19eb
Merge pull request #2960 from github/koesie10/install-workspace-packs
...
Do not show non-workspace packs when installing pack dependencies
2023-10-16 09:51:29 +02:00
Anders Starcke Henriksen
3cbaa5aa24
Merge pull request #2935 from github/starcke/language-selection-panel
...
Add language filter panel.
2023-10-16 09:42:35 +02:00
Anders Starcke Henriksen
e8e6c6bbc7
Update comment.
2023-10-13 16:28:14 +02:00
Anders Starcke Henriksen
d5388576b5
Apply suggestions from code review
...
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com >
2023-10-13 16:00:17 +02:00
Charis Kyriakou
a5139b7fbf
Convert InProgressMethods to an interface ( #2970 )
2023-10-13 14:56:33 +01:00
Nora Dimitrijević
f5f5b398fe
Merge pull request #2928 from github/d10c/trim-cache-command
...
Add "CodeQL: Trim Cache" command that calls `evaluation/trimCache`
2023-10-13 15:12:55 +02:00
Koen Vlaswinkel
7baad1a5c6
Fix unmodeled methods always being marked as unsaved
...
When opening a library group in the model editor, unmodeled methods
would always be marked as unsaved, even if there were no changes. This
was because the `ModelKindDropdown` component did not properly take into
account that the `kind` for an unmodeled method should be an empty
string. It would always try setting it to `undefined`, which would cause
the method to be marked as unsaved. This fixes it by checking if there
are valid kinds before setting the kind to the first one.
2023-10-13 13:21:53 +02:00
Koen Vlaswinkel
5e8de88ee0
Merge pull request #2968 from github/koesie10/readonly-modeling-store
...
Improve immutability of modeling store state
2023-10-13 13:13:27 +02:00
Koen Vlaswinkel
6801a64148
Improve immutability of modeling store state
...
This improves the immutability of the modeling store state by using
TypeScript's readonly types to ensure that state can only be modified
from within the modeling store or when it's copied. This mostly consists
of adding `readonly` to properties and arrays, but this also adds a
`DeepReadonly` type to use in `postMessage` arguments to ensure that
readonly objects can be passed in. `postMessage` will never modify the
objects, so this is safe.
2023-10-13 11:20:54 +02:00
Nora
ee630b4a87
Merge pull request #2963 from github/nora/cancel-code-search
...
Improve code search cancelling
2023-10-13 10:23:02 +02:00
Anders Starcke Henriksen
a03e2c85f1
Address comments.
2023-10-13 10:03:34 +02:00
Koen Vlaswinkel
288f44e57d
Merge remote-tracking branch 'origin/main' into koesie10/modeled-method-validation-neutral
2023-10-13 10:01:34 +02:00
Anders Starcke Henriksen
52d32a5051
Merge branch 'main' into starcke/language-selection-panel
2023-10-13 09:52:17 +02:00
Koen Vlaswinkel
fa9cc7c5f9
Merge pull request #2967 from github/koesie10/fix-multiple-models-method-panel-spec
...
Fix incorrect test for `MultipleModeledMethodsPanel`
2023-10-13 09:51:32 +02:00
Anders Starcke Henriksen
cc3feabe66
Apply suggestions from code review
...
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com >
2023-10-13 09:48:28 +02:00
Koen Vlaswinkel
1dbd5aa86e
Fix test with non-conflicting neutral
2023-10-13 09:47:00 +02:00
Koen Vlaswinkel
19c30f1ee2
Fix incorrect test for MultipleModeledMethodsPanel
...
This was caused by a semantic merge conflict resulting in the wrong
`onChange` argument being used in the test.
2023-10-13 09:33:55 +02:00
Koen Vlaswinkel
3c505719f2
Merge pull request #2957 from github/koesie10/modeled-methods-panel-multiple-save
...
Use `SetMultipleModeledMethodsMessage` in modeled methods panel
2023-10-13 09:26:44 +02:00
Nora Dimitrijević
b097804ad7
Make the command conditional on a supported CLI version
2023-10-12 16:15:49 +00:00
Nora Dimitrijević
8b918bdb19
Add CHANGELOG.md entry
2023-10-12 16:15:49 +00:00
Nora Dimitrijević
d0f4188f3f
Add "VSCode: Trim Cache" command that calls evaluation/trimCache
...
The purpose of this change is to add a command that clears the cache except for predicates marked `cached`.
In contrast, the existing "VSCode: Clear Cache" command clears everything (`--mode=brutal`).
This calls into the query server's `evaluation/trimCache` method;
however, its existing behaviour is to do a database cleanup with `--mode=gentle`.
This is not well documented, and `--mode=normal` would give the desired behaviour.
Accordingly, this approach is dependent on separately changing the backend behaviour to `--mode=normal`.
Other possible amendments to this commit would be to not touch the legacy client
(replacing required methods by failing promises, since the legacy server is fully deprecated already),
or to have less duplication (by introducing more arguments — however,
I'm applying the rule of thumb that >3 copy-pastes are required for the introduction of a deduplicating abstraction).
2023-10-12 16:15:49 +00:00
Robert
bf828bccb6
Correctly test when buttons are disabled
2023-10-12 17:10:25 +01:00
Robert
48732a817a
Update test names
2023-10-12 16:59:04 +01:00
Koen Vlaswinkel
4ac21232cf
Fix neutral model validation to consider kind
...
This fixes a bug where the validation of modeled methods would not
consider the kind of the modeled method, and would therefore give an
error when there was e.g. a neutral sink and a non-neutral summary.
2023-10-12 16:41:28 +02:00
Robert
fc9588a1ec
Add tests for buttons
2023-10-12 15:31:35 +01:00
Robert
08522f9ae2
Enable/disable the add/remove model buttons in model editor
2023-10-12 15:31:34 +01:00
Robert
e50affeb56
Introduce shared methods for canAdd / canRemoveModeledMethod
2023-10-12 15:31:32 +01:00
Nora
43bc92e386
throw when cancelling
2023-10-12 13:52:56 +00:00
Kasper Svendsen
8ecc31fae7
Merge pull request #2955 from github/kaspersv/hash-result-set-in-bqrs-filename
...
Hash result set name in sorted result set path
2023-10-12 14:17:47 +02:00
Koen Vlaswinkel
d15c57ee29
Merge pull request #2961 from github/koesie10/storybook-a11y
...
Add @storybook/addon-a11y package
2023-10-12 14:08:40 +02:00
Nora
f4f799894e
Merge pull request #2815 from github/nora/remove-unused-activation-events
...
Remove unnecessary `activationEvents` from extension's package.json
2023-10-12 14:03:43 +02:00
Kasper Svendsen
ee5b738e00
Hash result set name in sorted result set path
2023-10-12 13:58:55 +02:00
Koen Vlaswinkel
25ba9e436b
Merge branch 'main' into koesie10/install-workspace-packs
2023-10-12 13:48:19 +02:00
Koen Vlaswinkel
b72e0352c4
Merge branch 'main' into koesie10/storybook-a11y
2023-10-12 13:48:17 +02:00
Robert
95f43b7d8c
Merge pull request #2953 from github/robertbrignull/add-multiple-models
...
Add add/remove buttons for models
2023-10-12 12:47:46 +01:00
Nora
95dfb6e820
Remove onLanguage event
2023-10-12 11:44:41 +00:00
Koen Vlaswinkel
00a5717d78
Merge pull request #2962 from github/koesie10/use-memo
...
Add missing useMemo import
2023-10-12 13:33:41 +02:00
Koen Vlaswinkel
ea8e5c6cc2
Add missing useMemo import
2023-10-12 13:13:53 +02:00
Koen Vlaswinkel
26b4b98cbc
Merge pull request #2959 from github/koesie10/modeled-methods-panel-add-button
...
Only disable add button when there are no models yet
2023-10-12 13:08:28 +02:00
Koen Vlaswinkel
7e3cb7541c
Merge pull request #2936 from github/koesie10/method-modeling-panel-validation
...
Add model validation in method modeling panel
2023-10-12 13:08:17 +02:00
Robert
77dd376f92
Add content to table header for screen readers
2023-10-12 11:18:41 +01:00
Nora
f53ecde0a9
Remove events
2023-10-12 10:00:14 +00:00
Koen Vlaswinkel
56697a9c2f
Add storybook/addon-a11y package
2023-10-12 11:52:47 +02:00
Koen Vlaswinkel
a2a7002263
Do not show non-workspace packs when installing pack dependencies
...
When using the "CodeQL: Install pack dependencies" command, we would
show packs that are located in the package cache or distribution. Since
there are no dependencies to install for these packs, these options are
not useful.
This will filter out any packs that are not in the workspace folders
when showing the quick pick. This should exclude most packs if you are
in a workspace without the `codeql` submodule and should be a lot more
intuitive in those cases. If you are in a workspace with the `codeql`
submodule, it will still show all the packs.
2023-10-12 11:39:29 +02:00
Robert
369258dc95
Add add/remove buttons for models
2023-10-12 10:32:40 +01:00
Anders Starcke Henriksen
ac4ccf4c65
Merge pull request #2958 from github/version/bump-to-v1.9.3
...
Bump version to v1.9.3
2023-10-12 11:26:03 +02:00
Koen Vlaswinkel
2453c64f51
Only disable add button when there are no models yet
...
This will change the add button in the method modeling panel to only be
disabled if there is exactly 1 unmodeled method and there are no
unmodeled methods. This should be more intuitive for users since they
are able to see in 1 screen that there is an unmodeled method.
2023-10-12 11:06:52 +02:00
github-actions[bot]
23927ec0f1
Bump version to v1.9.3
2023-10-12 08:59:04 +00:00
Koen Vlaswinkel
095f5aecc3
Use SetMultipleModeledMethodsMessage in modeled methods panel
2023-10-12 10:36:43 +02:00
Robert
1993db5122
Merge pull request #2952 from github/robertbrignull/save_multiple_modeled_methods
...
Implement editing / saving multiple modeled methods from the model editor
2023-10-12 09:19:16 +01:00
Anders Starcke Henriksen
53df2bcd87
Merge pull request #2956 from github/v1.9.2
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
Release v1.9.2
2023-10-12 10:18:15 +02:00
Koen Vlaswinkel
bcceae4f51
Add test for adding neutral classification
2023-10-12 10:06:27 +02:00
Koen Vlaswinkel
b6eb383696
Merge remote-tracking branch 'origin/main' into koesie10/method-modeling-panel-validation
2023-10-12 10:02:19 +02:00
Koen Vlaswinkel
0835b140e7
Merge pull request #2948 from github/koesie10/sort-usages-panel
...
Sort methods in usages panel according to model editor sort order
2023-10-12 09:55:00 +02:00
Anders Starcke Henriksen
0e62d2635c
v1.9.2
2023-10-12 09:50:13 +02:00
Koen Vlaswinkel
52e3a71f9c
Define order of JSON.stringify operation
2023-10-12 09:49:24 +02:00
Koen Vlaswinkel
cce5a989cf
Clarify Alert ARIA documentation
2023-10-12 09:41:47 +02:00
Koen Vlaswinkel
78284cbc7a
Merge remote-tracking branch 'origin/main' into koesie10/sort-usages-panel
2023-10-12 09:39:11 +02:00
Koen Vlaswinkel
0d7002273a
Merge pull request #2949 from github/koesie10/single-model-editor-per-db
...
Only allow a single model editor per database
2023-10-12 09:37:56 +02:00
Charis Kyriakou
7041dd7698
Rename 'open database' button and only show if source available ( #2945 )
2023-10-12 08:09:05 +01:00
Robert
539ce245fc
Add more tests covering MethodRow
2023-10-11 16:29:59 +01:00
Koen Vlaswinkel
a3d41a2afe
Merge pull request #2924 from github/koesie10/modeling-panel-multiple-models-add-remove
...
Add ability to add/remove modelings to method modeling panel
2023-10-11 16:20:39 +02:00
Robert
b881a38703
Fix expected value in tests
2023-10-11 15:03:11 +01:00
Koen Vlaswinkel
0cbdadb271
Add newline for readability
...
Co-authored-by: Robert <robertbrignull@github.com >
2023-10-11 15:59:56 +02:00
Robert
6db59a84a2
Use 'type: "none"' instead of undefined
2023-10-11 14:12:58 +01:00
Robert
eaf81efd64
Extract nested ternary to method
2023-10-11 14:12:10 +01:00
Henry Mercer
5105187dbd
Merge pull request #2951 from github/github-action/bump-cli
...
Bump CLI Version to v2.15.0 for integration tests
2023-10-11 14:03:49 +01:00
Robert
9da3dc9a25
Allow editing multiple models in model editor
2023-10-11 13:41:45 +01:00
Robert
c7451fc4c2
Remove need for forEachModeledMethod method
2023-10-11 13:41:42 +01:00
Koen Vlaswinkel
918362f39e
Merge pull request #2950 from github/koesie10/variant-analysis-save-before-start
...
Use `saveBeforeStart` setting when running a variant analysis
2023-10-11 14:34:08 +02:00
github-actions[bot]
0b5d2d86cf
Bump CLI version from v2.14.6 to v2.15.0 for integration tests
2023-10-11 12:30:29 +00:00
Koen Vlaswinkel
3a035708c5
Merge pull request #2947 from github/koesie10/update-set-selected-method-message
...
Convert `SetSelectedMethodMessage` to include multiple modeled methods
2023-10-11 13:59:48 +02:00
Koen Vlaswinkel
84211c63bb
Merge remote-tracking branch 'origin/main' into koesie10/update-set-selected-method-message
2023-10-11 13:40:27 +02:00
Koen Vlaswinkel
11218522e7
Update CHANGELOG
2023-10-11 13:35:11 +02:00
Koen Vlaswinkel
0bdd441767
Use saveBeforeStart setting when running a variant analysis
...
This will respect the user's `saveBeforeStart` setting when running a
variant analysis. This re-uses the existing `saveBeforeStart` function
that is used when running local queries. The default behavior if the
setting is not set is to save all open named files.
2023-10-11 13:33:24 +02:00
Koen Vlaswinkel
667bf19f46
Add methodSignature to SetMultipleModeledMethodsMessage
2023-10-11 13:07:18 +02:00
Robert
c459d0ff65
Merge pull request #2942 from github/robertbrignull/SetModeledMethodsMessage
...
Convert SetModeledMethodsMessage to include multiple modeled methods
2023-10-11 11:45:57 +01:00
Koen Vlaswinkel
039b28235d
Only allow 1 view in the view tracker
...
This will change the model editor view tracker to only store 1 view per
database item instead of an array of views per database item.
2023-10-11 11:54:47 +02:00
Koen Vlaswinkel
76db520ce7
Only allow a single model editor per database
...
This will add checks in the appropriate places to ensure that only a
single model editor is opened per database.
2023-10-11 11:51:05 +02:00
Anders Starcke Henriksen
d2b17e1676
Add tests.
2023-10-11 11:45:01 +02:00
Koen Vlaswinkel
0e1afcee64
Sort methods in usages panel according to model editor sort order
...
This sorts the methods in the methods usages panel the same as in the
model editor. Since this is dependent on the mode, we need to keep track
of the mode in the modeling store, so this also adds a mode field to the
db state.
2023-10-11 11:42:10 +02:00
Robert
62c9e51c25
Avoid unnnecessarily renaming field read from props
2023-10-11 10:41:48 +01:00
Charis Kyriakou
2b47d3d192
Ensure modeled methods are not undefined in usages panel ( #2946 )
2023-10-11 08:29:39 +00:00
Koen Vlaswinkel
4a62d05af6
Convert SetSelectedMethodMessage to include multiple modeled methods
2023-10-11 10:14:58 +02:00
Koen Vlaswinkel
e77cf28192
Merge pull request #2944 from github/dependabot/npm_and_yarn/extensions/ql-vscode/postcss-8.4.31
...
Bump postcss from 8.4.24 to 8.4.31 in /extensions/ql-vscode
2023-10-11 09:51:41 +02:00
Koen Vlaswinkel
59e23f35e2
Merge pull request #2943 from github/koesie10/state-confusion
...
Fix confusion between modeling store and view states
2023-10-11 09:45:58 +02:00
dependabot[bot]
33d55b1f0a
Bump postcss from 8.4.24 to 8.4.31 in /extensions/ql-vscode
...
Bumps [postcss](https://github.com/postcss/postcss ) from 8.4.24 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases )
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md )
- [Commits](https://github.com/postcss/postcss/compare/8.4.24...8.4.31 )
---
updated-dependencies:
- dependency-name: postcss
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-10 15:03:37 +00:00
Koen Vlaswinkel
e7ddb4406a
Merge pull request #2937 from github/koesie10/remove-gulp-sourcemaps
...
Remove `gulp-sourcemaps` dependency
2023-10-10 17:02:00 +02:00
Koen Vlaswinkel
9a12a12065
Unexport DbModelingState
2023-10-10 16:57:19 +02:00
Koen Vlaswinkel
073440914d
Set instance variables on webview load
2023-10-10 16:55:55 +02:00
Robert
c6a9f23e7e
Delete convertToLegacyModeledMethods
2023-10-10 15:50:02 +01:00
Robert
d531bc642d
Convert SetModeledMethodsMessage to include multiple modeled methods
2023-10-10 15:50:02 +01:00
Robert
a6625334f0
Merge pull request #2940 from github/robertbrignull/CommonFromViewMessages
...
Add CommonFromViewMessages to FromModelEditorMessage
2023-10-10 15:49:04 +01:00
Koen Vlaswinkel
77bb9780ec
Fix confusion between modeling store an view states
...
This fixes three bugs related to the modeling store and view states:
- In the model editor view, when `setModeledMethods` was called, it
would do it on the active database, instead of the database that the
view was showing. This should not result in any visible bugs since the
active database is always the one that is being shown (in theory), but
I can imagine that it could cause issues if showing multiple model
editors next to each other.
- In the method modeling panel, the "reveal in editor" button would
always show the already active model editor. Therefore, if you had
multiple open and were still viewing the method of the first one, it
would always show the second one.
- In the method modeling panel, the same bug would cause the incorrect
modeled methods to be updated.
2023-10-10 16:44:40 +02:00
Koen Vlaswinkel
bb88c148aa
Merge pull request #2941 from github/koesie10/modeling-store-modeled-methods-bug
...
Fix bug when selecting method without modeled methods
2023-10-10 16:18:42 +02:00
Robert
6df7ea3ddc
Remove unused import
2023-10-10 15:15:29 +01:00
Robert
2beaf9a88c
ViewLoadedMsg is already included
2023-10-10 15:11:30 +01:00
Robert
a7dbae02e0
Use ap logger
2023-10-10 15:11:19 +01:00
Robert
28ac019929
Fix typo
2023-10-10 15:11:09 +01:00
Koen Vlaswinkel
2e2ab11e4f
Merge pull request #2939 from github/koesie10/unhandled-error-stack
...
Add stack trace to unhandled error log message
2023-10-10 16:10:01 +02:00
Robert
edf3cad6e4
Add CommonFromViewMessages to FromModelEditorMessage
2023-10-10 15:03:23 +01:00
Robert
246c347b04
Merge pull request #2938 from github/robertbrignull/legacy-conversion
...
Make use of modeled-methods-legacy.ts in the webview code
2023-10-10 15:00:52 +01:00
Koen Vlaswinkel
e332b26f29
Fix bug when selecting method without modeled methods
...
When selecting a method that has no modeled methods, the modeling state
would not contain an entry for the method signature. This would cause
the `modeledMethods` to be `undefined`, which is not allowed according
to its type.
2023-10-10 15:51:59 +02:00
Koen Vlaswinkel
22f6ac7974
Add stack trace to unhandled error log message
...
This change sets the `fullMessage` of the
`showAndLogExceptionWithTelemetry` to include the stack trace. This
makes it possible to find the source of the error rather than only
knowing that a specific error occurred. If the error does not have a
stack trace (which should be rare) the message will be the same as
before.
2023-10-10 15:45:49 +02:00
Robert
e45f4bd0d9
Merge branch 'main' into robertbrignull/legacy-conversion
2023-10-10 14:37:20 +01:00
Charis Kyriakou
f4d74c7d3f
Deal with already modeled methods in the modeling panel ( #2933 )
2023-10-10 14:35:21 +01:00
Robert
7ba58b6298
Use legacy modeled method conversions instead of custom conversions
2023-10-10 14:23:06 +01:00
Robert
2b59c041b8
Make convertFromLegacyModeledMethod handle undefined
2023-10-10 14:23:06 +01:00
Robert
a434fbffbc
Move modeled-methods-legacy.ts to /shared directory
2023-10-10 14:23:06 +01:00
Koen Vlaswinkel
649f69234e
Remove gulp-sourcemaps
2023-10-10 14:37:20 +02:00
Anders Starcke Henriksen
c668b39b30
Add language filter panel.
2023-10-10 14:34:04 +02:00
Koen Vlaswinkel
5f4e9d4879
Add alert to show validation errors
2023-10-10 14:29:10 +02:00
Koen Vlaswinkel
6b965afe4f
Add validation function for modeled methods
2023-10-10 14:20:44 +02:00
Charis Kyriakou
4ee86c15ad
Add some spacing in modeling method empty states ( #2934 )
2023-10-10 10:52:15 +00:00
Robert
fcfd4f37a6
Merge pull request #2926 from github/robertbrignull/JumpToUsageMessage
...
Only include method signature in JumpToUsageMessage
2023-10-10 11:12:36 +01:00
Robert
6561bb0543
Merge branch 'main' into robertbrignull/JumpToUsageMessage
2023-10-10 10:50:21 +01:00
Koen Vlaswinkel
319a54c32f
Merge pull request #2906 from github/koesie10/convert-remaining-multiple-models
...
Convert remaining extension host code to handle multiple models
2023-10-10 11:43:09 +02:00
Koen Vlaswinkel
385b0e8d1a
Merge remote-tracking branch 'origin/main' into koesie10/convert-remaining-multiple-models
2023-10-10 11:22:08 +02:00
Robert
4dcfa8b679
Merge pull request #2927 from github/robertbrignull/generateMethodsFromLlm
...
Only include method signatures in generateMethodsFromLlm message
2023-10-10 10:19:20 +01:00
Robert
47509a922a
Rename jumpToUsage => jumpToMethod throughout
2023-10-10 10:14:27 +01:00
Charis Kyriakou
7eab7e4e48
Set modeling mode when initialising method modeling panel ( #2932 )
2023-10-10 10:12:01 +01:00
Charis Kyriakou
f794a19d96
Track db related to modeled method and react when it closes ( #2930 )
2023-10-10 09:51:50 +01:00
Charis Kyriakou
e98611fd21
Ensure modified methods updated after changing a method from the modeling panel ( #2929 )
2023-10-10 08:57:36 +01:00
Koen Vlaswinkel
461cf15a47
Merge remote-tracking branch 'origin/main' into koesie10/convert-remaining-multiple-models
2023-10-10 09:30:29 +02:00
Koen Vlaswinkel
54e1b29940
Add explicit return type to convertToLegacyModeledMethod
2023-10-10 09:26:27 +02:00
Dave Bartolomeo
623890adc9
Merge pull request #2922 from github/dbartol/passthru
...
Add `additionalArgs` option to `launch.json`
2023-10-09 15:04:13 -04:00
Dave Bartolomeo
e7f75ab928
Merge branch 'dbartol/passthru' of https://github.com/github/vscode-codeql into dbartol/passthru
2023-10-09 14:44:49 -04:00
Dave Bartolomeo
df02fecf3c
Fix test expectations
2023-10-09 14:44:33 -04:00
Dave Bartolomeo
a861346b10
Merge branch 'main' into dbartol/passthru
2023-10-09 14:06:14 -04:00
Philip Ginsbach
86b2157552
Merge pull request #2792 from github/ginsbach/TextMateInstantiationSyntax
...
fix syntax highlighting after imports with instantiation arguments
2023-10-09 17:17:55 +01:00
Philip Ginsbach
47fa163cb9
Update compiled grammar
2023-10-09 16:58:00 +01:00
Dave Bartolomeo
c78f01758a
Alternate fix for import highlighting with instantiations
2023-10-09 16:58:00 +01:00
Philip Ginsbach
353e22d6e8
link to the PR from the changelog entry
2023-10-09 16:58:00 +01:00
Philip Ginsbach
599d31e5ac
add changelog entry for TextMate instantiation argument syntax
2023-10-09 16:57:25 +01:00
Philip Ginsbach
64df792eda
TextMate grammar: imports can have instantiation arguments
2023-10-09 16:56:21 +01:00
Robert
feebf7c3fd
Only include method signatures in generateMethodsFromLlm
2023-10-09 16:17:46 +01:00
Robert
27c4bd8349
Merge pull request #2910 from github/robertbrignull/multiple-models-method-row
...
Add ability for MethodRow to render multiple modelings of the same method
2023-10-09 16:17:17 +01:00
Dave Bartolomeo
d4cbfbb70e
Rename to additionalRunQueryArgs
2023-10-09 11:04:22 -04:00
Robert
153424ae5a
Only include method signature in JumpToUsageMessage
2023-10-09 16:03:41 +01:00
Robert
edd2aa5e8f
Merge branch 'main' into robertbrignull/multiple-models-method-row
2023-10-09 15:38:00 +01:00
Robert
0265353370
Use index as react key
2023-10-09 14:44:43 +01:00
Koen Vlaswinkel
623df4c2ee
Merge pull request #2919 from github/koesie10/show-multiple-models-listener
...
Listen to modeling setting changes in the model editor and method modeling panel
2023-10-09 15:38:30 +02:00
Robert
8b0825ab3c
Use better name for variable
2023-10-09 14:32:56 +01:00
Robert
c620939895
Merge pull request #2913 from github/robertbrignull/SaveModeledMethods
...
Remove method and modeledMethods from SaveModeledMethods message
2023-10-09 14:16:30 +01:00
Koen Vlaswinkel
e4a290fe37
Merge pull request #2925 from github/koesie10/method-modeling-codeowner
...
Set SecExp as codeowner for modeling panel
2023-10-09 15:13:56 +02:00
Koen Vlaswinkel
3230cc9166
Set SecExp as codeowner for modeling panel
2023-10-09 14:56:38 +02:00
Koen Vlaswinkel
4dae9b87d4
Add ability to add/remove modelings
2023-10-09 14:54:32 +02:00
Koen Vlaswinkel
5c368cec8b
Merge pull request #2921 from github/koesie10/modeling-panel-multiple-models
...
Add ability for method modeling panel to render multiple modelings of the same method
2023-10-09 14:27:30 +02:00
Koen Vlaswinkel
b76369330d
Convert remaining extension host code to handle multiple models
...
This converts all remaining extension host code to handle multiple
models per method. The only place where we're using the legacy format
is in the webview and in the boundary between the webview and the
extension host.
2023-10-09 13:56:41 +02:00
Koen Vlaswinkel
323c5368ba
Switch from CodiconButton to VSCodeButton
2023-10-09 13:52:55 +02:00
Robert
c3e18910fc
Fix typo in comment
2023-10-09 12:26:09 +01:00
Robert
603c799717
Merge pull request #2923 from github/robertbrignull/telemetry-changelog
...
Update CHANGELOG.md for telemetry changes
2023-10-09 12:24:39 +01:00
Robert
aa045835fd
Merge branch 'main' into robertbrignull/SaveModeledMethods
2023-10-09 11:35:47 +01:00
Robert
850c04a289
Clarify method docs
2023-10-09 11:30:35 +01:00
Robert
4d19955740
Update CHANGELOG.md for telemetry changes
2023-10-09 11:08:31 +01:00
Robert
b623f92c4a
Merge pull request #2824 from github/robertbrignull/telemetry
...
Respect "telemetry.telemetryLevel" as well as "telemetry.enableTelemetry"
2023-10-09 10:59:26 +01:00
Koen Vlaswinkel
08342f1960
Merge pull request #2905 from github/koesie10/convert-modeled-method-fs
...
Convert `modeled-method-fs.ts` to handle multiple models per method
2023-10-09 11:54:31 +02:00
Robert
af334a98e3
Merge pull request #2912 from github/robertbrignull/simplify_messages/RevealMethodMessage
...
Convert RevealMethodMessage to only include method signature
2023-10-09 10:46:19 +01:00
Dave Bartolomeo
9e26c29ddb
Fix tests for older CLIs
2023-10-06 18:35:20 -04:00
Dave Bartolomeo
705a7975c5
Add additionalArgs option to launch.json
2023-10-06 18:03:10 -04:00
Koen Vlaswinkel
6be98f3f8d
Fix test
2023-10-06 16:57:31 +02:00
Koen Vlaswinkel
3b6263fb07
Remove size from CodiconButton
2023-10-06 16:48:49 +02:00
Koen Vlaswinkel
29aa4a3f29
Add tests for multiple modeled methods panel
2023-10-06 16:42:41 +02:00
Koen Vlaswinkel
3a494dff36
Add support for unmodeled methods
2023-10-06 16:26:53 +02:00
Koen Vlaswinkel
a01a76cb73
Add initial multiple modelings panel
2023-10-06 16:25:25 +02:00
Koen Vlaswinkel
a29112e045
Add multiple models to MethodModeling story
2023-10-06 15:54:02 +02:00
Koen Vlaswinkel
ee1bf8896e
Change MethodModeling to accept multiple models
2023-10-06 15:50:31 +02:00
Koen Vlaswinkel
2410d2bfdd
Merge pull request #2918 from github/koesie10/modeling-panel-view-state
...
Add view state to method modeling panel
2023-10-06 15:49:37 +02:00
Charis Kyriakou
0e5551b650
Make method modeling panel available to canary users ( #2920 )
2023-10-06 13:25:33 +00:00
Koen Vlaswinkel
951bd13881
Use ModelConfig for all model settings
...
This switches all places where we're retrieving some model configuration
to use the `ModelConfig` or `ModelConfigListener` types. This makes it
much easier to mock these settings in tests.
This also adds a listener to the `ModelEditorView` to send the new view
state when any of the settings is changed. This should make it easier
to test settings changes in the model editor without having to re-open
the model editor.
2023-10-06 14:29:07 +02:00
Koen Vlaswinkel
08944a292c
Update method modeling panel after changes to config
...
This updates the method modeling panel's view state when the
`codeQL.model.showMultipleModels` setting changes. This will ensure that
the setting updates without needing to restart VS Code since this view
is much harder to restart than the model editor.
2023-10-06 14:15:23 +02:00
Koen Vlaswinkel
cf0057ecd9
Add view state to method modeling panel
...
This adds a view state to the method modeling panel similar to the
model editor. This will be used to send the state of the show multiple
models feature flag to the webview so this can be used to selectively
show/hide components in the method modeling panel.
2023-10-06 14:04:06 +02:00
Charis Kyriakou
1d691c2b7f
UI polish for modeling panel ( #2917 )
...
* Don't push content down with unsaved tag
* Adjust spacing between components
2023-10-06 11:57:52 +01:00
Charis Kyriakou
20c63921f7
Wire up modeling panel empty states ( #2915 )
2023-10-06 11:27:16 +01:00
Koen Vlaswinkel
9c275130a5
Fix duplicate modeled methods
...
Co-authored-by: Robert <robertbrignull@github.com >
2023-10-06 12:09:00 +02:00
Henry Mercer
b1df4a4f0a
Merge pull request #2916 from github/henrymercer/remove-ml-powered-queries
...
Packaging: Remove ML-powered queries pack from known list
2023-10-06 11:02:27 +01:00
Henry Mercer
08a4457e39
Packaging: Remove ML-powered queries pack from known list
...
ML-powered queries are [now deprecated](https://github.blog/changelog/2023-09-29-codeql-code-scanning-deprecates-ml-powered-alerts/ ).
2023-10-06 10:38:14 +01:00
Charis Kyriakou
db3d24236c
Add empty states for modeling panel ( #2914 )
2023-10-06 09:34:54 +01:00
Robert
9d40d9a703
Remove method and modeledMethods from SaveModeledMethods message
2023-10-05 16:56:05 +01:00
Robert
0fabcda49b
Convert RevealMethodMessage to only include method signature
2023-10-05 16:41:56 +01:00
Robert
2b0bd840e6
Place setup before initialising listener
2023-10-05 15:25:42 +01:00
Robert
d499ff3cf4
Merge branch 'main' into robertbrignull/telemetry
2023-10-05 15:19:07 +01:00
Charis Kyriakou
1806108166
Remove unnecessary TODOs ( #2900 )
2023-10-05 08:04:17 +00:00
Andrew Eisenberg
02af432d5f
Merge pull request #2885 from github/aeisenberg/multi-token
...
Adds `MultiCancellationToken`
2023-10-04 13:33:46 -07:00
Andrew Eisenberg
76ec9e2e50
Make DisposableObject a concrete class
2023-10-04 20:10:42 +00:00
Robert
5ba64a1db3
Add test for when there's no modeled method
2023-10-04 18:46:17 +01:00
Robert
f87b1c46de
Add some simple tests of rendering multiple models
2023-10-04 18:46:17 +01:00
Robert
8eef4eb4f2
Add story with multiple modelings
2023-10-04 18:46:17 +01:00
Robert
252c7a20c4
Convert MethodRow to display multiple modelings
2023-10-04 18:46:13 +01:00
Robert
86d7d8345c
Convert ApiOrMethodCell to ApiOrMethodRow
2023-10-04 18:17:34 +01:00
Robert
a704cd7bae
Convert getModelingStatus to take ModeledMethod[]
2023-10-04 18:17:34 +01:00
Robert
e75eccb416
Change MethodRow to accept ModelEditorViewState object instead of just Mode
2023-10-04 18:17:34 +01:00
Charis Kyriakou
17947fb7c2
Use base postMessage instead of webview one ( #2909 )
2023-10-04 17:23:49 +01:00
Charis Kyriakou
c00207cccc
Move method modeling panel out of explorer ( #2908 )
2023-10-04 15:38:07 +01:00
Andrew Eisenberg
801df7b14a
Merge branch 'main' into aeisenberg/multi-token
2023-10-04 07:09:21 -07:00
Koen Vlaswinkel
a6c7af09d4
Merge pull request #2907 from github/koesie10/eslint-memory
...
Increase memory limit when running ESLint
2023-10-04 15:11:26 +02:00
Koen Vlaswinkel
96668928aa
Increase memory limit when running ESLint
2023-10-04 14:46:32 +02:00
Koen Vlaswinkel
a6c97077fb
Merge pull request #2904 from github/koesie10/convert-yaml-modeled-methods
...
Convert `yaml.ts` to handle multiple models per method
2023-10-04 14:01:02 +02:00
Robert
6d7fbfc4f8
Merge pull request #2903 from github/robertbrignull/multiple-models-feature-flag
...
Add feature flag for showing multiple modelings
2023-10-04 12:55:42 +01:00
Koen Vlaswinkel
c5175e040e
Convert modeled-method-fs.ts to handle multiple models per method
...
This will change the input/output types for modeled methods in the
`modeled-method-fs.ts` file to take in multiple models per method. This
removes the need for conversion functions between this file and
`yaml.ts` files. Instead, the conversion functions are done when calling
any functions defined in `modeled-method-fs.ts` files.
2023-10-04 13:47:30 +02:00
Anders Starcke Henriksen
55af9bc47c
Merge pull request #2894 from github/starcke/lang-context-history
...
Add support for filtering history panel.
2023-10-04 13:38:38 +02:00
Koen Vlaswinkel
ada62ffd33
Convert yaml.ts to handle multiple models per method
...
This changes YAML parsing/creating functions for the model editor to
handle multiple models per method. The changes in the actual YAML
handling are fairly small because the format itself already supports
multiple models per method.
I've introduced a few helper functions to convert between the old and
new types. This should only be necessary while we're in the middle of
the transition to the new types and can be removed later. For now,
we'll just take the first model in the array when converting from the
new to the old type. This is a change in the behavior since currently
we always take the last model in the array but this behavior is
undocumented and unsupported, so it should be fine to change it.
2023-10-04 13:23:54 +02:00
Robert
e10e3adc14
Add feature flag for showing multiple modelings
2023-10-04 12:21:47 +01:00
Koen Vlaswinkel
16af4c49ea
Merge pull request #2902 from github/koesie10/actions-nvmrc
...
Use .nvmrc file for setting up Node version in Actions
2023-10-04 11:36:22 +02:00
Koen Vlaswinkel
c970c3bc19
Use .nvmrc file for setting up Node version in Actions
2023-10-04 10:00:56 +02:00
Andrew Eisenberg
3699f0b3b3
Add BasicDisposableObject
...
Use it for `MultiCancellationToken`. And ensure that adding a
cancellation requested listener to the `MultiCancellationToken` will
forward any cancellation requests to all constituent tokens.
2023-10-03 21:42:00 +00:00
Andrew Eisenberg
ccbe4ee974
Merge branch 'main' into aeisenberg/multi-token
2023-10-03 07:52:54 -07:00
Anders Starcke Henriksen
486180d149
Fix and add tests.
2023-10-03 13:57:16 +02:00
Anders Starcke Henriksen
9362447338
Add support for filtering history panel.
2023-10-03 13:55:01 +02:00
Anders Starcke Henriksen
ff34079247
Merge pull request #2892 from github/starcke/local-query-lang-dto
...
Add language to local query history items
2023-10-03 13:53:32 +02:00
Koen Vlaswinkel
7cd99cb000
Merge pull request #2897 from github/dependabot/npm_and_yarn/extensions/ql-vscode/p-queue-7.4.1
...
Bump p-queue from 6.6.2 to 7.4.1 in /extensions/ql-vscode
2023-10-03 12:53:55 +02:00
Koen Vlaswinkel
21fd0cfd29
Transform p-queue and p-timeout modules in Jest tests
2023-10-03 11:52:51 +02:00
dependabot[bot]
db3337cc1b
Bump p-queue from 6.6.2 to 7.4.1 in /extensions/ql-vscode
...
Bumps [p-queue](https://github.com/sindresorhus/p-queue ) from 6.6.2 to 7.4.1.
- [Release notes](https://github.com/sindresorhus/p-queue/releases )
- [Commits](https://github.com/sindresorhus/p-queue/compare/v6.6.2...v7.4.1 )
---
updated-dependencies:
- dependency-name: p-queue
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-03 09:29:01 +00:00
Koen Vlaswinkel
a525499c2a
Merge pull request #2818 from github/dependabot/npm_and_yarn/extensions/ql-vscode/nanoid-5.0.1
...
Bump nanoid from 3.3.6 to 5.0.1 in /extensions/ql-vscode
2023-10-03 11:26:00 +02:00
Anders Starcke Henriksen
6d2859cee5
Fix typo.
2023-10-03 11:23:32 +02:00
Koen Vlaswinkel
ac9128735f
Merge pull request #2896 from github/koesie10/reveal-in-editor
...
Add reveal in editor button to method modeling panel
2023-10-03 11:12:44 +02:00
Anders Starcke Henriksen
2c0838e393
Merge branch 'main' into starcke/local-query-lang-dto
2023-10-03 11:01:46 +02:00
Anders Starcke Henriksen
b294e16c44
Add to changelog.
2023-10-03 11:01:03 +02:00
Koen Vlaswinkel
f678f49bc9
Transform nanoid module in Jest tests
2023-10-03 10:48:08 +02:00
dependabot[bot]
99dabb0779
Bump nanoid from 3.3.6 to 5.0.1 in /extensions/ql-vscode
...
Bumps [nanoid](https://github.com/ai/nanoid ) from 3.3.6 to 5.0.1.
- [Release notes](https://github.com/ai/nanoid/releases )
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md )
- [Commits](https://github.com/ai/nanoid/compare/3.3.6...5.0.1 )
---
updated-dependencies:
- dependency-name: nanoid
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-03 08:13:33 +00:00
Koen Vlaswinkel
add7a25578
Merge pull request #2877 from github/robertbrignull/upgrade_msw
...
Upgrade MSW
2023-10-03 10:08:34 +02:00
Koen Vlaswinkel
487a753ede
Reveal method in editor view
...
This will reveal a method for which "Review in editor" is clicked in the
model editor view: it will expand the group (library/package) in which
the method is located, scroll to the method, and highlight the method.
If the user clicks anywhere on the page, the highlight will be removed,
but the group will remain expanded.
2023-10-03 09:49:00 +02:00
Koen Vlaswinkel
79ea901a52
Send message to model editor view on revealing method
...
This will call a method on the correct model editor view when the user
clicks on "Review in editor". This does not yet do anything to the view;
this will be added in a follow-up commit.
2023-10-03 09:48:59 +02:00
Koen Vlaswinkel
2872a2dcaf
Add model editor view tracker
...
This is used for registering which model editor views are currently
active. This will be used to determine which view to send the "reveal
method" command to. It can also be used in the future to limit the
number of instances of the model editor that can be opened for a
database.
This uses the same pattern as variant analyses with a separate interface
for the view to avoid having circular dependencies.
2023-10-03 09:48:17 +02:00
Koen Vlaswinkel
8b8bacb718
Add button for reveal method in editor
2023-10-03 09:47:52 +02:00
Koen Vlaswinkel
83e38c811f
Update CHANGELOG
2023-10-03 09:36:59 +02:00
Koen Vlaswinkel
8107bf7cb1
Merge remote-tracking branch 'origin/main' into robertbrignull/upgrade_msw
2023-10-03 09:36:03 +02:00
Andrew Eisenberg
625b3a5c37
Merge branch 'main' into aeisenberg/multi-token
2023-10-02 20:07:31 -07:00
Andrew Eisenberg
0fa3cf5d8e
Use EventEmitter in MultiCancellationToken
2023-10-02 10:21:17 -07:00
Charis Kyriakou
558b9329c5
Extract base functionality for WebviewViewProviders into an abstract class ( #2895 )
2023-10-02 16:31:52 +01:00
Koen Vlaswinkel
e15b7681db
Bump @types/vscode to 1.82.0
2023-10-02 11:14:42 +02:00
Koen Vlaswinkel
6539417d2d
Fix recording of binary response bodies
2023-10-02 11:13:18 +02:00
Koen Vlaswinkel
095d56ee37
Fix typo in BasicErrorResponse
2023-10-02 11:02:44 +02:00
Koen Vlaswinkel
7578697e92
Fix response bodies when recording
2023-10-02 11:02:20 +02:00
Anders Starcke Henriksen
6e06e7934b
Merge pull request #2889 from github/starcke/lang-context-queries
...
Apply language context to queries panel
2023-10-02 10:27:00 +02:00
Charis Kyriakou
58249e3efe
Dispose event subscriptions in method modeling view ( #2882 )
2023-10-02 08:57:33 +01:00
Andrew Eisenberg
75540b449f
Merge pull request #2884 from github/aeisenberg/avoid-double-restart
...
Avoid double restarts of the query server
2023-09-29 11:04:37 -07:00
Andrew Eisenberg
04dfc4e647
Move location of multi-cancellation-token
...
This avoids a code-scanning warning.
2023-09-29 08:31:20 -07:00
Andrew Eisenberg
3ba1712be0
Update Changelog
2023-09-29 08:30:51 -07:00
Andrew Eisenberg
e8f68c1b5f
Adds MultiCancellationToken
...
This is a cancellation token that cancels when any of its constituent
cancellation tokens are cancelled.
This token is used to fix a bug in Find Definitions. Previously, when
clicking `CTRL` (or `CMD` on macs) inside a source file in an archive
and hovering over a token, this will automatically invoke the
definitions finder (in preparation for navigating to the definition).
The only way to cancel is to move down to the message popup and click
cancel there.
However, this is a bug. What _should_ happen is that if a user moves
their mouse away from the token, the operation should cancel.
The underlying problem is that the extension was only listening to the
cancellation token from inside `getLocationsForUriString` the
cancellation token used by the Language Server protocol to cancel
operations in flight was being ignored.
This fix will ensure we are listening to _both_ cancellation tokens
and cancel the query if either are cancelled.
2023-09-29 08:28:35 -07:00
Andrew Eisenberg
a9edb36242
Merge branch 'main' into aeisenberg/avoid-double-restart
2023-09-29 08:26:53 -07:00
Koen Vlaswinkel
40b79f2e61
Improve scenario recording
2023-09-29 14:34:12 +02:00
Charis Kyriakou
3489c26ef6
Styling updates to method modeling panel ( #2888 )
2023-09-29 13:02:29 +01:00
Koen Vlaswinkel
6b522819fd
Merge pull request #2893 from github/version/bump-to-v1.9.2
...
Bump version to v1.9.2
2023-09-29 13:20:59 +02:00
Koen Vlaswinkel
15b8d2bdb4
Merge pull request #2890 from github/koesie10/add-missing-feature-flag-to-test-plan
...
Add missing feature flag to test plan
2023-09-29 13:10:27 +02:00
github-actions[bot]
213a03555a
Bump version to v1.9.2
2023-09-29 10:27:33 +00:00
Koen Vlaswinkel
0a9a9792ad
Merge pull request #2891 from github/koesie10/dispose-webview
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
Dispose tracked objects when panel is disposed
2023-09-29 12:19:56 +02:00
Anders Starcke Henriksen
c4fe868826
Add a way to show language for qury history.
2023-09-29 12:15:55 +02:00
Koen Vlaswinkel
4cf67ef799
Fix disposing in ResultsView
2023-09-29 12:00:26 +02:00
Anders Starcke Henriksen
c43d0fa805
Add language to local queries.
2023-09-29 11:54:45 +02:00
Koen Vlaswinkel
0a27c0538d
Dispose tracked objects when panel is disposed
...
This will change the `AbstractWebview` to dispose its tracked objects
(using `this.push`) when the panel is disposed rather than when the
view is disposed. This makes `this.push` actually useful in a view.
Before, the objects would only get disposed when the extension itself
was disposed.
2023-09-29 11:34:59 +02:00
Koen Vlaswinkel
e798663bbb
Add missing feature flag to test plan
2023-09-29 11:12:04 +02:00
Anders Starcke Henriksen
169a425e0b
Update and add tests.
2023-09-29 11:07:06 +02:00
Koen Vlaswinkel
66fdabf4c8
Merge pull request #2887 from github/v1.9.1
...
Release v1.9.1
2023-09-29 10:30:40 +02:00
Koen Vlaswinkel
f249b36660
v1.9.1
2023-09-29 10:05:43 +02:00
Anders Starcke Henriksen
1e6b7a6619
Add support for filtering queries panel.
2023-09-29 09:28:44 +02:00
Anders Starcke Henriksen
552a4f6eb3
Merge pull request #2873 from github/starcke/language-context-store
...
Add language context store.
2023-09-29 09:24:31 +02:00
Andrew Eisenberg
2b17979b6c
Update changelog
2023-09-28 14:29:40 -07:00
Andrew Eisenberg
3999ae3728
Avoid double restarts of the query server
...
Previously, if there was an explicit restart of the query server (eg-
by changing a configuration setting), then the query server process
would be started twice: once by the `close` handler and once by the
restart command.
By adding the `removeAllListeners` to the dispose method, we ensure that
when the query server shuts down gracefully, there won't be a `close`
listener that is going to restart it a second time if there is a
different way of restarting it.
2023-09-28 14:25:35 -07:00
Shati Patel
493e8d915e
Hide the language filter behind an extra flag ( #2881 )
2023-09-28 14:47:25 +00:00
Anders Starcke Henriksen
dc632d5c3d
Change to use QueryLanguage | undefined.
2023-09-28 16:43:33 +02:00
Koen Vlaswinkel
ae2d6ce16e
Upgrade Node version to 18.15.0
2023-09-28 16:38:54 +02:00
Charis Kyriakou
27a7474f2b
Add modeling indicator to method usages panel ( #2876 )
2023-09-28 15:33:46 +01:00
Koen Vlaswinkel
8b1c52886a
Fix typing error for Octokit
2023-09-28 16:09:16 +02:00
Koen Vlaswinkel
f9ddb4080c
Switch to stable VS Code version for tests
2023-09-28 16:07:34 +02:00
Koen Vlaswinkel
3afa15a0ce
Remove redundant query params
2023-09-28 16:07:05 +02:00
Koen Vlaswinkel
f22714777c
Use AppOctokit in tests
2023-09-28 16:06:34 +02:00
Koen Vlaswinkel
469f65a392
Merge pull request #2854 from github/koesie10/bump-min-version
...
Bump minimum VS Code version to 1.82
2023-09-28 16:04:57 +02:00
Koen Vlaswinkel
9b10a09727
Fix MSW JSON responses
2023-09-28 14:32:33 +02:00
Koen Vlaswinkel
3c10e87529
Switch Octokit to use node-fetch
...
It seems like Node's native `fetch` implementation isn't quite working
right with Octokit and MSW. This switches to using `node-fetch` like
we're already doing for all other requests (e.g. downloading databases).
2023-09-28 14:32:32 +02:00
Koen Vlaswinkel
a1ea1f8135
Upgrade Octokit and MSW
2023-09-28 14:32:16 +02:00
Robert
ffc90a0c30
Remove startServer method as it now does nothing
2023-09-28 14:32:15 +02:00
Robert
e34f4ed485
Only start server when loading a scenario
2023-09-28 14:32:15 +02:00
Robert
7c1b6e2ff6
Use new types
2023-09-28 14:32:15 +02:00
Robert
e719df711a
Upgrade msw to the @next tag
2023-09-28 14:32:15 +02:00
Anders Starcke Henriksen
6accba66fe
Rename state to languageFilter.
2023-09-28 14:28:31 +02:00
Anders Starcke Henriksen
a657df4468
Move context manipulation into store and fix initial state.
2023-09-28 14:19:07 +02:00
Koen Vlaswinkel
6aab4b4090
Merge pull request #2875 from github/koesie10/update-csharp-query
...
Update model editor C# query to return method parameters with parentheses
2023-09-28 14:10:50 +02:00
Anders Starcke Henriksen
c7e5922bd5
Merge branch 'main' into starcke/language-context-store
2023-09-28 14:08:26 +02:00
Anders Starcke Henriksen
bb25874299
Remove TODO.
2023-09-28 14:05:31 +02:00
Shati Patel
d5c78fd67b
Indicate which language is selected in the databases view ( #2871 )
2023-09-28 12:30:11 +02:00
Koen Vlaswinkel
6c5f160eee
Update model editor C# query to return method parameters with parentheses
2023-09-28 12:17:06 +02:00
Nora
ecbc458106
Merge pull request #2802 from github/nora/minor-integration-test-improvement
...
Minor test updates for `db-panel.test`
2023-09-28 12:16:54 +02:00
Koen Vlaswinkel
93652fc75f
Merge pull request #2872 from github/koesie10/resolve-queries-from-ql
...
Resolve model editor queries from CodeQL packs if present
2023-09-28 12:14:41 +02:00
Nora
859eca0195
Merge pull request #2812 from github/nora/remove-rate-limit-code-search
...
Code Search: don't show rate limit warnings to users
2023-09-28 11:57:15 +02:00
Koen Vlaswinkel
905eaf66aa
Implement PR feedback
2023-09-28 11:27:42 +02:00
Nora
7af8b7a274
Use BaseLogger instead of ExtLogger
2023-09-28 08:50:35 +00:00
Nora
a6b6b5a7d6
Show rate limit messages in extension output
2023-09-28 08:24:58 +00:00
Nora
9aff9891d3
Fix comment
2023-09-28 08:18:44 +00:00
Nora
681a15ce45
Extract dbConfigFilePath
2023-09-28 08:17:38 +00:00
Nora
f82b51f7c5
Add comment
2023-09-28 08:17:38 +00:00
Nora
5b7124683a
Replace void with await
2023-09-28 08:17:38 +00:00
Charis Kyriakou
031b5076db
Update modeling panel when clicking 'view' on model editor ( #2874 )
2023-09-27 16:59:39 +01:00
Dave Bartolomeo
f1533dde2d
Merge pull request #2858 from github/dbartol/long-strings
...
Use streaming when creating log symbols file.
2023-09-27 09:55:25 -04:00
Koen Vlaswinkel
e9b67dd90c
Resolve model editor queries from ql if present
2023-09-27 15:32:01 +02:00
Anders Starcke Henriksen
7bfe0df901
Add language context store.
2023-09-27 15:28:11 +02:00
Koen Vlaswinkel
b1debee244
Merge pull request #2868 from github/koesie10/new-model-editor-queries
...
Update model editor queries
2023-09-27 12:03:48 +02:00
Charis Kyriakou
3b00d74f47
Hook method modeling view to modeling store ( #2870 )
2023-09-27 09:57:27 +00:00
Koen Vlaswinkel
4efd3f8fe8
Merge pull request #2865 from github/github-action/bump-cli
...
Bump CLI Version to v2.14.6 for integration tests
2023-09-27 11:23:40 +02:00
Koen Vlaswinkel
95c512e3e8
Fix compilation errors when using submodule with updated queries
2023-09-27 11:20:57 +02:00
Koen Vlaswinkel
7501f9b81e
Merge pull request #2864 from github/koesie10/right-align-format-numbers
...
Right align and format raw result numbers
2023-09-27 11:03:12 +02:00
Charis Kyriakou
a98b998e5f
Add selected method and usage state to modeling store ( #2869 )
2023-09-27 08:15:51 +01:00
Koen Vlaswinkel
e03d106bc2
Update model editor queries
...
This updates the model editor queries to the version that will be merged
into the CodeQL repository. There are some slight changes to the output
format, so we slightly need to change the BQRS decoding of those
queries.
The queries themselves were copied from the two PRs with some minor
additions at the end since these were changes in core CodeQL library
files.
2023-09-27 09:05:15 +02:00
Dave Bartolomeo
3c63df2221
Unit tests for SplitBuffer
2023-09-26 17:54:47 -04:00
Charis Kyriakou
c6996771ab
Add unsaved tag on method modeling panel ( #2867 )
2023-09-26 20:17:16 +01:00
Koen Vlaswinkel
e475036721
Right align and format raw result numbers
...
This changes the formatting for both the local raw results table and the
variant analysis raw results table to right align and format numbers.
2023-09-26 16:18:42 +02:00
Charis Kyriakou
42192fa922
Move modeling status code to its own module ( #2866 )
...
* Move ModelingStatus to its own file
* Move getModelingStatus to modeling status module
2023-09-26 13:52:04 +00:00
Koen Vlaswinkel
947084d792
Merge pull request #2863 from github/koesie10/refactor-raw-results-table
...
Split out components in variant analysis raw results table
2023-09-26 15:41:47 +02:00
Charis Kyriakou
6c1cd71743
Move modeled and modified method state to store ( #2861 )
2023-09-26 14:23:12 +01:00
github-actions[bot]
c4b890597d
Bump CLI version from v2.14.5 to v2.14.6 for integration tests
2023-09-26 13:19:05 +00:00
Charis Kyriakou
93251f8d57
Make MethodModelingViewProvider a disposable object ( #2862 )
2023-09-26 13:53:23 +01:00
Koen Vlaswinkel
452329b07a
Extract RawResultRow to separate file
2023-09-26 14:46:42 +02:00
Koen Vlaswinkel
1afee02e78
Extract RawResultCell to separate file
2023-09-26 14:46:39 +02:00
Koen Vlaswinkel
cbb1de4faf
Merge pull request #2847 from github/dependabot/npm_and_yarn/extensions/ql-vscode/types/js-yaml-4.0.6
...
Bump @types/js-yaml from 3.12.5 to 4.0.6 in /extensions/ql-vscode
2023-09-26 12:41:11 +02:00
Charis Kyriakou
9e92c6c304
Merge pull request #2857 from github/charisk/initial-modeling-store
...
Introduce modeling store and move some state there
2023-09-26 11:36:46 +01:00
Koen Vlaswinkel
7864844ddd
Fix missing string type on dataExtensions
2023-09-26 11:58:33 +02:00
Charis Kyriakou
c77a300f24
Move methods, hideModeledMethods and active editor state to the modeling store
2023-09-26 09:52:59 +00:00
Koen Vlaswinkel
f5fbd7f4cc
Switch tests to new types
2023-09-26 11:32:25 +02:00
Koen Vlaswinkel
405292ecd4
Introduce type for QlPackFile
2023-09-26 11:29:19 +02:00
Shati Patel
3be7eb9e15
Add ability to filter DB view by language ( #2856 )
2023-09-26 09:20:40 +00:00
Dave Bartolomeo
c972a5c0de
Use streaming when creating log symbols file.
2023-09-25 14:24:10 -04:00
Koen Vlaswinkel
5ae67fecda
Do not export unused types
2023-09-25 15:54:26 +02:00
Charis Kyriakou
d33c26798d
Introduce modeling store
2023-09-25 13:42:57 +00:00
Koen Vlaswinkel
9392fb75c8
Format generated schema files with Prettier
2023-09-25 15:35:02 +02:00
Koen Vlaswinkel
e0509f684b
Merge pull request #2845 from github/dependabot/npm_and_yarn/extensions/ql-vscode/zip-a-folder-3.1.2
...
Bump zip-a-folder from 2.0.0 to 3.1.2 in /extensions/ql-vscode
2023-09-25 15:26:01 +02:00
Koen Vlaswinkel
c55e87c64b
Generate schema for extension pack file
2023-09-25 15:25:40 +02:00
Koen Vlaswinkel
bc01d73ba5
Fix some type errors in tests
2023-09-25 15:25:39 +02:00
Koen Vlaswinkel
db55e9cd42
Generate schema for extension pack metadata
...
After the upgrade to the correct types for js-yaml, the return type
of `load` is correctly typed as `unknown`. This means that we can't
use the return value directly, but need to validate it first.
This adds such validation by generating a JSON schema for a newly
created typed. The JSON schema generation is very similar to how we do
it in https://github.com/github/codeql-variant-analysis-action .
2023-09-25 15:25:37 +02:00
Charis Kyriakou
19890b8591
Merge pull request #2855 from github/charisk/tidy-castings
...
Don't use 'as any' when checking open view
2023-09-25 13:52:14 +01:00
Shati Patel
df1c12f2ba
Rearrange DB panel UI commands ( #2853 )
2023-09-25 14:10:34 +02:00
Charis Kyriakou
bd67afe799
Extract logic into reusable function
2023-09-25 10:08:52 +00:00
Koen Vlaswinkel
7a2876faad
Bump zip-a-folder to v3.1.3
...
This fixes an issue with TypeScript declarations.
See: https://redirect.github.com/maugenst/zip-a-folder/issues/48
2023-09-25 12:07:01 +02:00
Charis Kyriakou
4c9ce2d537
Don't use 'as any' when checking open view
2023-09-25 09:48:57 +00:00
Charis Kyriakou
868ffd79a5
Hide modeling panel when modeling editor is active ( #2851 )
2023-09-25 10:39:43 +01:00
Koen Vlaswinkel
eb3900f642
Bump minimum VS Code version for warnings
2023-09-25 11:38:39 +02:00
Charis Kyriakou
3934ba7e69
Remove redundant argument from onChange ( #2852 )
2023-09-25 09:41:36 +01:00
Charis Kyriakou
3e259f14c9
Add modeling inputs to method modeling panel ( #2849 )
2023-09-22 15:13:40 +00:00
Charis Kyriakou
4323aad254
Fix MethodRow stories to not all show as modeled ( #2850 )
2023-09-22 11:38:36 +00:00
Charis Kyriakou
cd7c26f2ff
Merge pull request #2848 from github/dependabot/npm_and_yarn/extensions/ql-vscode/graphql-16.8.1
...
Bump graphql from 16.6.0 to 16.8.1 in /extensions/ql-vscode
2023-09-22 11:43:04 +01:00
dependabot[bot]
6e9280b97e
Bump graphql from 16.6.0 to 16.8.1 in /extensions/ql-vscode
...
Bumps [graphql](https://github.com/graphql/graphql-js ) from 16.6.0 to 16.8.1.
- [Release notes](https://github.com/graphql/graphql-js/releases )
- [Commits](https://github.com/graphql/graphql-js/compare/v16.6.0...v16.8.1 )
---
updated-dependencies:
- dependency-name: graphql
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-21 17:49:46 +00:00
dependabot[bot]
e43adb6424
Bump @types/js-yaml from 3.12.5 to 4.0.6 in /extensions/ql-vscode
...
Bumps [@types/js-yaml](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/js-yaml ) from 3.12.5 to 4.0.6.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/js-yaml )
---
updated-dependencies:
- dependency-name: "@types/js-yaml"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-21 13:06:11 +00:00
dependabot[bot]
54435d78cf
Bump zip-a-folder from 2.0.0 to 3.1.2 in /extensions/ql-vscode
...
Bumps [zip-a-folder](https://github.com/maugenst/zip-a-folder ) from 2.0.0 to 3.1.2.
- [Commits](https://github.com/maugenst/zip-a-folder/commits )
---
updated-dependencies:
- dependency-name: zip-a-folder
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-21 13:04:12 +00:00
Charis Kyriakou
3a1431ca31
Merge pull request #2843 from github/charisk/model-kind-dropdown
...
Update KindInput component to bring it inline with others
2023-09-21 08:24:54 +01:00
Charis Kyriakou
73f161cdac
Clean up model editor onChange callback ( #2844 )
2023-09-21 08:16:11 +01:00
Robert
ef008a1659
Merge pull request #2840 from github/robertbrignull/node-version
...
Add docs about the Node.js version
2023-09-20 17:27:18 +01:00
Charis Kyriakou
dc33784dbc
Update ModelKindDropdown to be more self-contained
2023-09-20 14:59:11 +00:00
Charis Kyriakou
c4396b764c
Rename KindInput to ModelKindDropdown
2023-09-20 14:59:10 +00:00
Charis Kyriakou
4e096400db
Extract model output dropdown to its own component ( #2839 )
2023-09-20 15:58:24 +01:00
Robert
f99177ac21
Merge pull request #2842 from github/robertbrignull/revert-node18
...
Switch back to Node.js version 16
2023-09-20 14:41:04 +01:00
Robert
f95bf6889b
Revert "Disable unit tests using MockGitHubApiServer"
...
This reverts commit 26450e9236 .
2023-09-20 13:48:21 +01:00
Robert
ed48f4ac76
Revert "Change node version to 18.15.0"
...
This reverts commit 8136328ad6 .
2023-09-20 13:48:12 +01:00
Charis Kyriakou
d2f4f33bea
Extract type for modeled method kind ( #2835 )
2023-09-20 13:36:41 +01:00
Robert
a68d5df13b
Apply suggestions from code review
2023-09-20 12:25:30 +01:00
Robert
495f632ae2
Update node-version.md
2023-09-20 11:57:16 +01:00
Robert
929f54333b
Create vscode-version.md
2023-09-20 11:55:13 +01:00
Charis Kyriakou
4f1a92d09c
Extract model input dropdown to its own component ( #2837 )
2023-09-20 11:25:26 +01:00
Robert
91866971dd
Update node-version.md
2023-09-20 11:17:14 +01:00
Robert
9b15b35274
Add files via upload
2023-09-20 11:15:55 +01:00
Robert
b3544b461a
Update releasing.md
2023-09-20 11:15:35 +01:00
Robert
53fccdfb2e
Create node-version.md
2023-09-20 11:14:06 +01:00
Charis Kyriakou
606bfd7f87
Remove unnecessary spread of modeled method ( #2836 )
2023-09-20 10:56:47 +01:00
Charis Kyriakou
7d088b749b
Update import to fix build ( #2838 )
2023-09-20 09:53:44 +00:00
Charis Kyriakou
315021ef35
Minor redesign of method modeling title ( #2832 )
2023-09-20 10:10:40 +01:00
Charis Kyriakou
1dc70fe625
Extract model type dropdown to its own component ( #2833 )
2023-09-20 10:02:12 +01:00
Charis Kyriakou
36f6531fc4
Move method factories to factories/model-editor ( #2834 )
2023-09-20 08:55:02 +00:00
Robert
4227ff6338
Mock env.itTelemetryEnable
2023-09-19 17:24:53 +01:00
Robert
ca96cdf879
Mock sendTelemetryErrorEvent and check appropriately
2023-09-19 17:23:47 +01:00
Robert
aad1fee787
Stop mocking sendTelemetryException because we don't use that anywhere in the program
2023-09-19 17:18:38 +01:00
Koen Vlaswinkel
fc735cb83b
Merge pull request #2829 from github/koesie10/fix-return-value
...
Fix incorrect `ReturnType` instead of `ReturnValue`
2023-09-19 17:52:20 +02:00
Robert
48399a9aeb
Merge branch 'main' into robertbrignull/telemetry
2023-09-19 16:40:07 +01:00
Robert
c514575bc8
Merge pull request #2831 from github/version/bump-to-v1.9.1
...
Bump version to v1.9.1
2023-09-19 15:22:21 +01:00
Charis Kyriakou
651bc51ed6
Only download automodel query pack when relevant ( #2830 )
2023-09-19 15:11:15 +01:00
github-actions[bot]
dea6426c0b
Bump version to v1.9.1
2023-09-19 13:49:34 +00:00
Koen Vlaswinkel
96a8bea50a
Fix incorrect ReturnType instead of ReturnValue
2023-09-19 15:29:45 +02:00
Robert
297260af88
Merge pull request #2828 from github/v1.9.0
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
Release v1.9.0
2023-09-19 13:43:40 +01:00
Robert
26450e9236
Disable unit tests using MockGitHubApiServer
2023-09-19 11:37:25 +01:00
Robert
8d74933c70
v1.9.0
2023-09-19 10:13:20 +01:00
Robert
8136328ad6
Change node version to 18.15.0
2023-09-19 10:11:55 +01:00
Robert
d3df14f860
Merge pull request #2827 from github/robertbrignull/any/stderr
...
Avoid use of "as any" during error handling
2023-09-19 09:52:51 +01:00
Robert
31e233cc59
Add getChildProcessErrorMessage
2023-09-18 16:34:20 +01:00
Robert
23641a01d9
Avoid checking err.stderr when it's not necessary
2023-09-18 16:33:54 +01:00
Robert
209edf86e7
Merge pull request #2825 from github/robertbrignull/any/preview.ts
...
Avoid using "as any" in .storybook/preview.ts
2023-09-18 16:32:42 +01:00
Robert
3d410c9ce2
Merge pull request #2826 from github/robertbrignull/any/deploy.ts
...
Avoid use of "as any" in gulpfile.ts/deploy.ts
2023-09-18 16:27:28 +01:00
Robert
ef38ffaa6d
Move resolution of package.json path to inside deployPackage
2023-09-18 15:49:06 +01:00
Robert
f195e93d91
Import type of package.json
2023-09-18 15:47:37 +01:00
Robert
26c301603d
Include .storybook in deadcode detection
2023-09-18 15:36:56 +01:00
Robert
b9367095cf
Avoid use of "as any" in gulpfile.ts/deploy.ts
2023-09-18 15:26:18 +01:00
Robert
3d415d2852
Avoid using "as any" in preview.ts
2023-09-18 15:14:28 +01:00
Robert
177c770f4d
Delete config values that we on longer read directly
2023-09-18 11:15:34 +01:00
Robert
d4033615c8
Use onDidChangeTelemetryEnabled instead of listening for config value changes
2023-09-18 11:14:11 +01:00
Robert
9ec6590548
Use env.isTelemetryEnabled instead of checking configuration values ourselves
2023-09-18 11:14:11 +01:00
Robert
5fc9a73e20
Add telemtry tag to settings
2023-09-18 11:14:11 +01:00
Robert
af5547fb77
Use correct values of telemtetry level
2023-09-18 11:14:03 +01:00
Robert
1b0f0f4566
Merge pull request #2823 from github/robertbrignull/model-editor-changelog
...
Add changelog entry for model editor
2023-09-18 09:56:45 +01:00
Robert
1c81eb1b07
Merge pull request #2822 from github/robertbrignull/model-editor-feature-flag
...
Remove codeQL.model.editor feature flag
2023-09-18 09:56:32 +01:00
Robert
a506276635
Update custom telemetry setting description
2023-09-15 16:14:34 +01:00
Robert
f3e72a0ab8
Delete unused relevantSettings field
2023-09-15 16:04:58 +01:00
Robert
c7a9337ac0
Use .qualifiedName instead of writing out manually
2023-09-15 16:04:58 +01:00
Robert
c7bd343f54
Use sendTelemetryErrorEvent when sending errors
2023-09-15 16:04:58 +01:00
Robert
9c76ba35f1
Check both telemetry.telemetryLevel and telemetry.enableTelemetry
2023-09-15 16:04:13 +01:00
Robert
90093fb9f5
Rearrange settings so the telemetry settings are clearer
2023-09-15 15:01:32 +01:00
Robert
f183703b34
Add link to PR
2023-09-15 14:20:35 +01:00
Robert
49a3b534ae
Add changelog entry for model editor
2023-09-15 14:19:38 +01:00
Koen Vlaswinkel
d83ca35f0c
Merge pull request #2817 from github/koesie10/model-editor-row-tests
...
Add tests for model editor row and grid components
2023-09-15 14:04:53 +02:00
Koen Vlaswinkel
8bc8ffe1a1
Merge pull request #2820 from github/koesie10/cleanup-temp-directories
...
Cleanup temporary directories in model editor
2023-09-15 14:04:42 +02:00
Robert
ea2454742c
Remove codeQL.model.editor feature flag
2023-09-15 12:22:22 +01:00
Koen Vlaswinkel
d970b51a7c
Merge pull request #2814 from github/koesie10/test-model-editor-view
...
Add simple test for ModelEditorView
2023-09-15 13:19:13 +02:00
Koen Vlaswinkel
69f5d2c134
Cleanup model editor query dir after use
2023-09-15 11:59:11 +02:00
Koen Vlaswinkel
4d4a72bddb
Cleanup automodel temporary pack after use
2023-09-15 11:59:11 +02:00
Koen Vlaswinkel
ac9355edd1
Rename restoreView test and add comment
2023-09-15 11:26:25 +02:00
Koen Vlaswinkel
2a9c8ef9dd
Merge pull request #2816 from github/koesie10/simple-model-editor-react-tests
...
Add some simple model editor React unit tests
2023-09-15 11:22:37 +02:00
Koen Vlaswinkel
48f0b92d67
Merge pull request #2819 from github/github-action/bump-cli
...
Bump CLI Version to v2.14.5 for integration tests
2023-09-15 10:16:46 +02:00
Koen Vlaswinkel
57dcf58518
Merge pull request #2813 from github/koesie10/use-app-in-webview
...
Use `App` instead of `ExtensionContext` for webviews
2023-09-15 10:12:34 +02:00
github-actions[bot]
43efc9cc4c
Bump CLI version from v2.14.4 to v2.14.5 for integration tests
2023-09-14 15:17:49 +00:00
Koen Vlaswinkel
17e0291bb5
Add tests for MethodRow
2023-09-14 14:41:03 +02:00
Koen Vlaswinkel
499060d549
Add tests for ModeledMethodDataGrid
2023-09-14 14:24:24 +02:00
Koen Vlaswinkel
a359fd7054
Add tests for ModeledMethodsList
2023-09-14 14:11:40 +02:00
Koen Vlaswinkel
d3a9426411
Add story and tests for LibraryRow
2023-09-14 14:06:36 +02:00
Koen Vlaswinkel
72faf86678
Add some simple model editor React unit tests
2023-09-14 13:45:45 +02:00
Koen Vlaswinkel
7f20921984
Add simple test for ModelEditorView
2023-09-14 12:20:01 +02:00
Koen Vlaswinkel
d7565fb849
Use App instead of ExtensionContext for webviews
2023-09-14 12:03:18 +02:00
Robert
9175449323
Merge pull request #2811 from github/robertbrignull/fix-jump-to-usage
...
Fix jumping to usage and updating method modeling panel
2023-09-13 13:07:24 +01:00
Robert
c8487c9431
Fix jumping to usage and updating method modeling panel
2023-09-13 12:41:53 +01:00
Robert
93fc90fcd0
Merge pull request #2790 from github/dependabot/github_actions/actions/checkout-4
...
Bump actions/checkout from 3 to 4
2023-09-12 16:53:57 +01:00
Robert
0a705a6bfa
Merge pull request #2808 from github/robertbrignull/rename_hideModeledMethods_code
...
Rename hideModeledApis => hideModeledMethods throughout the code
2023-09-12 16:48:46 +01:00
Robert
b424157ab0
Merge pull request #2806 from github/robertbrignull/rename_externalApiUsages
...
Renames remaining references to "external API usage" in the code
2023-09-12 16:45:51 +01:00
github-actions[bot]
8c13124dfd
Bump CLI version from v2.14.3 to v2.14.4 for integration tests ( #2809 )
...
Co-authored-by: github-actions[bot] <github-actions@github.com >
2023-09-12 15:13:34 +00:00
Robert
cbf0f279b9
Update extensions/ql-vscode/src/model-editor/model-editor-view.ts
2023-09-12 15:53:24 +01:00
Robert
a5b22fd0b9
Update extensions/ql-vscode/test/unit-tests/model-editor/bqrs.test.ts
2023-09-12 15:50:48 +01:00
Robert
c6736e8576
Merge pull request #2807 from github/robertbrignull/rename_hideModeledMethods_checkbox
...
Rename checkbox for hide modeled APIs => methods
2023-09-12 15:47:45 +01:00
Nick Rolfe
acf7270e39
Relax 'resolve ram' test ( #2805 )
2023-09-12 14:35:42 +01:00
Robert
3ae55e92b8
Rename hideModeledApis => hideModeledMethods throughout
2023-09-12 14:30:22 +01:00
Robert
c3fa83f301
Rename checkbox for hide modeled APIs => methods
2023-09-12 14:18:28 +01:00
Robert
9018cac91a
Rename decodeBqrsToExternalApiUsages => decodeBqrsToMethods
2023-09-12 14:02:23 +01:00
Robert
aec742a508
Rename loadExternalApiUsages => loadMethods
2023-09-12 13:59:29 +01:00
Robert
64f6a770c3
Merge pull request #2800 from github/robertbrignull/num-hidden-methods
...
Add a row to the model editor tables showing how many methods have been hidden
2023-09-12 11:38:48 +01:00
Koen Vlaswinkel
7a2b61432c
Merge pull request #2804 from github/koesie10/source-archive-model-editor
...
Do not add source archive folder for "Model dependency"
2023-09-12 12:10:58 +02:00
Robert
b04ecc959a
Use pluralize
2023-09-12 10:18:26 +01:00
Robert
3ee16f88f2
Pull out props to separate variables instead of referencing props.foo
2023-09-12 10:14:10 +01:00
github-actions[bot]
ca079e085d
Bump version to v1.8.13 ( #2803 )
...
Co-authored-by: github-actions[bot] <github-actions@github.com >
2023-09-11 14:52:33 +00:00
Koen Vlaswinkel
c93dd7a25b
Do not add source archive folder for "Model dependency"
2023-09-11 15:45:46 +02:00
Shati Patel
9925b4e3bc
v1.8.12 ( #2801 )
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2023-09-11 14:02:23 +01:00
Koen Vlaswinkel
27f46062ae
Merge pull request #2799 from github/koesie10/upgrade-semver
...
Upgrade transitive semver dependencies
2023-09-11 13:08:48 +02:00
Robert
e379320015
Add row showing how many methods are hidden
2023-09-11 11:57:18 +01:00
Robert
bbacb147d2
Hide table entirely if there aren't any non-hidden methods
2023-09-11 11:56:33 +01:00
Robert
58d38ff867
Move calculation of hidden/modelable rows into ModeledMethodDataGrid
2023-09-11 11:52:37 +01:00
Koen Vlaswinkel
90972defed
Upgrade transitive semver dependencies
2023-09-11 10:51:07 +02:00
Andrew Eisenberg
3a8028cb6f
Merge pull request #2786 from github/aeisenberg/extensible-predicate-metadata
...
Copy more files into the synthetic variant analysis pack
2023-09-08 09:38:49 -07:00
Koen Vlaswinkel
6e802b1212
Merge pull request #2798 from github/koesie10/group-framework-mode-models
...
Group framework mode model files by package
2023-09-08 17:17:53 +02:00
Koen Vlaswinkel
c868bdcdec
Merge pull request #2797 from github/koesie10/sort-methods-alphabetically
...
Sort methods alphabetically
2023-09-08 16:54:52 +02:00
Koen Vlaswinkel
b1412912ec
Merge pull request #2795 from github/koesie10/switch-mode-loading
...
Set loading state when switching between modes
2023-09-08 16:54:27 +02:00
Koen Vlaswinkel
708c5bc3ef
Group framework mode model files by package
2023-09-08 16:08:13 +02:00
Koen Vlaswinkel
6f020d4b33
Sort methods alphabetically
2023-09-08 14:41:19 +02:00
Anders Starcke Henriksen
1b7a68a43e
Merge pull request #2791 from github/starcke/model-editor-test-plan
...
Test plan for model editor.
2023-09-08 14:38:01 +02:00
Shati Patel
8f7befd031
Make "databases" the top panel in the CodeQL sidebar ( #2796 )
2023-09-08 12:23:01 +00:00
Koen Vlaswinkel
3157ffab88
Set empty array in ModelEditorView
2023-09-08 14:20:45 +02:00
Koen Vlaswinkel
bf024943a8
Merge pull request #2794 from github/koesie10/improve-model-editor
...
Improve responsiveness of model editor
2023-09-08 13:40:29 +02:00
Koen Vlaswinkel
b0eab8b9fe
Set loading state when switching between modes
2023-09-08 13:34:08 +02:00
Koen Vlaswinkel
72ab83f15b
Remove createLockFile argument
2023-09-08 12:56:02 +02:00
Koen Vlaswinkel
567cb10a57
Merge pull request #2793 from github/koesie10/feature-flag-flow-generation
...
Add feature flag for flow generation
2023-09-08 12:48:59 +02:00
Koen Vlaswinkel
13c2f5979e
Add feature flag for flow generation
2023-09-08 12:07:27 +02:00
Koen Vlaswinkel
cecd8033bb
Improve responsiveness of model editor
2023-09-08 12:06:26 +02:00
Anders Starcke Henriksen
35dfebd353
Fix linter.
2023-09-08 10:28:56 +02:00
Anders Starcke Henriksen
6e50d4af7b
Address feedback.
2023-09-08 10:20:15 +02:00
Anders Starcke Henriksen
f8a90e5fba
Update docs/test-plan.md
...
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com >
2023-09-08 10:01:02 +02:00
Robert
45312865b1
Merge pull request #2782 from github/robertbrignull/calculateModeledPercentage
...
Change calculateModeledPercentage to accept Method instead of using Pick
2023-09-07 16:51:53 +01:00
Robert
0897cdd96d
Merge branch 'main' into dependabot/github_actions/actions/checkout-4
2023-09-07 16:37:03 +01:00
Robert
2e45dcd7b9
Merge pull request #2777 from github/robertbrignull/model-remove-disableAutoNameExtensionPack
...
Remove the disableAutoNameExtensionPack feature flag
2023-09-07 16:35:59 +01:00
Robert
4b93d341fe
Merge pull request #2784 from github/robertbrignull/saving-progress
...
Make progress notifications more useful when calling loadExternalApiUsages
2023-09-07 16:35:28 +01:00
Robert
5922bdf0e0
Merge pull request #2785 from github/robertbrignull/in-progress-dropdown
...
Adjust styling of disabled dropdowns when automodeling is in progress
2023-09-07 16:31:15 +01:00
dependabot[bot]
709c49542e
Bump actions/checkout from 3 to 4
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-07 13:19:53 +00:00
Anders Starcke Henriksen
860507dfa5
Merge pull request #2789 from github/version/bump-to-v1.8.12
...
Bump version to v1.8.12
2023-09-07 15:16:15 +02:00
github-actions[bot]
3a07e143de
Bump version to v1.8.12
2023-09-07 12:40:41 +00:00
Anders Starcke Henriksen
baf959efa9
Test plan for model editor.
2023-09-07 14:35:17 +02:00
Anders Starcke Henriksen
df5a7bce19
Merge pull request #2788 from github/v1.8.11
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.8.11
2023-09-07 13:51:35 +02:00
Anders Starcke Henriksen
1b3dc7d132
v1.8.11
2023-09-07 13:31:03 +02:00
Andrew Eisenberg
d8fb227cc7
Fix failing test
2023-09-05 14:49:36 -07:00
Andrew Eisenberg
767051e43f
Update changelog
2023-09-05 13:31:18 -07:00
Andrew Eisenberg
d264bca304
Copy more files into the synthetic variant analysis pack
...
Before this change and starting with CLI v2.14.3, if you wanted to run
a variant analysis query and the pack it is contained in has at least
one query that contains an extensible predicate, this would be an error.
The reason is that v2.14.3 introduced deep validation for data
extensions. We are not copying the query that contains an extensible
predicate to the synthetic pack we are generating. This means that deep
validation will fail because there will be extensions that target the
missing extensible predicate.
This change avoids the problem by copying any query files that contain
extensible predicates to the synthetic pack. It uses the internal
`generate extensible-predicate-metadata` command to discover which
query files contain extensible predicates and copies them.
2023-09-05 13:28:53 -07:00
Robert
a2f1710aa5
Add story for when modeling is in progress
2023-09-05 16:58:10 +01:00
Robert
fd1c7f338d
Make onChange optional
2023-09-05 16:58:10 +01:00
Robert
040a91a6d7
Use custom disabled placeholder text for InProgressDropdown
2023-09-05 16:58:10 +01:00
Robert
1e2acb0acb
Clarify progress message from loadExternalApiUsages
2023-09-05 16:53:01 +01:00
Robert
2171ec1a03
Include cliServer.resolveQlpacks in the progress notification so there isn't a gap with no updates
2023-09-05 16:48:25 +01:00
Robert
8407516b31
Move progress notification to cover entire saveModeledMethods message handler
2023-09-05 16:45:50 +01:00
Robert
899cfb058c
Store externalApiQueriesProgressMaxStep as a constant
2023-09-05 16:43:31 +01:00
Robert
95e4b04471
Move custom progress editing from loadExternalApiUsages into runExternalApiQueries
2023-09-05 16:43:03 +01:00
Robert
816b66c57c
Move withProgress out of loadExternalApiUsages
2023-09-05 16:36:01 +01:00
Robert
247ba4e8ea
Merge pull request #2779 from github/robertbrignull/dropdown-disabled
...
Adjust styling of disabled dropdowns to make their state clearer
2023-09-05 16:20:40 +01:00
Robert
a1c6a3a642
Change calculateModeledPercentage to accept Method instead of using Pick
2023-09-05 15:23:31 +01:00
Robert
e9a2028c10
Delete askForWorkspaceFolder
2023-09-05 11:03:01 +01:00
Shati Patel
a3ce9f516a
Queries Panel: Create query from welcome view ( #2780 )
2023-09-05 10:34:38 +01:00
Robert
f6b3f28039
Merge pull request #2781 from github/robertbrignull/model-editor-telemetry
...
Emit telemetry for all messages sent from model editor
2023-09-05 10:04:14 +01:00
Robert
ba423376cd
Emit telemetry for all messages sent from model editor
2023-09-04 17:13:29 +01:00
Robert
e9b459adaf
Merge pull request #2778 from github/robertbrignull/MethodRow_stories
...
Provide stories for all states of MethodRow
2023-09-04 15:42:59 +01:00
Robert
074f3fb402
Move dropdown arrow away from the right-hand edge
2023-09-04 15:23:21 +01:00
Robert
c316d52514
Set opacity to 40% when disabled
2023-09-04 15:23:03 +01:00
Robert
9af0239041
Show a dash when dropdown is disabled
2023-09-04 15:22:52 +01:00
Robert
5cf6786e9c
Merge branch 'main' into robertbrignull/MethodRow_stories
2023-09-04 14:19:35 +01:00
Charis Kyriakou
09077a0e24
Rename ExternalApiUsage to Method ( #2776 )
2023-09-04 14:10:10 +02:00
Robert
47c897e9bd
Include stories for all modeled method types
2023-09-04 11:12:07 +01:00
Robert
096e6e8ffd
Wrap MethodRow in a VSCodeDataGrid during story
2023-09-04 11:00:55 +01:00
Robert
480fa517ea
Remove the disableAutoNameExtensionPack feature flag
2023-09-04 10:16:08 +01:00
Charis Kyriakou
2d033bff57
Update jump to usage to include the method ( #2773 )
2023-09-01 13:30:54 +01:00
Robert
1861692055
Merge pull request #2768 from github/robertbrignull/mocked-treeview
...
Use mockedObject for TreeView
2023-09-01 12:41:27 +01:00
Charis Kyriakou
ac7a37c02e
Add ability to set method for modeling in the modeling panel ( #2767 )
2023-09-01 11:16:10 +00:00
Robert
b5d6c4d84c
Merge pull request #2771 from github/robertbrignull/normalize-feature-flag
...
Make methodModelingView match the naming of other flags
2023-09-01 11:05:10 +01:00
Anders Starcke Henriksen
cdd6553735
Merge pull request #2772 from github/starcke/fix-rename-comment
...
Fix a comment that should be renamed.
2023-09-01 11:52:00 +02:00
Anders Starcke Henriksen
6bb0854ff2
Fix a comment that should be renamed.
2023-09-01 11:26:33 +02:00
Robert
c51aaf7790
Make methodModelingView match the other flags
2023-09-01 10:19:12 +01:00
Anders Starcke Henriksen
a6745379c4
Merge pull request #2766 from github/starcke/rename-ff
...
Rename feature flags.
2023-09-01 10:35:28 +02:00
Robert
1178e4c3ae
Merge pull request #2770 from github/robertbrignull/model-beta-label
...
Add beta label to model editor
2023-08-31 15:49:27 +01:00
Robert
59c567a8fa
Add beta label to model editor
2023-08-31 15:25:54 +01:00
Shati Patel
4f2b46aa85
Add "create query" button to queries panel ( #2764 )
2023-08-31 15:02:25 +01:00
Shati Patel
66f12bfbef
Make the "Create query" location workspace-specific ( #2769 )
2023-08-31 15:02:10 +01:00
Robert
2b5d233847
Use mockedObject for TreeView
2023-08-31 12:01:49 +01:00
Robert
11ca60f213
Merge pull request #2738 from github/robertbrignull/useScrollIntoView
...
Convert ScrollIntoViewHelper into a React hook
2023-08-31 10:58:50 +01:00
Robert
dea6bc257a
Merge branch 'main' into robertbrignull/useScrollIntoView
2023-08-31 10:37:16 +01:00
Charis Kyriakou
26b602399a
Extract external api usage name component and reuse it ( #2765 )
2023-08-31 10:12:19 +01:00
Anders Starcke Henriksen
0836307f29
Rename feature flags.
2023-08-31 09:46:22 +02:00
Anders Starcke Henriksen
e61f619f8f
Merge pull request #2763 from github/starcke/rename-vars
...
Starcke/rename vars
2023-08-31 09:17:20 +02:00
Nora
fad674b1c5
Merge pull request #2760 from github/nora/add-components-to-modeling-panel
...
Adds container and header css to new method model sidebar
2023-08-30 17:37:34 +02:00
Nora
4d2856699b
polish
2023-08-30 15:14:51 +00:00
Shati Patel
b51d027b0c
Make "create query" command available when queries panel is enabled ( #2762 )
2023-08-30 16:09:39 +01:00
Nora
595249a9d6
Addning props and minor changes
2023-08-30 15:05:11 +00:00
Anders Starcke Henriksen
00b3ea473c
Misc renames.
2023-08-30 16:36:17 +02:00
Anders Starcke Henriksen
46f80efa4c
Rename in strings.
2023-08-30 16:36:17 +02:00
Anders Starcke Henriksen
05a7d933d1
Rename DataExtensionsEditor
2023-08-30 16:36:17 +02:00
Anders Starcke Henriksen
6da39ee79f
Rename "DataExtensionEditor".
2023-08-30 16:36:17 +02:00
Anders Starcke Henriksen
bb4d97999e
Merge pull request #2761 from github/starcke/rename-files2
...
Rename files.
2023-08-30 16:35:52 +02:00
Anders Starcke Henriksen
af3434b87c
Remove spurious theme.
2023-08-30 16:08:42 +02:00
Nora
083b232bb3
Fix merge conflict
2023-08-30 13:35:03 +00:00
Nora
a65c91c84e
Add Container and Header
2023-08-30 13:33:32 +00:00
Anders Starcke Henriksen
23f8c48b06
Rename files.
2023-08-30 15:06:45 +02:00
Anders Starcke Henriksen
7fbb1286b9
Merge pull request #2759 from github/starcke/rename-files
...
Starcke/rename files
2023-08-30 14:50:51 +02:00
Anders Starcke Henriksen
571e6f285f
Update webview enum.
2023-08-30 13:59:51 +02:00
Anders Starcke Henriksen
e64cf4073c
Rename data-extension-editor files.
2023-08-30 13:46:48 +02:00
Anders Starcke Henriksen
e3a2a11b3d
Merge pull request #2754 from github/starcke/rename-directories
...
Starcke/rename directories
2023-08-30 09:11:00 +02:00
Anders Starcke Henriksen
9b121d56c2
Merge branch 'main' into starcke/rename-directories
2023-08-29 15:38:08 +02:00
Anders Starcke Henriksen
b548bbd43b
Merge pull request #2758 from github/starcke/more-java-update
...
Change the java query to work for multiple java versions.
2023-08-29 15:37:28 +02:00
Anders Starcke Henriksen
ccdb46a1bb
Merge branch 'main' into starcke/rename-directories
2023-08-29 15:16:33 +02:00
Anders Starcke Henriksen
d1a342beaf
Merge pull request #2757 from github/starcke/automodel-pack
...
Use auto-model pack to run auto-model queries.
2023-08-29 15:12:03 +02:00
Anders Starcke Henriksen
eeac123ee5
Update non-build references.
2023-08-29 14:39:22 +02:00
Anders Starcke Henriksen
73c596c87a
Rename other directories.
2023-08-29 14:38:18 +02:00
Anders Starcke Henriksen
c6f40b3152
Rename main directory.
2023-08-29 14:38:18 +02:00
Anders Starcke Henriksen
3a0843219e
Change the java query to work for multiple java versions.
2023-08-29 13:57:16 +02:00
Anders Starcke Henriksen
b00a2cc803
Use auto-model pack to run auto-model queries.
2023-08-29 13:39:44 +02:00
Anders Starcke Henriksen
14b9f932ab
Merge pull request #2731 from github/starcke/no-submodule
...
Make automodel and flow queries work without submodule.
2023-08-29 12:45:22 +02:00
Anders Starcke Henriksen
f3e32baec4
Update extensions/ql-vscode/src/data-extensions-editor/external-api-usage-queries.ts
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2023-08-29 11:45:32 +02:00
Anders Starcke Henriksen
20e5429af8
Merge pull request #2755 from github/starcke/fix-neutral-fetch
...
Fix ql code in neutral fetch.
2023-08-29 09:29:59 +02:00
Dave Bartolomeo
d23178be85
Merge pull request #2756 from github/github-action/bump-cli
...
Bump CLI Version to v2.14.3 for integration tests
2023-08-28 12:18:48 -04:00
Andrew Eisenberg
b09e9942b2
Add more path triggers for cli-test.yml
2023-08-28 15:25:00 +00:00
github-actions[bot]
fc5cfd0aec
Bump CLI version from v2.14.2 to v2.14.3 for integration tests
2023-08-28 13:45:42 +00:00
Anders Starcke Henriksen
259159df45
Add missing pack download and fix lock file creation.
2023-08-28 13:22:03 +02:00
Anders Starcke Henriksen
bc7c97e216
Fix ql code in neutral fetch.
2023-08-28 09:42:04 +02:00
Charis Kyriakou
af22a1573b
Add new method modeling panel ( #2752 )
2023-08-25 15:47:57 +00:00
Anders Starcke Henriksen
d2eb366e74
Make automodel and flow queries work without submodule.
2023-08-25 14:57:54 +02:00
Anders Starcke Henriksen
6a6028bf63
Merge pull request #2746 from github/starcke/update-editor-name
...
Update editor name in visible strings.
2023-08-25 14:13:19 +02:00
Charis Kyriakou
3c7e1fc192
Remove codeQL.dataExtensions.frameworkMode setting ( #2753 )
2023-08-25 11:28:21 +00:00
Anders Starcke Henriksen
0433f899fd
Merge pull request #2750 from github/starcke/fetch-queries-out-of-view
...
Starcke/fetch queries out of view
2023-08-25 13:25:04 +02:00
Charis Kyriakou
c82f00eb45
Rename ModelDetail to MethodsUsage in types and functions ( #2751 )
2023-08-25 11:06:21 +01:00
Shati Patel
94edb9bf16
Merge pull request #2749 from github/shati-patel/implement-dropdown
...
Make "result format" dropdown determine result display
2023-08-25 10:52:23 +01:00
Shati Patel
4a87a6fddf
Merge pull request #2745 from github/shati-patel/result-format-view
...
Display "result format" dropdown in results view for (path-)problem queries
2023-08-25 09:46:54 +01:00
Anders Starcke Henriksen
9543ab339f
Update tests.
2023-08-25 09:50:01 +02:00
Anders Starcke Henriksen
398f16c4cb
Change fetch queries to use shared methods.
2023-08-25 09:49:57 +02:00
Anders Starcke Henriksen
ea14767f2a
Rename methods in fetch queries.
2023-08-25 09:28:46 +02:00
Anders Starcke Henriksen
b6deb8e0ea
Merge pull request #2744 from github/starcke/general-setup
...
Move pack setup out of fetch queries.
2023-08-25 09:26:01 +02:00
Nora
7b78fc1dd9
Merge pull request #2748 from github/nora/rename-method-usages-folder
...
Rename methods usage folder and command
2023-08-24 20:02:28 +02:00
shati-patel
0ccd39a368
Update changelog
2023-08-24 17:37:40 +01:00
shati-patel
24b93e247c
Make "result format" dropdown determine result display
2023-08-24 17:28:54 +01:00
Nora
6e3b0b245c
Merge pull request #2747 from github/nora/rename-model-details-files
...
Rename methods usage panel files
2023-08-24 18:12:39 +02:00
Nora
6939caa6a5
Rename command and folders
2023-08-24 15:22:13 +00:00
Nora
2e8e7cae47
Rename files only
2023-08-24 15:13:01 +00:00
shati-patel
f8d542d141
Only show the "result format" dropdown for (path-)problem queries
2023-08-24 15:44:08 +01:00
shati-patel
6715669036
Add "result format" dropdown to MRVA view
2023-08-24 15:44:07 +01:00
Shati Patel
c38a01e937
Add a dropdown for choosing MRVA result format ( #2743 )
2023-08-24 14:42:44 +00:00
Anders Starcke Henriksen
74a12b9fed
Move test to separate file.
2023-08-24 16:16:24 +02:00
Anders Starcke Henriksen
906af36337
Update editor name in visible strings.
2023-08-24 16:07:33 +02:00
Anders Starcke Henriksen
359e23fc59
Fix test.
2023-08-24 13:53:34 +02:00
Anders Starcke Henriksen
b13dd7545c
Merge branch 'main' into starcke/general-setup
2023-08-24 13:45:00 +02:00
Anders Starcke Henriksen
ac0dfa5e83
Merge pull request #2742 from github/starcke/flow-queries-refactor
...
Starcke/flow queries refactor
2023-08-24 13:38:13 +02:00
Shati Patel
2ffb7894d4
Always read BQRS results file ( #2741 )
2023-08-24 12:11:51 +01:00
Nora
422f6de05e
Merge pull request #2735 from github/nora/test-model-details-view
...
Add tests for Model Details View
2023-08-24 12:33:51 +02:00
Shati Patel
ee88ea1658
Store query @kind when running a variant analysis ( #2740 )
2023-08-24 10:18:20 +01:00
Nora
0daa06bc0d
rename test and remove boolean type
2023-08-24 08:58:37 +00:00
Anders Starcke Henriksen
c584d02805
Merge pull request #2734 from github/starcke/automodel-queries-refactor
...
Starcke/automodel queries refactor
2023-08-24 09:57:32 +02:00
Nora
c56936e2f6
create and use factories
2023-08-23 16:06:30 +00:00
Anders Starcke Henriksen
1fc735639b
Merge pull request #2733 from github/starcke/refactor-names
...
Rename query files to have consistent suffix.
2023-08-23 12:58:18 +02:00
Charis Kyriakou
0352629eb4
Rename WebviewView to WebviewKind ( #2739 )
2023-08-23 11:27:58 +01:00
Anders Starcke Henriksen
877fc51494
Move pack setup out of fetch queries.
2023-08-23 11:27:18 +02:00
Anders Starcke Henriksen
886f211441
Change flow queries to use shared methods.
2023-08-23 11:27:03 +02:00
Anders Starcke Henriksen
75d275c93f
Rename methods in flow queries.
2023-08-23 11:27:03 +02:00
Anders Starcke Henriksen
5d1fa1d6b5
Reorder methods in flow queries.
2023-08-23 11:27:03 +02:00
Anders Starcke Henriksen
4fce448717
Address comments.
2023-08-23 11:26:23 +02:00
Robert
610c936690
Add useScrollIntoView hook
2023-08-22 17:01:25 +01:00
Robert
d777427c0a
Merge pull request #2737 from github/robertbrignull/AlertTable-functional
...
Convert AlertTable to a function component
2023-08-22 16:59:00 +01:00
Charis Kyriakou
81924af1e4
Don't download artifacts for repos with no results in MRVA ( #2736 )
...
* Don't download artifacts for repos with no results
* Remove getVariantAnalysisRepoResult requests for repos with no results
* Run fix-scenario-file-numbering for mrva-problem-query-success scenario
* Update CHANGELOG
2023-08-22 16:23:40 +01:00
Nora
45f7d22d2a
Add reveal test
2023-08-22 13:11:46 +00:00
Robert
dcef43c6d5
Convert updateSelectionCallback to use useCallback
2023-08-22 14:08:14 +01:00
Robert
160642ec73
Convert toggle to use useCallback
2023-08-22 14:07:54 +01:00
Robert
240dd51dc0
Convert handleNavigationEvent to use useCallback
2023-08-22 14:07:54 +01:00
Robert
ad42b060b7
Decompose props earlier
2023-08-22 14:07:54 +01:00
Robert
23b2327bd0
Convert AlertTable to a function component
2023-08-22 14:07:52 +01:00
Robert
450d294bab
Move render to the end of the component
2023-08-22 14:04:48 +01:00
Robert
4e376063ee
Move getNewSelection to before it is used
2023-08-22 14:02:56 +01:00
Anders Starcke Henriksen
39cb219e56
Fix broken reference in test.
2023-08-22 14:53:04 +02:00
Anders Starcke Henriksen
e01fb9172f
Update tests.
2023-08-22 14:23:26 +02:00
Anders Starcke Henriksen
1764151bf7
Change automodel queries to use shared methods.
2023-08-22 14:20:59 +02:00
Anders Starcke Henriksen
82c40c69e6
Add generalized run query method.
2023-08-22 14:18:19 +02:00
Anders Starcke Henriksen
1a34d782e8
Reorder methods in automodel queries.
2023-08-22 14:16:18 +02:00
Anders Starcke Henriksen
08c1b57661
Rename query files to have consistent suffix.
2023-08-22 14:06:22 +02:00
Robert
5fc34248b3
Merge pull request #2732 from github/robertbrignull/AlertTable-decompose
...
Split AlertTable into smaller components
2023-08-22 12:24:12 +01:00
Robert
bee7d81fb4
Merge branch 'main' into robertbrignull/AlertTable-decompose
2023-08-22 11:40:45 +01:00
Charis Kyriakou
3094405f68
Split out CLI version tests to separate workflow ( #2729 )
2023-08-22 11:28:36 +01:00
Nora
392e76d8f2
Add getChildren tests
2023-08-22 08:56:42 +00:00
Nora
6e4e89a006
Move dataProvider creation to beforeEach
2023-08-22 08:56:07 +00:00
Nora
cb2802e2e7
Add mode details panel test
2023-08-22 08:55:25 +00:00
Robert
af1af074dc
Convert updateSelectionCallback to not use double-nested methods
2023-08-21 17:17:37 +01:00
Robert
d65ce3e24a
Use useCallback when calling toggleExpanded
2023-08-21 17:13:49 +01:00
Robert
13ce5f7e3c
Merge pull request #2730 from github/robertbrignull/details-ship
...
Remove config.codeQL.dataExtensions.modelDetailsView feature flag
2023-08-21 14:53:24 +01:00
Robert
eebe11e5dd
Simplify passing similar props
2023-08-21 14:52:42 +01:00
Robert
bd5d361de1
Pass around toggle instead of toggler
2023-08-21 14:26:10 +01:00
Robert
e3596db8e7
Remove rows array and render AlertTableResultRow inline
2023-08-21 14:26:10 +01:00
Robert
21b1c997c6
Move rendering of AlertTablePathRow to inside of AlertTableResultRow
2023-08-21 14:26:09 +01:00
Robert
9ecf97152a
Move rendering of msg to inside AlertTableResuiltRow
2023-08-21 14:25:42 +01:00
Robert
3983087bc8
Use useMemo for callback passed to SarifLocation.onClick in AlertTableResultRow
2023-08-21 14:25:08 +01:00
Robert
636d0bf025
Move rendering of locationCells to inside AlertTableResuiltRow
2023-08-21 14:25:08 +01:00
Robert
fe4d87dae5
Teach AlertTableResultRow how to render results without codeFlows
2023-08-21 14:25:06 +01:00
Robert
1794c6b7f7
Simplify rendering in AlertTable
2023-08-21 14:24:36 +01:00
Robert
23d815ff05
Use useMemo for callback passed to AlertTableDropdownIndicatorCell.onClick in AlertTableResultRow
2023-08-21 14:24:25 +01:00
Robert
8945abcb57
Pull out AlertTableResultRow to a separate component
2023-08-21 14:23:57 +01:00
Robert
a576dace04
Do all rendering in AlertTablePathRow in one place
2023-08-21 14:23:05 +01:00
Robert
3e7577c984
Use useMemo for callback passed to AlertTableDropdownIndicatorCell.onClick in AlertTablePathRow
2023-08-21 14:21:58 +01:00
Robert
acb76a64ef
Pull out AlertTablePathRow to a separate component
2023-08-21 14:20:45 +01:00
Robert
ba0cf9a22d
Use useMemo for callback passed to SarifLocation.onClick in AlertTablePathNodeRow
2023-08-21 14:19:54 +01:00
Robert
443c9ac56c
Inline some rendering in AlertTablePathNodeRow
2023-08-21 14:19:53 +01:00
Robert
91e69c93be
Pull out AlertTablePathNodeRow to a separate component
2023-08-21 14:19:53 +01:00
Robert
7e31b6e42a
Construct rows using maps instead of mutating array from multiple places
2023-08-21 14:19:52 +01:00
Robert
cff7170fdc
Move AlertTableTruncatedMessage to a new component in a new file
2023-08-21 14:17:47 +01:00
Robert
ca40963238
Move AlertTableNoResults to a new component in a new file
2023-08-21 14:17:45 +01:00
Robert
b1ff75b646
Remove config.codeQL.dataExtensions.modelDetailsView feature flag
2023-08-21 12:32:45 +01:00
Robert
e5ab1118ee
Merge pull request #2719 from github/koesie10/fix-button-accessibility
...
Fix button accessibility
2023-08-21 11:48:36 +01:00
Robert
d90fb69e39
Merge branch 'main' into koesie10/fix-button-accessibility
2023-08-21 11:11:35 +01:00
Robert
2f4eed4a4d
Merge pull request #2726 from github/koesie10/fix-alert-table-accessibility
...
Fix accessibility of alert table
2023-08-21 11:04:41 +01:00
Nora
2cb520d603
Merge pull request #2717 from github/nora/hide-modeled-on-model-details-view
...
Respect the "Hide modeled APIs" checkbox in the model details view
2023-08-21 11:09:48 +02:00
Charis Kyriakou
4a752d27c4
Moves mock GitHub API to /common ( #2728 )
...
* Move mock GitHub API to /common
* Rename MRVA mock scenarios
* Update mock GitHub API docs
2023-08-21 08:49:27 +01:00
Nora
6cfd20eca4
Set hodeModeledApis variable
2023-08-21 07:29:37 +00:00
dependabot[bot]
36259b21db
Bump @testing-library/jest-dom in /extensions/ql-vscode ( #2723 )
...
Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom ) from 5.16.5 to 6.0.0.
- [Release notes](https://github.com/testing-library/jest-dom/releases )
- [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/jest-dom/compare/v5.16.5...v6.0.0 )
---
updated-dependencies:
- dependency-name: "@testing-library/jest-dom"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2023-08-18 15:39:28 +01:00
dependabot[bot]
cd14a37f79
Bump lint-staged from 13.2.0 to 14.0.0 in /extensions/ql-vscode ( #2722 )
...
Bumps [lint-staged](https://github.com/okonet/lint-staged ) from 13.2.0 to 14.0.0.
- [Release notes](https://github.com/okonet/lint-staged/releases )
- [Commits](https://github.com/okonet/lint-staged/compare/v13.2.0...v14.0.0 )
---
updated-dependencies:
- dependency-name: lint-staged
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2023-08-18 14:55:10 +01:00
Koen Vlaswinkel
d6e0c6a4a7
Fix accessibility of alert table dropdown
2023-08-18 13:28:17 +02:00
Koen Vlaswinkel
9f589880df
Split alert table dropdown indicator cell
2023-08-18 13:26:45 +02:00
Koen Vlaswinkel
b7a4419420
Add story for AlertTable
2023-08-18 13:26:19 +02:00
Koen Vlaswinkel
1d2ef805fb
Merge remote-tracking branch 'origin/main' into koesie10/fix-button-accessibility
2023-08-18 10:03:54 +02:00
Koen Vlaswinkel
2888fddf61
Move all ResultTablesHeader styles to styled-components
2023-08-18 10:03:36 +02:00
Koen Vlaswinkel
a5c675b8c7
Add story for ResultTablesHeader
2023-08-18 09:58:34 +02:00
Shati Patel
d05dba4bba
Fix changelog entry ( #2725 )
2023-08-17 16:13:40 +00:00
Shati Patel
2db0ca8ecc
Group extension settings in the VS Code UI ( #2706 )
2023-08-17 16:48:15 +01:00
Robert
497dc31819
Merge pull request #2716 from github/robertbrignull/data-renames
...
Rename files in src/view/results to match their components
2023-08-17 15:23:38 +01:00
Nora
cd309aece6
Adjust badge number
2023-08-17 12:53:24 +00:00
Nora
aaaf799557
Add test
2023-08-17 12:27:16 +00:00
Nora
ece54b8f7d
Make all setStage arguments mandatory
2023-08-17 12:26:13 +00:00
Nora
0824892507
Move post message and use effect
2023-08-17 11:02:20 +00:00
Nora
082268e201
Rename constant file
2023-08-17 11:00:45 +00:00
Nora
27bce4a1e9
Add tests
2023-08-17 09:19:01 +00:00
Nora
56ecd1a84c
hide unmodeled apis
2023-08-17 09:19:01 +00:00
Nora
84ab602277
Send message from from view
2023-08-17 09:19:01 +00:00
Koen Vlaswinkel
a86a373e19
Merge pull request #2718 from github/koesie10/upgrade-storybook
...
Upgrade Storybook
2023-08-17 10:04:36 +02:00
Koen Vlaswinkel
90a39ec293
Use button instead of a for raw results link
2023-08-16 16:45:51 +02:00
Koen Vlaswinkel
3dd8583116
Use button instead of a for clickable location links
2023-08-16 16:45:47 +02:00
Koen Vlaswinkel
b0663669b0
Use button instead of a for compare table queries
2023-08-16 16:45:44 +02:00
Koen Vlaswinkel
493c9cb5fe
Add story for compare table
2023-08-16 16:45:41 +02:00
Robert
99dd9166b3
Merge pull request #2709 from github/robertbrignull/details-visible
...
Only show the details view when a data extensions editor is open
2023-08-16 15:28:38 +01:00
Koen Vlaswinkel
10604808e0
Upgrade Storybook
2023-08-16 15:45:28 +02:00
Robert
3164c3f11f
Rename results.tsx => ResultsApp.tsx
2023-08-16 13:21:07 +01:00
Robert
ed36fb725b
Rename raw-results-table.tsx => RawTable.tsx
2023-08-16 13:21:07 +01:00
Robert
67b138f0c2
Rename graph.tsx => Graph.tsx
2023-08-16 13:21:04 +01:00
Robert
fed9870a0c
Only show the details view when a data extensions editor is open
2023-08-16 13:06:14 +01:00
Robert
51844bb541
Merge pull request #2705 from github/robertbrignull/details-multiple-editors
...
Allow the details view to handle multiple open data extensions editors
2023-08-16 12:47:44 +01:00
Robert
0acd06f773
Rename alert-table.tsx => AlertTable.tsx
2023-08-16 10:35:59 +01:00
Robert
acb9669e9f
Merge pull request #2714 from github/robertbrignull/EmptyQueryResultsMessage
...
Move EmptyQueryResultsMessage out of results-table-utils
2023-08-16 10:05:58 +01:00
Charis Kyriakou
2a71183695
Start with collapsed items in data extensions editor ( #2713 )
2023-08-15 17:06:12 +01:00
Robert
1c3d3428e4
Merge pull request #2712 from github/robertbrignull/AlertTableHeader-filename
...
Rename alert-table-header.tsx => AlertTableHeader.tsx
2023-08-15 16:58:55 +01:00
Robert
c77bb2b9c2
Rename result-table-utils.tsx => result-table-utils.ts
2023-08-15 16:44:29 +01:00
Robert
d3d96a1dbe
Make EmptyQueryResultsMessage into a component
2023-08-15 16:42:10 +01:00
Robert
7c62176f59
Rename alert-table-header.tsx => AlertTableHeader.tsx
2023-08-15 16:31:55 +01:00
Robert
87754a9ec9
Move mostRecentlyActiveView variable to DataExtensionsEditorModule
2023-08-15 15:36:14 +01:00
Robert
ee78df683a
Add onPanelWasDisposed
2023-08-15 15:16:37 +01:00
Robert
3764a7e567
Split isTheMostRecentlyActivePanel into two methods
2023-08-15 15:14:15 +01:00
Robert
552baa5570
Merge branch 'main' into robertbrignull/details-multiple-editors
2023-08-15 14:57:45 +01:00
Charis Kyriakou
57262446fb
Merge pull request #2711 from github/version/bump-to-v1.8.11
...
Bump version to v1.8.11
2023-08-15 14:07:35 +01:00
Robert
5b128711e5
Merge pull request #2708 from github/robertbrignull/details-updates
...
Only update the details view when data has changed
2023-08-15 14:01:35 +01:00
Robert
6787deed04
Use not.toHaveBeenCalled()
2023-08-15 11:16:44 +01:00
Robert
381e8c0849
Fix test name
2023-08-15 11:15:32 +01:00
github-actions[bot]
74c6f3ce54
Bump version to v1.8.11
2023-08-15 10:08:02 +00:00
Charis Kyriakou
0c2773481a
v1.8.10 ( #2710 )
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2023-08-15 10:41:34 +01:00
Robert
96660ebbf9
Merge pull request #2702 from github/robertbrignull/ResultTables
...
Convert ResultTables to a function component
2023-08-15 09:45:56 +01:00
Dave Bartolomeo
e308c2b8c9
Merge pull request #2685 from github/shati-patel/get-current-query
...
Fix `getCurrentQuery` to look at active tabs instead of active text editors
2023-08-14 12:35:56 -04:00
Robert
35622a94f2
Move ProblemsViewCheckbox to a separate component
2023-08-14 17:08:13 +01:00
Robert
2ff0ee58fc
Move ResultCount to a separate component
2023-08-14 16:54:33 +01:00
Alexander Eyers-Taylor
a965ea4044
Graph: Set fill color for all graph text ( #2707 )
...
Grapviz no longer sets it to the default so we don't have anything to
override
2023-08-14 15:53:25 +00:00
Robert
194c8d5cfc
Make hook imports consistent
2023-08-14 16:49:43 +01:00
Robert
4e70c8999f
Only update the details view when data has changed
2023-08-14 15:55:01 +01:00
Shati Patel
2569f631a2
Add code lens for "Open referenced file" ( #2704 )
2023-08-14 15:26:43 +01:00
Robert
6005e3ab70
Update details view on view state changes, and remember the most recently active panel
2023-08-14 15:02:40 +01:00
Robert
7c93c7046e
Store the latest set of external API usages on the view class
2023-08-14 14:08:10 +01:00
Koen Vlaswinkel
a46209b22d
Merge pull request #2701 from github/koesie10/fix-duplicate-test-running
...
Fix running tests twice when test paths are passed
2023-08-14 13:28:54 +02:00
Robert
408d38dc88
Merge pull request #2703 from github/robertbrignull/InProgressMethods_immutable
...
Make InProgressMethods immutable so it's safer to use as react state
2023-08-14 12:26:24 +01:00
Robert
55aeb3ce86
Update extensions/ql-vscode/src/data-extensions-editor/shared/in-progress-methods.ts
...
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com >
2023-08-14 11:27:38 +01:00
Robert
37c461a89b
Make InProgressMethods immutable so it's safer to use as react state
2023-08-14 10:46:24 +01:00
Robert
1595f7c879
Merge pull request #2700 from github/robertbrignull/data-rows
...
Fix spacing of columns
2023-08-14 10:32:20 +01:00
Robert
a893bf7a77
Merge pull request #2688 from github/robertbrignull/data-view-jump
...
Implementing expanding/selecting item in details view when clicking "view"
2023-08-14 10:15:17 +01:00
Robert
81579351cd
Convert resultSet to use useMemo
2023-08-14 09:47:07 +01:00
Koen Vlaswinkel
1b0bcb3d2f
Fix running tests twice when test paths are passed
...
When running tests using `--runTestsByPath <some-path>`, the tests were
being run twice because jest-runner-vscode
[resolves test paths](0c98dc12ad/packages/jest-runner-vscode/src/runner.ts (L57-L66) ),
while the original arguments were also still passed to Jest. So, the
arguments Jest would receive would look something like
`test/vscode-tests/no-workspace/databases/local-databases/locations.test.ts /Users/koesie10/github/vscode-codeql/extensions/ql-vscode/test/vscode-tests/no-workspace/databases/local-databases/locations.test.ts`
which would cause Jest to run the tests twice. This fixes this by
resolving the paths to their absolute paths, and then removing any
duplicates.
2023-08-14 10:22:24 +02:00
Robert
8713a5403f
Convert resultSets to use useMemo
2023-08-11 17:32:31 +01:00
Robert
943a61b6a9
Convert getOffset to just a number
2023-08-11 17:31:44 +01:00
Robert
3652e52312
Convert alertTableExtras to use useMemo
2023-08-11 17:30:14 +01:00
Robert
94a8536f28
Move condition check into alertTableExtras
2023-08-11 17:27:02 +01:00
Robert
4e0ab5b46e
Convert handleCheckboxChanged to use useCallback
2023-08-11 17:24:42 +01:00
Robert
f761083342
Move handleCheckboxChanged out of alertTableExtras
2023-08-11 17:24:03 +01:00
Robert
57241c906e
Convert onTableSelectionChange to use useCallback
2023-08-11 17:23:06 +01:00
Robert
ee20a28fdc
Add dependencies to useEffect hooks
2023-08-11 17:22:43 +01:00
Robert
d173ff3c48
Convert vscodeMessageHandler to use useCallback
2023-08-11 17:22:21 +01:00
Robert
da8f959c42
Convert handleMessage to use useCallback
2023-08-11 17:21:24 +01:00
Robert
3d9f34e658
Naiely convert to function component
2023-08-11 17:17:50 +01:00
Robert
c124192879
Delete sendResultsPageChangedTelemetry as it is unused
2023-08-11 17:08:25 +01:00
Robert
2cb6a95ffd
Move handleMessage and componentDidMount to be before render method
2023-08-11 16:48:50 +01:00
Robert
c0568a837c
Move vscodeMessageHandler to before it is used
2023-08-11 16:46:45 +01:00
Robert
1f20836d53
Fix spacing of columns
2023-08-11 16:16:07 +01:00
Robert
5bf56baab8
Merge branch 'main' into robertbrignull/data-view-jump
2023-08-11 15:56:31 +01:00
Robert
dd0534b353
Merge pull request #2666 from github/robertbrignull/ResultTables-Header
...
Move ResultTablesHeader to its own component
2023-08-11 15:45:41 +01:00
Robert
dd89f0d337
Merge branch 'main' into robertbrignull/ResultTables-Header
2023-08-11 14:48:07 +01:00
Shati Patel
616bdb9021
Merge branch 'main' into shati-patel/get-current-query
2023-08-11 13:51:42 +01:00
github-actions[bot]
3b7f7e5528
Bump CLI version from v2.14.1 to v2.14.2 for integration tests ( #2699 )
...
Co-authored-by: github-actions[bot] <github-actions@github.com >
2023-08-11 12:26:41 +00:00
Charis Kyriakou
11a9668e44
Merge pull request #2698 from github/charisk/remove-automodel-v1
...
Remove automodel v1 code
2023-08-11 13:22:16 +01:00
Robert
1e0a7555f9
Merge branch 'main' into robertbrignull/data-view-jump
2023-08-11 12:28:54 +01:00
Robert
a52e067636
Merge branch 'main' into robertbrignull/ResultTables-Header
2023-08-11 12:26:21 +01:00
Charis Kyriakou
feb4bb61fe
Drop v2 from automodel code
2023-08-11 11:07:25 +00:00
Charis Kyriakou
2a5b6ea95b
Remove automodel v1
2023-08-11 11:07:19 +00:00
Nora
217114777f
Merge pull request #2683 from github/nora/model-details-view-styling
...
Add icons and main badge to Model Details View
2023-08-11 11:52:15 +02:00
Koen Vlaswinkel
2cac3181a8
Merge pull request #2697 from github/koesie10/downgrade-octokit
...
Revert "Bump @octokit/plugin-retry from 4.1.6 to 6.0.0"
2023-08-11 10:41:10 +02:00
Koen Vlaswinkel
9ebf99a572
Merge pull request #2693 from github/dependabot/npm_and_yarn/extensions/ql-vscode/patch-package-8.0.0
...
Bump patch-package from 7.0.0 to 8.0.0 in /extensions/ql-vscode
2023-08-11 10:35:42 +02:00
Koen Vlaswinkel
3059e78ca4
Merge pull request #2694 from github/dependabot/npm_and_yarn/extensions/ql-vscode/cosmiconfig-8.2.0
...
Bump cosmiconfig from 7.1.0 to 8.2.0 in /extensions/ql-vscode
2023-08-11 10:32:22 +02:00
Koen Vlaswinkel
7d9d1077fd
Revert "Bump @octokit/plugin-retry from 4.1.6 to 6.0.0 in /extensions/ql-vscode ( #2602 )"
...
This reverts commit e938a6a9cb .
2023-08-11 10:15:01 +02:00
Anders Starcke Henriksen
b3e81ffa53
Merge pull request #2691 from github/starcke/more-kinds
...
Add more sink and source kinds.
2023-08-11 09:45:42 +02:00
Koen Vlaswinkel
0ef688792b
Merge pull request #2692 from github/dependabot/npm_and_yarn/extensions/ql-vscode/eslint-config-prettier-9.0.0
...
Bump eslint-config-prettier from 8.5.0 to 9.0.0 in /extensions/ql-vscode
2023-08-10 17:19:56 +02:00
Koen Vlaswinkel
fa66b2757a
Merge pull request #2695 from github/dependabot/npm_and_yarn/extensions/ql-vscode/ts-unused-exports-10.0.0
...
Bump ts-unused-exports from 9.0.5 to 10.0.0 in /extensions/ql-vscode
2023-08-10 17:03:09 +02:00
Robert
9069ba2d62
Use sourceLocationPrefix to get relative path inside database
2023-08-10 15:06:41 +01:00
dependabot[bot]
5e1a9a330b
Bump ts-unused-exports from 9.0.5 to 10.0.0 in /extensions/ql-vscode
...
Bumps [ts-unused-exports](https://github.com/pzavolinsky/ts-unused-exports ) from 9.0.5 to 10.0.0.
- [Changelog](https://github.com/pzavolinsky/ts-unused-exports/blob/master/CHANGELOG.md )
- [Commits](https://github.com/pzavolinsky/ts-unused-exports/commits )
---
updated-dependencies:
- dependency-name: ts-unused-exports
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-10 13:48:45 +00:00
dependabot[bot]
49df14eeb8
Bump cosmiconfig from 7.1.0 to 8.2.0 in /extensions/ql-vscode
...
Bumps [cosmiconfig](https://github.com/cosmiconfig/cosmiconfig ) from 7.1.0 to 8.2.0.
- [Changelog](https://github.com/cosmiconfig/cosmiconfig/blob/main/CHANGELOG.md )
- [Commits](https://github.com/cosmiconfig/cosmiconfig/compare/v7.1.0...v8.2.0 )
---
updated-dependencies:
- dependency-name: cosmiconfig
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-10 13:48:17 +00:00
dependabot[bot]
0c0a4fe78d
Bump patch-package from 7.0.0 to 8.0.0 in /extensions/ql-vscode
...
Bumps [patch-package](https://github.com/ds300/patch-package ) from 7.0.0 to 8.0.0.
- [Release notes](https://github.com/ds300/patch-package/releases )
- [Changelog](https://github.com/ds300/patch-package/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ds300/patch-package/compare/v7.0.0...v8.0.0 )
---
updated-dependencies:
- dependency-name: patch-package
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-10 13:47:43 +00:00
dependabot[bot]
50b8ae5713
Bump eslint-config-prettier from 8.5.0 to 9.0.0 in /extensions/ql-vscode
...
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier ) from 8.5.0 to 9.0.0.
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/eslint-config-prettier/compare/v8.5.0...v9.0.0 )
---
updated-dependencies:
- dependency-name: eslint-config-prettier
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-10 13:47:08 +00:00
Nora
ebc5ef2d90
Adjust message
2023-08-10 12:36:28 +00:00
Anders Starcke Henriksen
c676ffdc13
Add more sink and source kinds.
2023-08-10 14:31:06 +02:00
Charis Kyriakou
b8ba32f028
Minor auto-model polish ( #2689 )
2023-08-10 13:03:02 +01:00
Charis Kyriakou
52a8704786
Improve auto-modeling in-progress state handling ( #2687 )
2023-08-10 11:58:49 +01:00
Robert
23ddc83c52
Inline methods that are small and only used from one place
2023-08-10 11:47:41 +01:00
Robert
54ec146c8e
Jump to usage as well as revealing in details view
2023-08-10 11:43:05 +01:00
Robert
b04f316730
Call revealItemInDetailsPanel when clicking view
2023-08-10 11:05:17 +01:00
Robert
2b58edaa84
Implement getParent by searching all usages
2023-08-10 11:05:17 +01:00
Robert
6aea8fee3a
Covert to canonical usage object before calling reveal
2023-08-10 11:05:17 +01:00
Robert
e37a833c9a
Add revealItem method and pass through to DataExtensionsEditorView
2023-08-10 11:05:17 +01:00
Robert
805bb74a8a
Include full usage in jumpToUsage message
2023-08-10 11:05:17 +01:00
Charis Kyriakou
209822e093
Add auto-model mock API scenario ( #2684 )
2023-08-10 09:55:17 +00:00
Charis Kyriakou
5d2e20516b
Rename 'dependency' to 'package' in auto-modeling code ( #2686 )
2023-08-10 09:06:33 +00:00
Nora
c905814393
Show line numbers and file path
2023-08-10 08:10:38 +00:00
Charis Kyriakou
b1dc862392
Merge pull request #2682 from github/charisk/batch-automodeling
...
Batch automodeling
2023-08-10 08:58:23 +01:00
shati-patel
c5febb4b48
Fix getCurrentQuery to look at active tabs instead of active text editors
2023-08-09 17:07:33 +01:00
Nora
df880496cc
Add icons and main badge
2023-08-09 16:41:45 +02:00
Charis Kyriakou
4b0f59983a
Add ability to stop automodeling
2023-08-09 12:25:14 +00:00
Charis Kyriakou
4f7126296e
Break up automodeling into batches
2023-08-09 12:24:44 +00:00
Robert
bd6a7b263f
Merge pull request #2679 from github/robertbrignull/data-details-jump
...
Implementing jumping to location when clicking on a usage in the details panel
2023-08-09 13:04:08 +01:00
Charis Kyriakou
6791ddb445
Pass dependency name around when automodeling ( #2681 )
2023-08-09 12:39:05 +01:00
Charis Kyriakou
6dc0b14be7
Merge pull request #2680 from github/charisk/move-automodeling
...
Move automodeling logic out of view
2023-08-09 12:00:06 +01:00
Robert
1139790620
Rename command from codeQLDataExtensions => codeQLDataExtensionsEditor
2023-08-09 11:57:19 +01:00
Charis Kyriakou
0cc8e68155
Extract modeling of specific set of candidates into its own function
2023-08-08 15:56:51 +00:00
Robert
f52a512794
Merge pull request #2672 from github/robertbrignull/sarif-processing-no-location
...
Handle when an alert message contains links to files outside of the repository source
2023-08-08 16:56:03 +01:00
Charis Kyriakou
75882710ad
Move automodeling logic to AutoModeler class
2023-08-08 15:52:03 +00:00
Robert
7443b35ebc
Jump to location when clicking on usage
2023-08-08 16:34:15 +01:00
Robert
16d5f0f12b
Add DatabaseItem to model details panel state
2023-08-08 16:34:10 +01:00
Robert
946607098a
Add command to jump to usage location
2023-08-08 16:26:33 +01:00
Robert
f4d6990c1f
Move duplicated error handling into showResolvableLocation
2023-08-08 16:26:27 +01:00
Robert
daf389a5ed
Merge pull request #2678 from github/robert-nora/model-details-data
...
Populate details panel with external API usages
2023-08-08 14:20:00 +01:00
Robert
29916be143
Send externalApiUsages data to details view whenever new data is calculated
2023-08-08 10:52:59 +01:00
Robert
aa227357e9
Add blank data provider for codeQLModelDetails view
2023-08-07 17:19:13 +01:00
Nora
0aae7392f0
Merge pull request #2677 from github/robert-nora/set-up-model-details-view
...
Set up model details view
2023-08-07 18:03:45 +02:00
Nora
81294ecf3a
Focus on panel when clicking view button
2023-08-07 14:38:34 +00:00
Nora
839e4d6246
Set up empty panel tab
2023-08-07 14:24:35 +00:00
Nora
ae6dc879ef
Create new feature flag
2023-08-07 14:11:42 +00:00
Charis Kyriakou
55557df53f
Add in-progress UI state for modeling methods ( #2675 )
2023-08-07 11:58:41 +00:00
Charis Kyriakou
f1204ce8f4
Move automodel version split further up ( #2676 )
2023-08-07 11:54:47 +00:00
Anders Starcke Henriksen
234760efd3
Merge pull request #2670 from github/starcke/apply-slice-filter
...
Use filtering queries to do batched AI querying
2023-08-07 11:37:40 +02:00
Robert
61f8f5fb88
Merge pull request #2673 from github/robertbrignull/unused_npm_dependencies
...
Remove unused NPM dependencies
2023-08-07 10:35:00 +01:00
Charis Kyriakou
4109da6a50
Add support for automodel requests in the mock API server ( #2674 )
2023-08-07 09:58:39 +01:00
Anders Starcke Henriksen
9bd2286660
Update extensions/ql-vscode/src/data-extensions-editor/auto-model-codeml-queries.ts
...
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com >
2023-08-07 10:21:12 +02:00
Robert
c068769af7
Uninstall ts-protoc-gen dependency
2023-08-04 16:19:33 +01:00
Robert
30fd9c28ac
Uninstall @types/stream-chain dependency
2023-08-04 15:22:26 +01:00
Robert
3238c0eb0e
Uninstall @types/jszip dependency
2023-08-04 15:20:14 +01:00
Robert
997e12c358
Uninstall @types/gulp-sourcemaps dependency
2023-08-04 15:18:52 +01:00
Robert
79f29a812e
Uninstall @types/google-protobuf dependency
2023-08-04 15:16:54 +01:00
Robert
91cfeb9acb
Uninstall stream-chain dependency
2023-08-04 15:13:35 +01:00
Robert
27d5169ce7
Uninstall stream dependency
2023-08-04 15:10:03 +01:00
Robert
ed91dafc25
Uninstall minimist dependency
2023-08-04 15:01:26 +01:00
Robert
461bf2d645
Uninstall minimatch dependency
2023-08-04 14:59:37 +01:00
Anders Starcke Henriksen
d4137b2c43
Address comments.
2023-08-04 15:59:25 +02:00
Robert
6a12dc23bb
Assert alert message in test
2023-08-04 14:45:41 +01:00
Anders Starcke Henriksen
12abf81623
Apply suggestions from code review
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2023-08-04 15:35:12 +02:00
Robert
62e45a2c1c
Handle when a related location has no region
2023-08-04 12:26:32 +01:00
Robert
fef55e3ec5
Add failing test when a related location is undefined
2023-08-04 12:26:03 +01:00
Anders Starcke Henriksen
f6c492dca4
Use filtering queries to do batched AI quering.
2023-08-04 13:09:59 +02:00
Robert
69c92b4434
Check key / keyCode in onKeyDownHandler
2023-08-04 11:29:29 +01:00
dependabot[bot]
7530920a0b
Bump @typescript-eslint/eslint-plugin from 5.41.0 to 6.2.1 in /extensions/ql-vscode ( #2668 )
2023-08-04 10:10:16 +00:00
dependabot[bot]
e938a6a9cb
Bump @octokit/plugin-retry from 4.1.6 to 6.0.0 in /extensions/ql-vscode ( #2602 )
...
Bumps [@octokit/plugin-retry](https://github.com/octokit/plugin-retry.js ) from 4.1.6 to 6.0.0.
- [Release notes](https://github.com/octokit/plugin-retry.js/releases )
- [Commits](https://github.com/octokit/plugin-retry.js/compare/v4.1.6...v6.0.0 )
---
updated-dependencies:
- dependency-name: "@octokit/plugin-retry"
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-04 10:46:08 +01:00
Robert
de8d0df818
Merge pull request #2671 from github/robertbrignull/sarif-parser-unit-test
...
Move sarif-parser.test.ts from no-workspace to unit-tests
2023-08-04 10:16:32 +01:00
Robert
f7b07a0892
Move test sarif data to a more shared location + fix links
2023-08-04 09:56:58 +01:00
dependabot[bot]
2b9aad34f8
Bump styled-components from 5.3.9 to 6.0.2 in /extensions/ql-vscode ( #2585 )
2023-08-04 09:45:17 +01:00
dependabot[bot]
a3c0896d37
Bump @typescript-eslint/parser in /extensions/ql-vscode ( #2669 )
2023-08-03 16:58:37 +00:00
Robert
3e6466d717
Move sarif-parser.test.ts from no-workspace to unit-tests
2023-08-03 17:28:33 +01:00
Robert
3960ece3e4
Merge pull request #2667 from github/robertbrignull/scrubber_tests
...
Try to fix flakes in query history scrubber tests
2023-08-03 17:05:27 +01:00
Andrew Eisenberg
87bbf2933b
Merge pull request #2660 from github/aeisenberg/qhelp-preview
...
Ensure the qhelp preview is refreshed after editing
2023-08-03 08:38:03 -07:00
Robert
8952874bb6
Merge branch 'main' into robertbrignull/ResultTables-Header
2023-08-03 16:14:24 +01:00
Robert
36f92da9ac
Merge pull request #2664 from github/robertbrignull/ResultTables-naming
...
Make sure ResultTable and ResultTables are in correctly named files
2023-08-03 15:48:57 +01:00
Robert
23a8927df1
Merge branch 'main' into robertbrignull/ResultTables-naming
2023-08-03 15:03:57 +01:00
Nora
4993e7b6a5
Merge pull request #2663 from github/version/bump-to-v1.8.10
...
Bump version to v1.8.10
2023-08-03 16:00:17 +02:00
Robert
2ffbb9c14c
Perform dirSync inside beforeEach block
2023-08-03 14:19:12 +01:00
Robert
8bce7b531c
Use a jest.fn() to track calls to the scrubber, instead of a local variable counter
2023-08-03 14:17:23 +01:00
Robert
28a0075fe4
Move creation of the mock context to a function
2023-08-03 14:16:43 +01:00
Robert
428014ce35
Move timestamp constants to be outside of describe block
2023-08-03 14:01:45 +01:00
Robert
6b21f3f29d
Merge pull request #2665 from github/robertbrignull/ResultTables-untoggleProblemsView
...
Delete untoggleProblemsView as it is unused
2023-08-03 13:55:56 +01:00
Robert
892f052227
Move ResultTablesHeader to its own component
2023-08-03 12:36:05 +01:00
Robert
fed2a22062
Delete untoggleProblemsView as it is unused
...
As far as I can tell it's been unused as far as back as
https://github.com/github/vscode-codeql/pull/602 when it was introduced.
It seems just to be an error in that PR.
2023-08-03 12:14:50 +01:00
Robert
aa1edfc231
Move ResultTable to its own file
2023-08-03 11:36:52 +01:00
Robert
ab442c4dde
Rename result-tables.tsx => ResultTables.tsx
2023-08-03 11:36:52 +01:00
github-actions[bot]
69490b1948
Bump version to v1.8.10
2023-08-03 09:53:59 +00:00
Nora
9ed6b011a5
Merge pull request #2662 from github/v1.8.9
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
Release prep for v1.8.9
2023-08-03 10:52:15 +02:00
Nora
912254fd3c
Update extensions/ql-vscode/CHANGELOG.md
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2023-08-03 10:31:41 +02:00
Nora
7eab911cc5
v1.8.9
2023-08-03 08:17:20 +00:00
Andrew Eisenberg
d7d1351957
Remove unused import
2023-08-02 12:31:53 -07:00
Nora
80ae9a4b36
Merge pull request #2658 from github/nora-koen/data-extensions-editor-without-ql-submodule
...
Remove submodules dependency from data extension editor
2023-08-02 17:30:46 +02:00
Nora
868fae093d
Reorder db language check
2023-08-02 14:25:39 +00:00
Andrew Eisenberg
2ce5ff7085
Update extensions/ql-vscode/CHANGELOG.md
...
Co-authored-by: Robert <robertbrignull@github.com >
2023-08-01 12:54:16 -07:00
Andrew Eisenberg
1289ab509c
Merge pull request #2659 from github/aeisenberg/download-pack-in-tests2
...
Install `java-all` and transitive dependencies
2023-08-01 07:43:40 -07:00
Nora
5f489212d4
Add test for setup
2023-08-01 12:39:30 +00:00
Nora
fea45ea04d
wrap all describe blocks in external api usage test
2023-08-01 12:39:30 +00:00
Nora
a39e55590a
Move query setup to query file
2023-08-01 12:39:30 +00:00
Nora
6e4641f2c1
Clean up runQyery test
2023-08-01 12:39:30 +00:00
Nora
553e5cb4a1
Remove automodel qll file
2023-08-01 12:39:29 +00:00
Nora
4c0f68f193
Adjust picker test
2023-08-01 12:39:29 +00:00
Nora
1ee9cdaadd
Add test for error log
2023-08-01 12:39:29 +00:00
Nora
098437b463
Cleanup
2023-08-01 12:39:29 +00:00
Nora
558a70e3c8
Adjust external api query test
2023-08-01 12:39:29 +00:00
Nora
7c10447bb5
Add .github folder manually
2023-08-01 12:39:29 +00:00
Nora
9fd6cb8c1f
Cleanup and install pack dependencies
2023-08-01 12:39:29 +00:00
Koen Vlaswinkel
f4da522953
wip: data extensions editor without ql submodule
2023-08-01 12:39:29 +00:00
Robert
6dfe1736f8
Merge pull request #2657 from github/robertbrignull/clean-test-dir
...
Add `npm run clean-test-dir`
2023-08-01 09:19:42 +01:00
Andrew Eisenberg
f067c6540b
Ensure the qhelp preview is refreshed after editing
...
This commit fixes a bug in the extension where the qhelp preview was not
being refreshed after the first time the preview was rendered. The
reason is that vscode will not refresh the markdown preview unless the
original file with the markdown in it is already open in the editor.
This fix will briefly open the raw markdown, refresh the preview and
close the raw markdown.
2023-07-31 16:21:09 -07:00
Andrew Eisenberg
b46e0ab175
Install java-all and transitive dependencies
...
need to install all transitive dependencies of `java-all` as well. This
will do it.
2023-07-31 11:14:59 -07:00
Andrew Eisenberg
34fa629054
Merge pull request #2655 from github/aeisenberg/download-pack-in-tests
...
Download `codeql/java-all` in tests
2023-07-31 10:02:14 -07:00
Robert
5107086a93
Switch to using find
2023-07-31 11:09:31 +01:00
Robert
58c5c0e5f5
Add npm run clean-test-dir
2023-07-31 11:09:31 +01:00
Charis Kyriakou
5427b5718f
Only show automodel button for Java ( #2656 )
2023-07-31 09:43:07 +00:00
Andrew Eisenberg
0cc399507f
Download codeql/java-all in tests
...
An upcoming change in the CLI will require that the extensible
predicates that are targeted by a data extension needs to be available
in order for the `resolve extensions` command to succeed.
There are a handful of tests that are failing with this new CLI. This
change will update the tests so that the `codeql/java-all` pack is
available in the tests and ensures they pass.
2023-07-28 14:49:55 -07:00
Robert
bb9299e0e2
Merge pull request #2646 from github/robertbrignull/fix_alert_461
...
Split codeQL.copyVariantAnalysisRepoList into two commands
2023-07-28 10:56:35 +01:00
Robert
e8afa54584
Fix test by mocking the correct function
2023-07-28 10:26:52 +01:00
Robert
d94443e025
Merge pull request #2652 from github/robertbrignull/data_narrow
...
Make the data extensions editor look a little bit better at small screen sizes
2023-07-28 10:15:28 +01:00
Robert
0e5cb1a3e8
Merge pull request #2653 from github/robertbrignull/dependencies_versions
...
Change all dependencies to use ^ instead of ~
2023-07-28 10:09:57 +01:00
Robert
59958a5b32
Log a ui-interaction telemetry event when copying repository lists
2023-07-28 10:09:12 +01:00
Robert
3d9b2da514
Remove codeQL.copyVariantAnalysisRepoListView command and instead call copyRepoListToClipboard directly
2023-07-28 10:09:11 +01:00
Robert
3b8cea8df4
Remove codeQL.copyVariantAnalysisRepoListQueryHistory command and instead call copyRepoListToClipboard directly
2023-07-28 10:00:38 +01:00
Robert
6adf683c87
Merge branch 'main' into robertbrignull/dependencies_versions
2023-07-28 09:51:43 +01:00
Robert
37f1c62ee6
Merge branch 'main' into robertbrignull/data_narrow
2023-07-28 09:51:27 +01:00
Chuan-kai Lin
c1107d7423
Merge pull request #2649 from github/cklin/remove-legacy-query-server-test
...
legacy-query.test.ts: skip if CLI supports new query server
2023-07-27 09:48:36 -07:00
Chuan-kai Lin
72fa1c5583
legacy-query.test.ts: skip if CLI supports new query server
2023-07-27 09:10:04 -07:00
github-actions[bot]
5f65498e0a
Bump CLI version from v2.14.0 to v2.14.1 for integration tests ( #2650 )
...
Co-authored-by: github-actions[bot] <github-actions@github.com >
2023-07-27 16:04:05 +00:00
Shati Patel
6e21706c15
Implement "Hide modeled APIs" checkbox and make it the default ( #2651 )
2023-07-27 15:49:41 +00:00
Robert
4dcca4e97c
Change all dependencies to use ^ instead of ~
2023-07-27 16:15:39 +01:00
Robert
84492d2fb9
Make sure the classifications don't wrap
2023-07-27 16:00:38 +01:00
Robert
a2c9ac792b
Move the method classification to the start of the row
2023-07-27 15:57:45 +01:00
Robert
18704558d3
Make the method name column 50%
2023-07-27 15:57:34 +01:00
Robert
ca16dca7ed
Merge pull request #2645 from github/robertbrignull/fix_alert_546
...
Don't alert for multiple usages of built-in VS Code commands
2023-07-27 15:20:39 +01:00
Robert
f05d5d9766
Split codeQL.copyVariantAnalysisRepoList into two commands
2023-07-27 12:22:19 +01:00
Robert
aacc243bae
Don't report multiply usages of builtin VS Code commands
2023-07-27 11:24:18 +01:00
Robert
396dc3e915
Merge pull request #2644 from github/robertbrignull/fix_alert_384
...
Fix alert by rewriting query history scrubbed to do fewer file operations
2023-07-27 11:22:10 +01:00
Robert
d3b2d0fce8
Fix indentation in query
2023-07-27 11:14:14 +01:00
Robert
4d4cd4c2d6
Use getErrorMessage
2023-07-27 10:32:19 +01:00
Shati Patel
72512da3b5
Data extensions editor: Allow users to pick an existing database from their workspace ( #2643 )
2023-07-27 10:09:12 +01:00
Koen Vlaswinkel
c2ed98eb85
Merge pull request #2633 from github/koesie10/automodel-v2
...
Add LLM functionality using auto-model V2
2023-07-27 10:02:55 +02:00
Koen Vlaswinkel
bebe130fb0
Do not use mocked URI in locations test
2023-07-27 09:40:37 +02:00
Koen Vlaswinkel
db065584fa
Merge remote-tracking branch 'origin/main' into koesie10/automodel-v2
2023-07-27 09:18:59 +02:00
Robert
844f25ed98
Rewrite query history scrubbed to do fewer file operations
2023-07-26 16:56:02 +01:00
Koen Vlaswinkel
546f668301
Move createMockUri to mocking helpers
2023-07-26 14:35:15 +02:00
Koen Vlaswinkel
a79753d0a5
Move all runAutoModelQuery arguments into the options object
2023-07-26 14:32:43 +02:00
Koen Vlaswinkel
32c44cdfe3
Rename Options to AutoModelQueriesOptions
2023-07-26 14:31:28 +02:00
Koen Vlaswinkel
de5dbea69f
Use promisify for gzip
2023-07-26 14:28:45 +02:00
Robert
3f896751f3
Merge pull request #2640 from github/robertbrignull/fix_alert_547
...
Fix alert by replacing regex with path.basename
2023-07-26 11:18:40 +01:00
Robert
41f5beb619
Merge pull request #2638 from github/robertbrignull/data_new_header
...
Add new data extensions header UI elements
2023-07-26 11:12:25 +01:00
Koen Vlaswinkel
5e5535653b
Merge pull request #2642 from github/koesie10/remove-path-browserify
...
Remove path-browserify
2023-07-26 12:09:47 +02:00
Robert
af50d90bcb
Merge branch 'main' into robertbrignull/data_new_header
2023-07-26 10:29:22 +01:00
Robert
c5a4c53a1a
Merge branch 'main' into robertbrignull/fix_alert_547
2023-07-26 10:26:24 +01:00
Koen Vlaswinkel
016940f2ce
Remove path-browserify
2023-07-26 11:23:39 +02:00
Robert
e877695a14
Merge pull request #2641 from github/robertbrignull/LockFileForStandardQueryResult
...
Unexport LockFileForStandardQueryResult
2023-07-26 10:22:53 +01:00
Robert
e2256e28ba
Unexport LockFileForStandardQueryResult
2023-07-26 10:06:55 +01:00
Robert
5c08083336
Merge pull request #2639 from github/robertbrignull/data_progress
...
Remove custom progress bar and use normal VS Code notification for progress
2023-07-26 10:05:05 +01:00
Robert
07b8732a31
Use custom implementation of basename instead of path-browserify version
2023-07-26 09:59:02 +01:00
Robert
3e49d05ef9
Text is uppercased automatically by styling
2023-07-26 09:51:51 +01:00
Koen Vlaswinkel
83cc9835e8
Merge pull request #2634 from github/koesie10/cleanup-query-resolver
...
Make query resolver more generic
2023-07-26 09:36:32 +02:00
Robert
c5af8bdcd7
Replace regex with path.basename
2023-07-25 17:29:34 +01:00
Robert
55b21c2add
Remove custom progress bar and use normal VS Code notification for progress
2023-07-25 15:33:39 +01:00
Charis Kyriakou
b87fe94a92
Remove most recent commit information and sorting ( #2637 )
2023-07-25 14:15:08 +00:00
Robert
493de4c190
Add new header UI elements
2023-07-25 15:01:27 +01:00
Shati Patel
8f99ed2478
Data extensions editor: Change "already modeled" message ( #2636 )
2023-07-25 13:40:54 +00:00
Shati Patel
cdcbdc60fb
Data extensions editor: Remove buttons that are no longer needed ( #2635 )
2023-07-25 14:12:16 +01:00
Robert
e1bbbd6e9c
Merge pull request #2631 from github/robertbrignull/deadcode_ci
...
Add check for deadcode for CI
2023-07-25 13:09:44 +01:00
Koen Vlaswinkel
84de8ad252
Add creation of auto-model request V2
2023-07-25 10:35:19 +02:00
Koen Vlaswinkel
57bcfbbe29
Extract creation of lock file to more generic function
2023-07-25 10:03:01 +02:00
Koen Vlaswinkel
32656c1cb8
Extract query resolving to more generic functions
2023-07-25 10:03:01 +02:00
Robert
5572cece83
Convert find-deadcode to a script
2023-07-24 18:00:30 +01:00
Robert
08675e6713
Rename to tsconfig.deadcode.json
2023-07-24 17:27:39 +01:00
Robert
abee109dbd
Merge branch 'main' into robertbrignull/deadcode_ci
2023-07-24 17:26:18 +01:00
Robert
ef27730e5e
Merge pull request #2632 from github/robertbrignull/deadcode_changes
...
Remove or fix dead code / unused exports
2023-07-24 16:32:13 +01:00
Robert
10c6708db5
Fix reference to tsconfig.json
2023-07-24 14:29:01 +01:00
Robert
a618aed415
Mark fileMock and styleMock as allowable exports
2023-07-24 14:28:41 +01:00
Robert
8e8e0faa9e
Unexport types that are unused outside of their source file
2023-07-24 14:22:23 +01:00
Robert
41ce5086e7
Mark the extension activation function as allowed to be exported but unused
2023-07-24 14:22:23 +01:00
Robert
a79b71cff6
Switch ALLOW_HTTP_SETTING for allowHttp()
2023-07-24 14:22:23 +01:00
Robert
f0318b0c84
Delete vsCodeGetConfiguration
2023-07-24 14:22:23 +01:00
Robert
814acfa74a
Add find-deadcode to CI linting workflow
2023-07-24 11:23:04 +01:00
Robert
d73276c136
Add find-deadcode npm script
2023-07-24 11:23:01 +01:00
Robert
44b58280e8
Merge pull request #2628 from github/robertbrignull/disposable
...
Merge definitions of Disposable where possible
2023-07-24 11:20:39 +01:00
Robert
49a05c412c
Delete pathRowClassName
2023-07-24 11:11:55 +01:00
Robert
f57bbc2b52
Delete decimalFormatter
2023-07-24 11:11:55 +01:00
Robert
e620120144
Delete getTestDirectory
2023-07-24 11:11:55 +01:00
Robert
6fbe95a334
Delete isRemoteSystemDefinedListDbItem
2023-07-24 11:11:55 +01:00
Robert
cb4dcc81ea
Delete remoteDbKinds and localDbKinds
2023-07-24 11:11:55 +01:00
Robert
3126c8d1a8
Delete PAGE_SIZE
2023-07-24 11:11:55 +01:00
Robert
0d7814c778
Delete InspectionResult
2023-07-24 11:11:55 +01:00
Robert
f70ea71885
Delete isVariantAnalysisLiveResultsEnabled
2023-07-24 11:11:55 +01:00
Robert
04df20a732
Install ts-unused-exports
2023-07-24 11:10:19 +01:00
Robert
c7b556e748
Merge pull request #2624 from github/robertbrignull/autoClosingPairs
...
Delete autoClosingPairs from LanguageConfiguration to appease proposed API
2023-07-24 11:04:52 +01:00
Charis Kyriakou
8314a5486d
Merge pull request #2627 from github/charisk/remove-deprecated-version-support
...
Remove conditionals and version constraints for unsupported CLI versions
2023-07-24 10:07:34 +01:00
Charis Kyriakou
e80ef7c1dc
Remove CLI_VERSION_WITH_PER_QUERY_EVAL_LOG constraint
2023-07-24 08:24:07 +00:00
Robert
f1a928994a
Merge all our DisposableObject definitions
2023-07-21 17:06:53 +01:00
Charis Kyriakou
0f594704d5
Remove CLI_VERSION_WITH_STRUCTURED_EVAL_LOG constraint
2023-07-21 15:37:56 +00:00
Charis Kyriakou
3064415068
Remove setting of evaluator log verbosity level
2023-07-21 15:33:07 +00:00
Charis Kyriakou
f03ef66596
Update handling of return value from packlist command
2023-07-21 15:31:57 +00:00
Robert
0617e3ec7f
Merge pull request #2626 from github/robertbrignull/data-make-selected
...
Instead of resetting the database after importing, pass through makeSelected = false
2023-07-21 16:20:37 +01:00
Shati Patel
dacaf4e394
Update title in Data extensions editor tab ( #2625 )
2023-07-21 14:44:41 +01:00
Robert
e6566b910a
Instead of resetting the database after importing, pass through makeSelected = false
2023-07-21 12:49:36 +01:00
Robert
778f839e8e
Merge pull request #2623 from github/robertbrignull/data-model-dependency
...
Implement "model dependency" button in application mode
2023-07-21 12:10:15 +01:00
Robert
52711c5cc1
Delete autoClosingPairs from LanguageConfiguration to appease proposed API
2023-07-21 11:31:55 +01:00
Robert
d8687b5985
Merge pull request #2621 from github/robertbrignull/data-saving
...
Load existing modeled methods before saving, to avoid overwriting data
2023-07-20 08:54:29 +01:00
Robert
19ad237427
Pull out common code for importing and resetting the current database
2023-07-19 16:29:13 +01:00
Robert
bb246144c2
Add comments to createDataExtensionYamlsForFrameworkMode too
2023-07-19 16:22:00 +01:00
Robert
fa01b33dfa
Implement modelDependency message
2023-07-19 16:14:44 +01:00
Robert
00780442dd
Send modelDependency message
2023-07-19 16:14:44 +01:00
Robert
5b170d02eb
Avoiding overwriting any existing modeled methods from the files
2023-07-19 11:44:12 +01:00
Robert
db4dc89e42
Split loadModeledMethods into loading all files individually and then merging them
2023-07-19 11:44:12 +01:00
Robert
b5b606d486
Make loadModeledMethodFiles return relative paths from the extension pack
2023-07-19 11:43:57 +01:00
Robert
f2c7c41117
Merge pull request #2406 from Marcono1234/location-url-column
...
Include column numbers in location URLs
2023-07-19 11:01:20 +01:00
Robert
152e194655
Merge branch 'main' into location-url-column
2023-07-19 09:58:46 +01:00
Robert
f12ba96389
Update CHANGELOG.md
2023-07-19 09:57:58 +01:00
Koen Vlaswinkel
add3296071
Merge pull request #2618 from github/dependabot/npm_and_yarn/extensions/ql-vscode/word-wrap-1.2.4
...
Bump word-wrap from 1.2.3 to 1.2.4 in /extensions/ql-vscode
2023-07-19 10:04:56 +02:00
Koen Vlaswinkel
a90b85c2a6
Merge pull request #2259 from github/koesie10/upgrade-storybook-7
...
Upgrade to Storybook 7
2023-07-19 09:51:13 +02:00
dependabot[bot]
3568d4a780
Bump word-wrap from 1.2.3 to 1.2.4 in /extensions/ql-vscode
...
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap ) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases )
- [Commits](https://github.com/jonschlinkert/word-wrap/compare/1.2.3...1.2.4 )
---
updated-dependencies:
- dependency-name: word-wrap
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-18 23:40:55 +00:00
Robert
d3a5a5e669
Merge pull request #2611 from github/robertbrignull/data-unsaved-checkbox
...
Show whether changes to a method are saved or not
2023-07-18 16:31:46 +01:00
Robert
fc77a52c46
Merge pull request #2614 from github/robertbrignull/Locations
...
Move components for rendering locations to a separate file
2023-07-18 15:31:15 +01:00
Robert
5617331598
Pass in methodIsUnsaved instead of modifiedSignatures
2023-07-18 15:26:34 +01:00
Robert
76a7a266ff
Rename jumpToLocationHandler => handleClick
2023-07-18 15:11:54 +01:00
Robert
b6c60b26cd
Rename handleClick => onClick
2023-07-18 15:11:22 +01:00
Robert
30d8303320
Pull out getModelingStatus method and avoid useMemo
2023-07-18 15:07:26 +01:00
Robert
5c12a4b205
Merge pull request #2605 from github/robertbrignull/data-modeled-methods-tests
...
Refactor the code for loading/saving modeled methods to disk, and add tests
2023-07-18 14:34:21 +01:00
Koen Vlaswinkel
b830781e48
Replace deprecated uses of ComponentMeta and ComponentStory
2023-07-18 15:29:11 +02:00
Koen Vlaswinkel
8329dedd7f
Upgrade to Storybook 7
2023-07-18 15:07:15 +02:00
Robert
70e04a1c99
Rename to MdelingStatusIndicator and move to a separate file
2023-07-18 10:59:08 +01:00
Marcono1234
768b95d3a9
Fix typo in CHANGELOG.md ( #2617 )
2023-07-17 19:39:38 +00:00
Shati Patel
8e4ee5df3d
Update release test plan ( #2616 )
2023-07-17 19:05:25 +01:00
Alexander Eyers-Taylor
baa2a7fed3
Add comma as a word boundary charecter. ( #2615 )
...
* Add comma as a word boundary charecter.
* Add changelog for missing trailing commas.
2023-07-17 16:12:36 +00:00
Robert
1f16294d7e
Avoid else blocks when we're returning early
2023-07-17 17:04:41 +01:00
Robert
679266c0b7
Remove unnecessarily forcing non-undefined
2023-07-17 17:02:59 +01:00
Robert
f1e96f7812
Use more standard name for callback
2023-07-17 17:02:16 +01:00
Robert
f8e6ccea23
Do event propogation cancelation before other work
2023-07-17 16:59:26 +01:00
Robert
8f46052459
Use optional call instead of explicit if-then
2023-07-17 16:58:52 +01:00
Robert
b210d83210
Use named Props interfaces instead of defining types inline
2023-07-17 16:58:08 +01:00
Robert
eaf8d68dd1
Remove all usages of NonClickableLocation outside of Location
2023-07-17 16:56:16 +01:00
Robert
c4ebee8e8d
Have each component in a separate file
2023-07-17 16:56:15 +01:00
Robert
2962306094
Specify that tmp dir is under homedir on windows
2023-07-17 15:48:20 +01:00
Robert
a4c0365a95
Move components for rendering locations to a separate file
2023-07-17 14:36:08 +01:00
Shati Patel
2abc4d542b
Merge pull request #2613 from github/version/bump-to-v1.8.9
...
Bump version to v1.8.9
2023-07-17 12:01:59 +01:00
github-actions[bot]
700b9bf348
Bump version to v1.8.9
2023-07-17 10:35:30 +00:00
Shati Patel
6be797d9d2
Merge pull request #2612 from github/v1.8.8
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
Release prep for v1.8.8
2023-07-17 11:10:54 +01:00
Robert
9924f87473
Add a test that calls loadModeledMethods
2023-07-17 11:07:24 +01:00
Robert
f19b600287
Fix semantic merge conflict in imports
2023-07-17 11:07:10 +01:00
Robert
14200a5011
Merge branch 'main' into robertbrignull/data-modeled-methods-tests
2023-07-17 11:06:40 +01:00
shati-patel
3fa7590187
v1.8.8
2023-07-17 10:17:54 +01:00
Marcono1234
fffb692ca8
Include column numbers in location URLs
2023-07-15 22:00:21 +02:00
Shati Patel
6cfc7d5ced
Remove support for CodeQL CLI versions older than 2.9.4 ( #2610 )
2023-07-14 16:13:46 +00:00
Philip Ginsbach
7ea6cd871b
Merge pull request #2609 from github/ginsbach/AdditionalAndDefaultKeywords
...
add `additional` and `default` keywords to the TextMate grammar
2023-07-14 16:23:50 +01:00
Shati Patel
5631d33b20
Change the data extension's webview icon ( #2608 )
2023-07-14 15:17:56 +00:00
Robert
de7d65fc8b
Replace checkbox with an icon that shows saved status
2023-07-14 16:16:30 +01:00
Robert
e73421dabb
Track changed signatures instead of unsaved models
2023-07-14 16:16:27 +01:00
Philip Ginsbach
e1e55d1d01
link to the PR from the changelog entry
2023-07-14 15:23:55 +01:00
Robert
421fe11664
Normalize paths before doing string comparisons
2023-07-14 15:12:12 +01:00
Philip Ginsbach
0b18492946
add changelog entry for 'additional' and 'default' keywords
2023-07-14 14:57:46 +01:00
Philip Ginsbach
f3ad6ec105
recompile the TextMate grammar
2023-07-14 14:57:46 +01:00
Philip Ginsbach
d97e4d1ba1
add 'additional' and 'default' annotation keywords to grammar
2023-07-14 14:47:07 +01:00
Koen Vlaswinkel
ccda490ab4
Merge pull request #2566 from github/koesie10/library-version
...
Add library versions to data extensions editor
2023-07-14 15:43:42 +02:00
Robert
1dcd048268
Move version check next to existing check
2023-07-14 14:20:58 +01:00
Robert
12511922ad
Remove version check in resolveExtensions method
2023-07-14 14:15:07 +01:00
Robert
2392d7c7b6
Merge pull request #2606 from github/robertbrignull/data-modeled-method-signature
...
Add signature and related fields to ModeledMethod
2023-07-14 14:11:40 +01:00
Koen Vlaswinkel
4158df197c
Improve library version matching regex
2023-07-14 14:13:23 +02:00
Robert
1782239c7c
Add in CodeQL CLI version check for the "resolve extensions" command
2023-07-14 11:38:07 +01:00
Robert
e2b211ad53
Merge branch 'main' into robertbrignull/data-modeled-method-signature
...
pick 2db42e3e Pull out createDataExtensionYamls into yaml.ts
pick 52f7cac0 Move saveModeledMethods to a separate file
pick ba27230e Move loadModeledMethods to a separate file
pick c512a11e Split out listModelFiles from loadModeledMethods
pick 752cf8ab Add some tests of listModelFiles
2023-07-14 11:05:14 +01:00
Koen Vlaswinkel
f91da95081
Add library versions to data extensions editor
2023-07-14 12:02:05 +02:00
Koen Vlaswinkel
10d9213dbe
Merge pull request #2563 from github/koesie10/classification
...
Add call classification and supported kind to data extensions editor
2023-07-14 12:01:58 +02:00
Robert
bb110152f2
Fix expected values in tests
2023-07-14 10:55:43 +01:00
Koen Vlaswinkel
bd6c302360
Add tooltip to classifications container
2023-07-14 11:38:45 +02:00
Koen Vlaswinkel
1272ddd696
Decrease text size of test and generated tags
2023-07-14 11:36:00 +02:00
Koen Vlaswinkel
ca7ba89a68
Move method classifications to separate component
2023-07-14 11:32:34 +02:00
Andrew Eisenberg
39465d9ad9
Merge pull request #2607 from github/github-action/bump-cli
2023-07-13 14:45:20 -07:00
github-actions[bot]
b419b8d308
Bump CLI version from v2.13.5 to v2.14.0 for integration tests
2023-07-13 18:34:27 +00:00
Robert
169221305f
Remove the ModeledMethodWithSignature type in favour of just ModeledMethod
2023-07-13 16:55:04 +01:00
Robert
97a331cf6a
Remove the ModeledExternalApiUsage type in favour of just ModeledMethod
2023-07-13 16:55:04 +01:00
Robert
16f98491e7
Remove the ExternalApiUsageByType in favour of just ModeledMethod
2023-07-13 16:55:04 +01:00
Robert
111dfff7fb
Add signature to ModeledMethod
2023-07-13 16:55:04 +01:00
Robert
f927ac9f1c
Split out MethodSignature from ExternalApiUsage
2023-07-13 16:55:04 +01:00
Koen Vlaswinkel
6a0cae58e0
Remove call type for unmodelable methods
...
This removes the call type as shown for an unmodelable method. We still
need to decide how to show this information, so this may be added back
in later.
2023-07-13 16:44:43 +02:00
Koen Vlaswinkel
1efc276c24
Show labels for methods only classified in test and generated
2023-07-13 16:36:37 +02:00
Koen Vlaswinkel
94015a0ac2
Show type for supported methods
2023-07-13 16:33:34 +02:00
Koen Vlaswinkel
048552093b
Add classification and type to types
2023-07-13 16:19:05 +02:00
Koen Vlaswinkel
0560f4fe76
Add classification and type to queries
2023-07-13 16:15:58 +02:00
Robert
752cf8ab16
Add some tests of listModelFiles
2023-07-13 10:29:52 +01:00
Robert
c512a11e7e
Split out listModelFiles from loadModeledMethods
2023-07-13 09:50:54 +01:00
Robert
ba27230e3c
Move loadModeledMethods to a separate file
2023-07-13 09:29:42 +01:00
Robert
52f7cac0a9
Move saveModeledMethods to a separate file
2023-07-13 09:20:00 +01:00
Robert
2db42e3eb0
Pull out createDataExtensionYamls into yaml.ts
2023-07-13 08:54:11 +01:00
Robert
31fdc794e5
Merge pull request #2600 from github/robertbrignull/data-supported
...
Show more clearly when a method is already modeled
2023-07-12 17:26:10 +01:00
Robert
e55800ae2d
Tweak message
2023-07-12 16:37:44 +01:00
Robert
0f39d41e50
fix typo
2023-07-12 16:37:18 +01:00
Robert
31118a514f
Merge pull request #2599 from github/nora/make-result-table-functional-component
...
Convert ResultTable to a functional component
2023-07-12 16:34:57 +01:00
Robert
fa5c24d837
Display an explanatory message on unmodelable methods
2023-07-12 14:56:15 +01:00
Robert
8ec08ef43f
Remove ugly jumpToUsage prop
2023-07-12 14:36:40 +01:00
Robert
7d59224407
Pull out ModelableMethodRow as a separate component
2023-07-12 14:36:40 +01:00
Robert
aba574e423
Pull out UmmodelableMethodRow to a separate component
2023-07-12 14:36:39 +01:00
Robert
799b96e7f6
Convert modelTypeOptions to be a const
2023-07-12 14:35:42 +01:00
Nora
60f33e573e
Convert ResultTable
2023-07-12 13:12:14 +00:00
Robert
5fa338e460
Return early if method cannot be modeled
2023-07-12 14:04:58 +01:00
Robert
8529c05396
Move boolean showXCell variables to be later and together
2023-07-12 14:02:39 +01:00
Robert
70b2e68ce7
Rename showModelTypeCell => methodCanBeModeled
2023-07-12 14:01:01 +01:00
Robert
8432f6cdfe
Move predicate variable closer to where it's used
2023-07-12 13:50:31 +01:00
Robert
39d53f469f
Merge pull request #2598 from github/robertbrignull/data-framework-model
...
Don't show model from source button in framework mode
2023-07-12 10:22:24 +01:00
Robert
c8ba8d6e1b
Merge branch 'main' into robertbrignull/data-framework-model
2023-07-12 10:05:06 +01:00
Robert
28c6ab36ce
Merge pull request #2597 from github/robertbrignull/data-view-state
...
Clear up how we pass around view state
2023-07-12 10:04:39 +01:00
Dave Bartolomeo
3e5985955d
Merge pull request #2538 from github/dbartol/save-before-start
...
Save dirty documents before evaluating queries
2023-07-11 15:55:03 -04:00
Dave Bartolomeo
a4cff531be
Remove more debugging code
2023-07-11 15:32:09 -04:00
Dave Bartolomeo
c18bb39f40
Remove more debugging code
2023-07-11 14:49:32 -04:00
Dave Bartolomeo
d93f2b67c8
Remove some debugging code
2023-07-11 14:42:57 -04:00
Robert
5b65e08fdf
Don't show model from source button in framework mode
2023-07-11 17:32:12 +01:00
Robert
79a567b478
Avoid passing in both viewState and mode at the same time
2023-07-11 16:53:12 +01:00
Robert
5e84b5f055
Enforce that viewState is defined and show a loading screen otherwise
2023-07-11 16:47:44 +01:00
Robert
aa4df082bf
Merge pull request #2594 from github/robertbrignull/data-unsaved-changes
...
Include in addModeledMethods whether the methods are unsaved or not
2023-07-11 16:26:44 +01:00
Robert
370872d005
Split addModeledMethods into that and loadModeledMethods
2023-07-11 15:23:30 +01:00
Robert
930103b3a8
Merge branch 'main' into robertbrignull/data-unsaved-changes
2023-07-11 15:11:24 +01:00
dependabot[bot]
6cf2f32705
Bump @octokit/plugin-retry from 3.0.9 to 4.1.6 in /extensions/ql-vscode ( #2518 )
...
Bumps [@octokit/plugin-retry](https://github.com/octokit/plugin-retry.js ) from 3.0.9 to 4.1.6.
- [Release notes](https://github.com/octokit/plugin-retry.js/releases )
- [Commits](https://github.com/octokit/plugin-retry.js/compare/v3.0.9...v4.1.6 )
---
updated-dependencies:
- dependency-name: "@octokit/plugin-retry"
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2023-07-11 13:02:04 +01:00
Robert
83a25006ec
Merge pull request #2586 from github/dependabot/npm_and_yarn/extensions/ql-vscode/prettier-3.0.0
...
Bump prettier from 2.7.1 to 3.0.0 in /extensions/ql-vscode
2023-07-11 11:11:21 +01:00
Robert
38d0d0ee7d
Merge pull request #2593 from github/dependabot/npm_and_yarn/extensions/ql-vscode/tough-cookie-4.1.3
...
Bump tough-cookie from 4.1.2 to 4.1.3 in /extensions/ql-vscode
2023-07-11 10:51:42 +01:00
Robert
296922c193
Merge pull request #2595 from github/robertbrignull/data-generate-from-source
...
Hook up generating from source in the new collapsible section
2023-07-11 09:54:07 +01:00
Robert
e5ae41328b
Run: npm run format
2023-07-11 09:51:28 +01:00
Robert
0fc3adf29a
Upgrade eslint-plugin-prettier to 5.0.0
2023-07-11 09:43:58 +01:00
dependabot[bot]
49954b5af0
Bump prettier from 2.7.1 to 3.0.0 in /extensions/ql-vscode
...
Bumps [prettier](https://github.com/prettier/prettier ) from 2.7.1 to 3.0.0.
- [Release notes](https://github.com/prettier/prettier/releases )
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/prettier/compare/2.7.1...3.0.0 )
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-10 15:19:00 +00:00
Nora
f493ba102b
Merge pull request #2596 from github/nora/update-eslint
...
Update eslint
2023-07-10 17:17:01 +02:00
Nora
43aa06a248
Update eslint
2023-07-10 13:49:55 +00:00
Robert
c8fd00b983
Hook up generating from source
2023-07-10 13:03:28 +01:00
Robert
c25619332c
Merge pull request #2569 from github/robertbrignull/convert-ResultsApp
...
Convert ResultsApp to a function component
2023-07-10 11:36:32 +01:00
Robert
f4b37c96e4
Merge branch 'main' into robertbrignull/convert-ResultsApp
2023-07-10 11:16:57 +01:00
Robert
f7239b073a
Include in addModeledMethods whether the methods are unsaved or not
2023-07-10 10:48:33 +01:00
Robert
bf0032d8de
Merge pull request #2592 from github/robertbrignull/data-supported-doc
...
Add documentation to ExternalApiUsage fields
2023-07-10 10:04:52 +01:00
dependabot[bot]
7eeec834ed
Bump tough-cookie from 4.1.2 to 4.1.3 in /extensions/ql-vscode
...
Bumps [tough-cookie](https://github.com/salesforce/tough-cookie ) from 4.1.2 to 4.1.3.
- [Release notes](https://github.com/salesforce/tough-cookie/releases )
- [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md )
- [Commits](https://github.com/salesforce/tough-cookie/compare/v4.1.2...v4.1.3 )
---
updated-dependencies:
- dependency-name: tough-cookie
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-09 22:27:45 +00:00
Robert
5eab1f8882
Add documentation to ExternalApiUsage fields
2023-07-07 17:10:06 +01:00
Robert
2525ae80b9
Merge pull request #2591 from github/robertbrignull/data-llm-section
...
Use AI to model just a single section
2023-07-07 16:16:42 +01:00
Robert
8423c73bdd
Merge pull request #2590 from github/robertbrignull/data-button-features
...
Only show LLM / framework mode when the view state says to show the button
2023-07-07 16:09:10 +01:00
Robert
37980612ac
Define separate no-op handler
2023-07-07 15:31:08 +01:00
Robert
c4912b1a65
Show framework mode button when available
2023-07-07 14:28:18 +01:00
Robert
ae3b6eccc3
Only show AI button when available
2023-07-07 14:28:01 +01:00
Robert
48ffca3103
Use AI to model just a single section
2023-07-07 12:37:10 +01:00
Robert
dae74e8772
Merge pull request #2588 from github/robertbrignull/data-save-single-model
...
Implement saving only one model at a time
2023-07-07 09:50:19 +01:00
Robert
e2dc0d6db5
Merge pull request #2589 from github/robertbrignull/data-title-buttons-background
...
Use better colours for title buttons
2023-07-07 09:26:03 +01:00
Robert
bf087d2114
Merge branch 'main' into robertbrignull/data-title-buttons-background
2023-07-07 08:41:58 +01:00
Shati Patel
8fab24f424
Merge pull request #2587 from github/shati-patel/unsaved-tag
...
Data extensions editor: Update styling of "unsaved" tag
2023-07-07 08:39:33 +01:00
Robert
7bda76347c
Changes buttons to avoid custom styling
2023-07-06 17:02:01 +01:00
dependabot[bot]
5db2b90212
Bump zip-a-folder from 1.1.3 to 2.0.0 in /extensions/ql-vscode ( #2517 )
...
Bumps [zip-a-folder](https://github.com/maugenst/zip-a-folder ) from 1.1.3 to 2.0.0.
- [Commits](https://github.com/maugenst/zip-a-folder/commits )
---
updated-dependencies:
- dependency-name: zip-a-folder
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2023-07-06 17:01:50 +01:00
shati-patel
2b13645b6f
Move "Save" button slightly to the left
2023-07-06 16:32:34 +01:00
shati-patel
4acc6f9e41
Use native "VS Code Tag" instead of custom span
2023-07-06 16:31:29 +01:00
Robert
e67f93c7bc
Implement saving only one model at a time
2023-07-06 16:28:29 +01:00
Robert
261f11e30e
Merge pull request #2582 from github/robertbrignull/data-table
...
Update data extensions modelling table to new designs
2023-07-06 16:27:06 +01:00
Robert
a07e829bf1
Make view link not wrap
2023-07-06 15:25:39 +01:00
Robert
afc9635d43
Use --vscode styles
2023-07-06 15:25:27 +01:00
Robert
7a54b00d29
Merge pull request #2583 from github/robertbrignull/data-unsaved-changes
...
Show when there are unsaved changes to a model
2023-07-06 12:08:01 +01:00
Robert
903e8c6688
Convert dropdown to a full component
2023-07-06 11:46:57 +01:00
Robert
d5c4f33d6e
Use a native select instead of VSCodeDropdown
2023-07-06 11:22:17 +01:00
Robert
7688542aa2
Merge branch 'main' into robertbrignull/data-unsaved-changes
2023-07-06 10:14:15 +01:00
Dave Bartolomeo
614a8d123c
Merge pull request #2584 from github/github-action/bump-cli
...
Bump CLI Version to v2.13.5 for integration tests
2023-07-05 14:33:43 -04:00
github-actions[bot]
e3ff6ace08
Bump CLI version from v2.13.4 to v2.13.5 for integration tests
2023-07-05 15:31:44 +00:00
Robert
fc866acae3
Show when there are unsaved changes to a model
2023-07-05 12:16:40 +01:00
Robert
f75b358e6c
Disable buttons instead of hiding them
2023-07-04 17:21:55 +01:00
Robert
e82bfb4153
Pull out booleans controlling visibility of each cell
2023-07-04 17:10:10 +01:00
Charis Kyriakou
7541b64ec8
Move some top level files ( #2580 )
...
* Move code-tour.ts to /code-tour
* Move qlpack-generator.ts to /local-queries
* Move query-status.ts to /query-history
* Move skeleton-query-wizard.ts to /local-queries
2023-07-04 16:08:26 +00:00
Robert
12e9de85c7
Merge pull request #2575 from github/robertbrignull/data-editor-story
...
Use more varied data for the number of usages
2023-07-04 17:01:20 +01:00
Shati Patel
5afdef1ec8
Merge pull request #2581 from github/shati-patel/data-ui-background
...
Data extensions UI: Change background colour of library container
2023-07-04 17:00:27 +01:00
Robert
870827085d
Remove colouring of the methods
2023-07-04 16:57:13 +01:00
Robert
e384f2447c
Convert data table to new column layout
2023-07-04 16:57:13 +01:00
Shati Patel
2c5b1da7b2
Merge pull request #2579 from github/shati-patel/bottom-bar
...
Data extensions UI: Add save button
2023-07-04 16:38:03 +01:00
shati-patel
c7295e66bc
Change background colour of library container
2023-07-04 16:35:15 +01:00
Shati Patel
5e49bd5491
Merge pull request #2578 from github/data-ext-divider
...
Data extensions UI: Add divider between title and status containers
2023-07-04 16:32:28 +01:00
shati-patel
33cb206fed
Add save button
2023-07-04 16:07:39 +01:00
shati-patel
882352fcbf
Add divider between title and status containers
2023-07-04 16:06:47 +01:00
Robert
f8ad72233a
Merge pull request #2574 from github/robertbrignull/data-title
...
Update data extensions modelling table title bar
2023-07-04 15:57:45 +01:00
Charis Kyriakou
31e94a877d
Add code search functionality to test plan ( #2577 )
2023-07-04 14:47:49 +01:00
Charis Kyriakou
545286b8d9
Add ability to record and replay mock code search requests ( #2576 )
2023-07-04 14:47:30 +01:00
Robert
c178d251a1
Use more varied data for the number of usages
2023-07-04 11:20:06 +01:00
Robert
97219b9f63
Remove old status info
2023-07-03 16:01:35 +01:00
Robert
15be27c4c3
Add new buttons to title bar
2023-07-03 16:01:34 +01:00
Nora
a3921b7afa
Merge pull request #2562 from github/nora/refactor-graph
...
Convert Graph to a functional component
2023-07-03 15:08:53 +02:00
Nora
9ba5701874
implement merge comments
2023-07-03 11:31:02 +00:00
Robert
4d8694e78b
Merge pull request #2571 from github/robertbrignull/AlertTableHeader
...
Pull out AlertTableHeader to a separate component/file
2023-07-03 12:22:05 +01:00
Robert
e5d4545150
Remove unnecessary function
2023-07-03 10:55:27 +01:00
Robert
0a0b9e590b
Merge pull request #2523 from github/robertbrignull/queries-loading
...
Display different message when queries are loading vs no queries found
2023-07-03 10:52:33 +01:00
Robert
f0af593b67
Simplify comparisons with undefined
2023-07-03 10:51:52 +01:00
Robert
08a8d6396c
Remove column arg where it is always "alert-message"
2023-07-03 10:47:02 +01:00
Robert
c876867753
Rename to folder/file items
2023-07-03 09:52:09 +01:00
Robert
eec2f33cba
Check for underfined before filtering
2023-07-03 09:44:07 +01:00
Robert
78e794ccdf
Convert back to type import
2023-07-03 09:40:05 +01:00
Robert
6acfb8d151
Merge pull request #2570 from github/robertbrignull/AlertTable-rename
...
Rename PathTable => AlertTable
2023-07-03 09:35:10 +01:00
Dave Bartolomeo
e80a06c5c1
Try grabbing screenshot
2023-06-30 13:36:58 -04:00
Dave Bartolomeo
c70ec7159a
Try different default for saveBeforeStart
2023-06-30 10:50:26 -04:00
Dave Bartolomeo
c25410ed5d
Log config settings
2023-06-30 10:16:49 -04:00
Dave Bartolomeo
81b2407a47
Log content of untitled docs
2023-06-30 09:57:47 -04:00
Dave Bartolomeo
1f5b3919b0
Dump dirty documents
2023-06-30 09:37:28 -04:00
Dave Bartolomeo
b859bca25f
Even more logging
2023-06-30 08:50:06 -04:00
Robert
bfae001b3c
Pull out AlertTableHeader to a separate component/file
2023-06-30 10:07:11 +01:00
Robert
2c2b0ecd79
Rename PathTable => AlertTable
2023-06-30 10:01:34 +01:00
Dave Bartolomeo
53a51ab1c9
More logging
2023-06-29 15:33:34 -04:00
Dave Bartolomeo
9f077b0810
Run Jest in verbose mode
2023-06-29 15:14:48 -04:00
Dave Bartolomeo
bf36051054
Increase timeout
2023-06-29 14:52:19 -04:00
Dave Bartolomeo
dbd257e2c0
More logging
2023-06-29 14:39:30 -04:00
Dave Bartolomeo
9fd0697868
Fix format
2023-06-29 12:15:36 -04:00
Dave Bartolomeo
adf0ccb48b
Disable workspace trust for CLI integration tests
2023-06-29 12:10:39 -04:00
Robert
3ff649a49a
Convert ResultsApp to a function component
2023-06-29 14:49:15 +01:00
Robert
dc5826a848
Rearrange functions so they are defined earlier in the file from where they are called
2023-06-29 14:47:45 +01:00
Anders Starcke Henriksen
4e92688900
Merge pull request #2567 from github/version/bump-to-v1.8.8
...
Bump version to v1.8.8
2023-06-29 15:30:29 +02:00
github-actions[bot]
08544a4248
Bump version to v1.8.8
2023-06-29 12:22:33 +00:00
Anders Starcke Henriksen
c00adc01f1
Merge pull request #2565 from github/v1.8.7
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.8.7
2023-06-29 13:04:42 +02:00
Anders Starcke Henriksen
65a3ba96c0
v1.8.7
2023-06-29 10:43:05 +02:00
Dave Bartolomeo
d27efb3a17
Merge remote-tracking branch 'origin/main' into dbartol/save-before-start
2023-06-28 20:07:12 -04:00
Dave Bartolomeo
8ff1db13f7
Fix bad diff
2023-06-28 19:55:43 -04:00
Alexander Eyers-Taylor
67d342f2ed
Give visibility information to the ide-server. ( #2482 )
...
* Add version constraint for Check errors
* Refactor parts of the ideserver out of extension.ts
* Give visibility information to the ide-server.
This allows it to report errors on visible files
eagerly.
2023-06-28 18:21:55 +00:00
Robert
d1838ba0f7
Convert to match style from DB panel
2023-06-28 17:00:44 +01:00
Nora
98d1a24a43
Convert Graph to a functional component
2023-06-28 12:11:55 +00:00
Robert
66d233d669
Merge pull request #2561 from github/enable-a11y-linting-rules
...
Enable accessibility linting rules and comment out existing violations
2023-06-28 11:54:50 +01:00
Koen Vlaswinkel
a64f44bc41
Merge pull request #2559 from github/koesie10/framework-mode-refresh-button
...
Add a refresh button to the data extensions editor
2023-06-28 12:38:04 +02:00
Sam Partington
b8b15a53dc
Enable accessibility linting rules and comment out existing violations
...
cf https://github.com/github/code-stats-collector/pull/390 /
https://github.com/github/code-scanning/issues/9347
2023-06-28 10:59:18 +01:00
Robert
6be9e5359c
fix typo
2023-06-28 10:37:19 +01:00
Koen Vlaswinkel
266b1e5818
Add a refresh button to the data extensions editor
...
This adds a refresh button to the data extensions editor when the
framework mode feature flag is enabled. If you are using framework mode,
you can have multiple tabs of the data extensions editor open in which
you are modeling the library separately from the application. When you
save the library in framework mode, the application mode will not
refresh and show that these calls have been modeled. Rather than using
apply, which might also save all modeled methods, you can now use the
refresh button to refresh the external API usages and whether they are
supported.
2023-06-28 11:33:21 +02:00
Koen Vlaswinkel
001179056e
Merge pull request #2558 from github/koesie10/exclude-test-methods-in-framework-mode
...
Exclude methods in tests in framework mode
2023-06-28 11:14:55 +02:00
Koen Vlaswinkel
bcbbb42b41
Exclude methods in tests in framework mode
...
This excludes methods defined in tests in framework mode, significantly
cutting down on the number of methods shown that would need to be
modeled.
For C#, this just checks that the file is not a test file, as defined
by the QL library.
For Java, this makes a copy of the internal
[`ModelExclusions.qll`](249f9f863d/java/ql/lib/semmle/code/java/dataflow/internal/ModelExclusions.qll )
file to avoid the use of internal modules. This module will tell us
whether a method is "interesting" to model or not. Not all of the checks
in this module need to happen for framework mode, but these checks might
be useful for telling a user whether a method is interesting to model
in application mode.
2023-06-28 10:21:26 +02:00
Koen Vlaswinkel
6465786411
Merge pull request #2557 from github/koesie10/jump-to-def-framework-mode
...
Add jump to definition in framework mode
2023-06-28 09:49:45 +02:00
Robert
d290b56649
Display custom text message when there are no queries found
2023-06-27 17:04:26 +01:00
Robert
cf49d5dcde
Change welcome message to say we're searching for queries
2023-06-27 17:04:26 +01:00
Robert
94fe3e0020
Always trigger pathsChanged listener after initial refresh
2023-06-27 17:04:26 +01:00
Shati Patel
9314b3ba56
Merge pull request #2554 from github/shati-patel/run-all-context-menu
...
Queries panel: Run all queries in folder (context menu)
2023-06-27 16:51:40 +01:00
Nora
af366afcff
Merge pull request #2556 from github/nora/release-run-from-tab
...
Release run query from file tab icon
2023-06-27 17:46:35 +02:00
Robert
6fe7b82397
Only return something from getPathData once discover has run at least once
2023-06-27 16:20:30 +01:00
Koen Vlaswinkel
1579859c9d
Merge pull request #2555 from github/koesie10/nested-name-csharp
...
Add `nestedName` function for C#
2023-06-27 17:00:23 +02:00
Koen Vlaswinkel
5349a75bd0
Add jump to definition in framework mode
...
This makes the method name and parameters in framework mode a link to
the definition of the method. In framework mode, the `usages` contains
1 element, which is the location of the definition of the method.
Therefore, we can simply use `jumpToUsage` to jump to the definition.
2023-06-27 16:57:46 +02:00
Nora
46a32081d9
Release run query from file tab
2023-06-27 14:40:48 +00:00
Nora
82977519ce
Merge pull request #2552 from github/nora/run-all-queries-panel
...
Queries Panel: run-all queries of a folders
2023-06-27 16:37:43 +02:00
Nora
32555cc4f2
Merge pull request #2548 from github/dependabot/npm_and_yarn/extensions/ql-vscode/semver-7.5.2
...
Bump semver from 7.3.7 to 7.5.2 in /extensions/ql-vscode
2023-06-27 16:33:16 +02:00
Koen Vlaswinkel
4b8cdf872a
Merge pull request #2553 from github/koesie10/nested-name
...
Use `nestedName` for getting the name of an API
2023-06-27 16:17:43 +02:00
Koen Vlaswinkel
8af0ba7411
Add nestedName function for C#
...
Similar to https://github.com/github/vscode-codeql/pull/2553 , this
changes the C# query to correctly report the name of nested types. I
couldn't find a `nestedName` method for C#, so this adds one in the
`AutomodelVsCode` library.
C# seems to use `+` as a separator for nested types, as reported by
`getQualifiedName()`:
```
GitHub.Nested.MyFirstClass+NestedClass
```
The `getApiName()` will now report:
```
GitHub.Nested#MyFirstClass+NestedClass.Test()
```
2023-06-27 16:14:42 +02:00
shati-patel
02b356cf86
Queries panel: Run all queries in folder (context menu)
...
Adds a command to run all queries in a certain folder.
This uses the existing `runQueries` command, which lets you run multiple queries against the selected local database.
We don't have a corresponding command for running multiple variant analysis queries, so I haven't implemented that.
2023-06-27 15:03:23 +01:00
Koen Vlaswinkel
3ad3644219
Merge pull request #2542 from github/koesie10/override-extension-directory
...
Allow overriding the data extensions editor extensions directory
2023-06-27 15:13:59 +02:00
Koen Vlaswinkel
77495df97d
Merge pull request #2550 from github/koesie10/refactor-duplication-queries
...
Refactor data extensions editor queries to reduce duplication
2023-06-27 15:13:50 +02:00
Nora
a591c82b3c
Add run all on folders
2023-06-27 15:08:30 +02:00
Shati Patel
ee68156574
Merge pull request #2547 from github/shati-patel/run-query-context-menu-remote
...
Run variant analysis from Queries Panel context menu
2023-06-27 13:38:25 +01:00
Koen Vlaswinkel
a053792d6e
Use nestedName for getting the name of an API
...
This changes the Java `CallableMethod.getApiName()` to use `nestedName`
instead of `getSourceDeclaration`. `getSourceDeclaration` would return a
`RefType`, on which the `toString()` method returns its `getName`().
However, for nested types this wouldn't work and wouldn't include the
enclosing type. This fixes it by using `nestedName` which matches the
method that is also used for determining whether a type matches an
extensible predicate.
2023-06-27 14:38:19 +02:00
Alexander Eyers-Taylor
b0699ee524
Add quick eval count to the command palette ( #2475 )
...
* Add version constraint for quick-eval-count
* Add quick eval count context.
* Add support for running quick-eval-count from the command pallete
* Adjust name for quick-eval-count-queries
* Add changenote for quick-eval-count.
* QuickEval:Address review comments
* Fix rebase conflict in changelog
2023-06-27 11:28:28 +01:00
Koen Vlaswinkel
bd0e5604a8
Fix incorrect JAR name being displayed in application mode
2023-06-27 11:22:03 +02:00
Nora
2a332f90c4
Merge pull request #2551 from github/nora/fix-merge-conflict-mistake
...
Fix merge conflict error: Re-add icon
2023-06-27 10:46:00 +02:00
Shati Patel
7b73ff4231
Merge pull request #2546 from github/shati-patel/run-query-context-menu-local
...
Run local query from Queries Panel context menu
2023-06-26 17:08:42 +01:00
Shati Patel
0d0ae6449f
Merge branch 'main' into shati-patel/run-query-context-menu-local
2023-06-26 16:46:24 +01:00
Nora
3c156b858c
Re-add icon
2023-06-26 14:54:17 +00:00
Koen Vlaswinkel
7e8578a22c
Refactor data extensions editor queries to reduce duplication
...
This refactors the data extensions editor queries to use a new
`AutomodelVsCode` module. This module is based on the `ExternalApi`
module, but is more general and can be used for retrieving public
methods from the source as well. The actual conditions are now in the
queries themselves.
This reduces the duplicated module in the framework mode query and will
mean that when we update the `ExternalApi` module, we will just have to
port it to the `AutomodelVsCode` module, and not to the `ExternalApi`
and a separate framework mode query.
2023-06-26 16:33:05 +02:00
Koen Vlaswinkel
aa4d3f4399
Merge pull request #2549 from github/koesie10/consistent-sorting
...
Sort methods sent to LLM the same way as the UI
2023-06-26 16:11:38 +02:00
Nora
75d2f76658
Merge pull request #2544 from github/nora/queries-panel-file-tab
...
Queries Panel: run local query from file tab
2023-06-26 16:09:03 +02:00
Robert
75cffd50b1
Merge pull request #2539 from github/robertbrignull/raw-results-react
...
Convert RawTable to a function component
2023-06-26 14:23:19 +01:00
Nora
10d8bbfe63
Add run icon to file tab
2023-06-26 14:48:48 +02:00
Koen Vlaswinkel
90c8391fea
Sort methods sent to LLM the same way as the UI
...
This changes the sorting of the methods sent to LLM to match the order
shown in the data extensions editor. This will ensure that the methods
which are shown first in the data extensions editor are also modeled
first.
2023-06-26 14:26:31 +02:00
Koen Vlaswinkel
a8aee6a8e1
Extract sorting to separate functions
2023-06-26 14:08:46 +02:00
dependabot[bot]
d41e9ef163
Bump semver from 7.3.7 to 7.5.2 in /extensions/ql-vscode
...
Bumps [semver](https://github.com/npm/node-semver ) from 7.3.7 to 7.5.2.
- [Release notes](https://github.com/npm/node-semver/releases )
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md )
- [Commits](https://github.com/npm/node-semver/compare/v7.3.7...v7.5.2 )
---
updated-dependencies:
- dependency-name: semver
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-26 11:57:15 +00:00
Nora
13a5b7854f
Merge pull request #2534 from github/nora/run-local-query-panel
...
Queries Panel: run local query from panel
2023-06-26 13:56:08 +02:00
shati-patel
3a3264302a
Run variant analysis from Queries Panel context menu
2023-06-26 11:53:01 +01:00
shati-patel
9704b498fe
Run local query from Queries Panel context menu
2023-06-26 10:51:18 +01:00
Nora
2b48991494
Rename command
2023-06-26 09:04:06 +00:00
Nora
ff41e50954
Show run button only when db is selected
2023-06-26 09:04:06 +00:00
Nora
24683f34de
Adjust command lint tests
2023-06-26 09:04:06 +00:00
Nora
7db84b0276
Always show run button
2023-06-26 09:04:06 +00:00
Nora
655294db06
Use only one command
2023-06-26 09:04:06 +00:00
Nora
5845e9e59e
Merge comments and mock command
2023-06-26 09:04:06 +00:00
Nora
c0c42d36b9
Use corret Uri method and extract feature flag guard
2023-06-26 09:04:06 +00:00
Nora
2898acd67f
Hide new command behind feature flag
2023-06-26 09:04:06 +00:00
Robert
7409fe8a56
rename commands to match linter
2023-06-26 09:04:06 +00:00
Robert
f25d7baa56
Expose QueryServerCommandManager from app
2023-06-26 09:04:06 +00:00
Nora
3f1b619904
Create new runQuery command for the queries panel
2023-06-26 09:04:06 +00:00
Nora
12c0c57c25
hook up new command and make runQuery executable
2023-06-26 09:04:06 +00:00
Nora
c78db22599
Hide run button when no local database is selected
2023-06-26 09:04:06 +00:00
Nora
fea0c3ce46
Add icon
2023-06-26 09:04:06 +00:00
Robert
0e033b48d4
Avoid creating and throwing away Scroller each render
2023-06-26 10:03:15 +01:00
Koen Vlaswinkel
971d1461c8
Merge pull request #2543 from github/koesie10/exclude-anonymous-classes
...
Exclude methods from anonymous classes in framework mode
2023-06-26 10:00:04 +02:00
Koen Vlaswinkel
a76bd4627c
Merge pull request #2535 from github/koesie10/framework-mode
...
Add initial implementation of framework mode
2023-06-23 13:57:09 +02:00
Koen Vlaswinkel
6e16f826fb
Exclude methods from anonymous classes in framework mode
2023-06-23 13:45:06 +02:00
Koen Vlaswinkel
4f367119cb
Fix data extensions editor story
2023-06-23 11:59:26 +02:00
Koen Vlaswinkel
01da0f1d34
Fix incorrect comment on method
2023-06-23 11:58:43 +02:00
Koen Vlaswinkel
aec5ff3902
Allow overriding the extensions directory
...
This will allow users to override the default directory in which
extension packs are created by using the
`codeQL.dataExtensions.extensionsDirectory` setting. This setting can be
overriden per language, so the user could create the following
configuration to set the extension pack setting for Java only:
```json
"[java]": {
"codeQL.dataExtensions.extensionsDirectory": "/Users/user/github/vscode-codeql-starter/codeql-custom-queries-java",
}
```
2023-06-23 11:37:58 +02:00
Koen Vlaswinkel
f90d538743
Add feature flag for framework mode
2023-06-23 11:12:28 +02:00
Koen Vlaswinkel
72a91efde9
Add tests for framework mode YAML generation
2023-06-23 10:45:12 +02:00
Koen Vlaswinkel
8c36e572cb
Create model filenames for framework mode
2023-06-23 10:04:37 +02:00
Koen Vlaswinkel
2351346440
Change data flow generator for framework mode
2023-06-23 09:53:53 +02:00
Koen Vlaswinkel
d26d886d09
Add grouping by package and remove usages for framework mode
2023-06-23 09:53:53 +02:00
Koen Vlaswinkel
48b78c1ac1
Change tests to include framework mode queries
2023-06-23 09:53:53 +02:00
Koen Vlaswinkel
526e7474a5
Add switching of mode
2023-06-23 09:53:52 +02:00
Koen Vlaswinkel
31e1bef548
Add framework mode queries
2023-06-23 09:53:01 +02:00
Koen Vlaswinkel
82cdf03d8c
Merge pull request #2521 from github/koesie10/auto-create-model-files
...
Automatically create different model files per library
2023-06-23 09:52:39 +02:00
Dave Bartolomeo
d9a1aa8a23
Just kidding, _this_ time it's fixed for reals
2023-06-22 14:40:26 -04:00
Dave Bartolomeo
3705464766
Seriously, I think they'll pass for reals this time.
2023-06-22 14:32:25 -04:00
Dave Bartolomeo
ff2d67d930
Merge remote-tracking branch 'origin/main' into dbartol/save-before-start
2023-06-22 17:32:05 +00:00
Dave Bartolomeo
ec71f53e38
Fix more test failures
2023-06-22 13:31:12 -04:00
Robert
fa23441efb
Merge pull request #2541 from github/robertbrignull/move-pure-4
...
Move tests out of pure directory
2023-06-22 17:08:58 +01:00
Dave Bartolomeo
6bdc095d27
Fix test failure
2023-06-22 11:45:54 -04:00
Robert
ecfa0ff5b9
Convert dataRows to a useMemo
2023-06-22 16:45:23 +01:00
Robert
3957d356f0
Import react hooks explicitly
2023-06-22 16:45:23 +01:00
Robert
f08ef1b742
Use useRef instead of useMemo for scroller
2023-06-22 16:45:21 +01:00
Robert
e29bfc83c8
Use useEffect instead of calling directly every time
2023-06-22 16:20:32 +01:00
Robert
8b95320ba8
Move tests out of pure directory
2023-06-22 15:19:47 +01:00
Robert
480bd48a8d
Merge pull request #2533 from github/robertbrignull/assert-pure
...
Update assert-pure.ql now that the /pure directory has been removed
2023-06-22 15:19:25 +01:00
Robert
1499d909c8
Merge pull request #2537 from github/robertbrignull/move-pure-3
...
Move files from /pure to the /common (and other) directories (part 3 of 3)
2023-06-22 15:15:31 +01:00
Dave Bartolomeo
2397ead586
Fix test failure
2023-06-22 10:02:10 -04:00
Koen Vlaswinkel
b42457c50b
Merge pull request #2540 from github/koesie10/update-external-api-qll
...
Update ExternalApi.qll dependencies
2023-06-22 15:21:10 +02:00
Robert
f5fef92f0f
Move variant-analysis-filter-sort to shared directory
2023-06-22 13:42:12 +01:00
Robert
fc36eaab4b
Move variant-analysis-filter-sort.ts to /variant-analysis
2023-06-22 13:37:13 +01:00
Robert
08fdddeefc
Move result-keys.ts to /view/results
2023-06-22 13:37:13 +01:00
Robert
8e58854302
Move log-summary-parser.ts to /log-insights
2023-06-22 13:37:13 +01:00
Robert
1750594d11
Move new-messages.ts to /query-server
2023-06-22 13:37:10 +01:00
Koen Vlaswinkel
2e7c86d107
Update ExternalApi.qll dependencies
2023-06-22 14:33:28 +02:00
Robert
6143bd30d8
Convert RawTable to a functional component
2023-06-22 12:41:23 +01:00
Dave Bartolomeo
0bd0bf1944
_Correctly_ emulate VS Code's saveBeforeStart
2023-06-22 07:30:53 -04:00
Robert
cd69e5934b
Merge pull request #2536 from github/robertbrignull/throw-instead-of-fail
...
Throw error instead of using fail method
2023-06-22 11:48:49 +01:00
Koen Vlaswinkel
669f4a6430
Add .model suffix to model filenames
2023-06-22 11:44:20 +02:00
Koen Vlaswinkel
b7b4302c1e
Automatically create different model files per library
...
This will remove the user input for a model file and will instead create
1 model file per library (JAR/DLL). The model filename will be based on
the JAR/DLL name, but will remove the version number and the file
extension. It will also normalize the name.
These files will be created automatically, and the editor now also reads
in all files contained in an extension pack to read the modeled methods.
This could result in duplicates if the user has created a different file
to contain the same modeled methods, but this is an edge-case that we're
explicitly not handling.
2023-06-22 11:44:18 +02:00
Koen Vlaswinkel
100b557823
Merge pull request #2520 from github/koesie10/auto-name-extension-pack
...
Automatically name extension packs
2023-06-22 11:34:37 +02:00
Koen Vlaswinkel
7249f4c343
Add comment to explain heuristic
2023-06-22 10:08:11 +02:00
Koen Vlaswinkel
e4e849d14c
Merge remote-tracking branch 'origin/main' into koesie10/auto-name-extension-pack
2023-06-22 10:01:51 +02:00
Dave Bartolomeo
b182d7afef
Fix PR feedback
2023-06-21 17:20:32 -04:00
Dave Bartolomeo
1da96c5a55
Allow languageId: scopes in tests
2023-06-21 17:01:13 -04:00
Dave Bartolomeo
de38b1fd20
Stop overriding saveBeforeStart for ql language
2023-06-21 14:27:57 -04:00
Dave Bartolomeo
7a46bac078
Save dirty documents before evaluating queries
2023-06-21 18:12:42 +00:00
Robert
f8b0583c5f
Move messages-shared.ts to /query-server
2023-06-21 16:31:57 +01:00
Robert
b0e6478bfe
Move legacy-messages.ts to /query-server
2023-06-21 16:31:57 +01:00
Robert
0031c1acc0
Throw error instead of using fail method
2023-06-21 16:02:57 +01:00
Robert
0451dd8d1b
Merge pull request #2532 from github/robertbrignull/move-pure-2
...
Move files from /pure to the /common directory (part 2 of 3)
2023-06-21 13:15:38 +01:00
Robert
8559d3baa0
Update assert-pure.ql now that the /pure directory has been removed
2023-06-21 12:33:32 +01:00
Robert
f12b62fa9d
Move zip.ts to /common
2023-06-21 12:19:35 +01:00
Robert
90e94e04fc
Move word.ts to /common
2023-06-21 12:19:35 +01:00
Robert
236a317fa0
Move time.ts to /common
2023-06-21 12:19:35 +01:00
Robert
1bf14e393f
Move text-utils.ts to /common
2023-06-21 12:19:35 +01:00
Robert
655adfcd51
Move sarif-utils.ts to /common
2023-06-21 12:19:35 +01:00
Robert
b11a675004
Move ql.ts to /common
2023-06-21 12:19:35 +01:00
Robert
855cac628b
Move number.ts to /common
2023-06-21 12:19:35 +01:00
Robert
5b168dfb7e
Move location-link-utils.ts to /common
2023-06-21 12:19:35 +01:00
Robert
704ebf1ff6
Move interface-types.ts to /common
2023-06-21 12:19:35 +01:00
Robert
9903982bb1
Merge pull request #2530 from github/robertbrignull/move-pure-1
...
Move files from /pure to the /common directory (part 1 of 3)
2023-06-21 11:54:11 +01:00
Robert
d0df2966c5
Merge branch 'main' into robertbrignull/move-pure-1
2023-06-21 11:23:42 +01:00
Koen Vlaswinkel
7f9208f1e1
Merge pull request #2531 from github/koesie10/remove-common-index
...
Remove `common/index.ts` and vscode from `common/logging`
2023-06-21 12:11:19 +02:00
Robert
e92b676820
Merge branch 'main' into robertbrignull/move-pure-1
2023-06-21 10:37:39 +01:00
Robert
a054290c50
Merge pull request #2529 from github/robertbrignull/queries-panel-errors
...
Ensure errors for one path don't stop discovery of other paths
2023-06-21 10:09:45 +01:00
Koen Vlaswinkel
eeb867624e
Remove common/index.ts and vscode from common/logging
...
The `logging` part of `common` was exported in `common/index.ts` and
could be imported by importing `common`. I don't think this makes a lot
of sense, so I removed it.
The `common/logging/index.ts` also contained exports of the
`common/logging/vscode` directory, which means that importing
`common/logging` automatically brings in the `vscode` module. This
removes that export, so now there are two separate imports needed for
importing the common part and the `vscode` specific part. This should
make it easier to keep them separate and be more explicit about what
you're importing.
2023-06-21 10:20:19 +02:00
Robert
2813576f07
Move helpers-pure.ts to /common
2023-06-21 09:10:26 +01:00
Robert
1ced7a90fd
Move files.ts to /common
2023-06-21 09:06:38 +01:00
Robert
4cbd0b7fb8
Move errors.ts to /common
2023-06-21 09:03:16 +01:00
Robert
af97077095
Move distribution.ts to /common
2023-06-21 08:59:51 +01:00
Robert
a5aa0c4cf3
Move disposable-object.ts to /common
2023-06-21 08:56:59 +01:00
Koen Vlaswinkel
d092e69abf
Add detection of root workspace directory using .git folder
2023-06-21 09:55:29 +02:00
Robert
7cab02de60
Move date.ts to /common
2023-06-21 08:53:51 +01:00
Robert
dc91028cee
Move bqrs-utils.ts to /common
2023-06-21 08:50:39 +01:00
Robert
f228ec9645
Move bqrs-cli-types.ts to /common
2023-06-21 08:50:35 +01:00
Koen Vlaswinkel
f32a240e24
Exclude workspace folders in the system temp dir
2023-06-21 09:44:39 +02:00
Robert
7135d39aad
Log error message
2023-06-21 08:24:22 +01:00
Shati Patel
c628454e25
Allow queries panel to be visible in non-dev mode too ( #2528 )
2023-06-20 16:46:31 +01:00
Robert
fa773a0029
Ensure errors for one path don't stop discovery of other paths
2023-06-20 16:21:20 +01:00
Koen Vlaswinkel
2c97ca95aa
Merge pull request #2527 from github/koesie10/replace-faker-uuid
...
Replace deprecated faker.datatype.uuid by faker.string.uuid
2023-06-20 16:50:30 +02:00
Koen Vlaswinkel
d3a179744e
Merge branch 'main' into koesie10/replace-faker-uuid
2023-06-20 16:22:51 +02:00
Koen Vlaswinkel
8fb1229c49
Merge pull request #2524 from github/koesie10/grouping-improvements
...
Improve grouping of libraries
2023-06-20 15:22:33 +02:00
Robert
23173bf441
Merge pull request #2525 from github/robertbrignull/sendRequest_progress
...
Remove ProgressCallback / CancellationToken arguments where they aren't used
2023-06-20 14:16:36 +01:00
Koen Vlaswinkel
1cc6aa5303
Merge branch 'main' into koesie10/auto-name-extension-pack
2023-06-20 15:12:15 +02:00
Koen Vlaswinkel
2800ccb74c
Add extra sorting parameters for libraries
2023-06-20 14:24:56 +02:00
Robert
3685575c11
Merge branch 'main' into robertbrignull/sendRequest_progress
2023-06-20 13:24:30 +01:00
github-actions[bot]
c40be89636
Bump CLI version from v2.13.3 to v2.13.4 for integration tests ( #2526 )
...
Co-authored-by: github-actions[bot] <github-actions@github.com >
2023-06-20 11:28:25 +01:00
Robert
f99957435d
Fix expected args in tests
2023-06-20 11:09:13 +01:00
Koen Vlaswinkel
ff491bb706
Replace deprecated faker.datatype.uuid by faker.string.uuid
2023-06-20 11:48:31 +02:00
Koen Vlaswinkel
cfc66a4e17
Store extension packs in .github/codeql/extensions
2023-06-20 11:16:23 +02:00
Robert
4d8506b3f5
Add back in manual progress update
2023-06-20 09:42:59 +01:00
Koen Vlaswinkel
ab6db71727
Move workspace folder functions to separate file
2023-06-20 10:06:52 +02:00
Koen Vlaswinkel
ddd97f08a3
Add chevron to show whether row is expanded
2023-06-20 09:32:57 +02:00
Koen Vlaswinkel
32d8968c56
Use pluralize function for pluralization
2023-06-20 09:32:57 +02:00
Koen Vlaswinkel
768c10734e
Make libraries collapsible
2023-06-20 09:32:57 +02:00
Koen Vlaswinkel
a833f78151
Sort libraries by supported and usages
2023-06-20 09:32:57 +02:00
Robert
c93449ab9f
Remove ProgressCallback / CancellationToken arguments where they aren't used
2023-06-19 17:13:40 +01:00
Robert
d8c3410641
Merge pull request #2490 from github/robertbrignull/resolve-queries-manual
...
Add manual discovery of queries and query packs
2023-06-19 14:40:50 +01:00
Robert
d2b69b1316
Normalize tmp path to ensure correct comparrison on windows
2023-06-19 14:13:09 +01:00
Koen Vlaswinkel
e83ad364f5
Merge pull request #2522 from github/koesie10/group-by-library
...
Group modeled methods by library in the data extensions editor
2023-06-19 15:01:19 +02:00
Koen Vlaswinkel
fe29a1a32a
Add more comments
2023-06-19 13:54:17 +02:00
Koen Vlaswinkel
3323fd4e3b
Add more tests for auto pack naming
2023-06-19 13:51:24 +02:00
Koen Vlaswinkel
3c60708b55
Separate pack naming and create interface
2023-06-19 13:47:27 +02:00
Koen Vlaswinkel
8980aabbfc
Split flows for checking existing extension pack
2023-06-19 13:34:35 +02:00
Robert
a30ec907d0
Add tiny sleep to fix tests
2023-06-19 11:32:55 +01:00
Robert
96bb7058a2
Make note about NodeJS.ErrnoException
2023-06-19 11:09:08 +01:00
Koen Vlaswinkel
5dcadd2f1f
Merge pull request #2519 from github/koesie10/add-library-to-data-extensions-editor
...
Add library to data extensions editor
2023-06-19 12:07:34 +02:00
Robert
1f18cc3f2c
Use Readonly and ReadonlyArray
2023-06-19 10:58:26 +01:00
Robert
989ef8b681
Fix typo
2023-06-19 10:57:20 +01:00
Robert
70681253eb
Only expose event to subclasses, instead of event emitter
2023-06-19 10:57:10 +01:00
Koen Vlaswinkel
bbc39b060f
Remove library column
2023-06-19 11:52:09 +02:00
Koen Vlaswinkel
590e908886
Group modeled methods by library
2023-06-19 11:39:47 +02:00
Koen Vlaswinkel
487c0a66f4
Create ModeledMethodDataGrid component
2023-06-19 11:33:45 +02:00
Koen Vlaswinkel
23745ba93f
Change jar to library for Java query
2023-06-19 11:25:40 +02:00
Robert
af62a92c5b
Make pathData private to FilePathDiscovery
2023-06-16 16:40:11 +01:00
Robert
da92a67834
Introduce recomputeAllData to avoid mutating pathData from outside of FilePathDiscovery
2023-06-16 16:35:58 +01:00
Robert
c6a7e1fb3c
Rename from path to pathData where appropriate
2023-06-16 16:23:39 +01:00
Robert
d626cea837
Use getOnDiskWorkspaceFolders instead of getOnDiskWorkspaceFoldersObjects when all we need is the path
2023-06-16 16:14:08 +01:00
Robert
bdea0c2c20
Use one lstat call instead of calling exists first
2023-06-16 16:12:29 +01:00
Robert
44327cac23
Use sets instead of custom expectArraysEqual
2023-06-16 15:23:32 +01:00
Koen Vlaswinkel
5d83ac84e3
Fix tests on Windows
2023-06-16 16:01:30 +02:00
Robert
3a0aaa0ae9
Use jest.SpiedFunction instead of jest.SpyInstance
2023-06-16 12:35:59 +01:00
Robert
18e7431a44
Make conditional easier to read
2023-06-16 12:33:21 +01:00
Koen Vlaswinkel
549884d507
Automatically name extension packs
...
This will change how extension packs are named in the data extensions
editor. Before, the user had to pick a workspace folder and a name for
the extension pack. Now, the workspace folder will be picked
automatically if we can detect it (i.e. it follows the naming structure
we expect), or the user will still need to select it. The extension pack
name is always auto-generated based on the database name and the
database language.
This adds a new `codeQL.dataExtensions.disableAutoNameExtensionPack`
setting to disable this behavior while we are still working on changing
how the data extensions editor works.
2023-06-16 13:31:31 +02:00
Robert
6504e46011
Invert condition to reduce nesting
2023-06-16 12:31:12 +01:00
Robert
ce6a21c65a
Use pathExists instead of exists
2023-06-16 12:21:36 +01:00
Robert
fce27d02dc
Use a plain Set intead of custom FilePathSet
2023-06-16 11:29:38 +01:00
Robert
f7a72c6d45
Use QueryLanguage where possible
2023-06-16 11:29:28 +01:00
Koen Vlaswinkel
55d1f14ac4
Add library to data extensions editor
...
This adds a new library column to the data extensions editor containing
the JAR or DLL file the method is defined in. This will be used to group
methods by library in the future. For now, it just shows in a column.
2023-06-16 12:01:30 +02:00
Robert
959c3fbcb8
Fix typos
2023-06-16 10:47:07 +01:00
Koen Vlaswinkel
0f9d127b4c
Merge pull request #2513 from github/koesie10/show-telemetry-without-vscode
...
Make the `showAndLogExceptionWithTelemetry` function work without the `vscode` module
2023-06-16 09:39:12 +02:00
Andrew Eisenberg
f9a415c377
Merge pull request #2516 from github/aeisenberg/modernize
...
Modernize query packs
2023-06-15 08:01:22 -07:00
Koen Vlaswinkel
539284b902
Merge pull request #2511 from github/koesie10/show-and-log-without-vscode
...
Make the showAndLog family of functions usable without the `vscode` module
2023-06-15 09:29:18 +02:00
Andrew Eisenberg
244bc3bdab
Modernize query packs
...
Remove legacy `libraryPathDependencies`. We are making some
changes internally that will cause legacy packs with lock
files to throw an error.
2023-06-14 20:56:45 +00:00
Robert
5cbb7b49d7
Update QueryDiscovery to use FilePathDiscovery and QueryPackDiscovery
2023-06-14 17:30:40 +01:00
Robert
a9d59aecb8
Add QueryPackDiscovery
2023-06-14 17:30:37 +01:00
Robert
17b5e000f8
Add FilePathDiscovery
2023-06-14 17:30:33 +01:00
Robert
790c33c661
Add silent arg to resolveLibraryPath
2023-06-14 16:09:42 +01:00
Robert
51b94e3fed
Add FilePathSet
2023-06-14 16:09:42 +01:00
Robert
b0441956df
Remove the update method from the Discovery class
...
See https://github.com/github/vscode-codeql/pull/2490#discussion_r1226437598
for more explanation. This will make the class more useful for future usecases
where we don't want the behaviour of only calling update when there isn't
another refresh scheduled. I also think it doesn't negatively affect other
users such as the query test discovery. The effect should be that we'll see
more updates to the UI. These updates will get overwritten quickly, but they
are all genuine snapshots of the filesystem at the point the discovery process
ran, so they aren't incorrect, or aren't more incorrect than continuing to show
the old state before any discovery ran.
2023-06-14 16:09:42 +01:00
Koen Vlaswinkel
8803433fa4
Merge pull request #2515 from github/version/bump-to-v1.8.7
...
Bump version to v1.8.7
2023-06-14 14:53:24 +02:00
github-actions[bot]
ab448e51d5
Bump version to v1.8.7
2023-06-14 12:20:00 +00:00
Koen Vlaswinkel
2905f5340a
Merge pull request #2514 from github/v1.8.6
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.8.6
2023-06-14 13:51:21 +02:00
Koen Vlaswinkel
170fce8815
v1.8.6
2023-06-14 13:17:03 +02:00
Koen Vlaswinkel
7a76e20841
Move showAndLogExceptionWithTelemetry out of vscode directory
2023-06-14 11:59:14 +02:00
Koen Vlaswinkel
d03d355513
Add telemetry as argument to showAndLogExceptionWithTelemetry
2023-06-14 11:19:50 +02:00
Koen Vlaswinkel
959728d1ca
Add telemetry to App
2023-06-14 11:19:46 +02:00
Koen Vlaswinkel
fefb2f6694
Add AppTelemetry interface
2023-06-14 11:19:16 +02:00
Koen Vlaswinkel
08786055e3
Move telemetry to common/vscode
2023-06-14 11:19:10 +02:00
Koen Vlaswinkel
108d5268b0
Fix tests mocking showAndLog functions
2023-06-14 11:17:49 +02:00
Koen Vlaswinkel
fcbe3bea1e
Use app logger instead of extLogger where possible
...
To increase the use of the `app` logger, this replaces the direct use of
`extLogger` by the `app.logger` where possible. This should not change
the behavior since the `extLogger` is the logger used by the `app`.
2023-06-14 11:17:37 +02:00
Koen Vlaswinkel
2b85690c68
Change logger on app to NotificationLogger
2023-06-14 11:17:18 +02:00
Koen Vlaswinkel
67c081921b
Move show and log functions to common
...
This moves the `showAndLog` family of functions to the `common/logging`
directory. It explicitly moves the `showAndLogExceptionWithTelemetry`
function to the `common/vscode/logging.ts` file because it still has a
dependency on the `telemetryListener`, which depends on the `vscode`
module.
2023-06-14 11:17:17 +02:00
Koen Vlaswinkel
9ff2d568c8
Change showAndLog functions to take NotificationLogger
2023-06-14 11:16:52 +02:00
Koen Vlaswinkel
d54ee0c0e5
Merge pull request #2508 from github/koesie10/split-helpers-4
...
Split helpers.ts [Part 4]
2023-06-14 11:15:04 +02:00
Nora
fa7d85ea58
Merge pull request #2512 from github/nora/remove-code-search-flag
...
Remove code search feature flag
2023-06-14 10:41:19 +02:00
Koen Vlaswinkel
179942680e
Merge pull request #2506 from github/koesie10/split-helpers-3
...
Move show and log functions out of helpers
2023-06-14 10:28:43 +02:00
Koen Vlaswinkel
f67f53dd68
Merge remote-tracking branch 'origin/main' into koesie10/split-helpers-3
2023-06-14 09:30:41 +02:00
Koen Vlaswinkel
c6c56284ff
Merge pull request #2505 from github/koesie10/split-helpers-2
...
Split `helpers.ts` [Part 2]
2023-06-14 09:29:58 +02:00
Nora
afa2f426b8
Update Changelog
2023-06-13 14:55:14 +00:00
Nora
fd381640a0
Remove feature flag
2023-06-13 14:55:02 +00:00
Robert
019e3772ef
Merge pull request #2510 from github/robertbrignull/use_contains_path
...
Use containsPath where possible
2023-06-13 10:19:01 +01:00
Nora
a03b3dca86
Merge pull request #2507 from github/nora/remove-1000-list-limit
...
Remove limit of 1000 repos per list
2023-06-13 09:57:16 +02:00
Robert
cad651d6bd
Use containsPath where possible
2023-06-12 16:33:35 +01:00
Robert
400bde6e03
Merge pull request #2509 from github/robertbrignull/contains_path
...
Fix containsPath for paths that share a prefix
2023-06-12 16:17:39 +01:00
Robert
3a9fa42790
Merge branch 'main' into robertbrignull/contait push origin robertbrignull/contains_pathns_path
2023-06-12 15:39:47 +01:00
Robert
c920b7e49e
Remove explicit check for windows
2023-06-12 15:16:43 +01:00
Koen Vlaswinkel
ccf38a98fb
Move incorrectly named helpers.test.ts
2023-06-12 15:55:10 +02:00
Koen Vlaswinkel
00240e56f4
Rename helpers.ts to tmp-dir.ts
2023-06-12 15:55:10 +02:00
Koen Vlaswinkel
1096ed8bf5
Move upgradesTmpDir out of helpers
2023-06-12 15:55:10 +02:00
Koen Vlaswinkel
61ac19f715
Move createTimestampFile out of helpers
2023-06-12 15:55:09 +02:00
Koen Vlaswinkel
9a32556b4d
Move query language functions out of helpers
2023-06-12 15:55:09 +02:00
Koen Vlaswinkel
2cd88cecde
Move tryGetQueryMetadata out of helpers
2023-06-12 15:55:09 +02:00
Robert
6dbbd22c0a
Merge pull request #2497 from github/robertbrignull/cleanup_workspace_folders
...
Remove workspaceFolders from app because it turned out not to be useful
2023-06-12 14:50:00 +01:00
Robert
aa4c459cdd
Use relative instead of startsWith to handle paths with the same prefix
2023-06-12 14:41:31 +01:00
Robert
f7c1f06354
Add another test case for case insensitivity on windows
2023-06-12 14:41:31 +01:00
Robert
6e3d0147c9
Add test cases for paths with the same prefix
2023-06-12 14:41:31 +01:00
Robert
300503e1c9
Remove platform arg as it's never not the process.platform
2023-06-12 14:41:31 +01:00
Robert
bdd2319297
Update docs to mention about paths being equal
2023-06-12 14:41:21 +01:00
Nora
4c16888624
Remove limit of 1000 to repo lists
2023-06-12 12:46:40 +00:00
Koen Vlaswinkel
d71f210647
Merge pull request #2504 from github/koesie10/split-helpers
...
Split helpers.ts file
2023-06-12 14:42:32 +02:00
Koen Vlaswinkel
c16d363b08
Move show and log functions out of helpers
2023-06-12 14:24:04 +02:00
Robert
8b1e49c6c0
Use more descriptive names
2023-06-12 12:50:01 +01:00
Koen Vlaswinkel
50f958067c
Move prepareCodeTour to separate file
2023-06-12 12:12:18 +02:00
Koen Vlaswinkel
7f3e9607aa
Move dialog functions to separate file
2023-06-12 12:09:36 +02:00
Koen Vlaswinkel
0cfbf0cb2a
Move workspace folder functions to separate file
2023-06-12 12:02:45 +02:00
Koen Vlaswinkel
bfead07592
Move walkDirectory to pure files file
2023-06-12 11:13:57 +02:00
Koen Vlaswinkel
8c98401efe
Move isQueryLanguage to query language file
2023-06-12 11:11:47 +02:00
Koen Vlaswinkel
a4e4c67bf2
Move getInitialQueryContents to separate file
2023-06-12 11:10:23 +02:00
Koen Vlaswinkel
754fa675f9
Move db contents heuristics to separate file
2023-06-12 11:07:25 +02:00
Koen Vlaswinkel
b0c18b3300
Move unused languageToDbScheme
2023-06-12 11:01:42 +02:00
Koen Vlaswinkel
706c6b8a7a
Move qlpacks helpers to separate file
2023-06-12 10:59:42 +02:00
Nora
fe21a21ca2
Merge pull request #2501 from github/nora/polish-code-search-copy
...
Code search: Use correct link and text
2023-06-12 07:44:25 +02:00
Koen Vlaswinkel
bca8e8fdb9
Merge pull request #2503 from github/koesie10/move-interface
...
Move interface.ts to local-queries/results-view.ts
2023-06-09 17:11:51 +02:00
Koen Vlaswinkel
5259456fe8
Merge pull request #2502 from github/koesie10/move-interface-utils
...
Move interface-utils to local-queries/webview
2023-06-09 17:11:39 +02:00
Robert
adc64c37c5
Merge pull request #2498 from github/robertbrignull/queries-panel-codeowners
...
Mark the queries panel as owned by secexp
2023-06-09 15:27:29 +01:00
Koen Vlaswinkel
2f1a3e95bf
Move interface.ts to local-queries/results-view.ts
2023-06-09 16:24:32 +02:00
Koen Vlaswinkel
00b32376d5
Move interface-utils to local-queries/webview
2023-06-09 16:20:30 +02:00
Koen Vlaswinkel
dfef8104c8
Merge pull request #2485 from github/koesie10/move-location-utils
...
Move functions for resolving locations
2023-06-09 15:59:48 +02:00
Nora
f0a8f79c2e
Use correct link and test
2023-06-09 13:25:39 +00:00
Charis Kyriakou
d485ff0015
Deal with no predictions gracefully ( #2499 )
2023-06-09 13:17:26 +01:00
Robert
7b5fb5b3aa
Mark the queries panel as owned by secexp
2023-06-09 10:49:32 +01:00
Robert
eb938034fb
Pass in just the environment instead of full app
2023-06-09 10:26:50 +01:00
Robert
a19c40bd66
Avoid using app.createEventEmitter
2023-06-09 10:24:07 +01:00
Koen Vlaswinkel
6b8169c479
Merge pull request #2494 from github/dependabot/npm_and_yarn/extensions/ql-vscode/eslint-plugin-jest-dom-5.0.1
...
Bump eslint-plugin-jest-dom from 4.0.2 to 5.0.1 in /extensions/ql-vscode
2023-06-09 11:19:26 +02:00
Koen Vlaswinkel
71ac6c73cd
Merge pull request #2496 from github/dependabot/npm_and_yarn/extensions/ql-vscode/xml2js-and-vscode/vsce-and-azure/core-http-0.5.0
...
Bump xml2js, @vscode/vsce and @azure/core-http in /extensions/ql-vscode
2023-06-09 11:19:15 +02:00
Koen Vlaswinkel
8b3ca1035c
Merge pull request #2495 from github/koesie10/remove-xml2js-types
...
Remove `@types/xml2js` dependency
2023-06-09 11:18:51 +02:00
Robert
f0cf4a0105
Remove onDidChangeWorkspaceFolders from app
2023-06-09 10:18:22 +01:00
Robert
1bd78649e7
Remove workspaceFolders from app
2023-06-09 09:57:23 +01:00
dependabot[bot]
f2ab949417
Bump xml2js, @vscode/vsce and @azure/core-http in /extensions/ql-vscode
...
Bumps [xml2js](https://github.com/Leonidas-from-XIV/node-xml2js ) to 0.5.0 and updates ancestor dependencies [xml2js](https://github.com/Leonidas-from-XIV/node-xml2js ), [@vscode/vsce](https://github.com/Microsoft/vsce ) and [@azure/core-http](https://github.com/Azure/azure-sdk-for-js ). These dependencies need to be updated together.
Updates `xml2js` from 0.4.23 to 0.5.0
- [Commits](https://github.com/Leonidas-from-XIV/node-xml2js/commits/0.5.0 )
Updates `@vscode/vsce` from 2.15.0 to 2.19.0
- [Release notes](https://github.com/Microsoft/vsce/releases )
- [Commits](https://github.com/Microsoft/vsce/compare/v2.15.0...v2.19.0 )
Updates `@azure/core-http` from 2.2.7 to 2.3.2
- [Release notes](https://github.com/Azure/azure-sdk-for-js/releases )
- [Changelog](https://github.com/Azure/azure-sdk-for-js/blob/main/documentation/Changelog-for-next-generation.md )
- [Commits](https://github.com/Azure/azure-sdk-for-js/compare/@azure/core-http_2.2.7...@azure/core-http_2.3.2 )
---
updated-dependencies:
- dependency-name: xml2js
dependency-type: indirect
- dependency-name: "@vscode/vsce"
dependency-type: direct:development
- dependency-name: "@azure/core-http"
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-09 08:44:18 +00:00
Koen Vlaswinkel
7869225cf1
Remove @types/xml2js
...
We don't seem to be using this dependency anymore, so we can remove it.
2023-06-09 10:38:19 +02:00
Koen Vlaswinkel
95828cdc61
Add @testing-library/dom as devDependency
2023-06-09 10:35:05 +02:00
Andrew Eisenberg
afb490b64b
Merge pull request #2441 from github/RasmusWL/codeql-executable-wording
...
Expand description for `codeQL.cli.executablePath`
2023-06-09 01:19:09 -07:00
dependabot[bot]
c3299f92c4
Bump eslint-plugin-jest-dom from 4.0.2 to 5.0.1 in /extensions/ql-vscode
...
Bumps [eslint-plugin-jest-dom](https://github.com/testing-library/eslint-plugin-jest-dom ) from 4.0.2 to 5.0.1.
- [Release notes](https://github.com/testing-library/eslint-plugin-jest-dom/releases )
- [Commits](https://github.com/testing-library/eslint-plugin-jest-dom/compare/v4.0.2...v5.0.1 )
---
updated-dependencies:
- dependency-name: eslint-plugin-jest-dom
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-08 13:58:25 +00:00
Koen Vlaswinkel
dc9f648452
Merge pull request #2470 from github/dependabot/npm_and_yarn/extensions/ql-vscode/faker-js/faker-8.0.2
...
Bump @faker-js/faker from 7.5.0 to 8.0.2 in /extensions/ql-vscode
2023-06-08 14:52:15 +02:00
Shati Patel
ee11805060
Update changelog (MRVA -> variant analysis) ( #2492 )
2023-06-08 12:47:59 +00:00
Koen Vlaswinkel
a24f640dc0
Replace faker.datatype.hexadecimal by faker.string.hexadecimal
2023-06-08 13:47:03 +02:00
Koen Vlaswinkel
4d2a935e80
Merge pull request #2469 from github/dependabot/npm_and_yarn/extensions/ql-vscode/css-loader-6.8.1
...
Bump css-loader from 3.1.0 to 6.8.1 in /extensions/ql-vscode
2023-06-08 12:57:59 +02:00
Koen Vlaswinkel
bbffc16b64
Replace faker.random.word by faker.word.sample
2023-06-08 12:50:42 +02:00
Koen Vlaswinkel
a4f90b7197
Replace faker.datatype.number by faker.number.int
2023-06-08 12:48:48 +02:00
Charis Kyriakou
286018ccea
Colour draft modeled methods with orange ( #2491 )
2023-06-08 11:33:51 +01:00
Koen Vlaswinkel
d2df162afd
Switch to Webpack asset modules
...
css-loader 6 deprecates the use of `file-loader`. As a replacement,
we can use asset modules which generates very similar results. This is a
fairly simple change, and this makes fonts work again.
See: https://github.com/webpack-contrib/css-loader/releases/tag/v6.0.0
See: https://webpack.js.org/guides/asset-modules/
2023-06-08 11:38:20 +02:00
dependabot[bot]
a73c39a29a
Bump css-loader from 3.1.0 to 6.8.1 in /extensions/ql-vscode
...
Bumps [css-loader](https://github.com/webpack-contrib/css-loader ) from 3.1.0 to 6.8.1.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases )
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v3.1.0...v6.8.1 )
---
updated-dependencies:
- dependency-name: css-loader
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-08 09:31:26 +00:00
dependabot[bot]
5113b04b36
Bump @faker-js/faker from 7.5.0 to 8.0.2 in /extensions/ql-vscode
...
Bumps [@faker-js/faker](https://github.com/faker-js/faker ) from 7.5.0 to 8.0.2.
- [Release notes](https://github.com/faker-js/faker/releases )
- [Changelog](https://github.com/faker-js/faker/blob/next/CHANGELOG.md )
- [Commits](https://github.com/faker-js/faker/compare/v7.5.0...v8.0.2 )
---
updated-dependencies:
- dependency-name: "@faker-js/faker"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-08 09:30:06 +00:00
Koen Vlaswinkel
8db5c6de65
Merge pull request #2488 from github/koesie10/fix-locale-lower-case
...
Add locale to `toLocaleLowerCase` calls
2023-06-08 11:14:07 +02:00
Koen Vlaswinkel
a46a8d06ec
Merge pull request #2489 from github/koesie10/add-cli-tests-timeout
...
Add timeout to CLI tests
2023-06-08 09:45:30 +02:00
Koen Vlaswinkel
3569c77626
Add timeout to CLI tests
...
It seems like some CLI tests are hanging and only completing after 6
hours when they run into the default timeout. This updates the timeout
to 30 minutes. All CLI tests should complete in 30 minutes, so this
should ensure that they are cancelled when they are stuck.
2023-06-07 15:41:42 +02:00
Koen Vlaswinkel
0b22a6f34d
Add locale to toLocaleLowerCase calls
2023-06-07 14:51:03 +02:00
Anders Starcke Henriksen
7c47a99805
Merge pull request #2486 from github/starcke/candidate-selection
...
Tweak candidate selection
2023-06-07 14:16:50 +02:00
Anders Starcke Henriksen
15c2a86725
Use Argument[this] instead of Argument[-1]
2023-06-07 13:14:31 +02:00
Anders Starcke Henriksen
e14b4c3040
Update extensions/ql-vscode/src/data-extensions-editor/auto-model.ts
...
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com >
2023-06-07 11:56:46 +02:00
Anders Starcke Henriksen
e3f192b76d
Add new test.
2023-06-07 11:24:06 +02:00
Anders Starcke Henriksen
222c0d72bd
Update tests.
2023-06-07 11:24:06 +02:00
Anders Starcke Henriksen
895c22ea85
Fix supported.
2023-06-07 11:24:02 +02:00
Nora
805d71286f
Merge pull request #2487 from github/version/bump-to-v1.8.6
...
Bump version to v1.8.6
2023-06-07 10:18:17 +02:00
github-actions[bot]
2e01836f55
Bump version to v1.8.6
2023-06-06 15:16:08 +00:00
Koen Vlaswinkel
bca8885513
Merge pull request #2484 from github/koesie10/move-webview-html
...
Move Webview HTML generation out of `interface-utils.ts`
2023-06-06 17:14:09 +02:00
Anders Starcke Henriksen
76fb55f918
Tweak candidate selection:
...
- At most 6 usages.
- Send -1 for `this` argument.
- Do not send only some arguments for candidate or sample.
2023-06-06 16:49:50 +02:00
Nora
999b24a40d
Merge pull request #2466 from github/v1.8.5
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.8.5
2023-06-06 15:15:28 +02:00
Nora
e612c8efcc
Update Changelog
2023-06-06 12:23:36 +00:00
Koen Vlaswinkel
ba9f5e35cb
Remove dependency on interface types from jumpToLocation
2023-06-06 11:27:57 +02:00
Koen Vlaswinkel
aa87fa8cda
Move functions for resolving locations
2023-06-06 11:25:43 +02:00
Koen Vlaswinkel
a98e31fffb
Merge pull request #2483 from github/koesie10/fix-locale-compare
...
Fix remaining `localeCompare` without locale set
2023-06-06 11:14:28 +02:00
Koen Vlaswinkel
461ff9bd21
Move Webview HTML generation out of interface-utils.ts
...
This moves the Webview HTML generation used by `AbstractWebview` out of
`interface-utils.ts` and into a new file `webview-html.ts` in the
`common/vscode` directory.
2023-06-06 11:12:05 +02:00
Koen Vlaswinkel
a678f8b3bc
Fix remaining localeCompare without locale set
2023-06-06 10:55:15 +02:00
Nora
cc9fb826b3
v1.8.5
2023-06-06 08:48:01 +00:00
Nora
a7a24fc0e9
Merge pull request #2476 from github/nora/use-code-search-api
...
Code search: use code search api
2023-06-06 10:29:43 +02:00
Koen Vlaswinkel
10bd774bcb
Merge pull request #2479 from github/koesie10/validate-scoped-pack-name
...
Only allow scoped extension pack names
2023-06-06 10:09:11 +02:00
Robert
ead138ee13
Merge pull request #2480 from github/robertbrignull/app-environment
...
Add EnvironmentContext so common code can do localisation
2023-06-06 08:44:12 +01:00
Nora
945594d47a
Adjust error response wording
2023-06-05 15:55:18 +00:00
Nora
876b92aa98
Move code search api call to its own file
2023-06-05 15:42:10 +00:00
Nora
b47006129d
Move octokit initialization to db panel to send log messages to the user
2023-06-05 15:42:10 +00:00
Nora
fef28806b1
Use showAndLogWarning to surface rateLimit
2023-06-05 15:42:10 +00:00
Nora
5467c50395
Implement throttling
2023-06-05 15:42:10 +00:00
Nora
6da1f936dd
Add no-language option
2023-06-05 15:42:10 +00:00
Robert
b722fb4d70
Convert to using a getter for AppEnvironmentContext.language
2023-06-05 14:04:27 +01:00
Nora
9672a0b1f1
Merge pull request #2478 from github/nora/code-search-feature-flag
...
Protect codeSearch feature for now
2023-06-05 14:33:09 +02:00
Robert
0e65c79c92
Pass in app.environment instead of vscode.env
2023-06-05 13:27:17 +01:00
Nora
897ad5bb57
Add 'codeSearch' feature flag
2023-06-05 11:55:50 +00:00
Robert
1d80cbb496
Add EnvironmentContext to App
2023-06-05 11:50:50 +01:00
Koen Vlaswinkel
b0d45cefe9
Only allow scoped extension pack names
...
When packaging an extension pack, unscoped extension pack names are not
allowed and calling `codeql pack bundle` will fail with an error. This
command will be called when running a variant analysis, so these packs
will not work for a variant analysis.
To improve the user experience, we now only allow scoped extension pack
names. This means that the user will now have to enter a scope when
creating a new extension pack.
2023-06-05 12:30:20 +02:00
Shati Patel
af9af99f09
Queries panel: display the query language in the UI ( #2472 )
2023-06-05 11:07:59 +01:00
Koen Vlaswinkel
0d390aa984
Merge pull request #2468 from github/koesie10/remove-ignore-source-archive-option
...
Remove `ignoreSourceArchive` option from databases
2023-06-05 09:41:14 +02:00
Andrew Eisenberg
610a349f26
Merge pull request #2405 from Marcono1234/simpler-location-url
...
Simplify location URLs if start and end line are the same
2023-06-02 11:07:07 -07:00
Andrew Eisenberg
afbf762d22
Merge branch 'main' into simpler-location-url
2023-06-02 10:47:23 -07:00
Charis Kyriakou
c96fd817b3
Allow unclassified methods to be marked as neutral ( #2477 )
2023-06-02 15:08:29 +00:00
Charis Kyriakou
134c4405f9
Handle 429 from auto-model service ( #2474 )
2023-06-02 12:51:40 +00:00
Koen Vlaswinkel
7250e82055
Merge pull request #2421 from github/koesie10/data-extension-editor-provenance
...
Add provenance support to data extensions editor
2023-06-02 14:13:40 +02:00
Koen Vlaswinkel
4ef520dc10
Merge pull request #2407 from github/koesie10/query-language
...
Use `QueryLanguage` type for representing query languages
2023-06-02 14:13:04 +02:00
Koen Vlaswinkel
cae72396d3
Merge pull request #2416 from github/koesie10/resolve-data-extensions-editor-queries
...
Resolve queries instead of hardcoding the path
2023-06-02 13:45:55 +02:00
Koen Vlaswinkel
e7ef449874
Add support for auto-model provenance
2023-06-02 12:21:04 +02:00
Koen Vlaswinkel
1cc77c0a26
Merge remote-tracking branch 'origin/main' into koesie10/data-extension-editor-provenance
2023-06-02 12:09:23 +02:00
Koen Vlaswinkel
c1edd08662
Remove unnecessary export on resolveQueries
2023-06-02 12:07:41 +02:00
Koen Vlaswinkel
96a28100b7
Merge remote-tracking branch 'origin/main' into koesie10/resolve-data-extensions-editor-queries
2023-06-02 12:06:18 +02:00
Koen Vlaswinkel
98844769a9
Merge remote-tracking branch 'origin/main' into koesie10/query-language
2023-06-02 12:03:16 +02:00
Nora
12615f19f8
Merge pull request #2473 from github/nora/move-cached-operation-to-common
...
Move CachedOperation to language-support contextual
2023-06-02 11:34:22 +02:00
Nora
b2adbf63eb
Move file to language-support/contextual
2023-06-02 08:33:09 +00:00
Koen Vlaswinkel
f115412cec
Merge branch 'main' into koesie10/remove-ignore-source-archive-option
2023-06-02 10:16:34 +02:00
Koen Vlaswinkel
26d27f832e
Merge pull request #2467 from github/koesie10/fix-neutral-definition
...
Fix neutral definition for CodeQL 2.13.3
2023-06-02 09:46:39 +02:00
Andrew Eisenberg
f5c96025cb
Merge pull request #2461 from aibaars/selected-line-column
...
View CFG: export selected line and column position
2023-06-01 10:15:54 -07:00
Andrew Eisenberg
51be504f6d
Merge branch 'main' into selected-line-column
2023-06-01 08:07:18 -07:00
Koen Vlaswinkel
831b2499a2
Merge branch 'main' into koesie10/fix-neutral-definition
2023-06-01 16:59:31 +02:00
github-actions[bot]
cf343785a7
Bump CLI version from v2.13.1 to v2.13.3 for integration tests ( #2465 )
...
Co-authored-by: github-actions[bot] <github-actions@github.com >
2023-06-01 15:57:18 +01:00
Koen Vlaswinkel
0e47709d10
Remove ignoreSourceArchive option from databases
...
This option was used to ignore source archives for `.testproj`
databases. It is only set to `true` or `false` when creating the
database and could not be changed, so I don't think we need this option.
It can simply be derived from the database URI. This simplifies handling
of databases a bit.
2023-06-01 15:32:30 +02:00
Koen Vlaswinkel
2b915b82e4
Fix neutral definition for CodeQL 2.13.3
...
In CodeQL 2.13.3, the definition of the neutralModel predicate has
changed to include the `kind`. This updates the definition of the
data extensions editor to match the new definition.
One caveat is that when selecting a `kind` other than `summary`, the
method will not be shown as supported. This is because a
`NeutralCallable` only calls into `neutralSummaryElement`. This matches
the previous behavior because setting the `kind` to `source` or `sink`
only says that the method is either not a source or not a sink, but not
both. Only `summary` fully models the method.
See: https://github.com/github/codeql/pull/12931
See: ff78ac98d2/java/ql/lib/semmle/code/java/dataflow/internal/FlowSummaryImpl.qll (L338)
See: ff78ac98d2/java/ql/lib/semmle/code/java/dataflow/internal/FlowSummaryImplSpecific.qll (L160)
2023-06-01 14:59:47 +02:00
Koen Vlaswinkel
2f61cfe693
Merge pull request #2457 from github/koesie10/auto-model-usages-sarif
...
Retrieve external API usage snippets using SARIF
2023-06-01 11:28:42 +02:00
Shati Patel
5387546e93
Don't log the resolve queries CLI command ( #2454 )
2023-06-01 09:49:35 +01:00
Koen Vlaswinkel
dd268af9e9
Use type in auto model usages query file
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2023-06-01 10:47:16 +02:00
Robert
bc342022cb
Merge pull request #2464 from github/robertbrignull/invocation-rate-limiter
...
Move the invocation rate limiter class out of helpers.ts
2023-05-31 16:45:17 +01:00
Robert
50c46b603a
Remove MockGlobalStorage
2023-05-31 16:21:28 +01:00
Nora
157210ffc5
Merge pull request #2439 from github/nora/search-prompt
...
Feed code search results into variant analysis repo lists
2023-05-31 17:08:44 +02:00
Robert
0b6bcfdfd6
Merge pull request #2459 from github/robertbrignull/discovery-logging
...
Avoid vscode reference rfom discovery.ts
2023-05-31 15:12:43 +01:00
Robert
9b84e0f831
"Fix" distribution tests
2023-05-31 14:59:23 +01:00
Robert
e7a5def15f
Merge pull request #2462 from github/robertbrignull/cached-operation
...
Move CachedOperation to a new file
2023-05-31 14:55:52 +01:00
Robert
1f6d8f215e
Merge branch 'main' into robertbrignull/discovery-logging
2023-05-31 14:53:56 +01:00
Koen Vlaswinkel
c017530410
Fix incorrect order in BQRS unit test
2023-05-31 15:20:53 +02:00
Koen Vlaswinkel
c654bfa4c4
Add some comments for the auto model usages query
2023-05-31 15:20:53 +02:00
Koen Vlaswinkel
bce097d939
Create type for usage snippets by signature
2023-05-31 15:20:53 +02:00
Koen Vlaswinkel
1920a2c6b4
Remove use of Pick in auto model usages query
2023-05-31 15:20:53 +02:00
Robert
00bd7b7d3e
Merge pull request #2458 from github/robertbrignull/common-vscode
...
Make assert-pure.ql ignore all /vscode/ directories
2023-05-31 14:09:39 +01:00
Robert
6b4726bc2b
Move InvocationRateLimiter to common
2023-05-31 13:47:59 +01:00
Robert
79dccaa12f
Pass in a Memento instead of a full ExtensionContext
2023-05-31 13:47:59 +01:00
Robert
b9c0f2bc14
Move InvocationRateLimiter to a separate file
2023-05-31 13:47:59 +01:00
Arthur Baars
7c47cf0968
View CFG: export selected line and column position
...
Fixes : #2456
2023-05-31 14:30:37 +02:00
Robert
d30e58b2cb
Merge pull request #2453 from github/robertbrignull/refresh-promise
...
Add ability to await the discovery refresh promise
2023-05-31 13:29:35 +01:00
Nora
0739c46fed
Add comments to gh api client and fix total number of returned repos
2023-05-31 11:30:31 +00:00
Nora
42436e623b
Add JSDoc to db config store
2023-05-31 11:30:00 +00:00
Robert
8badc1c407
Merge pull request #2460 from github/robertbrignull/selection-commond-vscode
...
Move selection-commands.ts to be in the vscode directory
2023-05-31 12:27:17 +01:00
Robert
56d6f19365
Move CachedOperation to a new file
2023-05-31 11:57:26 +01:00
Koen Vlaswinkel
a4d875af8d
Fix typo
2023-05-31 12:33:51 +02:00
Robert
b7a7329aff
Move selection-commands.ts to be in the vscode directory
2023-05-31 11:33:12 +01:00
Koen Vlaswinkel
a117e09796
Use a single SARIF-compatible query instead of two separate queries
2023-05-31 12:32:41 +02:00
Robert
a4a67856a5
Avoid vscode reference rfom discovery.ts
2023-05-31 11:26:25 +01:00
Robert
b8b378ffd4
Make assert-pure.ql ignore all /vscode/ directories
2023-05-31 10:59:50 +01:00
Robert
a0e6317559
Keep all updates of currentDiscoveryPromise in refresh
2023-05-31 10:45:36 +01:00
Robert
d2bb1b844e
Fix comment to be more accurate
2023-05-31 10:45:36 +01:00
Robert
82766d1033
Rename: getCurrentRefreshPromise => waitForCurrentRefresh
2023-05-31 10:45:32 +01:00
Robert
81fb1264e4
Merge pull request #2455 from github/robertbrignull/import-path-problem
...
Expand assert-pure.ql to cover common and be a path-problem query
2023-05-31 09:15:54 +01:00
Nora
4087620bf5
Polish copy
2023-05-30 14:30:07 +00:00
Alexander Eyers-Taylor
22172d5d74
Add support for quick eval count to the query runner ( #2417 )
...
* Add support for quick eval count to the query runner
This only adds support internally to the query runner,
without any UI support.
* Fix some tests
2023-05-30 14:12:47 +01:00
Alexander Eyers-Taylor
af3be543f5
Cache MRVA queries correctly ( #2435 )
2023-05-30 14:12:26 +01:00
Koen Vlaswinkel
5c81671e67
Retrieve external API usage snippets using SARIF
2023-05-30 13:46:14 +02:00
Robert
c462bc0243
Use edges from select clause
2023-05-30 11:42:36 +01:00
Robert
e1894afb16
Extend ImportDeclaration instead of AstNode
2023-05-30 11:39:47 +01:00
Koen Vlaswinkel
5a66d6ff2d
Merge pull request #2448 from github/koesie10/auto-model
...
Add initial implementation of auto-modeling
2023-05-30 12:19:22 +02:00
Koen Vlaswinkel
d27f3d2699
Remove incorrect explanations
2023-05-30 11:21:01 +02:00
Koen Vlaswinkel
695dc3f883
Improve sorting of input/output arguments
2023-05-30 11:17:52 +02:00
Koen Vlaswinkel
558f51b962
Add comment to parsePredictedClassifications method
2023-05-30 11:04:13 +02:00
Koen Vlaswinkel
2e29d0cda4
Fix incorrect signature reconstruction
2023-05-30 10:04:33 +02:00
Andrew Eisenberg
3b4f236426
Merge pull request #2440 from JarLob/patch-1
...
Retry results download if connection times out
2023-05-26 11:31:31 -07:00
Robert
b8770a2896
Convert assert-pure.ql to be a path-problem query
2023-05-26 16:28:40 +01:00
Andrew Eisenberg
e24377f9f3
Merge pull request #2446 from github/aeisenberg/use-orig-pack-name
...
Use the original pack name for generated pack
2023-05-26 08:12:01 -07:00
Andrew Eisenberg
deb268465f
Fix failing test
2023-05-26 07:52:49 -07:00
Koen Vlaswinkel
f52ad04afe
Improve parsing of predicted classifications
2023-05-26 16:18:59 +02:00
Koen Vlaswinkel
4b54e4f31f
Use 20 candidates and 100 samples
2023-05-26 13:40:12 +02:00
Robert
1f4b19cd37
Add getCurrentRefreshPromise
2023-05-26 10:15:14 +01:00
Robert
9dd7476c90
Use refresh promise in tests
2023-05-26 10:15:14 +01:00
Robert
5405b1bf29
Convert refresh to return a promise
2023-05-26 10:15:13 +01:00
Robert
5a2cb8bc41
Convert launchDiscovery to use async
2023-05-26 10:14:19 +01:00
Robert
35a7eee3c0
Merge pull request #2449 from github/robertbrignull/queries-welcome
...
Add welcome text for the queries panel
2023-05-25 17:01:13 +01:00
Andrew Eisenberg
efabcaefe3
Update extensions/ql-vscode/src/variant-analysis/run-remote-query.ts
...
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com >
2023-05-25 08:30:24 -07:00
Robert
a27b0a469e
Merge pull request #2447 from github/robertbrignull/QueryDiscovery-tests
...
Add integration tests of QueryDiscovery
2023-05-25 16:19:37 +01:00
Robert
472b1769c5
Update extensions/ql-vscode/test/vscode-tests/minimal-workspace/queries-panel/query-discovery.test.ts
...
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com >
2023-05-25 15:38:49 +01:00
Koen Vlaswinkel
7bbba38cfb
Merge pull request #2450 from github/koesie10/move-database-item-refresh
...
Extract `DatabaseItem.refresh` method to `DatabaseManager`
2023-05-25 16:32:01 +02:00
Koen Vlaswinkel
adcc3d0b39
Remove unnecessary if-statements before slice
2023-05-25 15:52:00 +02:00
Robert
8be2dd805b
Use path.sep
2023-05-25 14:44:05 +01:00
Koen Vlaswinkel
09fc0f3040
Extract DatabaseItem.refresh to DatabaseManager
...
This moves the `refresh` method from `DatabaseItem` to `DatabaseManager`
and makes it private. This makes the `DatabaseItem` interface smaller
and more focused and ensures that `refresh` cannot be called from
outside of the `DatabaseManager`.
2023-05-25 15:03:30 +02:00
Koen Vlaswinkel
295a08f85a
Use DatabaseItemImpl where possible in DatabaseManager
...
This will allow us to implement specific behavior on the
`DatabaseItemImpl` which is not available on the `DatabaseItem`. This
will allow us to make the surface area of the `DatabaseItem` smaller.
2023-05-25 14:36:38 +02:00
Robert
394b51f4f3
Add welcome text
2023-05-25 12:49:01 +01:00
Koen Vlaswinkel
a88e683ebf
Add initial implementation of auto-modeling
2023-05-25 13:28:32 +02:00
Nora
250089a9e3
Renaming and smaller merge comments
2023-05-25 10:02:22 +00:00
Nora
2e12b8d756
Rename command from importCodeSearch to importFromCodeSearch
2023-05-25 09:11:37 +00:00
Robert
f236e65f68
Add integration tests of QueryDiscovery
2023-05-25 09:57:52 +01:00
Robert
301149fd32
Don't create array entry if workspace contains no queries
2023-05-25 09:57:52 +01:00
Koen Vlaswinkel
b8557d337c
Merge pull request #2445 from github/koesie10/move-local-databases
...
Split up `local-databases.ts` file into multiple files
2023-05-25 09:30:23 +02:00
Andrew Eisenberg
b4506cf6e5
Use the original pack name for generated pack
...
Generated variant analysis packs will use the original name
of the pack that the query is located in. This is to support
some future work where we do extra validation of data extensions.
If the query is not in a pack, the default name is used.
2023-05-24 21:46:54 +00:00
Nora
49f3f5673d
Show progress information when sending search api request
2023-05-24 16:26:08 +00:00
Robert
ff88a8d491
Merge pull request #2444 from github/robertbrignull/QueryTreeDataProvider-tests
...
Add tests of QueryTreeDataProvider
2023-05-24 16:25:08 +01:00
Koen Vlaswinkel
0707155603
Fix imports for tests
2023-05-24 17:08:00 +02:00
Koen Vlaswinkel
c004f18720
Remove outdated comment
2023-05-24 17:04:36 +02:00
Koen Vlaswinkel
6b9c3491ec
Move local-databases.ts to local-databases/index.ts
2023-05-24 17:04:14 +02:00
Koen Vlaswinkel
d608c057a4
Remove unused getUpgradesDirectories function
2023-05-24 17:03:14 +02:00
Koen Vlaswinkel
60cfc311e5
Move DatabaseManager to separate file
2023-05-24 17:02:39 +02:00
Koen Vlaswinkel
59482c2b2c
Move DatabaseChangedEvent to separate file
2023-05-24 17:00:52 +02:00
Koen Vlaswinkel
7888d210c4
Move DatabaseResolver to separate file
2023-05-24 16:58:29 +02:00
Koen Vlaswinkel
67983c64ca
Move DatabaseContents to separate file
2023-05-24 16:55:31 +02:00
Koen Vlaswinkel
d02e53fbd2
Move DatabaseItemImpl to separate file
2023-05-24 16:53:59 +02:00
Koen Vlaswinkel
4bb4627d30
Move DatabaseItem to separate file
2023-05-24 16:52:53 +02:00
Koen Vlaswinkel
6331cddbfd
Move DatabaseOptions to separate file
2023-05-24 16:51:38 +02:00
Robert
5d7a7237a3
Merge pull request #2443 from github/robertbrignull/query-constructor
...
Remove member variables that could be local variables
2023-05-24 14:34:06 +01:00
Nora
2b4e302e29
Surface truncated repos when a list hits 1000 items
2023-05-24 10:58:13 +00:00
Nora
d07b7c8c05
Add db manager test
2023-05-24 10:57:13 +00:00
Robert
27a88032f7
Add QueryTreeDataProvider tests
2023-05-24 11:42:23 +01:00
Robert
b9ce91cff9
Add a QueryDiscoverer interface to make testing QueryTreeDataProvider easier
2023-05-24 11:42:23 +01:00
Robert
9dee2a132e
Remove member variables that could be local variables
2023-05-24 10:37:22 +01:00
jarlob
69f9ecc2f4
Delete unfinished downloads in case of retry
2023-05-24 11:25:50 +02:00
jarlob
9bd852a71b
Add error message to logging.
2023-05-24 11:20:52 +02:00
Shati Patel
7ef35af68a
Don't create "." directory in queries/tests tree view ( #2442 )
2023-05-24 10:15:34 +01:00
Nora
dd01832ebe
Add no more than 1000 items to a list plus tests
2023-05-24 08:06:31 +00:00
Nora
f76d7bfd96
Use pagination for code search api call
2023-05-24 08:05:30 +00:00
Jaroslav Lobačevski
6f6c229ca3
Update extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts
2023-05-23 23:24:18 +02:00
jarlob
65cfd851f2
Add logging
2023-05-23 23:21:51 +02:00
jarlob
32fb4e5db6
Move max retry to a constant
2023-05-23 22:47:13 +02:00
Rasmus Wriedt Larsen
c82ba1bdff
Expand description for codeQL.cli.executablePath
...
To match what the code actually does.
2023-05-23 12:05:19 +02:00
Robert
f6b0ae2032
Merge pull request #2437 from github/robertbrignull/query-event-emitter
...
Use app.createEventEmitter in QueryDiscovery
2023-05-23 10:27:20 +01:00
Jaroslav Lobačevski
e964ce6713
Retry results download if connection times out
2023-05-23 10:51:46 +02:00
Robert
57f04fcae5
Add type to onDidChangeQueriesEmitter
2023-05-23 09:46:04 +01:00
Nora
4d9e8d98b4
Ask for user input and add response to list
2023-05-23 07:13:05 +00:00
Nora
fed6158615
Add GH client method to query search endpoint
2023-05-22 15:48:41 +00:00
Robert
da5d0d2a84
Use app.createEventEmitter in QueryDiscovery
2023-05-22 14:34:44 +01:00
Robert
73f359c0d0
Merge pull request #2434 from github/robertbrignull/disposable-event-emitter
...
Mark AppEventEmitter as disposable
2023-05-22 13:54:34 +01:00
Robert
f855d81526
Make sure DbManager is also disposed
2023-05-22 13:34:48 +01:00
Robert
73e41f8d61
Mark AppEventEmitter as disposable
2023-05-22 12:28:24 +01:00
Robert
018440f266
Merge pull request #2433 from github/robertbrignull/query-discovery
...
Hook queries panel up to real data
2023-05-22 11:51:25 +01:00
Koen Vlaswinkel
189a1328cd
Merge pull request #2428 from github/koesie10/unsupported-cli-version-check
...
Add warning when using unsupported CLI version
2023-05-22 12:49:52 +02:00
Robert
cda3483b01
Use getOnDiskWorkspaceFoldersObjects early instead of getting all folders and filtering later
2023-05-22 10:51:32 +01:00
Robert
78f11397e2
Exclude src archives and other non-normal workspace folders
2023-05-22 10:42:47 +01:00
Robert
935c9b996f
Don't include bad workspace roots in the list
2023-05-22 10:41:49 +01:00
Koen Vlaswinkel
e91e9d2654
Merge branch 'main' into koesie10/unsupported-cli-version-check
2023-05-22 11:37:58 +02:00
Koen Vlaswinkel
791a445342
Update copy of deprecation warning message
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2023-05-22 11:37:42 +02:00
Koen Vlaswinkel
4ea1bb5f1c
Merge pull request #2427 from github/koesie10/export-copy-selected-text
...
Update export/copy buttons copy when repositories are selected
2023-05-22 11:36:31 +02:00
Koen Vlaswinkel
8f3fe7412e
Merge branch 'main' into koesie10/export-copy-selected-text
2023-05-22 10:52:01 +02:00
Robert
4e46d87a77
Use name from file tree instead of calculating from path
2023-05-19 17:09:21 +01:00
Robert
a8f8990793
Hook query discovery results up to query panel
2023-05-19 17:09:21 +01:00
Robert
0a534ae360
Add QueryDiscovery class
2023-05-19 17:09:21 +01:00
Robert
13f8f19339
Add resolveQueries to CodeQL CLI
2023-05-19 17:09:21 +01:00
Robert
a3f2b7b1ca
Merge pull request #2431 from github/robertbrignull/app-workspace
...
Add workspace folders to App interface
2023-05-19 17:08:59 +01:00
Robert
6371356b4b
Merge pull request #2432 from github/robertbrignull/tree-node-shared
...
Pull out node classes to shared location
2023-05-19 17:06:24 +01:00
Robert
a7f6401be7
Add workspace folders to App interface
2023-05-19 15:28:04 +01:00
Robert
a5af2f2e4b
Pull out node classes to shared location
2023-05-19 13:04:58 +01:00
Andrew Eisenberg
3ebd13df57
Merge pull request #2425 from github/aeisenberg/truncated-log-msg
...
Ensure full stack traces are included in log messages
2023-05-17 08:51:35 -07:00
Koen Vlaswinkel
d28ee6dbf1
Merge branch 'main' into koesie10/unsupported-cli-version-check
2023-05-17 17:12:23 +02:00
Andrew Eisenberg
4ad3f7cb1f
Merge branch 'main' into aeisenberg/truncated-log-msg
2023-05-17 08:08:34 -07:00
Andrew Eisenberg
0f1f00dfc8
Merge pull request #2424 from github/aeisenberg/update-changelog
...
Update changelog
2023-05-17 08:08:07 -07:00
Koen Vlaswinkel
3e9b4273c3
Update CHANGELOG
2023-05-17 16:55:11 +02:00
Robert
b47f018b69
Merge pull request #2426 from github/robertbrignull/open-on-click
...
Open query file on click
2023-05-17 15:54:11 +01:00
Koen Vlaswinkel
5a7f5c2ff1
Update CHANGELOG
2023-05-17 16:46:35 +02:00
Koen Vlaswinkel
ee2d78fbfc
Add warning when using unsupported CLI version
...
This adds a warning when the user is using an unsupported version of the
CodeQL CLI. The warning is shown once per session, and only if the
version is older than the oldest supported version.
2023-05-17 16:25:06 +02:00
shati-patel
565a7a53e0
Only implement "open file" when you click a file node (not a folder)
2023-05-17 14:43:43 +01:00
Koen Vlaswinkel
0125d10ffb
Take filtered state into account for buttons text
...
When the user filters the repositories, the buttons should reflect that
the results are filtered and that the user is not exporting or copying
all the results. If the user has selected repositories, the buttons
should still say that they are exporting selected results.
2023-05-17 15:08:55 +02:00
Koen Vlaswinkel
fa39bd1c2c
Update export/copy buttons copy when repositories are selected
...
This changes the text of the export/copy buttons on a variant analysis
when at least one repository is selected. This makes it more clear that
the user is only exporting/copying the results of the selected
repositories.
2023-05-17 15:03:28 +02:00
Nora
1955086cb6
Add new command and add it to db panel
2023-05-17 12:11:45 +00:00
Robert
ec1fda21d0
Open query file on click
2023-05-17 12:16:09 +01:00
Robert
baea36561d
Merge pull request #2423 from github/robertbrignull/query-tree-types
...
Simplify types around query panel
2023-05-17 10:39:43 +01:00
Andrew Eisenberg
55b65e33ad
Update changelog
2023-05-16 14:51:03 -07:00
Andrew Eisenberg
276e2cfdcf
Ensure full stack traces are included in log messages
...
Pass in the `fullMessage` to `internalShowAndLog` so that stack traces
aren't truncated.
2023-05-16 14:48:19 -07:00
Andrew Eisenberg
91c58f3618
Update changelog
...
For #2422 .
2023-05-16 12:32:29 -07:00
Robert
1ceccc8b4d
Avoid double-declaring fields that are inherited from TreeItem
2023-05-16 16:57:02 +01:00
Robert
b0371b5075
Simplify types on TreeDataProvider methods
2023-05-16 16:55:52 +01:00
Shati Patel
9ce95a3554
Queries panel: Expand/collapse child nodes ( #2419 )
2023-05-16 15:45:59 +00:00
Andrew Eisenberg
1dc83c5628
Merge pull request #2422 from github/aeisenberg/compare-view-quick-eval
...
Allow compare view to work with quick-eval
2023-05-16 08:41:12 -07:00
Koen Vlaswinkel
d00624cc85
Merge pull request #2420 from github/koesie10/cancel-monitor-on-404
...
Cancel monitoring variant analysis on 404 response
2023-05-16 11:57:26 +02:00
Koen Vlaswinkel
7d41cd7ae6
Rename editor-manual to manual
...
There is a defined list of of valid origin values for the provenance.
This does not include `editor`, so to make sure all values are valid we
use `manual` instead.
See ac1df4de91/java/ql/lib/semmle/code/java/dataflow/internal/FlowSummaryImpl.qll (L221-L229)
2023-05-16 10:23:21 +02:00
Andrew Eisenberg
4c33c06d55
Allow compare view to work with quick-eval
...
The compare view typically works by matching the results sets of
queries. It only allows the results sets of queries with identical
names to be compared.
Manually run queries use `#select` as the default result set. However,
quick eval queries use a different, generated, name. Therefore, these
two kinds of queries cannot be compared.
This commit changes the heuristics so that if there are no identical;y
named results sets, the first result set of each query that is prefixed
with `#` is used (this is the default result set).
It also makes a slightly nicer error message if there are no comparable
results sets.
2023-05-15 15:51:48 -07:00
Andrew Eisenberg
2d8c6905bf
Merge branch 'main' into simpler-location-url
2023-05-15 10:10:42 -07:00
Koen Vlaswinkel
dc3966e113
Add provenance support to data extensions editor
...
The data extensions editor was always setting the `provenance` field of
MaD to `manual`. This will change the `provenance` to be either
`editor-manual` (for models which were added by the user),
`df-generated` (for models generated by the dataflow generator), and
`df-manual` (for models generated and then edited). This makes it easier
to trace the origin of a model.
2023-05-15 17:05:35 +02:00
Koen Vlaswinkel
2d2a1fb2d1
Add tests for variant analysis monitor
2023-05-15 15:41:15 +02:00
Koen Vlaswinkel
5b9ed39f4f
Restart variant analysis monitor when reauthenticating
2023-05-15 15:08:32 +02:00
Koen Vlaswinkel
9e74ae0bbf
Cancel monitoring variant analysis on 404
2023-05-15 15:08:32 +02:00
Koen Vlaswinkel
927a0f0691
Track currently monitoring variant analyses
2023-05-15 14:50:13 +02:00
Shati Patel
e9552df395
Create a basic tree view for the queries panel ( #2418 )
2023-05-15 11:10:51 +00:00
Koen Vlaswinkel
0f3b36cf87
Resolve queries instead of hardcoding the path
...
This will change the data extensions editor generator to resolve the
queries based on the `modelgenerator` tag. This removes the requirement
of having a `ql` folder in the workspace.
I chose to use the path instead of the `id` for now to avoid having to
resolve the query 4 times. This also avoids the need to map the language
names to the language ID in the tag (i.e. `csharp` -> `cs`).
2023-05-11 15:02:43 +02:00
Alexander Eyers-Taylor
3e6372d6fa
Better error handling for unexpected query server termination. ( #2404 )
...
* Log stdout when servers are terminated with errors.
This logs the last stdout chunk (probabaly the last line) if things
went wrong. This can sometimes be useful for debugging.
It also prints the signal when killed by a signal
(rather than printing null)
* Restart/Abort the queryserver if the process dies.
This cancels any running tasks and gives a limited number of restarts.
* Update extensions/ql-vscode/src/codeql-cli/cli.ts
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
* Update extensions/ql-vscode/src/query-server/query-server-client.ts
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
---------
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2023-05-11 12:39:31 +01:00
Shati Patel
d0ca885e80
Move Discovery class into common folder ( #2414 )
2023-05-10 16:58:26 +00:00
Shati Patel
7fd984a7d0
Add a new blank "queries" panel ( #2412 )
2023-05-10 13:23:43 +01:00
Koen Vlaswinkel
00f4bc1fda
Merge pull request #2411 from github/koesie10/remove-deprecated-url-parse
...
Remove deprecated use of `url.parse`
2023-05-10 11:09:06 +02:00
Koen Vlaswinkel
7dfa6f0f58
Merge pull request #2408 from github/koesie10/replace-deprecated-storage-path
...
Replace deprecated `storagePath` by `storageUri`
2023-05-10 11:08:52 +02:00
Koen Vlaswinkel
8a75399cb7
Merge branch 'main' into koesie10/remove-deprecated-url-parse
2023-05-10 09:30:57 +02:00
Koen Vlaswinkel
6e5188fbbe
Replace Uri.parse by Uri.file
2023-05-10 09:30:53 +02:00
Koen Vlaswinkel
87be402a57
Improve unsupported language error message
2023-05-10 09:30:11 +02:00
Koen Vlaswinkel
ddbe3cdc2b
Add test cases for containsPath
2023-05-09 14:20:15 +02:00
Koen Vlaswinkel
9290f57b62
Use normalized path for checking inclusion
2023-05-09 14:20:15 +02:00
Koen Vlaswinkel
a414213804
Replace deprecated storagePath by storageUri
...
This replaces access to the deprecated `storagePath` and
`globalStoragePath` to use `storageUri` and `globalStorageUri` instead.
2023-05-09 14:20:15 +02:00
Andrew Eisenberg
3ad006de92
Merge pull request #2401 from github/github-action/bump-cli
...
Bump CLI Version to v2.13.1 for integration tests
2023-05-09 03:58:53 -07:00
Shati Patel
e722bf3e0b
Merge branch 'main' into github-action/bump-cli
2023-05-09 11:19:48 +01:00
Koen Vlaswinkel
9e7678de7a
Remove deprecated use of url.parse
...
`url.parse` is deprecated and should be replaced by the WHATWG URL API,
so this makes that change. The `protocol` and `host` properties are
unchanged, so no other changes are needed.
2023-05-09 10:15:58 +02:00
Nora
a4f1f49506
Merge pull request #2409 from github/nora/split-codeql-goto-commands
...
Split codeQL.goto and codeQL.previewQueryHelp command
2023-05-08 17:00:21 +02:00
Nora
6deb04bd26
Split codeQL.previewQueryHelp command
2023-05-08 12:27:12 +00:00
Nora
b6df591329
Split codeQL.goto command
2023-05-08 12:15:07 +00:00
Koen Vlaswinkel
b20a65a3a7
Use QueryLanguage type for representing query languages
...
This will make both the `askForLanguage` and `findLanguage` functions
return a `QueryLanguage` instead of a `string`. This will make it harder
to make mistakes when using these functions.
There are also some other changes with regards to `QueryLanguage` such
that we never need to use `as QueryLanguage` explicitly anymore, except
for the new `isQueryLanguage` function. The only remaining place that I
know of where we're using a `string` to represent the `QueryLanguage`
is in a database item's language, but this is harder to change and may
be relied upon by language authors.
2023-05-08 13:56:11 +02:00
Marcono1234
788eb2b663
Simplify location URLs if start and end line are the same
2023-05-07 19:54:49 +02:00
Andrew Eisenberg
5084b32152
Merge branch 'main' into github-action/bump-cli
2023-05-05 16:07:33 -07:00
Robert
bf9eb2469b
Merge pull request #2370 from github/robertbrignull/undefined_codeflows
...
Avoid crashing when SARIF file contains invalid thread flow locations
2023-05-05 17:43:58 +01:00
Robert
78c4cc17e9
Revert change to generation of blank lines
2023-05-05 17:19:07 +01:00
Andrew Eisenberg
62f44c9f56
Merge pull request #2403 from github/aeisenberg/fix-integration-tests
2023-05-05 07:24:53 -07:00
Andrew Eisenberg
e4a2760470
Run integration tests on 1.77.3
...
This avoids a bug on 1.78.0 on linux. See
https://github.com/github/vscode-codeql/issues/2402
2023-05-05 14:04:32 +00:00
github-actions[bot]
67bd603327
Bump CLI version from v2.13.0 to v2.13.1 for integration tests
2023-05-04 18:10:07 +00:00
Elena Tanasoiu
3a5a81a599
Merge pull request #2359 from github/yer-a-ternary-choice-query
...
Add configuration option to turn off skeleton pack generation
2023-05-04 08:53:17 +01:00
Robert
ecfa701159
Add tests of tryGetFilePath
2023-05-03 17:24:41 +01:00
Robert
a3a6784539
Rename to teyGetFilePath to fit other methods
2023-05-03 17:20:00 +01:00
Elena Tanasoiu
9515e3bdf8
Merge branch 'main' into yer-a-ternary-choice-query
2023-05-03 17:16:50 +01:00
Robert
e097bc13fa
Merge pull request #2400 from github/robertbrignull/test-plan
...
Update the test plan and add non-MRVA cases
2023-05-03 17:12:35 +01:00
Robert
b199d9485d
Merge branch 'main' into robertbrignull/undefined_codeflows
2023-05-03 17:11:31 +01:00
Elena Tanasoiu
cc8f1fd839
Merge branch 'main' into yer-a-ternary-choice-query
2023-05-03 16:08:37 +01:00
Elena Tanasoiu
a85d9d1434
Update comment
2023-05-03 15:07:24 +00:00
Shati Patel
71611e03fe
Add config options for default sorting/filtering values in variant analysis results view ( #2392 )
2023-05-03 14:52:35 +00:00
Robert
ff20bceaa8
Add test cases of non-MRVA areas
2023-05-03 15:21:08 +01:00
Robert
5edbb1e96c
Categorise test cases as mrva / local / general
2023-05-03 14:54:56 +01:00
Robert
bcd58181bf
List pre-release checks in the order you'll want to do them
2023-05-03 14:50:02 +01:00
Robert
0f5df90ee5
Add files via upload
2023-05-03 14:41:55 +01:00
Robert
992d8dd4be
Update MRVA tests in test-plan.md
2023-05-03 14:38:41 +01:00
Elena Tanasoiu
9ecb5035e0
Reduce options to "ask" and "never"
...
And update descriptions for them.
2023-05-03 12:14:23 +00:00
Robert
70a9ee6b1d
Merge pull request #2399 from github/version/bump-to-v1.8.5
...
Bump version to v1.8.5
2023-05-03 12:35:59 +01:00
Robert
c53bebd1ce
Merge pull request #2397 from github/robertbrignull/vscode-node-version
...
Add note about how to find VSCode node version
2023-05-03 12:21:55 +01:00
github-actions[bot]
ba9bfb57d1
Bump version to v1.8.5
2023-05-03 11:09:07 +00:00
Robert
ab9dd6a74f
Merge pull request #2398 from github/v1.8.4
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.8.4
2023-05-03 11:23:03 +01:00
Robert
1c2fc37175
Remove changelog entry for #2385
2023-05-03 11:07:23 +01:00
Robert
29dd24c733
Update extensions/ql-vscode/CHANGELOG.md
...
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com >
2023-05-03 11:05:26 +01:00
Robert
0f6714d9f6
Update extensions/ql-vscode/CHANGELOG.md
...
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com >
2023-05-03 11:05:14 +01:00
Robert
3102a177fb
v1.8.4
2023-05-03 10:41:14 +01:00
Robert
2111ba01ac
Add missing changelog entries
2023-05-03 10:40:33 +01:00
Robert
bb4060bcb6
Add note about how to find VSCode node version
2023-05-03 10:38:06 +01:00
Elena Tanasoiu
42320fcb87
Don't try to restore setting
2023-05-03 08:35:40 +00:00
Elena Tanasoiu
530ae689d3
Use strictly type choices for config setting
2023-05-03 07:58:35 +00:00
Elena Tanasoiu
c8b0b1c769
Use parent setting for "Create Query" config
2023-05-03 07:52:37 +00:00
Elena Tanasoiu
62597f1eb5
Remove extra space
2023-05-03 07:49:22 +00:00
Elena Tanasoiu
9c47a2718c
Remove "default" option
...
Since it's not defining a real option, we can get rid of it.
2023-05-03 07:35:49 +00:00
Robert
e8403cf5d2
Reject all file URIs
2023-05-02 17:08:52 +01:00
Robert
5ff5384551
Simplify adding indentation
2023-05-02 16:01:18 +01:00
Koen Vlaswinkel
5360f03700
Merge pull request #2396 from github/koesie10/suppress-error-message
...
Suppress similar error messages when monitor MRVA
2023-05-02 16:55:02 +02:00
Koen Vlaswinkel
5f3466404c
Add tests for suppressing error message
2023-05-02 16:19:53 +02:00
Koen Vlaswinkel
14eb7ff564
Merge pull request #2395 from github/koesie10/bqrs-use-select
...
Prefer `#select` result set over other result sets
2023-05-02 15:51:52 +02:00
Koen Vlaswinkel
e8ee43d955
Suppress similar error messages when monitor MRVA
...
This will suppress showing the same error message when monitoring the
variant analysis fails multiple times in a row. This is useful when
e.g. the internet is disconnected or the endpoint is non-functional for
any other reason.
This will show the error message at least once, and then only show it
if there has been a successful attempt in between or when the error
message is different. This should result in a much less noisy
experience.
2023-05-02 14:39:04 +02:00
Koen Vlaswinkel
36be323c89
Prefer #select result set over other result sets
...
For `@kind problem` queries, it seems like the BQRS contains four
result sets: `edges`, `nodes`, `subpaths`, and `#select`. The user is
probably interested in the results of `#select` since that contains the
direct result of the query. This changes the extraction of raw (BQRS)
results to always prefer `#select` over any other result set. If it
can't find a result set named `#select`, it will fall back to the first
result set in the BQRS like before.
2023-05-02 14:22:36 +02:00
Andrew Eisenberg
467e5ce452
Merge pull request #2385 from github/aeisenberg/no-cache-contextual
...
Add `codeQL.contextualQueries.disableCache`
2023-05-01 07:30:34 -07:00
Andrew Eisenberg
67110d7afb
Merge pull request #2393 from github/aeisenberg/fix-cfg-viewer
...
Fix CFG viewer
2023-05-01 07:29:26 -07:00
Andrew Eisenberg
c650afbf6e
Fix CFG viewer
...
After some bit of refactoring, the templates are no longer being
passed to the CFG viewer and this is preventing the viewer from
running.
This change fixes it.
2023-04-28 09:19:31 -07:00
Charis Kyriakou
c319d61dd5
Merge pull request #2391 from github/charisk/move-query-testing-files
...
Move query testing related files to /query-testing
2023-04-28 17:04:25 +01:00
Charis Kyriakou
331487dbab
Move qltest-discovery.ts to /query-testing/qltest-discovery.ts
2023-04-28 13:51:48 +00:00
Charis Kyriakou
82abaa6e13
Move discovery.ts to /query-testing/discovery.ts
2023-04-28 13:51:48 +00:00
Charis Kyriakou
feb92de0c4
Move test-ui.ts to /query-testing/test-ui.ts
2023-04-28 13:51:48 +00:00
Charis Kyriakou
6415978db5
Move test-tree-node.ts to /query-testing/test-tree-node.ts
2023-04-28 13:51:48 +00:00
Charis Kyriakou
c215072d2e
Move test-runner.ts to /query-testing/test-runner.ts
2023-04-28 13:51:48 +00:00
Charis Kyriakou
7662b3900f
Move test-manager-base.ts to /query-testing/test-manager-base.ts
2023-04-28 13:51:48 +00:00
Charis Kyriakou
863e7d207f
Move test-adapter.ts to /query-testing/test-adapter.ts
2023-04-28 13:51:48 +00:00
Charis Kyriakou
27ebc3e67f
Merge pull request #2388 from github/charisk/move-common-vscode-files
...
Move vscode utils to /common/vscode
2023-04-28 14:51:10 +01:00
Robert
afa7b1dea9
Merge pull request #2389 from github/robertbrignull/successful_repos_changelog
...
Add missing changelog entry for #2349
2023-04-28 12:31:44 +01:00
Robert
86ecd9bfad
Add changelog entry for https://github.com/github/vscode-codeql/pull/2349
2023-04-28 11:52:35 +01:00
Charis Kyriakou
b034c31db8
Move progress.ts to /common/vscode/progress.ts
2023-04-28 10:14:55 +00:00
Charis Kyriakou
4f1315aeae
Move authentication.ts to /common/vscode/authentication.ts
2023-04-28 10:14:55 +00:00
Charis Kyriakou
8500f20c2b
Move archive-filesystem-provider.ts to /common/vscode/archive-filesystem-provider.ts
2023-04-28 10:14:55 +00:00
Charis Kyriakou
d1db456e2e
Move abstract-webview.ts to /common/vscode/abstract-webview.ts
2023-04-28 09:33:02 +00:00
Charis Kyriakou
ff47310133
Move vscode-uitls/multi-file-system-watcher.ts to /common/vscode/multi-file-system-watcher.ts
2023-04-28 09:33:02 +00:00
Charis Kyriakou
5c6e8a46a3
Move vscode-uitls/external-files.ts to /common/vscode/external-files.ts
2023-04-28 09:33:02 +00:00
Charis Kyriakou
48dd3dc57c
Merge pull request #2387 from github/charisk/move-some-common-files
...
Move some common files into /common
2023-04-28 10:22:24 +01:00
Charis Kyriakou
8b59c12701
Move log-insights/jsonl-reader.ts to /common/jsonl-reader.ts
2023-04-28 07:35:54 +00:00
Charis Kyriakou
616e2be99b
Move sarif-parser.ts to /common/sarif-parser.ts
2023-04-28 07:35:54 +00:00
Andrew Eisenberg
5ce45761a0
Add codeQL.contextualQueries.disableCache
...
An internal option to help library authours to run and debug
the find references and find dependencies contetextual queries
without relying on the implicit cache.
2023-04-27 21:00:39 +00:00
dependabot[bot]
f4a3115a6a
Bump patch-package from 6.5.0 to 7.0.0 in /extensions/ql-vscode ( #2383 )
...
Bumps [patch-package](https://github.com/ds300/patch-package ) from 6.5.0 to 7.0.0.
- [Release notes](https://github.com/ds300/patch-package/releases )
- [Changelog](https://github.com/ds300/patch-package/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ds300/patch-package/compare/v6.5.0...v7.0.0 )
---
updated-dependencies:
- dependency-name: patch-package
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-27 10:04:51 -07:00
Robert
686d8749d0
Merge pull request #2384 from github/robertbrignull/makeSelected
...
Fix not setting database as selected if it already exists
2023-04-27 17:19:01 +01:00
Charis Kyriakou
39b890dd70
Merge pull request #2382 from github/charisk/move-mocks
...
Move mock GitHub API server files
2023-04-27 17:07:05 +01:00
Robert
b786b56c70
Fix tests
2023-04-27 16:53:25 +01:00
Robert
44a096202d
Add changelog entry
2023-04-27 16:51:33 +01:00
Elena Tanasoiu
f10185abc8
Write correct value to setting
2023-04-27 15:42:04 +00:00
Charis Kyriakou
431988f9fd
Move mock GitHub API server files
...
: scripts/lint-scenarios.ts
2023-04-27 15:24:09 +00:00
Robert
e0cb1df68c
Update expected args in test
2023-04-27 15:43:43 +01:00
Robert
92f23d18fb
Change default value of makeSelected from false to true
2023-04-27 15:17:01 +01:00
Robert
9941a42dd9
Set makeSelected to true for two calls
2023-04-27 15:13:36 +01:00
Robert
62737146fe
Make database selected even if it's already in the list
2023-04-27 15:06:46 +01:00
Charis Kyriakou
977c7f57b1
Merge pull request #2381 from github/charisk/move-cli-files
...
Move CodeQL CLI files
2023-04-27 14:06:13 +01:00
Elena Tanasoiu
d242117240
Fix comment to list correct options
...
I initially started defining an enum, but I'm not able to import it in package.json,
where the list of options is defined (under `codeQL.createQuery.autogenerateQlPacks`).
2023-04-27 12:35:06 +00:00
Elena Tanasoiu
c71a83b9c7
Correct test descriptions to say ternary instead of binary
2023-04-27 12:35:06 +00:00
Elena Tanasoiu
025ec257a5
Convert autogenerateQlPacks to use enum
2023-04-27 12:35:06 +00:00
Elena Tanasoiu
6034105462
Rename codeQL.autogenerateQlPacks -> codeQL.createQuery.autogenerateQlPacks
2023-04-27 12:35:06 +00:00
Elena Tanasoiu
9aeb520841
Rename SKELETON_WIZARD_FOLDER -> QL_PACK_LOCATION
...
To make it clear what it's supposed to be storing.
2023-04-27 12:35:06 +00:00
Elena Tanasoiu
4e2b26f285
Rename codeQL.createQuery.folder -> codeQL.createQuery.qlPackLocation
2023-04-27 12:35:06 +00:00
Elena Tanasoiu
c877f6cc60
Fix error in skeleton wizard tests
...
We modify both these options in the beforeEach(). We should reset
them in the afterEach().
2023-04-27 12:35:06 +00:00
Elena Tanasoiu
f2601432d3
Remember user's choice to not be prompted again
...
By writing the setting to our new `codeQL.autogenerateQlPacks` setting.
2023-04-27 12:35:04 +00:00
Elena Tanasoiu
8392284cc1
Introduce new dialog box with "No, never ask me again" option
2023-04-27 12:33:51 +00:00
Elena Tanasoiu
ae320d0fef
Set up new config setting for auto generating QL packs
...
In the next commit we will write to this setting when the user chooses
to disable the QL pack generation and prefers to never be asked again
about it.
2023-04-27 12:33:16 +00:00
Elena Tanasoiu
3eef0e9797
Give modal methods their own describe blocks
2023-04-27 12:33:16 +00:00
Robert
562f926be5
Merge pull request #2349 from github/robertbrignull/countSuccessfulRepos
...
Show number of successful repos instead of completed repos in variant analysis results view header
2023-04-27 12:58:15 +01:00
Charis Kyriakou
ae8766a296
Move distribution.ts to /codeql-cli/distribution.ts
2023-04-27 11:57:07 +00:00
Charis Kyriakou
8bdb51d281
Move cli-version.ts to /codeql-cli/cli-version.ts
2023-04-27 11:57:07 +00:00
Charis Kyriakou
732c67e6cd
Move cli.ts to /codeql-cli/cli.ts
2023-04-27 11:57:07 +00:00
Charis Kyriakou
84f482fcb7
Merge pull request #2379 from github/charisk/move-packaging-files
...
Move packaging files
2023-04-27 12:51:02 +01:00
Charis Kyriakou
287a2d1ef2
Update paths to data files to fix tests
2023-04-27 11:16:24 +00:00
Robert
9d7ea8ecd8
Make test names clearer
2023-04-27 12:10:51 +01:00
Robert
68c41d346c
Merge branch 'main' into robertbrignull/countSuccessfulRepos
2023-04-27 12:09:09 +01:00
Robert
29d04837ab
Merge pull request #2287 from github/robertbrignull/selection
...
Introduce helpers for commands that operate on selections
2023-04-27 11:38:22 +01:00
Shati Patel
988df04b0b
Change internal name for variant analysis SortKey values ( #2380 )
...
Follow-up to https://github.com/github/vscode-codeql/pull/2373
2023-04-27 10:37:14 +00:00
Robert
392c59ed2c
Remove unnecessary check of undefined
2023-04-27 10:56:25 +01:00
Shati Patel
af75fa9f2f
Update wording in the "sorting dropdown" of the variant analysis results view ( #2373 )
2023-04-27 10:41:32 +01:00
Robert
37459a1405
fix typo
2023-04-27 10:33:46 +01:00
Robert
0bc756766a
Merge branch 'main' into robertbrignull/selection
...
Conflicts:
extensions/ql-vscode/src/databases/local-databases-ui.ts
extensions/ql-vscode/src/query-history/query-history-manager.ts
2023-04-27 10:32:24 +01:00
Charis Kyriakou
80ac593bec
Add index.ts for packaging module
2023-04-27 08:52:52 +00:00
Charis Kyriakou
38af88805c
Move packaging.ts to /packaging/packaging.ts
2023-04-27 08:52:52 +00:00
Charis Kyriakou
8c9c38e1ae
Merge pull request #2377 from github/charisk/move-databse-files
...
Move database files
2023-04-27 09:44:03 +01:00
Charis Kyriakou
0941417caf
Move local-databases.ts to /databases/local-databases.ts
2023-04-26 13:52:16 +00:00
Charis Kyriakou
845197a95f
Move local-databases-ui.ts to /databases/local-databases-ui.ts
2023-04-26 13:52:16 +00:00
Charis Kyriakou
2e96ba90e6
Move databaseFetcher.ts to /databases/database-fetcher.ts
2023-04-26 13:52:16 +00:00
Charis Kyriakou
57cc9657ed
Merge pull request #2376 from github/charisk/move-query-evaluation-log-files
...
Move query evaluation logging files
2023-04-26 14:15:54 +01:00
Nora
099e8723bc
Merge pull request #2375 from github/version/bump-to-v1.8.4
...
Bump version to v1.8.4
2023-04-26 14:59:00 +02:00
Charis Kyriakou
de36944425
Add index for query-evaluation-logging module
2023-04-26 12:32:06 +00:00
Charis Kyriakou
1edecfae57
Move eval-log-viewer.ts to query-evaluation-logging/eval-log-viewer.ts and related tests
2023-04-26 12:32:06 +00:00
Charis Kyriakou
2d4d15aed8
Move eval-log-tree-builder.ts to query-evaluation-logging/eval-log-tree-builder.ts and related tests
2023-04-26 12:32:06 +00:00
Nora
77fbaea1c7
Merge pull request #2368 from github/nora/move-files-misc1
...
Move contextual and ast-viewer files into language-support
2023-04-26 14:15:35 +02:00
Nora
b6b3d3b541
improve imports
2023-04-26 09:56:45 +00:00
github-actions[bot]
e1e05725cf
Bump version to v1.8.4
2023-04-26 09:47:12 +00:00
Nora
3b53c5a14f
Merge pull request #2374 from github/v1.8.3
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.8.3
2023-04-26 11:03:51 +02:00
Nora
1614c833eb
v1.8.3
2023-04-26 10:20:20 +02:00
Robert
86b53a8def
Merge pull request #2358 from github/robertbrignull/handleCompareWith
...
Fiddle with handleCompareWith to make it cleaner
2023-04-25 16:29:49 +01:00
Robert
912a9e167f
Add LocalQueryInfo.databaseName getter
2023-04-25 15:57:20 +01:00
Robert
ab7ec589ff
Rename allItemsSelected => allSelectedItems
2023-04-25 15:52:41 +01:00
Robert
1a87ad8a33
Make comments clearer
2023-04-25 15:51:48 +01:00
Robert
1317dfa581
Pull out getFromQueryToCompare
2023-04-25 15:44:53 +01:00
Shati Patel
298176d8f1
React tests: Wrap code that causes state updates in act() ( #2372 )
2023-04-25 14:01:53 +00:00
Nora
9a317b7651
move ast test data files
2023-04-25 13:46:08 +00:00
Nora
ba85e98f8b
move language-support/contextual/ast-builder to language-support/ast-viewer/ast-builder
2023-04-25 13:46:08 +00:00
Nora
8d3d5dbf45
move src/astViewer to src/language-support/ast-viewer/ast-viewer including test
2023-04-25 13:46:08 +00:00
Nora
3757911d34
move src/ast-cfg-commands to language-support/ast-viewer/ast-cfg-commands
2023-04-25 13:46:08 +00:00
Nora
c9f7b7aacf
create index.ts and adjust imports and exports
2023-04-25 13:46:08 +00:00
Nora
e5845b1c21
move contextual -> language-support/contextual including tests and kebab-caseing
2023-04-25 13:46:08 +00:00
Koen Vlaswinkel
2d68c1c735
Merge pull request #2371 from github/koesie10/switch-to-argument-this
...
Rename `Argument[-1]` to `Argument[this]`
2023-04-25 14:20:49 +02:00
Koen Vlaswinkel
92b57bf1e2
Rename Argument[-1] to Argument[this]
...
See: https://github.com/github/codeql/pull/12556
2023-04-25 13:31:52 +02:00
Robert
72c646c29b
Ignore invalid file paths when parsing sarif
2023-04-25 11:21:56 +01:00
Robert
274cb9a6e8
Handle codeSnippet not being defined in markdown generation
2023-04-25 10:40:33 +01:00
Robert
0394bd5e1e
Make codeSnippet optional
2023-04-25 10:40:10 +01:00
Robert
e31ef662f8
Avoid using "as ThreadFlow" to force the type system
2023-04-24 17:32:21 +01:00
Robert
14952cf7d3
Delete assertSingleQuery
2023-04-24 16:08:46 +01:00
Robert
dbf3f26d13
Convert handleExportResults to use createSingleSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
a6a2f9776a
Convert handleCopyRepoList to use createSingleSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
be6f356437
Convert handleOpenOnGithub to use createSingleSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
1ea0f1429d
Convert handleViewDil to use createSingleSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
9c711eda97
Convert handleViewCsvAlerts to use createSingleSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
b74cd15752
Convert handleViewCsvResults to use createSingleSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
ef93ab9e70
Convert handleViewSarifAlerts to use createSingleSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
288a2bf62a
Convert handleShowQueryText to use createSingleSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
b2f0e2efd9
Convert handleCancel to use createMultiSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
28819dfe76
Convert handleShowEvalLogViewer to use createSingleSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
43c0d15be3
Convert handleShowEvalLogSummary to use createSingleSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
ccd73b2a16
Convert handleShowEvalLog to use createSingleSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
921cf60f5e
Convert handleOpenQueryDirectory to use createSingleSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
21757ae9b6
Convert handleShowQueryLog to use createSingleSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
a0a4a06430
Convert handleItemClicked to use createSingleSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
b17251b36c
Convert handleRenameItem to call createSingleSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
d29c24d06c
Convert handleRemoveHistoryItem to use createMultiSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
0b0a03396c
Convert handleOpenQuery to use createSingleSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
d1e528e48a
Convert runQueries to use createMultiSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
491cf2a58d
Convert handleAddSource to use createMultiSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
5394891691
Convert handleOpenFolder to use createMultiSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
be392b5415
Convert handleRenameDatabase to use createSingleSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
5bee5c6672
Convert handleRemoveDatabase to use createMultiSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
4a957adda3
Convert handleUpgradeDatabase to use createMultiSelectionCommand
2023-04-24 16:08:46 +01:00
Robert
40f3092244
Convert handleUpgradeDatabaseInternal to just take an array of databases
2023-04-24 16:08:46 +01:00
Robert
08eb7f811e
Add functions for creation selection commands
2023-04-24 16:08:46 +01:00
Dave Bartolomeo
be3efd79a8
Merge pull request #2369 from github/dbartol/qltest-error
...
Only attempt to discover QL tests in on-disk workspace folders
2023-04-24 11:06:15 -04:00
Dave Bartolomeo
f8a269c277
Only attempt to discover QL tests in on-disk workspace folders
...
This was only a problem for the new test UI, because the third-party Test Explorer extension we used before must have had this filter in its implementation.
2023-04-24 10:46:11 -04:00
Nora
f0ef98539c
Merge pull request #2367 from github/nora/move-local-query-files
...
Move local query files
2023-04-24 13:47:37 +02:00
Nora
a4dd26a13f
adjust index.ts, imports and export in quick-eval-code-lens-provider
2023-04-24 09:29:14 +00:00
Nora
aebf9be5d7
move /src/quickEvalCodeLensProvider.ts to /src/local-queries/quick-eval-code-lens-provider
2023-04-24 09:23:51 +00:00
Nora
7d711f3fb3
move src/quick-query to src/local-queries/quick-query
2023-04-24 09:22:18 +00:00
Nora
c708e5f595
Merge pull request #2360 from github/nora/move-language-support
...
Move language support files
2023-04-24 11:17:57 +02:00
Nora
d455c1aa76
Introduce and use index.ts
2023-04-24 08:25:31 +00:00
Nora
a175cac5f0
Move and rename languageSupport to language-support
2023-04-24 08:25:31 +00:00
Nora
f866545a40
Move query-editor
2023-04-24 08:25:31 +00:00
Nora
01c1888ded
Move ide-server
2023-04-24 08:25:31 +00:00
github-actions[bot]
4fafdbc58b
Bump CLI version from v2.12.7 to v2.13.0 for integration tests ( #2366 )
...
Co-authored-by: github-actions[bot] <github-actions@github.com >
2023-04-21 08:38:34 +00:00
Shati Patel
5fb001632b
Don't throw error if user cancels out of choosing a language ( #2365 )
...
When running "Create Query", if the user escapes out of the language quickpick we don't need to throw an error. Instead we can just show a `UserCancellationException` notice.
2023-04-21 07:29:09 +00:00
Robert
b0cdae7c9f
Merge branch 'main' into robertbrignull/handleCompareWith
...
uick 6363a6a4 Remove the determineSelection method
2023-04-20 16:03:41 +01:00
Robert
f0d41f6d3d
Merge pull request #2356 from github/robertbrignull/query_history_selection
...
Remove determineSelection and simplify selection commands for the query history
2023-04-20 16:01:51 +01:00
Robert
42f8916124
Remove test of impossible behaviour
2023-04-20 12:42:22 +01:00
Robert
ed9e9ddadf
Delete tests for determineSelection
2023-04-20 12:30:25 +01:00
Andrew Eisenberg
091985a164
Merge pull request #2351 from github/github-action/bump-cli
...
Bump CLI Version to v2.12.7 for integration tests
2023-04-20 02:51:23 -07:00
Shati Patel
0afe982ccf
Merge branch 'main' into github-action/bump-cli
2023-04-20 10:30:07 +01:00
Nora
d4fa420201
Merge pull request #2357 from github/charisk-nora/query-server-move
...
Move Query Server files
2023-04-20 10:21:20 +02:00
Koen Vlaswinkel
fbe782f4ef
Merge pull request #2354 from github/koesie10/clear-pack-cache-on-create
...
Clear pack cache on create and delete
2023-04-20 09:51:46 +02:00
Robert
3c77e81fd8
Make handleCompareWith cleaner
2023-04-19 17:35:23 +01:00
Nora
d9dc061312
Introduce index.ts
2023-04-19 15:05:30 +00:00
Nora
5cfb93980e
Rename legacyRunner to query-runner (kebab-case)
2023-04-19 14:11:05 +00:00
Nora
f97105ba41
Move queryRunner to query-server/queryRunner
2023-04-19 14:11:05 +00:00
Nora
e05defad3b
Rename query-runner to new-query-runner to match class and file
2023-04-19 14:11:05 +00:00
Nora
6d9a87c6e8
Rename legacy/legacyRunner to legacy/legacy-query-runner (kebab-case and class-file name)
2023-04-19 14:11:05 +00:00
Nora
ee66530d0d
Rename queryserver-client to query-sever-client (kebab-case)
2023-04-19 14:11:05 +00:00
Nora
78f1a88924
Rrename legacy/queryserver-client to legacy/query-sever-client (kebab-case)
2023-04-19 14:11:05 +00:00
Nora
222bf024f3
Rename json-rpc-server to server-process to match class and filename
2023-04-19 14:11:05 +00:00
Nora
4ee8e5a00e
Move json-rpc-server.ts
2023-04-19 14:11:05 +00:00
Charis Kyriakou
4097ee0255
Move legacy-query-server/ to query-server/legacy/
2023-04-19 14:11:04 +00:00
Charis Kyriakou
274182718a
Introduce index.ts for local-queries module ( #2355 )
2023-04-19 14:30:47 +01:00
Elena Tanasoiu
30c3ffad01
Merge pull request #2321 from github/elena/yer-a-flag-query
...
Enable skeleton wizard in codespaces-codeql template
2023-04-19 14:11:14 +01:00
Elena Tanasoiu
5f8ec14ad6
Merge branch 'main' into elena/yer-a-flag-query
2023-04-19 13:53:49 +01:00
Koen Vlaswinkel
686a9e4095
Clear pack cache on create and delete
...
We were only clearing the pack cache when a pack file was modified. When
using a script to create a new pack, the pack file is created at once
without a change event firing. This will change the behavior to also
clear the pack cache when a pack file is created or deleted.
2023-04-19 14:36:39 +02:00
Robert
6363a6a493
Remove the determineSelection method
2023-04-19 12:53:07 +01:00
Nora
7f3f3380ad
Merge pull request #2350 from github/nora/remove-query-history-title-bar-actions
...
Remove query history title actions
2023-04-19 13:50:19 +02:00
Nora
043adbf797
Merge pull request #2347 from github/nora/break-down-local-queries-1
...
Break down local-queries.ts
2023-04-19 13:49:30 +02:00
Elena Tanasoiu
aa2eceea4c
Merge branch 'main' into elena/yer-a-flag-query
2023-04-19 12:27:52 +01:00
Elena Tanasoiu
724dc45991
Fix typo
2023-04-19 11:25:33 +00:00
Elena Tanasoiu
2f811057b8
Enable skeleton wizard in codespaces template
...
Once we're satisfied with testing this flow (including with a single
rooted workspace) we can enable it in the codespaces-template.
2023-04-19 11:25:08 +00:00
Elena Tanasoiu
5ab24c0eea
Merge pull request #2330 from github/yer-a-sorted-database-query
...
Select latest database when creating skeleton query
2023-04-19 12:22:30 +01:00
Robert
cf78dbba92
Merge pull request #2343 from github/robertbrignull/results_filter
...
Add a component for filtering repositories based on their results
2023-04-19 12:19:37 +01:00
Robert
b5ad37a094
Don't say analyses failed when the workflow was canceled
2023-04-19 11:52:39 +01:00
Nora
82c8068b64
Update changelog
2023-04-19 08:59:05 +00:00
Nora
2be0c16f22
Remove unused type
2023-04-19 08:47:30 +00:00
Nora
1d8bcd476a
Remove titel actions
2023-04-19 08:47:30 +00:00
Elena Tanasoiu
02e17516d9
Convert db item methods to be static
...
So that we make it clear we should be passing state as params instead
of reading it off `this`.
2023-04-19 08:39:25 +00:00
Elena Tanasoiu
02dffe08d5
Fetch the latest database from the new sorted list
...
And add tests to check this.
I've had to adapt the existing `findExistingDatabaseItem` method
so receive params so that I'm better able to send it a language
and a list of database items.
2023-04-19 08:39:25 +00:00
Elena Tanasoiu
561e07a689
Sort database items by dateAdded
...
Before selecting an existing database, let's sort them by date.
We're opting to exclude databases with errors during the sorting
process.
2023-04-19 08:39:24 +00:00
Elena Tanasoiu
dce94e8510
Merge pull request #2341 from github/yer-an-input-box-query
...
Prompt non-codespace users for storage path
2023-04-19 09:36:42 +01:00
Koen Vlaswinkel
3f7b8a6409
Merge pull request #2348 from github/koesie10/non-existing-model-file
...
Hide link when model file does not exist
2023-04-19 10:21:21 +02:00
Elena Tanasoiu
7335e37c16
Merge branch 'main' into yer-an-input-box-query
2023-04-19 08:58:52 +01:00
Elena Tanasoiu
154fab845a
Don't mention workspace
2023-04-19 07:56:06 +00:00
github-actions[bot]
7c18934dde
Bump CLI version from v2.12.6 to v2.12.7 for integration tests
2023-04-18 20:36:27 +00:00
Elena Tanasoiu
5e76d0b1ad
Fix typos
...
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com >
2023-04-18 16:30:31 +00:00
Elena Tanasoiu
467c2a550e
Merge pull request #2328 from github/yer-a-single-rooted-workspace-query
...
Ensure we're selecting database in single rooted workspace
2023-04-18 17:25:09 +01:00
Elena Tanasoiu
1106e5959a
Remove canary flag
...
Once we're satisfied with testing this flow (including with a single
rooted workspace) we can remove this flag.
2023-04-18 15:51:53 +00:00
Robert
2844fed863
Merge branch 'main' into robertbrignull/results_filter
2023-04-18 16:41:45 +01:00
Robert
93acb76099
Use punctuation to make test names clearer
2023-04-18 16:38:56 +01:00
Robert
dd630bfca8
Split tests up into describe blocks
2023-04-18 16:38:39 +01:00
Robert
a8a84a6f8c
Add changelog entry
2023-04-18 16:34:34 +01:00
Elena Tanasoiu
db35cb294d
Add new setting to package.json
2023-04-18 15:34:21 +00:00
Elena Tanasoiu
e0bf1ca40f
Rename skeletonWizard setting to createQuery
2023-04-18 15:33:46 +00:00
Elena Tanasoiu
57d48a7b04
Prompt non-codespace users for storage path
...
Offer non-codespace users the option to configure their storage folder for skeleton packs.
Suggested here:
https://github.com/github/vscode-codeql/pull/2310#issuecomment-1507428217
At the moment we're choosing to create our skeleton packs in the first
folder in the workspace.
This is fine for the codespace template because we can control the
folder structure in that repo.
For users outside of this we'd like to offer them the option to choose
where to save their skeleton packs.
2023-04-18 15:33:45 +00:00
Andrew Eisenberg
72a3e8d44a
Merge pull request #2307 from github/aeisenberg/cli-version-telemetry
...
Add the CLI version to telemetry events
2023-04-18 08:27:46 -07:00
Elena Tanasoiu
93a2b06b35
Remove unnecessary assignment to variable
...
This was flagged by CodeQL.
2023-04-18 15:14:54 +00:00
Elena Tanasoiu
30ebe0ab57
Don't use shorthand boolean for large method calls
...
To make it clear what the search is doing and make the code more readable.
Co-authored-by: Robert Brignull <robertbrignull@github.com >
2023-04-18 15:14:54 +00:00
Elena Tanasoiu
28745da7b8
Replace setCurrentDatabaseItem with openDatabase
2023-04-18 15:14:51 +00:00
Elena Tanasoiu
6e4124115f
Ensure we're selecting database in single rooted workspace
...
After some testing of the wizard with a single rooted workspace
(`github/code-scanning`) we discovered a general VSCode extension
bug whereby after we download a database, we don't select it.
This isn't an issue in the wizard, but it does affect us as it means
we'll generate the QL pack, download the db for you but then you won't
know that we haven't selected your database.
So let's make sure our flow works for this case by explicitly selecting
the database once it's downloaded.
We've noticed by testing that we need to set the current database item
before we call `addDatabaseSourceArchiveFolder()`. Once that method is
called, the call to `setCurrentDatabaseItem()` is ignored.
We've had to make some changes to the openDatabase() method to select
a database item by default, since most places where we call `openDatabase()`
also immediately select the item.
There is one exception [1] in the test-runner.ts file, where we set the
current database item under special conditions.
For this reason, we've made the behaviour configurable and tried to add
some descriptive naming to the params so that it's easy to understand
what the config is doing.
[1]: 4170e7f7a7/extensions/ql-vscode/src/test-runner.ts (L120-L124)
2023-04-18 15:11:00 +00:00
Shati Patel
10adbd6fbc
Suggest smaller databases in "create query" setup ( #2346 )
2023-04-18 14:55:07 +01:00
Robert
7b03a6ed14
Fix story or cancelled analysis
2023-04-18 14:52:55 +01:00
Robert
6398ede2e2
Pull icon out to function
2023-04-18 14:52:55 +01:00
Robert
276d675242
Add labels to icons
2023-04-18 14:52:53 +01:00
Robert
3db0f2bdfe
Show an error if not all repos completed successfully
2023-04-18 14:52:53 +01:00
Robert
aa9e2fb5fc
Remove "Succeeded warnings" text
2023-04-18 14:52:53 +01:00
Robert
8291e52a9b
Pass in successfulRepositoryCount
2023-04-18 14:52:50 +01:00
Koen Vlaswinkel
23abc5de0d
Hide link when model file does not exist
...
This removes the link to the model file when it does not exist. It will
still show the filename of the model file. When clicking on "Apply", it
will refresh whether the model file exists after writing the file.
2023-04-18 15:47:18 +02:00
Nora
a1b020a5f7
Create new folder and split classes into it
2023-04-18 13:12:36 +00:00
Robert
612628fa98
Replace showWarning by passing in skippedRepositoryCount
2023-04-18 13:56:44 +01:00
Elena Tanasoiu
34d4fd4d41
Always check for an existing database
...
This fixes an issue where we would download a database every time
we create a new QL pack. Sometimes, a database is already available
so let's always check for it, regardless of the existence of a QL
pack.
2023-04-18 12:54:10 +00:00
Elena Tanasoiu
a5fc96397c
Rename selectExistingDatabase -> selectOrDownloadDatabase
...
Make it clear that this method can also download a database if it fails
to find one.
2023-04-18 12:54:10 +00:00
Elena Tanasoiu
d3ef29410b
Extract finding existing database item into separate method
2023-04-18 12:54:10 +00:00
Koen Vlaswinkel
b9c8983bb3
Merge pull request #2345 from github/koesie10/filter-extension-packs-for-language
...
Filter extension packs by database item language
2023-04-18 14:50:24 +02:00
Robert
52972f0d69
Make completedRepositoryCount non-optional
...
We're always passing in a non-undefined number anyway, so this optional value isn't giving us any benefit.
2023-04-18 13:23:52 +01:00
Anders Starcke Henriksen
6f11eca069
Merge pull request #2344 from github/starcke/csharp-fix-query
...
Fix C# query to give results in the same format as java.
2023-04-18 14:09:34 +02:00
Koen Vlaswinkel
46fbaf0657
Filter extension packs by database item language
...
This will filter the extension packs shown to the user when selecting an
extension pack to use in the data extension editor to only include the
extension packs that are compatible with the language of the database
item.
Unfortunately, this required quite some changes to the tests to ensure
the extension packs are actually setup properly since it's now reading
the extension pack files.
2023-04-18 13:48:20 +02:00
Anders Starcke Henriksen
6ec8df2c89
Fix C# query to give results in the same format as java.
2023-04-18 11:58:25 +02:00
Anders Starcke Henriksen
4170e7f7a7
Merge pull request #2338 from github/starcke/update-java-lib
...
Update library used by java query.
2023-04-18 11:32:10 +02:00
Koen Vlaswinkel
8d016a828e
Merge pull request #2340 from github/koesie10/show-extension-pack-name
...
Show extension pack name in data extensions editor
2023-04-18 11:15:29 +02:00
Anders Starcke Henriksen
d99b6c36a6
Merge pull request #2336 from github/starcke/sort-modeled
...
Sort on supported status.
2023-04-18 11:12:26 +02:00
Koen Vlaswinkel
1ae5589728
Update extension pack picker tests
2023-04-18 10:31:28 +02:00
Koen Vlaswinkel
18946b2dfd
Merge remote-tracking branch 'origin/main' into koesie10/show-extension-pack-name
2023-04-18 10:17:03 +02:00
Koen Vlaswinkel
a1ecb3dee6
Merge pull request #2339 from github/koesie10/model-filename
...
Show model filename in data extensions editor
2023-04-18 10:12:49 +02:00
Koen Vlaswinkel
94aee8abcb
Merge pull request #2337 from github/koesie10/fix-not-exists-error
...
Fix error when model file does not exist
2023-04-18 09:33:53 +02:00
Koen Vlaswinkel
b0b626c946
Merge pull request #2342 from github/koesie10/revert-2320
...
Revert "Bump @storybook/builder-webpack5 (#2320 )"
2023-04-18 09:24:31 +02:00
Dave Bartolomeo
dbdab13d03
Merge pull request #2291 from github/dbartol/debug-adapter
...
Implement basic CodeQL debug adapter
2023-04-17 21:33:45 -04:00
Andrew Eisenberg
02f14821c8
Merge pull request #2332 from jrozner/http-database
...
Allow HTTP connections to fetch database
2023-04-17 17:16:16 -07:00
Andrew Eisenberg
d20600320f
Fix invalid variable reference
2023-04-17 15:47:06 -07:00
Andrew Eisenberg
26459ded79
Update changelog
2023-04-17 15:43:07 -07:00
Andrew Eisenberg
8336df9483
Update extensions/ql-vscode/package.json
...
Fix typo
2023-04-17 15:39:54 -07:00
Joe Rozner
961f71d8a5
Changes requested from PR
2023-04-17 12:40:38 -07:00
Joe Rozner
99eb274029
Allow HTTP connections to fetch database
...
Introduce a new config option to allow requests over HTTP when fetching
a database from a URL.
2023-04-17 12:40:38 -07:00
Dave Bartolomeo
70b4aacf35
Merge pull request #2306 from github/dbartol/new-test-ui
...
Use native VS Code test UI on canary
2023-04-17 13:49:35 -04:00
Andrew Eisenberg
18f2d79aab
Merge branch 'main' into aeisenberg/cli-version-telemetry
2023-04-17 09:18:38 -07:00
Andrew Eisenberg
cc241d08b7
Merge pull request #2331 from github/aeisenberg/fix-flakes
...
Fix various test flakiness
2023-04-17 09:01:47 -07:00
Robert
ec35293e21
Add storybook for repository filter component
2023-04-17 16:28:43 +01:00
Robert
7fb9975cfa
Add UI for repository filter component
2023-04-17 16:28:43 +01:00
Robert
2701cd4824
Add tests of the new filter key
2023-04-17 16:28:43 +01:00
Robert
0685218c6a
Clarify some behaviour in filterAndSortRepositoriesWithResults
2023-04-17 16:28:43 +01:00
Koen Vlaswinkel
15bf338b8a
Revert "Bump @storybook/builder-webpack5 ( #2320 )"
...
This reverts commit 8e40d7d61d because
of mismatched package versions in Storybook which cause it to fail to
start.
2023-04-17 17:09:48 +02:00
Robert
72c07a397f
Implement support for new filterKey
2023-04-17 15:57:22 +01:00
Robert
049b4c27cc
Change matchesFilter to accept a FilterAndSortableResult
2023-04-17 15:57:22 +01:00
Robert
18d7c898a6
Split out FilterAndSortableResultWithIds to mirror RepositoriesFilterSortStateWithIds
2023-04-17 15:57:22 +01:00
Koen Vlaswinkel
744a516a44
Show extension pack name in data extensions editor
...
This will add the extension pack name to the data extensions editor and
allow the user to click on it to go to the folder of the extension pack
in the explorer panel.
2023-04-17 16:35:46 +02:00
Robert
563720b1af
Rename SortableResult => FilterAndSortableResult
2023-04-17 15:26:00 +01:00
Robert
d30ca71585
Add FilterKey type
2023-04-17 15:25:59 +01:00
Koen Vlaswinkel
fe2f37fdf5
Show model filename in data extensions editor
...
This adds the model filename to the data extensions editor and will also
allow the user to go to the model file by clicking on the filename.
This also updates the general UI to be somewhat more compact by moving
the modeled percentages to be below the header in 1 line.
2023-04-17 16:19:03 +02:00
Anders Starcke Henriksen
0d11075a5d
No indentation.
2023-04-17 15:50:33 +02:00
Anders Starcke Henriksen
7b901b4814
Update library used by java query.
2023-04-17 15:42:53 +02:00
Koen Vlaswinkel
3c16b81f25
Fix error when model file does not exist
...
When you have just created a model file using the quick picker/input
box, the data extension editor will try to read it and fail with an
error message. This adds a check to ensure the model file exists and if
it doesn't, it will not try to read in the file.
This should always be safe since the model file picker will only allow
you to select existing files.
2023-04-17 15:40:34 +02:00
Anders Starcke Henriksen
0ee090b6e1
Merge pull request #2335 from github/starcke/rename-sup-modelled
...
Rename supported to modelled.
2023-04-17 15:39:10 +02:00
Anders Starcke Henriksen
cbf1f7b7a7
Update test.
2023-04-17 15:38:10 +02:00
Anders Starcke Henriksen
42335c9947
Sort on supported status.
2023-04-17 15:24:31 +02:00
Anders Starcke Henriksen
fb4f39dcfb
Modelled -> Modeled.
2023-04-17 15:00:41 +02:00
Koen Vlaswinkel
3c0b3e467e
Merge pull request #2333 from github/koesie10/data-extension-editor-csharp
...
Add better support for different languages in data extension editor
2023-04-17 14:55:15 +02:00
Koen Vlaswinkel
97e9129023
Merge pull request #2334 from github/koesie10/data-extension-editor-language-check
...
Add database language check to data extensions editor
2023-04-17 14:55:02 +02:00
Anders Starcke Henriksen
7ce0e0a75a
Rename supported to modelled.
2023-04-17 14:48:04 +02:00
Koen Vlaswinkel
79c39a0826
Add database language check to data extensions editor
...
This will not allow the user to open the data extensions editor for a
database if it is not one of the supported languages. The supported
languages is a list of `string` rather than a list of `QueryLanguage`
because a database item's language is also a `string`.
2023-04-17 14:38:15 +02:00
Koen Vlaswinkel
923e13fce3
Add better support for different languages in data extension editor
...
There were still some places where we were hardcoding Java in the data
extension editor. This changes these places to use the database item
language instead.
2023-04-17 14:25:57 +02:00
Anders Starcke Henriksen
1367d386db
Merge pull request #2329 from github/starcke/ext-csharp-query
...
Add support for running C# query.
2023-04-17 10:21:01 +02:00
Anders Starcke Henriksen
1e42c1152f
Update query ID.
2023-04-17 10:06:00 +02:00
Anders Starcke Henriksen
a7f87658bb
Update extensions/ql-vscode/test/vscode-tests/no-workspace/data-extensions-editor/external-api-usage-query.test.ts
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2023-04-17 09:28:42 +02:00
Dave Bartolomeo
a52391b264
Merge branch 'dbartol/new-test-ui' of https://github.com/github/vscode-codeql into dbartol/new-test-ui
2023-04-14 18:47:44 -04:00
Dave Bartolomeo
a151adec06
Stop sending debug events after forcible disconnection
2023-04-14 18:32:45 -04:00
Dave Bartolomeo
74c3db7392
Fix crash in codeql.debugQuery when run from command palette
2023-04-14 17:56:58 -04:00
Elena Tanasoiu
9b647ff432
Merge pull request #2310 from github/yer-a-workspace-query
...
Stop pushing QL pack as top level folder to avoid confusing the user
2023-04-14 21:24:43 +01:00
Dave Bartolomeo
8c2c25e85f
Fix PR feedback
2023-04-14 15:24:08 -04:00
Dave Bartolomeo
7602d8e317
Merge remote-tracking branch 'origin/main' into dbartol/debug-adapter
2023-04-14 15:10:50 -04:00
Dave Bartolomeo
103e39726c
Move debugger tests into subdirectory
2023-04-14 15:01:29 -04:00
Andrew Eisenberg
9a40decc09
Remove timeout in test
...
A global timeout has already been set.
2023-04-14 11:31:28 -07:00
Dave Bartolomeo
aa9ca6e413
Remove unused code
2023-04-14 14:10:56 -04:00
Dave Bartolomeo
ad2c065413
Better error message UI for bad debug configuration
2023-04-14 14:00:46 -04:00
Dave Bartolomeo
55644d5f2a
Simplify nested ternaries
2023-04-14 13:51:16 -04:00
Andrew Eisenberg
35e8ce1654
Fix various test flakiness
...
This commit addresses various test flakiness:
1. Bump timeouts for queries tests
2. Add a dispose handler to queryserver-client. This will help us during
tests because if there is a test that timesout while a query is
running, the query's progress callback won't be invoked. We will
still get a timeout error in the first test, but the second test will
not get a spurious error.
3. Handle a disposed query server in `deregisterDatabase`. This method
will remove the database from the currently running query server.
If there is no query server, then there is nothing to remove. So,
this error is safe to ignore.
4. Explicitly `end()` a connection `ServerProcess`. I'm not 100% sure if
this is necessary, but it seems like it prevents responses from being
handled and erroring out.
5. Better handling of ideServer restarts. Previously, if you quickly
called `CodeQL: Restart Query Server` twice in a row, you would get
an error from the ideServer restart. Restart fails if the server is
not already started. So, in this case just call a start.
2023-04-14 10:50:27 -07:00
Dave Bartolomeo
d1b5ab645c
Merge branch 'dbartol/debug-adapter' of https://github.com/github/vscode-codeql into dbartol/debug-adapter
2023-04-14 13:41:19 -04:00
Dave Bartolomeo
ce2fecd506
Don't await showAndLog...
2023-04-14 13:41:03 -04:00
Dave Bartolomeo
03ceb738c0
Update extensions/ql-vscode/src/common/commands.ts
...
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com >
2023-04-14 13:31:26 -04:00
Dave Bartolomeo
6fa775777c
Merge branch 'dbartol/debug-adapter' of https://github.com/github/vscode-codeql into dbartol/debug-adapter
2023-04-14 13:29:48 -04:00
Dave Bartolomeo
14a4247ffa
Update extensions/ql-vscode/test/vscode-tests/cli-integration/debug-controller.ts
...
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com >
2023-04-14 13:29:23 -04:00
Dave Bartolomeo
95dda2b3dd
Update extensions/ql-vscode/src/run-queries-shared.ts
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2023-04-14 12:57:45 -04:00
Dave Bartolomeo
60fd868579
Remove unused code
2023-04-14 12:56:25 -04:00
Dave Bartolomeo
59dcea6fea
Add comment about disposal of debug adapter tracker
2023-04-14 12:56:06 -04:00
Dave Bartolomeo
30b9d7eb7f
Merge branch 'dbartol/debug-adapter' of https://github.com/github/vscode-codeql into dbartol/debug-adapter
2023-04-14 12:47:39 -04:00
Dave Bartolomeo
d3b118bc5f
Update extensions/ql-vscode/src/debugger/debug-configuration.ts
...
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com >
2023-04-14 12:47:11 -04:00
Dave Bartolomeo
6efdd116ee
Use preferred cast style
2023-04-14 12:45:51 -04:00
Dave Bartolomeo
22679b8972
Update extensions/ql-vscode/src/local-databases.ts
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2023-04-14 12:44:26 -04:00
Dave Bartolomeo
2da689598d
Rework debug query evaluation code to avoid lots of state-dependent properties
2023-04-14 12:38:49 -04:00
Dave Bartolomeo
a0a3af2759
Remove unused commands
2023-04-14 12:18:12 -04:00
Elena Tanasoiu
9c79799558
Merge branch 'main' into yer-a-workspace-query
2023-04-14 14:00:28 +01:00
Anders Starcke Henriksen
90936780bd
Add support for running C# query.
2023-04-14 14:47:20 +02:00
Koen Vlaswinkel
ffa643c91b
Merge pull request #2326 from github/koesie10/raise-cli-integration-timeout
...
Set default higher timeout on CLI integration tests
2023-04-14 14:38:21 +02:00
Elena Tanasoiu
70d533f073
Make check platform agnostic
...
The separator character is different on Windows.
2023-04-14 12:31:25 +00:00
Elena Tanasoiu
bfc5f49d44
Check specifically for the starter workspace
...
We've made an exception to fetch the parent folder when we're
in the vscode-codeql-starter workspace.
We'd like to make this more specific so that it doesn't interfere
with other repos.
2023-04-14 11:01:18 +00:00
Koen Vlaswinkel
d4b6259961
Merge pull request #2302 from github/koesie10/kind-dropdown
...
Change kind input to a dropdown
2023-04-14 12:22:39 +02:00
Elena Tanasoiu
4a8ba1377d
Don't offer to create skeleton pack again
...
When running Create Query in the codespaces-codeql repo, it successfully
creates codeql-custom-queries-xxx as a subfolder of the first workspace
folder, and then adds a database. After the database gets added, we get
prompted with this message:
```
We've noticed you don't have a CodeQL pack available to analyze this
database. Can we set up a query pack for you?
```
which would try to create another QL pack.
Since we're no longer pushing QL packs as top level folders in the
workspace when we use the new "Create Query" flow, we also need to adapt
the original flow to take into account subfolders.
Just as a reminder, the original flow is:
- Be in the codespace template
- Download a database from GitHub
- The extension will offer to create a QL pack for the database
The new flow:
- Run the "Create Query" command
- Choose a language
- Create a QL pack
- Download a database for it
In the new flow the last step of downloading a database would trigger
the extension to offer to create a QL pack.
Let's fix this by detecting subfolders as well and exiting early.
2023-04-14 09:55:18 +00:00
Koen Vlaswinkel
0ad3ffaba3
Merge pull request #2319 from github/dependabot/npm_and_yarn/extensions/ql-vscode/glob-10.0.0
...
Bump glob from 9.3.2 to 10.0.0 in /extensions/ql-vscode
2023-04-14 11:51:18 +02:00
Koen Vlaswinkel
02424984bb
Merge remote-tracking branch 'origin/main' into koesie10/kind-dropdown
2023-04-14 11:17:59 +02:00
Koen Vlaswinkel
47d7533ad5
Merge pull request #2300 from github/koesie10/create-extension-pack
...
Add creating extension packs when opening the editor
2023-04-14 11:17:35 +02:00
Koen Vlaswinkel
5a3630a954
Merge pull request #2296 from github/koesie10/create-extension-model-file
...
Allow creating new model file in existing data extension
2023-04-14 11:09:20 +02:00
Charis Kyriakou
05d68d0bbe
Move local query mappers to separate files ( #2322 )
2023-04-14 09:59:34 +01:00
Koen Vlaswinkel
370874a02f
Merge branch 'main' into koesie10/create-extension-model-file
2023-04-14 10:56:27 +02:00
Koen Vlaswinkel
fd98f3400b
Add Tuple type
2023-04-14 10:53:38 +02:00
Koen Vlaswinkel
5766db9285
Set default higher timeout on CLI integration tests
...
This sets a default timeout of 3 minutes on CLI integration tests. This
is because these tests call into the CLI and execute queries, so these
are expected to take a lot longer than the default 5 seconds. This
allows us to remove all the individual `jest.setTimeout` calls with
different values from the test files.
2023-04-14 10:46:33 +02:00
Koen Vlaswinkel
69c66f3b53
Merge pull request #2325 from github/koesie10/raise-queries-timeout
...
Raise timeout of queries tests
2023-04-14 10:44:52 +02:00
Koen Vlaswinkel
1419ff2a9a
Raise timeout of queries tests
2023-04-14 10:28:59 +02:00
Koen Vlaswinkel
e95e4a366f
Merge pull request #2314 from github/koesie10/use-query-in-extension
...
Add external APIs query in extension
2023-04-14 10:27:01 +02:00
Charis Kyriakou
013701d262
Merge pull request #2315 from github/charisk/variant-analysis-store-mappers
...
Introduce mapping layer for variant analysis history items
2023-04-14 09:26:30 +01:00
Koen Vlaswinkel
9261519636
Merge remote-tracking branch 'origin/main' into koesie10/create-extension-model-file
2023-04-14 09:29:39 +02:00
Koen Vlaswinkel
ff405a66c9
Merge remote-tracking branch 'origin/main' into koesie10/use-query-in-extension
2023-04-14 09:26:30 +02:00
Charis Kyriakou
a15eef823d
Update test data to match actual data format
2023-04-14 07:23:04 +00:00
Charis Kyriakou
2a9911dac2
Minor function rename to match convention
2023-04-14 07:22:27 +00:00
Dave Bartolomeo
8f5f43f29c
Merge branch 'main' into dbartol/new-test-ui
2023-04-13 18:27:04 -04:00
Dave Bartolomeo
d861772eb1
Merge pull request #2323 from github/dbartol/update-vscode-types
...
Update `@types/vscode` and fix naming conflicts
2023-04-13 18:25:48 -04:00
Dave Bartolomeo
da3f482a97
Reconsider the fanciness of CodeQL tests
2023-04-13 18:03:07 -04:00
Dave Bartolomeo
c9507dff5f
Merge branch 'dbartol/update-vscode-types' into dbartol/new-test-ui
2023-04-13 21:46:53 +00:00
Dave Bartolomeo
3eaa99696a
Add iterator function to mock environment variable collection
2023-04-13 17:39:50 -04:00
Dave Bartolomeo
78d3de6c86
Fixup rename in test code
2023-04-13 17:35:10 -04:00
Dave Bartolomeo
8f29e1c812
Add separate command for "Accept Output" on test item context menu
2023-04-13 17:27:23 -04:00
Andrew Eisenberg
3826e35cc5
Merge branch 'main' into aeisenberg/cli-version-telemetry
2023-04-13 14:24:01 -07:00
Dave Bartolomeo
64e867d1c4
Update @types/vscode and fix naming conflicts
2023-04-13 17:09:10 -04:00
Dave Bartolomeo
c963cf6f5d
Merge branch 'main' into dbartol/new-test-ui
2023-04-13 17:04:16 -04:00
Dave Bartolomeo
eca8cce6b9
Update extensions/ql-vscode/src/test-manager.ts
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2023-04-13 17:03:08 -04:00
Dave Bartolomeo
cb93c84611
Test tests
2023-04-13 17:00:15 -04:00
Andrew Eisenberg
0da40a6819
Use a CLI version changed listener for telemetry events
...
Set the CLI version in the telemetry listener whenever the version
changes.
A few things to note here:
1. In `CliServer::getVersion()`, avoid calling `supportsPerQueryEvalLog`
directly. This avoids a recursive call to `CliServer::getVersion()`.
Currently, it's always safe to do this, but I thought that it would
be good to avoid recursion here in case we change things in the
future.
2. Now, we are sending the CLI version with all telemetry events.
2023-04-13 12:16:27 -07:00
dependabot[bot]
8e40d7d61d
Bump @storybook/builder-webpack5 in /extensions/ql-vscode ( #2320 )
...
Bumps [@storybook/builder-webpack5](https://github.com/storybookjs/storybook/tree/HEAD/lib/core ) from 6.5.17-alpha.0 to 7.0.4.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Commits](https://github.com/storybookjs/storybook/commits/v7.0.4/lib/core )
---
updated-dependencies:
- dependency-name: "@storybook/builder-webpack5"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-13 10:27:53 -07:00
Elena Tanasoiu
b6eaf93dba
Rename workspaceStorage -> firstWorkspaceFolder
2023-04-13 15:57:58 +00:00
Elena Tanasoiu
14d8593d58
Use getOnDiskWorkspaceFolders to fetch folders
2023-04-13 15:57:58 +00:00
Koen Vlaswinkel
42aacce9d4
Merge pull request #2316 from github/koesie10/data-extension-editor-errors
...
Improve error handling in data extension editor
2023-04-13 17:12:19 +02:00
Elena Tanasoiu
b83d54f285
Add a JSDoc description for the method
2023-04-13 14:59:00 +00:00
Elena Tanasoiu
5634c1ee51
Rename getFirstStoragePath -> getFirstWorkspaceFolder
2023-04-13 14:58:58 +00:00
Charis Kyriakou
1c90fd1353
Rename variant analysis data and domain mappers to follow convention
2023-04-13 14:54:08 +00:00
Koen Vlaswinkel
7e9a7f2156
Fix test for YAML error
2023-04-13 16:48:44 +02:00
Elena Tanasoiu
abe74fce76
Merge pull request #2312 from github/yer-a-database-query
...
Filter out databases with errors
2023-04-13 15:39:45 +01:00
Dave Bartolomeo
9344499d23
Merge remote-tracking branch 'origin/main' into dbartol/debug-adapter
2023-04-13 10:00:08 -04:00
dependabot[bot]
64af86c6e3
Bump glob from 9.3.2 to 10.0.0 in /extensions/ql-vscode
...
Bumps [glob](https://github.com/isaacs/node-glob ) from 9.3.2 to 10.0.0.
- [Release notes](https://github.com/isaacs/node-glob/releases )
- [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md )
- [Commits](https://github.com/isaacs/node-glob/compare/v9.3.2...v10.0.0 )
---
updated-dependencies:
- dependency-name: glob
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-13 13:58:06 +00:00
Dave Bartolomeo
785f00983a
Merge remote-tracking branch 'origin/main' into dbartol/debug-adapter
2023-04-13 09:54:40 -04:00
Elena Tanasoiu
09396ff4ce
Bump test timeout, again
...
We've added more tests so now the overall duration is over 40 seconds for this file.
I'm increasing the timeout again.
2023-04-13 13:05:56 +00:00
Koen Vlaswinkel
0a304f633a
Use enum for query texts
2023-04-13 15:01:43 +02:00
Koen Vlaswinkel
3a761d080b
Improve error handling in data extension editor
...
This improves the error handling in the data extension editor by showing
more errors to the user and adding validation to data extension model
files.
2023-04-13 14:57:19 +02:00
Charis Kyriakou
807eb92c92
Merge pull request #2313 from github/charisk/repo-tasks-store-renaming
...
Repo tasks store renaming
2023-04-13 13:12:05 +01:00
Charis Kyriakou
7e08bb9efe
Introduce mapping layer for variant analysis history items
2023-04-13 13:11:35 +01:00
Charis Kyriakou
73089841a3
Merge pull request #2308 from github/charisk/query-history-store-naming
...
Query history store renaming
2023-04-13 12:30:25 +01:00
Koen Vlaswinkel
5200871989
Add external APIs query in extension
...
This adds the external API query text to the extension directly to avoid
users having to copy the query to their local `codeql` submodule or
having to checkout a specific branch.
This is a temporary solution until the queries are stabilized. Once they
are, we will upstream these to `github/codeql` and use them like other
contextual queries.
Since this is just a temporary solution, this is not the prettiest code
and is not intended to be a long-term solution. It does not do proper
caching and will create a new temporary directory for every query run.
The performance hit of this is acceptable and expected.
2023-04-13 13:26:37 +02:00
Charis Kyriakou
86dabae359
Add repo states store index file
2023-04-13 10:56:07 +00:00
Charis Kyriakou
ba75e7cbd9
Rename repo-task-store to repo-tasks-store
2023-04-13 10:56:00 +00:00
Charis Kyriakou
a85f7f9788
Rename repo states domain and dto mappers
2023-04-13 10:55:53 +00:00
Charis Kyriakou
2f9aac9acb
Rename mapping functions to follow same patterns and conventions
2023-04-13 10:55:49 +00:00
Charis Kyriakou
46ce1cbc51
Rename repo tasks DTOs
2023-04-13 10:55:41 +00:00
Charis Kyriakou
374d03e845
Move repo tasks store files to repo-tasks-store dir
2023-04-13 10:55:36 +00:00
Charis Kyriakou
9142fed2dc
Merge pull request #2311 from github/charisk/repo-state-store-naming
...
Repo state store naming
2023-04-13 11:40:04 +01:00
Elena Tanasoiu
128803b65b
Filter out databases with errors
...
When we create a skeleton query, we check whether you already have an
existing database with the same name (e.g. `github/codeql`). If we can't
find one, we also check for an existing database with the same language.
If we find one, we select it instead of downloading a new database.
Here we're filtering out databases with errors.
2023-04-13 10:26:52 +00:00
Charis Kyriakou
c0cd038423
Provide mapping functions for top level repo state models
2023-04-13 09:48:36 +00:00
Robert
089d3566ef
Merge pull request #2304 from github/robertbrignull/selection_types
...
Make types for selection commands more precise
2023-04-13 10:45:44 +01:00
Charis Kyriakou
7f5548b1e7
Add repo states store index file
2023-04-13 09:41:06 +00:00
Charis Kyriakou
61d5830196
Rename repo states domain and dto mappers
2023-04-13 09:38:27 +00:00
Charis Kyriakou
05838a0198
Rename mapping functions to follow same patterns and conventions
2023-04-13 09:37:03 +00:00
Charis Kyriakou
296cbe1619
Rename repo states DTOs
2023-04-13 09:32:40 +00:00
Charis Kyriakou
9798c5f307
Move repo state store files to repo-states-store dir
2023-04-13 09:31:28 +00:00
Elena Tanasoiu
6000e72ee5
Stop pushing QL pack as top level folder to avoid confusing the user
...
In the original flow for creating skeleton packs, we were starting out
by choosing a database (e.g. github/codeql) and having the extension
create the QL pack for us.
At that point, we were storing the QL pack together with the database in
the extension storage because we weren't interested in committing it to
the repo.
This means we weren't able to see it in the file explorer so in order to
make it visible, we decided to push it as a top-level folder in the
workspace.
Hindsight is 20/20.
Let's change this original flow by just creating the folder in the
workspace storage instead of the extension storage (which will make it
visible in the file explorer) and stop pushing it as an extra top level
folder in the workspace.
NB: For this flow, we exit early in the `createSkeletonPacks` method if
the folder already exists so we don't need to check this again.
2023-04-13 09:29:43 +00:00
Elena Tanasoiu
9a2de398f8
Move getFirstStoragePath method into helpers
...
So that we can re-use it in the QLPackGenerator.
2023-04-13 09:07:45 +00:00
Elena Tanasoiu
8c0d0d800d
Merge pull request #2305 from github/elena/yer-a-progress-query
...
Small fixes to skeleton query wizard
2023-04-13 09:09:19 +01:00
Elena Tanasoiu
03adb70e45
Merge pull request #2298 from github/elena/yer-a-windows-query
...
Fix problem with detecting storage folder on windows
2023-04-13 08:54:56 +01:00
Charis Kyriakou
a34ded92f6
Update query history store code comments
2023-04-13 07:38:55 +00:00
Charis Kyriakou
be65a568b8
Add query history store index file
2023-04-13 07:29:42 +00:00
Charis Kyriakou
d1366a14ca
Move ALLOWED_QUERY_HISTORY_VERSIONS const to store
2023-04-13 07:26:53 +00:00
Charis Kyriakou
6581988d22
Rename domain and dto mappers
2023-04-13 07:26:05 +00:00
Charis Kyriakou
e066e3b33f
Rename mapping functions to follow same patterns and conventions
2023-04-13 07:25:13 +00:00
Koen Vlaswinkel
e15f01c4a3
Merge pull request #2295 from github/koesie10/pick-extension-model-file
...
Add configurable model filename to data extension editor
2023-04-13 08:55:32 +02:00
Andrew Eisenberg
d6b3e51f15
Add the CLI version to telemetry events
...
This adds the CLI version to telemetry command-usage events.
Note that the CLI server is created after the telemetry listener is
created. The first few telemetry events may have a "not-set" value for
the CLI version.
2023-04-12 19:06:43 -07:00
Dave Bartolomeo
397b5852c1
Fix test adapter tests
2023-04-12 16:54:07 -04:00
Dave Bartolomeo
e986b07bc7
Add missing mock method after @types/vscode upgrade
2023-04-12 16:45:53 -04:00
Dave Bartolomeo
60bf56db45
Extend query runner test timeouts to 30s (from 20s)
2023-04-12 16:14:48 -04:00
Dave Bartolomeo
7ea7d6c1f6
Merge remote-tracking branch 'origin/main' into dbartol/new-test-ui
2023-04-12 19:51:31 +00:00
Dave Bartolomeo
4804220971
Use native VS Code test UI in canary
2023-04-12 15:50:27 -04:00
Dave Bartolomeo
e1dae0bf01
Avoid identifier collision with new VS Code version
2023-04-12 15:49:52 -04:00
Elena Tanasoiu
7f8f0653b0
Merge branch 'main' into elena/yer-a-windows-query
2023-04-12 18:08:43 +01:00
Elena Tanasoiu
eabcd00e75
Merge pull request #2297 from github/elena/improvements-to-wizard
...
Refactor `digForDatabaseItem` and `digForDatabaseWithSameLanguage` methods for skeleton wizard
2023-04-12 18:08:30 +01:00
Elena Tanasoiu
3627139c8a
Hide command behind canary flag
...
Adding this temporarily
2023-04-12 16:52:05 +00:00
Elena Tanasoiu
77bffd5bb1
Correct error messages to indicate ql pack storage path
2023-04-12 16:52:04 +00:00
Elena Tanasoiu
e981530b20
Import methods instead of whole databaseFetcher object
2023-04-12 16:52:04 +00:00
Elena Tanasoiu
b00e2aa09f
Rename codeQL.createSkeletonQuery -> codeQL.createQuery
2023-04-12 16:52:04 +00:00
Elena Tanasoiu
c9f7860621
Move try/catch into execute command
...
So that we're able to catch any errors when this fails.
2023-04-12 16:52:04 +00:00
Elena Tanasoiu
eff5f1f197
Fix regex expression
2023-04-12 16:52:04 +00:00
Elena Tanasoiu
9f04c712e0
Use progress correctly
...
By setting maxSteps to the correct number of steps.
2023-04-12 16:52:04 +00:00
Charis Kyriakou
759116dce1
Rename query history top level DTOs
2023-04-12 16:49:28 +00:00
Charis Kyriakou
d740c2356b
Rename variant analysis history item DTOs
2023-04-12 16:47:07 +00:00
Charis Kyriakou
f270a2c608
Rename SortDirection data model to SortDirectionDto.
...
This requires us providing mapping functions for objects that use SortDirection.
2023-04-12 17:44:32 +01:00
Elena Tanasoiu
4c04daafb7
Merge branch 'main' into elena/improvements-to-wizard
2023-04-12 17:40:08 +01:00
Elena Tanasoiu
a48b1f823a
Merge pull request #2256 from github/elena/yer-a-lizard-query
...
Improvements to skeleton query flow
2023-04-12 17:39:47 +01:00
Elena Tanasoiu
e298f2ba09
Take storage path off App instead of extension context
2023-04-12 16:39:14 +00:00
Elena Tanasoiu
b4468d612a
Download databases into extension storage path
...
Now that we've figured out how to set the storage path for both Mac &
Windows, we also want to make sure we're consistent with the location
where we save databases.
At the moment, our change will download databases directly in the
workspace folder.
When we call `downloadGitHubDatabase()` in other places outside the
wizard, we provide `ctx.storageUri.fsPath` as the location. [1] [2] [3]
Let's do the same here.
I've tested this on Mac for the codespaces-codeql & starter workspaces.
[1]: c7bb22c312/extensions/ql-vscode/src/local-databases-ui.ts (L476)
[2]: c7bb22c312/extensions/ql-vscode/src/extension.ts (L710)
[3]: c7bb22c312/extensions/ql-vscode/src/extension.ts (L1120)
2023-04-12 16:30:41 +00:00
Elena Tanasoiu
f8b0ecafcc
Merge branch 'main' into elena/yer-a-lizard-query
2023-04-12 17:24:19 +01:00
Elena Tanasoiu
6fc6f399fd
Shorten check for progress
...
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com >
2023-04-12 16:11:17 +00:00
Elena Tanasoiu
f377bb93ac
Merge pull request #2250 from github/elena/yer-a-wizard-query
...
Adapt skeleton pack generation to work with new queries panel
2023-04-12 17:07:12 +01:00
Andrew Eisenberg
b3ff1ed52f
Merge pull request #2289 from github/aeisenberg/watch-external-config
...
Restart query server when external config changes
2023-04-12 08:27:27 -07:00
Dave Bartolomeo
d14c84439c
Relax linting for debug configuration variable commands
2023-04-12 11:22:11 -04:00
Shati Patel
b5c65b5189
Minor: fix typo in changelog ( #2303 )
2023-04-12 15:18:19 +00:00
Andrew Eisenberg
6de58ec19d
Address review comments
2023-04-12 15:14:54 +00:00
Dave Bartolomeo
809c86f0dc
Remove unused command
2023-04-12 11:03:16 -04:00
Robert
0cf7341cc8
Make types for selection commands more precise
2023-04-12 16:01:03 +01:00
Anders Starcke Henriksen
b3e78c33e5
Merge pull request #2301 from github/version/bump-to-v1.8.3
...
Bump version to v1.8.3
2023-04-12 16:35:25 +02:00
Elena Tanasoiu
785c8c1f22
Rename storagePath -> qlPackStoragePath
2023-04-12 14:25:43 +00:00
Koen Vlaswinkel
f0fbaabd69
Change kind input to a dropdown
...
This changes the kind input from a text field to a dropdown in the data
extensions editor. The supported values for each extensible predicate
are based on what is currently in-scope for the documentation. Other
kinds are not supported.
The supported kinds are now stored on the
`extensiblePredicateDefinitions` to make it easier to add new kinds in
the future.
2023-04-12 15:51:12 +02:00
Charis Kyriakou
1cd5d922b2
Rename local query history item DTOs
2023-04-12 13:12:53 +00:00
shati-patel
4b01374a6f
Use path.join in folder paths
2023-04-12 14:12:33 +01:00
github-actions[bot]
341e0375a6
Bump version to v1.8.3
2023-04-12 12:58:18 +00:00
Koen Vlaswinkel
c1da623d43
Add creating extension packs when opening the editor
2023-04-12 14:55:42 +02:00
Anders Starcke Henriksen
c7bb22c312
Merge pull request #2299 from github/v1.8.2
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.8.2
2023-04-12 14:52:57 +02:00
shati-patel
a968aab209
Remove explicit Windows test
...
This should be covered by running the general test suite in CI (on windows-latest)
2023-04-12 13:26:23 +01:00
Anders Starcke Henriksen
3c8dc04845
v1.8.2
2023-04-12 14:26:17 +02:00
shati-patel
1e1594b2a7
Use fsPath instead of path everywhere
2023-04-12 13:14:20 +01:00
shati-patel
636be05f2b
Fix "invalid characters" bug on Windows
...
We now use `fsPath` instead of `path`.
Note: I haven't yet fixed the tests, nor checked manually on mac/linux
Tangential change: we now use the `dirname` method, instead of manually splitting paths to get a parent folder.
2023-04-12 12:51:13 +01:00
Koen Vlaswinkel
3664803b34
Add tests for creating model file
2023-04-12 12:50:31 +02:00
Koen Vlaswinkel
9bc53443c4
Fix tests for creating new model file
2023-04-12 12:26:30 +02:00
Koen Vlaswinkel
2c31335908
Merge branch 'koesie10/pick-extension-model-file' into koesie10/create-extension-model-file
2023-04-12 12:08:32 +02:00
Koen Vlaswinkel
5cdf7ed76f
Fix model file label on Windows
2023-04-12 12:04:17 +02:00
Elena Tanasoiu
3087886400
Fix problem with detecting storage folder on windows
...
The `getFirstStoragePath()` method would break on windows:
```
Path contains invalid characters: /c:/git-repo/codespaces-codeql (codeQL.createSkeletonQuery)
```
This makes sense, since we're looking to get the parent folder by splitting for `/`.
In windows, paths use `\` instead of `/`.
So let's detect the platform and add a test for this case.
2023-04-12 09:47:00 +00:00
Elena Tanasoiu
a6ffb6b020
Move back mockCli into beforeEach
...
This was an attempt to make the tests run in a shorter timeframe, but
we've gone with increasing the timeout to 40s.
2023-04-12 09:38:43 +00:00
Elena Tanasoiu
72b2080b02
Rename search methods
...
To be consistent with other database item search methods, we're renaming
ours:
`digForDatabaseItem` -> `findDatabaseItemByNwo`
and
`digForDatabaseItemSameLanguage` -> `findDatabaseItemByLanguage`
2023-04-12 09:38:43 +00:00
Elena Tanasoiu
6b26323ee0
Move database Item search methods into skeleton wizard
...
And the tests for it. We can now re-use the factory from the previous commit.
2023-04-12 09:38:43 +00:00
Elena Tanasoiu
0ff2e83fde
Move db mocking into factory file
...
So we can re-use it.
2023-04-12 09:38:43 +00:00
Koen Vlaswinkel
89c318bdc6
Rename extensions-packs.ts to extension-pack-picker.ts
2023-04-12 11:38:07 +02:00
Elena Tanasoiu
de4afae0a0
Don't track when user doesn't provide repo
2023-04-12 09:17:01 +00:00
Elena Tanasoiu
389d8f04d9
Don't show progress when choosing repo
2023-04-12 09:17:01 +00:00
Koen Vlaswinkel
a876c2ddb7
Add tests for extension pack and model file selection
2023-04-12 11:12:05 +02:00
Elena Tanasoiu
e4406f4c07
Merge branch 'main' into elena/yer-a-wizard-query
2023-04-12 09:47:11 +01:00
Koen Vlaswinkel
cdb6e8a3d3
Move all progress reporting into extension packs file
2023-04-12 10:13:08 +02:00
Koen Vlaswinkel
035456cd31
Rename resolve extensions results
2023-04-12 10:10:41 +02:00
Koen Vlaswinkel
59c0610122
Do not show quick pick when there are no model files
2023-04-12 08:55:24 +02:00
Koen Vlaswinkel
656e7d6d8a
Improve data extension pattern checking
2023-04-12 08:54:51 +02:00
Koen Vlaswinkel
649a47d966
Show all found locations in output log
2023-04-12 08:50:51 +02:00
Elena Tanasoiu
919219c084
Show the user a selection box before downloading database
...
At the moment, we're always deciding which database to download for the
user for an example query.
We'd like to give them a chance to change the database, so here we're
adding a step where we're showing the user a selection box with the
suggested database pre-filled.
They can choose to type in a different database before continuing the
skeleton generation process.
2023-04-11 16:54:09 +00:00
Elena Tanasoiu
3e3eb0da0a
Re-use existing database if one for the same language is already downloaded
...
We'd like to select an existing database for our query, if on is
already downloaded and matches the query language.
Previously we were re-using the database if the language and name
matched (e.g. the name would be `github/codeql`).
2023-04-11 16:53:00 +00:00
Dave Bartolomeo
e8f39fea83
Merge remote-tracking branch 'origin/main' into dbartol/debug-adapter
2023-04-11 16:06:25 +00:00
Dave Bartolomeo
1cbfd0159e
Fix determineSelectedQuery tests
2023-04-11 11:50:44 -04:00
Koen Vlaswinkel
b0940e6da9
Merge pull request #2279 from github/koesie10/fix-result-view-selected
...
Fix empty result view when switching between queries
2023-04-11 17:33:58 +02:00
Dave Bartolomeo
19e083e473
Use type-safe VSCode commands
2023-04-11 11:22:45 -04:00
Robert
048428b237
Merge pull request #2294 from github/robertbrignull/no_distribution_install
...
Don't rate limit if no CLI is installed
2023-04-11 16:18:55 +01:00
Elena Tanasoiu
460da1ea08
Add language to list of params
2023-04-11 15:00:00 +00:00
Elena Tanasoiu
f4a8de0f6b
Don't count files that are not example<number>.ql
...
When we try to determine the next file name for our example query,
we only look at `example<n>.ql` files.
e.g. if the files in the folder are:
- `example.ql`
- `example2.ql`
- `MyQuery.ql`
we will create an `example3.ql` file.
Previously we were counting all existing `.ql` files.
2023-04-11 15:00:00 +00:00
Elena Tanasoiu
c7d9407a4c
Rename workoutNextFileName -> determineNextFileName
2023-04-11 15:00:00 +00:00
Elena Tanasoiu
913942625c
Increase timeout for skeleton wizard tests
...
We've now added more tests and pushed the total duration over 5 seconds
for all the tests in this file.
This limitation seems to be a recent development where files with tests
that last longer than 5 seconds start failing in jest.
We're bumping the timeout limit to 40 seconds for now.
2023-04-11 14:59:59 +00:00
Elena Tanasoiu
62bebc02bd
Set storage path after the user selects language
...
And add tests for getFirstStoragePath method
2023-04-11 14:59:59 +00:00
Elena Tanasoiu
16a828938f
Shorten logic for deciding when to ask for language
...
Let's only ask for the language when the language is not provided OR it's invalid.
Let's also add tests for these cases.
2023-04-11 14:59:59 +00:00
Elena Tanasoiu
59909e20b0
Convert folderName property into getter method
2023-04-11 14:59:59 +00:00
Elena Tanasoiu
b794427778
Remove unnecessary casting to DatabaseItem
2023-04-11 14:59:59 +00:00
Elena Tanasoiu
97fb4ea2ed
Use Record
2023-04-11 14:59:59 +00:00
Elena Tanasoiu
911c3af225
Use a regular const instead of storing this on the class
2023-04-11 14:59:59 +00:00
Elena Tanasoiu
f949eda5ff
Fix error message
2023-04-11 14:59:59 +00:00
Elena Tanasoiu
9c0deaec96
Make it clear we're checking the filename
...
Replaces `file[0]` with a more meaningful `filename`.
2023-04-11 14:59:58 +00:00
Elena Tanasoiu
fe3e9a713b
Get rid of unnecessary ternary
2023-04-11 14:59:58 +00:00
Elena Tanasoiu
30011aaf65
Fail gracefully if we can't open the new query file
2023-04-11 14:59:58 +00:00
Elena Tanasoiu
061f347ea0
Don't obfuscate assignment when we choose language
...
Instead of assigning this property in a method, let's make the method
return a value and assign it more visibly.
2023-04-11 14:59:58 +00:00
Elena Tanasoiu
95ed076047
Shorten beforeEach to decrease chances of timeout
2023-04-11 14:59:58 +00:00
Elena Tanasoiu
c23b0bf6c8
Replace github/codeql with top databases for querying
...
We initially defined the default database to download as one from the
`github/codeql` repo as it was convenient.
However, this repo doesn't have a lot of vulnerabilities to discover.
Let's use repos that are in our MRVA top 10 list to allow users to
write more interesting queries.
2023-04-11 14:59:58 +00:00
Elena Tanasoiu
121ebc24a6
skeleton-query.ts -> skeleton-query-wizard.ts
2023-04-11 14:59:58 +00:00
Elena Tanasoiu
f212804634
Make "Create Query" command work with vscode-codeql-starter
...
We set up the "Create Query" command with the assumption that
the first folder in the workspace is the parent folder.
This is true for the `codespaces-codeql` repo where we expect
to use this command.
However, for the `vscode-codeql-starter` repo, the top level
folders are QL packs:
- codeql-custom-queries-cpp
- codeql-custom-queries-ruby
... etc.
In order to make the command work for people using the starter
repo, we'll need to introduce a check for these QL packs when
we decide the storage path.
The end goal is to replace the starter workspace completely
with the codespaces-codeql repo, so this code can be removed
in the future when we retire the repo.
Until then, the command will need this to be able to work in
both starter workspaces.
2023-04-11 14:59:57 +00:00
Elena Tanasoiu
b9decd8f80
Create QL pack in workspace instead of global storage
...
We were initially using the storage path of the extension.
We'd like to create these QL packs in the workspace instead.
2023-04-11 14:59:57 +00:00
Elena Tanasoiu
22d9487ab8
Be able to specify language when downloading github database
...
We offer `github/codeql` as a repo to use for downloading databases
for our skeleton pack.
Once the repo is specified, the user is prompted to choose a language.
At this point, we already know what language the user wants, so let's
change the `downloadGitHubDatabase` and `convertGithubNwoToDatabaseUrl`
methods to accept a language parameter.
We check if the language is in the list of languages received in the
response. If it isn't, we still prompt the user.
2023-04-11 14:59:57 +00:00
Elena Tanasoiu
91c4c9189f
Introduce "Create Query" command
2023-04-11 14:59:57 +00:00
Elena Tanasoiu
ddd00d16b0
Introduce SkeletonWizard class
...
This will be triggered by a "Create Query" command.
It will:
- prompt the user for a language
- create a skeleton pack based on the language chosen
- download a database for the QL pack
- open the new query file
If the skeleton pack already exists, we just create a new query file
in the existing folder.
If the database is already downloaded, we just re-use it.
2023-04-11 14:59:57 +00:00
Elena Tanasoiu
e63f0fc0af
Be able to specify the name of the skeleton query file
...
We introduced this QlPackGenerator a while ago. It always creates an `example.ql` query file as part of the skeleton pack.
We'd like to set the name of the query file, since we'll allow the user to create queries multiple times in the same skeleton pack folder.
The folder will be named `codeql-custom-queries-${language}` and will first receive an `example.ql` file.
If the user then tries to create a new query for the same language, we'll just create an `example2.ql`, `example3.ql` etc. file in the existing folder.
2023-04-11 14:59:57 +00:00
Elena Tanasoiu
2995b0120d
Provide a way to search for database items by name and language
...
We'll use this to check whether a database for our ql pack already exists.
While there are other methods that search for a database item by URI, we
only have a language chosen by the user and an nwo ("github/codeql").
So let's introduce a way to search for the db based on the information we
have.
2023-04-11 14:59:57 +00:00
Elena Tanasoiu
053a1800a9
Export existing language prompt
...
We plan to ask the user to choose a language, before attempting
to download a corresponding database for them.
The functionality already exists, so let's re-use it.
2023-04-11 14:59:56 +00:00
Elena Tanasoiu
1a2e5d90df
Extract functionality to download GitHub database
...
This was nested in a method that included prompting the user for a
github repo.
We'd like to re-use this to download a database of our choice from
GitHub, based on which language a user chooses.
2023-04-11 14:59:56 +00:00
Koen Vlaswinkel
62619b2364
Switch to outputFile
...
`outputFile` will create the parent directory if it doesn't exist yet,
so this will allow users to specify a sub-directory for the model file.
2023-04-11 16:58:29 +02:00
Koen Vlaswinkel
a61bae45f0
Allow creating new model file in existing data extension
...
This will allow a user to create a new model file in an existing data
extension when opening the data extension editor. There is some
validation on the name of the model file, which depends on reading in
the qlpack.
2023-04-11 16:55:31 +02:00
Koen Vlaswinkel
957f71c9d4
Merge pull request #2293 from github/koesie10/use-data-extensions-in-editor
...
Use data extensions for finding external API calls
2023-04-11 16:01:26 +02:00
Koen Vlaswinkel
2053b5db2f
Add configurable model filename to data extension editor
...
This adds a pickable model filename from an existing extension pack to
the data extensions editor. This allows the user to edit one of their
existing data extensions. This does not yet add the ability to create
new extension packs and/or new model files.
This uses the `codeql resolve extensions` command to get the list of
available model files. This should be available in all CLI versions
which the data extensions editor supports.
2023-04-11 14:41:06 +02:00
Robert
361cb60044
Don't rate limit if no CLI is installed
2023-04-11 12:45:48 +01:00
Koen Vlaswinkel
ae08a1b598
Use data extensions for finding external API calls
...
The data extension editor was only using the default data extensions
found in the `ql` submodule to find external API calls. This will add
support for using data extensions found in the workspace.
Rather than using the `codeQL.runningQueries.useExtensionPacks` setting,
this will always include data extensions since the editor doesn't make
sense to use without data extensions. We will also forbid the user from
opening this view unless they are using a CLI which supports data
extension packs.
2023-04-11 13:31:51 +02:00
Charis Kyriakou
deb2b83642
Update selected code flow when data flow paths change ( #2288 )
2023-04-11 11:02:03 +01:00
Koen Vlaswinkel
0115259778
Merge pull request #2271 from github/koesie10/data-extension-editor-cli-tests
...
Split and add tests for external API usages query
2023-04-11 11:46:29 +02:00
Koen Vlaswinkel
ccf9466fd9
Merge pull request #2260 from github/koesie10/data-extension-editor-stories
...
Add stories for data extension editor
2023-04-11 11:19:04 +02:00
Koen Vlaswinkel
6dfa726110
Merge remote-tracking branch 'origin/main' into koesie10/data-extension-editor-cli-tests
2023-04-11 11:13:07 +02:00
Koen Vlaswinkel
9f3baadee9
Rename getResults to readQueryResults
2023-04-11 11:10:45 +02:00
Koen Vlaswinkel
ad3a728012
Merge pull request #2267 from github/koesie10/data-extension-editor-generate-flow-model
...
Add generating of flow model to data extension editor
2023-04-11 11:07:30 +02:00
Koen Vlaswinkel
24c40af78f
Add comment to @ts-ignore
2023-04-11 10:31:37 +02:00
Koen Vlaswinkel
41e0dc2961
Remove unnecessary null check
2023-04-11 10:30:32 +02:00
Koen Vlaswinkel
102976e167
Use functions instead of class for generating flow model
...
We were using a single-use class for generating the flow model, while we
are actually able to do it using two functions. This is more in line
with our existing codebase.
2023-04-11 10:27:46 +02:00
Koen Vlaswinkel
4e8df309fb
Add comments for adding flow database
2023-04-11 10:22:10 +02:00
Dave Bartolomeo
7dfa52bbab
Debugger tests
2023-04-10 18:18:07 -04:00
Andrew Eisenberg
cbebeec2a1
Update changelog
2023-04-06 14:10:45 -07:00
Andrew Eisenberg
e12fe3f810
Restart query server when external config changes
...
This avoids manually restarting the query server when this file changes.
2023-04-06 14:08:01 -07:00
Dave Bartolomeo
0a0a9c6428
Fix bad merge
2023-04-06 14:27:09 -04:00
Dave Bartolomeo
61df133f1b
Merge remote-tracking branch 'origin/koesie10/fix-result-view-selected' into dbartol/debug-adapter-backup
2023-04-06 17:42:14 +00:00
Dave Bartolomeo
f182f423c2
Merge remote-tracking branch 'origin/main' into dbartol/debug-adapter-backup
2023-04-06 13:41:34 -04:00
Nora
36f7555fdd
Merge pull request #2281 from github/nora/refactor-repo-task
...
Repo task: new data model and mapping
2023-04-06 18:12:19 +02:00
Nora
2cb5928cd8
Remove unnecessary directory creation that is handled by outputJson
2023-04-06 14:58:29 +00:00
Nora
2963d7eb5f
Remove unnecessary return statements in repo task and repo states
2023-04-06 14:58:29 +00:00
Nora
1beddf7640
Map data types
2023-04-06 14:58:29 +00:00
Nora
f21117e5dd
Extract read and write to store
2023-04-06 14:58:29 +00:00
Koen Vlaswinkel
dbc7f90c20
Throw error instead of returning undefined
2023-04-06 16:54:20 +02:00
Koen Vlaswinkel
af8e0bb454
Rename getAddsTo
2023-04-06 16:49:20 +02:00
Koen Vlaswinkel
18db74ed2d
Add type check for query results
2023-04-06 16:35:04 +02:00
Koen Vlaswinkel
d5403ad926
Introduce type for modeled method with signature
2023-04-06 16:33:43 +02:00
Koen Vlaswinkel
fcc937657d
Merge pull request #2280 from github/koesie10/fix-webview-disposed
...
Fix error when closing MRVA webview during extension activation
2023-04-06 16:33:26 +02:00
Koen Vlaswinkel
0d00e5c5b7
Remove undefined from readModeledMethod return type
2023-04-06 16:27:34 +02:00
Koen Vlaswinkel
3214a376ad
Clarify definitions to be extensible predicate definitions
2023-04-06 16:24:25 +02:00
Koen Vlaswinkel
5a3a1a5cd7
Add comment for flow model progress
2023-04-06 16:23:10 +02:00
Koen Vlaswinkel
d3ff87ab71
Update language used for generating modeled methods
2023-04-06 16:21:48 +02:00
Koen Vlaswinkel
42d4034744
Extract getting ql submodule folder to function
2023-04-06 16:20:01 +02:00
Koen Vlaswinkel
4fa229f8a2
Rename generateExternalApi to generateModeledMethods
2023-04-06 16:16:37 +02:00
Nora
15a9093c98
Merge pull request #2270 from github/nora/model-repo-states
...
Repo States: new data model and mapping
2023-04-06 15:26:26 +02:00
Nora
1595d6f4aa
Fix default and use assertNever
2023-04-06 12:59:30 +00:00
Koen Vlaswinkel
6c95ac7c79
Fix error when closing MRVA webview during extension activation
...
This fixes the "Webview is disposed" error which occurs when the user
closes the variant analysis webview while the extension is still
activating. We will now check whether the webview is disposed before
restoring the view.
2023-04-06 14:57:58 +02:00
Nora
103070ee7a
Use shorthand
2023-04-06 12:52:45 +00:00
Nora
7e3c0265fe
Use new methods in test
2023-04-06 12:49:14 +00:00
Nora
8eaf1e9adc
Retain error message
2023-04-06 12:48:53 +00:00
Koen Vlaswinkel
978af54e2a
Fix potential concurrency bug in results view
...
This was pointed out by CodeQL: when calling `setState` and using
`this.props`, it may not be up-to-date because `setState` may run
concurrently. Therefore, we should use the `setState` callback variant
to ensure we get the latest props.
This refactors the code a bit to ensure we're not using `this.props`
anywhere, including in the `getResultSets` function which is called
in the `setState` callback.
2023-04-06 14:25:11 +02:00
Koen Vlaswinkel
84928fa2fe
Add test for empty result view bug
2023-04-06 14:10:58 +02:00
Koen Vlaswinkel
2a4a91207a
Fix empty result view when switching between queries
...
When updating to React 18, we removed the loading step from the updating
of the state of the result view since React would batch the updates
anyway. However, this caused a bug where the result view would be empty
when switching between queries. This is because the result view would
retain the old selected result set name. This would not happen
previously because React would re-render the view at least once, which
would cause the result view to be unmounted and re-created.
This fixes it by resetting the selected result set if we can't find the
result set in the new result sets.
2023-04-06 13:58:15 +02:00
Koen Vlaswinkel
bb05220b2c
Fix Babel compilation error
...
The default Storybook Babel config did not recognize the `public`
keyword in our custom errors (e.g. `ExhaustivityCheckingError`
and `RedactableError`). To fix this, we can use Storybook's V7 mode to
supply a custom Babel config. This fixes the compilation error.
See: https://storybook.js.org/docs/react/configure/babel
2023-04-06 13:35:10 +02:00
Koen Vlaswinkel
1bcc13af7c
Add story for DataExtensionsEditor
2023-04-06 13:35:04 +02:00
Koen Vlaswinkel
3ae16d9534
Add story for MethodRow
2023-04-06 13:32:10 +02:00
Koen Vlaswinkel
0b1b03d5b0
Merge remote-tracking branch 'origin/main' into koesie10/data-extension-editor-cli-tests
2023-04-06 12:46:36 +02:00
Koen Vlaswinkel
083cf44f66
Merge remote-tracking branch 'origin/main' into koesie10/data-extension-editor-generate-flow-model
2023-04-06 12:43:51 +02:00
Koen Vlaswinkel
3628f4bf36
Merge pull request #2266 from github/koesie10/data-extension-editor-jump-to-usage
...
Add link to example usage in data extensions editor
2023-04-06 12:18:35 +02:00
Nora
3f5bc85004
Map enum properly
2023-04-06 09:58:08 +00:00
Nora
14ad348f24
new repo states data type and mapping
2023-04-06 09:58:07 +00:00
Nora
84fd198391
Merge pull request #2242 from github/nora/query-history-refactoring
...
Query History: create and map data model to domain model
2023-04-06 11:40:18 +02:00
Koen Vlaswinkel
a1809b0bac
Merge similar messages for adding modeled methods
2023-04-06 11:22:52 +02:00
Koen Vlaswinkel
f78f535a95
Merge remote-tracking branch 'origin/main' into koesie10/data-extension-editor-generate-flow-model
2023-04-06 11:21:04 +02:00
Koen Vlaswinkel
b3ce6423d3
Merge remote-tracking branch 'origin/main' into koesie10/data-extension-editor-jump-to-usage
2023-04-06 11:18:17 +02:00
Nora
e62142b780
Introduce data models and refactor mapper
2023-04-06 09:17:42 +00:00
Koen Vlaswinkel
20e937026d
Merge pull request #2265 from github/koesie10/data-extension-editor-yaml-load
...
Load existing data extension YAML in editor
2023-04-06 11:16:41 +02:00
Koen Vlaswinkel
c0818d86d9
Move creation of YAML string from webview to extension
2023-04-06 10:52:46 +02:00
Koen Vlaswinkel
82f96178bf
Move loading of YAML from webview to extension
2023-04-06 10:49:01 +02:00
Koen Vlaswinkel
2da21a41bc
Merge remote-tracking branch 'origin/main' into koesie10/data-extension-editor-jump-to-usage
2023-04-06 10:43:30 +02:00
Koen Vlaswinkel
df2e22bad2
Merge remote-tracking branch 'origin/main' into koesie10/data-extension-editor-yaml-load
2023-04-06 10:36:59 +02:00
Koen Vlaswinkel
d60bcf31a8
Merge pull request #2264 from github/koesie10/data-extension-editor-yaml
...
Add saving of data extension editor table to YAML
2023-04-06 10:35:46 +02:00
Koen Vlaswinkel
9f78092857
Merge pull request #2276 from github/koesie10/markdown-lint-ci
...
Add markdownlint to CI
2023-04-06 10:26:11 +02:00
Koen Vlaswinkel
3945f64ace
Add alias for yaml imports
2023-04-06 10:15:20 +02:00
Koen Vlaswinkel
fa1200ddf9
Rename loadExistingYaml
2023-04-06 10:14:29 +02:00
Koen Vlaswinkel
083b736aec
Change getter to method
2023-04-06 10:12:52 +02:00
Koen Vlaswinkel
f35d11bc9c
Merge branch 'main' into koesie10/markdown-lint-ci
2023-04-06 10:11:58 +02:00
Koen Vlaswinkel
7470e72e76
Merge pull request #2269 from github/koesie10/upgrade-ts-jest
...
Upgrade ts-jest
2023-04-06 09:52:47 +02:00
Koen Vlaswinkel
ae40ae4f9a
Merge branch 'main' into koesie10/upgrade-ts-jest
2023-04-06 09:40:35 +02:00
Koen Vlaswinkel
82e3d48533
Merge pull request #2275 from github/koesie10/markdown-lint-generated-files
...
Fix markdownlint errors for generated files
2023-04-06 09:33:27 +02:00
Dave Bartolomeo
d0c405a0d8
QuickEval and other debug commands
2023-04-05 14:15:09 -04:00
Koen Vlaswinkel
df04f39651
Merge branch 'main' into koesie10/markdown-lint-generated-files
2023-04-05 17:19:49 +02:00
Koen Vlaswinkel
80cbaf9e7c
Merge branch 'koesie10/data-extension-editor-yaml-load' into koesie10/data-extension-editor-generate-flow-model
2023-04-05 17:06:49 +02:00
Koen Vlaswinkel
478d683743
Merge branch 'koesie10/data-extension-editor-yaml' into koesie10/data-extension-editor-yaml-load
2023-04-05 17:03:29 +02:00
Koen Vlaswinkel
64723d03b1
Merge remote-tracking branch 'origin/main' into koesie10/data-extension-editor-yaml
2023-04-05 17:00:18 +02:00
Koen Vlaswinkel
97af137252
Merge pull request #2263 from github/koesie10/data-extensions-editor-calls
...
Show external API calls in data extensions editor
2023-04-05 16:55:20 +02:00
Koen Vlaswinkel
c4f61553d4
Merge branch 'main' into koesie10/data-extensions-editor-calls
2023-04-05 16:43:32 +02:00
Koen Vlaswinkel
5d7d1b25ab
Merge pull request #2268 from github/markdown-lint-local
...
Set up markdownlint with GitHub's additional rules in VSCode and as npm script
2023-04-05 16:41:40 +02:00
Koen Vlaswinkel
f7bcd58100
Add markdownlint to CI
2023-04-05 16:41:34 +02:00
Koen Vlaswinkel
f062f8b821
Fix markdownlint errors for generated files
2023-04-05 16:40:47 +02:00
Robert
e455e57124
Merge pull request #2272 from github/robertbrignull/splitCommand/codeQL.monitorVariantAnalysis
...
Split up codeQL.monitorVariantAnalysis command
2023-04-05 15:35:21 +01:00
Sam Partington
f277b85554
Add more exclusions
2023-04-05 15:07:10 +01:00
Robert
3b7861edfc
Merge branch 'main' into robertbrignull/splitCommand/codeQL.monitorVariantAnalysis
2023-04-05 14:55:19 +01:00
github-actions[bot]
1b43e989ab
Bump CLI version from v2.12.5 to v2.12.6 for integration tests ( #2274 )
...
Co-authored-by: github-actions[bot] <github-actions@github.com >
2023-04-05 13:39:02 +00:00
Sam Partington
7a5e654a80
Add comment about base config
...
https://github.com/github/vscode-codeql/pull/2268#discussion_r1158488461
2023-04-05 14:35:07 +01:00
Sam Partington
bd7eea6cc0
Clarify which extension
...
https://github.com/github/vscode-codeql/pull/2268#discussion_r1158475799
2023-04-05 14:24:39 +01:00
Robert
e84d488005
Merge pull request #2273 from github/robertbrignull/splitCommand/codeQL.restartQueryServer
...
Split up codeQL.restartQueryServer command
2023-04-05 14:23:07 +01:00
Koen Vlaswinkel
d402d86589
Add comment about progress max step
2023-04-05 15:14:25 +02:00
Robert
145764c39b
Split up codeQL.restartQueryServer command
2023-04-05 13:35:40 +01:00
Koen Vlaswinkel
5ce3b22351
Add tests for external API query
...
This adds tests for the external API query and retrieving of results. It
does not use the "real" CLI integration, but instead mocks the CLI
server and query runner.
To make mocking easier and require less type casting, I've narrowed some
of the arguments of some other functions. They now use `Pick` to only
require the properties they need.
2023-04-05 13:58:58 +02:00
Sam Partington
b2f817d9f1
Ensure vscode extension considers github-markdownlint config
2023-04-05 12:50:52 +01:00
Sam Partington
e85cba8999
Fix duplicate headers, remove rule-disablement
2023-04-05 12:43:09 +01:00
Robert
322293449a
Split up codeQL.monitorVariantAnalysis command
2023-04-05 12:42:02 +01:00
Sam Partington
b0029bfbc4
Fix markdown that was treated as HTML
2023-04-05 12:34:39 +01:00
Sam Partington
9855bef84a
Remove bare links
2023-04-05 12:32:45 +01:00
Sam Partington
951a520bdb
Ensure github-markdownlint rules considered for all linting
2023-04-05 12:25:21 +01:00
Sam Partington
6458690d9f
Move common markdownlint config to top-level file
2023-04-05 12:11:49 +01:00
Koen Vlaswinkel
c245f338f5
Extract external API usage query to separate file
2023-04-05 12:36:44 +02:00
Koen Vlaswinkel
c02374125e
Upgrade ts-jest
...
The version of ts-jest we were using was given a warning that it did
not support TypeScript 5, even though it was working fine. The latest
version of ts-jest adds official support for TypeScript and removes the
warning.
2023-04-05 11:49:20 +02:00
Koen Vlaswinkel
d9b362ddff
Add simple error handling to external API usage extraction
2023-04-05 11:33:00 +02:00
Sam Partington
56b36baa82
Move config file to right place in relation to node_modules
...
https://github.com/github/vscode-codeql/pull/2268#pullrequestreview-1371042057
Still need to consider how to ensure that the extension picks
up the right config.
2023-04-05 10:26:43 +01:00
Koen Vlaswinkel
e37da4f6a4
Small clean-up of MethodRow
2023-04-05 11:22:57 +02:00
Koen Vlaswinkel
8ec753fb6c
Extract supported percentage calculation to separate file
2023-04-05 11:21:17 +02:00
Koen Vlaswinkel
e300b40ee5
Rename MethodRow parameters to be in line with type
2023-04-05 11:15:05 +02:00
Koen Vlaswinkel
4b54679ee9
Add simple unit test for BQRS decoding to external API usages
2023-04-05 11:14:04 +02:00
Koen Vlaswinkel
d51ff42ab3
Extract external API usage from BQRS in the extension
2023-04-05 11:03:31 +02:00
Koen Vlaswinkel
8741ba9379
Rename externalApiInfo to signature
2023-04-05 10:57:35 +02:00
Koen Vlaswinkel
115b807b23
Initialize query storage dir in data extension module
2023-04-05 10:55:07 +02:00
Koen Vlaswinkel
7baf11f6c0
Split the data extensions editor domain models file
2023-04-05 10:50:23 +02:00
Dave Bartolomeo
d489d0ec1f
QuickEval
2023-04-04 17:43:04 -04:00
Sam Partington
b51d731b70
Add missing trailing newline
2023-04-04 16:56:41 +01:00
Sam Partington
fa8ad791cf
Fix markdown in testing.md
2023-04-04 16:14:27 +01:00
Sam Partington
404ad65f92
Fix markdown in test-plan.md
2023-04-04 16:08:47 +01:00
Sam Partington
7a48cc0dc6
Fix violations in releasing doc
2023-04-04 16:01:42 +01:00
Sam Partington
c86dcafd2e
Fix generic links
2023-04-04 15:59:57 +01:00
Sam Partington
767f9934e9
Lint the whole codebase, not just the extension folders
2023-04-04 15:58:20 +01:00
Nora
9015a57732
Merge pull request #2261 from github/nora/repo-states-refactoring
...
Repo States: Extract read/write methods to repo states store
2023-04-04 14:45:09 +02:00
Koen Vlaswinkel
7f65122adb
Add generating of flow model to data extension editor
...
This adds the automatic generation of sources/sinks/summary flows to the
data extension editor using the flow model queries. This is based on the
Python script available in the CodeQL repo.
See: https://github.com/github/codeql/blob/main/java/ql/src/utils/modelgenerator/GenerateFlowModel.py
2023-04-04 13:54:35 +02:00
Koen Vlaswinkel
06cf608ed4
Add link to example usage in data extensions editor
...
This will allow a user to click on the number of usages to jump to an
example usage in the code.
2023-04-04 13:47:10 +02:00
Sam Partington
ec17cbd8a9
Indent images to show markdownlint they're part of the list
2023-04-04 12:45:19 +01:00
Sam Partington
7ba52de3fe
Give link some non-generic text
2023-04-04 12:38:35 +01:00
Koen Vlaswinkel
ef7ee9ef3d
Load existing data extension YAML in editor
...
This loads in the existing data extension YAML file for the selected
database. It only supports the filename we save it to, and will not load
it from any other data extension YAML files.
2023-04-04 13:37:34 +02:00
Sam Partington
5ddd2b385a
Disable rule for a couple of specific instances
2023-04-04 12:35:48 +01:00
Koen Vlaswinkel
6d133f800f
Add saving of data extension editor table to YAML
...
This adds the ability to save the modeled methods in the data extensions
editor to a YAML file named after the database name. It will save it to
the `ql` submodule for now. Support for data extension packs will be
added later.
2023-04-04 13:32:52 +02:00
Sam Partington
cc091eec47
Fix list style
...
We may want to disable this rule, but the change is worthwhile
here for consistency
2023-04-04 12:31:12 +01:00
Sam Partington
888b9b8aa6
Ensure markdownlint can find config when run as script
2023-04-04 12:29:54 +01:00
Sam Partington
1fb4ebe18a
Ignore certain linting rules
2023-04-04 12:25:15 +01:00
Sam Partington
03638f5558
Install markdownlint VSCode extension, CLI and github config
...
cf https://github.com/github/markdownlint-github
2023-04-04 12:24:58 +01:00
Koen Vlaswinkel
73bd6d696c
Show external API calls in data extensions editor
...
This updates the view of the data extensions editor to show a table of
possible sources/sinks/flow summaries that can be edited. It's not yet
possible to save the changes or load the existing file.
2023-04-04 13:17:16 +02:00
Koen Vlaswinkel
60e39636e7
Merge pull request #2262 from github/koesie10/data-extension-editor-setup
...
Add empty data extension editor view
2023-04-04 12:52:41 +02:00
Koen Vlaswinkel
478c095d65
Add empty data extension editor view
...
This adds an empty data extension editor view which is only available
behind the `codeQL.dataExtensions.editor` and `codeQL.canary` settings.
2023-04-04 12:14:19 +02:00
Koen Vlaswinkel
35cb1137e8
Merge pull request #2258 from github/koesie10/upgrade-storybook
...
Upgrade Storybook for TS 5.0 compatibility
2023-04-04 11:30:19 +02:00
Nora
2464537467
Extract read/write to extra file
2023-04-04 09:00:14 +00:00
Koen Vlaswinkel
78337543df
Upgrade Storybook for TS 5.0 compatibility
...
This upgrades Storybook to an alpha version to ensure we can start
Storybook when using TypeScript 5.0. This is temporary until we can
upgrade to Storybook 7 or to a released version of 6.5.17.
2023-04-03 15:26:19 +02:00
Koen Vlaswinkel
0af341407c
Merge pull request #2168 from github/koesie10/react-strict-mode
...
Enable React strict mode
2023-04-03 11:13:04 +02:00
Koen Vlaswinkel
de521e8e48
Merge pull request #2252 from github/dependabot/npm_and_yarn/extensions/ql-vscode/typescript-5.0.2
...
Bump typescript from 4.6.4 to 5.0.2 in /extensions/ql-vscode
2023-04-03 11:08:39 +02:00
Koen Vlaswinkel
0015a59971
Merge pull request #2254 from github/dependabot/npm_and_yarn/extensions/ql-vscode/ts-loader-9.4.2
...
Bump ts-loader from 8.1.0 to 9.4.2 in /extensions/ql-vscode
2023-04-03 11:06:28 +02:00
Koen Vlaswinkel
fce8f87c10
Update types for updated TypeScript
2023-04-03 10:54:58 +02:00
Koen Vlaswinkel
2eb420b656
Merge branch 'main' into koesie10/react-strict-mode
2023-04-03 10:47:29 +02:00
Koen Vlaswinkel
980e27a6ca
Merge pull request #2167 from github/koesie10/react-18
...
Upgrade to React 18
2023-04-03 10:47:20 +02:00
Koen Vlaswinkel
e997dab8cf
Merge branch 'main' into koesie10/react-18
2023-04-03 10:14:38 +02:00
Koen Vlaswinkel
64503770e0
Merge pull request #2255 from github/koesie10/results-view-regression-unit-test
...
Add simple regression unit test for the results view
2023-04-03 10:14:26 +02:00
Dave Bartolomeo
4bba53d5ad
Merge pull request #2246 from github/dbartol/debug-extension-packs
...
Move extension pack resolution into `LocalQueries`
2023-03-31 14:36:35 -04:00
Dave Bartolomeo
b67e3b7c35
Merge pull request #2245 from github/dbartol/local-queries-commands
...
Move `LocalQueries` commands to be member functions
2023-03-31 14:31:44 -04:00
Koen Vlaswinkel
cb2b4f432a
Reduce nesting in if-statement
2023-03-31 16:13:22 +02:00
Koen Vlaswinkel
b4b020800e
Use getErrorMessage
2023-03-31 13:52:46 +02:00
Koen Vlaswinkel
918fb75fe3
Better error message and check for results info
2023-03-31 13:52:21 +02:00
Koen Vlaswinkel
d5610c1a6f
Add simple regression unit test for the results view
...
This adds a really simple regression unit test for the results view
which checks that the results view can render a SARIF file. This is
in preparation for the upgrade to React 18 to ensure that we don't
break the basic functionality of the results view.
2023-03-31 13:48:10 +02:00
Dave Bartolomeo
65b0cb4dc4
Merge remote-tracking branch 'origin/dbartol/local-queries-commands' into dbartol/debug-adapter
2023-03-30 16:11:06 +00:00
Dave Bartolomeo
e2017c7f0c
Support extensionPacks debug configuration
2023-03-30 12:10:22 -04:00
Dave Bartolomeo
055bfcd36f
Add extension packs to debug configuration
2023-03-30 15:07:56 +00:00
Dave Bartolomeo
a3306da1bc
Implement CodeQL debug adapter
2023-03-30 15:07:56 +00:00
Dave Bartolomeo
6e51d81a9b
Merge branch 'main' into dbartol/local-queries-commands
2023-03-30 10:33:43 -04:00
Dave Bartolomeo
0da5aab1e9
Merge branch 'main' into dbartol/debug-extension-packs
2023-03-30 10:33:16 -04:00
Dave Bartolomeo
dd9f6bf185
Merge pull request #2244 from github/dbartol/debug-context
...
Refactor local query evaluation to prepare for debug adapter
2023-03-30 10:23:11 -04:00
Dave Bartolomeo
110f5f9d07
Merge remote-tracking branch 'origin/main' into dbartol/debug-context
2023-03-30 10:09:08 -04:00
dependabot[bot]
9058814fcf
Bump ts-loader from 8.1.0 to 9.4.2 in /extensions/ql-vscode
...
Bumps [ts-loader](https://github.com/TypeStrong/ts-loader ) from 8.1.0 to 9.4.2.
- [Release notes](https://github.com/TypeStrong/ts-loader/releases )
- [Changelog](https://github.com/TypeStrong/ts-loader/blob/main/CHANGELOG.md )
- [Commits](https://github.com/TypeStrong/ts-loader/compare/v8.1.0...v9.4.2 )
---
updated-dependencies:
- dependency-name: ts-loader
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-30 14:00:11 +00:00
dependabot[bot]
875f894741
Bump typescript from 4.6.4 to 5.0.2 in /extensions/ql-vscode
...
Bumps [typescript](https://github.com/Microsoft/TypeScript ) from 4.6.4 to 5.0.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases )
- [Commits](https://github.com/Microsoft/TypeScript/compare/v4.6.4...v5.0.2 )
---
updated-dependencies:
- dependency-name: typescript
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-30 13:58:59 +00:00
Dave Bartolomeo
c6309a9800
Show warning instead of error when using extension packs with legacy query server
2023-03-30 09:53:33 -04:00
Koen Vlaswinkel
8a4f2837e2
Merge pull request #2249 from github/koesie10/improve-monitor-error-message
...
Improve monitor error message
2023-03-30 11:40:38 +02:00
Robert
1e004514ea
Merge pull request #2237 from github/robertbrignull/use_app_commands_6
...
Convert call sites to use typed commands (part 6): createVSCodeCommandManager in tests
2023-03-30 10:30:26 +01:00
Dave Bartolomeo
aef836f9b1
Move LocalQueries commands to be member functions
2023-03-29 18:20:11 +00:00
Dave Bartolomeo
41e0702d3a
Update extensions/ql-vscode/src/run-queries-shared.ts
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2023-03-29 14:15:05 -04:00
Koen Vlaswinkel
0bf01274e8
Merge pull request #2248 from github/koesie10/fail-vsce-workflow-on-failure
...
Fail VSCE workflow on failure
2023-03-29 16:00:22 +02:00
Koen Vlaswinkel
91af71dbb6
Merge pull request #2247 from github/koesie10/use-gh-release-create
...
Use gh release create instead of deprecated actions
2023-03-29 16:00:07 +02:00
Koen Vlaswinkel
b06d935256
Improve monitor error message
...
This will improve the error message shown when monitoring fails. Instead
of showing "Error while monitoring variant analysis: Not Found", this
will now show "Error while monitoring variant analysis "Empty block
(javascript) [29/3/2023 10:45:10]: Not Found". This should make it
easier for the user to figure out which query history item is
problematic.
We're not using the full query history item label here because that
would require access to the query history item, which we don't yet have
here. Adding it here would add a dependency on the query history, which
seems undesirable.
2023-03-29 14:43:07 +02:00
Koen Vlaswinkel
70aa6df6c4
Fail VSCE workflow on failure
...
We were ignoring errors coming from `vsce publish` and this was causing
the workflow to succeed even when the publish failed. This will remove
the `||` and let the workflow fail if the publish fails.
2023-03-29 12:56:41 +02:00
Koen Vlaswinkel
58a1e27e64
Use gh release create instead of deprecated actions
2023-03-29 12:09:34 +02:00
Dave Bartolomeo
c712b2999c
Merge branch 'dbartol/debug-context' of https://github.com/github/vscode-codeql into dbartol/debug-context
2023-03-28 18:52:38 -04:00
Dave Bartolomeo
d84baedb52
Use default value for id parameter of createQueryRun()
2023-03-28 18:51:19 -04:00
Dave Bartolomeo
a8cd9c2abb
Fix bad param reference
2023-03-28 18:46:27 -04:00
Dave Bartolomeo
62cd4e3c64
Move extension pack resolution into LocalQueries
...
This way the debug configuration will be able to override it.
2023-03-28 18:26:33 -04:00
Dave Bartolomeo
24ecd6feb8
Update extensions/ql-vscode/src/run-queries-shared.ts
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2023-03-28 18:24:54 -04:00
Dave Bartolomeo
a00db34999
Mock CancellationToken slightly better
2023-03-28 17:24:00 -04:00
Dave Bartolomeo
f247687dd9
Better encapsulation of LocalQueryRun
2023-03-28 13:19:04 -04:00
Dave Bartolomeo
39e7caa972
Fix feedback
2023-03-28 12:59:27 -04:00
Dave Bartolomeo
2cb329bf03
Remove redundant check for custom log directory
2023-03-28 12:56:35 -04:00
Dave Bartolomeo
258cb55de0
Fix the _other_ typo
2023-03-28 12:52:49 -04:00
Dave Bartolomeo
b358f11e62
Fix integration tests on Windows
2023-03-28 12:05:58 -04:00
Dave Bartolomeo
fb7a0c80e4
Fix typo
2023-03-28 11:32:07 -04:00
Dave Bartolomeo
bf0af78d9f
Remove unnecessary spread operator
2023-03-28 11:28:09 -04:00
Dave Bartolomeo
5251f06c0a
Add comment about QueryOutputDir as a base class of QueryEvaluationInfo
2023-03-28 11:26:47 -04:00
Shati Patel
e6efac0a92
Open correct tutorial workspace on Windows ( #2240 )
2023-03-28 15:26:10 +01:00
Robert
92d66c6297
Merge pull request #2234 from github/robertbrignull/use_app_commands_4_alt
...
Convert call sites to use typed commands (part 4): cleanDatabases
2023-03-28 15:18:00 +01:00
Robert
1043448222
Add types to command runners
2023-03-28 14:56:23 +01:00
Dave Bartolomeo
1acf31232e
Fix test expectation
2023-03-27 13:44:03 -04:00
Dave Bartolomeo
8c3fbb80b5
Fix test code
2023-03-27 13:20:29 -04:00
Dave Bartolomeo
4ddf1c2c1a
Merge remote-tracking branch 'origin/main' into dbartol/debug-context
2023-03-27 16:09:25 +00:00
Dave Bartolomeo
348e9231e3
Use LocalQueryRun in LocalQueries
2023-03-27 11:48:31 -04:00
Dave Bartolomeo
543bada323
Add comments
2023-03-27 11:00:34 -04:00
Andrew Eisenberg
23f783beef
Merge pull request #2238 from github/aeisenberg/restart-lang-server
2023-03-24 15:56:09 -07:00
Dave Bartolomeo
4019e6c9dd
Fix test code
2023-03-24 18:37:10 -04:00
Dave Bartolomeo
d004f206f7
Move UI-related code from QueryRunner into LocalQueries
2023-03-24 18:32:16 -04:00
Dave Bartolomeo
f99f465365
Refactor query evaluation code to separate UI concerns
2023-03-24 17:27:53 -04:00
Andrew Eisenberg
2e0023fb3c
Restart language server on command
...
Ensure that the language server is restarted when the "Restart
Query Server" command is invoked.
2023-03-24 10:22:14 -07:00
Robert
a27f58d489
Convert tests that call real commands to use createVSCodeCommandManager
2023-03-24 17:05:02 +00:00
Robert
1e4672bb4c
Merge pull request #2236 from github/robertbrignull/update_codeql_pack_lock
...
Commit autogenerated changes to codeql-pack.lock.yml
2023-03-24 16:37:55 +00:00
Robert
aecccf1af8
Commit autogenerated changes
2023-03-24 16:26:04 +00:00
Robert
d35ab77aaf
Merge pull request #2235 from github/robertbrignull/use_app_commands_5
...
Convert call sites to use typed commands (part 5): VariantAnalysisView
2023-03-24 14:45:21 +00:00
Robert
93436ad610
Convert extensions/ql-vscode/src/variant-analysis/variant-analysis-view.ts to call typed commands
2023-03-24 14:10:19 +00:00
Robert
d4a8eb9834
Merge pull request #2229 from github/robertbrignull/use_app_commands_3
...
Convert call sites to use typed commands (part 3)
2023-03-24 13:07:16 +00:00
Robert
d5fd39f9f8
Convert cleanDatabases to not use commands
2023-03-24 11:55:57 +00:00
Robert
3bdf6c5225
Merge branch 'main' into robertbrignull/use_app_commands_3
2023-03-24 11:41:16 +00:00
Nora
cd03002f42
Merge pull request #2231 from github/nora/rename-query-history-serialization
...
Rename query history read and write methods
2023-03-24 12:13:24 +01:00
Nora
3b42b6720d
Rename to readQueryHistoryFromFile
2023-03-24 11:00:52 +00:00
Robert
92f50afb19
Merge pull request #2230 from github/robertbrignull/activate_extension
...
Use undefined instead of Record<string, never> type when unable to activate extension
2023-03-24 10:37:12 +00:00
Robert
b14ebc6f2b
Remove ExtensionContext argument from VSCodeMockGitHubApiServer
2023-03-24 10:33:18 +00:00
Koen Vlaswinkel
7c74764367
Merge pull request #2225 from github/dependabot/npm_and_yarn/extensions/ql-vscode/glob-9.3.2
...
Bump glob from 7.2.0 to 9.3.2 in /extensions/ql-vscode
2023-03-24 11:28:15 +01:00
Robert
091216f6fe
Update error message
2023-03-24 10:23:30 +00:00
Robert
1326c0a9dc
Remove unnecessary checks
2023-03-24 10:23:19 +00:00
Koen Vlaswinkel
1c8eb33a0e
Remove glob-promise and upgrade to glob 9
...
The `glob` package now uses promises in version 9, so we don't need the
separate `glob-promise` package anymore.
This also updates one call site to use `cwd` instead of `join` to
avoid possible issues due to a breaking change in version 8 which treats
Windows path separators differently. By changing the `cwd`, we should
not run into these issues.
Removing the `resolutions` of `glob-parent` did not change the
`package-lock.json`, so this does not have any effect on the package
version we are using.
2023-03-24 10:45:17 +01:00
Nora
76ef7ff5b7
Rename read and write methods
2023-03-24 09:36:27 +00:00
dependabot[bot]
a7b3e3d31e
Bump glob from 7.2.0 to 9.3.2 in /extensions/ql-vscode
...
Bumps [glob](https://github.com/isaacs/node-glob ) from 7.2.0 to 9.3.2.
- [Release notes](https://github.com/isaacs/node-glob/releases )
- [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md )
- [Commits](https://github.com/isaacs/node-glob/compare/v7.2.0...v9.3.2 )
---
updated-dependencies:
- dependency-name: glob
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-24 08:16:52 +00:00
Charis Kyriakou
331c92e0dd
Merge pull request #2223 from github/dependabot/npm_and_yarn/extensions/ql-vscode/fs-extra-and-types/fs-extra-11.1.1
...
Bump fs-extra and @types/fs-extra in /extensions/ql-vscode
2023-03-24 08:15:02 +00:00
Robert
1b9a7f89c3
Remove Record<string, never> type when activating extension
2023-03-23 17:31:32 +00:00
Charis Kyriakou
770ec51810
Remove unnecessary mock setup
2023-03-23 16:47:03 +00:00
Robert
a630663681
Convert extensions/ql-vscode/src/variant-analysis/variant-analysis-monitor.ts to call typed commands
2023-03-23 16:35:36 +00:00
Charis Kyriakou
c9e0618884
Merge pull request #2224 from github/dependabot/npm_and_yarn/extensions/ql-vscode/msw-1.2.0
...
Bump msw from 0.49.0 to 1.2.0 in /extensions/ql-vscode
2023-03-23 16:30:00 +00:00
Charis Kyriakou
b65790b22b
Deal with request with no body
2023-03-23 16:14:11 +00:00
Elena Tanasoiu
1d3d8da063
Merge pull request #2227 from github/elena/disable-local-retry
...
Only retry tests in CI
2023-03-23 16:13:30 +00:00
Robert
7b53c471b6
Convert extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts to call typed commands
2023-03-23 16:04:17 +00:00
Robert
fc3bce8d41
Convert extensions/ql-vscode/src/variant-analysis/export-results.ts to call typed commands
2023-03-23 16:03:20 +00:00
Robert
b7edf1efec
Convert extensions/ql-vscode/src/query-server/queryserver-client.ts to call typed commands
2023-03-23 15:58:22 +00:00
Charis Kyriakou
8641b83506
Rename SetupServerApi to SetupServer
2023-03-23 15:56:53 +00:00
Koen Vlaswinkel
2a0fd46952
Merge branch 'koesie10/react-18' into koesie10/react-strict-mode
2023-03-23 16:54:49 +01:00
Koen Vlaswinkel
d4464c8662
Merge remote-tracking branch 'origin/main' into koesie10/react-18
2023-03-23 16:53:17 +01:00
Robert
f84bf2dba0
Convert extensions/ql-vscode/src/mocks/vscode-mock-gh-api-server.ts to call typed commands
2023-03-23 15:53:12 +00:00
Robert
6b3a235a77
Convert extensions/ql-vscode/src/log-insights/summary-language-support.ts to call typed commands
2023-03-23 15:53:12 +00:00
Elena Tanasoiu
07c79058af
Merge branch 'main' into elena/disable-local-retry
2023-03-23 15:36:33 +00:00
Elena Tanasoiu
c882a9fc14
Only retry tests in CI
...
We introduced this change to help with reducing flakiness in CI [1].
This has a slightly different effect locally, where every failed test
will output three times.
This in turn makes it harder to read, especially when you have multiple
failing tests.
Since the original intent for this behaviour was to be used in CI, I'm
proposing we disable it when the CI env variable isn't set.
I've opted to set it for all jobs involving tests, just for consistency.
I'm happy to limit it to just the places where it's required.
[1]: https://github.com/github/vscode-codeql/pull/2059
2023-03-23 15:28:51 +00:00
Robert
d56a986cc5
Merge pull request #2222 from github/robertbrignull/use_app_commands_2
...
Convert call sites to use typed commands (part 2): QueryHistoryManager
2023-03-23 15:07:31 +00:00
Koen Vlaswinkel
16b9abed43
Merge pull request #2220 from github/koesie10/update-unique-command-use-typed-commands
...
Add support for typed commands to CodeQL query
2023-03-23 16:00:33 +01:00
Charis Kyriakou
7837f3077c
Merge pull request #2221 from github/dependabot/npm_and_yarn/extensions/ql-vscode/octokit/plugin-throttling-5.0.1
...
Bump @octokit/plugin-throttling from 4.3.2 to 5.0.1 in /extensions/ql-vscode
2023-03-23 14:25:55 +00:00
Robert
180b84b3da
Use correct variable name
2023-03-23 14:25:15 +00:00
dependabot[bot]
53067f8249
Bump msw from 0.49.0 to 1.2.0 in /extensions/ql-vscode
...
Bumps [msw](https://github.com/mswjs/msw ) from 0.49.0 to 1.2.0.
- [Release notes](https://github.com/mswjs/msw/releases )
- [Changelog](https://github.com/mswjs/msw/blob/main/CHANGELOG.md )
- [Commits](https://github.com/mswjs/msw/compare/v0.49.0...v1.2.0 )
---
updated-dependencies:
- dependency-name: msw
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-23 14:02:27 +00:00
dependabot[bot]
faec3cda5d
Bump fs-extra and @types/fs-extra in /extensions/ql-vscode
...
Bumps [fs-extra](https://github.com/jprichardson/node-fs-extra ) and [@types/fs-extra](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/fs-extra ). These dependencies needed to be updated together.
Updates `fs-extra` from 10.0.1 to 11.1.1
- [Release notes](https://github.com/jprichardson/node-fs-extra/releases )
- [Changelog](https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jprichardson/node-fs-extra/compare/10.0.1...11.1.1 )
Updates `@types/fs-extra` from 9.0.6 to 11.0.1
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/fs-extra )
---
updated-dependencies:
- dependency-name: fs-extra
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: "@types/fs-extra"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-23 14:00:56 +00:00
dependabot[bot]
de0a8bf94d
Bump @octokit/plugin-throttling in /extensions/ql-vscode
...
Bumps [@octokit/plugin-throttling](https://github.com/octokit/plugin-throttling.js ) from 4.3.2 to 5.0.1.
- [Release notes](https://github.com/octokit/plugin-throttling.js/releases )
- [Commits](https://github.com/octokit/plugin-throttling.js/compare/v4.3.2...v5.0.1 )
---
updated-dependencies:
- dependency-name: "@octokit/plugin-throttling"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-23 13:59:20 +00:00
Robert
c84c69f529
Convert extensions/ql-vscode/src/vscode-utils/external-files.ts to call typed commands
2023-03-23 13:49:11 +00:00
Robert
a9e495118c
Convert extensions/ql-vscode/src/query-history/query-history-manager.ts to call typed commands
2023-03-23 13:49:11 +00:00
Robert
2e7952cb37
Pull tryOpenExternalFile out to a separate file so it can be more easily tested
2023-03-23 13:49:11 +00:00
Robert
6bcfdda0a9
Merge pull request #2217 from github/robertbrignull/use_app_commands_1
...
Convert call sites to use typed commands (part 1)
2023-03-23 13:18:49 +00:00
Robert
e0dd8c7392
Add comment about codeQLDatabases.focus
2023-03-23 13:04:30 +00:00
Koen Vlaswinkel
164536338b
Merge pull request #2219 from github/koesie10/fix-command-runner-references
...
Remove remaining references to `commandRunner`
2023-03-23 14:03:39 +01:00
Koen Vlaswinkel
f57bfb6875
Add support for typed commands to CodeQL query
...
This adds support for detecting the `CommandManager.execute` method in
the unique command use query.
This may not be the best way to implement this. There's a method
`hasUnderlyingType` on `this.getReceiver().getType()`, but I couldn't
really figure out how to get it recognize `CommandManager`. It might be
possible if we can construct the type of `CommandManager`, but this will
probably include the filepath to the `CommandManager` class, which might
not neccessarily be something we want: moving the `CommandManager` class
should not require updating the query. I'm very happy to hear other
suggestions.
2023-03-23 13:55:52 +01:00
Koen Vlaswinkel
d0c4e5b8c5
Remove remaining references to commandRunner
2023-03-23 13:30:06 +01:00
Koen Vlaswinkel
96c9a4aca7
Merge pull request #2215 from github/koesie10/rename-command-runner
...
Rename and move `commandRunner`
2023-03-23 13:20:49 +01:00
Robert
14dc391229
Convert extensions/ql-vscode/src/legacy-query-server/queryserver-client.ts to call typed commands
2023-03-23 11:42:14 +00:00
Robert
d7e061e159
Convert extensions/ql-vscode/src/databases/ui/db-panel.ts to use typed commands
2023-03-23 11:42:14 +00:00
Robert
2a2cb26597
Convert extensions/ql-vscode/src/test-ui.ts to call typed commands
2023-03-23 11:42:14 +00:00
Robert
ff418b5487
Convert extensions/ql-vscode/src/query-editor.ts to call typed commands
2023-03-23 11:42:14 +00:00
Robert
8b9003e845
Convert extensions/ql-vscode/src/local-databases.ts to call typed commands
2023-03-23 11:42:12 +00:00
Robert
c394b7c4f0
Convert extensions/ql-vscode/src/helpers.ts to call typed commands
2023-03-23 11:42:09 +00:00
Robert
ddf5b3aac2
Convert extensions/ql-vscode/src/databaseFetcher.ts to call typed commands
2023-03-23 11:42:06 +00:00
github-actions[bot]
75634b3654
Bump version to v1.8.2 ( #2218 )
2023-03-23 11:39:09 +00:00
Shati Patel
4c7c1cb0e6
v1.8.1 ( #2216 )
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2023-03-23 11:00:29 +00:00
Robert
13c3c8efe4
Convert extensions/ql-vscode/src/cli.ts to call typed commands
2023-03-23 10:49:48 +00:00
Robert
a3c4c8fb61
Merge pull request #2212 from github/robertbrignull/app_executeCommand
...
Replace app.executeCommand with app.commands.execute
2023-03-23 10:28:36 +00:00
Koen Vlaswinkel
73b0a0565f
Merge pull request #2214 from github/koesie10/remove-command-runner-with-progress
...
Remove `commandRunnerWithProgress`
2023-03-23 11:26:20 +01:00
Koen Vlaswinkel
aa268cfc5f
Rename and move commandRunner
...
The `commandRunner` name doesn't really make sense since it doesn't
"run" a command, but rather registers a command. This renames it
to `registerCommandWithErrorHandling` and moves it to the
`common/vscode` directory.
2023-03-23 11:14:44 +01:00
Robert
8fbde9fba1
Limit setContext keys
2023-03-23 10:12:20 +00:00
Koen Vlaswinkel
aca0489fdc
Remove commandRunnerWithProgress
...
The `commandRunnerWithProgress` is unused because all commands have been
converted to using `commandRunner` in combination with `withProgress`.
2023-03-23 11:09:32 +01:00
Koen Vlaswinkel
dae472ca05
Merge pull request #2213 from github/koesie10/check-for-updates-typed-command
...
Add `codeQL.checkForUpdatesToCLI` type for command
2023-03-23 10:49:18 +01:00
Koen Vlaswinkel
20f85f2b81
Merge pull request #2210 from github/koesie10/base-typed-commands
...
Convert some base commands to typed commands
2023-03-23 10:03:53 +01:00
Koen Vlaswinkel
81cce9fa8b
Add codeQL.checkForUpdatesToCLI type for command
...
The `codeQL.checkForUpdatesToCLI` command is registered pre-activation,
and we don't really want to create the command manager before
activation, so this will just add the correct type without registering
it using the command manager.
2023-03-23 09:58:27 +01:00
Koen Vlaswinkel
a27ca2e177
Merge remote-tracking branch 'origin/main' into koesie10/base-typed-commands
2023-03-23 09:51:24 +01:00
Robert
3e9c2c85d3
Remove app.executeCommand
2023-03-22 17:13:12 +00:00
Robert
297fa2ebd3
Merge pull request #2207 from github/robertbrignull/extension_commands
...
Start using app.commands.execute for all commands called from extension.ts
2023-03-22 16:59:53 +00:00
Shati Patel
844e58a1b1
Tidy up recent changelog entries ( #2211 )
2023-03-22 16:54:17 +00:00
Robert
9948b93b76
Merge branch 'main' into robertbrignull/extension_commands
2023-03-22 16:35:56 +00:00
Koen Vlaswinkel
e1d5a4ddaa
Merge remote-tracking branch 'origin/main' into koesie10/base-typed-commands
2023-03-22 17:22:26 +01:00
Koen Vlaswinkel
7059f46141
Merge pull request #2209 from github/koesie10/query-editor-typed-commands
...
Convert query editing commands to typed commands
2023-03-22 17:21:31 +01:00
Koen Vlaswinkel
fe6ff6801a
Convert some base commands to typed commands
2023-03-22 17:02:16 +01:00
Koen Vlaswinkel
be3459c1aa
Convert query editing commands to typed commands
2023-03-22 16:52:59 +01:00
Koen Vlaswinkel
5ac5de8a5b
Move query editing commands to separate file
2023-03-22 16:50:44 +01:00
Koen Vlaswinkel
322c1a8835
Merge pull request #2206 from github/koesie10/test-ui-typed-commands
...
Convert test UI commands to typed commands
2023-03-22 16:42:18 +01:00
Robert
5d6a2e6d7f
rename types
2023-03-22 15:37:39 +00:00
Robert
0e79b92829
Merge branch 'main' into robertbrignull/extension_commands
2023-03-22 15:36:31 +00:00
Koen Vlaswinkel
59378daff3
Merge remote-tracking branch 'origin/main' into koesie10/test-ui-typed-commands
2023-03-22 16:29:36 +01:00
Koen Vlaswinkel
125af1139b
Merge pull request #2208 from github/koesie10/mock-server-typed-commands
...
Convert mock API server commands to typed commands
2023-03-22 16:28:28 +01:00
Robert
6afdf6357b
Merge pull request #2202 from github/robertbrignull/extract_progress
...
Move withProgress and associated code to a separate file
2023-03-22 15:19:50 +00:00
Koen Vlaswinkel
fd7013f754
Convert mock API server commands to typed commands
2023-03-22 16:04:49 +01:00
Robert
408c042b3b
Fix remaining imports
2023-03-22 14:49:04 +00:00
Koen Vlaswinkel
b2fceb9b2d
Merge pull request #2205 from github/koesie10/results-view-typed-commands
...
Convert results view commands to typed commands
2023-03-22 15:46:08 +01:00
Robert
819e596b9b
Merge branch 'main' into robertbrignull/extract_progress
2023-03-22 14:31:55 +00:00
Robert
31af28e73b
Add link to docs
2023-03-22 14:28:10 +00:00
Koen Vlaswinkel
c6d8a09f19
Add support for Partial in the command manager
...
The command manager types didn't fully support commands defined with
`Partial` because it deduced that the command function was `undefined`
when the function was not defined. However, if the command is not
present, the command registration will not be called. This fixes the
types by specifying that the command definition will never be
`undefined`.
2023-03-22 15:27:18 +01:00
Robert
39d4675b44
Start using app.commands.execute for all commands called from extension.ts
2023-03-22 14:16:55 +00:00
Koen Vlaswinkel
e74a2e4a15
Remove UIService
...
This class seems to have been introduced at some point to reduce the
dependency on VS Code from the test UI service. However, none of its
methods are being used anymore, and by using typed commands we have
already reduced the dependency on VS Code. Therefore, we can simply
remove this class.
2023-03-22 15:14:22 +01:00
Koen Vlaswinkel
9f85f56055
Convert test UI commands to typed commands
2023-03-22 15:13:05 +01:00
Koen Vlaswinkel
ac57f5005d
Convert results view commands to typed commands
2023-03-22 15:06:15 +01:00
Koen Vlaswinkel
88a9ecbeab
Merge pull request #2204 from github/koesie10/summary-language-support-typed-commands
...
Convert summary language commands to typed commands
2023-03-22 14:52:45 +01:00
Koen Vlaswinkel
9f7c7b2ed8
Merge pull request #2203 from github/koesie10/ast-viewer-typed-commands
...
Convert AST viewer commands to typed commands
2023-03-22 14:44:04 +01:00
Koen Vlaswinkel
1f8070c8b5
Convert summary language commands to typed commands
2023-03-22 14:26:06 +01:00
Koen Vlaswinkel
bc29231fec
Convert AST viewer commands to typed commands
2023-03-22 14:11:43 +01:00
Koen Vlaswinkel
e724577d82
Merge pull request #2196 from github/koesie10/ast-cfg-typed-commands
...
Convert AST and CFG commands to typed commands
2023-03-22 13:32:34 +01:00
Robert
b914b97be7
Pull progress to separate file
2023-03-22 12:07:16 +00:00
Koen Vlaswinkel
9d4b19f91f
Merge remote-tracking branch 'origin/main' into koesie10/ast-cfg-typed-commands
2023-03-22 13:03:21 +01:00
Koen Vlaswinkel
8a66bb4017
Merge pull request #2198 from github/koesie10/packaging-typed-commands
...
Convert packaging to typed commands
2023-03-22 13:02:21 +01:00
Robert
e55fb8c7a7
Merge pull request #2191 from github/robertbrignull/variant_analysis_commands
...
Convert all variant analysis commands to typed commands
2023-03-22 11:56:31 +00:00
Robert
a6fefdbabb
Merge branch 'main' into robertbrignull/variant_analysis_commands
2023-03-22 11:44:25 +00:00
Robert
2334e4e7b2
Merge pull request #2192 from github/robertbrignull/export_selected_results_command
...
Move codeQL.exportSelectedVariantAnalysisResults to query history manager
2023-03-22 11:41:13 +00:00
Koen Vlaswinkel
5c06bcc6bd
Merge remote-tracking branch 'origin/main' into koesie10/packaging-typed-commands
2023-03-22 12:39:36 +01:00
Koen Vlaswinkel
3240809d11
Merge pull request #2200 from github/koesie10/restart-typed-command
...
Convert codeQL.restartQueryServer to a typed command
2023-03-22 12:37:20 +01:00
Koen Vlaswinkel
3e66e7aaf3
Merge remote-tracking branch 'origin/main' into koesie10/restart-typed-command
2023-03-22 12:10:54 +01:00
Koen Vlaswinkel
71831fe460
Merge pull request #2201 from github/koesie10/eval-log-viewer-typed-command
...
Convert codeQLEvalLogViewer.clear to a typed command
2023-03-22 12:07:34 +01:00
Robert
0983733a67
fix typo
2023-03-22 10:51:03 +00:00
Robert
0166f9a557
Merge branch 'main' into robertbrignull/variant_analysis_commands
2023-03-22 10:50:17 +00:00
Robert
5af0ebcb24
convert to type imports
2023-03-22 10:49:50 +00:00
Koen Vlaswinkel
9d6c78b656
Merge branch 'main' into koesie10/ast-cfg-typed-commands
2023-03-22 11:37:23 +01:00
Koen Vlaswinkel
56c83eb480
Merge pull request #2195 from github/koesie10/move-database-commands
...
Move remaining local database commands to databases UI
2023-03-22 11:36:56 +01:00
Koen Vlaswinkel
aa0d011daa
Convert codeQLEvalLogViewer.clear to a typed command
2023-03-22 11:34:39 +01:00
Koen Vlaswinkel
76558b8d41
Merge pull request #2194 from github/koesie10/typed-local-query-commands
...
Convert local query commands to typed commands
2023-03-22 11:34:34 +01:00
Koen Vlaswinkel
eb5659a628
Merge branch 'main' into koesie10/move-database-commands
2023-03-22 11:22:48 +01:00
Koen Vlaswinkel
11b4de1820
Merge branch 'main' into koesie10/typed-local-query-commands
2023-03-22 11:20:02 +01:00
Koen Vlaswinkel
2c8c7cec8f
Convert codeQL.restartQueryServer to a typed command
2023-03-22 10:29:09 +01:00
Koen Vlaswinkel
1c6d9f3f22
Use commandRunner for codeQL.restartQueryServer
2023-03-22 10:26:29 +01:00
Elena Tanasoiu
f196e34fa5
Merge pull request #2188 from github/elena/force-workspace-in-codespace
...
Codespace: Open tutorial workspace on extension start
2023-03-22 08:30:31 +00:00
Koen Vlaswinkel
7c7a64ca5b
Convert packaging commands to typed commands
2023-03-22 09:22:07 +01:00
Koen Vlaswinkel
dfff7ae8de
Move packaging commands to withProgress
2023-03-22 09:22:07 +01:00
Koen Vlaswinkel
ef267f87bb
Move packaging command registration to separate file
2023-03-22 09:22:07 +01:00
Elena Tanasoiu
a7800ce3bc
Merge branch 'main' into elena/force-workspace-in-codespace
2023-03-22 07:46:19 +00:00
github-actions[bot]
168af11e00
Bump CLI version from v2.12.4 to v2.12.5 for integration tests ( #2197 )
...
Co-authored-by: github-actions[bot] <github-actions@github.com >
2023-03-21 16:27:58 +00:00
Koen Vlaswinkel
17bab1c09c
Remove unnecessary viewAst function
2023-03-21 16:10:05 +01:00
Koen Vlaswinkel
b3092be5d3
Convert AST and CFG commands to typed commands
2023-03-21 16:09:15 +01:00
Koen Vlaswinkel
1909fee91f
Remove use of commandRunnerWithProgress in AST and CFG commands
2023-03-21 16:04:41 +01:00
Koen Vlaswinkel
6ff2670ec2
Remove duplication of AST and CFG command implementations
2023-03-21 16:02:05 +01:00
Koen Vlaswinkel
0379575256
Move AST and CFG commands to separate file
2023-03-21 15:58:12 +01:00
Elena Tanasoiu
8fd9ebf2d8
Limit comparison to Uri path
...
We attempted to specify exactly which URI we're expecting here.
However, `Uri.parse` behaves differently in the test than it does in
the code so we've inadvertently created a flakey test [1]. The URI we
generate in the test has a `scheme: 'c'` while the one in the code has
a `scheme: 'C'` property.
This only happens on windows, not ubuntu.
Let's narrow the comparison to just the path of the URI.
[1]: https://github.com/github/vscode-codeql/actions/runs/4478429334/jobs/7871178529#step:7:231
2023-03-21 14:26:22 +00:00
Koen Vlaswinkel
bed56ef648
Make public methods private in local databases UI
...
Some of the methods in the `DatabaseUI` were public because they were
used in the `extension.ts` file. We have moved these method calls into
this file, so they do not need to be public anymore. We can also get rid
of the separation between some of these methods, so I've moved them into
the function that calls them.
2023-03-21 14:50:24 +01:00
Koen Vlaswinkel
7ab986fabe
Move codeQL.chooseDatabaseGithub command
2023-03-21 14:48:14 +01:00
Koen Vlaswinkel
15d30d5342
Move codeQL.chooseDatabaseInternet command
2023-03-21 14:47:26 +01:00
Koen Vlaswinkel
71f22b9a7a
Move codeQL.chooseDatabaseArchive command
2023-03-21 14:45:54 +01:00
Koen Vlaswinkel
32b6ad53cf
Move codeQL.chooseDatabaseFolder command
2023-03-21 14:44:46 +01:00
Koen Vlaswinkel
ac2f4475c0
Group local database commands by type
2023-03-21 14:40:04 +01:00
Elena Tanasoiu
108943d135
existsSync -> pathExists
...
Use async version of file check.
2023-03-21 13:19:33 +00:00
Gulshan Singh
bb0c53d65d
Display EntityValue labels in CSV export ( #2170 )
2023-03-21 11:59:18 +00:00
Nora
82d03091d0
Merge pull request #2193 from github/nora/query-history-data-model
...
Move query-serialization
2023-03-21 12:23:18 +01:00
Elena Tanasoiu
c1a515ed82
Open tutorial before extension activation
...
To reduce lag when checking for the existence of the tutorial workspace.
2023-03-21 11:20:14 +00:00
Elena Tanasoiu
0368d537ad
Ask the user for permission to reload workspace
...
To make this a nicer experience for the user, we're adding a prompt
to let them know we're about to reload the workspace.
2023-03-21 11:20:14 +00:00
Elena Tanasoiu
7059802a25
Add more logging before attempting to open tutorial workspace
2023-03-21 11:20:14 +00:00
Elena Tanasoiu
0f4fcdf676
Add comment with PR description
...
This adds the explanation from the PR description in a comment and
removes comment that's no longer helpful.
2023-03-21 11:20:14 +00:00
Elena Tanasoiu
ce413a6385
Stub isCodespaceTemplate correctly
...
Now that we fixed our expectation in the previous commit, we could see we
were stubbing this to false instead of true.
So now the test is checking the right scenario.
2023-03-21 11:20:13 +00:00
Elena Tanasoiu
8db9f52df3
Adjust the rest of the test expectations
...
Our expectation was quite narrow: we expect to not call an `openFolder`
command. We didn't specify any params for it, which might mean this
expectation wasn't working like it should.
Let's just check that `executeCommand` isn't called at all.
2023-03-21 11:20:13 +00:00
Elena Tanasoiu
782e413c64
Add workspace filepath to test expectation
2023-03-21 11:20:13 +00:00
Elena Tanasoiu
fade710f95
Call it commandSpy everywhere
2023-03-21 11:20:13 +00:00
Elena Tanasoiu
737a1f5c37
Use existing file path consistently
2023-03-21 11:19:56 +00:00
Koen Vlaswinkel
7950c1c982
Convert local query commands to typed commands
...
The local query commands are using a separate logger, and this is not
supported by the command manager because it is quite specific to this
extension. Therefore, we create a separate command manager which uses
a different logger to separate the commands.
2023-03-21 12:08:44 +01:00
Koen Vlaswinkel
f37a6c5e9e
Convert commandRunnerWithProgress to commandRunner
2023-03-21 12:08:44 +01:00
Koen Vlaswinkel
649179f62e
Rename local queries manager variable names
2023-03-21 12:08:44 +01:00
Koen Vlaswinkel
8a2630d1b7
Move local queries commands to separate file
2023-03-21 12:08:44 +01:00
Nora
fa29bcc5fd
Rename serializer
2023-03-21 11:03:58 +00:00
Nora
5cd50a67e7
Move query-serialization
2023-03-21 10:39:02 +00:00
Koen Vlaswinkel
f7b6d4c4a4
Merge pull request #2189 from github/koesie10/typed-local-database-ui-commands
...
Convert local database commands to typed commands
2023-03-21 10:39:57 +01:00
Koen Vlaswinkel
58bffe1edf
Merge remote-tracking branch 'origin/main' into koesie10/typed-local-database-ui-commands
2023-03-21 10:27:31 +01:00
Robert
0c9df6edba
Convert the codeQL.openVariantAnalysisView command
2023-03-20 17:41:23 +00:00
Robert
ac0d920156
Convert the codeQL.loadVariantAnalysisRepoResults command
2023-03-20 17:41:23 +00:00
Robert
5f2a8fa1d5
Convert the codeQL.autoDownloadVariantAnalysisResult command
2023-03-20 17:41:21 +00:00
Robert
b55910d2b9
Convert the codeQL.monitorVariantAnalysis command
2023-03-20 17:32:35 +00:00
Robert
e586f3de53
Move codeQL.exportSelectedVariantAnalysisResults to query history manager
2023-03-20 16:59:51 +00:00
Robert
08849c1df4
Convert codeQL.copyVariantAnalysisRepoList command
2023-03-20 16:50:53 +00:00
Robert
aa64459353
Convert existing variant analysis commands to bind(this)
2023-03-20 16:50:53 +00:00
Robert
3c229d244e
Merge pull request #2186 from github/robertbrignull/export_results_telemetry
...
Add telemetry for exporting variant analysis results
2023-03-20 16:47:49 +00:00
Robert
fb70382929
Fix tests to not reference deleted command
2023-03-20 16:33:55 +00:00
Robert
f49314f6f3
Merge branch 'main' into robertbrignull/export_results_telemetry
2023-03-20 15:46:41 +00:00
Koen Vlaswinkel
9044d11d2b
Merge pull request #2190 from github/koesie10/typed-new-database-panel-commands
...
Convert new database panel to typed commands
2023-03-20 16:25:04 +01:00
Elena Tanasoiu
5444a9e55e
Fail gracefully if we can't set up code tour
...
We're running this at the extension start-up. We don't want it to block the extension
from completing activation, so let's swallow any errors from the code tour and output
them, instead of letting this affect the rest of the extension activation.
2023-03-20 15:01:04 +00:00
Elena Tanasoiu
4fa3c459a1
Open tutorial workspace on extension start
...
When opening https://github.com/github/codespaces-codeql/ in a
codespace, it's easy to miss the prompt that tells you to open the
tutorial.code-workspace file.
In fact people actively dismiss the alert to get it out of the way.
If you miss that prompt, you end up with a single-rooted workspace,
which causes various other problems.
While there is an open issue to allow VS Code to open a default
workspace [1], there doesn't seem to have been any progress on it
in the last two years.
So we're taking matters into our own hands and forcing the extension
to open the tutorial workspace, if it detects it.
This will only happen if the following three conditions are met:
- the .tours folder exists
- the tutorial.code-workspace file exists
- the CODESPACES_TEMPLATE setting hasn't been set
NB: the `CODESPACES_TEMPLATE` setting can only be found if the
tutorial.code-workspace has already been opened. So it's a good
indicator that we're in the folder, but the user has ignored the prompt.
[1]: https://github.com/microsoft/vscode-remote-release/issues/3665
2023-03-20 13:31:20 +00:00
Koen Vlaswinkel
2e9a22e86d
Convert new database panel to typed commands
...
This converts the new database panel to use typed commands. There should
be no changes in behaviour.
2023-03-20 13:52:32 +01:00
Robert
b76bef4246
Remove the codeQL.exportVariantAnalysisResults command
2023-03-20 12:33:51 +00:00
Koen Vlaswinkel
e603de41c1
Convert local database commands to typed commands
2023-03-20 11:39:53 +01:00
Koen Vlaswinkel
dbd832f1a0
Switch local databases to function definitions
...
The local databases UI was essentially the only class which was defining
methods using assignment to a class property rather than using function
definitions and binding them. This switches it to use function
definitions and binding, which is more consistent with the rest of the
codebase.
2023-03-20 11:29:45 +01:00
Robert
5b2093df8f
Merge pull request #2185 from github/robertbrignull/remove_internal_commands
...
Remove two more internal-only commands
2023-03-20 10:24:31 +00:00
Koen Vlaswinkel
af63e5094f
Convert commandRunnerWithProgress invocations to withProgress
2023-03-20 11:19:32 +01:00
Robert
94db1dff73
Remove codeQL.openVariantAnalysisQueryText command
2023-03-17 16:13:21 +00:00
Robert
a44ecadae5
Add telemetry for exporting variant analysis results
2023-03-17 16:09:00 +00:00
Robert
a375afd61b
Remove codeQL.cancelVariantAnalysis command
2023-03-17 15:48:00 +00:00
Charis Kyriakou
42ce27b112
Merge pull request #2183 from github/charis/remove-primer
...
Remove primer packages and make styled-components a top-level dependency
2023-03-17 14:46:02 +00:00
Koen Vlaswinkel
f86c0b826a
Merge pull request #2176 from github/koesie10/query-history-commands-typed
...
Convert query history commands to typed commands
2023-03-17 15:28:21 +01:00
Charis Kyriakou
2d46365406
Add styled-components as a top level dependency
2023-03-17 14:19:22 +00:00
Charis Kyriakou
50e89ba1a3
Remove primer packages
2023-03-17 13:46:43 +00:00
Charis Kyriakou
7914403da0
Wire up data flow paths view ( #2182 )
2023-03-17 13:30:32 +00:00
Koen Vlaswinkel
5be08d7c92
Revert change to context menu name
2023-03-17 12:29:25 +01:00
Robert
df24a705b0
Merge pull request #2179 from github/robertbrignull/remove_openVariantAnalysisQueryFile_command
...
Remove codeQL.openVariantAnalysisQueryFile command
2023-03-17 11:23:31 +00:00
Koen Vlaswinkel
fce51ca9a2
Convert query history commands to typed commands
2023-03-17 10:54:40 +01:00
Charis Kyriakou
8a5273058b
Add new data flow paths view (empty) ( #2172 )
2023-03-17 09:25:03 +00:00
Koen Vlaswinkel
f3274b39d2
Merge pull request #2015 from github/dependabot/npm_and_yarn/extensions/ql-vscode/glob-promise-6.0.2
...
Bump glob-promise from 4.2.2 to 6.0.2 in /extensions/ql-vscode
2023-03-17 09:49:53 +01:00
Koen Vlaswinkel
38e551bb2a
Merge pull request #1930 from github/dependabot/npm_and_yarn/extensions/ql-vscode/tar-stream-3.0.0
...
Bump tar-stream from 2.2.0 to 3.0.0 in /extensions/ql-vscode
2023-03-17 09:48:52 +01:00
dependabot[bot]
cc53cd54c4
Bump webpack-cli from 4.6.0 to 5.0.1 in /extensions/ql-vscode ( #2181 )
...
Bumps [webpack-cli](https://github.com/webpack/webpack-cli ) from 4.6.0 to 5.0.1.
- [Release notes](https://github.com/webpack/webpack-cli/releases )
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack/webpack-cli/compare/webpack-cli@4.6.0...webpack-cli@5.0.1 )
---
updated-dependencies:
- dependency-name: webpack-cli
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-16 09:38:00 -07:00
Robert
61cc9191f9
Merge pull request #2139 from github/robertbrignull/webview_error_telemetry
...
Add listeners for unhandled errors to web views
2023-03-16 11:18:52 +00:00
Robert
f2f1b1d6a3
Collect common messages
2023-03-16 10:59:02 +00:00
Robert
64531f5a6f
Check undefined instead of using typeof
2023-03-16 10:54:29 +00:00
Robert
29bb7ce01e
Emit telemetry when opening variant analysis query file
2023-03-16 10:39:02 +00:00
Robert
9045253624
Merge pull request #2178 from github/robertbrignull/split-commands/codeQLQueryHistory.openQuery
...
Split up codeQLQueryHistory.openQuery command
2023-03-15 17:12:06 +00:00
Robert
34ab409050
Remove codeQL.openVariantAnalysisQueryFile command
2023-03-15 17:06:17 +00:00
Robert
e6f543670a
Split up codeQLQueryHistory.openQuery command
2023-03-15 16:54:46 +00:00
Robert
04c24d0996
Merge pull request #2177 from github/robertbrignull/split-commands/codeQLQueryHistory.removeHistoryItem
...
Split up the codeQLQueryHistory.removeHistoryItem command
2023-03-15 16:54:24 +00:00
Koen Vlaswinkel
41ca0ffba6
Merge pull request #2175 from github/dependabot/npm_and_yarn/extensions/ql-vscode/lint-staged-13.2.0
...
Bump lint-staged from 10.2.11 to 13.2.0 in /extensions/ql-vscode
2023-03-15 17:16:03 +01:00
Robert
84f60ccb8c
Avoid duplicate use of the codeQLQueryHistory.removeHistoryItem command
2023-03-15 16:11:40 +00:00
dependabot[bot]
0fa0fa3523
Bump tar-stream from 2.2.0 to 3.0.0 in /extensions/ql-vscode
...
Bumps [tar-stream](https://github.com/mafintosh/tar-stream ) from 2.2.0 to 3.0.0.
- [Release notes](https://github.com/mafintosh/tar-stream/releases )
- [Commits](https://github.com/mafintosh/tar-stream/compare/v2.2.0...v3.0.0 )
---
updated-dependencies:
- dependency-name: tar-stream
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-15 16:10:41 +00:00
dependabot[bot]
fe554ee2a7
Bump glob-promise from 4.2.2 to 6.0.2 in /extensions/ql-vscode
...
Bumps [glob-promise](https://github.com/ahmadnassri/node-glob-promise ) from 4.2.2 to 6.0.2.
- [Release notes](https://github.com/ahmadnassri/node-glob-promise/releases )
- [Commits](https://github.com/ahmadnassri/node-glob-promise/compare/v4.2.2...v6.0.2 )
---
updated-dependencies:
- dependency-name: glob-promise
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-15 16:09:35 +00:00
Koen Vlaswinkel
019af98f40
Merge pull request #2171 from github/koesie10/commands-with-progress
...
Convert run variant analysis command to new commands package
2023-03-15 16:39:35 +01:00
Koen Vlaswinkel
c853bafb91
Merge remote-tracking branch 'origin/main' into koesie10/commands-with-progress
2023-03-15 15:43:34 +01:00
Robert
c632c38220
Merge pull request #2087 from github/robertbrignull/no-nested-functions
...
Avoid having functions that aren't at the top level in extension.ts
2023-03-15 14:21:23 +00:00
Robert
fd570abdcd
Merge branch 'main' into robertbrignull/no-nested-functions
2023-03-15 13:37:35 +00:00
Robert
e81d585336
Swap arguments so command arg comes last
2023-03-15 13:36:57 +00:00
Anders Starcke Henriksen
dc55ef9985
Merge pull request #2157 from github/starcke/commands-registration
...
Commands registration
2023-03-15 14:05:25 +01:00
Robert
3fe069975a
Avoid reporting errors twice
2023-03-15 12:26:58 +00:00
Anders Starcke Henriksen
5303ec67cb
Name updates.
2023-03-15 12:04:52 +01:00
Robert
969fdb6337
Make type checking all use typeof
2023-03-15 10:21:25 +00:00
Robert
47fa752c5c
Merge branch 'main' into robertbrignull/webview_error_telemetry
2023-03-15 09:56:58 +00:00
dependabot[bot]
639c8728dd
Bump lint-staged from 10.2.11 to 13.2.0 in /extensions/ql-vscode
...
Bumps [lint-staged](https://github.com/okonet/lint-staged ) from 10.2.11 to 13.2.0.
- [Release notes](https://github.com/okonet/lint-staged/releases )
- [Commits](https://github.com/okonet/lint-staged/compare/v10.2.11...v13.2.0 )
---
updated-dependencies:
- dependency-name: lint-staged
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-15 09:22:59 +00:00
Koen Vlaswinkel
3d9f55ffea
Merge pull request #2174 from github/dependabot/npm_and_yarn/extensions/ql-vscode/webpack-5.76.0
...
Bump webpack from 5.73.0 to 5.76.0 in /extensions/ql-vscode
2023-03-15 10:20:43 +01:00
dependabot[bot]
ebd18cd245
Bump webpack from 5.73.0 to 5.76.0 in /extensions/ql-vscode
...
Bumps [webpack](https://github.com/webpack/webpack ) from 5.73.0 to 5.76.0.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.73.0...v5.76.0 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-15 02:21:22 +00:00
Robert
7571304fb2
Move viewAst to top level
2023-03-14 17:57:23 +00:00
Robert
764830e69d
Move runVariantAnalysis to top level
2023-03-14 17:55:35 +00:00
Robert
9d59abd0a8
Move openReferencedFile to top level
2023-03-14 17:53:50 +00:00
Robert
165542d115
Move previewQueryHelp to top level
2023-03-14 17:51:57 +00:00
Robert
d8371708b3
Move compileAndRunQueryOnMultipleDatabases to top level
2023-03-14 17:49:58 +00:00
Robert
c3f4a012a9
Move DatabaseQuickPickItem to top level
2023-03-14 17:49:07 +00:00
Robert
e2e197f4d9
Move compileAndRunQuery to top level
2023-03-14 17:46:37 +00:00
Robert
c366342f95
Move showResultsForCompletedQuery to top level
2023-03-14 17:43:58 +00:00
Robert
b05977516e
Move showResultsForComparison to top level
2023-03-14 17:43:07 +00:00
Andrew Eisenberg
444de8cc3d
Merge pull request #2072 from github/aeisenberg/mrva-extension-packs
...
Inject extension pack dependencies into MRVA packs
2023-03-14 10:41:35 -07:00
Robert
ee759abea9
Move installOrUpdateThenTryActivate to top level
2023-03-14 17:40:39 +00:00
Robert
a8f67d72f5
Move getDistributionDisplayingDistributionWarnings to top level
2023-03-14 17:38:36 +00:00
Robert
118be4a19a
Move installOrUpdateDistribution to top level
2023-03-14 17:36:30 +00:00
Robert
8d3ae78db2
Move installOrUpdateDistributionWithProgressTitle to top level
2023-03-14 17:34:10 +00:00
Robert
ada5f51e85
Move codeQlVersionRange to top level
2023-03-14 17:31:11 +00:00
Robert
82f4941415
Move shouldUpdateOnNextActivationKey to top level
2023-03-14 17:30:49 +00:00
Robert
23e1715c4a
Move DistributionUpdateConfig to top level
2023-03-14 17:27:48 +00:00
Andrew Eisenberg
250dc15fe5
Add extension packs to variant analysis queries
...
This change allows the `codeQL.runningQueries.useExtensionPacks`
setting to be respected when running variant analysis queries. When
set to `all`, before uploading the generated query pack, all extension
packs in the workspace will be injected as dependencies into the qlpack
file.
2023-03-14 08:55:01 -07:00
Koen Vlaswinkel
db967443dd
Remove viewLoaded callback comment
...
This removes the comment about the `viewLoaded` callback since it refers
to upgrade instructions.
2023-03-14 16:12:48 +01:00
Koen Vlaswinkel
b888ca07ae
Extract variable for React root
2023-03-14 16:10:32 +01:00
Koen Vlaswinkel
c3b023cf4b
Convert run variant analysis command to new commands package
2023-03-14 13:09:31 +01:00
Koen Vlaswinkel
52b00fe434
Merge branch 'main' into starcke/commands-registration
2023-03-14 12:55:25 +01:00
Koen Vlaswinkel
64d97aaf7e
Merge pull request #2165 from github/koesie10/simpler-progress-task
...
Simpler `withProgress` calls
2023-03-14 12:06:59 +01:00
Koen Vlaswinkel
964640c757
Remove default location values in withProgress calls
2023-03-14 11:00:59 +01:00
Koen Vlaswinkel
d437ebe215
Merge branch 'koesie10/react-18' into koesie10/react-strict-mode
2023-03-14 10:48:28 +01:00
Koen Vlaswinkel
36eb2cd2ea
Fix concurrency bug in results view
...
In the results view, `setState` was used to set some state, and then
`loadResults` was called to set some other state. However, `setState`
is asynchronous, so the `this.state` in `loadResults` was not the state
that was set before the call.
This commit fixes it by combining the two `setState` calls into one. The
logic was hard to follow, so I'm not sure if this is the correct fix.
The `shouldKeepOldResultsWhileRendering` state seems to be unnecessary
now since everything is being done in `setState` call, but I'm not sure
about that.
2023-03-14 10:27:04 +01:00
Koen Vlaswinkel
605315c70d
Mock CSS.supports in view tests
2023-03-14 10:27:04 +01:00
Koen Vlaswinkel
4a295098e5
Upgrade @primer packages
...
The version of `@primer/react` we were using didn't have the correct
types for the `ThemeProvider`. By upgrading these packages to their
latest versions, all types are correct.
2023-03-14 10:02:22 +01:00
Koen Vlaswinkel
3d354e1fb4
Merge pull request #2164 from github/koesie10/unify-command-runners
...
Unify `commandRunner` implementations
2023-03-14 09:54:16 +01:00
Koen Vlaswinkel
d92708e4a4
Merge pull request #2166 from github/koesie10/remove-babel-loader
...
Remove direct dependency on babel-loader
2023-03-14 09:54:06 +01:00
Dave Bartolomeo
6c3698bfb3
Merge pull request #2169 from github/dbartol/tee-logger
...
Use `TeeLogger` instead of `additionalLogLocation:` option
2023-03-13 17:49:13 -04:00
Dave Bartolomeo
a1d8aac391
Better handling of I/O errors when writing to side log
2023-03-13 17:34:53 -04:00
Dave Bartolomeo
56095d365c
Fix test code
2023-03-13 17:28:53 -04:00
Dave Bartolomeo
fc8b13b8be
Use TeeLogger instead of additionalLogLocation: option
2023-03-13 15:10:30 -04:00
Koen Vlaswinkel
9b1dee6314
Enable React strict mode
...
This enables React strict mode which will print extra warnings to the
console when we use certain constructs incorrectly. This does not affect
production builds.
See https://beta.reactjs.org/reference/react/StrictMode
2023-03-13 16:41:26 +01:00
Koen Vlaswinkel
e949b96057
Upgrade to React 18
2023-03-13 16:38:58 +01:00
Koen Vlaswinkel
3aa24ebb2c
Remove direct dependency on babel-loader
...
The extension Webpack config does not use `babel-loader`, so we can
remove it as a direct dependency. `babel-loader` is still included in
our `node_modules` because Storybook depends on it, but the version is
now completely managed by Storybook rather than us.
2023-03-13 16:17:23 +01:00
Andrew Eisenberg
205327d8aa
Merge pull request #2162 from github/aeisenberg/variant-analysis-tests
2023-03-13 07:37:26 -07:00
Koen Vlaswinkel
4969a08531
Make progress options optional
...
This will make the progress options passed to `withProgress` optional by
moving it to be the second argument and setting a default value for the
`location`. This will make it much easier to use from a variety of
commands.
2023-03-13 15:13:55 +01:00
Koen Vlaswinkel
2646716261
Remove args from ProgressTask
...
This removes the `args` from the `ProgressTask` passed to
`withProgress`. The `args` is only used by the
`commandRunnerWithProgress` and can easily be replaced by an anonymous
function that passes the `args` instead. This will simplify the
`ProgressTask` interface and make it easier to use.
2023-03-13 14:51:32 +01:00
Anders Starcke Henriksen
79d15cc602
Add comments.
2023-03-13 14:36:28 +01:00
Koen Vlaswinkel
a7bb74190f
Unify commandRunner implementations
...
The `commandRunnerWithProgress` implementation isn't actually any
different from `commandRunner`, except for the call to `withProgress`
and support for an `outputLogger` argument. Therefore, this will simply
make `commandRunnerWithProgress` a wrapper around `commandRunner`,
removing quite some duplication in the process.
2023-03-13 14:10:00 +01:00
Anders Starcke Henriksen
d990f316d1
Fix tests.
2023-03-13 12:16:38 +01:00
Andrew Eisenberg
fe123b3187
Inject extension pack dependencies into MRVA packs
...
If the user requests that extension packs be included in their MRVA run,
then do the following:
1. Search the workspace for all extension packs
2. Add each extension pack as an explicit and direct dependency on
the generated pack.
It is ok to use `*` as a dependency since we are guaranteed that
exactly one version of each injected extension pack dependency is
available when the pack is being compiled.
If we find multiple paths to an extension pack of the same name, this
is an error since it is ambiguous which path to use.
2023-03-10 11:15:36 -08:00
Andrew Eisenberg
5d85da5526
Refactor generateQueryPack
...
Creates a handful of new functions and adds documentation. This commit
has no behavioural changes.
2023-03-10 11:15:36 -08:00
Andrew Eisenberg
b3e642a2b4
Remove any references
2023-03-10 11:11:25 -08:00
Andrew Eisenberg
0d8df9ad88
Merge pull request #2065 from github/aeisenberg/run-with-all-data-extensions
...
Add ability to run query with data extensions
2023-03-10 08:09:19 -08:00
Koen Vlaswinkel
2457d4bd9d
Remove command manager argument to variant analysis view
2023-03-10 16:56:06 +01:00
Koen Vlaswinkel
df86adbbfa
Split variant analysis and extension commands
2023-03-10 16:49:30 +01:00
Koen Vlaswinkel
e97ffd2f27
Use command manager executeCommand
2023-03-10 16:37:20 +01:00
Koen Vlaswinkel
088e9aa958
Add command manager to app
2023-03-10 16:35:22 +01:00
Robert
e3d8dbc484
Merge pull request #2147 from github/robertbrignull/release-indenting
...
Fix indenting for sub-lists
2023-03-10 11:41:54 +00:00
Robert
6daa780fbe
Merge branch 'main' into robertbrignull/release-indenting
2023-03-10 10:48:11 +00:00
Robert
c0f3adc5ff
Merge pull request #2156 from github/robertbrignull/remoteResultsItemWithoutLogs
...
Introduce cancelledRemoteResultsItemWithoutLogs context value
2023-03-10 10:39:26 +00:00
Robert
0ab482a389
Merge branch 'main' into robertbrignull/remoteResultsItemWithoutLogs
2023-03-10 10:29:47 +00:00
Koen Vlaswinkel
103017d717
Merge pull request #2150 from github/koesie10/no-node-modules-copy
...
Do not copy `node_modules` when packaging
2023-03-10 10:34:00 +01:00
Koen Vlaswinkel
9048dfd251
Merge pull request #2151 from github/koesie10/packaging-error-message
...
Add check for error message for packaging.test.ts
2023-03-10 10:33:51 +01:00
Koen Vlaswinkel
807069e0c1
Merge pull request #2148 from github/koesie10/commands-package
...
Add commands package inside src directory
2023-03-10 10:32:32 +01:00
Nora
1fa976757c
Merge pull request #2153 from github/nora/remove-unnecessary-activation-events
...
Remove unnecessary commands from `activationEvents`
2023-03-10 10:23:10 +01:00
Nora
694dcea49a
Merge pull request #2154 from github/nora/split-commands-b
...
Extension Telemetry: Split `viewCfg`,`quickEval`, `openReferencedFile` command
2023-03-10 10:22:33 +01:00
Nora
83d14501fd
Merge pull request #2142 from github/nora/split-commands-a
...
Extension Telemetry: Split `runVariantAnalysis` and `viewAst` command
2023-03-10 10:22:22 +01:00
Koen Vlaswinkel
555d99ca33
Merge branch 'main' into koesie10/commands-package
2023-03-10 10:19:58 +01:00
Koen Vlaswinkel
9dc3df74bb
Merge branch 'main' into koesie10/no-node-modules-copy
2023-03-10 10:19:57 +01:00
Koen Vlaswinkel
877d11dbe6
Merge branch 'main' into koesie10/packaging-error-message
2023-03-10 10:19:41 +01:00
Nora
c0c7574891
Split openReferencedFile command
2023-03-10 08:55:55 +00:00
Nora
4fda4f71dd
Split quickEval command
2023-03-10 08:55:54 +00:00
Nora
6356149e54
Split viewCfg command
2023-03-10 08:55:54 +00:00
Nora
7f32439786
split viewAst command
2023-03-10 08:55:33 +00:00
Nora
27434862c3
split runVariantAnalysis command
2023-03-10 08:55:33 +00:00
Nora
275c16d5b0
Remove codeQLDatabases.chooseDatabase command
2023-03-10 08:54:36 +00:00
Nora
5586a02b44
Remove not necessary commands from activation event
2023-03-10 08:54:36 +00:00
Andrew Eisenberg
baba68d0df
Add back variant analysis tests
...
This commit adds back the variant analysis tests that were inadvertently
deleted after this commit
82ada54103/extensions/ql-vscode/src/vscode-tests/cli-integration/remote-queries/run-remote-query.test.ts (L67)
They are not identical to the removed tests. I refactored them so that
there is a single test function invoked three times with different
parameters.
2023-03-09 15:53:13 -08:00
Andrew Eisenberg
790a152f42
Merge branch 'main' into aeisenberg/run-with-all-data-extensions
2023-03-09 09:42:30 -08:00
Andrew Eisenberg
1db2bc048a
Merge pull request #2159 from github/github-action/bump-cli
...
Bump CLI Version to v2.12.4 for integration tests
2023-03-09 08:17:19 -08:00
Charis Kyriakou
d9917cbe8b
Fix date of last release on changelog ( #2158 )
2023-03-09 15:58:24 +00:00
Andrew Eisenberg
2bd9c8a732
Merge pull request #2149 from github/aeisenberg-patch-1
...
Add security experimental queries
2023-03-09 07:49:27 -08:00
github-actions[bot]
c8ec661dce
Bump CLI version from v2.12.3 to v2.12.4 for integration tests
2023-03-09 15:47:48 +00:00
Charis Kyriakou
1158dfdb89
Merge pull request #2155 from github/version/bump-to-v1.8.1
...
Bump version to v1.8.1
2023-03-09 15:27:30 +00:00
Anders Starcke Henriksen
61974a7664
Register concrete command from extension.
2023-03-09 16:25:11 +01:00
Robert
155b83b540
Introduce remoteResultsItemWithoutLogs context value
2023-03-09 14:35:10 +00:00
github-actions[bot]
bc8d07bc33
Bump version to v1.8.1
2023-03-09 14:22:57 +00:00
Anders Starcke Henriksen
d87911a803
Basic implementation of command manager.
2023-03-09 14:15:27 +01:00
Koen Vlaswinkel
2d5c339e0e
Add check for error message for packaging.test.ts
...
This will add a check to ensure that `showAndLogExceptionWithTelemetry`
is not called when downloading packs. This expectation is placed before
the check for `showAndLogInformationMessage` so that when the test
fails, the error message will be shown.
2023-03-09 11:16:04 +01:00
Koen Vlaswinkel
d151b2f5f9
Do not copy node_modules when packaging
...
We are no longer including our dependencies in the VSIX package, so we
can tell VSCE that we don't want it to look at dependencies using
`--no-dependencies`. If we do this, VSCE doesn't require the
`node_modules` directory anymore and we can skip that step, which will
make building significantly faster.
I've confirmed that there are no changes between the two options by
building the extension both without and with the change. This is the
diff of the two outputs (using `diff -r`):
```diff
diff --color -r vscode-codeql-1.8.0-dev.2023.3.8.15.10.13/extension/package.json vscode-codeql-old/extension/package.json
7c7
< "version": "1.8.0-dev.2023.3.8.15.10.13",
---
> "version": "1.8.0-dev.2023.3.8.15.6.51",
diff --color -r vscode-codeql-1.8.0-dev.2023.3.8.15.10.13/extension.vsixmanifest vscode-codeql-old/extension.vsixmanifest
4c4
< <Identity Language="en-US" Id="vscode-codeql" Version="1.8.0-dev.2023.3.8.15.10.13" Publisher="GitHub" />
---
> <Identity Language="en-US" Id="vscode-codeql" Version="1.8.0-dev.2023.3.8.15.6.51" Publisher="GitHub" />
```
The only difference is the version number, which is expected.
2023-03-08 16:18:55 +01:00
Andrew Eisenberg
7bc6276115
Update .github/codeql/codeql-config.yml
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2023-03-08 07:10:53 -08:00
Andrew Eisenberg
a5021dc4c9
Add security experimental queries
2023-03-08 07:08:30 -08:00
Koen Vlaswinkel
77dd9bff94
Add commands package inside src directory
2023-03-08 15:35:14 +01:00
Charis Kyriakou
56111b39fc
Merge pull request #2146 from github/v1.8.0
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.8.0
2023-03-08 13:48:14 +00:00
Robert
0b6d828fa0
Fix indenting for sub-lists
2023-03-08 13:25:38 +00:00
Charis Kyriakou
d22be729be
v1.8.0
2023-03-08 13:22:40 +00:00
Charis Kyriakou
9490642522
Merge pull request #2144 from github/charisk/mrva-public-beta
...
Prepare for MRVA public beta
2023-03-08 12:21:40 +00:00
Charis Kyriakou
643c106fbd
Add controller repo 'learn more' link
2023-03-07 16:41:04 +00:00
Charis Kyriakou
9a308f6602
Update CHANGELOG to include MRVA
2023-03-07 16:41:04 +00:00
Charis Kyriakou
582c917541
Update README to include MRVA
2023-03-07 16:41:04 +00:00
Charis Kyriakou
e3625c982f
MRVA execution not behind canary
2023-03-07 16:41:04 +00:00
Charis Kyriakou
6f37f176e4
MRVA repositories panel not behind canary
2023-03-07 16:41:04 +00:00
Charis Kyriakou
90b0911ed3
Update release process to lock/unlock the main branch ( #2143 )
2023-03-07 15:06:43 +00:00
Charis Kyriakou
84506d7340
Merge pull request #2141 from github/charisk/docs-tidy
...
Tidy up docs
2023-03-07 15:06:03 +00:00
Robert
d8c2562bb1
Move listener registration to webview.tsx
2023-03-07 15:05:49 +00:00
Charis Kyriakou
d480056c68
Move test plan near other docs
2023-03-07 11:40:12 +00:00
Charis Kyriakou
c3d28e395c
Move testing docs to separate file
2023-03-07 11:37:00 +00:00
Charis Kyriakou
840cfbf3f6
Move releasing docs to separate doc file
2023-03-07 11:33:46 +00:00
Koen Vlaswinkel
d3466c3a72
Merge pull request #2136 from github/koesie10/upgrade-to-husky-8
...
Upgrade to Husky 8
2023-03-07 10:16:36 +01:00
Andrew Eisenberg
0ecde78d6e
Fix test comments
2023-03-06 18:05:38 -08:00
Andrew Eisenberg
e07208b089
Merge remote-tracking branch 'upstream/main' into aeisenberg/run-with-all-data-extensions
2023-03-06 15:10:19 -08:00
Robert
7176f690f3
Add listeners for unhandled errors to web views
2023-03-06 17:22:06 +00:00
Charis Kyriakou
22aa77ff4c
Fix VS Marketplace badge ( #2138 )
2023-03-06 16:00:49 +00:00
Koen Vlaswinkel
a6f189b144
Upgrade to Husky 8
2023-03-06 11:21:19 +01:00
Alexander Eyers-Taylor
2217d3f21f
Give the LanguageClient an easier id to use. ( #2135 )
2023-03-03 17:26:08 +00:00
Koen Vlaswinkel
9703d10b32
Merge pull request #2122 from github/koesie10/remove-as-unknown-as-quickpickitem
...
Remove `as unknown as QuickPickItem`
2023-03-03 16:40:21 +01:00
Robert
53492b5202
Merge pull request #2115 from github/robertbrignull/cleanup_new_telemetry
...
Cleanup config to enabling new telemetry
2023-03-03 14:13:47 +00:00
Robert
082a00e81b
Cleanup config to enabling new telemetry
2023-03-03 11:55:12 +00:00
Robert
e9bbf112f3
Merge pull request #2125 from github/robertbrignull/error_listener
...
Report unhandled errors, but only those that are from our extension
2023-03-03 11:34:31 +00:00
Robert
9386817727
Report unhandled errors from our extension
2023-03-02 17:19:40 +00:00
dependabot[bot]
68ce7c3b53
Bump actions/upload-artifact from 2 to 3 ( #2133 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 2 to 3.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/v2...v3 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-02 15:03:58 +00:00
Koen Vlaswinkel
a0ba1126cb
Merge pull request #2131 from github/koesie10/fix-delete-local-query
...
Fix error while deleting query history item
2023-03-02 14:08:26 +01:00
Koen Vlaswinkel
d574f3d94c
Fix error while deleting query history item
...
When deleting a query history item and the "next" query is still
running, the `completedQuery` is `undefined`. This commit fixes it by
using optional chaining to ensure that the `completedQuery` is defined
before accessing its `successful` property.
2023-03-02 12:32:45 +01:00
Koen Vlaswinkel
b0cc4c28ed
Merge remote-tracking branch 'origin/main' into koesie10/remove-as-unknown-as-quickpickitem
2023-03-02 12:27:31 +01:00
Koen Vlaswinkel
11b63f39b4
Merge pull request #2123 from github/koesie10/remove-unknown-database-item
...
Remove additional `as unknown as` for database items
2023-03-02 12:23:03 +01:00
Koen Vlaswinkel
216413e5d7
Merge pull request #2124 from github/koesie10/move-tests
...
Move variant analysis tests out from the CLI integration test suite
2023-03-02 12:22:39 +01:00
Charis Kyriakou
5555fcaded
Merge pull request #2118 from github/charisk/variant-analysis-scrubbing
...
Clean up variant analyses from query history
2023-03-02 09:26:49 +00:00
Koen Vlaswinkel
68fb744eab
Merge pull request #2085 from github/koesie10/fix-graphviz-wasm
...
Fix Graphviz WASM module not loading for graph viewer
2023-03-02 10:00:18 +01:00
Andrew Eisenberg
3de6a110ce
Merge pull request #2130 from github/version/bump-to-v1.7.12
...
Bump version to v1.7.12
2023-03-01 13:06:10 -08:00
github-actions[bot]
dd19ebdfdb
Bump version to v1.7.12
2023-03-01 19:07:38 +00:00
Andrew Eisenberg
6bbb14edd4
Merge pull request #2129 from github/v1.7.11
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.7.11
2023-03-01 10:57:50 -08:00
Andrew Eisenberg
fb5675a7c5
Update extensions/ql-vscode/CHANGELOG.md
...
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com >
2023-03-01 10:42:26 -08:00
Andrew Eisenberg
82a2db9fec
v1.7.11
...
Release prep and fix markdown linting warnings in test plan.
2023-03-01 18:33:51 +00:00
Andrew Eisenberg
25d85c3e61
Merge pull request #2128 from github/revert-2120-charisk/learn-more-controller-repo
...
Revert "Add controller repo 'learn more' link"
2023-03-01 09:43:20 -08:00
Andrew Eisenberg
81e6d8583a
Merge pull request #2127 from github/revert-2121-charisk/mrva-public-beta
...
Revert "Move MRVA out of canary"
2023-03-01 09:35:42 -08:00
Andrew Eisenberg
ea9dede453
Merge pull request #2126 from github/charisk/cli-v2.12.3-hack
...
Hack to avoid CodeQL CLI v2.12.3
2023-03-01 09:33:21 -08:00
Charis Kyriakou
e9062551ee
Revert "Add controller repo 'learn more' link ( #2120 )"
...
This reverts commit fd6cd1f2d2 .
2023-03-01 17:03:24 +00:00
Charis Kyriakou
dd2e79477f
Revert "Move MRVA out of canary "
2023-03-01 17:02:11 +00:00
Charis Kyriakou
e9787c2702
Hack to avoid CodeQL CLI v2.12.3
2023-03-01 16:26:49 +00:00
Koen Vlaswinkel
304330074d
Add some additional safety to allowWasmEval
2023-03-01 17:17:27 +01:00
Koen Vlaswinkel
074229e2a0
Clarify some comments
2023-03-01 17:17:06 +01:00
Koen Vlaswinkel
b679c18b0b
Move variant analysis results zip to be next to tests
2023-03-01 14:09:09 +01:00
Koen Vlaswinkel
c3799bdb5a
Move variant analysis results manager tests to activated extension suite
2023-03-01 14:07:49 +01:00
Koen Vlaswinkel
daaeb5be3f
Move some variant analysis manager test to activated extension suite
2023-03-01 14:03:00 +01:00
Koen Vlaswinkel
2b346b6873
Move variant analysis monitor tests to activated extension suite
2023-03-01 13:54:54 +01:00
Koen Vlaswinkel
1c6ecf4a5c
Remove as unknown as FullDatabaseOptions
2023-03-01 13:11:32 +01:00
Koen Vlaswinkel
59cc93f94f
Remove as unknown as DatabaseItem
2023-03-01 13:11:32 +01:00
Koen Vlaswinkel
db0fea3af5
Remove as unknown as QuickPickItem
...
This is definitely not a perfect solution since we're essentially just
moving the place where we're casting. However, because we have manually
made the types similar, this provides some type assurances where there
were none before. This also has the cast in only one place, which makes
it easier to find and fix in the future.
2023-03-01 12:21:14 +01:00
Charis Kyriakou
56d283f6d5
Merge pull request #2121 from github/charisk/mrva-public-beta
...
Move MRVA out of canary
2023-03-01 09:55:28 +00:00
Charis Kyriakou
fd6cd1f2d2
Add controller repo 'learn more' link ( #2120 )
2023-03-01 09:40:11 +00:00
Koen Vlaswinkel
b3d9804842
Only enable graph viewer in canary mode
2023-03-01 09:52:56 +01:00
Andrew Eisenberg
5843c40a37
Remove mention of search path in coment
...
Co-authored-by: Robert <robertbrignull@github.com >
2023-02-28 08:29:00 -08:00
Shati Patel
57a4a2f717
Merge pull request #2112 from github/github-action/bump-cli
...
Bump CLI Version to v2.12.3 for integration tests
2023-02-28 16:25:28 +00:00
Charis Kyriakou
ff0425d889
Update CHANGELOG to include MRVA
2023-02-28 15:02:37 +00:00
Elena Tanasoiu
5fd902257e
Merge pull request #2111 from github/elena/update-tutorial-database-path
...
Update path to codespace tutorial database
2023-02-28 14:51:14 +00:00
Koen Vlaswinkel
d3e64539d0
Only allow WASM execution in results view
2023-02-28 15:22:23 +01:00
Charis Kyriakou
55761aa4ee
Update README to include MRVA
2023-02-28 14:06:26 +00:00
Charis Kyriakou
1bf7fc148a
MRVA execution not behind canary
2023-02-28 14:04:30 +00:00
Charis Kyriakou
590b839166
MRVA repositories panel not behind canary
2023-02-28 14:04:30 +00:00
Charis Kyriakou
06463a25e6
Clean up variant analyses directory
2023-02-28 13:02:37 +00:00
Charis Kyriakou
7b2ef6bf76
Pass both local queries and variant analyses dirs in query history scrubber
2023-02-28 13:02:01 +00:00
Koen Vlaswinkel
fd57133a41
Merge pull request #2103 from github/koesie10/mock-more-objects
...
Remove more instances of `as unknown as`
2023-02-28 13:44:41 +01:00
Nora
f39bbd325c
Merge pull request #2119 from github/nora/cleanup-split-runquery
...
Remove new commands from command palette
2023-02-28 13:28:16 +01:00
Nora
9a53b637e8
Remove new commands from comman palette
2023-02-28 11:42:08 +00:00
Nora
eb25f31b9f
Merge pull request #2117 from github/nora/split-run-query
...
Split usage of runQuery and runQueryOnMultipleDatabases
2023-02-28 12:26:39 +01:00
Nora
7188d8df41
reorder command
2023-02-28 11:01:44 +00:00
Robert
badbee1bfb
Merge pull request #2101 from github/robertbrignull/unique-command-use-query
...
Add unique-command-use.ql
2023-02-28 09:15:18 +00:00
Elena Tanasoiu
2f92ea396a
Merge pull request #2090 from github/elena/install-csv-depenedencies
...
Install dependencies for tutorial query in codespace
2023-02-27 20:24:04 +00:00
Elena Tanasoiu
1f4790bbb7
Use join as it's meant to be used
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2023-02-27 20:09:05 +00:00
Elena Tanasoiu
28abc1e3a6
Don't reparse Uri path
...
I was initially trying to understand why this method was failing due
to an unrelated error [1] so I ended up over-engineering the path
parsing.
We can use the path from the first workspace folder, like we do in
other places in the extension.
[1]: https://github.com/github/vscode-codeql/pull/2104
2023-02-27 20:09:05 +00:00
Elena Tanasoiu
9b7c3bc2bf
Install dependencies for tutorial query in codespace
...
When a user goes through the Code Tour, we select a dummy `csv` database
for them to get them up and running.
Once they complete the code tour and would like to continue writing
queries, they will need to add their own database.
After they do that, we check the language of their new database and
generate a skeleton QL pack for them so that they don't need to create
these files by hand. See [1] for details.
This skeleton pack folder will be called
`codeql-custom-queries-<language>` and it comes with its own example
query: `example.ql`.
When we try to run this example query, the query gets confused about
which `dbscheme` to pick, as it sees a `qlpack.yml` file in the new
skeleton pack folder, as well as one in the existing `tutorial-lib`
folder.
So we'll need to get rid of the `tutorial-lib` folder in order to make room
for new queries to be run once the tour is complete.
This commit introduces a `handleTourDependencies` step which will
trigger a `codeql pack install` command in order to install real library
dependencies for `tutorial-queries`, since we no longer have the dummy
library in `tutorial-lib`.
2023-02-27 20:09:04 +00:00
Robert
4d73e1a068
Remove getLocationOrdinal
2023-02-27 17:46:49 +00:00
Robert
6f5ac5df4f
Introduce getAUse
2023-02-27 17:45:24 +00:00
Robert
4c880dfb19
Fix typos
2023-02-27 17:42:43 +00:00
Robert
56e8d8aac7
Merge pull request #2114 from github/robertbrignull/enable_telemetry
...
Enable new telemetry by default
2023-02-27 16:46:41 +00:00
Robert
ced9f60949
Add documentation
2023-02-27 16:06:38 +00:00
Charis Kyriakou
4fa530d69d
Check controller repo before we set it ( #2116 )
2023-02-27 16:01:39 +00:00
Robert
c0a65c994a
Convert to alert only first usage, instead of all other usages
2023-02-27 15:54:38 +00:00
Nora
921d9d22e4
split usage of runQuery and runQueryOnMultipleDatabases
2023-02-27 15:53:00 +00:00
Robert
ead1869a7e
Use PackageJson class
2023-02-27 15:30:45 +00:00
Robert
b1ddf89fe3
Update CHANGELOG.md
2023-02-27 15:23:36 +00:00
Robert
c37096bf2c
Update changelog
2023-02-27 13:12:28 +00:00
Robert
4127be2905
Enable new telemetry by default
2023-02-27 13:07:10 +00:00
Charis Kyriakou
ce29768796
Minor changes to the test plan ( #2113 )
2023-02-27 12:59:06 +00:00
Charis Kyriakou
571d9d1424
Merge pull request #2109 from github/version/bump-to-v1.7.11
...
Bump version to v1.7.11
2023-02-27 11:54:51 +00:00
Koen Vlaswinkel
65e652b5e4
Fix mockResolvedValue not working with mocked objects
2023-02-27 11:59:11 +01:00
Koen Vlaswinkel
fd2b91d4d4
Remove casting to QueryHistoryConfig
2023-02-27 11:59:11 +01:00
Koen Vlaswinkel
dd4df012e9
Remove as unknown as ExtensionContext
2023-02-27 11:59:11 +01:00
Koen Vlaswinkel
af167c6d6e
Remove as unknown as DatabaseManager
...
Unfortunately `Object.defineProperty` doesn't work on proxies, so I've
added an options object to `mockedObject` which allows passing in
methods that will return a value for a specific property.
2023-02-27 11:59:11 +01:00
Koen Vlaswinkel
551ed95fc8
Remove as unknown as QueryHistoryManager
2023-02-27 11:59:11 +01:00
Koen Vlaswinkel
9b1ca5136e
Remove as unknown as WorkspaceFolder
2023-02-27 11:59:10 +01:00
Koen Vlaswinkel
fa5bad6946
Remove as unknown as TextEditor/TextDocument
2023-02-27 11:59:10 +01:00
github-actions[bot]
6229de8634
Bump CLI version from v2.12.2 to v2.12.3 for integration tests
2023-02-24 19:18:50 +00:00
Koen Vlaswinkel
4c14db951b
Merge pull request #2102 from github/koesie10/mock-objects
...
Add new `mockedObject` function
2023-02-24 15:43:19 +01:00
Koen Vlaswinkel
bed4e8a060
Rename methods parameter to props
2023-02-24 15:28:01 +01:00
Elena Tanasoiu
2c6dc24525
Update path to codespace tutorial database
...
In https://github.com/github/codespaces-codeql/pull/12 we moved
the source for our tutorial database into `.tours` in order to
avoid confusing the user when we load the database into the
workspace, since they'd see two databases.
Since this is just the source, we'd like to hide it.
2023-02-23 17:08:20 +00:00
Charis Kyriakou
8d5a00dcc7
Remove obsolete config setting ( #2110 )
2023-02-23 16:47:30 +00:00
github-actions[bot]
3ea3cd8e9b
Bump version to v1.7.11
2023-02-23 08:58:41 +00:00
Charis Kyriakou
a32b0736db
Merge pull request #2108 from github/v1.7.10
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.7.10
2023-02-23 08:54:39 +00:00
Charis Kyriakou
50b0926390
v1.7.10
2023-02-23 08:38:10 +00:00
Elena Tanasoiu
4be573c805
Merge pull request #2106 from github/elena/change-query
...
Update skeleton query
2023-02-22 12:14:23 +00:00
Elena Tanasoiu
8bf8adfc74
Fix default query for skeleton pack
...
We mark this query as `@kind problem`.
We'll need to change the query a bit to make it fit this type of ...
erm... kind.
This means the results view will be formatted to display the file name
next to each of the results.
We're also getting rid of any mentions of an empty block query since
that's no longer what it checks.
2023-02-22 11:57:01 +00:00
Robert
14f58df2fc
Merge pull request #2107 from github/revert-2076-robertbrignull/unhandled_rejection
...
Revert "Add unhandled rejection listener"
2023-02-22 10:53:00 +00:00
Robert
c712b069b1
Revert "Add unhandled rejection listener"
2023-02-22 10:06:37 +00:00
Anders Starcke Henriksen
7b4b491a9d
Merge pull request #2099 from github/starcke/qlpack-gen-rename
...
Starcke/qlpack gen rename
2023-02-21 16:34:47 +01:00
Koen Vlaswinkel
2a43ffb49a
Add new mockedObject function
...
This will remove some instances where we're using `as unknown as T` and
replace them by a call to `mockedObject<T>()`. The `mockedObject`
function is a bit more explicit about what it does and has types which
ensure that the methods that are set on the object actually exist.
Unfortunately, we can't fully get rid of `as unknown as T` in the
`mockedObject` function. However, this construct is more localized and
does not need to be used in as many places. If we do enable an ESLint
rule to prevent the use of `as unknown as T`, I would feel comfortable
with disabling the rule for the `mockedObject` function.
2023-02-21 13:01:28 +01:00
Koen Vlaswinkel
5e51bb57f5
Merge pull request #2098 from github/koesie10/refactor-cli-arguments
...
Use options objects instead of multiple optional arguments in CLI methods
2023-02-21 12:55:35 +01:00
Robert
70ae7284f3
Add unique-command-use.ql
2023-02-21 11:09:15 +00:00
Charis Kyriakou
396fdb8c5b
Update README files for database dirs ( #2100 )
2023-02-21 09:39:02 +00:00
Charis Kyriakou
51570c3ba3
Remove obsolete config settings ( #2097 )
2023-02-21 09:09:54 +00:00
Charis Kyriakou
403e893f93
Remove isVariantAnalysisReposPanelEnabled feature flag and old flows ( #2096 )
2023-02-21 08:52:50 +00:00
Anders Starcke Henriksen
ffd27d4207
Update text to reflect multiple pack names.
2023-02-21 09:41:34 +01:00
Anders Starcke Henriksen
94b81bae71
Rename qlpack.yml -> codeql-pack.yml in generator.
2023-02-21 09:40:49 +01:00
Elena Tanasoiu
61f4ce27da
Merge pull request #2074 from github/elena/refactor-query-language
...
Consolidate the way we define query languages
2023-02-20 18:10:50 +00:00
Elena Tanasoiu
c2f7d38018
Fix spelling
2023-02-20 17:54:20 +00:00
Elena Tanasoiu
b635d914d0
Move types/query-language to common/query-language
...
And fix imports
2023-02-20 17:54:20 +00:00
Elena Tanasoiu
8b8912bc40
Import QueryLanguage from new file
2023-02-20 15:53:39 +00:00
Elena Tanasoiu
7a5bbb228a
Move dbSchemeToLanguage into QueryLanguage file
2023-02-20 15:53:39 +00:00
Elena Tanasoiu
269af3ed23
Move constant in QueryLanguage type file
2023-02-20 15:53:39 +00:00
Elena Tanasoiu
50f50f59b4
Use new type in tests
2023-02-20 15:53:39 +00:00
Elena Tanasoiu
abbc13033d
Use new type in dbSchemeToLanguage
2023-02-20 15:53:39 +00:00
Elena Tanasoiu
9508b629f5
Organise required packs by query language
2023-02-20 15:53:39 +00:00
Elena Tanasoiu
aabeba067a
Replace VariantAnalysisQueryLanguage -> QueryLanguage
2023-02-20 15:53:37 +00:00
Elena Tanasoiu
73838ffc6c
Introduce types folder
2023-02-20 15:48:59 +00:00
Charis Kyriakou
1ab34967a0
Merge pull request #2095 from github/version/bump-to-v1.7.10
...
Bump version to v1.7.10
2023-02-20 15:46:52 +00:00
Koen Vlaswinkel
0f90319691
Use an options object for runAsyncCodeQlCliCommand
...
This also removes the type for the `runTests` `options` argument since
it's only used in this definition and don't actually use the type
anywhere else.
2023-02-20 16:40:18 +01:00
Koen Vlaswinkel
8afdabdd53
Use an options object for runJsonCodeQlCliCommand
2023-02-20 16:37:48 +01:00
github-actions[bot]
624e24579e
Bump version to v1.7.10
2023-02-20 12:27:39 +00:00
Charis Kyriakou
c6481ca6ff
Merge pull request #2094 from github/v1.7.9
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.7.9
2023-02-20 12:22:15 +00:00
Charis Kyriakou
3fbfa840ac
v1.7.9
2023-02-20 11:58:32 +00:00
Charis Kyriakou
90ba3d4f29
Rename some files around local databases ( #2093 )
2023-02-20 09:46:10 +00:00
Charis Kyriakou
146f23f929
Cache schema validator for db config ( #2092 )
2023-02-17 15:32:00 +00:00
Koen Vlaswinkel
207c37c8de
Merge pull request #2091 from github/koesie10/rename-remote-queries
...
Rename `remote-queries` directories to `variant-analysis`
2023-02-17 16:01:27 +01:00
Koen Vlaswinkel
9aff6ee5a9
Remove remaining references to remote-queries
2023-02-17 11:39:22 +01:00
Koen Vlaswinkel
39d91788dc
Rename remote-queries directories to variant-analysis
2023-02-17 11:38:24 +01:00
Charis Kyriakou
c309bdc1b7
Unveil new variant analysis repositories panel ( #2082 )
2023-02-16 17:14:38 +00:00
Charis Kyriakou
f9851a3dbf
Pre-select top-10 list in variant analysis repos panel ( #2088 )
2023-02-16 13:01:34 +00:00
Koen Vlaswinkel
1fad9f6b5e
Merge pull request #2083 from github/koesie10/variant-analysis-history-item-label-tests
...
Add tests for variant analysis history item label
2023-02-16 11:17:57 +01:00
Elena Tanasoiu
d618a4e026
Merge pull request #2080 from github/shati-elena/fix-database-prompt
...
Don't offer to create skeleton pack for default database in CodeTour
2023-02-16 09:30:03 +00:00
Koen Vlaswinkel
feac82f52e
Merge pull request #2084 from github/koesie10/remove-remote-queries
...
Remove remaining remote queries code
2023-02-16 09:57:09 +01:00
Charis Kyriakou
2c81d3cbb7
Correctly initialize App and DbManager in variant analysis tests ( #2086 )
2023-02-15 16:36:14 +00:00
Robert
64f1c8e0aa
Merge pull request #2076 from github/robertbrignull/unhandled_rejection
...
Add unhandled rejection listener
2023-02-15 16:09:16 +00:00
Koen Vlaswinkel
bc51e7462b
Fix Graphviz WASM module not loading for graph viewer
...
It seems that when we added the CSP policy to the webview, we did not
take into account that `d3-graphviz` uses `@hpcc-js/wasm` to load
Graphviz as a WASM module. This commit adds `'wasm-unsafe-eval'` to the
CSP policy to allow this.
2023-02-15 15:41:36 +01:00
Robert
2ebfea1292
Add unhandled rejection listener
2023-02-15 14:28:35 +00:00
Koen Vlaswinkel
defc3816e7
Fix test depending on user-specified label
2023-02-15 13:56:53 +01:00
Koen Vlaswinkel
6ff8aad2e9
Simplify query history type checks
2023-02-15 13:53:19 +01:00
Koen Vlaswinkel
4d1e61a94d
Remove remote query text provider
2023-02-15 13:53:19 +01:00
Koen Vlaswinkel
8f9e420402
Remove remote queries types
2023-02-15 13:53:19 +01:00
Koen Vlaswinkel
6856d1b6a5
Rename exportSelectedRemoteQueryResults
2023-02-15 13:39:32 +01:00
Koen Vlaswinkel
ebe2f89ca6
Add tests for variant analysis history item label
2023-02-15 13:29:54 +01:00
Elena Tanasoiu
397be15b89
Don't offer to create skeleton pack for default database in CodeTour
...
This is step 3 in the Code Tour. At this point we don't need to create
the skeleton pack so let's disable that functionality.
Co-authored-by: Shati Patel <shati-patel@github.com >
2023-02-15 12:22:46 +00:00
Elena Tanasoiu
5933f097e7
Merge pull request #2078 from github/shati-elena/update-launch-json
...
Add an extra line for testing the codespace-codeql tour
2023-02-15 12:20:30 +00:00
Koen Vlaswinkel
0ec30ee854
Merge pull request #2079 from github/koesie10/markdown-generation-tests
...
Add tests for Markdown generation
2023-02-15 13:17:40 +01:00
Elena Tanasoiu
1b81e8662e
Merge pull request #2081 from github/shati-elena/do-not-send-format-option-for-packadd
...
Don't send `--format` option for `codeql pack add` command
2023-02-15 12:00:00 +00:00
Elena Tanasoiu
993bebe213
Add an extra line for testing the codespace-codeql tour
...
If you uncomment this, you'll be able to test the codespace locally.
Co-authored-by: Shati Patel <shati-patel@github.com >
2023-02-15 11:35:21 +00:00
Elena Tanasoiu
ef8aa14307
Don't send --format option for codeql pack add command
...
By default, this is added when we call `runJsonCodeQlCliCommandWithAuthentication`.
However, `codeql pack add` doesn't support this option so we need to turn it off.
Co-authored-by: Shati Patel <shati-patel@github.com >
2023-02-15 11:34:47 +00:00
Robert
c6ee20b7fb
Merge pull request #2075 from github/robertbrignull/enable-await-thenable
...
Enable eslint rule to disallow awaiting a non-thenable type
2023-02-15 11:26:26 +00:00
Koen Vlaswinkel
38eb9bbd89
Add tests for markdown generation
2023-02-15 11:46:09 +01:00
Robert
5f20ef3df1
Fix extra alert from merging in main
2023-02-15 10:30:21 +00:00
Robert
fc7d48bf3a
Merge branch 'main' into robertbrignull/enable-await-thenable
2023-02-15 10:28:43 +00:00
Robert
f69a6c523b
More unnecessary awaits
2023-02-15 10:24:02 +00:00
Elena Tanasoiu
95f46b3b3a
Merge pull request #2055 from github/elena/download-ql-packs
...
Generate QL pack for CodeTour
2023-02-15 10:19:08 +00:00
Koen Vlaswinkel
47c7e9e101
Move text-utils to pure
2023-02-15 11:18:47 +01:00
Koen Vlaswinkel
c0dc710b30
Rename markdown-generation file
2023-02-15 11:17:09 +01:00
Koen Vlaswinkel
a96265643c
Merge pull request #2073 from github/koesie10/remove-remote-queries-react
...
Remove remote queries React components
2023-02-15 11:15:31 +01:00
Elena Tanasoiu
ab29fb759f
Copy changes and remove extra line
2023-02-15 09:59:15 +00:00
Koen Vlaswinkel
754f6b2d49
Merge pull request #2059 from github/koesie10/retry-tests
...
Retry VSCode integration tests
2023-02-15 10:44:03 +01:00
Koen Vlaswinkel
3a188faf40
Merge branch 'main' into koesie10/retry-tests
2023-02-15 10:17:23 +01:00
Koen Vlaswinkel
b20aeb3e2c
Merge pull request #2058 from github/koesie10/improve-test-setup
...
Improve test setup
2023-02-15 10:15:45 +01:00
Andrew Eisenberg
256b806cd4
Remove skipIfTrue
...
Also, add a comment to the vscode settings file and describe how to use
it.
2023-02-14 14:47:39 -08:00
Elena Tanasoiu
086df15357
Use file system path
...
On windows, the `Uri.path` will return an extra folder, as we can see in the tests:
```
ENOENT: no such file or directory, open 'D:\C:\Users\RUNNER~1\AppData\Local\Temp\tmp-4784XPDQPb5jM6IW\test-ql-pack-ruby\qlpack.yml'
```
Let's use `Uri.fsPath` instead.
2023-02-14 19:09:22 +00:00
Andrew Eisenberg
c0c30b48af
Merge remote-tracking branch 'upstream/main' into aeisenberg/run-with-all-data-extensions
2023-02-14 18:39:35 +00:00
Elena Tanasoiu
3e87a2d53c
Remove directory from workspace by index
...
We were initially always removing the last folder in the workspace as
we assumed that would be the directory we use.
Now that we've switched to using a temporary directory, this is no longer
the case so we need to find the index of the directory in the list of
workspace folders and then use that index to remove the directory.
2023-02-14 18:05:01 +00:00
Elena Tanasoiu
f1227dd2eb
Build directory URI using Uri.file instead of Uri.parse
...
`Uri.parse` will not work with Windows paths as it will consider `C:\path`
to indicate a file scheme (the "C:" part) and will complain about it.
With `Uri.file` we can build the URI without hitting this complication.
2023-02-14 18:01:05 +00:00
Elena Tanasoiu
a59a008d8e
Use temporary directory for generator tests
...
This will hopefully work with Windows tests as well.
2023-02-14 17:12:31 +00:00
Robert
950a218c29
Enable eslint rule to disallow awaiting a non-thenable type
2023-02-14 17:10:16 +00:00
Elena Tanasoiu
1ae52ef1cc
Mock storageUri for workspace in tests
...
So that we can provide this to the generator.
2023-02-14 15:13:51 +00:00
Andrew Eisenberg
851a42f5e3
Merge pull request #2066 from github/aeisenberg/update-settingsjson
...
Add some better sample env vars in settings.json
2023-02-14 06:53:36 -08:00
Elena Tanasoiu
d6ccc11135
Update tests to check we call the generator
...
We don't need to repeat the tests for the generator functionality
here. All we want to check is that the generator is triggered correctly.
2023-02-14 13:02:29 +00:00
Elena Tanasoiu
24eb8fd307
Store QL pack in workspace instead of VSCode storage
...
We're checking that the skeleton QL pack doesn't exist as a workspace
folder, so we should be creating this folder in the workspace as well.
Initially this was being created in VSCode's local storage.
2023-02-14 13:02:29 +00:00
Elena Tanasoiu
ce3e19a2d7
Mention that the query file is automatically generated
2023-02-14 13:02:29 +00:00
Elena Tanasoiu
c4bed4e8aa
Simplify example query to make it work with all languages
2023-02-14 13:02:29 +00:00
Elena Tanasoiu
3464cd0cda
Reword dialog box prompt
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2023-02-14 13:02:29 +00:00
Elena Tanasoiu
b04b3bf33e
Reword packAdd output
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2023-02-14 13:02:28 +00:00
Elena Tanasoiu
a8f36ee9e8
Generate a QL pack when you add a new database, if one is missing
2023-02-14 13:02:28 +00:00
Elena Tanasoiu
6cda6534d1
Introduce a QlPackGenerator class
...
This will receive a folder name and language.
It will generate:
- a `codeql-pack.yml` file
- an `example.ql` file
- a `codeql-pack.lock.yml` file
It will also install dependencies listed in `codeql-pack.lock.yml`
file.
We were initially planning to call the `packInstall` command once
we generate `codeql-pack.yml` in order to install dependencies.
However, the `packAdd` command does this for us, as well as
generating a lock file.
Rather than trying to craft the lock file by hand, we're opting
to use the cli command.
NB: We're introducing a new `QueryLanguage` type which is identical
to the `VariantAnalysisQueryLanguage`. In a subsequent PR we'll
unify these two types.
2023-02-14 13:02:28 +00:00
Elena Tanasoiu
5a9d12ea60
Introduce wrapper for codeql pack add CLI command
...
Similar to what we do with `codeql pack install`.
Tnis will simulate us running `codeql pack add codeql/<language>-all`.
We're going to need in order to:
- generate a lock file (codeql-pack.lock.yaml)
- install the correct packages for our skeleton QL pack based on the
lock file.
2023-02-14 13:02:28 +00:00
Koen Vlaswinkel
f9ef9567cf
Merge pull request #2071 from github/koesie10/remove-remote-queries-history-item
...
Remove remote queries history item
2023-02-14 13:11:04 +01:00
Koen Vlaswinkel
547e18bab9
Merge remote-tracking branch 'origin/main' into koesie10/remove-remote-queries-react
2023-02-14 12:16:41 +01:00
Koen Vlaswinkel
7d7a7060fa
Merge pull request #2070 from github/koesie10/remove-remote-query-manager
...
Remove remote queries manager
2023-02-14 12:16:02 +01:00
Koen Vlaswinkel
16464d5e3a
Merge pull request #2069 from github/koesie10/remove-remote-query-commands
...
Remove remote queries commands
2023-02-14 11:21:12 +01:00
Koen Vlaswinkel
c0ffd795e0
Remove remote queries React components
2023-02-14 10:28:51 +01:00
Koen Vlaswinkel
7508ef2e26
Move components used by MRVA out of remote-queries
2023-02-14 10:27:52 +01:00
Koen Vlaswinkel
fb4d6db03d
Remove remote queries history item
...
This removes the remote queries history item as a supported history
item. This allows us to delete almost all code related to remote
queries except for the React view code which will be removed separately.
In the query serialization code, we now ignore remote queries.
2023-02-14 10:20:04 +01:00
Andrew Eisenberg
39e6b27676
Make linter happy
2023-02-13 21:11:14 -08:00
Andrew Eisenberg
d8435d113a
Fix skipIfTrue
...
Also, update jsdoc for `resolveQlpacks`.
2023-02-13 14:30:29 -08:00
Andrew Eisenberg
d386d42f34
Add back comment
2023-02-13 09:55:25 -08:00
Koen Vlaswinkel
89860d4f84
Remove remote queries view
2023-02-13 16:01:39 +01:00
Koen Vlaswinkel
53ffdc30ce
Remove remote queries manager
2023-02-13 15:57:10 +01:00
Koen Vlaswinkel
e5a48fb46f
Merge pull request #2068 from github/koesie10/remove-run-remote-query
...
Remove code to start a remote query run
2023-02-13 15:46:10 +01:00
Koen Vlaswinkel
f6d7ddf5b3
Remove tests for remote query history
2023-02-13 15:44:58 +01:00
Koen Vlaswinkel
dbe9807ccc
Remove codeQL.exportRemoteQueryResults command
2023-02-13 14:40:54 +01:00
Koen Vlaswinkel
b2ea12023c
Remove codeQL.autoDownloadRemoteQueryResults command
2023-02-13 14:32:50 +01:00
Koen Vlaswinkel
255f1b6a5d
Remove codeQL.copyRepoList command
2023-02-13 14:31:50 +01:00
Koen Vlaswinkel
dcdb303da7
Remove codeQL.monitorRemoteQuery command
2023-02-13 14:12:44 +01:00
Koen Vlaswinkel
096e8f6196
Remove code to start a remote query run
...
This removes the `runRemoteQuery` method on the remote queries manager,
all code that calls it and code which is now dead.
2023-02-13 14:00:35 +01:00
Charis Kyriakou
f7826c3254
Remove some as umknown as X usages ( #2067 )
2023-02-13 12:47:37 +00:00
Charis Kyriakou
ad03dfa0a9
Optimistically update the UI when user selects db/list ( #2063 )
2023-02-13 12:29:14 +00:00
Koen Vlaswinkel
930def851d
Disable parallelization of tests
...
This would run the unit, view, integration and CLI integration tests in
parallel, which would cause problems with multiple VSCode instances and
use a lot of memory.
2023-02-13 12:02:21 +01:00
Koen Vlaswinkel
46670cc7d6
Clarify CLI integration test CI runs
2023-02-13 11:39:38 +01:00
Koen Vlaswinkel
b412896d54
Make purpose of no-workspace tests clearer
2023-02-13 11:39:07 +01:00
Koen Vlaswinkel
14eb6b4f89
Only download test DB for CLI integration tests
...
The test database is not required for activated extension tests, so we
only need to download the test database for CLI integration tests.
2023-02-13 11:37:11 +01:00
Charis Kyriakou
682a1e12bc
Update copy for local db select button ( #2062 )
2023-02-13 09:53:48 +00:00
Charis Kyriakou
366965adbf
Remove random capital letters ( #2064 )
2023-02-13 09:02:45 +00:00
Koen Vlaswinkel
3917b14a58
Merge remote-tracking branch 'origin/main' into koesie10/improve-test-setup
2023-02-13 09:21:39 +01:00
Andrew Eisenberg
722f5c5035
Add some better sample env vars in settings.json
2023-02-10 15:55:16 -08:00
Andrew Eisenberg
6f435300e8
Add ability to run query with data extensions
...
- Add a new config that toggles between using all data extensions or
none.
- If using all data extensions, then before a query evaluation, run a
`codeql resolve qlpacks` command with the new `--kind` option. This
will return a list of extension packs in the workspace.
- Pass these packs to the cli before evaluation/
- This will only work with CLI v2.12.3 (not yet released) or later.
- Also include some CLI tests to ensure this works.
2023-02-10 15:51:07 -08:00
Charis Kyriakou
57f9ff68f8
Remove remote queries integration tests ( #2060 )
2023-02-10 14:56:12 +00:00
Charis Kyriakou
b599885b1c
Update edit db config icon ( #2061 )
2023-02-10 14:40:43 +00:00
Charis Kyriakou
514dd7afe3
New db item/list selection UX for variant analysis repo panel ( #2053 )
2023-02-10 14:38:08 +00:00
Koen Vlaswinkel
ce56e6f038
Retry VSCode integration tests
...
This will call `jest.retryTimes` to retry the VSCode integration tests
up to 3 times. This should help with the flaky tests.
2023-02-10 10:43:48 +00:00
Koen Vlaswinkel
0138df5da8
Merge pull request #2051 from github/koesie10/filter-vscode-output
...
Hide VSCode console output
2023-02-09 15:36:59 +01:00
Koen Vlaswinkel
212273791b
Merge pull request #2054 from github/koesie10/codeql-pack-yml
...
Handle `codeql-pack.yml` files everywhere
2023-02-09 15:36:00 +01:00
Koen Vlaswinkel
6ed5c2a583
Merge remote-tracking branch 'origin/main' into koesie10/filter-vscode-output
2023-02-09 09:48:24 +00:00
Koen Vlaswinkel
752b6a7f8a
Add tests for getQlPackPath
2023-02-08 17:17:10 +00:00
Koen Vlaswinkel
34bdbd158d
Move qlpack functions/constants to pure
2023-02-08 17:12:22 +00:00
Koen Vlaswinkel
c71238c6d2
Merge pull request #2052 from github/koesie10/source-map-script-from-release-asset
...
Download sourcemaps from release asset if available
2023-02-08 14:49:28 +01:00
Koen Vlaswinkel
202c93b580
Merge pull request #2049 from github/koesie10/upload-sourcemaps-release
...
Upload sourcemaps as release asset
2023-02-08 14:46:39 +01:00
Koen Vlaswinkel
b03efa4f24
Merge remote-tracking branch 'origin/main' into koesie10/source-map-script-from-release-asset
2023-02-08 13:31:28 +00:00
Koen Vlaswinkel
1198a05776
Merge remote-tracking branch 'origin/main' into koesie10/upload-sourcemaps-release
2023-02-08 13:31:13 +00:00
Koen Vlaswinkel
642b8e5960
Add documentation for new test suite and scripts
2023-02-08 13:28:18 +00:00
Andrew Eisenberg
2b816f9f0f
Merge pull request #2056 from github/github-action/bump-cli
...
Bump CLI Version to v2.12.2 for integration tests
2023-02-08 05:26:49 -08:00
Koen Vlaswinkel
708af3cbb9
Merge pull request #2057 from github/koesie10/version-number-advice
...
Add recommendation for version number bumps
2023-02-08 14:16:29 +01:00
Koen Vlaswinkel
6b8467fc4e
Update test script names
2023-02-08 13:14:00 +00:00
Koen Vlaswinkel
a9c36ea699
Create new activated-extension test suite
2023-02-08 11:52:55 +00:00
Koen Vlaswinkel
ef1fe756cb
Add recommendation for version number bumps
2023-02-08 11:21:33 +00:00
github-actions[bot]
977e3c099d
Bump CLI version from v2.12.1 to v2.12.2 for integration tests
2023-02-07 21:39:28 +00:00
Koen Vlaswinkel
7d6461a10a
Handle codeql-pack.yml files everywhere
...
This will add support for the `codeql-pack.yml` filename in all places
where we currently support `qlpack.yml`. It centralizes the list of the
supported filenames in a single place and a method that can figure out
the correct filename to use.
2023-02-07 17:55:50 +00:00
Koen Vlaswinkel
f3f8de0e60
Merge remote-tracking branch 'origin/main' into koesie10/source-map-script-from-release-asset
2023-02-07 17:29:07 +00:00
Koen Vlaswinkel
81502fefec
Merge pull request #2039 from github/koesie10/source-map-script-stacktrace
...
Add source map support for full stacktraces
2023-02-07 18:04:14 +01:00
Koen Vlaswinkel
ac127b3a3d
Merge remote-tracking branch 'origin/main' into koesie10/source-map-script-from-release-asset
2023-02-07 17:00:48 +00:00
Koen Vlaswinkel
465da69ecf
Merge remote-tracking branch 'origin/main' into koesie10/source-map-script-stacktrace
2023-02-07 16:38:44 +00:00
Koen Vlaswinkel
648e6745a8
Merge pull request #2037 from github/koesie10/source-map-script
...
Add script for retrieving original source location
2023-02-07 17:37:19 +01:00
Koen Vlaswinkel
5b9c09c958
Download sourcemaps from release asset if available
...
This download download the sourcemaps from the release asset if it is
available. Unfortunately, I'm not able to test this yet because we don't
yet have any releases with sourcemaps attached. As a fallback, it will
still try to download from the workflow run.
2023-02-07 15:16:10 +00:00
Koen Vlaswinkel
943229f065
Merge pull request #2033 from github/koesie10/mocked-config
...
Mock config instead of writing settings files
2023-02-07 15:50:32 +01:00
Koen Vlaswinkel
c42cd9059d
Hide information about VSCode exit code and download
2023-02-07 14:45:50 +00:00
Koen Vlaswinkel
f7fb6a4920
Merge remote-tracking branch 'origin/main' into koesie10/mocked-config
2023-02-07 14:33:53 +00:00
Koen Vlaswinkel
5e8c2fa6db
Hide VSCode console output
...
Most of the warnings that are currently being shown in CI are coming
from VSCode. We can hide the VSCode output to make the CI logs more
readable. This should not influence the tests; the output of tests
(in particular using `console.log`/`console.error` etc.) will still be
shown.
See: 0c98dc12ad/packages/jest-runner-vscode/src/public-types.ts (L58-L68)
2023-02-07 14:30:07 +00:00
Elena Tanasoiu
f7ab8b7ba0
Merge pull request #2042 from github/elena/add-more-test-coverage
...
Add test coverage for `openDatabase`
2023-02-07 14:03:09 +00:00
Elena Tanasoiu
b2fa85f5c5
Merge pull request #2036 from github/shati-elena/create-skeleton
...
Introduce command for creating skeleton QL packs
2023-02-07 12:49:13 +00:00
Elena Tanasoiu
72f3847a3e
Add tests for openDatabase function
2023-02-07 11:45:01 +00:00
Elena Tanasoiu
f8d0f689a6
Move functions into class so they can be mocked
...
We'd like to add test coverage for the openDatabase function (which is
public).
At the moment, this relies on `resolveDatabaseContents` which is just
a standalone function.
This means we're unable to mock it using Jest.
So let's move it into its own class.
This method in turn depends on a `resolveDatabase` function, which we've
also moved into the new class.
The only usages I could find for there functions were from within
the `databases.ts` file.
2023-02-07 11:26:33 +00:00
Elena Tanasoiu
235fb83e8c
Don't check for specific number of calls on callback
...
This is unrelated to the changes in this PR but it's causing CI to fail.
```
config listeners › CliConfigListener › should listen for changes to 'codeQL.runningTests.numberOfThreads'
expect(jest.fn()).toHaveBeenCalledTimes(expected)
Expected number of calls: 1
Received number of calls: 2
109 | const newValue = listener[setting.property as keyof typeof listener];
110 | expect(newValue).toEqual(setting.values[1]);
> 111 | expect(onDidChangeConfiguration).toHaveBeenCalledTimes(1);
| ^
112 | });
113 | });
114 | });
```
We don't need to check that the callback is triggered a certain number of times, just that it works
so we can change this test to be more permissive.
2023-02-07 11:25:11 +00:00
Elena Tanasoiu
5c89952999
"select" -> "add"
2023-02-07 11:23:40 +00:00
Elena Tanasoiu
397aa2befe
Mention language in pop-up message
2023-02-07 11:23:40 +00:00
Elena Tanasoiu
63add84bf3
Use triple equals
2023-02-07 11:23:40 +00:00
Elena Tanasoiu
037596cfb4
Create skeleton QL pack if in CodeTour
...
We'd like to make it easier for a user going through the CodeQL Tour to
write their queries.
To help them along, we can generate skeleton QL packs once we know which
database they're using, instead of expecting them to know how to create
this themselves.
We're then able to download the necessary dependencies for their CodeQL
queries.
This checks that we're running the CodeTour by looking for the
`codeQL.codespacesTemplate` setting.
2023-02-07 11:23:39 +00:00
Elena Tanasoiu
a85281e365
Be able to pass custom db options to mock
...
We will use this to set/unset the language on a database item.
This will then be used to determine whether we need to create a QL pack.
2023-02-07 11:23:39 +00:00
Elena Tanasoiu
99f3d28640
Introduce helper method to detect folder in workspace
2023-02-07 11:23:39 +00:00
Elena Tanasoiu
41256ec9fd
Make it a little clearer which function the tests are checking
2023-02-07 11:23:39 +00:00
Koen Vlaswinkel
74581fb8e3
Merge pull request #2046 from github/koesie10/rename-last-commit-to-last-updated
...
Rename "Last commit" to "Last updated"
2023-02-07 12:15:04 +01:00
Koen Vlaswinkel
483d674da1
Upload sourcemaps as release asset
...
This will upload the sourcemaps produced as part of the release as a
release asset. This allows the sourcemaps to be downloaded and used
for decoding stack traces beyond the 90 day artifact limit of GitHub
Actions.
2023-02-07 11:06:03 +00:00
Koen Vlaswinkel
cff3d9508e
Merge remote-tracking branch 'origin/main' into koesie10/rename-last-commit-to-last-updated
2023-02-07 11:00:31 +00:00
Robert
24e4708477
Merge pull request #2017 from github/robertbrignull/logged_error_telemetry
...
Introduce showAndLogExceptionWithTelemetry
2023-02-07 10:00:14 +00:00
Koen Vlaswinkel
4f0032d77b
Merge pull request #2045 from github/koesie10/link-to-actions-workflow
...
Add link to Actions workflow when running MRVA
2023-02-07 10:48:22 +01:00
Robert
420fd8d48a
Merge branch 'main' into robertbrignull/logged_error_telemetry
2023-02-07 09:42:54 +00:00
Charis Kyriakou
a901369c5e
Enable eqeqeq ESLint rule and fix violations ( #2043 )
2023-02-07 09:36:18 +00:00
Elena Tanasoiu
b05697c327
Merge pull request #2044 from github/elena/remove-lint
...
Don't lint on `git push`
2023-02-07 09:23:11 +00:00
Koen Vlaswinkel
0cbc9916fc
Rename "Last commit" to "Last updated"
...
Last commit is confusing because it's actually the `updated_at` of the
repository. By renaming it, this will be clearer to users.
2023-02-06 17:54:31 +00:00
Koen Vlaswinkel
f57b811585
Add link to Actions workflow when running MRVA
2023-02-06 17:46:35 +00:00
Elena Tanasoiu
0b9dcb44d9
Don't lint on git push
...
We run `npm run lint` every time we do a `git push`.
This takes quite a long time, and the lint command has already been run
when we created the commit in the first place.
Could we instead skip this and rely on CI to tell us if we've failed
to address a linting issue?
2023-02-06 17:36:24 +00:00
Koen Vlaswinkel
a5b95944fc
Add radix to parseInt
2023-02-06 17:13:23 +00:00
Koen Vlaswinkel
6d1c66b121
Add example to source map script
2023-02-06 17:09:56 +00:00
Koen Vlaswinkel
740cbc8dee
Make onDidChangeConfiguration less strict
...
It seems like the `onDidChangeConfiguration` is being called multiple
times. It doesn't actually matter that it's being called twice, so we
just need to ensure it's called at least once.
2023-02-06 17:02:18 +00:00
Koen Vlaswinkel
c9f0d1b525
Merge remote-tracking branch 'origin/main' into koesie10/mocked-config
2023-02-06 16:21:09 +00:00
shati-patel
66fd8ad6cc
Rename const to refer to the codespaces template in general
2023-02-06 11:13:10 +00:00
shati-patel
d0d48dfd08
Add feature flag for codespaces-codeql template workspace
...
We'll use this flag for commands that are specific to the tutorial code tour and "quick setup" in https://github.com/github/codespaces-codeql
2023-02-06 11:13:10 +00:00
Andrew Eisenberg
0dd741fa9b
Merge pull request #2035 from github/version/bump-to-v1.7.9
...
Bump version to v1.7.9
2023-02-03 08:43:32 -08:00
Elena Tanasoiu
9c2aa8c7fa
Merge pull request #2032 from github/shati-elena/check-for-ql-pack
...
Small tidy-up: Rename test file for databaseFetcher tests
2023-02-03 16:40:51 +00:00
github-actions[bot]
09e7a84597
Bump version to v1.7.9
2023-02-03 16:26:19 +00:00
Elena Tanasoiu
6e53ed020c
Rename tests for databaseFetcher
...
These are not testing anything in the databases.ts file as we're
invoking functions from the DatabaseFetcher.
Let's name the file accordingly
2023-02-03 16:20:07 +00:00
Elena Tanasoiu
0eff27731e
Merge pull request #2041 from github/elena/skip-failing-tests
...
Skip failing tests
2023-02-03 16:17:50 +00:00
Elena Tanasoiu
f276a3414a
Skip failing tests
...
This is blocking us from merging new PRs so while we figure out
how to fix them, let's skip the tests that are failing on our
`main` branch.
For full context: the tests started failing when a new version of
VSCode was released (1.75.0).
2023-02-03 15:54:36 +00:00
Koen Vlaswinkel
0ed03c14bf
Add source map support for full stacktraces
...
This adds support for mapping full stacktraces in the source map
script. This allows you to pass a full stacktrace to the script and get
back a stacktrace with all original positions.
2023-02-03 15:21:57 +01:00
Koen Vlaswinkel
92e2975c24
Add script for retrieving original source location
...
This adds a script that can be used for retrieving the original source
location when given a location in the released extension. It will
download the source map from the Actions workflow run of the release and
use the `source-map` library to extract the original location.
2023-02-03 12:15:57 +01:00
Koen Vlaswinkel
bc181c6c9b
Only set CLI path in workspace configuration
2023-02-03 11:36:40 +01:00
Koen Vlaswinkel
beb0058365
Mock env.openExternal instead of overriding it
2023-02-03 11:29:29 +01:00
Robert
7a9b8bbdde
Merge pull request #2034 from github/v1.7.8
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.7.8
2023-02-02 16:59:00 +00:00
Robert
d2c795bec0
Update extensions/ql-vscode/CHANGELOG.md
...
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com >
2023-02-02 16:38:03 +00:00
Robert
d144874e77
v1.7.8
2023-02-02 16:30:46 +00:00
Koen Vlaswinkel
cac0add788
Mock config instead of writing settings files
...
In our tests, we were writing settings files to disk because we were
using the VSCode configuration API which writes settings to files. This
results in flaky tests because concurrency can cause the VSCode API to
misbehave.
This will switch the tests to use a mocked API by default. For some
tests the real implementation is used, but the large majority of tests
is now using a mocked version which only keeps track of the
configuration in memory. This makes it easier to reset the state between
tests since we can just empty out the in-memory configuration.
2023-02-02 16:51:02 +01:00
Elena Tanasoiu
c493425046
Merge pull request #2027 from github/elena/select-db-in-codespace
...
Introduce command to set default Code Tour database
2023-02-02 12:05:27 +00:00
Charis Kyriakou
302091f2c5
Added version to db config ( #2029 )
2023-02-02 11:50:16 +00:00
Robert
05d9f9b3a6
Add test that error messages are redacted
2023-02-02 11:11:52 +00:00
Robert
69b7e04ec0
Put error logging behind new secret flag
2023-02-02 11:11:49 +00:00
Robert
9184bde8a6
Merge branch 'main' into robertbrignull/logged_error_telemetry
2023-02-02 10:46:41 +00:00
Elena Tanasoiu
99d794c2a8
Update error message
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2023-02-02 10:30:01 +00:00
Elena Tanasoiu
b6aa41d19b
Replace undefined check with length check
2023-02-02 10:27:22 +00:00
Elena Tanasoiu
6257608433
Add comment to indicate which folder we're pointing to
2023-02-02 10:27:22 +00:00
Elena Tanasoiu
6ebeb2b201
Introduce command to set default Code Tour database
...
We have a codespace template which houses our CodeQL tour:
https://github.com/github/codespaces-codeql
This contains a repo with a default databases already loaded
for the user so that they can start writing queries more quickly.
At the moment we're asking the user to manually right click on
the database folder ('codeql-tutorial-database') and set it as
the current database.
We can take this one step further by defining a command that gets
triggered when we arrive at the step for setting up the database.
The command ("codeQL.setDefaultTourDatabase") will build the URI
pointing to our preloaded database and set it as the current one.
We initially considered whether we can re-use the setCurrentDatabase
command and pass the URI of the database from the codespace itself,
but the URI would be hardcoded as:
```
file://0-62/workspaces/codespaces-codeql/codeql-tutorial-database
```
as we can only pass the codeTour extension a command and string
parameters.
This would have been brittle as the filepath for a codespace might
change in the future.
Instead we can define a custom tour command ("setDefaultTourDatabase")
to look at the current workspace folder and build the path to the
database in the CodeQL extension.
Co-authored-by: Shati Patel <shati-patel@github.com >
2023-02-02 10:27:22 +00:00
Nora
9f240c8500
Merge pull request #2028 from github/nora/polish-url-helper
...
DP Panel: Drop protocol check when creating a new item
2023-02-01 20:17:18 +01:00
Koen Vlaswinkel
d4b061115b
Merge pull request #2031 from github/koesie10/gh-pr-create
...
Use first-party action for creating release PR
2023-02-01 15:41:52 +01:00
Koen Vlaswinkel
15382a02bc
Use first-party action for creating release PR
...
Instead of using the third party `peter-evans/create-pull-request`
action for creating a PR for releases, we can use the already present
`./.github/actions/create-pr` action which is also used for the PR for
bumping CLI versions.
2023-02-01 14:39:00 +01:00
Robert
c3050fc324
Merge pull request #2030 from github/robertbrignull/disable-new-telemetry
...
Don't send new telemetry data unless opted-in
2023-02-01 12:21:12 +00:00
Nora
4c54778515
Allow usage of www.github.com
2023-02-01 11:34:49 +00:00
Nora
72412c92c8
Allow usage of github.com
2023-02-01 11:32:57 +00:00
Robert
d780c24994
Don't send new telemetry data unless opted-in
2023-02-01 11:19:11 +00:00
Koen Vlaswinkel
fa8def3c8c
Merge pull request #2025 from github/koesie10/mrva-view-title
...
Update variant analysis view title
2023-02-01 09:37:55 +01:00
Koen Vlaswinkel
ad38d6d1ce
Merge pull request #2023 from github/koesie10/db-panel-controller-repo-welcome
...
Show welcome view when controller repo is not setup
2023-01-31 17:01:00 +01:00
Charis Kyriakou
23a8468a26
Update the copy for the codeQLVariantAnalysisRepositories.removeItemContextMenu command ( #2026 )
2023-01-31 15:36:21 +00:00
Nora
9e54e5eced
Drop protocol check
2023-01-31 14:18:12 +00:00
Koen Vlaswinkel
dbca4456a8
Change variant analysis view title
2023-01-31 11:55:04 +01:00
Koen Vlaswinkel
ecc5fa1e4e
Extract MRVA view title generation to method
...
We had duplicated logic for generating the variant analysis view title.
This extracts it to a single method so the title are always in sync.
2023-01-31 11:53:22 +01:00
Koen Vlaswinkel
7ec4b4bc96
Merge pull request #2024 from github/koesie10/eslint-config
...
Unify ESLint configuration
2023-01-31 11:50:07 +01:00
Koen Vlaswinkel
ba11781165
Move welcome view test to rendering test
2023-01-31 11:43:55 +01:00
Nora
3fa7bec323
Merge pull request #2021 from github/nora/fix-placeholder
...
Fix placeholder copy
2023-01-31 09:52:21 +01:00
Robert
1120f2fca8
Fix tests
2023-01-30 16:58:11 +00:00
Robert
2f573aba0c
Remove accidental spaces from error message string
2023-01-30 16:23:35 +00:00
Koen Vlaswinkel
a3c6b362f8
Remove unnecessary disabled rules
...
These rules are already disabled in the base config, so they don't need
to be disabled individually anymore.
2023-01-30 16:55:05 +01:00
Koen Vlaswinkel
5f382a5677
Combine ESLint configurations
...
Instead of having different ESLint configuration files in each
directory which don't seem to inherit the configuration correctly, this
will add `overrides` in the root file.
2023-01-30 16:43:19 +01:00
Koen Vlaswinkel
6114b591c5
Fix tests when no controller repo is set
...
This also extracts the helper to do so into a separate function to avoid
duplicating this logic.
2023-01-30 15:52:19 +01:00
Nora
87465a65ae
Merge pull request #2022 from github/nora/remove-history-item-hover
...
Query History Item: remove on hover
2023-01-30 14:44:39 +01:00
Koen Vlaswinkel
b3c4979358
Show welcome view when controller repo is not setup
...
This will add a welcome view to the database panel which is shown when
the controller repository is not setup. This welcome view will show a
button which can be used to set up the controller repository.
2023-01-30 14:28:22 +01:00
Nora
3ba13a32e3
Remove query item on hover
2023-01-30 13:07:47 +00:00
Nora
3dc2cec5b6
Update copy
2023-01-30 10:39:42 +00:00
Robert
72c8e0bcb6
Convert RedactableError to an Error class of its own
2023-01-27 17:36:56 +00:00
Koen Vlaswinkel
160a6cca76
Use redactable error message for telemetry events
2023-01-27 11:50:40 +01:00
Koen Vlaswinkel
4edb83163d
Create tagged template for error messages
2023-01-27 11:50:12 +01:00
Robert
fbe0df59be
Fix typos
2023-01-27 10:32:03 +00:00
Koen Vlaswinkel
ddddd2f0b9
Merge pull request #2018 from github/koesie10/download-progress-indicator
...
Add download progress indicator for MRVA downloads
2023-01-27 10:14:32 +01:00
Koen Vlaswinkel
5098382afb
Merge pull request #2014 from github/koesie10/download-progress
...
Report download progress when downloading variant analysis results
2023-01-27 10:14:08 +01:00
Koen Vlaswinkel
7dd5b0a826
Decrease download update delay
...
3 seconds is a really long time to wait for downloads since a
significant percentage of downloads will complete within 3 seconds. This
changes the update delay to 500ms which should still give us good
performance, but also make the download feel more responsive.
2023-01-26 17:11:42 +01:00
Koen Vlaswinkel
94968f41e7
Fix response size calculation
...
The `response.size` is almost always set to `0`. However, the
`Content-Length` header is returned by Azure and contains the size of
the file.
2023-01-26 17:11:40 +01:00
Nora
5ca409797d
Merge pull request #2013 from github/nora/extract-scrubber-tests
...
Extract query history scrubber tests
2023-01-26 17:00:26 +01:00
Koen Vlaswinkel
c7bd9f9394
Add determinate progress ring
2023-01-26 16:47:37 +01:00
Robert
db0d41a305
Introduce showAndLogExceptionWithTelemetry
2023-01-26 15:38:03 +00:00
Nora
2264b6b983
Merge pull request #2016 from github/nora/query-history-context-menu
...
Query History: context menu copy and groups
2023-01-26 16:33:29 +01:00
Nora
012157a57a
Remove unused code
2023-01-26 13:48:56 +00:00
Nora
940169e2a0
Extract query history scrubber tests
2023-01-26 13:48:56 +00:00
Nora
6ebb4affec
Use groups and new copy
2023-01-26 13:41:09 +00:00
Koen Vlaswinkel
0efbbbfef1
Add test for download progress reporting
2023-01-26 13:36:04 +01:00
Koen Vlaswinkel
610a623bc5
Fix download tests
2023-01-26 13:36:04 +01:00
Koen Vlaswinkel
37c9414dad
Use async appendFile
2023-01-26 13:36:04 +01:00
Robert
6cf351f332
Output percentage during results download
2023-01-26 13:36:04 +01:00
Robert
07f5d2b20d
Merge pull request #2010 from github/robertbrignull/logging_types
...
Introduce ShowAndLogOptions
2023-01-26 11:21:28 +00:00
Robert
51a72227e9
Merge pull request #2011 from github/robertbrignull/catch_unknown
...
Enforce that promise rejection values must have unknown type
2023-01-26 10:39:55 +00:00
Robert
e9345dc588
Move documentation to type instead of methods
2023-01-26 10:37:23 +00:00
Nora
2acaf31287
Merge pull request #2007 from github/nora/query-history-sort-button
...
Query History: sorting
2023-01-26 10:43:20 +01:00
Nora
9a572a3c71
Merge pull request #2008 from github/nora/split-query-history-file
...
Query History: split file
2023-01-26 10:38:20 +01:00
Nora
1f52642308
Fix rebase problems
2023-01-26 09:21:04 +00:00
Nora
af7ec57b72
Fix rename in comments
2023-01-26 10:07:31 +01:00
Nora
c993d30b34
Split query history file
2023-01-26 10:07:31 +01:00
Robert
13dd5298bf
Enforce that promise rejection values must have unknown type
2023-01-25 16:34:47 +00:00
Robert
de640e347d
Introduce ShowAndLogOptions
2023-01-25 16:29:30 +00:00
Nora
ca1d63a3fc
Merge pull request #2006 from github/nora/update-old-panel-icons
...
Update icons of old DB panel
2023-01-25 16:58:09 +01:00
Robert
5c5c2e485d
Show download percentage in UI
2023-01-25 16:35:08 +01:00
Robert
2dc45ae5f6
Add downloadPercentage to VariantAnalysisScannedRepositoryState
2023-01-25 16:35:08 +01:00
Robert
ad6cbe60fd
Merge pull request #1989 from github/robertbrignull/credentials_in_app
...
Add credentials to App
2023-01-25 15:15:30 +00:00
Nora
c1392e5c68
Update copy
2023-01-25 13:58:45 +00:00
Nora
dcfa990adb
Use vscode icon for edit
2023-01-25 13:54:48 +00:00
Nora
89483a7b43
Use vscode icon for preview
2023-01-25 13:52:40 +00:00
Nora
bc6b829d17
Use vscode icon for trash
2023-01-25 13:50:13 +00:00
Nora
2c701e0663
Inline shorting in menu
2023-01-25 13:49:56 +00:00
Nora
0771e93c1e
Use vscode icons
2023-01-25 11:34:42 +00:00
Nora
64e73c6426
Merge pull request #2005 from github/nora/update-panel-remote-icon
...
DB panel: use cloud icon for variant analysis repositories
2023-01-25 11:52:09 +01:00
Nora
cf2dec9577
Merge pull request #2004 from github/nora/update-query-history-icons
...
Query history polish: new icons
2023-01-25 11:51:55 +01:00
Robert
9e25d19924
Fix merge conflict
2023-01-25 10:41:40 +00:00
Nora
5342b5b83a
Fix tests for error color
2023-01-25 10:19:49 +00:00
Robert
c5494b6fd2
Merge branch 'main' into robertbrignull/credentials_in_app
2023-01-25 10:15:29 +00:00
Nora
1ec39053cb
Replace remote icon with cloud
2023-01-25 09:55:53 +00:00
Nora
0936185d2f
Replace remote database icon
2023-01-25 09:47:07 +00:00
Nora
ec9b5fe1d3
Replace local database icon
2023-01-25 09:47:06 +00:00
Nora
3c56c549bc
Replace error icon
2023-01-25 09:47:06 +00:00
Nora
407aa14d4d
Merge pull request #2002 from github/elena-nora/move-query-history-files
...
Move query history files to new folders
2023-01-25 10:36:25 +01:00
Nora
76a35deb66
Move query history files to new folders
2023-01-24 17:04:25 +00:00
Nora
d6ab2292e0
Merge pull request #2001 from github/nora/query-history-empty-state
...
Query history polish: update empty state
2023-01-24 18:01:05 +01:00
Robert
8e80106b4f
Add documentation
2023-01-24 15:40:38 +00:00
Robert
697a004005
Combine test credentials methods into testCredentialsWithRealOctokit
2023-01-24 15:40:21 +00:00
Nora
4f2b1af811
Update copy
2023-01-24 15:13:57 +00:00
github-actions[bot]
8ed826c78c
Bump CLI Version to v2.12.1 for integration tests ( #1999 )
2023-01-24 10:36:15 +00:00
Koen Vlaswinkel
f7a9830455
Merge pull request #1788 from github/koesie10/remove-unsupported-version-constraints
...
Remove unsupported version constraints
2023-01-24 10:49:51 +01:00
Robert
1381cb67d6
Merge pull request #1997 from github/robertbrignull/use_as_error
...
Make use of asError instead of reimplementing
2023-01-23 17:15:59 +00:00
Robert
cc76ca80da
Don't change compileAndRunQuery
2023-01-23 16:05:18 +00:00
Robert
3316d1712d
Make use of asError instead of reimplementing
2023-01-23 15:49:31 +00:00
Koen Vlaswinkel
140d369098
Remove unsupported version constraints
...
This removes all CodeQL CLI version constraints for unsupported CLI
versions (< 2.7.6). The oldest supported CLI version is 2.7.6 since GHES
3.3 recommends using CodeQL CLI 2.7.6.
2023-01-23 14:13:05 +01:00
Shati Patel
2c19b32cb3
Minor polish to the "bump CLI" automation ( #1996 )
2023-01-20 18:42:20 +00:00
github-actions[bot]
3ce6735475
Bump CLI Version to v2.12.0 for integration tests ( #1995 )
2023-01-20 17:54:30 +00:00
Taj
c7f72c5aa9
Ensure cli using latest version from the supported_cli_versions.json ( #1992 )
2023-01-20 17:13:14 +00:00
Elena Tanasoiu
a17e41cbf1
Merge pull request #1993 from github/elena/extend-tests
...
Add remote queries and variant analyses to our serialization tests
2023-01-20 15:14:48 +00:00
Charis Kyriakou
3b5b85caed
Disable select item button in new db panel ( #1994 )
2023-01-20 13:45:15 +00:00
Nora
708e55244e
Merge pull request #1991 from github/nora/order-context-menu-actions
...
Sort and group context menu actions
2023-01-20 13:42:54 +01:00
Elena Tanasoiu
b58d82e53a
Fix typo
2023-01-20 12:15:35 +00:00
Elena Tanasoiu
a2df1eaee4
Add remote queries and variant analyses to our serialization tests
...
This was just testing local queries.
2023-01-20 12:11:06 +00:00
Charis Kyriakou
d7fae741ae
Merge pull request #1990 from github/charisk/disable-local-dbs
...
Turn off support for local dbs and remote root 'remote' node from new db panel
2023-01-20 11:29:08 +00:00
Nora
dadd3499ac
Sort and group context menu actions
2023-01-20 11:02:03 +00:00
Charis Kyriakou
526c4f3ab7
Remove root 'remote' node
2023-01-20 09:53:23 +00:00
Charis Kyriakou
65623c07a2
Turn off support for local dbs in new panel
2023-01-20 09:53:23 +00:00
Charis Kyriakou
8a6b361e84
Fix rename that went too far ( #1988 )
2023-01-19 09:09:58 +00:00
Andrew Eisenberg
bd74b410f6
Merge pull request #1973 from github/tjgurwara99/bump-cli-extension
...
Modifying the `bump-cli` workflow to append/replace version from `supported_cli_versions.json`
2023-01-18 09:54:47 -08:00
Robert
03993f376f
Add credentials to App
2023-01-18 17:36:38 +00:00
Elena Tanasoiu
4dc1b12785
Merge pull request #1984 from github/elena/move-tests
...
Move tests for serialization/deserialization in their own file
2023-01-18 17:29:27 +00:00
Charis Kyriakou
c2dcfe92bc
Update db panel rendering tests to not rely on order of root nodes ( #1987 )
2023-01-18 17:47:35 +01:00
Charis Kyriakou
1bd749dee0
Convert integration tests to unit tests ( #1986 )
2023-01-18 16:42:38 +00:00
Elena Tanasoiu
e97a7c4993
Move tests for serialization/deserialization in their own file
...
We didn't have a query-serialization.test.ts file. Now we do.
We can build on these tests when we begin to save other types of data.
2023-01-18 12:21:39 +00:00
Nora
13389fd35f
Merge pull request #1983 from github/nora/db-panel-add-item
...
Extract db panel add items tests to new file
2023-01-18 13:17:23 +01:00
Nora
9c011c5fd1
Create testfile in no workspaces and copy paste
2023-01-18 12:36:45 +01:00
Nora
f97dbb136d
Merge pull request #1981 from github/nora/db-panel-selection
...
Extract db panel selection tests to new file
2023-01-18 12:35:59 +01:00
Taj
f154b59b14
description for version
2023-01-18 11:10:44 +00:00
Charis Kyriakou
ec1cf015bf
Removed unnecessary awaits ( #1982 )
2023-01-18 10:58:37 +00:00
Nora
79289802c0
Create new selection test file and copy paste tests
2023-01-18 10:42:57 +00:00
Nora
e1bc8ae95a
Merge pull request #1980 from github/nora/db-panel-rendering
...
Extract db panel render tests to new file
2023-01-18 11:41:39 +01:00
Robert
0bd6ba7898
Merge pull request #1978 from github/robertbrignull/compare_view_telemetry
...
Telemetry for compare view
2023-01-18 10:13:57 +00:00
Robert
84c6c1ef6b
Merge pull request #1976 from github/robertbrignull/local_results_telemetry
...
Emit telemetry for user interactions in the local results view
2023-01-18 10:13:20 +00:00
Nora
5b6587cc18
Create new file and copy paste tests
2023-01-18 10:07:52 +00:00
Shati Patel
e230bf47d0
When adding repo, check whether name exists in specified parent list ( #1977 )
2023-01-18 10:01:47 +00:00
Nora
6c523db0ad
Merge pull request #1975 from github/nora/review-user-messages
...
Polish user facing messages
2023-01-18 10:05:19 +01:00
Robert
37e3e041e8
Piggyback on changeSort message
2023-01-17 16:46:02 +00:00
Robert
3a4ce9abb1
Telemetry for compare view
2023-01-17 16:34:30 +00:00
Koen Vlaswinkel
b0168aa04a
Merge pull request #1964 from github/koesie10/packages-auth
...
Use stdin for supplying auth to CodeQL
2023-01-17 17:30:25 +01:00
Robert
4009f03dd2
Send telementry on other links and UI elements
2023-01-17 15:49:50 +00:00
Taj
160ee22d1b
combined version change and bump-cli workflow
2023-01-17 14:32:19 +00:00
Nora
fe17f61b5e
Rename remote to variant analysis
2023-01-17 14:18:24 +00:00
Nora
c5722d7aa2
Merge pull request #1972 from github/nora/expanded-tests
...
Add test for behaviour around expanded state
2023-01-17 14:23:15 +01:00
Robert
f1dbc22a9a
output telemtry from local results view on state changes
2023-01-17 12:58:11 +00:00
Robert
10776759c7
Support telemetry from local results view
2023-01-17 12:55:50 +00:00
Nora
e6c6e8a2be
Merge comments
2023-01-17 12:30:11 +00:00
Nora
07868d90e9
Remove unneeded expectations and adjust test
2023-01-17 10:14:08 +00:00
Nora
40f08393b2
Add test for expanded state cleanup
2023-01-17 10:14:08 +00:00
Nora
c6c7b71b8a
Add test for renaming expanded items
2023-01-17 10:14:08 +00:00
Nora
0bccdbb8d6
Add tests for adding and removing item to expanded state
2023-01-17 10:14:08 +00:00
Robert
611f6e39e0
Merge pull request #1953 from github/robertbrignull/telemetry_ui
...
Report telemetry on actions taken in the UI
2023-01-17 09:36:06 +00:00
Elena Tanasoiu
a1f5e5b277
Merge pull request #1944 from github/elena/fix-removal
...
Display modal when removing an item from query history
2023-01-17 08:57:03 +00:00
Koen Vlaswinkel
7b5e5a6407
Merge pull request #1963 from github/koesie10/webpack-production-build
...
Use Webpack in production mode for releases
2023-01-17 09:49:59 +01:00
Koen Vlaswinkel
2957979b15
Update comment for CodeQL CLI authentication
2023-01-17 09:35:48 +01:00
Koen Vlaswinkel
e8799ad275
Handle race condition when authenticating to the CLI
2023-01-17 09:31:58 +01:00
Taj
bfa6780529
first pass at automating appending/prepending/removing version from supported cli versions
2023-01-16 22:06:15 +00:00
Elena Tanasoiu
80f588c5c8
Merge pull request #1971 from github/elena/rename-splat-slurp
...
Rename `splat/slurp` to `serialize/deserialize`
2023-01-16 17:41:34 +00:00
Elena Tanasoiu
57b6c9bb2c
Don't mention splat/slurp in comments or descriptions
2023-01-16 17:20:22 +00:00
Elena Tanasoiu
80dfe4ba69
Rename slurpQueryHistory -> deserializeQueryHistory
2023-01-16 17:20:22 +00:00
Elena Tanasoiu
06bc4c8fe3
Rename splatQueryHistory -> serializeQueryHistory
2023-01-16 17:20:22 +00:00
Elena Tanasoiu
c62f381a2f
Remove extra log message
2023-01-16 17:19:26 +00:00
Elena Tanasoiu
3547fdfd54
Add tests for modal behaviour
...
Tests whether we choose "Yes" / "No" in the new modal window.
"Yes" -> remove the item and show you a toast notification
"No" -> don't remove item
This only shows up for in progress items.
2023-01-16 17:19:25 +00:00
Elena Tanasoiu
ab0e67c251
Split removal tests based on state of query
...
We now have special behaviour for removing an "in progress" query so the
tests will be different.
Let's have a separate section for "in progress" queries. We'll add extra
behaviour testing in the next commit.
2023-01-16 17:19:25 +00:00
Elena Tanasoiu
fa1f355b93
Show dialog with "Are you sure?" for in-progress queries
...
When you attempt to delete a query that's still in progress from your
query history, you get a prompt asking if you're sure.
If you pick "Yes", the item is removed and you see a toast notification
with a link towards the GitHub Action.
2023-01-16 17:19:25 +00:00
Robert
3777eb382f
Make isCanary a string
2023-01-16 16:56:30 +00:00
Nora
4cb3c4cb50
Merge pull request #1968 from github/nora/rename-db-config-file
...
Rename DbConfigFile and Schema
2023-01-16 17:46:54 +01:00
Robert
44a0cad146
Make useTelemetryOnChange signature simpler
2023-01-16 16:44:32 +00:00
Robert
293ec1f204
Add debounce to variant-analysis-selected-repository-ids
2023-01-16 16:36:00 +00:00
Robert
38cbb95ecc
Avoid === true on a boolean
2023-01-16 16:34:13 +00:00
Robert
18ddb3a297
Use isCanary() method
2023-01-16 16:12:20 +00:00
Robert
2453038387
Merge branch 'main' into robertbrignull/telemetry_ui
2023-01-16 16:10:18 +00:00
Charis Kyriakou
856e516b20
Renamed Run Query command ( #1962 )
2023-01-16 15:48:06 +00:00
Nora
6f78fffd10
Merge comments
2023-01-16 15:23:48 +00:00
Charis Kyriakou
957f6a023c
Mark App interface properties as read-only ( #1969 )
2023-01-16 15:20:28 +00:00
Nora
afcb84fcd8
Rename db config file
2023-01-16 10:58:28 +00:00
Nora
c19f58b0e3
Rename schema file
2023-01-16 10:22:55 +00:00
Nora
7f1bcedf9b
Extract config file to constant
2023-01-16 10:11:00 +00:00
Shati Patel
817db85c36
Add "describe" blocks around db-panel tests ( #1965 )
2023-01-16 10:07:35 +00:00
Koen Vlaswinkel
b4bb1b6ad7
Upload sourcemaps for release builds
...
To allow us to reconstruct a stack trace, this will upload the
sourcemaps for all release builds.
2023-01-16 10:58:00 +01:00
Andrew Eisenberg
ecbb0fb232
Merge pull request #1871 from tjgurwara99/main
...
Workflow to automatically bump cli version if different from the current version
2023-01-13 13:14:14 -08:00
Taj
365519af63
fix: src dir to test dir
2023-01-13 19:11:53 +00:00
Taj
ef1444617d
Merge branch 'main' of github.com:tjgurwara99/vscode-codeql
2023-01-13 16:00:22 +00:00
Taj
c72734e49a
fix: replaced with newer version since the PR was open
2023-01-13 15:59:39 +00:00
Taj
7f05af942b
Merge branch 'github:main' into main
2023-01-13 14:00:41 +00:00
Koen Vlaswinkel
20a06238a2
Use stdin for supplying auth to CodeQL
...
This will supply the GitHub access token to certain CodeQL CLI commands
such that private packages can be resolved. It will only do so if the
user has an existing auth session. If they don't, they will now get a
prompt to login. However, this will only happen for commands which
actually use authentication, which is limited to packaging commands.
2023-01-13 15:02:51 +02:00
Taj
91dc39b465
added the bump-cli.yml file to trigger the workflow when changed
2023-01-13 12:58:28 +00:00
Koen Vlaswinkel
f6f8b68ce9
Use Webpack in production mode for releases
...
This will set the `mode` of Webpack to `production` for release builds.
It will also stop inlining the sourcemap and instead produce a separate
file which is excluded by `.vscodeignore`.
In terms of the bundled extension, this will add 1 file
(`out/webview.js.LICENSE.txt`). It decreases the size of the VSIX file
from 4.28MB to 1.77MB.
2023-01-13 14:23:51 +02:00
Robert
47f63f6df6
Implement debounce for telemetry events
2023-01-13 12:17:15 +00:00
Robert
98a29d2459
Convert useStateWithTelemetry to useTelemetryOnChange
2023-01-13 12:17:13 +00:00
Koen Vlaswinkel
f82fde35ee
Merge pull request #1799 from github/koesie10/bundle-extension
...
Bundle extension files using ESBuild
2023-01-13 14:13:35 +02:00
Robert
e9830ee854
Add telemetry message to remote queries view
2023-01-13 11:21:10 +00:00
Shati Patel
277da3c971
Rename feature flag ( #1961 )
2023-01-13 11:07:26 +00:00
Charis Kyriakou
78e01e6f92
Rename db config terms to use 'variant analysis' instead of remote ( #1960 )
2023-01-13 09:30:45 +00:00
Nora
4ae77351c8
Merge pull request #1949 from github/nora/rename-expanded-methods
...
Minor refactoring for expanded things
2023-01-12 17:00:11 +01:00
Nora
5c40293c06
Revert "Rename arguments"
...
This reverts commit 85b7e0eabad1092792ff336b8ccff4fdef04e034.
2023-01-12 15:15:57 +00:00
Nora
ba830dd2e5
Fix expanded bug when renaming lists
2023-01-12 15:15:57 +00:00
Nora
c36da4ba7e
Rename arguments
2023-01-12 15:15:57 +00:00
Nora
b9740fe582
Use individual functions for add and remove from expanded state
2023-01-12 15:15:56 +00:00
Charis Kyriakou
09c60ecfc8
Improve docs around different test suites ( #1959 )
2023-01-12 15:15:24 +00:00
Nora
8b661c7a6d
Merge pull request #1947 from github/nora/db-config-store-tests
...
Improve tests coverage in db-config-store
2023-01-12 14:25:54 +01:00
Nora
94823a6c75
Disable filewatcher for tests
2023-01-12 12:53:12 +00:00
Nora
010e85c28b
Merge comments
2023-01-12 13:44:34 +01:00
Nora
ed11b20cb7
Add tests for does exist methods
2023-01-12 12:43:30 +00:00
Nora
8cb0cd23dd
Add test for set selected item
2023-01-12 12:43:30 +00:00
Nora
9f5e9653da
Add tests for add
2023-01-12 12:43:30 +00:00
Shati Patel
2b7d2d0610
Increase timeout for "variant analysis submission" test ( #1958 )
2023-01-12 12:04:26 +00:00
Shati Patel
e322bf829a
Add db manager tests for "removeDbItem" functionality ( #1948 )
2023-01-12 11:59:25 +00:00
Robert
25a3ba76ed
Extract on-click handlers to consts
2023-01-12 11:01:10 +00:00
Robert
0aa2cd6e90
Make Telemetry.ts lowercase
2023-01-12 10:58:01 +00:00
Charis Kyriakou
67fa920d4d
Merge pull request #1957 from github/charisk/rename-new-db-panel
...
Rename new db panel to 'Variant Analysis Repositories'
2023-01-12 10:55:08 +00:00
Shati Patel
b54dfe9b58
Fix flaky test: avoid file watcher in db manager tests ( #1951 )
2023-01-12 10:51:46 +00:00
Charis Kyriakou
4f588d9def
Remove obsolete test file ( #1955 )
2023-01-12 10:38:57 +00:00
Charis Kyriakou
1c3a6154c9
Rename the id for the new db panel to 'codeQLVariantAnalysisRepositories'
2023-01-12 09:20:35 +00:00
Charis Kyriakou
a21382b053
Rename the user-visible name for the new db panel to 'Variant Analysis Repositories'
2023-01-12 08:49:24 +00:00
Andrew Eisenberg
6f168459a2
Merge pull request #1933 from github/aeisenberg/codeql-pack-yml
...
Ensure remote queries can handle codeql-pack.yml files
2023-01-11 15:55:15 -08:00
Andrew Eisenberg
77c6706320
Ensure remote queries can handle codeql-pack.yml files
...
This updates one of our integration tests so that it uses
`codeql-pack.yml` instead of `qlpack.yml`.
2023-01-11 14:36:43 -08:00
Shati Patel
3fe3117c39
Temporarily skip flaky test ( #1954 )
...
We're working on a fix, but this will unblock CI in the meantime
2023-01-11 16:24:35 +00:00
Robert
e163e0625d
Merge pull request #1952 from github/robertbrignull/open_logs_command
...
Convert opening variant analysis logs to a command
2023-01-11 15:37:28 +00:00
Robert
f1a8564db4
Output telemetry when clicking links
2023-01-11 14:50:25 +00:00
Robert
34e98c4cc5
Convert useStateWithTelemetry to use useMemo
2023-01-11 14:50:25 +00:00
Robert
f325eeb5ab
Output telemetry on react state changes in MRVA results view
2023-01-11 14:50:24 +00:00
Robert
bdfb2f29da
Add method to loging telemetry of a UI interaction
2023-01-11 14:48:14 +00:00
Robert
9d457304b1
Convert opening variant analysis logs to a command
2023-01-11 14:35:40 +00:00
Koen Vlaswinkel
bb63dc52c9
Fix debugging not working
...
VSCode was not able to find the original source of the bundled
extension because it was looking for the source in the `out` directory.
By setting the `sourceRoot` to the `extensions/ql-vscode` directory
which is located at `..` from the `out` directory, VSCode is able to
find the original source and breakpoints are hit.
2023-01-11 12:13:55 +02:00
Koen Vlaswinkel
033d653d44
Fix types in CodeFlowsDropdown
2023-01-11 11:56:50 +02:00
Koen Vlaswinkel
6bf19eb52f
Use case-insensitive path comparison on Windows
2023-01-11 11:29:23 +02:00
Koen Vlaswinkel
477b32662f
Copy WASM file from source-map
...
This will copy the WASM file from source-map to the output directory.
This makes the source-map package work. See the comment in the code for
more details.
2023-01-11 10:43:45 +02:00
Koen Vlaswinkel
65696997de
Add correct binding of sourcemap instance
2023-01-11 10:43:45 +02:00
Koen Vlaswinkel
d79b105751
Remove fs mocking from cli-integration tests
2023-01-11 10:43:44 +02:00
Koen Vlaswinkel
1f9e28e09d
Remove fs mocking from minimal-workspace tests
2023-01-11 10:43:43 +02:00
Koen Vlaswinkel
0d8c90a7b5
Remove fs mocking from no-workspace tests
2023-01-11 10:43:24 +02:00
Koen Vlaswinkel
f13f0b3bc3
Bundle extension files using ESBuild
...
This bundles the extension files using esbuild, as recommended by
VSCode. This reduces the size of the extension from 34MB to less than
5MB.
Gulp will still run TypeScript to check types, but will not use the
TypeScript compiler output in the bundle.
Tests are now run separately, outside of Gulp, so their data doesn't
need to be copied anymore.
See: https://code.visualstudio.com/api/working-with-extensions/bundling-extension
2023-01-11 10:42:24 +02:00
Charis Kyriakou
0b6f2c248b
Refactor logic to remove db or list from config ( #1946 )
2023-01-11 08:41:58 +00:00
Shati Patel
9cf508837e
Add db manager tests for "rename" functions ( #1939 )
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2023-01-10 14:00:47 +00:00
Nora
ed2bdd8a43
Merge pull request #1925 from github/nora/add-remove-context-action
...
Add remove context menu action
2023-01-10 09:09:51 +01:00
Robert
82ce7bc874
Merge pull request #1943 from github/robertbrignull/telemetry_race_condition
...
Avoid race condition requesting telemetry permissions
2023-01-09 17:38:00 +00:00
Robert
7bbbf8b986
Merge pull request #1942 from github/robertbrignull/telemetryListener_undefined
...
Acknowledge that telemetryListener may be undefined
2023-01-09 17:09:32 +00:00
Robert
aa950eed6a
Avoid race condition requesting telemetry permissions
2023-01-09 16:54:32 +00:00
Robert
f9777016a7
Acknowledge that telemetryListener may be undefined
2023-01-09 16:19:09 +00:00
Nora
c4df8bf7b2
Handle expanded state
2023-01-09 15:01:57 +00:00
Nora
29c29f0b77
Remove db in list from selected
2023-01-09 07:54:33 +00:00
Nora
b5f865432e
Add action
2023-01-09 08:26:21 +01:00
Aditya Sharad
8346eda8b8
Integration tests: Accept github/codeql checkouts named ql ( #1940 )
...
Some checkouts of the github/codeql repo, such as the
internal submodule, may be named `ql` rather than
`codeql`. Allow this folder name when running tests.
2023-01-06 15:16:36 -08:00
Charis Kyriakou
2a6d581de4
Added logic to clean expanded state when it's updated ( #1938 )
2023-01-06 16:09:43 +00:00
Shati Patel
b3fcd47930
Add integration test for database selection command ( #1937 )
2023-01-06 14:38:28 +00:00
Charis Kyriakou
8c558f04f4
Merge pull request #1936 from github/charisk/expansion-tidy
...
Some minor tidy up around db item expansion
2023-01-06 14:14:56 +00:00
Charis Kyriakou
51d1d3226c
Remove unnecessary type casting
2023-01-06 12:57:23 +00:00
Charis Kyriakou
d69a048a38
Handle all db item kinds when checking for equality with expanded items
2023-01-06 12:57:19 +00:00
Charis Kyriakou
971fb6edee
Rename updateItemInExpandedState -> updateExpandedItem and replaceItemInExpandedState -> replaceExpandedItem
2023-01-06 12:57:12 +00:00
Elena Tanasoiu
13db377334
Merge pull request #1931 from github/elena/ignore-prettier-commits
...
Move list of ignored commits to root
2023-01-06 09:37:28 +00:00
Andrew Eisenberg
61c3bef8ff
Merge pull request #1932 from github/aeisenberg/fix-vscode-integration-tests
...
Remove assertion in tests
2023-01-05 16:41:49 -08:00
Andrew Eisenberg
0959cb8bbd
Remove assertion in tests
...
I am removing these assertions so that our internal integration tests
can pass. They are currently failing because the number of dependencies
of the `codeql/javascript-all` pack has changed. It no longer makes
sense to test this value as newer versions of this pack will have more
dependencies and we expect this value will continue to go up.
2023-01-05 16:13:13 -08:00
Elena Tanasoiu
d385a9e7a4
Move list of ignored commits to root
...
This was initially added [here][1] but wasn't quite in the right place
to have the intended effect.
Let's move it up to the root of the project.
[1]: f515663640
2023-01-05 17:37:41 +00:00
Charis Kyriakou
1c705da444
Add 'rename' context menu action for dbs/lists ( #1928 )
2023-01-05 13:29:10 +00:00
Shati Patel
4dba169412
Support new DB config format in "copy repo list" function ( #1927 )
2023-01-05 10:56:55 +00:00
Charis Kyriakou
afc6ce5211
Merge pull request #1926 from github/charisk/db-config-store-rename
...
Add db and list rename functionality to db config store
2023-01-04 17:38:44 +00:00
Charis Kyriakou
db9bc5bf5c
Add db and list rename functionality to db config store
2023-01-04 15:59:14 +00:00
Charis Kyriakou
3227935078
Minor refactoring of the db config store and tests ( #1924 )
...
* Remove unnecessary type castings
* Extract validation to separate functions
* Nest tests inside a 'describe' block
2023-01-04 13:11:26 +00:00
Shati Patel
0902e187c8
Add context menu command to open repo/owner on GitHub ( #1921 )
2023-01-04 10:44:48 +00:00
Charis Kyriakou
35a49b018f
Merge pull request #1923 from github/charisk/db-item-expansion-tidy
...
Some small refactorings around db item expansion
2023-01-04 10:02:33 +00:00
Charis Kyriakou
a82f40fb1e
Remove unnecessary config check.
...
This used to be valid when expanded state lived in the db config, but it's now stored in workspace storage.
2023-01-04 09:28:16 +00:00
Charis Kyriakou
4db3cd6b1b
Extract setExpandedItems function so that it can be re-used
2023-01-04 09:10:04 +00:00
Charis Kyriakou
abe5b3c0fc
Rename getCurrentExpandedItems -> getExpandedItems
2023-01-04 09:08:21 +00:00
Charis Kyriakou
7738041ee7
Nest tests inside a 'describe' block
2023-01-04 09:07:42 +00:00
Charis Kyriakou
f3d0773085
Rename calculateNewExpandedState -> updateItemInExpandedState
2023-01-04 09:06:31 +00:00
Charis Kyriakou
1a08ae4df2
Move db item expansion models to db-item-expansion
2023-01-04 09:05:12 +00:00
dependabot[bot]
5e864ae8e0
Bump json5 from 1.0.1 to 1.0.2 in /extensions/ql-vscode ( #1919 )
...
Bumps [json5](https://github.com/json5/json5 ) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases )
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md )
- [Commits](https://github.com/json5/json5/compare/v1.0.1...v1.0.2 )
---
updated-dependencies:
- dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-03 10:10:38 -08:00
dependabot[bot]
f716032235
Bump d3-color and d3-graphviz in /extensions/ql-vscode ( #1915 )
...
Bumps [d3-color](https://github.com/d3/d3-color ) to 3.1.0 and updates ancestor dependency [d3-graphviz](https://github.com/magjac/d3-graphviz ). These dependencies need to be updated together.
Updates `d3-color` from 1.4.1 to 3.1.0
- [Release notes](https://github.com/d3/d3-color/releases )
- [Commits](https://github.com/d3/d3-color/compare/v1.4.1...v3.1.0 )
Updates `d3-graphviz` from 2.6.1 to 5.0.2
- [Release notes](https://github.com/magjac/d3-graphviz/releases )
- [Changelog](https://github.com/magjac/d3-graphviz/blob/master/CHANGELOG.md )
- [Commits](https://github.com/magjac/d3-graphviz/compare/v2.6.1...v5.0.2 )
---
updated-dependencies:
- dependency-name: d3-color
dependency-type: indirect
- dependency-name: d3-graphviz
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-03 10:09:58 -08:00
Charis Kyriakou
8e848e3403
Set db tree item context value to drive actions ( #1920 )
2023-01-03 16:17:51 +00:00
Nora
ae3ed9402d
Merge pull request #1918 from github/nora/add-select-context-menu
...
Add select context menu
2023-01-03 16:40:44 +01:00
Nora
306529b4a9
Add command to activationEvents
2023-01-03 15:10:02 +00:00
Nora
48a51fe10b
Add select context menu
2023-01-03 13:34:50 +00:00
Charis Kyriakou
bbbbb3a1ee
Renamed selectable context value ( #1917 )
2023-01-03 12:34:24 +00:00
Charis Kyriakou
bbdbe01e03
Add test tsconfigs in eslint projects ( #1916 )
2023-01-03 12:17:17 +00:00
Charis Kyriakou
35d1d8ba6e
Move VS Code integration tests to /test directory ( #1912 )
2023-01-03 10:31:38 +00:00
Charis Kyriakou
a7be6cf31a
Fix broken unit test that relies on date ( #1914 )
2023-01-03 09:26:13 +00:00
Charis Kyriakou
40a7dd04fb
Tidy up unit test suite file structure ( #1910 )
2022-12-23 14:23:55 +00:00
Charis Kyriakou
24a7348fc2
Add support for adding local lists ( #1907 )
2022-12-23 11:11:48 +00:00
Charis Kyriakou
31b80efc56
Use constant for selected db item resource uri ( #1908 )
2022-12-23 08:34:16 +00:00
Charis Kyriakou
3234f0afe1
Move db item expanded state to workspace storage ( #1904 )
2022-12-22 15:44:00 +00:00
Elena Tanasoiu
ae0dfd8089
Merge pull request #1901 from github/elena/move-test-scenarios-into-markdown
...
Move test plan into markdown file
2022-12-22 14:32:08 +00:00
Elena Tanasoiu
1a6f532c8b
Change results view title
2022-12-22 14:15:21 +00:00
Elena Tanasoiu
beb5e37f3a
American spelling
2022-12-22 14:14:59 +00:00
Elena Tanasoiu
9fe4c8cfa9
Remove copy section
2022-12-22 14:14:35 +00:00
Shati Patel
9e1da8f142
Check for duplicate repo within parent list ( #1905 )
2022-12-22 14:01:11 +00:00
Elena Tanasoiu
f1b17d1c46
Fix wonky indentation
2022-12-22 12:54:24 +00:00
Elena Tanasoiu
097c048edd
Expand results view tests
2022-12-22 12:49:14 +00:00
Elena Tanasoiu
531f32c1f6
Expand query results scenarios based on variant analysis state
2022-12-22 12:49:10 +00:00
Nora
46a54a623a
Merge pull request #1900 from github/nora/add-repo-to-list
...
Add new repositories to a highlighted user defined list
2022-12-22 13:41:27 +01:00
Elena Tanasoiu
1b76159c06
Fix quotes
2022-12-22 11:35:22 +00:00
Elena Tanasoiu
30e614e26d
Remove duplicate test case
2022-12-22 11:31:21 +00:00
Elena Tanasoiu
8ca9391115
Mention what "it" means
2022-12-22 11:28:55 +00:00
Elena Tanasoiu
ec8066a11c
Clarify these are mostly aimed at MRVA
2022-12-22 11:28:01 +00:00
Elena Tanasoiu
ac27a80769
Drop numbering
2022-12-22 11:27:06 +00:00
Elena Tanasoiu
c9087ffaf0
Update screenshot
2022-12-22 11:26:18 +00:00
Robert
25dd679b7d
Merge pull request #1892 from github/robertbrignull/undefined_credentials
...
Simplify the credentials class, and clear up impossible error cases
2022-12-22 11:20:09 +00:00
Elena Tanasoiu
16c688f9c8
Change to american spelling
2022-12-22 11:15:49 +00:00
Elena Tanasoiu
0f3936900c
Remove pre-live-results sections
2022-12-22 11:15:15 +00:00
Elena Tanasoiu
3c9c6dc324
Rephrase ... erm ... phrases
...
And fix a typo
2022-12-22 11:14:10 +00:00
Elena Tanasoiu
f11cd17f83
Check these when query starts instead of completes
2022-12-22 11:10:05 +00:00
Nora
824f56d614
use find and remove unneccessary checks
2022-12-22 10:53:54 +00:00
Elena Tanasoiu
eddc228a00
Remove bullet points and mention results view
2022-12-22 10:48:36 +00:00
Elena Tanasoiu
812205cecf
Clarify that test cases are for MRVA
2022-12-22 10:45:59 +00:00
Elena Tanasoiu
a839206846
Mention canary flag as pre-requisite for MRVA
2022-12-22 10:45:22 +00:00
Elena Tanasoiu
2f07f417fa
Move last step to first step in release requirements
2022-12-22 10:43:31 +00:00
Elena Tanasoiu
dc6bd07518
Add more info to release steps
2022-12-22 10:43:08 +00:00
Elena Tanasoiu
e890e6cc1f
Remove "Areas to consider" section
2022-12-22 10:32:26 +00:00
Robert
6285ba7632
fix typos
2022-12-22 10:25:34 +00:00
Koen Vlaswinkel
be79d68271
Merge pull request #1891 from github/koesie10/sort-gist-files
...
Sort Gist files by user-defined sort order
2022-12-22 09:17:07 +01:00
Charis Kyriakou
19a9ad38d5
Add workspace state to app container ( #1902 )
2022-12-21 17:58:34 +00:00
Elena Tanasoiu
1e84bc9116
Move test plan into VSCode markdown file
...
This moves our existing test plan under a "Required testing" section.
We're also adding the scenarios used for testing live results under an "Optional testing" section.
2022-12-21 16:55:33 +00:00
Nora
28abd40963
Add repo to list when child is highlighted
2022-12-21 15:45:19 +00:00
Robert
abc025cb39
Inline the createOctokit method
...
It's now only used from one place and inlining it doesn't make
getOctokit too long to be unclear.
2022-12-21 15:01:47 +00:00
Robert
551f76cc4e
Create a new octokit instance every time
...
I believe this doesn't change the user-visible behaviour at all. The user
won't be prompted to log in any more or less often than they would have
done before.
One benefit of this is that we can remove the registerListeners method
because we no longer need to know if the cached octokit is still valid.
Instead we just call vscode.authentication.getSession every time and it
will return the current session, which might be different from the last
time we called it. This might prompt the user to log in, but that would
have happened anyway because when the session changed we would have
overwritten our cached octokit instance.
Another benefit is that we no longer need the extension context and this
removed a surprisingly large amount of code where we are passing this
parameter around because we need it for the credentials.
The only downside I can see is that we call getSession more often and
create more javascript objects in general. I believe the performance
impact of this will be negligible and not worth worrying about.
2022-12-21 15:01:42 +00:00
Robert
8f34f6af2e
Remove the createIfNone parameter from createOctokit
...
At this point we are only ever passing true, so we may as well remove
the parameter and simplify the code.
2022-12-21 14:52:25 +00:00
Robert
8c05b3a508
Don't try to pre-populate an octokit
...
I argue that calling createOctokit(false) adds no benefit. If an
authenticated session already exists then this silently create an
octokit, which makes getOctokit() a no-op just returning the field.
However if there is already an authenticated session then getOctokit()
would already be able to create an octokit without prompting the user.
On the other hand if there isn't an authenticated session then we
won't be able to pre-populate an octokit, so getOctokit() will have
to prompt the user anyway.
Not calling createOctokit(false) in registerListeners also doesn't
change behaviour. If the user is authenticated in the new session then
we would be able to create an octokit instance wihtout prompting in
getOctokit anyway. If the user is not authenticated in the new session
then we won't be able to create an instance without prompting either way.
The only benefit I can think of is that it moves a tiny amount of
computation earlier in the pipeline, but the amount of computation is
tiny and it isn't any more async than it would be if it happened in
getOctokit(). I don't think this is worth making the code more complex.
2022-12-21 14:51:13 +00:00
dependabot[bot]
7004e94b32
Bump actions/dependency-review-action from 1 to 3 ( #1897 )
2022-12-21 14:32:38 +00:00
Robert
74f10a306e
Remove the overrideToken parameter from createOctokit
...
This was only used from initializeWithToken and only added a completely
separate case to the start of the method, effectively turning it into
two separate implementations. Therefore we can make things simpler by
inlining this case in the one place it is used.
2022-12-21 14:27:50 +00:00
Robert
7e8ce35485
Remove the requiresAuthentication parameter
...
It is true by default and no place in the codebase sets it to false. We can
simplify the code by removing this case we aren't using. If we want this
behaviour in the future we can always implement it again, but I think it's
likely to be unnecessary and if you don't want authenticated requests then
you likely won't be initializing a Credentials object.
2022-12-21 14:24:13 +00:00
Nora
758c182a33
Add repo to highlighted list
2022-12-21 15:23:09 +01:00
Robert
0c483d1e29
Remove places where we are checking if credentials are undefined
...
This cannot happen already, even before the other changes in this PR.
The Credentials.initialize method can never return undefined, so these
checks would never return true. The real place that checks that we are
authenticated is in the vscode.authentication.getSession method, and
it will reject the promise if the user declines to authenticate or
anything else means we can't get an authenticated session.
I feel justified in removing the tests for these cases because the
code was never actually called in production, and we are covered by the
vscode authentication library rejecting the promise. Any exception
thrown from Credentials.initialize would behave the same as the one I'm
deleting.
2022-12-21 14:23:08 +00:00
dependabot[bot]
4bb3be9fd1
Bump peter-evans/create-pull-request from 3.4.1 to 4.2.3 ( #1898 )
2022-12-21 14:10:45 +00:00
Shati Patel
f99e5587d0
Update dependencies in workflow files ( #1896 )
2022-12-21 13:54:49 +00:00
Charis Kyriakou
2493b0fd3c
Handle db validation errors gracefully ( #1895 )
2022-12-21 12:53:47 +00:00
Charis Kyriakou
dbdb4ba57a
Stop user from adding a db or owner with the same name ( #1893 )
2022-12-21 10:51:24 +00:00
Charis Kyriakou
55869e8033
Merge pull request #1894 from github/charisk/add-db-integration-test
...
Add basic integration test for 'add db' functionality
2022-12-21 10:06:52 +00:00
Charis Kyriakou
47ac9c631e
Add basic integration test for 'add db' functionality
2022-12-20 20:42:14 +00:00
Charis Kyriakou
decbd52d1b
Rename 'addNewRemoteList' to 'addNewList'
2022-12-20 20:40:58 +00:00
Nora
952faf5efc
Merge pull request #1889 from github/shati-nora/add-remote-repositories
...
Create "Add database" button in DB panel
2022-12-20 17:31:12 +01:00
shati-patel
eb3ba1e229
Merge branch 'main' into shati-nora/add-remote-repositories
2022-12-20 16:13:00 +00:00
Shati Patel
5a3248647b
Get highlighted item in DB panel ( #1887 )
2022-12-20 16:00:45 +00:00
Charis Kyriakou
4b43b9a140
Use ✓ for db item selection ( #1890 )
2022-12-20 15:00:03 +00:00
Nora
467d43c68c
Implement refactor merge comments
2022-12-20 12:58:50 +00:00
Koen Vlaswinkel
fe7d14b136
Sort Gist files by user-defined sort order
...
This will sort the files in an exported Gist by the user-defined sort
order. It does so by prefixing the files with `result-{index}-` where
the `index` is the 1-based index of the repository in the sort order.
It will automatically pad the index with leading zeros to ensure that
the files are sorted in the correct order.
Unfortunately, we can't just use `{index}-` because numbers sort before
the `_` character, which is used in the summary filename to place it
first.
There are also some changes in how we determine which repositories to
export since we need to know in advance how many zeroes we need to pad
the index with. There should be no functional changes in which
repositories are actually exported.
2022-12-20 13:51:22 +01:00
Nora
f332e6145a
Implement addNewDatabase
2022-12-20 11:01:48 +00:00
Nora
6350ac7f66
Merge pull request #1888 from github/nora/refactor-githubnwoowner-helper
...
Extract github url identifier helper
2022-12-20 12:01:13 +01:00
Nora
7241e317af
Move helper to new file and minor refactor
2022-12-20 10:19:42 +00:00
Charis Kyriakou
22ec4b0b6a
Don't allow empty list names ( #1886 )
2022-12-19 11:59:53 +00:00
Taj
5a42b8b890
using secrets instead of actions context
2022-12-16 20:30:14 +00:00
Taj
f2076df73d
Merge branch 'main' of github.com:tjgurwara99/vscode-codeql
2022-12-16 20:28:51 +00:00
Taj
c89d267d55
change the order of supported versions
2022-12-16 20:28:29 +00:00
Taj
09d744a98e
Merge branch 'github:main' into main
2022-12-16 18:36:37 +00:00
Andrew Eisenberg
2493ddd39a
Merge pull request #1885 from github/aeisenberg/lgtm-remove
...
Remove LGTM references and commands
2022-12-16 10:17:15 -08:00
Andrew Eisenberg
0bf1fae2fe
Remove LGTM references and commands
...
LGTM has been decommissioned. All code and tests for downloading
LGTM databases should be removed.
2022-12-16 09:58:24 -08:00
Taj
f7d48916d9
Merge branch 'github:main' into main
2022-12-16 17:21:43 +00:00
Taj
ec9078d616
permission conf and removed deprecated use of set-output
2022-12-16 17:09:39 +00:00
Charis Kyriakou
8971bee31d
Add basic integration test for 'add db list' functionality ( #1881 )
2022-12-16 14:44:53 +00:00
Taj
2723816a5a
namespacing actions branch
2022-12-16 13:40:38 +00:00
Koen Vlaswinkel
281fe56d2b
Merge pull request #1883 from github/koesie10/result-performance
...
Add Storybook story for many results performance
2022-12-16 14:20:06 +01:00
Taj
54204167b6
separation of concern of creating a PR vs code to change the version
2022-12-16 13:12:19 +00:00
Koen Vlaswinkel
c6c6d55bed
Add Storybook story for many results performance
2022-12-16 13:28:59 +01:00
Nora
2b1a2cddb1
Merge pull request #1880 from github/nora/move-db-config-factories
...
Move DbConfig Factories to src directory
2022-12-16 10:05:01 +01:00
Nora
0c2e15a176
Use factory in db tree creator
2022-12-15 14:56:26 +00:00
Nora
1aebd895b1
Use factory in db panel test
2022-12-15 14:53:36 +00:00
Nora
8665a81ec1
Move factory to src
2022-12-15 14:52:51 +00:00
Shati Patel
fecefe4468
Add unit tests to check codeQLDatabasesExperimental.configError value ( #1876 )
2022-12-15 13:07:17 +00:00
Charis Kyriakou
727da3d78c
Add logging around db config loading ( #1875 )
2022-12-15 12:21:20 +00:00
Charis Kyriakou
468c4a2539
Add logger to the app container ( #1874 )
2022-12-15 11:28:38 +00:00
Shati Patel
18423ca518
Hide DB panel UI actions when config is broken/undefined ( #1866 )
2022-12-15 10:50:13 +00:00
Charis Kyriakou
091d793f13
Stop user from adding a db list with the same name ( #1873 )
2022-12-15 09:21:54 +00:00
Charis Kyriakou
b1bf82d432
Enable awaitWriteFinish for the db config file watcher ( #1872 )
2022-12-14 15:25:34 +00:00
Charis Kyriakou
602289eb6d
Add validation for duplicate names in the db config ( #1867 )
2022-12-14 12:51:46 +00:00
Taj
3f39af2840
workflow to automatically bump cli version if different from the current version
2022-12-14 00:01:36 +00:00
Shati Patel
bce5d420d6
Bump CLI version to 2.11.6 for integration tests ( #1869 )
2022-12-13 18:15:49 +00:00
Charis Kyriakou
dc2e17d2f9
Add min length constraints to various properties in the db config schema ( #1868 )
2022-12-13 17:29:02 +00:00
Nora
b2285499a3
Merge pull request #1860 from github/nora/show-error-empty-list
...
Show error message when running query on empty list
2022-12-13 17:48:18 +01:00
Shati Patel
5ba2a5af1d
Merge pull request #1865 from github/shati-patel/gh-nwo
...
Extract github nwo helper functions
2022-12-13 15:35:56 +00:00
Nora
0f1881d2bc
Merge comments
2022-12-13 15:12:57 +00:00
Charis Kyriakou
e18a33074c
Update ValueResult to have generic error type ( #1861 )
2022-12-13 14:15:52 +00:00
Robert
3b197a21e7
Merge pull request #1864 from github/version/bump-to-v1.7.8
...
Bump version to v1.7.8
2022-12-13 14:13:12 +00:00
Charis Kyriakou
e987a3535d
Fix executeCommand to pass arguments correctly ( #1863 )
2022-12-13 13:12:10 +00:00
robertbrignull
060b7c6099
Bump version to v1.7.8
2022-12-13 13:10:27 +00:00
shati-patel
674a126078
Extract github nwo helper functions
2022-12-13 12:58:46 +00:00
Robert
2a60faa451
Merge pull request #1862 from github/v1.7.7
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.7.7 release
2022-12-13 12:44:40 +00:00
Robert
578ffe0e2f
v1.7.7
2022-12-13 11:55:42 +00:00
Robert
e805ef37eb
Merge pull request #1769 from github/robertbrignull/liveResults_true
...
Make live results enabled for everyone
2022-12-13 11:46:18 +00:00
Robert
1e76e583c7
Make live results enabled for everyone
2022-12-13 11:08:39 +00:00
Nora
ed9592c2d7
Update extensions/ql-vscode/src/vscode-tests/no-workspace/remote-queries/repository-selection.test.ts
...
Co-authored-by: Robert <robertbrignull@github.com >
2022-12-13 11:37:12 +01:00
Shati Patel
25b9aeba8e
DB panel: "Add list" command ( #1851 )
2022-12-13 09:54:00 +00:00
Nora
35ce928068
Show error message when running query on empty list
2022-12-13 09:53:07 +00:00
Charis Kyriakou
e521112f3e
Add db config factory function and use it in tests ( #1859 )
2022-12-13 08:36:37 +00:00
Charis Kyriakou
216faee279
Db module init tidy up ( #1858 )
2022-12-12 11:59:57 +00:00
Koen Vlaswinkel
891ce74a80
Merge pull request #1847 from github/koesie10/typecheck-everything
...
Run type checking on all directories in CI
2022-12-12 11:36:09 +01:00
Koen Vlaswinkel
e2e4879548
Merge remote-tracking branch 'origin/main' into koesie10/typecheck-everything
2022-12-12 10:14:50 +01:00
Koen Vlaswinkel
cac7c3ae4e
Simplify gulpfile.ts/tsconfig.json
...
The `tsconfig.json` inside `gulpfile.ts` needs to match the root
`tsconfig.json`, so by making it extend the root `tsconfig.json` and
changing just the options which decide which files are included, we can
remove a lot of duplication.
2022-12-12 10:13:58 +01:00
Charis Kyriakou
7dedfca369
Properly track collapsed/expanded events ( #1856 )
2022-12-12 09:00:19 +00:00
Charis Kyriakou
1a0d88135d
Add executeCommand to app container ( #1857 )
2022-12-09 17:12:25 +00:00
Nora
ed76b46fa5
Merge pull request #1853 from github/nora/test-factories-dbitem
...
Create and use more factories for DbItem creation
2022-12-09 14:27:29 +01:00
Nora
1dc69a125b
Merge pull request #1848 from github/nora/db-module-initialization
...
Initialize DbManager when newQueryRun is enabled
2022-12-09 14:21:50 +01:00
Nora
35f582b731
Implement merge comments
2022-12-09 12:53:40 +00:00
Koen Vlaswinkel
794e874206
Merge pull request #1854 from github/koesie10/upgrade-vsce
...
Replace vsce by @vscode/vsce
2022-12-09 12:34:18 +01:00
Nora
e7bab9207d
Remove unused checks
2022-12-09 09:59:59 +00:00
Koen Vlaswinkel
3bd61ae1a6
Merge remote-tracking branch 'origin/main' into koesie10/upgrade-vsce
2022-12-09 10:36:02 +01:00
Angela P Wen
698b6ad0e4
Bump CLI version to 2.11.5 for integration tests ( #1855 )
2022-12-09 09:33:29 +00:00
Koen Vlaswinkel
abbebd3d42
Merge pull request #1845 from github/koesie10/variant-analysis-remove-item-tests
...
Add tests for removing remote queries and variant analyses
2022-12-09 10:30:23 +01:00
Nora
33ef89a28c
Use new factories
2022-12-09 10:16:49 +01:00
Nora
a9b2aec353
Create missing factories and test adjustment
2022-12-09 10:16:49 +01:00
Koen Vlaswinkel
1cb0b0b6cb
Replace vsce by @vscode/vsce
...
The `vsce` package has been replaced by `@vscode/vsce`, as announced
in the VSCode 1.74.0 release notes. There should be no functional
changes between 2.7.0 and 2.15.0 for our use case.
See: https://code.visualstudio.com/updates/v1_74#_renaming-of-vsce-to-vscodevsce
2022-12-09 09:48:27 +01:00
Koen Vlaswinkel
3346bd48cb
Merge remote-tracking branch 'origin/main' into koesie10/variant-analysis-remove-item-tests
2022-12-09 09:47:46 +01:00
Andrew Eisenberg
5138831cd3
Merge pull request #1852 from github/koesie10/fix-vscode-1.74.0
...
Fix failing tests on VSCode 1.74.0
2022-12-08 10:20:29 -08:00
Koen Vlaswinkel
484c7db8c5
Use Proxy for _VSCODE_NODE_MODULES
...
Instead of deleting the complete `_VSCODE_NODE_MODULES` object, we now
use a `Proxy` to intercept the `_isMockFunction` property. This is safer
and will not delete a global variable that VSCode expects to exist.
2022-12-08 18:47:03 +01:00
Koen Vlaswinkel
691121d7c7
Restructure handleRemoveHistoryItem tests
...
This will restructure the `handleRemoveHistoryItem` tests to be more
structured and easier to read.
2022-12-08 14:01:33 +01:00
Koen Vlaswinkel
1ea3cfddb0
Fix failing tests on VSCode 1.74.0
...
This fixes the tests on VSCode 1.74.0. The issue is as follows:
1. Jest wil try reset all mocks after each test, as it should.
2. When Jest does this, it will loop over all global variables and check
if they are mocks.
3. One of the global variables it checks is _VSCODE_NODE_MODULES, which
is a proxy object.
4. When Jest checks whether it is a proxy by getting _isMockFunction on
it, the `get` function on the proxy object will be called.
5. This will in turn call require, which will try to load
the non-existing `_isMockFunction` module. This throws the error we are
seeing.
By removing the `_VSCODE_NODE_MODULES` property from the global object
in the Jest environment, Jest will not try to reset it, and the tests
should work again.
See: 41bf230089/packages/jest-runtime/src/index.ts (L1173-L1186)
See: ed442a9e99/src/bootstrap-amd.js (L15)
2022-12-08 11:52:45 +01:00
Koen Vlaswinkel
993b8c94d6
Merge pull request #1832 from github/koesie10/restructure-varianta-analysis-manager-tests
...
Restructure variant analysis manager tests
2022-12-08 10:04:19 +01:00
Koen Vlaswinkel
79f427c05d
Merge pull request #1850 from github/koesie10/upgrade-actions-upload-artifact
...
Upgrade actions/upload-artifact to v3
2022-12-07 18:55:02 +01:00
Koen Vlaswinkel
d66e7c6198
Merge pull request #1837 from github/koesie10/fix-no-error-empty-repositories
...
Fix missing error message on repository selection
2022-12-07 17:57:54 +01:00
Koen Vlaswinkel
8205b19125
Upgrade actions/upload-artifact to v3
...
This upgrades the action to remove a deprecation warning about Node 12.
2022-12-07 17:44:44 +01:00
Koen Vlaswinkel
597c9c48ff
Merge pull request #1849 from github/koesie10/date-environment-variables
...
Add environment variables for date test
2022-12-07 17:36:29 +01:00
Koen Vlaswinkel
7fd45efed8
Merge remote-tracking branch 'origin/main' into koesie10/fix-no-error-empty-repositories
2022-12-07 17:29:44 +01:00
Koen Vlaswinkel
2e7557ba09
Run type checking on all directories in CI
...
This commit adds a new step to the CI workflow that runs type checking
on all directories containing `tsconfig.json` files, using `find` and
`xargs`. Unfortunately, this does not work on Windows, so on Windows
it's not possible to run all of these type checks locally.
2022-12-07 16:50:19 +01:00
Koen Vlaswinkel
0f5117ecec
Merge pull request #1828 from github/koesie10/results-loading
...
Add spinner when loading results
2022-12-07 16:46:20 +01:00
Koen Vlaswinkel
0ae7bb821d
Extract mocking of repo states into method
2022-12-07 16:44:34 +01:00
Koen Vlaswinkel
ba419dd561
Remove duplicate describe
2022-12-07 16:40:15 +01:00
Koen Vlaswinkel
3dd0ef50e0
Merge pull request #1846 from github/koesie10/monitor-multiple-responses-test
...
Add integration test for variant analysis monitor
2022-12-07 16:38:47 +01:00
Nora
1c1117f7a3
Suggestion: initialize DbManager when newQueryRun is enabled
2022-12-07 16:35:51 +01:00
Koen Vlaswinkel
4e66b62534
Add environment variables for date test
...
This adds the environment variables necessary for running the date test
in all of these cases:
- When running the npm script outside of VSCode (using `cross-env`)
- When using the Jest Runner "Run" option (`terminal.integrated.env.*`)
- When using the Jest Runner "Debug" option
2022-12-07 16:35:48 +01:00
Nora
572ba290b4
Merge pull request #1838 from github/charis-nora/run-mrva-against-selected-db
...
Use currently selected remote DB when Variant Analysis is run
2022-12-07 15:05:35 +01:00
Koen Vlaswinkel
63c2932cd9
Add integration test for variant analysis monitor
...
This integration test will check that the monitor will actually make
multiple requests to the API and that it will trigger a download
extension command for each repo that has finished scanning.
2022-12-07 14:49:32 +01:00
Charis Kyriakou
d97eb2e76b
Track expanded state of db items ( #1844 )
2022-12-07 12:39:18 +00:00
Nora
323862a828
Merge comments
2022-12-07 12:57:10 +01:00
Koen Vlaswinkel
502d4236ad
Add tests for removing remote queries and variant analyses
...
Unfortunately, one of the tests we have for local queries doesn't seem
to be working for variant analyses. I'm not sure why it isn't
working, but I think it's better to get the rest of the integration
tests in and then figure out what's going on with that one.
2022-12-07 12:30:56 +01:00
dependabot[bot]
28652a2088
Bump decode-uri-component from 0.2.0 to 0.2.2 in /extensions/ql-vscode ( #1842 )
...
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component ) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases )
- [Commits](https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.2 )
---
updated-dependencies:
- dependency-name: decode-uri-component
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-06 17:39:18 +01:00
dependabot[bot]
04b4d15099
Bump @xmldom/xmldom from 0.8.3 to 0.8.6 in /extensions/ql-vscode ( #1843 )
...
Bumps [@xmldom/xmldom](https://github.com/xmldom/xmldom ) from 0.8.3 to 0.8.6.
- [Release notes](https://github.com/xmldom/xmldom/releases )
- [Changelog](https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md )
- [Commits](https://github.com/xmldom/xmldom/compare/0.8.3...0.8.6 )
---
updated-dependencies:
- dependency-name: "@xmldom/xmldom"
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-06 17:20:19 +01:00
Shati Patel
7ef75f5971
New DB panel: Add UI command to select database item ( #1840 )
2022-12-06 16:00:08 +00:00
Koen Vlaswinkel
4bfefb8ebb
Merge pull request #1841 from github/koesie10/fix-monitor-await
...
Fix incorrect await for monitor
2022-12-06 16:30:15 +01:00
Charis Kyriakou
a5fcfe7f40
Add functionality to set the selected db item ( #1839 )
2022-12-06 15:20:07 +00:00
Nora
7a3d5c1925
Add unit tests
2022-12-06 15:28:14 +01:00
Nora
18c3ce237e
Reorder existing tests in new describe blog
2022-12-06 15:25:33 +01:00
Koen Vlaswinkel
6f52469d64
Fix incorrect await for monitor
...
When rehydrating remote queries, we were awaiting the monitoring
command. Since this command may take minutes to hours to complete, it
seems like this would block the extension from loading. This is the same
issue as in https://github.com/github/vscode-codeql/pull/1698 , but for
remote queries instead of variant analyses.
2022-12-06 14:36:00 +01:00
Nora
728f80189b
Refactor selection method to allow all types of DbItem lists
2022-12-06 09:41:36 +01:00
Nora
dbba6972e1
Run MRVA against remote DB
2022-12-06 09:41:36 +01:00
Nora
c436688eb2
Merge pull request #1830 from github/nora/selected-db-item
...
Create method that returns selected DbItem
2022-12-06 09:33:21 +01:00
darkred
127baea584
Update README.md to clarify that vscode-codeql also installs 'Test Adapter Converter' and 'Test Explorer UI' ( #1831 )
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-12-05 09:10:20 -08:00
Nora
425befa959
Add tests
2022-12-05 17:38:40 +01:00
Nora
1050968db1
Update extensions/ql-vscode/test/pure-tests/databases/db-item-selection.test.ts
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2022-12-05 16:57:30 +01:00
Nora
7a2f976199
Refactor selection method to allow all types of DbItem lists
2022-12-05 16:21:35 +01:00
Nora
9362881e22
Rename method on db Manager
2022-12-05 16:21:03 +01:00
Nora
60b1f141a1
Rename and reduce test lines
2022-12-05 16:20:49 +01:00
Koen Vlaswinkel
02c8df003a
Fix missing error message on repository selection
...
The repository selection was structured such that you would get in the
`else` case if there was nothing selected, but this case would also be
used if for some other reason the selected item was not valid.
This restructures the conditions to first check whether the user
cancelled out of the operation and will silently return in that case. In
other cases where it cannot determine the repositories, it will now show
a user-visible error.
2022-12-05 15:17:31 +01:00
Koen Vlaswinkel
b91e31cb2c
Merge pull request #1835 from github/koesie10/hide-analyzed-when-failed
...
Hide analyzed panel when it's empty
2022-12-05 14:51:11 +01:00
Koen Vlaswinkel
272aed7d31
Merge pull request #1836 from github/koesie10/fix-view-jest-config
...
Fix Jest config for view tests
2022-12-05 14:40:17 +01:00
Koen Vlaswinkel
96850e442f
Hide analyzed panel when it's empty
...
This will hide the "Analyzed" panel when there are no scanned repos and
it's completely empty.
When all three panels are empty, this will also hide the search bar and
filters, and will skip rendering anything for the panels.
2022-12-05 14:06:07 +01:00
Koen Vlaswinkel
a19a3297c5
Fix Jest config for view tests
...
This will allow running the view tests in `src/view`, rather than
only allowing these tests to be run from the root directory.
2022-12-05 13:59:09 +01:00
Shati Patel
795a0bc46d
Minor: make changelog entry more consistent ( #1834 )
2022-12-05 11:19:08 +00:00
Charis Kyriakou
2967777db1
Track parent list name for db items ( #1833 )
2022-12-05 10:48:33 +00:00
Koen Vlaswinkel
7bb0d0fda9
Restructure variant analysis manager tests
...
This restructures the variant analysis manager tests to follow this
pattern:
- Class
- Method
- Context
- Context
- ...
- Test
Before, we were only using this pattern for some of the tests and this
made it confusing were which method was being tested.
By splitting this off, it will also be easier to move some of these
tests out of the cli-integration tests and into the no-workspace or
minimal-workspace tests.
2022-12-05 11:16:27 +01:00
Koen Vlaswinkel
0e744fdb5a
Merge pull request #1822 from github/koesie10/consistent-query-text-file-commands
...
Make query text and file commands consistent
2022-12-05 10:46:29 +01:00
Koen Vlaswinkel
39a0ef00c4
Merge pull request #1825 from github/koesie10/add-swift-support
...
Add basic Swift support
2022-12-05 10:23:33 +01:00
Nora
9110af80d8
Add test
2022-12-05 10:08:04 +01:00
Nora
ee056ce2b3
Create method to expose selected DbItem
2022-12-05 10:08:04 +01:00
Nora
2db4a951c2
Merge pull request #1829 from github/nora/fix-vscode-test-setup
...
Fix problem running integration tests from VsCode test and debug panel
2022-12-05 09:58:03 +01:00
Koen Vlaswinkel
994ebaacd0
Merge pull request #1827 from github/koesie10/filter-sarif-snippets
...
Limit SARIF code snippet size
2022-12-02 18:46:19 +01:00
Nora
d00dde06ca
Adjust launch.json
2022-12-02 16:36:43 +01:00
Koen Vlaswinkel
402b33830d
Add tests for excluded snippets
2022-12-02 16:32:29 +01:00
Koen Vlaswinkel
735372ee72
Implement PR feedback
2022-12-02 16:26:24 +01:00
Koen Vlaswinkel
51d3a018de
Add spinner when loading results
...
This will add a spinner to each repo row when the results for a
particular repo are loading. It will also disable the row to make clear
that it is loading and not clickable.
2022-12-02 16:19:56 +01:00
Koen Vlaswinkel
c0187a5650
Limit SARIF code snippet size
...
This adds a new filtering on SARIF code snippets for very large code
snippets (defined as 8MB or more). If less than 1% of such a snippet
is highlighted, it will not include the code snippet in the analysed
results, and it will thus not be shown in the UI.
This is to avoid very large SARIF files that can cause the extension
host to crash when the analysis results are send to the UI. I don't
think any of these snippets would ever be useful to show, so it should
be fine to just not include them.
2022-12-02 15:33:44 +01:00
Robert
008d7b363f
Merge pull request #1826 from github/robertbrignull/check_status
...
Check variant analysis status in isVariantAnalysisComplete
2022-12-02 14:23:36 +00:00
Koen Vlaswinkel
c9d6bfd32e
Merge pull request #1820 from github/koesie10/export-progress
...
Add progress notification to exporting results
2022-12-02 14:55:28 +01:00
Koen Vlaswinkel
dc2bb3a6e0
Merge remote-tracking branch 'origin/main' into koesie10/export-progress
2022-12-02 14:25:05 +01:00
Robert
1d4cbde48e
Check variant analysis status in isVariantAnalysisComplete
2022-12-02 12:45:52 +00:00
Shati Patel
8b354357c1
Show selected item in new DB panel ( #1824 )
2022-12-02 12:44:51 +00:00
Koen Vlaswinkel
109ee0498e
Merge pull request #1816 from github/koesie10/export-cancelled-results
...
Add exporting of in-progress/cancelled results
2022-12-02 13:03:37 +01:00
Koen Vlaswinkel
944a9115e9
Add basic Swift support
...
The extension doesn't actually use anything regarding the language of
variant analyses, so this just updates some types.
The actual Swift support is done in the CLI, which is also used for
determining which languages are actually supported. So, the environment
variable is already used by the CLI for showing supported languages.
2022-12-02 11:23:26 +01:00
Koen Vlaswinkel
9c51974cb0
Merge pull request #1821 from github/koesie10/monitor-error-handling
...
Handle errors when retrieving variant analyses in the monitor
2022-12-02 11:12:29 +01:00
Charis Kyriakou
6d1b5ab1e1
Update the format of selected state and propagate it to the treeview ( #1817 )
2022-12-01 16:27:21 +00:00
Koen Vlaswinkel
5bee07c712
Merge pull request #1819 from github/koesie10/fix-export-title
...
Fix Gist title in result export
2022-12-01 14:19:00 +01:00
Koen Vlaswinkel
32f3d32989
Add tests for opening query text/file
2022-12-01 14:03:07 +01:00
Koen Vlaswinkel
dd5da2bbc0
Make query text and file commands consistent
...
We were using two different implementations for opening the query file
and query text between the query history and the results view. This
moves the better implementation in the view to a command and uses these
commands for opening the query text/file in the query history and view.
This results in consistent error messages and behaviour between the two
different views.
2022-12-01 13:39:35 +01:00
Koen Vlaswinkel
3d81e1b31e
Handle errors when retrieving variant analyses in the monitor
...
This will add error handling to the retrieval of variant analyses in the
monitor by catching the error. It will show a warning to the user and
log it. Then, it will simply sleep for 5 seconds and try again.
I'm not sure if we want to show all of these errors to the user since
this can result in many warnings popping up if many variant analyses are
being monitored, but this is probably that the user should be made aware
of.
2022-12-01 13:22:57 +01:00
Koen Vlaswinkel
bf84dbea69
Merge pull request #1818 from github/koesie10/fix-duplicate-webviews-error
...
Close serialized webview when another view already exists
2022-12-01 12:55:47 +01:00
Koen Vlaswinkel
7414a77b8a
Add progress notification to exporting results
...
This will add a progress notification to exporting results to give users
feedback about what's happening.
Unfortunately, we need to change some things in how we handle the
actions on completion notifications since we want the progress
notification to disappear when that notification shows. This results in
us having to remove the `await` on the
`showInformationMessageWithAction` calls.
2022-12-01 12:53:10 +01:00
Nora
fb154ab423
Merge pull request #1814 from github/nora/adjust-errormessage-api-response
...
Adjust for new GitHub Api response
2022-12-01 12:24:28 +01:00
Koen Vlaswinkel
6a431b0719
Fix Gist title in result export
...
The Gist title in the result export didn't take into account the actual
number of exported repositories, it only used the scanned, unfiltered,
repositories in the variant analysis. This switches it to use the actual
exported repositories for determining the result and repository counts.
This is somewhat more complicated than we'd expect it to be since the
results are being read in async, so we need to switch the order of
operations and store some additional information for being able to
compute this information. However, this also makes the code somewhat
easier to understand since the summary file is now being created in only
1 location, rather than being split between a method and a for-loop.
2022-12-01 12:14:35 +01:00
Koen Vlaswinkel
f6bb233a15
Close serialized webview when another view already exists
...
When deserializing a webview, it could happen that a view was already
manually opened by the user before the webview was deserialized. This
would result in duplicate webview tabs, which is not supported by the
manager.
This will close the webview that is being deserialized and focus on the
existing view. This should ensure that we never have duplicate loaded
webview tabs. There could still be duplicate webview tabs if there are
non-deserialized tabs, but once it is opened it should be closed
automatically.
2022-12-01 11:43:37 +01:00
Elena Tanasoiu
386e9bb865
Merge pull request #1791 from github/elena/eslint-github
...
Install `eslint-plugin-github` and apply autofixes where possible
2022-12-01 10:30:04 +00:00
Koen Vlaswinkel
0f7cf2d935
Take into account filters for action buttons
...
This will disable the export and copy buttons when no results would be
exported by executing the command. In contrast to the "normal" filtering
in the view, this will also take into account the checkboxes since those
are also used in the extension host.
2022-12-01 11:21:28 +01:00
Koen Vlaswinkel
72f253e39f
Add exporting of in-progress/cancelled results
...
This will allow exporting results for a variant analysis which is
cancelled or in-progress. Repositories for which the results are not yet
available or which have not yet been downloaded will not be exported.
The header of the summary file is incorrect, but this will be fixed in
a follow-up PR.
2022-12-01 11:21:26 +01:00
Elena Tanasoiu
168ce8fd28
Add new lint fix
2022-12-01 09:40:33 +00:00
Elena Tanasoiu
0a633a29fe
Remove duplicate identifier
...
This was also caught while running gulp-typescript.
2022-12-01 09:10:47 +00:00
Elena Tanasoiu
d8bbd3de9f
Fix faulty import
...
During the build process, we now get errors pointing out that we import two different
items and call them `QueryServerClient`. One is actually the legacy one and has been
superseded by the new one so far.
Let's fix this and appease the linter.
Full errors:
```
[gulp-typescript]
/home/runner/work/vscode-codeql/vscode-codeql/extensions/ql-vscode/src/extension.ts(88,9):
error TS2300: Duplicate identifier 'QueryServerClient'.
[gulp-typescript]
/home/runner/work/vscode-codeql/vscode-codeql/extensions/ql-vscode/src/extension.ts(89,9):
error TS2300: Duplicate identifier 'QueryServerClient'.
[gulp-typescript]
/home/runner/work/vscode-codeql/vscode-codeql/extensions/ql-vscode/src/extension.ts(1596,30):
error TS2345: Argument of type
'import("/home/runner/work/vscode-codeql/vscode-codeql/extensions/ql-vscode/src/legacy-query-server/queryserver-client").QueryServerClient'
is not assignable to parameter of type
'import("/home/runner/work/vscode-codeql/vscode-codeql/extensions/ql-vscode/src/query-server/queryserver-client").QueryServerClient'.
```
2022-12-01 09:10:47 +00:00
Elena Tanasoiu
99bb04b458
Enable eslint-plugin-github for vscode-tests folder
2022-12-01 09:10:47 +00:00
Elena Tanasoiu
8fcbee6ad4
Enable eslint-github-plugin for view folder
2022-12-01 09:10:47 +00:00
Elena Tanasoiu
195ef45600
Enable eslint-plugin-github for storybook
...
This also adds the recommended rules for React.
2022-12-01 09:10:46 +00:00
Elena Tanasoiu
56660b1720
Enable eslint-plugin-github in test folder
2022-12-01 09:10:46 +00:00
Elena Tanasoiu
b45c67f24f
Autofix prefer-template
2022-12-01 09:10:46 +00:00
Elena Tanasoiu
30cf72b6c8
Autofix object-shorthand
2022-12-01 09:10:46 +00:00
Elena Tanasoiu
670c863f3f
Autofix import/no-namespace
...
I'm leaving the rule turned off as it still has 100+ offenses that aren't
autofixable.
2022-12-01 09:10:44 +00:00
Elena Tanasoiu
754fa67231
Autofix import/no-duplicates
2022-12-01 09:08:33 +00:00
Elena Tanasoiu
706f2e3ca1
Autofix eslint-comments/no-unused-disable
2022-12-01 09:08:33 +00:00
Elena Tanasoiu
dc5d8daa84
Autofix @typescript-eslint/array-type
2022-12-01 09:08:33 +00:00
Elena Tanasoiu
0b9ba3cb94
Start by turning off all rules that have found offences
...
In the next commits we'll turn these rules on, one-by-one, and then
autofix the offenses.
At the end we'll be left with the rules that require manual attention.
2022-12-01 09:08:33 +00:00
Elena Tanasoiu
f539ba3b85
Enable eslint-plugin-github in main extension folder
...
There are 5 eslint config files. We're going to enable this plugin one file at a time
and then deal with the fixes.
2022-12-01 09:08:32 +00:00
Elena Tanasoiu
bccc573c6a
Install eslint-plugin-github
2022-12-01 09:08:32 +00:00
Koen Vlaswinkel
b273db13d0
Merge pull request #1812 from github/koesie10/load-results-tests
...
Add tests for loading results
2022-12-01 09:55:25 +01:00
Koen Vlaswinkel
a704a2bf46
Merge pull request #1804 from github/koesie10/stop-monitor-after-remove
...
Stop variant analysis monitor after removing the variant analysis from the query history
2022-12-01 09:38:23 +01:00
Koen Vlaswinkel
bf328d56d7
Merge remote-tracking branch 'origin/main' into koesie10/stop-monitor-after-remove
2022-11-30 18:29:54 +01:00
Robert
10fe55cff5
Merge pull request #1815 from github/robertbrignull/view_paths
...
Add theme provider when rendering code flows
2022-11-30 17:26:52 +00:00
Koen Vlaswinkel
b3003fc0ba
Merge remote-tracking branch 'origin/main' into koesie10/load-results-tests
2022-11-30 18:23:41 +01:00
Robert
125867d68c
Merge pull request #1809 from github/robertbrignull/failed_analysis_spinner
...
Don't show spinner for a failed analysis
2022-11-30 17:19:33 +00:00
Charis Kyriakou
27b4203d8b
Merge pull request #1813 from github/charisk/logging-tidy
...
Some further tidying up around logging
2022-11-30 16:59:10 +00:00
Robert
f9803fc760
Use toBeInTheDocument
2022-11-30 16:45:36 +00:00
Robert
c958fd2052
Remove unused mock
2022-11-30 16:40:46 +00:00
Robert
adea0b4d77
Add theme provider when rendering code flows
2022-11-30 16:34:50 +00:00
Nora
3dd6effce5
Adjust api response
2022-11-30 17:16:25 +01:00
Koen Vlaswinkel
f3e4766287
Merge pull request #1789 from github/koesie10/remove-variant-analysis-monitor-return-value
...
Remove variant analysis monitor return value
2022-11-30 16:47:23 +01:00
Robert
3751f3ec6c
Add tests
2022-11-30 15:28:21 +00:00
Koen Vlaswinkel
2b9bff14f3
Switch to async methods for fs operations
...
Hopefully this fixes some issues on Windows.
2022-11-30 16:27:08 +01:00
Robert
45a87192de
Merge pull request #1808 from github/robertbrignull/failed_analysis_pending
...
Don't show pending state when analysis has failed
2022-11-30 15:18:11 +00:00
Charis Kyriakou
c889c09584
Rename logger to extLogger
2022-11-30 13:53:17 +00:00
Charis Kyriakou
45ffd8a45c
Tidy up logging docs
2022-11-30 13:28:29 +00:00
Koen Vlaswinkel
6c3731fe98
Add tests for loading results
...
This adds tests for the `loadResults` method of the variant analysis
results manager. It tests that SARIF results can be successfully
loaded and that the `onResultLoaded` event is fired.
2022-11-30 13:52:33 +01:00
Charis Kyriakou
74e047cbd8
Move logging code to /common/logging and split into multiple files ( #1800 )
2022-11-30 09:45:29 +00:00
Koen Vlaswinkel
a9a5d098c7
Merge pull request #1811 from github/koesie10/fix-stat-item-header-color
...
Fix header color of stat item
2022-11-30 09:59:31 +01:00
Koen Vlaswinkel
8f0e6154ad
Remove variant analysis monitor return value
...
The monitor return value was only used in tests, but we can also assert
the correct behavior using the calls it makes, rather than using the
result of the monitor.
2022-11-30 09:55:16 +01:00
Koen Vlaswinkel
2895e84586
Merge pull request #1798 from github/jest-migration/integration-tests
...
Migrate integration tests to Jest
2022-11-30 09:54:35 +01:00
Koen Vlaswinkel
56585b43e6
Merge remote-tracking branch 'origin/main' into jest-migration/integration-tests
2022-11-30 09:06:07 +01:00
Koen Vlaswinkel
6dc1f9f601
Merge pull request #1801 from github/jest-migration/retry-tests
...
Add retries of CLI integration tests
2022-11-30 08:49:49 +01:00
Andrew Eisenberg
91edad8df2
Merge pull request #1662 from github/alexet/update-lsp
...
Update languageserver-client
2022-11-29 10:37:19 -08:00
Alexander Eyers-Taylor
2637d6d00c
Added changelog entry for updated vscode version.
2022-11-29 17:24:54 +00:00
Robert
4771d9b834
Add tests of a pending and failed variant analysis
2022-11-29 16:33:03 +00:00
Koen Vlaswinkel
e6fb4803d1
Merge pull request #1810 from github/koesie10/storybook-themes
...
Add additional Storybook VSCode themes
2022-11-29 17:21:36 +01:00
Koen Vlaswinkel
c7dbaebcec
Fix header color of stat item
...
The header color of a stat item was using the badge foreground color,
but badges can have a different background color than the editor. For
some themes, this would result in unreadable text. By using the editor
foreground color, the header should be readable in many more themes.
2022-11-29 17:19:14 +01:00
Koen Vlaswinkel
3fdc328767
Add additional Storybook VSCode themes
...
This adds four new VSCode themes to Storybook which will allow us to
more easily test these themes in Storybook. These themes were chosen
because they are either used for accessibility (the high contrast
themes) or are currently not compatible with the variant analysis UI
(there are items that are not visible).
2022-11-29 16:49:04 +01:00
Koen Vlaswinkel
ec9d6b1907
Merge pull request #1806 from github/koesie10/fix-loading-results
...
Fix loading results in second opened view
2022-11-29 16:30:25 +01:00
Robert
2cdd6de38e
Don't show spinner for a failed analysis
2022-11-29 15:00:41 +00:00
Robert
339819c82b
Don't show pending state when analysis has failed
2022-11-29 14:56:09 +00:00
Shati Patel
75b684b00f
MRVA: Fix typo in repo cancellation message ( #1807 )
2022-11-29 14:37:19 +00:00
Koen Vlaswinkel
bc65d8f311
Fix loading results in second opened view
...
When results were already cached in memory and the view requested the
result, it would not be loaded because the event would not be fired.
This fires the event when the result is loaded from cache as well, to
ensure that the view always receives the result.
2022-11-29 14:26:36 +01:00
Koen Vlaswinkel
0047186c83
Fix rehydration in variant analysis removal test
2022-11-29 11:41:57 +01:00
Koen Vlaswinkel
ff3b6091c6
Stop variant analysis monitor after removing it
...
This will stop the variant analysis monitor from monitoring when a
variant analysis is removed from the query history. Since the variant
analysis monitor cannot depend on the variant analysis manager (this
would create a circular dependency), a function is passed into the
variant analysis monitor for checking whether the variant analysis
should be cancelled.
This commit will also ensure that even if a variant analysis comes in
through the `onVariantAnalysisChange` callback, it won't be added to
the variant analysis map of the manager.
2022-11-29 11:12:46 +01:00
Koen Vlaswinkel
a1b81d9b6f
Merge pull request #1802 from github/koesie10/path-basename
...
Show correct query filename on Windows
2022-11-29 09:03:11 +01:00
Koen Vlaswinkel
4bc97b850c
Show correct query filename on Windows
...
On Windows, we were showing the full path to the query, rather than just
the filename. This is because the `path` package being imported was
actually `path-browserify` which only claims support for POSIX. Since
Windows uses backslashes rather than forward slashes for paths, this
resulted in the full path being shown.
This creates a new `basename` function that works on both POSIX and
Windows by detecting whether a POSIX or Windows path is given. This
ensures that the correct path is shown on Windows, and will also ensure
that we show the correct path on Linux if the user has opened a variant
analysis that was originally created on Windows.
2022-11-28 15:47:54 +01:00
Koen Vlaswinkel
7ba90275a8
Increase scenarios in which retries will be used
...
This will update the `jest-runner-vscode` patch to retry tests that fail
due to no test result being returned from the test runner.
This will also add some retries to the `minimal-workspace` and
`no-workspace` tests to help with flakiness.
2022-11-28 13:05:14 +01:00
Koen Vlaswinkel
9a9a8c5ac4
Fix multiple VSCode instances launching
...
Multiple VSCode instances were being launched when a second instance of
VSCode was being spawned with the same user data directory. This is
probably because VSCode restores the windows from the previous session,
even when `-n`/`--new-window` is passed.
This fixes it by patching `jest-runner-vscode` to always create a new
temporary user data directory, rather than re-using the same one for
all test suites.
2022-11-28 11:51:23 +01:00
Koen Vlaswinkel
644bea27ad
Add retries of CLI integration tests
...
This will patch `jest-runner-vscode` to retry tests. This is a temporary
test to see if this will help with the flakiness of the CLI integration
tests.
The biggest problem with this is that it will launch multiple VSCode
instances on every retry:
- First try (not a retry): 1 instance
- Second try: 2 instances
- Third try: 3 instances
- etc.
I'm not sure why this is happening and can't really narrow it down to a
specific cause. Even if I change the `runVSCode` call for the retry by
a simple `cp.spawn` call, it still launches multiple instances.
2022-11-28 11:32:17 +01:00
Koen Vlaswinkel
68de9f09e4
Disable fail-fast for CLI integration tests
2022-11-25 18:37:15 +01:00
Alexander Eyers-Taylor
a16366caae
More changes to make lint happy
2022-11-25 17:17:16 +00:00
Alexander Eyers-Taylor
ccf4fad912
Hopefully make lint happy
2022-11-25 16:57:50 +00:00
Alexander Eyers-Taylor
5754d19327
Merge remote-tracking branch 'origin/main' into alexet/update-lsp
2022-11-25 16:53:43 +00:00
Koen Vlaswinkel
595b14cf30
Merge pull request #1797 from github/jest-migration/docs
...
Add documentation for running a single test
2022-11-25 14:33:15 +01:00
Koen Vlaswinkel
858a3268df
Merge remote-tracking branch 'origin/main' into jest-migration/integration-tests
2022-11-25 13:42:02 +01:00
Koen Vlaswinkel
55408a7e0b
Merge pull request #1792 from github/jest-migration/windows
...
Use `patch-package` to add Windows support
2022-11-25 13:40:29 +01:00
Koen Vlaswinkel
24a61d387d
Add documentation for running a single test
2022-11-25 13:36:07 +01:00
Koen Vlaswinkel
927817f99d
Add debugging support to jest-runner
...
This adds debugging support to jest-runner for the integration tests
when they are run from the `out` directory. Unfortunately, this removes
the ability to debug the non-integration tests, such as the pure tests.
2022-11-25 13:36:07 +01:00
Koen Vlaswinkel
e60ed32731
Merge pull request #1795 from github/jest-migration/ts-jest
...
Use ts-jest for running integration tests
2022-11-25 13:35:28 +01:00
Charis Kyriakou
003b9dcf2c
Add launch configuration to run single unit test ( #1796 )
2022-11-25 12:24:40 +00:00
Koen Vlaswinkel
a23a8f78dd
Use ts-jest for running integration tests
...
Instead of running the integration tests from the `out` directory, this
will run the integration tests from the `src` directory using `ts-jest`.
Unfortunately, we are not able to use TypeScript files for the
`jest-runner-vscode` configuration since `cosmiconfig` (the package that
handles the configuration loading for `jest-runner-vscode`) doesn't
support loading TypeScript files by default.
2022-11-25 13:06:03 +01:00
Shati Patel
f6613867d3
Bump CLI version to 2.11.4 for integration tests ( #1794 )
2022-11-25 11:40:28 +00:00
Koen Vlaswinkel
51425915d9
Use fs-extras and async methods for file manipulation
2022-11-25 11:40:56 +01:00
Koen Vlaswinkel
754cad3815
Merge pull request #1793 from github/jest-migration/debug
...
Add debugging support for Jest integration tests
2022-11-25 11:20:19 +01:00
Koen Vlaswinkel
430bcd0aa2
Increase timeout for legacy query server tests
2022-11-25 10:59:50 +01:00
Koen Vlaswinkel
4be69e858c
Add debugging support for Jest integration tests
...
Since we are launching a completely different process for the extension
tests than the process that is launched by VSCode, we need to add some
special handling for the debugging.
This will let the extension host/VSCode expose a debugging port, which
VSCode will then connect to. This is "less desirable than letting the
bootloader do its thing", but a packaged VSCode application does not
allow using the bootloader (`NODE_OPTIONS`=`--require=...`). Therefore,
we have to fallback to this option.
See: 47c60558ec/src/configuration.ts (L405-L411)
2022-11-25 10:41:22 +01:00
Koen Vlaswinkel
9fc2c38970
Merge pull request #1790 from github/jest-migration/cleanup-mocha
...
Clean up Mocha, Sinon and Chai
2022-11-25 10:41:17 +01:00
Koen Vlaswinkel
aa5026f192
Use patch-package to add Windows support
...
This will apply the same change as the PR on `jest-runner-vscode` in
the local `node_modules` on every install, ensuring that we have
Windows support.
2022-11-25 10:11:19 +01:00
Koen Vlaswinkel
e55b8a366e
Clean up Mocha, Sinon and Chai
...
This removes the Mocha, Sinon and Chai-related packages and removes
unused code from the test suite.
2022-11-24 17:24:43 +01:00
Koen Vlaswinkel
5841fbccd7
Merge pull request #1785 from github/jest-migration/cli-integration
...
Migrate CLI integration tests to Jest
2022-11-24 17:15:23 +01:00
Koen Vlaswinkel
925acbd36e
Merge remote-tracking branch 'origin/jest-migration/integration-tests' into jest-migration/cli-integration
2022-11-24 17:02:33 +01:00
Charis Kyriakou
91ca9481eb
Migrate minimal-workspace integration tests to Jest ( #1786 )
2022-11-24 16:01:20 +00:00
Koen Vlaswinkel
f830c23018
Fix variant analysis submission integration test
...
Apparently, we're not importing the same `config` file as is used by the
actual extension, so mocking methods in this file does not do anything.
However, we can mock the `vscode` module, so we can use this for
returning different values in the configuration.
We also need to mock the authentication session since we don't have one.
2022-11-24 13:38:40 +01:00
Koen Vlaswinkel
52e2a63828
Fix missed toHaveLength on object
2022-11-24 13:21:52 +01:00
Koen Vlaswinkel
3f76ad6eb8
Fix variant analysis and remote queries tests
2022-11-24 13:10:42 +01:00
Koen Vlaswinkel
1c0d6b991a
Enable restoreMocks Jest configuration option
...
This will ensure all mocks are restored after every test. This required
a significant amount of changes in the tests since `jest.spyOn` now
needs to be called in `beforeEach`, rather than in the `describe` block.
2022-11-24 12:27:18 +01:00
Koen Vlaswinkel
68d867ef76
Fix remote queries manager tests
...
There were some things that were breaking due to version checks. Since
we aren't testing on these CLI versions (2.7.2 and 2.7.4 or older)
anymore, we can remove these checks and simplify the tests.
2022-11-24 11:36:03 +01:00
Koen Vlaswinkel
e04f941cee
Fix spy on undefined variable
2022-11-24 10:44:08 +01:00
Koen Vlaswinkel
558eb19c97
Remove unnecessary calls to mockReset
2022-11-24 10:24:48 +01:00
Koen Vlaswinkel
31b64d2f73
Fix incorrect to.contain transformation
...
For `to.contain`, `jest-codemods` seems to have converted these to be
`expect.arrayContaining`, even for strings. This will make the correct
change for strings.
2022-11-24 10:23:14 +01:00
Koen Vlaswinkel
d02a5cd3dc
Do not use toHaveLength for objects
...
Mocha supported `.to.have.length` for objects, but Jest only allows
`toHaveLength` on objects which have a length property (such as arrays).
2022-11-24 10:23:14 +01:00
Koen Vlaswinkel
e895078913
Do not use .skip from within tests
...
Jest does not support skipping tests when the test has already started
(which could also be in a before hook), so we need to manually return
from the tests when the CLI version does not support a tested feature.
2022-11-24 10:23:14 +01:00
Koen Vlaswinkel
1a10fd35f1
Remove calls to fail
...
Instead of calling `fail`, we can just let the error be caught by Jest,
which will automatically fail the tests. For other instances where we're
calling `fail` in case an error was not thrown, we will instead use
`.rejects.toThrow`.
2022-11-24 10:23:13 +01:00
Koen Vlaswinkel
614785fb7a
Do not dispose the extension after every test file
2022-11-24 10:22:47 +01:00
Koen Vlaswinkel
4f8d68d8a2
Always activate the extension before running tests
2022-11-24 10:22:47 +01:00
Koen Vlaswinkel
dc6de0f8a8
Fix async describes
2022-11-24 10:22:47 +01:00
Koen Vlaswinkel
e5967c3851
First pass on converting cli-integration tests to Jest
...
This is a first pass on converting the cli-integration tests to Jest. It
uses a custom Jest runner (based on the jest-runner-vscode) to install
required extensions. It will also necessary to move some code for
installating the CLI to ensure it was possible to install the CLI from
outside VSCode.
Most of the conversion has been done by `npx jest-codemods`, but all
migration of Sinon has been done manually.
2022-11-24 10:22:45 +01:00
Koen Vlaswinkel
c31635fe90
Merge pull request #1782 from github/jest-migration/no-workspace
...
Migrate no-workspace integration tests to Jest
2022-11-24 10:21:50 +01:00
Koen Vlaswinkel
e26e1113be
Remove calls to fail
...
Instead of calling `fail` and catching an error, this will use the
`rejects.toThrow` assertion to check that a Promise rejects with a
specific error.
2022-11-24 10:04:37 +01:00
Koen Vlaswinkel
01f6576e95
Clarify comment for activation test
2022-11-24 09:58:10 +01:00
Koen Vlaswinkel
347d234906
Use projects arg to run the Jest tests
2022-11-24 09:56:08 +01:00
Koen Vlaswinkel
043a7b1039
Use resetMocks option to reset mocks before every test
2022-11-24 09:55:48 +01:00
Koen Vlaswinkel
b10cb7771e
Merge pull request #1784 from github/koesie10/move-filter-sort
...
Move filter and sort tests to pure tests
2022-11-23 16:39:29 +01:00
Koen Vlaswinkel
80b2a43be9
Move filter and sort tests to pure tests
...
The filter and sort tests were located inside the React tests since they
were already using Jest. Now that the pure tests have been switched to
Jest, these tests can finally be moved to the "normal" pure tests.
2022-11-23 14:06:57 +01:00
Koen Vlaswinkel
a985bcb872
Use different method of running tests
2022-11-23 11:23:15 +01:00
Koen Vlaswinkel
90dd97fbc0
Use correct jest-runner-vscode for no-workspace
2022-11-23 11:23:15 +01:00
Koen Vlaswinkel
0296db8b25
Move jest-runner-vscode config to correct location
2022-11-23 11:23:15 +01:00
Koen Vlaswinkel
65bb61b530
Set timeouts on tests correctly
...
The timeouts need to be set either on a per-file basis, or per test by
using the parameter in `it`. Since we have both Mocha and Jest types, we
need to declare in the test file which one we're using.
2022-11-23 11:23:15 +01:00
Koen Vlaswinkel
3da0034953
Do not run integration tests in parallel
...
This results in parallel downloads of VSCode, which is not supported.
2022-11-23 11:23:15 +01:00
Koen Vlaswinkel
a0ab34bf55
Migrate no-workspace integration tests to Jest
...
This migrates all no-workspace VSCode integration tests to Jest by
running `npx jest-codemods`, followed by manual fixes (mostly for Sinon
and Proxyquire).
2022-11-23 11:23:13 +01:00
Koen Vlaswinkel
cc869daf05
Merge pull request #1783 from github/koesie10/split-workflow-files
...
Split workflow run into more jobs
2022-11-23 10:59:54 +01:00
Koen Vlaswinkel
1c820b4812
Switch from npm install to npm ci in CI
2022-11-23 10:44:45 +01:00
Koen Vlaswinkel
d215c7e2de
Split workflow run into more jobs
...
The unit tests and linting is now run separately, which will hopefully
speed up the time it takes for the integration tests to complete.
2022-11-23 10:19:34 +01:00
Koen Vlaswinkel
a88039bf0b
Merge pull request #1780 from github/koesie10/jest-pure-tests
...
Convert pure tests to Jest
2022-11-22 16:13:05 +01:00
Koen Vlaswinkel
f5c39d7931
Improve error message for empty array
...
When `jest-codemods` was run, it replaced the error message `array.join`
by a comment for the error message. Since Jest does not support custom
error messages out-of-the-box, this will instead do an equality check
with an empty array, which will ensure that the received array is
printed.
2022-11-22 15:54:22 +01:00
Charis Kyriakou
261933b6a9
Install VS Code jest runner ( #1781 )
2022-11-22 11:01:46 +00:00
Nora
33eb33405e
Merge pull request #1776 from github/nora/update-compiler-target
...
Update compiler target version in gulp and extension tsconfig
2022-11-22 11:55:14 +01:00
Koen Vlaswinkel
ec60f3f000
Dispose config store in tests
...
The config store was not being disposed in tests, resulting in Chokidar
watchers being left open. This was causing tests to not exit since there
were still open file descriptors.
This commit also fixes the `DbConfigStore` to make the correct `super`
call in its `dispose` method.
2022-11-22 11:53:21 +01:00
Koen Vlaswinkel
0974700557
Convert pure tests to Jest
...
This converts all pure tests to Jest. This was done by first running
`npx jest-codemods` with the Mocha transformation, then manually fixing
any places where it hadn't automatically converted the correct thing
or had missed things (mostly Sinon).
This also sets up VSCode correctly for running Jest.
2022-11-22 10:39:21 +01:00
Koen Vlaswinkel
03f1547160
Merge pull request #1777 from github/koesie10/jest-config-projects
...
Add project-based Jest config
2022-11-22 09:44:23 +01:00
Andrew Eisenberg
91a5db7359
Merge pull request #1779 from github/version/bump-to-v1.7.7
...
Bump version to v1.7.7
2022-11-21 12:02:20 -08:00
aeisenberg
fbd2cbd3aa
Bump version to v1.7.7
2022-11-21 19:39:04 +00:00
Andrew Eisenberg
f36ab18310
Merge pull request #1778 from github/v1.7.6
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.7.6
2022-11-21 09:42:39 -08:00
Andrew Eisenberg
663b26328b
v1.7.6
2022-11-21 09:01:47 -08:00
Koen Vlaswinkel
55534e19d6
Add project-based Jest config
...
This moves the view Jest config to the view directory and adds a new
jest.config.js file which only references the view directory as a
project. This will make it easier to add multiple Jest configs for
separate projects.
2022-11-21 16:41:47 +01:00
Nora
b6f33d7c7b
Update compiler target version in gulp and extension tsconfig
2022-11-21 15:49:38 +01:00
Andrew Eisenberg
e93d8393ca
Merge pull request #1774 from github/aeisenberg/fix-mrva-packs
...
Allow synthetic variant analysis packs to handle `${workspace}`
2022-11-18 15:00:05 -08:00
Andrew Eisenberg
24bbd5153c
Allow synthetic variant analysis packs to handle ${workspace}
...
`${workspace}` references are new in CLI version 2.11.3. These mean that
the version depended upon in a pack must be the version available in the
current codeql workspace.
When generating a variant analysis pack, however, we copy the target
query and generate a synthetic pack with the original dependencies.
This breaks workspace references since the synthetic pack is no longer
in the same workspace.
A simple workaround is to replace `${workspace}` with `*` references.
2022-11-18 14:47:07 -08:00
Andrew Eisenberg
4eb465277a
Update gitignore to avoid codeql metadata files
...
Also, we're no longer using the rush package manager, so delete that
from gitignore.
2022-11-18 11:33:53 -08:00
Koen Vlaswinkel
3e7e4b86bd
Merge pull request #1525 from github/koesie10/prettier
...
Add Prettier
2022-11-17 09:58:47 +01:00
Koen Vlaswinkel
f515663640
Add .git-blame-ignore-revs file for previous commit
...
See https://www.stefanjudis.com/today-i-learned/how-to-exclude-commits-from-git-blame/
2022-11-16 19:07:01 +01:00
Koen Vlaswinkel
ebcdf8ad0b
Run Prettier on all files
...
This will change all existing files to match Prettier formatting.
The command used is `npm run format`.
2022-11-16 19:06:13 +01:00
Koen Vlaswinkel
f41ca1a330
Add Prettier
...
This adds Prettier and makes it replace tsfmt. VSCode is set to use
Prettier for formatting TypeScript/TSX files and format on save since
Prettier is very fast and does not cause any noticeable delay.
2022-11-16 19:04:17 +01:00
Koen Vlaswinkel
6219b43051
Merge pull request #1766 from github/koesie10/export-results-sorting-filtering
...
Add filtering and sorting to exported results
2022-11-16 19:01:36 +01:00
Koen Vlaswinkel
47297800ab
Merge remote-tracking branch 'origin/main' into koesie10/export-results-sorting-filtering
2022-11-16 18:44:36 +01:00
Koen Vlaswinkel
5838f1b6a3
Merge pull request #1765 from github/koesie10/selected-copy
...
Use selected repositories for copying repo lists
2022-11-16 18:41:46 +01:00
Koen Vlaswinkel
bbaa27a1f0
Split filter and sort methods and simplify type checks
2022-11-16 16:32:17 +01:00
dependabot[bot]
d7fd84c8e1
Bump loader-utils from 1.4.1 to 1.4.2 in /extensions/ql-vscode ( #1772 )
...
Bumps [loader-utils](https://github.com/webpack/loader-utils ) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases )
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md )
- [Commits](https://github.com/webpack/loader-utils/compare/v1.4.1...v1.4.2 )
---
updated-dependencies:
- dependency-name: loader-utils
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-16 15:03:23 +00:00
Koen Vlaswinkel
6aaa7d63a7
Simplify type checks for repositoryIds
2022-11-16 13:02:55 +01:00
Robert
ed0868ba26
Merge pull request #1768 from github/robertbrignull/openVariantAnalysis
...
Remove the openVariantAnalysis command
2022-11-16 11:04:02 +00:00
Shati Patel
b2a3703d3a
Render nodes for local database items ( #1759 )
2022-11-16 11:03:49 +00:00
Nora
539dd1f0f3
Merge pull request #1771 from github/nora/move-db-panel-files
...
New DB Panel: Move config files to config folder
2022-11-16 10:55:30 +01:00
Koen Vlaswinkel
2a30c669e1
Merge pull request #1760 from github/koesie10/filter-export-copy
...
Add filtering and sorting to exported repo list
2022-11-16 10:31:52 +01:00
Nora
bd6c3add1b
Move files to config folder
2022-11-16 10:22:54 +01:00
Charis Kyriakou
435fc0a327
Fix rootDir used in test tsconfig ( #1770 )
2022-11-16 09:01:55 +00:00
Koen Vlaswinkel
53c1a585c1
Simplify filtering of repositories
...
Co-authored-by: Elena Tanasoiu <elenatanasoiu@github.com >
2022-11-16 09:53:37 +01:00
Andrew Eisenberg
ede534cf5f
Merge pull request #1744 from github/aeisenberg/new-query-server
...
Enable the new query server by default
2022-11-15 13:24:01 -08:00
Andrew Eisenberg
9a7489f6cd
Merge pull request #1674 from github/aeisenberg/assert-version
...
Assert VSCode version is high enough
2022-11-15 10:51:42 -08:00
Robert
2f5f09550d
Remove openVariantAnalysis command
2022-11-15 16:49:49 +00:00
Koen Vlaswinkel
1793963f06
Merge branch 'koesie10/selected-copy' into koesie10/export-results-sorting-filtering
2022-11-15 16:14:45 +01:00
Koen Vlaswinkel
e0230375e3
Merge branch 'koesie10/filter-export-copy' into koesie10/selected-copy
2022-11-15 16:13:29 +01:00
Koen Vlaswinkel
b8a0ed4ec3
Merge remote-tracking branch 'origin/main' into koesie10/filter-export-copy
2022-11-15 16:12:13 +01:00
Nora
846eda5428
Merge pull request #1761 from github/nora/add-selected-state-to-db-config
...
Add selected to config
2022-11-15 16:09:06 +01:00
Koen Vlaswinkel
796611d3bc
Merge pull request #1758 from github/koesie10/export-results-from-view
...
Add exporting of results to view
2022-11-15 16:02:23 +01:00
Koen Vlaswinkel
c88b32091b
Merge pull request #1750 from github/koesie10/export-results
...
Add exporting of results from the context menu
2022-11-15 16:01:50 +01:00
Nora
a012d80341
Merge comments
2022-11-15 15:48:28 +01:00
Charis Kyriakou
542a78e4ef
Stop showing warnings for unhandled requests by the mock API server ( #1767 )
2022-11-15 14:45:21 +00:00
Nora
cf7e33363a
Resolve conflicts
2022-11-15 14:19:51 +01:00
Nora
0505d5a0ab
Merge comments
2022-11-15 14:19:51 +01:00
Nora
27f62bc1ff
Add selected to config
2022-11-15 14:19:51 +01:00
Koen Vlaswinkel
5ed4981673
Add tests for handleCopyRepoList and handleExportResults
2022-11-15 14:13:35 +01:00
Koen Vlaswinkel
e9681bc546
Restore private visibility of loadResultsFromStorage
2022-11-15 13:20:44 +01:00
Koen Vlaswinkel
7486431bea
Use options instead of separate method for skipping cache store
...
This adds a new options argument to the `loadResults` method which
allows the caller to specify that the results should not be saved to the
cache. This exposes a smaller API surface and makes it harder to misuse
the methods.
2022-11-15 13:16:59 +01:00
Koen Vlaswinkel
95e073b9a4
Use separate directory for variant analysis exports
...
Each variant analysis export can be different due to different filters,
so there are two options:
- We need to clean up the directory before each export to ensure no old
files are left
- We need to use a separate directory for each export
This implements the second option, which is more flexible and allows the
user to retain different result exports.
2022-11-15 13:05:37 +01:00
Koen Vlaswinkel
f94837ebca
Add filtering and sorting to exported results
...
This adds filtering (based on search and selected repositories) and
sorting to exporting results. This is done in the same way as for
copying the repository list, so the changes are fairly minimal.
2022-11-15 12:06:06 +01:00
Koen Vlaswinkel
dd1ced9ba3
Merge branch 'koesie10/selected-copy' into koesie10/export-results-sorting-filtering
2022-11-15 12:02:21 +01:00
Charis Kyriakou
f1b24987eb
Re-render db panel on config update ( #1763 )
2022-11-15 10:36:38 +00:00
Koen Vlaswinkel
4ed409d91a
Use selected repositories for copying repo lists
...
This will use the selected repositories to limit which repositories are
included in the copied repo list. If there are both selected
repositories and a search filter (on the full name), the search filter
will be ignored and the selected repositories will be used in full.
2022-11-15 11:23:01 +01:00
Charis Kyriakou
39ae3cd7f4
Add mode and subscriptions to App container ( #1762 )
2022-11-15 10:03:10 +00:00
Koen Vlaswinkel
73ff057df0
Merge remote-tracking branch 'origin/main' into koesie10/filter-export-copy
2022-11-15 10:53:58 +01:00
Andrew Eisenberg
2dd482a8a4
Enable the new query server by default
2022-11-14 17:36:31 -08:00
Andrew Eisenberg
93cc4082dc
Merge branch 'main' into aeisenberg/assert-version
2022-11-14 17:35:25 -08:00
Charis Kyriakou
345125994a
Revert "Rename iconPath to icon" ( #1764 )
...
* Revert "Rename iconPath to icon (#1742 )"
This reverts commit 93b6abeeb4 .
* Add comment to explain things
2022-11-14 16:38:59 +00:00
Koen Vlaswinkel
9b0fe4ddc7
Merge pull request #1755 from github/koesie10/checkbox-state
...
Keep track of checkbox state in view
2022-11-14 17:18:30 +01:00
Charis Kyriakou
fca2faf021
Add extension and storage paths to App container ( #1756 )
2022-11-14 15:47:58 +00:00
Koen Vlaswinkel
30988993be
Simplify canSelect method
...
Co-authored-by: Robert <robertbrignull@github.com >
2022-11-14 16:33:08 +01:00
Koen Vlaswinkel
bb4307ea3e
Add filtering and sorting to exported repo list
...
This will pass the filter and sort parameters in the export repo list
message so it can be used by the command to filter and sort the
repositories which are placed in the repo list.
2022-11-14 14:50:52 +01:00
Koen Vlaswinkel
82a7fc5070
Move filter and sort functions to pure
...
These functions can be re-used by the sorting and filtering code for
exporting results and copying repository lists, so these should not be
in the view directory.
The tests have been kept in the same place for now, but they should be
moved to the pure tests directory once those have been switched to Jest.
I figured it wasn't worth it to convert these to Mocha, and convert them
back to Jest in a week.
2022-11-14 14:10:40 +01:00
Shati Patel
3fd9fd449c
Add support for local dbs in config ( #1751 )
2022-11-14 12:45:18 +00:00
Koen Vlaswinkel
d6ae5b1359
Add exporting of results to view
...
This will allow a user to export the results from the view by clicking
the "Export results" button.
2022-11-14 12:03:30 +01:00
Koen Vlaswinkel
922d2122a7
Merge remote-tracking branch 'origin/main' into koesie10/export-results
2022-11-14 12:01:23 +01:00
Koen Vlaswinkel
f48567101a
Merge pull request #1757 from github/koesie10/copy-repo-list-from-view
...
Add copying of repository list to view
2022-11-14 11:55:59 +01:00
Koen Vlaswinkel
96c24ccd5b
Add copying of repository list to view
...
This will allow a user to use the "Copy repository list" button in the
view to copy a repository list.
2022-11-14 11:26:04 +01:00
Koen Vlaswinkel
6168145116
Merge pull request #1753 from github/koesie10/copy-repo-list
...
Add copying of repository list for variant analyses
2022-11-14 09:48:43 +01:00
Charis Kyriakou
a05313733f
Add event emitter abstraction ( #1754 )
2022-11-11 16:28:20 +00:00
Koen Vlaswinkel
4caa1e2d82
Merge remote-tracking branch 'origin/main' into koesie10/export-results
2022-11-11 16:49:35 +01:00
Koen Vlaswinkel
e90f3d0b46
Keep track of checkbox state in view
...
This will add a new `useState` call on the top-level to keep track of
the checkbox state. It will allow all downloaded repositories to be
selected. This will allow us to make the copy repository list and export
results button dependent on the selected repositories.
2022-11-11 16:33:20 +01:00
Shati Patel
7e8fa5c5fe
Bump CLI version to 2.11.3 for integration tests ( #1752 )
2022-11-11 14:35:37 +00:00
Koen Vlaswinkel
baae8d5710
Merge remote-tracking branch 'origin/main' into koesie10/copy-repo-list
2022-11-11 15:23:42 +01:00
Koen Vlaswinkel
0d15768093
Merge pull request #1749 from github/koesie10/split-remote-query-flows
...
Split flows for running remote queries
2022-11-11 15:15:26 +01:00
Koen Vlaswinkel
022d5c564f
Add copying of repository list for variant analyses
...
This adds the ability to copy the repository list for variant analyses
from the context menu in the query history.
2022-11-11 15:14:28 +01:00
Koen Vlaswinkel
47ee82fc03
Merge remote-tracking branch 'origin/main' into koesie10/split-remote-query-flows
2022-11-11 15:00:02 +01:00
Koen Vlaswinkel
4eb8c55045
Merge pull request #1748 from github/koesie10/reduce-nesting-remote-query
...
Reduce nesting in `runRemoteQuery`
2022-11-11 14:46:05 +01:00
Koen Vlaswinkel
175f8eadc5
Merge remote-tracking branch 'origin/main' into koesie10/split-remote-query-flows
2022-11-11 14:37:51 +01:00
Koen Vlaswinkel
65641e3776
Move remote queries specific code out of run-remote-query
...
This moves some of the code that is specific to remote queries out of
the `run-remote-query.ts` file and instead places it in separate files
that only deal with remote queries, rather than also dealing with
variant analyses.
2022-11-11 14:35:02 +01:00
Koen Vlaswinkel
7649f20d4d
Remove unused return values for run methods
...
The `runRemoteQuery` and `runVariantAnalysis` were returning values
which were only used in tests. This removes them and replaces the tests
by expectations on the commands called by the methods.
2022-11-11 14:28:09 +01:00
Koen Vlaswinkel
09120a2328
Declare type explicitly instead of inferring it
2022-11-11 14:12:55 +01:00
Koen Vlaswinkel
42c642df25
Add exporting of variant analysis results
...
This adds the export of variant analysis results. This is unfortunately
a larger change than I would have liked because there are many
differences in the types and I think further unification of the code
might make it less clear and would actually make this code harder to
read when the remote queries code is removed.
In general, the idea for the export of a variant analysis follows the
same process as the export of remote queries, with the difference being
that variant analysis results are loaded on-the-fly from dis, rather
than only loading from memory. This means it should use less memory, but
it also means that the export is slower.
2022-11-11 14:01:34 +01:00
Koen Vlaswinkel
62453d12c6
Split commands for exporting results
...
There was only a single command for exporting variant analysis results,
which would either export the selected result or a given result. From
the query history, the command was always calculating the exported
result, while we can just give a query ID to export.
This will create two separate commands for exporting results, one for
exporting the selected results (user-visible) and one for exporting a
specific remote query result. This will make it easier to add support
for exporting variant analysis results.
I'm not sure if there will be impact from renaming the command. I expect
the only impact to be that the command history might not show the
command in the correct place (i.e. it disappears from recently used
commands), but please check if that is the only impact.
2022-11-11 14:01:34 +01:00
Koen Vlaswinkel
8b360f3004
Merge pull request #1747 from github/koesie10/remove-dry-run-parameter
...
Remove `dryRun` parameter from `runRemoteQuery`
2022-11-11 11:38:25 +01:00
Koen Vlaswinkel
9894eda60c
Merge pull request #1746 from github/koesie10/remote-queries-tests-tar
...
Change remote queries to test against submitted data
2022-11-11 11:36:06 +01:00
Shati Patel
1241ce985a
Fix date format to 'en-US' ( #1741 )
2022-11-11 10:35:24 +00:00
Koen Vlaswinkel
a4402cb68b
Add tar-stream as dev dependency
2022-11-11 11:24:22 +01:00
Koen Vlaswinkel
21eabc2a93
Merge pull request #1745 from github/koesie10/extract-remote-query-preparation
...
Extract remote query preparation to separate method
2022-11-11 11:23:07 +01:00
Koen Vlaswinkel
c089135626
Change arrow function to exported function
2022-11-11 11:23:03 +01:00
Koen Vlaswinkel
00905a9be3
Add return type to prepareRemoteQueryRun
2022-11-11 11:07:11 +01:00
Charis Kyriakou
93b6abeeb4
Rename iconPath to icon ( #1742 )
2022-11-11 10:56:31 +01:00
Koen Vlaswinkel
b1a5f14471
Split flows for running remote queries
...
This removes the `runRemoteQuery` method and instead moves all logic
specific to remote queries/variant analysis to the remote queries
manager and variant analysis manager respectively. This will make it
easier to completely remove the remote queries manager in the future.
2022-11-11 10:48:43 +01:00
Koen Vlaswinkel
082fea8587
Reduce nesting in runRemoteQuery
...
Now that we do not have a dry run mode, we can create and clean up the
temporary directory in the same function. This allows us to remove the
complete try..finally block inside `runRemoteQuery` and move it to a
much more local spot.
2022-11-11 10:45:14 +01:00
Koen Vlaswinkel
cca13fde48
Remove dryRun parameter from runRemoteQuery
2022-11-11 10:43:11 +01:00
Koen Vlaswinkel
2dad33f2ba
Change remote queries to test against submitted data
...
The remote queries tests were testing the data on the filesystem, rather
than the data submitted to the server. This required using a `dryRun`
parameter to prevent deleting the temporary directory, while we can
actually just test against the submitted data.
This will create an in-memory filesystem of the submitted query pack by
un-tar-gz'ing the query pack into memory and using that to test the
existence of certain files.
2022-11-11 10:40:04 +01:00
Koen Vlaswinkel
5905cf8811
Extract remote query preparation to separate method
...
There is some common logic between remote queries and the variant
analysis flows which deals with parsing the query and asking the user
how to run the query. This extracts that part of the logic to a separate
method such that the only logic left in the actual `runRemoteQuery`
method is related to submitting the query.
2022-11-11 10:38:41 +01:00
Koen Vlaswinkel
616a2693ef
Merge pull request #1726 from github/koesie10/new-variant-analysis-statuses
...
Use new variant analysis statuses
2022-11-11 10:25:10 +01:00
Koen Vlaswinkel
a80ace5334
Add alert message for failed Actions workflow
...
This also changes the failure reason alert component to remove the logs
button since it's not used by any failure reason. Instead, a link is
added into the message for a failed Actions workflow using which the
Actions workflow run may be opened.
2022-11-10 15:07:58 +01:00
Koen Vlaswinkel
b333a16570
Merge remote-tracking branch 'origin/main' into koesie10/new-variant-analysis-statuses
2022-11-10 14:58:37 +01:00
Koen Vlaswinkel
03e48b7ae0
Merge pull request #1728 from github/koesie10/failed-view
...
Handle failed status in variant analysis view
2022-11-10 11:22:24 +01:00
Charis Kyriakou
71297e360b
Remove unused method argument ( #1740 )
2022-11-10 08:18:04 +00:00
Charis Kyriakou
47af1f8c05
Add some integration tests for the db panel ( #1739 )
2022-11-09 15:37:47 +00:00
Koen Vlaswinkel
a2398990bc
Merge pull request #1729 from github/koesie10/failed-download-view
...
Handle failed result download in view
2022-11-09 12:43:51 +01:00
Charis Kyriakou
8183c3108c
Surface db config errors ( #1730 )
2022-11-09 11:37:22 +00:00
Koen Vlaswinkel
5390a11dc7
Merge pull request #1738 from github/koesie10/update-mrva-messages
...
Update messages for variant analysis warnings
2022-11-09 11:54:05 +01:00
Koen Vlaswinkel
bac39630d6
Update messages for variant analysis warnings
...
This uses the correct title and message for all warnings currently
supported.
2022-11-09 10:16:18 +01:00
Koen Vlaswinkel
c2baa4557f
Merge remote-tracking branch 'origin/main' into koesie10/failed-view
2022-11-09 10:05:14 +01:00
Andrew Eisenberg
96d99a71a7
Merge pull request #1737 from github/version/bump-to-v1.7.6
...
Bump version to v1.7.6
2022-11-08 20:08:54 -08:00
aeisenberg
632a675b13
Bump version to v1.7.6
2022-11-09 02:04:18 +00:00
Andrew Eisenberg
acc37fb4de
Merge pull request #1736 from github/v1.7.5
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.7.5
2022-11-08 18:00:33 -08:00
Andrew Eisenberg
05951b6c74
v1.7.5
2022-11-08 17:24:55 -08:00
Andrew Eisenberg
473569df5b
Merge pull request #1735 from adityasharad/ast/synthetic-query-pack
...
Contextual queries: Support running when the library pack is in the package cache
2022-11-08 17:15:52 -08:00
Aditya Sharad
97c985b716
Contextual queries: Record whether a temp lock file was created
2022-11-08 16:37:30 -08:00
Aditya Sharad
84b9d9c994
Contextual queries: Factor common code for resolving and running
...
Shared by the AST viewer, jump to def, and find references
contextual queries.
This allows contextual queries to have their dependencies
resolved and be run whether the library pack is in the
workspace or in the package cache.
2022-11-08 16:06:27 -08:00
Aditya Sharad
639487be0a
AST viewer: Address review comments
...
Clear the CLI server's pack cache before installing packs,
to avoid race conditions where the new lock file is not
detected during query running.
Adjust some helper methods.
2022-11-08 15:33:04 -08:00
Aditya Sharad
f9a19b6a4a
AST viewer: Support running when the library pack is in the package cache
...
If the library pack containing the AST query does not have
a lock file, it is likely to be in the package cache, not
a checkout of the CodeQL repo.
In this case, use `codeql pack resolve-dependencies`
to create a temporary lock file, and `codeql pack install`
to install the dependencies of this library pack.
This allows the CLI to resolve the library path and
dependencies for the AST query before running it.
2022-11-08 14:16:18 -08:00
Koen Vlaswinkel
ab18a74b73
Update error message for no repos queried
2022-11-08 16:56:37 +01:00
Andrew Eisenberg
ab0e8a0ff2
Merge pull request #1722 from github/aeisenberg/bump-timeouts-in-test
2022-11-08 07:35:43 -08:00
Nora
03f58593ce
Merge pull request #1717 from github/norascheuch/add-config-validation
...
Add config validation
2022-11-08 16:11:15 +01:00
Koen Vlaswinkel
a24e7c6172
Merge pull request #1727 from github/koesie10/canceled-view
...
Handle canceled status in variant analysis view
2022-11-08 14:10:43 +01:00
Koen Vlaswinkel
bf52c7105d
Handle failed result download in view
...
We were not yet showing any errors when a result download had failed.
This adds a warning icon to any repositories for which the download has
failed and allow expanding the item to show an alert.
2022-11-08 13:40:22 +01:00
Koen Vlaswinkel
8e6cfa8551
Handle failed status in variant analysis view
...
This will show a message for the failure reason in the variant analysis
view when the variant analysis has failed. There don't seem to be
designs for these alerts, but we will need to do a full design review of
the view at some point anyway, so I don't think the exact text is
important.
2022-11-08 13:22:53 +01:00
Koen Vlaswinkel
d711d80cfb
Use new variant analysis statuses
...
The `status` on the variant analysis has changed to have `succeeded`,
`failed` and `cancelled` instead of `completed`.
2022-11-08 13:13:55 +01:00
Koen Vlaswinkel
e164bbb79e
Handle canceled status in variant analysis view
...
The variant analysis view was missing an alert when the variant
analysis was canceled. This adds it, and also adds a story for checking
what the view of a canceled variant analysis looks like.
2022-11-08 13:11:50 +01:00
Koen Vlaswinkel
bbdad0afc4
Merge pull request #1720 from github/koesie10/stop-query-button
...
Add cancelling of variant analysis to view
2022-11-08 11:05:48 +01:00
Koen Vlaswinkel
89359e30bf
Use ID instead of query name in error message
...
Co-authored-by: Robert <robertbrignull@github.com >
2022-11-08 10:36:42 +01:00
Koen Vlaswinkel
4c0c93d120
Merge pull request #1721 from github/koesie10/run-all-unit-tests
...
Run all unit tests on Linux/macOS
2022-11-08 09:53:40 +01:00
Andrew Eisenberg
94b411e3b2
Merge pull request #1724 from github/aeisenberg/fix-actions-warnings
...
Uses newer actions versions and avoids `set-output`
2022-11-07 20:02:38 -08:00
Andrew Eisenberg
2baf99b38a
Merge pull request #1723 from github/dependabot/npm_and_yarn/extensions/ql-vscode/loader-utils-1.4.1
...
Bump loader-utils from 1.4.0 to 1.4.1 in /extensions/ql-vscode
2022-11-07 19:53:55 -08:00
Andrew Eisenberg
082d4b8c78
Uses newer actions versions and avoids set-output
...
`set-output` is deprecated:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
2022-11-07 16:20:29 -08:00
dependabot[bot]
66cb7dc92f
Bump loader-utils from 1.4.0 to 1.4.1 in /extensions/ql-vscode
...
Bumps [loader-utils](https://github.com/webpack/loader-utils ) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/webpack/loader-utils/releases )
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md )
- [Commits](https://github.com/webpack/loader-utils/compare/v1.4.0...v1.4.1 )
---
updated-dependencies:
- dependency-name: loader-utils
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-07 23:29:11 +00:00
Andrew Eisenberg
62ed83b655
Add CHANGELOG entry
2022-11-07 15:23:24 -08:00
Andrew Eisenberg
767a5cf809
Merge branch 'main' into aeisenberg/assert-version
2022-11-07 15:21:57 -08:00
Andrew Eisenberg
9519efe525
Merge pull request #1679 from github/version/bump-to-v1.7.5
...
Bump version to v1.7.5
2022-11-07 15:21:25 -08:00
Andrew Eisenberg
71daf0b8c6
Bumps timeouts in tests
...
This tests occasionally times out during setup. This change attempts to
avoid this problem by increasing the max length of the test.
2022-11-07 15:19:58 -08:00
Andrew Eisenberg
67d2fe5332
Add a way to disable version checks
...
Version checks are re-enabled whenever the version of vscode changes.
This is because the user would have needed to manually update their
vscode version in order to get this new version. And another failing
version check would mean there is a newer version that needs to be
downloaded.
2022-11-07 14:25:45 -08:00
Aditya Sharad
b526ff4d3a
Contextual queries: update doc comments
2022-11-07 14:02:50 -08:00
Charis Kyriakou
03bc63c689
Read schema from file
2022-11-07 16:07:10 +00:00
Charis Kyriakou
916b840407
Use new function in db config store
2022-11-07 16:57:00 +01:00
Nora
4858be6ac8
Extract validation to its own file
2022-11-07 16:56:48 +01:00
Nora
daec8b691d
Extract validation to its own file
2022-11-07 16:56:48 +01:00
Nora
3df94b92cd
Add basic public config validation
2022-11-07 16:56:23 +01:00
Koen Vlaswinkel
5f1431ffc2
Run all unit tests on Linux/macOS
...
It seems like the expansion of the test files pattern is different
between Windows and Linux/macOS. This fixes it by allowing Mocha to
expand the glob pattern rather than the shell which should fix the
inconsistency.
2022-11-07 16:41:52 +01:00
Shati Patel
3bb10d8c6e
Add button to open database config from the new databases UI ( #1719 )
2022-11-07 13:24:15 +00:00
Charis Kyriakou
3f001c981d
Create remote db tree view items based on the user's db config ( #1714 )
2022-11-07 11:26:33 +00:00
Koen Vlaswinkel
09bae13732
Add cancelling of variant analysis to view
...
This implements the "Stop query" button on the view. It moves some of
the logic of actually cancelling the variant analysis to the manager
instead of being in the query history to allow better re-use of the
code.
2022-11-07 11:21:24 +01:00
Koen Vlaswinkel
93054e14a2
Merge pull request #1683 from github/koesie10/fix-duplicate-downloads
...
Fix duplicate variant analysis results downloads
2022-11-07 10:37:51 +01:00
Koen Vlaswinkel
a661daaa37
Merge remote-tracking branch 'origin/main' into koesie10/fix-duplicate-downloads
2022-11-07 09:43:31 +01:00
Koen Vlaswinkel
b062f61544
Merge pull request #1716 from github/koesie10/use-shared-types-in-variant-analysis
...
Remove `gh-api` usage from variant analysis code
2022-11-04 17:07:54 +01:00
Elena Tanasoiu
1fdb1e23f4
Merge pull request #1715 from github/elena/cancel-variant-analysis
...
Implement query history "cancel" option
2022-11-04 15:19:20 +00:00
Elena Tanasoiu
145f0bf1f2
Be slightly less verbose when mocking a variant analysis
2022-11-04 14:13:18 +00:00
Elena Tanasoiu
2ca15f3665
Make it possible to cancel a variant analysis from Query History
...
This also adds tests for cancelling a local query and a remote query.
NB: We only cancel queries that are in progress, so the tests check
the behaviour both for in progress and not in progress items.
2022-11-04 14:13:17 +00:00
Elena Tanasoiu
20b127c693
Make it possible to cancel a mock local query
...
We're going to add tests to check that we cancel a remote query.
We'll need a `.cancel` method to be present on our mock local queries for this.
2022-11-04 14:13:17 +00:00
Elena Tanasoiu
620cc39e63
Introduce createVariantAnalysis method in actions API
...
This will allow us to make an API call to cancel a variant analysis.
2022-11-04 14:13:17 +00:00
Koen Vlaswinkel
8345284327
Merge pull request #1712 from github/koesie10/filter-sort-fixes
...
Add missing margin to repositories sort/filter row
2022-11-04 14:54:12 +01:00
Koen Vlaswinkel
ae3c0888e8
Remove gh-api usage from variant analysis code
...
This removes all usages of the `gh-api` types from the variant analysis
code by replacing it by the same types defined in `shared`.
This is a breaking change for the query history since the files
serialized to disk now also change. However, since this is still behind
a feature flag the change should be safe to make now.
2022-11-04 14:44:37 +01:00
Nora
4d00c4abfc
Merge pull request #1713 from github/charis-nora/introduce-error-view-in-db-panel
...
Introduce error in new db panel
2022-11-04 13:41:27 +01:00
Nora
99e523f645
Update extensions/ql-vscode/src/databases/ui/db-tree-data-provider.ts
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2022-11-04 13:23:29 +01:00
Nora
6e19b5200c
Update extensions/ql-vscode/src/databases/ui/db-tree-data-provider.ts
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2022-11-04 13:23:23 +01:00
Nora
45bb643a8a
Update extensions/ql-vscode/src/databases/ui/db-tree-view-item.ts
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2022-11-04 13:23:17 +01:00
Koen Vlaswinkel
c6548cbe41
Add missing margin to repositories sort/filter row
2022-11-04 13:08:43 +01:00
Nora
3cc7d3ce8a
Add sample error
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2022-11-04 13:06:31 +01:00
Koen Vlaswinkel
3dbd071570
Merge pull request #1711 from github/koesie10/sort-repositories
...
Add sorting to variant analysis repositories
2022-11-04 12:27:43 +01:00
Nora
fe90f38ad4
Merge pull request #1709 from github/charis-nora/validate-db-config-file
...
Validate workspace-databases.json
2022-11-04 12:20:20 +01:00
Koen Vlaswinkel
588351b101
Merge remote-tracking branch 'origin/main' into koesie10/sort-repositories
2022-11-04 11:30:24 +01:00
Koen Vlaswinkel
c0ba9c5f6e
Merge pull request #1705 from github/koesie10/filter-repositories-by-name
...
Add repository filter by full name
2022-11-04 11:28:58 +01:00
Koen Vlaswinkel
18e1cfa8aa
Merge remote-tracking branch 'origin/main' into koesie10/fix-duplicate-downloads
2022-11-04 11:27:50 +01:00
Koen Vlaswinkel
49f97e1bcc
Add tests for repo states
2022-11-04 11:24:52 +01:00
Nora
f6b50bb3d6
Use contributes jsonValidation instead
2022-11-04 11:24:46 +01:00
Nora
544ff89bf8
Merge comments
2022-11-04 10:20:47 +01:00
Elena Tanasoiu
e7a0c7e652
Merge pull request #1710 from github/elena/sort-sorting
...
Make sorting tests work with remote queries & variant analysis history items
2022-11-03 16:57:14 +00:00
Koen Vlaswinkel
5ff7b8a1c1
Add sorting to variant analysis repositories
...
This adds sorting to the variant analysis repositories on the outcome
panels. The sort state is shared between all panels, so unlike the
design this doesn't disable the sort when you are on e.g. the no access
panel.
2022-11-03 16:18:22 +01:00
Elena Tanasoiu
f0aa0a5ef6
Get rid of old item factory method
...
We don't use it anymore.
2022-11-03 14:34:27 +00:00
Elena Tanasoiu
52ee4563dc
Make sorting tests work with remote queries and variant analysis history items
...
We can now, finally, test sorting works, with REAL objects.
2022-11-03 14:34:27 +00:00
Elena Tanasoiu
a7431bdc1d
Use new factory methods in query history tests
2022-11-03 14:18:52 +00:00
Elena Tanasoiu
a1d3c612ad
Use new createMockLocalQueryInfo method in query-history-info tests
2022-11-03 14:16:43 +00:00
Elena Tanasoiu
2fe0c7925d
Adapt tests for query history labels to use new LocalQueryInfo factory method
...
We're making a number of changes:
1. We're changing the userSpecifiedLabel value to be
`user-specified-name` instead of `xxx`
2. For local queries, we're changing `in progress` to `finished in 0
seconds` when the query has results. The previous version was
contradictory because any query still in progress wouldn't have results.
3. Similarly, for remote queries, we're changing `in progress` to
`completed` when the query has results. Here we actually set a `status`
property which means `in progress` becomes `completed`.
2022-11-03 14:08:16 +00:00
Elena Tanasoiu
028cc79bb9
Combine createMockLocalQueryInfo and createMockLocalQuery
...
One factory method to rule them all!
There were a number of problems with these methods:
1. We were previously using two different factory methods to generate
a fake local queries. Ideally we'd just have one.
2. We weren't really creating a real LocalQueryInfo object, which
blocked us [1] from being able to correctly understand which fields we
need in our tests and how they interact together.
3. We stubbed a bunch of methods on the original object to get our tests
to work. We can now use a real object with all the trimmings.
[1]: https://github.com/github/vscode-codeql/pull/1697#discussion_r1011990685
2022-11-03 14:02:14 +00:00
Elena Tanasoiu
0639c66bb0
Change createMockRemoteQueryHistoryItem to receive resultCount and startTime
...
Again, we'll need these for sorting.
We also want to be able to set/unset a userSpecifiedLabel. Since this factory
method is used in `history-item-label-provider.test.ts`, we have tests there
that count on this custom label being defined/undefined.
2022-11-03 13:58:09 +00:00
Nora
e6d0646786
Fix rebase conflict changes
2022-11-03 14:56:33 +01:00
Nora
fcc814c0c9
Call db config and initialize with extension path
2022-11-03 14:56:33 +01:00
Nora
ea0887622e
Copy schema to extension files
2022-11-03 14:56:33 +01:00
Nora
d4fb0fa177
Add workspace databases schema
2022-11-03 14:56:33 +01:00
Elena Tanasoiu
44aeaf7d32
Allow createMockVariantAnalysisHistoryItem to receive named params
...
Similarly, we want to provide params selectively to test sorting.
We're also setting some defaults to play nicely with our current
tests.
2022-11-03 13:56:09 +00:00
Elena Tanasoiu
dd55b7e03e
Change createMockVariantAnalysis calls to use named params
2022-11-03 13:55:20 +00:00
Elena Tanasoiu
304c9fb12d
Change createMockVariantAnalysis to receive named params
...
So that we can set them selectively.
For example, we'd like to set executionStartTime to test sorting by date.
2022-11-03 13:55:20 +00:00
Shati Patel
4e3b201054
Rename dbconfig file to workspace-databases.json ( #1707 )
2022-11-03 13:38:32 +00:00
Elena Tanasoiu
4fa5355239
Merge pull request #1702 from github/elena/de-gulp
...
Don't run gulp for integration test commands
2022-11-03 13:02:28 +00:00
Charis Kyriakou
7cff1fb84d
Add core classes and models for the new (experimental) databases panel ( #1704 )
2022-11-03 12:47:23 +00:00
Shati Patel
684c492a43
Set up a watcher that checks for changes to the new db config ( #1699 )
...
Co-authored-by: Nora <norascheuch@users.noreply.github.com >
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2022-11-03 12:26:30 +00:00
Elena Tanasoiu
20e7432ca0
Mention npm run build in the docs
2022-11-03 12:22:24 +00:00
Koen Vlaswinkel
26e2021551
Merge pull request #1692 from github/koesie10/add-metadata-to-repo-row
...
Add repository metadata to row
2022-11-03 11:55:03 +01:00
Koen Vlaswinkel
18111ff4bf
Add repository filter by full name
...
This adds a new textbox to the outcome panels that allows filtering by
the repository full name (e.g. `github/vscode-codeql`). The filtering
uses the same logic as the existing remote queries filter, i.e. by
converting the input and the repository full name to lower case and
checking the the latter includes the former.
2022-11-03 11:12:29 +01:00
Elena Tanasoiu
75ed7d20dc
Await file operations when copying test data
...
Both `copyNoWorkspaceData` and `copyCliIntegrationData` return
promises. Since file copy-ing is quite fast at the moment, this
hasn't been a problem, but it might become a problem in the future
if we start copying larger files.
Let's wait for the operations to finish.
2022-11-03 09:49:57 +00:00
Elena Tanasoiu
abfd1e2e83
Make it possible to have test data in cli-integration
...
This will now reload any files that live in `src/vscode-tests/*/data`.
2022-11-03 09:49:56 +00:00
Elena Tanasoiu
8e7fa4f1d6
Update docs to add reminder about using test data
2022-11-03 09:49:52 +00:00
Robert
afc0d4e6db
Merge pull request #1697 from github/robertbrignull/open_pending_analysis
...
Don't show "open on github" link when we don't yet have anything to show
2022-11-02 16:03:41 +00:00
Elena Tanasoiu
aba2277053
Stop removing files during test setup
...
Now that we have a watch command to check when our test files
need updating, we don't need to do this step during the setup.
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-11-02 15:51:35 +00:00
Elena Tanasoiu
cf6a10ccb2
Introduce watch method for test files
...
Because we're no longer running `gulp` when we run our test command,
we're going to need a way to update our test files when they change.
This will watch for any changes in our test files and copy the new
version over.
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-11-02 15:50:59 +00:00
Shati Patel
7296c645b9
Add database configuration store ( #1691 )
...
This "config store" creates a `dbconfig.json` file (if it doesn't yet exist),
and reads the file to load the database panel state.
Only the database config store should be able to modify the config
— the config cannot be modified externally.
2022-11-02 15:07:23 +00:00
Elena Tanasoiu
d8a3e49d19
Update contribution docs
2022-11-02 14:09:53 +00:00
Elena Tanasoiu
b639f62cfd
Don't run gulp for integration tests
...
We previously attempted to speed up no-workspace tests [1] but realised
we still needed to run some setup steps to get the latest files [2].
Given that we already have `npm run watch` running in the background
when we run our tests, we should be able to regenerate files on the fly.
This means we can drop `gulp` from our setup steps when running integration
tests.
While there's still a danger that you forget to run `npm run watch` in
the background, we think the massive speed up (10s -> 1s) is worth it
as we add more and more tests to this extension.
[1]: https://github.com/github/vscode-codeql/pull/1694
[2]: https://github.com/github/vscode-codeql/pull/1696
2022-11-02 14:02:19 +00:00
Koen Vlaswinkel
1487ff5e0e
Merge remote-tracking branch 'origin/main' into koesie10/add-metadata-to-repo-row
2022-11-02 14:05:08 +01:00
Elena Tanasoiu
0965448c02
Merge pull request #1688 from github/elena/query-history-testing-with-different-items
...
Make query history tests work with remote queries & variant analyses
2022-11-02 12:47:32 +00:00
Koen Vlaswinkel
cb1233d018
Improve humanizeRelativeTime tests
...
The tests were expecting the wrong results, except for the case where
the time was less than a second. For less than a second ago, it makes
sense to return "this minute". For times that are 2.001 minutes ago, it
makes sense to return "2 minutes ago" rather then the previous behaviour
of "3 minutes ago".
2022-11-02 13:45:44 +01:00
Koen Vlaswinkel
3c860cfcff
Merge pull request #1701 from github/koesie10/rename-not-found-repo-nwos
...
Rename `not_found_repo_nwos` to `not_found_repos`
2022-11-02 13:18:02 +01:00
Shati Patel
4064da640b
Refactor: Move sleep function to shared module and import it ( #1700 )
2022-11-02 12:01:14 +00:00
Robert
30dd163265
Merge pull request #1698 from github/robertbrignull/await_monitor
...
Don't await the monitoring command
2022-11-02 12:00:57 +00:00
Shati Patel
bd1f6cf30e
Fix indentation in exported markdown results ( #1693 )
2022-11-02 11:51:43 +00:00
Koen Vlaswinkel
25fec684e2
Rename not_found_repo_nwos to not_found_repos
...
The `not_found_repo_nwos` field doesn't actually exist (anymore?) on the
GitHub API. The correct name is `not_found_repos`, so this renames the
field on the type and in the scenarios.
2022-11-02 12:49:05 +01:00
Koen Vlaswinkel
06fd3a58a7
Add new GitHub API fields to scenario files
...
This uses a script to add the new `stargazers_count` and `updated_at` to
the scenario files. This is done by using the GitHub API to get the
information for each repo and then updating the scenario file.
The `updated_at` values are not completely representative since they are
the `updated_at` at time of running the script, rather than at the time
the variant analysis was run. However, this should not really matter in
practice. An alternative for scanned repositories might be getting the
creation time of the `database_commit_sha` commit.
2022-11-02 12:39:30 +01:00
Robert
f6702844b3
Don't await the monitoring command
2022-11-02 11:20:44 +00:00
Robert
aac9971e2e
Differentiate pending vs in-progress states in query history
2022-11-02 11:03:02 +00:00
Robert
7835ba45a4
Pull out getIconPath and getContextValue methods
2022-11-02 11:00:11 +00:00
Elena Tanasoiu
841c66c7f8
Remove typecasting for factories
...
To produce valid history items and have them blow up when we need to
add new fields.
2022-11-02 10:36:46 +00:00
Robert
78f091729f
Merge pull request #1696 from github/robertbrignull/integration-tests
...
Run test setup before integration tests
2022-11-02 10:25:22 +00:00
Robert
aff369ad7f
Run test setup before integration tests
2022-11-02 10:00:21 +00:00
Elena Tanasoiu
d610701d45
Use factory method to generate variant analysis
2022-11-02 09:44:25 +00:00
Robert
36754a8a10
Merge pull request #1690 from github/robertbrignull/handle_states_monitoring
...
Make the monitoring command slightly simpler and handle being called on any variant analysis
2022-11-02 09:33:37 +00:00
Elena Tanasoiu
4cc423217d
Merge pull request #1694 from github/robert-elena/extract-no-workspace-command
...
Introduce command to run no-workspace tests separately
2022-11-02 09:16:26 +00:00
Elena Tanasoiu
5a4015900f
Only test removal for local queries for now
...
Paired with @robertbrignull on debugging why having all types of
query history items isn't playing nicely when we try to remove an item.
We've tracked down the issue it the handleRemoveHistoryItem method
not correctly setting the `current` item after a deletion.
However, it's unclear whether the test setup is to blame or this is a
real bug.
I'm going to leave the tests for `handleRemoveHistoryItem` to test just
local queries for now (as they were originally) and will come back to
this in a different PR.
2022-11-01 17:31:41 +00:00
Elena Tanasoiu
e0a0051f70
Introduce command to run no-workspace tests separately
...
This takes down the feedback loop from 5-10 seconds to half a second
since we're not running through the setup for minimal workspace tests.
2022-11-01 17:21:31 +00:00
Koen Vlaswinkel
be62bd3b25
Add metadata to repository row
...
This will add the star count and last updated fields to the repository
row. We are able to re-use some components from remote queries, but we
cannot re-use `LastUpdated` since it requires a numeric duration, while
we are dealing with an ISO8601 date.
2022-11-01 16:56:11 +01:00
Robert
ae31a17344
Merge pull request #1672 from github/robertbrignull/always_trigger_monitoring
...
When rehydrating, always trigger a monitoring command unless the variant analysis is fully complete
2022-11-01 13:57:02 +00:00
Robert
9359d5de24
Merge pull request #1687 from github/robertbrignull/load_query_history_later
...
Move loading query history to after registering commands
2022-11-01 13:56:41 +00:00
Koen Vlaswinkel
fcb1ef4fd7
Fix typings on Storybook stories
...
It seems like the Storybook stories were not being type-checked by CI
and got out-of-sync with the required types. This fixes the types and
also uses the factories to reduce the chance of this happening with
future changes.
2022-11-01 14:25:13 +01:00
Elena Tanasoiu
a1daa91502
Break down handleItemClicked tests per history item type
...
We were expecting all three types to behave the same when clicked /
double clicked.
In fact local & remote queries only allow you to open the results view
when they're complete, while variant analyses always allow you to open
the results view no matter what their status.
Let's break down these tests per history item type and test the
expected behaviour more granularly.
NB: I tried moving some of the setup in beforeEach blocks, but alas
queryHistoryManager can be undefined so rather than adding `?` to
every method call, I'm just gonna leave the setup inside the tests.
In an ideal world, we'd stop declaring `queryHistoryManager` as
`undefined`:
```
let queryHistoryManager: QueryHistoryManager | undefined;
```
Baby steps!
2022-11-01 11:39:53 +00:00
Elena Tanasoiu
a21dec7461
Fix label text
...
In [1] we changed our factory methods to actually use QueryStatus when
creating remote query & variant analysis history items.
Previously we were just setting the value to `in progress`...
... which made the tests for history-item-label-provider.test.ts pass...
... but that value did not reflect reality ...
What we actually need to do is introduce a method to map different
query statuses to human readable strings, e.g.
QueryStatus.InProgress becomes 'in progress'
[1]: 4b9db6a298 (diff-217b085c45cd008d938c3da4714b5782db6ad31438b27b07e969254feec8298aL28)
2022-11-01 11:39:53 +00:00
Elena Tanasoiu
8cfa82f334
Move query-history-info tests next to query-history tests
...
We've introduced a new `local-query-history-item.ts` factory method [1]
which includes a cancellation token. The factory will need to import the
CancellationTokenSource from `vscode`.
We already had a factory method but it didn't quite map with the setup
we needed. For example we need to call `.completeQuery` rather than
providing a dummy `completedQuery` object.
The previous factory method was used in the tests for
`query-history-info.test.ts`. Because that factory omitted the
cancellation token, we could get away with having these tests in the
`tests/pure-tests` folder.
With the addition of the second factory method, the tests for
`query-history-info` blow up because they can't find `vscode`.
Now that we need to add more fields to local query history items, it's
becoming clearer that these `query-history-info` tests should live next
to the `query-history` tests in `vscode-tests/no-workspace`.
Granted, in an ideal situation we'd only have one factory method to
generate a local query history item, but combining these two methods
is actually quite painful. So for now let's at least have the query
history tests next to each other and appease Typescript.
2022-11-01 11:36:25 +00:00
Robert
cc955c70f9
Slim down VariantAnalysisMonitorResult
2022-11-01 11:15:54 +00:00
Robert
594d879640
Try to download results even if there's a failure reason
2022-11-01 11:15:54 +00:00
Robert
5174afed00
Only fire _onVariantAnalysisChange from one place
2022-11-01 11:15:54 +00:00
Koen Vlaswinkel
5a2a9fc4bf
Add repository metadata to types
...
This adds the new `stargazers_count` and `updated_at` fields in the
repositories to the appropriate `gh-api` and `shared` types.
To make testing easier this also moves the
`variant-analysis-processor.test.ts` to the pure tests since it doesn't
and shouldn't depend on any `vscode` APIs.
2022-11-01 12:05:50 +01:00
Koen Vlaswinkel
be2ca6c368
Merge pull request #1689 from github/koesie10/move-create-gist-to-gh-api-client
...
Move `createGist` to `gh-api-client`
2022-11-01 11:03:00 +01:00
Elena Tanasoiu
99af9ca47d
Combine getChildren tests together
...
And rename original `getChildren` describe block to `sorting` since
that's what the tests are checking.
2022-11-01 09:39:52 +00:00
Elena Tanasoiu
b3c8ef115d
Move getChildren tests into HistoryTreeDataProvider describe block
2022-11-01 09:39:52 +00:00
Elena Tanasoiu
661638517f
Move tests for getTreeItem into getTreeItem describe block
2022-11-01 09:39:52 +00:00
Elena Tanasoiu
6d3f7e3fdb
Group dangling tests into a QueryHistoryManager describe block
2022-11-01 09:39:52 +00:00
Elena Tanasoiu
8550778609
Wrap tests for removal in handleRemoveHistoryItem describe block
...
Instead of having them dangle around.
2022-11-01 09:39:52 +00:00
Elena Tanasoiu
f837508d86
Combine beforeEach blocks
...
I don't know why there are two.
2022-11-01 09:39:52 +00:00
Elena Tanasoiu
4b9db6a298
Make query history tests work with remote / variant analysis queries
...
We're adding both remote query history items and variant analysis history
items to the query history.
We've introduced a little method to shuffle the query history list
before we run our tests so that we don't accidentally write tests that
depend on a fixed order.
The query history now has increased test coverage for:
- handling an item being clicked
- removing and selecting the next item in query history
- handling single / multi selection
- showing the item results
While we're here we're also:
1. Adding a factory to generate variant analysis history items
2. Providing all fields for remote query history items and ordering them
according to their type definition order. At least one field (`queryId`)
was missing from our factory, which we will need to make the tests work
with remote queries.
2022-11-01 09:39:51 +00:00
Elena Tanasoiu
6289411e08
Move local query tests into their own describe block
...
There are a couple of tests that check whether we can correctly
compare two local queries.
These shouldn't be applied to remote queries [1] so let's just
make that a bit clearer by moving them into a local queries describe
block and using the `localHistory` array to choose items to compare
instead of the `allHistory` array.
[1]: bf1e3c10db/extensions/ql-vscode/src/query-history.ts (L1311-L1314)
2022-11-01 09:39:51 +00:00
Elena Tanasoiu
0164d1094c
Move factory for creating query results into shared folder
2022-11-01 09:39:51 +00:00
Elena Tanasoiu
b0ba1e0576
Move factory for creating local query into shared folder
...
There's a lot of clean-up in these tests so I'm making one change per commit.
Let's move out the utility methods so we can focus on just our tests.
2022-11-01 09:39:51 +00:00
Elena Tanasoiu
718a6d6948
Allow testing for multiple types of history items
...
At the moment our query history tests are set up to only check
local queries.
Let's prepare the ground to introduce remote query history items
and variant analysis history items.
This will allow us to expand test coverage for these other types
of items.
2022-11-01 09:39:50 +00:00
Koen Vlaswinkel
6ccaf5302f
Move createGist to gh-api-client
...
The `createGist` functionw was part of `gh-actions-api-client`, while it
didn't actually involve anything related to the GitHub Actions API. This
moves it to the non-Actions-specific `gh-api-client` module.
Another candidate for moving to `gh-api-client` is
`getRepositoriesMetadata`, but that one is a bit more involved since it
uses `showAndLogErrorMessage`, so depends on the `vscode` module. This
means it would not be possible to test in the "pure" tests and we would
need to move all our `gh-actions-api` tests to the integration tests. It
will not be used for variant analysis queries anymore, so I don't think
it's worth moving or refactoring to not depend on `vscode`.
2022-11-01 10:38:05 +01:00
Robert
952f033377
Merge branch 'main' into robertbrignull/always_trigger_monitoring
2022-10-31 15:42:52 +00:00
Robert
12d5255073
Fix rehydrateVariantAnalysis integration tests
...
The method no longer accepts a second argument
2022-10-31 15:41:28 +00:00
Koen Vlaswinkel
bf1e3c10db
Merge pull request #1686 from github/koesie10/live-results-view-logs
...
Open Actions workflow run when clicking on "View logs"
2022-10-31 16:21:21 +01:00
Koen Vlaswinkel
453cc77c3e
Merge pull request #1685 from github/koesie10/open-live-results-on-github
...
Add opening on GitHub of live results variant analyses
2022-10-31 16:20:56 +01:00
Robert
6dc684f2b6
Fix unit test expectated results 🤦
2022-10-31 15:14:52 +00:00
Robert
6b578c830d
Move loading query history to after registering commands
2022-10-31 14:54:45 +00:00
Charis Kyriakou
76119e40fb
A new experimental database panel ( #1682 )
...
* Add new config setting
* Add a new database panel behind experimental config
2022-10-31 14:53:16 +00:00
Robert
c9038f5334
Add awaits
2022-10-31 14:29:26 +00:00
Koen Vlaswinkel
45764d9bff
Clean up opening variant analysis on GitHub
...
This removes a comment and makes the test lines shorter.
2022-10-31 15:18:17 +01:00
Koen Vlaswinkel
804632274a
Open Actions workflow run when clicking on "View logs"
...
This will hook up the "View logs" link to make it open the variant
analysis actions workflow run. The method for creating the actions
workflow run URL has been extracted from the query history to make it
callable without a history item.
2022-10-31 14:46:32 +01:00
Koen Vlaswinkel
847cb13694
Add opening on GitHub of live results variant analyses
...
This implements the "Open on GitHub" context menu item for live results
variant analyses.
2022-10-31 14:46:01 +01:00
Koen Vlaswinkel
dad6467599
Add controller repo to VariantAnalysis type
...
This adds the `controllerRepo` field to the `VariantAnalysis` shared
type. This is technically a breaking change since the old history won't
have this field and all calls on this will fail. However, the feature
is not available so this should be fine.
2022-10-31 14:19:12 +01:00
Koen Vlaswinkel
b6410073d4
Merge pull request #1681 from github/koesie10/variant-analysis-view-title
...
Set variant analysis view title to query name
2022-10-31 14:14:52 +01:00
Koen Vlaswinkel
1e1c7d4a5f
Merge pull request #1684 from github/koesie10/fix-eslint
...
Fix ESLint configuration for `scripts` directory
2022-10-31 14:05:58 +01:00
Koen Vlaswinkel
31a28e70b2
Remove unnecessary await in restoreView
2022-10-31 13:57:49 +01:00
Koen Vlaswinkel
ccf03cbcff
Fix view not taking into account download status
...
The variant analysis view would allow expanding the results when the
repo task was completed. However, it did not take into account whether
the results were actually downloaded. This will that by usign the
download status when the repo task was succeeded and sending the repo
states to the view on load.
2022-10-31 13:51:32 +01:00
Koen Vlaswinkel
47045f23c3
Fix duplicate variant analysis results downloads
...
This adds a new file `repo_states.json` which tracks the download status
of all repositories of a variant analysis. We will write this file when
a download has completed and skip a repository download if the repo
state is marked as `succeeded`. This should prevent duplicate downloads.
This will still queue all repositories, even those which have already
been downloaded. However, I expect the actual cost in the download
method to be negligible since it's just an in-memory check.
2022-10-31 13:51:32 +01:00
Koen Vlaswinkel
c1f24142c9
Run ESLint on all files
...
This wil remove the discrepancy between the files on which ESLint is run
when `lint-staged` is used and the files that are checked using
`npm run lint` and `npm run format`.
It will now also include the `.storybook` directory which was previously
excluded from the ESLint configuration.
2022-10-31 13:22:27 +01:00
Koen Vlaswinkel
762288b57f
Add tsconfig.json file for scripts directory
...
This will fix linting errors when `lint-staged` is run and there are
changed files in the `scripts` directory.
2022-10-31 13:21:56 +01:00
Robert
c36fa0f5d3
Merge branch 'main' into robertbrignull/always_trigger_monitoring
2022-10-31 11:53:20 +00:00
Robert
b751cee618
Check directory exists before deleting
2022-10-31 11:39:05 +00:00
Robert
b497c4fa00
make public prepareStorageDirectory private
2022-10-31 11:34:06 +00:00
Robert
b53366f277
Move isVariantAnalysisComplete implementation out of variant analysis manager
2022-10-31 11:34:03 +00:00
Koen Vlaswinkel
1cce7ae0e2
Merge pull request #1680 from github/koesie10/close-webview-on-history-item-delete
...
Close view when variant analyis is deleted from query history
2022-10-31 12:03:08 +01:00
Koen Vlaswinkel
9b59b65591
Set variant analysis view title to query name
2022-10-31 11:41:54 +01:00
Robert
7e59d4c736
Convert to using sinon spies
2022-10-31 10:38:44 +00:00
Koen Vlaswinkel
cdbdf62612
Make webview panel creation async
...
This will make the creation of a webview panel async to allow the
`getPanelConfig` method to be an async function. This will allow us to
do some work (like retrieving the variant analysis) in the
`getPanelConfig` method.
2022-10-31 11:34:58 +01:00
Elena Tanasoiu
c36ce4867e
Merge pull request #1650 from github/nora-elena/integration-tests
...
Add tests for variant analysis history item
2022-10-31 10:33:59 +00:00
Robert
7748f82c96
Stop checking result count and rename repoScanHasResults
2022-10-31 10:24:34 +00:00
Koen Vlaswinkel
5b217220fa
Close view when variant analyis is deleted from query history
...
This will close the variant analysis view when the corresponding variant
analysis history item is deleted from the query history. This required
some extra code to handle `dispose` being called on the view to ensure
this actually disposes the panel, but we can now call `dispose()` on the
view to close it.
2022-10-31 11:18:00 +01:00
Elena Tanasoiu
7685d7651e
Don't test rehydration twice
2022-10-31 10:06:27 +00:00
Koen Vlaswinkel
25a9ee1606
Merge pull request #1665 from github/koesie10/msw-integration-test
...
Add some basic integration tests for MRVA
2022-10-31 09:22:37 +01:00
aeisenberg
12e2eb2d8b
Bump version to v1.7.5
2022-10-29 20:41:07 +00:00
Andrew Eisenberg
84b48f416f
Merge pull request #1678 from github/v1.7.4
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.7.4
2022-10-29 13:36:36 -07:00
Andrew Eisenberg
606ffe41b0
v1.7.4
2022-10-29 13:17:19 -07:00
github-actions[bot]
75b4934d97
Bump version to v1.7.4 ( #1676 )
...
Co-authored-by: angelapwen <angelapwen@users.noreply.github.com >
2022-10-29 00:31:47 +00:00
Angela P Wen
77c28e0453
v1.7.3 ( #1675 )
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2022-10-28 23:11:00 +00:00
Andrew Eisenberg
47ae6e2b41
Assert minimum version of vscode
2022-10-28 09:58:12 -07:00
Andrew Eisenberg
9f03db2f28
Fix typos
2022-10-28 09:54:33 -07:00
Koen Vlaswinkel
72b335649c
Use new mock API server and rename integration test
2022-10-28 17:22:34 +02:00
Koen Vlaswinkel
2a437c0d1a
Merge remote-tracking branch 'origin/main' into koesie10/msw-integration-test
2022-10-28 17:20:48 +02:00
Koen Vlaswinkel
bc10a7a38a
Merge pull request #1663 from github/koesie10/gh-api-client-msw-test
...
Add msw tests for gh-api-client
2022-10-28 17:20:34 +02:00
Koen Vlaswinkel
562986546d
Use scenario JSON files in tests
...
This will check that the data returned matches the data in the JSON
files, rather than checking against constants/magic values.
2022-10-28 16:36:03 +02:00
Koen Vlaswinkel
c4d9ef26a8
Use correct tsconfig.json in pure tests
...
This will change the pure tests Mocha setup to actually use the
`tsconfig.json` located in the `test` directory. Before, it was using
the root-level `tsconfig.json`. To ensure we are still using mostly the
same settings, this will extend the `test/tsconfig.json` from the
root-level `tsconfig.json`.
2022-10-28 16:34:36 +02:00
Koen Vlaswinkel
a9e49f2d72
Split mock GitHub API server into VSCode and non-VSCode
...
This splits the mock GitHub API server class into two parts: one for the
interactive, VSCode parts and one for the non-VSCode parts. This allows
us to use the non-VSCode part in tests.
2022-10-28 14:59:18 +02:00
Charis Kyriakou
b15626853b
Add script to help with scenario recording ( #1671 )
2022-10-28 09:22:11 +00:00
Charis Kyriakou
f04c34629e
Set in memory variant analysis on submission ( #1673 )
2022-10-28 10:07:14 +01:00
Charis Kyriakou
a217b53bf3
Add some more mock scenarios ( #1667 )
2022-10-28 09:44:14 +01:00
Nora
626592ee79
Fix tests
2022-10-28 10:22:29 +02:00
Elena Tanasoiu
4826a7e91f
Merge pull request #1658 from github/elena/add-tests-for-removal
...
Add test for `removeVariantAnalysis`
2022-10-28 09:11:17 +01:00
Koen Vlaswinkel
d12cdbe679
Merge pull request #1664 from github/koesie10/upgrade-vscode-test
...
Upgrade from vscode-test to @vscode/test-electron
2022-10-28 09:41:46 +02:00
Robert
599a9ed5d9
When rehydrating, always trigger a monitoring command if variant analysis is not complete
2022-10-27 17:05:32 +01:00
Robert
caeaba2f2f
Make isVariantAnalysisRepoDownloaded public
2022-10-27 17:04:50 +01:00
Robert
51589e953e
Move test fixtures earlier in file
2022-10-27 17:02:36 +01:00
Robert
c4b1134903
Rename variantAnalysis to be more specific
2022-10-27 16:58:43 +01:00
Koen Vlaswinkel
1ec3d044cf
Merge pull request #1668 from github/koesie10/dangling-foreach-promises
...
Fix dangling promises in `forEach` calls
2022-10-27 15:17:28 +02:00
Charis Kyriakou
dbb549d5fb
Add mock GitHub API server docs ( #1661 )
2022-10-27 12:08:08 +00:00
Koen Vlaswinkel
4c469e7386
Fix dangling promises in forEach calls
...
This will ensure that we are awaiting all calls by using `Promise.all`.
2022-10-27 14:06:48 +02:00
Shati Patel
2ccdb9e577
Correctly rehydrate variant analyses ( #1666 )
2022-10-27 12:30:36 +01:00
Koen Vlaswinkel
00145bbfd4
Add some basic integration tests for MRVA
...
This adds some basic integration tests for MRVA using the GitHub mock
API server. It only does basic assertions and still needs to stub some
things because it is quite hard to properly test things since VSCode
does not expose an API to e.g. answer quick pick pop-ups.
I'm not sure how useful these integration tests will actually be in
practice, but they do at least ensure that we are able to successfully
submit a variant analysis.
2022-10-27 12:24:22 +02:00
Koen Vlaswinkel
123219aace
Upgrade from vscode-test to @vscode/test-electron
2022-10-27 10:51:30 +02:00
Koen Vlaswinkel
ecdc485e79
Add msw tests for gh-api-client
...
This adds some really simple tests for the `gh-api-client` file to
ensure that we can use msw mocks in pure tests.
2022-10-27 10:29:23 +02:00
Charis Kyriakou
3812e3dcb0
Add some mock scenarios ( #1660 )
2022-10-27 09:23:26 +01:00
Alexander Eyers-Taylor
df832746ad
Also upgrade jsonrpc
2022-10-26 17:09:56 +00:00
Elena Tanasoiu
eb09a0db8a
Use getter method
2022-10-26 16:55:53 +01:00
Elena Tanasoiu
ad7a04e385
Update tests to account for item removal and showView
...
We've merged https://github.com/github/vscode-codeql/pull/1656
which actually implements item removal. We'll need to change our
tests to account for this.
We've also merged https://github.com/github/vscode-codeql/pull/1654
which implements opening the view when we click on a variant analysis
history item. So we've changed our tests to take into account that
there's now a `showView` method being called.
2022-10-26 16:52:10 +01:00
Charis Kyriakou
158bebd03f
Remove incorrect and unnecessary field from data model ( #1659 )
2022-10-26 15:46:42 +00:00
Alexander Eyers-Taylor
c9e87eff56
Update languageserver-client
2022-10-26 15:08:43 +00:00
Nora
c4b4cee057
Adjust handling of historyItem
2022-10-26 15:59:26 +01:00
Nora
7cffb997a7
Add query text test
2022-10-26 15:52:17 +01:00
Nora
83291c5ceb
Add should handle click test
2022-10-26 15:52:17 +01:00
Nora
3c870a10e2
Add test to remove 2 entries from query history
2022-10-26 15:52:17 +01:00
Elena Tanasoiu
2a722ba264
Add test for removing a variant analysis history item
...
Co-authored-by: Nora Scheuch <norascheuch@github.com >
2022-10-26 15:52:17 +01:00
Elena Tanasoiu
da754a23e4
Create basic test set up and first test
...
Co-authored-by: Nora Scheuch <norascheuch@github.com >
2022-10-26 15:52:16 +01:00
Elena Tanasoiu
4a237ba019
Add test data for variant analysis
...
We will need to set up some VariantAnalysisHistoryItem types in order
to use them in our tests.
We're repeating what we've done for RemoteQueryHistoryItem for now.
Separately we'll think about setting up tests that check for both
remote queries and variant analysis in the query history.
At the moment we'd like to focus on just adding some test coverage
for variant analysis history items.
Co-authored-by: Nora Scheuch <norascheuch@github.com >
2022-10-26 15:52:16 +01:00
Nora
319d8ce0f5
Combine beforeEach
2022-10-26 15:52:16 +01:00
Nora
f313648ab7
Combine afterEach calls
2022-10-26 15:52:16 +01:00
Elena Tanasoiu
1a3fecd3e8
Add test for removeVariantAnalysis
2022-10-26 15:15:12 +01:00
Elena Tanasoiu
1348de5a5f
Surround tests with describe blocks
...
To better indicate which method they're testing.
2022-10-26 15:06:46 +01:00
Elena Tanasoiu
8521138bce
Merge pull request #1657 from github/elena/decouple-manager-from-results
...
Decouple VariantAnalysisManager from VariantAnalysisResultsManager
2022-10-26 15:04:10 +01:00
Elena Tanasoiu
8569fa7399
Don't track results manager as a disposable object
2022-10-26 14:36:51 +01:00
Elena Tanasoiu
ee37fbff63
Merge pull request #1656 from github/nora-charis-elena/handle-item-removal-take-two
...
Implement `handleRemoveHistoryItem` for variant analysis history items - take two
2022-10-26 14:16:10 +01:00
Elena Tanasoiu
d49bffe98e
Decouple VariantAnalysisManager from VariantAnalysisResultsManager
...
At the moment we create the results manager as a private property on the `VariantAnalysisManager`.
If we instead created it at the extension level and passed it to the `VariantAnalysisManager`, we would have more freedom to write unit tests for the `VariantAnalysisManager` without needing to reach into a private results manager property.
2022-10-26 13:47:52 +01:00
Nora
832211d789
Adjust comment
2022-10-26 14:33:47 +02:00
Nora
f9553d7033
Rename method
2022-10-26 14:29:50 +02:00
Elena Tanasoiu
f18f1b0ca7
Implement handleRemoveHistoryItem for variant analysis history items
...
We had previously added a no-op placeholder for when we attempt
to remove a variant analysis from our query history.
This adds the implementation:
- removes the item from the query history
- cleans up any existing result files attached to the variant analysis
NB: The remote queries would store all their results in a single folder.
For variant analysis, we store results per repo. The folder names are build
using a cache key and are stored in `cachedResults`. The cache key is
built from the variant analysis id and the repo name.
In order to delete the results, we've had to pass in the full variant analysis
object to the manager and call `cacheResults.delete()` for each of its scanned
repos.
Co-authored-by: Charis Kyriakou <charisk@github.com >
Co-authored-by: Nora Scheuch <norascheuch@github.com >
2022-10-26 12:21:46 +01:00
Shati Patel
50ec71893c
Implement openQueryResults for variant analysis items ( #1654 )
2022-10-26 10:20:23 +01:00
Andrew Eisenberg
56af69e58d
Merge pull request #1638 from github/aeisenberg/persist-dbs
...
Fix bug where dbs are lost on restart
2022-10-25 10:28:58 -07:00
Andrew Eisenberg
d209e52a0b
Merge branch 'main' into aeisenberg/persist-dbs
2022-10-25 08:54:31 -07:00
Andrew Eisenberg
09b30fe5a3
Merge pull request #1568 from asgerf/asgerf/navigate-alerts
...
Add commands for navigation of alerts
2022-10-25 08:51:38 -07:00
Andrew Eisenberg
c6d54de748
Update extensions/ql-vscode/CHANGELOG.md
...
Co-authored-by: Edoardo Pirovano <6748066+edoardopirovano@users.noreply.github.com >
2022-10-25 08:42:27 -07:00
Andrew Eisenberg
a3fafc8e59
Merge pull request #1611 from github/aeisenberg/fix-flakes
...
Test cleanups
2022-10-25 08:26:26 -07:00
Charis Kyriakou
6a636baa21
Remove historyItemId for variant analyses ( #1651 )
2022-10-25 12:57:48 +00:00
Charis Kyriakou
9e92d0c4a7
Allow multiple query history items for a single variant analysis ( #1653 )
2022-10-25 13:47:53 +01:00
Shati Patel
78a0a4e580
Bump CLI version to 2.11.2 for integration tests
2022-10-25 11:30:04 +01:00
Koen Vlaswinkel
f0f01720f1
Merge pull request #1648 from github/koesie10/store-scenario-bodies-as-files
...
Store binary scenario bodies as files
2022-10-25 11:18:38 +02:00
Elena Tanasoiu
c8b0461f7f
Merge pull request #1620 from github/mob/consume-update-event
...
QueryHistory: Consume event when variant analysis status is updated
2022-10-25 09:20:31 +01:00
Koen Vlaswinkel
00de0820fb
Add proper handling of binary responses
...
msw doesn't seem to support binary responses because it decodes them to
a UTF-8 string. To work around that, we will do a separate fetch of the
file and save that.
2022-10-25 10:07:43 +02:00
Koen Vlaswinkel
5a76df8489
Load response bodies from files
2022-10-25 10:07:16 +02:00
Koen Vlaswinkel
9764a93900
Store ZIP bodies as files
2022-10-25 10:06:50 +02:00
Charis Kyriakou
130d8efe35
Tidy up msw handlers used for scenario replay ( #1649 )
2022-10-25 08:44:29 +01:00
Angela P Wen
63a5021e5e
Use sarif parser for reopened results ( #1457 )
2022-10-24 12:31:35 -07:00
Edoardo Pirovano
e891169ca3
MRVA: Use QLX to precompile queries
...
Co-authored-by: Henning Makholm <hmakholm@github.com >
2022-10-24 17:33:25 +01:00
Charis Kyriakou
98284d9b2c
Add loading of mock scenarios ( #1641 )
2022-10-24 16:27:37 +01:00
Asger F
b480f8f375
Fix incorrect merge resolution in changelog
2022-10-24 13:20:42 +02:00
Asger F
ead1fb4cd9
Merge branch 'main' into asgerf/navigate-alerts
2022-10-24 13:19:05 +02:00
Asger F
0acf9f7b66
Fix bad suggestion merge in package.json
2022-10-24 13:18:33 +02:00
Asger F
9cb4b9d372
Update extensions/ql-vscode/package.json
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-10-24 13:13:57 +02:00
Shati Patel
8a10a49f66
Merge pull request #1639 from github/shati-patel/repo-count
...
Implement query history label for variant analysis items
2022-10-24 11:29:09 +01:00
Koen Vlaswinkel
40d281aa3f
Merge pull request #1646 from github/koesie10/fix-command-visibility
...
Fix scenario commands visibility
2022-10-24 12:17:42 +02:00
Elena Tanasoiu
b25cb8adbe
Merge branch 'main' into mob/consume-update-event
2022-10-24 11:13:41 +01:00
Nora
88edcaf067
Merge pull request #1621 from github/norascheuch/variant-analysis-rehydrate-and-remove-event
...
Implement rehydration for variant analysis
2022-10-24 11:47:44 +02:00
shati-patel
8737cfde0b
Add undefined case to pluralize unit tests
2022-10-24 10:44:16 +01:00
shati-patel
593ca57497
Cover more cases in buildRepoLabel unit tests
2022-10-24 10:30:56 +01:00
Koen Vlaswinkel
471ead37c0
Fix scenario commands visibility
...
When the mock GitHub API server setting was moved to the top-level, we
forgot the comamnds in the `package.json`. This updates the commands to
have the correct visibility.
See: https://github.com/github/vscode-codeql/pull/1643
2022-10-24 11:30:09 +02:00
shati-patel
436af066fc
Add unit tests for pluralize
2022-10-24 10:17:03 +01:00
shati-patel
c85338d11a
refactor: move pluralize into its own module
2022-10-24 10:08:49 +01:00
Nora
1523babcb3
Implement new filePath method suggestion
...
Co-authored-by: Robert <robertbrignull@github.com >
2022-10-24 10:40:03 +02:00
Nora
4ed0e0fa09
Implement find-method suggestion
...
Co-authored-by: Robert <robertbrignull@github.com >
2022-10-24 10:40:03 +02:00
Nora
79bb894a7d
Implement rehydration for variant analysis and introduce onRemoveVariantAnalysis event
2022-10-24 10:40:03 +02:00
Charis Kyriakou
da63b99a94
Update mock GitHub API request models to support failures ( #1644 )
2022-10-24 08:02:36 +00:00
Koen Vlaswinkel
c325a725ea
Merge pull request #1642 from github/koesie10/validate-mocks
...
Add linter for scenario files
2022-10-24 10:01:44 +02:00
Charis Kyriakou
6c8c15155b
Restructure configuration around mock GitHub API ( #1643 )
2022-10-24 08:44:32 +01:00
shati-patel
3cd025f879
Add a unit test for building repo labels
2022-10-21 17:01:46 +01:00
Charis Kyriakou
6b1fce9cd5
Revert to previously used version of husky ( #1640 )
2022-10-21 14:51:56 +00:00
Koen Vlaswinkel
104055e703
Add linter for scenario files
...
This adds a linter for JSON scenario files which will validate the JSON
files in the scenarios directory against the TypeScript types. It will
convert the TypeScript types to JSON schema to simplify this process.
Unfortunately, this will not currently allow adding scenarios with
failing requests since the types do not allow this. Rather than removing
this validation, we should fix the types. This can be done in a follow-up
PR.
2022-10-21 16:41:01 +02:00
shati-patel
add5417a42
Move pluralize method into "pure" helpers file (since we don't require vscode)
2022-10-21 15:04:01 +01:00
Shati Patel
31ef6aef29
Implement buildRepoLabel for variant analysis items
2022-10-21 14:18:53 +01:00
Shati Patel
bd81d3c4a7
Fix bug in pluralize helper method
...
Correctly handle the zero case
2022-10-21 14:17:40 +01:00
Koen Vlaswinkel
4e5abee2ea
Merge pull request #1634 from github/koesie10/record-scenario
...
Add recording of mock scenarios
2022-10-21 14:52:29 +02:00
Asger F
bdf7208476
Mention keyboard navigation in README
2022-10-21 14:26:54 +02:00
Asger F
e1a56dd91d
Update a new more nullish checks
2022-10-21 14:26:37 +02:00
Asger F
d4a58a64ee
Consistently check for undefined rather than nullish
2022-10-21 14:17:06 +02:00
Koen Vlaswinkel
71b1b49502
Fix incorrect development scenarios path
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2022-10-21 14:12:35 +02:00
Asger F
65777b5e60
Use null-aware accessors in getResult
2022-10-21 13:56:30 +02:00
Asger F
53bb9d797b
Title-case command names, like other commands
2022-10-21 13:55:07 +02:00
Asger F
cbf15e6d02
Update extensions/ql-vscode/src/view/results/alert-table.tsx
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-10-21 13:54:45 +02:00
Asger F
ecc07a50be
Update extensions/ql-vscode/CHANGELOG.md
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-10-21 13:54:33 +02:00
Koen Vlaswinkel
7288712e47
Unscope mock commands
...
This reverts commit 57ba12db8b .
2022-10-21 13:12:38 +02:00
Koen Vlaswinkel
74ae5a7fdc
Start mock server on startup
...
The mock server wasn't being started when the extension was activated
when the config setting was already set.
2022-10-21 11:39:29 +02:00
Koen Vlaswinkel
302722b982
Fix isRecording variable name
2022-10-21 11:32:13 +02:00
Koen Vlaswinkel
22f28fa6ff
Hard-code scenarios path in development
...
The scenarios path can still be overridden by setting the config setting.
2022-10-21 11:18:55 +02:00
Koen Vlaswinkel
9ba06ef562
Merge pull request #1627 from github/koesie10/storybook-vscode-theme-addon
...
Create Storybook add-on for switching VSCode themes
2022-10-21 10:53:14 +02:00
Koen Vlaswinkel
cff56b7e7b
Change title of cancelRecording command
2022-10-21 10:45:57 +02:00
Koen Vlaswinkel
ad41a043a7
Add comment for setContext call
2022-10-21 10:45:18 +02:00
Koen Vlaswinkel
66c6bf5e86
Rename some variables
2022-10-21 10:43:32 +02:00
Koen Vlaswinkel
463633334c
Rename recordScenario to startRecording
2022-10-21 10:41:38 +02:00
Koen Vlaswinkel
9278422406
Ensure save and cancel commands are only visible with feature flag
2022-10-21 10:41:03 +02:00
Koen Vlaswinkel
57ba12db8b
Scope mock commands
...
The command lint expects all command palette commands to have a common
prefix which these violated. So, I've moved them to being a scoped
command so we can have different lints.
2022-10-21 10:39:47 +02:00
Andrew Eisenberg
ccdffc296c
Merge branch 'main' into aeisenberg/fix-flakes
2022-10-20 17:07:39 -07:00
Andrew Eisenberg
24e9fbe8ca
Update changelog
2022-10-20 16:25:14 -07:00
Andrew Eisenberg
6e33b3c032
Fix bug where dbs are lost on restart
...
If the workspace is restarted while databases are being loaded, this
change prevents any from being lost.
The bug was that each time a database was added when rehydrating a db
from persisted state on startup, the persisted db list
was being updated. Instead of updating the list each time we add a db,
on restart, instead update the persisted list only after all are added.
Note that we need to update the persisted list after reading it in since
the act of rehydrating a database _may_ change its persisted state.
For example, the primary language of the database may be initialized
if it was not able to be determined originally.
2022-10-20 16:20:06 -07:00
Andrew Eisenberg
a625a39999
Merge pull request #1625 from github/aeisenberg/dil-fixes
...
A couple of small changes around the new query server
2022-10-20 10:38:20 -07:00
Andrew Eisenberg
94ef752c0b
A couple of small changes around the new query server
2022-10-20 10:21:05 -07:00
Alexander Eyers-Taylor
9957b211e0
Fix missing DIL for new query server ( #1623 )
...
* Fix missing DIL for new query server
* Fix DIL error message when QLO was not expected.
* Update extensions/ql-vscode/src/run-queries-shared.ts
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-10-20 14:36:31 +01:00
Elena Tanasoiu
38f22b65ef
Merge pull request #1635 from github/elenatanasoiu/update-readme
...
Clarify the roles of different types of tests
2022-10-20 11:28:23 +01:00
Shati Patel
4eecdbfada
Merge pull request #1622 from github/shati-patel/open-query-dir
...
Implement "open query directory" for variant analysis history items
2022-10-20 10:30:03 +01:00
Andrew Eisenberg
7637f9428a
Calculate hidden configuration keys using package.json
2022-10-19 14:57:38 -07:00
Asger F
0e3679d186
Scroll selected item into view
2022-10-19 19:49:12 +02:00
Elena Tanasoiu
e5dcffc04b
Clarify the roles of different types of tests
...
And also clean up the explanation on how to run each type of test.
2022-10-19 18:38:27 +01:00
dependabot[bot]
0ce25eef63
Bump ansi-regex from 4.1.0 to 5.0.1 in /extensions/ql-vscode ( #1613 )
...
Bumps [ansi-regex](https://github.com/chalk/ansi-regex ) from 4.1.0 to 5.0.1.
- [Release notes](https://github.com/chalk/ansi-regex/releases )
- [Commits](https://github.com/chalk/ansi-regex/compare/v4.1.0...v5.0.1 )
---
updated-dependencies:
- dependency-name: ansi-regex
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-19 08:49:22 -07:00
dependabot[bot]
2ca4fb052e
Bump husky from 4.3.8 to 8.0.1 in /extensions/ql-vscode ( #1555 )
...
Bumps [husky](https://github.com/typicode/husky ) from 4.3.8 to 8.0.1.
- [Release notes](https://github.com/typicode/husky/releases )
- [Commits](https://github.com/typicode/husky/compare/v4.3.8...v8.0.1 )
---
updated-dependencies:
- dependency-name: husky
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-19 08:48:35 -07:00
shati-patel
dab67f148e
Implement "open query directory" for variant analysis history items
2022-10-19 16:26:34 +01:00
Koen Vlaswinkel
a032678f24
Add commands for recording of scenario
...
This will add the commands and the implementation in the
`MockGitHubApiServer` for the recording of a scenario.
2022-10-19 17:22:36 +02:00
Koen Vlaswinkel
dcac6f56da
Add scenario recorder
...
This adds a new class which will setup the MSW server to record requests,
save them to memory and save them to files when calling a separate save
method.
2022-10-19 17:22:36 +02:00
Shati Patel
57ee00efd0
Merge pull request #1631 from github/shati-patel/storage-dir
...
Get `variantAnalysisStoragePath` from the variant analysis manager + create `timestamp` file
2022-10-19 16:17:54 +01:00
Koen Vlaswinkel
4bc799246f
Merge pull request #1619 from github/koesie10/vscode-light-theme
...
Add VSCode light theme to Storybook
2022-10-19 17:15:03 +02:00
Charis Kyriakou
6a7856052c
Add mock GitHub API config listener ( #1632 )
2022-10-19 15:01:29 +00:00
Koen Vlaswinkel
fe31730dd1
Merge pull request #1633 from github/koesie10/add-missing-mock-type
...
Add missing request type for mock GitHub API
2022-10-19 16:59:38 +02:00
shati-patel
cc74533267
Increase timeout so tests are less flaky
2022-10-19 15:40:13 +01:00
Elena Tanasoiu
1a219af821
Update all history items that are connected to the same variant analysis
2022-10-19 15:33:03 +01:00
shati-patel
43de90f03d
Pass variantAnalysisStorageLocation to the results manager
2022-10-19 15:26:16 +01:00
Koen Vlaswinkel
9624858335
Add missing request type for mock GitHub API
...
We were still missing the `SubmitVariantAnalysisRequest` type and a type
to represent the union of all request types. This adds both of them.
2022-10-19 16:25:32 +02:00
Elena Tanasoiu
3d4cdb69b1
Check variant analysis id instead of history item ID
...
Since have no way to find the query item via the historyItemId.
2022-10-19 14:49:30 +01:00
shati-patel
6b7ebf543c
Create timestamp inside onVariantAnalysisSubmitted
2022-10-19 14:43:02 +01:00
Charis Kyriakou
7e8782723d
Add mock GitHub API server setting ( #1630 )
2022-10-19 13:23:39 +00:00
shati-patel
55fb0b7078
Create timestamp file in variant analysis storage directory
2022-10-19 13:12:20 +01:00
Asger F
45b6288363
Reveal panel on navigate, to prevent webview destruction
2022-10-19 14:09:38 +02:00
Charis Kyriakou
424520613e
Initial setup around GitHub API mock server ( #1629 )
2022-10-19 12:05:28 +00:00
shati-patel
304a96cb25
Expose variant analysis storage location in variant analysis manager
2022-10-19 13:05:25 +01:00
Elena Tanasoiu
32dbc87049
Also store variantAnalysis on the query history item
...
Since this is expected in the `VariantAnalysisQueryHistoryItem` type,
let's also store the variant analysis object.
2022-10-19 12:19:45 +01:00
Charis Kyriakou
baf1b70460
Add GitHub API requests that will be mocked ( #1626 )
2022-10-19 11:38:41 +01:00
Koen Vlaswinkel
a254ceaa59
Create Storybook add-on for switching VSCode themes
...
This adds a Storybook add-on that allows you to switch between VSCode
theme. It follows the pattern of the [outline](https://github.com/storybookjs/storybook/tree/v6.5.12/addons/outline/src )
and [backgrounds](https://github.com/storybookjs/storybook/tree/v6.5.12/addons/backgrounds )
add-ons.
Unfortunately, it doesn't apply the CSS to just the elements it should
be applied to, but globally to the complete preview. This is a limitation
of using CSS files rather than setting inline styles on the elements. We
might be able to resolve this in the future by extracting the CSS
variables from the CSS files, but this is somewhat more involved.
2022-10-19 11:01:25 +02:00
Elena Tanasoiu
7fd5999ead
QueryHistory: Consume event when variant analysis status is updated
...
Update the state of a query history item when the status of the variant analysis has changed.
2022-10-19 09:18:15 +01:00
Andrew Eisenberg
c85ef15d9e
Test cleanups
...
- Avoid Installing `xvfb` since it is already available.
- Ensure `supportsNewQueryServer()` takes the CLI version into account
- Always run the new query server tests on v2.11.1 and later
- Avoid printing directory contents in `run-remote-query-tests`
- Run tests with `--disable-workspace-trust` to avoid a non-fatal error
being thrown from the dialog service.
- Ensure the exit code of the extension host while running integration
tests is the exit code of the actual process. Otherwise, there is
a possibility that an error exit code is swallowed up and ignored.
- Remove a duplicate unhandledRejection handler.
- Handle Exit code 7 from windows. This appears to be a failure on
exiting and unrelated to the tests.
- Fix handling of configuration in tests:
1. It is not possible to update a configuration setting for internal
settings like `codeql.canary`.
2. On windows CI, updating configuration after global teardown. So,
on tests avoid resetting test configuration when tests are over.
Also, I tried to remove all those pesky errors in the logs like:
> [2094:1017/235357.424002:ERROR:bus.cc(398)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
I was following advice from here, but I can't get it working.
- https://github.com/microsoft/vscode-test/issues/127
- https://github.com/electron/electron/issues/31981
2022-10-18 16:25:35 -07:00
shati-patel
986749b40f
Open query text as a .ql file
...
This fixes a minor bug (introduced in https://github.com/github/vscode-codeql/pull/1115/files#diff-cf43a74569f5e6eea483a9178f5de8fc372f8ca652017d3f1451dd2640876874L603 ) where we accidentally removed the `.ql` file extension. I've hard-coded it here, and tested it works for the local, remote, and variant-analysis cases.
2022-10-18 17:10:08 +01:00
shati-patel
9c2821a418
Unit tests for getQueryText
2022-10-18 17:10:08 +01:00
shati-patel
93a6f50c0e
Create query history items at start of test
2022-10-18 17:10:08 +01:00
shati-patel
0413b01990
Implement getQueryText for variant analysis items
...
Also moved this to the `query-history-info` helper file
2022-10-18 17:10:08 +01:00
Koen Vlaswinkel
157a5d6afd
Add VSCode light theme to Storybook
...
This adds a documented way to change the theme in Storybook from the
VSCode Dark+ theme to the VSCode Light+ theme. It requires multiple
changes to two files, but these are all quite simple and it has been
documented on the "Overview" page.
2022-10-18 16:25:53 +02:00
Shati Patel
6b27a4209a
Merge pull request #1614 from github/shati-patel/query-history-get-id
...
Get query ID for query history items (incl `VariantAnalysisHistoryItem`)
2022-10-18 12:40:04 +01:00
shati-patel
1bb68d65f9
Merge branch 'main' into shati-patel/query-history-get-id
2022-10-18 11:59:22 +01:00
shati-patel
fd13c35b5d
Rename queryId -> historyItemId
2022-10-18 11:58:55 +01:00
shati-patel
77deea77fc
Rename: queryId -> historyItemId
2022-10-18 11:39:16 +01:00
shati-patel
2eaa923019
Rename function: getQueryId -> getQueryHistoryItemId
2022-10-18 11:31:46 +01:00
shati-patel
ad9b46e494
Use a generated queryId on VariantAnalysisHistoryItem
2022-10-18 11:29:17 +01:00
Elena Tanasoiu
fa4766fe91
Merge pull request #1599 from github/elenatanasoiu/add-batching-to-download-take-two
...
Download variant analysis results in batches - take two
2022-10-18 10:32:18 +01:00
Shati Patel
28eb9ead01
Merge pull request #1606 from github/shati-patel/query-history-info-tests
...
Add unit tests for `query-history-info`
2022-10-18 10:17:33 +01:00
Shati Patel
0013a0f1b2
Clean-up: Remove unsupported CLI version from testing matrix
...
We officially only support the previous 4 minor versions of the CLI, so v2.6.3 can go.
2022-10-18 09:50:13 +01:00
Elena Tanasoiu
25b71e8651
Merge branch 'main' into elenatanasoiu/add-batching-to-download-take-two
2022-10-17 16:20:31 +01:00
Elena Tanasoiu
31a97897c8
Use fewer async/awaits
2022-10-17 16:13:46 +01:00
Elena Tanasoiu
bf7509e3df
Add test to check results are being downloaded
...
Previously we were only checking whether we're triggering the download
command in the extension.
Now we're mocking `autoDownloadVariantAnalysisResult` on the
variantAnalysisManager and checking that it's being called for all repos
that have available results.
2022-10-17 15:58:01 +01:00
Charis Kyriakou
4fd9b54c58
Remove debug log entry ( #1616 )
2022-10-17 14:52:26 +00:00
Elena Tanasoiu
7d2bae1f1b
Remove extra parentheses
2022-10-17 14:55:09 +01:00
Elena Tanasoiu
1f4e1f27ae
Make queue private and one-line initiatialization for it
2022-10-17 14:51:06 +01:00
Elena Tanasoiu
3a1800319a
Move guts for adding task to a queue into a method
...
So that the extension command doesn't need to know how to push to a queue.
2022-10-17 14:51:06 +01:00
Elena Tanasoiu
f2fe1063d9
Rename maxConcurrentTasks to maxConcurrentDownloads
2022-10-17 14:51:06 +01:00
Elena Tanasoiu
7e1b35eae4
Don't use Promise.all
...
Since we're only adding one task at a time.
2022-10-17 14:51:05 +01:00
Elena Tanasoiu
3283b68ff9
Download results in batches
...
This makes use of the p-queue package to download our variant analysis
results in batches of 3 at a time.
2022-10-17 14:51:05 +01:00
Elena Tanasoiu
aaf21d35f6
Install p-queue
2022-10-17 14:51:05 +01:00
Elena Tanasoiu
67a6ab5c8e
Test that we only download results once per repo
...
To make us confident that we're not repeatedly downloading results.
2022-10-17 14:51:05 +01:00
Elena Tanasoiu
64994d7c03
Extract downloadVariantAnalysisResults method
...
In the next commit we'll start changing this method to support batching.
2022-10-17 14:51:05 +01:00
Elena Tanasoiu
362094b8de
Extract getReposToDownload method
2022-10-17 14:51:04 +01:00
Elena Tanasoiu
e791e77ef9
Extract shouldDownload method
2022-10-17 14:51:04 +01:00
Elena Tanasoiu
0009114f7b
Extract scheduleForDownload method
...
Before we make any changes, let's extract some of the monitor code into
smaller methods.
Since we have test coverage, we're able to do this quite comfortably.
2022-10-17 14:51:04 +01:00
aeisenberg
3b644fea7b
Bump version to v1.7.3
2022-10-17 10:03:25 +01:00
shati-patel
04c9f17398
Get query ID for query history items (incl VariantAnalysisHistoryItem)
2022-10-17 09:53:34 +01:00
shati-patel
60e9f552db
Add unit tests for query-history-info
2022-10-17 09:51:56 +01:00
Dave Bartolomeo
38caad032b
Merge pull request #1604 from github/dbartol/join-order-threshold
...
Make bad join order warning threshold configurable
2022-10-14 18:20:42 -04:00
Andrew Eisenberg
7c1a8b3bc9
Merge pull request #1612 from github/revert-1586-koesie10/upgrade-vscode-test
...
Revert "Upgrade from vscode-test to @vscode/test-electron"
2022-10-14 14:50:51 -07:00
Andrew Eisenberg
c7c709b366
Revert "Upgrade from vscode-test to @vscode/test-electron"
2022-10-14 14:15:18 -07:00
Andrew Eisenberg
bf662354fe
Merge pull request #1609 from github/v1.7.2
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.7.2
2022-10-14 12:55:51 -07:00
Dave Bartolomeo
131e72b162
Decouple join-order.ts from VS Code for testing purposes
2022-10-14 15:32:03 -04:00
Dave Bartolomeo
4b875e7e42
Merge remote-tracking branch 'origin/main' into dbartol/join-order-threshold
2022-10-14 15:01:41 -04:00
Andrew Eisenberg
6ea36867a2
v1.7.2
2022-10-14 10:44:07 -07:00
Andrew Eisenberg
8df061f443
Merge pull request #1607 from github/aeisenberg/fix-failing-tests
...
`loadPersistedState` should happen outside of dbm constructor
2022-10-14 10:13:10 -07:00
Andrew Eisenberg
0885a22984
loadPersistedState should happen outside of dbm constructor
...
Also, add stub to logger in tests.
This fixes some occasionally failing tests on main.
2022-10-14 09:29:47 -07:00
Andrew Eisenberg
0354b1caac
Merge pull request #1605 from github/aeisenberg/fix-missing-success
...
Fix deserialization error
2022-10-14 08:29:37 -07:00
Koen Vlaswinkel
d32a3a0deb
Merge pull request #1601 from github/koesie10/completed-status
...
Add display of duration and completion status
2022-10-14 17:25:10 +02:00
shati-patel
e41dba7627
Move createMockRemoteQueryHistoryItem into shared location
2022-10-14 16:14:22 +01:00
shati-patel
b2f4fecfb4
Move createMockLocalQueryInfo into shared location
2022-10-14 16:14:22 +01:00
Koen Vlaswinkel
21b6adb92c
Merge pull request #1575 from github/koesie10/reset-config
...
Reset VSCode configuration between tests
2022-10-14 16:52:46 +02:00
Andrew Eisenberg
90577f516f
Update changelog
2022-10-14 07:42:11 -07:00
Andrew Eisenberg
a2825162ac
Fix deserialization error
...
We added a `successful` property to serialized local queries. But, this
property does not exist on older serialized queries. This change ensures
older queries get a `successful` property when deserialized.
2022-10-14 07:39:02 -07:00
Dave Bartolomeo
9b0d4bd7b8
Make bad join order warning threshold configurable
...
The threshold at which the bad join order detection reports a warning was previously hard-coded to 50. Initial feedback from internal QL developers suggests that this is too high, and should be configurable in any case. I've made it configurable via the `codeQL.logInsights.joinOrderWarningThreshold` setting, leaving the default at 50. Once we get more feedback about what a better default value is, I'll update the default.
2022-10-14 10:36:58 -04:00
Koen Vlaswinkel
2e26b857f4
Add tests for missing duration
2022-10-14 16:18:07 +02:00
Shati Patel
7bdd452d63
Merge pull request #1600 from github/shati-patel/query-history-info
...
Move `QueryHistoryInfo` type to separate file
2022-10-14 13:12:11 +01:00
shati-patel
be9a7a35bc
Address review comments
...
- Change function name
- Fix import
2022-10-14 12:36:16 +01:00
Koen Vlaswinkel
dd8600fcc6
Fix processor test
2022-10-14 13:16:59 +02:00
Koen Vlaswinkel
cc8f304f96
Add tests for duration calculation
...
This adds tests for the duration calculation and moves it down a
component to make this easier. Adding tests for the
`VariantAnalysisHeader` would require constructing a complete variant
analysis object, while this is now just a simple unit test.
2022-10-14 13:04:51 +02:00
Koen Vlaswinkel
1ca623f68a
Add display of duration and completion status
...
This will use the new fields on the API to display the duration and
completion status of a variant analysis.
2022-10-14 12:11:54 +02:00
Koen Vlaswinkel
53c404b131
Add new date fields from API to variant analysis types
...
This will add some new date fields that have been added in the API to
the variant analysis types and factories. They are stored as strings
since storing them as `Date` would make the types inconsistent if they
are serialized to JSON (`JSON.stringify` -> `JSON.parse` would result
in strings rather than dates).
2022-10-14 12:11:54 +02:00
Koen Vlaswinkel
f8d5fd8f6e
Merge pull request #1586 from github/koesie10/upgrade-vscode-test
...
Upgrade from vscode-test to @vscode/test-electron
2022-10-14 11:54:22 +02:00
shati-patel
d49c2d7958
Add getRawName helper function to query-history-info
2022-10-14 10:43:57 +01:00
shati-patel
01d7329bc3
Move QueryHistoryInfo to separate file
2022-10-14 10:43:56 +01:00
github-actions[bot]
e8d230c8f5
Bump version to v1.7.2 ( #1592 )
...
Co-authored-by: aeisenberg <aeisenberg@users.noreply.github.com >
2022-10-14 09:36:00 +00:00
Charis Kyriakou
44a3e6b557
Subscribe to new variant analyses events in query history ( #1598 )
2022-10-14 09:25:03 +00:00
Shati Patel
8b2a3b18ce
Query history: Add new VariantAnalysisHistoryItem type ( #1590 )
2022-10-14 10:04:56 +01:00
Charis Kyriakou
fad5bb31a0
Only show file name (not full path) in query details ( #1595 )
2022-10-13 13:21:31 +00:00
Shati Patel
484b7668cb
Typo fixes in query history methods/properties ( #1594 )
2022-10-13 12:10:57 +01:00
Koen Vlaswinkel
33dd50ca4d
Merge pull request #1588 from github/koesie10/open-query-text
...
Add ability to open the query text
2022-10-13 12:01:54 +02:00
Koen Vlaswinkel
195cd69567
Improve variant analysis query text error messages
...
Co-authored-by: Robert Brignull <robertbrignull@github.com >
2022-10-13 11:10:19 +02:00
Koen Vlaswinkel
268199e9e2
Rename queryText to text
...
The `text` property is already nested under `query`, so it's redundant
to prefix it with `query`. This also makes it consistent with the other
properties.
2022-10-13 10:24:27 +02:00
Dave Bartolomeo
6cef629507
Merge pull request #1591 from github/v1.7.1
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
Release prep v1.7.1
2022-10-12 14:29:02 -04:00
Andrew Eisenberg
563489d1e0
Release prep v1.7.1
...
- Add missing changelog entry
- Update .nvmrc and workflow node versions to align with vscode's
node version.
2022-10-12 10:56:30 -07:00
Andrew Eisenberg
ebfcce30ba
Merge pull request #1589 from github/aeisenberg/load-database-logging
...
Add better logging while loading databases
2022-10-12 10:41:21 -07:00
Shati Patel
159d900edb
Add start time to VariantAnalysis type ( #1587 )
2022-10-12 16:56:09 +01:00
Andrew Eisenberg
46233b9355
Add better logging while loading databases
2022-10-12 08:15:22 -07:00
Koen Vlaswinkel
1d6a7f8df1
Open query text when clicking on view query
...
This will implement the final step of opening the query text. Inside
the webview, this will send the message to the extension host to open
the query text.
2022-10-12 17:05:23 +02:00
Koen Vlaswinkel
e380c78876
Add openQueryText message
...
This will allow the webview to send a `openQueryText` message, which
will open a virtual file to show the query text.
2022-10-12 17:05:23 +02:00
Koen Vlaswinkel
cd67ce9242
Add text document content provider for variant analysis
...
This will add a new text document content provider for showing variant
analyses. This is separate from the remote queries content provider
to allow this to evolve separately. It also retrieves the query text
from the manager rather than passing the text directly to prevent the
webview from opening a tab with arbitrary content.
See: 4c527a3573/extensions/ql-vscode/src/extension.ts (L1242-L1257)
2022-10-12 17:05:23 +02:00
Koen Vlaswinkel
cd8d82daac
Add query text to variant analysis submission
...
This will add a new query text field to the variant analysis submission,
which will also propagate to the variant analysis itself. This will
allow us to show the query text on the variant analysis page.
2022-10-12 17:05:23 +02:00
Koen Vlaswinkel
726feb19e1
Register all settings as test setting automatically
...
This will register all settings for which a `Setting` instance is
created as settings which will be reset. This should make it less
error-prone to change settings in tests.
2022-10-12 16:30:38 +02:00
Koen Vlaswinkel
8c324a3263
Merge pull request #1577 from github/koesie10/open-existing-variant-analysis
...
Add command for opening existing variant analysis
2022-10-12 16:03:13 +02:00
Shati Patel
119649144e
Emit "update" events while variant analysis is being monitored ( #1579 )
2022-10-12 15:00:18 +01:00
Koen Vlaswinkel
4c527a3573
Merge pull request #1585 from github/koesie10/open-query-file
...
Add ability to open the query file
2022-10-12 15:41:43 +02:00
Koen Vlaswinkel
525f5234b6
Upgrade from vscode-test to @vscode/test-electron
...
The `vscode-test` package was renamed to `@vscode/test-electron` in
December of last year. This commit updates the extension to use the new
package name.
The reason for this change is that the `vscode-test` package was
somewhat flaky in actually starting VSCode to run the tests from the
command line. The new package also has some bugfixes and other
improvements which would normally have been part of a new version of the
`vscode-test` package.
2022-10-12 15:12:17 +02:00
Koen Vlaswinkel
908abb4413
Merge pull request #1574 from github/koesie10/view-loaded-message
...
Handle `viewLoaded` message
2022-10-12 13:49:48 +02:00
Koen Vlaswinkel
a69ec03c6e
Add ability to open the query file
...
This makes it possible to open the query file in the editor when
clicking on the query filename.
This is a slightly different implementation from the remote queries
implementation. The remote queries implementation will send the file
path to open to the extension host, and the extension host will simply
open the given file path. If someone is able to inject JavaScript into
the webview, this would allow them to open an arbitrary file in VSCode.
By moving the file path logic to the extension host, we can ensure that
we only allow opening the actual query file.
2022-10-12 13:46:37 +02:00
Andrew Eisenberg
a071470c5a
QueryServer: Add support for new query-server ( #1508 )
...
* QueryServer: Add support for new query-server
* Add a new canary flag to enable new query server support
* Add evaluation results to query object
Ensures better backwards compatibility with legacy query objects.
* Fix query server command name
* Add log message for new query server
* Use only legacy results
Co-authored-by: alexet <alexet@semmle.com >
2022-10-12 12:19:19 +01:00
Koen Vlaswinkel
2ae95144a5
Show notification to user when loading varaint analysis fails
2022-10-12 12:47:32 +02:00
Koen Vlaswinkel
60faed1ccc
Merge remote-tracking branch 'origin/main' into koesie10/view-loaded-message
2022-10-12 10:41:18 +02:00
Koen Vlaswinkel
6e6ea76c97
Rename settingState to initialSettingState
2022-10-12 10:40:08 +02:00
Robert
d30eb27320
Move inspect to config.ts to reduce duplication of knowledge
2022-10-12 10:39:23 +02:00
Angela P Wen
2104cb3d09
Bump CLI version to 2.11.1 for integration tests ( #1583 )
2022-10-11 14:01:06 -07:00
Henry Mercer
5644206777
Merge pull request #1581 from github/henrymercer/update-codeowners
...
Update CODEOWNERS
2022-10-11 16:48:39 +01:00
Koen Vlaswinkel
a6a0ee5f50
Merge pull request #1580 from github/koesie10/views-deps
...
Fix missing dependencies and cleanup of addEventListener
2022-10-11 17:14:15 +02:00
Henry Mercer
74c1e583b4
Update CODEOWNERS
...
With this change, secexp will own all folders named `remote-queries` or `variant-analysis`.
2022-10-11 16:04:27 +01:00
Koen Vlaswinkel
326653e25a
Fix missing dependencies and cleanup of addEventListener
...
This will implement ebba9949a8
and d18e3dd40e
for the `Compare` and `RemoteQueries` views. These should not be
impacted in the same way as the `VariantAnalysis` view, but this will
make them consistent and more resilient to future changes.
2022-10-11 17:01:02 +02:00
Koen Vlaswinkel
0d057aed3f
Merge pull request #1578 from github/koesie10/mrva-performance
...
Fix freezing of live results view
2022-10-11 16:48:49 +02:00
Koen Vlaswinkel
c90eede573
Merge pull request #1572 from github/koesie10/request-repo-results-message
...
Implement `requestRepoResults` message
2022-10-11 16:48:34 +02:00
Koen Vlaswinkel
ebba9949a8
Add cleanup function to registering the message listener
...
This cleanup function would never be called in normal operation, but if
we do decide to add a dependency to this `useEffect`, this will ensure
that only one listener is registered at a time.
2022-10-11 16:26:42 +02:00
Koen Vlaswinkel
d18e3dd40e
Fix performance of variant analysis view
...
When the variant analysis view was being rerendered, we were also
reregistering the message listeners, while not deregistering the old
ones. This resulted in a loop of message listeners being registered,
and the variant analysis being rerendered every time a message was
received by one of the listeners. This will ensure that the listener
is only registered once to prevent this from happening.
2022-10-11 16:24:20 +02:00
Koen Vlaswinkel
9355f0633a
Run monitorVariantAnalysis on a completed variant analysis
...
The `monitorVariantAnalysis` command will send the repository states and
finish off any downloads. Without this, the view not will not load
properly.
2022-10-11 16:22:20 +02:00
Koen Vlaswinkel
f553523f73
Add command for opening existing variant analysis
...
To make debugging the view easier and prevent needing to run a variant
analysis for each change, this will add a simple command which opens a
variant analysis by its ID. This it not intended to be visible to users
at any point.
2022-10-11 12:02:46 +02:00
Koen Vlaswinkel
627bb59bd5
Merge remote-tracking branch 'origin/koesie10/request-repo-results-message' into koesie10/view-loaded-message
2022-10-11 11:11:39 +02:00
Koen Vlaswinkel
95cbe02768
Use unzipped file path for loading results
2022-10-11 11:10:45 +02:00
Asger F
d08e005b46
When stepping up or down, collapse the previous node
2022-10-11 11:09:45 +02:00
Koen Vlaswinkel
e73a6874b2
Merge remote-tracking branch 'origin/main' into koesie10/request-repo-results-message
2022-10-11 11:08:49 +02:00
Elena Tanasoiu
dc6ae6cc39
Merge pull request #1576 from github/elenatanasoiu/unzip
...
Make download method handle zip files
2022-10-11 09:13:18 +01:00
Elena Tanasoiu
3902596823
Use real zip file for VariantAnalysisManager download tests
...
Now that we're unzipping results, we also have to use something closer
to a zip file when testing download functionality for the
`variantAnalysisManager`.
The `variantAnalysisManager` has access to the
`variantAnalysisResultsManager` so we could've stubbed the result
manager's `download` method instead of going as far as using a zip
fixture.
However, since the results manager is private it seems bad to make it
public in order to stub one of its methods.
So using realistic data in the setup seems like a good compromise.
2022-10-10 23:40:28 +01:00
Elena Tanasoiu
c400485a4e
Delete duplicate test
...
This checks the same thing as the test before it.
2022-10-10 23:40:28 +01:00
Elena Tanasoiu
1a7ddcf843
Make download method handle zip files
...
This will:
- download a zip file as an ArrayBuffer
- save the file as `results.zip`
- unzip the contents into a `results/` folder
For the tests:
- In order to check whether we're saving the correct files in the tests,
we've had to make the `getRepoStorageDirectory` method public.
Unfortunately the temporary file path generated for tests is random so
we're not able to hardcode it.
- Now that we have a real zip file to use in our tests, we're first
converting this file into an ArrayBuffer, then stubbing the API to
return it. We then check that it's saved and unzipped correctly.
2022-10-10 23:38:48 +01:00
Elena Tanasoiu
7cef45c434
Use real zip file in our download tests
...
This matches what type of file we'd expect in real life: a zip file
containing a sarif file.
We've copied an example `results.sarif` file from other tests in the
`no-workspace` folder.
2022-10-10 23:38:21 +01:00
Elena Tanasoiu
69b06ae95c
Make getVariantAnalysisRepoResult return the correct type
...
We expect this method to return a zip file which can be typed to an
`ArrayBuffer`. In the following commits we'll read this buffer and save it
as a zip file.
2022-10-10 23:07:04 +01:00
Koen Vlaswinkel
ae2bd81215
Use new test config for testings currently writing to the config
2022-10-10 15:41:52 +02:00
Koen Vlaswinkel
b9be9cff9f
Add new class and helper for setting test config values
...
This class will be used to set test config values for the tests. It is
able to set the config value to a specified value for every test and
restore the value to the original value after the test.
2022-10-10 15:40:42 +02:00
Asger F
4871728216
Added change note
2022-10-10 15:36:36 +02:00
Koen Vlaswinkel
8c5d73bd76
Simplify tests index-template
...
Instead of using the `glob` library and a custom promise, this will use
`glob-promise` which is used by other parts of the codebase already.
This reduces the amount of code which manually needs to call `reject`
and makes it easier to read.
2022-10-10 15:30:31 +02:00
Koen Vlaswinkel
81b53c9c19
Merge pull request #1573 from github/koesie10/real-cancellation-token
...
Use real `CancellationTokenSource` in tests
2022-10-10 09:15:20 +02:00
Elena Tanasoiu
a232b56bcd
Merge pull request #1566 from github/shati-elena/query-history-analysis-added
...
Emit `variantAnalysisAdded` event
2022-10-07 17:32:35 +01:00
Elena Tanasoiu
c26d786a1c
Emit variantAnalysisAdded event
...
When we first submit the variant analysis for processing, we'd like to update
the query history panel.
At the moment we're just adding the setup for triggering the event. In a future
PR we'll consume this event and change the query history panel accordingly.
In order for this to happen we will need to introduce a new `VariantAnalysisHistoryItem`
type which will massage the data we get from the API into a type which the Query
History panel can consume.
Co-authored-by: Shati Patel <shati-patel@github.com >
2022-10-07 17:08:39 +01:00
Asger F
f759eed0f5
Remove unsed parts of result-keys.ts
2022-10-07 16:26:56 +02:00
Koen Vlaswinkel
99d2df2067
Remove mock variant analysis view
...
The mock variant analysis view would only show the loading message. This
completely removes it since it does not provide value anymore.
2022-10-07 15:07:06 +02:00
Koen Vlaswinkel
866b137fd4
Remove default values from VariantAnalysis component
...
The `VariantAnalysis` component will now only receive values from the
`VariantAnalysisView`. We still allow setting defaults to support
Storybook.
2022-10-07 15:02:34 +02:00
Koen Vlaswinkel
76a00e5fa5
Send variant analysis on viewLoaded message
...
When the `viewLoaded` message is received by the view, it will now
retrieve the variant analysis from the manager and send it to the
view. This will allow the view to display the variant analysis.
2022-10-07 14:57:38 +02:00
Koen Vlaswinkel
f0d71ba356
Use real CancellationTokenSource in tests
...
This will change tests that are using a mocked `CancellationTokenSource`
to use a real `CancellationTokenSource` instead. Tests are run inside
VSCode, so we can use these without mocking.
2022-10-07 14:30:48 +02:00
Koen Vlaswinkel
b4fbfb6d2b
Merge pull request #1570 from github/koesie10/variant-analysis-results-manager
...
Add variant analysis results manager
2022-10-07 14:08:03 +02:00
Koen Vlaswinkel
1d02c19854
Add tests for RepoRow expansion
2022-10-07 14:00:46 +02:00
Koen Vlaswinkel
3167ceec91
Send message to webview when results are loaded
2022-10-07 12:32:15 +02:00
Koen Vlaswinkel
fba49020e3
Send message to load results when expanding a repo item
2022-10-07 12:31:41 +02:00
Koen Vlaswinkel
dea36820e4
Add command to load results
...
This adds a new VSCode command which can be used to load results.
2022-10-07 12:30:55 +02:00
Koen Vlaswinkel
60df319754
Save repo task object to storage
...
To create the interpreted and raw results from the SARIF/BQRS files, we
need some information from the repo task object. This will store the
repo task object to the filesystem as JSON so we can read them when
loading results.
2022-10-07 12:28:19 +02:00
Koen Vlaswinkel
0bdee6e77e
Switch caching/loading of results to use the full name
...
In most cases, we will not have access to the full repo task object
since this needs to be retrieved from the API. Since we are only using
the full name from the repo task object, we can just use the full name
instead.
2022-10-07 12:24:51 +02:00
Koen Vlaswinkel
88440ba148
Store variant analyses in manager
...
This will store all variant analysis that are run in the manager. Right
now, it only stores the variant analyses in memory. In the future, these
will be loaded from the query history and can be restored after a
restart.
2022-10-07 12:21:57 +02:00
Koen Vlaswinkel
a0fb3b47c8
Merge remote-tracking branch 'origin/main' into koesie10/variant-analysis-results-manager
2022-10-07 11:36:17 +02:00
Koen Vlaswinkel
86d10b439b
Merge pull request #1550 from github/koesie10/restore-mrva-on-restart
...
Restore variant analysis view on restart of VSCode
2022-10-07 11:29:18 +02:00
Asger F
5a694653d7
Rename command IDs.
...
We register a handler for the old command ID, but do not mention it in package.json.
This seems to be backward compatible without polluting the command palette.
2022-10-07 10:35:41 +02:00
Koen Vlaswinkel
902c489979
Use nullish coalescing operator for loading results
2022-10-07 10:28:13 +02:00
Asger F
0f6100cc42
Bugfix in getPathNode
2022-10-07 09:22:07 +02:00
Koen Vlaswinkel
7fed5baebc
Merge remote-tracking branch 'origin/main' into koesie10/restore-mrva-on-restart
2022-10-06 18:30:24 +02:00
dependabot[bot]
d3e961ffb3
Bump @primer/octicons-react in /extensions/ql-vscode ( #1569 )
...
Bumps [@primer/octicons-react](https://github.com/primer/octicons ) from 16.3.0 to 17.6.0.
- [Release notes](https://github.com/primer/octicons/releases )
- [Changelog](https://github.com/primer/octicons/blob/main/CHANGELOG.md )
- [Commits](https://github.com/primer/octicons/compare/v16.3.0...v17.6.0 )
---
updated-dependencies:
- dependency-name: "@primer/octicons-react"
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-06 08:29:04 -07:00
Koen Vlaswinkel
a20d9102e6
Add variant analysis results manager
...
This adds a new variant analysis results manager which is responsible
for downloading and loading variant analysis results to/from the
filesystem. It is essentially the `AnalysesResultsManager` modified to
suit the variant analysis results.
2022-10-06 15:13:52 +02:00
Asger F
88bfd19c91
Switch commands to up/down/left/right semantics
2022-10-06 15:06:08 +02:00
Koen Vlaswinkel
131d252a8b
Merge pull request #1567 from github/koesie10/set-repo-results-message
...
Implement message for setting download status
2022-10-06 10:43:46 +02:00
Asger F
125f63887a
Make raw result view respond to navigation events
2022-10-05 22:57:32 +02:00
Asger F
20dea5ea46
Also show selection in raw result view
2022-10-05 22:57:32 +02:00
Asger F
3c4682e556
Ensure nodes are expanded
2022-10-05 22:57:32 +02:00
Asger F
bb61b5ea25
Replace the expansion index with the result key
2022-10-05 22:57:29 +02:00
Asger F
2949fc33d1
Replace 'expanded' with a Set<number>
2022-10-05 22:56:58 +02:00
Asger F
ab933fcb81
Add 'show next/previous alert' commands
2022-10-05 22:56:26 +02:00
Koen Vlaswinkel
90023137ca
Merge pull request #1562 from github/koesie10/set-variant-analysis-message
...
Implement `setVariantAnalysis` message
2022-10-05 16:20:32 +02:00
Koen Vlaswinkel
fcecfa112e
Merge remote-tracking branch 'origin/main' into koesie10/restore-mrva-on-restart
2022-10-05 13:01:24 +02:00
Koen Vlaswinkel
303a7d1662
Show loading icon when downloading repo results
2022-10-05 12:58:28 +02:00
Koen Vlaswinkel
7c935b37b0
Receive setRepoStates message in webview
2022-10-05 12:58:28 +02:00
Koen Vlaswinkel
339fc9a755
Post setRepoStates message when downloading
2022-10-05 12:58:28 +02:00
Koen Vlaswinkel
4138ca1085
Receive setRepoResults message in React component
2022-10-05 12:58:28 +02:00
Koen Vlaswinkel
6941584214
Add variant analysis view to disposables of manager
2022-10-05 12:53:05 +02:00
Koen Vlaswinkel
525d7f5f3d
Receive setVariantAnalysis message in React component
...
This will store the variant analysis in the React state and replace it
when the `setVariantAnalysis` message is received.
2022-10-05 12:53:05 +02:00
Koen Vlaswinkel
84621b7ecc
Fix variant analysis monitor failing
...
All fields in the variant analysis skipped repositories are optional,
but this was not properly defined in the API types. This will correct
the types and the functions processing the data such that they handle
non-existing fields.
2022-10-05 12:53:05 +02:00
Koen Vlaswinkel
2baa53a149
Post message to view when variant analysis is updated
2022-10-05 12:53:05 +02:00
Koen Vlaswinkel
15579012f1
Emit event when variant analysis is updated
2022-10-05 12:53:05 +02:00
Koen Vlaswinkel
28b00b249b
Update variant analysis from API response
...
This will ensure that when we return a new variant analysis summary from
the API, the variant analysis object will be updated.
2022-10-05 12:53:05 +02:00
Koen Vlaswinkel
401da636a0
Keep track of opened variant analysis views
...
To be able to send messages to the open view for a variant analysis, we
need to have a reference to the view. This is done by keeping track of
all open views in a dictionary indexed by their variant analysis ID.
We currently only allow one view per variant analysis, but do allow
multiple variant analysis views to be open at a time. In the future, we
may want to allow multiple views per variant analysis (such that e.g.
"Split right" works), but this is not supported yet.
The reason for the indirection through the interfaces is to prevent
circular dependencies between the variant analysis view and the manager.
2022-10-05 12:53:02 +02:00
Elena Tanasoiu
ab9cf465cc
Merge pull request #1559 from github/elenatanasoiu/download-variant-analysis-results
...
Download variant analysis results
2022-10-05 11:43:05 +01:00
Elena Tanasoiu
bb7246b612
Pass in variant analysis summary to autodownload command
...
This was missed in 4f84376faa
2022-10-04 18:09:02 +01:00
Elena Tanasoiu
b82cd8b6f4
Use real cancellation token match VSCode behaviour
2022-10-04 18:08:50 +01:00
Elena Tanasoiu
f56f017a84
Generate ids using faker for test factories
2022-10-04 17:07:15 +01:00
Elena Tanasoiu
7dc5eebcc1
Generate a real NotFoundRepoGroup
...
This won't have an `id` field. We initially generated this the same
way we did for all other skipped repos, but this one is special because
it's only providing the fullName field, while the others also provide
`id` and `private`.
2022-10-04 16:36:00 +01:00
Elena Tanasoiu
644a83d6d8
Only use safe navigator for optional fields
2022-10-04 16:35:59 +01:00
Elena Tanasoiu
4f84376faa
Make monitor trigger autodownload of result when a new repo is scanned
...
This introduces a new `autoDownloadVariantAnalysisResult` command which
will be called by the VariantAnalysisMonitor every time it detects a new
repo has been scanned.
In turn, this will use the `autoDownloadVariantAnalysisResult` method
which we defined in an earlier commit on the VariantAnalysisManager.
2022-10-04 16:35:59 +01:00
Elena Tanasoiu
5e76c08f84
Only import what we need from vscode in VariantAnalysisMonitor
...
In the next commit, we'll also import `commands`.
2022-10-04 16:35:59 +01:00
Elena Tanasoiu
765c956481
Introduce download method on VariantAnalysisManager
...
This method will be called from the VariantAnalysisMonitor once
a new repo has been scanned.
It will then perform an API request to get the repo task for it,
which will contain an `artifact_url`.
Finally it will use the API method we introduced in the previous commit
to download the result for the repo and then save it on disk.
2022-10-04 16:35:59 +01:00
Elena Tanasoiu
deac8c8c02
Add API method for download scanned repo result
...
This will download the result for a particular repo by making a call
to the download URL via octokit.
2022-10-04 16:35:59 +01:00
Elena Tanasoiu
a47031b0d5
Call monitor from new VariantAnalysisManager class
2022-10-04 16:35:59 +01:00
Elena Tanasoiu
3bf27b3472
Set up factories for VSCode VariantAnalysis
...
In a previous PR [1] we introduced factories for generating variant analyses
(and their associated objects) that were returned from the API.
Let's also introduce factories for generating their VSCode equivalent.
We can immediately use them for generating a VariantAnalysis object for the
monitor tests.
[1]: https://github.com/github/vscode-codeql/pull/1545
2022-10-04 16:35:58 +01:00
Shati Patel
9422c6d65c
Fix running Jest unit tests from the debugger on Windows ( #1563 )
2022-10-04 13:28:49 +01:00
Koen Vlaswinkel
b81e3c7b94
Merge pull request #1560 from github/koesie10/reduce-duplication-repo-rows
...
Combine repository row components into a single component
2022-10-04 12:19:50 +02:00
Andrew Eisenberg
011eee1d16
Merge pull request #1565 from github/aeisenberg/db-folder-check
...
Use better heuristics when checking db folders
2022-10-03 14:50:57 -07:00
Andrew Eisenberg
924d24b106
Update extensions/ql-vscode/src/vscode-tests/no-workspace/helpers.test.ts
...
Co-authored-by: Angela P Wen <angelapwen@github.com >
2022-10-03 14:36:34 -07:00
Andrew Eisenberg
54ba5ced09
Use better heuristics when chekcking db folders
2022-10-03 14:07:55 -07:00
Koen Vlaswinkel
78a90ffa92
Merge pull request #1553 from github/koesie10/show-variant-analysis-view
...
Open variant analysis view after submission
2022-10-03 11:21:26 +02:00
Koen Vlaswinkel
b95ee896df
Combine repository row components into a single component
...
This is a follow-up to clean up the skipped and analyzed repository
component duplication. The rows in both tabs are very similar, so this
will combine them to use a single component.
2022-10-03 11:07:14 +02:00
Koen Vlaswinkel
d33b07b2d1
Merge branch 'main' into koesie10/show-variant-analysis-view
2022-10-03 10:06:58 +02:00
James Fletcher
3d7f303c65
Merge pull request #1558 from github/lgtm-update
...
Remove mentions of lgtm.com from README
2022-09-30 20:23:21 +01:00
Andrew Eisenberg
540d6758d1
Merge pull request #1557 from github/aeisenberg/view-column
...
Ensure results view is opened in column beside
2022-09-30 09:22:21 -07:00
Koen Vlaswinkel
b5b34743f1
Open variant analysis view after submission
...
This will open the variant analysis view after the variant analysis has
been submitted. It will also show a notification that the analysis has
been submitted, which includes the query name.
2022-09-30 17:01:12 +02:00
Robert
0a6db47b5f
Merge pull request #1549 from github/robertbrignull/skipped-repos
...
Implement skipped repositories tabs
2022-09-30 13:10:12 +01:00
James Fletcher
f679a2efec
remove lgtm.com from reaadme
2022-09-30 11:47:43 +00:00
Robert
72253a1bb8
Merge branch 'main' into robertbrignull/skipped-repos
2022-09-30 11:22:38 +01:00
Elena Tanasoiu
2065c7d75c
Merge pull request #1545 from github/elenatanasoiu/monitor-variant-analysis
...
Implement monitoring for variant analysis live results
2022-09-30 10:00:03 +01:00
Elena Tanasoiu
ff4ea3e4c8
Exit early if variant analysis completes
2022-09-30 09:41:23 +01:00
Andrew Eisenberg
9bd932294a
Ensure results view is opened in column beside
...
The results view will always open next to the current editor.
2022-09-29 13:04:28 -07:00
Andrew Eisenberg
afdc8164c8
Merge pull request #1554 from github/aeisenberg/bump-to-2.11.0-cli
...
Update tests to v2.11.0
2022-09-29 09:18:40 -07:00
dependabot[bot]
ea022f4cde
Bump @octokit/rest from 18.6.0 to 19.0.4 in /extensions/ql-vscode ( #1551 )
...
Bumps [@octokit/rest](https://github.com/octokit/rest.js ) from 18.6.0 to 19.0.4.
- [Release notes](https://github.com/octokit/rest.js/releases )
- [Commits](https://github.com/octokit/rest.js/compare/v18.6.0...v19.0.4 )
---
updated-dependencies:
- dependency-name: "@octokit/rest"
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-29 09:12:38 -07:00
Andrew Eisenberg
48ced51035
Update tests to v2.11.0
2022-09-29 07:50:43 -07:00
Koen Vlaswinkel
177688dc56
Merge pull request #1544 from github/koesie10/scanned-repos-tab
...
Add analyzed repositories component
2022-09-29 16:05:20 +02:00
Koen Vlaswinkel
c5cbf92b3a
Merge pull request #1546 from github/koesie10/refactor-raw-results-table
...
Refactor `RawResultsTable` component
2022-09-29 16:03:29 +02:00
Robert
529ceb133e
Fix text when 1 repo is shown
2022-09-29 13:02:22 +01:00
Robert
baaa3d31c0
Update codicon styling
2022-09-29 13:00:34 +01:00
Robert
9629c99ccb
Move alertTitle and alertMessage to props
2022-09-29 13:00:18 +01:00
Robert
7ade7be0c4
Use simple array type
2022-09-29 12:40:40 +01:00
Robert
4272cee01b
Rename files to end .stories.tsx
2022-09-29 12:31:53 +01:00
Koen Vlaswinkel
d8fbc56ec2
Restore variant analysis view on restart of VSCode
...
This implements persistence for the variant analysis webview, allowing
the webview panel to be restored when VSCode is restarted. It's probably
easier to add this now than to try to add it later.
The basic idea is that there are no real differences when opening the
webview for the first time. However, when VSCode is restarted it will
use the `VariantAnalysisViewSerializer` to restore the webview panel.
In our case this means recreating the `VariantAnalysisView`.
To fully test this, I've also added a mock variant analysis ID as the
state of the webview. This value is now randomly generated when calling
the `codeQL.mockVariantAnalysisView` command. This allows us to test
opening multiple webviews and that the webviews are restored with the
correct state.
See: https://code.visualstudio.com/api/extension-guides/webview#persistence
2022-09-29 13:26:56 +02:00
Elena Tanasoiu
e41b0ff779
Only check for failure reason during monitoring
...
There's no need to check for the status of variant analysis in order to
mark it as failed. The presence of a failure reason should be enough.
2022-09-29 10:29:05 +01:00
Koen Vlaswinkel
cf3ba32906
Merge pull request #1548 from github/koesie10/filter-raw-results
...
Hide repositories with raw results without rows
2022-09-29 11:08:19 +02:00
Koen Vlaswinkel
741d364a52
Simplify check for raw results
...
Co-authored-by: Robert <robertbrignull@github.com >
2022-09-29 10:18:33 +02:00
Elena Tanasoiu
49a2555dab
Only send repository ids in databases param
...
At the moment we're only able to send one of:
- repositories
- repositoryLists
- repositoryOwners
In the future, we intend to be able to send a combination of these
but at the moment the API will only ever allow you to send one.
So let's be consistent and just send `repositories` here.
2022-09-28 16:20:33 +01:00
Elena Tanasoiu
f4e6a0db9b
Remove failure_message
...
Since the API would either return a real value or skip this field.
2022-09-28 16:07:09 +01:00
Elena Tanasoiu
4e7b89864c
Declare type of status in function signature
...
Rather than casting it later in the function body.
2022-09-28 15:54:38 +01:00
Elena Tanasoiu
02443b5ddd
Add missing / to nwo names
2022-09-28 15:54:38 +01:00
Elena Tanasoiu
50b507dba5
Parse failure reason correctly
2022-09-28 15:54:38 +01:00
Elena Tanasoiu
aea5d33c42
Be verbose about expected output
2022-09-28 15:54:38 +01:00
Elena Tanasoiu
b2427a6534
Rename nwos to full_names
...
To match what we now return in the API.
2022-09-28 15:54:37 +01:00
Elena Tanasoiu
b95f6a5afb
Replace forEach & push with map
2022-09-28 15:54:27 +01:00
Koen Vlaswinkel
7b7413ba26
Merge pull request #1547 from github/koesie10/fix-remote-query-run
...
Fix not being able to run variant analyses
2022-09-28 13:35:53 +02:00
Koen Vlaswinkel
d33fa5df8a
Hide repositories with raw results without rows
...
Currently, when running a query which produces raw results, we will show
all repositories, even if they do not have any results. This change will
ensure that we are only showing repositories which have results. This
matches the behavior for queries which produce interpreted results.
2022-09-28 13:34:31 +02:00
Koen Vlaswinkel
2efff809eb
Fix not being able to run variant analyses
...
The `controllerRepo` parameter was being encoded/escaped by Octokit,
resulting in a URL like
`repos/dsp-testing%2Fqc-controller/code-scanning/codeql/queries` rather
than `repos/dsp-testing/qc-controller/code-scanning/codeql/queries`.
This switches it to use the ID instead, since we already have the ID
and do not have access to the owner and repo separately anymore.
2022-09-28 13:18:47 +02:00
Robert
c442ff5599
Implement skipped repositories tabs
2022-09-28 12:09:32 +01:00
Elena Tanasoiu
e4de8c6b9b
Define mock variant analysis with scanned repos
...
Now that we have a monitor, we expect the variant analysis to return
a list of scanned repos.
Let's re-use our previous factory for creating mocked responses to
get a dummy variant analysis with scanned repos.
2022-09-28 11:33:47 +01:00
Elena Tanasoiu
c032e4f9a7
Hook up new monitor class to VScode command introduced earlier
...
In a previous commit we were submitting a variant analysis to the API
and then triggering a `monitorVariantAnalysis` command.
Here we're hooking up the command to the VariantAnalysisMonitor class.
2022-09-28 11:33:47 +01:00
Elena Tanasoiu
487cc7b088
Introduce a VariantAnalysisMonitor class
...
This will poll the API every 5 seconds for changes to the variant
analysis. By default it will continue to run for a maximum of 2 days,
or when the user closes VSCode.
The monitor will receive a variantAnalysis summary from the API that
will contain an up-to-date list of scanned repos.
The monitor will then return a list of scanned repo ids.
In a future PR we'll add the functionality to:
- update the UI for in progress/completed states
- raise error on timeout
- download the results
2022-09-28 11:33:47 +01:00
Elena Tanasoiu
d9e9c1b885
Make createMockApiResponse more convenient
...
So that we're able to:
- set the status value
- build scanned and skipped repos by default
For previous tests, we needed to perform checks on scanned & skipped
repos so we needed to build them outside of this method. When we re-use
this method for the VariantAnalysisMonitor, we will just need a generic
ApiResponse so we can create these repos inside the method.
2022-09-28 11:33:47 +01:00
Elena Tanasoiu
e19637b59c
Extract methods for generating VariantAnalysis objects
...
We're going to need some of these methods to generate a valid VariantAnalysis.
We might as well extract them from the tests for the VariantAnalysisProcessor.
2022-09-28 11:33:47 +01:00
Elena Tanasoiu
066bf3fd26
Trigger monitoring processs
...
Once we submit a variant analysis and get our response from the API,
we'd like to set up a way to monitor the variant analysis as it starts
producing live results.
Here we're using a VSCode command to trigger a monitoring process which
will poll the API for changes.
2022-09-28 11:33:46 +01:00
Elena Tanasoiu
7ab1f3a83d
Introduce a way to process API responses into variant analyses
...
This receives an API response and builds a VariantAnalysis from the fields.
2022-09-28 11:33:45 +01:00
Koen Vlaswinkel
e3e2fcc349
Refactor RawResultsTable component
...
The `RawResultsTable` was using inline styles, while we should prefer
to use styled components. This refactors it to use styled components and
also improves some other miscelleanous things (extracting the props to
a separate type and moving the `Cell` above the `Row` since the latter
uses the former).
2022-09-28 11:32:11 +02:00
Elena Tanasoiu
17ed18a29d
Install faker
2022-09-27 18:28:41 +01:00
Koen Vlaswinkel
110d930b68
Merge pull request #1543 from github/koesie10/outcome-panel
...
Add outcome panels
2022-09-27 15:20:24 +02:00
Koen Vlaswinkel
f8cc3aec32
Add analyzed repositories component
...
This adds the analyzed repositories component for showing within the
"Analyzed" tab. I wasn't completely sure whether there should be a
difference between "Pending" and "In progress", but pending will now not
show an icon, while in progress will show a spinner.
For the collapsible items, it does not reuse the `CollapsibleItem`
component because that component is tightly coupled with the styles
of the remote queries component.
2022-09-27 14:59:18 +02:00
Koen Vlaswinkel
f408418f23
Merge remote-tracking branch 'origin/main' into koesie10/outcome-panel
2022-09-27 14:03:13 +02:00
Robert
0b638b6ae1
Merge pull request #1538 from github/robertbrignull/submit-variant-analysis
...
Implement submitting a live-results variant analysis
2022-09-27 10:36:24 +01:00
Robert
ce7c7119c7
Return a VariantAnalysis from runRemoteQuery
2022-09-27 10:11:49 +01:00
Robert
5dce5e83b0
Promise resolves successfully but result is undefined
2022-09-26 15:08:37 +01:00
Robert
ac3b94dac8
Merge pull request #1541 from github/robertbrignull/loading-component
...
Add loading component
2022-09-26 14:55:41 +01:00
Robert
519c3039b8
Don't wait for dialog box
2022-09-26 14:55:00 +01:00
Koen Vlaswinkel
0a5c272b17
Merge pull request #1539 from github/koesie10/alert-components
...
Add Alert component for showing warnings and errors
2022-09-26 15:00:38 +02:00
Robert
32ec043cbe
Hook into main variant analysis component
2022-09-26 13:52:37 +01:00
Robert
454a1eab39
Adjust styling
2022-09-26 13:48:32 +01:00
Koen Vlaswinkel
d3701944bf
Add outcome panels
...
This creates the component for showing the outcome panels. It does not
implement the content of each individual panel; it only implements the
tabs, panel views, and the general warnings.
2022-09-26 14:03:03 +02:00
Koen Vlaswinkel
43bcd69e39
Use proper casing for alert type text
2022-09-26 14:01:22 +02:00
Koen Vlaswinkel
53a17d5728
Use better color variables for alerts
2022-09-26 13:59:55 +02:00
Andrew Eisenberg
b0dab966f3
Merge pull request #1498 from alexet/alexet/prepare-new-qs
...
QueryServer: Abstract over the query running parts.
2022-09-23 11:10:39 -07:00
Andrew Eisenberg
e4a3161283
Merge pull request #1540 from github/aeisenberg/safe-max-fix
...
Ensure `safeMax` is safe for undefined values
2022-09-23 10:49:02 -07:00
Robert
47e53da89c
Fix typo
2022-09-23 17:25:49 +01:00
Robert
f8f81cfb40
Add loading component
2022-09-23 17:20:13 +01:00
Andrew Eisenberg
fd43bed99d
Merge remote-tracking branch 'alexet/alexet/prepare-new-qs' into alexet/prepare-new-qs
2022-09-23 08:56:38 -07:00
Andrew Eisenberg
ffc3d406c2
Merge branch 'main' into alexet/prepare-new-qs
2022-09-23 08:56:10 -07:00
Andrew Eisenberg
11bf3c9462
Ensure safeMax is safe for undefined values
...
I came across this when I had a query that threw an error while running
for unrelated reasons. At this point, the query results were in a bad
state, but this caused `safeMax` to be called with `undefined` and
it prevented the extension from starting. This changed fixed the error.
2022-09-23 08:21:44 -07:00
Robert
9b2c40b298
Move duplicate definition to constant
2022-09-23 15:41:28 +01:00
Robert
abf6c6f108
Remove unnecessary async
2022-09-23 15:41:11 +01:00
Robert
910c1b7352
Stub isVariantAnalysisLiveResultsEnabled instead of updating setting
2022-09-23 14:43:48 +01:00
Robert
f47d6ec21c
Stub getRepositoryFromNwoStub
2022-09-23 14:43:16 +01:00
Robert
0e23dd59db
Remove settings duplicated in beforeEach
2022-09-23 14:11:00 +01:00
Koen Vlaswinkel
160a0aebfe
Add Alert component for showing warnings and errors
2022-09-23 15:10:15 +02:00
Robert
4d3385825b
Move test to pure-tests directory
2022-09-23 13:05:07 +01:00
Robert
80862944d8
Add tests of parseVariantAnalysisQueryLanguage
2022-09-23 12:31:11 +01:00
Robert
91344a74f6
Fix tests that use parseResponse
2022-09-23 12:31:01 +01:00
Robert
7538ad1ba4
Add parseVariantAnalysisQueryLanguage method
2022-09-23 12:21:14 +01:00
Robert
24c2663fe7
Use separate describe blocks for live results enabled vs disabled
2022-09-23 12:03:27 +01:00
Robert
50aaf3b537
Move more implementation of fetching the controller repo into getControllerRepo
...
This involved changing a few different methods to take a Repository object
instead of taking owner and repo separately. Overall I think this is a good change.
2022-09-23 11:01:25 +01:00
Robert
847082cd30
Set live results mode to off both before and after tests
2022-09-23 10:41:14 +01:00
Koen Vlaswinkel
8c7c197b22
Merge pull request #1537 from github/koesie10/icons-storybook
...
Add Storybook stories for icons
2022-09-23 09:28:14 +02:00
dependabot[bot]
1f95eb2f49
Bump sinon from 13.0.1 to 14.0.0 in /extensions/ql-vscode ( #1535 )
...
Bumps [sinon](https://github.com/sinonjs/sinon ) from 13.0.1 to 14.0.0.
- [Release notes](https://github.com/sinonjs/sinon/releases )
- [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md )
- [Commits](https://github.com/sinonjs/sinon/compare/v13.0.1...v14.0.0 )
---
updated-dependencies:
- dependency-name: sinon
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-22 10:38:00 -07:00
Robert
7874a34947
Add tests for runRemoteQuery when in live results mode
2022-09-22 17:33:35 +01:00
Koen Vlaswinkel
a74c8a7cee
Merge pull request #1536 from github/koesie10/eslint-plugin-react-hooks
...
Add ESLint plugin for React hooks
2022-09-22 17:39:12 +02:00
Koen Vlaswinkel
3aced3c4d3
Add Storybook stories for icons
...
This will add Storybook stories for the error, success, and warning
icons, as well as for the generic `Codicon` component.
To show the available icons for the `Codicon` component, a static JSON
list is generated from the contents of a CSV file included as part of
the `@vscode/codicons` npm package. The command to regenerate the file
is included in the story.
2022-09-22 17:37:33 +02:00
Koen Vlaswinkel
bec23f36d2
Add ESLint plugin for React hooks
...
This will add the ESLint plugin for React hooks which will automatically
check that all dependencies are listed in `useMemo`, `useEffect`, etc.
See: https://www.npmjs.com/package/eslint-plugin-react-hooks
2022-09-22 17:10:45 +02:00
Koen Vlaswinkel
92bbf3a2e8
Merge pull request #1534 from github/koesie10/variant-analysis-header-domain-model
...
Use domain model for VariantAnalysisHeader
2022-09-22 15:27:32 +02:00
Koen Vlaswinkel
5c478e98d9
Merge pull request #1532 from github/koesie10/split-common-components
...
Split CodePaths and FileCodeSnippet into multiple files
2022-09-22 15:09:42 +02:00
Koen Vlaswinkel
f26988731e
Add missed dependency in useMemo
2022-09-22 15:03:35 +02:00
Koen Vlaswinkel
e6f9ce050b
Extract potentially reusable functions to shared file
2022-09-22 15:00:09 +02:00
Robert
52f993f748
Implement submitting a variant analysis
2022-09-22 12:20:24 +01:00
Charis Kyriakou
99fe65f6f7
Update skipped repo groups structure for variant analysis ( #1533 )
2022-09-22 12:02:30 +01:00
Robert
7d721d9544
Add getControllerRepoId method
2022-09-22 11:35:16 +01:00
Koen Vlaswinkel
1005ecdc6a
Fix mock view
2022-09-22 12:06:04 +02:00
Koen Vlaswinkel
c9f65be721
Use domain model for VariantAnalysisHeader
...
This will change the VariantAnalysisHeader to take the VariantAnalysis
domain model instead of a large amount of props.
It also adds the `canceled` status to the `VariantAnalysisStatus` to
represent a stopped variant analysis.
2022-09-22 11:58:26 +02:00
Koen Vlaswinkel
9ad28f36b4
Split CodePaths and FileCodeSnippet into multiple files
2022-09-22 11:12:03 +02:00
Koen Vlaswinkel
9c076152cb
Merge pull request #1523 from github/koesie10/refactor-common-components
...
Refactor CodePaths and FileCodeSnippet components
2022-09-22 11:03:56 +02:00
Charis Kyriakou
bbb6f10f17
Add new GitHub API client with functions for new MRVA flow ( #1527 )
2022-09-22 09:02:44 +00:00
Koen Vlaswinkel
8a671be85c
Merge remote-tracking branch 'origin/main' into koesie10/refactor-common-components
2022-09-22 10:51:30 +02:00
Koen Vlaswinkel
0476815f8a
Merge pull request #1531 from github/koesie10/move-components-to-common
...
Move CodePaths and FileCodeSnippet to common directory
2022-09-22 10:43:56 +02:00
Koen Vlaswinkel
53dfd1243f
Move CodePaths and FileCodeSnippet to common directory
2022-09-22 10:26:55 +02:00
Koen Vlaswinkel
d69772d1f8
Merge pull request #1517 from github/koesie10/variant-analysis-stats
...
Add variant analysis stats component
2022-09-22 10:06:22 +02:00
Koen Vlaswinkel
2fd5f38574
Merge pull request #1528 from github/koesie10/fix-export-all-selection
...
Fix "Export All" not always exporting the correct query
2022-09-22 10:05:44 +02:00
Koen Vlaswinkel
06d22841cf
Rename getQueryById to getRemoteQueryById
2022-09-22 09:30:07 +02:00
Koen Vlaswinkel
0133cd7734
Improve error message for not found queries
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2022-09-22 09:28:57 +02:00
Robert
a53c04e2c1
Merge pull request #1530 from github/robertbrignull/release-instructions
...
Clarify step of the release process
2022-09-21 17:16:09 +01:00
Robert
eba6c190e8
Merge pull request #1529 from github/version/bump-to-v1.7.1
...
Bump version to v1.7.1
2022-09-21 17:09:41 +01:00
Charis Kyriakou
d0e6e3ca89
Define variant analysis domain models ( #1521 )
2022-09-21 16:59:44 +01:00
Robert
cc00456cbc
Clarify step of the release process
2022-09-21 16:56:28 +01:00
robertbrignull
434567aa34
Bump version to v1.7.1
2022-09-21 15:22:10 +00:00
Koen Vlaswinkel
7b1a93d7c6
Use HorizontalSpace instead of margin-left
2022-09-21 15:38:28 +02:00
Koen Vlaswinkel
d3ea84e863
Rename VariantAnalysisCompletionStats to VariantAnalysisStatusStats
2022-09-21 15:22:00 +02:00
Koen Vlaswinkel
1b6685ef6f
Fix "Export All" not always exporting the correct query
...
The "Export All" button was always exporting the selected query, while a
different query could be open in a VSCode panel. This will ensure that
the query ID is passed to the export function, so that the correct query
is exported.
2022-09-21 14:24:54 +02:00
Koen Vlaswinkel
f26795ca17
Merge remote-tracking branch 'origin/main' into koesie10/variant-analysis-stats
2022-09-21 12:28:47 +02:00
Koen Vlaswinkel
617f7bab0a
Extract icons to reusable components
2022-09-21 12:25:36 +02:00
Koen Vlaswinkel
8da1a28478
Add documentation to formatDecimal function
2022-09-21 12:16:37 +02:00
Koen Vlaswinkel
4518d9a81d
Use div instead of empty styled component
2022-09-21 12:16:20 +02:00
Koen Vlaswinkel
3817133b5b
Refactor CodePaths and FileCodeSnippet components
...
This refactors the CodePaths and FileCodeSnippet components to be more
readable and in style with the rest of the "new" components. It does the
following:
- Remove uses of the `style` and `sx` props; replace it by using
`styled-components` instead
- Remove uses of Primer icons
- Split out the components into multiple files
- Change the colors of the severity to match VSCode colors (and make
them themable)
I haven't removed the use of the Primer `Overlay` component yet, since
this component seems to do quite a lot and the VSCode WebView UI Toolkit
doesn't have a replacement for it.
2022-09-21 11:29:39 +02:00
Robert
c9b68caee4
Merge pull request #1526 from github/v1.7.0
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
Release PR for v1.7.0
2022-09-21 09:51:37 +01:00
Andrew Eisenberg
60c4d8d40a
Merge pull request #1519 from github/aeisenberg/upgrade-db-fix
...
Avoid error after upgrading a database
2022-09-20 09:38:26 -07:00
Robert
1a9d63315f
v1.7.0
2022-09-20 16:23:47 +01:00
Charis Kyriakou
5c8098f28d
Move GitHub Actions API client to gh-api directory ( #1524 )
2022-09-20 15:52:55 +01:00
Charis Kyriakou
bcf70c6962
Move zipFile util to its own module for easy re-use ( #1522 )
2022-09-20 09:57:33 +01:00
Koen Vlaswinkel
64f33a5f44
Merge pull request #1520 from github/koesie10/react-components-common
...
Move common React components to separate directory
2022-09-20 10:51:37 +02:00
dependabot[bot]
48a527ad52
Bump applicationinsights from 1.8.7 to 2.3.5 in /extensions/ql-vscode ( #1515 )
...
Bumps [applicationinsights](https://github.com/microsoft/ApplicationInsights-node.js ) from 1.8.7 to 2.3.5.
- [Release notes](https://github.com/microsoft/ApplicationInsights-node.js/releases )
- [Commits](https://github.com/microsoft/ApplicationInsights-node.js/compare/1.8.7...2.3.5 )
---
updated-dependencies:
- dependency-name: applicationinsights
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-19 10:02:35 -07:00
Koen Vlaswinkel
faabe6d887
Move common React components to separate directory
2022-09-19 10:03:30 +02:00
Koen Vlaswinkel
4b8d611d86
Merge pull request #1512 from github/koesie10/variant-analysis-header
...
Add variant analysis top header
2022-09-19 09:21:21 +02:00
Andrew Eisenberg
bfc9a17ffb
Update CHANGELOG
2022-09-16 16:19:58 -07:00
Andrew Eisenberg
a4a3f70984
Avoid error after upgrading a database
...
The `runUpgrade` query server command is mistakenly caching the old
dbscheme in memory after running the upgrade. The problem is in the
CLI. The workaround is to restart the query server after running an
upgrade. This is not a great solution, but considering that explicit
upgrades are now very rare. I do not think it is worth putting in
too much effort for a proper fix.
2022-09-16 15:58:39 -07:00
Koen Vlaswinkel
98bae3253d
Merge branch 'koesie10/variant-analysis-header' into koesie10/variant-analysis-stats
2022-09-16 16:34:43 +02:00
Koen Vlaswinkel
70098aa19c
Fix running unit tests on Windows
2022-09-16 14:58:26 +02:00
Koen Vlaswinkel
1261fdd41e
Add stories for individual variant analysis header components
2022-09-16 14:43:02 +02:00
Koen Vlaswinkel
c914312e85
Move variant analysis header tests to individual components
2022-09-16 14:40:41 +02:00
Koen Vlaswinkel
cd2b5a8c59
Set timezone and locale for tests
2022-09-16 14:36:12 +02:00
Koen Vlaswinkel
29a43c7dc1
Merge pull request #1518 from github/koesie10/codeowners-mrva
...
Add correct CODEOWNERS for MRVA webviews
2022-09-16 13:45:23 +02:00
Koen Vlaswinkel
8ef3c3713b
Add correct properties to variant analysis mock view
2022-09-16 13:33:34 +02:00
Koen Vlaswinkel
54f83d11d6
Add correct CODEOWNERS for MRVA webviews
2022-09-16 13:30:26 +02:00
Koen Vlaswinkel
22cfad6711
Add variant analysis stats to header component
2022-09-16 13:25:23 +02:00
Koen Vlaswinkel
cbc2650f30
Add tests for date and number formatting functions
2022-09-16 13:18:21 +02:00
Koen Vlaswinkel
55b060af97
Use browser date format
2022-09-16 13:18:21 +02:00
Koen Vlaswinkel
9f347d136b
Format date according to designs
2022-09-16 13:18:21 +02:00
Koen Vlaswinkel
0d0367c39d
Add tests for variant analysis stats component
2022-09-16 13:18:21 +02:00
Koen Vlaswinkel
ba0a30dcfe
Add variant analysis stats component
2022-09-16 13:18:21 +02:00
Koen Vlaswinkel
3079d7f285
Split variant analysis header component
2022-09-16 12:10:13 +02:00
Koen Vlaswinkel
10eb355900
Merge pull request #1467 from github/koesie10/deprecate-lgtm-download
...
Deprecate download from LGTM by hiding it behind canary flag
2022-09-16 09:39:37 +02:00
Andrew Eisenberg
0daea7399a
Merge branch 'main' into alexet/prepare-new-qs
2022-09-15 14:36:00 -07:00
Koen Vlaswinkel
1b0077a115
Implement PR feedback
2022-09-15 10:06:13 +02:00
Charis Kyriakou
db5e743055
Some more renames around webviews ( #1513 )
2022-09-14 16:01:49 +01:00
Charis Kyriakou
a6d63222f5
Consolidate view loading messages into one ( #1511 )
2022-09-14 15:19:21 +01:00
Koen Vlaswinkel
58e80ecce3
Rename styled components to be more descriptive
2022-09-14 16:14:30 +02:00
Koen Vlaswinkel
0ad44a3fe2
Use VSCodeLink for links in header
2022-09-14 16:11:20 +02:00
Charis Kyriakou
09dccc13a2
Renamed 'interface managers' to something more specific ( #1510 )
2022-09-14 13:09:43 +00:00
Koen Vlaswinkel
2cdded9cca
Add story for variant analysis view
2022-09-14 14:27:37 +02:00
Koen Vlaswinkel
e8a0b24f57
Add Jest tests to VSCode config
2022-09-14 14:20:54 +02:00
Koen Vlaswinkel
182c2f3b8e
Add variant analysis header to view
2022-09-14 14:14:19 +02:00
Koen Vlaswinkel
e5376b3469
Add DOM tests for variant analysis header
2022-09-14 13:56:38 +02:00
Koen Vlaswinkel
ef22cf174e
Add React testing library
2022-09-14 13:56:38 +02:00
Koen Vlaswinkel
d158487081
Add variant analysis header
2022-09-14 13:56:38 +02:00
Charis Kyriakou
2e9c0c301c
Add new variant analysis view ( #1506 )
2022-09-14 11:52:58 +00:00
Koen Vlaswinkel
f256e18041
Merge pull request #1509 from github/koesie10/fix-eslint-vscode-setting
...
Fix ESLint VSCode configuration
2022-09-14 10:46:46 +02:00
Koen Vlaswinkel
aa23680603
Fix ESLint VSCode configuration
...
The working directory of ESLint was not set directly, so ESLint warnings
did not show up in VSCode. This sets the working directory properly such
that ESLint warnings are shown in VSCode.
See: https://github.com/Microsoft/vscode-eslint#settings-options
2022-09-14 10:21:55 +02:00
Andrew Eisenberg
e5fe2148ab
Add back the evaluation results to CompletedQuery
...
This ensures that queries created by new versions of the extension
can still be read by older versions of the extension.
2022-09-13 14:51:44 -07:00
Andrew Eisenberg
c44b7b1d78
Apply suggestions from code review
2022-09-13 14:51:44 -07:00
alexet
24ede1b66f
QueryServer: Abstract over the query running parts of the query server in preperation for the new query server.
2022-09-13 14:51:44 -07:00
Andrew Eisenberg
6335b9881b
Add back the evaluation results to CompletedQuery
...
This ensures that queries created by new versions of the extension
can still be read by older versions of the extension.
2022-09-13 14:08:35 -07:00
shati-patel
8c0fee5a2e
Bump CLI version to 2.10.5 for integration tests
2022-09-13 16:58:21 +01:00
Koen Vlaswinkel
e95f8e85a8
Merge remote-tracking branch 'origin/main' into koesie10/deprecate-lgtm-download
2022-09-13 10:38:53 +02:00
Andrew Eisenberg
c6531a293e
Apply suggestions from code review
2022-09-12 16:10:58 -07:00
alexet
e648d9c67c
QueryServer: Abstract over the query running parts of the query server in preperation for the new query server.
2022-09-12 16:10:58 -07:00
Koen Vlaswinkel
45efca9425
Merge pull request #1503 from github/koesie10/remove-open-on-github-for-mrva
...
Remove open on GitHub item from cancelled local results
2022-09-09 09:25:05 +02:00
Alexander Eyers-Taylor
9071f54863
Don't display destructive upgrades any more. ( #1501 )
...
* Don't display destructive upgrades any more.
* Add change note
* Update extensions/ql-vscode/CHANGELOG.md
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com >
2022-09-08 18:57:12 +00:00
Koen Vlaswinkel
0aa34a51ff
Merge pull request #1504 from github/koesie10/remove-query-name-from-query-id
...
Remove query name from query ID for MRVA queries
2022-09-08 17:04:09 +02:00
Koen Vlaswinkel
181b5d6f7b
Remove query name from query ID for MRVA queries
2022-09-08 13:59:26 +02:00
Koen Vlaswinkel
7502fdee67
Remove open on GitHub item from cancelled local results
...
This will make a distinction between cancelled local and remote results,
allowing us to hide the *Open Variant Analysis on GitHub* item from
local failed/cancelled items. It also hides the *Show Evaluator Log*
items for cancelled/failed remote queries.
2022-09-08 13:36:50 +02:00
Koen Vlaswinkel
24652a84e4
Merge pull request #1497 from github/koesie10/storybook
...
Setup Storybook for testing UI components
2022-09-08 10:38:22 +02:00
Koen Vlaswinkel
2ee46cfd81
Add comment to .npmrc file for Storybook option
2022-09-08 09:22:08 +02:00
Alexander Eyers-Taylor
7c4eac8520
Avoid prompting for upgrades when they wouldn't be prompted. ( #1500 )
2022-09-07 17:53:37 +01:00
Koen Vlaswinkel
6fdc632743
Add overview page for Storybook
2022-09-07 17:06:23 +02:00
Koen Vlaswinkel
a38a0356a0
Remove MRVA prefix from component stories
2022-09-07 16:43:19 +02:00
Koen Vlaswinkel
9383b03971
Move Storybook config to TypeScript
2022-09-07 16:41:42 +02:00
Koen Vlaswinkel
baf130d60e
Remove WebView UI Toolkit stories
2022-09-07 16:37:37 +02:00
Koen Vlaswinkel
d15e3885d7
Add documentation about parameters in preview.js
2022-09-07 16:36:24 +02:00
Koen Vlaswinkel
2211e2317d
Add mock VSCode API in Storybook
...
This allows us to add a story for the "main" remote queries view.
2022-09-07 14:35:04 +02:00
Koen Vlaswinkel
6018ebaca9
Setup Storybook for testing UI components
...
This sets up Storybook for testing of React components. It adds stories
for some of the MRVA components. It does not add stories for the main
MRVA views since those are not independent of VSCode and need to be run
from within VSCode.
2022-09-06 10:55:55 +02:00
Koen Vlaswinkel
da9065101f
Merge pull request #1492 from github/koesie10/retry-artifacts
...
Add retry for finding result-index artifact
2022-09-05 10:08:11 +02:00
Koen Vlaswinkel
80867e6f58
Move result-index availability check to monitorQuery
2022-09-02 15:47:17 +02:00
Dave Bartolomeo
5067fbc452
Merge pull request #1494 from github/version/bump-to-v1.6.13
...
Bump version to v1.6.13
2022-09-02 05:17:43 -04:00
dbartol
d88b5170ac
Bump version to v1.6.13
2022-09-01 21:06:50 +00:00
Dave Bartolomeo
d4673d9ca0
Merge pull request #1493 from dbartol/v1.16.12
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.16.12
2022-09-01 16:38:14 -04:00
Dave Bartolomeo
87f45a7739
v1.16.12
2022-09-01 16:25:04 -04:00
Koen Vlaswinkel
0c89df9a80
Merge pull request #1482 from github/koesie10/bundle-codicons
...
Bundle Codicons using Webpack
2022-09-01 16:12:55 +02:00
Koen Vlaswinkel
57666bbbe3
Add retry for finding result-index artifact
...
It seems like the result-index artifact may not be available immediately
after the workflow run has finished. This adds a retry mechanism to wait
for the result-index to be available. It will retry at most 10 times
with a wait of 1 second between each retry.
2022-09-01 13:01:56 +02:00
Koen Vlaswinkel
ba8b32078d
Simplify and clarify Webpack font config
2022-09-01 11:21:06 +02:00
Koen Vlaswinkel
fa4dd087e5
Remove Codicons references from webview
2022-09-01 09:39:19 +02:00
Dave Bartolomeo
ac74b967b3
Merge pull request #1490 from dbartol/dbartol/log-version/work
2022-08-31 21:01:36 -04:00
Dave Bartolomeo
c349c6a048
Fix race condition when generating evaluator log summaries
...
The original code that logged the human-readable log summary generated the log asynchronously, which was a reasonable choice. When I added support for viewing and scanning logs, I didn't notice that the summary was being generated asynchronously, and wrote my code assuming that the summary was already on disk when I opened it to find where each relation's log started. The effect was that, depending on timing, the evaluation sometimes failed with an error popup complaining about not being able to open the log summary file.
The fix is to _generate_ the log summary synchronously, but continue to _log_ it asynchronously.
2022-08-31 18:17:45 -04:00
Dave Bartolomeo
234b05994c
Guard --sourcemap option based on CLI version
2022-08-31 18:08:21 -04:00
Koen Vlaswinkel
af8f0231c0
Merge pull request #1485 from github/koesie10/add-github-download-button
...
Remove canary requirement for GitHub database download
2022-08-31 16:57:12 +02:00
Edoardo Pirovano
84bd029749
Restart CLI server too when restarting query server
2022-08-31 14:39:44 +01:00
shati-patel
7d2e4b6de4
Bump CLI version to 2.10.4 for integration tests
2022-08-31 13:52:40 +01:00
Koen Vlaswinkel
23a0e03cef
Completely remove using credentials in non-canary mode
...
This does not remove the previously added mechanism of not requesting
credentials, but using them when they are available. I expect this to be
used in the future.
2022-08-31 14:22:17 +02:00
Koen Vlaswinkel
21c5ed01ad
Fix typo in getOctokit JSDoc
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-08-31 11:48:27 +02:00
Koen Vlaswinkel
d2af550bcc
Merge remote-tracking branch 'origin/main' into koesie10/bundle-codicons
2022-08-31 09:51:46 +02:00
Koen Vlaswinkel
cf36a52762
Merge pull request #1478 from github/koesie10/abstract-interface-manager
...
Add abstract interface manager
2022-08-31 09:48:05 +02:00
Koen Vlaswinkel
ac1a97efa0
Refactor databaseFetcher tests to not use proxyquire
2022-08-30 15:32:08 +02:00
Koen Vlaswinkel
8d5067f622
Update CHANGELOG
2022-08-30 15:09:16 +02:00
Koen Vlaswinkel
fe5f1c417d
Remove authentication requirement for download GitHub databases
...
This makes authentication for download GitHub CodeQL databases optional.
If you are already authenticated, your token will be used. If you are
not authenticated, an anonymous request will be made.
If the canary flag is enabled, you will be prompted for credentials when
downloading a database and you are not yet logged in.
2022-08-30 15:05:15 +02:00
Koen Vlaswinkel
95438bb7e3
Remove canary requirement for GitHub database download
2022-08-30 14:33:48 +02:00
Koen Vlaswinkel
6d7d0ca41a
Merge pull request #1477 from github/koesie10/unified-webpack-bundle
...
Unify the Webpack bundle
2022-08-30 11:29:45 +02:00
Koen Vlaswinkel
3749e17769
Bundle Codicons using Webpack
...
This will include the Codicons inside the webview bundle, reducing the
number of files that need to be loaded and the resource roots that need
to be included.
2022-08-29 14:31:29 +02:00
Koen Vlaswinkel
ee49fb5070
Merge branch 'koesie10/unified-webpack-bundle' into koesie10/abstract-interface-manager
2022-08-29 14:12:20 +02:00
Koen Vlaswinkel
de6c523bad
Merge remote-tracking branch 'origin/main' into koesie10/unified-webpack-bundle
2022-08-29 13:57:23 +02:00
Koen Vlaswinkel
6612c279ae
Merge pull request #1479 from github/koesie10/improve-controller-repo-prompt
...
Improve prompot for controller repo
2022-08-29 09:53:26 +02:00
Koen Vlaswinkel
2dfa0e8b52
Simplify interface manager and types
2022-08-29 09:51:49 +02:00
Koen Vlaswinkel
0197306713
Remove unnecessary top-level package-lock.json
2022-08-29 09:47:24 +02:00
Dave Bartolomeo
269165eaa3
Merge pull request #1476 from github/version/bump-to-v1.6.12
...
Bump version to v1.6.12
2022-08-26 10:38:05 -04:00
Koen Vlaswinkel
14c736d72e
Improve prompot for controller repo
...
This will improve the prompt for the controller repo by making clear
that the GitHub Actions workflow will be run in the specified repo.
2022-08-26 13:58:11 +02:00
Koen Vlaswinkel
b8898b939c
Add abstract interface manager
...
This will add a new abstract class that implements the creation of the
panel and webview to reduce duplication across the different interface
managers.
2022-08-26 12:34:28 +02:00
Koen Vlaswinkel
45da1e0f1f
Unify the Webpack bundle
...
This will move all webviews into a single Webpack bundle. This will make
it easier to add new webviews since we don't need to add a new bundle,
but just need to add a new directory with an `index.tsx` file.
It also moves the CSS processing to Webpack so that we don't need to
specify the CSS files to use separately, but can simply do so in the
TypeScript files.
2022-08-26 11:15:24 +02:00
dbartol
88c990c6ae
Bump version to v1.6.12
2022-08-25 20:46:21 +00:00
Dave Bartolomeo
ac7211c117
Merge pull request #1475 from dbartol/dbartol/extension-release/work
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
Prepare for release 1.6.11
2022-08-25 16:36:44 -04:00
Dave Bartolomeo
d1d13fbd2e
Update changelog for release
2022-08-25 13:11:50 -04:00
Dave Bartolomeo
f99166d26c
Update Node version to match vscode
2022-08-25 13:01:35 -04:00
dependabot[bot]
9cd6f9a768
Bump d3 and @types/d3 in /extensions/ql-vscode ( #1461 )
...
Bumps [d3](https://github.com/d3/d3 ) and [@types/d3](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/d3 ). These dependencies needed to be updated together.
Updates `d3` from 6.7.0 to 7.6.1
- [Release notes](https://github.com/d3/d3/releases )
- [Changelog](https://github.com/d3/d3/blob/main/CHANGES.md )
- [Commits](https://github.com/d3/d3/compare/v6.7.0...v7.6.1 )
Updates `@types/d3` from 6.7.5 to 7.4.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/d3 )
---
updated-dependencies:
- dependency-name: d3
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: "@types/d3"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-24 08:13:04 -07:00
Koen Vlaswinkel
4dd16f4611
Merge pull request #1472 from github/koesie10/fix-data-not-loaded-in-mrva-results
...
Fix data not being loaded in MRVA results panel
2022-08-24 15:14:26 +02:00
Koen Vlaswinkel
2113d08545
Fix data not being loaded in MRVA results panel
...
When the MRVA results panel is closed (so the panel gets disposed) and
opened again, it would not load the MRVA data (such as whether a query
has already been downloaded). This fixes it by also resetting the
internal state of whether the panel is loaded when the panel is
disposed.
2022-08-24 13:20:01 +02:00
Koen Vlaswinkel
5b5ef26864
Merge pull request #1471 from github/revert-1466-koesie10/add-github-download-button
...
Revert "Remove canary requirement for GitHub database download"
2022-08-24 12:12:44 +02:00
Koen Vlaswinkel
c5a6e64df8
Revert "Remove canary requirement for GitHub database download"
2022-08-24 11:51:44 +02:00
Charis Kyriakou
178d626062
Upgrade webview-ui-toolkit version with long link fix ( #1469 )
2022-08-24 10:17:41 +01:00
Dave Bartolomeo
d1d48b3506
Merge pull request #1468 from dbartol/dbartol/pmod-highlight/work
...
Add `implements` and `signature` to syntax highlighting
2022-08-23 17:02:03 -04:00
Dave Bartolomeo
9180d1d9fc
Fix comment
2022-08-23 16:42:57 -04:00
Dave Bartolomeo
674c5ecbff
Add implements and signature to syntax highlighting
2022-08-23 14:56:47 -04:00
Koen Vlaswinkel
951d0b1004
Merge remote-tracking branch 'origin/main' into koesie10/deprecate-lgtm-download
2022-08-23 16:27:23 +02:00
Koen Vlaswinkel
edcac6925c
Merge pull request #1466 from github/koesie10/add-github-download-button
...
Remove canary requirement for GitHub database download
2022-08-23 16:24:12 +02:00
Koen Vlaswinkel
2989e4cfb9
Update CHANGELOG
2022-08-23 16:08:23 +02:00
Koen Vlaswinkel
8f869813a9
Deprecate download from LGTM by hiding it behind canary flag
2022-08-23 16:05:11 +02:00
Koen Vlaswinkel
c10500c5ea
Update CHANGELOG
2022-08-23 14:58:36 +02:00
Koen Vlaswinkel
0832850009
Remove canary requirement for GitHub database download
2022-08-23 14:45:48 +02:00
Alexander Eyers-Taylor
b352830674
Improve startup time ( #1465 )
...
* ArchiveFileSystem: Only parse zips once
* CLIServer: Only get version once
2022-08-23 11:05:10 +01:00
Andrew Eisenberg
e913165249
Merge pull request #1463 from github/aeisenberg/bump-timeout
2022-08-17 17:21:31 -07:00
Andrew Eisenberg
ef94bb3d38
Bump telemetry test timeout
...
This test is failing occasionally on our CI system. Let's see if this
change prevents the failures.
2022-08-17 15:47:30 -07:00
Shati Patel
4d6076c4ea
Escape HTML characters when rendering MRVA results as markdown ( #1462 )
2022-08-17 10:52:36 +01:00
Dave Bartolomeo
43650fde00
Merge pull request #1454 from github/dbartol/join-order
...
Report suspicious join orders
2022-08-15 14:13:35 -04:00
Angela P Wen
f2c72a67f6
Bump CLI version to 2.10.3 for integration tests ( #1460 )
2022-08-15 16:41:26 +00:00
Dave Bartolomeo
2b1f3227ce
Fix computation of result sizes in IN_LAYER events
2022-08-12 17:00:26 -04:00
Dave Bartolomeo
841f1d3310
Replace console logging to route through problem reporter
2022-08-12 16:43:21 -04:00
Dave Bartolomeo
99756ae63b
Fix PR feedback
2022-08-12 16:25:52 -04:00
Dave Bartolomeo
9a2bea39e6
Better handling of missing log data
2022-08-12 16:14:24 -04:00
Dave Bartolomeo
1aab49c719
Specify return type
2022-08-12 16:01:58 -04:00
Dave Bartolomeo
cf925c256f
Update extensions/ql-vscode/src/log-insights/log-scanner-service.ts
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-08-12 15:50:28 -04:00
Dave Bartolomeo
8383a76e43
Merge branch 'dbartol/join-order' of https://github.com/github/vscode-codeql into dbartol/join-order
2022-08-12 15:41:52 -04:00
Dave Bartolomeo
c6d792f41e
Fix PR feedback
...
Better handling of malformed RA
2022-08-12 15:39:32 -04:00
Dave Bartolomeo
277192e7d3
Update extensions/ql-vscode/src/log-insights/join-order.ts
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-08-12 14:59:20 -04:00
Dave Bartolomeo
85988ecf34
Update extensions/ql-vscode/src/log-insights/join-order.ts
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-08-12 14:50:10 -04:00
Dave Bartolomeo
49d12674b7
Cache regexprs
2022-08-12 14:47:50 -04:00
Dave Bartolomeo
beeb19dc05
Fix typo
2022-08-12 12:58:46 -04:00
Dave Bartolomeo
de88d27057
Update extensions/ql-vscode/src/log-insights/join-order.ts
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-08-12 12:49:29 -04:00
Dave Bartolomeo
eb2d00e999
Update extensions/ql-vscode/src/log-insights/join-order.ts
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-08-12 12:48:28 -04:00
Dave Bartolomeo
d58fb54928
Better formatting of metrics
2022-08-11 13:51:11 -04:00
Dave Bartolomeo
fdc209ca08
Test for log scanning
2022-08-10 18:07:59 -04:00
Dave Bartolomeo
28092f2b86
Move more of log scanning into pure code
2022-08-10 17:33:55 -04:00
Dave Bartolomeo
8970ad78ae
Remove code added via bad merge
2022-08-10 13:51:08 -04:00
Dave Bartolomeo
e7a0c58940
Fix CodeQL alert
2022-08-10 13:18:00 -04:00
Dave Bartolomeo
02270aaeee
Fix lint
2022-08-10 13:13:59 -04:00
Dave Bartolomeo
51fb03b4b1
Fix tests to match code changes
2022-08-10 13:11:34 -04:00
Dave Bartolomeo
838a2b71ac
Scan logs on change in current query
2022-08-09 18:02:27 -04:00
Charis Kyriakou
f01c421d42
Merge pull request #1458 from github/version/bump-to-v1.6.11
...
Bump version to v1.6.11
2022-08-09 16:59:14 +01:00
charisk
561bc6f53c
Bump version to v1.6.11
2022-08-09 15:21:26 +00:00
Charis Kyriakou
24b421e82d
v1.6.10 ( #1456 )
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2022-08-09 16:17:57 +01:00
Dave Bartolomeo
3c57597a19
Share code for splitting records from pseudo-JSONL
2022-08-05 17:36:45 -04:00
Dave Bartolomeo
e8d5029912
Merge remote-tracking branch 'origin/main' into dbartol/join-order-temp
2022-08-05 17:34:52 -04:00
Dave Bartolomeo
cb514f5c78
Pre-cleanup to avoid merge conflicts
2022-08-05 14:59:40 -04:00
Dave Bartolomeo
57bb8cee41
Update regexes to match new summary text
2022-08-04 16:17:27 -04:00
Dave Bartolomeo
1219ef4a8c
Remove unnecessary command
2022-08-04 16:17:09 -04:00
Dave Bartolomeo
677a0f7940
Fix lint
2022-08-04 14:42:47 -04:00
Charis Kyriakou
b8cca29eb3
Ensure query history state is persisted after new query is added ( #1451 )
2022-08-04 15:06:47 +01:00
Shati Patel
4cbf104bdf
(Minor) Remove outdated comment ( #1453 )
2022-08-04 13:24:48 +00:00
Angela P Wen
26ccde9e7d
Bump CLI version to 2.10.2 for integration tests
2022-08-03 10:30:55 +01:00
Angela P Wen
beb5b78b89
Add 50ms wait for flaky telemetry popup test ( #1449 )
2022-08-02 08:24:07 -07:00
Dave Bartolomeo
c3a21b93c0
Merge pull request #1430 from github/dbartol/goto-ql
...
Initial implementation of sourcemap-based jump-to-QL command
2022-08-01 13:52:06 -04:00
Dave Bartolomeo
6b9f73e156
Add comment to test data file
2022-08-01 13:19:15 -04:00
Dave Bartolomeo
6409e09063
Code cleanup
2022-08-01 12:28:35 -04:00
Dave Bartolomeo
8f5611b074
Move sourcemap tests to cli-integration
2022-08-01 12:14:00 -04:00
Dave Bartolomeo
7f3fcce1ac
Temporarily increase delay for extension activation in test
2022-07-29 13:11:46 -04:00
Dave Bartolomeo
4bc1d1ed8a
Force activation of extension
2022-07-29 12:44:06 -04:00
Dave Bartolomeo
02e5b4e830
Fix installation of dependent extensions
2022-07-29 12:03:43 -04:00
Dave Bartolomeo
538792e8bb
Try installing extension dependencies for minimal-workspace tests
2022-07-29 11:35:52 -04:00
Dave Bartolomeo
56ec970121
Merge branch 'dbartol/goto-ql' of https://github.com/github/vscode-codeql into dbartol/goto-ql
2022-07-29 11:01:07 -04:00
Dave Bartolomeo
57a04297bd
Only disable specific extensions for minimal-workspace tests
2022-07-29 11:01:02 -04:00
Dave Bartolomeo
59f1e4e90a
Update extensions/ql-vscode/src/pure/log-summary-parser.ts
2022-07-28 22:31:18 -04:00
Dave Bartolomeo
7c1fce3319
Merge remote-tracking branch 'origin/main' into dbartol/goto-ql
2022-07-28 22:29:45 -04:00
Dave Bartolomeo
476ea7aef0
Integration test
2022-07-28 22:20:22 -04:00
Elena Tanasoiu
0c654c4320
Merge pull request #1444 from github/elenatanasoiu/fix-bugs
...
Don't show parentheses when results are not yet fetched in Query History
2022-07-26 10:33:32 +01:00
Elena Tanasoiu
895ac6ae26
Squash extra whitespace for Query History labels
...
We'd like to remove duplicate whitespace in these labels in order
to make it less likely that we introduce extra space.
We initially also tried trimming whitespaces at the start and end
of these labels but that had no effect.
2022-07-26 09:49:27 +01:00
Elena Tanasoiu
52484f1211
Don't show parentheses when results are not yet fetched
...
We missed a place where we needed to check if results are present
before attempting to show them.
Let's also add tests for this.
2022-07-26 09:47:55 +01:00
Elena Tanasoiu
cba188b4db
Use named arguments for mock function
...
We'd like to be able to add tests for when the result count exists and
when it's missing.
Let's change the createMockRemoteQueryInfo method so that we can pass
in parameters by name, e.g.
```
createMockRemoteQueryInfo(undefined, 2)
```
becomes
```
createMockRemoteQueryInfo({ repositoryCount: 2 }
```
2022-07-26 09:46:10 +01:00
Elena Tanasoiu
123b1fc085
Clarify title description
...
To make it clear it's referring to a `user-specified` label, not that the user is not specified.
2022-07-25 17:16:36 +01:00
Angela P Wen
833f8e06ca
Add a tree viewer UI for the evaluator logs ( #1433 )
...
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com >
2022-07-22 12:01:39 +02:00
Andrew Eisenberg
747049ed1b
Merge pull request #1435 from github/dependabot/npm_and_yarn/extensions/ql-vscode/yargs-parser-20.2.4
...
Bump yargs-parser from 5.0.0-security.0 to 20.2.4 in /extensions/ql-vscode
2022-07-20 08:47:15 -07:00
Andrew Eisenberg
d62e9181f2
Merge pull request #1436 from github/dependabot/npm_and_yarn/extensions/ql-vscode/semver-regex-and-husky-3.1.4
...
Bump semver-regex and husky in /extensions/ql-vscode
2022-07-20 08:45:04 -07:00
Dave Bartolomeo
e4d1f4e73e
Fix newline handling for cross-platform logs
...
We were splitting JSONL records based on the current OS newline sequence. In order to handle reading of logs from the opposite OS, I've switched our split to handle both flavors of line ending. This originally showed up as log parser unit tests failing on Windows (the checked-in log used Unix line endings), but could affect real world usage as well.
2022-07-20 11:21:53 -04:00
dependabot[bot]
c1922126d3
Bump terser from 5.14.1 to 5.14.2 in /extensions/ql-vscode
...
Bumps [terser](https://github.com/terser/terser ) from 5.14.1 to 5.14.2.
- [Release notes](https://github.com/terser/terser/releases )
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/commits )
---
updated-dependencies:
- dependency-name: terser
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-20 12:03:15 +01:00
elenatanasoiu
d2ebb3d20a
Bump version to v1.6.10
2022-07-20 11:57:41 +01:00
Angela P Wen
72858e341a
Bump CLI version to 2.10.1 for integration tests ( #1442 )
2022-07-20 11:55:43 +02:00
Elena Tanasoiu
4499773f6f
Merge pull request #1440 from github/v1.6.9
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.6.9
2022-07-20 10:16:21 +01:00
Elena Tanasoiu
1d3b0e0ca9
v1.6.9
2022-07-20 10:01:12 +01:00
Elena Tanasoiu
98e503c768
Merge pull request #1438 from github/shati-patel/gist-description
...
MRVA: Fix Gist description when repository count is undefined
2022-07-20 09:46:22 +01:00
Elena Tanasoiu
62c3974d35
Check for undefined, null or zero repositories
...
`undefined`, `null` and 0 will evaluate to `false` so if we only want to
display the repository count when these values are not present we can
check for a truthy value:
```
query.repositoryCount ? `(${pluralize(...)})` : '';
```
instead of checking explicitly:
```
query.repositoryCount !== undefined && query.repositoryCount !== null && query.repositoryCount != 0 ? `(${pluralize(...)})` : '';
```
2022-07-20 09:30:54 +01:00
Dave Bartolomeo
40e0027074
Fix newline handling for cross-platform logs
...
We were splitting JSONL records based on the current OS newline sequence. In order to handle reading of logs from the opposite OS, I've switched our split to handle both flavors of line ending. This originally showed up as log parser unit tests failing on Windows (the checked-in log used Unix line endings), but could affect real world usage as well.
2022-07-19 17:29:33 -04:00
shati-patel
ab1c2e0a0d
Explicitly check for undefined
2022-07-19 20:00:10 +01:00
shati-patel
d918c41197
Fix Gist description when repository count is undefined
2022-07-19 18:25:25 +01:00
Dave Bartolomeo
84048ccac1
Merge remote-tracking branch 'origin/main' into dbartol/goto-ql
2022-07-19 09:39:51 -04:00
dependabot[bot]
cbb09da0d0
Bump semver-regex and husky in /extensions/ql-vscode
...
Bumps [semver-regex](https://github.com/sindresorhus/semver-regex ) and [husky](https://github.com/typicode/husky ). These dependencies needed to be updated together.
Updates `semver-regex` from 2.0.0 to 3.1.4
- [Release notes](https://github.com/sindresorhus/semver-regex/releases )
- [Commits](https://github.com/sindresorhus/semver-regex/compare/v2.0.0...v3.1.4 )
Updates `husky` from 4.2.5 to 4.3.8
- [Release notes](https://github.com/typicode/husky/releases )
- [Commits](https://github.com/typicode/husky/compare/v4.2.5...v4.3.8 )
---
updated-dependencies:
- dependency-name: semver-regex
dependency-type: indirect
- dependency-name: husky
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-19 12:51:24 +00:00
dependabot[bot]
c8d3428f21
Bump yargs-parser in /extensions/ql-vscode
...
Bumps [yargs-parser](https://github.com/yargs/yargs-parser ) from 5.0.0-security.0 to 20.2.4.
- [Release notes](https://github.com/yargs/yargs-parser/releases )
- [Changelog](https://github.com/yargs/yargs-parser/blob/main/CHANGELOG.md )
- [Commits](https://github.com/yargs/yargs-parser/commits/v20.2.4 )
---
updated-dependencies:
- dependency-name: yargs-parser
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-07-19 12:51:22 +00:00
Elena Tanasoiu
2cf5b39cfe
Merge pull request #1432 from github/charisk-elena/result-count-on-history-labels
...
Add result count to remote queries in Query History
2022-07-19 13:50:22 +01:00
Elena Tanasoiu
13921bf8a2
Extract sum method for adding up repo results
...
When a queryResult is created, it comes with an array for AnalysisSummaries.
There is one summary per repository.
We've had to calculate the total number of results for all summaries in multiple
places, so let's extract a method for this as well.
2022-07-19 13:26:56 +01:00
Elena Tanasoiu
12a97ecba2
Shorten param forwarding for repositoryCount
2022-07-19 13:26:54 +01:00
Elena Tanasoiu
26529232f4
Rename numRepositoriesQueries to repositoryCount
...
To make it consistent with `resultCount`.
2022-07-19 13:25:48 +01:00
Elena Tanasoiu
1b425fc261
DRY up labels using the new pluralize method
2022-07-19 13:25:40 +01:00
Elena Tanasoiu
9c598c2f06
Extract pluralize method
...
There are at least 4 different files where this method could DRY things up,
so let's extract it.
I've chosen to move it to src/helpers.ts but happy to be told there's a better
place for shared utility methods like this one.
2022-07-19 12:32:24 +01:00
Elena Tanasoiu
99a784f072
Be able to sort remote queries by number of results
...
Previously we would set all remote query results to -1 when someone
attempted to sort queries.
We would then only sort local queries as those had access to the number
of results.
Let's include number of results for remote queries in the sorting.
Co-authored-by: Shati Patel <shati-patel@github.com >
2022-07-19 12:32:24 +01:00
Elena Tanasoiu
030488a459
Make local and remote query results match
...
In the previous commit we're now displaying number of results for remote
queries.
Previously we could only do this for local queries.
Let's make the format match for both types of queries by displaying
number of results in parentheses: `(x results)`.
Co-authored-by: Shati Patel <shati-patel@github.com >
2022-07-19 12:32:24 +01:00
Elena Tanasoiu
377f7965b1
Add result count to remote queries in Query History
...
When you run a remote query, we'd like to display more information about
it in the Query History panel.
At the moment we've improved this [1] by adding the language and number of repositories.
In this commit we're also adding the number of results for a remote query.
So the final format of the query history item will change from:
`<query_name> - <query_status>`
to
`<query_name> (<language>) on x repositories (y results) - <query_status>`
[1]: https://github.com/github/vscode-codeql/pull/1427
Co-authored-by: Charis Kyriakou <charisk@github.com >
Co-authored-by: Shati Patel <shati-patel@github.com >
2022-07-19 12:32:22 +01:00
Charis Kyriakou
651a6fbda8
Ensure completed flag is set on remote query history items ( #1434 )
2022-07-19 10:40:02 +01:00
Elena Tanasoiu
55ffdf7963
Merge pull request #1431 from github/shati-elena/rename-gist
...
Add useful information to MRVA gist titles
2022-07-19 09:11:47 +01:00
Elena Tanasoiu
cc907d2f31
Add test for exportResultsToGist method
...
While we're here we're also adding a test for the `exportResultsToGist`
method, as there were no tests for the `export-results.ts` file.
We initially attempted to add the test to the pure-tests folder, but the
`export-results.ts` file imports some components from `vscode`, which
meant we needed to set up the test in an environment where VSCode
dependencies are available.
We chose to add the test to `vscode-tests/no-workspace` for convenience,
as there are already other unit tests there.
We've also had to import our own query and analysis result to be able
to work with data closer to reality for exported results.
Since we've introduced functionality to build a gist title, let's check
that the `exportResultsToGist` method will forward the correct title to
the GitHub Actions API.
Co-authored-by: Shati Patel <shati-patel@github.com >
2022-07-18 19:52:51 +01:00
Dave Bartolomeo
49a1576d14
Merge branch 'dbartol/goto-ql' of https://github.com/github/vscode-codeql into dbartol/goto-ql
2022-07-18 14:33:37 -04:00
Dave Bartolomeo
0cc4561ee9
Discard cached sourcemap when summary document is closed
...
Also some minor lint feedback
2022-07-18 14:33:33 -04:00
Elena Tanasoiu
c4df9dbec8
Extract method for creating Extension context
...
We'd like to re-use this to test the `exportResultsToGist` method in
`export-results.ts`.
So let's move it to a shared folder in the `vscode-tests/no-workspace` folder.
Since there's no `helper.ts` file in this folder and to avoid any confusion with
the `helpers.test.ts` file, I've opted to put this shared method into `index.ts`.
Happy to be told there's a better pattern for this as it doesn't feel very nice!
2022-07-18 19:22:44 +01:00
Elena Tanasoiu
c384a631dc
Handle missing repo count gracefully
...
Let's handle this case gracefully and skip displaying the number of repositories
when they're not available.
Similarly let's add a check to see if we should pluralize the `repository` noun
or not.
Co-authored-by: Shati Patel <shati-patel@github.com >
2022-07-18 19:22:44 +01:00
Elena Tanasoiu
b079690f0e
Add useful information to MRVA gist titles
...
All exported MRVA gists are given the name `CodeQL variant analysis
results', which makes it hard to work out what it contains at a glance.
We're adding more information in the gist title to make it more useful.
Example of new title:
`Empty Block (Go) x results (y repositories)`
This translates to:
`<query name> (<query language>) <number of results> results (<number of repositories> repositories)`
Co-authored-by: Shati Patel <shati-patel@github.com >
2022-07-18 19:22:41 +01:00
Elena Tanasoiu
4e863e995b
Introduce method to add analysis results
...
We'd like to improve MRVA query gists by giving them more descriptive
titles that contain useful information about the query.
Let's add the number of query results to the title of the gist.
To do this we'll first need to count all the results provided to us in
the `analysisResults` array. There is an item in this array for each of
the repositories we've queried, so we're introducing a method to sum up
results for all the items in the array.
Co-authored-by: Shati Patel <shati-patel@github.com >
2022-07-18 19:20:58 +01:00
Dave Bartolomeo
576737cac8
Update extensions/ql-vscode/src/log-insights/summary-language-support.ts
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-07-15 14:50:48 -04:00
Dave Bartolomeo
742aa4ca19
Use error message helper
2022-07-15 11:43:05 -04:00
Shati Patel
f992679e94
MRVA: Include more info in query history label ( #1427 )
...
Co-authored-by: Elena Tanasoiu <elenatanasoiu@github.com >
2022-07-15 13:58:45 +01:00
Shati Patel
ffe1704ac0
Replace code paths dropdown with VS Code UI Toolkit ( #1429 )
2022-07-15 13:04:36 +01:00
Dave Bartolomeo
b5e6700cba
Log message on failure to open sourcemap
2022-07-14 18:10:58 -04:00
Dave Bartolomeo
7f5302dc37
fs-extra
2022-07-14 17:39:16 -04:00
Dave Bartolomeo
3ea5524048
Hide "Go to QL Code" behind canary flag
2022-07-14 17:21:52 -04:00
Dave Bartolomeo
1823ae8397
Fix test expectation
2022-07-14 17:03:39 -04:00
Dave Bartolomeo
6dca9ccbeb
Fix linter issues
2022-07-14 14:12:10 -04:00
Dave Bartolomeo
f3c2862937
Fix lint error
2022-07-14 14:06:19 -04:00
Dave Bartolomeo
855cb485d5
Initial implementation of sourcemap-based jump-to-QL command
2022-07-14 13:55:46 -04:00
Edoardo Pirovano
bd2dd04ac6
Regularly scrub query history view
2022-07-14 16:59:08 +01:00
Edoardo Pirovano
bbf4a03b03
Fix typo in config parameter name
2022-07-13 16:34:18 +01:00
Shati Patel
f38eb4895d
Replace "repository search" filter box with VS Code UI Toolkit ( #1424 )
2022-07-13 15:13:31 +01:00
Andrew Eisenberg
f559b59ee5
Merge pull request #1420 from github/robertbrignull/api-retry
...
Add API retries for octokit requests
2022-07-12 08:12:21 -07:00
Angela P Wen
c9d895ea42
Parse summary of evaluator logs into data model ( #1405 )
...
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com >
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-07-12 14:04:55 +02:00
Shati Patel
e57bbcb711
Use VSCodeTags instead of Primer Labels in webview ( #1421 )
2022-07-01 16:21:44 +01:00
Shati Patel
b311991644
MRVA: Fix grammar in pop-up message ( #1416 )
2022-07-01 12:43:46 +01:00
Robert
825054a271
Use octokit retry module
2022-07-01 11:19:49 +00:00
Robert
f7aa0a5ae5
Install @octokot/plugin-retry
2022-07-01 11:06:22 +00:00
Andrew Eisenberg
f486ccfac6
Merge pull request #1418 from github/aeisenberg/resolve-ml-libs
...
Resolve ml-queries from directory
2022-06-30 08:56:15 -07:00
Andrew Eisenberg
70f74d3baf
Resolve ml-queries from directory
...
Previously, there was a bug where quick eval queries would crash when
the eval snippet is in a library file.
The problem was that the `codeql resolve queries` command fails when
passed a library file. The fix is to avoid passing the library file at
all. Instead, pass the directory. This is safe because the resolve
queries command only needs to know which query pack the file is
contained in. Passing in the parent directory is the same as passing in
a file in this particular case.
2022-06-30 08:36:55 -07:00
Charis Kyriakou
ebad1844df
MRVA: Don't show notification if user aborts firing off a query ( #1417 )
2022-06-30 14:35:33 +01:00
Charis Kyriakou
a40a2edaf2
Merge pull request #1414 from github/version/bump-to-v1.6.9
...
Bump version to v1.6.9
2022-06-29 13:17:30 +01:00
charisk
5f3d525ff8
Bump version to v1.6.9
2022-06-29 11:56:36 +00:00
Charis Kyriakou
8f5d88156f
Merge pull request #1413 from github/v1.6.8
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.6.8
2022-06-29 12:53:51 +01:00
Charis Kyriakou
7c941fe8a8
v1.6.8
2022-06-29 12:42:18 +01:00
Henry Mercer
e9835cb376
Improve changelog note
...
Co-authored-by: Edoardo Pirovano <6748066+edoardopirovano@users.noreply.github.com >
2022-06-29 12:01:10 +01:00
Henry Mercer
7651a960b1
Add changelog note
2022-06-29 12:01:10 +01:00
Henry Mercer
5b17a84733
Avoid resolve ml-models errors being logged during quick eval
...
Currently `resolve ml-models` only supports queryspecs, i.e. .ql, .qls,
directory, and query pack specifications. Therefore quick evaluation within
a library isn't
supported.
2022-06-29 12:01:10 +01:00
Andrew Eisenberg
22873a2f3c
Invoke codeql pack install after adding a quick query
...
This ensures the pack lock file is in place after the quick query is
generated.
2022-06-29 10:25:00 +01:00
Andrew Eisenberg
2debadd3bf
Update changelog
2022-06-29 10:25:00 +01:00
Charis Kyriakou
6808d7dcaf
MRVA: Display alert text even if location is undefined ( #1407 )
2022-06-29 08:35:56 +01:00
Shati Patel
3480aa5495
Remove older CLI versions from testing matrix ( #1410 )
2022-06-28 14:07:11 +00:00
Shati Patel
a4d1ad57c7
Bump CLI version for integration tests ( #1409 )
2022-06-28 13:49:37 +00:00
Robert
628e0e924d
Merge pull request #1408 from github/robertbrignull/cutoff_repos
...
Add cutoff repos and counts to error message
2022-06-28 06:16:18 -07:00
Robert
16077f4124
Add cutoff repos to error message
2022-06-28 12:21:11 +01:00
Charis Kyriakou
e6a68b3223
Add ability to define repo lists in a file outside of settings ( #1402 )
2022-06-24 16:48:10 +01:00
Charis Kyriakou
539a494914
Only copy repos that have results when copying repo list ( #1406 )
2022-06-24 14:13:33 +01:00
Charis Kyriakou
9c29c5c9c6
Add ability to create repo list from MRVA results ( #1403 )
2022-06-24 09:26:12 +01:00
Charis Kyriakou
fd4b6022a9
Refactor: Invert dependency between query history and remote quries managers ( #1396 )
2022-06-23 13:28:57 +01:00
dependabot[bot]
58bbb59e39
Bump shell-quote from 1.7.2 to 1.7.3 in /extensions/ql-vscode
...
Bumps [shell-quote](https://github.com/substack/node-shell-quote ) from 1.7.2 to 1.7.3.
- [Release notes](https://github.com/substack/node-shell-quote/releases )
- [Changelog](https://github.com/substack/node-shell-quote/blob/master/CHANGELOG.md )
- [Commits](https://github.com/substack/node-shell-quote/compare/v1.7.2...1.7.3 )
---
updated-dependencies:
- dependency-name: shell-quote
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-06-23 10:58:47 +01:00
Robert
5cc55530e1
Merge pull request #1399 from github/robertbrignull/skipped_private_repos
...
Show in log message when repos are filtered out for being private
2022-06-23 02:28:54 -07:00
Robert
3d74dbf48a
Update extensions/ql-vscode/src/vscode-tests/no-workspace/remote-queries/run-remote-query.test.ts
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-06-23 10:16:37 +01:00
Elena Tanasoiu
b7489d8f66
Merge pull request #1400 from github/elenatanasoiu/check-for-codeql-folder-in-workspace
...
Fail fast if codeql repo is missing from the workspace
2022-06-23 09:26:40 +01:00
Elena Tanasoiu
e0b2aa9b45
Update docs for running cli-integration tests
2022-06-23 09:13:20 +01:00
Elena Tanasoiu
10b4c15053
Fail fast if codeql CLI is missing from the workspace
...
In order to run our cli-integration tests, we're required to have a
local copy of the codeql CLI repo. We can then run the tests by running
the `Launch Integration Tests - With CLI` task from inside VS Code.
(See CONTRIBUTING.md for details.)
If we don't have the CLI repo cloned locally or we're not pointing to it
in `launch.json`, we don't get a clear indication of what the problem is.
The tests will still attempt to run.
Let's fail fast instead and add an actionable error message to the output.
2022-06-23 09:13:20 +01:00
Robert
8bc83a336a
Show skipped private repos in log message
2022-06-22 17:18:29 +01:00
Elena Tanasoiu
c84b858205
Merge pull request #1397 from github/elenatanasoiu/improve-mrva-controller-feedback
...
MRVA: Improve experience when controller repo does not exist
2022-06-22 17:03:26 +01:00
Elena Tanasoiu
e5f3a973a0
Improve experience when controller repo does not exist
...
The controller repo is set via the `codeQL.variantAnalysis.controllerRepo`
setting in VSCode.
While we have validation to check that the repo is not null and the
format of the controller repo is correct: `<owner>/<repo>`, we still
allow you to provide a non-existent repo (e.g. a mispelled one).
When the MRVA request is sent over to the API, it will verify that the
repo exists and return a very generic "Not Found" response.
This will then be logged out in the "Output" tab for VSCode.
We'd like to give users a better indication of what has gone wrong in
this case so we're making the error message more verbose.
Co-authored-by: Charis Kyriakou <charisk@github.com >
Co-authored-by: Shati Patel <shati-patel@github.com >
2022-06-22 16:42:51 +01:00
Andrew Eisenberg
3682f05a42
Merge pull request #1398 from github/aeisenberg/integration-tests-fix
...
Fix failing integration test
2022-06-21 17:33:54 -07:00
Andrew Eisenberg
eb5ce029ba
Fix failing integration test
...
How did this ever work? It was using an old variant of the
qlpack name.
Also, this commit makes the unhandledRejection handler less
verbose. This gets hit when the tests end and there is a cancellation.
this is not an error.
2022-06-21 17:22:43 -07:00
Charis Kyriakou
0ebff2d6e6
Add ability of running MRVA against a whole org ( #1372 )
2022-06-21 09:19:07 +01:00
Andrew Eisenberg
d061634fe3
Merge pull request #1379 from github/aeisenberg/fix-bqrs-decode
...
Fix quoting of string columns in csv
2022-06-20 08:38:36 -07:00
Andrew Eisenberg
6b9410c67e
Merge pull request #1388 from github/aeisenberg/fix-flaky-test
...
Arcane workaround to fix a flaky test
2022-06-20 08:13:22 -07:00
Andrew Eisenberg
8245e54e9c
Update extensions/ql-vscode/src/vscode-tests/no-workspace/query-history.test.ts
2022-06-20 08:00:31 -07:00
Shati Patel
8ee744ef0c
Bump CLI version used in integration tests ( #1394 )
2022-06-20 12:02:53 +00:00
Charis Kyriakou
da179b2580
Use VSCodeProgressRing instead of Primer's Spinner ( #1392 )
2022-06-20 08:39:28 +01:00
Shati Patel
0714f06adc
MRVA: Include number of repositories queried in confirmation message ( #1393 )
2022-06-17 16:15:13 +01:00
Charis Kyriakou
b2906257a1
Remove use of Primer's box component ( #1389 )
2022-06-17 08:16:51 +01:00
Shati Patel
18097e4676
Allow repo names with periods ( #1391 )
2022-06-16 17:43:31 +01:00
Charis Kyriakou
efcade84c6
First pass at using VS Code UI toolkit ( #1382 )
2022-06-16 08:24:42 +00:00
Andrew Eisenberg
7f27375d17
Arcane workaround to fix a flaky test
...
For an inexplicable reason, the first time the selection
occurs, the value is incorrect. We often miss this error
in our tests if the expectation is reached before the
selection changed event fires.
It seems that the _second_ time the selection changed
event fires, the value is correct.
This change ensures we wait for the second selection change.
And we avoid running expectations until then.e
2022-06-15 15:16:51 -07:00
Andrew Eisenberg
01e1f134be
Merge pull request #1361 from github/dependabot/npm_and_yarn/extensions/ql-vscode/glob-promise-4.2.2
...
Bump glob-promise from 3.4.0 to 4.2.2 in /extensions/ql-vscode
2022-06-15 21:22:15 +02:00
dependabot[bot]
0695b0557f
Bump glob-promise from 3.4.0 to 4.2.2 in /extensions/ql-vscode
...
Bumps [glob-promise](https://github.com/ahmadnassri/node-glob-promise ) from 3.4.0 to 4.2.2.
- [Release notes](https://github.com/ahmadnassri/node-glob-promise/releases )
- [Commits](https://github.com/ahmadnassri/node-glob-promise/compare/v3.4.0...v4.2.2 )
---
updated-dependencies:
- dependency-name: glob-promise
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-06-15 18:24:24 +00:00
Elena Tanasoiu
c63f0c0833
Merge pull request #1387 from github/elenatanasoiu/node-18
...
Prepare for Node 18 upgrade
2022-06-15 19:23:01 +01:00
Elena Tanasoiu
3264ffaaa4
Upgrade webpack
...
We're upgrading the minimum version of webpack from 5.28.0 to 5.62.2
since this version doesn't rely on OpenSSL for its hashing algorithm so
it wouldn't need legacy OpenSSL support when we decide to upgrade to
Node 18.
This allows us to build our extension on Node 18:
https://github.com/github/vscode-codeql/runs/6904100934?check_suite_focus=true
Happily, this also works fine with our current version of Node (16.13.0).
2022-06-15 18:00:46 +01:00
Elena Tanasoiu
40959c8876
Use source-map 0.7.4
...
A new release of source-map was pushed 10 days ago:
https://github.com/mozilla/source-map/releases/tag/v0.7.4
It contains a fix for building on Node 18 (which was added in Oct
2020): https://github.com/mozilla/source-map/issues/423 .
Let's make use of it!
2022-06-15 18:00:38 +01:00
Elena Tanasoiu
ecea7f4638
Merge pull request #1386 from github/elenatanasoiu/update-release-docs
...
Follow guidance for git tagging in contribution docs
2022-06-15 17:27:27 +01:00
Elena Tanasoiu
0b15a166fa
Follow guidance for git tagging in contribution docs
...
Adding two things:
- A bit more detail on how to add a tag and how to delete a badly named one
- Switch to the official way of sharing tags according to the git docs[^1]
[^1]: https://git-scm.com/book/en/v2/Git-Basics-Tagging
2022-06-15 16:57:38 +01:00
elenatanasoiu
c368424a15
Bump version to v1.6.8
2022-06-15 15:42:36 +01:00
Elena Tanasoiu
5df1f80307
Merge pull request #1384 from github/v1.6.7
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.6.7
2022-06-15 15:03:00 +01:00
Elena Tanasoiu
4b59045149
v1.6.7
2022-06-15 13:41:11 +00:00
Andrew Eisenberg
a3a05131c7
Handle quote escaping in csv export
2022-06-13 11:17:37 -07:00
Elena Tanasoiu
a9922b86fe
Merge pull request #1374 from github/elenatanasoiu/set-node-version
...
Use the same Node version as VSCode
2022-06-13 16:54:10 +02:00
Elena Tanasoiu
431350ac0e
Merge pull request #1375 from github/elenatanasoiu/adjust-font-on-results
...
Use base styling for MRVA results font
2022-06-13 16:53:32 +02:00
Elena Tanasoiu
5f8802fe7f
Use base styling for MRVA results font
...
It's been pointed out that MRVA results are hard to read as the font is
small and narrowly spaced. It also doesn't match the font type normally
used in source files.
We can instead switch to using the font-family used by VS Code itself and
increase the font size from `x-small` to `small` for code snippets.
2022-06-13 14:28:15 +01:00
Elena Tanasoiu
5f21594d23
Provide a maximum node version in package.json
...
As recommended here https://github.com/github/vscode-codeql/pull/1369#issuecomment-1142418037 , since the current build for this extension does not work with Node v18 https://github.com/github/vscode-codeql/issues/1373 , it would be good to set a maximum node version until this gets addressed.
So we're updating `engines` here to allow for a maximum version, which in this case is v17.0.0.
2022-06-13 11:21:29 +01:00
Elena Tanasoiu
8964ec1a4d
Use the same Node version as VSCode
...
As recommended here https://github.com/github/vscode-codeql/pull/1369#issuecomment-1142418037 , we want to stay in sync with the current node version shipped with
VSCode (v16.13.0):
32d40cf44e/remote/.yarnrc (L2)
For this we can add a `.nvmrc` file to alert nvm to switch to the preferred version automatically.
It will also help prevent builds from failing when setting up the project for the first time, as building the extension currently fails in Node v18: https://github.com/github/vscode-codeql/issues/1373
We're also updating the docs to mention using `nvm` to manage node versions and point to the right place to check for current supported versions.
2022-06-13 11:21:25 +01:00
Andrew Eisenberg
aa270e57ec
Refactor exportCsvResults and create test
...
1. `exportCsvResults` now no longer requires an `onFinish` callback.
2. The test adds a generic framework for creating a mock cli server.
This should be used in future tests.
2022-06-06 10:21:12 +02:00
Andrew Eisenberg
fe7eb07f39
Don't choose a non-existent result set for csv viewing
...
If the `#select` resultset doesn't exist, arbitrarily choose the first
result set when viewing csv results. This will almost certainly be the
correct result set.
In the future, we could offer a popup if there are multiple result sets
available, but let's wait on that until someone actually asks for it.
2022-06-06 09:23:40 +02:00
Andrew Eisenberg
c10da7f960
Update Changelog
2022-06-03 16:26:02 -07:00
Andrew Eisenberg
0c8390c094
Fix quoting of string columns in csv
2022-06-03 16:24:10 -07:00
shati-patel
d41c63bf7d
Change parameter type + extract local variable
2022-06-01 21:19:35 +01:00
shati-patel
a3bbdafabb
Add tests for 'tryGetRemoteLocation'
2022-06-01 21:19:35 +01:00
shati-patel
a78eef464b
Handle undefined URLs
2022-06-01 21:19:35 +01:00
shati-patel
e8348ac12a
Check format of URI
2022-06-01 21:19:35 +01:00
shati-patel
5efc3835db
Add sourceLocationPrefix to one of the test files
2022-06-01 21:19:35 +01:00
shati-patel
c4ed6e88de
Pass sourceLocationPrefix down through all the functions
2022-06-01 21:19:35 +01:00
shati-patel
51e6559145
Update tryGetRemoteLocation to use sourceLocationPrefix (if available)
2022-06-01 21:19:35 +01:00
Charis Kyriakou
db8b419885
Combine time constants ( #1371 )
2022-06-01 16:52:18 +01:00
Elena Tanasoiu
475d7cc535
Merge pull request #1369 from github/elenatanasoiu/fix-casing-query-history
...
Be consistent about casing in Query History menu
2022-06-01 12:24:29 +01:00
Elena Tanasoiu
1858de5ed0
Update Changelog
2022-06-01 12:07:13 +01:00
Angela P Wen
642f4788fb
Update tests to CLI v2.9.3 ( #1370 )
2022-05-31 17:44:43 +00:00
Elena Tanasoiu
7e70f8b758
Be consistent about casing in Query History
...
Reported here: https://github.com/github/code-scanning/issues/6008
We originally started out by capitalizing each word [1], but made some
small changes [2] which resulted in our Query History options
being inconsistent.
Let's fix that.
[1]: a5da556496/extensions/ql-vscode/package.json
[1]: b470e41431
2022-05-31 18:34:37 +01:00
Charis Kyriakou
e417bea948
Move time constants to time module ( #1368 )
2022-05-31 13:21:45 +01:00
Andrew Eisenberg
6b4be93169
Merge pull request #1363 from github/aeisenberg/resolve-ml-model
...
Add new support for resolve ml-models
2022-05-30 18:46:53 -07:00
Andrew Eisenberg
061eaad743
Update extensions/ql-vscode/src/cli.ts
...
Change version where precise ml-model resolution was introduced.
2022-05-30 18:32:11 -07:00
Andrew Eisenberg
8ff21d6c89
Merge pull request #1365 from github/aeisenberg/time
...
Extract time functions
2022-05-30 07:54:18 -07:00
Andrew Eisenberg
0d9f4e8c0f
Merge pull request #1366 from github/aeisenberg/handle-missing-nwo
...
Handle missing nwos returned from graphql query
2022-05-30 07:53:55 -07:00
Andrew Eisenberg
02288718dc
Handle missing nwos returned from graphql query
2022-05-27 13:12:49 -07:00
Andrew Eisenberg
615cf86fc0
Refactor time functions
...
Rename, add comments, and extract some local variables.
2022-05-27 08:51:14 -07:00
Andrew Eisenberg
d63a209674
Make conditional statement more explicit
2022-05-27 07:08:58 -07:00
Andrew Eisenberg
9d26304f7a
Extract time functions
...
Create the `time.ts` module as a place to put fime functions.
Move two time functions there and create tests for them.
The `humanizeUnit` function now uses ECMAscript apis. This ensures
that pluralization happens appropriately.
Also, fix a small bug in the results view to enure `repository`
is correctly pluralized.
2022-05-26 15:47:03 -07:00
Andrew Eisenberg
f73bda438a
Merge pull request #1362 from github/aeisenberg/last-update-sort
...
Add sort MRVA results by last updated
2022-05-26 09:15:37 -07:00
Andrew Eisenberg
19b65a654e
Fix method name
2022-05-26 08:44:04 -07:00
Andrew Eisenberg
770127e67a
Use the repo push icon
2022-05-26 06:55:12 -07:00
Andrew Eisenberg
f373e6467a
Store LastUpdated as a duration, not a timestamp
...
The `lastUpdated` value is now the duration between timestamp of the
last time the repo was updated and time the file was downloaded.
This fixes the duration and it won't change over time.
2022-05-25 20:30:28 -07:00
Andrew Eisenberg
e43b4e66a1
Add sort MRVA results by last updated
...
1. Refactor references of `Stargazers` to `RepositoryMetadata` since
the query is now more generic.
2. Update the graphql query to request last updated as well as stars
3. Update web view to display last updated
4. Update sort mechanism for last updated
A few notes:
1. I used `Intl.RelativeTimeFormat` to humanize the times. It wasn't as
simple as I had hoped since I need to also make a guess as to which
unit to use.
2. The icon used by last updated is not quite what is in the wireframes.
But, I wanted to stick with primer icons and I used the closest I can
get.
3. The last updated time is retrieved when the query is first loaded
into vscode and then never changes. However, this time is always
compared with `Date.now()`. So, opening the query up a week from now,
all of the last updated times would be one week older (even if the
repository has been updated since then).
I don't want to re-retrieve the last updated time each time we open
the query, so this timestamp will get out of date eventually.
Is this confusing as it is?
2022-05-24 19:57:40 -07:00
Andrew Eisenberg
90ec003386
Add new support for resolve ml-models
...
The new support will be available in the next
release of the CLI, most likely 2.9.3,
This change requires the query to be run to be
passed in to the call to resolve ml-models.
2022-05-24 17:24:46 -07:00
Angela P Wen
2f9aca785e
Log most expensive predicates and timings to query log ( #1349 )
2022-05-20 13:21:33 -07:00
Andrew Eisenberg
405a6c9901
Merge pull request #1353 from github/aeisenberg/sort-remote-results
...
Add sorting to variant analysis results
2022-05-20 09:23:10 -07:00
Andrew Eisenberg
3611b1fe61
Add comments and simplify some JSX
...
Use `ActionMenu.Anchor` instead of `ActionMenu.Button`.
The theming styles are not correct. Will work on that next.
2022-05-20 08:01:54 -07:00
Andrew Eisenberg
7b33441519
Merge pull request #1360 from github/dependabot/npm_and_yarn/extensions/ql-vscode/mocha-10.0.0
...
Bump mocha from 9.1.3 to 10.0.0 in /extensions/ql-vscode
2022-05-19 08:29:52 -07:00
dependabot[bot]
2a8f61dfbe
Bump mocha from 9.1.3 to 10.0.0 in /extensions/ql-vscode
...
Bumps [mocha](https://github.com/mochajs/mocha ) from 9.1.3 to 10.0.0.
- [Release notes](https://github.com/mochajs/mocha/releases )
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mochajs/mocha/compare/v9.1.3...v10.0.0 )
---
updated-dependencies:
- dependency-name: mocha
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-05-19 13:05:48 +00:00
Andrew Eisenberg
dcfd6d43c0
Merge pull request #1307 from github/dependabot/npm_and_yarn/extensions/ql-vscode/js-yaml-4.1.0
...
Bump js-yaml from 3.14.0 to 4.1.0 in /extensions/ql-vscode
2022-05-18 15:03:36 -07:00
Andrew Eisenberg
4e4d8b2f04
Fix js-yaml issues
...
With js-yaml 4.0, safeLoad is no longer available. Use load instead.
2022-05-18 14:45:28 -07:00
Andrew Eisenberg
50197ba7b7
Merge pull request #1308 from github/dependabot/npm_and_yarn/extensions/ql-vscode/style-loader-3.3.1
...
Bump style-loader from 0.23.1 to 3.3.1 in /extensions/ql-vscode
2022-05-18 14:40:50 -07:00
Andrew Eisenberg
6c376d8721
Add integration test for ensuring the graphql query succeeds
2022-05-18 14:20:24 -07:00
Andrew Eisenberg
82ada54103
Add sorting to variant analysis results
...
Sort by stars, number of results, and name.
This also includes a graphql query that retrieves all the stars
for relevant repositories.
2022-05-18 13:56:17 -07:00
shati-patel
0fdfeb3cd3
Bump version to v1.6.7
2022-05-17 16:37:42 +01:00
shati-patel
096d7719c6
v1.6.6
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2022-05-17 16:07:06 +01:00
Angela P Wen
619c485224
Show query results before structured evaluator log summary completes ( #1350 )
2022-05-17 10:45:52 -04:00
Shati Patel
9367d5fb45
MRVA: Export results to local markdown files ( #1344 )
2022-05-17 10:03:23 +01:00
Shati Patel
50ec97ad91
Update CLI version used in tests
2022-05-16 17:43:06 +01:00
shati-patel
fa5fcde987
Rename button component
2022-05-16 16:45:07 +01:00
shati-patel
5b33333404
Fix padding to match design doc
2022-05-16 16:45:07 +01:00
shati-patel
cf50624e4e
Tidy up
2022-05-16 16:45:07 +01:00
shati-patel
ccc9ed8b49
MRVA: Add webview button to export results
2022-05-16 16:45:07 +01:00
shati-patel
141f5381e7
MRVA: Export results from query history
2022-05-16 10:08:46 +01:00
shati-patel
be054ca4f8
Move "exporting results" to a separate file
2022-05-12 13:26:16 +01:00
Shati Patel
0a06452450
Update extensions/ql-vscode/src/remote-queries/remote-queries-manager.ts
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2022-05-11 17:27:45 +01:00
shati-patel
b840d3f9bf
Tidy up Gist creation
2022-05-11 17:27:45 +01:00
shati-patel
c829c30688
MRVA: Add command to export markdown results to gist
2022-05-11 17:27:45 +01:00
Shati Patel
7947afb1b4
Remove unnecessary commas from alert shortDescription
2022-05-10 11:39:41 +01:00
dependabot[bot]
c32b53613d
Bump js-yaml from 3.14.0 to 4.1.0 in /extensions/ql-vscode
...
Bumps [js-yaml](https://github.com/nodeca/js-yaml ) from 3.14.0 to 4.1.0.
- [Release notes](https://github.com/nodeca/js-yaml/releases )
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nodeca/js-yaml/compare/3.14.0...4.1.0 )
---
updated-dependencies:
- dependency-name: js-yaml
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-05-09 21:51:58 +00:00
Andrew Eisenberg
c058e7a128
Merge pull request #1340 from github/aeisenberg/fix-integration-tests
...
Fix cli-integration tests
2022-05-09 14:48:17 -07:00
Andrew Eisenberg
1dc663339d
Revert back to vscode-test
2022-05-09 14:02:22 -07:00
Andrew Eisenberg
351db4efc8
Fix cli-integration tests
...
The main problem this commit fixes is with vscode 1.67.0, an error is
thrown when inside of integration tests and a dialog box is opened. We
were opening the telemetry dialog box. Now, an env variable is set
during cli-integration tests that prevents the dialog from being
opened.
There are also other cleanups and improvements with cli-integration
tests that assist with running locally:
- `vscode-test` dependency has been renamed to `@vscode/test-electron`,
so use that instead and make the small API changes to support it.
- Commit the codeql-pack.lock.yml file so it isn't recreated on each
test run.
- Ensure all databases are removed before _and after_ each test run
that manipulates the set of installed databases
- Similarly, for quick query files, delete them before and after each
test.
- Change some async `forEach` blocks to for loops in order to support
sequential operations more easily.
2022-05-09 13:50:28 -07:00
Shati Patel
12d6ea3966
Update CLI version used in tests
2022-05-05 18:17:18 +01:00
shati-patel
e1adc7b428
MRVA: Rename summary file to make it appear first alphabetically
2022-05-05 14:32:55 +01:00
shati-patel
dc34adadcd
Tidy up tests to use expected directory
2022-05-05 14:01:39 +01:00
shati-patel
6e06381640
Move expected files into subdirectory
2022-05-05 14:01:39 +01:00
shati-patel
f55389cd26
MRVA: Also test names of generated markdown files
2022-05-05 14:01:39 +01:00
shati-patel
6d930f53ba
Don't include file extension for summary file
...
(to be consistent with other markdown files)
2022-05-04 17:18:00 +01:00
shati-patel
f7616cf685
Refactor: Include filename when generating markdown
2022-05-04 17:18:00 +01:00
Andrew Eisenberg
f55d9820bd
Merge pull request #1329 from github/aeisenberg/run-queries-message
...
Further massage the message after running remote queries
2022-05-04 08:03:04 -07:00
Andrew Eisenberg
befc2cddd2
Apply suggestions from code review
...
Co-authored-by: Robert <robertbrignull@github.com >
2022-05-04 07:46:53 -07:00
Andrew Eisenberg
ef268e043f
Further massage the message after running remote queries
2022-05-03 16:38:44 -07:00
Dave Bartolomeo
cff235c420
Auto-format
2022-05-03 18:14:03 -04:00
Dave Bartolomeo
1089a052ec
Initial implementation of join order metric scanning
2022-05-03 13:20:30 -04:00
Charis Kyriakou
e10d2aef8e
Upgrade node version minimum requirement ( #1326 )
2022-05-03 16:10:45 +01:00
Charis Kyriakou
a97c5fe836
MRVA: Support both local and gist links when generating markdown
2022-05-03 13:27:53 +01:00
shati-patel
9b6eddddae
MRVA: Expand path results individually
2022-04-29 18:50:30 +01:00
shati-patel
ed84825e65
See if replaceAll works on actions
2022-04-29 14:58:16 +01:00
shati-patel
cb84003c31
Actually fix the test + code scanning error 🤞🏽
2022-04-29 14:58:16 +01:00
shati-patel
a1cd87aa3a
Update test data + try to fix code scanning error
2022-04-29 14:58:16 +01:00
shati-patel
7d3b015e20
Generate markdown for raw result tables
2022-04-29 14:58:16 +01:00
Charis Kyriakou
7d0d11f526
MRVA: Add view on GitHub action to cancelled/failed queries ( #1325 )
2022-04-29 11:11:33 +01:00
Shati Patel
eb2520e7ca
Fix outdated description of "watch" command
2022-04-28 15:29:38 +01:00
shati-patel
2675bf464e
Correctly indent code snippets that use tabs
2022-04-28 12:03:39 +01:00
shati-patel
b638449498
Link to specific highlighted line instead of whole code snippet
2022-04-28 12:03:39 +01:00
Dave Bartolomeo
1d195cb347
Merge remote-tracking branch 'origin/main' into dbartol/join-order
2022-04-27 17:50:50 -04:00
Dave Bartolomeo
8d8ed28aea
Add necessary dependencies
2022-04-27 17:50:46 -04:00
shati-patel
e12bf63f9a
Minor tidy-up
2022-04-27 16:45:01 +01:00
shati-patel
ffcc1f82f1
Generate markdown summary file for raw results
2022-04-27 16:45:01 +01:00
shati-patel
04d7b12dd8
Extract "getAnalysisResultCount" to helper file
2022-04-27 16:45:01 +01:00
shati-patel
3e33b00a75
Add test data for raw results
2022-04-27 16:45:01 +01:00
Andrew Eisenberg
12dc378fc1
Merge pull request #1305 from github/aeisenberg/mrva-result-message
...
Update the warning message after running variant analysis
2022-04-26 11:46:03 -07:00
Andrew Eisenberg
bbe99f4451
Fix newlines in tests
2022-04-26 11:34:00 -07:00
shati-patel
91b17f8fa6
Update CLI version used in tests
2022-04-26 14:36:48 +01:00
Shati Patel
69f1778309
Update extensions/ql-vscode/src/remote-queries/remote-queries-markdown-generation.ts
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2022-04-26 10:15:45 +01:00
shati-patel
c55e801d00
Add example with multiple paths
2022-04-26 10:15:45 +01:00
shati-patel
b363f77a83
Tidy up how we display paths
2022-04-26 10:15:45 +01:00
shati-patel
f55f46f95b
Markdown rendering: Display paths
2022-04-26 10:15:45 +01:00
github-actions[bot]
5ee2f0efe1
Bump version to v1.6.6 ( #1315 )
...
Co-authored-by: angelapwen <angelapwen@users.noreply.github.com >
2022-04-25 10:34:34 -07:00
Angela P Wen
1314a36ba4
v1.6.5 ( #1314 )
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com >
2022-04-25 09:42:44 -07:00
shati-patel
2b8b621298
10% nicer way of wrapping code lines 😄
...
+ update test data to contain a single-line example
2022-04-25 12:42:10 +01:00
shati-patel
aed4c9fc58
MRVA: Make markdown code snippets look nicer
...
Remove some extraneous newlines
2022-04-25 12:42:10 +01:00
Andrew Eisenberg
604001dfb1
Update extensions/ql-vscode/src/remote-queries/run-remote-query.ts
...
Move comment
2022-04-22 13:42:10 -07:00
shati-patel
1a03c0e4ac
Attempt to fix tests
2022-04-22 14:52:15 +01:00
shati-patel
a8c54b7640
MRVA: Don't display excessive error/warning pop-ups if user doesn't select a repo list
2022-04-22 14:52:15 +01:00
shati-patel
9bb60c9474
Link to workflow + fix incorrect comment
2022-04-22 13:01:54 +01:00
shati-patel
0b2ce7a071
MRVA: Display available results, even if some jobs are cancelled
2022-04-22 13:01:54 +01:00
Andrew Eisenberg
44145baca7
Use os.EOL instead of \n
2022-04-21 08:47:48 -07:00
Angela P Wen
dac7881ca3
Bug fix for show eval log and show eval log summary commands in query history view ( #1304 )
2022-04-21 08:11:58 -07:00
Charis Kyriakou
31bd927959
Fix max-width for code paths ( #1309 )
2022-04-21 13:12:40 +00:00
dependabot[bot]
46922de3c0
Bump style-loader from 0.23.1 to 3.3.1 in /extensions/ql-vscode
...
Bumps [style-loader](https://github.com/webpack-contrib/style-loader ) from 0.23.1 to 3.3.1.
- [Release notes](https://github.com/webpack-contrib/style-loader/releases )
- [Changelog](https://github.com/webpack-contrib/style-loader/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/style-loader/compare/v0.23.1...v3.3.1 )
---
updated-dependencies:
- dependency-name: style-loader
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-04-21 13:02:49 +00:00
shati-patel
908a862dd1
Tidy up test
2022-04-21 09:57:23 +01:00
shati-patel
6676ba99d0
Add initial test data for problem query
2022-04-21 09:57:23 +01:00
shati-patel
6d3c6e598f
Change folder structure to have separate folders for path-problem and problem queries
2022-04-21 09:57:23 +01:00
shati-patel
e1a10fc827
Markdown results: Highlight snippets with "<strong>"
2022-04-21 09:17:31 +01:00
Andrew Eisenberg
2ebdbaafa3
Update the warning message after running variant analysis
...
Adds more information about onboarding new repos.
2022-04-20 14:46:23 -07:00
shati-patel
a74dfea08b
Use HTML code blocks
...
This is so that we can highlight code snippets using `<strong>` tags
2022-04-20 10:32:24 +01:00
Andrew Eisenberg
44ff380c86
Merge pull request #1295 from github/aeisenberg/result-log
...
Add better error messages for partial failing variant analysis
2022-04-19 17:55:31 -07:00
Andrew Eisenberg
0a41713253
Add new test
...
And rename test file.
2022-04-19 17:45:17 -07:00
Andrew Eisenberg
f5a5675da4
Merge pull request #1298 from github/aeisenberg/no-results-mixing
...
Avoid loading wrong results into an open window
2022-04-19 16:02:14 -07:00
Andrew Eisenberg
7a8cf55090
Merge pull request #1294 from github/aeisenberg/db-name-github
...
Display nicer names for github-downloaded databases
2022-04-19 16:01:04 -07:00
Andrew Eisenberg
7932de3b7d
Merge pull request #1299 from github/aeisenberg/remove-jsonc
2022-04-18 09:06:13 -07:00
Andrew Eisenberg
c8ba967a54
Remove jsonc dependency
...
This dependency was only used to parse package.json and
this can be just as easily parsed by regular JSON object.
jsonc can also parse JSON with comments, but there are no
comments in package.json.
2022-04-14 15:45:24 -07:00
Andrew Eisenberg
f5d2f0e0ca
Merge pull request #1263 from github/dependabot/npm_and_yarn/extensions/ql-vscode/zip-a-folder-1.1.3
...
Bump zip-a-folder from 0.0.12 to 1.1.3 in /extensions/ql-vscode
2022-04-14 15:36:44 -07:00
Andrew Eisenberg
2c7e2f4b7f
Avoid loading wrong results into an open window
...
This fixes a bug where an open results view will accumulate results from
other queries who have their results downloaded while this view is open.
The fix is to ensure that the results view for the query is open when
some results are downloaded.
2022-04-14 14:54:42 -07:00
dependabot[bot]
ee3ebe687b
Bump zip-a-folder from 0.0.12 to 1.1.3 in /extensions/ql-vscode
...
Bumps [zip-a-folder](https://github.com/maugenst/zip-a-folder ) from 0.0.12 to 1.1.3.
- [Release notes](https://github.com/maugenst/zip-a-folder/releases )
- [Commits](https://github.com/maugenst/zip-a-folder/commits )
---
updated-dependencies:
- dependency-name: zip-a-folder
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-04-14 21:09:55 +00:00
Andrew Eisenberg
77024f0757
Merge pull request #1297 from github/dependabot/npm_and_yarn/extensions/ql-vscode/async-2.6.4
...
Bump async from 2.6.3 to 2.6.4 in /extensions/ql-vscode
2022-04-14 14:08:46 -07:00
Andrew Eisenberg
c0e39886eb
Add unit tests for remote queries in logs
...
Also, change text slightly.
2022-04-14 13:39:36 -07:00
dependabot[bot]
6339e7897d
Bump async from 2.6.3 to 2.6.4 in /extensions/ql-vscode
...
Bumps [async](https://github.com/caolan/async ) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases )
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md )
- [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4 )
---
updated-dependencies:
- dependency-name: async
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-04-14 19:41:37 +00:00
Andrew Eisenberg
783a8a8772
Merge pull request #1290 from github/aeisenberg/remote-history-label-editing
...
Allow remote query items to have their labels edited
2022-04-14 12:40:50 -07:00
Andrew Eisenberg
8f2d865999
Display nicer names for github-downloaded databases
...
This will now name databases downloaded from github based on their nwo.
Also, this adds a new button to suggest downloading from github in an
empty databases view.
2022-04-14 12:36:43 -07:00
Andrew Eisenberg
d6d0825926
Merge branch 'main' into aeisenberg/remote-history-label-editing
2022-04-14 12:30:08 -07:00
Andrew Eisenberg
37de2e7f52
Add better error messages for partial failing variant analysis
...
Two scenarios handled:
1. no database for existing repo
2. repo does not exits (or no access rights for current user)
In either case, an error message is sent to the logs, with a notificaiton
in a popup.
2022-04-13 16:32:13 -07:00
Andrew Eisenberg
800c9e0c93
Remove deprecated comments
...
Also, change interpolation of result count. For Remote queries, this
value will be empty. For local queries, use the label `X results`, where
`X` is the number of results for this query.
2022-04-13 14:08:44 -07:00
shati-patel
a1bc7eb4d5
Capitalize!
2022-04-13 17:00:17 +01:00
shati-patel
8ff45d2aee
Split handling of highlighted code lines into helper function
2022-04-13 17:00:17 +01:00
Andrew Eisenberg
8ec19777b5
Merge pull request #1291 from github/aeisenberg/handle-remote-cancel
...
Handle cancelling of remote queries
2022-04-13 06:59:14 -07:00
Andrew Eisenberg
3e388fedeb
Merge pull request #1292 from github/aeisenberg/rename-remote-queries
...
Rename remote queries -> variant analysis
2022-04-13 06:41:33 -07:00
Andrew Eisenberg
83ffba2f08
Rename remote queries -> variant analysis
...
In some user facing text.
2022-04-12 13:16:44 -07:00
Andrew Eisenberg
f1c4fef8ba
Allow remote query items to have their labels edited
...
The labels for remote query items are interpolated using the same
strategy as local queries with two caveats:
1. There is no easy way to get the result count without reading files,
so, this value is kept empty.
2. There is no database name for remote queries. Instead, use the
nwo of the controller repo.
Also, adds tests for the history item label provider.
2022-04-12 12:37:31 -07:00
Andrew Eisenberg
eec506a209
Introduce history-item-label-provider
...
The label provider is the instance that performs the logic for
generating labels for history items, using string interpolation when
necessary.
This commit creates the label provider and uses it with local queries.
Remote queries will be changed in the next commit.
2022-04-12 12:35:01 -07:00
Andrew Eisenberg
2ca0060c6a
Remove references to 'remote query' in user-facing text
...
(Only in recently introduced locations. More work still needs to be
done.)
Also:
- Change error to info
- Create credentials directly, don't use a callback.
2022-04-12 12:20:39 -07:00
shati-patel
8b2d79a7f7
Formatting fixes and code tidy-up
2022-04-12 12:32:45 +01:00
shati-patel
c4db8b6d4b
Create markdown summary file for sharing MRVA results
2022-04-12 12:32:45 +01:00
Andrew Eisenberg
61d4305593
Handle cancelling of remote queries
...
This change issues a cancel request when the user clicks on "cancel" for
a remote query.
The cancel can take quite a while to complete, so a message is popped up
to let the user know.
2022-04-11 19:05:00 -07:00
Andrew Eisenberg
542e1d24aa
Allow remote query items to have their labels edited
...
The labels for remote query items are interpolated using the same
strategy as local queries with two caveats:
1. There is no easy way to get the result count without reading files,
so, this value is kept empty.
2. There is no database name for remote queries. Instead, use the
nwo of the controller repo.
2022-04-11 14:20:57 -07:00
shati-patel
47ec074cfb
Tidy-up and address review comments
2022-04-11 15:24:08 +01:00
shati-patel
e44835e795
Make line endings consistent?
2022-04-11 15:24:08 +01:00
shati-patel
2e28146a58
Create markdown files for sharing results
2022-04-11 15:24:08 +01:00
Andrew Eisenberg
85e051a76d
Merge pull request #1285 from github/aeisenberg/reenable-openvsx
...
Reenable publishing to open-vsx
2022-04-08 09:40:40 -07:00
Andrew Eisenberg
7027a61e63
Update changelog
2022-04-07 14:01:28 -07:00
Andrew Eisenberg
e8c5b27d92
Reenable publishing to open-vsx
...
The extension ms-vscode.test-adapter-converter is now available on
open-vsx, but under a different name.
Fixes https://github.com/github/vscode-codeql/issues/1085
I have verified that I can publish and install the extension by
manually publishing v1.6.4.
2022-04-07 13:58:16 -07:00
Andrew Eisenberg
a3deec7875
Merge pull request #1280 from febuiles/patch-2
...
Update dependency-review.yml
2022-04-07 08:39:47 -07:00
Andrew Eisenberg
6282a462c8
Merge pull request #1283 from github/bump-cli
2022-04-07 07:44:29 -07:00
Shati Patel
dac5952e96
Bump CLI version used in integration tests
2022-04-07 15:30:41 +01:00
Federico Builes
ada6fcb908
Try using workflow_dispatch.
2022-04-07 13:36:57 +02:00
Andrew Eisenberg
8d2f902420
Merge pull request #1282 from github/version/bump-to-v1.6.5
...
Bump version to v1.6.5
2022-04-07 02:11:28 -07:00
aeisenberg
fc3fe7a81e
Bump version to v1.6.5
2022-04-06 22:39:04 +00:00
Andrew Eisenberg
426cc95e9f
Merge pull request #1281 from github/v1.6.4
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.6.4
2022-04-06 15:36:05 -07:00
Andrew Eisenberg
9e40043fe0
v1.6.4
2022-04-06 14:54:56 -07:00
Federico Builes
14608fe5f7
Update dependency-review.yml
2022-04-06 15:17:40 +02:00
Charis Kyriakou
22ed090685
Add support for system defined repository lists ( #1271 )
2022-04-06 09:05:22 +01:00
Charis Kyriakou
2ca4097daf
Move remote queries test files to be under remote-queries dir ( #1270 )
2022-04-05 08:40:10 +01:00
github-actions[bot]
f1d16015bf
Bump version to v1.6.4 ( #1278 )
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-04-04 23:44:55 +00:00
Andrew Eisenberg
9a81ad05ed
Merge pull request #1277 from github/v1.6.3
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.6.3
2022-04-04 12:39:27 -07:00
Andrew Eisenberg
76e983d19c
v1.6.3
...
Also adds a step in our release process to manually test the new
extension build.
2022-04-04 12:30:41 -07:00
Andrew Eisenberg
a3015c0fa3
Merge pull request #1276 from github/aeisenberg/dev-dependencies
...
Move source-map-support to dependencies
2022-04-04 12:27:09 -07:00
Andrew Eisenberg
88d0bda049
Move source-map-support to dependencies
2022-04-04 12:15:57 -07:00
Andrew Eisenberg
d2ec54e89e
Merge pull request #1273 from github/version/bump-to-v1.6.3
...
Bump version to v1.6.3
2022-04-04 09:10:52 -07:00
edoardopirovano
4559c5a38d
Bump version to v1.6.3
2022-04-04 15:28:36 +00:00
Edoardo Pirovano
16bd106abc
v1.6.2
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2022-04-04 08:25:23 -07:00
Charis Kyriakou
e5dcec8d8e
Move repository selection code to own module ( #1269 )
2022-04-04 11:03:53 +01:00
Charis Kyriakou
ad3565d3ad
Use the repos defined in the query result instead of the query ( #1268 )
2022-04-04 11:03:05 +01:00
Andrew Eisenberg
5fe12ecd74
Merge pull request #1265 from github/aeisenberg/pat-instructions-update
...
Move vscode marketplace pat isntructions to internal docs
2022-03-31 12:24:51 -07:00
Andrew Eisenberg
318214642f
Merge pull request #1249 from github/dependabot/npm_and_yarn/extensions/ql-vscode/ts-node-10.7.0
...
Bump ts-node from 8.10.2 to 10.7.0 in /extensions/ql-vscode
2022-03-31 12:15:43 -07:00
Andrew Eisenberg
227fe3ee6b
Fix typo
...
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com >
2022-03-31 12:12:57 -07:00
dependabot[bot]
978a82dd1a
Bump ts-node from 8.10.2 to 10.7.0 in /extensions/ql-vscode
...
Bumps [ts-node](https://github.com/TypeStrong/ts-node ) from 8.10.2 to 10.7.0.
- [Release notes](https://github.com/TypeStrong/ts-node/releases )
- [Commits](https://github.com/TypeStrong/ts-node/compare/v8.10.2...v10.7.0 )
---
updated-dependencies:
- dependency-name: ts-node
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-03-31 18:51:38 +00:00
Andrew Eisenberg
04f72a7da9
Merge pull request #1260 from github/aeisenberg/source-map-support
...
Add source map support and clean test dependencies
2022-03-31 11:42:22 -07:00
Andrew Eisenberg
a0954a1dc0
Move vscode marketplace pat isntructions to internal docs
2022-03-31 10:22:33 -07:00
Angela P Wen
cc1bf74370
Print end-of-query summary logs to Query Server Console ( #1264 )
...
* Log new end summary file to query server console
* Change supported CLI version to 2.9.0
2022-03-31 16:26:13 +00:00
Andrew Eisenberg
2f7908773a
Merge pull request #1253 from github/aeisenberg/codeSnippet-handling
2022-03-31 07:19:44 -07:00
Andrew Eisenberg
0efd02979e
Merge pull request #1242 from github/aeisenberg/analysis-results-on-restart
2022-03-31 07:19:02 -07:00
shati-patel
bd9776c4b7
Variant analysis: Remove handling of invalid repos
...
This is now done automatically on the API side
2022-03-31 15:15:16 +01:00
Andrew Eisenberg
35e9da83ec
Add source map support and clean test dependencies
...
1. Source map support means that stack traces will point to the *.ts
file instead of the generated *.js file
2. Cleaning test dependencies means moving all mocha and chai
registration into the respective index files and removing unnecessary
imports.
2022-03-30 12:30:18 -07:00
Andrew Eisenberg
4f5ca0bca9
Merge pull request #1261 from github/aeisenberg/dependabot-changes
...
Run dependabot updates weekly
2022-03-30 12:05:06 -07:00
Andrew Eisenberg
43f314b2b5
Change missing code snippet handling in UI
...
Also, simplify sarif tests.
2022-03-30 12:02:19 -07:00
Andrew Eisenberg
4bdf579ce2
Merge branch 'aeisenberg/analysis-results-on-restart' into aeisenberg/codeSnippet-handling
2022-03-30 11:57:24 -07:00
Andrew Eisenberg
aba3039eef
Merge pull request #1257 from github/dependabot/npm_and_yarn/extensions/ql-vscode/sinon-13.0.1
...
Bump sinon from 9.0.2 to 13.0.1 in /extensions/ql-vscode
2022-03-30 11:48:11 -07:00
Andrew Eisenberg
bbff791c65
Merge pull request #1258 from github/dependabot/npm_and_yarn/extensions/ql-vscode/gulp-sourcemaps-3.0.0
...
Bump gulp-sourcemaps from 2.6.5 to 3.0.0 in /extensions/ql-vscode
2022-03-30 11:47:20 -07:00
Andrew Eisenberg
1ed50b3081
Run dependabot updates weekly
...
Daily is too noisy.
2022-03-30 11:45:39 -07:00
Andrew Eisenberg
67336a24e7
Simplify checking for downloaded analyses
...
And some renaming.
2022-03-30 11:30:10 -07:00
Andrew Eisenberg
48174c327d
Merge pull request #1246 from github/aeisenberg/repo-filter
...
Add repositories search box
2022-03-30 11:14:27 -07:00
Andrew Eisenberg
43f2539b42
Remove unused css class
2022-03-30 10:54:14 -07:00
dependabot[bot]
462a7a722a
Bump gulp-sourcemaps from 2.6.5 to 3.0.0 in /extensions/ql-vscode
...
Bumps [gulp-sourcemaps](https://github.com/gulp-sourcemaps/gulp-sourcemaps ) from 2.6.5 to 3.0.0.
- [Release notes](https://github.com/gulp-sourcemaps/gulp-sourcemaps/releases )
- [Commits](https://github.com/gulp-sourcemaps/gulp-sourcemaps/compare/v2.6.5...v3.0.0 )
---
updated-dependencies:
- dependency-name: gulp-sourcemaps
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-03-30 13:04:47 +00:00
dependabot[bot]
4101bb252e
Bump sinon from 9.0.2 to 13.0.1 in /extensions/ql-vscode
...
Bumps [sinon](https://github.com/sinonjs/sinon ) from 9.0.2 to 13.0.1.
- [Release notes](https://github.com/sinonjs/sinon/releases )
- [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md )
- [Commits](https://github.com/sinonjs/sinon/compare/v9.0.2...v13.0.1 )
---
updated-dependencies:
- dependency-name: sinon
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-03-30 13:04:31 +00:00
Shati Patel
4ff4e4827e
Bump CLI version in integration tests
2022-03-30 12:03:16 +01:00
Andrew Eisenberg
8daa92ad49
Merge branch 'main' into aeisenberg/analysis-results-on-restart
2022-03-29 16:04:35 -07:00
Andrew Eisenberg
371e83bff9
Merge branch 'aeisenberg/analysis-results-on-restart' into aeisenberg/codeSnippet-handling
2022-03-29 15:30:08 -07:00
Andrew Eisenberg
6fa0227a1e
Merge branch 'main' into aeisenberg/codeSnippet-handling
2022-03-29 15:08:17 -07:00
Andrew Eisenberg
c38e4ce265
Merge pull request #1252 from github/aeisenberg/settings
...
Prevent cli path from being synced across remote instances
2022-03-29 14:23:51 -07:00
Andrew Eisenberg
de06ed148d
Merge branch 'main' into aeisenberg/analysis-results-on-restart
2022-03-29 14:21:15 -07:00
Andrew Eisenberg
21bcd62ba8
Merge pull request #1239 from github/dependabot/npm_and_yarn/extensions/ql-vscode/types/gulp-replace-1.1.0
...
Bump @types/gulp-replace from 0.0.31 to 1.1.0 in /extensions/ql-vscode
2022-03-29 14:21:06 -07:00
Andrew Eisenberg
76c034f79a
Merge branch 'main' into aeisenberg/repo-filter
2022-03-29 14:15:31 -07:00
Andrew Eisenberg
d8d394ce40
Use new version of gulp-replace
2022-03-29 14:09:01 -07:00
Andrew Eisenberg
213f4ce92f
Merge branch 'main' into aeisenberg/settings
2022-03-29 13:54:41 -07:00
Andrew Eisenberg
2d1726763f
Merge pull request #1254 from github/aeisenberg/fix-main
...
Fix duplication import
2022-03-29 13:54:00 -07:00
Andrew Eisenberg
abfd9b3cbd
Fix duplication import
2022-03-29 13:21:08 -07:00
Andrew Eisenberg
6114f6a7fd
Merge branch 'main' into aeisenberg/analysis-results-on-restart
2022-03-29 13:18:13 -07:00
Andrew Eisenberg
61e674e9f6
Allow for undefined codeSnippets
...
This reverts commit 006cc8c52a .
2022-03-29 13:10:28 -07:00
Andrew Eisenberg
006cc8c52a
Undo sarif-processing change
...
Will move to a different PR.
2022-03-29 13:07:56 -07:00
Andrew Eisenberg
ffe7fdcb46
Rename methods and address comments
2022-03-29 13:04:00 -07:00
Andrew Eisenberg
49cceffe1b
Merge pull request #1235 from github/aeisenberg/history-sort
...
Add query history sorting for remote queries
2022-03-29 11:13:35 -07:00
Andrew Eisenberg
011782395a
Merge pull request #1250 from github/dependabot/npm_and_yarn/extensions/ql-vscode/types/webpack-5.28.0
...
Bump @types/webpack from 4.41.21 to 5.28.0 in /extensions/ql-vscode
2022-03-29 11:13:00 -07:00
Andrew Eisenberg
558009543f
Update changelog
2022-03-29 11:11:44 -07:00
Andrew Eisenberg
aaef5bde2c
Prevent cli path from being synced across remote instances
...
This will fix a problem where settings sync will cause the cli not
to be found on codespaces.
2022-03-29 11:08:31 -07:00
Andrew Eisenberg
f52f595d56
Add max-width for remote queries results page
2022-03-29 11:05:22 -07:00
dependabot[bot]
50196d8430
Bump @types/webpack from 4.41.21 to 5.28.0 in /extensions/ql-vscode
...
Bumps [@types/webpack](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/webpack ) from 4.41.21 to 5.28.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/webpack )
---
updated-dependencies:
- dependency-name: "@types/webpack"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-03-29 17:17:18 +00:00
Andrew Eisenberg
2ecfbfbb42
Merge pull request #1244 from github/aeisenberg/webpack-watch
...
Add webpack watch gulp task
2022-03-29 10:16:18 -07:00
Andrew Eisenberg
9508dffe6d
Merge pull request #1236 from github/dependabot/npm_and_yarn/extensions/ql-vscode/fs-extra-10.0.1
...
Bump fs-extra from 9.0.1 to 10.0.1 in /extensions/ql-vscode
2022-03-29 10:15:13 -07:00
Andrew Eisenberg
b4a72bbcab
Merge pull request #1238 from github/dependabot/npm_and_yarn/extensions/ql-vscode/through2-4.0.2
...
Bump through2 from 3.0.2 to 4.0.2 in /extensions/ql-vscode
2022-03-29 10:08:32 -07:00
Andrew Eisenberg
4ceaaf92cc
Merge pull request #1237 from github/dependabot/npm_and_yarn/extensions/ql-vscode/vsce-2.7.0
...
Bump vsce from 1.88.0 to 2.7.0 in /extensions/ql-vscode
2022-03-29 10:07:04 -07:00
Andrew Eisenberg
ef28c9531b
Update extensions/ql-vscode/gulpfile.ts/webpack.ts
2022-03-29 08:50:42 -07:00
Shati Patel
c86c602e39
Allow GitHub URL as well as NWO ( #1241 )
2022-03-29 12:45:46 +01:00
Angela P Wen
3bee2905e5
Gate show eval log and summary commands behind CLI v2.8.4 ( #1243 )
2022-03-29 05:30:31 -04:00
Edoardo Pirovano
9ac8a15cd5
Address review comments from @aeisenberg
2022-03-29 05:30:31 -04:00
Edoardo Pirovano
81b8104064
Expose per-query structured evaluator logs
2022-03-29 05:30:31 -04:00
Andrew Eisenberg
65f58b1f98
Add repositories search box
...
A simple, webview-only search box for filtering repositories from
the remote queries results view.
2022-03-28 17:01:11 -07:00
Andrew Eisenberg
7e872aa6d6
Add webpack watch gulp task
...
Now, when running `npm run watch`, both the regular tsc command
and the webpack command will be run in watch mode.
The raw gulp tasks are now:
- `gulp watchView` to watch webpack compilation.
- `gulp watchCss` to watch for css changes.
- `gulp compileView` to compile the webpack once and exit.
However, stats are no longer being printed out. Not sure why.
2022-03-28 15:43:35 -07:00
Andrew Eisenberg
0383a91a68
Display proper download state in remote results view
...
Before displaying any results for a remote query, ensure that all
downloaded results are in memory. This ensures the proper download icon
is displayed alongside each NWO.
2022-03-28 12:38:13 -07:00
Andrew Eisenberg
bb6ebe5750
Handle query directory not existing
...
Also, fix some changelog notes.
2022-03-28 10:55:02 -07:00
Andrew Eisenberg
71aa3d145f
Update changelog
2022-03-25 14:30:01 -07:00
dependabot[bot]
2f1f80029b
Bump @types/gulp-replace from 0.0.31 to 1.1.0 in /extensions/ql-vscode
...
Bumps [@types/gulp-replace](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/gulp-replace ) from 0.0.31 to 1.1.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/gulp-replace )
---
updated-dependencies:
- dependency-name: "@types/gulp-replace"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-03-25 21:28:00 +00:00
dependabot[bot]
ad18cfa284
Bump through2 from 3.0.2 to 4.0.2 in /extensions/ql-vscode
...
Bumps [through2](https://github.com/rvagg/through2 ) from 3.0.2 to 4.0.2.
- [Release notes](https://github.com/rvagg/through2/releases )
- [Commits](https://github.com/rvagg/through2/compare/v3.0.2...v4.0.2 )
---
updated-dependencies:
- dependency-name: through2
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-03-25 21:27:45 +00:00
dependabot[bot]
92ed1c6ac9
Bump vsce from 1.88.0 to 2.7.0 in /extensions/ql-vscode
...
Bumps [vsce](https://github.com/Microsoft/vsce ) from 1.88.0 to 2.7.0.
- [Release notes](https://github.com/Microsoft/vsce/releases )
- [Commits](https://github.com/Microsoft/vsce/compare/v1.88.0...v2.7.0 )
---
updated-dependencies:
- dependency-name: vsce
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-03-25 21:27:25 +00:00
dependabot[bot]
e71e04a8f1
Bump fs-extra from 9.0.1 to 10.0.1 in /extensions/ql-vscode
...
Bumps [fs-extra](https://github.com/jprichardson/node-fs-extra ) from 9.0.1 to 10.0.1.
- [Release notes](https://github.com/jprichardson/node-fs-extra/releases )
- [Changelog](https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jprichardson/node-fs-extra/compare/9.0.1...10.0.1 )
---
updated-dependencies:
- dependency-name: fs-extra
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-03-25 21:27:03 +00:00
Andrew Eisenberg
ef127c279c
Merge pull request #1233 from github/aeisenberg/dependabot
...
Add dependabot configuration
2022-03-25 14:26:02 -07:00
Andrew Eisenberg
4afac5fa4d
Add query history sorting for remote queries
...
Also, fix two smaller issues:
- Ensure the `Open Query Directory` command opens inside the specified
directory.
- Ensure label changes are saved across restarts.
2022-03-25 14:25:07 -07:00
Andrew Eisenberg
29ae97aa82
Add actions to dependabot config
2022-03-25 13:18:46 -07:00
Andrew Eisenberg
9319d7e8ef
Add dependabot configuration
2022-03-25 12:21:10 -07:00
dependabot[bot]
689db3713b
Bump minimist from 1.2.5 to 1.2.6 in /extensions/ql-vscode
...
Bumps [minimist](https://github.com/substack/minimist ) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases )
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6 )
---
updated-dependencies:
- dependency-name: minimist
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-03-25 18:48:40 +00:00
Andrew Eisenberg
0b9fcb884b
Merge pull request #1202 from github/aeisenberg/update-tsc
...
Update tsc to 4.5.5
2022-03-25 11:33:37 -07:00
Andrew Eisenberg
23e29a1fdc
Update tsc to 4.5.5
...
The default version of tsc in vscode is now 4.5.4. This version
has changed the type of the variable in the catch block.
Previously, it was `any`. Now it is `unknown`.
This change updates vscode so that it can build with 4.5.4.
Previously, this had been a bit of a pain since sometimes running
a compile task in vscode will use the global default version of
tsc.
2022-03-25 09:48:51 -07:00
Shati Patel
90d636a026
Download databases from GitHub ( #1229 )
2022-03-25 15:24:09 +00:00
Andrew Eisenberg
3e3e12afb9
Merge pull request #1230 from github/aeisenberg/astviewer-uri
...
Fix invalid file comparison for changing ast viewer location
2022-03-25 08:21:05 -07:00
Andrew Eisenberg
421f5d23ec
Update changelog
2022-03-24 12:39:11 -07:00
Andrew Eisenberg
0fa91f32cb
Fix invalid file comparison for changing ast viewer location
...
This fixes a bug where the ast viewer was not updating its source
location when a user clicks on different parts of a file.
The problem was that the file name of the AST viewer was being stored as
a base name, which was getting compared with the full URI string of the
current file.
This fixes the comparison to ensure that the full URI strings are always
being compared.
2022-03-24 12:36:17 -07:00
shati-patel
3d21b203be
Make "promptForLanguage" more general
...
(so we can use it for downloading a GH database as well)
2022-03-21 16:37:51 +00:00
shati-patel
3972b8f4c1
Rename LGTM-specific function
2022-03-21 16:37:51 +00:00
Tobias Speicher
2d1707db00
refactor: replace deprecated String.prototype.substr()
...
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated
Signed-off-by: Tobias Speicher <rootcommander@gmail.com >
2022-03-21 14:16:54 +00:00
Robert
72aa4f0561
Merge pull request #1226 from github/robertbrignull/allow-custom-action-branch
...
Allow a custom branch name in settings file
2022-03-21 10:52:21 +00:00
Robert
fd57cc95e9
Remove unnnecessary function
2022-03-21 10:38:00 +00:00
Robert
04c392be7e
Allow a custom branch name in settings file
2022-03-18 16:26:06 +00:00
github-actions[bot]
38da598214
Bump version to v1.6.2 ( #1221 )
...
Co-authored-by: charisk <charisk@users.noreply.github.com >
2022-03-17 12:47:33 +00:00
Charis Kyriakou
3f2c9b647c
v1.6.1 ( #1220 )
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
2022-03-17 12:04:37 +00:00
Shati Patel
7d5b4369c1
Fix highlighting issues ( #1219 )
2022-03-17 11:45:31 +00:00
Shati Patel
aade33fa88
Minor webview fixes ( #1217 )
2022-03-17 11:12:50 +00:00
Shati Patel
2a8a90bdfc
Change public occurrences of "remote queries" ( #1215 )
2022-03-17 10:14:32 +00:00
Shati Patel
f36048cc95
Use variable for highlighting code ( #1216 )
2022-03-17 10:08:42 +00:00
Charis Kyriakou
517feeca21
Remove SARIF viewer support ( #1213 )
2022-03-16 14:39:52 +00:00
Charis Kyriakou
9436a49118
Remove helper command for working on the Remote Query results view ( #1214 )
2022-03-16 14:19:19 +00:00
Charis Kyriakou
0e02cb08fd
Enable viewing of analyses results ( #1212 )
2022-03-16 14:15:43 +00:00
Shati Patel
26244efc50
Create remote file links to GitHub URL ( #1209 )
...
Co-authored-by: Charis Kyriakou <charisk@github.com >
2022-03-16 14:11:17 +00:00
Charis Kyriakou
6339eeffe5
Minor styling fix for raw results ( #1211 )
2022-03-16 11:44:51 +00:00
Charis Kyriakou
8cc2f598eb
Fix highlight region end column calculation ( #1210 )
2022-03-16 09:47:09 +00:00
Charis Kyriakou
46a1dd57f4
Minor style fixes around result rendering ( #1208 )
2022-03-15 14:43:24 +00:00
shati-patel
9d99fc521e
Get database sha from result index
2022-03-15 10:30:01 +00:00
Shati Patel
bcf79354ee
Bump CLI version in integration tests
2022-03-15 10:22:18 +00:00
Charis Kyriakou
27a8636bac
Deal with non-printable characters when rendering raw results ( #1203 )
2022-03-14 11:25:33 +00:00
Charis Kyriakou
92a99938c9
Add support for remote queries raw results ( #1198 )
2022-03-14 08:18:43 +00:00
Charis Kyriakou
ed61eb0a95
Deal with analysis messages that have links to locations ( #1195 )
2022-03-14 08:14:09 +00:00
Andrew Eisenberg
50d495b522
Merge pull request #1201 from mrysav/patch-1
...
Install Dependency Review Action
2022-03-11 10:40:06 -08:00
Andrew Eisenberg
526d5c2c44
Apply suggestions from code review
2022-03-11 10:29:02 -08:00
Charis Kyriakou
1720f9201e
Update Primer React to v35 ( #1199 )
2022-03-10 20:24:12 +00:00
Mitchell Rysavy
e62de1ca22
Create dependency-review.yml
2022-03-10 14:48:06 -05:00
Charis Kyriakou
d052ddb742
Rename analysis alert results ( #1197 )
2022-03-10 07:56:05 +00:00
Andrew Eisenberg
af53a02ea5
Merge pull request #1192 from github/aeisenberg/disable-openvsx-deploy
...
Disable the open-vsx-publish job
2022-03-09 09:27:17 -08:00
Charis Kyriakou
8e2d18da8c
Rename ColumnValue to CellValue ( #1196 )
2022-03-09 16:44:15 +00:00
Charis Kyriakou
2c5004387d
Add support for showing code flows ( #1187 )
2022-03-09 09:15:45 +00:00
Charis Kyriakou
3fc3b259ba
Add pre-push hook check to block leftover .only()s ( #1189 )
2022-03-08 09:32:18 +00:00
Andrew Eisenberg
cd95f68692
Merge pull request #1191 from github/version/bump-to-v1.6.1
...
Bump version to v1.6.1
2022-03-07 10:25:23 -08:00
Andrew Eisenberg
59c3b1ba2f
Disable the open-vsx-publish job
...
It is failing, blocked on #1085
2022-03-07 10:19:42 -08:00
aeisenberg
fa85865fe5
Bump version to v1.6.1
2022-03-07 18:04:29 +00:00
Andrew Eisenberg
5575d4142c
Merge pull request #1190 from github/v1.6.0
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.6.0
2022-03-07 10:00:52 -08:00
Andrew Eisenberg
ae6263a07f
v1.6.0
...
Note that the change to `run-remote-query.ts` is being coordinated
with the rest of the remote-queries team.
2022-03-07 09:46:56 -08:00
Charis Kyriakou
9af75634fa
Remove .only from mocha test ( #1188 )
2022-03-07 10:04:29 +00:00
Andrew Eisenberg
04b8681272
Merge pull request #1184 from github/aeisenberg/open-remote
...
Add command to open remote query on github
2022-03-04 10:46:55 -08:00
Andrew Eisenberg
d5549f2894
Add command to open remote query on github
...
Command is available for remote queries that are in progress or
completed.
2022-03-04 10:36:41 -08:00
Charis Kyriakou
b510b85ca0
Extract code snippet into stand alone component ( #1181 )
2022-03-04 08:06:19 +00:00
Andrew Eisenberg
5ad754a3a2
Merge pull request #1178 from github/aeisenberg/log-history
...
Save log files to the query history directory
2022-03-03 08:14:25 -08:00
Andrew Eisenberg
4f04f9db6e
Merge pull request #1179 from github/aeisenberg/open-query-folder
...
Add new command to open the query history directory
2022-03-03 08:00:55 -08:00
Andrew Eisenberg
025a1a1383
Add new command to open the query history directory
...
Allows users to explore the contents and all artifacts of the query
that was just run.
2022-03-03 07:57:56 -08:00
Andrew Eisenberg
f28c1f91d9
Ensure structured logging file exists before running a query
2022-03-03 07:57:23 -08:00
Charis Kyriakou
c609377a9c
Add SARIF processing and basic alert rendering ( #1171 )
2022-03-03 09:03:27 +00:00
Andrew Eisenberg
2579d12f24
Save log files to the query history directory
...
This commit deprecates the the cutsom log directory option by saving
all log files with query history.
There is a simplification of the `OutputChannelLogger` since it no
longer needs to manage deleting log files on exit.
Also, the `codeQL.runningQueries.customLogDirectory` is marked as
deprecated. If this value is being used, a warning message is popped
up after the query completes.
2022-03-02 12:21:15 -08:00
Andrew Eisenberg
c18f7953e7
Merge pull request #1111 from github/aeisenberg/graph-viewer
...
More work on the graph viewer
2022-03-02 07:52:49 -08:00
Andrew Eisenberg
3a292b02b6
Simplify walkDirectory
...
The check for `seenFiles` is not necessary since we do not need to
handle symbolic links.
2022-03-01 14:02:21 -08:00
Andrew Eisenberg
7baf2d0a2a
Small formatting changes for graphes
2022-03-01 11:50:55 -08:00
Andrew Eisenberg
328289eb1c
Ensure graph view loads when result is clicked
...
Without these changes, a race condition was sometimes hit when viewing
a graph. There are two, related issues that are fixed. These problems
did not appear in the past since rendering a normal results view is
much faster and the message handler is always already set up by the
time the interface first sends a message over to the web view.
1. `vscode.postMessage({ t: 'resultViewLoaded' });` was being called
before the component is completely mounted. Ie- `componentDidMount`
is not called. So, the interface is notified that the web view is
ready to receive messages _before_ it is actually ready to receive
messages.
The change ensures the interface only sends messages when the web
view is ready.
2. `this._panelLoaded` is never set to false if the panel is unloaded.
This means that if a panel is re-opened, the interface assumes that
the view is nearly _immediately_ ready to receive messages.
The change ensures that the interface waits for the webview to really
be loaded before sending messages.
In both of these cases, if the interface sends the `setState` message
too early, then the message is ignored since no handlers have been added
to the web view.
2022-03-01 11:46:26 -08:00
Andrew Eisenberg
95d93eeb61
Merge pull request #1176 from github/bump-cli
...
Bump CLI version in integration tests
2022-03-01 08:15:05 -08:00
Charis Kyriakou
b54cc27cab
Update ECMAScript version to be the same across the codebase ( #1177 )
2022-03-01 16:01:29 +00:00
shati-patel
c9ca1ee7b3
Bump CLI version in integration tests
2022-03-01 12:14:30 +01:00
Charis Kyriakou
649d6d94a3
Expose Remote Query language ( #1173 )
2022-02-28 13:12:01 +00:00
Charis Kyriakou
bf68d21830
Some UI fixes for collapsible items ( #1172 )
2022-02-28 10:53:02 +00:00
Andrew Eisenberg
64b33b76cb
Update node version in CI
2022-02-26 19:48:55 -08:00
Andrew Eisenberg
c189df3fd6
Ensure Graph results can only be seen if in canary mode
2022-02-25 18:04:21 -08:00
Andrew Eisenberg
277869ebca
Ensure graph queries with ids that have slashes work
...
Do this by actually walking the interpretation directory.
Move the directory walker from tests to prod and make it async. Also
add tests for it.
And add a warning on graph views to let users know that it is not
production quality.
Finally, change the interpreted directory to be `graphResults` instead
of `interpretedResults.sarif`.
2022-02-25 18:03:14 -08:00
shati-patel
303513a566
Make icon part of clickable link
...
Plus fix the associated styling/CSS
2022-02-25 21:08:16 +00:00
shati-patel
8712106b3d
Add link to workflow run logs from results view
2022-02-25 21:08:16 +00:00
Andrew Eisenberg
cdb9506583
Merge branch 'main' into aeisenberg/graph-viewer
2022-02-25 10:38:19 -08:00
Andrew Eisenberg
94a311a550
Merge pull request #1166 from github/aeisenberg/remote-queries-unit-tests
...
Add unit tests for query history and remote queries
2022-02-25 10:07:56 -08:00
Andrew Eisenberg
791e7e9c4d
Small cleanups around remote-queries tests
...
- More explicit test helper module names
- Fix unit test names
- Better sanitization of repo names in tests
2022-02-25 09:57:15 -08:00
Angela P Wen
6cfa7e2cd3
Integrate evaluator structured logging per query server instance ( #1151 )
...
Adds structured evaluator logging on a per-query instance to CLI v 2.8.2+. The newline-delimited JSON logs are emitted to `structured-evaluator-log.json` in the directory with other query artifacts, but not consumed by the extension.
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-02-25 09:22:56 -08:00
Andrew Eisenberg
7196c26181
Merge pull request #1168 from github/aeisenberg/query-history-version
...
Preemptively add a version number to the query history json file
2022-02-25 08:11:14 -08:00
Charis Kyriakou
735f177283
Use webview CSP source for style-src ( #1170 )
2022-02-25 16:03:58 +00:00
Andrew Eisenberg
f857e5ec6c
Ensure all tests are run
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2022-02-25 08:00:03 -08:00
Charis Kyriakou
a5e02950c2
Fixed unique key warning ( #1169 )
2022-02-25 10:58:24 +00:00
Andrew Eisenberg
4a928f1298
Add unit tests for query history and remote queries
...
Adds some tests for reading in the history and manipulating.
There are some more tests to come later. Maybe in another PR, maybe in
this one.
Note that this PR uses a new node 16 API String.prototype.replaceAll.
I think this is ok since vscode ships with node 16. If this causes
problems, I can separate to a different PR and we can discuss there.
2022-02-24 23:09:55 -08:00
Andrew Eisenberg
f59012862e
Preemptively add a version number to the query history json file
...
Since we are now storing query history on disk, we will need to handle
situations where versions change. For now, there is only version 1. In
the future, we may need to make breaking changes to this format and we
need the flexibility to detect and possibly handle different versions.
In this case, users don't often downgrade their vscode versions, so
most likely, we only need to be forward compatible. Ie- we need to
handle moving from v1 to v2, but not the other way around.
2022-02-24 11:42:46 -08:00
Andrew Eisenberg
5f5418a297
Merge pull request #1164 from github/aeisenberg/avoid-download
...
Avoid downloading a result if it already exists
2022-02-24 08:11:02 -08:00
Andrew Eisenberg
548a216b56
Avoid downloading a result if it already exists
...
This commit adds a check if a results artifact already exists before
trying to download it again.
This is not a complete solution since the page icon will still have a
download button even if the artifact already exists. In this case,
clicking on it will avoid downloading it a second time.
The next step is to read in the downloaded artifacts and display them
appropriately.
2022-02-23 11:16:39 -08:00
Andrew Eisenberg
c943c89fc6
Merge pull request #1163 from github/aeisenberg/remote-multi-analyses
...
Allow multiple analyses for same repo to be downloaded
2022-02-23 11:13:37 -08:00
Andrew Eisenberg
06de6077ba
Merge pull request #1162 from github/aeisenberg/remote-query-restart
...
Remember remote queries across restarts
2022-02-23 11:13:17 -08:00
Andrew Eisenberg
cef1fcc95d
Merge pull request #1155 from github/aeisenberg/remote-query-save
...
Add remote query items to history view
2022-02-23 11:13:00 -08:00
Andrew Eisenberg
1ed8b225db
Small cleanup and comment
2022-02-23 09:52:46 -08:00
Andrew Eisenberg
f0354c87f4
Allow multiple analyses for same repo to be downloaded
...
Removes the limitation specified in #1089 where analyses for the same
repo and different queries will overwrite each other.
2022-02-22 14:16:54 -08:00
Andrew Eisenberg
5e06a615cd
Remember remote queries across restarts
...
Remote query items will be stored in query history and will remain
available across restarts.
When the extension is restarted, any `InProgress` remote queries will
be monitored until they complete.
When clicked on, a remote query is opened and its results can be
downloaded. The query text and the query file can be opened from the
history menu. A remote query can be deleted as well, which will purge
all results from global storage.
Limitations:
1. Labels are not editable
2. Running multiple queries that each run on the same repository
will have conflicting results and there will be errors when trying
to view the results of the second query. This limitation is not new,
but it is easier to hit now. See #1089 .
Both of these limitations will be addressed in future PRs.
2022-02-22 11:42:52 -08:00
Andrew Eisenberg
e11aa7af18
Merge branch 'main' into aeisenberg/remote-query-save
2022-02-22 10:13:16 -08:00
Andrew Eisenberg
f4ddc17851
Merge pull request #1158 from github/aeisenberg/open-query-logger
...
Open query server logger for query errors
2022-02-22 09:55:19 -08:00
Andrew Eisenberg
ebce2826cb
Merge pull request #1143 from github/aeisenberg/refactor-query-history-info
...
Refactor query history to handle remote and local
2022-02-22 09:51:13 -08:00
Andrew Eisenberg
4c411acef4
Merge branch 'main' into aeisenberg/open-query-logger
2022-02-22 09:44:41 -08:00
Andrew Eisenberg
ddc941f464
Merge pull request #1157 from github/aeisenerg/empty-additional-packs
...
Ensure `--addtional-packs` arg not used for empty workspace
2022-02-22 09:44:10 -08:00
shati-patel
c5ff2c6f76
Fix styling for light mode
2022-02-22 17:14:15 +00:00
shati-patel
85ac16bb22
Change shape of result index
2022-02-22 17:14:15 +00:00
shati-patel
e7ee4a33c7
Add new component for displaying analysis failures
2022-02-22 17:14:15 +00:00
shati-patel
ac0da04542
Read analysis failures from index file
2022-02-22 17:14:15 +00:00
shati-patel
3337117970
Use more accurate primer icon
2022-02-22 12:04:21 +00:00
Charis Kyriakou
9b61ff5714
Use Primer octicons where possible ( #1156 )
2022-02-21 11:28:13 +00:00
Andrew Eisenberg
d25db48452
Open query server logger for query errors
...
Because errors when running queries tend to have better explanations
in the query server log instead of the extension log, by default open
the query server log for query errors.
2022-02-18 12:55:32 -08:00
Andrew Eisenberg
251f354076
Ensure --addtional-packs arg not used for empty workspace
2022-02-18 10:16:42 -08:00
Andrew Eisenberg
9c6ae226fb
Merge branch 'aeisenberg/refactor-query-history-info' into aeisenberg/remote-query-save
2022-02-17 14:11:44 -08:00
Andrew Eisenberg
a502ee85d1
Fix unit test and add comments/todos
2022-02-17 13:07:10 -08:00
Andrew Eisenberg
eec72e0cbd
Merge pull request #1142 from github/aeisenberg/remote-queries-history
...
Store remote query artifacts in global storage
2022-02-17 12:35:09 -08:00
Andrew Eisenberg
7a1acce133
Merge pull request #1150 from github/aeisenberg/clear-cache
...
Fix race condition where packs with no name errored during remote query
2022-02-17 10:04:53 -08:00
Andrew Eisenberg
84b4bfe663
Merge pull request #1149 from github/aeisenberg/avoid-redownload
...
Avoid re-downloading analyses
2022-02-17 08:14:58 -08:00
Andrew Eisenberg
16df990183
Add remote query items to history view
...
This is another incremental step on the way to saving history.
This commit adds remote items to the history view. It adds in progress
and completed icons. Users can explicitly remove items.
Here is what is _not_ working:
1. Any other query history commands like open results or open query.
2. Seeing items after a restart.
2022-02-16 18:43:00 -08:00
Andrew Eisenberg
969dd26041
Use QueryHistoryInfo instead of LocalQueryInfo
...
Also, rename RemoteQueryInfo -> RemoteQueryHistoryItem
2022-02-16 13:52:17 -08:00
Andrew Eisenberg
9df1f91318
Fix race condition where packs with no name errored during remote query
...
Uses the internal `clear-cache` CLI server command.
2022-02-16 12:46:38 -08:00
Andrew Eisenberg
48ddc66d47
Merge branch 'aeisenberg/remote-queries-history' into aeisenberg/refactor-query-history-info
2022-02-16 12:34:43 -08:00
Andrew Eisenberg
85e3869607
Avoid re-downloading analyses
...
Avoids re-downloading analyses when downloading all analyses.
2022-02-16 12:01:21 -08:00
Andrew Eisenberg
5bb2a763e3
Avoid artifactStorageDir and use queryId to build storage paths
...
This is still an intermediate step as we start to bring in more
abstractions. I plan to implement a storage handler that will
keep track of all the different bits for a remote query.
2022-02-16 11:46:10 -08:00
Andrew Eisenberg
2110709d72
Merge pull request #1140 from github/aeisenberg/contextual-storage
...
Store query results for contextual queries elsewhere
2022-02-16 08:11:49 -08:00
shati-patel
493033edc0
Remove unused code about validating DB uploads
2022-02-16 14:25:43 +00:00
Andrew Eisenberg
bf8e77b9b9
Ensure proper paths are used for retrieving artifacts
...
This change builds on the previous change to ensure that sarif results
can be displayed properly. Here is what it does:
- Move prepareDownloadDirectory to the RemoteQueryManager
- Store the queryResult to disk
- Use the `artifactStorageDir` as the location where artifacts are kept
- Add `artifactStorageDir` to DownloadLink
- Ensure the webview passes around the right links.
2022-02-15 20:24:17 -08:00
Andrew Eisenberg
c7e5581027
Store query results for contextual queries elsewhere
...
We want them to be deleted when the application exits. We don't want
them to be stored with user queries.
2022-02-15 13:18:45 -08:00
Andrew Eisenberg
c78802a1ed
Refactor query history to handle remote and local
...
This is a step on the way towards storing remote query history across
restarts.
This PR adds a `QueryHistoryInfo` type that is a union of two types:
`LocalQueryInfo` and `RemoteQueryInfo`.
`LocalQueryInfo` used to be called `FullQueryInfo` and `RemoteQueryInfo`
is only a skeleton right now. The body will be added later. This PR
only introduces it and changes types to make future PRs simpler.
Also, `slurp` and `splat` have been moved to the `query-serialization.ts`
module.
2022-02-15 13:07:47 -08:00
Andrew Eisenberg
39f9c082b9
Store remote query artifacts in global storage
...
This moves all artifacts downloaded for a remote query into the global
storage directory. Each remote query gets its own directory. The
parent directory is the shared query storage directory.
Each remote query directory also gets a timestamp file.
With these changes, remote queries will be persisted across restarts
and deleted automatically on the same schedule as local queries.
Note: This does _not_ add remote queries to the query history view yet.
This part of the feature is coming next.
2022-02-15 13:05:51 -08:00
shati-patel
ca1ef5192d
Update wording in results view
2022-02-15 17:36:39 +00:00
Shati Patel
1d6fef9169
Update CLI version in integration tests
2022-02-15 15:50:51 +00:00
shati-patel
81f80ddbe5
Clear SARIF viewer before showing new results
2022-02-15 14:33:15 +00:00
Andrew Eisenberg
b53657344c
General refactoring and adding comments
...
There is no new behaviour added in this commit. Just some cleanup:
- Move some shared constants to the `helpers` module
- Add comments to some of the query related modules
- Some general formatting and tidying
2022-02-14 11:39:19 -08:00
Andrew Eisenberg
95e818898e
Merge pull request #1130 from github/aeisenberg/save-query-history
...
Save query history across restarts
2022-02-14 11:25:35 -08:00
Andrew Eisenberg
a7e014a87e
Merge branch 'main' into aeisenberg/save-query-history
2022-02-14 11:15:22 -08:00
Andrew Eisenberg
cca65e5a48
Rename and add comment
2022-02-14 10:54:17 -08:00
Robin Neatherway
a75249f3e4
Merge pull request #1132 from github/rneatherway/remove-repositories
...
Remove .repositories configuration approach
2022-02-14 17:43:24 +00:00
Henry Mercer
053a4b0392
Remove feature flag for loading ML models from packs
...
This functionality should now be enabled for all users.
2022-02-14 10:36:00 +00:00
Andrew Eisenberg
d1362bf44f
More work on the graph viewer
...
The viewer is largely implemented now with the following features and
limitations:
1. Any query with `@kind graph` will be opened as a graph
2. Queries that are `@kind graph` and
`@tags ide-contextual-queries/print-cfg` will be used in the
`CodeQL: View CFG` context command. This will be visible
similar to how the AST viewer works. If there is not exactly
1 such query for a given language, then the extension will throw
an error.
3. Unfortunately, the cg viewer assumes that the entire file will
be added to the graph, so often this will be too big, That leads to
the following limitation:
4. There is no size checking on the graph. Graphs that are too big will
crash vscode.
5. Lastly, there is a small bug in how the `@id` is interpreted. Any
`@id` with a `/` in it will place the `.dot` in a location that
can't be found by vscode. So, just don't name your queries with any
`/`.
This feature is only available in canary mode.
2022-02-11 15:55:01 -08:00
Tom Hvitved
580832ea7b
Graph viewer support
2022-02-11 14:47:13 -08:00
Tom Hvitved
ddca0bb851
Address review comments
2022-02-11 14:45:15 -08:00
Tom Hvitved
d9a04ea895
Refactor interpreted-data interface in preparation for other interpretations than SARIF
2022-02-11 14:45:15 -08:00
Andrew Eisenberg
48ccb27e49
Update changelog
2022-02-11 13:54:09 -08:00
Andrew Eisenberg
a2b5ad07ff
Fix upgrades path
...
Ensure that upgrades can be resolved even when the upgrades pack is not
in the workspace. This is the situation when the core libraries are
resolved from the package cache.
This change works because `qlProgram.libraryPath` is the resolved
search path for compiling the query. We are guaranteed that the
appropriate core libraries are included in this query.
Note that this change avoids using extra source folders from the
workspace. Previously without using packages, we assume that all
relevant query paths are already inside the workspace. With
packaging, this is no longer the case.
It is theoretically possible that there will be extra upgrade scripts
that are not on the resolved search path, but are included in the
workspace. This situation would have worked in the past.This is not a
situation that we expect to happen in practice. And if this does happen,
I believe this is an error and all upgrades should be added explicitly
to the search path.
An open question is if this will work with downgrade scripts. If it does
not, then I don't think this change makes things any worse than before.
2022-02-11 12:58:34 -08:00
dependabot[bot]
cc9cbf7f06
Bump pathval from 1.1.0 to 1.1.1 in /extensions/ql-vscode
...
Bumps [pathval](https://github.com/chaijs/pathval ) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/chaijs/pathval/releases )
- [Changelog](https://github.com/chaijs/pathval/blob/master/CHANGELOG.md )
- [Commits](https://github.com/chaijs/pathval/compare/v1.1.0...v1.1.1 )
---
updated-dependencies:
- dependency-name: pathval
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-02-11 11:40:21 +00:00
Andrew Eisenberg
ad5c43c9ba
Fix failing tests
2022-02-10 20:00:46 -08:00
Andrew Eisenberg
9c27d01d47
Merge branch 'main' into aeisenberg/save-query-history
2022-02-10 16:03:56 -08:00
Andrew Eisenberg
64ac33e3bb
Address comments from PR
...
- Rename queryStorageLocation -> queryStorageDir
- Extract scrubber to its own module
- Add more comments
- Rename source -> cancellationSource
- Ensure cancellatinSource is disposed
2022-02-10 16:03:46 -08:00
aeisenberg
329fb87e12
Bump version to v1.5.12
2022-02-10 12:50:03 -08:00
Robin Neatherway
d49e6e19a6
Remove .repositories configuration approach
...
This was our first temporary attempt at configuration of a remote
query run. I don't think that we're using it anymore, so it simplifies
the code to remove it.
2022-02-10 12:47:48 +00:00
Andrew Eisenberg
7785dfead2
Update changelog
2022-02-09 15:09:08 -08:00
Andrew Eisenberg
29c29f9e3a
Save query history across restarts
...
Successfully completed queries will be stored on disk and available
across restarts.
- The query results are contained in global storage.
- Metadata and a summary about a query are stored in workspace storage.
- There is a job that runs every 2 hours to determine if any queries are
old enough to be deleted.
2022-02-09 15:01:44 -08:00