Remove GitHub database download feature flag

This removes the `codeQL.githubDatabase.enable` setting and always
enables the GitHub database download feature.
This commit is contained in:
Koen Vlaswinkel
2023-12-14 10:08:14 +01:00
parent 598f2eb3f2
commit cf50a71a16
2 changed files with 0 additions and 11 deletions

View File

@@ -762,8 +762,6 @@ export class ModelConfigListener extends ConfigListener implements ModelConfig {
const GITHUB_DATABASE_SETTING = new Setting("githubDatabase", ROOT_SETTING);
// Feature flag for the GitHub database downnload.
const GITHUB_DATABASE_ENABLE = new Setting("enable", GITHUB_DATABASE_SETTING);
const GITHUB_DATABASE_DOWNLOAD = new Setting(
"download",
GITHUB_DATABASE_SETTING,
@@ -778,7 +776,6 @@ const GitHubDatabaseUpdateValues = ["ask", "never"] as const;
type GitHubDatabaseUpdate = (typeof GitHubDatabaseUpdateValues)[number];
export interface GitHubDatabaseConfig {
enable: boolean;
download: GitHubDatabaseDownload;
update: GitHubDatabaseUpdate;
setDownload(
@@ -802,10 +799,6 @@ export class GitHubDatabaseConfigListener
);
}
public get enable() {
return !!GITHUB_DATABASE_ENABLE.getValue<boolean>();
}
public get download(): GitHubDatabaseDownload {
const value = GITHUB_DATABASE_DOWNLOAD.getValue<GitHubDatabaseDownload>();
return GitHubDatabaseDownloadValues.includes(value) ? value : "ask";

View File

@@ -60,10 +60,6 @@ export class GitHubDatabasesModule extends DisposableObject {
}
private async initialize(): Promise<void> {
if (!this.config.enable) {
return;
}
// Start the check and downloading the database asynchronously. We don't want to block on this
// in extension activation since this makes network requests and waits for user input.
void this.promptGitHubRepositoryDownload().catch((e: unknown) => {