Merge pull request #2344 from github/starcke/csharp-fix-query

Fix C# query to give results in the same format as java.

extensions/ql-vscode/src/data-extensions-editor/queries/csharp.ts

@@ -77,16 +77,6 @@ class ExternalApi extends DotNet::Callable {
     not isUninteresting(this)
   }
 
-  /**
-   * Gets the unbound type, name and parameter types of this API.
-   */
-  bindingset[this]
-  private string getSignature() {
-    result =
-      this.getDeclaringType().getUnboundDeclaration() + "." + this.getName() + "(" +
-        parameterQualifiedTypeNamesToString(this) + ")"
-  }
-
   /**
    * Gets the namespace of this API.
    */
@@ -97,7 +87,8 @@ class ExternalApi extends DotNet::Callable {
    * Gets the namespace and signature of this API.
    */
   bindingset[this]
-  string getApiName() { result = this.getNamespace() + "#" + this.getSignature() }
+  string getApiName() { result = this.getNamespace() + "." + this.getDeclaringType().getUnboundDeclaration() + "#" + this.getName() + "(" +
+  parameterQualifiedTypeNamesToString(this) + ")" }
 
   /** Gets a node that is an input to a call to this API. */
   private ArgumentNode getAnInput() {