Merge pull request #2114 from github/robertbrignull/enable_telemetry

Enable new telemetry by default

extensions/ql-vscode/CHANGELOG.md

@@ -2,7 +2,7 @@
 
 ## [UNRELEASED]
 
-## [UNRELEASED]
+- Enable collection of telemetry concerning interactions with UI elements, including buttons, links, and other inputs. [#2114](https://github.com/github/vscode-codeql/pull/2114)
 
 # 1.7.10 - 23 February 2023
 

extensions/ql-vscode/src/config.ts

@@ -83,13 +83,8 @@ export const GLOBAL_ENABLE_TELEMETRY = new Setting(
   GLOBAL_TELEMETRY_SETTING,
 );
 
-const ENABLE_NEW_TELEMETRY = new Setting(
-  "enableNewTelemetry",
-  TELEMETRY_SETTING,
-);
-
 export function newTelemetryEnabled(): boolean {
-  return ENABLE_NEW_TELEMETRY.getValue<boolean>();
+  return true;
 }
 
 // Distribution configuration

extensions/ql-vscode/test/vscode-tests/no-workspace/telemetry.test.ts

@@ -394,6 +394,10 @@ describe("telemetry reporting", () => {
   });
 
   describe("when new telementry is not enabled", () => {
+    beforeEach(async () => {
+      jest.spyOn(Config, "newTelemetryEnabled").mockReturnValue(false);
+    });
+
     it("should not send a ui-interaction telementry event", async () => {
       await telemetryListener.initialize();