mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Convert handleShowEvalLogViewer to use createSingleSelectionCommand

Browse Source
This commit is contained in:
Robert
2023-04-20 17:19:59 +01:00
parent 43c0d15be3
commit 28819dfe76
1 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
extensions/ql-vscode/src/query-history/query-history-manager.ts
View File

@@ -260,8 +260,10 @@ export class QueryHistoryManager extends DisposableObject {
this.handleShowEvalLogSummary.bind(this),
"query",
),
"codeQLQueryHistory.showEvalLogViewer":
"codeQLQueryHistory.showEvalLogViewer": createSingleSelectionCommand(
this.handleShowEvalLogViewer.bind(this),
"query",
),
"codeQLQueryHistory.showQueryLog": createSingleSelectionCommand(
this.handleShowQueryLog.bind(this),
"query",
@@ -761,17 +763,13 @@ export class QueryHistoryManager extends DisposableObject {
}
}
async handleShowEvalLogViewer(
singleItem: QueryHistoryInfo,
multiSelect: QueryHistoryInfo[] | undefined,
) {
// Only applicable to an individual local query
if (!this.assertSingleQuery(multiSelect) || singleItem.t !== "local") {
async handleShowEvalLogViewer(item: QueryHistoryInfo) {
if (item.t !== "local") {
return;
}
// If the JSON summary file location wasn't saved, display error
if (singleItem.jsonEvalLogSummaryLocation === undefined) {
if (item.jsonEvalLogSummaryLocation === undefined) {
this.warnInProgressEvalLogViewer();
return;
}
@@ -779,16 +777,16 @@ export class QueryHistoryManager extends DisposableObject {
// TODO(angelapwen): Stream the file in.
try {
const evalLogData: EvalLogData[] = await parseViewerData(
singleItem.jsonEvalLogSummaryLocation,
item.jsonEvalLogSummaryLocation,
);
const evalLogTreeBuilder = new EvalLogTreeBuilder(
singleItem.getQueryName(),
item.getQueryName(),
evalLogData,
);
this.evalLogViewer.updateRoots(await evalLogTreeBuilder.getRoots());
} catch (e) {
throw new Error(
`Could not read evaluator log summary JSON file to generate viewer data at ${singleItem.jsonEvalLogSummaryLocation}.`,
`Could not read evaluator log summary JSON file to generate viewer data at ${item.jsonEvalLogSummaryLocation}.`,
);
}
}