mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Replace local database icon

Browse Source
This commit is contained in:
Nora
2023-01-25 08:19:26 +00:00
parent 3c56c549bc
commit ec9b5fe1d3
3 changed files with 3 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
extensions/ql-vscode/media/drive.svg
View File

@@ -1,7 +0,0 @@
<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
<path fill-rule="evenodd" clip-rule="evenodd" d="M15.5 12.1952C15.5 12.9126 14.9137 13.4996 14.1957 13.4996H1.80435C1.08696 13.4996 0.5 12.9126 0.5 12.1952L0.5 9.80435C0.5 9.08696 1.08696 8.5 1.80435 8.5H14.1956C14.9137 8.5 15.5 9.08696 15.5 9.80435L15.5 12.1952Z" stroke="#959DA5" stroke-linecap="round" stroke-linejoin="round"/>
<path d="M2.45654 11.5H13.5435" stroke="#959DA5" stroke-linecap="round" stroke-linejoin="round"/>
<path fill-rule="evenodd" clip-rule="evenodd" d="M13.5 9.5C13.224 9.5 13 9.725 13 10C13 10.275 13.224 10.5 13.5 10.5C13.776 10.5 14 10.275 14 10C14 9.725 13.776 9.5 13.5 9.5" fill="#959DA5"/>
<path fill-rule="evenodd" clip-rule="evenodd" d="M11.5 9.5C11.224 9.5 11 9.725 11 10C11 10.275 11.224 10.5 11.5 10.5C11.776 10.5 12 10.275 12 10C12 9.725 11.776 9.5 11.5 9.5" fill="#959DA5"/>
<path d="M15.5 9.81464L13.8728 2.76261C13.6922 2.06804 12.9572 1.5 12.2391 1.5H3.76087C3.04348 1.5 2.30848 2.06804 2.12783 2.76261L0.5 9.8" stroke="#959DA5" stroke-linecap="round" stroke-linejoin="round"/>
</svg>
Side by Side

Before

Width:  |  Height:  |  Size: 1.1 KiB

13
extensions/ql-vscode/src/query-history/query-history.ts
View File

@@ -101,11 +101,6 @@ const SHOW_QUERY_TEXT_QUICK_EVAL_MSG = `\
`;
/**
* Path to icon to display next to a successful local run.
*/
const LOCAL_SUCCESS_QUERY_HISTORY_ITEM_ICON = "media/drive.svg";
/**
* Path to icon to display next to a successful remote run.
*/
@@ -153,8 +148,6 @@ export class HistoryTreeDataProvider
private history: QueryHistoryInfo[] = [];
private localSuccessIconPath: string;
private remoteSuccessIconPath: string;
private current: QueryHistoryInfo | undefined;
@@ -164,10 +157,6 @@ export class HistoryTreeDataProvider
private readonly labelProvider: HistoryItemLabelProvider,
) {
super();
this.localSuccessIconPath = join(
extensionPath,
LOCAL_SUCCESS_QUERY_HISTORY_ITEM_ICON,
);
this.remoteSuccessIconPath = join(
extensionPath,
REMOTE_SUCCESS_QUERY_HISTORY_ITEM_ICON,
@@ -198,7 +187,7 @@ export class HistoryTreeDataProvider
return new ThemeIcon("sync~spin");
case QueryStatus.Completed:
if (element.t === "local") {
return this.localSuccessIconPath;
return new ThemeIcon("database");
} else {
return this.remoteSuccessIconPath;
}

8
extensions/ql-vscode/test/vscode-tests/no-workspace/query-history/query-history.test.ts
View File

@@ -1683,9 +1683,7 @@ describe("query-history", () => {
});
expect(treeItem.label).toContain("query-file.ql");
expect(treeItem.contextValue).toBe("rawResultsItem");
expect(treeItem.iconPath).toEqual(
vscode.Uri.file(`${mockExtensionLocation}/media/drive.svg`).fsPath,
);
expect(treeItem.iconPath).toEqual(new vscode.ThemeIcon("database"));
});
it("should get a tree item with interpreted results", async () => {
@@ -1701,9 +1699,7 @@ describe("query-history", () => {
mockQueryWithInterpretedResults,
);
expect(treeItem.contextValue).toBe("interpretedResultsItem");
expect(treeItem.iconPath).toEqual(
vscode.Uri.file(`${mockExtensionLocation}/media/drive.svg`).fsPath,
);
expect(treeItem.iconPath).toEqual(new vscode.ThemeIcon("database"));
});
it("should get a tree item that did not complete successfully", async () => {