Rename Options to AutoModelQueriesOptions

This commit is contained in:
Koen Vlaswinkel
2023-07-26 14:31:21 +02:00
parent de5dbea69f
commit 32c44cdfe3
3 changed files with 26 additions and 19 deletions

View File

@@ -18,19 +18,6 @@ import { interpretResultsSarif } from "../query-results";
import { join } from "path";
import { assertNever } from "../common/helpers-pure";
type Options = {
cliServer: CodeQLCliServer;
queryRunner: QueryRunner;
databaseItem: DatabaseItem;
queryStorageDir: string;
progress: ProgressCallback;
};
export type AutoModelQueriesResult = {
candidates: Sarif.Log;
};
type AutoModelQueryOptions = {
cliServer: CodeQLCliServer;
queryRunner: QueryRunner;
@@ -158,10 +145,28 @@ async function runAutoModelQuery(
return sarif;
}
export async function runAutoModelQueries(
mode: Mode,
{ cliServer, queryRunner, databaseItem, queryStorageDir, progress }: Options,
): Promise<AutoModelQueriesResult | undefined> {
type AutoModelQueriesOptions = {
mode: Mode;
cliServer: CodeQLCliServer;
queryRunner: QueryRunner;
databaseItem: DatabaseItem;
queryStorageDir: string;
progress: ProgressCallback;
};
export type AutoModelQueriesResult = {
candidates: Sarif.Log;
};
export async function runAutoModelQueries({
mode,
cliServer,
queryRunner,
databaseItem,
queryStorageDir,
progress,
}: AutoModelQueriesOptions): Promise<AutoModelQueriesResult | undefined> {
// maxStep for this part is 1500
const maxStep = 1500;

View File

@@ -383,7 +383,8 @@ export class DataExtensionsEditorView extends AbstractWebview<
let predictedModeledMethods: Record<string, ModeledMethod>;
if (useLlmGenerationV2()) {
const usages = await runAutoModelQueries(this.mode, {
const usages = await runAutoModelQueries({
mode: this.mode,
cliServer: this.cliServer,
queryRunner: this.queryRunner,
queryStorageDir: this.queryStorageDir,

View File

@@ -73,6 +73,7 @@ describe("runAutoModelQueries", () => {
};
const options = {
mode: Mode.Application,
cliServer: mockedObject<CodeQLCliServer>({
resolveQlpacks: jest.fn().mockResolvedValue({
"/a/b/c/my-extension-pack": {},
@@ -149,7 +150,7 @@ describe("runAutoModelQueries", () => {
progress: jest.fn(),
};
const result = await runAutoModelQueries(Mode.Application, options);
const result = await runAutoModelQueries(options);
expect(result).not.toBeUndefined();
expect(options.cliServer.resolveQlpacks).toHaveBeenCalledTimes(1);