Use a generated queryId on VariantAnalysisHistoryItem

This commit is contained in:
shati-patel
2022-10-18 11:29:17 +01:00
parent 04c9f17398
commit ad9b46e494
4 changed files with 7 additions and 2 deletions

View File

@@ -25,7 +25,7 @@ export function getQueryId(item: QueryHistoryInfo): string {
case 'remote':
return item.queryId;
case 'variant-analysis':
return item.variantAnalysis.id.toString();
return item.queryId;
default:
assertNever(item);
}

View File

@@ -51,6 +51,7 @@ import { EvalLogData, parseViewerData } from './pure/log-summary-parser';
import { QueryWithResults } from './run-queries-shared';
import { QueryRunner } from './queryRunner';
import { VariantAnalysisManager } from './remote-queries/variant-analysis-manager';
import { nanoid } from 'nanoid';
/**
* query-history.ts
@@ -603,6 +604,7 @@ export class QueryHistoryManager extends DisposableObject {
t: 'variant-analysis',
status: QueryStatus.InProgress,
completed: false,
queryId: nanoid(),
variantAnalysis,
});

View File

@@ -10,6 +10,7 @@ export interface VariantAnalysisHistoryItem {
resultCount?: number;
status: QueryStatus;
completed: boolean;
readonly queryId: string,
variantAnalysis: VariantAnalysis;
userSpecifiedLabel?: string;
}

View File

@@ -32,6 +32,7 @@ describe('Query history info', () => {
t: 'variant-analysis',
status: QueryStatus.InProgress,
completed: false,
queryId: 'abc123',
variantAnalysis: createMockVariantAnalysis()
};
@@ -65,12 +66,13 @@ describe('Query history info', () => {
t: 'variant-analysis',
status: QueryStatus.InProgress,
completed: false,
queryId: 'abc123',
variantAnalysis: createMockVariantAnalysis()
};
const queryId = getQueryId(queryHistoryItem);
expect(queryId).to.equal(queryHistoryItem.variantAnalysis.id.toString());
expect(queryId).to.equal(queryHistoryItem.queryId);
});
});
});