mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #3345 from github/robertbrignull/addWatcher-unknown

Browse Source 
Use bind instead of thisArg parameter in MultiFileSystemWatcher
This commit is contained in:
Robert
2024-02-12 16:37:21 +00:00
committed by GitHub
parent 6472ea8fde 8a389f2eb7
commit f4edc6e5a9
1 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
extensions/ql-vscode/src/common/vscode/multi-file-system-watcher.ts
View File

@@ -18,15 +18,11 @@ class WatcherCollection extends DisposableObject {
* deleted.
* @param thisArgs The `this` argument for the event listener.
*/
public addWatcher(
pattern: GlobPattern,
listener: (e: Uri) => any,
thisArgs: any,
): void {
public addWatcher(pattern: GlobPattern, listener: (e: Uri) => void): void {
const watcher = workspace.createFileSystemWatcher(pattern);
this.push(watcher.onDidCreate(listener, thisArgs));
this.push(watcher.onDidChange(listener, thisArgs));
this.push(watcher.onDidDelete(listener, thisArgs));
this.push(watcher.onDidCreate(listener));
this.push(watcher.onDidChange(listener));
this.push(watcher.onDidDelete(listener));
}
}
@@ -54,7 +50,7 @@ export class MultiFileSystemWatcher extends DisposableObject {
* @param pattern The pattern to watch.
*/
public addWatch(pattern: GlobPattern): void {
this.watchers.addWatcher(pattern, this.handleDidChange, this);
this.watchers.addWatcher(pattern, this.handleDidChange.bind(this));
}
/**