Add dependencies to useEffect hooks

2023-08-11 17:22:43 +01:00
parent d173ff3c48
commit ee20a28fdc
1 changed files with 2 additions and 2 deletions
--- a/extensions/ql-vscode/src/view/results/ResultTables.tsx
+++ b/extensions/ql-vscode/src/view/results/ResultTables.tsx
@@ -164,7 +164,7 @@ export function ResultTables(props: ResultTablesProps) {
    return () => {
      window.removeEventListener("message", vscodeMessageHandler);
    };
-  }, []);
+  }, [vscodeMessageHandler]);

  useEffect(() => {
    const resultSetExists =
@@ -180,7 +180,7 @@ export function ResultTables(props: ResultTablesProps) {
          getDefaultResultSet(getResultSets(rawResultSets, interpretation)),
      );
    }
-  });
+  }, [parsedResultSets, interpretation, rawResultSets, selectedTable]);

  const onTableSelectionChange = (
    event: React.ChangeEvent<HTMLSelectElement>,