From ee20a28fdc1401d6eef5b142ece7727359c3ecac Mon Sep 17 00:00:00 2001 From: Robert Date: Fri, 11 Aug 2023 17:22:43 +0100 Subject: [PATCH] Add dependencies to useEffect hooks --- extensions/ql-vscode/src/view/results/ResultTables.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extensions/ql-vscode/src/view/results/ResultTables.tsx b/extensions/ql-vscode/src/view/results/ResultTables.tsx index c153f498e..f5697f7e0 100644 --- a/extensions/ql-vscode/src/view/results/ResultTables.tsx +++ b/extensions/ql-vscode/src/view/results/ResultTables.tsx @@ -164,7 +164,7 @@ export function ResultTables(props: ResultTablesProps) { return () => { window.removeEventListener("message", vscodeMessageHandler); }; - }, []); + }, [vscodeMessageHandler]); useEffect(() => { const resultSetExists = @@ -180,7 +180,7 @@ export function ResultTables(props: ResultTablesProps) { getDefaultResultSet(getResultSets(rawResultSets, interpretation)), ); } - }); + }, [parsedResultSets, interpretation, rawResultSets, selectedTable]); const onTableSelectionChange = ( event: React.ChangeEvent,