mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Remove redundant argument from onChange (#2852)

Browse Source
This commit is contained in:
Charis Kyriakou
2023-09-25 09:41:36 +01:00
committed by GitHub
parent 3e259f14c9
commit 3934ba7e69
16 changed files with 23 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
extensions/ql-vscode/src/stories/method-modeling/MethodModelingInputs.stories.tsx
View File

@@ -7,7 +7,6 @@ import { createMethod } from "../../../test/factories/model-editor/method-factor
import { createModeledMethod } from "../../../test/factories/model-editor/modeled-method-factories";
import { useState } from "react";
import { ModeledMethod } from "../../model-editor/modeled-method";
import { Method } from "../../model-editor/method";
export default {
title: "Method Modeling/Method Modeling Inputs",
@@ -26,7 +25,7 @@ const Template: StoryFn<typeof MethodModelingInputsComponent> = (args) => {
args.modeledMethod,
);
const onChange = (method: Method, modeledMethod: ModeledMethod) => {
const onChange = (modeledMethod: ModeledMethod) => {
setModeledMethod(modeledMethod);
};

2
extensions/ql-vscode/src/view/method-modeling/MethodModeling.tsx
View File

@@ -36,7 +36,7 @@ export type MethodModelingProps = {
modelingStatus: ModelingStatus;
method: Method;
modeledMethod: ModeledMethod | undefined;
onChange: (method: Method, modeledMethod: ModeledMethod) => void;
onChange: (modeledMethod: ModeledMethod) => void;
};
export const MethodModeling = ({

2
extensions/ql-vscode/src/view/method-modeling/MethodModelingInputs.tsx
View File

@@ -21,7 +21,7 @@ const Name = styled.span`
export type MethodModelingInputsProps = {
method: Method;
modeledMethod: ModeledMethod | undefined;
onChange: (method: Method, modeledMethod: ModeledMethod) => void;
onChange: (modeledMethod: ModeledMethod) => void;
};
export const MethodModelingInputs = ({

2
extensions/ql-vscode/src/view/method-modeling/MethodModelingView.tsx
View File

@@ -44,7 +44,7 @@ export function MethodModelingView(): JSX.Element {
// For now we just store the updated method in the state but soon
// we'll need to send it back to the other views.
const onChange = (method: Method, modeledMethod: ModeledMethod) => {
const onChange = (modeledMethod: ModeledMethod) => {
setModeledMethod(modeledMethod);
};

1
extensions/ql-vscode/src/view/method-modeling/__tests__/MethodModelingInputs.spec.tsx
View File

@@ -54,7 +54,6 @@ describe(MethodModelingInputs.name, () => {
await userEvent.selectOptions(modelTypeDropdown, "source");
expect(onChange).toHaveBeenCalledWith(
method,
expect.objectContaining({
type: "source",
}),

2
extensions/ql-vscode/src/view/model-editor/LibraryRow.tsx
View File

@@ -76,7 +76,7 @@ export type LibraryRowProps = {
inProgressMethods: InProgressMethods;
viewState: ModelEditorViewState;
hideModeledMethods: boolean;
onChange: (method: Method, modeledMethod: ModeledMethod) => void;
onChange: (modeledMethod: ModeledMethod) => void;
onSaveModelClick: (
methods: Method[],
modeledMethods: Record<string, ModeledMethod>,

2
extensions/ql-vscode/src/view/model-editor/MethodRow.tsx
View File

@@ -56,7 +56,7 @@ export type MethodRowProps = {
methodIsUnsaved: boolean;
modelingInProgress: boolean;
mode: Mode;
onChange: (method: Method, modeledMethod: ModeledMethod) => void;
onChange: (modeledMethod: ModeledMethod) => void;
};
export const MethodRow = (props: MethodRowProps) => {

6
extensions/ql-vscode/src/view/model-editor/ModelEditor.tsx
View File

@@ -179,14 +179,14 @@ export function ModelEditor({
[methods],
);
const onChange = useCallback((method: Method, model: ModeledMethod) => {
const onChange = useCallback((model: ModeledMethod) => {
setModeledMethods((oldModeledMethods) => ({
...oldModeledMethods,
[method.signature]: model,
[model.signature]: model,
}));
setModifiedSignatures(
(oldModifiedSignatures) =>
new Set([...oldModifiedSignatures, method.signature]),
new Set([...oldModifiedSignatures, model.signature]),
);
}, []);

6
extensions/ql-vscode/src/view/model-editor/ModelInputDropdown.tsx
View File

@@ -7,7 +7,7 @@ import { Method, getArgumentsList } from "../../model-editor/method";
type Props = {
method: Method;
modeledMethod: ModeledMethod | undefined;
onChange: (method: Method, modeledMethod: ModeledMethod) => void;
onChange: (modeledMethod: ModeledMethod) => void;
};
export const ModelInputDropdown = ({
@@ -45,12 +45,12 @@ export const ModelInputDropdown = ({
const target = e.target as HTMLSelectElement;
onChange(method, {
onChange({
...modeledMethod,
input: target.value,
});
},
[onChange, method, modeledMethod],
[onChange, modeledMethod],
);
return (

6
extensions/ql-vscode/src/view/model-editor/ModelKindDropdown.tsx
View File

@@ -11,7 +11,7 @@ import { extensiblePredicateDefinitions } from "../../model-editor/predicates";
type Props = {
method: Method;
modeledMethod: ModeledMethod | undefined;
onChange: (method: Method, modeledMethod: ModeledMethod) => void;
onChange: (modeledMethod: ModeledMethod) => void;
};
export const ModelKindDropdown = ({
@@ -43,12 +43,12 @@ export const ModelKindDropdown = ({
return;
}
onChange(method, {
onChange({
...modeledMethod,
kind,
});
},
[method, modeledMethod, onChange],
[modeledMethod, onChange],
);
const handleChange = useCallback(

6
extensions/ql-vscode/src/view/model-editor/ModelOutputDropdown.tsx
View File

@@ -7,7 +7,7 @@ import { Method, getArgumentsList } from "../../model-editor/method";
type Props = {
method: Method;
modeledMethod: ModeledMethod | undefined;
onChange: (method: Method, modeledMethod: ModeledMethod) => void;
onChange: (modeledMethod: ModeledMethod) => void;
};
export const ModelOutputDropdown = ({
@@ -47,12 +47,12 @@ export const ModelOutputDropdown = ({
const target = e.target as HTMLSelectElement;
onChange(method, {
onChange({
...modeledMethod,
output: target.value,
});
},
[onChange, method, modeledMethod],
[onChange, modeledMethod],
);
return (

4
extensions/ql-vscode/src/view/model-editor/ModelTypeDropdown.tsx
View File

@@ -19,7 +19,7 @@ const options: Array<{ value: ModeledMethodType; label: string }> = [
type Props = {
method: Method;
modeledMethod: ModeledMethod | undefined;
onChange: (method: Method, modeledMethod: ModeledMethod) => void;
onChange: (modeledMethod: ModeledMethod) => void;
};
export const ModelTypeDropdown = ({
@@ -54,7 +54,7 @@ export const ModelTypeDropdown = ({
methodName: method.methodName,
methodParameters: method.methodParameters,
};
onChange(method, updatedModeledMethod);
onChange(updatedModeledMethod);
},
[onChange, method, modeledMethod, argumentsList],
);

2
extensions/ql-vscode/src/view/model-editor/ModeledMethodDataGrid.tsx
View File

@@ -23,7 +23,7 @@ export type ModeledMethodDataGridProps = {
inProgressMethods: InProgressMethods;
mode: Mode;
hideModeledMethods: boolean;
onChange: (method: Method, modeledMethod: ModeledMethod) => void;
onChange: (modeledMethod: ModeledMethod) => void;
};
export const ModeledMethodDataGrid = ({

2
extensions/ql-vscode/src/view/model-editor/ModeledMethodsList.tsx
View File

@@ -18,7 +18,7 @@ export type ModeledMethodsListProps = {
inProgressMethods: InProgressMethods;
viewState: ModelEditorViewState;
hideModeledMethods: boolean;
onChange: (method: Method, modeledMethod: ModeledMethod) => void;
onChange: (modeledMethod: ModeledMethod) => void;
onSaveModelClick: (
methods: Method[],
modeledMethods: Record<string, ModeledMethod>,

2
extensions/ql-vscode/src/view/model-editor/__tests__/MethodRow.spec.tsx
View File

@@ -66,7 +66,7 @@ describe(MethodRow.name, () => {
);
expect(onChange).toHaveBeenCalledTimes(1);
expect(onChange).toHaveBeenCalledWith(method, {
expect(onChange).toHaveBeenCalledWith({
...modeledMethod,
kind: "value",
});

2
extensions/ql-vscode/src/view/model-editor/__tests__/ModelKindDropdown.spec.tsx
View File

@@ -30,7 +30,6 @@ describe(ModelKindDropdown.name, () => {
expect(screen.getByRole("combobox")).toHaveValue("local");
await userEvent.selectOptions(screen.getByRole("combobox"), "remote");
expect(onChange).toHaveBeenCalledWith(
method,
expect.objectContaining({
kind: "remote",
}),
@@ -87,7 +86,6 @@ describe(ModelKindDropdown.name, () => {
expect(screen.getByRole("combobox")).toHaveValue("local");
expect(onChange).toHaveBeenCalledWith(
method,
expect.objectContaining({
kind: "local",
}),