mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Use useCallback when calling toggleExpanded

Browse Source
This commit is contained in:
Robert
2023-08-21 17:13:49 +01:00
parent eebe11e5dd
commit d65ce3e24a
2 changed files with 16 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/ql-vscode/src/view/results/AlertTablePathRow.tsx
View File

@@ -5,7 +5,7 @@ import { selectableZebraStripe } from "./result-table-utils";
import { ScrollIntoViewHelper } from "./scroll-into-view-helper";
import { AlertTablePathNodeRow } from "./AlertTablePathNodeRow";
import { AlertTableDropdownIndicatorCell } from "./AlertTableDropdownIndicatorCell";
import { useMemo } from "react";
import { useCallback, useMemo } from "react";
interface Props {
path: Sarif.ThreadFlow;
@@ -37,8 +37,8 @@ export function AlertTablePathRow(props: Props) {
() => ({ resultIndex, pathIndex }),
[pathIndex, resultIndex],
);
const handleDropdownClick = useMemo(
() => (e: React.MouseEvent) => toggleExpanded(e, [pathKey]),
const handleDropdownClick = useCallback(
(e: React.MouseEvent) => toggleExpanded(e, [pathKey]),
[pathKey, toggleExpanded],
);

23
extensions/ql-vscode/src/view/results/AlertTableResultRow.tsx
View File

@@ -5,7 +5,7 @@ import { info, listUnordered } from "./octicons";
import { ScrollIntoViewHelper } from "./scroll-into-view-helper";
import { selectableZebraStripe } from "./result-table-utils";
import { AlertTableDropdownIndicatorCell } from "./AlertTableDropdownIndicatorCell";
import { useMemo } from "react";
import { useCallback, useMemo } from "react";
import { SarifLocation } from "./locations/SarifLocation";
import { SarifMessageWithLocations } from "./locations/SarifMessageWithLocations";
import { AlertTablePathRow } from "./AlertTablePathRow";
@@ -46,15 +46,18 @@ export function AlertTableResultRow(props: Props) {
() => updateSelectionCallback(resultKey),
[resultKey, updateSelectionCallback],
);
const handleDropdownClick = useMemo(() => {
const indices =
Keys.getAllPaths(result).length === 1
? [resultKey, { ...resultKey, pathIndex: 0 }]
: /* if there's exactly one path, auto-expand
* the path when expanding the result */
[resultKey];
return (e: React.MouseEvent) => toggleExpanded(e, indices);
}, [result, resultKey, toggleExpanded]);
const handleDropdownClick = useCallback(
(e: React.MouseEvent) => {
const indices =
Keys.getAllPaths(result).length === 1
? [resultKey, { ...resultKey, pathIndex: 0 }]
: /* if there's exactly one path, auto-expand
* the path when expanding the result */
[resultKey];
toggleExpanded(e, indices);
},
[result, resultKey, toggleExpanded],
);
const resultRowIsSelected =
selectedItem?.resultIndex === resultIndex &&