Rename: queryId -> historyItemId

This commit is contained in:
shati-patel
2022-10-18 11:39:16 +01:00
parent 2eaa923019
commit 77deea77fc
4 changed files with 7 additions and 7 deletions

View File

@@ -25,7 +25,7 @@ export function getQueryHistoryItemId(item: QueryHistoryInfo): string {
case 'remote':
return item.queryId;
case 'variant-analysis':
return item.queryId;
return item.historyItemId;
default:
assertNever(item);
}

View File

@@ -604,7 +604,7 @@ export class QueryHistoryManager extends DisposableObject {
t: 'variant-analysis',
status: QueryStatus.InProgress,
completed: false,
queryId: nanoid(),
historyItemId: nanoid(),
variantAnalysis,
});

View File

@@ -10,7 +10,7 @@ export interface VariantAnalysisHistoryItem {
resultCount?: number;
status: QueryStatus;
completed: boolean;
readonly queryId: string,
readonly historyItemId: string,
variantAnalysis: VariantAnalysis;
userSpecifiedLabel?: string;
}

View File

@@ -32,7 +32,7 @@ describe('Query history info', () => {
t: 'variant-analysis',
status: QueryStatus.InProgress,
completed: false,
queryId: 'abc123',
historyItemId: 'abc123',
variantAnalysis: createMockVariantAnalysis()
};
@@ -42,7 +42,7 @@ describe('Query history info', () => {
});
});
describe('getQueryId', () => {
describe('getQueryHistoryItemId', () => {
it('should get the ID for local history items', () => {
const date = new Date('2022-01-01T00:00:00.000Z');
const dateStr = date.toLocaleString();
@@ -66,13 +66,13 @@ describe('Query history info', () => {
t: 'variant-analysis',
status: QueryStatus.InProgress,
completed: false,
queryId: 'abc123',
historyItemId: 'abc123',
variantAnalysis: createMockVariantAnalysis()
};
const queryId = getQueryHistoryItemId(queryHistoryItem);
expect(queryId).to.equal(queryHistoryItem.queryId);
expect(queryId).to.equal(queryHistoryItem.historyItemId);
});
});
});