Merge pull request #1943 from github/robertbrignull/telemetry_race_condition

Avoid race condition requesting telemetry permissions
2023-01-09 17:38:00 +00:00
parent 7bbbf8b986 aa950eed6a
commit 82ce7bc874
1 changed files with 2 additions and 4 deletions
--- a/extensions/ql-vscode/src/telemetry.ts
+++ b/extensions/ql-vscode/src/telemetry.ts
@@ -95,10 +95,8 @@ export class TelemetryListener extends ConfigListener {
      CANARY_FEATURES.getValue() &&
      !ENABLE_TELEMETRY.getValue()
    ) {
-      await Promise.all([
-        this.setTelemetryRequested(false),
-        this.requestTelemetryPermission(),
-      ]);
+      await this.setTelemetryRequested(false);
+      await this.requestTelemetryPermission();
    }
  }