mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #2219 from github/koesie10/fix-command-runner-references

Browse Source 
Remove remaining references to `commandRunner`
This commit is contained in:
Koen Vlaswinkel
2023-03-23 14:03:39 +01:00
committed by GitHub
parent 96c9a4aca7 d0c4e5b8c5
commit 164536338b
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/ql-vscode/src/common/vscode/commands.ts
View File

@@ -15,7 +15,7 @@ import {
import { telemetryListener } from "../../telemetry";
/**
* Create a command manager for VSCode, wrapping the commandRunner
* Create a command manager for VSCode, wrapping registerCommandWithErrorHandling
* and vscode.executeCommand.
*/
export function createVSCodeCommandManager<

7
extensions/ql-vscode/src/extension.ts
View File

@@ -236,7 +236,7 @@ function registerErrorStubs(
stubbedCommands.forEach((command) => {
if (excludedCommands.indexOf(command) === -1) {
// This is purposefully using `commandRunner` instead of the command manager because these
// This is purposefully using `registerCommandWithErrorHandling` instead of the command manager because these
// commands are untyped and registered pre-activation.
errorStubs.push(
registerCommandWithErrorHandling(command, stubGenerator(command)),
@@ -341,7 +341,7 @@ export async function activate(
),
);
ctx.subscriptions.push(
// This is purposefully using `commandRunner` directly instead of the command manager
// This is purposefully using `registerCommandWithErrorHandling` directly instead of the command manager
// because this command is registered pre-activation.
registerCommandWithErrorHandling(checkForUpdatesCommand, () =>
installOrUpdateThenTryActivate(
@@ -1035,7 +1035,8 @@ function addUnhandledRejectionListener() {
// "uncaughtException" will trigger whenever an exception reaches the top level.
// This covers extension initialization and any code within a `setTimeout`.
// Notably this does not include exceptions thrown when executing commands,
// because `commandRunner` wraps the command body and handles errors.
// because `registerCommandWithErrorHandling` wraps the command body and
// handles errors.
process.addListener("uncaughtException", handler);
// "unhandledRejection" will trigger whenever any promise is rejected and it is