mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #3298 from github/koesie10/try-fix-flaky-suggestbox-tab

Browse Source 
Wait for options to be shown and to be removed when pressing Tab
This commit is contained in:
Koen Vlaswinkel
2024-01-31 16:26:33 +01:00
committed by GitHub
parent e9e98403a9 820989a8c5
commit b3284d6760
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
extensions/ql-vscode/src/view/common/SuggestBox/__tests__/SuggestBox.test.tsx
View File

@@ -1,4 +1,4 @@
import { render as reactRender, screen } from "@testing-library/react";
import { render as reactRender, screen, waitFor } from "@testing-library/react";
import type { SuggestBoxProps } from "../SuggestBox";
import { SuggestBox } from "../SuggestBox";
import { userEvent } from "@testing-library/user-event";
@@ -200,6 +200,9 @@ describe("SuggestBox", () => {
});
await userEvent.click(screen.getByRole("combobox"));
expect(screen.getAllByRole("option")).not.toHaveLength(0);
await userEvent.keyboard("{Enter}");
expect(screen.queryByRole("option")).not.toBeInTheDocument();
@@ -211,9 +214,14 @@ describe("SuggestBox", () => {
});
await userEvent.click(screen.getByRole("combobox"));
expect(screen.getAllByRole("option")).not.toHaveLength(0);
await userEvent.keyboard("{Tab}");
expect(screen.queryByRole("option")).not.toBeInTheDocument();
await waitFor(() => {
expect(screen.queryByRole("option")).not.toBeInTheDocument();
});
});
it("shows no suggestions with no matching followup options", async () => {