Don't use shorthand boolean for large method calls

To make it clear what the search is doing and make the code more readable.

Co-authored-by: Robert Brignull <robertbrignull@github.com>
This commit is contained in:
Elena Tanasoiu
2023-04-18 13:38:13 +00:00
parent 28745da7b8
commit 30ebe0ab57

View File

@@ -269,18 +269,21 @@ export class SkeletonQueryWizard {
throw new Error("Language is undefined");
}
const databaseNwo = QUERY_LANGUAGE_TO_DATABASE_REPO[this.language];
const defaultDatabaseNwo = QUERY_LANGUAGE_TO_DATABASE_REPO[this.language];
return (
(await this.findDatabaseItemByNwo(
this.language,
databaseNwo,
this.databaseManager.databaseItems,
)) ||
(await this.findDatabaseItemByLanguage(
this.language,
this.databaseManager.databaseItems,
))
const defaultDatabaseItem = await this.findDatabaseItemByNwo(
this.language,
defaultDatabaseNwo,
this.databaseManager.databaseItems,
);
if (defaultDatabaseItem !== undefined) {
return defaultDatabaseItem;
}
return await this.findDatabaseItemByLanguage(
this.language,
this.databaseManager.databaseItems,
);
}
}