mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fix incorrect await for monitor

Browse Source 
When rehydrating remote queries, we were awaiting the monitoring
command. Since this command may take minutes to hours to complete, it
seems like this would block the extension from loading. This is the same
issue as in https://github.com/github/vscode-codeql/pull/1698, but for
remote queries instead of variant analyses.
This commit is contained in:
Koen Vlaswinkel
2022-12-06 14:36:00 +01:00
parent c436688eb2
commit 6f52469d64
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/ql-vscode/src/remote-queries/remote-queries-manager.ts
View File

@@ -125,11 +125,7 @@ export class RemoteQueriesManager extends DisposableObject {
} else if (status === QueryStatus.InProgress) {
// In this case, last time we checked, the query was still in progress.
// We need to setup the monitor to check for completion.
await commands.executeCommand(
"codeQL.monitorRemoteQuery",
queryId,
query,
);
void commands.executeCommand("codeQL.monitorRemoteQuery", queryId, query);
}
}