mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Allow repo names with periods (#1391)

Browse Source
This commit is contained in:
Shati Patel
2022-06-16 17:43:31 +01:00
committed by GitHub
parent efcade84c6
commit 18097e4676
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/ql-vscode/src/pure/helpers-pure.ts
View File

@@ -33,10 +33,10 @@ export const asyncFilter = async function <T>(arr: T[], predicate: (arg0: T) =>
/**
* This regex matches strings of the form `owner/repo` where:
* - `owner` is made up of alphanumeric characters or single hyphens, starting and ending in an alphanumeric character
* - `repo` is made up of alphanumeric characters, hyphens, or underscores
* - `owner` is made up of alphanumeric characters, hyphens, underscores, or periods
* - `repo` is made up of alphanumeric characters, hyphens, underscores, or periods
*/
export const REPO_REGEX = /^(?:[a-zA-Z0-9]+-)*[a-zA-Z0-9]+\/[a-zA-Z0-9-_]+$/;
export const REPO_REGEX = /^[a-zA-Z0-9-_\.]+\/[a-zA-Z0-9-_\.]+$/;
export function getErrorMessage(e: any) {
return e instanceof Error ? e.message : String(e);

4
extensions/ql-vscode/src/vscode-tests/no-workspace/remote-queries/repository-selection.test.ts
View File

@@ -77,7 +77,7 @@ describe('repository-selection', function() {
// Test the regex in various "good" cases
const goodRepos = [
'owner/repo',
'owner-with-hyphens/repo-with-hyphens_and_underscores',
'owner_with.symbols-/repo.with-symbols_',
'ownerWithNumbers58/repoWithNumbers37'
];
goodRepos.forEach(repo => {
@@ -101,7 +101,7 @@ describe('repository-selection', function() {
// Test the regex in various "bad" cases
const badRepos = [
'invalid_owner/repo',
'invalid*owner/repo',
'owner/repo+some&invalid&stuff',
'owner-with-no-repo/',
'/repo-with-no-owner'