Change parameter type + extract local variable

This commit is contained in:
shati-patel
2022-06-01 20:47:25 +01:00
committed by Shati Patel
parent a3bbdafabb
commit d41c63bf7d
2 changed files with 4 additions and 3 deletions

View File

@@ -98,7 +98,7 @@ export function isStringLoc(loc: UrlValue): loc is string {
export function tryGetRemoteLocation(
loc: UrlValue | undefined,
fileLinkPrefix: string,
sourceLocationPrefix: string,
sourceLocationPrefix: string | undefined,
): string | undefined {
const resolvableLocation = tryGetResolvableLocation(loc);
if (!resolvableLocation) {

View File

@@ -48,10 +48,11 @@ const Cell = ({
return <span>{convertNonPrintableChars(value.toString())}</span>;
case 'object': {
const url = tryGetRemoteLocation(value.url, fileLinkPrefix, sourceLocationPrefix);
const safeLabel = convertNonPrintableChars(value.label);
if (url) {
return <Link href={url}>{convertNonPrintableChars(value.label)}</Link>;
return <Link href={url}>{safeLabel}</Link>;
} else {
return <span>{convertNonPrintableChars(value.label)}</span>;
return <span>{safeLabel}</span>;
}
}
}