mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #3158 from github/koesie10/fix-qltest-discovery-watcher

Browse Source 
Do not reregister watchers on every file change for qltests
This commit is contained in:
Koen Vlaswinkel
2023-12-21 09:49:58 +01:00
committed by GitHub
parent 262744e6e5 218be87e88
commit f3780c6305
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
extensions/ql-vscode/src/query-testing/qltest-discovery.ts
View File

@@ -31,6 +31,15 @@ export class QLTestDiscovery extends Discovery {
super("QL Test Discovery", extLogger);
this.push(this.watcher.onDidChange(this.handleDidChange, this));
// Watch for changes to any `.ql` or `.qlref` file in any of the QL packs that contain tests.
this.watcher.addWatch(
new RelativePattern(this.workspaceFolder.uri.fsPath, "**/*.{ql,qlref}"),
);
// need to explicitly watch for changes to directories themselves.
this.watcher.addWatch(
new RelativePattern(this.workspaceFolder.uri.fsPath, "**/"),
);
}
/**
@@ -56,15 +65,6 @@ export class QLTestDiscovery extends Discovery {
protected async discover() {
this._testDirectory = await this.discoverTests();
this.watcher.clear();
// Watch for changes to any `.ql` or `.qlref` file in any of the QL packs that contain tests.
this.watcher.addWatch(
new RelativePattern(this.workspaceFolder.uri.fsPath, "**/*.{ql,qlref}"),
);
// need to explicitly watch for changes to directories themselves.
this.watcher.addWatch(
new RelativePattern(this.workspaceFolder.uri.fsPath, "**/"),
);
this._onDidChangeTests.fire(undefined);
}