mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Stop checking result count and rename repoScanHasResults

Browse Source
This commit is contained in:
Robert
2022-10-31 10:24:34 +00:00
parent 599a9ed5d9
commit 7748f82c96
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/ql-vscode/src/remote-queries/shared/variant-analysis.ts
View File

@@ -153,10 +153,10 @@ export function hasRepoScanCompleted(repo: VariantAnalysisScannedRepository): bo
/**
* @param repo
* @returns whether the repo scan is complete and has results that can be downloaded
* @returns whether the repo scan has an artifact that can be downloaded
*/
export function repoScanHasResults(repo: VariantAnalysisScannedRepository): boolean {
return repo.analysisStatus === VariantAnalysisRepoStatus.Succeeded && (repo.resultCount || 0) > 0;
export function repoHasDownloadableArtifact(repo: VariantAnalysisScannedRepository): boolean {
return repo.analysisStatus === VariantAnalysisRepoStatus.Succeeded;
}
/**

4
extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts
View File

@@ -12,7 +12,7 @@ import {
} from './gh-api/variant-analysis';
import {
hasRepoScanCompleted,
repoScanHasResults,
repoHasDownloadableArtifact,
VariantAnalysis, VariantAnalysisQueryLanguage,
VariantAnalysisScannedRepository,
VariantAnalysisScannedRepositoryDownloadStatus,
@@ -87,7 +87,7 @@ export class VariantAnalysisManager extends DisposableObject implements VariantA
private async isVariantAnalysisRepoComplete(variantAnalysisId: number, repo: VariantAnalysisScannedRepository): Promise<boolean> {
if (!hasRepoScanCompleted(repo)) {
return false;
} else if (!repoScanHasResults(repo)) {
} else if (!repoHasDownloadableArtifact(repo)) {
return true;
} else {
const storageLocation = this.getVariantAnalysisStorageLocation(variantAnalysisId);