Replace faker.datatype.number by faker.number.int

extensions/ql-vscode/src/stories/variant-analysis/VariantAnalysisAnalyzedRepos.stories.tsx

@@ -135,11 +135,11 @@ const manyScannedRepos = Array.from({ length: 1000 }, (_, i) => {
   return {
     ...mockedScannedRepo,
     analysisStatus: VariantAnalysisRepoStatus.Succeeded,
-    resultCount: faker.datatype.number({ min: 0, max: 1000 }),
+    resultCount: faker.number.int({ min: 0, max: 1000 }),
     repository: {
       ...mockedScannedRepo.repository,
       // We need to ensure the ID is unique for React keys
-      id: faker.helpers.unique(faker.datatype.number, [], {
+      id: faker.helpers.unique(faker.number.int, [], {
         store: uniqueStore,
       }),
       fullName: `octodemo/${faker.helpers.unique(faker.random.word, [], {

extensions/ql-vscode/test/factories/db-config-factories.ts

@@ -41,10 +41,10 @@ export function createDbConfig({
 }
 
 export function createLocalDbConfigItem({
-  name = `database${faker.datatype.number()}`,
+  name = `database${faker.number.int()}`,
   dateAdded = faker.date.past().getTime(),
-  language = `language${faker.datatype.number()}`,
-  storagePath = `storagePath${faker.datatype.number()}`,
+  language = `language${faker.number.int()}`,
+  storagePath = `storagePath${faker.number.int()}`,
 }: {
   name?: string;
   dateAdded?: number;

extensions/ql-vscode/test/factories/db-item-factories.ts

@@ -29,7 +29,7 @@ export function createRootRemoteDbItem({
 }
 
 export function createRemoteOwnerDbItem({
-  ownerName = `owner${faker.datatype.number()}`,
+  ownerName = `owner${faker.number.int()}`,
   selected = false,
 }: {
   ownerName?: string;
@@ -43,7 +43,7 @@ export function createRemoteOwnerDbItem({
 }
 
 export function createRemoteRepoDbItem({
-  repoFullName = `owner${faker.datatype.number()}/repo${faker.datatype.number}`,
+  repoFullName = `owner${faker.number.int()}/repo${faker.number.int()}`,
   selected = false,
   parentListName = undefined,
 }: {
@@ -60,7 +60,7 @@ export function createRemoteRepoDbItem({
 }
 
 export function createRemoteSystemDefinedListDbItem({
-  listName = `top_${faker.datatype.number()}`,
+  listName = `top_${faker.number.int()}`,
   listDisplayName = `Display Name`,
   listDescription = `Description`,
   selected = false,
@@ -82,7 +82,7 @@ export function createRemoteSystemDefinedListDbItem({
 export function createRemoteUserDefinedListDbItem({
   expanded = false,
   selected = false,
-  listName = `list${faker.datatype.number()}`,
+  listName = `list${faker.number.int()}`,
   repos = [
     createRemoteRepoDbItem({
       parentListName: listName,
@@ -119,10 +119,10 @@ export function createRootLocalDbItem({
 }
 
 export function createLocalDatabaseDbItem({
-  databaseName = `database${faker.datatype.number()}`,
+  databaseName = `database${faker.number.int()}`,
   dateAdded = faker.date.past().getTime(),
-  language = `language${faker.datatype.number()}`,
-  storagePath = `storagePath${faker.datatype.number()}`,
+  language = `language${faker.number.int()}`,
+  storagePath = `storagePath${faker.number.int()}`,
   selected = false,
 }: {
   databaseName?: string;
@@ -142,7 +142,7 @@ export function createLocalDatabaseDbItem({
 }
 
 export function createLocalListDbItem({
-  listName = `top_${faker.datatype.number()}`,
+  listName = `top_${faker.number.int()}`,
   selected = false,
   expanded = false,
   databases = [],

extensions/ql-vscode/test/factories/query-history/local-query-history-item.ts

@@ -42,7 +42,7 @@ export function createMockLocalQueryInfo({
       name: dbName,
     },
     start: startTime,
-    id: faker.datatype.number().toString(),
+    id: faker.number.int().toString(),
     userSpecifiedLabel,
   } as InitialQueryInfo;
 

extensions/ql-vscode/test/factories/variant-analysis/gh-api/repository.ts

@@ -6,7 +6,7 @@ import {
 
 export function createMockRepository(name = faker.random.word()): Repository {
   return {
-    id: faker.datatype.number(),
+    id: faker.number.int(),
     name,
     full_name: `github/${name}`,
     private: faker.datatype.boolean(),
@@ -16,7 +16,7 @@ export function createMockRepository(name = faker.random.word()): Repository {
 export function createMockRepositoryWithMetadata(): RepositoryWithMetadata {
   return {
     ...createMockRepository(),
-    stargazers_count: faker.datatype.number(),
+    stargazers_count: faker.number.int(),
     updated_at: faker.date.past().toISOString(),
   };
 }

extensions/ql-vscode/test/factories/variant-analysis/gh-api/scanned-repositories.ts

@@ -18,8 +18,8 @@ export function createMockScannedRepo(
       private: isPrivate,
     },
     analysis_status: analysisStatus,
-    result_count: faker.datatype.number(),
-    artifact_size_in_bytes: faker.datatype.number(),
+    result_count: faker.number.int(),
+    artifact_size_in_bytes: faker.number.int(),
   };
 }
 

extensions/ql-vscode/test/factories/variant-analysis/gh-api/variant-analysis-api-response.ts

@@ -16,7 +16,7 @@ export function createMockApiResponse(
   skippedRepos: VariantAnalysisSkippedRepositories = createMockSkippedRepos(),
 ): VariantAnalysisApiResponse {
   const variantAnalysis: VariantAnalysisApiResponse = {
-    id: faker.datatype.number(),
+    id: faker.number.int(),
     controller_repo: {
       ...createMockRepository(),
       name: "pickles",
@@ -28,7 +28,7 @@ export function createMockApiResponse(
     created_at: faker.date.recent().toISOString(),
     updated_at: faker.date.recent().toISOString(),
     status,
-    actions_workflow_run_id: faker.datatype.number(),
+    actions_workflow_run_id: faker.number.int(),
     scanned_repositories: scannedRepos,
     skipped_repositories: skippedRepos,
   };

extensions/ql-vscode/test/factories/variant-analysis/gh-api/variant-analysis-repo-task.ts

@@ -10,8 +10,8 @@ export function createMockVariantAnalysisRepoTask(): VariantAnalysisRepoTask {
       private: false,
     },
     analysis_status: VariantAnalysisRepoStatus.Succeeded,
-    result_count: faker.datatype.number(),
-    artifact_size_in_bytes: faker.datatype.number(),
+    result_count: faker.number.int(),
+    artifact_size_in_bytes: faker.number.int(),
     artifact_url: "https://www.pickles.com",
   };
 }

extensions/ql-vscode/test/factories/variant-analysis/shared/repository.ts

@@ -6,7 +6,7 @@ import {
 
 export function createMockRepository(): Repository {
   return {
-    id: faker.datatype.number(),
+    id: faker.number.int(),
     fullName: `github/${faker.random.word()}`,
     private: faker.datatype.boolean(),
   };
@@ -15,7 +15,7 @@ export function createMockRepository(): Repository {
 export function createMockRepositoryWithMetadata(): RepositoryWithMetadata {
   return {
     ...createMockRepository(),
-    stargazersCount: faker.datatype.number(),
+    stargazersCount: faker.number.int(),
     updatedAt: faker.date.past().toISOString(),
   };
 }

extensions/ql-vscode/test/factories/variant-analysis/shared/scanned-repositories.ts

@@ -17,8 +17,8 @@ export function createMockScannedRepo(
       private: isPrivate,
     },
     analysisStatus,
-    resultCount: faker.datatype.number(),
-    artifactSizeInBytes: faker.datatype.number(),
+    resultCount: faker.number.int(),
+    artifactSizeInBytes: faker.number.int(),
   };
 }
 

extensions/ql-vscode/test/factories/variant-analysis/shared/variant-analysis-repo-tasks.ts

@@ -11,8 +11,8 @@ export function createMockVariantAnalysisRepositoryTask(
   return {
     repository: createMockRepositoryWithMetadata(),
     analysisStatus: VariantAnalysisRepoStatus.Pending,
-    resultCount: faker.datatype.number(),
-    artifactSizeInBytes: faker.datatype.number(),
+    resultCount: faker.number.int(),
+    artifactSizeInBytes: faker.number.int(),
     databaseCommitSha: faker.git.commitSha(),
     sourceLocationPrefix: faker.system.filePath(),
     artifactUrl: faker.internet.url(),

extensions/ql-vscode/test/factories/variant-analysis/shared/variant-analysis-submission.ts

@@ -4,8 +4,8 @@ import { QueryLanguage } from "../../../../src/common/query-language";
 
 export function createMockSubmission(): VariantAnalysisSubmission {
   return {
-    startTime: faker.datatype.number(),
-    controllerRepoId: faker.datatype.number(),
+    startTime: faker.number.int(),
+    controllerRepoId: faker.number.int(),
     actionRepoRef: "repo-ref",
     query: {
       name: "query-name",

extensions/ql-vscode/test/factories/variant-analysis/shared/variant-analysis.ts

@@ -14,7 +14,7 @@ export function createMockVariantAnalysis({
   status = VariantAnalysisStatus.InProgress,
   scannedRepos = createMockScannedRepos(),
   skippedRepos = createMockSkippedRepos(),
-  executionStartTime = faker.datatype.number(),
+  executionStartTime = faker.number.int(),
 }: {
   status?: VariantAnalysisStatus;
   scannedRepos?: VariantAnalysisScannedRepository[];
@@ -22,7 +22,7 @@ export function createMockVariantAnalysis({
   executionStartTime?: number | undefined;
 }): VariantAnalysis {
   return {
-    id: faker.datatype.number(),
+    id: faker.number.int(),
     controllerRepo: {
       ...createMockRepository(),
       fullName: `github/${faker.datatype.hexadecimal({
@@ -42,7 +42,7 @@ export function createMockVariantAnalysis({
     createdAt: faker.date.recent().toISOString(),
     updatedAt: faker.date.recent().toISOString(),
     status,
-    actionsWorkflowRunId: faker.datatype.number(),
+    actionsWorkflowRunId: faker.number.int(),
     scannedRepos,
     skippedRepos,
   };

extensions/ql-vscode/test/vscode-tests/activated-extension/variant-analysis/variant-analysis-results-manager.test.ts

@@ -23,7 +23,7 @@ describe(VariantAnalysisResultsManager.name, () => {
   let variantAnalysisResultsManager: VariantAnalysisResultsManager;
 
   beforeEach(async () => {
-    variantAnalysisId = faker.datatype.number();
+    variantAnalysisId = faker.number.int();
 
     const cli = mockedObject<CodeQLCliServer>({});
     variantAnalysisResultsManager = new VariantAnalysisResultsManager(