mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Use index as react key

Browse Source
This commit is contained in:
Robert
2023-10-09 14:44:43 +01:00
parent 8b0825ab3c
commit 0265353370
1 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
extensions/ql-vscode/src/view/model-editor/MethodRow.tsx
View File

@@ -153,9 +153,9 @@ const ModelableMethodRow = forwardRef<HTMLElement | undefined, MethodRowProps>(
{!props.modelingInProgress && (
<>
<MultiModelColumn gridColumn={2}>
{forEachModeledMethod(modeledMethods, (modeledMethod) => (
{forEachModeledMethod(modeledMethods, (modeledMethod, index) => (
<ModelTypeDropdown
key={JSON.stringify(modeledMethod)}
key={index}
method={method}
modeledMethod={modeledMethod}
onChange={onChange}
@@ -163,9 +163,9 @@ const ModelableMethodRow = forwardRef<HTMLElement | undefined, MethodRowProps>(
))}
</MultiModelColumn>
<MultiModelColumn gridColumn={3}>
{forEachModeledMethod(modeledMethods, (modeledMethod) => (
{forEachModeledMethod(modeledMethods, (modeledMethod, index) => (
<ModelInputDropdown
key={JSON.stringify(modeledMethod)}
key={index}
method={method}
modeledMethod={modeledMethod}
onChange={onChange}
@@ -173,9 +173,9 @@ const ModelableMethodRow = forwardRef<HTMLElement | undefined, MethodRowProps>(
))}
</MultiModelColumn>
<MultiModelColumn gridColumn={4}>
{forEachModeledMethod(modeledMethods, (modeledMethod) => (
{forEachModeledMethod(modeledMethods, (modeledMethod, index) => (
<ModelOutputDropdown
key={JSON.stringify(modeledMethod)}
key={index}
method={method}
modeledMethod={modeledMethod}
onChange={onChange}
@@ -183,9 +183,9 @@ const ModelableMethodRow = forwardRef<HTMLElement | undefined, MethodRowProps>(
))}
</MultiModelColumn>
<MultiModelColumn gridColumn={5}>
{forEachModeledMethod(modeledMethods, (modeledMethod) => (
{forEachModeledMethod(modeledMethods, (modeledMethod, index) => (
<ModelKindDropdown
key={JSON.stringify(modeledMethod)}
key={index}
method={method}
modeledMethod={modeledMethod}
onChange={onChange}
@@ -249,10 +249,13 @@ function sendJumpToUsageMessage(method: Method) {
function forEachModeledMethod(
modeledMethods: ModeledMethod[],
renderer: (modeledMethod: ModeledMethod | undefined) => JSX.Element,
renderer: (
modeledMethod: ModeledMethod | undefined,
index: number,
) => JSX.Element,
): JSX.Element | JSX.Element[] {
if (modeledMethods.length === 0) {
return renderer(undefined);
return renderer(undefined, 0);
} else {
return modeledMethods.map(renderer);
}