mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Convert handleCheckboxChanged to use useCallback

Browse Source
This commit is contained in:
Robert
2023-08-11 17:24:42 +01:00
parent f761083342
commit 4e0ab5b46e
1 changed files with 22 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
extensions/ql-vscode/src/view/results/ResultTables.tsx
View File

@@ -195,25 +195,28 @@ export function ResultTables(props: ResultTablesProps) {
[],
);
const handleCheckboxChanged = (e: React.ChangeEvent<HTMLInputElement>) => {
if (e.target.checked === problemsViewSelected) {
// no change
return;
}
setProblemsViewSelected(e.target.checked);
if (e.target.checked) {
sendTelemetry("local-results-show-results-in-problems-view");
}
if (resultsPath !== undefined) {
vscode.postMessage({
t: "toggleDiagnostics",
origResultsPaths,
databaseUri: database.databaseUri,
visible: e.target.checked,
metadata,
});
}
};
const handleCheckboxChanged = useCallback(
(e: React.ChangeEvent<HTMLInputElement>) => {
if (e.target.checked === problemsViewSelected) {
// no change
return;
}
setProblemsViewSelected(e.target.checked);
if (e.target.checked) {
sendTelemetry("local-results-show-results-in-problems-view");
}
if (resultsPath !== undefined) {
vscode.postMessage({
t: "toggleDiagnostics",
origResultsPaths,
databaseUri: database.databaseUri,
visible: e.target.checked,
metadata,
});
}
},
[database, metadata, origResultsPaths, problemsViewSelected, resultsPath],
);
const alertTableExtras = (): JSX.Element | undefined => {
return (