mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Store LastUpdated as a duration, not a timestamp

Browse Source 
The `lastUpdated` value is now the duration between timestamp of the
last time the repo was updated and time the file was downloaded.
This fixes the duration and it won't change over time.
This commit is contained in:
Andrew Eisenberg
2022-05-25 20:30:28 -07:00
parent e43b4e66a1
commit f373e6467a
4 changed files with 64 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/ql-vscode/src/remote-queries/gh-actions-api-client.ts
View File

@@ -395,7 +395,7 @@ export async function getRepositoriesMetadata(credentials: Credentials, nwos: st
const owner = node.owner.login;
const name = node.name;
const starCount = node.stargazerCount;
const lastUpdated = new Date(node.updatedAt).getTime();
const lastUpdated = Date.now() - new Date(node.updatedAt).getTime();
metadata[`${owner}/${name}`] = {
starCount, lastUpdated
};

63
extensions/ql-vscode/src/remote-queries/view/LasstUpdated.tsx
View File

@@ -1,63 +0,0 @@
import * as React from 'react';
import { CalendarIcon } from '@primer/octicons-react';
import styled from 'styled-components';
const Calendar = styled.span`
flex-grow: 0;
text-align: right;
margin-right: 0;
`;
const Duration = styled.span`
text-align: left;
width: 8em;
margin-left: 0.5em;
`;
type Props = { lastUpdated?: number };
const LastUpdated = ({ lastUpdated }: Props) => (
Number.isFinite(lastUpdated) ? (
<>
<Calendar>
<CalendarIcon size={16} />
</Calendar>
<Duration>
{humanizeDuration(lastUpdated)}
</Duration>
</>
) : (
<></>
)
);
export default LastUpdated;
const formatter = new Intl.RelativeTimeFormat('en', {
numeric: 'auto'
});
// All these are approximate, specifically months and years
const MINUTES_IN_MILLIS = 1000 * 60;
const HOURS_IN_MILLIS = 60 * MINUTES_IN_MILLIS;
const DAYS_IN_MILLIS = 24 * HOURS_IN_MILLIS;
const MONTHS_IN_MILLIS = 30 * DAYS_IN_MILLIS;
const YEARS_IN_MILLIS = 365 * DAYS_IN_MILLIS;
function humanizeDuration(from?: number) {
if (!from) {
return '';
}
const diff = Date.now() - from;
if (diff < HOURS_IN_MILLIS) {
return formatter.format(- Math.floor(diff / MINUTES_IN_MILLIS), 'minute');
} else if (diff < DAYS_IN_MILLIS) {
return formatter.format(- Math.floor(diff / HOURS_IN_MILLIS), 'hour');
} else if (diff < MONTHS_IN_MILLIS) {
return formatter.format(- Math.floor(diff / DAYS_IN_MILLIS), 'day');
} else if (diff < YEARS_IN_MILLIS) {
return formatter.format(- Math.floor(diff / MONTHS_IN_MILLIS), 'month');
} else {
return formatter.format(- Math.floor(diff / YEARS_IN_MILLIS), 'year');
}
}

62
extensions/ql-vscode/src/remote-queries/view/LastUpdated.tsx Normal file
View File

@@ -0,0 +1,62 @@
import * as React from 'react';
import { CalendarIcon } from '@primer/octicons-react';
import styled from 'styled-components';
const Calendar = styled.span`
flex-grow: 0;
text-align: right;
margin-right: 0;
`;
const Duration = styled.span`
text-align: left;
width: 8em;
margin-left: 0.5em;
`;
type Props = { lastUpdated?: number };
const LastUpdated = ({ lastUpdated }: Props) => (
Number.isFinite(lastUpdated) ? (
<>
<Calendar>
<CalendarIcon size={16} />
</Calendar>
<Duration>
{humanizeDuration(lastUpdated)}
</Duration>
</>
) : (
<></>
)
);
export default LastUpdated;
const formatter = new Intl.RelativeTimeFormat('en', {
numeric: 'auto'
});
// All these are approximate, specifically months and years
const MINUTE_IN_MILLIS = 1000 * 60;
const HOUR_IN_MILLIS = 60 * MINUTE_IN_MILLIS;
const DAY_IN_MILLIS = 24 * HOUR_IN_MILLIS;
const MONTH_IN_MILLIS = 30 * DAY_IN_MILLIS;
const YEAR_IN_MILLIS = 365 * DAY_IN_MILLIS;
function humanizeDuration(diff?: number) {
if (!diff) {
return '';
}
if (diff < HOUR_IN_MILLIS) {
return formatter.format(- Math.floor(diff / MINUTE_IN_MILLIS), 'minute');
} else if (diff < DAY_IN_MILLIS) {
return formatter.format(- Math.floor(diff / HOUR_IN_MILLIS), 'hour');
} else if (diff < MONTH_IN_MILLIS) {
return formatter.format(- Math.floor(diff / DAY_IN_MILLIS), 'day');
} else if (diff < YEAR_IN_MILLIS) {
return formatter.format(- Math.floor(diff / MONTH_IN_MILLIS), 'month');
} else {
return formatter.format(- Math.floor(diff / YEAR_IN_MILLIS), 'year');
}
}

2
extensions/ql-vscode/src/remote-queries/view/RemoteQueries.tsx
View File

@@ -23,7 +23,7 @@ import RepositoriesSearch from './RepositoriesSearch';
import ActionButton from './ActionButton';
import StarCount from './StarCount';
import SortRepoFilter, { Sort, sorter } from './SortRepoFilter';
import LastUpdated from './LasstUpdated';
import LastUpdated from './LastUpdated';
const numOfReposInContractedMode = 10;