Merge pull request #2664 from github/robertbrignull/ResultTables-naming

Make sure ResultTable and ResultTables are in correctly named files
This commit is contained in:
Robert
2023-08-03 15:48:57 +01:00
committed by GitHub
3 changed files with 35 additions and 33 deletions

View File

@@ -0,0 +1,33 @@
import * as React from "react";
import { AlertTable } from "./alert-table";
import { Graph } from "./graph";
import { RawTable } from "./raw-results-table";
import { ResultTableProps } from "./result-table-utils";
export function ResultTable(props: ResultTableProps) {
const { resultSet } = props;
switch (resultSet.t) {
case "RawResultSet":
return <RawTable {...props} resultSet={resultSet} />;
case "InterpretedResultSet": {
const data = resultSet.interpretation.data;
switch (data.t) {
case "SarifInterpretationData": {
const sarifResultSet = {
...resultSet,
interpretation: { ...resultSet.interpretation, data },
};
return <AlertTable {...props} resultSet={sarifResultSet} />;
}
case "GraphInterpretationData": {
return (
<Graph
graphData={data?.dot[props.offset]}
databaseUri={props.databaseUri}
/>
);
}
}
}
}
}

View File

@@ -14,11 +14,7 @@ import {
ParsedResultSets,
IntoResultsViewMsg,
} from "../../common/interface-types";
import { AlertTable } from "./alert-table";
import { Graph } from "./graph";
import { RawTable } from "./raw-results-table";
import {
ResultTableProps,
tableHeaderClassName,
tableHeaderItemClassName,
toggleDiagnosticsClassName,
@@ -28,6 +24,7 @@ import {
import { vscode } from "../vscode-api";
import { sendTelemetry } from "../common/telemetry";
import { basename } from "../../common/path";
import { ResultTable } from "./ResultTable";
/**
* Properties for the `ResultTables` component.
@@ -433,34 +430,6 @@ export class ResultTables extends React.Component<
}
}
function ResultTable(props: ResultTableProps) {
const { resultSet } = props;
switch (resultSet.t) {
case "RawResultSet":
return <RawTable {...props} resultSet={resultSet} />;
case "InterpretedResultSet": {
const data = resultSet.interpretation.data;
switch (data.t) {
case "SarifInterpretationData": {
const sarifResultSet = {
...resultSet,
interpretation: { ...resultSet.interpretation, data },
};
return <AlertTable {...props} resultSet={sarifResultSet} />;
}
case "GraphInterpretationData": {
return (
<Graph
graphData={data?.dot[props.offset]}
databaseUri={props.databaseUri}
/>
);
}
}
}
}
}
function getDefaultResultSet(resultSets: readonly ResultSet[]): string {
return getDefaultResultSetName(
resultSets.map((resultSet) => resultSet.schema.name),

View File

@@ -15,7 +15,7 @@ import {
ResultSet,
} from "../../common/interface-types";
import { EventHandlers as EventHandlerList } from "./event-handler-list";
import { ResultTables } from "./result-tables";
import { ResultTables } from "./ResultTables";
import "./resultsView.css";
import { useCallback, useEffect } from "react";