Merge pull request #3138 from github/koesie10/remove-github-databases-enable-ff

Remove GitHub database download feature flag

extensions/ql-vscode/CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## [UNRELEASED]
 
+- Add a prompt for downloading a GitHub database when opening a GitHub repository. [#3138](https://github.com/github/vscode-codeql/pull/3138)
 - Avoid showing a popup when hovering over source elements in database source files. [#3125](https://github.com/github/vscode-codeql/pull/3125)
 
 ## 1.11.0 - 13 December 2023

extensions/ql-vscode/src/config.ts

@@ -762,8 +762,6 @@ export class ModelConfigListener extends ConfigListener implements ModelConfig {
 
 const GITHUB_DATABASE_SETTING = new Setting("githubDatabase", ROOT_SETTING);
 
-// Feature flag for the GitHub database downnload.
-const GITHUB_DATABASE_ENABLE = new Setting("enable", GITHUB_DATABASE_SETTING);
 const GITHUB_DATABASE_DOWNLOAD = new Setting(
   "download",
   GITHUB_DATABASE_SETTING,
@@ -778,7 +776,6 @@ const GitHubDatabaseUpdateValues = ["ask", "never"] as const;
 type GitHubDatabaseUpdate = (typeof GitHubDatabaseUpdateValues)[number];
 
 export interface GitHubDatabaseConfig {
-  enable: boolean;
   download: GitHubDatabaseDownload;
   update: GitHubDatabaseUpdate;
   setDownload(
@@ -802,10 +799,6 @@ export class GitHubDatabaseConfigListener
     );
   }
 
-  public get enable() {
-    return !!GITHUB_DATABASE_ENABLE.getValue<boolean>();
-  }
-
   public get download(): GitHubDatabaseDownload {
     const value = GITHUB_DATABASE_DOWNLOAD.getValue<GitHubDatabaseDownload>();
     return GitHubDatabaseDownloadValues.includes(value) ? value : "ask";

extensions/ql-vscode/src/databases/github-databases/github-databases-module.ts

@@ -60,10 +60,6 @@ export class GitHubDatabasesModule extends DisposableObject {
   }
 
   private async initialize(): Promise<void> {
-    if (!this.config.enable) {
-      return;
-    }
-
     // Start the check and downloading the database asynchronously. We don't want to block on this
     // in extension activation since this makes network requests and waits for user input.
     void this.promptGitHubRepositoryDownload().catch((e: unknown) => {