mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Return early if method cannot be modeled

Browse Source
This commit is contained in:
Robert
2023-07-12 14:04:58 +01:00
parent 8529c05396
commit 5fa338e460
1 changed files with 31 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
extensions/ql-vscode/src/view/data-extensions-editor/MethodRow.tsx
View File

@@ -174,6 +174,36 @@ export const MethodRow = ({
const methodCanBeModeled =
!externalApiUsage.supported ||
(modeledMethod && modeledMethod?.type !== "none");
const externalApiUsageName = (
<span>
{externalApiUsage.packageName}.{externalApiUsage.typeName}.
{externalApiUsage.methodName}
{externalApiUsage.methodParameters}
</span>
);
if (!methodCanBeModeled) {
return (
<VSCodeDataGridRow>
<ApiOrMethodCell gridColumn={1}>
<VSCodeCheckbox />
{externalApiUsageName}
{mode === Mode.Application && (
<UsagesButton onClick={jumpToUsage}>
{externalApiUsage.usages.length}
</UsagesButton>
)}
<ViewLink onClick={jumpToUsage}>View</ViewLink>
</ApiOrMethodCell>
<VSCodeDataGridCell gridColumn={2} />
<VSCodeDataGridCell gridColumn={3} />
<VSCodeDataGridCell gridColumn={4} />
<VSCodeDataGridCell gridColumn={5} />
</VSCodeDataGridRow>
);
}
const showInputCell =
modeledMethod?.type && ["sink", "summary"].includes(modeledMethod?.type);
const showOutputCell =
@@ -188,11 +218,7 @@ export const MethodRow = ({
<VSCodeDataGridRow>
<ApiOrMethodCell gridColumn={1}>
<VSCodeCheckbox />
<span>
{externalApiUsage.packageName}.{externalApiUsage.typeName}.
{externalApiUsage.methodName}
{externalApiUsage.methodParameters}
</span>
{externalApiUsageName}
{mode === Mode.Application && (
<UsagesButton onClick={jumpToUsage}>
{externalApiUsage.usages.length}
@@ -204,7 +230,6 @@ export const MethodRow = ({
<Dropdown
value={modeledMethod?.type ?? "none"}
options={modelTypeOptions}
disabled={!methodCanBeModeled}
onChange={handleTypeInput}
/>
</VSCodeDataGridCell>