Rename 'dependency' to 'package' in auto-modeling code (#2686)

This commit is contained in:
Charis Kyriakou
2023-08-10 10:06:33 +01:00
committed by GitHub
parent b1dc862392
commit 5d2e20516b
5 changed files with 24 additions and 24 deletions

View File

@@ -549,14 +549,14 @@ interface GenerateExternalApiMessage {
interface GenerateExternalApiFromLlmMessage {
t: "generateExternalApiFromLlm";
dependencyName: string;
packageName: string;
externalApiUsages: ExternalApiUsage[];
modeledMethods: Record<string, ModeledMethod>;
}
interface StopGeneratingExternalApiFromLlmMessage {
t: "stopGeneratingExternalApiFromLlm";
dependencyName: string;
packageName: string;
}
interface ModelDependencyMessage {

View File

@@ -42,34 +42,34 @@ export class AutoModeler {
}
public async startModeling(
dependency: string,
packageName: string,
externalApiUsages: ExternalApiUsage[],
modeledMethods: Record<string, ModeledMethod>,
mode: Mode,
): Promise<void> {
if (this.jobs.has(dependency)) {
if (this.jobs.has(packageName)) {
return;
}
const cancellationTokenSource = new CancellationTokenSource();
this.jobs.set(dependency, cancellationTokenSource);
this.jobs.set(packageName, cancellationTokenSource);
try {
await this.modelDependency(
dependency,
await this.modelPackage(
packageName,
externalApiUsages,
modeledMethods,
mode,
cancellationTokenSource,
);
} finally {
this.jobs.delete(dependency);
this.jobs.delete(packageName);
}
}
public async stopModeling(dependency: string): Promise<void> {
void extLogger.log(`Stopping modeling for dependency ${dependency}`);
const cancellationTokenSource = this.jobs.get(dependency);
public async stopModeling(packageName: string): Promise<void> {
void extLogger.log(`Stopping modeling for package ${packageName}`);
const cancellationTokenSource = this.jobs.get(packageName);
if (cancellationTokenSource) {
cancellationTokenSource.cancel();
}
@@ -81,14 +81,14 @@ export class AutoModeler {
}
}
private async modelDependency(
dependency: string,
private async modelPackage(
packageName: string,
externalApiUsages: ExternalApiUsage[],
modeledMethods: Record<string, ModeledMethod>,
mode: Mode,
cancellationTokenSource: CancellationTokenSource,
): Promise<void> {
void extLogger.log(`Modeling dependency ${dependency}`);
void extLogger.log(`Modeling package ${packageName}`);
await withProgress(async (progress) => {
const maxStep = 3000;

View File

@@ -177,7 +177,7 @@ export class DataExtensionsEditorView extends AbstractWebview<
case "generateExternalApiFromLlm":
if (useLlmGenerationV2()) {
await this.generateModeledMethodsFromLlmV2(
msg.dependencyName,
msg.packageName,
msg.externalApiUsages,
msg.modeledMethods,
);
@@ -189,7 +189,7 @@ export class DataExtensionsEditorView extends AbstractWebview<
}
break;
case "stopGeneratingExternalApiFromLlm":
await this.autoModeler.stopModeling(msg.dependencyName);
await this.autoModeler.stopModeling(msg.packageName);
break;
case "modelDependency":
await this.modelDependency();
@@ -459,12 +459,12 @@ export class DataExtensionsEditorView extends AbstractWebview<
}
private async generateModeledMethodsFromLlmV2(
dependency: string,
packageName: string,
externalApiUsages: ExternalApiUsage[],
modeledMethods: Record<string, ModeledMethod>,
): Promise<void> {
await this.autoModeler.startModeling(
dependency,
packageName,
externalApiUsages,
modeledMethods,
this.mode,

View File

@@ -227,13 +227,13 @@ export function DataExtensionsEditor({
const onGenerateFromLlmClick = useCallback(
(
dependencyName: string,
packageName: string,
externalApiUsages: ExternalApiUsage[],
modeledMethods: Record<string, ModeledMethod>,
) => {
vscode.postMessage({
t: "generateExternalApiFromLlm",
dependencyName,
packageName,
externalApiUsages,
modeledMethods,
});
@@ -241,10 +241,10 @@ export function DataExtensionsEditor({
[],
);
const onStopGenerateFromLlmClick = useCallback((dependencyName: string) => {
const onStopGenerateFromLlmClick = useCallback((packageName: string) => {
vscode.postMessage({
t: "stopGeneratingExternalApiFromLlm",
dependencyName,
packageName,
});
}, []);

View File

@@ -27,11 +27,11 @@ type Props = {
modeledMethods: Record<string, ModeledMethod>,
) => void;
onGenerateFromLlmClick: (
dependencyName: string,
packageName: string,
externalApiUsages: ExternalApiUsage[],
modeledMethods: Record<string, ModeledMethod>,
) => void;
onStopGenerateFromLlmClick: (dependencyName: string) => void;
onStopGenerateFromLlmClick: (packageName: string) => void;
onGenerateFromSourceClick: () => void;
onModelDependencyClick: () => void;
};