Merge pull request #2842 from github/robertbrignull/revert-node18

Switch back to Node.js version 16

.github/workflows/cli-test.yml

@@ -62,7 +62,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: '18.15.0'
+          node-version: '16.17.1'
           cache: 'npm'
           cache-dependency-path: extensions/ql-vscode/package-lock.json
 

.github/workflows/main.yml

@@ -22,7 +22,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: '18.15.0'
+          node-version: '16.17.1'
           cache: 'npm'
           cache-dependency-path: extensions/ql-vscode/package-lock.json
 
@@ -64,7 +64,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: '18.15.0'
+          node-version: '16.17.1'
           cache: 'npm'
           cache-dependency-path: extensions/ql-vscode/package-lock.json
 
@@ -113,7 +113,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: '18.15.0'
+          node-version: '16.17.1'
           cache: 'npm'
           cache-dependency-path: extensions/ql-vscode/package-lock.json
 
@@ -147,7 +147,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: '18.15.0'
+          node-version: '16.17.1'
           cache: 'npm'
           cache-dependency-path: extensions/ql-vscode/package-lock.json
 
@@ -215,7 +215,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: '18.15.0'
+          node-version: '16.17.1'
           cache: 'npm'
           cache-dependency-path: extensions/ql-vscode/package-lock.json
 

.github/workflows/release.yml

@@ -22,7 +22,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: '18.15.0'
+          node-version: '16.17.1'
 
       - name: Install dependencies
         run: |

extensions/ql-vscode/.nvmrc

@@ -1 +1 @@
-v18.15.0
+v16.17.1

extensions/ql-vscode/package-lock.json

@@ -147,7 +147,7 @@
         "webpack-cli": "^5.0.1"
       },
       "engines": {
-        "node": "^18.15.0",
+        "node": "^16.17.1",
         "npm": ">=7.20.6",
         "vscode": "^1.67.0"
       }

extensions/ql-vscode/package.json

@@ -14,7 +14,7 @@
   },
   "engines": {
     "vscode": "^1.67.0",
-    "node": "^18.15.0",
+    "node": "^16.17.1",
     "npm": ">=7.20.6"
   },
   "categories": [

extensions/ql-vscode/test/unit-tests/variant-analysis/gh-api/gh-api-client.test.ts

@@ -21,7 +21,7 @@ const controllerRepoId = variantAnalysisJson_response.body.controller_repo.id;
 const variantAnalysisId = variantAnalysisJson_response.body.id;
 const repoTaskId = variantAnalysisRepoJson_response.body.repository.id;
 
-describe.skip("submitVariantAnalysis", () => {
+describe("submitVariantAnalysis", () => {
   it("returns the submitted variant analysis", async () => {
     await mockServer.loadScenario("mrva-problem-query-success");
 
@@ -35,7 +35,7 @@ describe.skip("submitVariantAnalysis", () => {
   });
 });
 
-describe.skip("getVariantAnalysis", () => {
+describe("getVariantAnalysis", () => {
   it("returns the variant analysis", async () => {
     await mockServer.loadScenario("mrva-problem-query-success");
 
@@ -50,7 +50,7 @@ describe.skip("getVariantAnalysis", () => {
   });
 });
 
-describe.skip("getVariantAnalysisRepo", () => {
+describe("getVariantAnalysisRepo", () => {
   it("returns the variant analysis repo task", async () => {
     await mockServer.loadScenario("mrva-problem-query-success");
 
@@ -66,7 +66,7 @@ describe.skip("getVariantAnalysisRepo", () => {
   });
 });
 
-describe.skip("getRepositoryFromNwo", () => {
+describe("getRepositoryFromNwo", () => {
   it("returns the repository", async () => {
     await mockServer.loadScenario("mrva-problem-query-success");