mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Improve humanizeRelativeTime tests

Browse Source 
The tests were expecting the wrong results, except for the case where
the time was less than a second. For less than a second ago, it makes
sense to return "this minute". For times that are 2.001 minutes ago, it
makes sense to return "2 minutes ago" rather then the previous behaviour
of "3 minutes ago".
This commit is contained in:
Koen Vlaswinkel
2022-11-02 13:43:14 +01:00
parent 06fd3a58a7
commit cb1233d018
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
extensions/ql-vscode/test/pure-tests/time.test.ts
View File

@@ -54,12 +54,14 @@ describe('Time', () => {
});
it('should return a humanized duration negative', () => {
expect(humanizeRelativeTime(-1)).to.eq('1 minute ago');
expect(humanizeRelativeTime(-1)).to.eq('this minute');
expect(humanizeRelativeTime(-1000 * 60)).to.eq('1 minute ago');
expect(humanizeRelativeTime(-1000 * 60 - 1)).to.eq('2 minutes ago');
expect(humanizeRelativeTime(-1000 * 60 - 1)).to.eq('1 minute ago');
expect(humanizeRelativeTime(-1000 * 60 * 2)).to.eq('2 minutes ago');
expect(humanizeRelativeTime(-1000 * 60 * 2 - 1)).to.eq('3 minutes ago');
expect(humanizeRelativeTime(-1000 * 60 * 2 - 1)).to.eq('2 minutes ago');
expect(humanizeRelativeTime(-1000 * 60 * 3)).to.eq('3 minutes ago');
expect(humanizeRelativeTime(-1000 * 60 * 60)).to.eq('1 hour ago');
expect(humanizeRelativeTime(-1000 * 60 * 60 - 1)).to.eq('1 hour ago');
expect(humanizeRelativeTime(-1000 * 60 * 60 * 2)).to.eq('2 hours ago');
expect(humanizeRelativeTime(-1000 * 60 * 60 * 24)).to.eq('yesterday');
expect(humanizeRelativeTime(-1000 * 60 * 60 * 24 * 2)).to.eq('2 days ago');