Sam Partington
44377d2ae3
Make java/string-concatenation-in-loop high precision
2024-06-26 15:18:47 +01:00
Owen Mansel-Chan
272132a09a
Merge pull request #16799 from owen-mc/go/mad/match-all-package-versions
...
Go: Make models-as-data package column match any version without "$ANYVERSION"
2024-06-26 13:46:49 +01:00
Anders Schack-Mulligen
9d8ee99c1c
Merge pull request #16806 from aschackmull/dataflow/debug-stages
...
Dataflow: Add path-problem view of intermediate stages for debug purposes.
2024-06-26 12:53:12 +02:00
Michael Nebel
e1f65d1f8b
Merge pull request #16836 from michaelnebel/csharp/bestlocation
...
C#: Be more consistent when picking between locations.
2024-06-26 12:46:50 +02:00
Cornelius Riemenschneider
c4cc30fb7a
Merge pull request #16839 from github/criemen/bazel-721
...
Bump to bazel 7.2.1.
2024-06-26 11:26:19 +02:00
Paolo Tranquilli
53a7d823ec
Merge pull request #16841 from github/redsun82/kotlin
...
Kotlin: exclude `KotlinExtractorDbScheme.kt` generated by hand
2024-06-26 11:18:44 +02:00
Tamás Vajk
81f4786643
Merge pull request #16832 from tamasvajk/feature/update-dependencies
...
C#: Update (some) nuget dependencies
2024-06-26 11:12:26 +02:00
Michael Nebel
e258d9fa74
C#: Use the first best location from the list of locations.
2024-06-26 11:04:38 +02:00
Paolo Tranquilli
a52a412c24
Kotlin: exclude KotlinExtractorDbScheme.kt generated by hand
2024-06-26 09:05:09 +02:00
Owen Mansel-Chan
a30b34c4bd
Used "fixed-version:" prefix in a test
2024-06-26 05:01:09 +01:00
Owen Mansel-Chan
418a56d385
Replace "$THISVERSION" suffix with "fixed-version:" prefix
2024-06-26 05:01:09 +01:00
Owen Mansel-Chan
081f32141c
Accept review suggestion fixing a comment
...
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com >
2024-06-26 05:01:09 +01:00
Owen Mansel-Chan
d4e8e4c943
Add QLDoc for majorVersionSuffixRegex
2024-06-26 05:01:09 +01:00
Owen Mansel-Chan
46d0c6ff9c
Use lookahead in regex to not match e.g. "/v2foo"
2024-06-26 05:01:09 +01:00
Owen Mansel-Chan
c8a3bedf44
Move major version suffix regex into one place
2024-06-26 05:01:09 +01:00
Owen Mansel-Chan
cb2ccef5fa
Refactor suffix check
2024-06-26 05:01:09 +01:00
Owen Mansel-Chan
c045e77d61
Fix QLDoc for interpretPackage
2024-06-26 05:01:09 +01:00
Owen Mansel-Chan
7d11fc2c7d
Fix bug in regex
...
I accidentally included a `$` at the end, so it only matched a major
version suffix at the end of the package path.
2024-06-26 05:01:09 +01:00
Owen Mansel-Chan
a9afbfa993
Document version matching and "$THISVERSION"
2024-06-26 05:01:09 +01:00
Owen Mansel-Chan
3e2bbd38d4
Remove "$ANYVERSION" from models
2024-06-26 05:01:09 +01:00
Owen Mansel-Chan
47d946fb1c
Make MaD package match any version without $ANYVERSION
...
Note that if the package column contains major version suffix (like
"/v2") or if it ends with "$THISVERSION" (which is removed) then we
don't do any version matching.
2024-06-26 05:01:09 +01:00
Owen Mansel-Chan
ea0db4d55e
Add predicate for package path without "/v2" etc
2024-06-26 05:01:09 +01:00
Ian Lynagh
f9ae44ca5c
Merge pull request #16736 from igfoo/igfoo/debugLoC
...
Java/Kotlin: Tag the LoC queries 'debug'
2024-06-25 22:57:36 +01:00
Cornelius Riemenschneider
37da3e1bb3
Bump to bazel 7.2.1.
2024-06-25 21:21:39 +02:00
Chris Smowton
2413332553
Merge pull request #16802 from github/smowton/admin/note-java-system-requirements
...
Java: document extraction system requirements
2024-06-25 15:53:09 +01:00
Ian Lynagh
c12adbeeaa
Java/Kotlin: Tag the LoC queries 'debug'
...
This brings them into line with LinesOfCode.ql
2024-06-25 15:46:10 +01:00
Michael Nebel
d18915a1e4
C#: Update expected test output.
2024-06-25 16:02:58 +02:00
Michael Nebel
e15a47d58c
C#: Update the extractor to use the BestOrDefault extension method to choose between multiple locations.
2024-06-25 16:02:54 +02:00
Michael Nebel
dd65d960be
C#: Introduce a Location extension method to help pick a unique location.
2024-06-25 16:02:49 +02:00
Michael Nebel
8dc95ce9b0
Merge pull request #16722 from michaelnebel/csharp/modelgensourcesink
...
C#/Java: Respect manual neutrals, sources and sinks in model generation.
2024-06-25 15:55:06 +02:00
yoff
58b6b3f601
Merge pull request #16789 from yoff/python/document-models-as-data
...
python: Document MaD format
2024-06-25 15:46:28 +02:00
Tamas Vajk
5058727980
C#: Update (some) nuget dependencies
2024-06-25 15:24:08 +02:00
Anders Schack-Mulligen
1cc49af454
Dataflow: Address review comments.
2024-06-25 15:19:55 +02:00
Asger F
6a3bb4dd28
Merge pull request #16834 from asgerf/shared/capture-this-location
...
Shared: add location for 'this' CaptureContainer
2024-06-25 13:18:41 +02:00
Mathias Vorreiter Pedersen
17edfdf801
Merge pull request #16833 from MathiasVP/simplify-incorrect-allocation-error-handling
...
C++: Simplify `cpp/incorrect-allocation-error-handling`
2024-06-25 12:16:21 +01:00
Rasmus Lerchedahl Petersen
6524b8e25d
Python: consistent double quotes in examples
2024-06-25 12:11:52 +02:00
Rasmus Lerchedahl Petersen
09905ee228
Python: double back-tics
2024-06-25 12:05:38 +02:00
Rasmus Lerchedahl Petersen
6d4e993dea
Python: remove named parameter filename
2024-06-25 12:00:53 +02:00
Rasmus Lerchedahl Petersen
aa4fd1992e
Python: compact types in type models
2024-06-25 11:59:55 +02:00
Rasmus Lerchedahl Petersen
b902dd5680
Python: add change note
2024-06-25 11:54:30 +02:00
Jeroen Ketema
e0e5bdec8a
Merge pull request #16818 from jketema/predef
...
C++: Update expected test results
2024-06-25 11:06:53 +02:00
Mathias Vorreiter Pedersen
921afb71e2
Update cpp/ql/src/Security/CWE/CWE-570/IncorrectAllocationErrorHandling.ql
...
Co-authored-by: Jeroen Ketema <93738568+jketema@users.noreply.github.com >
2024-06-25 10:03:53 +01:00
Owen Mansel-Chan
890da5377e
Merge pull request #16819 from owen-mc/go/remove-dataflowtype-optimizer-bug-workaround
...
Go: Make DataFlowType a singleton (remove workaround)
2024-06-25 10:03:08 +01:00
Asger F
551743e000
Shared: add location for 'this' CaptureContainer
...
Only has an effect for debugging purposes
2024-06-25 10:34:28 +02:00
Mathias Vorreiter Pedersen
982f845be7
C++: Accept test changes.
2024-06-25 09:31:00 +01:00
Mathias Vorreiter Pedersen
bb8b0d0bf5
C++: Use the unary version of 'comparesEq' to handle both disjuncts.
2024-06-25 09:30:53 +01:00
Jeroen Ketema
285ed3630b
C++: Update expected test results
2024-06-25 09:16:05 +02:00
Dave Bartolomeo
1e46e431e8
Merge pull request #16823 from smowton/smowton/admin/maven-transfer-failure-test-expectations
...
Java: Adjust and tolerate variability in test expectations
2024-06-24 13:54:25 -04:00
Paolo Tranquilli
d2a00fa773
Merge pull request #16822 from github/redsun82/nodejs-mirror
...
Bazel: add `nodejs` mirror
2024-06-24 17:59:08 +02:00
Chris Smowton
351b908f62
Adjust and tolerate variability in test expectations
2024-06-24 16:38:18 +01:00
Paolo Tranquilli
0669186713
Bazel: remove unneeded upstream rules_nodejs patch
2024-06-24 17:09:40 +02:00
Paolo Tranquilli
a02cf07833
Bazel: add nodejs mirror
...
This patches `rules_nodejs` with the contents of
https://github.com/bazelbuild/rules_nodejs/pull/3763
in order to allow specifying a mirror for nodejs, as nodejs.org has
hit us with intermittent downtimes.
2024-06-24 16:59:25 +02:00
Mathias Vorreiter Pedersen
5b1b60cc92
Merge pull request #16797 from MathiasVP/yml-for-allocation-and-deallocation
...
C++: Add extensible predicates to `Allocation` and `Deallocation`
2024-06-24 15:34:27 +01:00
Anders Schack-Mulligen
25d520a7f1
Merge pull request #16785 from aschackmull/dataflow/stage3-notypes
...
Dataflow: Replace stage 3 type pruning with flow-insensitive type pruning.
2024-06-24 15:21:37 +02:00
Mathias Vorreiter Pedersen
36d59cef7e
C++: Add 'bsl::free' as a deallocation function model.
2024-06-24 13:56:44 +01:00
Mathias Vorreiter Pedersen
82ed1ee671
Update cpp/ql/lib/change-notes/2024-06-20-extensible-allocation-deallocation.md
...
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com >
2024-06-24 13:50:24 +01:00
Owen Mansel-Chan
d8df38c683
Make DataFlowType a singleton (remove workaround)
2024-06-24 13:43:10 +01:00
Mathias Vorreiter Pedersen
19b6d24bc2
Merge pull request #16816 from MathiasVP/fix-valuenumber-imports
...
C++: Fix value numbering imports
2024-06-24 13:37:38 +01:00
Anders Schack-Mulligen
fdf6e30888
Dataflow: Handle non-trivial type systems with stores into a top type.
2024-06-24 13:35:50 +02:00
Anders Schack-Mulligen
a26132e818
Dataflow: Replace stage 3 type pruning with flow-insensitive type pruning.
2024-06-24 13:35:50 +02:00
Anders Schack-Mulligen
3ede3af6f2
C#: Fix join-order.
2024-06-24 13:35:49 +02:00
Anders Schack-Mulligen
8c23e21073
Dataflow: Cache compatibleTypes.
2024-06-24 13:35:48 +02:00
Anders Schack-Mulligen
06a7e3f3ee
Dataflow: Cache typeStrongerThan.
2024-06-24 13:35:48 +02:00
Anders Schack-Mulligen
bd99f32a4b
Dataflow: Check types on ParamReturnNode.
2024-06-24 13:35:47 +02:00
Michael Nebel
24685a07c0
Java: Update model generator test expected output.
2024-06-24 13:07:42 +02:00
Michael Nebel
c687dcb094
Java: Sync files and make language specific implementation.
2024-06-24 13:07:39 +02:00
Michael Nebel
30249e4f2b
Java: Add some spurious source and sink examples.
2024-06-24 13:07:34 +02:00
Michael Nebel
854674a71c
C#: Update expected test output.
2024-06-24 13:07:30 +02:00
Michael Nebel
b27a9d948a
C#: Exclude APIs with a manual source neutral from source model generation and allow source generation for all source kinds.
2024-06-24 13:07:14 +02:00
Michael Nebel
2657e7f56d
C#: Add some source and sink modelling examples where a neutral exist.
2024-06-24 13:05:35 +02:00
Mathias Vorreiter Pedersen
00d772f980
C++: Fix value numbering imports.
2024-06-24 11:53:24 +01:00
Michael Nebel
abc7cc39d4
Merge pull request #16775 from michaelnebel/modelgen/refactorprinting
...
C#/Java: Parameterized module for model printing.
2024-06-24 12:51:07 +02:00
Michael Nebel
9cd16fd9d6
Java: Base the model printing on the shared implementation.
2024-06-24 11:52:50 +02:00
Michael Nebel
8630583856
C#/Java: Exclude the model printing implementation form sync files.
2024-06-24 11:50:57 +02:00
Michael Nebel
b7bc540325
C#: Adjust implementation to use the shared model printer.
2024-06-24 11:50:46 +02:00
Michael Nebel
65e150b416
Add parameterized module for MaD model printing.
2024-06-24 11:48:33 +02:00
Owen Mansel-Chan
f04a85e121
Merge pull request #16753 from owen-mc/go/misc-clean-up
...
Go: a few small clean ups
2024-06-24 10:47:21 +01:00
Michael Nebel
94d12edfdb
Merge pull request #16759 from michaelnebel/modelgen/sourcesinkmodelgen
...
C#/Java: Introduce source and sink model generation sanitisers.
2024-06-24 11:47:11 +02:00
Rasmus Lerchedahl Petersen
4626e134fa
Python: update doc to use operations module
2024-06-24 10:56:34 +02:00
Rasmus Lerchedahl Petersen
00fbada41d
Python: recognize fabric.operations
2024-06-24 10:54:59 +02:00
Rasmus Lerchedahl Petersen
21a0f8af07
Python: address reviewer comments
...
- fix wording on `builtins`
- add named argument/parameter access path components
2024-06-24 10:48:53 +02:00
yoff
d603b48884
Apply suggestions from code review
...
Co-authored-by: Taus <tausbn@github.com >
2024-06-24 10:29:33 +02:00
Mathias Vorreiter Pedersen
a1743aa12e
Merge pull request #16805 from MathiasVP/tc-in-temp-materialization
...
C++: Fix missing `asExpr` for temporary materializations with conversions
2024-06-23 13:38:01 +01:00
Owen Mansel-Chan
513ec16691
Merge pull request #16796 from owen-mc/go/fix/package-vendor
...
Go: Fix bug removing "vendor/" from package paths
2024-06-22 07:54:18 +01:00
Mathias Vorreiter Pedersen
1bb762bea9
C++: Accept test changes.
2024-06-21 13:35:10 +01:00
Mathias Vorreiter Pedersen
7d41e8ef73
C++: Perform a TC to skip conversions when special-casing materialization of temporaries.
2024-06-21 13:35:09 +01:00
Mathias Vorreiter Pedersen
3b585b4196
C++: Add test with missing flow.
2024-06-21 13:35:08 +01:00
Taus
4a448f445e
Merge pull request #15715 from am0o0/am0o0-python-codeExec
...
Python: New command execution sinks
2024-06-21 14:26:33 +02:00
Anders Schack-Mulligen
accc73d1d0
Dataflow: Add debug graph for pruning stages.
2024-06-21 14:25:32 +02:00
Erik Krogh Kristensen
49f74bacf2
Merge pull request #16729 from mbaluda/main
...
JS: Extract SAP XSJS file types as Javascript
2024-06-21 14:23:55 +02:00
Anders Schack-Mulligen
bbdae5188d
Dataflow: Add ArgNodeEx column to fwdFlowIsEntered.
2024-06-21 14:10:37 +02:00
Anders Schack-Mulligen
fa13861e53
Dataflow: Add Debug module with stage references.
2024-06-21 14:02:07 +02:00
Mauro Baluda
b75514c990
Merge branch 'github:main' into main
2024-06-21 13:36:38 +02:00
Chris Smowton
cfb48ace73
Java: document extraction system requirements
...
Note that a `java` binary is at least highly recommended for Java extraction, and in many circumstances a hard requirement. The same goes for `mvn` and `gradle`.
2024-06-21 11:53:36 +01:00
Kasper Svendsen
988d0671bb
Merge pull request #16734 from kaspersv/kaspersv/doc-intern-sets-builtin
...
Document builtin InternSets module
2024-06-21 12:06:40 +02:00
Tom Hvitved
dff3ce2a9f
Merge pull request #16794 from hvitved/ruby/sinatra-flow
...
Ruby: Rework `Sinatra.FilterJumpStep`
2024-06-21 11:38:10 +02:00
Mathias Vorreiter Pedersen
c357cc9f08
C++: Add change note.
2024-06-21 08:54:12 +01:00
Mathias Vorreiter Pedersen
69490c62cd
C++: Add qlpack dependency.
2024-06-21 08:54:10 +01:00
Mathias Vorreiter Pedersen
6bf22bda58
C++: Replace allocation models with models from extensible predicates.
2024-06-21 08:54:09 +01:00
Tom Hvitved
8ea4f85de3
Ruby: Rework Sinatra.FilterJumpStep
2024-06-21 08:57:59 +02:00
Tom Hvitved
95c764eff6
Fix Sinatra test to properly output pathgraph
2024-06-21 08:57:19 +02:00
Erik Krogh Kristensen
db768960f4
Merge pull request #15060 from am0o0/amammad-js-envinjection
...
JS: Env Injection query
2024-06-20 21:27:21 +02:00
Erik Krogh Kristensen
555d7e5958
Merge pull request #14293 from am0o0/amammad-js-CodeInjection_dynamic_import
...
JS: Dynamic import as code injection sink
2024-06-20 21:19:57 +02:00
Erik Krogh Kristensen
60ed51781e
Merge pull request #16790 from github/max-schaefer-patch-1
...
JavaScript: Fix CodeQL alert in extractor
2024-06-20 20:20:00 +02:00
Erik Krogh Kristensen
e84028d01e
Merge pull request #14088 from am0o0/amammad-js-JWT
...
JS: decoding JWT without signature verification
2024-06-20 20:13:40 +02:00
Mathias Vorreiter Pedersen
d308178781
C++: Add extensible predicate for allocation.
2024-06-20 16:26:52 +01:00
Mathias Vorreiter Pedersen
ce5ab4c4b7
C++: Add qlpack dependency.
2024-06-20 16:26:50 +01:00
Mathias Vorreiter Pedersen
3457551264
C++: Replace deallocation models with models from extensible predicates.
2024-06-20 16:26:49 +01:00
Jeroen Ketema
0e04a59c08
Merge pull request #16795 from jketema/test-cleanup
...
C++: Remove unneeded options from tests
2024-06-20 16:24:07 +02:00
Mathias Vorreiter Pedersen
e5c20b13cf
C++: Add extensible predicate for deallocation.
2024-06-20 14:51:09 +01:00
Jeroen Ketema
4c4c15b425
C++: Remove unneeded options from tests
2024-06-20 14:21:34 +02:00
Owen Mansel-Chan
aa35bd771b
Fix bug removing "vendor/" from package paths
2024-06-20 13:18:21 +01:00
Asger F
a36e39359f
Merge pull request #16739 from RasmusWL/js-array-steps
...
JS: Allow many Array steps to be used in type-tracking
2024-06-20 11:39:46 +02:00
Rasmus Lerchedahl Petersen
a7386b6670
Python: include new documentation
2024-06-20 11:25:25 +02:00
Rasmus Lerchedahl Petersen
f0e68887d4
Python: autoformat
2024-06-20 10:59:39 +02:00
yoff
b4fdf3c342
Apply suggestions from code review
...
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com >
2024-06-20 10:57:54 +02:00
Rasmus Wriedt Larsen
596102d3fb
Update javascript/ql/lib/change-notes/2024-06-14-type-tracking-array-steps.md
...
Co-authored-by: Asger F <asgerf@github.com >
2024-06-20 10:07:49 +02:00
Owen Mansel-Chan
754fd8e84c
Drop leading . from getQualifiedName for built-in functions
...
So it will be "panic" instead of ".panic".
2024-06-19 22:04:21 +01:00
Owen Mansel-Chan
68a661f3c7
Write out whole function names
2024-06-19 21:58:31 +01:00
Owen Mansel-Chan
b79711b17e
Move deprecated notice to top of comment
2024-06-19 21:58:28 +01:00
Max Schaefer
2be171746b
JavaScript: Fix CodeQL alert in extractor
...
This doesn't make a difference in practice because we only run the method on arrays of even length, but we might as well fix it.
2024-06-19 17:13:01 +01:00
Rasmus Lerchedahl Petersen
5cb37f5c4c
python: Document MaD format
...
- add a few tests reflecting the documentation
- make the mentioned sink-kinds have an effect on relevant queries
2024-06-19 17:00:15 +02:00
Michael Nebel
aa962f9b03
Java: Update expected output of model generation.
2024-06-19 14:10:59 +02:00
Michael Nebel
1185e28ea2
Java: Add some spurious source and sink model generation examples.
2024-06-19 14:10:56 +02:00
Michael Nebel
ed3f1e40db
Java: Sync changes and make dummy language specific implementation.
2024-06-19 14:10:54 +02:00
Michael Nebel
99907471b2
C#: Update model generator expected output.
2024-06-19 14:10:52 +02:00
Michael Nebel
40204911bc
C#: Only allow source propgatation upwards in the call stack if the call path consists of unique call targets (to avoid unwanted virtual dispatch). This severely tightens the generation of extrapolated sources.
2024-06-19 14:10:49 +02:00
Tom Hvitved
6dbdc9e17f
Merge pull request #16784 from github/redsun82/fix-warnings-in-ql-tests
...
C++/Java: Accept new warning format in ql tests
2024-06-19 13:05:50 +02:00
Paolo Tranquilli
b7a2ea8981
CI: accept other diagnostic format related test changes
2024-06-19 11:33:50 +02:00
Paolo Tranquilli
59f8f8a394
Merge branch 'main' into redsun82/fix-warnings-in-ql-tests
2024-06-19 11:21:36 +02:00
Tamás Vajk
45ece48b6f
Merge pull request #16776 from tamasvajk/fix/source-generator-folder
...
C#: Make sure no file is added twice to the compilation
2024-06-19 10:09:50 +02:00
Paolo Tranquilli
919ddccfdb
C++/Java: Accept new warning format in ql tests
2024-06-19 09:13:18 +02:00
Edward Minnix III
7adfa6bbed
Merge pull request #16709 from egregius313/egregius313/go/df/threat-models/refactor-queries
...
Go: Refactor queries to use `ThreatModelFlowSource` instead of `RemoteFlowSource`
2024-06-18 13:56:00 -04:00
am0o0
eb1999f8b3
revert .vscode/settings.json :((
2024-06-18 18:43:20 +02:00
am0o0
ccb923a436
fix formatting
2024-06-18 18:31:29 +02:00
Ed Minnix
5bbd003dfc
Reword change note
2024-06-18 12:27:21 -04:00
Ed Minnix
b53712cae0
Change note
2024-06-18 12:27:19 -04:00
Ed Minnix
6a0be6ad09
ExternalAPIs
2024-06-18 12:27:18 -04:00
Ed Minnix
46e16b88bb
Refactor experimental queries to use ThreadModelFlowSource
2024-06-18 12:27:17 -04:00
Ed Minnix
cfd5f53eb0
Refactor Customizations libraries to use ThreatModelFlowSource
2024-06-18 12:27:15 -04:00
Edward Minnix III
8997f2cdf2
Merge pull request #16697 from egregius313/egregius313/go/dataflow/threat-modeling
...
Go: Introduce Threat Modeling
2024-06-18 12:25:33 -04:00
am0o0
1f99559e9f
Revert "update id of the query file"
...
This reverts commit 1f112467ce .
2024-06-18 17:33:07 +02:00
am0o0
cb39ae7dd3
revert .vscode/settings.json
2024-06-18 17:27:15 +02:00
am0o0
8a7fdfa6fe
fix conflict
2024-06-18 17:18:59 +02:00
Taus
59a77a873c
Merge pull request #16754 from github/tausbn/python-disregard-unused-imports-in-pytest-tests
...
Python: Disregard unused imports in `pytest` tests
2024-06-18 15:10:31 +02:00
Owen Mansel-Chan
9403bf25d8
Merge pull request #16667 from smowton/smowton/fix/global-variable-side-effect
...
Add support for flow through content of global variables
2024-06-18 13:41:57 +01:00
Tamas Vajk
6c8e391a63
C#: Make sure no file is added twice to the compilation
2024-06-18 13:45:09 +02:00
Tamas Vajk
5170585515
C#: Add integration test with file added multiple times in the same compilation
2024-06-18 13:45:06 +02:00
Michael Nebel
1c3ceacf04
C#: Some renaming and re-factoring.
2024-06-18 13:05:21 +02:00
Michael Nebel
dfaa40a1d2
C#: Update expected test output from model generation.
2024-06-18 13:05:17 +02:00
Michael Nebel
b5d6a6db7e
C#: Use the same types as sanitizers for source and sink model as we use for summary model generation.
2024-06-18 13:05:12 +02:00
Michael Nebel
031e44b157
C#: Add some source/sink model generator test examples.
2024-06-18 13:05:07 +02:00
Max Schaefer
2c4a95bb5e
Merge pull request #16777 from github/max-schaefer-patch-1
...
Swift: Add missing bracket in example
2024-06-18 11:39:42 +01:00
Alex Ford
6c3d90e8a0
Merge pull request #16650 from alexrford/rb/routing-improvements
...
Ruby: ActionDispatch - support `path => target` route format
2024-06-18 11:17:05 +01:00
Max Schaefer
9ca74de3e9
Swift: Add missing bracket in example
2024-06-18 11:00:59 +01:00
Joe Farebrother
33704779ea
Merge pull request #16503 from joefarebrother/ruby-sensitive-sources
...
Ruby: Use additional sensitive data heuristics for CleartextSources
2024-06-18 10:57:55 +01:00
Michael Nebel
cd9d58fdc8
Merge pull request #16772 from michaelnebel/java/taintedpermissionthreatmodel
...
Java: Opt-in `java/tainted-permissions-check` to threat models.
2024-06-18 10:54:28 +02:00
Joe Farebrother
eee7f5a896
Use a combined regex for performance
2024-06-17 22:21:33 +01:00
Cornelius Riemenschneider
0f98d9e815
Merge pull request #16774 from github/criemen/cleanup
...
Remove unused bzl files.
2024-06-17 20:04:25 +02:00
Chris Smowton
4da5d6660a
Add change note
2024-06-17 16:49:09 +01:00
Chris Smowton
38ee085782
Adjust test expectation
2024-06-17 16:46:49 +01:00
Chris Smowton
822f6eebfb
Add support for flow through content of global variables
2024-06-17 16:42:23 +01:00
Ed Minnix
b4ecc81145
Fix provenance numbers in tests
2024-06-17 11:33:19 -04:00
Ed Minnix
fa2c50616b
Remove getSourceType definitions
2024-06-17 10:57:11 -04:00
Ed Minnix
b6adff6377
Fix jsoniter test
2024-06-17 10:51:13 -04:00
Ed Minnix
53dd269f9f
Go: Threat model tests
2024-06-17 10:51:11 -04:00
Ed Minnix
7f19f449eb
Change note
2024-06-17 10:51:10 -04:00
Ed Minnix
49fb372eb9
Add getSourceType declarations to existing remote flow sources
2024-06-17 10:51:09 -04:00
Ed Minnix
df6449cfc7
Go: Add the SourceNode and ThreatModelFlowSource classes
2024-06-17 10:51:07 -04:00
Ed Minnix
b697068e9a
Go: Add threat modeling shared library
2024-06-17 10:51:06 -04:00
Michael Nebel
5686efd25c
Update java/ql/src/change-notes/2024-06-17-tainted-permissions-check.md
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2024-06-17 16:47:22 +02:00
Cornelius Riemenschneider
f41bd41bd0
Remove unused bzl files.
2024-06-17 15:15:08 +02:00
Michael Nebel
197cdab43d
Merge pull request #16752 from michaelnebel/shared/sourcesinkcallables
...
C#/Java: Add some (shared) helper classes for Neutrals, Sources and Sink
2024-06-17 14:58:27 +02:00
Anders Schack-Mulligen
0e8af39b77
Merge pull request #16719 from aschackmull/shared/fix-qldoc
...
Shared: Fix file-module qldoc.
2024-06-17 13:26:57 +02:00
Anders Schack-Mulligen
96b6ddefe0
Merge pull request #16751 from aschackmull/java/sndlevelscope-fix
...
Java: Calculate 2nd level scopes for implicit instance accesses.
2024-06-17 13:10:46 +02:00
Michael Nebel
57925373c6
Address review comment.
2024-06-17 13:02:25 +02:00
Michael Nebel
833b4f90bf
Java: Make source and sink callable adapters.
2024-06-17 12:53:08 +02:00
Michael Nebel
0fabca94db
C#: Use the new shared classes for Source and Sink callables.
2024-06-17 12:53:06 +02:00
Michael Nebel
3d53ddf919
DataFlow: Add some shared classes for Neutrals, Source and Sink callables.
2024-06-17 12:53:03 +02:00
Michael Nebel
e1317ddcb6
Merge pull request #16768 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-06-17 11:51:35 +02:00
Anders Schack-Mulligen
b8b95fd81d
Java: Add change note.
2024-06-17 11:46:54 +02:00
Michael Nebel
c3862660e4
Java: Add change note.
2024-06-17 11:07:29 +02:00
Michael Nebel
327dab69d0
Java: Opt-in the tainted permissions check query to threat models.
2024-06-17 11:02:08 +02:00
Jeroen Ketema
1d1a84962b
Merge pull request #16765 from jketema/attrib-dup
...
C++: Add more tests that show we do not properly deduplicate attributes
2024-06-17 07:07:55 +02:00
github-actions[bot]
abe2deb6a6
Add changed framework coverage reports
2024-06-17 00:18:39 +00:00
Andrew Eisenberg
3d3a315456
Merge pull request #16766 from github/aeisenberg/requirements
...
Add powershell to list of requirements on windows
2024-06-14 15:15:28 -07:00
Andrew Eisenberg
d238b9198d
Clarify that this applies to both autobuild and regular builds
2024-06-14 14:41:29 -07:00
Owen Mansel-Chan
b0afba49a2
Merge pull request #16761 from owen-mc/java/reverse-dns-get-loopback-address
...
Java: Exclude loopback address from reverse DNS source
2024-06-14 22:39:55 +01:00
Andrew Eisenberg
39a8af6519
Add powershell to list of requirements on windows
2024-06-14 14:30:47 -07:00
Jeroen Ketema
14b5114aa6
C++: Add more tests that show we do not properly deduplicate attributes
2024-06-14 17:44:05 +02:00
Jeroen Ketema
c0df22950b
Merge pull request #16763 from jketema/attrib-dup
...
C++: Add test that show that routine attributes are not fully de-duplicated
2024-06-14 17:15:27 +02:00
Taus
b7b0f84e8b
Python: Handle @pytest.fixture decorations with arguments as well
...
Not the prettiest of solutions, but it seems to work well enough.
2024-06-14 15:11:25 +00:00
Taus
c75e66c433
Merge pull request #16762 from github/redsun82/python-disregard-unused-imports-in-pytest-tests
...
Python: failing unused import test case
2024-06-14 16:57:53 +02:00
Owen Mansel-Chan
9aa0c9f1f3
Fix test expectations
2024-06-14 15:55:30 +01:00
Paolo Tranquilli
1046d03486
Python: update unused import test case for pytest
2024-06-14 16:55:05 +02:00
Jeroen Ketema
7d97463e4d
C++: Add test that show that routine attributes are not fully de-duplicated
2024-06-14 16:43:29 +02:00
Ian Lynagh
079717bbc0
Merge pull request #16694 from igfoo/igfoo/PopulationSpecFile
...
Kotlin: Remove unused PopulationSpecFile
2024-06-14 15:06:39 +01:00
Rasmus Wriedt Larsen
3fc8401370
JS: Add change-note
2024-06-14 15:37:25 +02:00
Rasmus Wriedt Larsen
3f2befc3e5
JS: Support spread arguments in array.splice
2024-06-14 15:33:17 +02:00
Rasmus Wriedt Larsen
269f8ca2cd
JS: Add splice(...arr) test
2024-06-14 15:19:56 +02:00
Rasmus Wriedt Larsen
68ccec3d43
JS: Prepare for new test
2024-06-14 15:18:47 +02:00
Taus
2f00a0d323
Python: Also test pytest fixture factories
2024-06-14 13:11:00 +00:00
Owen Mansel-Chan
6cfd9458b0
Add change note
2024-06-14 14:05:25 +01:00
Owen Mansel-Chan
7a13c31021
Exclude loopback address from reverse DNS source
2024-06-14 14:05:01 +01:00
Owen Mansel-Chan
5973f3fadc
Add test for reverse DNS from loopback address
2024-06-14 14:04:47 +01:00
Owen Mansel-Chan
098b732937
Fix formatting of inline expectation test comment
2024-06-14 14:04:42 +01:00
Rasmus Wriedt Larsen
194ef607f7
JS: Updated .expected
2024-06-14 14:49:34 +02:00
Taus
78729180ad
Python: Fix pytest fixture unused import FPs
2024-06-14 12:05:55 +00:00
Taus
f3a9c9a9dc
Python: Add tests for pytest fixture unused import FPs
2024-06-14 12:03:43 +00:00
am0o0
4e1f7a930d
fix invalid js file sample in qlhelp
2024-06-14 13:47:01 +02:00
Paolo Tranquilli
e2a47e7c18
Merge pull request #16720 from github/redsun82/kotlin
...
Kotlin: cleanup after internal changes
2024-06-14 13:28:22 +02:00
Cornelius Riemenschneider
c808953b1d
Merge pull request #16723 from github/criemen/codeql-pack-group
...
`pkg.bzl`: Significantly restructure `codeql_pack` rule.
2024-06-14 13:19:00 +02:00
Michael Nebel
3525967143
Merge pull request #16701 from michaelnebel/csharp/modelgentaintmembers
...
C#/Java: Improve Sink and Summary model generation.
2024-06-14 12:30:50 +02:00
Tom Hvitved
c7b4f51077
Merge pull request #16758 from hvitved/ruby/shared-ci-trigger
...
Ruby: Trigger `ruby-build.yml` on changes to shared extractor
2024-06-14 12:00:18 +02:00
Michael B. Gale
039537f7ba
Merge pull request #16727 from github/mbg/go/fix/too-many-go-mod-files-initialised
2024-06-14 10:14:57 +01:00
Tom Hvitved
be66ea2178
Ruby: Trigger ruby-build.yml on changes to shared extractor
2024-06-14 11:09:03 +02:00
Michael Nebel
a29446a566
C#/Java: Address review comments.
2024-06-14 10:46:19 +02:00
Cornelius Riemenschneider
58f69c9385
Make CodeQLPackInfo provider public.
2024-06-13 21:57:46 +02:00
Cornelius Riemenschneider
02100e58d9
Address review.
2024-06-13 21:55:56 +02:00
Cornelius Riemenschneider
ede0b5bdf4
Merge remote-tracking branch 'origin/main' into criemen/codeql-pack-group
2024-06-13 21:53:31 +02:00
Paolo Tranquilli
f9db7864e1
Change note: reword
2024-06-13 18:04:23 +02:00
Paolo Tranquilli
0198806658
Merge branch 'main' into redsun82/kotlin
2024-06-13 16:29:13 +02:00
am0o0
bb03a9faba
format the query file
2024-06-13 14:54:29 +02:00
am0o0
f0a467e80b
update tests
2024-06-13 14:52:22 +02:00
am0o0
84b9d4d1ac
fix qlhelp errors
2024-06-13 14:32:41 +02:00
Mathias Vorreiter Pedersen
3d037e73f0
Merge pull request #16749 from MathiasVP/fix-fps-on-double-free
...
C++: Fix `ArrayExpr` FPs in `cpp/double-free`
2024-06-13 12:58:41 +01:00
Paolo Tranquilli
b8de2ea03b
Merge pull request #16731 from github/redsun82/kotlin-fix-version-picker
...
Kotlin: expose kotlin version picker for internal packaging
2024-06-13 13:57:38 +02:00
Anders Schack-Mulligen
b47831af14
Java: Calculate 2nd level scopes for implicit instance accesses.
2024-06-13 13:57:18 +02:00
Michael B. Gale
1834a399d2
Merge pull request #16738 from github/mbg/go/remove-go-work
...
Go: Remove `go.work` file
2024-06-13 12:20:12 +01:00
Mathias Vorreiter Pedersen
4bbeda08d6
C++: Fix change note naming.
2024-06-13 11:10:00 +01:00
Mathias Vorreiter Pedersen
83108e3e25
C++: Add change note.
2024-06-13 11:03:52 +01:00
Mathias Vorreiter Pedersen
bcabc88649
C++: Accept test changes.
2024-06-13 10:59:46 +01:00
Mathias Vorreiter Pedersen
4079de125f
C++: Fix FP by also excluding indirections of array expressions.
2024-06-13 10:59:39 +01:00
Mathias Vorreiter Pedersen
eec259279a
C++: Add another FP test. We already have tests for this, but it doesn't hurt to have another one, I guess.
2024-06-13 10:57:49 +01:00
Mathias Vorreiter Pedersen
e244eef3b5
Merge pull request #16748 from MathiasVP/rc-3.14-mergeback-2
...
Mergeback from `rc/3.14`
2024-06-13 10:44:46 +01:00
Michael Nebel
7f7c5d7c94
Java: Update model generator expected test output.
2024-06-13 10:57:15 +02:00
Michael Nebel
e247d5b316
Java: Sync files and make dummy language specific implementation.
2024-06-13 10:55:17 +02:00
Michael Nebel
e56c185f32
Java: Add some model generator sink examples.
2024-06-13 10:49:57 +02:00
Mathias Vorreiter Pedersen
0150269503
Merge branch 'rc/3.14' into rc-3.14-mergeback-2
2024-06-13 09:14:40 +01:00
Mathias Vorreiter Pedersen
9384f6189e
Merge pull request #16740 from MathiasVP/fix-join-in-ssa
...
SSA: Fix bad join in `lastRefRedefExt`
2024-06-13 09:06:20 +01:00
Paolo Tranquilli
11c37734c3
Kotlin: add change note for having fixed kotlin QL tests in release
2024-06-13 09:49:39 +02:00
Michael Nebel
854c6fa813
C#: Update expected test output after .NET 8 models update.
2024-06-13 09:24:13 +02:00
Michael Nebel
9ea2b463f0
C#: Update .NET 8 Runtime models.
2024-06-13 08:36:23 +02:00
Michael Nebel
78d23ee044
C#/Java: Allow the model generator to use 32GB of ram.
2024-06-13 08:35:52 +02:00
Rasmus Wriedt Larsen
ec18786488
JS: Provide better model for Array.splice
2024-06-12 16:29:21 +02:00
Mathias Vorreiter Pedersen
5b3403c4b1
C++: Fix bad join in 'lastRefRedefExt'.
2024-06-12 15:24:58 +01:00
Michael B. Gale
e10e2899bd
Go: Update comment in gen.py
2024-06-12 15:24:33 +01:00
Rasmus Wriedt Larsen
54a0e6dc45
JS: Add new test for Array.splice
2024-06-12 16:24:33 +02:00
Michael B. Gale
8629e00686
Go: Remove workspace from vendor/modules.txt
2024-06-12 15:22:56 +01:00
Rasmus Wriedt Larsen
9ed6da1072
JS: prepare to extend Array tests
...
Oh how I have enjoyed working with InlineExpectationTests for these sort
of things, not worrying about all the .expected files changing because
you add a few lines in the middle of your tests :D
2024-06-12 16:22:55 +02:00
Michael B. Gale
a90968d277
Go: Replace go work vendor with go mod vendor
2024-06-12 15:19:14 +01:00
Rasmus Wriedt Larsen
1027ca266d
JS: Allow many Array steps to be used in type-tracking
2024-06-12 16:14:13 +02:00
Joe Farebrother
90d6f2ece3
Factor out nameIndicatesRelevantSensitiveData
2024-06-12 15:11:47 +01:00
Tom Hvitved
605fe54a06
Ruby: Remove two Cartesian products
2024-06-12 15:11:43 +01:00
Joe Farebrother
5f08371f19
Add change note
2024-06-12 15:11:39 +01:00
Joe Farebrother
07f03be8cc
Add unit tests
2024-06-12 15:11:35 +01:00
Joe Farebrother
b0c03f6d68
Allow implicit read steps on sinks
2024-06-12 15:11:32 +01:00
Joe Farebrother
8b51ee8fe8
Use additional sensitive data heuristics in CleartextSources
2024-06-12 15:11:27 +01:00
Michael B. Gale
a04f08f026
Go: Remove go.work file
2024-06-12 15:10:28 +01:00
Tamás Vajk
a756f86847
Merge pull request #16732 from tamasvajk/refactor/extraction-states
...
C#: Refactor extractor state classes and simplify extraction code
2024-06-12 15:20:11 +02:00
Tamas Vajk
0df6a1c4b1
Fix quality issues
2024-06-12 14:48:16 +02:00
Michael Nebel
48739da565
C#: Update expected test output.
2024-06-12 14:16:31 +02:00
Michael Nebel
91ebeee429
C#: Perceive field and property reads as additional flow steps in sink extrapolation.
2024-06-12 14:16:26 +02:00
Michael Nebel
5aee35256d
C#: Add member flow example.
2024-06-12 14:16:22 +02:00
Michael Nebel
4b62cb64ed
C#: Update expected test output.
2024-06-12 14:16:17 +02:00
Michael Nebel
0bbf131fdb
C#: Add some compound sink examples.
2024-06-12 14:16:12 +02:00
Kasper Svendsen
7c2ee80bc3
Document builtin InternSets module
2024-06-12 13:56:48 +02:00
Tamas Vajk
e3cbf1479a
Fix quality issue
2024-06-12 13:25:34 +02:00
Arthur Baars
4ee80653e2
Merge pull request #16471 from Sim4n6/ruby-UBV
...
Ruby: Add some method calls as a Source
2024-06-12 12:42:08 +02:00
Tamas Vajk
3551386a1a
Simplify standalone extractor
2024-06-12 12:30:08 +02:00
Owen Mansel-Chan
6af1ed9d75
Merge pull request #16730 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-06-12 11:22:29 +01:00
Tamas Vajk
cdca607828
Rename Extractor to ExtractionContext
2024-06-12 11:43:19 +02:00
Tamas Vajk
af2a78ea4d
Reduce references to Extract class
2024-06-12 11:13:05 +02:00
Paolo Tranquilli
183a825841
Kotlin: expose kotlin version picker for internal packaging
2024-06-12 09:29:57 +02:00
github-actions[bot]
bbeebfae73
Add changed framework coverage reports
2024-06-12 00:17:31 +00:00
Joe Farebrother
f441c68f7e
Merge pull request #16657 from joefarebrother/python-partial-ssrf-fp
...
Python: Add additional sanitizers to SSRF
2024-06-11 23:20:50 +01:00
Mauro Baluda
1db5e32e86
Extract SAP XSJS file types as Javascript
2024-06-11 23:53:41 +02:00
Mauro Baluda
45a48f360f
Extract SAP XSJS file types as Javascript
2024-06-11 23:51:44 +02:00
Michael B. Gale
e9bd85e0ba
Merge pull request #16704 from github/mbg/go/fix/build-scripts-running-more-than-once
2024-06-11 22:23:15 +01:00
Michael B. Gale
202d77d94f
Merge pull request #16726 from github/mbg/go/log-one-line-for-stray-sources
...
Go: Only log one line for stray .go files
2024-06-11 22:16:21 +01:00
Owen Mansel-Chan
24c9062b35
Merge pull request #16671 from owen-mc/go/mad-builtin-taint-models-try-2
...
Go: Convert old-style models for built-ins to MaD
2024-06-11 19:45:34 +01:00
Michael B. Gale
d8d1ae632c
Merge branch 'mbg/go/fix/build-scripts-running-more-than-once' into mbg/go/fix/too-many-go-mod-files-initialised
2024-06-11 18:31:03 +01:00
Michael B. Gale
0f56e408f8
Merge branch 'main' into mbg/go/fix/build-scripts-running-more-than-once
2024-06-11 18:29:41 +01:00
Michael B. Gale
864d629a13
Go: Prevent go.mod files from being added to every directory with stray source files
2024-06-11 18:24:11 +01:00
Michael B. Gale
20b7def543
Go: Only log one line for stray .go files
2024-06-11 18:06:08 +01:00
Geoffrey White
cf4736c8f6
Merge pull request #16545 from geoffw0/salvage
...
Swift: Salvage
2024-06-11 17:51:17 +01:00
Mathias Vorreiter Pedersen
67b327a0f7
Merge pull request #16725 from MathiasVP/rc-3.14-mergeback
...
Mergeback from `rc/3.14`
2024-06-11 17:37:40 +01:00
Tony Torralba
a299afaf51
Merge pull request #16712 from mbaluda/main
...
Java: Add `FileUtils` sinks to path injection
2024-06-11 17:50:08 +02:00
Paolo Tranquilli
3d3652c63f
Merge branch 'main' into redsun82/kotlin
2024-06-11 17:25:10 +02:00
Cornelius Riemenschneider
92957a63ad
Add prefix feature to codeql_pack_group.
...
Turns out we need this for our production targets.
2024-06-11 17:22:35 +02:00
Mathias Vorreiter Pedersen
3351b9547d
Merge branch 'rc/3.14' into rc-3.14-mergeback
2024-06-11 16:21:08 +01:00
Owen Mansel-Chan
2ae7fa4897
Tests: accept expected changes
2024-06-11 16:20:06 +01:00
Owen Mansel-Chan
6fd2ab7cef
Tests: Accept model renumbering in edge provenance
2024-06-11 16:18:18 +01:00
Mathias Vorreiter Pedersen
b88a1b2d1e
Merge pull request #16724 from MathiasVP/cache-asexpr
...
C++: Cache `asExpr` (and `asIndirectExpr`) implementation predicates
2024-06-11 16:17:29 +01:00
Owen Mansel-Chan
700604a1c2
Convert old-style models for built-ins to MaD
...
These models are to cover the special cases where `append` can be used
with a second argument which is a string followed by `...`, and `copy`
can be used with a second argument which is a string. In this case the
taint is carried by the whole string, rather than in array elements.
2024-06-11 16:16:45 +01:00
Joe Farebrother
93f10fcf14
Add sanitizers for compiled regexes
2024-06-11 15:44:16 +01:00
Mathias Vorreiter Pedersen
6a6978398a
C++: Add file QLDoc.
2024-06-11 15:39:45 +01:00
Mathias Vorreiter Pedersen
333df03f64
C++: Cache more things.
2024-06-11 15:39:43 +01:00
Mauro Baluda
a464a8e48e
@mbaluda
...
Update provenance in test expectations
2024-06-11 15:15:50 +02:00
Tamas Vajk
11faf08ed0
Remove specific standalone/tracing extractor state classes
2024-06-11 14:16:35 +02:00
Geoffrey White
214db5c20d
Swift: Make CI more happy.
2024-06-11 12:49:58 +01:00
Cornelius Riemenschneider
3cf719cb39
pkg.bzl: Significantly restructure codeql_pack rule.
...
This PR introduces a `codeql_pack_rule` that does the heavy lifting
of extracting arch- and common zip files for production dist building.
It also factors out the installer targets for individual packs,
as well as pack groups.
This changes the contract between the internal build system and the pack
definition significantly, which is why an accompanying internal PR is required.
No backwards compatibility layer is provided, as the PR as complex enough as-is.
The individual `codeql_pack` rules are now much simpler,
as they mostly stuff their inputs into a new `_CodeQLPackInfo` provider,
and let the installer and `codeql_pack_group` rules do the heavy lifting.
For working in the external repo with self-contained packs,
the per-pack installer targets are still available.
Internally, we'll only use the new `codeql_pack_group` targets
going forward, both for defining intree-dists and for building
the production zip files.
2024-06-11 13:15:05 +02:00
Cornelius Riemenschneider
3574b9fd4f
Merge pull request #16716 from github/criemen/rust-bzlmod-new
...
Rust: Move to bzlmod.
2024-06-11 13:13:16 +02:00
Mauro Baluda
29e3816412
Apply suggestions from code review
...
Address reviewiew comments
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2024-06-11 12:05:14 +02:00
Paolo Tranquilli
01416838a1
Merge branch 'main' into redsun82/kotlin
2024-06-11 11:57:19 +02:00
Cornelius Riemenschneider
4226270ef9
Merge branch 'main' into criemen/rust-bzlmod-new
2024-06-11 11:40:40 +02:00
Anders Schack-Mulligen
73caa48302
Merge pull request #16721 from aschackmull/dataflow/remove-unused-import
...
Dataflow: Remove unused import.
2024-06-11 09:54:05 +02:00
Chris Smowton
3172054073
Merge pull request #16717 from github/post-release-prep/codeql-cli-2.17.5
...
Post-release preparation for codeql-cli-2.17.5
2024-06-11 07:56:55 +01:00
Anders Schack-Mulligen
939ae4a561
Dataflow: Remove unused import.
2024-06-11 08:55:44 +02:00
Paolo Tranquilli
90db894d01
Kotlin: remove obsolete scripts and reword comments
2024-06-11 08:52:26 +02:00
Anders Schack-Mulligen
87316784ad
Shared: Fix file-module qldoc.
2024-06-11 08:49:15 +02:00
Mauro Baluda
bb5ef3ccd9
Update provenance in test expectations
2024-06-10 19:57:37 +02:00
Mauro Baluda
e9dba59f11
Merge branch 'main' into main
2024-06-10 19:57:00 +02:00
Geoffrey White
ae0bf037ac
Swift: Make CI happy.
2024-06-10 18:54:16 +01:00
Geoffrey White
2f33b9422b
Merge branch 'main' into salvage
2024-06-10 18:31:46 +01:00
Geoffrey White
83860acdde
Swift: Test BuiltinLiteralExpr.
2024-06-10 18:20:25 +01:00
Geoffrey White
f2b1e09650
Swift: Add some conversion test cases.
2024-06-10 17:25:25 +01:00
Michael B. Gale
317790eac3
Merge pull request #16703 from github/mbg/go/improve-version-selection-v2
...
Go: Use toolchain directives for version selection if available, and add tests (v2)
2024-06-10 16:03:00 +00:00
Mathias Vorreiter Pedersen
ec34007a88
Merge pull request #16714 from MathiasVP/handle-unlikely-in-guards-2
...
C++: Support `__builtin_expect` in `IRGuards`
2024-06-10 16:54:01 +01:00
github-actions[bot]
8a25081a0e
Post-release preparation for codeql-cli-2.17.5
2024-06-10 15:33:08 +00:00
Tony Torralba
7336dd1ae5
Merge pull request #16482 from grakshith/rakshith/tune-java-crypto
...
Java: Add RSA/ECB/OEAP ciphers to the list of secure algorithms
2024-06-10 17:27:35 +02:00
Cornelius Riemenschneider
496fff4273
C#: Remove empty glob pattern.
2024-06-10 17:04:00 +02:00
Cornelius Riemenschneider
00319c5010
Upgrade bazel to 7.2.0.
...
This also bumps a bunch of external dependencies.
2024-06-10 17:03:59 +02:00
Cornelius Riemenschneider
092bc6445d
Rust/bazel: Port to bzlmod.
...
This gets rid of our last workspace dependency.
In particular, this change also gets rid of the checked-in extra
lock files that took forever to generate.
2024-06-10 17:03:58 +02:00
Michael B. Gale
d4adc373c6
Replace if with else if in RequiredGoVersion
2024-06-10 15:48:29 +01:00
Chris Smowton
a160b891c8
Merge pull request #16715 from github/release-prep/2.17.5
...
Release preparation for version 2.17.5
2024-06-10 14:46:30 +01:00
github-actions[bot]
877bfa2468
Release preparation for version 2.17.5
2024-06-10 13:40:39 +00:00
Mathias Vorreiter Pedersen
c3bba38950
C++: Fix QLDoc.
2024-06-10 13:39:34 +01:00
Cornelius Riemenschneider
7ecf1f9010
Merge pull request #16713 from github/criemen/csharp-version-fallback
...
C#: Add fallback for branch detection.
2024-06-10 14:24:37 +02:00
Mathias Vorreiter Pedersen
1aea120e89
C++: Add change note.
2024-06-10 13:01:01 +01:00
Mathias Vorreiter Pedersen
b0c4fcec57
C++: Cleanup.
2024-06-10 12:53:07 +01:00
Mathias Vorreiter Pedersen
9e088f3e4a
C++: Accept test changes.
2024-06-10 12:53:06 +01:00
Mathias Vorreiter Pedersen
84c1341b62
C++: Support builtin expect in IRGuards.
2024-06-10 12:53:04 +01:00
Mathias Vorreiter Pedersen
d76700497b
C++: Add testcases using the builtin expect operation.
2024-06-10 12:47:45 +01:00
Mathias Vorreiter Pedersen
9c98652116
C++: Handle 'unlikely' in IRGuards.
2024-06-10 12:47:44 +01:00
Jeroen Ketema
000a81fd29
Merge pull request #16690 from MathiasVP/better-guards
...
C++: Fix missing results for `comparesEq` in `IRGuardCondition`
2024-06-10 13:32:10 +02:00
Sim4n6
7c0ce6486b
Rerun the test learn
2024-06-10 12:21:10 +01:00
Cornelius Riemenschneider
027c7d0d43
C#: Add fallback for branch detection.
...
Apparently, when building a release build, we're getting `no-git`
as first part o the version string for the submodule.
If we do, fall back to the internal repo's branch name.
For releases, that's the same anyways.
Luckily, the commit SHA is correct.
2024-06-10 12:14:03 +02:00
Mauro Baluda
1d44f45be2
Update org.apache.commons.io.model.yml
2024-06-10 12:03:57 +02:00
Mathias Vorreiter Pedersen
7819cc1c36
C++: Add more QLDoc.
2024-06-10 10:58:52 +01:00
Mauro Baluda
71505f4003
Added more org.apache.commons.io.FileUtils-related sinks to the path injection query.
2024-06-10 11:29:51 +02:00
Tamás Vajk
06aa2664bf
Merge pull request #16705 from tamasvajk/build/fix-attributes
...
C#: Add assembly attributes to assemblies built with Bazel
2024-06-10 09:26:31 +02:00
am0o0
9db334d02f
update select statement, update test cases
2024-06-07 21:26:20 +02:00
am0o0
2c9340331d
update test cases expected results
2024-06-07 21:16:31 +02:00
am0o0
5e0a78c4c7
make predicate for env key and value nodes, use propertyRead/Write instead of API nodes to find env key and value assignments, fix a bug thanks to @erik-krogh
2024-06-07 21:15:30 +02:00
Michael B. Gale
e7a60b72f1
Go: Check dependencies per workspace
2024-06-07 16:22:41 +00:00
Michael B. Gale
b9586a81ef
Go: Add functions for constructing go list commands
2024-06-07 16:22:40 +00:00
Michael B. Gale
6c0c3365cf
Go: Fix vendor issues and go.sum files in separate loop
2024-06-07 16:22:39 +00:00
Michael B. Gale
d344f720aa
Go: Add methods to GoModule for the tidy and vendor commands
...
These ensure that the module path is used automatically
2024-06-07 16:22:37 +00:00
Tamas Vajk
5f98f2aec9
Add assembly attributes to bazel build script
2024-06-07 15:42:12 +02:00
Cornelius Riemenschneider
6731bccc92
C#: Provide skeleton to generate an assemblyInfo file.
...
Each unit gets a unique assemblyInfo file, on top
of the ones for entrypoints that also gets the git info embedded.
2024-06-07 15:24:53 +02:00
Tamas Vajk
16f8be4ba4
C#: Add product name to assemblies
2024-06-07 15:24:21 +02:00
Tamas Vajk
beffc2a49d
C#: Remove unneeded source folder from Bazel build scripts
2024-06-07 15:23:45 +02:00
Anders Schack-Mulligen
32260e2823
Merge pull request #16210 from aschackmull/dataflow/provenance-for-tests
...
Dataflow: Add support for pretty-printed alert provenance in tests
2024-06-07 14:53:56 +02:00
Michael B. Gale
881b2586e1
Go: Add tests for RequiredGoVersion
2024-06-07 12:20:44 +00:00
Michael B. Gale
504a233299
Go: Use Toolchain directives in go.mod files, if available
2024-06-07 12:20:43 +00:00
Michael B. Gale
1d6f09c750
Go: Refactor go.mod version retrieval into its own method
2024-06-07 12:20:42 +00:00
Michael B. Gale
44a16cef6c
Go: Use Toolchain directives in go.work files, if available
2024-06-07 12:20:41 +00:00
Michael B. Gale
ea3a3db847
Merge pull request #16460 from github/mbg/go/semver-type
...
Go: Use new type for all semantic versions
2024-06-07 12:19:12 +00:00
Michael B. Gale
9d1c2c6ba1
Merge branch 'main' into mbg/go/semver-type
2024-06-07 12:09:10 +00:00
Anders Schack-Mulligen
9b1e4d7895
Go: Fix test failure.
2024-06-07 13:16:20 +02:00
Pierre
0ab67d1790
Merge pull request #16684 from github/sitedocs/2.17.4
...
Add changelog for 2.17.4
2024-06-07 02:50:38 -07:00
Anders Schack-Mulligen
7e980d9524
Add a bit more qldoc.
2024-06-07 11:47:50 +02:00
Anders Schack-Mulligen
0c47203580
Javascript: Add support for pretty-printed provenace in tests.
2024-06-07 11:47:49 +02:00
Anders Schack-Mulligen
68ddae2918
Python: Add support for pretty-printed provenace in tests.
2024-06-07 11:47:48 +02:00
Anders Schack-Mulligen
5d51b5b97b
Ruby: Add support for pretty-printed provenace in tests. Convert one test.
2024-06-07 11:47:48 +02:00
Anders Schack-Mulligen
a26c01d7c7
Go: Add support for pretty-printed provenace in tests. Convert one test.
2024-06-07 11:47:45 +02:00
Anders Schack-Mulligen
0e8d72c126
C#: Add support for pretty-printed provenace in tests. Convert one test.
2024-06-07 11:45:16 +02:00
Anders Schack-Mulligen
4ec4da4c8c
Dataflow/Java: Add support for pretty-printed provenace in tests. Convert one test.
2024-06-07 11:45:13 +02:00
Tamás Vajk
68a78fa3ed
Merge pull request #16700 from tamasvajk/buildless/tsp-warning-config
...
C#: Add TSP warning if `buildless` option is used instead of `build-mode`
2024-06-07 11:07:16 +02:00
Michael Nebel
d5af71a6c9
Merge pull request #16647 from michaelnebel/csharp/idempotentsummarygeneration
...
C#: Make summary generation idempotent.
2024-06-07 10:38:25 +02:00
Tamas Vajk
9366eb8288
C#: Add TSP warning if buildless option is used instead of build-mode
2024-06-07 10:33:13 +02:00
Mathias Vorreiter Pedersen
7f62085be5
C++: Delete unused predicate.
2024-06-07 09:13:29 +01:00
Jeroen Ketema
456c046b09
Merge pull request #16693 from jketema/func-fix
...
C++: Correctly identify orphaned variables as static
2024-06-07 07:54:11 +02:00
am0o0
1033bf9c4c
remove unused imports from javascript test cases
2024-06-07 06:04:12 +02:00
am0o0
b9e3b3310e
update the remote flow based query thanks to @erik-krogh, update tests and separate the local and remote query tests
2024-06-07 06:01:49 +02:00
Ian Lynagh
97cb0c89c8
Kotlin: Remove unused PopulationSpecFile
2024-06-06 21:14:28 +01:00
Mathias Vorreiter Pedersen
ed525fce70
C++: Accept test changes.
2024-06-06 20:38:31 +01:00
Mathias Vorreiter Pedersen
b5a3575130
C++: Make proper use of barrier guards in test.
2024-06-06 20:38:17 +01:00
Jeroen Ketema
4488518838
C++: Update expected test results
2024-06-06 21:12:34 +02:00
Jeroen Ketema
5ae8fe502a
C++: Correctly identify orphaned variables as static
2024-06-06 20:35:26 +02:00
Jeroen Ketema
798357ffc6
C++: Add test case that shows that __func__ is not considered static
2024-06-06 20:31:45 +02:00
Mathias Vorreiter Pedersen
7b92554cf2
Merge branch 'main' into better-guards
2024-06-06 19:22:10 +01:00
Mathias Vorreiter Pedersen
9f4c1380e5
Merge pull request #16677 from MathiasVP/phi-input-nodes
...
C++: Extend barrier guards to handle phi inputs
2024-06-06 19:21:30 +01:00
Michael B. Gale
2662808629
Go: Output setup-go compatible pre-release identifiers
2024-06-06 17:14:45 +00:00
Mathias Vorreiter Pedersen
9564ae1ca4
C++: Accept more test changes.
2024-06-06 17:04:48 +01:00
Tom Hvitved
eae6406629
Merge pull request #16687 from hvitved/ruby/bump-ts-grammar
...
Ruby: Bump tree-sitter grammar
2024-06-06 17:44:18 +02:00
Mathias Vorreiter Pedersen
528afba919
C++: Accept test changes.
2024-06-06 16:32:29 +01:00
Mathias Vorreiter Pedersen
36aac3ffd8
C++: Get rid of 'relevantUnaryComparison' since it was excluding too much. The performance is most likely fine with that restriction.
2024-06-06 16:32:16 +01:00
Mathias Vorreiter Pedersen
703832f5a1
C++: Remove a column from a few predicates.
2024-06-06 16:30:32 +01:00
Mathias Vorreiter Pedersen
0298755975
C++: Add a test.
2024-06-06 16:22:23 +01:00
Mathias Vorreiter Pedersen
8aaa2a1079
C++: Improve comment.
2024-06-06 15:58:52 +01:00
Mathias Vorreiter Pedersen
f7b2d98c6e
C++: Add tests to demonstrate that it's not barrier guard that's buggy. Rather, it's the GuardCondition library.
2024-06-06 15:35:16 +01:00
Mathias Vorreiter Pedersen
fa09d21c32
C++: Simplify. No need for the 'PhiInputNodeExt' class.
2024-06-06 15:33:38 +01:00
Asger F
6e0f3df573
Merge pull request #14120 from asgerf/dynamic/typemodel-istypeused
...
Dynamic: add TypeModel.isTypeUsed
2024-06-06 15:31:16 +02:00
Mathias Vorreiter Pedersen
5deb9002bf
Merge pull request #16665 from geoffw0/yml
...
C++: Support for extension models (.yml)
2024-06-06 14:21:42 +01:00
Geoffrey White
8acb11924d
C++: Remove redundant import.
2024-06-06 13:39:10 +01:00
Mathias Vorreiter Pedersen
314eb5db72
Merge pull request #16688 from MathiasVP/flow-through-builtin-bit-cast
...
C++: Fix IR generation for builtins and add flow through `__builtin_bit_cast`
2024-06-06 13:28:41 +01:00
Geoffrey White
38acfcf42e
C++: Doc tweaks addressing review comments.
2024-06-06 13:11:57 +01:00
am0o0
12df7dee17
Merge branch 'amammad-js-JWT' of https://github.com/amammad/codeql into amammad-js-JWT
2024-06-06 14:04:46 +02:00
Am
af016f9416
Merge branch 'github:main' into amammad-js-JWT
2024-06-06 15:33:26 +03:30
am0o0
8258e377dd
use PascalCase for URLConstructorLabel
2024-06-06 14:00:56 +02:00
am0o0
d27a378008
change query-id to avoid duplicate ids
2024-06-06 13:59:58 +02:00
Geoffrey White
7aec488d8a
C++: Permit ':' in models-as-data namespaces.
2024-06-06 12:53:42 +01:00
Geoffrey White
894497218d
Shared: Recognize 'remote-sink' in ModelValidation.qll.
2024-06-06 12:49:13 +01:00
Geoffrey White
f9ef72eca6
C++: Fix typos.
2024-06-06 12:31:44 +01:00
Tom Hvitved
331f676832
Merge pull request #16523 from microsoft/jb1/chanely-insecure-sql-connection
...
Adding case to InsecureSQLConnection.ql when Encrypt set in initializer
2024-06-06 12:58:14 +02:00
Mathias Vorreiter Pedersen
31bc4263e7
C++: Fix QLDoc.
2024-06-06 10:52:37 +01:00
Paolo Tranquilli
ac6cc38b20
Merge pull request #16681 from github/redsun82/ripunzip
...
Ripunzip: provide installer
2024-06-06 11:52:04 +02:00
Paolo Tranquilli
2d42ea0f2f
Merge pull request #16668 from github/criemen/pkg-js-fixup
...
JS: Use `resources/tools` from external repo, not internal.
2024-06-06 11:50:54 +02:00
Mathias Vorreiter Pedersen
bd9ece0bd3
C++: Add dataflow through '__builtin_bit_cast'.
2024-06-06 10:00:18 +01:00
Mathias Vorreiter Pedersen
48f2fd0460
C++: Accept IR changes.
2024-06-06 09:52:35 +01:00
Mathias Vorreiter Pedersen
d6352b47a1
C++: Fix IR generation for builtin operations.
2024-06-06 09:52:20 +01:00
Mathias Vorreiter Pedersen
f58757ff9d
C++: Skip children we cannot translate when translating builtin operations.
2024-06-06 09:48:41 +01:00
Mathias Vorreiter Pedersen
af4d2f1ed3
C++: Add an IR test.
2024-06-06 09:48:03 +01:00
Tom Hvitved
523139259a
Ruby: Update cargo-bazel-lock.json
2024-06-06 10:46:01 +02:00
Tom Hvitved
7122db0c45
Ruby: Bump tree-sitter grammar
2024-06-06 10:31:16 +02:00
Tom Hvitved
421c68a263
Merge pull request #16663 from hvitved/ruby/extraction-error-consistency
...
Ruby: Add consistency query for extraction errors
2024-06-06 10:29:56 +02:00
Tamás Vajk
0f09198bcd
Merge pull request #16673 from tamasvajk/fix/logger-disposal
...
C#: Fix erroneous logger disposal
2024-06-06 09:13:27 +02:00
Sim4n6
dabc33bf66
simplify UnicodeBypassValidationQuery code
2024-06-05 22:45:49 +01:00
Erik Krogh Kristensen
2e5d9c34bf
Merge pull request #16675 from mbaluda/main
...
Extract .xsaccess files as JSON
2024-06-05 20:19:40 +02:00
Chanel
7b5297b882
Merge branch 'main' into jb1/chanely-insecure-sql-connection
2024-06-05 09:02:13 -07:00
Chanel Young
716e2737d1
formatting
2024-06-05 09:01:10 -07:00
Owen Mansel-Chan
ef2f01613c
Merge pull request #16676 from owen-mc/qldoc-external-flow
...
C/C#/Java/Swift: Cover all params in QLDoc of `modelCoverage`
2024-06-05 16:53:27 +01:00
Ian Lynagh
ac91a5167a
Merge pull request #16682 from igfoo/igfoo/integ
...
Java integration tests: accept new output
2024-06-05 16:48:18 +01:00
Chris Smowton
e704bf353b
Merge pull request #16685 from smowton/smowton/admin/ecj-change-note
...
Java: Add change note documenting ECJ improvements
2024-06-05 16:39:20 +01:00
Owen Mansel-Chan
3b51f1f722
Merge pull request #16683 from owen-mc/go/refactor-extractor
...
Go: Refactor findMethodWithGivenReceiver
2024-06-05 16:31:44 +01:00
Chris Smowton
79ae522349
Add change note documenting ECJ improvements
2024-06-05 15:12:33 +01:00
Michael B. Gale
c0142c1a91
Go: Add comment explaining why NewSemVer does not Canonicalise the result
2024-06-05 14:08:45 +00:00
Pierre
366fba8b33
Add changelog for 2.17.4
2024-06-05 16:03:50 +02:00
Michael B. Gale
f830dc6852
Merge branch 'main' into mbg/go/semver-type
2024-06-05 13:59:20 +00:00
Owen Mansel-Chan
fcf06c59aa
Refactor findMethodWithGivenReceiver
2024-06-05 14:52:31 +01:00
Chris Smowton
e267031f59
Merge pull request #16680 from smowton/smowton/admin/add-ecj-tests
...
Java: add basic ECJ integration tests
2024-06-05 14:33:36 +01:00
Ian Lynagh
13dd87f04c
Java integration tests: accept new output
...
This means the expected output is in the order that the new test driver
creates it in, which means future diffs will be smaller.
2024-06-05 14:14:44 +01:00
Paolo Tranquilli
61847bc58b
Ripunzip: provide installer
2024-06-05 14:46:59 +02:00
Michael B. Gale
5dd7e136e5
Merge branch 'main' into mbg/go/semver-type
2024-06-05 12:22:16 +00:00
Sim4n6
7dcbbbac91
Refactor UnicodeBypassValidationQuery to remove unnecessary code
2024-06-05 13:05:34 +01:00
Chris Smowton
54347c2642
Java: add basic ECJ integration tests
2024-06-05 12:49:25 +01:00
Owen Mansel-Chan
44a56c420f
Merge pull request #16558 from owen-mc/go/sync-external-flow
...
Go: sync ExternalFlow.qll
2024-06-05 11:31:34 +01:00
Jeroen Ketema
ff46e2c627
Merge pull request #16662 from jketema/gets
...
C++: Ignore `gets`'es with incorrect parameter counts
2024-06-05 11:50:04 +02:00
Mathias Vorreiter Pedersen
97f0c759c0
C++: Accept test changes.
2024-06-05 09:58:47 +01:00
Mathias Vorreiter Pedersen
44cc19cd6b
C++: Handle phi inputs in barrier guards logic.
2024-06-05 09:58:45 +01:00
Mathias Vorreiter Pedersen
05d46a6793
C++: Also ignore phi input edges in 'AllocaInLoop.ql'.
2024-06-05 09:58:44 +01:00
Mathias Vorreiter Pedersen
0149fb640d
C++: Simplify.
2024-06-05 09:58:43 +01:00
Mathias Vorreiter Pedersen
25179074c1
C++: Better toString on phi nodes.
2024-06-05 09:58:41 +01:00
Mathias Vorreiter Pedersen
85d0efcbed
C++: Make the last use of a node before entering the phi node map to a phi input dataflow node.
2024-06-05 09:58:40 +01:00
Jeroen Ketema
6f8449cf75
C++: Add change note
2024-06-05 10:05:13 +02:00
Owen Mansel-Chan
6b2e86afea
Accept review suggestion
2024-06-05 07:34:46 +01:00
Owen Mansel-Chan
63bec5ae3e
Merge pull request #16678 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-06-05 07:31:57 +01:00
github-actions[bot]
c2bd050e08
Add changed framework coverage reports
2024-06-05 00:17:01 +00:00
Mauro Baluda
cc0271715b
Merge branch 'main' into main
2024-06-04 23:27:10 +02:00
Mauro Baluda
0b9bafc9c3
Update AutoBuildTests.java
2024-06-04 21:07:57 +02:00
Mauro Baluda
168cba86c1
Add .xsaccess test data
2024-06-04 20:55:07 +02:00
Rakshith Gopalakrishna
798a736d16
fix: update changelog
...
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2024-06-04 11:20:05 -07:00
Rakshith Gopalakrishna
65af2556ed
fix: remove rsa/ecb/* from getASecureAlgorithmName
...
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2024-06-04 11:20:05 -07:00
Rakshith Gopala krishna
97f9a882c6
fix: address PR comments
2024-06-04 11:20:05 -07:00
Rakshith Gopala krishna
0f63f0dda2
docs: add changenote
2024-06-04 11:20:05 -07:00
Rakshith Gopala krishna
80bf7cdb52
fix: remove the pkcs1 scheme
2024-06-04 11:20:05 -07:00
Rakshith Gopala krishna
dd223ed704
feat: add rsa/ecb/... variants to the list of secure algorithms
2024-06-04 11:20:05 -07:00
Paolo Tranquilli
ad2eacfd2f
Merge pull request #16117 from github/redsun82/kotlin
...
Kotlin: build extractor with bazel
2024-06-04 20:13:00 +02:00
Mathias Vorreiter Pedersen
d020f93005
C++: This is never a definition.
2024-06-04 17:19:49 +01:00
Mathias Vorreiter Pedersen
3e53f3bd13
C++: Flow out of phi inputs to the phi node.
2024-06-04 17:19:47 +01:00
Mathias Vorreiter Pedersen
e04c75df24
C++: Introduce a new phi input dataflow node.
2024-06-04 17:19:46 +01:00
Mathias Vorreiter Pedersen
888a831a5c
C++: Use 'ssaDefReachesReadExt' instead of 'ssaDefReachesRead'.
2024-06-04 17:19:45 +01:00
Mathias Vorreiter Pedersen
556dc282d2
C++: Use 'phiHasInputFromBlockExt' instead of 'phiHasInputFromBlock'.
2024-06-04 17:19:43 +01:00
Mathias Vorreiter Pedersen
ceccc9294c
C++: Add a testcase that failed during development.
2024-06-04 17:19:41 +01:00
Mathias Vorreiter Pedersen
a9af28ede0
C++: Drive-by fix. This is not needed anymore after #16345
2024-06-04 17:19:40 +01:00
Mathias Vorreiter Pedersen
43c7ac36d9
C++: Add a test with spurious flow.
2024-06-04 17:19:36 +01:00
Owen Mansel-Chan
3fb5ad2a0d
Cover all params in QLDoc of modelCoverage
2024-06-04 17:06:00 +01:00
Paolo Tranquilli
b7e16ca55d
Kotlin: fix custom_plugin test
2024-06-04 17:59:13 +02:00
Paolo Tranquilli
e4653a80d4
Kotlin: remove kapt wrapper, probably unneeded
2024-06-04 17:55:19 +02:00
Mauro Baluda
8791e67789
Add .xsaccess test data
2024-06-04 17:50:08 +02:00
Mauro Baluda
576ee7892d
Add .xsaccess test data
2024-06-04 17:36:05 +02:00
Mauro Baluda
7b3e9b4ec1
Extract .xsaccess files as JSON
2024-06-04 16:28:08 +02:00
Mauro Baluda
73b18129d9
Extract .xsaccess files as JSON
2024-06-04 16:23:05 +02:00
Paolo Tranquilli
10584b3a7a
Kotlin: improve posix dev wrappers
2024-06-04 15:36:35 +02:00
Paolo Tranquilli
a48d71b42f
Merge branch 'main' into redsun82/kotlin
2024-06-04 15:32:59 +02:00
Tamas Vajk
b8bc014297
Fix erroneous logger disposal
2024-06-04 15:12:44 +02:00
Paolo Tranquilli
8205f86365
Kotlin: use tools/bazel in integration test
2024-06-04 15:12:23 +02:00
Paolo Tranquilli
be5c82cb88
Kotlin: add other tools to dev wrapper
2024-06-04 15:11:59 +02:00
Tom Hvitved
e42de3de6f
Ruby: Fix extraction errors
2024-06-04 14:54:02 +02:00
Paolo Tranquilli
c6039b345b
Kotlin: update default kotlinc version
2024-06-04 14:39:16 +02:00
Paolo Tranquilli
e693c2719d
Kotlin: remove unneeded patch
2024-06-04 14:39:02 +02:00
Paolo Tranquilli
e7cec01a81
Kotlin: make current_kotlin_version.py executable
2024-06-04 14:31:59 +02:00
Paolo Tranquilli
4c91bdce48
Kotlin: tgt -> target
2024-06-04 14:27:33 +02:00
Paolo Tranquilli
2fe0718e49
Explain .lfsconfig choice in the comment
2024-06-04 14:27:08 +02:00
Am
e3e59e02e5
Merge branch 'github:main' into amammad-js-CodeInjection_dynamic_import
2024-06-04 16:22:06 +04:00
Paolo Tranquilli
6a9cb90a57
Kotlin: rework header comment
2024-06-04 14:21:58 +02:00
Paolo Tranquilli
fcd326eb11
CI: reword comment
2024-06-04 14:14:23 +02:00
Owen Mansel-Chan
60970ff015
Merge pull request #16571 from owen-mc/go/remove-step-duplication-in-config
...
Go: remove flow step duplication in configs
2024-06-04 12:57:26 +01:00
Cornelius Riemenschneider
e8c1e50276
JS: Use resources/tools from external repo, not internal.
...
This was missing in https://github.com/github/codeql/pull/16656 , so we couldn't actually
delete the resources in the internal repo.
2024-06-04 13:54:41 +02:00
Cornelius Riemenschneider
c8202341bb
Merge pull request #16666 from tamasvajk/buildless/fix/quote-nuget-path
...
C#: Quote `nuget.exe` path
2024-06-04 13:29:05 +02:00
Tom Hvitved
ad99158838
Ruby: Fix/accept extraction errors
2024-06-04 12:55:44 +02:00
Tom Hvitved
858c7cead2
Ruby: Add consistency query for extraction errors
2024-06-04 12:55:42 +02:00
Tamas Vajk
c608675212
C#: Quote nuget.exe path
2024-06-04 12:49:32 +02:00
Owen Mansel-Chan
cbbdd01d5a
Reinstate more descriptive QLDoc
2024-06-04 11:46:05 +01:00
Owen Mansel-Chan
7356e747e4
Add change note
2024-06-04 11:46:04 +01:00
Owen Mansel-Chan
6e67e724b4
Update documentation for receiver instead of -1
2024-06-04 11:46:02 +01:00
Owen Mansel-Chan
5c5949ba5e
Add tests for neutral models
2024-06-04 11:46:01 +01:00
Owen Mansel-Chan
c964fc2dca
Update expected results (only empty predicate names added)
2024-06-04 11:46:00 +01:00
Owen Mansel-Chan
18fa454d33
Replace Argument[-1] with Argument[receiver]
2024-06-04 11:45:59 +01:00
Owen Mansel-Chan
0870946e05
Add model validation to more tests
2024-06-04 11:45:58 +01:00
Owen Mansel-Chan
a8112ec62e
Add neutralModel to empty.model.yml so it is defined somewhere
2024-06-04 11:45:57 +01:00
Owen Mansel-Chan
adfaae02e7
Cache interpretElement
2024-06-04 11:45:55 +01:00
Owen Mansel-Chan
479ea9f82c
Remove unused predicate hasExternalSpecification
2024-06-04 11:45:54 +01:00
Owen Mansel-Chan
174712a472
Delete unused predicate paramsString
...
This is needed for other languages, but in Go you cannot have two
functions which are distinguished only by their parameter types.
2024-06-04 11:45:52 +01:00
Owen Mansel-Chan
40127583fb
Make manual neutral summary models block generated summary models
2024-06-04 11:45:51 +01:00
Owen Mansel-Chan
5b04a71169
Non-trivial implementation of NeutralCallableAdapter
2024-06-04 11:45:49 +01:00
Owen Mansel-Chan
df8e04fcf9
Add predicate neutralElement matching summaryElement
2024-06-04 11:45:48 +01:00
Owen Mansel-Chan
209fe731a6
Change type of c to be more portable
2024-06-04 11:45:47 +01:00
Owen Mansel-Chan
e2008e14e2
Move summaryElement to FlowSummyImpl.qll
2024-06-04 11:45:45 +01:00
Owen Mansel-Chan
7f0f2d3438
Rename interpretSummary to summaryElement
2024-06-04 11:45:44 +01:00
Owen Mansel-Chan
961b09d63c
Use methods of AccessPathToken more
2024-06-04 11:45:42 +01:00
Owen Mansel-Chan
9f7c47509a
Expect "receiver" instead of "-1"
2024-06-04 11:45:41 +01:00
Owen Mansel-Chan
557adaf6f2
Update invalid model predicates
2024-06-04 11:45:40 +01:00
Owen Mansel-Chan
8e2e32742c
Use neutralModel in various places
2024-06-04 11:45:38 +01:00
Owen Mansel-Chan
83672f545f
Add neutralModel extensible predicate
2024-06-04 11:45:36 +01:00
Owen Mansel-Chan
a71e678bb9
Change imports
2024-06-04 11:45:33 +01:00
Owen Mansel-Chan
c3e1592815
Use AccessPath and AccessPathToken more
2024-06-04 11:45:27 +01:00
Owen Mansel-Chan
54a0c03e5d
Rename canonicalPackageHasASubpackage to canonicalPkgLink
2024-06-04 11:45:25 +01:00
Owen Mansel-Chan
e81a98925a
Remove QLDoc
2024-06-04 11:45:20 +01:00
Owen Mansel-Chan
797e5d0c8a
Rename packageHasASubpackage to packageLink
2024-06-04 11:45:17 +01:00
Owen Mansel-Chan
7c94120eb7
Rename packageHasMaDCoverage to relevantPackage
2024-06-04 11:45:13 +01:00
Owen Mansel-Chan
89e7bab0b3
QLDoc
2024-06-04 11:45:06 +01:00
Tony Torralba
78552b8bca
Merge pull request #16600 from atorralba/atorralba/java/more-file-sinks
...
Java: Add more File-related sinks to the path-injection query
2024-06-04 11:59:05 +02:00
Cornelius Riemenschneider
63116d2779
Merge pull request #16656 from github/criemen/pkg-javascript
...
Javascript: use `codeql_pack` for javascript extractor
2024-06-04 11:58:45 +02:00
Tamás Vajk
a1415e2b6d
Merge pull request #16661 from tamasvajk/buildless/nuget-path-space
...
C#: Quote packages.config paths
2024-06-04 11:53:55 +02:00
Geoffrey White
38c47a4b11
C++: Add change notes.
2024-06-04 10:47:25 +01:00
Tamás Vajk
c06df5552b
Merge pull request #16660 from tamasvajk/buildless/nuget-exe
...
C#: Prefer downloading nuget.exe over local instances
2024-06-04 11:25:03 +02:00
Geoffrey White
9c2b4c9446
C++: Update the doc examples for C/C++.
2024-06-04 10:21:06 +01:00
Geoffrey White
79e9198b20
C++: An empty models-as-data namespace / type is not 'dubious' in CPP.
2024-06-04 10:21:06 +01:00
Geoffrey White
f479649727
C++: Add Boost::Asio models.
2024-06-04 10:21:05 +01:00
Geoffrey White
7e5b7346c0
C++: Add flow test cases for Boost::Asio.
2024-06-04 10:21:05 +01:00
Geoffrey White
8a5b5d220a
C++: Add source/sink test cases for Boost::Asio.
2024-06-04 10:21:05 +01:00
Geoffrey White
af6a08893a
C++: Update the doc text for C/C++.
2024-06-04 10:20:59 +01:00
Jeroen Ketema
66077dc38d
C++: Ignore gets'es with incorrect parameter counts
2024-06-04 11:15:07 +02:00
Joe Farebrother
6ff7fb2a70
Add change note
2024-06-04 09:52:57 +01:00
Michael Nebel
a83d50062e
Merge pull request #16658 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-06-04 10:52:03 +02:00
Tamas Vajk
9af6cb8e4b
Quote packages.config paths
2024-06-04 10:47:00 +02:00
Joe Farebrother
9331c2c33a
Add tests
2024-06-04 09:39:37 +01:00
Tony Torralba
292395b80e
Update test expectations
2024-06-04 10:35:16 +02:00
Tony Torralba
f16dd8c010
Apply code review suggestions.
2024-06-04 10:35:11 +02:00
Tony Torralba
f84c2a842d
Java: Add more File-related sinks for path-injection
2024-06-04 10:35:07 +02:00
Tamas Vajk
2a62bfd0c2
C#: Add integration test with space in packages.config path
2024-06-04 10:33:03 +02:00
Rasmus Wriedt Larsen
839171e557
Merge pull request #16646 from RasmusWL/url-redirect-qhelp
...
Python: Update url-redirect qhelp with `https:/example.com` handling
2024-06-04 10:17:37 +02:00
Rasmus Wriedt Larsen
dd8b65130e
Merge pull request #16598 from jorgectf/jorgectf/opml-models
...
Python: Add models for `opml`
2024-06-04 10:16:26 +02:00
Tamas Vajk
f4d3756894
C#: Prefer downloading nuget.exe over local instances
2024-06-04 09:58:04 +02:00
Tom Hvitved
16e9cede3c
Merge pull request #16637 from hvitved/csharp/xml-validation-perf
...
C#: Improve performance of `MissingXMLValidation` query
2024-06-04 09:28:37 +02:00
Paolo Tranquilli
99f70a64e9
Kotlin: address review comments
2024-06-04 09:00:35 +02:00
Paolo Tranquilli
d1a2c0fbe4
Merge branch 'main' into redsun82/kotlin
2024-06-04 08:48:52 +02:00
Tom Hvitved
48455ec3c9
C#: Improve performance of MissingXMLValidation query
2024-06-04 08:35:53 +02:00
Tom Hvitved
e6dc36b2c4
Merge pull request #16636 from hvitved/tree-sitter/verbosity-fix
...
Tree-sitter: Verbosity fixes
2024-06-04 08:33:28 +02:00
Owen Mansel-Chan
133983678c
Merge pull request #16619 from owen-mc/go/fix/response-writer-variadic
...
Go: Fix bug in ResponseWriter for variadic MaD
2024-06-04 05:36:58 +01:00
github-actions[bot]
922489c8e8
Add changed framework coverage reports
2024-06-04 00:17:08 +00:00
Joe Farebrother
6ac46b8436
Add additional sanitizers to SSRF for methods that restrict the contents of a string.
2024-06-03 23:23:25 +01:00
Paolo Tranquilli
7b8c11379d
Javascript: use codeql_pack for javascript extractor
2024-06-03 23:14:44 +02:00
yoff
fe8f13e8dd
Merge pull request #16654 from sidshank/sidshank/fix-incorrect-deprecation-comment
...
Python: Fixes an error in the deprecation notice for a taint tracking configuration
2024-06-03 21:46:35 +02:00
Cornelius Riemenschneider
5b6f38f821
Merge pull request #16623 from github/criemen/new-pkg
...
Bazel: Use new packaging rules
2024-06-03 20:15:56 +02:00
Sid Shankar
859e8db5f2
Fixes typo in deprecation notice
2024-06-03 16:31:29 +00:00
Cornelius Riemenschneider
8783dfbaac
Merge branch 'main' into criemen/new-pkg
2024-06-03 18:15:45 +02:00
Ian Lynagh
b0865c2218
Merge pull request #16554 from igfoo/igfoo/k2rel
...
Kotlin: Accept Kotlin 2 test output, and use 2.0.0 on CI
2024-06-03 17:14:21 +01:00
Cornelius Riemenschneider
1bd7aef1b2
Fix search paths.
...
It turns out we still need to supply this option, so `codeql` goes looking
for the extractor paths specified in the `codeql-workspace.yml` file.
2024-06-03 16:33:17 +02:00
Ian Lynagh
986babb912
Kotlin: Accept 2.0 output for integration tests, and run some in 1.9 mode
2024-06-03 15:26:53 +01:00
Ian Lynagh
2bcf292dd6
Kotlin: Fix custom_plugin test with Kotlin 2.0.0
2024-06-03 15:26:53 +01:00
Ian Lynagh
acdf7df6a4
Kotlin: Fix typo
2024-06-03 15:26:53 +01:00
Ian Lynagh
839258897a
Kotlin: Add test for generated throw statements
2024-06-03 15:26:52 +01:00
Ian Lynagh
f458ca9568
Kotlin: Bump supported version limit to 2.0.0x
2024-06-03 15:26:52 +01:00
Ian Lynagh
2d760c7cc7
Kotlin: Tweak comments test
...
The top comment now gets owned by the Compilation Unit. We could
explicitly stop this from happening instead, but I think it's
reasonable.
2024-06-03 15:26:52 +01:00
Ian Lynagh
6224670884
Kotlin: Accept 2.0.0's Kotlin 2 test output
2024-06-03 15:26:51 +01:00
Ian Lynagh
918bee07dd
Kotlin: Accept Kotlin 1 test changes 1.9.0 -> 2.0.0
2024-06-03 15:26:51 +01:00
Ian Lynagh
2550e113a0
Kotlin: Set CI to use 2.0.0 release
2024-06-03 15:26:51 +01:00
Cornelius Riemenschneider
c30cc0f665
Fix formatting.
2024-06-03 16:10:41 +02:00
Cornelius Riemenschneider
b67309299f
C#: Unified handling of in-tree extractor packs.
2024-06-03 16:07:13 +02:00
Cornelius Riemenschneider
dd267e126c
Ql-for-ql: Unified handling of in-tree extractor packs.
2024-06-03 16:06:58 +02:00
Cornelius Riemenschneider
57f7602126
Go: Unified handling of in-tree extractor packs.
2024-06-03 16:06:44 +02:00
Cornelius Riemenschneider
5c77b8708c
Ruby: Unified handling of in-tree extractor packs.
2024-06-03 16:06:24 +02:00
Cornelius Riemenschneider
7b72018e56
Swift: Unified handling of in-tree extractor packs.
2024-06-03 16:06:08 +02:00
Cornelius Riemenschneider
04f5f30489
Unified handling of in-tree extractor packs.
2024-06-03 16:05:46 +02:00
Cornelius Riemenschneider
b9da01a384
Merge remote-tracking branch 'origin/main' into criemen/new-pkg
2024-06-03 15:47:15 +02:00
Cornelius Riemenschneider
5875ec272d
Merge pull request #16627 from github/criemen/pkg-fix-install
...
`pkg.bzl`: Fix install targets.
2024-06-03 15:31:43 +02:00
Geoffrey White
e87593af75
C++: Add the doc (copy from csharp).
2024-06-03 13:49:38 +01:00
Geoffrey White
94413c8c2e
C++: Implement YML extension models.
2024-06-03 13:49:38 +01:00
Geoffrey White
34130d50d3
C++: Add library tests for YML extension models.
2024-06-03 13:49:26 +01:00
Paolo Tranquilli
51b000a424
Merge pull request #16649 from github/redsun82/bazel-lfs
...
Bazel: ignore non-default SSH endpoints in `git_lfs_probe.py`
2024-06-03 13:31:43 +02:00
Paolo Tranquilli
8479673419
Bazel: ignore non-default SSH endpoints in git_lfs_probe.py
2024-06-03 12:26:37 +02:00
Cornelius Riemenschneider
a42bdd9bb0
Update misc/bazel/pkg.bzl
...
Co-authored-by: Paolo Tranquilli <redsun82@github.com >
2024-06-03 10:53:08 +02:00
Cornelius Riemenschneider
0173cf56f5
Merge pull request #16645 from github/criemen/cmake
...
Cmake generator: Remove space in argument.
2024-06-03 10:46:42 +02:00
Michael Nebel
546b260330
C#: Update expected test output and remove spurious result.
2024-06-03 10:40:13 +02:00
Michael Nebel
46f5b13854
C#: Only dispatch to summarized callables with generated summaries in case there are no source dispatch possibilities.
2024-06-03 10:40:10 +02:00
Michael Nebel
eb0925be60
C#: There should at least be one manual summary for a non-source summarized callable.
2024-06-03 10:40:06 +02:00
Michael Nebel
213e3918df
C#: Add some more external flow testcases (one with a spurious result).
2024-06-03 10:40:02 +02:00
Michael Nebel
b08a0a303f
C#: Re-factor external models tests to use compiled code instead of emulating it.
2024-06-03 10:39:59 +02:00
Michael Nebel
88b978f0ec
Merge pull request #16574 from michaelnebel/csharp/updatenetruntimemodels
...
C#: Re-generate .NET 8 Runtime models.
2024-06-03 10:33:10 +02:00
Rasmus Wriedt Larsen
121ca129bc
Update qhelp with https:/example.com handling
2024-06-03 10:17:10 +02:00
Cornelius Riemenschneider
cff78cca5e
Cmake generator: Remove space in argument.
...
This space breaks when upgrading bazelisk on Windows.
Somehow, a space inside the argument messes up some argument-parsin
somewhere. Porbably due to Windows argument parsing
being not well-defined in how it splits a string into argv.
Removing the space works around the problem.
If the space is included, cmake suddenly can't find the bazelisk
binary anymore, despite happily executing `info output_base` earlier.
2024-06-02 23:56:31 +02:00
Tom Hvitved
58ce3e805e
Merge pull request #16633 from hvitved/dataflow/inline-pred
...
Data flow: Inline `isUnreachableInCall1`
2024-05-31 20:12:14 +02:00
Tom Hvitved
beeae69845
Tree-sitter: Verbosity fixes
2024-05-31 20:10:19 +02:00
Chuan-kai Lin
8d5bb21643
Merge pull request #16642 from github/post-release-prep/codeql-cli-2.17.4
...
Post-release preparation for codeql-cli-2.17.4
2024-05-31 09:08:03 -07:00
Alex Ford
1100b75a3c
Ruby: handle routes with path/action pairs
2024-05-31 15:54:57 +01:00
github-actions[bot]
a19149032f
Post-release preparation for codeql-cli-2.17.4
2024-05-31 14:49:11 +00:00
Paolo Tranquilli
58fb0270fb
Merge pull request #16641 from github/redsun82/legacy-integration-test-marker
...
Mark all integration tests as legacy
2024-05-31 16:18:00 +02:00
Alex Ford
0473655752
Ruby: actiondispatch add hash arg testcase
2024-05-31 15:08:35 +01:00
Alex Ford
22858249f9
Ruby: actiondispatch test whitespace changes
2024-05-31 15:07:39 +01:00
Paolo Tranquilli
096a31dbef
Mark all integration tests as legacy
...
This is in preparation for the new integration test framework. Tests
marked thus will be run by the current framework and ignored by the new
one.
2024-05-31 16:04:50 +02:00
Alex Ford
4644f08195
Ruby: Routing.qll - rename call as methodCall
2024-05-31 14:45:32 +01:00
Alex Ford
25f9449f53
Ruby: Routing.qll - rename method as httpMethod
2024-05-31 14:45:26 +01:00
Alex Ford
af9ed21c36
Ruby: Routing.qll - rename method as methodCall
2024-05-31 14:45:20 +01:00
Chuan-kai Lin
a7bbcf3eb8
Merge pull request #16640 from github/release-prep/2.17.4
...
Release preparation for version 2.17.4
2024-05-31 06:43:37 -07:00
github-actions[bot]
a22e70373a
Release preparation for version 2.17.4
2024-05-31 13:40:51 +00:00
Anders Schack-Mulligen
06ce40c687
Merge pull request #16561 from aschackmull/java/typeflow-effectively-private
...
Java: Improve dispatch through TypeFlow of effectively private calls.
2024-05-31 15:11:18 +02:00
Michael Nebel
e2758f2abb
C#: Update expected test output.
2024-05-31 15:06:16 +02:00
Owen Mansel-Chan
ca2faa7ef0
Merge pull request #16624 from owen-mc/go/append-taint-models
...
Go: Add back taint models for `append` and `copy`
2024-05-31 13:35:14 +01:00
Paolo Tranquilli
01c1acd43f
Merge pull request #16632 from github/redsun82/bazel-fix
...
Bazel: fix non-swift macOS builds
2024-05-31 14:33:55 +02:00
Michael Nebel
d38894a5e5
C#: Update .NET 8 runtime models.
2024-05-31 14:19:48 +02:00
Paolo Tranquilli
25ab1a934d
Merge branch 'main' into redsun82/bazel-fix
2024-05-31 14:03:20 +02:00
Paolo Tranquilli
67e2ea195f
Merge pull request #16634 from github/redsun82/swift-integration-tests
...
Swift: remove integration test running in CI
2024-05-31 13:55:14 +02:00
Cornelius Riemenschneider
f27d48d03d
Merge pull request #16622 from github/criemen/pkg-lib-nolang
...
`pkg.bzl`: Add features to support the nolang dist.
2024-05-31 13:15:23 +02:00
Paolo Tranquilli
959aa3515c
Swift: remove integration test running in CI
...
They are being triggered by QLucie now, so there's no need to also
trigger them in the `codeql` specific CI.
2024-05-31 12:59:38 +02:00
Michael Nebel
8b75bb2ba9
C#: The model generator should consider System.Type and System.DateTime as sanitizers.
2024-05-31 12:50:18 +02:00
Michael Nebel
02f9aec517
C#: Add some spurious summary generation examples.
2024-05-31 12:50:14 +02:00
Michael Nebel
b628c2e121
C#: Update flow summaries expected output.
2024-05-31 12:50:10 +02:00
Michael Nebel
5e1801f7be
C#: Update models based on review comments.
2024-05-31 12:50:06 +02:00
Michael Nebel
121378a262
C#: Add change-note.
2024-05-31 12:50:02 +02:00
Michael Nebel
0985a3a5f6
C#: Update expected test output.
2024-05-31 12:49:58 +02:00
Michael Nebel
9bb7575018
C#: Promote IDataRecord and IDbCommand to manual summaries such that they are used in conjunction with source code.
2024-05-31 12:49:53 +02:00
Michael Nebel
90538d4b4c
C#: Update expected test output.
2024-05-31 12:49:48 +02:00
Michael Nebel
cd5168b570
C#: Limit the defintion of database flow source and use summaries for better paths and reduced result multiplicity.
2024-05-31 12:49:44 +02:00
Michael Nebel
38d246a3bd
C#: Update flowsummaries expected output.
2024-05-31 12:49:40 +02:00
Michael Nebel
db0131d931
C#: Update .NET8 models.
2024-05-31 12:49:35 +02:00
Tom Hvitved
be4fce26c0
Merge pull request #16631 from hvitved/tree-sitter/multi-file-lists
...
Tree-sitter: Allow for multiple file lists in simple extractor
2024-05-31 12:47:11 +02:00
Paolo Tranquilli
bfc37fddff
Bazel: move --build_tests_only from swift action to .bazelrc
2024-05-31 12:35:52 +02:00
Cornelius Riemenschneider
14988002fa
Address review.
2024-05-31 12:35:03 +02:00
Tom Hvitved
42d87f6d19
Data flow: Inline isUnreachableInCall1
2024-05-31 12:25:11 +02:00
Paolo Tranquilli
3f19974bb6
Bazel: fix transition on non-macOS
2024-05-31 12:14:13 +02:00
Paolo Tranquilli
b3e29bd8b5
Bazel: add --build_tests_only in swift CI
2024-05-31 12:13:26 +02:00
Paolo Tranquilli
07f4288e1f
Fix zipmerge build and test
2024-05-31 12:12:58 +02:00
Paolo Tranquilli
8e26f64f89
Bazel: fix non-swift macOS builds
...
This is meant to be cleaned up in a later PR with respect to the TODOs.
2024-05-31 11:49:36 +02:00
Tom Hvitved
d6a3765597
Tree-sitter: Allow for multiple file lists in simple extractor
2024-05-31 11:15:21 +02:00
Tony Torralba
2d3d49f957
Merge pull request #16628 from mbaluda/main
...
Disable csrf for ServerHttpSecurity
2024-05-31 10:31:28 +02:00
Mauro Baluda
48fc44baff
Add release notes
2024-05-30 23:21:12 +02:00
Mauro Baluda
bbe888c2b3
Update SpringCsrfProtection.qll
2024-05-30 23:13:08 +02:00
Mauro Baluda
e2479a7ce2
Disable csrf for ServerHttpSecurity
2024-05-30 23:08:57 +02:00
Owen Mansel-Chan
d112073a13
Edit change note
2024-05-30 21:04:05 +01:00
Owen Mansel-Chan
ffc25add70
Accept test changes
2024-05-30 21:01:06 +01:00
Owen Mansel-Chan
a5c392ed4b
Add back taint models for append and copy
...
This is needed when they are used with string arguments.
2024-05-30 21:01:03 +01:00
Cornelius Riemenschneider
e2cb5631d9
pkg.bzl: Fix install targets.
...
First, the labels used in this file need to be wrapped in `Label`,
so that we can use the installer target from the internal repo.
Second, when unpacking zips, the path passed to `ripunzip` included a trailing
`\n`, which caused `ripunzip` to fail.
2024-05-30 21:06:46 +02:00
Chuan-kai Lin
0369f8f5df
Merge pull request #16625 from github/revert-16605-release-prep/2.17.4
...
Revert "Release preparation for version 2.17.4"
2024-05-30 10:08:31 -07:00
Chuan-kai Lin
b41835a7d9
Revert "Release preparation for version 2.17.4"
2024-05-30 09:25:15 -07:00
Cornelius Riemenschneider
e43b773d7c
Fix comment to indicate the correct order in the zip dict.
2024-05-30 17:58:22 +02:00
Cornelius Riemenschneider
60cb8e7e8e
Ruby: Move to new packaging rules.
2024-05-30 14:25:20 +02:00
Cornelius Riemenschneider
1158e92f12
Python: Move to the new packaging rules.
2024-05-30 14:25:18 +02:00
Cornelius Riemenschneider
dcd44859f5
Go: Move to new packaging rules.
2024-05-30 14:25:17 +02:00
Cornelius Riemenschneider
d66d7d8a3a
C#: Move to new packaging rules.
2024-05-30 14:25:16 +02:00
Cornelius Riemenschneider
60b5317c5f
C++: Move to new packaging rules.
2024-05-30 14:25:15 +02:00
Cornelius Riemenschneider
9f3310d3d2
pkg.bzl: Add features to support the nolang dist.
...
In order to build the language-independent parts of our dist with `pkg.bzl`,
we need two override features:
* A way to set the prefix in the zip files to the empty string, so that our top-level files
stay top-level.
* A way to put `codeql.exe` into the arch-specific zip, despite it not being under `CODEQL_PLATFORM`.
This PR implements both.
2024-05-30 13:03:57 +02:00
Owen Mansel-Chan
61593aed7d
Merge pull request #16617 from owen-mc/go/side-effects-on-global-variables
...
Go: Add tests (mostly failing) for writes to global variables
2024-05-30 08:02:45 +01:00
Cornelius Riemenschneider
2c4a216dd9
Merge pull request #16616 from github/redsun82/fix-pkg
...
Reinstate bazel packaging library with a backward compatibility fix
2024-05-29 23:02:30 +02:00
Owen Mansel-Chan
1d9a98614a
Fix bug in ResponseWriter for variadic MaD
...
`getSummaryInputOrOutputNode` was giving the summary component stack for
arguments corresponding to variadic parameters. This will be a problem
when the models for variadic functions are converted to models-as-data.
2024-05-29 21:15:49 +01:00
Owen Mansel-Chan
7ff1eabfc3
Add tests (mostly failing) for writes to global variables
...
This was based on the equivalent for java:
https://github.com/github/codeql/pull/16500
2024-05-29 16:07:16 +01:00
am0o0
1f112467ce
update id of the query file
2024-05-29 16:48:35 +02:00
am0o0
b9edcb7943
rename secondary to remote :), complete the previous commit changes
2024-05-29 16:47:37 +02:00
am0o0
52a809145e
SecondaryCommandInjection to RemoteCommandExecution, change RemoteCommandExecution to module like SystemCommandExecution module
2024-05-29 16:18:55 +02:00
Paolo Tranquilli
655f079329
Swift: fix legacy extractor-pack-arch target
2024-05-29 16:17:59 +02:00
am0o0
fd9e6f48d7
fix the docs of secondary server cmd injection
2024-05-29 16:01:43 +02:00
am0o0
171486641e
Ssh2.qll: fix a typo
2024-05-29 16:00:52 +02:00
am0o0
5299c4a845
fix the qhelp of secondary server cmd injectino
2024-05-29 16:00:06 +02:00
Paolo Tranquilli
2606d3f6d1
Reapply "Bazel: add codeql specific packaging library"
...
This reverts commit 31d6b9be4d .
2024-05-29 15:46:29 +02:00
am0o0
66cba89fdb
Torch.qll: use better alternative instead of exists
2024-05-29 15:43:41 +02:00
am0o0
8c3994bc9c
Paramiko.qll: improve docs
2024-05-29 15:42:29 +02:00
am0o0
b1242e464e
Pandas.qll: remove unnecessary exists, fix class naming
2024-05-29 15:41:45 +02:00
Paolo Tranquilli
8509bcae58
Merge pull request #16615 from github/revert-16432-redsun82/pkg
...
Revert "Bazel: add codeql specific packaging library"
2024-05-29 15:39:23 +02:00
am0o0
fcd2bd6776
fabic.qll: remove test predicate and apply review changes
2024-05-29 15:37:11 +02:00
Paolo Tranquilli
31d6b9be4d
Revert "Bazel: add codeql specific packaging library"
2024-05-29 15:27:10 +02:00
Paolo Tranquilli
3b246b2422
Merge pull request #16432 from github/redsun82/pkg
...
Bazel: add codeql specific packaging library
2024-05-29 12:58:47 +02:00
Paolo Tranquilli
1e6820b6ed
Merge branch 'main' into redsun82/pkg
2024-05-29 12:02:31 +02:00
Paolo Tranquilli
336ec089cc
Bazel: use extend(...) instead of += list(...)
2024-05-29 12:02:02 +02:00
Paolo Tranquilli
e8061ecd38
Bazel: fix _zipmerge rule
2024-05-29 11:59:18 +02:00
Tom Hvitved
775625968a
Merge pull request #16602 from hvitved/dataflow/fix-bad-join
...
Data flow: Fix bad join
2024-05-29 09:53:56 +02:00
Paolo Tranquilli
5672ddf8f3
Fix bazel formatting
2024-05-29 09:53:31 +02:00
Anders Schack-Mulligen
2f95851537
Merge pull request #16603 from aschackmull/dataflow/location
...
Dataflow/Go: Add getLocation to DataFlowCall and DataFlowCallable for easier debugging.
2024-05-29 08:58:22 +02:00
Paolo Tranquilli
491e3a44be
Merge branch 'main' into redsun82/pkg
2024-05-29 08:55:48 +02:00
Paolo Tranquilli
fbe1b56f2d
Zipmerge: link test statically
2024-05-29 08:55:06 +02:00
Chuan-kai Lin
06fd16bbf5
Merge pull request #16607 from github/post-release-prep/codeql-cli-2.17.4
...
Post-release preparation for codeql-cli-2.17.4
2024-05-28 14:56:43 -07:00
github-actions[bot]
906b65d09c
Post-release preparation for codeql-cli-2.17.4
2024-05-28 18:02:25 +00:00
Tom Hvitved
059ce1ba15
Data flow: Fix bad join
...
Before
```
Evaluated relational algebra for predicate _DataFlowImpl::Impl<ExceptionInformationExposure::ExceptionInformationExposure::C>::AccessPathApprox__#count_range@9acc2d7t with tuple counts:
875 ~0% {3} r1 = SCAN `num#DataFlowImpl::Impl<ExceptionInformationExposure::ExceptionInformationExposure::C>::TCons1#055add5f` OUTPUT _, In.0, In.1
875 ~0% {3} | REWRITE WITH Tmp.0 := 1, Out.0 := (InOut.2 - Tmp.0)
113896125 ~1% {3} | JOIN WITH `DataFlowImpl::Impl<ExceptionInformationExposure::ExceptionInformationExposure::C>::AccessPathApprox.len/0#dispred#e932df4d_10#join_rhs` ON FIRST 1 OUTPUT Rhs.1, Lhs.1, Lhs.2
113896125 ~7% {4} | JOIN WITH `DataFlowImpl::Impl<ExceptionInformationExposure::ExceptionInformationExposure::C>::AccessPathApprox.getFront/0#dispred#5d402e21` ON FIRST 1 OUTPUT Lhs.1, Lhs.0, Lhs.2, Rhs.1
2404 ~9% {5} | JOIN WITH `DataFlowImpl::Impl<ExceptionInformationExposure::ExceptionInformationExposure::C>::Stage5::consCand/3#cd06ec82_021#join_rhs` ON FIRST 2 OUTPUT Lhs.2, Lhs.0, Rhs.2, Lhs.3, _
2404 ~14% {5} | REWRITE WITH Out.4 := 1
return r1
Evaluated relational algebra for predicate DataFlowImpl::Impl<ExceptionInformationExposure::ExceptionInformationExposure::C>::count1to2unfold/1#9ad56f09@c47f87cq with tuple counts:
365 ~0% {2} r1 = JOIN `num#DataFlowImpl::Impl<ExceptionInformationExposure::ExceptionInformationExposure::C>::TCons1#055add5f_102#join_rhs` WITH `__DataFlowImpl::Impl<ExceptionInformationExposure::ExceptionInformationExposure::C>::AccessPathAppro__#join_rhs` ON FIRST 2 OUTPUT Lhs.2, Rhs.2
return r1
```
After
```
Evaluated relational algebra for predicate DataFlowImpl::Impl<ExceptionInformationExposure::ExceptionInformationExposure::C>::stage5ConsCand/4#ce755854@46e7620j with tuple counts:
848899 ~5% {3} r1 = SCAN `DataFlowImpl::Impl<ExceptionInformationExposure::ExceptionInformationExposure::C>::AccessPathApprox.len/0#dispred#e932df4d` OUTPUT In.0, _, In.1
848899 ~0% {2} | REWRITE WITH Tmp.1 := 1, Out.1 := (Tmp.1 + In.2) KEEPING 2
848899 ~0% {3} | JOIN WITH `DataFlowImpl::Impl<ExceptionInformationExposure::ExceptionInformationExposure::C>::AccessPathApprox.getFront/0#dispred#5d402e21` ON FIRST 1 OUTPUT Lhs.0, Lhs.1, Rhs.1
12961 ~14% {4} | JOIN WITH `DataFlowImpl::Impl<ExceptionInformationExposure::ExceptionInformationExposure::C>::Stage5::consCand/3#cd06ec82_201#join_rhs` ON FIRST 1 OUTPUT Rhs.1, Rhs.2, Lhs.2, Lhs.1
return r1
Evaluated relational algebra for predicate DataFlowImpl::Impl<ExceptionInformationExposure::ExceptionInformationExposure::C>::stage5ConsCand/4#ce755854_0312_1#count_range@a0e570ci with tuple counts:
11548 ~1% {5} r1 = SCAN `DataFlowImpl::Impl<ExceptionInformationExposure::ExceptionInformationExposure::C>::stage5ConsCand/4#ce755854` OUTPUT In.0, In.3, In.1, In.2, _
11548 ~3% {5} | REWRITE WITH Out.4 := 1
return r1
Evaluated relational algebra for predicate DataFlowImpl::Impl<ExceptionInformationExposure::ExceptionInformationExposure::C>::count1to2unfold/1#9ad56f09@e0e6143p with tuple counts:
3981 ~0% {3} r1 = AGGREGATE `DataFlowImpl::Impl<ExceptionInformationExposure::ExceptionInformationExposure::C>::stage5ConsCand/4#ce755854_0312_1#count_range`, `DataFlowImpl::Impl<ExceptionInformationExposure::ExceptionInformationExposure::C>::stage5ConsCand/4#ce755854_0312_1#count_range` ON WITH COUNT OUTPUT In.0, In.1, Agg.0
365 ~0% {2} | JOIN WITH `num#DataFlowImpl::Impl<ExceptionInformationExposure::ExceptionInformationExposure::C>::TCons1#055add5f` ON FIRST 2 OUTPUT Rhs.2, Lhs.2
return r1
```
2024-05-28 19:59:30 +02:00
Chuan-kai Lin
dc0db9a6c6
Merge pull request #16605 from github/release-prep/2.17.4
...
Release preparation for version 2.17.4
2024-05-28 08:57:38 -07:00
github-actions[bot]
33b4ae8bbb
Release preparation for version 2.17.4
2024-05-28 15:44:32 +00:00
Paolo Tranquilli
332d178298
Zipmerge: allow test to be run from internal repo
2024-05-28 17:37:34 +02:00
Paolo Tranquilli
4094db40b8
Merge branch 'main' into redsun82/pkg
2024-05-28 17:28:24 +02:00
Paolo Tranquilli
45f1fdfaff
Bazel: extract pack filtering logic out of _zipmerge
2024-05-28 17:24:20 +02:00
Pierre
06d6671c55
Merge pull request #16569 from github/sitedocs/2.17.3
...
Add changelogs for 2.17.2 and 2.17.3
2024-05-28 08:15:04 -07:00
Paolo Tranquilli
de484773f0
Zipmerge: print test outputs on CI
2024-05-28 16:29:41 +02:00
Paolo Tranquilli
2a62455822
Merge branch 'main' into redsun82/pkg
2024-05-28 16:15:48 +02:00
Paolo Tranquilli
5eb12b8503
Zipmerge: substitute stripped down slf4j jars with dummy ones
2024-05-28 16:15:20 +02:00
Michael Nebel
195ccb0018
Merge pull request #16484 from michaelnebel/csharp/superimplmodelgen
...
C#: Lift models.
2024-05-28 15:49:35 +02:00
Paolo Tranquilli
c3ccf4d5a3
Zipmerge: substitute CPython archives with dummy ones
2024-05-28 15:47:24 +02:00
Paolo Tranquilli
67d622fa9d
Bazel: actually run the zipmerge tests
2024-05-28 15:44:53 +02:00
Paolo Tranquilli
9c1efb9f0e
Bazel: expose compression_level in codeql_pack
2024-05-28 15:09:15 +02:00
Paolo Tranquilli
00ed00e1e5
Bazel: avoid unneeded operations if no imported zips are present
2024-05-28 15:01:35 +02:00
Paolo Tranquilli
e2206e62d6
Bazel: restrict codeql_pack zips to .zip files
2024-05-28 14:39:20 +02:00
Paolo Tranquilli
6b971617e7
Bazel: rename _process_path to _expand_path, and make its use clearer
2024-05-28 14:17:05 +02:00
Paolo Tranquilli
76fbb522d2
Bazel: use pack name for zip file name
2024-05-28 14:10:31 +02:00
Anders Schack-Mulligen
3b12f69dd9
Dataflow/Go: Add getLocation to calls and callables for easier debugging.
2024-05-28 13:47:08 +02:00
Michael Nebel
5a25967019
C#: Address review comments.
2024-05-28 13:38:23 +02:00
Paolo Tranquilli
6d798410ce
Bazel: add --no-cleanup to installer script
2024-05-28 12:51:52 +02:00
Paolo Tranquilli
a8543d4a88
Zipmerge: port tests from internal repo
2024-05-28 12:01:57 +02:00
Paolo Tranquilli
afadc1f1eb
Merge branch 'main' into redsun82/pkg
2024-05-28 11:21:19 +02:00
Paolo Tranquilli
f7bfe435c8
Swift: fix windows build again
2024-05-28 11:20:32 +02:00
Joe Farebrother
4c97b0c785
Merge pull request #16529 from joefarebrother/python-flask-session-interface
...
Python: Model Flask SessionInterface request parameter
2024-05-28 10:03:13 +01:00
Paolo Tranquilli
fe9a153f44
Merge branch 'main' into redsun82/pkg
2024-05-28 10:07:28 +02:00
Jeroen Ketema
174f212d4e
Merge pull request #16589 from rvermeulen/rvermeulen/update-nospaceforzeroterminator-qlhelp
...
Rewrite recommendations for the query `cpp/no-space-for-terminator`
2024-05-28 09:52:20 +02:00
Paolo Tranquilli
fbf3b9ae7a
Merge branch 'main' into redsun82/pkg
2024-05-27 18:16:39 +02:00
Paolo Tranquilli
392ef09d19
Zipmerge: make lib public for internal testing
2024-05-27 17:28:33 +02:00
Paolo Tranquilli
cde71a915b
Bazel: address review comments
2024-05-27 17:00:39 +02:00
Paolo Tranquilli
2f95944244
Bazel: add documentation to install.py
2024-05-27 16:58:58 +02:00
Paolo Tranquilli
2f53c0e640
Bazel: fix codeql_pack installation on Windows
2024-05-27 16:09:42 +02:00
Paolo Tranquilli
6bbad22672
Codegen: make codegen work on windows
2024-05-27 16:05:38 +02:00
Jeroen Ketema
c936f964d3
Merge pull request #16599 from jketema/padding
...
C++: Make the padding test independent of the `predefined_macros` file
2024-05-27 15:36:06 +02:00
Tom Hvitved
69fb2bb97c
Merge pull request #16597 from hvitved/tree-sitter/empty-location
...
Tree-sitter: Emit `empty_location` relation to avoid scan
2024-05-27 15:19:15 +02:00
Jeroen Ketema
c57c027f70
C++: Make the padding test independent of the predefined_macros file
...
The padding test is the only test that currently depends on the contents
of the `predefined_macros` flile that we ship with CodeQL for use with the
CodeQL tests. Explicitly specifying `__x86_64` makes the test independent of
the contents of the file.
2024-05-27 14:21:10 +02:00
Anders Schack-Mulligen
d88c498d49
Merge pull request #16456 from aschackmull/dataflow/callcontext-grouping
...
Dataflow: Implement call context grouping to improve performance
2024-05-27 14:11:11 +02:00
Paolo Tranquilli
821bd1f27b
Merge branch 'main' into redsun82/kotlin
2024-05-27 13:17:06 +02:00
Paolo Tranquilli
2bec696114
Merge branch 'main' into redsun82/pkg
2024-05-27 13:13:12 +02:00
Cornelius Riemenschneider
bd6e233b66
Merge pull request #16519 from github/criemen/bazel-csharp
...
Bazel-build for C# language pack
2024-05-27 12:08:21 +02:00
Paolo Tranquilli
1e7b3d0f6f
Merge pull request #16588 from github/redsun82/ripunzip
...
Add ripunzip build workflow
2024-05-27 12:05:34 +02:00
Cornelius Riemenschneider
735bea624a
Place the C++ autobuilder in the correct path.
2024-05-27 11:55:14 +02:00
Jorge
b786ea7e5f
Add change note
2024-05-27 09:48:56 +00:00
Jorge
34230369bc
Add OPML module to frameworks imports
2024-05-27 09:48:49 +00:00
Jorge
e992d86d38
Add OPML models
2024-05-27 09:48:10 +00:00
Anders Schack-Mulligen
51c48c767e
Dataflow: Address review comments (take 2).
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
4ff37cc7b6
Dataflow: Address review comments.
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
8085460e4a
C++/Shared: Fix join order issues.
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
5c635e982e
C++/C#/Java: Update expected output.
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
1432519cc2
Dataflow: Add totalorder predicates to all languages.
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
5a259843bb
Dataflow: Switch call context to a set representation.
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
972b81bbd1
Util: Allow best-effort total orders with a reasonable fallback.
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
b83416f3a1
Dataflow: Make two predicates private.
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
52a232e91c
Dataflow: Make CallContext type private to DataFlowImplCommon.
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
947c2bf722
Dataflow: Move two declarations.
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
1dd1f12919
Dataflow: Move Level1CallContext to DataFlowImplCommon
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
e1e6cd9b3d
Dataflow: Simplify: remove Level1CallContextInput module
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
f6eb82ee15
Dataflow: Simplify.
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
5ac96d009a
Dataflow: Move viableImplNotCallContextReducedReverse to DataFlowImplCommon::CallContextSensitivity.
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
740bb84423
Dataflow: Rename prunedViableImplInCallContextReverse to viableImplCallContextReducedReverse.
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
0561c65b61
Dataflow: Rename noPrunedViableImplInCallContext to viableImplNotCallContextReduced.
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
aa87243e3a
Dataflow: Rename prunedViableImplInCallContext to viableImplCallContextReduced
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
ace369faa8
Dataflow: Share getCallContextCall in DataFlowImplCommon::CallContextSensitivity.
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
b2e3d784f6
Dataflow: Share getCallContextReturn in DataFlowImplCommon::CallContextSensitivity.
2024-05-27 11:01:52 +02:00
Anders Schack-Mulligen
79b1cd7d3d
Dataflow: Refactor getLocalCc to avoid reference to NodeEx.
2024-05-27 11:01:51 +02:00
Anders Schack-Mulligen
eb0b92350a
Dataflow: Switch column order in viableImplCallContextReducedReverse.
2024-05-27 11:01:51 +02:00
Anders Schack-Mulligen
86e6d0b1e1
Dataflow: Switch local call contexts to use canonical representative.
2024-05-27 11:01:51 +02:00
Anders Schack-Mulligen
012e1b498d
Dataflow: Remove duplicate definitions
2024-05-27 11:01:51 +02:00
Anders Schack-Mulligen
bc8ca1af86
Dataflow: Introduce NodeRegions for use in isUnreachableInCall.
2024-05-27 11:01:51 +02:00
Anders Schack-Mulligen
486eaad566
Shared: Add MakeSets module.
2024-05-27 11:01:51 +02:00
Paolo Tranquilli
f9674d1b3a
Update .github/workflows/build-ripunzip.yml
...
Co-authored-by: Cornelius Riemenschneider <cornelius@github.com >
2024-05-27 11:01:05 +02:00
Paolo Tranquilli
546d644765
Swift: do not use codeql_pkg_files needlessly
2024-05-27 10:46:50 +02:00
Tom Hvitved
686879a2a3
Ruby: Add up/downgrade scripts
2024-05-27 10:39:22 +02:00
Tom Hvitved
94d2e9591d
Tree-sitter: Emit empty_location relation to avoid scan
2024-05-27 10:39:21 +02:00
Cornelius Riemenschneider
44f666c90a
Merge pull request #16585 from github/criemen/ruby-codeql-extractor-hack
...
Ruby: Change how we pull in `shared/tree-sitter-extractor` dependency
2024-05-27 10:32:16 +02:00
Paolo Tranquilli
0b7a4257d7
Bazel: use {CODEQL_PLATFORM} as discriminant between arch and generic contents
2024-05-27 10:31:19 +02:00
am0o0
2b929c4d2d
remove old expected test file
2024-05-25 20:45:34 +02:00
am0o0
1fc481ce81
v2: it is basically the first stable version :))
2024-05-25 20:43:36 +02:00
am0o0
ea05b297a3
update expected test files
2024-05-25 19:40:37 +02:00
am0o0
14daf58767
update tests, add test cases for query with local sources
2024-05-25 18:17:56 +02:00
am0o0
8fde8c2db4
change test dir name
2024-05-25 13:54:31 +02:00
am0o0
b397f57357
change queries id according to new naming
2024-05-25 13:53:33 +02:00
am0o0
300c82a8ff
use Verification instead of validation in files name
2024-05-25 13:52:32 +02:00
am0o0
76beffb04a
change dir name
2024-05-25 13:49:34 +02:00
am0o0
f1533f40b6
change query files name
2024-05-25 13:49:01 +02:00
am0o0
d2d945c66d
merge all JWT pkgs into one
2024-05-25 13:47:43 +02:00
am0o0
4af4040bd6
change duplicate query IDs
2024-05-25 13:29:16 +02:00
am0o0
f905ac10c4
add jsonWebToken library file to remove duplicate predicate declrations
2024-05-25 13:28:13 +02:00
Remco Vermeulen
6df4c8964b
Rewrite recommendations
...
- Replace segmentation fault with crash that is platform agnostic (I think segmentation fault is not really a thing on Windows).
- Replace security vulnerability with malicious code execution. This provides a range of issues, because a crash (previously segmentation fault) could also be considered a security vulnerability. Namely a DOS.
- Removed the additional note on stack allocated arrays which seem confusing because we are always talking about buffers allocated on the heap.
2024-05-24 16:10:42 -07:00
Cornelius Riemenschneider
d30ed54bfd
Merge branch 'main' into criemen/bazel-csharp
2024-05-24 18:02:20 +02:00
Paolo Tranquilli
5d4b61c365
Bazel: replace prebuilt ripunzip from workflow
2024-05-24 17:44:39 +02:00
Paolo Tranquilli
8d5fa9583e
Add ripunzip build workflow
2024-05-24 17:37:59 +02:00
Cornelius Riemenschneider
b09f3c1c0d
Don't build with cross any longer.
...
We've removed cross from the internal build when converting to bazel,
mirror that here.
2024-05-24 16:17:37 +02:00
Paolo Tranquilli
b9064c5446
Bazel: fail install on ripunzip failing
2024-05-24 15:50:16 +02:00
Cornelius Riemenschneider
8c46b61e85
Ruby: Change how we pull in shared/tree-sitter-extractor dependency
...
Previously, we pulled in the shared tree-sitter extractor via a `git`
dependency in `Cargo.toml` to address a `rules_rust` limitation (no `path`
dependencies outside of the cargo workspace)). This was a problem,
as that means we're cloning `github/codeql` _again_ for the build, which is
quite slow.
I found another way that is faster, and still produces correct builds
for both `cargo`` and `rules_rust`:
* Cargo depends on a fake crate that has the same dependencies as the real crate (thanks to `sync-files.py`). Therefore, cargo pulls in the right dependencies into the lockfile, which bazel targets
* For local builds, we override the path to that dependency in a cargo config, so we're pulling in the correct code
* rules_rust only uses `path` dependencies for collecting transitive dependencies, it never pulls in the code from there. So far that, we manually provide a `BUILD.bazel` file for the shared extractor, and depend on that.
2024-05-24 15:37:35 +02:00
Cornelius Riemenschneider
5fa1b57aaa
Merge pull request #16586 from hvitved/rust-bump
...
Python: Use Rust 1.74
2024-05-24 15:30:15 +02:00
Paolo Tranquilli
f35f077c76
Swift: cleanup tools scripts in pack
2024-05-24 15:24:15 +02:00
Paolo Tranquilli
e990d75a8f
Bazel: use codeql platform as arch zip filename
2024-05-24 15:23:51 +02:00
Paolo Tranquilli
ea01ae6534
Swift: fix integration test log upload
2024-05-24 14:29:22 +02:00
Paolo Tranquilli
fa2c626e49
Bazel: add fat macOS ripunzip binary
2024-05-24 14:29:02 +02:00
Paolo Tranquilli
dcbf42d29c
Bazel: reorganize LFS files and add licensing information
2024-05-24 14:26:22 +02:00
Tom Hvitved
386bc1eb03
Bazel: repin
2024-05-24 13:53:55 +02:00
Tom Hvitved
7490472772
Update Python to use Rust 1.74
2024-05-24 13:05:39 +02:00
Michael Nebel
c59c7cf02a
C#: Use manual sink callables as exclusion for extrapolated sinks.
2024-05-24 12:50:48 +02:00
Michael Nebel
d272d6a9ca
C#: Assume that models should apply when a method is overridable except for the implicit methods on Object and ValueType.
2024-05-24 12:50:48 +02:00
Michael Nebel
ad55744877
C#: Add model generator test case for property.
2024-05-24 12:50:48 +02:00
Michael Nebel
057a420833
C#: Update expected test output.
2024-05-24 12:50:48 +02:00
Michael Nebel
a8feda2e2b
C#: Introduce lifting of callables in the model generator.
2024-05-24 12:50:48 +02:00
Michael Nebel
0d397cea9f
C#: Add some model generator tests related to lifting.
2024-05-24 12:50:48 +02:00
Michael Nebel
3ad29d843d
C#: Re-factor model generator specific to align with Java.
2024-05-24 12:50:48 +02:00
Michael Nebel
95473c06fc
Merge pull request #16520 from michaelnebel/csharp/fixsummarizedcallabledataflow
...
C#: Make the flow summary filtering in the adapter.
2024-05-24 12:48:03 +02:00
Paolo Tranquilli
e694968012
Fix change to .gitattributes done by mistake
2024-05-24 12:41:32 +02:00
Paolo Tranquilli
175f0dbb00
Swift: remove broken obsolete alias
2024-05-24 12:40:29 +02:00
Paolo Tranquilli
94d6feffed
Swift: fix module
2024-05-24 12:35:41 +02:00
Paolo Tranquilli
8e132e90cc
Bazel: add executable attribute to lfs_files
2024-05-24 12:35:17 +02:00
Paolo Tranquilli
1529b58089
Swift: add resource dir updater
2024-05-24 12:19:06 +02:00
Paolo Tranquilli
e8b857b79e
Bazel/Swift: add zip imports to packs
2024-05-24 12:18:42 +02:00
Tom Hvitved
0dbce3d077
Merge pull request #16451 from hvitved/treesitter/codeql-verbosity
...
Tree-sitter: Respect verbosity defined in `CODEQL_VERBOSITY`
2024-05-24 11:24:01 +02:00
Paolo Tranquilli
4d93e8a732
Bazel: move codeql packaging rules away from some macros
2024-05-24 10:27:45 +02:00
Paolo Tranquilli
60cf77be7e
Bazel: add codeql specific packaging library
...
This encapsulate arch specific logic, local installation and separation
of zip files into generic and arch-specific parts as required by the
internal build.
2024-05-24 10:27:44 +02:00
Tamás Vajk
8ae607cdce
Merge pull request #16577 from tamasvajk/fix/adjust-compiler-arg-test
...
C#: Adjust compiler argument integration test
2024-05-24 09:24:21 +02:00
Erik Krogh Kristensen
c743abad54
Merge pull request #14294 from am0o0/amammad-js-CodeInjection_execa
...
JS: provide command execution sinks for execa package
2024-05-24 09:20:19 +02:00
Anders Schack-Mulligen
5a7174dcbb
Merge pull request #16500 from aschackmull/java/static-field-side-effect
...
Java: Add support for flow through side-effects on static fields.
2024-05-24 09:19:31 +02:00
Michael Nebel
78d4745722
Merge pull request #16578 from michaelnebel/java/dontliftneutral
...
Java: Do not lift neutrals in Model generation.
2024-05-24 09:19:20 +02:00
Tamas Vajk
9aee2dc002
C#: Adjust compiler argument integration test
2024-05-24 08:39:08 +02:00
Michael Nebel
f5c654b669
Merge pull request #16579 from tamasvajk/fix/integration-test-2
...
C#: Fix integration test expected file
2024-05-24 08:16:37 +02:00
Dave Bartolomeo
6f67f9e887
Merge pull request #16564 from github/dbartol/v1
...
Update all pack versions to `1.0.0`
2024-05-23 17:32:27 -04:00
Dave Bartolomeo
f498e05099
Merge branch 'main' into dbartol/v1
2024-05-23 14:37:28 -04:00
Dave Bartolomeo
613ccaac1d
Add change note to all v1.0.0 packs
2024-05-23 13:01:22 -04:00
Arthur Baars
b2c64eabd4
Merge pull request #16572 from github/aibaars-patch-2
...
Java: include link to `remote source` in TrustBoundaryViolation.ql
2024-05-23 18:16:11 +02:00
Philip Ginsbach
4fbbda508b
Merge pull request #16580 from github/ginsbach/MonotonicAggregateModules
...
`monotonicAggregates` can apply to modules (see language spec)
2024-05-23 16:40:29 +01:00
Philip Ginsbach
1129df9cb7
'monotonicAggregates' can apply to modules (see language spec)
2024-05-23 16:20:54 +01:00
Tamas Vajk
5928ede324
C#: Fix integration test expected file
2024-05-23 16:47:35 +02:00
Michael Nebel
9cf0995720
Java: Update test expected output.
2024-05-23 16:33:04 +02:00
Michael Nebel
6f5bdfba65
Java: Do not lift neutrals and only generate for public endpoints.
2024-05-23 16:32:45 +02:00
Arthur Baars
b5b5fef642
Switch source and sink in TrustBoundaryViolation.ql
2024-05-23 15:53:12 +02:00
Arthur Baars
5c4eb3c943
Java: add change note
2024-05-23 13:06:01 +00:00
Michael Nebel
1e54422662
Java: Add neutral implementations.
2024-05-23 15:00:23 +02:00
Tamás Vajk
c0d623c056
Merge pull request #16567 from tamasvajk/refactor/static-extraction-state
...
C#: Refactor static compilation state
2024-05-23 14:49:33 +02:00
Anders Schack-Mulligen
4905612905
Merge pull request #16573 from aschackmull/java/dispatch-joinorder
...
Java: Fix join-order in viableImplInCallContext.
2024-05-23 14:48:25 +02:00
Arthur Baars
d540675b9e
Update TrustBoundaryViolation.ql
2024-05-23 12:04:47 +00:00
Tom Hvitved
e4cd9d86f6
Tree-sitter: Respect verbosity defined in CODEQL_VERBOSITY
2024-05-23 13:38:35 +02:00
Anders Schack-Mulligen
1bc3f6b0e7
Java: Add change note.
2024-05-23 13:03:06 +02:00
Tom Hvitved
a523be4d0a
Tree-sitter: Add set_tracing_level to shared extractor module
2024-05-23 12:58:53 +02:00
Anders Schack-Mulligen
bf3dbc24de
Java: Add support for flow through side-effects on static fields.
2024-05-23 12:57:57 +02:00
Anders Schack-Mulligen
619913b553
Merge pull request #16552 from aschackmull/java/no-source-dispatch-for-exact-mad
...
Java: Remove source dispatch when there's an exact match from a manual model.
2024-05-23 12:56:58 +02:00
Paolo Tranquilli
7da7416bcd
Merge pull request #16568 from github/redsun82/m1-opts
...
Swift: add flags and instructions for building on macOS ARM
2024-05-23 12:53:29 +02:00
Anders Schack-Mulligen
4b3e35ed52
Java: Fix join-order in viableImplInCallContext.
2024-05-23 12:49:57 +02:00
Owen Mansel-Chan
b2deea4606
Avoid duplicate additional flow steps in configs
...
`localTaintStep` includes a lot of steps which are already part of value
flow. Instead use `defaultAdditionalTaintStep`, which is just the extra
steps that are added for taint tracking.
2024-05-23 11:13:35 +01:00
Owen Mansel-Chan
7e5891b443
Remove unnecessary additional flow step
...
TaintTracking already adds taint steps for field reads
2024-05-23 11:08:29 +01:00
Owen Mansel-Chan
cf997fddf6
Trivial: improve parameter names
...
These names make more sense and match everywhere
else that this function signature is used.
2024-05-23 11:04:09 +01:00
Pierre
52a834dfa3
Add changelogs for 2.17.2 and 2.17.3
2024-05-23 11:26:16 +02:00
Anders Schack-Mulligen
70d3be0a3a
Java: Fix test.
2024-05-23 11:24:11 +02:00
Anders Schack-Mulligen
b519f13600
Java: Add change note.
2024-05-23 10:50:16 +02:00
Anders Schack-Mulligen
527dafa346
Java: Improve dispatch through TypeFlow of effectively private calls.
2024-05-23 10:50:16 +02:00
Anders Schack-Mulligen
f353065d26
Java: Allow overloading for exact model matches.
2024-05-23 10:50:01 +02:00
Anders Schack-Mulligen
0f864081cb
Java: Remove source dispatch when there's an exact match from a manual model.
2024-05-23 10:50:00 +02:00
Paolo Tranquilli
90a152a2bc
Swift: add flags and instructions for building on macOS ARM
2024-05-23 10:44:06 +02:00
Tamás Vajk
5cf7112d4c
Merge pull request #16541 from tamasvajk/buildless/use-nuget-config-fallback
...
C#: Use nuget feeds from nuget.config in fallback restore
2024-05-23 10:43:03 +02:00
Owen Mansel-Chan
4567b17a58
Merge pull request #16566 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-05-23 09:42:51 +01:00
Cornelius Riemenschneider
303dc200c1
Add standalone dependency to autobuilder, following upstream changes.
2024-05-23 10:24:44 +02:00
Cornelius Riemenschneider
576ea325e8
Merge remote-tracking branch 'origin/main' into criemen/bazel-csharp
2024-05-23 10:21:19 +02:00
Tamas Vajk
7042f3222a
Code quality improvements
2024-05-23 09:49:09 +02:00
Tamas Vajk
c58971e632
C#: Refactor static compilation state
2024-05-23 09:47:49 +02:00
Tom Hvitved
11da42b049
Merge pull request #16134 from hvitved/csharp/autobuild-buildless-process-indirection
...
C#: Avoid process creation indirection in auto-builder
2024-05-23 09:25:58 +02:00
Tom Hvitved
f517c00658
Merge pull request #16559 from hvitved/csharp/callable-always-returns-true
...
C#: Simplify logic in `JsonWebTokenHandlerLib.qll`
2024-05-23 09:25:19 +02:00
Owen Mansel-Chan
0cc868c742
Merge branch 'main' into workflow/coverage/update
2024-05-23 07:49:02 +01:00
Tony Torralba
d202355b07
Merge pull request #16553 from atorralba/atorralba/java/xxe-qhelp-reword
...
Java: Reword recommendation section of XXE query
2024-05-23 08:48:29 +02:00
erik-krogh
c80f48b23a
Merge branch 'main' into amammad-js-CodeInjection_execa
2024-05-23 08:02:22 +02:00
github-actions[bot]
0f2d0c098f
Add changed framework coverage reports
2024-05-23 00:16:44 +00:00
Joe Farebrother
2db1fbc713
Merge branch 'main' into python-flask-session-interface
2024-05-22 21:48:01 +01:00
Tom Hvitved
621de2b977
C#: Avoid process creation indirection in auto-builder
2024-05-22 20:05:16 +02:00
Dave Bartolomeo
ffe4c8c87b
Update all pack versions to 1.0.0
2024-05-22 13:39:08 -04:00
Mathias Vorreiter Pedersen
3f66b635a4
Merge pull request #16562 from aschackmull/dataflow/update-qltest-expected
...
Dataflow: Fix qltests following https://github.com/github/codeql/pull/16511
2024-05-22 16:16:04 +01:00
Mathias Vorreiter Pedersen
1978922d9e
Merge pull request #16563 from MathiasVP/avoid-cp
...
C++: Avoid a CP in `cpp/alloca-in-loop`
2024-05-22 15:58:46 +01:00
Mathias Vorreiter Pedersen
769d9317c7
C++: Avoid a CP between 'getExpr(node)' and 'this' in 'LoopWithAlloca'.
2024-05-22 15:15:40 +01:00
Mathias Vorreiter Pedersen
1a0d66b339
Merge pull request #16557 from MathiasVP/fix-unique-pointer-query-fp
...
C++: Fix `cpp/use-of-unique-pointer-after-lifetime-ends` FP
2024-05-22 15:09:54 +01:00
Anders Schack-Mulligen
987d5712b8
Python: Accept qltest .expected file changes.
2024-05-22 15:43:49 +02:00
Anders Schack-Mulligen
15a7c3faeb
Java: Accept qltest .expected file changes.
2024-05-22 15:42:40 +02:00
Anders Schack-Mulligen
a650499a9c
Java: Accept qltest .expected file changes (interesting).
2024-05-22 15:42:12 +02:00
Anders Schack-Mulligen
f931c8d836
Go: Accept qltest .expected file changes.
2024-05-22 15:39:47 +02:00
Anders Schack-Mulligen
8db9187698
Go: Accept qltest .expected file changes (interesting).
2024-05-22 15:38:01 +02:00
Anders Schack-Mulligen
e7f24318cd
C++: Accept qltest .expected file changes.
2024-05-22 15:36:30 +02:00
Anders Schack-Mulligen
f977a4206a
C++: Accept qltest .expected file changes (interesting).
2024-05-22 15:35:28 +02:00
Joe Farebrother
8ff0cb614b
Apply review suggestion - Update change note
...
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com >
2024-05-22 14:26:41 +01:00
Michael Nebel
2449074f3d
C#: Remove the DataFlowSummarizedCallable as this narrowing is now handled in the adapter.
2024-05-22 15:11:41 +02:00
Mathias Vorreiter Pedersen
9907f0f827
C++: Exclude a cast to any integral type.
2024-05-22 13:42:07 +01:00
Tom Hvitved
39019b3b62
C#: Simplify logic in JsonWebTokenHandlerLib.qll
2024-05-22 14:24:32 +02:00
Anders Schack-Mulligen
bbebdfea8d
Merge pull request #16511 from aschackmull/dataflow/configuration-provenance
...
Dataflow: Add provenance for configuration-specific steps.
2024-05-22 14:07:10 +02:00
Anders Schack-Mulligen
de5c69d0a1
Merge pull request #16551 from aschackmull/java/model-fixes
...
Java: Revise some jdk time-related models
2024-05-22 14:05:23 +02:00
Mathias Vorreiter Pedersen
09357e15b4
Merge pull request #16533 from MathiasVP/better-negation-guards-in-c
...
C++: Make `IRGuardCondition` handle `p` in `if(p)` and `if(!p)` better in C programs
2024-05-22 13:02:06 +01:00
Tom Hvitved
a992b67d97
Merge pull request #16556 from hvitved/dataflow/simplify
...
Data flow: Remove two redundant conjuncts
2024-05-22 13:58:04 +02:00
Tamás Vajk
c9f468578d
Merge pull request #16521 from tamasvajk/impr/refactor-common-csproj-prop
...
C#: Refactor common msbuild properties
2024-05-22 13:38:31 +02:00
Mathias Vorreiter Pedersen
00a940fd58
Merge pull request #16524 from catenacyber/deref-null-result
...
Adds another rule for null deref
2024-05-22 12:37:39 +01:00
Mathias Vorreiter Pedersen
4b02f88089
C++: Add change note.
2024-05-22 12:37:08 +01:00
Mathias Vorreiter Pedersen
af81698fa8
C++: Fix FP and accept test changes.
2024-05-22 12:34:09 +01:00
Mathias Vorreiter Pedersen
91f860ba4f
C++: Add 'cpp/use-of-unique-pointer-after-lifetime-ends' FP.
2024-05-22 12:33:34 +01:00
Paolo Tranquilli
eab940c45d
Merge branch 'main' into redsun82/kotlin
2024-05-22 13:30:23 +02:00
Alex Ford
8119a27540
Merge pull request #16185 from alexrford/rb/conditions-arr0
...
Ruby: ActiveRecord - refine `conditions` argument as an SQLi sink
2024-05-22 12:19:10 +01:00
Michael Nebel
e4319db18d
C#: Filter out unwanted summaries at the root.
2024-05-22 12:53:55 +02:00
Tom Hvitved
a006c29a00
Merge pull request #16481 from hvitved/treesitter/bump2
...
Tree-sitter: Bump to 0.22.6
2024-05-22 12:53:14 +02:00
Tom Hvitved
70cf16597b
Data flow: Remove two redundant conjuncts
2024-05-22 12:45:11 +02:00
Anders Schack-Mulligen
a078dcf1f2
Merge pull request #16550 from aschackmull/java/zipslip-number-sanitizer
...
Java: Improve sanitizer for java/zipslip
2024-05-22 12:43:44 +02:00
Mathias Vorreiter Pedersen
eda815789b
Update cpp/ql/src/experimental/Likely Bugs/DerefNullResult.ql
2024-05-22 11:21:04 +01:00
Cornelius Riemenschneider
24a14badbb
Bazel: Remove some kwargs.pop invocations.
2024-05-22 12:09:18 +02:00
Cornelius Riemenschneider
09f60e3e45
C#: Address C# code comments.
2024-05-22 12:09:12 +02:00
Tony Torralba
5ec3335b07
Java: Reword recommendation section of XXE query
2024-05-22 11:34:19 +02:00
Anders Schack-Mulligen
a74cf6501a
Java: update qltest expected files.
2024-05-22 11:13:06 +02:00
Michael Nebel
84e412fe36
Merge pull request #16477 from michaelnebel/csharp/madinlinetest
...
C#: Inline expectation for model generator test.
2024-05-22 11:05:23 +02:00
Anders Schack-Mulligen
ba97c3623a
Java: Change most java.time.* df-generated taint models to neutrals.
2024-05-22 10:29:54 +02:00
Anders Schack-Mulligen
54f2316d00
Java: Add a neutral model.
2024-05-22 10:29:49 +02:00
Anders Schack-Mulligen
7828cb8f5a
Java: Add change note.
2024-05-22 10:27:33 +02:00
Anders Schack-Mulligen
d82acf5866
Java: Add simple type sanitization to java/zipslip.
2024-05-22 10:23:30 +02:00
Tamás Vajk
855fe12c6c
Merge pull request #16549 from tamasvajk/fix/tsp-diag
...
C#: Fix TSP diagnostic message
2024-05-22 10:10:26 +02:00
Anders Schack-Mulligen
012b861ffb
Ruby: Accept qltest .expected file changes.
2024-05-22 10:08:59 +02:00
Anders Schack-Mulligen
c4ae18649e
Ruby: Accept qltest .expected file changes (interesting).
2024-05-22 10:08:59 +02:00
Anders Schack-Mulligen
c2ec1bf561
Swift: Accept qltest .expected file changes.
2024-05-22 10:08:56 +02:00
Anders Schack-Mulligen
73b8314308
C#: Accept qltest .expected file changes.
2024-05-22 10:05:42 +02:00
Anders Schack-Mulligen
22c1d52381
Dataflow: Add provenance for configuration-specific steps.
2024-05-22 10:05:42 +02:00
Tamas Vajk
91aa182d53
C#: Fix TSP diagnostic message
2024-05-22 08:49:55 +02:00
Paolo Tranquilli
b744f9fab9
Merge pull request #16544 from github/redsun82/bazel-csharp-2
...
Bazel/C#: avoid zipmerge
2024-05-22 08:18:30 +02:00
Erik Krogh Kristensen
92df0a3d46
Merge pull request #16546 from erik-krogh/ts-big-file-fix
...
JS: fix that very large TypeScript files would crash the extractor
2024-05-22 07:41:58 +02:00
am0o0
0895f7d971
update qlref files
2024-05-21 22:48:17 +02:00
am0o0
c470c078dc
move to experimental
2024-05-21 22:42:16 +02:00
erik-krogh
a30bac14e9
add change-note
2024-05-21 22:14:39 +02:00
Philippe Antoine
ab4b823c2e
fixup unique assignment
2024-05-21 22:10:00 +02:00
Tom Hvitved
22aea47604
Repin
2024-05-21 20:59:54 +02:00
Tom Hvitved
a87ceed361
Merge pull request #16394 from hvitved/dataflow/synth-param-ret-node
...
Data flow: Synthesize parameter return nodes
2024-05-21 20:55:14 +02:00
Tom Hvitved
bc1283c715
Ruby: Reference official Tree-sitter grammar in Cargo.toml
2024-05-21 20:51:50 +02:00
erik-krogh
61c72361cd
move the "isFileTooLarge" earlier in the pipeline, so we're only doing it once
2024-05-21 20:01:24 +02:00
erik-krogh
241f977488
fix that very large TypeScript files would crash the extractor
2024-05-21 19:52:43 +02:00
Paolo Tranquilli
3c52e3b7c5
Bazel/C#: adjust DefaultInfo in codeql_pkg_files_overlay
2024-05-21 16:32:24 +01:00
Geoffrey White
8dad622de2
Swift: Fix some inconsistencies.
2024-05-21 16:32:00 +01:00
Cornelius Riemenschneider
730d5425b3
C#: Add comment justifing turning off strict deps.
2024-05-21 17:30:27 +02:00
Cornelius Riemenschneider
767d427c1b
C#: Re-implement the git version logic using an attribute.
2024-05-21 17:28:31 +02:00
Chuan-kai Lin
8a22e2283c
Merge pull request #16424 from github/cklin/ruby-entities-reorder
...
Ruby: Use entities in reorder directives
2024-05-21 07:32:28 -07:00
Paolo Tranquilli
b19bf2f37a
Bazel/C#: avoid zipmerge
2024-05-21 15:29:54 +01:00
Tom Hvitved
bebcd679a4
Address review comments
2024-05-21 14:51:52 +02:00
Tom Hvitved
18f138e754
Add change note
2024-05-21 14:47:42 +02:00
Rasmus Wriedt Larsen
2451a6d3f6
Accept .expected changes
2024-05-21 14:47:42 +02:00
Tom Hvitved
454687d583
Data flow: Synthesize parameter return nodes
2024-05-21 14:47:42 +02:00
Asger F
0b78d1d953
Python: add qldoc
2024-05-21 14:40:35 +02:00
Asger F
3b211089d6
JS: Remove redundant import
2024-05-21 14:40:17 +02:00
Asger F
13d01f1ec4
Ruby/Python: add recursion guard
2024-05-21 14:40:15 +02:00
Asger F
14c71a351e
Sync shared files
2024-05-21 14:38:55 +02:00
Asger F
6f19fc2fcd
JS: Add isTypeUsed to avoid overpruning
2024-05-21 14:38:52 +02:00
Asger F
632cce2c16
JS: Add failing test due to overpruning
2024-05-21 14:20:13 +02:00
Asger F
43abc72780
JS: Add TypeModel.isTypeUsed
...
f
2024-05-21 14:19:56 +02:00
Tamas Vajk
182325dc5e
Fix expected test files
2024-05-21 14:03:04 +02:00
Tamas Vajk
12494a0c5a
C#: Use nuget feeds from nuget.config in fallback restore
2024-05-21 12:47:38 +02:00
yoff
358c7410c8
Merge pull request #16490 from yoff/python/rich-type-column-MaD
...
Python: Rich `type` column in MaD
2024-05-21 11:55:41 +02:00
Tom Hvitved
158dafa7d0
Python: Dummy change to trigger CI
2024-05-21 11:25:21 +02:00
Tom Hvitved
80364e9570
Ruby: Repin in Cargo.toml
2024-05-21 11:25:21 +02:00
Jeroen Ketema
bddc69e409
Merge pull request #16537 from jketema/memcmp
...
C++: Fix typo in `cpp/network-to-host-function-as-array-bound`
2024-05-21 11:14:48 +02:00
Tom Hvitved
bf2ae9890f
Tree-sitter: Bump to 0.22.6
2024-05-21 11:14:06 +02:00
Jeroen Ketema
c8fec336ce
C++: Fix typo in cpp/network-to-host-function-as-array-bound
2024-05-21 10:29:17 +02:00
Jeroen Ketema
1a60c01723
C++: Add memcmp test for cpp/network-to-host-function-as-array-bound
2024-05-21 10:27:38 +02:00
Joe Farebrother
01a6c5e82f
Merge pull request #16446 from joefarebrother/shared-sensitive-heuristics
...
Ruby/Python/JS/Swift: Add category of Private information to shared sensitive data heuristics
2024-05-21 09:07:13 +01:00
Tom Hvitved
60ee7fb0d3
Merge pull request #16473 from hvitved/csharp/entity-framework-perf
...
C#: Fix performance issue in EntityFramework modelling
2024-05-21 10:03:21 +02:00
Tamás Vajk
1a20a624d6
Merge pull request #16498 from tamasvajk/buildless/use-nuget-from-path
...
C#: Use nuget.exe from the executing machine instead of always downlo…
2024-05-21 09:38:47 +02:00
Tamas Vajk
c9b4e83e73
Add empty Directory.Build.props to ql subdirectory
2024-05-21 09:30:25 +02:00
Cornelius Riemenschneider
731b9412df
Fix integration test expectations.
2024-05-21 09:14:15 +02:00
Cornelius Riemenschneider
36922f2625
Remove GitInfo dependency.
...
GitInfo doesn't work with the bazel-based build.
Instead, we pull in the information from bazel,
which correctly works with the bazel cache.
2024-05-21 09:14:14 +02:00
Cornelius Riemenschneider
71372bc74c
C#: Add Bazel-based build system.
...
This commits a bazel-based build system for C#
using `rules_dotnet`. External dependencies are managed
via `paket`, and updates to the generated bazel files
are done via `./update-deps.sh`.
We're providing our own (minimal) test runner for `xunit`
tests.
2024-05-21 09:14:13 +02:00
Paolo Tranquilli
9d21e2cda3
Merge pull request #16522 from github/redsun82/lfs
...
Bazel: allow LFS rules to use cached downloads without internet
2024-05-21 08:56:47 +02:00
Tamas Vajk
cecaa0de3a
C#: Clear possibly inherited Directory.Build.props and Directory.Build.targets in stub generator
2024-05-21 08:55:19 +02:00
Tamas Vajk
6da0592ab6
C#: Refactor common msbuild properties
2024-05-21 08:55:12 +02:00
Tom Hvitved
d9019f9676
C#: Fix performance issue in EntityFramework modelling
2024-05-21 08:53:51 +02:00
erik-krogh
c166cb406a
Merge branch 'main' into amammad-js-CodeInjection_execa
2024-05-21 08:48:12 +02:00
Mathias Vorreiter Pedersen
5893e38567
C++: Accept test changes.
2024-05-20 22:28:17 +01:00
Mathias Vorreiter Pedersen
0a550bb919
C++: Support 'if(!p)' for C programs in IRGuards.
2024-05-20 22:28:17 +01:00
Philippe Antoine
8ace9da14a
fixup dataflow path and formatting
2024-05-20 21:31:47 +02:00
Mathias Vorreiter Pedersen
398b90a15d
C++: Rename a few predicates.
2024-05-20 17:15:20 +01:00
Joe Farebrother
553500d9f2
Fix change note
2024-05-20 15:47:07 +01:00
Geoffrey White
13a7d9acb6
Merge pull request #16528 from geoffw0/docfix2
...
C++: Update an instance of the name 'Semmle' in a doc page.
2024-05-20 15:07:42 +01:00
Joe Farebrother
be573329d8
Add change note
2024-05-20 10:54:13 +01:00
Mathias Vorreiter Pedersen
c483a4bf04
Merge pull request #16527 from codeqlhelper/main
...
C++: Static variables are initialized to zero or null by compiler
2024-05-20 10:13:23 +01:00
Geoffrey White
0ba3cd96f5
C++: Update an instance of the name 'Semmle' in a doc page.
2024-05-20 10:02:50 +01:00
Joe Farebrother
7727e465f4
Model Flask SessionInterface request parameter
2024-05-20 09:46:54 +01:00
Mathias Vorreiter Pedersen
2f7766a557
C++: Autoformat.
2024-05-20 09:04:24 +01:00
Mathias Vorreiter Pedersen
df24e5982a
C++: Add tests and accept test changes.
2024-05-20 09:01:42 +01:00
Mathias Vorreiter Pedersen
e8b9d7e6fa
C++: Modify change note to be more aligned with existing change notes.
2024-05-20 08:52:18 +01:00
codeqlhelper
15667dcf1e
Create 2024-05-19-avoid-reporting-static-variable.md
2024-05-19 21:55:35 +08:00
codeqlhelper
1d8d45b3aa
Static variables are initialized to zero or null by compiler
...
Static variables are initialized to zero or null by compiler, no need to get an initializer of them
2024-05-19 21:48:43 +08:00
Erik Krogh Kristensen
bfc95c6f13
Merge pull request #16510 from erik-krogh/go-command
...
Go: Update the QHelp for `go/command-injection`.
2024-05-17 17:45:10 +02:00
Paolo Tranquilli
d01d657f89
Bazel: accept new SSH keys in git_lfs_probe.py
2024-05-17 16:39:18 +01:00
Philippe Antoine
73d306c8c8
Adds another rule for null deref
2024-05-17 17:35:07 +02:00
Paolo Tranquilli
170e2231d4
Bazel: allow LFS rules to use cached downloads without internet
...
If the cache is prefilled, LFS rules were still trying to query LFS
urls.
Now the strategy is to first try to fetch the files from the repository
cache (which is possible by providing an empty url list and `allow_fail`
to `repository_ctx.download`), and only run the LFS protocol if that
fails. Technically this is possible by enhancing `git_lfs_probe.py` with
a `--hash-only` flag.
This is also an optimization where no uneeded access is done (including
the slightly slow SSH call) if the repository cache is warm.
2024-05-17 16:24:38 +01:00
yoff
0ecefd6a24
Update python/ql/lib/change-notes/2024-05-17-maD-rich-type-column.md
...
Co-authored-by: Taus <tausbn@github.com >
2024-05-17 16:58:59 +02:00
Rasmus Lerchedahl Petersen
9534e56d1b
Python: address review comments
2024-05-17 16:25:22 +02:00
Cornelius Riemenschneider
b639f60fa6
Merge pull request #16517 from github/criemen/paket-rewrite
...
C#: Reformat project files with `paket`.
2024-05-17 16:20:25 +02:00
Chuan-kai Lin
1a4c07a1ac
Merge pull request #16425 from github/cklin/swift-entities-reorder
...
Swift: Use entities in reorder directives
2024-05-17 06:43:18 -07:00
Chuan-kai Lin
f1047606ad
Merge pull request #16418 from github/cklin/cpp-entities-reorder
...
C++: Use entities in reorder directives
2024-05-17 06:43:07 -07:00
yoff
a7a12f17b5
Merge pull request #16512 from yoff/python/allow-provenance-in-additional-taint-steps
...
Python: Allow provenance in additional taint steps
2024-05-17 15:07:12 +02:00
Felicity Chapman
daf19a2468
Merge pull request #16496 from github/felicitymay/sphinx-config
...
Stop building the CodeQL for VS Code docs now they've been migrated
2024-05-17 13:37:36 +01:00
Paolo Tranquilli
ad1188be1f
Merge pull request #16518 from github/redsun82/bazel-update
...
Bazel: update bazel to version 7.1.2
2024-05-17 12:14:48 +01:00
Cornelius Riemenschneider
a6ce24dc39
C#: Reformat project files with paket.
...
When running `dotnet paket update` or `dotnet paket install`, `paket`
forcefully reformats the project files. This is unfortunate.
One option is to accept these changes, as they're not harmful.
They do mean that each project includes the Paket restore targets individually,
instead of doing so via `Directory.Build.targets`.
Another option would be to not merge this PR, and then I'll document that
the changes to the csproj files should be ignored when running `paket` instead.
I don't really mind either way.
2024-05-17 12:19:53 +02:00
Paolo Tranquilli
cc4f8e038d
Bazel: update bazel to version 7.1.2
2024-05-17 10:52:29 +01:00
Erik Krogh Kristensen
03cf9b702c
Merge pull request #14291 from am0o0/amammad-js-CodeInjection_Shelljs
...
JS: Shelljs improvement
2024-05-17 11:14:11 +02:00
Rasmus Lerchedahl Petersen
a568873a8e
Python: update test expectations
2024-05-17 10:59:49 +02:00
Rasmus Lerchedahl Petersen
92a5b6f6d6
python: add change note
2024-05-17 10:02:38 +02:00
Rasmus Lerchedahl Petersen
e66cce7fe1
python: add qldoc and refactor
...
The logic of which steps an `AdditionalTaintStep` has defined
is now pushed into the defitnion of `AdditionalTaintStep`.
2024-05-17 09:49:31 +02:00
Michael Nebel
e198d0105f
C#: Re-factor the model generator tests.
2024-05-17 09:44:58 +02:00
Michael Nebel
adeff8c602
C#: Convert neutral capture test to inline expectation.
2024-05-17 09:44:58 +02:00
Michael Nebel
e3b6ee1aaf
C#: Convert type based summary capture test to inline expectation.
2024-05-17 09:44:58 +02:00
Michael Nebel
a5fd433c20
C#: Convert sink capture test to inline expectation.
2024-05-17 09:44:58 +02:00
Michael Nebel
26f9297d62
C#: Convert source capture test to inline expectation.
2024-05-17 09:44:58 +02:00
Michael Nebel
404b39b6e6
C#: Convert summary capture test to inline expectation.
2024-05-17 09:44:57 +02:00
Michael Nebel
2cda1a207e
C#: Add language specific part of the models as data inline expectation.
2024-05-17 09:44:57 +02:00
Michael Nebel
78b8a9259a
Share the Models as Data inline expect predicates.
2024-05-17 09:44:57 +02:00
Michael Nebel
e483948c19
Merge pull request #16513 from michaelnebel/csharp/flowsummariestest
...
C#: Change the printed information in the Flow summaries tests.
2024-05-17 09:43:28 +02:00
erik-krogh
384649b336
changes based on review, and improve the new command-injection test
2024-05-17 08:38:54 +02:00
Chanel Young
5ee7004a62
fp case if encrypt set in initializer
2024-05-16 17:59:17 -07:00
Rasmus Lerchedahl Petersen
d4d6b48f98
python: add test for subclass instance method
2024-05-17 00:03:01 +02:00
Rasmus Lerchedahl Petersen
3d0c42f44d
python: rewrite text models to use rich paths
2024-05-17 00:03:01 +02:00
Rasmus Lerchedahl Petersen
a88c007c05
python: Allow dotted paths in type column
2024-05-17 00:03:00 +02:00
Tamas Vajk
a79105e2ae
C#: Use nuget.exe from the executing machine instead of always downloading it
2024-05-16 23:15:04 +02:00
erik-krogh
2848ccf0e2
fix frontend errors that Go complained about
2024-05-16 20:06:26 +02:00
erik-krogh
08c0d8ec60
autoformat go files
2024-05-16 19:59:40 +02:00
erik-krogh
9aeebc6f39
update the QHelp to add a "--" example
2024-05-16 19:49:22 +02:00
Owen Mansel-Chan
a8201a19ae
Merge pull request #16506 from github/smowton/admin/gradle-version-detection-change-note
...
Java: Add change note for Gradle JDK version detection
2024-05-16 17:11:03 +01:00
Cornelius Riemenschneider
3a224871ee
Merge pull request #16476 from github/criemen/update-deps
...
C#: Update non-Roslyn thirdparty dependencies
2024-05-16 17:58:10 +02:00
Alex Ford
19e2af8a1d
Merge pull request #13556 from am0o0/amammad-ruby-bombs
...
Ruby: Decompression Bombs
2024-05-16 16:23:02 +01:00
Paolo Tranquilli
75709bf1ec
Merge branch 'main' into redsun82/kotlin
2024-05-16 15:55:08 +01:00
Paolo Tranquilli
92699d18ac
Merge pull request #16508 from github/redsun82/updated-prebuilt
...
Swift: update prebuilt package
2024-05-16 14:58:17 +01:00
am0o0
dcadda23cd
update expected file
2024-05-16 15:15:27 +02:00
am0o0
f06c3fddd9
fix qhelp, fix duplicate query id
2024-05-16 15:12:31 +02:00
Michael Nebel
18fc92247b
C#: Update flowsummaries expected output.
2024-05-16 15:09:04 +02:00
Michael Nebel
763d53afed
C#: Remove the override and ext column from the summaries printing test.
2024-05-16 15:08:45 +02:00
Alex Ford
78dc6502f5
Merge branch 'main' into amammad-ruby-bombs
2024-05-16 13:53:31 +01:00
Michael Nebel
b1329fd806
Merge pull request #16362 from michaelnebel/java/removelocalqueries
...
Java: Remove local query variants.
2024-05-16 14:34:04 +02:00
am0o0
42a9962519
make shellJSMember predicate private, improve predicate document
2024-05-16 14:05:06 +02:00
Rasmus Lerchedahl Petersen
4378924785
Python: Example use of provenance for additional taint steps
2024-05-16 14:04:35 +02:00
Rasmus Lerchedahl Petersen
20ea9255a1
Python: Allow provenance in additional taint steps
2024-05-16 14:04:10 +02:00
yoff
ea3cc51286
Merge pull request #16194 from yoff/python/test-constructor-MaD-path
...
Python: test the MaD path for constructor calls
2024-05-16 13:52:30 +02:00
Cornelius Riemenschneider
47f679dc34
C#: Remove version constraints on most dependencies.
...
This means that `dotnet paket update` will pull in the
latest matching versions of all dependencies, except
the pinned roslyn versions.
GitInfo also remains pinned, as we're removing that
dependency when converting the build to bazel anyways.
This removes a whole bunch of transitive dependencies
we no longer need, resulting in a smaller distribution,
and hopefully a smaller build.
2024-05-16 13:51:36 +02:00
Cornelius Riemenschneider
8dc9c95be4
Merge pull request #16376 from github/criemen/dotnet-paket
...
C#/C++: Convert C# code to use `paket` package manager
2024-05-16 13:45:25 +02:00
Owen Mansel-Chan
2dd42f7aa5
Merge pull request #16509 from owen-mc/go/fix-missing-underlying-types
...
Go: make two barriers recognise named types whose underlying types are integer types
2024-05-16 12:41:42 +01:00
Owen Mansel-Chan
2b7394cd42
Merge pull request #16305 from github/go/value-flow-instead-of-taint-flow
...
Go: Use value flow instead of taint flow for `go/incorrect-integer-conversion`
2024-05-16 12:40:53 +01:00
Asger F
499c4df79b
Merge pull request #13554 from am0o0/amammad-js-bombs
...
JS: Decompression Bombs
2024-05-16 13:25:41 +02:00
Erik Krogh Kristensen
a2994c073a
Merge pull request #16507 from erik-krogh/up-insecure-randomness
...
JS: Update the insecure-randomness QHelp
2024-05-16 12:52:09 +02:00
Owen Mansel-Chan
8cc118f781
Add change note
2024-05-16 11:16:54 +01:00
Owen Mansel-Chan
b008f98782
Fix missing getUnderlyingType() calls
...
In both cases we also care about named types whose underlying type is
an integer type.
2024-05-16 11:10:15 +01:00
Paolo Tranquilli
451f601a65
Swift: update prebuilt package
2024-05-16 11:07:07 +01:00
Max Schaefer
98d2c848bb
Merge pull request #16497 from github/max-schaefer/comparison-with-wider-type
...
Java: Add tests for `comparison-with-wider-type`.
2024-05-16 10:59:59 +01:00
Cornelius Riemenschneider
74e446ea3b
Paket/C#: Only pull in the tool restore targt via InitialTargets.
2024-05-16 11:42:20 +02:00
erik-krogh
56dff8540f
add an example of how to get a floating point value between 0 and 1
2024-05-16 11:15:07 +02:00
erik-krogh
066f3b61a2
RandomSource is deprecated, it's crypto now
2024-05-16 11:14:50 +02:00
Owen Mansel-Chan
410543f26b
Add change note
2024-05-16 10:10:22 +01:00
Owen Mansel-Chan
e71cf0ff1d
Use value flow instead of taint flow
2024-05-16 10:10:18 +01:00
Owen Mansel-Chan
5dbb91f508
Merge pull request #16504 from owen-mc/go/allow-array-reads-from-named-types
...
Go: allow read and store steps from named types
2024-05-16 09:47:54 +01:00
Tamás Vajk
c4d33fbede
Merge pull request #16505 from tamasvajk/fix/pin-sdk-version-in-test
...
C#: Pin dotnet SDK version in integration test relying on razor sourc…
2024-05-16 10:18:17 +02:00
Chris Smowton
e8d064e291
Java: Add change note for Gradle JDK version detection
2024-05-16 09:15:47 +01:00
erik-krogh
ea2b73bda2
add a sanitizer that checks that the string does not start with "--"
2024-05-16 09:25:19 +02:00
Tamas Vajk
62faab320b
C#: Pin dotnet SDK version in integration test relying on razor source generator
2024-05-16 09:00:53 +02:00
yoff
5076b1a214
Merge pull request #16135 from sylwia-budzynska/gradio-model
...
Python: Add Gradio models
2024-05-16 09:00:50 +02:00
erik-krogh
b9a7f6a8f7
add regexp check as a sanitizer for command-injection
2024-05-16 08:55:03 +02:00
erik-krogh
761f9cac97
make a new go/command-injection qhelp
2024-05-16 08:54:55 +02:00
erik-krogh
e2a4c2aa1b
move the code samples for the Go command-injection queries to an examples/ folder
2024-05-16 08:54:54 +02:00
Owen Mansel-Chan
6ffa821aa3
Add change note
2024-05-16 00:41:28 +01:00
Owen Mansel-Chan
21ff705b73
Fix bug with read/store steps and named types
2024-05-16 00:35:45 +01:00
Owen Mansel-Chan
1af3374322
Add tests for data flow through ranged for loops
...
Including the case where the type of the domain is a named type rather
than an array type or map type or whatever.
2024-05-16 00:32:30 +01:00
Cornelius Riemenschneider
1b22e0879a
Paket/C#: Automatically restore tools for CSharp.sln.
...
This is not a general fix, as we not always build the
solution file, but this should improve the DX for
local developers that use the solution file.
2024-05-15 21:51:33 +02:00
Chris Smowton
4617c055e2
Merge pull request #16336 from smowton/smowton/admin/android-8-test
...
Java: Add Android Gradle Plugin 8 and Spring Boot 3 tests
2024-05-15 16:23:21 +01:00
Chris Smowton
a50584c665
Comment on Java version selection testing strategy
2024-05-15 14:52:09 +01:00
Chris Smowton
44edff7661
AGP 8 test: ignore and remove the .gradle directory
2024-05-15 14:52:09 +01:00
Chris Smowton
9c823d708d
Expose toolchains to some Android tests, which would otherwise now try to upgrade to JDK17
2024-05-15 14:52:09 +01:00
Chris Smowton
c328957bf3
Add Spring Boot 3 test
2024-05-15 14:52:09 +01:00
Chris Smowton
7e13c88f1d
Add Android 8 integration test
2024-05-15 14:52:09 +01:00
Sylwia Budzynska
72493a6bd1
Change classes to private
...
Co-authored-by: yoff <lerchedahl@gmail.com >
2024-05-15 15:08:27 +02:00
Cornelius Riemenschneider
950e8c85e7
Paket: Prevent recursion into ql/csharp/ql directory.
2024-05-15 14:17:04 +02:00
Cornelius Riemenschneider
a158e40cc2
MSBuild: Move paket restore target inclusion to global file.
2024-05-15 14:17:02 +02:00
Cornelius Riemenschneider
90bb0ba33f
Paket: Mark lockfile as generated.
2024-05-15 14:17:01 +02:00
Cornelius Riemenschneider
8f207e7a06
Add dotnet tool restore to local CI.
2024-05-15 14:16:47 +02:00
Max Schaefer
3c47c1137d
Simplify query.
2024-05-15 12:49:45 +01:00
Max Schaefer
d406646414
Java: Add tests for comparison-with-wider-type.
2024-05-15 12:45:19 +01:00
Felicity Chapman
b32fb1d961
Fix another couple of links
2024-05-15 12:43:40 +01:00
Cornelius Riemenschneider
3f020a96e4
Remove unused dependency.
2024-05-15 13:37:05 +02:00
Cornelius Riemenschneider
25b7214064
C++: Move Windows autobuilder to paket dependencies.
2024-05-15 13:36:51 +02:00
Cornelius Riemenschneider
723850394d
Add paket files to .gitignore.
2024-05-15 13:28:03 +02:00
Cornelius Riemenschneider
f1616d3c26
Add auto-generated paket restore targets.
2024-05-15 13:28:01 +02:00
Cornelius Riemenschneider
45167cf9f1
C#: Switch over dependencies in msbuild files to paket.
2024-05-15 13:28:00 +02:00
Cornelius Riemenschneider
04c26056a1
C#: Commit paket-based dependency tree.
2024-05-15 13:27:58 +02:00
Cornelius Riemenschneider
4a85cc98e5
C#: Add tool file for paket.
2024-05-15 13:27:56 +02:00
Michael B. Gale
81297aad8c
Go: Use standard semver format in outputEnvironmentJson
2024-05-15 12:21:23 +01:00
Felicity Chapman
24da489bab
Replace a few more old references
2024-05-15 12:14:10 +01:00
Felicity Chapman
c6ee25497e
Replace old references to VS Code articles
2024-05-15 12:07:53 +01:00
Michael B. Gale
fabd7a9c51
Go: Better preserve original versions
2024-05-15 12:01:03 +01:00
Cornelius Riemenschneider
eb9c734120
Merge pull request #16487 from github/criemen/move-win-autobuilder
...
C++/C#: Move the Windows autobuilder into a subfolder in `ql/csharp`.
2024-05-15 12:55:10 +02:00
Owen Mansel-Chan
332a3dbc61
Merge pull request #16493 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-05-15 11:49:06 +01:00
Michael B. Gale
e0543d1d59
Go: Support all permutations of version prefixes and suffixes
2024-05-15 10:43:02 +01:00
Owen Mansel-Chan
253965096b
Merge branch 'main' into workflow/coverage/update
2024-05-15 10:10:44 +01:00
Michael B. Gale
6652685f5a
Go: Restore toolchain.IsInstalled check
2024-05-15 10:07:44 +01:00
Michael B. Gale
898383ccff
Go: Fix comment in NewSemVer for empty string
2024-05-15 10:07:44 +01:00
Michael B. Gale
054efa648c
Go: Move version constants to shared location
2024-05-15 10:03:35 +01:00
Michael B. Gale
9e618b6961
Go: Use SemVer type in autobuilder package
2024-05-15 10:03:35 +01:00
Michael B. Gale
a6d2aa3913
Go: Use SemVer type in project package
2024-05-15 10:03:32 +01:00
Michael B. Gale
010df54657
Go: Use SemVer type in toolchain package
2024-05-15 10:03:01 +01:00
Michael B. Gale
d171750678
Go: Add SemVer type to track valid semantic versions
2024-05-15 10:02:10 +01:00
Michael B. Gale
964b3f2339
Merge pull request #16480 from github/mbg/go/improve-script-fail-message
...
Go: Improve log messages in `buildWithoutCustomCommands`
2024-05-15 10:00:30 +01:00
Michael B. Gale
586e90043a
Merge pull request #16462 from github/mbg/go/add-resolve-env-tests
...
Go: Add tests for `resolve build-environment`
2024-05-15 09:59:52 +01:00
Cornelius Riemenschneider
ab7d30a464
Merge branch 'main' into criemen/move-win-autobuilder
2024-05-15 10:58:01 +02:00
Michael B. Gale
38e1065b24
Go: Document return values for Autobuild
2024-05-15 09:38:31 +01:00
Mathias Vorreiter Pedersen
64b8f97d39
Merge pull request #16495 from MathiasVP/delete-duplicated-conjunction
2024-05-15 09:37:46 +01:00
Michael B. Gale
28c8611f93
Go: Add build-environment.expected for linux-only tests
2024-05-15 09:34:28 +01:00
Michael B. Gale
b44ad2d39f
Go: Add missing diagnostics.expected file
2024-05-15 09:33:44 +01:00
Cornelius Riemenschneider
8ea1d1376f
Update CODEOWNERS
...
Co-authored-by: Jeroen Ketema <93738568+jketema@users.noreply.github.com >
2024-05-15 10:18:31 +02:00
Michael B. Gale
7e10f212cd
Go: Move resolve build-environment test into subdirectory
2024-05-15 08:54:24 +01:00
Mathias Vorreiter Pedersen
a1cb419902
C++: Delete duplicated case in IR generation.
2024-05-15 08:52:56 +01:00
Michael B. Gale
7cf61ffb18
Go: Add integration test for resolve build-environment
2024-05-15 08:51:54 +01:00
Michael B. Gale
eb2e587637
Go: Add build-environment.expected files
2024-05-15 08:41:31 +01:00
github-actions[bot]
c3caafcca1
Add changed framework coverage reports
2024-05-15 00:16:53 +00:00
Dave Bartolomeo
b49a61705c
Merge pull request #16491 from github/post-release-prep/codeql-cli-2.17.3
...
Post-release preparation for codeql-cli-2.17.3
2024-05-14 19:33:20 -04:00
github-actions[bot]
32e8b5c667
Post-release preparation for codeql-cli-2.17.3
2024-05-14 21:14:08 +00:00
Owen Mansel-Chan
145873f562
Merge pull request #16413 from owen-mc/go/fix-builtin-models
...
Go: fix models for built-in functions
2024-05-14 21:03:05 +01:00
Dave Bartolomeo
b7f0b7afb5
Merge pull request #16489 from github/release-prep/2.17.3
...
Release preparation for version 2.17.3
2024-05-14 15:43:46 -04:00
yoff
538d556465
Merge branch 'main' into python/test-constructor-MaD-path
2024-05-14 21:30:58 +02:00
yoff
04c0475251
Merge pull request #16483 from yoff/python/MaD-instance-follow-subclass
...
Python: The MaD token `Instance` now follows subclasses
2024-05-14 21:30:43 +02:00
github-actions[bot]
100166fa53
Release preparation for version 2.17.3
2024-05-14 19:23:18 +00:00
Chris Smowton
d76182b945
Merge pull request #16468 from smowton/smowton/admin/add-buildless-timeout-tests
...
Java: add test cases for Maven and Gradle stalling in buildless mode
2024-05-14 19:13:03 +01:00
Chris Smowton
829707528b
Merge pull request #16488 from smowton/smowton/admin/document-test-servers
...
Java: Add comments to tests that spawn an HTTP/S server
2024-05-14 18:11:20 +01:00
Chris Smowton
cf134331a9
Java: Add comments to tests that spawn an HTTP/S server
2024-05-14 17:48:35 +01:00
Chris Smowton
61cd93fcf3
Switch to a different black-hole IP, because Windows blocks 240.0.0.0/24
2024-05-14 17:36:50 +01:00
Chris Smowton
e699b18928
Java: add test cases for Maven and Gradle stalling in buildless mode
2024-05-14 17:36:49 +01:00
Chris Smowton
1b1367eec0
Merge pull request #16479 from smowton/smowton/admin/test-java-trust-store-inheritence
...
Java: Add test case for a custom Java trust store
2024-05-14 17:35:26 +01:00
Michael B. Gale
58ef9f4e3e
Go: Run resolve build-environment in integration tests
2024-05-14 15:46:03 +01:00
Chris Smowton
8814e6e2bd
Replace deprecated ssl.wrap_socket method
2024-05-14 15:14:27 +01:00
Owen Mansel-Chan
827d15aaa0
Test changes due to model renumbering
2024-05-14 14:40:57 +01:00
Owen Mansel-Chan
ab5e1f8a69
Fix models for min and max and improve tests
...
Although the documentation makes them look variadic (and generic), they
are actually special-cased in the compiler. Like all built-in functions
they don't have a signature type, but the type of `min(a, b, c)` is
`func(int, int, int) int` and not `func(int, ...int) int`.
Go doesn't allow open-ended ranges for argument indices in
models-as-data specifications (though Ruby and Python do), so I've used
`1..1000`.
2024-05-14 14:40:56 +01:00
Chuan-kai Lin
99335e5f29
Merge pull request #16421 from github/cklin/java-entities-reorder
...
Java: Use entities in reorder directives
2024-05-14 06:03:52 -07:00
Rasmus Lerchedahl Petersen
49ffa8bf07
Merge branch 'main' of https://github.com/github/codeql into python/test-constructor-MaD-path
2024-05-14 14:30:18 +02:00
Joe Farebrother
027e5e7291
Merge pull request #16300 from joefarebrother/python-pyramid
...
Python: Model the Pyramid framework
2024-05-14 13:24:19 +01:00
Joe Farebrother
904799b674
Merge pull request #16105 from joefarebrother/python-promote-header-injection
...
Python: Promote Header Injection query from experimental
2024-05-14 13:23:58 +01:00
Sylwia Budzynska
34c447939e
Update test results
2024-05-14 14:23:36 +02:00
Cornelius Riemenschneider
869bf8afc6
C++/C#: Move the Windows autobuilder into a subfolder in ql/csharp.
...
This is a necessary preparation for moving the C# dependency management to `paket`,
which in turn is a necessary preparation for moving the C# build to bazel.
As we discovered in https://github.com/github/codeql/pull/16376 ,
`paket` tries to restore all projects recursively from the root folder.
If we support building C# code under both `ql/csharp` and `ql/cpp`, we need
to have a single lockfile under `ql`, as both codebases share the same set of dependencies
(and utilities from `ql/csharp/extractor`).
Then, `paket` will also try to restore things that look like "C# projects" in other languages'
folders, which is not what we want.
Therefore, we address this by moving all C# code into a common root directory, `ql/csharp`.
This needs an internal PR to adjust the buildsystem to look for the autobuilder in the new location.
2024-05-14 13:45:49 +02:00
Michael Nebel
79c6834aa3
Merge pull request #16374 from michaelnebel/java/narrowsuperimpl
...
Java: Improve finding best type for models and lifting.
2024-05-14 13:12:04 +02:00
Sylwia Budzynska
f72afdc7cb
Merge branch 'main' into gradio-model
2024-05-14 12:41:00 +02:00
Óscar San José
e65a62c727
Merge pull request #16485 from github/oscarsj/fix-lfs-probe-auth-in-cs
...
make sure GITHUB_TOKEN exists and is not empty before using it in auth headers
2024-05-14 11:49:20 +02:00
Óscar San José
9105faa3fd
make sure GITHUB_TOKEN exists and is not empty before using it in auth headers
2024-05-14 11:22:07 +02:00
Óscar San José
faa2dcee24
test GITHUB_TOKEN non-emptyness before using it in auth headers
2024-05-14 11:18:18 +02:00
Joe Farebrother
a62ce4c51d
Merge pull request #16461 from joefarebrother/csharp-missing-cwe-metadata
...
C#: Add missing CWE tags
2024-05-14 09:32:06 +01:00
Óscar San José
5b572a2c2a
make GITHUB_TOKEN in lfs_probe a fallback rather than an override
2024-05-14 10:24:02 +02:00
am0o0
c7adb32bc4
simply replace duplicate class references with classRef() in Fabric.qll
2024-05-14 09:51:47 +02:00
Anders Schack-Mulligen
ed0717af96
Merge pull request #16478 from aschackmull/java/hasqualifiedname
...
Java: Clean up some instances of getQualifiedName.
2024-05-14 09:19:25 +02:00
Rasmus Lerchedahl Petersen
52717f8500
python: The MaD token Instance now follows subclasses
2024-05-14 08:40:19 +02:00
Joe Farebrother
513a319149
Change cwe to 348
2024-05-13 22:38:47 +01:00
Chuan-kai Lin
b34fb7c26b
Merge pull request #16423 from github/cklin/python-entities-reorder
...
Python: Use entities in reorder directives
2024-05-13 10:26:55 -07:00
Chuan-kai Lin
1758a1e04b
Merge pull request #16422 from github/cklin/javascript-entities-reorder
...
JS: Use entities in reorder directives
2024-05-13 10:26:41 -07:00
Chuan-kai Lin
9456eaf5d3
Merge pull request #16420 from github/cklin/go-entities-reorder
...
Go: Use entities in reorder directives
2024-05-13 10:26:04 -07:00
Chuan-kai Lin
372746ffd4
Merge pull request #16419 from github/cklin/csharp-entities-reorder
...
C#: Use entities in reorder directives
2024-05-13 10:25:50 -07:00
Felicity Chapman
34f91f8129
Stop building the CodeQL for VS Code docs
2024-05-13 16:23:06 +01:00
Michael B. Gale
65c654e946
Go: Do not use a named return variable in buildWithoutCustomCommands
2024-05-13 15:33:52 +01:00
am0o0
37d33186e5
revert classRef deletion, fix secondaryserverCmdInjection expected test results
2024-05-13 15:02:04 +02:00
am0o0
fb3d34ce11
format Torch.qll
2024-05-13 14:43:43 +02:00
Chris Smowton
10e1bfcee5
Add test case for a custom Java trust store
2024-05-13 12:43:06 +01:00
Michael B. Gale
4d5f05a8dd
Go: Adjust log messages depending on whether build scripts were found or not
2024-05-13 12:42:00 +01:00
Michael B. Gale
1b9e8ae86f
Go: Modify Autobuild to return an array of scripts that were run
2024-05-13 12:38:51 +01:00
Michael B. Gale
bbc359ebde
Go: Improve messages in buildWithoutCustomCommands
2024-05-13 12:31:04 +01:00
Anders Schack-Mulligen
76e740bc1d
Java: Clean up some instances of getQualifiedName.
2024-05-13 13:06:44 +02:00
Paolo Tranquilli
5eaaf02bf5
Merge pull request #16472 from github/redsun82/go-pre-commit
...
Go: disable pre-commit hook
2024-05-13 09:49:40 +02:00
Paolo Tranquilli
f125e732b0
Go: disable pre-commit hook
2024-05-13 09:27:35 +02:00
Paolo Tranquilli
c30ca4d9f6
Merge pull request #16398 from github/redsun82/go-make
...
Go: update `make` and CI to use `bazel`
2024-05-13 08:37:52 +02:00
Sim4n6
7f153ed07b
Add some method calls as a Source
2024-05-12 09:46:36 +01:00
Erik Krogh Kristensen
0d814e0e20
Merge pull request #16220 from erik-krogh/domainAnc
...
Go: Add an example specific to domain names in missing-regexp-anchor
2024-05-11 07:52:13 +02:00
Owen Mansel-Chan
f7e6bf7ef5
Two tests have different paths but same results
2024-05-10 23:41:00 +01:00
Owen Mansel-Chan
f8e17fe8cc
Accept expected test changes
2024-05-10 23:40:59 +01:00
Owen Mansel-Chan
76946184de
Accept MaD renumbering for edge provenance
2024-05-10 23:40:58 +01:00
Owen Mansel-Chan
e1c85e3581
Fix elementWrite to include flow summaries
2024-05-10 23:40:58 +01:00
Owen Mansel-Chan
8cc9838628
Add change note
2024-05-10 23:40:57 +01:00
Owen Mansel-Chan
d5aa08dbf3
Local flow steps for flow summaries for built-in functions
2024-05-10 23:40:57 +01:00
Owen Mansel-Chan
86e2b845f3
Add tests for copy (taint passes, value fails)
2024-05-10 23:40:56 +01:00
Owen Mansel-Chan
eab1569342
Update ExternalValueFlow to use value flow
2024-05-10 23:40:56 +01:00
Owen Mansel-Chan
c816412795
Create copy of ExternalTaintFlow called ExternalValueFlow
2024-05-10 23:40:55 +01:00
Owen Mansel-Chan
84b7319688
Rename test folder ExternalFlow to ExternalTaintFlow
2024-05-10 23:40:54 +01:00
Owen Mansel-Chan
f95ccd242f
Remove old-style models of built-in functions
2024-05-10 23:40:54 +01:00
Owen Mansel-Chan
fcdac0aeb0
Add models for min and max built-in functions
2024-05-10 23:40:53 +01:00
Owen Mansel-Chan
1322ce35d6
Add model for built-in function copy
2024-05-10 23:40:53 +01:00
Owen Mansel-Chan
e857eedd4a
Fix model for append - it is variadic
2024-05-10 23:40:52 +01:00
Erik Krogh Kristensen
462e564c19
apply suggestion from code review
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2024-05-10 18:59:55 +02:00
Ian Lynagh
e7092b403b
Merge pull request #16401 from igfoo/igfoo/vars
...
Java/Kotlin: Remove support for some deprecated environment variables
2024-05-10 13:37:55 +01:00
Sylwia Budzynska
d6acea1d0c
Fix tests
2024-05-10 12:41:47 +02:00
Sylwia Budzynska
52ceb7fb89
Apply suggestions from code review
...
Co-authored-by: yoff <lerchedahl@gmail.com >
2024-05-10 12:07:32 +02:00
am0o0
90da07159e
fix tests, chore on Find.ql
2024-05-10 08:51:23 +02:00
am0o0
a87d27b53e
revert vscode settings.json file
2024-05-10 08:35:50 +02:00
am0o0
9435a62a86
revert vscode settings.json file
2024-05-10 08:34:08 +02:00
am0o0
0e80e867af
fix actions reviews
2024-05-10 08:32:45 +02:00
am0o0
f93d4a0dd5
fix Fabric query library
2024-05-10 01:27:31 +02:00
am0o0
3a52cd186e
Merge branch 'am0o0-python-codeExec' of https://github.com/amammad/codeql into am0o0-python-codeExec
2024-05-09 23:16:11 +02:00
Am
0043d93fc1
Merge branch 'github:main' into am0o0-python-codeExec
2024-05-09 23:15:56 +02:00
am0o0
9b4ea8877b
Merge branch 'am0o0-python-codeExec' of https://github.com/amammad/codeql into am0o0-python-codeExec
2024-05-09 23:14:11 +02:00
Erik Krogh Kristensen
bcddef8f32
Merge pull request #16131 from erik-krogh/cpp-path
...
C++: Improve the cpp/path-injection qhelp
2024-05-09 22:21:51 +02:00
Owen Mansel-Chan
e721399eec
Merge pull request #16464 from owen-mc/go/fix-broken-test
...
Go: Fix test expectations
2024-05-09 16:46:04 +01:00
Owen Mansel-Chan
674e65e134
Fix test expectations
2024-05-09 16:26:30 +01:00
Ian Lynagh
4d54c09a6f
Java: Add changenote for dropping support for some old variables
2024-05-09 15:59:47 +01:00
Ian Lynagh
b5d6bb9097
Kotlin: Remove unused var SEMMLE_PLATFORM_TOOLS
2024-05-09 15:59:47 +01:00
Ian Lynagh
cfc419b639
Kotlin: Remove unused ODASA_HOME variable
2024-05-09 15:59:47 +01:00
Ian Lynagh
304ad33837
Kotlin: Remove unused ODASA_TOOLS variable
2024-05-09 15:59:47 +01:00
Ian Lynagh
231918f612
Kotlin: Remove redundant variable ODASA_JAVA_LAYOUT
2024-05-09 15:59:47 +01:00
Owen Mansel-Chan
526204dc43
Merge pull request #16458 from owen-mc/go/fix-mad-for-builtin-functions
...
Go: fix `hasQualifiedName` and models-as-data for built-in functions
2024-05-09 15:06:07 +01:00
Joe Farebrother
20a1e22c44
Add missing CWE tags
2024-05-09 10:33:48 +01:00
Joe Farebrother
da93a08639
Add change notes
...
No change note is needed for Swift, as the new heuristics are unused and thus should not affect any queries.
2024-05-09 10:03:20 +01:00
Joe Farebrother
f1ab3f40f3
Add unit tests
2024-05-09 09:47:44 +01:00
Joe Farebrother
9aff22c664
Fix typos in sensitive data regex
2024-05-09 09:39:03 +01:00
Jeroen Ketema
4dfcdbccd7
Merge pull request #16459 from jketema/handler-fix
...
C++: Fix destructor translation for handlers
2024-05-09 10:23:07 +02:00
Sarita Iyer
aab5da0435
Merge pull request #16320 from github/subatoi/deprecate-codeql-for-vs-code
...
[8th May 2024] Add deprecation notices to CodeQL for VS Code documentation
2024-05-08 17:00:42 -04:00
Jeroen Ketema
9e09c5a6cf
C++: Fix copy and paste error in comment
2024-05-08 22:11:19 +02:00
Owen Mansel-Chan
279b2c7a95
Merge pull request #16457 from owen-mc/go/fix-implicitvarargsslice-type
...
Go: Fix `getType` on `ImplicitVarArgsSlice`
2024-05-08 20:52:01 +01:00
erik-krogh
811c175556
add example for domain names with sub-domains to missing-regexp-anchor
2024-05-08 20:50:43 +02:00
erik-krogh
a51d24cbab
apply suggestions from code review, and the examples to the test
2024-05-08 19:34:50 +02:00
Jeroen Ketema
d68d2cca41
C++: Fix destructor translation for handlers
2024-05-08 19:26:56 +02:00
Jeroen Ketema
0cbedfb28c
Merge pull request #16455 from jketema/if-fix
...
C++: Ensure destructors for ifs are called after both branches and for both if and constexpr if
2024-05-08 19:15:28 +02:00
Geoffrey White
49aba25852
Merge pull request #16445 from geoffw0/qhelp4
...
C++: Improve qhelp for DoubleFree.
2024-05-08 18:02:12 +01:00
Geoffrey White
53d4a10108
Update cpp/ql/src/Critical/DoubleFree.qhelp
...
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com >
2024-05-08 17:15:08 +01:00
Mathias Vorreiter Pedersen
59fb9cc862
Merge pull request #16299 from MathiasVP/remove-base-address-as-ipa-key
...
C++: Remove an unnecessary column
2024-05-08 16:43:30 +01:00
Owen Mansel-Chan
4f10cb5fa0
Local flow tests: do not list summary models
...
This is so that when we don't change the test results every time we add
a summary model for a built-in function.
2024-05-08 16:13:37 +01:00
Owen Mansel-Chan
57ff30c5f3
Update tests: built-in models now work
2024-05-08 16:07:02 +01:00
Owen Mansel-Chan
1ccea884ff
Add change note
2024-05-08 15:37:25 +01:00
Owen Mansel-Chan
f6f594e4b5
parse empty string as package name
2024-05-08 15:33:19 +01:00
Owen Mansel-Chan
fb74a2a170
Use "" in qualified name for entities without a package
2024-05-08 15:33:19 +01:00
Owen Mansel-Chan
4d42a88c3c
Add change note
2024-05-08 15:31:22 +01:00
Owen Mansel-Chan
9842445b52
Fix getType on ImplicitVarArgsSlice
...
It was not defined for built-in functions or for functions called via
a function variable.
2024-05-08 15:22:27 +01:00
Rasmus Wriedt Larsen
694b3b0fce
Merge pull request #16452 from RasmusWL/fix-warning
...
misc: Fix docstring warning
2024-05-08 16:07:10 +02:00
Michael B. Gale
8cba06a25c
Merge pull request #16454 from github/mbg/go/fix/shadowed-variable
2024-05-08 14:13:18 +01:00
Geoffrey White
088f8297b6
C++: Use nullptr.
2024-05-08 14:04:21 +01:00
Joe Farebrother
ab23d0ad23
Merge branch 'main' into python-promote-header-injection
2024-05-08 13:49:00 +01:00
Jeroen Ketema
1a53b923a6
C++: Ensure destructors for ifs are called after both branches
2024-05-08 14:48:28 +02:00
Sylwia Budzynska
944f8842b7
Change getASuccessor() to getASubscript()
2024-05-08 14:44:06 +02:00
Michael Nebel
64145cf181
Java: Make it evident that we print signature of the lifted callable.
2024-05-08 14:42:53 +02:00
Michael Nebel
f00ad7c0e7
C#/Java: Invert api filtering logic.
2024-05-08 14:42:53 +02:00
Michael Nebel
5e2e224c9c
Java: Updated expected test output.
2024-05-08 14:42:53 +02:00
Michael Nebel
e8120afef9
Java: Improve super implementation and ensure that lift produces a result.
2024-05-08 14:42:52 +02:00
Sylwia Budzynska
8bb4193704
Put GradioInterface models into GradioInput
2024-05-08 14:36:42 +02:00
Paolo Tranquilli
e359744b8b
Go: bring back qhelp in action
2024-05-08 14:31:00 +02:00
Michael B. Gale
896fb87d1d
Go: Fix err being shadowed in RunListWithEnv
2024-05-08 13:29:28 +01:00
Michael B. Gale
724d026238
Go: Move go list functions to toolchain package
2024-05-08 13:29:28 +01:00
Sylwia Budzynska
eaba798e34
Apply suggestions from code review
...
Co-authored-by: yoff <lerchedahl@gmail.com >
2024-05-08 14:26:34 +02:00
Jeroen Ketema
52db1c1253
C++: Introduce abstract class to share code between if and constexpr if
2024-05-08 14:16:19 +02:00
Jeroen Ketema
fa06d88642
C++: Add forgotten getLastChild to TranslatedConstExprIfStmt
2024-05-08 14:07:29 +02:00
Rasmus Wriedt Larsen
24f8b5f203
misc: Fix docstring warning
...
When using a sufficiently new version of Python, it will give a warning
about the escape sequence `\_` in `¯\_(ツ)_/¯` not being a valid escape
:D fix is to make the docstring a raw string.
Thanks @owen-mc
2024-05-08 13:56:11 +02:00
Jeroen Ketema
7b89c6c7f7
Merge pull request #16450 from jketema/inconsistent
...
C++: Add IR tests demonstrating some inconsistencies that may occur
2024-05-08 13:32:01 +02:00
Jeroen Ketema
9bc04e7591
Merge pull request #16447 from jketema/destructors-loc
...
C++: Update test results after extractor changes
2024-05-08 13:03:46 +02:00
Michael Nebel
2a40a2a57f
Java: Add some inheritance test cases for the model generator and updated expected test output.
2024-05-08 13:01:41 +02:00
Michael Nebel
c5403f4249
Merge pull request #16431 from michaelnebel/java/madinlinetest
...
Java: Models as Data inline like test.
2024-05-08 12:59:41 +02:00
Geoffrey White
3fd6bc9b5c
C++: Fix qhelp format.
2024-05-08 11:46:07 +01:00
Geoffrey White
486226814a
C++: Add a second example.
2024-05-08 11:40:29 +01:00
Paolo Tranquilli
12c28f3f68
Go: reorganize CI steps
2024-05-08 12:32:57 +02:00
Geoffrey White
871fd9aba3
Merge pull request #16405 from geoffw0/qhelp3
...
C++: Improve qhelp for StrncpyFlippedArgs.
2024-05-08 11:23:41 +01:00
Paolo Tranquilli
5b1b30a171
Apply suggestions from code review
...
Co-authored-by: Michael B. Gale <mbg@github.com >
2024-05-08 12:23:16 +02:00
Geoffrey White
880d56c576
Merge pull request #16404 from geoffw0/qhelp2
...
C++: Improve qhelp for WrongTypeFormatArguments.
2024-05-08 11:22:57 +01:00
Geoffrey White
9c8945f626
Merge pull request #16403 from geoffw0/qhelp1
...
C++: Improve qhelp for IncorrectNotOperatorUsage.
2024-05-08 11:22:15 +01:00
Jeroen Ketema
6575927630
C++: Add IR tests demonstrating some inconsistencies that may occur
2024-05-08 11:43:58 +02:00
Jeroen Ketema
2dcb55cc42
C++: Add bool operator to IR test
2024-05-08 11:38:50 +02:00
Joe Farebrother
23fbfcee27
Exclude new private heuristics from swift sensitive credential
2024-05-08 10:02:00 +01:00
Joe Farebrother
5f4bc4197b
Add private category to sensitive data heuristics
2024-05-08 10:02:00 +01:00
Mathias Vorreiter Pedersen
65645821be
C++: Remove the 'BaseSourceVariableInstruction' column as it's functionally determined by the address column.
2024-05-08 10:00:48 +01:00
Owen Mansel-Chan
0338ffd125
Merge pull request #16444 from owen-mc/shared/update-summary-through-step-value
...
Shared data flow: Make summaryThroughStepValue include param outputs
2024-05-08 09:53:30 +01:00
Jeroen Ketema
61580da14d
C++: Update test results after extractor changes
2024-05-08 08:43:20 +02:00
erik-krogh
3989717878
Merge branch 'main' into cpp-path
2024-05-07 23:01:52 +02:00
erik-krogh
336c7de643
updates based on review
2024-05-07 22:58:49 +02:00
Erik Krogh Kristensen
8b91914826
Merge pull request #16417 from erik-krogh/dummyPass
...
JS: Remove some FPs from the hardcoded-credentials query
2024-05-07 18:00:58 +02:00
Geoffrey White
575b66a054
C++: Clarify the recommendation and example.
2024-05-07 16:52:50 +01:00
Geoffrey White
dd95a2abab
C++: Move qhelp.
2024-05-07 16:35:21 +01:00
Owen Mansel-Chan
aab43afd81
Swift: accept test changes
2024-05-07 15:36:48 +01:00
Mathias Vorreiter Pedersen
99940a6084
Merge pull request #16440 from MathiasVP/fix-iterator-to-expired-container-fp-2
...
C++: Fix location of SSA def for local variable addresses
2024-05-07 14:39:13 +01:00
Owen Mansel-Chan
c11fac81fd
Make summaryThroughStepValue include param outputs
...
This matches summaryThroughStepTaint.
2024-05-07 13:55:42 +01:00
Mathias Vorreiter Pedersen
85e71c30dc
Merge pull request #16442 from MathiasVP/add-uninitialized-local-fp
...
C++: Add `cpp/uninitialized-local` FP
2024-05-07 13:35:02 +01:00
Ben Ahmady
c529988b43
Update README.md
...
Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com >
2024-05-07 13:09:08 +01:00
Mathias Vorreiter Pedersen
8e95395382
C++: Accept more test changes.
2024-05-07 12:55:42 +01:00
Mathias Vorreiter Pedersen
61fb89721a
C++: Add 'cpp/uninitialized-local' FP.
2024-05-07 12:19:06 +01:00
Jeroen Ketema
8198b1a6ef
Merge pull request #16426 from jketema/destructors-ranged-based-cleanup
...
C++: Update test results after extractor changes
2024-05-07 13:11:00 +02:00
Paolo Tranquilli
ab3d21ce7e
Merge pull request #16441 from github/redsun82/lfs
...
Bazel: make `git_lfs_probe.py` compatible with python 3.8
2024-05-07 13:04:43 +02:00
Paolo Tranquilli
9f27eb3eda
Bazel: make git_lfs_probe.py compatible with python 3.8
2024-05-07 12:44:28 +02:00
Joe Farebrother
efda63d37a
Update test output
2024-05-07 10:49:55 +01:00
Jeroen Ketema
4eea214cb4
C++: Update test results after extractor changes
2024-05-07 11:10:07 +02:00
Jeroen Ketema
b8f62ae4d5
Merge pull request #16436 from jketema/jketema/throw-wrong
...
C++: Add test case that shows that no destructors are attached to unwinds
2024-05-07 11:07:24 +02:00
Joe Farebrother
0f7325ec68
Rename test directory and add comment to clarity on the purpose of splitting them.
2024-05-07 09:40:55 +01:00
Michael Nebel
5fe3ab7890
Java: Prepare for inline test sharing with C#.
2024-05-07 10:38:24 +02:00
Mathias Vorreiter Pedersen
53c2d2f1e7
C++: Accept test changes.
2024-05-07 09:10:58 +01:00
Mathias Vorreiter Pedersen
07d51a55fd
C++: Assign a meaningful definition location to the address of an SSA variable when it's available.
2024-05-07 09:10:58 +01:00
Mathias Vorreiter Pedersen
41b95a1938
Merge pull request #16416 from MathiasVP/add-iterator-to-expired-container-fp-2
...
C++: Add `cpp/iterator-to-expired-container` FP
2024-05-07 09:10:38 +01:00
Michael Nebel
cfb0a862c1
Merge pull request #16356 from michaelnebel/csharp/aligntelemetryimplementation
...
C#: Base telemetry Api Source/Sink nodes on abstract classes.
2024-05-07 09:16:38 +02:00
Jeroen Ketema
9b23635d0a
C++: Add test case that shows that no destructors are attached to unwinds
2024-05-06 17:47:55 +02:00
Paolo Tranquilli
bbdc2752ac
Merge branch 'main' into redsun82/go-make
2024-05-06 17:43:48 +02:00
Paolo Tranquilli
e546560d7c
Kotlin: restore kotlin-compiler-embeddable-1.7.0.jar to the maven central version
2024-05-06 17:37:16 +02:00
Paolo Tranquilli
514e24ce62
Kotlin: bring back lazy LFS dependencies
...
This reverts commit d7ecaae245 .
Problems with lazy LFS rules were solved by
https://github.com/github/codeql/pull/16393 and
https://github.com/github/codeql/pull/16434 .
2024-05-06 17:31:50 +02:00
Paolo Tranquilli
239b6d8c8e
Merge branch 'main' into redsun82/kotlin
2024-05-06 17:24:53 +02:00
Paolo Tranquilli
5c74bebe6c
Merge pull request #16317 from github/redsun82/go
...
Go: add bazel build
2024-05-06 16:55:58 +02:00
Michael Nebel
757cf8d43a
C#: Fix a comment typo.
2024-05-06 16:48:31 +02:00
Michael Nebel
b53fa0f7f3
Java: Ensure that it is the callable for the model origin that carries the comment containing the model.
2024-05-06 16:41:58 +02:00
Paolo Tranquilli
d85f81d699
Merge pull request #16435 from github/redsun82/buildifier
...
Bazel: move buildifier out of root `BUILD`
2024-05-06 16:41:25 +02:00
Paolo Tranquilli
7c7bdb2242
Merge pull request #16434 from github/redsun82/lfs
...
Bazel: fix lfs lazy rule when all objects are local
2024-05-06 16:40:59 +02:00
Paolo Tranquilli
92b3eda12d
Bazel: move buildifier out of root BUILD
...
See https://github.com/github/codeql/pull/16428 for details as to why
this is necessary.
2024-05-06 16:00:05 +02:00
Michael Nebel
a8549d2e23
Java: Convert remaining tests to inline flow tests.
2024-05-06 15:54:01 +02:00
Paolo Tranquilli
54c9aea251
Bazel: fix lfs lazy rule when all objects are local
2024-05-06 15:47:43 +02:00
Paolo Tranquilli
e71d038d7f
Go: specify Go runtime version in actions
2024-05-06 14:57:24 +02:00
Paolo Tranquilli
c123513311
Go: bring back test action
...
This reverts commit 9055d9567a .
2024-05-06 14:56:57 +02:00
Paolo Tranquilli
bab2dd4427
Go: bring back make and CI changes
...
This reverts commit 12b9b805e2 .
2024-05-06 14:56:21 +02:00
Paolo Tranquilli
73df4fa920
Go: fix Windows installation
2024-05-06 14:55:35 +02:00
am0o0
4a2ab49efb
better structure for pandas DataFrame, it is now much better readable and also we can find much more DataFrame objects
2024-05-06 14:36:10 +02:00
am0o0
8b93e815b9
minor test cases change: remove unused dict
2024-05-06 14:36:10 +02:00
amammad
6b9cc1a278
update Twisted document link
2024-05-06 14:36:10 +02:00
amammad
c4a38d0a2f
add twisted SSH client as secondary server command injection sinks, add proper test cases
2024-05-06 14:36:10 +02:00
amammad
0a765cc94a
add jsonpickle and pexpect libs in case of unsafe decoding and secondary command execution, add proper test cases
2024-05-06 14:36:10 +02:00
amammad
7e93102097
finalize Secondary server command injection queries and tests.
2024-05-06 14:36:10 +02:00
amammad
ead247469d
add ssh client libraries, add SecondaryServerCmdInjectionCustomizations
2024-05-06 14:36:10 +02:00
amammad
4df73f9975
continue to convert paramiko query to a more general query,
...
the proxy command is not a secondary command execution
so we can add proxy command to SystemCommandExecution::Range, update QLDocs,
add a proper Paramiko test case
fix a typo
2024-05-06 14:36:10 +02:00
amammad
5fea71e5d6
convert paramiko query to SecondaryServerCmdInjection query, Add inline tests
2024-05-06 14:36:10 +02:00
amammad
6520e2fdfb
update Fabric models, add new sink to Fabric, add proper test cases
2024-05-06 14:36:10 +02:00
amammad
2708e57e4b
add pyTorch :) code execution sinks, add proper tests
2024-05-06 14:36:10 +02:00
amammad
cffdc5b452
add panas code execution sinks, add proper tests
2024-05-06 14:36:10 +02:00
Michael Nebel
95ddd6ec74
Java: Generalize the inline mad test to allow further re-use.
2024-05-06 13:57:18 +02:00
Michael Nebel
51e7f3be1a
Java: Rename MaD to summary.
2024-05-06 13:03:38 +02:00
Paolo Tranquilli
5b184c179a
Bazel/Go: add some comments
2024-05-06 12:48:01 +02:00
Paolo Tranquilli
cba4ba042c
Merge branch 'main' into redsun82/go
2024-05-06 12:43:56 +02:00
Michael Nebel
a33393d452
Java: Delete old summary models expected output.
2024-05-06 11:02:04 +02:00
Michael Nebel
7cb8a6c52f
Java: Inline models as data expected output as comments in the java files and add a test.
2024-05-06 11:01:23 +02:00
Michael Nebel
6815bcaa80
Java: Move param module into TestUtilities.
2024-05-06 10:19:39 +02:00
Michael Nebel
105984f7de
Java: Make param module for MaD inline test.
2024-05-06 10:01:34 +02:00
Tom Hvitved
6233da3e40
Merge pull request #16399 from hvitved/csharp/unique-get-location
...
C#: Make `Element.getLocation` (mostly) functional
2024-05-05 20:18:19 +02:00
Chuan-kai Lin
e68165fcb7
Swift: Use entities in reorder directives
2024-05-03 11:18:42 -07:00
Chuan-kai Lin
cbc0261567
Ruby: Use entities in reorder directives
2024-05-03 11:18:15 -07:00
Chuan-kai Lin
535e6db40f
Python: Use entities in reorder directives
2024-05-03 11:17:41 -07:00
Chuan-kai Lin
9b51e0e0ee
JS: Use entities in reorder directives
2024-05-03 11:17:13 -07:00
Chuan-kai Lin
30b5d5092d
Java: Use entities in reorder directives
2024-05-03 11:16:31 -07:00
Chuan-kai Lin
1dd3a0fd76
Go: Use entities in reorder directives
2024-05-03 11:16:08 -07:00
Chuan-kai Lin
077a2e3479
C#: Use entities in reorder directives
2024-05-03 11:15:42 -07:00
Chuan-kai Lin
ca9567debc
C++: Use entities in reorder directives
2024-05-03 11:14:41 -07:00
Mathias Vorreiter Pedersen
5d5e31378b
Merge pull request #16415 from MathiasVP/cleanup-ir-variables
2024-05-03 18:49:11 +01:00
Jeroen Ketema
5cde3fa697
Merge pull request #16414 from jketema/range-based-for-loop-destructor-fix
...
C++: Correctly handle destructors at the end of range-based for-loops in the IR
2024-05-03 19:38:45 +02:00
erik-krogh
39a8b49222
add qhelp recommendation that you can use an obvious placeholder value
2024-05-03 19:37:31 +02:00
erik-krogh
b209fc67cb
test the change to hardcoded-credentials
2024-05-03 19:34:18 +02:00
Paolo Tranquilli
77128de105
Bazel/Go: make installer work from internal repo and on windows
...
It turns out everything that is needed for the installer to work on
windows is enabling runfiles. This also requires symlinks to avoid
excessive copying of files.
2024-05-03 17:45:57 +02:00
Mathias Vorreiter Pedersen
7a1b85aa56
C++: Add FP test.
2024-05-03 16:04:21 +01:00
Geoffrey White
eb0621ab7a
Merge pull request #16406 from geoffw0/test1
...
C++: Add test case for reassignment to UseAfterFree.ql.
2024-05-03 15:32:58 +01:00
Geoffrey White
c0cf1c7c8c
Merge pull request #16402 from geoffw0/stringlifetimedoc
...
C++: Improve UseOfStringAfterLifetimeEnds doc.
2024-05-03 15:04:07 +01:00
Paolo Tranquilli
17990da205
Update go/extractor/BUILD.bazel
...
Co-authored-by: Cornelius Riemenschneider <cornelius@github.com >
2024-05-03 15:58:43 +02:00
Mathias Vorreiter Pedersen
d5475c4a89
C++: Delete predicate that I introduced by mistake.
2024-05-03 14:48:01 +01:00
Paolo Tranquilli
471303bd7c
Bazel/Go: remove unneeded comment
2024-05-03 14:56:17 +02:00
Paolo Tranquilli
2132c7bf96
Bazel/Go: make @codeql//go:gen runnable from internal repo
2024-05-03 14:52:17 +02:00
Mathias Vorreiter Pedersen
7ca54a6f94
C++: Sync identical files.
2024-05-03 13:51:04 +01:00
Mathias Vorreiter Pedersen
e8cb8b4f81
C++: Convert IR variables to an abstract base class and use final alias'ing to ensure that we don't accidentially extend the abstract base class.
2024-05-03 13:50:50 +01:00
Jeroen Ketema
ba64cf3016
C++: Correctly handle destructors at the end of range-based for-loops in the IR
2024-05-03 14:38:37 +02:00
Tom Hvitved
3c91333d0b
Address review comment
2024-05-03 14:09:41 +02:00
erik-krogh
d9e8e0e00a
use some more standard values for credentials-kind for NodeJS client credentials
2024-05-03 13:58:37 +02:00
erik-krogh
ff85db36e2
exclude credentials as kind key from hardcoded-credentials when the key looks like a dummy password
2024-05-03 13:58:11 +02:00
Paolo Tranquilli
8f0b88497a
Bazel/Go: be more specific in go/extractor/BUILD.bazel comments
2024-05-03 13:15:08 +02:00
Paolo Tranquilli
31c427e64c
Bazel/Go: add more explanation in gen.py
2024-05-03 13:15:08 +02:00
Michael Nebel
e64a2d6c9c
C#: Align telemetry implementation with Java.
2024-05-03 12:48:14 +02:00
Geoffrey White
807e6795a7
Apply suggestions from code review
...
Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com >
2024-05-03 11:40:56 +01:00
Paolo Tranquilli
880262d462
Merge pull request #16393 from github/redsun82/lfs
...
Bazel: improved lazy lfs files
2024-05-03 12:37:41 +02:00
Michael Nebel
95ff5bae65
Merge pull request #16297 from michaelnebel/java/improveapitelemetry
...
Java: Identify more APIs as supported in the telemetry queries.
2024-05-03 12:34:19 +02:00
Paolo Tranquilli
6cbe16e0c2
Bazel: add progress reporting
2024-05-03 12:00:15 +02:00
Mathias Vorreiter Pedersen
75615f2817
Merge pull request #16373 from jketema/destructors-block-fix
...
C++: Update test results after extractor changes
2024-05-03 10:17:40 +01:00
Michael Nebel
c07bf65eb6
Update java/ql/lib/semmle/code/java/dataflow/FlowSources.qll
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2024-05-03 11:13:05 +02:00
Michael Nebel
8def1c2c13
Java: Address review comments and some other code quality improvements.
2024-05-03 11:11:52 +02:00
Rasmus Wriedt Larsen
1b90f22e84
Merge pull request #16400 from RasmusWL/accept-ci-fixes
...
.expected script: Handle multiple job failure URLs
2024-05-03 09:58:47 +02:00
Paolo Tranquilli
ecdf62376d
Bazel: clean up git_lfs_probe.py
2024-05-03 09:21:57 +02:00
Geoffrey White
f5431abb10
C++: Fix strncpy reference link (the old link was broken).
2024-05-02 17:37:52 +01:00
Geoffrey White
73cc211779
C++: Fix qhelp error.
2024-05-02 17:36:35 +01:00
Geoffrey White
08e08a2b3a
C++: Qhelp punctuation.
2024-05-02 17:32:24 +01:00
Geoffrey White
657402b42f
C++: Fix % character in qhelp.
2024-05-02 17:31:09 +01:00
Geoffrey White
ecbf7aef18
C++: Fix qhelp formatting.
2024-05-02 17:26:24 +01:00
Geoffrey White
669fc925e0
C++: Fix qhelp formatting.
2024-05-02 17:24:20 +01:00
Geoffrey White
8a04840f93
C++: Improve qhelp for IncorrectNotOperatorUsage.ql, including mention of an alternative fix.
2024-05-02 17:17:55 +01:00
Geoffrey White
f4e4e238ba
C++: Add test cases for IncorrectNotOperatorUsage.ql.
2024-05-02 17:17:55 +01:00
Geoffrey White
8f682ef4e4
C++: Improve quality of some qhelp references.
2024-05-02 17:08:26 +01:00
Paolo Tranquilli
96d69ca49c
Merge branch 'main' into redsun82/lfs
2024-05-02 18:05:50 +02:00
Geoffrey White
8a261b7e7a
C++: Update StrncpyFlippedArgs.qhelp.
2024-05-02 17:04:49 +01:00
Paolo Tranquilli
daea674095
Bazel: cover standard https git credentials in git_lfs_probe.py
2024-05-02 18:02:22 +02:00
Geoffrey White
315f439135
C++: Add test case for reassignment to UseAfterFree.ql.
2024-05-02 16:40:28 +01:00
Geoffrey White
06d8892e03
C++: Rename an example file.
2024-05-02 16:39:59 +01:00
Geoffrey White
e22159ab5d
C++: Update WrongTypeFormatArguments.qhelp.
2024-05-02 16:34:56 +01:00
Geoffrey White
355c7d9b41
C++: Rename an example file.
2024-05-02 16:34:49 +01:00
Paolo Tranquilli
00baccbc15
Go: autoformat
2024-05-02 17:08:23 +02:00
Paolo Tranquilli
81dea9f89a
Merge branch 'main' into redsun82/go
2024-05-02 17:03:09 +02:00
Paolo Tranquilli
76067cb12d
Go: skip X:nocoverageredesign printing by autobuilder built with bazel
2024-05-02 17:02:48 +02:00
Geoffrey White
e4cf7df38f
C++: Edits to the .qhelp based on suggestions.
2024-05-02 16:00:31 +01:00
Geoffrey White
b8b3689251
C++: Autoformat.
2024-05-02 15:49:56 +01:00
Geoffrey White
0693bf9e75
C++: Improve UseOfStringAfterLifetimeEnds qhelp, references and alert message.
2024-05-02 15:40:27 +01:00
Paolo Tranquilli
1aafc377ad
Revert "Go: write test go runtime version in a specific file"
...
This reverts commit abcd9165b4 .
2024-05-02 16:22:24 +02:00
Paolo Tranquilli
abcd9165b4
Go: write test go runtime version in a specific file
2024-05-02 16:09:11 +02:00
Paolo Tranquilli
0bc6934bfc
Go: rename pkg_files to something less confusing
2024-05-02 15:44:06 +02:00
Paolo Tranquilli
4ae82ac215
Go: add explanatory comment to extractor BUILD file
2024-05-02 15:40:13 +02:00
Rasmus Wriedt Larsen
ccad70897d
Add --dont-wait option
2024-05-02 15:39:07 +02:00
Paolo Tranquilli
318d954536
Go: make //go:gen not clear by default, and clean on --force
2024-05-02 15:38:47 +02:00
Rasmus Wriedt Larsen
3239af9973
Handle multiple job failure URLs
...
CI has changed how jobs are being run 🤷
2024-05-02 15:31:56 +02:00
Mathias Vorreiter Pedersen
f7113e0105
Merge pull request #16345 from MathiasVP/cleanup-ssa-and-iterator-flow
...
C++: Clean up SSA and stop relying on memory edges for iterator flow
2024-05-02 14:21:25 +01:00
Paolo Tranquilli
ca2d94b297
Fix go pattern in .pre-commit-config.yaml
2024-05-02 15:15:45 +02:00
Rasmus Wriedt Larsen
2cff081f2b
Minor fixes to CI script.
...
I had problems with proper resolution of codeql_repo_dir with old python installation, this fixes it
2024-05-02 15:13:50 +02:00
Paolo Tranquilli
9055d9567a
Go: remove unused action (will be re-added later)
2024-05-02 15:08:51 +02:00
Tamás Vajk
f99cb3f649
Merge pull request #16396 from tamasvajk/buildless/opt-out-feed-check
...
C#: Change nuget feed responsiveness checking to be opt-out
2024-05-02 15:04:28 +02:00
Tamás Vajk
dfdd79d8cf
Merge pull request #16395 from tamasvajk/buildless/logs1
...
C#: Add file path to log messages in assets.json parsing
2024-05-02 15:03:57 +02:00
Tom Hvitved
8ec4f0b5bd
C#: Update expected test output
2024-05-02 14:53:02 +02:00
Mathias Vorreiter Pedersen
b912918d8b
C++: Fix QLDoc.
2024-05-02 13:32:52 +01:00
Harry Maclean
ef88f3ed09
Merge pull request #16377 from hmac/hmac-sanitization-fp
...
Ruby: Fix StringSubstitutionCall charpred
2024-05-02 13:31:01 +01:00
Tom Hvitved
f5d4b2e6cd
C#: Make Element.getLocation (mostly) functional
2024-05-02 14:16:34 +02:00
Michael Nebel
8b0f3af5b1
Java: Update change-note.
2024-05-02 14:05:44 +02:00
Felicity Chapman
54793cfa01
Update a couple of reusables
2024-05-02 12:52:43 +01:00
Tamas Vajk
d909f2bc4f
Fix expected test output
2024-05-02 13:32:01 +02:00
Felicity Chapman
7f27127301
Update docs/codeql/reusables/vs-code-deprecation-note.rst
2024-05-02 12:02:09 +01:00
Paolo Tranquilli
520a2c96ff
Merge branch 'main' into redsun82/go
2024-05-02 12:41:51 +02:00
Paolo Tranquilli
12b9b805e2
Go: revert changes to make and CI to postpone them in a separate PR
2024-05-02 12:37:47 +02:00
Felicity Chapman
6eb07a7a7e
Apply suggestions from code review
...
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com >
2024-05-02 11:05:39 +01:00
Owen Mansel-Chan
9bfb189fa7
Merge pull request #16392 from owen-mc/external-flow/standardize-empty-model-yml
...
External flow: standardize `empty.model.yml`
2024-05-02 11:01:47 +01:00
Mathias Vorreiter Pedersen
322fa36359
C++: Fix QLDoc.
2024-05-02 10:37:49 +01:00
Mathias Vorreiter Pedersen
4a47e11a16
C++: Fix QLDoc.
2024-05-02 10:36:40 +01:00
Owen Mansel-Chan
83249cd9c2
Fix grammar in comment
2024-05-02 09:59:48 +01:00
Tamas Vajk
c6185b30ba
C#: Change nuget feed responsiveness checking to be opt-out
2024-05-02 10:25:12 +02:00
Tamas Vajk
9ce08c586c
C#: Add file path to log messages in assets.json parsing
2024-05-02 10:14:26 +02:00
Paolo Tranquilli
a8d3226e99
Merge branch 'main' into redsun82/go
2024-05-02 09:27:47 +02:00
Paolo Tranquilli
94212d103e
Bazel/Go: remove apple_support
...
This was actually unnecessary, and requried a full Xcode installation
that we'd rather avoid.
2024-05-02 09:21:47 +02:00
Paolo Tranquilli
608791fd7f
Bazel/Go: use native cross compilation for fat binaries
2024-05-02 09:21:43 +02:00
Harry Maclean
7d92ec5ddf
Merge pull request #16378 from hmac/hmac-sanitization-wording
...
Ruby: fix wording in rb/request-without-cert-validation
2024-05-02 08:00:28 +01:00
Paolo Tranquilli
9157dee0db
Bazel: integrate download_and_extract into lfs_smudge
2024-05-02 08:53:51 +02:00
Paolo Tranquilli
677520aa8e
Bazel: improved lazy lfs files
...
This reintroduces lazy lfs file rules that were removed in
https://github.com/github/codeql/pull/16117 , now improved.
The new rules will make the actual file download go through bazel's
download manager, which includes:
* caching into the repository cache
* sane limiting of concurrent downloads
* retries
The bulk of the work is done by `git_lfs_probe.py`, which will use the
LFS protocol (with authentication via SSH) to output short lived
download URLs that can be consumed by `repository_ctx.download`.
2024-05-02 06:38:26 +02:00
Owen Mansel-Chan
16dcc0969b
Standardise comment explaining why extensible predicates must be defined
2024-05-01 22:00:01 +01:00
Owen Mansel-Chan
09e59ccf44
Name files with empty definitions of MaD extensible predicates to erowdmpty.model.yml
2024-05-01 21:39:38 +01:00
Mathias Vorreiter Pedersen
a8f2cbc2b1
Merge pull request #16331 from mario-campos/mario-campos/guarded-free
...
Cpp: new experimental query cpp/guarded-free
2024-05-01 17:32:44 +01:00
Harry Maclean
c00d0d302d
Ruby: fix wording in rb/request-without-cert-validation
2024-05-01 17:25:58 +01:00
Mario Campos
5a7a1dc92e
C++: forgot to import semmle.code.cpp.controlflow.Guards
2024-05-01 11:00:19 -05:00
Mario Campos
c480431ec0
C++: simplify cpp/guarded-free
...
This new form is more declarative by use of the `GuardCondition`. Thanks to the tireless effort of @MathiasVP!
2024-05-01 10:59:16 -05:00
Harry Maclean
f7fc2e0b00
Ruby: Fix StringSubstitutionCall charpred
...
Some missing parens meant this class targeted way more things than
intended.
2024-05-01 16:14:58 +01:00
Michael B. Gale
397e641f2f
Merge pull request #16375 from github/mbg/go/allow-version-suffixes
...
Go: Allow version suffixes
2024-05-01 15:41:54 +01:00
Michael B. Gale
00cbfaf40e
Go: Allow version suffixes
2024-05-01 15:00:45 +01:00
Michael Nebel
42653b5fec
Java: Add change note about local query removal.
2024-05-01 13:07:22 +02:00
Michael Nebel
58bbfe694f
Java: Deprecate the content of ExecTaintedLocalQuery as this is unused.
2024-05-01 13:07:21 +02:00
Michael Nebel
d9c7401ea2
Java: Deprecate the local content of UrlRedirectLocalQuery and remove the local query variant.
2024-05-01 13:07:21 +02:00
Michael Nebel
ed7538d0b9
Java: Deprecate the local content of TaintedPathQuery and remove the local query variant.
2024-05-01 13:07:21 +02:00
Michael Nebel
5b89bd23c7
Java: Deprecate the content of SqlTaintedLocalQuery and remove the local query variant.
2024-05-01 13:07:21 +02:00
Michael Nebel
b68abab12a
Java: Deprecate the content of ResponseSplittingLocalQuery and remove local query variant.
2024-05-01 13:07:21 +02:00
Michael Nebel
d05c5e3d94
Java: Deprecate the content of NumericCastTaintedLocalQuery, remove the local query variant and update the non-local query variant.
2024-05-01 13:07:21 +02:00
Michael Nebel
301a6cc191
Java: Deprecate the content of ImproperValidationOrArray and remove local query variants.
2024-05-01 13:07:21 +02:00
Michael Nebel
acd0fa4b7b
Java: Deprecate the content of ExternallyControlledFormatStringLocalQuery and remove the externally controlled format string local query variant.
2024-05-01 13:07:21 +02:00
Michael Nebel
85a4dd0325
Java: Deprecate the local content of CommandLineQuery and remove the exec tainted local query variant.
2024-05-01 13:07:20 +02:00
Mathias Vorreiter Pedersen
dc4604f5a5
Merge pull request #16367 from MathiasVP/better-documentation-for-iterator-to-expired-container
...
C++: Improve documentation for `cpp/iterator-to-expired-container`
2024-05-01 11:56:27 +01:00
Mathias Vorreiter Pedersen
40b6e1624f
Update cpp/ql/src/Security/CWE/CWE-416/IteratorToExpiredContainer.qhelp
...
Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com >
2024-05-01 11:41:23 +01:00
Mathias Vorreiter Pedersen
22e843abc6
Update cpp/ql/src/Security/CWE/CWE-416/IteratorToExpiredContainer.qhelp
...
Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com >
2024-05-01 11:41:16 +01:00
Jeroen Ketema
3c70a2d7df
C++: Update test results after extractor changes
2024-05-01 12:30:38 +02:00
Jeroen Ketema
541effb8cb
Merge pull request #16369 from jketema/destructors-init-stmt
...
C++: Update IR tests after better handling of init statements in the extractor
2024-05-01 10:47:03 +02:00
Anders Schack-Mulligen
248ffa15a2
Merge pull request #16318 from aschackmull/dataflow/doublyboundedfasttc
...
Dataflow: Use doublyBoundedFastTC.
2024-05-01 09:48:23 +02:00
Michael Nebel
072f19008a
Java: Deprecate the content of ArithmeticTaintedLocalQuery and remove the arithmetic tainted local query variant.
2024-05-01 08:59:51 +02:00
Michael Nebel
93988e5834
Java: Deprecate the content of XxeLocalQuery and remove the Xxe local query variant.
2024-05-01 08:59:50 +02:00
Michael Nebel
e0c2a43780
Java: Deprecate the content of XssLocalQuery and remove the Xss local query variant.
2024-05-01 08:59:50 +02:00
Jeroen Ketema
5843326b5c
C++: Update IR tests after better handling of init statements in the extractor
2024-04-30 21:12:30 +02:00
Mathias Vorreiter Pedersen
3a2b0a2feb
Merge pull request #16366 from MathiasVP/fix-ir-for-destructors-in-switch
...
C++: Fix IR destructor calls on `JumpStmt`s
2024-04-30 18:26:54 +01:00
Joe Farebrother
fd55713006
add changenote
2024-04-30 18:17:18 +01:00
Joe Farebrother
c6372d5822
Fix qldoc and remove PotentialViewCallable class
2024-04-30 18:13:06 +01:00
Mathias Vorreiter Pedersen
07dd6d5c8d
C++: Align 'break' statements.
2024-04-30 16:40:23 +01:00
Mathias Vorreiter Pedersen
708d12624f
C++: Update documentation on 'cpp/iterator-to-expired-container'.
2024-04-30 16:32:32 +01:00
Mathias Vorreiter Pedersen
3eddd3114f
C++: Accept test changes.
2024-04-30 16:14:30 +01:00
Mathias Vorreiter Pedersen
61ce7252e6
C++: Update the alert message in 'cpp/iterator-to-expired-container'.
2024-04-30 16:12:54 +01:00
Mathias Vorreiter Pedersen
b86aeb68ae
Merge pull request #16364 from MathiasVP/ir-guards-with-boolean
...
C++: Support `IRGuard`s with no implicit boolean conversion
2024-04-30 16:07:32 +01:00
Mathias Vorreiter Pedersen
cf025e1924
C++: Accept test changes.
2024-04-30 15:47:53 +01:00
Mathias Vorreiter Pedersen
a200ced2d6
C++: Fix IR generation for jump statements.
2024-04-30 15:46:46 +01:00
Mathias Vorreiter Pedersen
c04e59611b
Merge pull request #16355 from MathiasVP/promote-iterator-to-expired-container-out-of-experimental
...
C++: Promote `cpp/iterator-to-expired-container` out of experimental
2024-04-30 15:45:56 +01:00
Mathias Vorreiter Pedersen
c5a87c95d8
C++: Add tests that incorrectly call destructors twice.
2024-04-30 15:39:00 +01:00
Joe Farebrother
4f22b91e73
Add tests for cases not yet supported
2024-04-30 15:20:09 +01:00
Henry Mercer
797f675285
Merge pull request #16365 from github/post-release-prep/codeql-cli-2.17.2
...
Post-release preparation for codeql-cli-2.17.2
2024-04-30 14:51:01 +01:00
Mathias Vorreiter Pedersen
c32c810ae7
C++: Add a test with a 'short' type.
2024-04-30 14:48:21 +01:00
Mathias Vorreiter Pedersen
32fe084630
Update cpp/ql/lib/semmle/code/cpp/controlflow/IRGuards.qll
...
Co-authored-by: Jeroen Ketema <93738568+jketema@users.noreply.github.com >
2024-04-30 14:42:30 +01:00
Joe Farebrother
ba054bd428
Manually specify subclasses for redirect models
2024-04-30 14:33:46 +01:00
Ian Lynagh
0715c4ac5a
Merge pull request #16341 from igfoo/igfoo/ODASA_BUILD_ERROR_DIR
...
Java: Remove support for deprecated ODASA_BUILD_ERROR_DIR env var
2024-04-30 13:18:51 +01:00
github-actions[bot]
99928b82ed
Post-release preparation for codeql-cli-2.17.2
2024-04-30 12:15:35 +00:00
Rasmus Wriedt Larsen
377c6b4cc8
Merge pull request #12557 from felickz/patch-1
...
add security-severity score to code scanning query list
2024-04-30 13:48:22 +02:00
Mathias Vorreiter Pedersen
2939c89f7a
C++: Accept test changes.
2024-04-30 12:04:42 +01:00
Mathias Vorreiter Pedersen
bb6cc92728
C++: Support guards without implicit boolean conversions.
2024-04-30 12:04:35 +01:00
Mathias Vorreiter Pedersen
d736426529
C++: Support guards without implicit boolean conversions.
2024-04-30 11:45:58 +01:00
Mathias Vorreiter Pedersen
806d42852c
C++: Add test in C file with pointer type guard.
2024-04-30 11:33:22 +01:00
Henry Mercer
8e251ee54f
Merge pull request #16363 from github/release-prep/2.17.2
...
Release preparation for version 2.17.2
2024-04-30 11:29:06 +01:00
github-actions[bot]
5228d94d42
Release preparation for version 2.17.2
2024-04-30 10:25:51 +00:00
Geoffrey White
7d9f78b2de
Merge pull request #16328 from geoffw0/pathinj
...
C++: Reduce duplication from cpp/path-injection
2024-04-30 10:06:40 +01:00
Paolo Tranquilli
2590d8a27f
Merge branch 'main' into redsun82/go
2024-04-30 11:00:27 +02:00
Joe Farebrother
7df8b1ba51
Don't rely on specific parameter names, add qldoc
2024-04-30 09:45:11 +01:00
Erik Krogh Kristensen
7e839792da
Merge pull request #16330 from erik-krogh/del-deps-apr-2024
...
All: delete outdated deprecations
2024-04-30 10:43:39 +02:00
Paolo Tranquilli
98106f31c1
Merge pull request #16358 from github/redsun82/registry-override
...
Bazel: add empty registry override
2024-04-30 09:09:46 +02:00
Paolo Tranquilli
52a015fb11
Bazel: remove further unneeded files
2024-04-30 09:07:11 +02:00
Ian Lynagh
676bcf39a5
Java: Remove support for deprecated ODASA_BUILD_ERROR_DIR env var
2024-04-29 18:02:28 +01:00
Paolo Tranquilli
a28f87fff0
Bazel: add empty registry override
...
This will unblock work in parallel on two separate PRs that require
patching different modules.
2024-04-29 18:01:09 +02:00
Mathias Vorreiter Pedersen
94364f724e
C++: Remove CP between all sinks and all states in 'cpp/iterator-to-expired-container'.
2024-04-29 16:46:00 +01:00
Paolo Tranquilli
d4e0a5629d
Kotlin: update wrapper location
2024-04-29 17:33:40 +02:00
Paolo Tranquilli
b83417301f
Merge branch 'main' into redsun82/kotlin
2024-04-29 17:26:59 +02:00
Paolo Tranquilli
450f6518e2
Bazel: remove generic lazy lfs files
2024-04-29 17:26:48 +02:00
Paolo Tranquilli
d7ecaae245
Kotlin: back off from lazy LFS rules
...
Those have shown to cause problems with too many concurrent downloads.
This changes kotlinc dependencies fetching to:
* use `resource/kotlinc-dependencies` if available (which is the case
for the internal repo)
* otherwise, download them from maven.
This means sha256 hashes need to be written down for bazel.
2024-04-29 17:26:25 +02:00
Harry Maclean
607ed2efb4
Merge pull request #16354 from hmac/hmac-incomplete-hostname-fp
...
Ruby: Reduce FPs for rb/incomplete-hostname-regexp
2024-04-29 14:40:44 +01:00
Michael Nebel
a304e2d8d6
Merge pull request #16248 from michaelnebel/csharp/groupsprojectbeforerestore
...
C#: Restore projects and collect dependencies for projects in the same folder sequentially.
2024-04-29 14:05:40 +02:00
Paolo Tranquilli
cb85a756a0
Bazel: patch apple_support to avoid registering its toolchain
...
This is done in order to avoid requiring a full Xcode installation, but
still being able to use other `apple_support` facilities, like
`universal_binary`.
2024-04-29 13:42:05 +02:00
Paolo Tranquilli
e7886d0e57
Bazel: add empty registry override
2024-04-29 13:39:30 +02:00
yoff
1c611fecde
Merge pull request #16155 from yoff/python/MaD-method-arg-tests
2024-04-29 12:59:57 +02:00
Harry Maclean
51bc8e917e
Ruby: Reduce FPs for rb/incomplete-hostname-regexp
...
Arguments in calls to `match[?]` should only be considered regular
expression interpretations if the `match` refers to the standard library
method, not a method in source code.
2024-04-29 11:19:34 +01:00
Mathias Vorreiter Pedersen
0fa5a1f274
C++: Add change note.
2024-04-29 11:17:53 +01:00
Paolo Tranquilli
15bb846a5f
Go: add workaround for extractor pack windows installer
2024-04-29 12:17:47 +02:00
Mathias Vorreiter Pedersen
5c454bdd8c
C++: Compute and add severity.
2024-04-29 11:09:42 +01:00
Mathias Vorreiter Pedersen
f194c70e8a
C++: Set precision to medium.
2024-04-29 11:08:08 +01:00
Mathias Vorreiter Pedersen
179270ffc1
C++: Move 'cpp/iterator-to-expired-container' out of experimental.
2024-04-29 11:07:55 +01:00
Paolo Tranquilli
1f78882cdc
Go: make windows checks happy
2024-04-29 11:27:16 +02:00
Paolo Tranquilli
f0f6c229f6
Go: fix regex in action for macOS
2024-04-29 11:16:30 +02:00
Paolo Tranquilli
2f6dd2ab81
Go: refactor workflows with shared action
2024-04-29 11:12:48 +02:00
Paolo Tranquilli
6ec223c515
Go: small cleanup in Makefile
2024-04-29 11:00:21 +02:00
Harry Maclean
8ccedd658a
Merge pull request #16349 from hmac/hmac-uri-open
...
Ruby: Add URI.open example to rb/kernel-open qhelp
2024-04-29 09:42:39 +01:00
Mathias Vorreiter Pedersen
401717d739
C++: Add a missing taint step and accept test changes.
2024-04-29 09:38:42 +01:00
Mathias Vorreiter Pedersen
527409d05f
C++: Fix iterator return types and accept test changes.
2024-04-29 09:38:42 +01:00
Mathias Vorreiter Pedersen
d3d2e2188d
C++: Accept test changes.
2024-04-29 09:38:42 +01:00
Mathias Vorreiter Pedersen
141af7cc87
C++: Subclasses for both 'begin' and 'end'.
2024-04-29 09:38:42 +01:00
Mathias Vorreiter Pedersen
6e3dddede0
C++: Use iterator flow in dataflow.
2024-04-29 09:38:42 +01:00
Mathias Vorreiter Pedersen
683fe26034
C++: Add iterator flow based on dataflow SSA.
2024-04-29 09:38:41 +01:00
Mathias Vorreiter Pedersen
ea1b8a3999
C++: Implement 'getAnUltimateDefinition' on SSA definitions.
2024-04-29 09:38:41 +01:00
Mathias Vorreiter Pedersen
5f0efc19fa
C++: Accept test changes.
2024-04-29 09:38:41 +01:00
Paolo Tranquilli
0dfd336729
Go: fix //go:gen on windows
2024-04-29 10:34:22 +02:00
Paolo Tranquilli
b0758fd109
Go: workaround for gazelle on macOS
...
See https://github.com/bazelbuild/bazel-gazelle/issues/1793 for details.
2024-04-29 10:29:53 +02:00
Michael Nebel
d62e888b86
C#: Code quality improvements.
2024-04-29 09:27:12 +02:00
Mathias Vorreiter Pedersen
50775d0c53
C++: Get rid of 'UseImpl' in TSsaDefOrUse so that it now only contains definitions.
2024-04-29 00:02:05 +01:00
Mathias Vorreiter Pedersen
9874d40d29
C++: Make 'getAddressOperand' available on 'DefImpl'.
2024-04-28 23:41:18 +01:00
Mathias Vorreiter Pedersen
044ee9b08a
C++: Delete old iterator flow using memory edges.
2024-04-28 23:41:13 +01:00
Harry Maclean
8b23f6db10
Ruby: Add URI.open example to rb/kernel-open qhelp
2024-04-27 09:53:54 +01:00
Mathias Vorreiter Pedersen
3c2206728d
Merge pull request #16333 from MathiasVP/fix-guards-on-pointers
2024-04-26 21:33:08 +01:00
Jeroen Ketema
8c87cb83bb
Merge pull request #16342 from jketema/destructors-cleanup
...
C++: Don't emit destructor calls as part of 'TranslatedResultCopy' as this has already been done in some other 'TranslatedExpr'.
2024-04-26 22:05:00 +02:00
Mathias Vorreiter Pedersen
c9ce642e7a
Merge pull request #16339 from MathiasVP/one-less-stage
...
C++: Remove a stage by properly caching `getResultIRType`
2024-04-26 16:52:16 +01:00
Mathias Vorreiter Pedersen
d18cdee0bc
C++: Accept test changes.
2024-04-26 16:19:33 +01:00
Mathias Vorreiter Pedersen
b78537dd74
C++: Allow comparisons with pointer types in IRGuards.
2024-04-26 16:19:24 +01:00
Mathias Vorreiter Pedersen
e78091e9d0
C++: Sync identical files.
2024-04-26 16:19:02 +01:00
Mathias Vorreiter Pedersen
c10e00d389
C++: Add a subclass for constant instructions with pointer type.
2024-04-26 16:18:52 +01:00
Mathias Vorreiter Pedersen
bf61114284
C++: Add a test with pointer comparisons and float comparisons.
2024-04-26 16:17:45 +01:00
erik-krogh
800d7546fa
change all the change-notes to breaking
2024-04-26 17:17:23 +02:00
Mathias Vorreiter Pedersen
d6c57de650
C++: Convert one of the tests to also test the 'absolute' versions of the GuardCondition predicates.
2024-04-26 16:11:19 +01:00
Paolo Tranquilli
d66494dcb0
Go: update go-tests-other-os.yml
2024-04-26 17:03:56 +02:00
Paolo Tranquilli
86d6b8ef21
Go: put back go setup
2024-04-26 16:54:14 +02:00
Mathias Vorreiter Pedersen
6147a38bea
Merge pull request #16337 from MathiasVP/cache-second-level-scope
...
DataFlow: Cache `getSecondLevelScope`
2024-04-26 15:49:11 +01:00
Jeroen Ketema
67fb866efa
C++: Update test results
2024-04-26 16:38:39 +02:00
Paolo Tranquilli
0f387eeac2
Go: add vendor update to //go:gen
2024-04-26 16:31:04 +02:00
Mathias Vorreiter Pedersen
4b0a217420
C++: Don't emit destructor calls as part of 'TranslatedResultCopy' as this has already been done in some other 'TranslatedExpr'.
2024-04-26 16:25:05 +02:00
Mario Campos
3195f0c828
Use more specific hasGlobalName() for stdlib function free(3)
...
Based on the CodeQL documentation's example of strncpy(3) and strlen(3): https://codeql.github.com/docs/codeql-language-guides/hash-consing-and-value-numbering/#example-query
2024-04-26 09:10:40 -05:00
Paolo Tranquilli
d98ccdfa06
Go: update workflow
2024-04-26 16:02:22 +02:00
Paolo Tranquilli
c8b02241af
Merge branch 'main' into redsun82/go
2024-04-26 15:59:17 +02:00
Tamás Vajk
a707e14495
Merge pull request #16338 from tamasvajk/buildless/extractor-timing
...
C#: Store buildless extraction timing information and return in telem…
2024-04-26 15:59:01 +02:00
Paolo Tranquilli
146d84bbf8
Go: rework makefile
2024-04-26 15:20:33 +02:00
Tamas Vajk
1d45e3a558
C#: Store buildless extraction timing information and return in telemetry query
2024-04-26 14:59:31 +02:00
Mathias Vorreiter Pedersen
70e9c48a47
C++: Also implement the predicate in the raw stage.
2024-04-26 13:48:13 +01:00
Mathias Vorreiter Pedersen
dcc4ad2550
C++: Sync identical files.
2024-04-26 13:45:15 +01:00
Mathias Vorreiter Pedersen
54cadcfe9b
C++: Forward to a cached predicate in a cached module instead of caching the predicate in 'Instruction.qll' to include it in the cached stage of the other predicates.
2024-04-26 13:44:45 +01:00
Rasmus Lerchedahl Petersen
3716b8c6a0
Python: update test to reflect correct behaviour
...
also add comments
2024-04-26 14:21:15 +02:00
Rasmus Lerchedahl Petersen
9f7edf378e
Python: fix tests
...
The way to expose the `self` arguemnt
is to call an instance method on the class,
not on the instance...
2024-04-26 14:21:15 +02:00
Rasmus Lerchedahl Petersen
4f46ce1133
Python: add test for Argument[0, self, self:] for instance methods
2024-04-26 14:21:15 +02:00
Rasmus Lerchedahl Petersen
862942f3d8
python: extra test
...
suggested by @RasmusWL
2024-04-26 14:19:10 +02:00
Rasmus Lerchedahl Petersen
adc82b553b
Python: more realistic summaries
2024-04-26 14:19:10 +02:00
Rasmus Lerchedahl Petersen
c2252e12ac
python: sync files
2024-04-26 14:19:09 +02:00
Rasmus Lerchedahl Petersen
bab6ecf3bb
Python: test the MaD path for constructor calls
2024-04-26 14:19:09 +02:00
Michael Nebel
f95b33049e
Java: Improve the Api sources and sinks implementation.
2024-04-26 14:12:41 +02:00
Mathias Vorreiter Pedersen
2482519cd3
DataFlow: Cached second level scope.
2024-04-26 13:09:59 +01:00
Asger F
e44d4c45aa
Merge pull request #16323 from asgerf/js/expose-internal-module-naming
...
JS: Expose InternalModuleNaming
2024-04-26 13:57:26 +02:00
Paolo Tranquilli
bfa189e2ac
Go: use a dbscheme generated during the build in extractor-pack
2024-04-26 13:48:44 +02:00
Paolo Tranquilli
19b2e56d02
Go: group BUILD and dbscheme generation target
2024-04-26 13:38:10 +02:00
erik-krogh
14d88eb3ce
add change-notes
2024-04-26 12:56:28 +02:00
Michael Nebel
b754706e44
Java: Update SupportedExternalApi expected test output.
2024-04-26 12:39:46 +02:00
Michael Nebel
9db32f4d26
Java: Identify more APIs as supported in the telemetry queries (as QL defined sinks).
2024-04-26 12:39:46 +02:00
Michael Nebel
acb2bbb2a3
Java: Identify more APIs as supported in the telemetry queries (as QL defined sources).
2024-04-26 12:39:46 +02:00
Michael Nebel
06f987ad58
Java: Add test example of a supported sink defined in QL.
2024-04-26 12:39:46 +02:00
Paolo Tranquilli
925a2cca7e
Go: create whole extractor pack with bazel
2024-04-26 12:01:23 +02:00
Paolo Tranquilli
3ad9c026a5
Go: remove go_sdk.host
...
It's not required, and it can't work from the internal repository.
2024-04-26 11:20:47 +02:00
Paolo Tranquilli
7d9a68bf17
Go: wrap gazelle to regenerate from scratch and add header
2024-04-26 11:19:22 +02:00
Paolo Tranquilli
a841a2b0a2
Merge branch 'main' into redsun82/kotlin
2024-04-26 10:38:28 +02:00
erik-krogh
0468c5d0bf
delete some tests of the old GVN library
2024-04-26 07:58:35 +02:00
erik-krogh
e55f2c5309
reinroduce GLobalValueNumbering.qll, that one was supposed to stay
2024-04-26 06:52:57 +02:00
Mario Campos
d7c784ef2f
Initial commit of experimental query cpp/guarded-free.
2024-04-25 16:29:37 -05:00
erik-krogh
fb376a1cfd
revert the deletion of explorationLimit. It'll be deleted along with the entire class later
2024-04-25 22:31:11 +02:00
erik-krogh
baa31e1469
delete outdated deprecations
2024-04-25 22:19:28 +02:00
Jeroen Ketema
8d962a5c28
Merge pull request #16322 from jketema/child-stmt
...
C++: Print destructors for children of statements that are again statements
2024-04-25 22:17:35 +02:00
Jeroen Ketema
389df35fb7
Merge branch 'main' into child-stmt
2024-04-25 21:47:06 +02:00
Geoffrey White
aa80dd41da
Merge pull request #16329 from geoffw0/multibyte
...
C++: Fix typo.
2024-04-25 17:26:40 +01:00
Geoffrey White
553871678a
C++: Change note.
2024-04-25 16:52:01 +01:00
Geoffrey White
15123a7b40
C++: Reduce duplication.
2024-04-25 16:49:22 +01:00
Geoffrey White
bbd80ec7a4
C++: Add some more test cases.
2024-04-25 16:44:52 +01:00
Florin Coada
1d421b3b28
Merge pull request #16326 from github/changedocs/2.17.1
...
Update codeql-changelog index.rst to include codeql-cli-2.17.1
2024-04-25 16:08:41 +01:00
Joe Farebrother
2a0459838b
Add models for responses
2024-04-25 15:55:59 +01:00
Michael B. Gale
a87b991d78
Merge pull request #16325 from github/mbg/go/use-parse-instead-of-parselax
2024-04-25 15:20:36 +01:00
Geoffrey White
0fb71e24cb
C++: Fix typo.
2024-04-25 14:52:56 +01:00
Florin Coada
14d04903dc
Update codeql-changelog index.rst to include codeql-cli-2.17.1
2024-04-25 14:40:44 +01:00
Michael Nebel
181a063bb9
C#: Update expected test output.
2024-04-25 15:38:39 +02:00
Michael Nebel
131d0b911f
C#: Inline dependency collection from asset files per group.
2024-04-25 15:35:08 +02:00
Michael Nebel
0124b0749f
C#: Do not run dotnet restore in parallel for projects in the same folder.
2024-04-25 15:35:07 +02:00
Michael Nebel
6daf80cdd0
C#: Add integration test with multiple project files that have disjoint dependencies.
2024-04-25 15:35:07 +02:00
Tamás Vajk
9c139b591f
Merge pull request #16321 from tamasvajk/buildless/log-messages
...
C#: Improve log messages
2024-04-25 15:12:37 +02:00
Michael B. Gale
b8cfff6d19
Go: Use Parse instead of ParseLax, since we need toolchain directives
2024-04-25 14:10:26 +01:00
Michael B. Gale
f33d7ee80d
Go: Add unit tests for hasInvalidToolchainVersion
2024-04-25 14:09:47 +01:00
Michael B. Gale
15a6308c72
Go: Refactor condition for EmitInvalidToolchainVersion into separate function
2024-04-25 14:04:00 +01:00
Joe Farebrother
86d1e5b646
Add additional type tracking for request attributes
2024-04-25 13:58:36 +01:00
Tamas Vajk
dd9183c345
Code quality improvements
2024-04-25 14:38:26 +02:00
Asger F
d0c9e3f7ad
JS: Expose InternalModuleNaming
2024-04-25 13:33:17 +02:00
Asger F
9082972842
Merge pull request #16061 from RasmusWL/js-extractor-fix
...
JS: More robust CommonJS/ES2015 detection logic for extractor
2024-04-25 13:26:56 +02:00
Jeroen Ketema
05819a52ef
C++: Print destructors for children of statements that are again statements
2024-04-25 13:25:42 +02:00
Nick Rolfe
116873c9b0
Merge pull request #16314 from github/nickrolfe/rb-sensitive
...
Ruby: do fewer regexp matches in SensitiveActions
2024-04-25 11:56:41 +01:00
Rasmus Wriedt Larsen
290b0fc4ab
Merge pull request #16308 from asgerf/js/model-generation-quote
...
JS: Fix naming issue in generated models
2024-04-25 11:36:36 +02:00
Paolo Tranquilli
8e1d77bcb2
Bazel: format file
2024-04-25 11:05:57 +02:00
Paolo Tranquilli
1e622e168c
Merge branch 'main' into redsun82/kotlin
2024-04-25 11:05:19 +02:00
Paolo Tranquilli
332d118d93
Merge pull request #16315 from github/redsun82/buildifier
...
Bazel: introduce buildifier formatting
2024-04-25 10:48:18 +02:00
Owen Mansel-Chan
82bbecc9c4
Merge pull request #16307 from owen-mc/go/fix/incomplete-hostname-regex
...
Go: fix flow through string concatenation in `go/incomplete-hostname-regex`
2024-04-25 09:43:51 +01:00
Tamas Vajk
15c1fd9425
C#: Improve log messages
2024-04-25 10:39:53 +02:00
Ben Ahmady
be9009d653
Use clearer filename
2024-04-25 08:16:48 +00:00
Ben Ahmady
037211c4a4
Add formatting fixes
2024-04-25 08:10:27 +00:00
Rasmus Wriedt Larsen
13ff9412a4
Merge pull request #16252 from RasmusWL/move-dataflow-tests
...
Python: Move dataflow tests out of experimental
2024-04-25 10:05:06 +02:00
Jeroen Ketema
9d24b5afa6
Merge pull request #16319 from jketema/ir-comment-fix
...
C++: Fix comment in IR test
2024-04-25 09:59:58 +02:00
Ben Ahmady
8cba276b87
Deprecate the CodeQL for VS Code docs in favour of docs.github.com version
2024-04-25 07:59:33 +00:00
Paolo Tranquilli
4ca8faa9c9
Go: introduce universal binaries on macOS
2024-04-25 09:27:59 +02:00
Paolo Tranquilli
393f6b7666
Go: add gazelle-generated BUILD files
2024-04-25 08:53:26 +02:00
Jeroen Ketema
95ec4e8d26
C++: Fix comment in IR test
2024-04-24 21:47:47 +02:00
Tom Hvitved
17e0cc5648
Merge pull request #16313 from hvitved/dataflow/fix-bad-join3
...
Data flow: Fix bad join
2024-04-24 17:09:14 +02:00
Paolo Tranquilli
196b6d7a1d
CI: simplify reporting
2024-04-24 16:43:38 +02:00
Paolo Tranquilli
9def57250d
CI: make reporting better
2024-04-24 16:35:50 +02:00
Paolo Tranquilli
9af9873e04
CI: add names to steps
2024-04-24 16:20:54 +02:00
Paolo Tranquilli
9f5782b67b
Bazel: introduce buildifier formatting
...
This introduces tooling and enforcement for formatting bazel files.
The tooling is provided as a bazel run target from
[keith/buildifier-prebuilt](https://github.com/keith/buildifier-prebuilt ).
This is used in a [`pre-commit`](https://pre-commit.com/ ) hook for those
having that installed. In turn this is used in a CI check. Relying on a
`pre-commit` action gives us easy checking that buildifying did not
change anything in the files and printing the diff, without having to
hand-roll the check ourselves.
This enforcement will make usage of gazelle easier, as gazelle itself
might reformat files, even outside of `go`. Having them properly
formatted will allow gazelle to leave them unchanged, without needing
to configure awkward exclude directives.
2024-04-24 15:49:48 +02:00
Alex Ford
98a6d0fa26
Ruby: add another SQLi AR conditions test case
2024-04-24 14:46:53 +01:00
Alex Ford
6b0e7961fa
Ruby: prepare test case whitespace
2024-04-24 14:39:06 +01:00
Owen Mansel-Chan
c61177cf42
Add change note
2024-04-24 14:21:59 +01:00
Owen Mansel-Chan
4140942479
Update tests
2024-04-24 14:19:33 +01:00
Owen Mansel-Chan
fd306ed79b
Exclude constant names from sources to avoid duplicate results
2024-04-24 14:19:30 +01:00
Owen Mansel-Chan
8962307291
Add second good go file to tests
2024-04-24 14:19:29 +01:00
Owen Mansel-Chan
0000c72329
Remove attempt at avoiding duplicate alerts
2024-04-24 14:19:26 +01:00
Owen Mansel-Chan
3ef7a0932a
Add flow through string concatenation
2024-04-24 14:19:25 +01:00
Tamás Vajk
f29d2c21bd
Merge pull request #16312 from tamasvajk/fix/buildless/file-lookup
...
C#: Fix `global.json` and `packages.config` lookup
2024-04-24 15:05:55 +02:00
Joe Farebrother
53f69d9966
Reduce query tests with cases covered by concept tests
2024-04-24 14:05:42 +01:00
Joe Farebrother
8fb2faa89b
Add additional info to concept tests
2024-04-24 14:05:41 +01:00
Joe Farebrother
2b935e575a
Add concept tests + fix typo
2024-04-24 14:05:41 +01:00
Joe Farebrother
ec4c820391
Fix deprecation
2024-04-24 14:05:41 +01:00
Joe Farebrother
1dce2eb325
Rename to response splitting
2024-04-24 14:05:40 +01:00
Joe Farebrother
49e5f8a1a5
Add tests for instances of the header write concept
2024-04-24 14:05:40 +01:00
Joe Farebrother
f3b27d611a
Add test case for validated wsgiref servers + fix typo
2024-04-24 14:05:40 +01:00
Joe Farebrother
f57ba3e642
Add change note
2024-04-24 14:05:40 +01:00
Joe Farebrother
d4a072818f
Add more tests
2024-04-24 14:05:40 +01:00
Joe Farebrother
eeef062f7c
Implement sinks for wsgiref + allow lists in bulk header updates + local flow
2024-04-24 14:05:39 +01:00
Joe Farebrother
9d56f3eb68
Fix qldoc formatting
2024-04-24 14:05:39 +01:00
Joe Farebrother
cf8db4e425
Update instances of experimental concept to the main one, and anotate missing experimental test results.
2024-04-24 14:05:39 +01:00
Joe Farebrother
daa31b5bb7
Add documentation
2024-04-24 14:05:38 +01:00
Joe Farebrother
8636a50190
Fix qldoc + remove deprecation from experimental concepts (as they are still used in another experimental query)
2024-04-24 14:05:38 +01:00
Joe Farebrother
fa28d94363
Added a sanitizer for replacing newlines.
2024-04-24 14:05:38 +01:00
Joe Farebrother
dbbc944f32
Correct spelling
2024-04-24 14:05:38 +01:00
Joe Farebrother
a88ad62c00
Implemented sinks for bulk header updates, and added corresponding tests.
2024-04-24 14:05:38 +01:00
Joe Farebrother
3e9341ff8a
Model class instantiation for werkzueg headers
2024-04-24 14:05:37 +01:00
Joe Farebrother
b9984beb16
Add test cases
2024-04-24 14:05:37 +01:00
Joe Farebrother
68d90918cf
Add to header write concept a specification of whether the name or value arg allows newlines.
...
Ported sink defenitions from Flask and Werzeug from experimental to main.
Removed experimental sink definitions for Django, as neither name nor value are vulnerable.
2024-04-24 14:05:37 +01:00
Joe Farebrother
25ffcb2fde
Split into customizations file
2024-04-24 14:05:37 +01:00
Joe Farebrother
6021d9238c
Move headers injection query and concept from experimental to main
2024-04-24 14:05:37 +01:00
Tamás Vajk
3b44b131b9
Merge pull request #16311 from tamasvajk/fix/resx
...
C#: Do not download `Microsoft.CodeAnalysis.ResxSourceGenerator` when…
2024-04-24 13:49:55 +02:00
Tamas Vajk
4a97f95890
Improve code quality
2024-04-24 13:47:25 +02:00
Paolo Tranquilli
a23327c399
Merge branch 'main' into HEAD
2024-04-24 13:39:44 +02:00
Paolo Tranquilli
4aa0a8ebae
Kotlin: make wrapper more robust for windows
2024-04-24 13:39:32 +02:00
Tamás Vajk
84ea3a9a2c
Merge pull request #16310 from tamasvajk/buildless/nuget_versions
...
C#: Add integration test with multiple versions of the same nuget pac…
2024-04-24 13:33:27 +02:00
Nick Rolfe
8f2e51faa6
Ruby: do fewer regexp matches in SensitiveActions
2024-04-24 12:32:49 +01:00
Owen Mansel-Chan
f828f8ea65
Merge pull request #16250 from owen-mc/go/rename-untrusted-flow-source
...
Go: Rename `UntrustedFlowSource` to `RemoteFlowSource` to match other language libraries
2024-04-24 11:37:00 +01:00
Tom Hvitved
95d579d9de
Data flow: Fix bad join
...
```
Evaluated relational algebra for predicate _DataFlowImpl::Impl<HardcodedDataInterpretedAsCodeQuery::HardcodedDataInterpretedAsCodeFlow::C>::ret__#count_range@d112335l with tuple counts:
285176 ~2% {3} r1 = SCAN `_DataFlowDispatch::DataFlowCall.getEnclosingCallable/0#dispred#b7b78b19_DataFlowImpl::Impl<Hardcoded__#shared` OUTPUT In.1, In.0, In.2
3265592261 ~3% {5} | JOIN WITH `DataFlowImpl::Impl<HardcodedDataInterpretedAsCodeQuery::HardcodedDataInterpretedAsCodeFlow::C>::returnCallEdge1/4#d02cae42_2301#join_rhs` ON FIRST 2 OUTPUT Lhs.0, Lhs.2, Rhs.2, Lhs.1, Rhs.3
39070 ~8% {6} | JOIN WITH `DataFlowImplCommon::Cached::viableImplInCallContextExt/2#58e931ad` ON FIRST 3 OUTPUT Lhs.0, Lhs.3, Lhs.1, Lhs.2, Lhs.4, _
39070 ~0% {6} | REWRITE WITH Out.5 := 1
return r1
```
2024-04-24 12:22:28 +02:00
Tamas Vajk
f3daba510b
C#: Fix global.json and packages.config lookup
2024-04-24 11:57:45 +02:00
Tamas Vajk
88e67715a1
C#: Do not download Microsoft.CodeAnalysis.ResxSourceGenerator when there are no resx files to process
2024-04-24 11:53:29 +02:00
Tamas Vajk
53eb753346
C#: Add integration test with multiple versions of the same nuget package
2024-04-24 11:50:43 +02:00
Mathias Vorreiter Pedersen
037114b336
Merge pull request #16309 from geoffw0/newtests
...
C++: Add test cases
2024-04-24 10:06:51 +01:00
Nick Rolfe
af72c0848e
Merge pull request #16306 from github/nickrolfe/js-sensitive
...
JS: do fewer regexp matches in SensitiveActions
2024-04-24 09:49:44 +01:00
Tamás Vajk
de58ee5a22
Merge pull request #16225 from tamasvajk/buildless/resx
...
C#: Add resource generator
2024-04-24 10:10:45 +02:00
Tom Hvitved
a1a93c7331
Merge pull request #16304 from hvitved/csharp/fix-bad-join
...
C#: Fix a bad join
2024-04-24 08:11:25 +02:00
Asger F
db07c162e4
JS: Allow generated models to use (package)
2024-04-23 20:25:55 +02:00
Asger F
9d00f660f1
Update ModelGeneration.expected
2024-04-23 20:08:21 +02:00
Owen Mansel-Chan
0311888fd4
Update change note
...
Co-authored-by: Michael B. Gale <mbg@github.com >
2024-04-23 19:07:02 +01:00
Asger F
e4f23b31c6
JS: Add quotes around package name to correct parsing
2024-04-23 20:04:23 +02:00
Geoffrey White
57a53891e9
C++: Effect of recent QL changes.
2024-04-23 18:12:05 +01:00
Geoffrey White
b6703bc25c
C++: Add test cases inspired by QA results differences.
2024-04-23 18:06:12 +01:00
Nick Rolfe
003d208574
JS: do fewer regexp matches in SensitiveActions
2024-04-23 15:31:38 +01:00
Tom Hvitved
d8d7688f88
C#: Fix another bad join
2024-04-23 15:39:59 +02:00
Paolo Tranquilli
c014cd84f4
Bazel: fix kotlin wrapper version dependency
2024-04-23 15:15:38 +02:00
Paolo Tranquilli
5b143cee96
Kotlin: make wrapper install quietly unless --select is explicit
...
This allows `kotlinc -version` to always produce something parseable.
2024-04-23 15:15:38 +02:00
Paolo Tranquilli
072e2edd34
Merge branch 'main' into redsun82/kotlin
2024-04-23 14:29:33 +02:00
Anders Schack-Mulligen
830b83f653
Dataflow: Use doublyBoundedFastTC.
2024-04-23 13:07:20 +02:00
Mathias Vorreiter Pedersen
3592e76269
Merge pull request #16302 from MathiasVP/fieldflowbranchlimit-follow-up-1
...
C++: `fieldFlowBranchLimit` follow-up (1)
2024-04-23 11:35:49 +01:00
Tom Hvitved
6aa4c5c187
C#: Fix a bad join
2024-04-23 11:47:55 +02:00
Michael B. Gale
fb8ee07b43
Merge pull request #16262 from github/dependabot/go_modules/go/ql/integration-tests/all-platforms/go/two-go-mods-not-nested/src/subdir1/golang.org/x/net-0.23.0
2024-04-23 10:44:54 +01:00
Michael B. Gale
4ccff1a630
Merge pull request #16263 from github/dependabot/go_modules/go/ql/integration-tests/all-platforms/go/ninja-sample/src/golang.org/x/net-0.23.0
2024-04-23 10:44:17 +01:00
Michael B. Gale
4b7160d4b2
Merge pull request #16267 from github/dependabot/go_modules/go/ql/integration-tests/all-platforms/go/go-mod-without-version/src/golang.org/x/net-0.23.0
2024-04-23 10:43:43 +01:00
Michael B. Gale
5cce5008a3
Merge pull request #16264 from github/dependabot/go_modules/go/ql/integration-tests/all-platforms/go/single-go-work-not-in-root/src/modules/subdir2/golang.org/x/net-0.23.0
2024-04-23 10:42:53 +01:00
Michael B. Gale
5b6ce56ca2
Merge pull request #16268 from github/dependabot/go_modules/go/ql/integration-tests/all-platforms/go/single-go-mod-not-in-root/src/subdir/golang.org/x/net-0.23.0
2024-04-23 10:42:24 +01:00
Michael B. Gale
2b81b6c323
Merge pull request #16265 from github/dependabot/go_modules/go/ql/integration-tests/all-platforms/go/mixed-layout/src/module/golang.org/x/net-0.23.0
2024-04-23 10:41:50 +01:00
Mathias Vorreiter Pedersen
a39d8b7c7c
C++: Ensure that each node type gets mapped to an instruction by 'getAnInstruction'.
2024-04-23 09:44:30 +01:00
Mathias Vorreiter Pedersen
553c09ada3
Merge pull request #16301 from MathiasVP/proper-coroutine-cfg-support-2
...
C++: Implement proper coroutine support in IR
2024-04-23 09:19:15 +01:00
Anders Schack-Mulligen
b2f09949df
Merge pull request #15599 from aschackmull/dataflow/fieldflowbranchlimit-v2
...
Dataflow: update fieldFlowBranchLimit semantics
2024-04-23 10:08:05 +02:00
Rasmus Wriedt Larsen
1bc085c8f7
Python: Fixup for callGraphConfig
2024-04-23 09:42:35 +02:00
Rasmus Wriedt Larsen
bb00d6919a
Python: Move dataflow TestUtil to importable location
2024-04-23 09:40:59 +02:00
Rasmus Wriedt Larsen
e0e405bb31
Python: replace dataflow-test location in files
2024-04-23 09:40:59 +02:00
Rasmus Wriedt Larsen
ce711f7d2f
Python: Move dataflow tests out of experimental
2024-04-23 09:40:44 +02:00
Rasmus Wriedt Larsen
19974f04c9
Merge pull request #16245 from github/tausbn/python-rename-StrConst-to-StringLiteral
...
Python: Rename `StrConst` to `StringLiteral`
2024-04-23 09:35:24 +02:00
Mathias Vorreiter Pedersen
c1755603a8
Update TranslatedExpr.qll
...
Co-authored-by: Jeroen Ketema <93738568+jketema@users.noreply.github.com >
2024-04-23 07:25:25 +01:00
Mathias Vorreiter Pedersen
24cf75a37c
C++: Accept test changes.
2024-04-22 21:38:13 +01:00
Mathias Vorreiter Pedersen
8169e7ce68
C++: Add proper translation of 'co_await' and 'co_yield'.
2024-04-22 21:38:13 +01:00
Mathias Vorreiter Pedersen
8383bc1629
C++: Add getters for the other children of 'co_return' and 'co_yield'.
2024-04-22 21:38:13 +01:00
Jeroen Ketema
35d1a9202b
Merge pull request #16298 from jketema/reuse-val
...
C++: Update expected test results after extractor changes
2024-04-22 21:14:42 +02:00
Paolo Tranquilli
aaa29d8982
Remove unneeded slash in kotlinc.bat
2024-04-22 18:13:55 +02:00
Joe Farebrother
f85ee38e04
Add instance taint steps for requests
2024-04-22 16:03:39 +01:00
Paolo Tranquilli
f685843a52
Merge branch 'main' into redsun82/kotlin
2024-04-22 16:47:56 +02:00
Mathias Vorreiter Pedersen
799c380e5f
Merge pull request #16255 from MathiasVP/fix-more-fps-in-iterator-to-expired-container
...
Fix more FPs in `cpp/iterator-to-expired-container`
2024-04-22 14:25:51 +01:00
Tamas Vajk
f20812d8ad
Code quality improvement
2024-04-22 15:12:01 +02:00
Tamas Vajk
05f3c64172
Fix code review findings
2024-04-22 14:46:24 +02:00
Joe Farebrother
88e3227ed0
Add pyramid models
2024-04-22 13:27:18 +01:00
Taus
81246cd41a
Python: Add missing QLDoc for isUnicode
2024-04-22 12:08:53 +00:00
Taus
bab461ffd1
Python: Add change note
2024-04-22 12:00:09 +00:00
Taus
58eaddf627
Python: Update all .expected files
...
I'm beginning to realise why I didn't do the `toString` overriding way
back when. Thankfully, now that all of our tests are in the same place,
this is actually not a terrible ordeal.
2024-04-22 12:00:09 +00:00
Taus
d51fcd4f2a
Python: Change Str to StringLiteral
...
As far as I can tell, this was the only occurrence of `Str` as a type
throughout the entire library.
2024-04-22 12:00:09 +00:00
Taus
b484aee39e
Python: Autoformat everything
...
Of course, `StringLiteral` being much longer than `StrConst` meant a
bunch of files changed formatting.
2024-04-22 12:00:09 +00:00
Taus
1c68c987b0
Python: Change all remaining occurrences of StrConst
...
Done using
```
git grep StrConst | xargs sed -i 's/StrConst/StringLiteral/g'
```
2024-04-22 12:00:09 +00:00
Taus
f6487d7b13
Python: Rename StrConst to StringLiteral
...
Does a few things:
- Renames `StrConst` to `StringLiteral`, and deprecates the former.
- Also deprecates `Str`.
- Adds an override of `StringLiteral::toString` making it output
`"StringLiteral"` rather than the inherited `"Str"`. This ensures that
the AST viewer shows these nodes as the former type, not the latter.
There are a large number of uses of `StrConst` in the codebase. These
will be fixed in a later commit.
2024-04-22 12:00:09 +00:00
Jeroen Ketema
76637b0d03
C++: Update expected test results
2024-04-22 13:01:10 +02:00
Mathias Vorreiter Pedersen
77a7e007e3
Merge branch 'main' into fix-more-fps-in-iterator-to-expired-container
2024-04-22 10:42:06 +01:00
Jeroen Ketema
bea7b94537
Merge pull request #16296 from jketema/test-fix
...
C++: Fix aliased IR test
2024-04-22 11:34:13 +02:00
Jeroen Ketema
19d0d7bbc0
C++: Fix aliased IR test
2024-04-22 11:08:01 +02:00
Jeroen Ketema
c5bdd5bbd7
Merge pull request #16289 from jketema/reuse-improve
...
C++: Improve handling of re-use expressions
2024-04-22 10:34:35 +02:00
Jeroen Ketema
bcde7151e8
C++: Address review comment
2024-04-22 10:23:03 +02:00
Paolo Tranquilli
7952f0e237
Merge branch 'main' into redsun82/kotlin
2024-04-22 08:30:22 +02:00
Jeroen Ketema
2c76b13451
C++: Improve handling of re-used qualifier in delete expressions
2024-04-21 16:16:24 +02:00
Anders Schack-Mulligen
874d9d14bc
Merge pull request #16290 from aschackmull/java/oscheck-perf
...
Java: Fix join-order.
2024-04-19 16:55:56 +02:00
Mathias Vorreiter Pedersen
bcedf687ff
Merge pull request #16246 from MathiasVP/parameter-nodes-for-functions-without-bodies
...
C++: Add Parameter nodes for functions without bodies
2024-04-19 15:54:38 +01:00
Tom Hvitved
57796d6d02
Merge pull request #16249 from hvitved/csharp/no-compilation-clone
...
C#: Do not call `CSharpCompilation.Clone`
2024-04-19 16:28:23 +02:00
Anders Schack-Mulligen
c45fd4080d
Java: Fix join-order.
...
The TC was being fully materialised but all we need is unary
reachability.
2024-04-19 15:41:35 +02:00
Michael B. Gale
9d83c91deb
Merge pull request #16261 from github/dependabot/go_modules/go/ql/integration-tests/all-platforms/go/single-go-work-not-in-root/src/modules/subdir1/golang.org/x/net-0.23.0
...
Bump golang.org/x/net from 0.0.0-20200505041828-1ed23360d12c to 0.23.0 in /go/ql/integration-tests/all-platforms/go/single-go-work-not-in-root/src/modules/subdir1
2024-04-19 12:04:56 +01:00
Michael B. Gale
3c22bf4a25
Merge pull request #16260 from github/dependabot/go_modules/go/ql/integration-tests/all-platforms/go/make-sample/src/golang.org/x/net-0.23.0
...
Bump golang.org/x/net from 0.0.0-20200505041828-1ed23360d12c to 0.23.0 in /go/ql/integration-tests/all-platforms/go/make-sample/src
2024-04-19 12:04:31 +01:00
Michael B. Gale
3c0bb6f4e5
Merge pull request #16259 from github/dependabot/go_modules/go/ql/integration-tests/all-platforms/go/bazel-sample-2/src/golang.org/x/net-0.23.0
...
Bump golang.org/x/net from 0.0.0-20200505041828-1ed23360d12c to 0.23.0 in /go/ql/integration-tests/all-platforms/go/bazel-sample-2/src
2024-04-19 12:04:05 +01:00
Michael B. Gale
1648b427c2
Merge pull request #16258 from github/dependabot/go_modules/go/ql/integration-tests/all-platforms/go/bazel-sample-1/src/golang.org/x/net-0.23.0
...
Bump golang.org/x/net from 0.0.0-20200505041828-1ed23360d12c to 0.23.0 in /go/ql/integration-tests/all-platforms/go/bazel-sample-1/src
2024-04-19 12:03:38 +01:00
Michael B. Gale
e443c65c75
Merge pull request #16266 from github/dependabot/go_modules/go/ql/integration-tests/all-platforms/go/two-go-mods-one-failure/src/subdir1/golang.org/x/net-0.23.0
...
Bump golang.org/x/net from 0.0.0-20200505041828-1ed23360d12c to 0.23.0 in /go/ql/integration-tests/all-platforms/go/two-go-mods-one-failure/src/subdir1
2024-04-19 12:02:45 +01:00
Michael B. Gale
220abc4d36
Merge pull request #16270 from github/dependabot/go_modules/go/ql/integration-tests/all-platforms/go/single-go-mod-in-root/src/golang.org/x/net-0.23.0
...
Bump golang.org/x/net from 0.0.0-20200505041828-1ed23360d12c to 0.23.0 in /go/ql/integration-tests/all-platforms/go/single-go-mod-in-root/src
2024-04-19 12:02:15 +01:00
Michael B. Gale
7d4ce0a79a
Merge pull request #16269 from github/dependabot/go_modules/go/ql/integration-tests/all-platforms/go/two-go-mods-nested-none-in-root/src/subdir0/golang.org/x/net-0.23.0
...
Bump golang.org/x/net from 0.0.0-20200505041828-1ed23360d12c to 0.23.0 in /go/ql/integration-tests/all-platforms/go/two-go-mods-nested-none-in-root/src/subdir0
2024-04-19 12:01:48 +01:00
Michael B. Gale
ac9b77a3ac
Merge pull request #16271 from github/dependabot/go_modules/go/ql/integration-tests/all-platforms/go/single-go-mod-and-go-files-not-under-it/src/subdir/golang.org/x/net-0.23.0
...
Bump golang.org/x/net from 0.0.0-20200505041828-1ed23360d12c to 0.23.0 in /go/ql/integration-tests/all-platforms/go/single-go-mod-and-go-files-not-under-it/src/subdir
2024-04-19 12:01:12 +01:00
Michael B. Gale
abfbb47390
Merge pull request #16276 from github/dependabot/go_modules/go/ql/integration-tests/all-platforms/go/mixed-layout/src/workspace/subdir/golang.org/x/net-0.23.0
...
Bump golang.org/x/net from 0.0.0-20200505041828-1ed23360d12c to 0.23.0 in /go/ql/integration-tests/all-platforms/go/mixed-layout/src/workspace/subdir
2024-04-19 12:00:37 +01:00
Michael B. Gale
e7e7e4197e
Merge pull request #16274 from github/dependabot/go_modules/go/ql/integration-tests/all-platforms/go/go-mod-sample/src/golang.org/x/net-0.23.0
...
Bump golang.org/x/net from 0.0.0-20200505041828-1ed23360d12c to 0.23.0 in /go/ql/integration-tests/all-platforms/go/go-mod-sample/src
2024-04-19 12:00:10 +01:00
Michael B. Gale
e9a9f56ea5
Merge pull request #16273 from github/dependabot/go_modules/go/ql/integration-tests/all-platforms/go/two-go-mods-nested-one-in-root/src/golang.org/x/net-0.23.0
...
Bump golang.org/x/net from 0.0.0-20200505041828-1ed23360d12c to 0.23.0 in /go/ql/integration-tests/all-platforms/go/two-go-mods-nested-one-in-root/src
2024-04-19 11:59:14 +01:00
Michael B. Gale
03d7f5ec73
Merge pull request #16275 from github/dependabot/go_modules/go/ql/integration-tests/all-platforms/go/two-go-mods-nested-none-in-root/src/subdir0/subdir1/golang.org/x/net-0.23.0
...
Bump golang.org/x/net from 0.0.0-20200505041828-1ed23360d12c to 0.23.0 in /go/ql/integration-tests/all-platforms/go/two-go-mods-nested-none-in-root/src/subdir0/subdir1
2024-04-19 11:57:41 +01:00
Mathias Vorreiter Pedersen
ba99d49b61
Merge pull request #16187 from MathiasVP/cfg-for-coroutines
...
C++: Placeholder CFG for coroutines
2024-04-19 11:31:55 +01:00
Owen Mansel-Chan
ea2cf27432
Merge pull request #16234 from owen-mc/go/incorrect-integer-conversion-type-switch-fp
...
Go: Fix FPs in `go/incorrect-integer-conversion` query
2024-04-19 11:26:17 +01:00
dependabot[bot]
bd1731b420
Bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.0.0-20200505041828-1ed23360d12c to 0.23.0.
- [Commits](https://github.com/golang/net/commits/v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-19 09:46:03 +00:00
dependabot[bot]
31bea7e0ca
Bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.0.0-20200505041828-1ed23360d12c to 0.23.0.
- [Commits](https://github.com/golang/net/commits/v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-19 09:46:03 +00:00
dependabot[bot]
e01e8a0842
Bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.0.0-20200505041828-1ed23360d12c to 0.23.0.
- [Commits](https://github.com/golang/net/commits/v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-19 09:46:02 +00:00
dependabot[bot]
6c057ddc81
Bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.0.0-20200505041828-1ed23360d12c to 0.23.0.
- [Commits](https://github.com/golang/net/commits/v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-19 09:46:02 +00:00
dependabot[bot]
3c401d3a4f
Bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.0.0-20200505041828-1ed23360d12c to 0.23.0.
- [Commits](https://github.com/golang/net/commits/v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-19 09:46:01 +00:00
dependabot[bot]
cf1cddc8ca
Bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.0.0-20200505041828-1ed23360d12c to 0.23.0.
- [Commits](https://github.com/golang/net/commits/v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-19 09:46:01 +00:00
dependabot[bot]
2e50d61446
Bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.0.0-20200505041828-1ed23360d12c to 0.23.0.
- [Commits](https://github.com/golang/net/commits/v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-19 09:46:01 +00:00
dependabot[bot]
dae187eb0b
Bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.0.0-20200505041828-1ed23360d12c to 0.23.0.
- [Commits](https://github.com/golang/net/commits/v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-19 09:46:00 +00:00
dependabot[bot]
7f195d0257
Bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.0.0-20200505041828-1ed23360d12c to 0.23.0.
- [Commits](https://github.com/golang/net/commits/v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-19 09:46:00 +00:00
dependabot[bot]
a8162baada
Bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.0.0-20200505041828-1ed23360d12c to 0.23.0.
- [Commits](https://github.com/golang/net/commits/v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-19 09:46:00 +00:00
dependabot[bot]
6e50357224
Bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.0.0-20200505041828-1ed23360d12c to 0.23.0.
- [Commits](https://github.com/golang/net/commits/v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-19 09:46:00 +00:00
dependabot[bot]
ef53184c10
Bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.0.0-20200505041828-1ed23360d12c to 0.23.0.
- [Commits](https://github.com/golang/net/commits/v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-19 09:45:59 +00:00
dependabot[bot]
9d38c255f5
Bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.0.0-20200505041828-1ed23360d12c to 0.23.0.
- [Commits](https://github.com/golang/net/commits/v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-19 09:45:58 +00:00
dependabot[bot]
4de4525528
Bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.0.0-20200505041828-1ed23360d12c to 0.23.0.
- [Commits](https://github.com/golang/net/commits/v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-19 09:45:57 +00:00
dependabot[bot]
b9940f260f
Bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.0.0-20200505041828-1ed23360d12c to 0.23.0.
- [Commits](https://github.com/golang/net/commits/v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-19 09:45:57 +00:00
dependabot[bot]
58b0bed7f3
Bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.0.0-20200505041828-1ed23360d12c to 0.23.0.
- [Commits](https://github.com/golang/net/commits/v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-19 09:45:56 +00:00
dependabot[bot]
02af978e8d
Bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.0.0-20200505041828-1ed23360d12c to 0.23.0.
- [Commits](https://github.com/golang/net/commits/v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-19 09:45:56 +00:00
dependabot[bot]
9609dc4030
Bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.0.0-20200505041828-1ed23360d12c to 0.23.0.
- [Commits](https://github.com/golang/net/commits/v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-19 09:45:55 +00:00
Mathias Vorreiter Pedersen
4aee6d506d
C++: Accept test changes
2024-04-19 09:17:37 +01:00
Asger F
ac34b922ec
Merge pull request #16241 from asgerf/js/re-export
...
JS: Improve support for `export * as ...` declarations
2024-04-19 10:03:17 +02:00
Tom Hvitved
18acad516b
Merge pull request #16251 from hvitved/dataflow/fix-bad-join2
...
Data flow: Fix a bad join
2024-04-19 09:49:41 +02:00
Mathias Vorreiter Pedersen
cedc84df8f
C++: Fix FPs by only having one dataflow config. This means we preserve the call context all the way though from the source to the sink.
2024-04-19 08:27:41 +01:00
Mathias Vorreiter Pedersen
2b9c96d7cc
C++: Add testcase.
2024-04-19 08:26:50 +01:00
Anders Schack-Mulligen
595014966a
Dataflow: Add change note.
2024-04-19 08:46:04 +02:00
Tom Hvitved
339c40c2b7
Data flow: Fix bad join
2024-04-18 21:30:32 +02:00
Mathias Vorreiter Pedersen
a108fcd2b4
Merge pull request #16242 from MathiasVP/fix-tostring-on-nodes
...
C++: Fix `toString` on non-`ExprNode`s
2024-04-18 15:47:06 +01:00
Owen Mansel-Chan
79b4890794
Also rename .expected files
2024-04-18 14:17:04 +01:00
Mathias Vorreiter Pedersen
bcda4a1377
C++: Add change note.
2024-04-18 13:02:56 +01:00
Owen Mansel-Chan
dc985c2c98
Add change note
2024-04-18 12:55:59 +01:00
Mathias Vorreiter Pedersen
45b1a5e29b
Merge branch 'main' into fix-tostring-on-nodes
2024-04-18 12:48:25 +01:00
Mathias Vorreiter Pedersen
58832a546a
C++: Accept test changes.
2024-04-18 12:33:27 +01:00
Mathias Vorreiter Pedersen
9f8c9615fc
C++: Use the unconverted expression available for a non-'ExprNode' when one exists.
2024-04-18 12:33:20 +01:00
Owen Mansel-Chan
b6f6bdc6f4
Make RemoteFlowAsSource private
...
`UntrustedFlowAsSource` should have been private. Since we are deprecating them anyway
we may as well make the replacement private (and make it use `instanceof`). The deprecation
comments have been updated.
2024-04-18 12:31:38 +01:00
Mathias Vorreiter Pedersen
b43aae18e0
C++: Accept test changes.
2024-04-18 12:01:01 +01:00
Mathias Vorreiter Pedersen
06f52c2854
C++: Make the new nodes parameter nodes.
2024-04-18 12:01:00 +01:00
Mathias Vorreiter Pedersen
98a3f2da7d
C++: Add new dataflow nodes for parameters without any Instructions associated with them.
2024-04-18 12:01:00 +01:00
Mathias Vorreiter Pedersen
111ad8b525
C++: Refactor parameter nodes into an abstract class that's easier to extend.
2024-04-18 12:01:00 +01:00
Owen Mansel-Chan
a49b43fdf6
Add deprecated version of renamed public classes
2024-04-18 11:49:54 +01:00
Owen Mansel-Chan
317c335269
Rename test query files
2024-04-18 11:49:42 +01:00
Owen Mansel-Chan
db06c08141
Rename UntrustedSource to RemoteSource
...
Including renaming some files (in the experimental folder).
2024-04-18 11:49:30 +01:00
Owen Mansel-Chan
f39301f533
Fix "an remote" and similar
...
Preserve case, allow for "a `Remote" etc.
2024-04-18 11:49:18 +01:00
Owen Mansel-Chan
a6646021d0
Rename Untrusted Flow to Remote Flow
...
Not matching case but preserving original case.
2024-04-18 11:49:05 +01:00
Owen Mansel-Chan
d967b2baa3
Rename UntrustedFlowAsSource to RemoteFlowAsSource
2024-04-18 11:48:04 +01:00
Asger F
decd576a6b
Merge pull request #15386 from asgerf/js/graph-export
...
JS: Add library for exporting graphs as type models
2024-04-18 11:56:17 +02:00
Mathias Vorreiter Pedersen
622f69e1a1
Merge pull request #16238 from MathiasVP/fix-terator-to-expired-container-fp
2024-04-18 10:24:13 +01:00
Asger F
3c885f3969
JS: Fix bug in MkClassInstance use-nodes
...
This only worked when the RHS was a SourceNode, which is not generally the case
2024-04-18 10:06:11 +02:00
Tom Hvitved
3c83262d58
C#: Do no call CSharpCompilation.Clone
2024-04-18 09:45:26 +02:00
Tamás Vajk
77d0df4fb6
Merge pull request #16247 from tamasvajk/feature/adjust-known-types
...
C#: Adjust known type telemetry query
2024-04-18 09:26:09 +02:00
Tamas Vajk
c11adc8c28
C#: Adjust known type telemetry query
2024-04-18 08:49:48 +02:00
Mathias Vorreiter Pedersen
43df0cd5f4
C++: Add a failing test.
2024-04-17 21:47:32 +01:00
Mathias Vorreiter Pedersen
a1267d732e
Merge pull request #16139 from MathiasVP/enable-sound-ir
...
C++: Enable sound IR
2024-04-17 21:46:51 +01:00
Owen Mansel-Chan
a4df20da85
Rename UntrustedFlowSource to RemoteFlowSource
...
Relaxed match case requirement. Again skipped one instance in an old
change note.
2024-04-17 21:40:46 +01:00
Owen Mansel-Chan
81eaa6e327
Rename UntrustedFlowSource to RemoteFlowSource
...
Relaxed whole word requirement. Again skipped one instance in an old
change note.
2024-04-17 21:35:50 +01:00
Owen Mansel-Chan
5fba9895c6
Rename UntrustedFlowSource to RemoteFlowSource
...
Only the whole word. Skipped one instance in an old change note.
2024-04-17 21:27:32 +01:00
Asger F
64321b314f
Merge branch 'main' into js-extractor-fix
2024-04-17 20:55:54 +02:00
Asger F
da33c220a6
JS: Update test output
2024-04-17 20:11:11 +02:00
Owen Mansel-Chan
212a0f27ff
Add change note
2024-04-17 16:32:53 +01:00
Owen Mansel-Chan
2f56ec7fe0
Fix QLDoc
2024-04-17 16:32:49 +01:00
Owen Mansel-Chan
80c3993ddc
Remove redundant test
...
It was introduced in https://github.com/github/codeql-go/pull/718 in
response to https://github.com/github/codeql-go/issues/717 , to check
that we don't have type assertions as sinks. We now have other tests
covering type assertions.
2024-04-17 16:32:41 +01:00
Owen Mansel-Chan
3ad2d90014
Make type switches tranform flow state
2024-04-17 16:32:36 +01:00
Owen Mansel-Chan
611f98bca4
Make type assertions transform the flow state
2024-04-17 16:32:30 +01:00
Owen Mansel-Chan
544660322f
Refactor flow state transforming barriers
2024-04-17 16:32:25 +01:00
Owen Mansel-Chan
f08a598821
Add tests for FPs: type switches, type assertions
2024-04-17 16:32:13 +01:00
Michael Nebel
4d3d07a964
Merge pull request #16215 from michaelnebel/csharp/telemetryissupported
...
C#: Take more sources and sinks into account when reporting in the te…
2024-04-17 15:29:46 +02:00
Tamas Vajk
7b5f2c7d94
Fix expected test result on Windows
2024-04-17 15:12:51 +02:00
Paolo Tranquilli
3678e51f0b
Merge branch 'main' into redsun82/kotlin
2024-04-17 15:09:27 +02:00
Tamás Vajk
dc4cc74cbb
Merge pull request #16240 from tamasvajk/fix/cleanup
...
C#: Fix cleanup logic in dependency manager
2024-04-17 14:53:40 +02:00
Asger F
eab96988bf
JS: Add test for use steps
2024-04-17 14:46:00 +02:00
Asger F
2dcb5fbd16
Ensure props are included in MkMemberLabel
2024-04-17 14:46:00 +02:00
Asger F
3eb4e39251
JS: Also do this for use-steps and exclude pseudo-properties
2024-04-17 14:45:58 +02:00
Tamas Vajk
6f782f3f62
C#: Fix cleanup logic in dependency manager
2024-04-17 14:17:47 +02:00
Asger F
55b9724f59
JS: Add store step into namespace re-export specifier
2024-04-17 14:14:12 +02:00
Asger F
0a7af90454
JS: Add test with ESModule re-exports
2024-04-17 14:14:12 +02:00
Tamas Vajk
41e666c724
Parse and use RootNamespace from project files
2024-04-17 14:01:52 +02:00
Henry Mercer
902f0f91b0
Merge pull request #16218 from github/henrymercer/remove-ml-powered-queries
...
JS: Remove ML-powered queries
2024-04-17 12:54:05 +01:00
Tamas Vajk
88f6e04339
Make Resx extraction opt-in
2024-04-17 13:49:05 +02:00
Tamas Vajk
b560ab1a73
Fix condition for running dotnet source generators
2024-04-17 13:44:03 +02:00
Tamas Vajk
3626c814ac
Run dotnet source generators on files grouped by projects
2024-04-17 13:40:03 +02:00
Asger F
5e7026c6c6
JS: Use AccessPath as parameter type
2024-04-17 13:31:51 +02:00
Alexander Eyers-Taylor
da3fa22cbd
Merge pull request #16228 from github/post-release-prep/codeql-cli-2.17.1
...
Post-release preparation for codeql-cli-2.17.1
2024-04-17 11:24:34 +01:00
Tamas Vajk
bef556e208
Improve log messages
2024-04-17 11:46:27 +02:00
Tamas Vajk
5a5fc79b3b
Fix regex to recognize prerelease version string
2024-04-17 11:46:27 +02:00
Tamas Vajk
9926c817de
Code quality improvements
2024-04-17 11:46:26 +02:00
Tamas Vajk
53902c824d
Fix integration tests
2024-04-17 11:46:26 +02:00
Tamas Vajk
3c5675b3fb
WIP: Hardcode namespace for Resx generation
2024-04-17 11:46:26 +02:00
Mathias Vorreiter Pedersen
592ca06159
C++: Accept test changes.
2024-04-17 10:10:54 +01:00
Mathias Vorreiter Pedersen
96ba3ec88e
C++: Rename predicate.
2024-04-17 10:10:54 +01:00
Mathias Vorreiter Pedersen
eb2790ae63
C++: Fix 'case 2' in 'destroyedToBeginSink' now that we're working with the sink instead of the source.
2024-04-17 10:10:39 +01:00
Mathias Vorreiter Pedersen
d22e2bae8e
C++: Select the post-update node in 'getADestroyedNode'.
2024-04-17 10:10:39 +01:00
Mathias Vorreiter Pedersen
b2974ba1c6
C++: Factor body of isSink into its own predicate.
2024-04-17 10:10:21 +01:00
Tamas Vajk
3154a11b43
List members in resx test
2024-04-17 10:47:44 +02:00
Mathias Vorreiter Pedersen
b201fd0bdd
Merge pull request #16232 from MathiasVP/add-iterator-to-expired-container-fp
...
C++: Add `cpp/iterator-to-expired-container` FP test
2024-04-17 09:44:32 +01:00
Tamas Vajk
1ff4c0daf3
Restore and use Microsoft.CodeAnalysis.ResxSourceGenerator
2024-04-17 10:41:47 +02:00
Michael Nebel
bc0e580683
C#: Address review comments.
2024-04-17 09:34:27 +02:00
Asger F
f78ea26c3b
Merge pull request #16161 from RasmusWL/js/strict-mode
...
JS: Parser: Never run in strict mode
2024-04-17 09:21:29 +02:00
Asger F
93a9c62e29
Merge branch 'main' into js/graph-export
2024-04-17 09:19:59 +02:00
Michael Nebel
7434a58afc
Merge pull request #16236 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-04-17 09:09:48 +02:00
Asger F
ed80e4e284
JS: Change note
2024-04-17 08:41:27 +02:00
Asger F
c4eeda1560
JS: Bump EXTRACTOR_VERSION
2024-04-17 08:34:26 +02:00
github-actions[bot]
7faf3a8b8e
Add changed framework coverage reports
2024-04-17 00:16:33 +00:00
Taus
dd97e70ffc
Merge pull request #16233 from github/tausbn/python-fix-flags-test
2024-04-17 00:35:11 +02:00
Mathias Vorreiter Pedersen
1847a6deb0
Merge pull request #16203 from MathiasVP/break-bigstep-at-store
...
C++: Break dataflow big-step on right-hand side of assignments
2024-04-16 23:04:17 +01:00
Mathias Vorreiter Pedersen
fdddec74d3
Merge branch 'main' into break-bigstep-at-store
2024-04-16 21:08:33 +01:00
Chad Bentz
f77f91ef49
move security-severity to end of column list in csv
...
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com >
2024-04-16 16:02:15 -04:00
Taus
bf8307f78d
Python: Fix flags test
...
In 25cb52aa52 I accidentally introduced an extra `not` where none existed before. Whoops!
2024-04-16 21:17:34 +02:00
Asger F
3335d48154
Sync files
2024-04-16 20:26:41 +02:00
Asger F
c0db40d11a
Merge branch 'js/graph-export' of github.com:asgerf/codeql into js/graph-export
2024-04-16 20:25:11 +02:00
Asger F
be64daf265
Merge branch 'main' into js/graph-export
2024-04-16 20:23:33 +02:00
Asger F
ee5cb6f3d8
Update shared/mad/codeql/mad/dynamic/GraphExport.qll
2024-04-16 20:10:51 +02:00
Asger F
844b29b637
Update shared/mad/codeql/mad/dynamic/GraphExport.qll
...
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com >
2024-04-16 20:09:26 +02:00
Sid Shankar
5c50ed036c
Merge pull request #16231 from github/tausbn/python-temporarily-remove-crlf-test
...
Python: Remove test with CRLF line endings
2024-04-16 13:54:06 -04:00
Mathias Vorreiter Pedersen
62299dc95a
C++: Add FP test.
2024-04-16 18:19:33 +01:00
Taus
48e367cb11
Python: Remove test with CRLF line endings
...
These were causing `git` to behave strangely, leaving files that were
impossible to reset. In the future we should probably generate these
problematic test files on the fly, so that they don't have to exist in
the repo, but in the short run, it's easier to just remove them so as to
not block other users of the repo.
2024-04-16 17:18:20 +00:00
Mathias Vorreiter Pedersen
8f82db07d3
Merge pull request #16230 from MathiasVP/fix-join-in-global-use-before-init
...
C++: Use interpolation to avoid a bad join order
2024-04-16 18:17:11 +01:00
Paolo Tranquilli
c5f6c65ff1
Merge branch 'main' into redsun82/kotlin
2024-04-16 18:23:33 +02:00
Mathias Vorreiter Pedersen
ba9267df5b
Merge branch 'main' into break-bigstep-at-store
2024-04-16 17:15:58 +01:00
Cornelius Riemenschneider
4cb0695646
Merge pull request #16229 from github/criemen/rules-pkg
...
Upgrade rules_pkg to 0.10.1.
2024-04-16 18:03:00 +02:00
Mathias Vorreiter Pedersen
c3cf425079
C++: Use interpolation to avoid a bad join order.
2024-04-16 16:24:08 +01:00
Mathias Vorreiter Pedersen
dd656d34be
Merge branch 'main' into break-bigstep-at-store
2024-04-16 15:33:21 +01:00
Taus
c647f30576
Merge pull request #16212 from github/tausbn/python-add-copy-of-internal-tests
...
Python: Add copy of internal tests
2024-04-16 16:32:31 +02:00
Mathias Vorreiter Pedersen
7155af50be
C++: Accept more test changes.
2024-04-16 15:32:24 +01:00
Cornelius Riemenschneider
6ba27dc863
Upgrade rules_pkg to 0.10.1.
2024-04-16 16:29:56 +02:00
github-actions[bot]
622e176a16
Post-release preparation for codeql-cli-2.17.1
2024-04-16 14:21:32 +00:00
Paolo Tranquilli
a7411700ef
Merge branch 'main' into redsun82/kotlin
2024-04-16 16:13:31 +02:00
Michael Nebel
4a4f9b3942
C#: Update expected test output.
2024-04-16 16:05:16 +02:00
Michael Nebel
e7bfd7df62
C#: Take more sources and sinks into account when reporting in the telemetry queries.
2024-04-16 16:05:16 +02:00
Michael Nebel
543032a3de
C#: Add ParallelSink QL Doc.
2024-04-16 16:05:16 +02:00
Michael Nebel
f69737b407
C#: Move parallelsink to the library qlpack.
2024-04-16 16:05:16 +02:00
Michael Nebel
c720fb2c34
C#: Add HtmlString test, which is supported as it is a known sink defined in QL.
2024-04-16 16:05:16 +02:00
Michael Nebel
4886bb1116
Merge pull request #16227 from michaelnebel/csharp/fixmadid
...
C#: Update MaD id in expected file.
2024-04-16 16:04:47 +02:00
Mathias Vorreiter Pedersen
8888ee9fa8
Merge pull request #16149 from codeqlhelper/main
...
C++: Improvements to reduce false alarms
2024-04-16 15:03:31 +01:00
Chris Smowton
69d8fa6e4a
Merge pull request #16188 from smowton/smowton/admin/maven-buildless-missing-host-tolerance-test
...
Java: add test for a Maven project with an unreachable repository
2024-04-16 14:53:22 +01:00
Michael Nebel
ae0e25e5b1
C#: Update MaD id in expected file.
2024-04-16 15:37:46 +02:00
Mathias Vorreiter Pedersen
2627a3dcb7
Merge pull request #15371 from geoffw0/mad
...
C++: Implement models-as-data
2024-04-16 14:33:12 +01:00
Mathias Vorreiter Pedersen
e1884c193b
C++: Add tests (and fix a missing quote in the alert message).
2024-04-16 14:20:19 +01:00
Mathias Vorreiter Pedersen
6cb5db2387
C++: Improve change note comments.
2024-04-16 13:55:55 +01:00
Mathias Vorreiter Pedersen
439afd97ba
C++: Small performance optimization.
2024-04-16 13:54:58 +01:00
Mathias Vorreiter Pedersen
132bb9f1d6
C++: Address (my own) review comments.
2024-04-16 13:53:27 +01:00
Michael Nebel
58635bdbd6
Merge pull request #16121 from michaelnebel/csharp/modelgenexcludeset
...
C#: Exclude properties with both a getter and setter as candidates for modelling.
2024-04-16 14:49:07 +02:00
Tamas Vajk
79fe5f851b
C#: Add resource generator
2024-04-16 14:30:53 +02:00
Tom Hvitved
e99c78e027
Merge pull request #16226 from hvitved/csharp/exclude-delegate-dynamic-calls-extraction-info
...
C#: Exclude delegate and dynamic calls from extractor telemetry
2024-04-16 14:23:38 +02:00
Tom Hvitved
75b1e14098
Merge pull request #16205 from samgiz/samgiz-tiny-docs-fix
...
Tiny docs fix
2024-04-16 13:57:38 +02:00
Paolo Tranquilli
306f0f172d
Kotlin: accept --select default in kotlinc wrapper to select the default version
2024-04-16 13:55:20 +02:00
Paolo Tranquilli
27ab4875fd
Kotlin: simplify kotlinc wrapper
2024-04-16 13:37:06 +02:00
Alexander Eyers-Taylor
0daa6c2c1d
Merge pull request #16219 from github/release-prep/2.17.1
...
Release preparation for version 2.17.1
2024-04-16 12:02:14 +01:00
Tom Hvitved
6bf05eb29a
C#: Exclude delegate and dynamic calls from extractor telemetry
2024-04-16 12:53:39 +02:00
Paolo Tranquilli
aee3c0d249
Add license and notice information to patched registry
2024-04-16 12:33:00 +02:00
Mathias Vorreiter Pedersen
fb9fc14f3d
C++: Accept test changes in paths.
2024-04-16 11:09:22 +01:00
Mathias Vorreiter Pedersen
8630630c45
C++: Use 'asDefinition' instead of checking for a 'Store' instruction.
2024-04-16 11:00:57 +01:00
Paolo Tranquilli
735b3410aa
Merge branch 'main' into redsun82/kotlin
2024-04-16 11:49:21 +02:00
Mathias Vorreiter Pedersen
54957d6ea4
Merge branch 'main' into enable-sound-ir
2024-04-16 10:46:59 +01:00
Joe Farebrother
f57e0cb71e
Merge pull request #16209 from joefarebrother/csharp-missing-precision
...
C#: Add missing query precision
2024-04-16 10:46:27 +01:00
Rasmus Wriedt Larsen
ec862ebc72
Merge pull request #16196 from michaelnebel/misc/expected-changes-usageinfo
...
Print usage information for accept-expected-changes script in case PR…
2024-04-16 11:38:24 +02:00
Tamás Vajk
9671e05148
Merge pull request #16213 from tamasvajk/buildless/source-generators
...
C#: Move source code generators to dedicated classes
2024-04-16 11:08:28 +02:00
Joe Farebrother
3567c30020
Set precision to high
2024-04-16 09:41:46 +01:00
Tamas Vajk
407837afc4
C#: Refactor dotnet source generator execution
2024-04-16 10:20:23 +02:00
Tom Hvitved
ff55ed84f4
Merge pull request #16181 from hvitved/dynamic/deprecate-csv-models
...
Dynamic languages: Deprecate models-as-data CSV interface
2024-04-16 10:06:30 +02:00
Tamas Vajk
13a71a4f6d
C#: Move source code generators to dedicated classes
2024-04-16 09:28:50 +02:00
Michael Nebel
3105697c7f
Merge pull request #16200 from michaelnebel/csharp/dependencylogging
...
C#: Logging
2024-04-16 08:24:36 +02:00
Geoffrey White
fc7fef3dd8
Swift: Add dataflow tests for dictionaries.
2024-04-15 18:50:41 +01:00
github-actions[bot]
9bfe4ea90a
Release preparation for version 2.17.1
2024-04-15 17:34:47 +00:00
Geoffrey White
0c88d05a65
Swift: QLDoc BuiltinLiteralExpr subclasses and add BuiltinLiteral.getValueString.
2024-04-15 18:23:32 +01:00
Henry Mercer
8747438613
JS: Remove ML-powered queries
2024-04-15 17:35:32 +01:00
Alexander Eyers-Taylor
feeaef14be
Merge pull request #16217 from github/alexet/fix-change-note
...
Go: Fix broken changenote metadata
2024-04-15 17:32:20 +01:00
Michael B. Gale
d9bd547f06
Merge pull request #16216 from github/mbg/go/respect-gotoolchain
...
Go: Respect `GOTOOLCHAIN` in `GetEnvGoVersion` if already set
2024-04-15 17:04:27 +01:00
Alexander Eyers-Taylor
43572fe9ae
Go: Fix broken changenote metadata
2024-04-15 16:55:23 +01:00
Michael B. Gale
c0d2b89de0
Go: Respect GOTOOLCHAIN in GetEnvGoVersion if already set
2024-04-15 16:28:24 +01:00
Taus
82057e2e46
Python: Autoformat tests
...
I guess these were never considered back when we switched to
autoformatting everything.
2024-04-15 15:27:21 +00:00
Michael B. Gale
ce73c29962
Merge pull request #16214 from github/mbg/go/use-shared-integration-test-code
...
Go: Use shared integration test code
2024-04-15 16:25:28 +01:00
Taus
25cb52aa52
Python: Fix inefficient string comparison
2024-04-15 15:23:07 +00:00
Michael B. Gale
7a0aad87a4
Go: Use shared library for integration tests
2024-04-15 14:46:53 +01:00
Michael B. Gale
4673fff65b
Go: Add db and runFunction to go_integration_test
2024-04-15 14:46:53 +01:00
Michael B. Gale
caaccb7709
Go: Run go clean -modcache in finally for integration tests
...
This ensures that the temporary GOPATH is cleaned up correctly in case of an integration test failure as well
2024-04-15 14:46:53 +01:00
Paolo Tranquilli
8c705adbe9
Kotlin/Bazel: fix java release to 8 for java code
2024-04-15 15:38:06 +02:00
Paolo Tranquilli
bd631c5e00
Merge branch 'main' into redsun82/kotlin
2024-04-15 15:37:33 +02:00
Anders Schack-Mulligen
3c69f8f607
Java: Count second level scopes for fieldFlowBranchLimit.
2024-04-15 15:17:43 +02:00
Anders Schack-Mulligen
2f0987e980
Dataflow: Add dummy DataFlowSecondLevelScope implementations.
...
These could be an empty type, but Unit was available and it probably
doesn't matter.
2024-04-15 15:16:30 +02:00
Anders Schack-Mulligen
db6d27bd2b
C++: Count return dispatch based on 2nd level scopes.
2024-04-15 15:13:08 +02:00
Anders Schack-Mulligen
9e39be5aea
C++: Update qltest.
2024-04-15 15:13:05 +02:00
Anders Schack-Mulligen
b87b8329a0
Dataflow: Use default fieldFlowBranchLimit in qltests.
2024-04-15 15:13:03 +02:00
Anders Schack-Mulligen
f945687a93
Dataflow: Simplify branch and join.
2024-04-15 15:13:01 +02:00
Anders Schack-Mulligen
82afbbc17b
Dataflow: Adjust fieldFlowBranchLimit count (block less) and adjust return edge condition (block more)
2024-04-15 15:12:58 +02:00
Anders Schack-Mulligen
a99849d897
Merge pull request #16211 from aschackmull/dataflow/alert-provenance-update-change-note
...
Dataflow: Amend change note for alert provenance.
2024-04-15 15:00:49 +02:00
Anders Schack-Mulligen
1389c7220b
Dataflow: Amend change note.
2024-04-15 14:35:39 +02:00
Taus
8ec414d454
Python: Add copy of internal Python 3 tests
...
Again, mostly extractor tests, and a single library test.
2024-04-15 12:30:01 +00:00
Taus
b22b4c5b85
Python: Add copy of internal Python 2 tests
...
These are mostly extractor tests, which now live in `2/extractor-tests`,
and a single library tests that was added to the existing directory.
2024-04-15 12:26:45 +00:00
Taus
e45f6e9b24
Python: Add copy of extractor tests
...
These get to live next to the existing library and query tests, and are
run as part of both the Python 2 and Python 3 language tests.
2024-04-15 12:22:07 +00:00
Paolo Tranquilli
5bb2cba66c
Merge branch 'main' into redsun82/kotlin
2024-04-15 14:08:13 +02:00
Paolo Tranquilli
6a83bf9de5
Merge pull request #16208 from github/redsun82/kotlin-wrapper
...
Kotlin/Bazel: provide wrapper for managing versions of `kotlinc`
2024-04-15 13:33:10 +02:00
Paolo Tranquilli
1b5675eb21
Kotlin/Bazel: tweak wrapper
2024-04-15 13:31:29 +02:00
Paolo Tranquilli
e53ef4acd2
Kotlin/Bazel: fix wrapper on Windows
2024-04-15 13:13:31 +02:00
Michael Nebel
d5073df24c
Merge pull request #16186 from michaelnebel/csharp/suppressnullablefix
...
C#: Fix issue with suppress nullable warning directly on a method call.
2024-04-15 13:11:03 +02:00
Michael Nebel
8915241166
C#: Reduce nuget and razor logging.
2024-04-15 13:01:12 +02:00
Michael Nebel
336a18a1d9
C#: Make Started log as Debug.
2024-04-15 13:01:12 +02:00
Michael Nebel
ddfed6ea65
C#: Changing logging of dotnet commands to Debug except for dotnet --info and friends.
2024-04-15 13:01:12 +02:00
Michael Nebel
72ffcf5f9c
C#: Replace some LogInfo with LogDebug.
2024-04-15 13:01:12 +02:00
Michael Nebel
f7e5fe7040
C#: Inline some calls.
2024-04-15 13:01:03 +02:00
Paolo Tranquilli
b07fa70133
Kotlin/Bazel: provide wrapper for managing versions of kotlinc
...
By adding `java/kotlinc-extractor/deps/dev` to `PATH`, one gets a
`kotlinc` wrapper that takes care of downloading and extracting the
desired version of `kotlinc` on demand. The desired version can be
selected with `kotlinc --select x.y.z`, or left to the current default
of `1.9.0`.
Moreover, this default version is integrated with the Bazel build, so
that when using this wrapper, changes in the selected version will be
picked up to define the default single version kotlin extractor build,
without needing to do anything else (like `bazel fetch --force` or
similar).
Selected and installed version data is stored in `.gitignore`d files
in the same directory, and can be cleared with `kotlinc --clear`.
2024-04-15 10:48:57 +02:00
Tamás Vajk
611cf231a7
Merge pull request #16195 from tamasvajk/depManager/refactoring
...
C#: Split `DependencyManager` into multiple classes
2024-04-15 10:25:08 +02:00
Geoffrey White
1c66e26e92
C++: Autoformat.
2024-04-15 09:06:49 +01:00
Joe Farebrother
6e130d24cd
C#: Add missing query precision
2024-04-15 08:42:26 +01:00
Tamas Vajk
69c43094ba
Fix review findings
2024-04-15 09:32:18 +02:00
Paolo Tranquilli
9d1901c049
Merge branch 'main' into redsun82/kotlin
2024-04-15 08:27:34 +02:00
Paolo Tranquilli
bdc8a7f59d
Revert "Use fetchexclude=* in .lfsconfig rather than fetchinclude"
...
This reverts commit a834101d7e .
Using `fetchinclude` allows for easier local customization of what to
fetch, because fetchexlude has precedence over fetchinclude.
2024-04-15 08:26:19 +02:00
Zigmas Bitinas
5125468307
Tiny docs fix
...
Noticed the mistake when browsing the docs [here](https://codeql.github.com/codeql-standard-libraries/ruby/codeql/ruby/security/CodeInjectionCustomizations.qll/module.CodeInjectionCustomizations$CodeInjection$FlowState.html )
2024-04-13 21:18:36 +01:00
Mathias Vorreiter Pedersen
f3a5ce5efc
C++: Accept more test changes.
2024-04-13 11:03:15 +01:00
Mathias Vorreiter Pedersen
6f08790065
C++: Accept test changes.
2024-04-13 01:00:48 +01:00
Mathias Vorreiter Pedersen
2cbc59b7a1
C++: Always show the right-hand side of assignment in paths.
2024-04-13 01:00:38 +01:00
Geoffrey White
9302b167d8
C++: Fix further merge conflicts.
2024-04-12 19:38:38 +01:00
Mathias Vorreiter Pedersen
0bed22178c
Merge pull request #16201 from MathiasVP/add-consistency
...
C++: Add new AST consistency check
2024-04-12 17:46:48 +01:00
Geoffrey White
e13b3ed5e7
C++ and Swift: Fix merge conflicts.
2024-04-12 17:30:46 +01:00
Mathias Vorreiter Pedersen
aac1070aca
C++: Consistent naming.
2024-04-12 17:00:46 +01:00
Mathias Vorreiter Pedersen
413d3abbd7
C++: Add new AST consistency check.
2024-04-12 16:57:19 +01:00
Mathias Vorreiter Pedersen
116664588b
Merge pull request #16125 from MathiasVP/destructors-for-unconditional-unnamed
...
C++: Generate IR for destruction of unconditionally constructed temporaries
2024-04-12 16:26:03 +01:00
Alex Ford
91bca4a2c3
Ruby: limit ActiveRecord conditions sink to first array element
2024-04-12 15:32:16 +01:00
Alex Ford
2950890180
Ruby: add more ActiveRecord conditions arg test cases
2024-04-12 15:31:28 +01:00
Alex Ford
f98479dca3
Ruby: prepare test case whitespace
2024-04-12 15:30:42 +01:00
Paolo Tranquilli
b36cabb396
Anchor .gitattributes entries at root where it makes sense
2024-04-12 16:04:15 +02:00
Paolo Tranquilli
92a5f3da75
Merge branch 'main' into redsun82/kotlin
2024-04-12 16:02:39 +02:00
Paolo Tranquilli
3614d3d52b
Merge pull request #16199 from github/redsun82/add-shared-triggers-to-swift-ci
...
Swift: add `shared/**` to CI triggers
2024-04-12 16:00:18 +02:00
Paolo Tranquilli
de4ffbb552
Swift: add shared/** to CI triggers
...
Not being triggered by changes in shared was making it possible to not
notice changes in `shared` having effect on Swift tests. For example
[this PR](https://github.com/github/codeql/pull/15501 ) introduced a
test change that was fixed [here](https://github.com/github/codeql/pull/16197 ).
2024-04-12 15:46:01 +02:00
Paolo Tranquilli
67946614e3
Merge pull request #16197 from github/redsun82/accept-swift-tests
...
Swift: accept new test results
2024-04-12 15:34:00 +02:00
Geoffrey White
e29ce5f5d5
Merge branch 'main' into mad
2024-04-12 14:30:44 +01:00
Geoffrey White
1df1f0dbc2
C++: Use 'concat' in the variable.ql test.
2024-04-12 14:22:21 +01:00
Geoffrey White
0235e9962e
C++: Accept test changes (related to getAQlClass).
2024-04-12 14:19:37 +01:00
Chad Bentz
78ddb998a2
Merge branch 'main' into patch-1
2024-04-12 09:09:43 -04:00
Tamas Vajk
e3fe9f7ca5
Move Nuget restore logic from DependencyManager to dedicated class
2024-04-12 15:04:45 +02:00
Asger F
3949ae4123
Update shared/mad/codeql/mad/dynamic/GraphExport.qll
...
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com >
2024-04-12 15:00:24 +02:00
Asger F
330229c463
Update javascript/ql/lib/semmle/javascript/frameworks/data/ModelsAsData.qll
...
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com >
2024-04-12 15:00:17 +02:00
Paolo Tranquilli
70e72aadd5
Swift: accept new test results
2024-04-12 14:57:59 +02:00
Paolo Tranquilli
a78124b2d5
Bazel/Kotlin: use a wrapper to get the current kotlin version
2024-04-12 14:47:21 +02:00
Michael Nebel
52be6579b7
Print usage information for accept-expected-changes script in case PR auto detection fails.
2024-04-12 14:31:25 +02:00
Michael Nebel
1c8298ae08
C#: Update expected test output.
2024-04-12 14:24:30 +02:00
Paolo Tranquilli
5c2d9fe9a1
Merge branch 'main' into redsun82/kotlin
2024-04-12 14:01:04 +02:00
Paolo Tranquilli
24c7ad5d28
Bazel/Kotlin: use plain kotlinc instead of result of repository_ctx.which
2024-04-12 14:00:46 +02:00
Tamas Vajk
5406fac834
C#: Move all file lookup to separate class
2024-04-12 13:58:49 +02:00
Michael Nebel
d88a813038
C#: Re-generate .NET models.
2024-04-12 13:49:26 +02:00
Michael Nebel
254c6c3344
C#: Address review comments.
2024-04-12 13:48:13 +02:00
Tom Hvitved
e7dc120456
Add deprecation comments
2024-04-12 13:40:15 +02:00
Tom Hvitved
ceb5b4c56e
Python: No longer use models-as-data CSV interface
2024-04-12 13:40:15 +02:00
Tom Hvitved
9d8b93ed45
JS: No longer use models-as-data CSV interface
2024-04-12 13:40:15 +02:00
Tom Hvitved
fdb77457b3
Sync files
2024-04-12 13:40:14 +02:00
Tom Hvitved
04de315e0e
Ruby: Deprecate models-as-data CSV interface
2024-04-12 13:40:14 +02:00
Michael Nebel
dc34cb0aae
C#: Update all MaD ids in the tests.
2024-04-12 13:24:18 +02:00
Tamás Vajk
91f2ea572c
Merge pull request #16164 from tamasvajk/buildless/nuget-feed-fallback-feed-check
...
C#: Check fallback nuget feeds before trying to use them in the fallb…
2024-04-12 13:17:06 +02:00
Chris Smowton
bdd6fba06a
Java: add test for a Maven project with an unreachable repository
2024-04-12 12:03:38 +01:00
Paolo Tranquilli
0ad8ed3822
Kotlin/Bazel: use kotlinc.bat instead of kotlinc.exe on Windows
2024-04-12 12:15:26 +02:00
Paolo Tranquilli
65df2bb16d
Bazel/Kotlin: add .exe to kotlinc on windows
2024-04-12 11:56:33 +02:00
Paolo Tranquilli
b8010f27e7
Merge branch 'main' into redsun82/kotlin
2024-04-12 11:56:16 +02:00
Asger F
15eabb42ef
JS: Address review comments
2024-04-12 11:35:34 +02:00
Michael Nebel
f799962146
C#: Update expected test output.
2024-04-12 11:35:08 +02:00
Michael Nebel
cb3a59446c
C#: Remove redundant neutral summaries for ProcessStartInfo.
2024-04-12 11:31:59 +02:00
Michael Nebel
e70a49a771
C#: Add some manual models for ProcessStartInfo.
2024-04-12 11:31:59 +02:00
Michael Nebel
db48461ebc
C#: Add change note.
2024-04-12 11:31:59 +02:00
Michael Nebel
ac2769c142
C#: Update the Telemetry queries such that properties with both get and set are no longer interesting.
2024-04-12 11:31:59 +02:00
Michael Nebel
829557fdda
C#: Update expected test output.
2024-04-12 11:31:59 +02:00
Michael Nebel
c12c2a534c
C#: Update the model editor code to disregard properties in case both a getter and a setter is present.
2024-04-12 11:31:58 +02:00
Michael Nebel
5323af33d2
C#: Update flow summaries expected test output.
2024-04-12 11:31:58 +02:00
Michael Nebel
96ef6809a7
C#: Update .NET Runtime models.
2024-04-12 11:31:58 +02:00
Michael Nebel
312b96aa8b
C#: Update expected test output.
2024-04-12 11:31:57 +02:00
Michael Nebel
8cc4f86e7d
C#: Only attempt to generate models for properties that does not both have a get and a set accessor.
2024-04-12 11:31:57 +02:00
Michael Nebel
32595b92a2
C#: Add some property test cases.
2024-04-12 11:31:57 +02:00
Michael Nebel
cbb5d433b1
C#: Add change note.
2024-04-12 11:23:16 +02:00
Michael Nebel
a2bb3dd78b
C#: Update expected test output.
2024-04-12 11:23:03 +02:00
Paolo Tranquilli
9114131128
Bazel: add settings required by internal repo
2024-04-12 11:19:43 +02:00
Paolo Tranquilli
2d16192bab
CI: fix typo in kotlin-build.yml
2024-04-12 11:19:43 +02:00
Joe Farebrother
5cebcadc56
Merge pull request #15987 from joefarebrother/ruby-mass-reassignment
...
Ruby: Add query for insecure mass assignment
2024-04-12 10:18:41 +01:00
Michael Nebel
19b7574c9c
C#: Fix issue with suppress nullable warning directly on a method call.
2024-04-12 11:16:37 +02:00
Michael Nebel
1e59def89d
C#: Add some suppress nullable warning testcases and update expected output.
2024-04-12 11:16:37 +02:00
Anders Schack-Mulligen
854dfb35c1
Merge pull request #15501 from aschackmull/dataflow/alert-provenance
...
Dataflow: Support alert provenance
2024-04-12 11:14:20 +02:00
Paolo Tranquilli
9c3a615794
CI: add non-blocking kotlin extractor build check
...
This is to check that the build from `codeql` works. The "official"
build will still be checked from the internal repo with QLucie, once
we integrate the bazel build there.
2024-04-12 10:59:17 +02:00
Paolo Tranquilli
bc89742979
Kotlin: fix space indentation in OdasaOutput.java
2024-04-12 10:50:02 +02:00
Paolo Tranquilli
c64d02d6df
Undo .gitattributes formatting, move LFS entry
2024-04-12 10:44:18 +02:00
Paolo Tranquilli
a834101d7e
Use fetchexclude=* in .lfsconfig rather than fetchinclude
2024-04-12 10:41:46 +02:00
Paolo Tranquilli
4822de3313
Kotlin/Bazel: add fail printouts to _default_version
2024-04-12 10:19:10 +02:00
Anders Schack-Mulligen
b4e23d9487
Dataflow: Address review comments
2024-04-12 09:20:45 +02:00
Anders Schack-Mulligen
31a86574bb
Dataflow: Add change note.
2024-04-12 09:20:42 +02:00
Anders Schack-Mulligen
b7ee5597a0
Swift: Update expected output (interesting).
2024-04-12 09:20:40 +02:00
Anders Schack-Mulligen
2c43d0c5a4
Ruby: Update expected output (interesting).
2024-04-12 09:20:38 +02:00
Anders Schack-Mulligen
7cc8fd00aa
Ruby: Update expected output (uninteresting).
2024-04-12 09:20:35 +02:00
Anders Schack-Mulligen
cbcdf1f8b5
Python: Update expected output (interesting).
2024-04-12 09:20:33 +02:00
Anders Schack-Mulligen
bfcfedab8c
Python: Update expected output (uninteresting).
2024-04-12 09:20:30 +02:00
Anders Schack-Mulligen
f85ff9defc
Java: Update expected output (interesting).
2024-04-12 09:20:28 +02:00
Anders Schack-Mulligen
c2f5731e8d
Java: Update expected output (uninteresting).
2024-04-12 09:20:26 +02:00
Anders Schack-Mulligen
20e91f9cac
Go: Update expected output (uninteresting).
2024-04-12 09:20:23 +02:00
Anders Schack-Mulligen
c3946a92ff
C#: Update expected output (interesting)
2024-04-12 09:20:21 +02:00
Anders Schack-Mulligen
647f9aba82
C#: Update some expected output (uninteresting).
2024-04-12 09:20:18 +02:00
Anders Schack-Mulligen
c355737d30
C++: Update expected output.
2024-04-12 09:20:16 +02:00
Anders Schack-Mulligen
fdfb4a1a18
JS: Adapt to shared ApiGraphModels.qll changes.
2024-04-12 09:20:13 +02:00
Anders Schack-Mulligen
44147b9520
JS: Sync.
2024-04-12 09:20:11 +02:00
Anders Schack-Mulligen
a8fc100108
Python: Add alert provenance plumbing.
2024-04-12 09:20:08 +02:00
Anders Schack-Mulligen
f202661912
C++: Add alert provenance plumbing.
2024-04-12 09:20:06 +02:00
Anders Schack-Mulligen
6991f5452f
Ruby: Add alert provenance plumbing.
2024-04-12 09:20:04 +02:00
Anders Schack-Mulligen
82e6fbbd22
Swift: Add alert provenance plumbing.
2024-04-12 09:20:01 +02:00
Anders Schack-Mulligen
ba6039946b
Go: Add alert provenance plumbing.
2024-04-12 09:19:59 +02:00
Anders Schack-Mulligen
004bda1ee0
C#: Add alert provenance plumbing.
2024-04-12 09:19:56 +02:00
Anders Schack-Mulligen
eafc0075fd
Legacy dataflow: Sync.
2024-04-12 09:19:54 +02:00
Anders Schack-Mulligen
2925e45434
Java/Dataflow: Propagate MaD-id/model-id to PathGraph.
2024-04-12 09:19:51 +02:00
Paolo Tranquilli
b8c063ed2a
Merge branch 'main' into redsun82/kotlin
2024-04-12 08:19:14 +02:00
Paolo Tranquilli
fc62ed5af0
Kotlin/Bazel: port custom_plugin test to use bazel
2024-04-12 08:18:53 +02:00
Joe Farebrother
06d7b3ce80
Use cfg nodes
2024-04-11 22:30:41 +01:00
Sid Shankar
1015ee9872
Merge pull request #16189 from github/sidshank/check-python-executable-name-option-on-win
...
Python: Modifies check for py launcher
2024-04-11 16:16:23 -04:00
Aditya Sharad
790ee4a906
Merge pull request #16163 from github/mbg/docs/macos14
...
Docs: Add macOS 14 to list of supported operating systems
2024-04-11 11:26:39 -07:00
Sid Shankar
e33c5706f8
Modifies check for py launcher
...
This commit modifies the check for the "py" launcher on windows. We now look for the launcher only if the python_executable_name extractor option is not specified.
2024-04-11 12:59:41 -04:00
Geoffrey White
13100b19bc
C++: Fix unintentionally changing the type of AdditionalCallTarget.viableTarget.
2024-04-11 17:07:20 +01:00
Geoffrey White
66f88d9c71
C++: Restrict the AST cases in TReturnKind.
2024-04-11 16:52:15 +01:00
Paolo Tranquilli
3d1465439a
Bazel/Kotlin: tentatively fix version detection on Windows
2024-04-11 17:39:09 +02:00
Paolo Tranquilli
59fdbdbb20
Kotlin/Bazel: move defaults to separate bazel package
...
This makes calling specific targets in `java/kotlin-extractor` not
depend on `@kotlin_extractor_defaults`, avoiding its overhead.
2024-04-11 17:31:37 +02:00
Paolo Tranquilli
7f495b1851
Bazel/kotlin: make version detection more robust
2024-04-11 17:17:57 +02:00
Paolo Tranquilli
c18b556f3d
Kotlin/Bazel: remove 2.0.255-SNAPSHOT version
2024-04-11 16:50:09 +02:00
Mathias Vorreiter Pedersen
477322d21d
C++: Accept test changes.
2024-04-11 15:44:44 +01:00
Mathias Vorreiter Pedersen
846eac8be9
C++: Add a placeholder for 'getOpcode'.
2024-04-11 15:44:33 +01:00
Paolo Tranquilli
3b75d63c18
Merge branch 'main' into redsun82/kotlin
2024-04-11 16:40:57 +02:00
Paolo Tranquilli
54156650d7
Bazel/Kotlin: make _embeddable_source more robust
2024-04-11 16:40:37 +02:00
Paolo Tranquilli
f0fc8110a0
Bazel/Kotlin: add 2.0.0-RC1, remove 2.0.0-Beta4
2024-04-11 16:39:23 +02:00
Mathias Vorreiter Pedersen
8842b974f0
C++: Accept test changes.
2024-04-11 15:34:34 +01:00
Mathias Vorreiter Pedersen
65b69fe353
C++: Mark 'CoYieldExpr' as a unary expression in IR construction.
2024-04-11 15:34:29 +01:00
Paolo Tranquilli
02257eead0
Bazel: use triple slash in --registry
...
`file://%workspace%` works on POSIX systems, but not on Windows.
`file:///` works on both.
2024-04-11 16:28:49 +02:00
Mathias Vorreiter Pedersen
2a914770ea
C++: Accept test changes.
2024-04-11 15:27:45 +01:00
Mathias Vorreiter Pedersen
d030f0b5d2
C++: Add a placeholder for 'getOpcode'.
2024-04-11 15:27:38 +01:00
Mathias Vorreiter Pedersen
33364a8ab6
C++: Accept test changes.
2024-04-11 14:28:44 +01:00
Mathias Vorreiter Pedersen
d8bd18f369
C++: IR translation of 'co_return' statements.
2024-04-11 14:28:15 +01:00
Michael B. Gale
f7262b7e6d
Merge pull request #16184 from github/mbg/go/integration-tests-lib
...
Go: Add integration test library
2024-04-11 14:26:03 +01:00
Paolo Tranquilli
fe35902222
Merge branch 'main' into redsun82/kotlin
2024-04-11 15:07:39 +02:00
Ian Lynagh
3c1286385d
Merge pull request #16177 from igfoo/igfoo/kt2.0.0-rc1
...
Kotlin: Add 2.0.0-RC1 support (and remove 2.0.0-Beta4)
2024-04-11 14:01:58 +01:00
Tamas Vajk
c004f92365
Apply code review findings
2024-04-11 14:47:20 +02:00
Tamas Vajk
da91cea153
Add unit tests for dotnet nuget list source calls
2024-04-11 14:45:43 +02:00
Tamas Vajk
743e77d0d4
Improve logging, expose inherited feeds in integration test
2024-04-11 14:45:43 +02:00
Tamas Vajk
8d0856f97e
Fix failing test
2024-04-11 14:45:36 +02:00
Tamas Vajk
0f7fc90fe0
C#: Check fallback nuget feeds before trying to use them in the fallback restore process
2024-04-11 14:43:32 +02:00
Mathias Vorreiter Pedersen
3e1359b92e
C++: Accept test changes.
2024-04-11 13:31:48 +01:00
Mathias Vorreiter Pedersen
4c4d2415e9
C++: Mark 'CoAwaitExpr' as a unary expression in IR construction.
2024-04-11 13:30:33 +01:00
Mathias Vorreiter Pedersen
161f586510
Merge pull request #16097 from MathiasVP/add-coroutine-tests
...
C++: Add coroutine tests
2024-04-11 13:11:26 +01:00
Mathias Vorreiter Pedersen
aa94ee5b96
C++: Accept test changes.
2024-04-11 12:27:33 +01:00
Michael B. Gale
9c26cdd0bb
Go: Add integration test library
2024-04-11 12:27:31 +01:00
Erik Krogh Kristensen
c00e2075a4
Merge pull request #16111 from erik-krogh/rb-url
...
RB: Improve QHelp for `rb/url-redirect`, and fix an FP.
2024-04-11 13:03:35 +02:00
Mathias Vorreiter Pedersen
3a18da730e
Merge branch 'main' into add-coroutine-tests
2024-04-11 11:59:07 +01:00
Ian Lynagh
58f825fcb8
Kotlin: Drop our 2.0.255-SNAPSHOT version
...
It's now older than 2.0.0-RC1
2024-04-11 11:58:59 +01:00
Ian Lynagh
9c573dbee3
Kotlin: Update expected result for kotlin-version-too-new test
2024-04-11 11:58:59 +01:00
Ian Lynagh
7ce7685b91
Kotlin: FirMetadataSource.File.files has been removed
...
In new versions, but not old versions, we want FirMetadataSource.File.fir
instead.
2024-04-11 11:58:59 +01:00
Ian Lynagh
1698ccff9a
Kotlin: Add 2.0.0-RC1 support (and remove 2.0.0-Beta4)
2024-04-11 11:58:59 +01:00
Tom Hvitved
982765ced3
Merge pull request #16176 from hvitved/csharp/adjust-conditional-locations
...
C#: Adjust conditional access locations
2024-04-11 12:47:51 +02:00
Owen Mansel-Chan
d4bb4d4faa
Merge pull request #16120 from owen-mc/go/fix/type-switch-control-flow
...
Go: Fix data flow through variable defined in type switch guard
2024-04-11 11:39:40 +01:00
Owen Mansel-Chan
1e8315d797
Merge pull request #16180 from owen-mc/go/tweak-go-tainted-path-additions
...
Go: Tweak go tainted path additions
2024-04-11 11:17:30 +01:00
Mathias Vorreiter Pedersen
736d59c42d
Merge branch 'main' into destructors-for-unconditional-unnamed
2024-04-11 09:53:31 +01:00
Mathias Vorreiter Pedersen
34a0c02f70
Merge branch 'main' into enable-sound-ir
2024-04-11 09:48:45 +01:00
Joe Farebrother
ec973ac1f3
Use not exists
2024-04-11 09:38:41 +01:00
Tony Torralba
e6fdc75450
Merge pull request #16129 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-04-11 10:21:13 +02:00
Owen Mansel-Chan
a7c5e849f4
Expand ReplaceAll in sanitizer
2024-04-11 07:35:56 +01:00
Owen Mansel-Chan
c3fefa8f69
Add extra sanitizer Part.FileName()
2024-04-11 07:35:45 +01:00
Owen Mansel-Chan
21189af294
Improve QLDoc and refactor QL
2024-04-11 07:34:58 +01:00
github-actions[bot]
c4c81b77cf
Add changed framework coverage reports
2024-04-11 00:16:51 +00:00
Mathias Vorreiter Pedersen
5c4e02a1da
Merge branch 'main' into enable-sound-ir
2024-04-10 23:56:16 +01:00
Mathias Vorreiter Pedersen
0e610ba535
Merge pull request #16179 from MathiasVP/delete-noisy-test
2024-04-10 23:53:50 +01:00
Joe Farebrother
0a3d73d902
Add flow steps and sanitizers for permit calls
2024-04-10 21:47:07 +01:00
Erik Krogh Kristensen
844e78dce5
remove redundant cast
...
Co-authored-by: Alex Ford <alexrford@users.noreply.github.com >
2024-04-10 20:02:49 +02:00
Mathias Vorreiter Pedersen
313501aa29
C++: Delete a noisy test that's not very helpful.
2024-04-10 18:54:50 +01:00
Mathias Vorreiter Pedersen
21bc8c4324
C++: Accept test changes.
2024-04-10 18:32:15 +01:00
Geoffrey White
19b14e166d
C++: Reduce code duplication.
2024-04-10 17:44:55 +01:00
Mathias Vorreiter Pedersen
3d96206783
Merge branch 'main' into enable-sound-ir
2024-04-10 17:39:13 +01:00
Mathias Vorreiter Pedersen
7172e2f445
Merge branch 'main' into destructors-for-unconditional-unnamed
2024-04-10 17:34:08 +01:00
Geoffrey White
959300f963
C++: Fixes for internals that are now private.
2024-04-10 17:32:10 +01:00
Geoffrey White
41ce4ffe4b
C++: Fix some QLDoc holes.
2024-04-10 17:21:48 +01:00
Geoffrey White
eca112c3bc
C++: More autoformatting.
2024-04-10 17:21:05 +01:00
Geoffrey White
250cb30c05
Swift: Autoformat.
2024-04-10 17:21:02 +01:00
Geoffrey White
dd96095a30
Apply suggestions from code review
...
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com >
2024-04-10 17:20:35 +01:00
Paolo Tranquilli
85968e343a
Merge pull request #16178 from github/redsun82/swift-deps-extension-all
...
Bazel: `swift/third_party/load.bzl` cleanup and `bazel mod tidy` enablement
2024-04-10 17:59:51 +02:00
Mathias Vorreiter Pedersen
33f6b6a940
Merge pull request #16175 from MathiasVP/more-iterator-models
...
C++: Add alias and side-effect models for more iterator functions
2024-04-10 16:55:10 +01:00
Jeroen Ketema
b9b2aa3580
Merge pull request #16138 from jketema/coroutine3
...
C++: Update expected test results
2024-04-10 17:48:48 +02:00
Rasmus Wriedt Larsen
d5160927f5
Merge branch 'main' into js/strict-mode
2024-04-10 17:33:01 +02:00
Rasmus Wriedt Larsen
c4e674b8d2
Merge pull request #16173 from RasmusWL/remove-lib-stubs
...
Python: Remove deprecated stubs for points-to tests
2024-04-10 17:12:16 +02:00
Erik Krogh Kristensen
d33e8adae4
Merge pull request #16174 from erik-krogh/no-arr-ruby-shell
...
RB: don't mention arrays in the qhelp for rb/shell-command-constructed-from-input
2024-04-10 17:08:24 +02:00
Paolo Tranquilli
24ef424d04
Merge branch 'main' into redsun82/kotlin
2024-04-10 16:57:30 +02:00
Owen Mansel-Chan
1c0ef90e96
Merge pull request #15865 from owen-mc/go/extractor/no-intermediate-string-values
...
Go: extractor: do not store intermediate values in long string concatenations
2024-04-10 15:31:51 +01:00
Michael Nebel
b79d738f64
Merge pull request #15993 from michaelnebel/csharp/assemblycachefiltering
...
C#: Exclude Semmle.* dlls when using the executing runtime.
2024-04-10 16:22:22 +02:00
Tom Hvitved
1c344d6735
C#: Adjust conditional access locations
2024-04-10 16:21:58 +02:00
Geoffrey White
925ee825ff
C++: Add change notes.
2024-04-10 15:18:43 +01:00
Owen Mansel-Chan
dc3ea6c418
Merge pull request #11703 from Kwstubbs/go-taintedpath-additions
...
Go: Add and Modify Sanitizers For TaintedPath
2024-04-10 15:13:13 +01:00
Paolo Tranquilli
05f5879a2c
Bazel: swift/third_party/load.bzl cleanup and bazel mod tidy enablement
2024-04-10 16:11:20 +02:00
Mathias Vorreiter Pedersen
0ed0731024
C++: Reduce comment duplication.
2024-04-10 15:04:29 +01:00
Geoffrey White
36db493723
C++: Autoformat.
2024-04-10 15:02:19 +01:00
Geoffrey White
cbab24ba45
C++: Sort Models.qll.
2024-04-10 14:59:13 +01:00
Geoffrey White
e0f866f19d
Merge branch 'main' into mad
2024-04-10 14:58:52 +01:00
Mathias Vorreiter Pedersen
9c9ed13ede
C++: More comments.
2024-04-10 14:57:40 +01:00
Mathias Vorreiter Pedersen
1ae22d0781
C++: Improve comment based on PR feedback.
2024-04-10 14:55:29 +01:00
Owen Mansel-Chan
5ec3934ac8
Merge branch 'main' into go/extractor/no-intermediate-string-values
2024-04-10 14:51:22 +01:00
Paolo Tranquilli
5df1abcd26
Bazel/Kotlin: use "all" for extension metadata direct dependencies
2024-04-10 15:41:27 +02:00
Paolo Tranquilli
1a7f25af35
Merge pull request #16167 from github/redsun82/kotlin-patched-registry
...
Bazel: move patching of `rules_kotlin` to a registry override
2024-04-10 15:30:40 +02:00
Paolo Tranquilli
35a2ed87b6
Bazel/Kotlin: patch jdep emission
2024-04-10 15:29:44 +02:00
Tom Hvitved
7c43ca7001
C#: Add more conditional access tests
2024-04-10 15:25:00 +02:00
Mathias Vorreiter Pedersen
a7c98e3d94
C++: Accept test changes.
2024-04-10 14:19:06 +01:00
Mathias Vorreiter Pedersen
d98ed2d3cf
C++: Add alias and side effect models for more iterator functions.
2024-04-10 14:19:06 +01:00
Michael Nebel
ef68e33449
C#: Address review comments.
2024-04-10 14:48:02 +02:00
erik-krogh
4ae25c2d34
don't mention arrays in the qhelp for rb/shell-command-constructed-from-input, because there are no array
2024-04-10 14:26:00 +02:00
Owen Mansel-Chan
0e67aa5baa
Merge pull request #16172 from owen-mc/go/perf/synth-location
...
Go: Avoid magic in `TSynthLocation` definition
2024-04-10 13:02:18 +01:00
Owen Mansel-Chan
f45305ec3f
Merge pull request #16170 from owen-mc/go/add-comments-in-extractor
...
Go: Add comments in extractor with link to online documentation
2024-04-10 12:50:18 +01:00
Paolo Tranquilli
a15681a181
Bazel: ease update of local registry
2024-04-10 13:22:18 +02:00
Paolo Tranquilli
5bdd724221
Bazel: move patching of rules_kotlin to a registry override
2024-04-10 13:22:18 +02:00
Michael Nebel
ff498f616a
C#: Some renaming.
2024-04-10 13:20:57 +02:00
Rasmus Wriedt Larsen
9615e2ded9
Python: Remove deprecated stubs for points-to tests
...
I grep'ed through all our options files, and couldn't find any tests
that relies on these anymore 👍
2024-04-10 13:12:36 +02:00
Rasmus Wriedt Larsen
78ca691912
Python: remove deprecated points-to test for zope
2024-04-10 13:12:17 +02:00
Rasmus Wriedt Larsen
3db560158a
Merge pull request #16169 from RasmusWL/mad-remoteflowsource
...
Python: Fix `RemoteFlowSourceFromCsv`
2024-04-10 13:06:42 +02:00
Mathias Vorreiter Pedersen
59936c8642
Merge pull request #16151 from MathiasVP/use-shared-typeflow-lib
...
C++: Use the shared typeflow library
2024-04-10 12:02:03 +01:00
Michael Nebel
3b42dc25a1
C#: Also use AssemblyLookupLocation for framework dlls.
2024-04-10 12:56:48 +02:00
Owen Mansel-Chan
a18a4fb62e
Avoid magic in TSynthLocation definition
...
This improves performance, because in this case magic is not beneficial.
2024-04-10 11:47:13 +01:00
Michael Nebel
99f0ed26e9
C#: Make the assembly lookup case insensitive on the dll file extension and log if no dlls are found in a directory.
2024-04-10 12:45:28 +02:00
Michael Nebel
9eb13833fa
C#: Code quality improvements.
2024-04-10 12:45:18 +02:00
Michael Nebel
2bea927d43
C#: Update expected test output.
2024-04-10 12:41:39 +02:00
Michael Nebel
d04bf6b6d6
C#: Don't include Semmle.* dlls, if the executing runtime is used as framework.
2024-04-10 12:41:39 +02:00
Michael Nebel
646b272b4e
C#: Move the AssemblyPath class to its own file.
2024-04-10 12:41:39 +02:00
Michael Nebel
6299d9cecd
C#: Introduce AssemblyPath and re-factor AssemblyCache to use this instead of strings.
2024-04-10 12:41:29 +02:00
Michael Nebel
bee54e4247
C#: Add desktop runtime dependencies integration test.
2024-04-10 12:35:52 +02:00
Owen Mansel-Chan
b4829addf7
Add comments with link to online doc
2024-04-10 10:48:23 +01:00
Rasmus Wriedt Larsen
4fed3cf12d
Python: Fix RemoteFlowSourceFromCsv
2024-04-10 11:31:34 +02:00
Paolo Tranquilli
c9565b3657
Bazel/Kotlin: fix version comparison logic, add default version printing
2024-04-10 11:29:58 +02:00
Joe Farebrother
976ca48317
Review suggestions - rename sink class and add barrier out
2024-04-10 10:17:19 +01:00
Paolo Tranquilli
aca8d047ca
Bazel: fix .bazelrc
2024-04-10 10:24:15 +02:00
Paolo Tranquilli
3bdab70451
Bazel: rename exported.bazelrc to .bazelrc.exported
...
This makes the `.bazelrc` files be near each other in the directory
listing.
2024-04-10 10:18:10 +02:00
Dave Bartolomeo
996f535f0b
Merge pull request #16103 from github/dbartol/javadoc-record
...
Allow `@param` tags to apply to record parameters
2024-04-09 14:21:45 -04:00
Geoffrey White
138975e4a8
C++: Add ZMQ summary models.
2024-04-09 18:10:15 +01:00
Geoffrey White
783ce48538
C++: Add test cases for ZMQ summary models.
2024-04-09 18:08:56 +01:00
Mathias Vorreiter Pedersen
8a92a4250f
C++: Autoformat.
2024-04-09 17:53:33 +01:00
Dave Bartolomeo
b9cfeaf614
Add test case
2024-04-09 12:41:32 -04:00
Taus
3656376cc4
Merge pull request #16064 from github/max-schaefer/fix-unexploitable-types
...
Automodel: Filter unexploitable types in application mode.
2024-04-09 17:14:53 +02:00
Mathias Vorreiter Pedersen
a53ef495ee
C++: Simplify 'hasExactBufferType' and add comments.
2024-04-09 16:04:20 +01:00
Felicity Chapman
5253c96aa2
Merge pull request #16162 from github/felicitymay/threat-models-csharp
...
Make duplicated content clear
2024-04-09 15:47:44 +01:00
Paolo Tranquilli
e7c680e963
Kotlin: reuse generated dbscheme in embeddable, and tweak comments
2024-04-09 16:33:17 +02:00
Mathias Vorreiter Pedersen
291cc0a671
C++: Anonymous namespaces provide internal linkage.
2024-04-09 15:25:13 +01:00
Owen Mansel-Chan
5e4a5c1571
Merge pull request #16160 from owen-mc/java/delete-jdk-internal-models
...
Java: Delete models for JDK internal packages
2024-04-09 15:01:16 +01:00
Mathias Vorreiter Pedersen
2a7420ce11
Update cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/TypeFlow.qll
...
Co-authored-by: Jeroen Ketema <93738568+jketema@users.noreply.github.com >
2024-04-09 15:00:23 +01:00
Geoffrey White
1264e6e292
C++: Fit the function pointer tests better with what is and isn't working.
2024-04-09 14:57:15 +01:00
Paolo Tranquilli
662fd5c04a
Add explanatory comment to .lfsconfig
2024-04-09 15:48:23 +02:00
Paolo Tranquilli
9c73a9a1db
Bazel: move shared bazelrc settings to a exported.bazelrc file
...
This will be `importe`d by the `semmle-code` `.bazelrc` file.
2024-04-09 15:48:23 +02:00
Max Schaefer
deb78b248b
Apply suggestions from code review
...
Co-authored-by: Taus <tausbn@github.com >
2024-04-09 14:38:17 +01:00
Tom Hvitved
6c9a0e4a9a
Merge pull request #16154 from hvitved/ruby/redundant-implicit-read
...
Ruby: Remove two redundant `allowImplicitRead` predicates
2024-04-09 15:38:05 +02:00
Jeroen Ketema
46c44b4dc0
C++: Update QLDoc of IRDeclarationEntry to reflect current reality
2024-04-09 15:15:41 +02:00
Jeroen Ketema
e821a62b44
C++: Update expected test results
2024-04-09 15:15:41 +02:00
Rasmus Wriedt Larsen
6f1a9d4574
Merge pull request #16159 from RasmusWL/fix-integration-tests
...
Python: Fixup integration tests after no dep inst
2024-04-09 15:08:20 +02:00
Michael B. Gale
0c3c20ece1
Docs: Add macOS 14 to list of supported operating systems
2024-04-09 14:06:24 +01:00
Felicity Chapman
e6d63b980d
Make duplicated content clear
2024-04-09 14:05:42 +01:00
Mathias Vorreiter Pedersen
e9cd2dc9e1
C++: Implement 'lambdaCreation' and 'lambdaCall' for models-as-data.
2024-04-09 14:05:32 +01:00
Rasmus Wriedt Larsen
16e2ac898f
JS: Parser: Remove direct this.strict assignment
2024-04-09 14:58:14 +02:00
Geoffrey White
4d5f158652
C++: Pivot ReturnKind solution to derive types from SSA + AST, rather than SSA + MAD.
2024-04-09 13:49:21 +01:00
Rasmus Wriedt Larsen
6ce38be3cc
Merge pull request #16112 from github/tausbn/python-various-extractor-fixups
...
Python: Various extractor fixups
2024-04-09 14:46:23 +02:00
Paolo Tranquilli
4b205ff96d
Apply suggestions from code review
...
Co-authored-by: Cornelius Riemenschneider <cornelius@github.com >
2024-04-09 14:44:44 +02:00
Asger F
f5355cfa98
Dynamic: Sync ApiGraphModels.qll
2024-04-09 14:37:20 +02:00
Rasmus Wriedt Larsen
1985dd629d
JS: Parser: Never run in strict mode
...
This initial change is a bit of a hacky way to achieve our goals (since
it doesn't rewrite all the uses of this.strict), but it is easy to
understand is correct. Let's accept test changes NOW, and ensure that
later changes don't change things further.
2024-04-09 14:37:07 +02:00
Asger F
82101434fd
Dynamic: Add hasPrettyName()
2024-04-09 14:32:59 +02:00
Asger F
8cb80d6014
JS: Switch from hasLocationInfo to Location
2024-04-09 14:32:59 +02:00
Asger F
81b96a8041
JS: Ensure MkClassInstance exists for base classes
2024-04-09 14:32:58 +02:00
Asger F
29a61458e0
JS: Add test case showing problem with chains going through internal classes
2024-04-09 14:32:58 +02:00
Asger F
56ebe6c727
JS: More re-export logic to handle subclass export
2024-04-09 14:32:58 +02:00
Asger F
f2ea88aa4c
JS: Add test showing missing re-export of base class relationship
2024-04-09 14:32:58 +02:00
Asger F
9313564e64
JS: Add subclassing test and fix lack of subclassing handling
2024-04-09 14:32:58 +02:00
Asger F
ef7767b6cd
JS: Add partial test for subclassing
2024-04-09 14:32:58 +02:00
Asger F
3022c59654
JS: Add access path alias test
2024-04-09 14:32:58 +02:00
Asger F
ab3c03d2d6
JS: Add test where root export object is a function
2024-04-09 14:32:58 +02:00
Asger F
f4e05cc621
JS: Add tests with semi-internal class problem
2024-04-09 14:32:58 +02:00
Asger F
946f0b4dc4
JS: Add test for class with aliases
2024-04-09 14:32:58 +02:00
Asger F
348c95ebe1
JS: Add a test case with fluent flow
2024-04-09 14:32:58 +02:00
Asger F
c55e03c588
Dynamic/JS: Add support for re-exporting type models
2024-04-09 14:32:58 +02:00
Asger F
acef9b7111
Dynamic/JS: Add library for exporting models
2024-04-09 14:32:58 +02:00
Michael Nebel
bd1de179b3
Merge pull request #15887 from michaelnebel/csharp/qualifiedname
...
C#: Fully qualified name.
2024-04-09 14:26:36 +02:00
Owen Mansel-Chan
ae8240a695
Delete models for JDK internal packages
2024-04-09 13:23:03 +01:00
Rasmus Wriedt Larsen
e9e7ccddce
Python: delete force-enable-library-extraction integration test
2024-04-09 14:02:34 +02:00
Rasmus Wriedt Larsen
a0d6324f68
Python: Fix ignore-venv integration test
...
Now that we no longer support the fallback option
(https://github.com/github/codeql/pull/16127 )
2024-04-09 14:01:10 +02:00
Rasmus Wriedt Larsen
bb4952f557
Revert "Python: Disable failing integration tests"
...
This reverts commit 8c2455fc11 .
2024-04-09 14:00:25 +02:00
Paolo Tranquilli
11729aaf6e
Kotlin: add licensing links about kotlin dependencies
2024-04-09 13:55:30 +02:00
Owen Mansel-Chan
322d9fe105
Update change note wording
...
Co-authored-by: Chris Smowton <smowton@github.com >
2024-04-09 12:46:26 +01:00
Paolo Tranquilli
4a4bd16eab
Java/Kotlin: prepare for internal bazel packaging
2024-04-09 13:27:27 +02:00
Paolo Tranquilli
7b2dc325ec
Merge pull request #16153 from github/redsun82/setup-swift-fix
...
CI: apply `setup-swift` workaround
2024-04-09 13:15:39 +02:00
Taus
29b843f772
Merge pull request #16158 from github/tausbn/python-disable-failing-integration-tests
...
Python: Disable failing integration tests
2024-04-09 13:12:48 +02:00
Geoffrey White
13734d4e62
C++: Improve indirectionForModelledFunction.
2024-04-09 12:06:03 +01:00
Geoffrey White
70bb29581d
C++: Test failures.
2024-04-09 11:53:33 +01:00
Taus
8c2455fc11
Python: Disable failing integration tests
...
These failures were likely caused by
https://github.com/github/codeql/pull/16127
My guess is that they can probably be deleted altogether, but as the
failures are blocking other development, I have opted to simply disable
them for the time being.
2024-04-09 10:49:30 +00:00
Tamás Vajk
239776ba21
Merge pull request #16124 from tamasvajk/buildless/nuget-feed-precheck
...
C#: Validate all nuget feeds to respond in reasonable time
2024-04-09 12:12:06 +02:00
Owen Mansel-Chan
a65b02eb28
Update test expectations
2024-04-09 10:59:06 +01:00
Owen Mansel-Chan
f89fb8eb57
Add change note
2024-04-09 10:59:00 +01:00
Owen Mansel-Chan
6ae07a2c43
Add location for implicitly declared variables
2024-04-09 10:58:55 +01:00
Owen Mansel-Chan
ffdb610d93
Add new IR::Instruction MkTypeSwitchImplicitVariable
...
It represents the implicit declaration of a variable at the beginning of a case clause
2024-04-09 10:58:49 +01:00
Owen Mansel-Chan
4ffc4f5c62
Add test for dataflow through switches
2024-04-09 10:58:42 +01:00
Owen Mansel-Chan
0ed330056d
Add extra CFG test for type switch
2024-04-09 10:55:52 +01:00
Owen Mansel-Chan
8df23522f0
Delete redundant test
2024-04-09 10:55:40 +01:00
Mathias Vorreiter Pedersen
448a9015c0
C++: Compute the number of indirections from MaD using a new predicate.
2024-04-09 10:33:06 +01:00
Mathias Vorreiter Pedersen
21592563cb
C++: Define 'ReturnKind's in terms of SSA instead of 'Function'.
2024-04-09 10:32:31 +01:00
Tom Hvitved
5f8eb7b138
Merge pull request #16110 from hvitved/dataflow/param-flow-no-expects-content
...
Data flow: Block flow at `expectsContents` nodes in `parameterValueFlow`
2024-04-09 11:26:24 +02:00
yoff
1048cf7c5e
Merge pull request #15711 from RasmusWL/tt-content
...
Python: Add type tracking for content
2024-04-09 10:37:43 +02:00
Mathias Vorreiter Pedersen
c325a79206
C++: Ensure 'isConditionalTemporaryDestructorCall' only holds when the reused expression is a temporary.
2024-04-09 09:32:54 +01:00
Michael Nebel
10d96ee02f
C#: Address review comments.
2024-04-09 10:31:48 +02:00
Mathias Vorreiter Pedersen
17c8fa3e84
Update cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedElement.qll
...
Co-authored-by: Jeroen Ketema <93738568+jketema@users.noreply.github.com >
2024-04-09 09:27:44 +01:00
Tom Hvitved
e6984aa865
Ruby: Remove two redundant allowImplicitRead predicates
2024-04-09 10:10:25 +02:00
Tamas Vajk
80995ec1d7
Improve comments on environment variable names
2024-04-09 09:51:45 +02:00
codeqlhelper
ac7a25734b
Merge branch 'main' into main
2024-04-09 15:42:58 +08:00
Paolo Tranquilli
e3d676f91b
CI: apply tentative setup-swift fix
2024-04-09 09:37:21 +02:00
Erik Krogh Kristensen
44fba68015
Merge pull request #16128 from erik-krogh/java-info
...
Java: add link to the source variable in the alert-message for `java/implicit-cast-in-compound-assignment`
2024-04-09 08:55:09 +02:00
Mathias Vorreiter Pedersen
386580fc94
C++: Accept test changes.
2024-04-08 21:26:12 +01:00
Mathias Vorreiter Pedersen
b2002a981a
C++: Use the shared typeflow library to determine whether a pointer points to a buffer or an object.
2024-04-08 21:25:05 +01:00
Mathias Vorreiter Pedersen
c389611e5c
C++: Add spurious dataflow test.
2024-04-08 21:24:59 +01:00
erik-krogh
8cb6598f50
fixing that I put a type on the wrong thing in the alert-message
2024-04-08 20:51:19 +02:00
codeqlhelper@gmail.com
334c0d0449
...
2024-04-09 02:06:06 +08:00
codeqlhelper
fc26e148fd
Create 2024-04-09-reduce-FP.md
2024-04-09 02:00:52 +08:00
Geoffrey White
e3ce7c608b
C++: Fix indirection ambiguity in the test.
2024-04-08 18:27:51 +01:00
Geoffrey White
087d689997
C++: Additional test cases.
2024-04-08 18:18:30 +01:00
codeqlhelper
af2a7eadc3
Reduce false alarms of InconsistentNullnessTesting.ql
...
We should ignore `checked` in a macro to avoid too many false alarms,
2024-04-09 00:07:40 +08:00
codeqlhelper
fb15a4ea11
Reduce the false alarms of GlobalUseBeforeInit.ql
2024-04-09 00:03:05 +08:00
Geoffrey White
c0c1ab7006
C++: Fix code scanning warnings.
2024-04-08 16:05:55 +01:00
Geoffrey White
31a246b554
Swift: Remove similar non-functional case from Swift as well.
2024-04-08 16:05:50 +01:00
Geoffrey White
06d369ba11
C++: Remove untested PostUpdateNode code for now, and field cases that don't work anyway.
2024-04-08 16:05:18 +01:00
Geoffrey White
b2b2c2016c
C++: Update more QLDoc.
2024-04-08 16:04:23 +01:00
Mathias Vorreiter Pedersen
4fa53b63ae
Merge branch 'main' into destructors-for-unconditional-unnamed
2024-04-08 15:42:35 +01:00
Mathias Vorreiter Pedersen
9c25ce4079
C++: Add testcase with two destructor calls without a temporary object expression at the top-level.
2024-04-08 15:35:33 +01:00
Mathias Vorreiter Pedersen
e08790d21e
Merge pull request #16146 from MathiasVP/missing-destructor-for-parameter
...
C++: Add example with missing destructor call on parameter
2024-04-08 15:33:00 +01:00
Sylwia Budzynska
5d946586b8
Add tests
2024-04-08 15:39:54 +02:00
Paolo Tranquilli
b71ffc658b
Bazel: properly fix lfs smudge script
2024-04-08 15:22:54 +02:00
Paolo Tranquilli
60febcdf1e
Revert "Bazel: fix lfs to do checkout rather than smudging"
...
This reverts commit fd77f1a7cb .
2024-04-08 14:54:15 +02:00
Mathias Vorreiter Pedersen
b581a9ba04
C++: Add example with missing destructor calls on parameters passed by value.
2024-04-08 13:49:05 +01:00
Paolo Tranquilli
a970c2d11c
Kotlin: move empty zip from git to internal bazel repo rule
2024-04-08 14:37:53 +02:00
Asger F
f08e8b1d5e
Merge pull request #16136 from asgerf/js/instance-to-subclasses
...
JS: Make getInstance() propagate to subclasses
2024-04-08 14:37:42 +02:00
Jeroen Ketema
ad1139d3af
Merge pull request #16116 from jketema/cpp-version-in-doc
...
C++: Update supported compiler versions based on frontend documentation
2024-04-08 14:09:40 +02:00
Mathias Vorreiter Pedersen
febd06063a
C++: Add testcase where two destructor calls are remapped to a temporary object expression.
2024-04-08 13:03:51 +01:00
Paolo Tranquilli
e963b84a5a
Kotlin: fix error in building extractor from internal repo
2024-04-08 14:03:15 +02:00
Michael Nebel
fc689efd1b
C#: Add debug version of the getFullyQualifiedName predicate.
2024-04-08 13:47:59 +02:00
Michael Nebel
8fbfafc1d7
C#: Dont cache the deprecated getFullyQualifiedName predicate.
2024-04-08 13:46:45 +02:00
Michael Nebel
b677e89f35
C#: Deprecate getFullyQualifiedNameWithTypes.
2024-04-08 13:46:45 +02:00
Michael Nebel
8fa9191434
C#: Deprecate the getFullyQualifiedName predicate.
2024-04-08 13:46:44 +02:00
Michael Nebel
2fb9c2db6f
C#: Remove deprecated qualifiedName predicates.
2024-04-08 13:46:44 +02:00
Tamas Vajk
d7f8b96158
Improve logging
2024-04-08 13:15:33 +02:00
Tamas Vajk
95896bc95f
Make sure diagnostic directory exists
2024-04-08 13:15:32 +02:00
Tamas Vajk
6a5520c85d
Add integration test for unreachable nuget feeds
2024-04-08 13:15:32 +02:00
Tamas Vajk
7051db5e1c
Fix code review findings
2024-04-08 13:15:32 +02:00
Tamas Vajk
9aa85f2d13
C#: Validate all nuget feeds to respond in reasonable time
2024-04-08 13:15:20 +02:00
Geoffrey White
ec515f967d
C++: Update QLDoc.
2024-04-08 11:57:35 +01:00
erik-krogh
642a134035
add tests for the fixes in the qhelp, and fix an FP that appeared
2024-04-08 12:00:27 +02:00
erik-krogh
59c72b683c
update the url-redirect QHelp
2024-04-08 12:00:27 +02:00
Tom Hvitved
aa24c29395
Merge pull request #16122 from hvitved/ruby/cfg-may-raise-issue
...
Ruby: Fix CFG for nodes that may raise
2024-04-08 11:20:49 +02:00
Mathias Vorreiter Pedersen
9917c3c5ba
C++: Add change note.
2024-04-08 10:10:31 +01:00
Mathias Vorreiter Pedersen
fae002fbb7
C++: Accept test changes.
2024-04-08 10:10:31 +01:00
Mathias Vorreiter Pedersen
4831ee65b6
C++: Enable sound IR.
2024-04-08 10:10:31 +01:00
Mathias Vorreiter Pedersen
b8e6632bf1
Merge pull request #16140 from MathiasVP/alias-model-for-fopen
...
C++: Add alias models for `fopen` and friends
2024-04-08 10:09:54 +01:00
Paolo Tranquilli
fd77f1a7cb
Bazel: fix lfs to do checkout rather than smudging
...
On Windows `git lfs smudge` was not working as expected.
2024-04-08 10:57:24 +02:00
Rasmus Wriedt Larsen
dfe2f1a52b
Merge pull request #16127 from RasmusWL/remove-dep-inst-fallback
...
Python: Extractor: Remove dependency installation fallback
2024-04-08 10:43:50 +02:00
Asger F
ad9838d0fe
JS: Add change note
2024-04-08 10:02:28 +02:00
Asger F
6e931000c2
JS: Rewrite docs for API::Node#getInstance()
2024-04-08 10:02:22 +02:00
Asger F
d829dd435f
JS: Update docs
2024-04-08 10:00:06 +02:00
Paolo Tranquilli
38a7bc0580
Bazel: optimize LFS to use symlinks when the file is not an LFS pointer
2024-04-08 09:26:19 +02:00
erik-krogh
018b066b95
autoformat
2024-04-08 07:15:33 +02:00
erik-krogh
ca4f667053
add fallback if I can't easily determine the variable
2024-04-08 07:14:48 +02:00
erik-krogh
8b220cc1b3
also get the variable for array accesses
2024-04-08 07:14:48 +02:00
erik-krogh
795b767b6e
add link to the source variable in the alert-message for java/implicit-cast-in-compound-assignment
2024-04-08 07:14:48 +02:00
Mathias Vorreiter Pedersen
d40fa4cfba
C++: Accept test changes.
2024-04-07 15:50:16 +01:00
Mathias Vorreiter Pedersen
8a6a60e59b
C++: Also handle destructor calls on converted expressions in PrintAST.
2024-04-07 15:49:50 +01:00
Mathias Vorreiter Pedersen
fcd0e9999c
C++: Accept test changes.
2024-04-07 15:49:27 +01:00
Mathias Vorreiter Pedersen
89eaadd76f
C++: Move destructor calls from expressions with a temporary object conversion to the temporary object conversion.
2024-04-07 15:48:38 +01:00
Mathias Vorreiter Pedersen
a0de95dc44
C++: Add testcases that produces an 'missingOperandType' and 'missingPhiOperand' consistency errors.
2024-04-07 14:26:30 +01:00
Mathias Vorreiter Pedersen
557555eb71
C++: Make Code Scanning happy.
2024-04-05 19:03:03 +01:00
Mathias Vorreiter Pedersen
777755a241
C++: Add alias models for 'fopen'.
2024-04-05 19:02:23 +01:00
Mathias Vorreiter Pedersen
45e71543b4
C++: Accept test changes.
2024-04-05 18:08:25 +01:00
Mathias Vorreiter Pedersen
54e4103e71
C++: Fix another multiple parents problem.
2024-04-05 18:07:53 +01:00
Mathias Vorreiter Pedersen
955f9c735c
C++: Add a failing testcase.
2024-04-05 18:05:30 +01:00
Mathias Vorreiter Pedersen
2256c4c008
Merge pull request #15728 from MathiasVP/shared-typeflow-library
...
Java/Shared: Refactor `TypeFlow.qll` into a shared library
2024-04-05 16:24:17 +01:00
Mathias Vorreiter Pedersen
c85db2a026
Merge pull request #16137 from MathiasVP/swift-5.10-support-fix
...
Docs: Remove Swift version in footnote
2024-04-05 14:59:39 +01:00
Mathias Vorreiter Pedersen
d114d09d73
Docs: Remove Swift version in footnote.
2024-04-05 14:52:19 +01:00
Mathias Vorreiter Pedersen
4c01c06f0c
C++: Accept test changes.
2024-04-05 14:49:22 +01:00
Mathias Vorreiter Pedersen
f1d2dac648
C++: Fix a bug where the destructor attached to a 'new' expression would
...
have multiple parents (the 'new' expression, the call to 'operator new',
and the size expression). This happens because the latter two are
'TranslatedExpr's that return the 'new' expression as their expression
even though they don't technically represent the translation of this
expression.
To prevent this bug we tell the IR construction that the latter two
handle their destructors explicitly which means that IR construction
doesn't try to synthesize them.
2024-04-05 14:46:27 +01:00
Mathias Vorreiter Pedersen
b042366c8e
C++: Add a failing testcase.
2024-04-05 14:41:11 +01:00
Asger F
cd84fa4bee
JS: Make getInstance() propagate to subclasses
2024-04-05 15:12:02 +02:00
Sylwia Budzynska
112992585a
Add change note
2024-04-05 14:56:06 +02:00
Sylwia Budzynska
84d69566c9
Fix decorator QLdoc
2024-04-05 14:51:30 +02:00
Sylwia Budzynska
ca7789d73c
Fix QLdoc
2024-04-05 14:40:17 +02:00
Mathias Vorreiter Pedersen
27688bf154
Shared: Rename 'joinStep' to 'joinStepNotNull' to prevent name clashes. Rename 'sccJoinStep' to 'sccJoinStepNotNull' to match the new name.
2024-04-05 13:25:29 +01:00
Mathias Vorreiter Pedersen
bae633ad24
Shared: Make 'erasedHaveIntersection' more identical to the Java version.
2024-04-05 13:19:21 +01:00
Sylwia Budzynska
bed0d5678d
Add Gradio models
2024-04-05 14:14:21 +02:00
Mathias Vorreiter Pedersen
9deeb67af4
Update shared/typeflow/codeql/typeflow/internal/TypeFlowImpl.qll
...
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com >
2024-04-05 13:10:08 +01:00
Mathias Vorreiter Pedersen
ba347bdcf2
Merge pull request #16133 from MathiasVP/swift-5.10-support-docs
...
Docs: Mark Swift version 5.10 as supported
2024-04-05 13:07:09 +01:00
Mathias Vorreiter Pedersen
bffa262a2c
Shared: Make 'getAStrictAncestor' private.
2024-04-05 13:04:26 +01:00
Mathias Vorreiter Pedersen
96e205a4a6
Docs: Mark Swift 5.10 as supported.
2024-04-05 12:59:07 +01:00
Mathias Vorreiter Pedersen
a2c29fe094
Shared: nomagicify 'getASourceSupertype'.
2024-04-05 12:57:11 +01:00
Mathias Vorreiter Pedersen
3f6967829e
Update shared/typeflow/codeql/typeflow/internal/TypeFlowImpl.qll
...
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com >
2024-04-05 12:53:23 +01:00
Mathias Vorreiter Pedersen
1775bdee5f
Java: Remove redundant qualifiers.
2024-04-05 12:52:04 +01:00
Mathias Vorreiter Pedersen
26cf8df8d6
Update java/ql/lib/semmle/code/java/dataflow/TypeFlow.qll
...
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com >
2024-04-05 12:50:26 +01:00
Mathias Vorreiter Pedersen
3f63d3a865
Update java/ql/lib/semmle/code/java/dataflow/TypeFlow.qll
...
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com >
2024-04-05 12:49:40 +01:00
Mathias Vorreiter Pedersen
1acbb84444
Shared/Java: Make the 'isNull' interface slightly prettier.
2024-04-05 11:58:43 +01:00
Pierre
e5b7957e4a
Merge pull request #16130 from github/sitedocs/2.17.0
...
Add changelog for 2.17.0
2024-04-05 12:46:45 +02:00
Taus
ef9f99b3be
Python: Remove unparse.py
2024-04-05 12:30:40 +02:00
Taus
599f573a4a
Python: Preserve comments and docstrings in extractor
2024-04-05 12:30:40 +02:00
Taus
752d28c1b9
Python: Update repinning instructions
...
This aligns us better with the corresponding instructions for
the Ruby extractor.
2024-04-05 12:30:40 +02:00
Taus
7bec41096c
Python: Rename tsg-build target to tsp-build
...
The latter makes more sense, as it's actually building
`tree-sitter-python`.
2024-04-05 12:30:40 +02:00
Mathias Vorreiter Pedersen
bb2c690bdd
C++: Accept test changes.
2024-04-05 09:49:38 +01:00
Mathias Vorreiter Pedersen
d279e3f17a
C++: Suppress destructor calls for the right-hand side of logical operations since these are also conditional.
2024-04-05 09:47:11 +01:00
Mathias Vorreiter Pedersen
e63a607eb3
C++: Add another test with conditional construction.
2024-04-05 09:41:50 +01:00
Pierre
268141822d
Merge branch 'main' into sitedocs/2.17.0
2024-04-05 09:39:18 +02:00
erik-krogh
6d3244d01c
update expected outputs with an FP
2024-04-05 09:36:44 +02:00
erik-krogh
3ab73c8552
C++: Improve the cpp/path-injection qhelp
2024-04-05 09:36:39 +02:00
Pierre
9e49c5f185
Add changelogs for 2.16.6 (to this branch) and 2.17.0 (new)
2024-04-05 09:34:27 +02:00
Pierre
0604b4cc14
Changelog mergeback for versions prior to 2.17.0
2024-04-05 09:33:51 +02:00
Owen Mansel-Chan
e10333bf2b
Merge pull request #14919 from github/java/jdk-model-autogeneration
...
Java: add dataflow-generated models for JDK17
2024-04-04 21:12:55 +01:00
Owen Mansel-Chan
32ea94e625
Merge pull request #16123 from owen-mc/go/misc-trivial-fixes
...
Go: miscellaneous trivial fixes
2024-04-04 21:09:15 +01:00
Mathias Vorreiter Pedersen
b6ddb97e40
C++: Accept test changes.
2024-04-04 20:02:02 +01:00
Mathias Vorreiter Pedersen
f098b8eb82
C++: Make sure the edge kind out of a throw is an 'ExceptionEdge' even if destructors are called.
2024-04-04 20:01:52 +01:00
Geoffrey White
bdc3d10cdb
C++: QLDoc SummaryCall, SourceCallable and SummarizedCallable.
2024-04-04 17:13:59 +01:00
Geoffrey White
49ef677b1d
C++: Additional test case for function pointers.
2024-04-04 16:53:29 +01:00
Geoffrey White
144c19db74
C++: Add a test of SummaryCalls, SummarizedCallables and sourceCallables.
2024-04-04 16:50:50 +01:00
Paolo Tranquilli
7aefd22e34
Kotlin: tweak BUILD.bazel file, add documentation
2024-04-04 17:32:23 +02:00
Paolo Tranquilli
44f3c0289a
Kotlin: revert accidental modification of kotlin_plugin_versions.py
2024-04-04 17:31:40 +02:00
Mathias Vorreiter Pedersen
587ae07579
C++: Accept query test changes.
2024-04-04 16:23:41 +01:00
Mathias Vorreiter Pedersen
8f11cb64ec
C++: Accept test changes.
2024-04-04 16:03:06 +01:00
Mathias Vorreiter Pedersen
180888616b
C++: Properly handle the case where a TranslatedElement has no children.
2024-04-04 16:02:01 +01:00
Mathias Vorreiter Pedersen
805b4d6465
C++: Add a failing testcase.
2024-04-04 16:01:25 +01:00
Paolo Tranquilli
cbdb1ebb5a
Merge branch 'main' into redsun82/kotlin
2024-04-04 16:56:07 +02:00
Rasmus Wriedt Larsen
4faff83aa0
Python: Extractor: Remove dependency installation fallback
2024-04-04 16:49:55 +02:00
Dave Bartolomeo
2336e14627
Remove expectation of spurious diagnostic
2024-04-04 10:31:05 -04:00
Mathias Vorreiter Pedersen
774efb5f3f
Merge branch 'main' into destructors-for-unconditional-unnamed
2024-04-04 15:04:34 +01:00
Asger F
b8b8e2b991
Merge pull request #16054 from asgerf/js/call-graph-improvement2
...
JS: more implied receiver steps
2024-04-04 15:54:06 +02:00
Mathias Vorreiter Pedersen
0b7070feec
C++: Accept test changes.
2024-04-04 14:51:16 +01:00
Mathias Vorreiter Pedersen
73602dca92
C++: Also suppress destructor calls on throwing ternary expressions.
2024-04-04 14:51:11 +01:00
Paolo Tranquilli
3a0a219ce7
Kotlin: remove obsolete 1.4.32 version
2024-04-04 15:49:37 +02:00
Mathias Vorreiter Pedersen
a6a0e20176
C++: Accept test changes.
2024-04-04 14:45:20 +01:00
Mathias Vorreiter Pedersen
796fcfec6c
C++: Handle conversions in 'isInConditionalEvaluation'.
2024-04-04 14:44:16 +01:00
Erik Krogh Kristensen
0cfac605bd
Merge pull request #16100 from erik-krogh/fix-js-rb-typo
...
RB: fix language specifier typo in qhelp for rb/multi-char-san
2024-04-04 15:42:45 +02:00
Mathias Vorreiter Pedersen
56a132fa8e
C++: Accept test changes.
2024-04-04 14:41:24 +01:00
Mathias Vorreiter Pedersen
a756f14e77
C++: Only report implicit destructors if we need to translate them.
2024-04-04 14:41:23 +01:00
Paolo Tranquilli
5d6baea174
Kotlin: add aliases for default versions
2024-04-04 15:34:48 +02:00
Tamas Vajk
e42639852c
C#: Move nuget related DependencyManager methods to separate file
2024-04-04 14:25:09 +02:00
Tom Hvitved
ce3b359813
Ruby: Fix CFG for nodes that may raise
2024-04-04 13:27:29 +02:00
Tom Hvitved
6d2d9654b5
Ruby: Add CFG test
2024-04-04 13:27:29 +02:00
Paolo Tranquilli
55ff7109fa
Kotlin: support embeddable build in bazel
2024-04-04 12:53:14 +02:00
Mathias Vorreiter Pedersen
d4e2d37311
C++: Add a simple test that fails.
2024-04-04 11:29:25 +01:00
Mathias Vorreiter Pedersen
cf996f8600
C++: Accept test changes.
2024-04-04 11:28:33 +01:00
Robert Marsh
17e8c95e7f
C++: suppress destructors on conditional temporaries
2024-04-04 11:28:10 +01:00
Mathias Vorreiter Pedersen
894d934de8
C++: Accept test changes.
2024-04-04 11:28:01 +01:00
Owen Mansel-Chan
7fc5265168
Misc small tidy-ups mostly suggested by linter
2024-04-04 10:51:22 +01:00
Owen Mansel-Chan
68321dd9ec
Use nil for optional argument to packages.Visit
2024-04-04 10:51:13 +01:00
Owen Mansel-Chan
d9fe39d5ae
Extractor: add comment about tw.Package.TypesInfo.Defs
2024-04-04 10:37:31 +01:00
Owen Mansel-Chan
720961787b
Improve QLDoc for CaseClause
2024-04-04 10:37:25 +01:00
Jeroen Ketema
a8f27af6d8
Merge pull request #16119 from jketema/coroutine2
...
C++: Add more missing variable declaration tests
2024-04-04 11:35:52 +02:00
Robert Marsh
75c453fd30
C++: Unsuppress temporary destructors in IR
2024-04-04 10:29:59 +01:00
Paolo Tranquilli
5313288b8e
LFS: do non-matching fetchinclude rather than explicit fetchexclude
2024-04-04 11:02:29 +02:00
Jeroen Ketema
70491c4a8d
C++: Add more missing variable declaration tests
2024-04-04 10:54:09 +02:00
Tom Hvitved
c03b74545d
Merge pull request #16115 from hvitved/dataflow/fix-bad-join
...
Data flow: Fix bad join
2024-04-04 10:51:22 +02:00
Paolo Tranquilli
47ff1c1ee6
Kotlin: working standalone extractor built with bazel
2024-04-04 10:23:26 +02:00
Jeroen Ketema
55d1f43239
C++: Update supported compiler versions based on frontend documentation
2024-04-04 10:18:56 +02:00
Tom Hvitved
79440f6734
Data flow: Fix bad join
...
```
Evaluated relational algebra for predicate DataFlowImpl::Impl<PolynomialReDoSQuery::PolynomialReDoSFlow::C>::storeEx/5#34133ef9@0425e0m7 with tuple counts:
2209132 ~1% {6} r1 = SCAN `DataFlowImpl::Impl<PolynomialReDoSQuery::PolynomialReDoSFlow::C>::storeExUnrestricted/5#3a86a98e` OUTPUT In.1, In.0, In.1, In.2, In.3, In.4
4338565685 ~1% {6} | JOIN WITH `DataFlowPublic::ContentSet.getAReadContent/0#dispred#e4acf74e_10#join_rhs` ON FIRST 1 OUTPUT Rhs.1, Lhs.1, Lhs.2, Lhs.3, Lhs.4, Lhs.5
34811200 ~1428% {5} | JOIN WITH `project#DataFlowImpl::Impl<PolynomialReDoSQuery::PolynomialReDoSFlow::C>::readSetEx/3#35ac556a` ON FIRST 1 OUTPUT Lhs.1, Lhs.2, Lhs.3, Lhs.4, Lhs.5
return r1
```
2024-04-04 10:02:02 +02:00
Tom Hvitved
c2f91a5ccf
Merge pull request #16104 from hvitved/csharp/more-compiler-generated
...
C#: Mark more expressions as compiler generated
2024-04-04 09:09:16 +02:00
Tom Hvitved
fc02938687
Merge pull request #16088 from hvitved/csharp/library-property-store
...
C#: Include all non-source-code properties in data flow
2024-04-04 09:04:00 +02:00
Tamás Vajk
7beb73729d
Merge pull request #16036 from tamasvajk/autobuilder/disposable
...
C#: Properly dispose diagnostic writer objects
2024-04-04 08:21:11 +02:00
Tom Hvitved
813f5b99e7
C#: Update PrintAST query
2024-04-03 20:03:02 +02:00
Tom Hvitved
d93d6585d9
C#: Mark more expressions as compiler generated
2024-04-03 20:03:02 +02:00
Tom Hvitved
c2d771b334
Ruby: Reduce alerts produced by MassAssignment.ql
2024-04-03 19:58:51 +02:00
Tom Hvitved
3c96bf6b22
Fix bad join
2024-04-03 19:41:37 +02:00
Erik Krogh Kristensen
35f61d9de4
Merge pull request #16107 from erik-krogh/fix-log-injection-typo
...
RB: Tiny fixes to log-injection QHelp
2024-04-03 18:29:37 +02:00
Paolo Tranquilli
c242466d31
Kotlin: first support for Kotlin extractor build
2024-04-03 16:30:57 +02:00
Tom Hvitved
2d4cf55c87
Merge pull request #15985 from hvitved/ruby/phi-barrier-guards
...
Ruby: Extend barrier guards to handle phi inputs
2024-04-03 15:22:39 +02:00
Tom Hvitved
7871fb8ce6
Data flow: Block flow at expectsContents nodes in parameterValueFlow
2024-04-03 15:19:34 +02:00
Tom Hvitved
137594cf36
Ruby: Add regression test
2024-04-03 15:19:34 +02:00
Geoffrey White
a8742ea111
C++: PascalCase and US spelling fixes.
2024-04-03 14:17:55 +01:00
Owen Mansel-Chan
fe24710c96
Improve QLDoc of Entity.getDeclaration
2024-04-03 14:09:37 +01:00
Owen Mansel-Chan
c7f2e991ed
Improve QLDoc for TypeAssertExpr
...
Include information about the type assert `x.(type)` used in type switches.
2024-04-03 13:59:04 +01:00
Owen Mansel-Chan
698debfa20
Extractor: explicitly deal with extracting x.(type) in type switches
2024-04-03 13:58:58 +01:00
Tamás Vajk
9be2b9cbdb
Merge pull request #16108 from tamasvajk/cleanup/utils
...
C#: Remove unused classes from `Util` project
2024-04-03 14:24:58 +02:00
Tamás Vajk
362a109e04
Remove redundant implemented interface
...
Co-authored-by: Michael Nebel <michaelnebel@github.com >
2024-04-03 14:23:36 +02:00
Tom Hvitved
8b78463f25
Merge pull request #16087 from hvitved/dataflow/store-step-exploration
...
Data flow: Do not require stores to have matching reads in flow exploration
2024-04-03 14:10:28 +02:00
Tom Hvitved
550e251d68
Data flow: Do not require stores to have matching reads in flow exploration
2024-04-03 13:28:24 +02:00
Tamas Vajk
75894d581c
C#: Remove unused classes from Util project
2024-04-03 12:15:37 +02:00
Tom Hvitved
1dc13cc169
Merge pull request #15923 from hvitved/shared-xml-impl
...
Properly shared `XML.qll` implementation
2024-04-03 11:39:50 +02:00
Tom Hvitved
64e82bb00e
C#: Include all non-source-code properties in data flow
2024-04-03 10:22:36 +02:00
Tom Hvitved
cccb11f697
Merge pull request #16091 from hvitved/csharp/system-diagnostics-modules
...
C#: Neutralize some `System.Diagnostics` generated models
2024-04-03 10:21:56 +02:00
Tamas Vajk
fbec197d4a
Move TSP diagnostics related classes to separate files
2024-04-03 10:13:44 +02:00
Tamas Vajk
305fa84186
Change IDiagnosticsWriter to implement IDisposable
2024-04-03 10:08:46 +02:00
Tamas Vajk
0f980e2b97
C#: Properly dispose diagnostic writer objects
2024-04-03 09:47:24 +02:00
erik-krogh
ec32bdce63
fix unsanitized -> sanitized typo, and don't add a new variable just to remove newlines
2024-04-03 09:19:18 +02:00
Tamás Vajk
d7e514913f
Merge pull request #16039 from tamasvajk/fix/buildless-references
...
C#: Reword public mentions of C# buildless
2024-04-03 09:19:13 +02:00
Paolo Tranquilli
341816c280
Kotlin: add dependencies as lazy LFS files
2024-04-03 08:35:34 +02:00
Paolo Tranquilli
0da4130bb9
Bazel: add LFS rules
2024-04-03 08:35:19 +02:00
Dave Bartolomeo
ce98353d22
Allow @param tags to apply to record parameters
2024-04-02 15:15:11 -04:00
Chuan-kai Lin
1f27eb3658
Merge pull request #16102 from github/post-release-prep/codeql-cli-2.17.0
...
Post-release preparation for codeql-cli-2.17.0
2024-04-02 11:47:23 -07:00
github-actions[bot]
19797fdd27
Post-release preparation for codeql-cli-2.17.0
2024-04-02 18:20:44 +00:00
Chuan-kai Lin
839ca60f90
Merge pull request #16099 from github/release-prep/2.17.0
...
Release preparation for version 2.17.0
2024-04-02 11:07:43 -07:00
erik-krogh
572d3ba542
fix language specifier typo in qhelp for rb/multi-char-san
2024-04-02 19:40:46 +02:00
github-actions[bot]
c511de2eae
Release preparation for version 2.17.0
2024-04-02 17:15:41 +00:00
Chuan-kai Lin
b87cf3c41a
Merge pull request #16098 from github/revert-16085-release-prep/2.17.0
...
Revert "Release preparation for version 2.17.0"
2024-04-02 10:11:15 -07:00
Chuan-kai Lin
6c649c898e
Revert "Release preparation for version 2.17.0"
2024-04-02 10:06:20 -07:00
Mathias Vorreiter Pedersen
4baa9ad8c8
C++: Accept test changes.
2024-04-02 18:02:43 +01:00
Mathias Vorreiter Pedersen
baa508d336
C++: Add some simple coroutine tests.
2024-04-02 18:02:43 +01:00
Geoffrey White
db60360293
C++: Add a test case where a function has a MAD model *and* an implementation.
2024-04-02 17:50:00 +01:00
Geoffrey White
9c4567bd6d
Swift: Additional models-as-data doc change I missed out in the other PR - neither CPP nor Swift support 'Parameter' with no argument in an access path.
2024-04-02 16:18:25 +01:00
Geoffrey White
f2ef4ad6ac
C++: Update for the provenance changes.
2024-04-02 16:15:08 +01:00
Geoffrey White
57beb73bf7
C++: Update for the dataflow hasLocationInfo -> getLocation change made on main.
2024-04-02 16:15:06 +01:00
Geoffrey White
f1ead2554f
C++: Trivial merge fixes.
2024-04-02 16:15:05 +01:00
Geoffrey White
33164c8a43
Merge branch 'main' into mad
2024-04-02 16:14:53 +01:00
Michael B. Gale
48f93438d8
Merge pull request #16096 from github/mbg/go/revert-auto-version-fixing
...
Go: Revert `go version` call in `LoadGoModules`
2024-04-02 16:01:45 +01:00
Geoffrey White
11acb499bb
Merge pull request #16042 from geoffw0/maddoc
...
Remove [potentially] untrue claims about models-as-data
2024-04-02 16:01:31 +01:00
Rasmus Wriedt Larsen
a22b9947c0
Python: Revert IterableSequenceNode as LocalSourceNode
...
When looking things over a bit more, we could actually exclude the steps
that would never be used instead. A much more involved solution, but
more performance oriented and clear in terms of what is supported (at
least until we start supporting type-tracking with more than depth 1
access-path, if that ever happens)
2024-04-02 16:51:00 +02:00
Michael B. Gale
55fa245194
Go: Revert go version call in LoadGoModules
2024-04-02 15:20:56 +01:00
Mathias Vorreiter Pedersen
0bf742b82d
Merge pull request #16089 from MathiasVP/fix-double-free-join
...
C++: Fix join order in 'cpp/double-free'.
2024-04-02 14:15:51 +01:00
Asger F
2feb00bb2e
Merge pull request #13303 from asgerf/js/use-server-and-client
...
JS: Move Directive subclasses into module and support "use client/server"
2024-04-02 15:13:45 +02:00
Michael Nebel
c378d6a661
Merge pull request #16027 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-04-02 14:08:09 +02:00
Tom Hvitved
368a500d93
C#: Neutralize some System.Diagnostics generated models
2024-04-02 13:58:55 +02:00
Felicity Chapman
75eee04f3e
Merge pull request #15890 from intrigus-lgtm/patch-9
...
[cpp-docs] Fix 404 link in guards library doc.
2024-04-02 12:49:03 +01:00
Rasmus Wriedt Larsen
8707a63edb
Python: Add comments around storeStepCommon
2024-04-02 13:26:26 +02:00
Rasmus Wriedt Larsen
20202aba90
Python: Deprecate AttributeName
2024-04-02 13:21:46 +02:00
Ian Lynagh
e610573411
Merge pull request #16078 from igfoo/igfoo/exprs_changes
...
Kotlin 2: Accept more changes
2024-04-02 12:19:17 +01:00
Ian Lynagh
e5999f76b0
Merge pull request #16079 from igfoo/igfoo/del
...
Kotlin 2: Accept some more location changes
2024-04-02 12:18:58 +01:00
Harry Maclean
409f46ef7b
Merge pull request #14308 from hmac/hmac-rb-csrf-not-enabled
...
Ruby: Add a query for CSRF protection not enabled
2024-04-02 11:30:36 +01:00
Jeroen Ketema
3c8c45872e
Merge pull request #16060 from jketema/qual-fix
...
C++: Output destructor calls for delete expressions
2024-04-02 11:49:51 +02:00
Henry Mercer
9409d7fdca
Merge pull request #16066 from github/henrymercer/ql-run-diagnostics
...
QL: Run diagnostics and summary metrics in code scanning
2024-04-02 10:45:50 +01:00
Mathias Vorreiter Pedersen
352e7de07d
C++: Accept test changes.
2024-04-02 10:43:10 +01:00
Jeroen Ketema
01183800a6
C++: Fix formatting
2024-04-02 11:38:19 +02:00
Jeroen Ketema
9190bf25ce
C++: Add example to QLDoc
2024-04-02 11:35:43 +02:00
Rasmus Wriedt Larsen
f33222c83b
JS: Add change-note
2024-04-02 11:10:53 +02:00
Mathias Vorreiter Pedersen
bd0ddec630
C++: Fix join order in 'cpp/double-free'.
2024-04-02 09:59:53 +01:00
Jeroen Ketema
a5d4fad806
C++: Output destructor calls for delete expressions
2024-04-02 10:32:03 +02:00
Tom Hvitved
a8dac17aec
Merge pull request #16016 from hvitved/csharp/remove-lgtm-autobuilder-options
...
C#: Remove support for legacy LGTM options in autobuilder
2024-04-02 10:03:10 +02:00
Erik Krogh Kristensen
332c1e3b8a
Merge pull request #16026 from erik-krogh/htmlSafeSan
...
RB: Add barrier guard for `.html_safe?` to the XSS queries
2024-04-02 07:54:19 +02:00
Erik Krogh Kristensen
0fd89549da
Merge pull request #16033 from github/dependabot/cargo/ql/regex-1.10.4
...
Bump regex from 1.10.3 to 1.10.4 in /ql
2024-04-02 07:52:17 +02:00
Erik Krogh Kristensen
58bf0b709f
Merge pull request #16077 from github/dependabot/cargo/ql/chrono-0.4.37
...
Bump chrono from 0.4.35 to 0.4.37 in /ql
2024-04-02 07:51:49 +02:00
github-actions[bot]
55987d9c1f
Add changed framework coverage reports
2024-04-02 00:16:19 +00:00
Chuan-kai Lin
0bc9318400
Merge pull request #16086 from github/post-release-prep/codeql-cli-2.17.0
...
Post-release preparation for codeql-cli-2.17.0
2024-04-01 08:41:39 -07:00
github-actions[bot]
8e61c6625b
Post-release preparation for codeql-cli-2.17.0
2024-04-01 15:27:42 +00:00
Chuan-kai Lin
6475034b09
Merge pull request #16085 from github/release-prep/2.17.0
...
Release preparation for version 2.17.0
2024-04-01 06:53:52 -07:00
github-actions[bot]
ec97d9a304
Release preparation for version 2.17.0
2024-04-01 13:46:57 +00:00
Owen Mansel-Chan
fdafaa2ff4
Change note: update numbers of models added
2024-04-01 14:04:01 +01:00
Owen Mansel-Chan
e3fb40a842
Adjust change note
2024-04-01 14:03:53 +01:00
Owen Mansel-Chan
a5979e209a
Add change note
2024-04-01 14:03:47 +01:00
Owen Mansel-Chan
fa614df3f4
Tests fixed by model for CharBuffer.wrap(char[])
2024-04-01 14:03:42 +01:00
Owen Mansel-Chan
2d24fe011b
Accept that lots of sinks are now summaries as well
2024-04-01 14:03:36 +01:00
Owen Mansel-Chan
9067a337b0
Test fixed by model for BasicAttributes(String, Object)
2024-04-01 14:03:30 +01:00
Owen Mansel-Chan
776c9d9eb2
Accept changes to top jdk apis test
2024-04-01 14:03:23 +01:00
Owen Mansel-Chan
52e6ea30e7
Accept more capture summary models
...
This line is added because `FileOutputStream`'s constructor is now modeled as propagating taint, not just as a sink.
| p;PrivateFlowViaPublicInterface$SPI;true;openStream;();;Argument[this];ReturnValue;taint;df-generated |
2024-04-01 14:03:00 +01:00
Owen Mansel-Chan
919436efbb
Remove df-gen models we have deliberately modeled
...
Manual models always take precedence over generated models, so there is
no point in keeping the generated models.
These manual models were deliberately written to take precedence over
the corresponding df-gen models.
2024-04-01 13:59:36 +01:00
Jami
d889e3cf98
Merge pull request #14854 from jcogs33/jcogs33/unsafe-url-forward-promotion
...
Java: Promote Unsafe URL Forward query from experimental
2024-03-29 16:34:06 -04:00
Geoffrey White
fa26b55452
C++: Add models-as-data models for ZMQ networking library + wiring.
2024-03-28 21:50:07 +00:00
Geoffrey White
16f9ad06ef
C++: Add a test for ZMQ network library sources as well.
2024-03-28 21:50:07 +00:00
Geoffrey White
891f05c5ae
C++: Add a test for simple sinks involving ZMQ networking library.
2024-03-28 21:50:07 +00:00
Geoffrey White
5618001c3f
C++: More QLDoc refinement.
2024-03-28 21:50:07 +00:00
Jami
2f8c4df309
docs wording updates
...
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com >
2024-03-28 16:15:05 -04:00
James Fletcher
5b1cae5fc2
Merge pull request #16076 from github/jf205-patch-1
...
Make customizing-library-models-for-javascript.rst visible to search and the docs TOC
2024-03-28 17:05:32 +00:00
Calum Grant
ef2e2e4067
Merge pull request #16071 from github/calumgrant/cpp-analysis
...
Add C++ analysis in separate workflow
2024-03-28 17:53:53 +01:00
Ian Lynagh
3acdc73f22
Kotlin 2: Accept some more location changes
2024-03-28 16:15:37 +00:00
Ian Lynagh
568fba6940
Kotlin 2: Accept some more test changes
2024-03-28 15:28:36 +00:00
Ian Lynagh
0fdc71bf57
Kotlin 2: Accept a test change
...
For
if(r != null) {
val r2: Rectangle = r
in Kotlin 2 mode, there is no IMPLICIT_NOTNULL check in Kotlin 2 mode:
then: BLOCK type=kotlin.Unit origin=null
VAR name:r2 type:java.awt.Rectangle [val]
- TYPE_OP type=java.awt.Rectangle origin=IMPLICIT_NOTNULL typeOperand=java.awt.Rectangle
- GET_VAR 'val r: @[FlexibleNullability] java.awt.Rectangle? [val] declared in <root>.foo' type=@[FlexibleNullability] java.awt.Rectangle? origin=null
+ GET_VAR 'val r: @[FlexibleNullability] java.awt.Rectangle? [val] declared in <root>.foo' type=@[FlexibleNullability] java.awt.Rectangle? origin=null
VAR name:height type:kotlin.Int [val]
GET_FIELD 'FIELD IR_EXTERNAL_JAVA_DECLARATION_STUB name:height type:kotlin.Int visibility:public' type=kotlin.Int origin=null
receiver: GET_VAR 'val r2: java.awt.Rectangle [val] declared in <root>.foo' type=java.awt.Rectangle origin=null
2024-03-28 15:23:27 +00:00
Ian Lynagh
96723b1a8f
Kotlin 2: Accept some loc changes
2024-03-28 15:11:19 +00:00
Ian Lynagh
24c4c3e068
Kotlin 2: Accept a test change
...
With:
open class Root {}
class Subclass1: Root() {}
fun typeTests(x: Root, y: Subclass1) {
val y1: Subclass1 = if (x is Subclass1) { x } else { y }
}
we now get a slightly different AST, which means we no longer need to
insert a StmtExpr:
BRANCH
if: TYPE_OP type=kotlin.Boolean origin=INSTANCEOF typeOperand=<root>.Subclass1
GET_VAR 'x: <root>.Root declared in <root>.typeTests' type=<root>.Root origin=null
- then: TYPE_OP type=<root>.Subclass1 origin=IMPLICIT_CAST typeOperand=<root>.Subclass1
- BLOCK type=<root>.Root origin=null
+ then: BLOCK type=<root>.Subclass1 origin=null
+ TYPE_OP type=<root>.Subclass1 origin=IMPLICIT_CAST typeOperand=<root>.Subclass1
GET_VAR 'x: <root>.Root declared in <root>.typeTests' type=<root>.Root origin=null
2024-03-28 15:07:30 +00:00
Michael B. Gale
73f71d8ace
Merge pull request #15979 from github/mbg/go/deal-with-incorrect-versions
2024-03-28 14:16:14 +00:00
Michael B. Gale
f6c22d466f
Update toolchain_test.go
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2024-03-28 13:32:02 +00:00
Sid Shankar
aeacfb82c1
Merge pull request #16073 from hmac/ruby-re-add-mad-docs
...
Ruby: Re-add MaD docs
2024-03-28 09:18:04 -04:00
Paolo Tranquilli
2fa2a5a53c
Merge pull request #15984 from github/alexdenisov/swift-5.10
...
Swift: upgrade to 5.10
2024-03-28 13:58:39 +01:00
Geoffrey White
03d0d984e3
C++: Remove duplicate TDataFlowCallable's and fix three places where we assumed a source callable (two of them would have caused lost results).
2024-03-28 11:39:43 +00:00
Michael B. Gale
977ac71b26
Update toolchain_test.go
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2024-03-28 11:15:30 +00:00
Ian Lynagh
5dcd635403
Merge pull request #15961 from igfoo/igfoo/MissingEnumInSwitch
...
Java: Limit the amount of results that MissingEnumInSwitch produces per switch
2024-03-28 11:13:45 +00:00
Paolo Tranquilli
a34bb2608d
Swift: fix ql format
2024-03-28 11:57:33 +01:00
Paolo Tranquilli
ece0d1f477
Swift: add upgrade/downgrade scripts
2024-03-28 11:54:18 +01:00
Paolo Tranquilli
bfce01cef6
Swift: add change note for Swift 5.10 upgrade
2024-03-28 11:38:39 +01:00
James Fletcher
d57e8efaf2
Update codeql-for-javascript.rst
2024-03-28 10:28:37 +00:00
Geoffrey White
a55f07ac68
C++: QLDoc FlowSummaryNode.
2024-03-28 10:17:39 +00:00
Jeroen Ketema
3d8ac1441a
Merge pull request #16074 from jketema/reuse-val-cat
...
C++: Add value category column to the expr_reuse relation
2024-03-28 10:14:32 +01:00
dependabot[bot]
07f9614dc2
Bump chrono from 0.4.35 to 0.4.37 in /ql
...
Bumps [chrono](https://github.com/chronotope/chrono ) from 0.4.35 to 0.4.37.
- [Release notes](https://github.com/chronotope/chrono/releases )
- [Changelog](https://github.com/chronotope/chrono/blob/main/CHANGELOG.md )
- [Commits](https://github.com/chronotope/chrono/compare/v0.4.35...v0.4.37 )
---
updated-dependencies:
- dependency-name: chrono
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-28 03:07:21 +00:00
Jeroen Ketema
9eb51a9b9e
C++: Add value category column to the expr_reuse relation
2024-03-27 22:49:40 +01:00
Jeroen Ketema
9e47909208
Merge pull request #16065 from geoffw0/codeowners
...
C++: Divide CODEOWNERS responsibilities.
2024-03-27 22:22:15 +01:00
Harry Maclean
3690f294da
Ruby: add MaD doc to TOC tree
2024-03-27 21:02:25 +00:00
Ian Lynagh
b6a1266ade
Java: Accept test changes for MissingEnumInSwitch Oxford commas
2024-03-27 18:48:22 +00:00
Harry Maclean
ce0edcc265
Ruby: Make MaD doc visible to search
...
Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com >
2024-03-27 17:29:18 +00:00
James Fletcher
04edd6ec69
Update docs/codeql/codeql-language-guides/codeql-for-javascript.rst
2024-03-27 17:08:47 +00:00
James Fletcher
121fed63a0
Update codeql-for-javascript.rst
2024-03-27 17:06:31 +00:00
James Fletcher
fbc0f57280
Update customizing-library-models-for-javascript.rst
2024-03-27 16:58:11 +00:00
Paolo Tranquilli
e9957aa4a6
Swift: make result a child in ThenStmt
2024-03-27 17:53:36 +01:00
Geoffrey White
103932fec8
C++: Resolve discussed TODO comment.
2024-03-27 16:44:50 +00:00
Geoffrey White
507ada1951
C++: Sort out the localFlow / simpleLocalFlow confusion (and the same for taint).
2024-03-27 16:05:35 +00:00
Harry Maclean
f6e2e1319b
Ruby: Link to MaD docs from Ruby doc page
...
Also remove an internal link from the docs.
2024-03-27 15:30:05 +00:00
Harry Maclean
e6ba0a34f4
Revert "Ruby: remove customizing-library-models-for-ruby.rst"
...
This reverts commit 5b46256fdb .
2024-03-27 15:24:30 +00:00
Michael B. Gale
45b41bb506
Go: Mirror stdout/stderr output in InstallVersion
2024-03-27 15:18:24 +00:00
Michael B. Gale
6b1d1d427c
Go: Add integration test for incorrect version format logic
2024-03-27 15:16:32 +00:00
Michael B. Gale
6ea99825be
Go: Add unit test to sanity check HasGoVersion
2024-03-27 15:15:40 +00:00
Michael B. Gale
ab255d70b5
Go: Fix semver-related logic bugs
2024-03-27 15:15:20 +00:00
Ian Lynagh
fda3c92612
Java: Add a changenote for the MissingEnumInSwitch change
2024-03-27 15:12:55 +00:00
Ian Lynagh
59ae6dd5f5
Java: Add a couple of Oxford commas
2024-03-27 15:07:58 +00:00
Michael B. Gale
86bf4fbbc0
Go: Make diagnostic names static
2024-03-27 14:22:58 +00:00
Jami Cogswell
40c932a5f9
Java: move UrlForward.qll code to UrlForwardQuery.qll
2024-03-27 10:12:28 -04:00
Max Schaefer
5b07e14fb3
Merge pull request #16055 from github/max-schaefer/go-open-redirect-qhelp
...
Go: Improve QHelp for `go/unvalidated-url-redirection`.
2024-03-27 13:56:48 +00:00
Paolo Tranquilli
0243d9f2b9
Swift: accept explicit any in existential type name
2024-03-27 13:49:15 +01:00
Jami Cogswell
2391fe7d89
Java: use InlineFlowTest instead of InlineExpectationsTest
2024-03-27 08:44:17 -04:00
Paolo Tranquilli
d9c40488bb
Swift: add ThenStmt to control flow
2024-03-27 13:37:24 +01:00
Paolo Tranquilli
b8e38288e3
Swift: add extraction of ThenStmt
...
These are currently added implicitly by the compiler in the context of
`if`/`switch` expressions. In the future, there might be explicit
`then <expr>` statement useful for cases where one would like to add
more than one statement in the branch, to mark what value to actually
use.
See https://forums.swift.org/t/pitch-multi-statement-if-switch-do-expressions/68443
2024-03-27 13:26:04 +01:00
Max Schaefer
32ebd4eebb
Automodel: Filter unexploitable types in application mode.
...
We already did this in framework mode.
2024-03-27 12:22:24 +00:00
Arthur Baars
ba89f1b6b1
Merge pull request #15896 from github/aibaars/java-update-output
...
Java: update expected output
2024-03-27 13:19:52 +01:00
Jami Cogswell
121b24ea7c
Java: remove parentheses
2024-03-27 08:16:06 -04:00
Owen Mansel-Chan
311512c768
Remove df-gen models for incidentally modelled APIs
...
Manual models always take precedence over generated models, so there is
no point in keeping the generated models.
These APIs happened to have been modelled between model generation and
merging this PR.
2024-03-27 12:15:08 +00:00
Owen Mansel-Chan
f03a56f7e0
Run generation script
...
The command line was:
python3 /Users/owen-mc/workspace/codeql-home/codeql/java/ql/src/utils/modelgenerator/GenerateFlowModel.py /Users/owen-mc/db/java/openjdk17 --with-summaries --with-neutrals
2024-03-27 12:15:00 +00:00
Jami Cogswell
35fbc95cc7
Java: remove redundant line
2024-03-27 08:09:40 -04:00
Mathias Vorreiter Pedersen
7bb2b57394
Merge pull request #15964 from rdmarsh2/rdmarsh2/cpp/temp-destructors-extended
...
C++: IR translation for destruction of temporaries with extended lifetimes
2024-03-27 11:58:48 +00:00
Calum Grant
03bf804a68
Add C++ analysis in separate workflow
2024-03-27 11:44:58 +00:00
Mathias Vorreiter Pedersen
8711232a38
Merge pull request #16069 from jketema/var-templ
...
C++: Add `VariableTemplateInstantiation` class
2024-03-27 11:31:35 +00:00
Paolo Tranquilli
2382f76317
Swift: ignore experimental ThenStmt
2024-03-27 12:23:37 +01:00
Paolo Tranquilli
f9d10cec08
Swift: fix DeclTranslator.cpp compile errors
2024-03-27 12:21:28 +01:00
Ian Lynagh
6cd94cf253
Merge pull request #16059 from igfoo/igfoo/exprs
...
Kotlin 2: Accept more location changes
2024-03-27 11:17:07 +00:00
Jeroen Ketema
050682c477
C++: Update expected test results
2024-03-27 12:03:37 +01:00
Paolo Tranquilli
8e9b4336da
Merge branch 'main' into alexdenisov/swift-5.10
2024-03-27 11:35:14 +01:00
Jeroen Ketema
27c6e2421c
C++: Add VariableTemplateInstantiation class
...
This adds some uniformity, as we already had `FunctionTemplateInstantiation` and
`ClassTemplateInstantiation` classes.
2024-03-27 11:35:13 +01:00
Tony Torralba
b617667b0e
Merge pull request #16062 from atorralba/atorralba/java/more-neutrals
...
Java: Add more neutrals and improve `java.net.URL` models
2024-03-27 10:41:38 +01:00
Geoffrey White
30c9ec1926
C++: Adjust following discussion.
2024-03-27 09:23:48 +00:00
Tony Torralba
7a0446740b
Update java/ql/lib/ext/java.net.model.yml
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2024-03-27 09:09:48 +01:00
Henry Mercer
568442d5f8
QL: Run diagnostics and summary metrics in code scanning
...
Add diagnostics and summary metric queries to the code scanning suite.
2024-03-26 18:11:50 +00:00
Arthur Baars
497325455a
Java: update expected output
2024-03-26 18:40:22 +01:00
Geoffrey White
b4a6f75ad7
C++: Divide CODEOWNERS responsibilities.
2024-03-26 17:35:07 +00:00
Mathias Vorreiter Pedersen
3e9602854a
Merge pull request #16063 from MathiasVP/taint-inheriting-content-for-cpp
...
C++: Add `TaintInheritingContent`
2024-03-26 17:28:52 +00:00
Mathias Vorreiter Pedersen
3bfaab9182
C++: Remove debugging conjunct.
2024-03-26 17:01:06 +00:00
Mathias Vorreiter Pedersen
6a8c592900
Update cpp/ql/lib/semmle/code/cpp/ir/dataflow/FlowSteps.qll
...
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com >
2024-03-26 16:59:18 +00:00
Mathias Vorreiter Pedersen
d610d721a4
C++: Add file QLDoc.
2024-03-26 16:47:39 +00:00
Mathias Vorreiter Pedersen
e3744c435a
C++: Add change note.
2024-03-26 16:44:16 +00:00
Mathias Vorreiter Pedersen
ec3d041c8d
C++: Accept test changes.
2024-03-26 16:40:18 +00:00
Mathias Vorreiter Pedersen
bd2ecd3346
C++: Add test.
2024-03-26 16:38:28 +00:00
Mathias Vorreiter Pedersen
2075716df7
C++: Add 'TaintInheritingContent'.
2024-03-26 16:37:22 +00:00
Tony Torralba
d786ea90a4
Java: Add more neutrals
...
Adds more neutral models to help the model generator ignore certain callables.
Also improves the precision of certain URL models by using synthetic fields so that the parts of a URL are tainted separately.
2024-03-26 17:31:11 +01:00
Rasmus Wriedt Larsen
df463e51c1
JS: Extractor: Fix experimental flag value for NodeJSDetectorTests
2024-03-26 17:02:47 +01:00
Rasmus Wriedt Larsen
60944a9bcb
JS: Accept new trap files
...
As I see it, these all seem to have invalid code initially anyway, but
this is definitely something a JS expert should review :)
2024-03-26 17:01:57 +01:00
Rasmus Wriedt Larsen
1d51d182ec
JS: Extractor: Explain how to make replaceExpectedOutput work now with bazel
2024-03-26 17:01:57 +01:00
Rasmus Wriedt Larsen
04a0740ccb
JS: Extractor: More robust ES2015 checking
...
Created shared AbstractDetector to not duplicate all the tedious logic
;)
I took inspiration from the tests in `javascript/extractor/tests/esnext/input/dynamic-import.js`
2024-03-26 17:01:57 +01:00
Rasmus Wriedt Larsen
cd84500c56
JS: Extractor: Separate base detector logic into own file
...
Should hopefully make it easier to review these changes to have it split into its' own commit :)
2024-03-26 17:01:57 +01:00
Henry Mercer
2de62dfcdd
Merge pull request #16058 from github/henrymercer/merge-back-rc-3.13
...
Merge `rc/3.13` back to `main`
2024-03-26 14:57:31 +00:00
Ian Lynagh
c5604c97bd
Kotlin 2: Accept more location changes
2024-03-26 14:10:28 +00:00
Henry Mercer
0646744928
Merge branch 'main' into henrymercer/merge-back-rc-3.13
2024-03-26 12:59:12 +00:00
Michael B. Gale
cf9e2dcea1
Merge pull request #16056 from github/mbg/go/changenote-for-dependency-improvement
...
Go: Add changenote for `CODEQL_EXTRACTOR_GO_FAST_PACKAGE_INFO` change
2024-03-26 12:50:19 +00:00
Henry Mercer
f89109df7c
Merge pull request #16048 from github/post-release-prep/codeql-cli-2.16.6
...
Post-release preparation for codeql-cli-2.16.6
2024-03-26 12:23:11 +00:00
Geoffrey White
8fbbc2b6d8
C++: Improve QLDoc.
2024-03-26 11:21:25 +00:00
Max Schaefer
d7258f76d3
Go: Improve QHelp for go/unvalidated-url-redirection.
...
The example showed a different (and better) fix from what the help claimed, but the suggestion also had a subtle bug that I fixed at the same time.
2024-03-26 10:57:36 +00:00
Michael B. Gale
f84609dbc4
Go: Add changenote for CODEQL_EXTRACTOR_GO_FAST_PACKAGE_INFO change
2024-03-26 10:51:57 +00:00
Tamás Vajk
0c5ea975a4
Merge pull request #16021 from tamasvajk/feature/add-buildless-telemetry
...
C#: Add high level diagnostic messages for buildless extraction (star…
2024-03-26 11:03:20 +01:00
Asger F
22b56a4a40
JS: More implied receiver steps
2024-03-26 10:23:08 +01:00
Asger F
f2939bd05b
JS: Add test case
2024-03-26 10:23:08 +01:00
Asger F
f8641dd82d
JS: Fix use of deprecated alias
2024-03-26 09:39:39 +01:00
Asger F
a0b49b23f5
JS: Add UseServer and UseClient directives
2024-03-26 09:39:39 +01:00
Asger F
1d22e65851
JS: Move Directive subclasses into Directive module
2024-03-26 09:39:37 +01:00
Dave Bartolomeo
a950de36a0
Merge pull request #16050 from github/dbartol/more-test-fixes
...
Remove unused data extension in test
2024-03-25 20:50:09 -04:00
Dave Bartolomeo
c11b8f9d51
Remove unused data extension in test
2024-03-25 19:14:54 -04:00
Max Schaefer
ff23f572d0
Merge pull request #16038 from github/max-schaefer/string-break-qhelp
...
Go: Improve QHelp for `go/unsafe-quoting`.
2024-03-25 20:10:02 +00:00
Max Schaefer
5bc710b406
Apply suggestions from code review
...
Co-authored-by: Felicity Chapman <felicitymay@github.com >
2024-03-25 19:48:56 +00:00
Dave Bartolomeo
98bf5269a0
Merge pull request #16040 from github/dbartol/qltest-model
...
Use correct model pack name in qltest data extension
2024-03-25 15:29:16 -04:00
Chris Smowton
f5ebd3d501
Merge pull request #16047 from github/smowton/admin/update-java-supported-version
...
Update Java version supported to 22
2024-03-25 18:42:35 +00:00
Geoffrey White
ce52cbb428
C++: Disambiguate *n1..n2 doc.
2024-03-25 18:22:28 +00:00
github-actions[bot]
f67b5f9158
Post-release preparation for codeql-cli-2.16.6
2024-03-25 18:17:15 +00:00
Geoffrey White
76780d74d9
C++: Unify four implementations of repeatStars. Note that the recursive approach is faster for very large strings (well over 100 stars), while the concat approach appears to be faster for short strings and does not require an upper bound.
2024-03-25 18:10:21 +00:00
Geoffrey White
95db7aa776
C++: Clean up argument / parameter position logic.
2024-03-25 18:10:21 +00:00
Chris Smowton
757b9bb5fa
Update Java version supported to 22
2024-03-25 18:01:30 +00:00
Chris Smowton
6fc99e3ad6
Merge pull request #16023 from smowton/smowton/feature/jdk22-support
...
Java: support Java 22 language features
2024-03-25 17:58:50 +00:00
Geoffrey White
58737b1d7e
C++: We *could* support .Argument with no index, but I'm not convinced we can do so efficiently, so lets not.
2024-03-25 17:08:15 +00:00
Geoffrey White
0a33a6e79b
C++: Another test case - Arguments with no specified index.
2024-03-25 17:00:46 +00:00
Henry Mercer
3d82318839
Merge pull request #16045 from github/release-prep/2.16.6
...
Release preparation for version 2.16.6
2024-03-25 16:59:13 +00:00
github-actions[bot]
71ab804274
Release preparation for version 2.16.6
2024-03-25 16:58:08 +00:00
Geoffrey White
cf35fd4dee
C++: Improve ExternalFlow.qll doc.
2024-03-25 16:52:09 +00:00
Geoffrey White
cdafb26423
C++: Fix test failures.
2024-03-25 16:51:36 +00:00
Chris Smowton
dcebcc35b6
Rename getPatternAtIndex
2024-03-25 16:36:38 +00:00
Chris Smowton
568bddc4a9
Add test cases for cases falling directly out of switch blocks
2024-03-25 16:31:40 +00:00
Chris Smowton
17193ac11b
Distinguish record patterns that do or don't declare identifiers
2024-03-25 16:31:40 +00:00
Chris Smowton
a4401963f5
Use getAPattern
2024-03-25 16:31:39 +00:00
Chris Smowton
f347784ec2
autoformat
2024-03-25 16:31:39 +00:00
Chris Smowton
3d9bc6fc89
Note pattern-cases may be missing some type-accesses
2024-03-25 16:31:39 +00:00
Chris Smowton
5e0961b348
Account for new possible child index gap
2024-03-25 16:31:39 +00:00
Chris Smowton
9fa2f19990
Add test for guards in the presence of fall-through between pattern and constant cases
2024-03-25 16:31:39 +00:00
Chris Smowton
c48e64e536
Add tests for the combination of anonymous labels and a guard
2024-03-25 16:31:39 +00:00
Chris Smowton
1e0766dffa
Add tests for case statement type test dominance against anonymous labels and fall-through
2024-03-25 16:31:39 +00:00
Chris Smowton
f2ff6c476a
Add printast tests for anonymous variables
2024-03-25 16:31:38 +00:00
Chris Smowton
5cb5ee026c
Fix pretty-printing of anonymous vars and multiple patterns; add test
2024-03-25 16:31:38 +00:00
Chris Smowton
f317f782ae
Add test for control-flow with mixed patterns, constants and fall-through
2024-03-25 16:31:38 +00:00
Chris Smowton
6cf956d07a
Add CFG test for anonymous variables and fall-throughs with pattern cases
2024-03-25 16:31:38 +00:00
Chris Smowton
cc8dcf63b0
Convert test to use an anonymous local
2024-03-25 16:31:38 +00:00
Chris Smowton
ee36e3b72b
autoformat
2024-03-25 16:31:38 +00:00
Chris Smowton
403e86878c
Don't mistake a rule case for a fall-through edge
2024-03-25 16:31:37 +00:00
Chris Smowton
5243a62a41
Accept test changes
2024-03-25 16:31:37 +00:00
Chris Smowton
c0874ab04b
Fix pattern-case variable pretty-printer
2024-03-25 16:31:37 +00:00
Chris Smowton
f66811048d
Fix next-normal-statement predicate
2024-03-25 16:31:37 +00:00
Chris Smowton
bc0724e2b3
Add change note
2024-03-25 16:31:37 +00:00
Chris Smowton
d5443b3f10
Remove dead code
2024-03-25 16:31:37 +00:00
Chris Smowton
29e93edf90
Dataflow: restrict pattern-case flow to unique patterns.
2024-03-25 16:31:37 +00:00
Chris Smowton
00c7dd5f92
Fix a stray use of getPattern
2024-03-25 16:31:36 +00:00
Chris Smowton
e59487a324
Don't regard cases with multiple patterns as conducting a type test
2024-03-25 16:31:36 +00:00
Chris Smowton
c7cb885e71
Add missing javadoc and getUniquePattern predicate
2024-03-25 16:31:36 +00:00
Chris Smowton
f44becea7f
Implement multiple pattern case and fall-through pattern case support
2024-03-25 16:31:36 +00:00
Chris Smowton
c283894b4b
Fix typo
2024-03-25 16:31:36 +00:00
Chris Smowton
33b807f3bb
Parameters and local variables: add isAnonymous predicate
2024-03-25 16:31:36 +00:00
Joe Farebrother
fb19288981
Address review comments - Fix docs typo and add a reference
2024-03-25 15:46:45 +00:00
Geoffrey White
b2a301c206
Swift: Remove claims about 'Annotated'.
2024-03-25 15:45:37 +00:00
Geoffrey White
4a4c77e81d
Remove claims about models-as-data that require you to select a parameter from non-Java languages. We believe this is only possible in Java.
2024-03-25 15:41:00 +00:00
Edward Minnix III
7377cbb46e
Merge pull request #15930 from egregius313/egregius313/csharp/mad/database/dapper-sources
...
C#: Sources for the `Dapper` database library
2024-03-25 11:21:51 -04:00
Rasmus Wriedt Larsen
d516db6abc
Merge pull request #15903 from yoff/python/test-MaD-keyword-argument
...
Python: test MaD syntax for keyword argument
2024-03-25 15:51:49 +01:00
Dave Bartolomeo
d805bbcd27
Use correct model pack name in qltest data extension
2024-03-25 10:31:11 -04:00
Tamas Vajk
78912d5eea
C#: Reword public mentions of C# buildless
2024-03-25 14:33:51 +01:00
Max Schaefer
120fb93c23
Go: Improve QHelp for go/unsafe-quoting.
2024-03-25 13:32:51 +00:00
Paolo Tranquilli
dea922958b
Merge pull request #16034 from github/redsun82/swift-move-integration-tests-to-internal
...
Swift: prepare integration tests for internal running
2024-03-25 14:08:47 +01:00
Paolo Tranquilli
9c9f4b956e
Swift: fix db in diagnostics_test_utils.py
2024-03-25 13:53:27 +01:00
Tamas Vajk
2f0b54c801
Refactor buildless telemetry logging
2024-03-25 12:48:27 +01:00
Geoffrey White
88ea9197d9
C++: Add more tests for uncommon cases.
2024-03-25 11:40:15 +00:00
Ian Lynagh
55226c48a6
Merge pull request #16022 from igfoo/igfoo/k2_exprs
...
Kotlin 2: Accept more location changes
2024-03-25 11:38:15 +00:00
Tamas Vajk
b94d33d78d
Add buildless failed diagnostic
2024-03-25 12:27:36 +01:00
Paolo Tranquilli
7f53509022
Merge branch 'main' into redsun82/swift-move-integration-tests-to-internal
2024-03-25 12:22:00 +01:00
Geoffrey White
46b8e3be66
C++: Fix another mistake in the test.
2024-03-25 11:20:55 +00:00
Geoffrey White
dec5fc0f48
C++: Switch MAD syntax from *Argument[0] style to Argument[*0] style.
2024-03-25 11:20:55 +00:00
Geoffrey White
40270e1f70
C++: Fix mistake in test model.
2024-03-25 11:20:55 +00:00
Geoffrey White
b598b4ac45
C++: Fix for field content indirection (1-based).
2024-03-25 11:20:55 +00:00
Geoffrey White
73e95d67b9
C++: Implement Field indirection.
2024-03-25 11:20:55 +00:00
Geoffrey White
393bd7277c
C++: Add some negative test cases for indirection.
2024-03-25 11:20:55 +00:00
Geoffrey White
af4320df50
C++: Modify a summary test case to only test the summary model, not a source model as well.
2024-03-25 11:20:55 +00:00
Geoffrey White
14deb06e80
C++: Implement Argument + Parameter indirection.
2024-03-25 11:20:55 +00:00
Paolo Tranquilli
6707fc3a7c
Swift: remove wrong flag in runner.py
2024-03-25 12:20:13 +01:00
Geoffrey White
638bfff09d
C++: Implement ReturnValue indirection (this version only worked with a small change to the shared library parsing to permit '*' in the token name; we no longer need this, so I rebased it out).
2024-03-25 11:20:09 +00:00
Paolo Tranquilli
148033e020
Swift: fix assertion diagnostics test
2024-03-25 12:05:22 +01:00
Tamas Vajk
5ab5244171
Change public messages to not include 'buildless'
2024-03-25 11:59:29 +01:00
Chris Smowton
10afb1cd93
Merge pull request #16030 from smowton/smowton/admin/buildless-wording-update
...
Java: Update buildless test expectations
2024-03-25 10:57:56 +00:00
Paolo Tranquilli
ca5d85c57e
Merge branch 'main' into redsun82/swift-move-integration-tests-to-internal
2024-03-25 11:56:48 +01:00
Paolo Tranquilli
0fa40af131
Swift: fix last references to old integration test location
2024-03-25 11:49:19 +01:00
Rasmus Wriedt Larsen
0515b12305
JS: Add example of bad NodeJS detection
...
Notice the TRAP lines
```
is_module(#20001 )
is_es2015_module(#20001 )
```
2024-03-25 11:36:21 +01:00
Max Schaefer
ffbe3e6ed4
Merge pull request #16020 from github/max-schaefer/go-path-injection-qhelp
...
Go: Update query help for `go/path-injection` to include example fixes.
2024-03-25 10:25:36 +00:00
Owen Mansel-Chan
f2db9ce312
Merge pull request #16028 from owen-mc/java/sensitive-log-whitelist-tokenimage
...
Java: whitelist variable name `tokenImage` for `java/sensitive-log` as it's used in code generated by JavaCC
2024-03-25 10:02:19 +00:00
Paolo Tranquilli
5a771ad2cf
Swift: bump python version
2024-03-25 10:42:16 +01:00
Tamás Vajk
d6374f65e4
Merge pull request #15957 from tamasvajk/feature/limit-message-extraction
...
C#: Limit extracted compilation and extraction messages
2024-03-25 10:30:10 +01:00
Paolo Tranquilli
762b4ce42e
Swift: prepare integration tests for internal running
...
This harmonizes Swift integration tests with the rest of the repository,
to prepare for the internal integration test runner to run them. The
stripped down runner is kept compatible, so that current CI can still
use it now. Maybe it will be kept for developer use.
This PR includes:
* moving the integration tests inside `ql`
* editing `qlpack.yml` so that the internal runner can use it
* change database directory to be `test-db` rather than `db`
2024-03-25 10:17:55 +01:00
dependabot[bot]
0c73340e47
Bump regex from 1.10.3 to 1.10.4 in /ql
...
Bumps [regex](https://github.com/rust-lang/regex ) from 1.10.3 to 1.10.4.
- [Release notes](https://github.com/rust-lang/regex/releases )
- [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/regex/compare/1.10.3...1.10.4 )
---
updated-dependencies:
- dependency-name: regex
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-25 03:31:03 +00:00
Owen Mansel-Chan
ac6c4add14
Apply suggestions from code review
...
Co-authored-by: Chris Smowton <smowton@github.com >
2024-03-24 20:20:37 +00:00
Chris Smowton
d8686e02a8
Update test expectations
2024-03-24 17:57:27 +00:00
Owen Mansel-Chan
821f399193
Add change note
2024-03-23 23:51:52 +00:00
Owen Mansel-Chan
f4b3bae88b
Add test for ParseException use of tokenImage
2024-03-23 23:48:16 +00:00
Owen Mansel-Chan
4832dc51ed
Whitelist variable name tokenImage
2024-03-23 21:33:02 +00:00
Owen Mansel-Chan
63a04c056a
Add test with tokenImage as used in JavaCC
2024-03-23 21:30:33 +00:00
erik-krogh
051120e958
add qldoc for ReflectedXssSanitizers
2024-03-22 17:58:25 +01:00
erik-krogh
c60cec36d4
add calls to .html_safe? as a shared XSS sanitizer
2024-03-22 17:46:39 +01:00
Aditya Sharad
1a8932bc28
Merge pull request #16024 from github/changedocs/2.16.5
...
Update CodeQL CLI to version 2.16.5
2024-03-22 09:32:52 -07:00
Erik Krogh Kristensen
45ce988943
Merge pull request #16002 from erik-krogh/tarBlank
...
JS: change the precision of the `js/unsafe-external-link` query to `low`
2024-03-22 17:12:58 +01:00
Florin Coada
c653f1ce8c
Add CodeQL 2.16.5 changelog
2024-03-22 15:28:54 +00:00
Joe Farebrother
592acb94d2
Add missing .s to qldoc
2024-03-22 15:28:34 +00:00
Max Schaefer
034ed17227
Apply suggestions from code review
...
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com >
2024-03-22 15:24:29 +00:00
Jeroen Ketema
d9b0a5918c
Merge pull request #16018 from jketema/tls-precision
...
C++: Add precision to `cpp/boost/tls-settings-misconfiguration` and `cpp/boost/use-of-deprecated-hardcoded-security-protocol`
2024-03-22 16:17:34 +01:00
Jeroen Ketema
453cdfa513
C++: Add change note
2024-03-22 15:52:52 +01:00
Joe Farebrother
a6ee19ca2d
Fix query id
2024-03-22 14:36:47 +00:00
Ian Lynagh
63e34c4dec
Kotlin 2: Accept more location changes
2024-03-22 14:09:20 +00:00
Joe Farebrother
01f712476b
Add change note and update severity
2024-03-22 14:07:11 +00:00
Joe Farebrother
b74145349b
Add test cases
2024-03-22 14:07:11 +00:00
Joe Farebrother
507a6102a2
Reorganise into Custimizations file + add some more sinks on ActiveRecord methods
2024-03-22 14:07:04 +00:00
Joe Farebrother
a8aac318d0
Add qhelp
2024-03-22 14:04:52 +00:00
Joe Farebrother
89838981b7
Add test cases
2024-03-22 14:04:52 +00:00
Joe Farebrother
0f45a53adc
Add mass assignment query
2024-03-22 14:04:52 +00:00
Edward Minnix III
1785086ccb
Merge pull request #15784 from egregius313/egregius313/csharp/dataflow/sources/file
...
C#: Add source models for `file` threat model/source kind for .NET standard library
2024-03-22 09:50:30 -04:00
Michael Nebel
a07ee8e961
C#: Update the AsList model to a value flow model.
2024-03-22 14:40:25 +01:00
Tamas Vajk
178a45af25
C#: Add high level diagnostic messages for buildless extraction (start, success)
2024-03-22 14:27:36 +01:00
Max Schaefer
bc9396e0e6
Address suggestions from review.
2024-03-22 13:19:36 +00:00
Michael B. Gale
f48e295f4a
Merge pull request #16019 from p-/p--weak-enc-ecb-qhelp
...
C#: add hint regarding ECB to weak encryption QHelp
2024-03-22 13:09:08 +00:00
Michael Nebel
ca72b0583d
C#: Update source and sink expected test output.
2024-03-22 13:59:47 +01:00
Erik Krogh Kristensen
7d968184fd
improve the change-note
...
Co-authored-by: Asger F <asgerf@github.com >
2024-03-22 13:58:34 +01:00
Ed Minnix
4b13ad1310
Fix flow summary tests
2024-03-22 13:46:20 +01:00
Ed Minnix
9ed8ca27a1
Fix test and model
2024-03-22 13:46:19 +01:00
Ed Minnix
1f04229def
Fix typo
2024-03-22 13:46:19 +01:00
Ed Minnix
73b4e8fe6a
Add WithElement identifier to AsList method
2024-03-22 13:46:19 +01:00
Ed Minnix
9b23bfa038
Execute methods which return objects
...
The `Execute` method returns `int` for "number of rows affected". But
some of the other `Execute*` methods return objects.
2024-03-22 13:46:19 +01:00
Ed Minnix
5885938eaf
Use wildcard signatures for Query methods
2024-03-22 13:46:19 +01:00
Ed Minnix
8223781978
Fix FlowSummaries tests
2024-03-22 13:46:19 +01:00
Ed Minnix
5ca6b40c34
Change note
2024-03-22 13:46:18 +01:00
Ed Minnix
23aeb1d878
Add tests
2024-03-22 13:46:18 +01:00
Ed Minnix
98285b5171
Add AsList summary
2024-03-22 13:46:18 +01:00
Ed Minnix
87ad170067
Dapper source models
2024-03-22 13:46:18 +01:00
Ian Lynagh
01475fd8ba
Merge pull request #16011 from igfoo/igfoo/legacy_vars
...
Java/Kotlin: Remove references to legacy ODASA_SNAPSHOT env var
2024-03-22 12:38:37 +00:00
Max Schaefer
4e4cd52f63
Go: Update query help for go/path-injection to include example fixes.
2024-03-22 11:45:59 +00:00
Peter Stöckli
d62d68a40b
C#: add hint regarding ECB to weak encryption QHelp
2024-03-22 12:08:30 +01:00
Rasmus Wriedt Larsen
69f6e1e263
Merge pull request #16010 from RasmusWL/perf
...
Python: Two small join-order fixes
2024-03-22 11:36:17 +01:00
Jeroen Ketema
adfb3c3d50
C++: Simplify cpp/boost/tls-settings-misconfiguration
2024-03-22 11:22:11 +01:00
yoff
c520cb6d58
Merge branch 'main' into python/test-MaD-keyword-argument
2024-03-22 10:56:08 +01:00
Rasmus Lerchedahl Petersen
eef60c9ad2
python: add test for "ReturnValue.TupleElement[0,1]"
...
also synchronise files
2024-03-22 10:54:12 +01:00
Jeroen Ketema
fb4ed39d89
Merge pull request #16017 from jketema/destructors21
...
C++: Add destructor test cases for AV Rule 114
2024-03-22 10:50:27 +01:00
Jeroen Ketema
a770bddff0
C++: Add precision to cpp/boost/tls-settings-misconfiguration and cpp/boost/use-of-deprecated-hardcoded-security-protocol
...
Also clean up the names of the queries while here.
2024-03-22 10:48:18 +01:00
Jeroen Ketema
3f0ce98ccb
C++: Add destructor test cases for AV Rule 114
2024-03-22 10:25:47 +01:00
Tom Hvitved
9d124197e8
C#: Remove support for legacy LGTM options in autobuilder
2024-03-22 10:09:24 +01:00
Tamas Vajk
205d6a3bc5
Extract total number of diagnostic per ID and compilation
2024-03-22 08:55:41 +01:00
Tamas Vajk
fa7f437e71
Code quality improvement
2024-03-22 08:16:11 +01:00
Jeroen Ketema
eca6c00003
Merge pull request #16014 from jketema/destructors20
...
C++: Handle destructors of range-based for-loop, if, and switch initializer statements
2024-03-21 21:04:23 +01:00
Ed Minnix
c7a746e3dc
Flow summary tests
2024-03-21 13:15:45 -04:00
Ed Minnix
3e3eceea5f
Typo
2024-03-21 13:06:34 -04:00
Ed Minnix
e2c2d574f8
Add FileInfo::OpenText
2024-03-21 13:06:33 -04:00
Ed Minnix
46a9bb9804
Change note
2024-03-21 13:06:31 -04:00
Ed Minnix
08611f0c9c
Fix flow summary tests
2024-03-21 13:06:30 -04:00
Ed Minnix
e14e47cd73
Fix Stream::Read(Span<byte>) model
2024-03-21 13:06:28 -04:00
Ed Minnix
d6f085373e
System.IO.Stream::ReadExactly models
2024-03-21 13:06:27 -04:00
Ed Minnix
2a73677fd2
Missing Stream::ReadAsync overload
2024-03-21 13:06:26 -04:00
Ed Minnix
a698684fec
System.IO.Stream::ReadAtLeast
2024-03-21 13:06:24 -04:00
Ed Minnix
3e29a8d2a1
System.IO files test
2024-03-21 13:06:23 -04:00
Ed Minnix
d387e6d068
Fix flow-summary tests
2024-03-21 13:06:21 -04:00
Ed Minnix
9232fafde1
Add System.IO.Stream::Read(Span<Byte>) model
2024-03-21 13:06:20 -04:00
Ed Minnix
a8c5e4e0f2
FileInfo source models
2024-03-21 13:06:18 -04:00
Ed Minnix
bb9b0eabf2
Add BufferedStream summary models
2024-03-21 13:06:17 -04:00
Ed Minnix
a5b801b31f
Add File reading methods
2024-03-21 13:06:15 -04:00
Arthur Baars
c219b1a3c7
Merge pull request #16013 from github/rc/3.13
...
Merge rc/3.13 into main
2024-03-21 16:04:58 +01:00
Rasmus Wriedt Larsen
93f940aa9c
Python: Join-order improvement for DataFlowDispatch::TrackAttrReadInput
...
I was surprised to see that this predicate actually gets evaluated 3 times
- Pipeline standard for DataFlowDispatch::TrackAttrReadInput::start/2#67f26627@c15596yu was evaluated in 74 iterations totaling 165ms (delta sizes total: 113119).
- Pipeline standard for DataFlowDispatch::TrackAttrReadInput::start/2#67f26627@3459ejws was evaluated in 30 iterations totaling 76ms (delta sizes total: 32555).
- Pipeline standard for DataFlowDispatch::TrackAttrReadInput::start/2#67f26627@5ac22jwq was evaluated in 30 iterations totaling 108ms (delta sizes total: 32555).
It does however fit with it being used in exactly 3 places: https://github.com/search?q=repo%3Agithub%2Fcodeql+%2FattrReadTracker%5C%28%2F&type=code -- so I assume it's because each use forces a new evaluation. Although that's something we could look into solving, for now I'm just trying to fix the join-order.
Initial
```
Pipeline standard for DataFlowDispatch::TrackAttrReadInput::start/2#67f26627@3459ejws was evaluated in 30 iterations totaling 76ms (delta sizes total: 32555).
7068090 ~0% {2} r1 = SCAN Attributes::AttrRead#class#f6c3f431 OUTPUT In.0, In.0
{2} | AND NOT `DataFlowDispatch::TrackAttrReadInput::start/2#67f26627#prev`(FIRST 2)
3901178 ~5% {2} | SCAN OUTPUT In.1, In.1
3901178 ~0% {3} | JOIN WITH `Attributes::AttrRef.getObject/0#dispred#d7cd0a97` ON FIRST 1 OUTPUT Rhs.1, Lhs.0, Lhs.1
13615 ~1% {2} r2 = JOIN r1 WITH `DataFlowDispatch::classTracker/1#d11f2237#reorder_1_0#prev_delta` ON FIRST 1 OUTPUT Lhs.1, Lhs.2
94 ~2% {2} r3 = JOIN r1 WITH `DataFlowDispatch::superCallTwoArgumentTracker/2#d18be99f#reorder_2_0_1#prev_delta` ON FIRST 1 OUTPUT Lhs.1, Lhs.2
18846 ~1% {2} r4 = JOIN r1 WITH `DataFlowDispatch::classInstanceTracker/1#d73ecef4#prev_delta_1#join_rhs` ON FIRST 1 OUTPUT Lhs.1, Lhs.2
32555 ~1% {2} r5 = r2 UNION r3 UNION r4
return r5
```
==>
```
Pipeline standard for DataFlowDispatch::TrackAttrReadInput::start/2#67f26627@f2517jwq was evaluated in 30 iterations totaling 12ms (delta sizes total: 32704).
186719 ~121% {1} r1 = SCAN `DataFlowDispatch::classInstanceTracker/1#d73ecef4#prev_delta` OUTPUT In.1
164342 ~158% {1} r2 = SCAN `DataFlowDispatch::classTracker/1#d11f2237#reorder_1_0#prev_delta` OUTPUT In.0
96 ~0% {1} r3 = SCAN `DataFlowDispatch::superCallTwoArgumentTracker/2#d18be99f#reorder_2_0_1#prev_delta` OUTPUT In.0
351157 ~80% {1} r4 = r1 UNION r2 UNION r3
88074 ~14% {1} | JOIN WITH `Attributes::AttrRef.getObject/0#dispred#d7cd0a97_10#join_rhs` ON FIRST 1 OUTPUT Rhs.1
41789 ~18% {2} | JOIN WITH Attributes::AttrRead#class#f6c3f431 ON FIRST 1 OUTPUT Lhs.0, Lhs.0
{2} | AND NOT `DataFlowDispatch::TrackAttrReadInput::start/2#67f26627#prev`(FIRST 2)
32883 ~2% {2} | SCAN OUTPUT In.1, In.1
return r4
```
AND
initial
```
Pipeline standard for DataFlowDispatch::TrackAttrReadInput::start/2#67f26627@c15596yu was evaluated in 74 iterations totaling 165ms (delta sizes total: 113119).
17434622 ~0% {2} r1 = SCAN Attributes::AttrRead#class#f6c3f431 OUTPUT In.0, In.0
{2} | AND NOT `DataFlowDispatch::TrackAttrReadInput::start/2#67f26627#prev`(FIRST 2)
9483976 ~4% {2} | SCAN OUTPUT In.1, In.1
9483976 ~0% {3} | JOIN WITH `Attributes::AttrRef.getObject/0#dispred#d7cd0a97` ON FIRST 1 OUTPUT Rhs.1, Lhs.0, Lhs.1
19258 ~1% {2} r2 = JOIN r1 WITH `DataFlowDispatch::classInstanceTracker/1#d73ecef4#reorder_1_0#prev_delta` ON FIRST 1 OUTPUT Lhs.1, Lhs.2
1654 ~1% {2} r3 = JOIN r1 WITH `DataFlowDispatch::superCallNoArgumentTracker/1#0a2e8a06#reorder_1_0#prev_delta` ON FIRST 1 OUTPUT Lhs.1, Lhs.2
1314 ~4% {2} r4 = JOIN r1 WITH `DataFlowDispatch::clsArgumentTracker/1#47339327#reorder_1_0#prev_delta` ON FIRST 1 OUTPUT Lhs.1, Lhs.2
94 ~2% {2} r5 = JOIN r1 WITH `DataFlowDispatch::superCallTwoArgumentTracker/2#d18be99f#reorder_2_0_1#prev_delta` ON FIRST 1 OUTPUT Lhs.1, Lhs.2
77217 ~0% {2} r6 = JOIN r1 WITH `DataFlowDispatch::selfTracker/1#f157aa27#reorder_1_0#prev_delta` ON FIRST 1 OUTPUT Lhs.1, Lhs.2
13632 ~1% {2} r7 = JOIN r1 WITH `DataFlowDispatch::classTracker/1#d11f2237#reorder_1_0#prev_delta` ON FIRST 1 OUTPUT Lhs.1, Lhs.2
113169 ~0% {2} r8 = r2 UNION r3 UNION r4 UNION r5 UNION r6 UNION r7
return r8
```
==>
```
Pipeline standard for DataFlowDispatch::TrackAttrReadInput::start/2#67f26627@d732e6yt was evaluated in 74 iterations totaling 31ms (delta sizes total: 113129).
186719 ~150% {1} r1 = SCAN `DataFlowDispatch::classInstanceTracker/1#d73ecef4#reorder_1_0#prev_delta` OUTPUT In.0
1669 ~0% {1} r2 = SCAN `DataFlowDispatch::superCallNoArgumentTracker/1#0a2e8a06#reorder_1_0#prev_delta` OUTPUT In.0
3425 ~15% {1} r3 = SCAN `DataFlowDispatch::clsArgumentTracker/1#47339327#prev_delta` OUTPUT In.1
96 ~0% {1} r4 = SCAN `DataFlowDispatch::superCallTwoArgumentTracker/2#d18be99f#reorder_2_0_1#prev_delta` OUTPUT In.0
123310 ~0% {1} r5 = SCAN `DataFlowDispatch::selfTracker/1#f157aa27#reorder_1_0#prev_delta` OUTPUT In.0
164342 ~581% {1} r6 = SCAN `DataFlowDispatch::classTracker/1#d11f2237#reorder_1_0#prev_delta` OUTPUT In.0
479561 ~94% {1} r7 = r1 UNION r2 UNION r3 UNION r4 UNION r5 UNION r6
169424 ~2% {1} | JOIN WITH `Attributes::AttrRef.getObject/0#dispred#d7cd0a97_10#join_rhs` ON FIRST 1 OUTPUT Rhs.1
116290 ~0% {2} | JOIN WITH Attributes::AttrRead#class#f6c3f431 ON FIRST 1 OUTPUT Lhs.0, Lhs.0
{2} | AND NOT `DataFlowDispatch::TrackAttrReadInput::start/2#67f26627#prev`(FIRST 2)
113160 ~0% {2} | SCAN OUTPUT In.1, In.1
return r7
```
2024-03-21 15:55:58 +01:00
Jeroen Ketema
98de4e209b
C++: Handle destructors of if and switch initializer statements
2024-03-21 15:47:11 +01:00
Jeroen Ketema
9cc287dff1
C++: Handle destructors of range-based for-loop initializer statements
2024-03-21 15:47:11 +01:00
Cornelius Riemenschneider
be245dd4b2
Merge pull request #16012 from github/criemen/swift-linux-sandbox
...
Swift genrule: Replace local with no-sandbox.
2024-03-21 15:06:47 +01:00
Rasmus Wriedt Larsen
bfa8515b28
Python: Apply suggestions from code review
...
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com >
2024-03-21 14:51:45 +01:00
Cornelius Riemenschneider
79094e4b89
Swift genrule: Replace local with no-sandbox.
...
This allows the bazel cache to cache this genrule invocation.
It shouldn't depend on system-specific binaries, so
I believe this is correct.
This is the only part of our build where we otherwise
need to recompute parts after pulling in a full cache.
2024-03-21 13:51:22 +00:00
Ian Lynagh
1b3605754f
Java: Add a changenote for dropping ODASA_SNAPSHOT support
2024-03-21 13:38:54 +00:00
Tamás Vajk
0aa7de295b
Merge pull request #16004 from tamasvajk/feature/adjust-incorrect-compare-to
...
C#: Simplify the output of `cs/wrong-compareto-signature` to remove e…
2024-03-21 14:38:54 +01:00
Ian Lynagh
33fe5abf94
Kotlin: Remove references to legacy ODASA_SNAPSHOT env var
2024-03-21 13:29:40 +00:00
Henry Mercer
4e3a6e2140
Merge pull request #15874 from github/henrymercer/mark-loc-as-telemetry
...
Show lines of code data in debug mode only
2024-03-21 12:20:09 +00:00
Rasmus Wriedt Larsen
cff63ad5d5
Python: Fix small join-order problem for call-graph
...
problem is:
```
14294 ~33% {1} r23 = r21 UNION r22
13626 ~0% {2} | JOIN WITH `DataFlowPublic::Node.getEnclosingCallable/0#dispred#be95825a` ON FIRST 1 OUTPUT Rhs.1, Lhs.0
11871493 ~2% {2} | JOIN WITH `DataFlowPublic::Node.getEnclosingCallable/0#dispred#be95825a_10#join_rhs` ON FIRST 1 OUTPUT Rhs.1, Lhs.1
6810938 ~3% {2} | JOIN WITH num#DataFlowPublic::TCfgNode#2cd2fb22_10#join_rhs ON FIRST 1 OUTPUT Rhs.1, Lhs.1
0 ~0% {4} | JOIN WITH `DataFlowDispatch::resolveMethodCall/4#3067f1f1#reorder_0_3_1_2#prev` ON FIRST 2 OUTPUT Rhs.3, Lhs.1, Lhs.0, Rhs.2
0 ~0% {4} | JOIN WITH num#DataFlowDispatch::CallTypeClassMethod#3508c3e5 ON FIRST 1 OUTPUT Lhs.3, Lhs.2, Lhs.0, Lhs.1
0 ~0% {4} | JOIN WITH `DataFlowDispatch::resolveCall/3#454c02d8#reorder_1_0_2#prev` ON FIRST 3 OUTPUT Lhs.3, Lhs.1, Lhs.0, Lhs.2
0 ~0% {5} | JOIN WITH num#DataFlowDispatch::TSelfArgumentPosition#de6d64b8 CARTESIAN PRODUCT OUTPUT Lhs.1, Lhs.2, Lhs.3, Lhs.0, Rhs.0
```
that is, it does cartesian product of DataFlowPublic::Node.getEnclosingCallable
After fix
```
14294 ~33% {1} r23 = r21 UNION r22
0 ~0% {4} | JOIN WITH `DataFlowDispatch::resolveMethodCall/4#3067f1f1#reorder_3_0_1_2#prev` ON FIRST 1 OUTPUT Rhs.3, Lhs.0, Rhs.1, Rhs.2
0 ~0% {4} | JOIN WITH num#DataFlowDispatch::CallTypeClassMethod#3508c3e5 ON FIRST 1 OUTPUT Lhs.3, Lhs.2, Lhs.0, Lhs.1
0 ~0% {4} | JOIN WITH `DataFlowDispatch::resolveCall/3#454c02d8#reorder_1_0_2#prev` ON FIRST 3 OUTPUT Lhs.1, Lhs.3, Lhs.0, Lhs.2
0 ~0% {5} | JOIN WITH num#DataFlowPublic::TCfgNode#2cd2fb22 ON FIRST 1 OUTPUT Rhs.1, Lhs.1, Lhs.0, Lhs.2, Lhs.3
0 ~0% {5} | JOIN WITH `DataFlowPublic::Node.getEnclosingCallable/0#dispred#be95825a` ON FIRST 1 OUTPUT Lhs.1, Rhs.1, Lhs.2, Lhs.3, Lhs.4
0 ~0% {4} | JOIN WITH `DataFlowPublic::Node.getEnclosingCallable/0#dispred#be95825a` ON FIRST 2 OUTPUT Lhs.0, Lhs.2, Lhs.3, Lhs.4
0 ~0% {5} | JOIN WITH num#DataFlowDispatch::TSelfArgumentPosition#de6d64b8 CARTESIAN PRODUCT OUTPUT Lhs.1, Lhs.2, Lhs.3, Lhs.0, Rhs.0
```
Overall stats
(old)
Pipeline standard for DataFlowDispatch::getCallArg/5#21589076@b30c7vxg was evaluated in 51 iterations totaling 54ms (delta sizes total: 38247).
==>
(new)
Pipeline standard for DataFlowDispatch::getCallArg/5#21589076@c1559vxu was evaluated in 51 iterations totaling 28ms (delta sizes total: 38247).
2024-03-21 12:31:58 +01:00
Jeroen Ketema
ccc5a80d93
Merge pull request #16008 from jketema/destructors19
...
C++: Handle `getInitializingExpr` in PrintAST
2024-03-21 12:22:48 +01:00
Rasmus Wriedt Larsen
2aa5ae41fb
Python: Fix join-order problem in SqlAlchemy
...
No major performance impact, more of a learning example for myself (had +3000 join order badness).
Initial tuple counts
```
Evaluated recursive predicate SqlAlchemy::SqlAlchemy::Connection::ConnectionConstruction#45e716e0@594cfx2g in 1ms on iteration 1 (delta size: 4).
Evaluated relational algebra for predicate SqlAlchemy::SqlAlchemy::Connection::ConnectionConstruction#45e716e0@594cfx2g on iteration 1 running pipeline base with tuple counts:
37793 ~0% {3} r1 = JOIN `ApiGraphs::API::Node.getACall/0#dispred#312deb92_10#join_rhs` WITH DataFlowPublic::CallCfgNode#b8ddbf81 ON FIRST 1 OUTPUT Lhs.1, Lhs.0, Rhs.1
0 ~0% {2} | JOIN WITH `SqlAlchemy::SqlAlchemy::Connection::classRef/0#565fc3ad` ON FIRST 1 OUTPUT Lhs.1, Lhs.2
30 ~0% {5} r2 = JOIN DataFlowPublic::CallCfgNode#b8ddbf81 WITH `DataFlowPublic::MethodCallNode.calls/2#dispred#1dd1e0f4#ffb` ON FIRST 1 OUTPUT Lhs.0, Lhs.1, Rhs.1, Rhs.2, _
{4} | REWRITE WITH NOT [NOT [Tmp.4 := "begin", TEST InOut.3 = Tmp.4], NOT [Tmp.4 := "connect", TEST InOut.3 = Tmp.4]] KEEPING 4
21 ~0% {3} | SCAN OUTPUT In.2, In.0, In.1
4 ~0% {2} | JOIN WITH `SqlAlchemy::SqlAlchemy::Engine::instance/0#1828baef` ON FIRST 1 OUTPUT Lhs.1, Lhs.2
4 ~0% {2} r3 = r1 UNION r2
return r3
```
which is fixed by the only_bind_out
```
Evaluated recursive predicate SqlAlchemy::SqlAlchemy::Connection::ConnectionConstruction#45e716e0@49effxtg in 0ms on iteration 1 (delta size: 0).
Evaluated relational algebra for predicate SqlAlchemy::SqlAlchemy::Connection::ConnectionConstruction#45e716e0@49effxtg on iteration 1 running pipeline base with tuple counts:
0 ~0% {1} r1 = JOIN `SqlAlchemy::SqlAlchemy::Connection::classRef/0#565fc3ad` WITH `ApiGraphs::API::Node.getACall/0#dispred#312deb92` ON FIRST 1 OUTPUT Rhs.1
0 ~0% {2} | JOIN WITH DataFlowPublic::CallCfgNode#b8ddbf81 ON FIRST 1 OUTPUT Lhs.0, Rhs.1
return r1
```
We also had this initial problem
```
Evaluated recursive predicate SqlAlchemy::SqlAlchemy::Connection::ConnectionConstruction#45e716e0@594cfx2g in 1ms on iteration 4 (delta size: 0).
Evaluated relational algebra for predicate SqlAlchemy::SqlAlchemy::Connection::ConnectionConstruction#45e716e0@594cfx2g on iteration 4 running pipeline standard with tuple counts:
48722 ~6% {2} r1 = DataFlowPublic::CallCfgNode#b8ddbf81 AND NOT SqlAlchemy::SqlAlchemy::Connection::ConnectionConstruction#45e716e0#prev(FIRST 2)
48722 ~3% {3} r2 = SCAN r1 OUTPUT In.0, _, In.1
48722 ~1% {3} | REWRITE WITH Out.1 := "connect"
16 ~0% {3} | JOIN WITH `DataFlowPublic::MethodCallNode.calls/2#dispred#1dd1e0f4#ffb_021#join_rhs` ON FIRST 2 OUTPUT Rhs.2, Lhs.0, Lhs.2
0 ~0% {2} | JOIN WITH `SqlAlchemy::SqlAlchemy::Connection::instance/0#5ed87c17#prev_delta` ON FIRST 1 OUTPUT Lhs.1, Lhs.2
48722 ~3% {3} r3 = SCAN r1 OUTPUT In.0, _, In.1
48722 ~2% {3} | REWRITE WITH Out.1 := "execution_options"
9 ~0% {3} | JOIN WITH `DataFlowPublic::MethodCallNode.calls/2#dispred#1dd1e0f4#ffb_021#join_rhs` ON FIRST 2 OUTPUT Rhs.2, Lhs.0, Lhs.2
0 ~0% {2} | JOIN WITH `SqlAlchemy::SqlAlchemy::Connection::instance/0#5ed87c17#prev_delta` ON FIRST 1 OUTPUT Lhs.1, Lhs.2
0 ~0% {2} r4 = r2 UNION r3
return r4
```
which is fixed by `connectionConstruction_helper`
```
Evaluated recursive predicate SqlAlchemy::SqlAlchemy::Connection::helper/0#62cfc178#b@4f295yef in 1ms on iteration 4 (delta size: 0).
Evaluated relational algebra for predicate SqlAlchemy::SqlAlchemy::Connection::helper/0#62cfc178#b@4f295yef on iteration 4 running pipeline standard with tuple counts:
4 ~0% {1} r1 = JOIN `SqlAlchemy::SqlAlchemy::Connection::instance/1#029b4c87#prev_delta` WITH `TypeTrackingImpl::TypeTracker::end/0#2ac2cfd4` ON FIRST 1 OUTPUT Lhs.1
16 ~0% {1} | JOIN WITH `LocalSources::Cached::hasLocalSource/2#8b3ee0ec_10#join_rhs` ON FIRST 1 OUTPUT Rhs.1
0 ~0% {3} | JOIN WITH `DataFlowPublic::MethodCallNode.calls/2#dispred#1dd1e0f4#ffb_102#join_rhs` ON FIRST 1 OUTPUT Rhs.1, Rhs.2, _
0 ~0% {2} | REWRITE WITH NOT [NOT [Tmp.2 := "connect", TEST InOut.1 = Tmp.2], NOT [Tmp.2 := "execution_options", TEST InOut.1 = Tmp.2]] KEEPING 2
0 ~0% {1} | JOIN WITH DataFlowPublic::CallCfgNode#b8ddbf81 ON FIRST 1 OUTPUT Lhs.0
0 ~0% {1} | AND NOT `SqlAlchemy::SqlAlchemy::Connection::helper/0#62cfc178#b#prev`(FIRST 1)
return r1
```
2024-03-21 11:55:49 +01:00
Jeroen Ketema
4c4ebd907e
C++: Update more expected test results
2024-03-21 11:54:29 +01:00
Jeroen Ketema
a3ae304dfe
C++: Handle getInitializingExpr in PrintAST
2024-03-21 11:32:23 +01:00
Jeroen Ketema
33c524d9fd
Merge pull request #16003 from jketema/destructors18
...
C++: Add tests showing missing destructors for initialization statements
2024-03-21 11:28:54 +01:00
Tamas Vajk
9d655520cc
Code quality improvement
2024-03-21 11:26:45 +01:00
Mathias Vorreiter Pedersen
dc5ee7c8b4
Merge pull request #16007 from MathiasVP/fix-tls-settings-misconfiguration
...
C++: Fix `cpp/boost/tls-settings-misconfiguration` FPs
2024-03-21 10:16:37 +00:00
Mathias Vorreiter Pedersen
7fb64268bd
Merge pull request #15997 from MathiasVP/simplify-guard-in-missing-check-scanf
...
C++: Simplify use of guard conditions in `cpp/missing-check-scanf`
2024-03-21 10:16:12 +00:00
Tamas Vajk
d0c09f43a9
Add change note
2024-03-21 11:13:42 +01:00
Paolo Tranquilli
eb7f07dc3f
Merge pull request #15967 from github/redsun82/test
...
Swift: add `-headerpad_max_install_names` to link options
2024-03-21 11:11:53 +01:00
Tom Hvitved
c0f80ecd2f
Merge pull request #15994 from hvitved/csharp/no-trap-stack-in-buildless
...
C#: Avoid using TRAP stack in buildless mode
2024-03-21 10:46:08 +01:00
erik-krogh
54a1c25276
change the precision of the js/unsafe-external-link query to low
2024-03-21 10:32:15 +01:00
Tamas Vajk
9da8cb1165
C#: Simplify the output of cs/wrong-compareto-signature to remove entity locations
2024-03-21 10:27:55 +01:00
Jeroen Ketema
06313b9bb6
Merge pull request #15998 from MathiasVP/simplify-guard-in-incorrectly-check-scanf
...
C++: Simplify use of guard conditions in `cpp/incorrectly-checked-scanf`
2024-03-21 10:10:03 +01:00
Jeroen Ketema
84646cd795
C++: Add tests showing missing destructors for initialization statements
...
Incidentially this also shows that for contructs like `if (char x = ...)`, so
there is an initialization but not initializer statement, the initialization
is not displayed in the AST, although the IR does contain the initialization.
2024-03-21 09:40:00 +01:00
Michael Nebel
6619be3137
Merge pull request #15940 from michaelnebel/csharp/sourcesinktests
...
C#: Source- and sink tests.
2024-03-21 08:12:16 +01:00
Jeroen Ketema
ec071cde51
Merge pull request #15991 from jketema/destructors17
...
C++: Handle destruction of temporaries in expressions with a `thow` at the root
2024-03-21 07:47:09 +01:00
Jeroen Ketema
9300b04def
C++: Update test results
2024-03-21 00:05:30 +01:00
Henry Mercer
a76832f4e0
Mark LOC queries as debug instead
2024-03-20 21:18:55 +00:00
Tom Hvitved
8f56edea80
Merge pull request #15966 from hvitved/treesitter-split-up-node-info-table
...
Tree-sitter: Split up `ast_node_info` table into two tables
2024-03-20 20:38:18 +01:00
Mathias Vorreiter Pedersen
0ef8c7d87f
C++: Accept test changes.
2024-03-20 18:05:14 +00:00
Mathias Vorreiter Pedersen
1330c885c8
C++: Use 'asIndirectExpr' in the sink of 'ExistsAnyFlowConfig.
2024-03-20 18:04:59 +00:00
Mathias Vorreiter Pedersen
f31bb1391d
C++: Simplify 'checkedForEof'.
2024-03-20 16:59:39 +00:00
Mathias Vorreiter Pedersen
5476f42d2c
C++: Simplify use of 'GuardCondition's in 'cpp/missing-check-scanf'.
2024-03-20 16:44:43 +00:00
Mathias Vorreiter Pedersen
e3be2057d3
Merge pull request #15996 from MathiasVP/missing-check-scanf-path-problem
...
Make `cpp/missing-check-scanf` a `path-problem` query
2024-03-20 16:42:47 +00:00
Mathias Vorreiter Pedersen
96cd259eda
C++: Add change note.
2024-03-20 14:56:39 +00:00
Mathias Vorreiter Pedersen
14aff5c94c
C++: Convert 'cpp/missing-check-scanf' to a path-problem query.
2024-03-20 14:54:53 +00:00
Mathias Vorreiter Pedersen
0fe3072a65
Merge pull request #15988 from MathiasVP/clean-up-missing-check-scanf
...
C++: Rewrite 'cpp/missing-check-scanf' to use standard dataflow configs
2024-03-20 14:50:08 +00:00
Mathias Vorreiter Pedersen
ebac171b2b
Java/Shared: Rename 'joinStep0' to 'joinStep'.
2024-03-20 14:40:16 +00:00
Mathias Vorreiter Pedersen
6a65c46b2e
Java/Shared: Share more 'isNull' computations.
2024-03-20 14:36:12 +00:00
Mathias Vorreiter Pedersen
90fbacc7bf
Java/Shared: Use getLocation instead of hasLocationInfo.
2024-03-20 14:29:48 +00:00
Michael Nebel
969676975d
C#: Address review comments.
2024-03-20 15:28:56 +01:00
Michael B. Gale
616015fddf
Merge pull request #15935 from github/mbg/go/speed-up-dependencies
2024-03-20 14:26:46 +00:00
Tom Hvitved
79dc7fcc04
C#: Avoid using TRAP stack in buildless mode
2024-03-20 15:21:36 +01:00
Taus
1d38ca371b
Merge pull request #15845 from github/tausbn/python-extractor-fix-build
...
Python: Build external extractor
2024-03-20 15:18:59 +01:00
Michael B. Gale
648543f2fb
Merge pull request #15989 from github/mbg/docs/go-1.22
...
Docs: Add Go 1.22 to supported versions range
2024-03-20 14:04:26 +00:00
Michael B. Gale
c74d6348f9
Go: Run go with a valid toolchain version if we have found an invalid one
2024-03-20 13:55:37 +00:00
Michael B. Gale
0d527b2f75
Go: Keep track of all installed toolchains that we know of
2024-03-20 13:52:06 +00:00
Jeroen Ketema
1fd11928eb
Merge pull request #15978 from jketema/destructors16
...
C++: Handle destructors at temporary object lifetime expressions
2024-03-20 14:24:10 +01:00
Ian Lynagh
9086ec8b13
Merge pull request #15973 from igfoo/igfoo/exprs
...
Kotlin 2: Accept more test changes
2024-03-20 13:13:56 +00:00
Michael B. Gale
96a6dd72cd
Go: Move go version command construction into its own function
2024-03-20 13:08:59 +00:00
Michael B. Gale
c71ba0361e
Docs: Add Go 1.22 to supported versions range
2024-03-20 12:12:20 +00:00
Mathias Vorreiter Pedersen
c9dbb7c5a9
C++: Rewrite 'cpp/missing-check-scanf' to use standard dataflow configurations.
2024-03-20 12:01:57 +00:00
Michael B. Gale
06134467e9
Go: Make CODEQL_EXTRACTOR_GO_FAST_PACKAGE_INFO true by default
2024-03-20 12:01:49 +00:00
Ian Lynagh
3fa7532b43
Kotlin 2: Accept more test changes
2024-03-20 11:46:58 +00:00
Cornelius Riemenschneider
8fbd743e9e
Merge pull request #15971 from github/criemen/bazel-7-1
...
Upgrade to bazel 7.1
2024-03-20 12:27:03 +01:00
Mathias Vorreiter Pedersen
7ff2998c88
Merge pull request #15980 from MathiasVP/guards-lt
...
C++: Support `<` reasoning for `switch` statements in Guards library
2024-03-20 10:40:39 +00:00
Mathias Vorreiter Pedersen
3a7b80da47
C++: Respond to review comments.
2024-03-20 10:12:29 +00:00
Mathias Vorreiter Pedersen
9179f0bda6
Merge pull request #15969 from MathiasVP/disable-some-constant-folding
...
C++: Disable _some_ constant folding in IR
2024-03-20 09:25:06 +00:00
Arthur Baars
1d956e1039
Merge pull request #15974 from github/dbartol/rc3.13-mergeback
...
Mergeback from `rc/3.13`
2024-03-20 10:13:32 +01:00
erik-krogh
db3bf0e482
use the sanitizers from ReflectedXSS in unsafe-html-construction
2024-03-20 10:11:07 +01:00
Jeroen Ketema
3ee965f2b9
C++: Update test results
2024-03-20 10:05:35 +01:00
Tom Hvitved
90779f4413
Ruby: Extend barrier guards to handle phi inputs
2024-03-20 10:02:20 +01:00
Tom Hvitved
0f0acc0428
Ruby: Add barrier guard flow tests
2024-03-20 09:25:20 +01:00
Alex Denisov
1cfde49297
Swift: remove unused patches
2024-03-20 09:24:25 +01:00
Alex Denisov
589a5039c8
Swift: update Swift 5.10 dependencies
2024-03-20 09:23:12 +01:00
Tony Torralba
0bb86fc087
Merge pull request #15983 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-03-20 09:00:34 +01:00
Paolo Tranquilli
10efcc2bb4
Swift: add -headerpad_max_install_names to link options
2024-03-20 08:35:33 +01:00
github-actions[bot]
f6f7073520
Add changed framework coverage reports
2024-03-20 00:15:31 +00:00
Mathias Vorreiter Pedersen
97aa301ac9
C++: Accept more test changes.
2024-03-19 17:33:23 +00:00
Mathias Vorreiter Pedersen
88bfb81b1f
C++: Add change note.
2024-03-19 17:14:07 +00:00
Taus
d12ac1e7ce
Python: Use tsp instead of tree-sitter-python
2024-03-19 17:11:40 +00:00
Taus
38169a981d
Python: Shorten tree-sitter-python directory name
...
The current name results in a path that is more than 260 characters long,
and this causes issues for the build on Windows.
2024-03-19 17:11:40 +00:00
Taus
6f388acdd8
Python: Rename tsg_python_crate_index to py_deps
...
This aligns us a bit more with Ruby.
2024-03-19 17:11:40 +00:00
Taus
04c9ed37a7
Python: Fix reference in unit test
...
The referenced file lives in the internal repo, so this is perhaps a bit
of a hack, but I think it should be fine in the short run.
2024-03-19 17:11:40 +00:00
Taus
cac5a8236e
Python: Fix CLI integration tests
...
Two issues:
- Tests relying on existing query machinery (i.e. `import python`) were not resolving
correctly due to a bad `qlpack.yml` file.
- The diagnostics output tests needed an updated import to account for their new location.
2024-03-19 17:11:40 +00:00
Taus
0550c46766
Python: Fix Bazel build
2024-03-19 17:11:40 +00:00
Taus
5fed8bc57b
Python: Add codeql-extractor.yml
2024-03-19 17:11:40 +00:00
Taus
016aedab0a
Python: Move Python language pack tooling to external repo
...
This is essentially the contents of `language-packs/python/tools` with some minor
modifications to account for the changed location.
Of note: we explicitly exclude the `recorded-call-graph-metrics` director that
was already present in `python/tools`. When we revisit this directory for some
cleanup (e.g. to get rid of the `lgtm` references), we'll probably want to switch
to an explicit list of sources to include.
2024-03-19 17:11:40 +00:00
Taus
cdc879ee89
Python: Fix up some bazel references
2024-03-19 17:11:40 +00:00
Mathias Vorreiter Pedersen
1411ee5b26
C++: Extend tests to also test the new predicates and accept test changes.
2024-03-19 17:09:22 +00:00
Mathias Vorreiter Pedersen
a78080cc0e
C++: Implement less-than logic for guard conditions when comparing to constants.
2024-03-19 17:06:26 +00:00
Mathias Vorreiter Pedersen
8b85735cdc
C++: Generalize predicates from booleans to abstract values.
2024-03-19 17:03:59 +00:00
Dave Bartolomeo
bf46fa27d6
Merge remote-tracking branch 'origin/main' into dbartol/rc3.13-mergeback
2024-03-19 13:02:15 -04:00
Mathias Vorreiter Pedersen
aeb667c6ca
Merge pull request #15976 from MathiasVP/guards-eq-follow-up
...
C++: Fix interface for `GuardCondition.comparesEq` and `GuardCondition.ensuresEq`
2024-03-19 16:45:38 +00:00
Mathias Vorreiter Pedersen
6bf1611f10
C++: Fix comments.
2024-03-19 16:26:37 +00:00
Michael B. Gale
be027e217e
Go: Emit diagnostic for invalid toolchain versions
2024-03-19 16:26:06 +00:00
Mathias Vorreiter Pedersen
357a2ba733
C++: Sync identical files.
2024-03-19 16:24:11 +00:00
Mathias Vorreiter Pedersen
458ee13345
C++: Add constant analysis for bitwise operations now that these are no longer constant folded by IR construction.
2024-03-19 16:23:57 +00:00
yoff
ee411cc53a
Merge pull request #15936 from yoff/python/test-conflicting-summaries
...
Python: No `fieldFlowBranchLimit` for `SummarizedCallable`s
2024-03-19 16:56:56 +01:00
Robert Marsh
467f4e11a1
C++: Change note for IR translation of destruction of temporaries with extended lifetimes
2024-03-19 15:55:36 +00:00
Robert Marsh
5a30ad162a
C++: Add a comment for ReusedExpr IR translation
2024-03-19 15:54:52 +00:00
Robert Marsh
3d4f7d880d
C++: unsuppress destructoion of temporaries with extended lifetimes
2024-03-19 15:54:42 +00:00
Robert Marsh
ba10ea8121
C++: ReuseExpr IR translation
2024-03-19 15:50:28 +00:00
Michael Nebel
d3aa2eed64
C#: Fix test.
2024-03-19 16:30:24 +01:00
Jeroen Ketema
f5fed84bb2
Merge pull request #15968 from jketema/destructors15
...
C++: Fabricate destructors for temporaries that occur in dynamic initializations
2024-03-19 16:16:43 +01:00
Owen Mansel-Chan
b8608a1b1c
Merge pull request #15946 from owen-mc/java/more-manual-models
...
Java: more manual models
2024-03-19 15:00:27 +00:00
Mathias Vorreiter Pedersen
c640bd67e9
C++: Fix tests for guards.
2024-03-19 14:43:16 +00:00
Mathias Vorreiter Pedersen
6ce3f35ef5
C++: Fix API for guards.
2024-03-19 14:43:10 +00:00
Dave Bartolomeo
311ba8ea1b
Merge from main to resolve conflicts
2024-03-19 10:41:31 -04:00
Harry Maclean
219cd4e415
Merge pull request #14426 from hmac/hmac-ar-scopes
...
Ruby: Track flow into ActiveRecord scopes
2024-03-19 14:19:14 +00:00
Chris Smowton
f8124222cc
Merge pull request #15959 from smowton/smowton/admin/jdk22-test-changes
...
JDK22 upgrade test changes
2024-03-19 14:02:46 +00:00
Harry Maclean
7e479e3c8e
Ruby: Fix Hash#keys flow summary
2024-03-19 13:47:45 +00:00
Tom Hvitved
ee3e38f0eb
Simplify test interface in FlowSummaryImpl.qll
2024-03-19 14:35:00 +01:00
Owen Mansel-Chan
7371f5e508
Provenance should be "df-manual"
2024-03-19 13:33:49 +00:00
Mathias Vorreiter Pedersen
597f0082e7
Merge pull request #15958 from MathiasVP/ir-guards-from-switch-statements-2
...
C++: Implement guards logic for switch statements
2024-03-19 13:21:45 +00:00
Michael Nebel
70c6744944
Java/Go/Swift: Sync changes.
2024-03-19 14:20:43 +01:00
Michael Nebel
d24f032d97
C#: Update other tests.
2024-03-19 14:20:43 +01:00
Michael Nebel
b39842501a
C#: Update sink test expected output.
2024-03-19 14:20:42 +01:00
Michael Nebel
e32902ad47
C#: Update source expected test output.
2024-03-19 14:20:42 +01:00
Michael Nebel
5b37ee4ec7
Re-factor TestOutput into a param module.
2024-03-19 14:20:42 +01:00
Mathias Vorreiter Pedersen
54262a53c3
Revert "C++: Accept test changes."
...
This reverts commit f36b48346e .
2024-03-19 13:18:01 +00:00
Mathias Vorreiter Pedersen
a88d8b260d
C++: Only ignore constant folding for certain binary operations.
2024-03-19 13:17:49 +00:00
Mathias Vorreiter Pedersen
a97891cbc1
C++: Add QLDoc to 'getNumberOfBinaryOperands' (and rename it to 'getNumberOfNestedBinaryOperands').
2024-03-19 12:56:15 +00:00
Mathias Vorreiter Pedersen
f36b48346e
C++: Accept test changes.
2024-03-19 12:50:43 +00:00
Harry Maclean
df1845379a
Merge pull request #15965 from hmac/hmac-symbol-constant
...
Ruby: remove isString from TSymbol
2024-03-19 12:50:27 +00:00
Michael Nebel
90db9b330f
C#: Add MaD source and sink test query to shared library.
2024-03-19 13:45:38 +01:00
Cornelius Riemenschneider
42c5066cae
Upgrade to bazel 7.1
2024-03-19 13:40:45 +01:00
Harry Maclean
22ddf2129b
Ruby: remove isString from TSymbol
2024-03-19 12:27:34 +00:00
Tom Hvitved
2e370e2ded
Python: Switch to shared XML.qll implementation
2024-03-19 13:17:53 +01:00
Tom Hvitved
61ef9e2e5c
JS: Switch to shared XML.qll implementation
2024-03-19 13:17:50 +01:00
Tom Hvitved
a6c147134a
Java: Switch to shared XML.qll implementation
2024-03-19 13:15:45 +01:00
Tom Hvitved
754b491d09
C++: Switch to shared XML.qll implementation
2024-03-19 13:14:42 +01:00
Tom Hvitved
529e901fb1
C#: Switch to shared XML.qll implementation
2024-03-19 13:14:42 +01:00
Tom Hvitved
7055cd8239
Make XML.qll a parameterized module
2024-03-19 13:14:42 +01:00
Tom Hvitved
ccfbd2956c
Copy existing XML.qll into new a new codeql/xml pack
2024-03-19 13:14:42 +01:00
Tom Hvitved
31e04631d1
QL4QL: Regenerate DB scheme and stats
2024-03-19 13:04:12 +01:00
Tom Hvitved
865026f22b
Ruby: Add up/downgrade scripts (sigh)
2024-03-19 13:04:12 +01:00
Tom Hvitved
72ff494739
Ruby: Regenerate dbscheme and stats
2024-03-19 13:04:07 +01:00
Mathias Vorreiter Pedersen
1af1ba48a9
C++: Accept test changes.
2024-03-19 11:46:51 +00:00
Mathias Vorreiter Pedersen
4d3076ae7e
C++: Don't constant fold small binary operations.
2024-03-19 11:46:51 +00:00
Mathias Vorreiter Pedersen
e16e1c7e83
C++: Add tests.
2024-03-19 11:26:32 +00:00
Jeroen Ketema
06dbb4e9ef
Merge pull request #15937 from jketema/destructors14
...
C++: Handle destructors of temporaries with extended lifetimes
2024-03-19 12:07:05 +01:00
Mathias Vorreiter Pedersen
d7afd7b2e1
C++: Accept test changes.
2024-03-19 10:54:35 +00:00
Mathias Vorreiter Pedersen
350b239ed6
C++: Fix cartesian product in 'simple_comparison_eq'.
2024-03-19 10:29:43 +00:00
Jeroen Ketema
d47e2690b8
C++: Update test results after extractor changes
2024-03-19 11:18:36 +01:00
Jeroen Ketema
fd49871b9a
C++: Handle destructors of temporaries with extended lifetimes
2024-03-19 10:56:44 +01:00
Tom Hvitved
cee6f003fd
Tree-sitter: Split up ast_node_info table into two tables
2024-03-19 10:52:37 +01:00
Mathias Vorreiter Pedersen
0c3d9f75f4
C++: Add change note.
2024-03-19 09:41:58 +00:00
yoff
f025430431
Merge pull request #15319 from Sim4n6/main
...
[Python] Add Unicode DoS (qhelp, tests and the query)
2024-03-19 10:00:30 +01:00
Rasmus Wriedt Larsen
d78efdb67b
Merge pull request #15883 from RasmusWL/js-cg-tests
...
JS: show test changes after #15823
2024-03-19 09:58:20 +01:00
Harry Maclean
dde148ee7e
Ruby: add changenote
2024-03-19 08:40:30 +00:00
Harry Maclean
32b80f8cb1
Ruby: Add tests for hash flow
2024-03-19 08:38:14 +00:00
Tom Hvitved
5ab1047b14
Merge pull request #15882 from hvitved/js/dataflow-node-get-location
...
JS: Add `DataFlow::Node.getLocation`
2024-03-19 09:21:00 +01:00
Chris Smowton
9a8ec36a4f
Accept test changes
2024-03-19 07:55:08 +00:00
Mathias Vorreiter Pedersen
aa1d5c5e41
Merge pull request #15960 from MathiasVP/unitialized-local-as-path
...
C++: Convert `cpp/uninitialized-local` to a `path-problem` query
2024-03-18 21:18:17 +00:00
Erik Krogh Kristensen
a3da6c886b
Merge pull request #15895 from erik-krogh/url-java-qhelp
...
Java: update the url-redirection in the same style as the C# qhelp
2024-03-18 21:10:07 +01:00
yoff
44ab36f238
Merge pull request #15729 from yoff/python/hardcoded-credentials-without-pointsto
...
python: Rewrite `HardcodedCredentials` away from `PointsTo`
2024-03-18 20:48:30 +01:00
Tom Hvitved
fc55567d90
Merge pull request #15853 from hvitved/dataflow/get-location
...
Data flow: Replace `hasLocationInfo` with `getLocation`
2024-03-18 20:21:46 +01:00
Tom Hvitved
8899d66132
Merge pull request #15734 from hvitved/dataflow/hidden-subpath
...
Data flow: Account for hidden `subpath` wrappers
2024-03-18 20:17:16 +01:00
Michael B. Gale
3649af3f05
Go: Add test for go/autobuilder/invalid-go-toolchain-version diagnostic
2024-03-18 17:56:59 +00:00
Harry Maclean
187a68bf76
Ruby: Add flow summary for Hash#keys
2024-03-18 17:56:10 +00:00
Harry Maclean
e895f96a3a
Ruby: Taint flow to second block param in map
...
When `map` is called on a hash, the values in the hash are passed to the
second parameter of the block.
2024-03-18 17:55:02 +00:00
Mathias Vorreiter Pedersen
b66b8785c4
Merge branch 'main' into unitialized-local-as-path
2024-03-18 17:42:53 +00:00
Chris Smowton
35a309fd40
Merge pull request #15897 from smowton/smowton/admin/test-for-gradle-wrapper-without-gradle
...
Java: add test for partial gradle wrapper without gradle on the path
2024-03-18 17:07:20 +00:00
Owen Mansel-Chan
764e99bda7
Fix model for java.util.Scanner#findall(String)
...
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com >
2024-03-18 16:56:20 +00:00
Owen Mansel-Chan
e10ce8875f
Merge pull request #15947 from owen-mc/java/fix-model-provenance-to-df-manual
...
Fix model provenance to df-manual
2024-03-18 16:54:39 +00:00
Mathias Vorreiter Pedersen
9c2b2160ce
Merge pull request #15939 from MathiasVP/experimental-surprising-lifetimes-for-range-based-for-loop
...
C++: Add an experimental query for surprising lifetimes from range-based for loops
2024-03-18 16:43:11 +00:00
Mathias Vorreiter Pedersen
40dbc6fdd9
C++: Accept test changes.
2024-03-18 16:27:18 +00:00
Mathias Vorreiter Pedersen
032678a367
C++: Extend tests to also test the new predicates.
2024-03-18 16:27:10 +00:00
Mathias Vorreiter Pedersen
dbd47b387a
C++: Add AST wrappers for the new predicates.
2024-03-18 16:26:36 +00:00
Mathias Vorreiter Pedersen
decede51dc
C++: Use the new predicate in 'ScanfChecks.qll'.
2024-03-18 16:07:57 +00:00
Mathias Vorreiter Pedersen
44045d3eed
C++: Add guards logic for constant comparisons.
2024-03-18 16:07:57 +00:00
Mathias Vorreiter Pedersen
a21eea4ee0
C++: Generalize more predicates from booleans to abstract values.
2024-03-18 16:07:57 +00:00
Arthur Baars
e812682991
Merge pull request #15955 from github/post-release-prep/codeql-cli-2.16.5
...
Post-release preparation for codeql-cli-2.16.5
2024-03-18 16:58:01 +01:00
Mathias Vorreiter Pedersen
b944f3b411
C++: Fix FP.
2024-03-18 15:57:20 +00:00
Mathias Vorreiter Pedersen
e373341f62
C++: Add more tests.
2024-03-18 15:57:17 +00:00
Ian Lynagh
60b5e49905
Java: Limit the amount of results that MissingEnumInSwitch produces per switch
...
The tool status page warns:
An analysis file contained multiple alerts that included more related
locations than our allowed limit of 100.
These alerts correspond to the rule java/missing-case-in-switch.
Only 100 locations were stored for these alerts.
2024-03-18 15:56:21 +00:00
Ian Lynagh
916b1e959e
Java: Add a test for MissingEnumInSwitch
2024-03-18 15:56:10 +00:00
Chris Smowton
af7b1bc425
Java: add test for partial gradle wrapper without gradle on the path
...
Note I had to mimic the actual absence of Gradle by testing the case where it fails, but have manually verified a missing binary works too.
2024-03-18 15:37:39 +00:00
Mathias Vorreiter Pedersen
668239f355
C++: Convert tabs to spaces.
2024-03-18 15:16:10 +00:00
Mathias Vorreiter Pedersen
bd0969b87b
C++: Add change note.
2024-03-18 15:04:19 +00:00
Mathias Vorreiter Pedersen
4a55b6fbdf
C++: Make 'cpp/uninitialized-local' a path-problem query.
2024-03-18 15:02:33 +00:00
Harry Maclean
80ae017aa1
Ruby: Track flow into ActiveRecord scopes
2024-03-18 15:01:37 +00:00
Tom Hvitved
0cecbf5239
Update 2024-02-28-hidden-subpaths.md
...
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com >
2024-03-18 15:36:01 +01:00
Joe Farebrother
4177c38ed4
Merge pull request #15907 from joefarebrother/ruby-uploaded-file
...
Ruby: Model ActiveDispatch::Http::UploadedFile
2024-03-18 14:02:33 +00:00
Tamas Vajk
322fb6c507
Change integration test to return stable results
2024-03-18 14:53:49 +01:00
Tom Hvitved
7a3b8ebb3a
Address review comments
2024-03-18 14:49:35 +01:00
Tom Hvitved
40089e8088
Add change note
2024-03-18 14:49:35 +01:00
Tom Hvitved
e53357d376
Update expected test output
2024-03-18 14:49:32 +01:00
Tom Hvitved
d7c9bfa08b
Data flow: Account for hidden subpath wrappers
2024-03-18 14:47:11 +01:00
Sim4n6
1af8167354
updated the .expected file
2024-03-18 13:26:20 +00:00
Tamas Vajk
d749335f54
C#: Limit extracted compilation and extraction messages
2024-03-18 14:24:34 +01:00
Tom Hvitved
d83500de5d
Address review comments
2024-03-18 14:24:07 +01:00
Tamas Vajk
e8e1dc0390
C#: Add integration test with extraction and compilation messages
2024-03-18 14:23:40 +01:00
github-actions[bot]
aebe9f6992
Post-release preparation for codeql-cli-2.16.5
2024-03-18 12:16:26 +00:00
Rasmus Wriedt Larsen
c82f5dad56
JS: show test changes after #15823
2024-03-18 13:09:37 +01:00
Rasmus Wriedt Larsen
28c3d35e9b
Merge commit '7c35309732dd2aa4dc0b4e2949922272ad448854' into js-cg-tests
2024-03-18 13:08:46 +01:00
Rasmus Wriedt Larsen
f9309cec0b
JS: Add tests before #15823 changes
2024-03-18 13:08:39 +01:00
Mathias Vorreiter Pedersen
7b6accd33a
Update cpp/ql/src/experimental/Security/CWE/CWE-416/IteratorToExpiredContainer.ql
...
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com >
2024-03-18 12:01:51 +00:00
Mathias Vorreiter Pedersen
457d71d7bc
Update cpp/ql/src/experimental/Security/CWE/CWE-416/IteratorToExpiredContainer.ql
...
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com >
2024-03-18 12:01:44 +00:00
Arthur Baars
dbf16827bf
Merge pull request #15951 from github/aibaars/changenotes-fixes
...
Fix minor formatting issues in changenotes
2024-03-18 12:56:50 +01:00
Tamás Vajk
7429fa7b96
Merge pull request #15952 from tamasvajk/buildless/impr1
...
C#: Add logging for source file parsing
2024-03-18 12:27:27 +01:00
Tamás Vajk
f63c9fa07f
Merge pull request #15953 from tamasvajk/buildless/impr2
...
C#: Iterate text files only once
2024-03-18 12:26:38 +01:00
Ian Lynagh
d2bb951ecd
Merge pull request #15943 from igfoo/igfoo/k2locs
...
Kotlin 2: Accept more location changes
2024-03-18 11:26:08 +00:00
Owen Mansel-Chan
7fb05f4a76
Fix duplicate "df-" in "df-df-manual"
2024-03-18 11:17:55 +00:00
Mathias Vorreiter Pedersen
575af1a5f9
Merge branch 'main' into experimental-surprising-lifetimes-for-range-based-for-loop
2024-03-18 11:11:32 +00:00
Mathias Vorreiter Pedersen
1d12e0c9d9
Merge pull request #15941 from MathiasVP/ir-guards-from-switch-statements
...
C++: Handle `switch` statements in the guards library
2024-03-18 11:07:10 +00:00
Mathias Vorreiter Pedersen
e0476b555d
Merge pull request #15934 from MathiasVP/ir-models-for-iterators
...
C++: Add alias and side-effect models to `begin` and `end` functions
2024-03-18 11:06:59 +00:00
Arthur Baars
769e3469a4
Merge pull request #15954 from github/release-prep/2.16.5
...
Release preparation for version 2.16.5
2024-03-18 11:56:14 +01:00
Mathias Vorreiter Pedersen
0be329dbdc
C++: Delete duplicated code.
2024-03-18 10:33:40 +00:00
github-actions[bot]
0a6243d07b
Release preparation for version 2.16.5
2024-03-18 10:14:07 +00:00
Mathias Vorreiter Pedersen
51db2b0bc4
C++: Convert tabs to spaces in ir.cpp.
2024-03-18 10:11:37 +00:00
Tamas Vajk
881c426631
C#: Iterate text files only once
2024-03-18 11:06:44 +01:00
Tamas Vajk
3a8d468983
C#: Add logging for source file parsing
2024-03-18 11:02:29 +01:00
Arthur Baars
a810165e35
Fix minor formatting issues in changenotes
2024-03-18 10:57:05 +01:00
Tom Hvitved
a13391bda1
Merge pull request #15802 from hvitved/dataflow/variable-capture-overlapping-paths
...
Variable capture: Avoid overlapping and false-positive data flow paths
2024-03-18 10:45:55 +01:00
Rasmus Lerchedahl Petersen
2a0c451d2d
python: No fieldFlowBranchLimit for SummarizedCallables
...
Like https://github.com/github/codeql/pull/15689 for Ruby.
2024-03-18 10:29:36 +01:00
Rasmus Lerchedahl Petersen
45c65b48aa
python: make it a real package
...
so python2 also respects it
2024-03-18 08:49:31 +01:00
Jami Cogswell
a8eb1d10f6
Java: remove experimental tests
2024-03-17 22:35:27 -04:00
Jami Cogswell
658fffeac1
Java: remove experimental files
2024-03-17 22:03:59 -04:00
Owen Mansel-Chan
754d4cd959
Fix model provenance to df-manual
2024-03-17 14:36:47 +00:00
Owen Mansel-Chan
23a58a0835
Add df-manual models related to existing df-manual models
2024-03-17 14:21:05 +00:00
Owen Mansel-Chan
fc367042ef
Fix df-manual model with wrong parameter type
2024-03-17 14:21:01 +00:00
Ian Lynagh
a53d5d832d
Kotlin 2: Accept more loc changes
2024-03-15 18:08:53 +00:00
Ian Lynagh
c4c843968e
Kotlin 2: Accept more loc changes
2024-03-15 18:07:39 +00:00
Ian Lynagh
57d17d85f2
Kotlin 2: Accept more loc changes
2024-03-15 18:07:12 +00:00
Ian Lynagh
6c0885c24d
Kotlin 2: Accept more loc changes
2024-03-15 18:06:45 +00:00
Jami Cogswell
55f7369df0
Java: performance fix
2024-03-15 14:06:36 -04:00
Ian Lynagh
5580daf60e
Kotlin 2: Accept more loc changes
2024-03-15 18:06:13 +00:00
Ian Lynagh
1d2b31f0be
Kotlin 2: Accept more loc changes
2024-03-15 18:05:46 +00:00
Ian Lynagh
5552fe3c34
Kotlin 2: Accept more loc changes
2024-03-15 18:05:09 +00:00
Ian Lynagh
28f98d0344
Kotlin 2: Accept more location changes
2024-03-15 18:04:28 +00:00
Ian Lynagh
354cdf44aa
Kotlin 2: Accept more location changes
2024-03-15 18:03:55 +00:00
Ian Lynagh
f4542f6160
Kotlin2 : Accept some more location changes
2024-03-15 18:02:54 +00:00
Mathias Vorreiter Pedersen
e23e3d7fb4
C++: Run tests without the extractor and analysis changes.
2024-03-15 17:35:47 +00:00
Mathias Vorreiter Pedersen
a8718f99a1
C++: Add qhelp for 'cpp/iterator-to-expired-container'.
2024-03-15 17:35:47 +00:00
Mathias Vorreiter Pedersen
3a8db49573
C++: Add tests for 'cpp/iterator-to-expired-container'.
...
NOTE: This is with the yet-to-be-merged changes to the extractor and IR generation.
2024-03-15 17:35:17 +00:00
Mathias Vorreiter Pedersen
f4f417c3f9
C++: Fix QLoc.
2024-03-15 17:19:36 +00:00
Mathias Vorreiter Pedersen
b5e59492bf
C++: Add change note.
2024-03-15 17:17:05 +00:00
Mathias Vorreiter Pedersen
fb218150e1
C++: Change the testcase so that it outputs the controlling values for switch statements as well.
2024-03-15 17:05:42 +00:00
Mathias Vorreiter Pedersen
07ebbb0591
C++: Accept test changes.
2024-03-15 17:04:27 +00:00
Mathias Vorreiter Pedersen
34decd3cf1
C++: Add more general public predicates to work with abstract values.
2024-03-15 17:03:45 +00:00
Mathias Vorreiter Pedersen
f4eb5f5a2d
C++: Convert 'getBranchSuccessor' to use abstract values.
2024-03-15 17:03:45 +00:00
Mathias Vorreiter Pedersen
b7292fbc67
C++: Introduce 'AbstractValue' similar to what C# has.
2024-03-15 17:03:45 +00:00
Mathias Vorreiter Pedersen
2af68d37d0
C++: Include 'SwitchInstruction's as 'IRGuardCondition's.
2024-03-15 17:03:45 +00:00
Mathias Vorreiter Pedersen
704f1fad46
C++: Add switches as testcases for guard conditions.
2024-03-15 17:02:32 +00:00
Max Schaefer
daee22d38c
Merge pull request #15933 from github/max-schaefer/go-incomplete-hostname-regex
...
Go: Mention raw string iterals in QHelp for `go/incomplete-hostname-regexp`.
2024-03-15 15:07:10 +00:00
Edward Minnix III
8ae64e992c
Merge pull request #15929 from egregius313/egregius313/csharp/mad/source-node-clases-for-models
...
C#: Add classes extending `SourceNode` for local and stored source models
2024-03-15 11:06:14 -04:00
Joe Farebrother
8c5fff2d11
Update names and qldoc for params taint predicates
2024-03-15 14:43:29 +00:00
Mathias Vorreiter Pedersen
23cf99734a
C++: Add a new experimental query ' cpp/iterator-to-expired-container'.
2024-03-15 14:29:29 +00:00
Mathias Vorreiter Pedersen
f7c29e6bfb
C++: Expose some previously private classes from our models so they can be used in queries.
2024-03-15 14:21:39 +00:00
Rasmus Lerchedahl Petersen
cfbc3f73ec
Pyhton: add test for conflicting summaries
...
We noticed that when
- a function has more than one summary (with different charpred)
- one summary is subsumed by a subpath (or something happens around the function being extracted)
- the function is called multiple times(we needed at least three)
one of the summaries would no longer lead to flow.
2024-03-15 15:13:39 +01:00
Sim4n6
3acdd3382c
Update the expected file
2024-03-15 14:17:23 +01:00
Sim4n6
26a16b7857
use of a single var "op" of type Cmpop
2024-03-15 14:17:23 +01:00
Sim4n6
a717bf1b9d
Fix p tag in UnicodeDoS.qhelp
2024-03-15 14:17:23 +01:00
Sim4n6
af19a0342e
Fix UnicodeDoS vulnerability in CWE-770 code
2024-03-15 14:17:23 +01:00
Sim4n6
085d803b14
Fix UnicodeDoS vulnerability in CWE-770
2024-03-15 14:17:23 +01:00
Sim4n6
31dc542111
Update request parameter name in good_1() function
2024-03-15 14:17:23 +01:00
Sim4n6
70ebc58b4c
Refactor Unicode normalization code
2024-03-15 14:17:23 +01:00
Sim4n6
3d8868a6c3
Add routes for bad_5 and bad_6, and fix routes for good_3 and good_4
2024-03-15 14:17:23 +01:00
Sim4n6${{7*'7'}}
658b88e62f
Update python/ql/src/experimental/Security/CWE-770/UnicodeDoS.ql
...
update the Config API
Co-authored-by: yoff <lerchedahl@gmail.com >
2024-03-15 14:17:23 +01:00
Sim4n6
1f767b887e
Add some comments and docs
2024-03-15 14:17:23 +01:00
Sim4n6
5cc9170249
Add UnicodeDoS sink for werkzeug secure_filename
2024-03-15 14:17:23 +01:00
Sim4n6
342465057c
Add Unicode DoS (CWE-770)
2024-03-15 14:17:23 +01:00
Mathias Vorreiter Pedersen
19c9ea7e20
C++: Implement alias and side effect models for iterators.
2024-03-15 12:13:43 +00:00
Mathias Vorreiter Pedersen
a51fe4a00e
C++: Make the vector and iterator classes in 'ir.cpp' more realistic. This matches the one we use for dataflow tests.
2024-03-15 12:10:48 +00:00
Max Schaefer
d3e0a90ae5
Go: Mention raw string iterals in QHelp for go/incomplete-hostname-regexp.
2024-03-15 11:22:40 +00:00
Tom Hvitved
693c28a821
Merge pull request #15931 from hvitved/ql/remove-missing-override-query
...
QL4QL: Remove `MissingOverride` query
2024-03-15 11:28:41 +01:00
Owen Mansel-Chan
8e52483beb
Add df-manual models in manually modeled classes
2024-03-15 10:10:23 +00:00
Tom Hvitved
80649786c3
QL4QL: Remove MissingOverride query
2024-03-15 11:06:15 +01:00
Tom Hvitved
e7b00a7b42
Ruby: Add post-update argument nodes for string constants
2024-03-15 10:47:39 +01:00
Rasmus Wriedt Larsen
7eb4419342
Python: Restrict type-tracking content to only be precise
...
At least for now :)
2024-03-15 10:24:57 +01:00
Rasmus Wriedt Larsen
6babb2ff90
Python: Accept .expected for typetracking-summaries
2024-03-15 10:24:33 +01:00
Rasmus Wriedt Larsen
00f2a6a65e
Python: Update ssa-compute test expectations
2024-03-15 10:14:45 +01:00
Tony Torralba
171ff4d161
Merge pull request #15928 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-03-15 09:24:57 +01:00
Ed Minnix
71cf948650
Classes extending SourceNode for local and stored source models
...
Queries such as `cs/sql-injection` cast their source to a `SourceNode`
in order to describe them. For example:
```ql
import semmle.code.csharp.security.dataflow.flowsources.FlowSources
string getSourceType(DataFlow::Node source) {
result = source.(SourceNode).getSourceType()
}
```
Models as data source models are not included in `SourceNode` by
default, they must be wrapped with a class extending `SourceNode`.
This adds such classes, which wrap the
`sourceNode(DataFlow::Node,string)` predicate and assigns a
`getSourceType`.
2024-03-14 22:23:54 -04:00
github-actions[bot]
7f05743212
Add changed framework coverage reports
2024-03-15 00:16:16 +00:00
Joe Farebrother
f464f1b94e
Accept test output + fix qldoc typo
2024-03-14 22:25:37 +00:00
Joe Farebrother
b4ed77343b
Add change note + fix qldoc
2024-03-14 22:25:36 +00:00
Joe Farebrother
3e61be1b6a
Add test cases
2024-03-14 22:25:36 +00:00
Joe Farebrother
5333c75919
Model additional string attributes
2024-03-14 22:25:36 +00:00
Joe Farebrother
8c31b612ca
Model UploadedFile original_filename and read
2024-03-14 22:25:35 +00:00
Mathias Vorreiter Pedersen
6dddae0154
Merge pull request #15925 from MathiasVP/rename-dataflowutil-class
...
C++: Follow-up to #15918
2024-03-14 18:15:14 +00:00
Tony Torralba
ee3efbadae
Merge pull request #15924 from atorralba/atorralba/go/hardcoded-credentials-fix
...
Go: Consider more strings as hardcoded credentials
2024-03-14 16:52:34 +01:00
Tamás Vajk
945121de1b
Merge pull request #15922 from tamasvajk/buildless/namespace-extraction
...
C#: Handle namespace resolution error more gracefully
2024-03-14 16:19:48 +01:00
Michael Nebel
2280469564
Merge pull request #15902 from michaelnebel/csharp/uncontrolledformatstring
...
C#: Remove hard-coded local sources from the uncontrolled-format-string query.
2024-03-14 15:21:31 +01:00
Mathias Vorreiter Pedersen
7fdea27d33
C++: Rename 'IndirectTemporaryExpr' to 'IndirectOperandExprNode'.
2024-03-14 11:46:15 +00:00
Owen Mansel-Chan
2bd08838d4
Add manual neutral models for java.lang.ClassLoader
2024-03-14 11:40:06 +00:00
Owen Mansel-Chan
5b734c76b6
Add manual neutral models for java.util.Locale and its subclasses
2024-03-14 11:39:59 +00:00
Tony Torralba
20691e409c
Add change note
2024-03-14 11:56:43 +01:00
Mathias Vorreiter Pedersen
9aefdca7a7
Merge pull request #15875 from MathiasVP/bring-back-type-barriers-in-non-constant-format
...
C++: Clean up `cpp/non-constant-format`
2024-03-14 10:51:23 +00:00
Tony Torralba
30d906d42a
Merge pull request #15906 from atorralba/atorralba/java/jdk-neutrals
...
Java: Add more neutral JDK models
2024-03-14 11:07:06 +01:00
Geoffrey White
19cc620f18
C++: Effect of 'Fix dataflow node <> expression problem on prvalues' from main.
2024-03-14 09:47:38 +00:00
Rasmus Wriedt Larsen
7a3ee0f5f8
Python: Make IterableSequenceNode LocalSourceNode
...
We do this to remove the inconsistencies, and to be ready for a future
where type-tracking support content tracker of depth > 1.
It works because targets of loadSteps needs to be LocalSourceNodes
predicate loadStep(Node nodeFrom, LocalSourceNode nodeTo, Content content) {
2024-03-14 10:46:29 +01:00
Geoffrey White
f208594067
Merge branch 'main' into mad
2024-03-14 09:44:45 +00:00
Rasmus Wriedt Larsen
6ffaad1bc8
Python: Expand type-tracking tests with nested tuples
...
I was initially surprised to see that this didn't work, until I
remembered that type-tracking only works with content of depth 1.
2024-03-14 10:44:25 +01:00
Rasmus Wriedt Larsen
af8cef5b53
Python: Fixup deprecated type-tracker API
2024-03-14 10:43:28 +01:00
Rasmus Wriedt Larsen
2b09b084e0
Python: Add change-note
2024-03-14 10:43:28 +01:00
Rasmus Wriedt Larsen
7de304bf16
Python: Add proper type-tracking tests for content
...
Instead of just relying on the call-graph tests
2024-03-14 10:43:28 +01:00
Rasmus Wriedt Larsen
fa0c4e18fc
Python: Expand dict-content tt test even more
...
While it might be useful to track content to any lookup, it's not
something we do right now.
2024-03-14 10:43:28 +01:00
Rasmus Wriedt Larsen
4d78762ba8
Python: Ignore consistency failure
2024-03-14 10:43:28 +01:00
Rasmus Wriedt Larsen
8a7ffac19c
Python: Accept consistency failure
2024-03-14 10:43:28 +01:00
Rasmus Wriedt Larsen
92729dbbd6
Python: Support iterable unpacking in type-tracking
2024-03-14 10:42:38 +01:00
Rasmus Wriedt Larsen
0cf3fe4a4c
Python: Expand dict update tests
2024-03-14 10:42:38 +01:00
Rasmus Wriedt Larsen
dac2b57bb0
Python: type-track through dict-updates
2024-03-14 10:42:38 +01:00
Rasmus Wriedt Larsen
73fe596753
Python: type-tracking through dictionary construction
2024-03-14 10:42:38 +01:00
Rasmus Wriedt Larsen
ece8245a4b
Python: type-track through tuple content
2024-03-14 10:42:38 +01:00
Rasmus Wriedt Larsen
a95bb7c86b
Python: Expand function reference in content test
2024-03-14 10:42:38 +01:00
Rasmus Wriedt Larsen
7721fb3331
Python: Setup shared read/store steps
2024-03-14 10:42:37 +01:00
Rasmus Wriedt Larsen
636cf611ae
Python: Allow general content in type-tracker
...
This should not result in many changes, since store/load steps are still
only implemented for attributes.
2024-03-14 10:42:37 +01:00
Rasmus Wriedt Larsen
fc8caa66c8
Python: Prepare for general content in type-tracker
...
Due to the char-pred of Content, this change should keep exactly the
same behavior as before.
2024-03-14 10:42:37 +01:00
Mathias Vorreiter Pedersen
dacf7d73d9
Merge pull request #15918 from MathiasVP/fix-as-expr-for-temps
...
C++: Fix dataflow node <> expression problem on prvalues
2024-03-14 09:38:46 +00:00
Tony Torralba
87b2dcc892
Adjust test expectations
2024-03-14 10:25:04 +01:00
Mathias Vorreiter Pedersen
a24432bacc
Update cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll
2024-03-14 09:23:33 +00:00
Mathias Vorreiter Pedersen
c375497fa5
Update cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll
2024-03-14 09:16:04 +00:00
Tony Torralba
d8c0ab8e1f
Go: Consider more strings as hardcoded credentials
2024-03-14 10:11:39 +01:00
Tony Torralba
9d44045e6f
Adjust test expectations
2024-03-14 09:41:34 +01:00
Tony Torralba
eecab9122a
Recognize the model generator involvement in the models' provenances
2024-03-14 08:56:23 +01:00
Tony Torralba
5b88b8a3ed
A few more neutrals
2024-03-14 08:53:58 +01:00
Tony Torralba
36f6a6fb10
Model more EnumSet methods as neutrals
2024-03-14 08:46:43 +01:00
Tamas Vajk
b5f349bd2c
C#: Handle namespace resolution error more gracefully
2024-03-14 08:37:22 +01:00
Jeroen Ketema
b2e0485c94
Merge pull request #15908 from jketema/destructors12
...
C++: suppress destructors with reuse expressions until proper support is added
2024-03-14 07:41:59 +01:00
Mathias Vorreiter Pedersen
a839c92979
C++: Fix mapping issue between dataflow nodes and expressions when the expression is a prvalue.
2024-03-13 22:59:09 +00:00
Mathias Vorreiter Pedersen
2fc0922b29
Merge branch 'main' into bring-back-type-barriers-in-non-constant-format
2024-03-13 22:46:35 +00:00
Mathias Vorreiter Pedersen
d1c253b519
C++: Accept test changes.
2024-03-13 22:41:32 +00:00
Mathias Vorreiter Pedersen
61597f5ac7
C++: This commit does two things:
...
1. It fixes a logic error in the cannotContainString predicate.
2. It reverts the changes to the `isSource` predicate that required the external
function to be within the source root.
The change to `isSource` was meant to fix the a performance problem that occurred
because of the logic error in the cannotContainString predicate. However, now that
the logic error is fixed this is no longer necessary 🎉
2024-03-13 22:40:06 +00:00
erik-krogh
ef8368cfc4
fix typo
2024-03-13 22:37:13 +01:00
Jami Cogswell
1b01f26d09
Java: adjust BarrierPrefix to handle prepended chars
2024-03-13 16:28:45 -04:00
Jami Cogswell
5ac453eb38
Java: add spurious test case for StringBuilder.append
2024-03-13 16:28:45 -04:00
Jami Cogswell
04d27f2d65
Java: adjust prefix barriers
2024-03-13 16:28:44 -04:00
Jami Cogswell
e99cea340b
Java: update UrlPathBarrier to include FollowsBarrierPrefix
2024-03-13 16:28:44 -04:00
Jami Cogswell
c5a59d6c51
Java: add QLDoc
2024-03-13 16:28:44 -04:00
Jami Cogswell
7310c155e2
Java: rename SpringUrlForwardSink
2024-03-13 16:28:44 -04:00
Jami Cogswell
a002674587
Java: clean up comments on test cases
2024-03-13 16:28:44 -04:00
Jami Cogswell
a8075969d8
Java: add QLDocs to UrlPathBarrier code
2024-03-13 16:28:44 -04:00
Jami Cogswell
042dcf9cd9
Java: some updates to UrlPathBarrier code
2024-03-13 16:28:44 -04:00
Jami Cogswell
052452b186
Java: create UrlDecodeMethod
2024-03-13 16:28:44 -04:00
Jami Cogswell
d220b3a298
Java: some updates to test cases
2024-03-13 16:28:43 -04:00
Jami Cogswell
d9772c1880
Java: update change note
2024-03-13 16:28:43 -04:00
Jami Cogswell
43b49628fc
Java: use new 'SimpleTypeSanitizer', and update some non-extending subtype relationships
2024-03-13 16:28:43 -04:00
Jami Cogswell
2708e53c7f
Java: remove redundant imports
2024-03-13 16:28:43 -04:00
Jami Cogswell
f573032b2e
Java: remove todo comments from ext files
2024-03-13 16:28:43 -04:00
Jami Cogswell
911a61df22
Java: initial update of barrier and test cases to remove FN
2024-03-13 16:28:42 -04:00
Jami Cogswell
c8ec301793
Java: add change note
2024-03-13 16:28:42 -04:00
Jami Cogswell
e75c96c0f9
Java: combine test cases; add test for StaplerResponse.forward
2024-03-13 16:28:41 -04:00
Jami Cogswell
5fa63ab5c2
Java: update/add some TODO comments
2024-03-13 16:28:41 -04:00
Jami Cogswell
c331393cfd
Java: update qhelp
2024-03-13 16:28:41 -04:00
Jami Cogswell
09bc21dbd3
Java: rename 'UnsafeUrlForward' to 'UrlForward'
2024-03-13 16:28:41 -04:00
Jami Cogswell
6e7c05467b
Java: update query metadata and alert message
2024-03-13 16:28:41 -04:00
Jami Cogswell
5a9d7552b3
Java: add some comments and minor code reorg
2024-03-13 16:28:41 -04:00
Jami Cogswell
1da1e896cb
Java: convert SpringModelAndViewSink to MaD
2024-03-13 16:28:41 -04:00
Jami Cogswell
8d66097483
Java: switch StaplerResponse.forward from request-forgery sink to url-forward sink
2024-03-13 16:28:41 -04:00
Jami Cogswell
42e3825ea3
Java: convert RequestDispatcherSink to MaD
2024-03-13 16:28:40 -04:00
Jami Cogswell
4ff884e26c
Java: remove more path-injection related classes (will maybe add some of these back in a separate PR)
2024-03-13 16:28:40 -04:00
Jami Cogswell
2a682995ae
Java: move MaD models to correct files, delete ones that already exist
2024-03-13 16:28:40 -04:00
Jami Cogswell
915e106ab3
Java: remove path-injection related models and tests for now
2024-03-13 16:28:40 -04:00
Jami Cogswell
35a083ae9e
Java: update test cases to use inline expectations
2024-03-13 16:28:40 -04:00
Jami Cogswell
2793f28428
Java: move config to Query.qll file
2024-03-13 16:28:40 -04:00
Jami Cogswell
0d38a9625e
Java: copy files from experimental
2024-03-13 16:28:39 -04:00
Jeroen Ketema
866a3934d4
C++: suppress destructors with reuse expressions until proper support is added
2024-03-13 20:17:00 +01:00
Tom Hvitved
54fa8181da
Address review comment
2024-03-13 20:03:01 +01:00
Jeroen Ketema
67b3670d06
Merge pull request #15901 from jketema/destructors11
...
C++: Introduce re-use expressions in the database scheme
2024-03-13 18:27:28 +01:00
Geoffrey White
8d3fc735ea
C++: Fix compilation issue in UseAfterFree.qll.
2024-03-13 17:03:00 +00:00
Geoffrey White
f52b6e0449
C++: Add more test cases for taint through qualifier fields.
2024-03-13 16:20:12 +00:00
Geoffrey White
6019a38266
C++: Add more test cases for indirection (4).
2024-03-13 16:20:08 +00:00
Geoffrey White
23da0c16c7
C++: Add more test cases for indirection (3).
2024-03-13 16:20:04 +00:00
Geoffrey White
7c4927c2e3
C++: Add more test cases for indirection (2).
2024-03-13 16:19:58 +00:00
Tony Torralba
039bea1625
Java: Add more neutral JDK models
...
This is similar to https://github.com/github/codeql/pull/15766 , in the sense that it adds neutral models to prevent the model generator from generating summaries for them. These models were spotted while evaluating https://github.com/github/codeql/pull/14919 .
2024-03-13 16:59:38 +01:00
Geoffrey White
fcda0c9819
C++: Add more test cases for indirection (1).
2024-03-13 15:35:28 +00:00
Geoffrey White
c17a36ec07
C++: Add more test cases for taint through qualifiers.
2024-03-13 15:30:13 +00:00
Mathias Vorreiter Pedersen
b638d4d0ba
Merge pull request #15900 from MathiasVP/glib-alloc-and-dealloc
...
C++: Add models for `GLib` allocation and deallocation
2024-03-13 15:29:46 +00:00
Geoffrey White
92d57ab504
C++: Correct some existing cases that are in fact indirect.
2024-03-13 15:26:21 +00:00
Erik Krogh Kristensen
bd121b98ae
Merge pull request #15893 from erik-krogh/more-filter-taint
...
JS: allow more flow through .filter()
2024-03-13 16:19:28 +01:00
Rasmus Lerchedahl Petersen
533b63743b
Python: test MaD syntax for keyword argument
...
use the combined positional/keyword syntax as
that is what we will probably mostly use.
2024-03-13 15:28:34 +01:00
Tom Hvitved
6c0ed28e6b
Python: Implement new data flow interface
2024-03-13 14:41:57 +01:00
Tom Hvitved
02ae2d1520
Java: Implement new data flow interface
2024-03-13 14:41:57 +01:00
Tom Hvitved
e4a4c18166
Go: Implement new data flow interface
2024-03-13 14:41:57 +01:00
Michael Nebel
560b355e0c
C#: Remove hard-coded local sources from the uncontrolled-format-string query.
2024-03-13 14:26:30 +01:00
Erik Krogh Kristensen
53502a8662
Merge pull request #15510 from yoff/ts-54
...
JS: Add support for TS 5.4
2024-03-13 14:22:24 +01:00
Jeroen Ketema
8d5eab401d
C++: Introduce re-use expressions in the database scheme
2024-03-13 13:28:27 +01:00
Tom Hvitved
16cef92106
JS: Add DataFlow::Node.getLocation
2024-03-13 13:06:16 +01:00
Mathias Vorreiter Pedersen
8d504d8b32
Merge pull request #15899 from jketema/destructors10
...
C++: Add IR tests for the destruction of temporaries
2024-03-13 11:56:04 +00:00
Mathias Vorreiter Pedersen
465c3c18e3
C++: Add change note.
2024-03-13 11:49:26 +00:00
Asger F
c5a02dae2b
Merge pull request #15768 from asgerf/js/amd-pseudo-deps
...
JS: Do not treat AMD pseudo-dependencies as imports
2024-03-13 12:49:17 +01:00
Mathias Vorreiter Pedersen
3ea39a2553
C++: Add some query tests.
2024-03-13 11:39:34 +00:00
Mathias Vorreiter Pedersen
bcd36b1994
C++: Recognize glib allocations and deallocations.
2024-03-13 11:39:15 +00:00
Geoffrey White
9aad43f649
C++: Add indirect test models.
2024-03-13 11:34:36 +00:00
Ian Lynagh
adefdfd59f
Merge pull request #15889 from igfoo/igfoo/k2exprs
...
Kotlin 2: Accept more changes in the exprs test
2024-03-13 11:34:10 +00:00
erik-krogh
129286aa1c
allow more flow through .filter()
2024-03-13 12:03:00 +01:00
Jeroen Ketema
3ef1ab49ea
C++: Add IR tests for the destruction of temporaries
2024-03-13 12:00:02 +01:00
erik-krogh
013ed7adb3
Java: update the url-redirection in the same style as the C# qhelp
2024-03-13 11:58:16 +01:00
yoff
b5c0fbb827
Merge pull request #15776 from RasmusWL/tt-consistency
...
Python: Add type-tracking consistency query
2024-03-13 11:11:07 +01:00
Tom Hvitved
4085c8ec8f
Merge pull request #15866 from hvitved/ruby/orm-tracking-ap-limit
...
Ruby: Lower access path limit to 1 for `OrmTracking`
2024-03-13 10:57:09 +01:00
Harry Maclean
806f42ef72
Ruby: Update change note
2024-03-13 09:54:17 +00:00
Harry Maclean
dd5eb982ec
Merge pull request #15524 from hmac/hmac-process-spawn
...
Ruby: Add some more command injection sinks
2024-03-13 09:53:10 +00:00
Tony Torralba
2fd2b4c874
Merge pull request #15891 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-03-13 09:51:22 +01:00
github-actions[bot]
cff2cdb9e4
Add changed framework coverage reports
2024-03-13 00:15:53 +00:00
Edward Minnix III
c190dd21db
Merge pull request #15877 from egregius313/egregius313/csharp/mad/sources/windows-registry
...
C#: Add source models for values from the Windows registry
2024-03-12 16:41:42 -04:00
Edward Minnix III
d54489931c
Merge pull request #15869 from egregius313/egregius313/java/fix/parcelfiledescriptor-open-sink
...
Java: Add path-injection sink for `ParcelFileDescriptor::open`
2024-03-12 16:39:20 -04:00
intrigus-lgtm
f70a39e72f
[cpp-docs] Fix 404 link in guards library doc.
2024-03-12 19:59:26 +01:00
Erik Krogh Kristensen
863e3f79e5
Merge pull request #15731 from erik-krogh/java-url
...
Java: More sanitizers for request-forgery
2024-03-12 19:31:52 +01:00
Geoffrey White
cbacd51337
C++: Make Argument[-1] refer to *this rather than this.
2024-03-12 17:51:43 +00:00
Geoffrey White
22d5e9bbfb
C++: Add test cases involving pointer qualifiers.
2024-03-12 17:47:11 +00:00
Ian Lynagh
0e94aa0eb5
Kotlin 2: Accept more changes in the exprs test
2024-03-12 16:42:37 +00:00
Ian Lynagh
8d1ee10981
Merge pull request #15876 from igfoo/igfoo/buildless-java-complete
...
Java: Accept test changes
2024-03-12 16:12:58 +00:00
Tamás Vajk
be2ce17376
Merge pull request #15881 from tamasvajk/buildless/fix-fallback
...
C#: Deduplicate not yet restored package names
2024-03-12 16:08:16 +01:00
Mathias Vorreiter Pedersen
ab6e2f9364
C++: Accept test regression.
2024-03-12 15:04:49 +00:00
erik-krogh
f613823047
add explicit QLDoc that any method named "contains" is matched
2024-03-12 15:25:27 +01:00
Geoffrey White
900c8b71d8
C++: Complete the SummaryCall class.
2024-03-12 14:23:00 +00:00
erik-krogh
35aae0a981
move changenote to src/
2024-03-12 15:22:57 +01:00
Erik Krogh Kristensen
b53ae77c56
expand change-note
...
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2024-03-12 15:22:17 +01:00
Mathias Vorreiter Pedersen
51f5740707
C++: Exclude functions that aren't declared inside the source root. This fixes performance on ImageMagick.
2024-03-12 14:20:16 +00:00
Mathias Vorreiter Pedersen
6a563c161e
C++: Simplify the definition of 'isNonConst'. On ImageMagick I get the same exact sources before and after.
2024-03-12 14:20:09 +00:00
Mathias Vorreiter Pedersen
179a7d500e
C++: Handle 'wchar_t' types that may be defined as unsigned short in C. This brings back SAMATE results.
2024-03-12 14:19:48 +00:00
Geoffrey White
a27949cffa
C++: Set certain = true in storeStepImpl.
2024-03-12 14:08:20 +00:00
Tamas Vajk
b07b0762f2
Adjust based on code review feedback
2024-03-12 15:07:58 +01:00
erik-krogh
74876ff49b
add change-note
2024-03-12 15:07:36 +01:00
erik-krogh
52f71e4553
small fixes based on review
2024-03-12 15:07:29 +01:00
Ian Lynagh
c2aa334465
Java: Accept test changes
2024-03-12 14:03:02 +00:00
Tom Hvitved
695e728ed5
Ruby: Lower access path limit to 1 for OrmTracking
2024-03-12 14:58:29 +01:00
Tom Hvitved
dddba3228b
Merge pull request #15867 from hvitved/dataflow/ap-limit
...
Data flow: Add `ConfigSig::accessPathLimit`
2024-03-12 14:57:51 +01:00
erik-krogh
6be0ed1dc3
narrow the version specifier used for TypeScript
2024-03-12 13:42:58 +01:00
Tom Hvitved
d7790faece
Address review comments
2024-03-12 13:34:55 +01:00
erik-krogh
95a5ec7f27
add test that the new Object.groupBy method has a type
2024-03-12 13:22:11 +01:00
Owen Mansel-Chan
33c17313b4
Add test for not extracting values for intermediate string concatenations
2024-03-12 11:59:10 +00:00
Michael Nebel
50851210ea
Merge pull request #15794 from michaelnebel/csharp/removecil
...
C#: Delete the CIL extractor.
2024-03-12 12:48:41 +01:00
Mathias Vorreiter Pedersen
1a42e55095
Merge pull request #15820 from MathiasVP/add-type-confusion-query
...
C++: Add a new query for detecting type confusion vulnerabilities
2024-03-12 10:29:22 +00:00
Tom Hvitved
0e0b73a5e6
Address review comment
2024-03-12 11:22:04 +01:00
Michael Nebel
eb62c033aa
C#: Remove the cil extractor option.
2024-03-12 11:12:56 +01:00
Michael Nebel
f59aaf1d75
C#: Add change note.
2024-03-12 11:12:55 +01:00
Michael Nebel
2e5155d1f8
C#: Remove all CIL related tests.
2024-03-12 11:12:55 +01:00
Michael Nebel
af06202241
C#: Cleanup implementation.
2024-03-12 11:12:55 +01:00
Michael Nebel
bf27f203d5
C#: Remove CIL extractor projects.
2024-03-12 11:12:55 +01:00
Tamas Vajk
1633673cc2
C#: Deduplicate not yet restored package names
2024-03-12 09:22:38 +01:00
Kevin Stubbings
5acc15bfff
fix grammar
2024-03-11 20:13:08 -07:00
Kevin Stubbings
30fe4168e3
Removed filepath.base sanitizer
2024-03-11 15:08:10 -07:00
Angela P Wen
ca12348ecb
Merge pull request #15880 from github/sitedocs/2.16.4-2
...
Add changelog for 2.16.4
2024-03-11 14:59:53 -07:00
Kevin Stubbings
c4c0b22bc7
Formattinga and change notes
2024-03-11 14:54:30 -07:00
Kevin Stubbings
c9b49d3760
resolve feedback
2024-03-11 14:54:28 -07:00
Kevin Stubbings
530c76ca8b
Add New Sanitizers and Modify Old Ones
2024-03-11 14:53:29 -07:00
Pierre
d1f8336be6
Add changelog for 2.16.4
2024-03-11 22:21:25 +01:00
Ed Minnix
7745c2c2b7
Change note
2024-03-11 17:00:12 -04:00
Tom Hvitved
8d767862dc
Swift: Implement new data flow interface
2024-03-11 20:56:38 +01:00
Tom Hvitved
1c57e99686
C++: Implement new data flow interface
2024-03-11 20:56:38 +01:00
Tom Hvitved
257686eb9a
C#: Implement new data flow interface
2024-03-11 20:56:38 +01:00
Tom Hvitved
4291290277
Ruby: Implement new data flow interface
2024-03-11 20:56:38 +01:00
Tom Hvitved
e82e3180f0
Data flow: Replace hasLocationInfo with getLocation
2024-03-11 20:56:38 +01:00
Mathias Vorreiter Pedersen
9854ed4b89
C++: Delete comment.
2024-03-11 18:54:53 +00:00
Mathias Vorreiter Pedersen
2345907a52
C++: Reintroduce the 'cannotContainString' optimization that was removed in #15516 .
2024-03-11 18:49:03 +00:00
Mathias Vorreiter Pedersen
f97b6e2848
C++: Stop conflating pointers and indirections in the query.
2024-03-11 18:48:19 +00:00
Mathias Vorreiter Pedersen
32e532ff3c
C++: Some cleanup to avoid conflating the case of a function returning something as a return value, and a function updating one of its arguments.
2024-03-11 18:42:42 +00:00
Ed Minnix
bc745dfd5e
Windows registry sources
2024-03-11 13:55:34 -04:00
erik-krogh
9f410eb2d6
Merge branch 'main' into ts-54
2024-03-11 18:07:52 +01:00
Joe Farebrother
9c51514bd9
Merge pull request #15857 from joefarebrother/ruby-activerecord-from
...
Ruby: Model second argument of `ActiveRecord` `from`
2024-03-11 16:49:52 +00:00
Henry Mercer
c325ff8a23
Mark lines of code queries as telemetry queries
...
The new file coverage metrics are available in all supported GHES
versions. This PR tags lines of code queries as telemetry queries. Lines
of code information will still be available in the SARIF file, but it
will no longer be displayed in the logging output of the CLI.
The one exception is the metric queries for Java/Kotlin that provides
separate lines of code information for Java and Kotlin. I've kept these
since separate file coverage information for languages like Java and
Kotlin is only available for GHES 3.12 and later.
2024-03-11 16:40:31 +00:00
Rasmus Lerchedahl Petersen
d73f43477f
update ts to released version 54
2024-03-11 16:32:19 +01:00
Tony Torralba
04436208ab
Merge pull request #15843 from atorralba/atorralba/go/uncontrolled-allocation-size
...
Go: Promote `go/uncontrolled-allocation-size` from experimental
2024-03-11 16:12:27 +01:00
Michael Nebel
5749fdbc46
Merge pull request #15868 from michaelnebel/csharp/csharp12releasenote
...
C#: Overall change note for C# 12 / .NET 8 support.
2024-03-11 16:08:24 +01:00
Tony Torralba
ff2d78d2c8
Update go/ql/src/Security/CWE-770/UncontrolledAllocationSize.ql
2024-03-11 15:53:40 +01:00
Ed Minnix
76aeee2820
Change note
2024-03-11 10:34:15 -04:00
Ed Minnix
61dbe26858
Add sinks for android.os.ParcelFileDescriptor
2024-03-11 10:31:51 -04:00
Mathias Vorreiter Pedersen
7b0df57d7a
C++: Remove the two configurations that depend on flow state to speed up performance on ChakraCore.
2024-03-11 13:56:22 +00:00
Michael Nebel
f571ebdaf4
C#: Overall change note for C# 12 / .NET 8 support.
2024-03-11 14:43:14 +01:00
Rasmus Wriedt Larsen
800351c7b7
Merge branch 'main' into tt-consistency
2024-03-11 14:12:09 +01:00
yoff
e6e6a4e9c8
Merge pull request #15841 from RasmusWL/missing-use-use2
...
Python: Add example of missing use-use flow
2024-03-11 13:59:57 +01:00
yoff
adbcbefaa9
Merge pull request #15551 from yoff/python/avoid-duplicate-model-inclusions
...
python: Remove `TaintStepFromSummary`
2024-03-11 13:52:20 +01:00
Geoffrey White
026a13b4db
C++: Change Node/Node0.getEnclosingCallable back to returning Declaration.
2024-03-11 12:22:55 +00:00
Tom Hvitved
da66281fef
Sync files
2024-03-11 13:02:04 +01:00
Tom Hvitved
7a39f077d9
Data flow: Add ConfigSig::accessPathLimit
2024-03-11 13:01:58 +01:00
Rasmus Wriedt Larsen
4ac8dd72a7
Merge pull request #15855 from yoff/python/add-MaD-test-tuple-output
...
Python: Add test for `ReturnValue.TupleElement[n]`
2024-03-11 12:05:31 +01:00
Owen Mansel-Chan
da8cc13506
go extractor: avoid long string concatenations
...
When we see "a" + "b" + "c" + "d", do not add a
row to the constvalues table for the intermiediate
strings "ab" and "abc". We still have entries for
the string literals ("a", "b", "c", and "d") and
the whole string concatenation ("abcd").
2024-03-11 10:53:26 +00:00
Mathias Vorreiter Pedersen
73c4fe08fa
Merge pull request #15835 from MathiasVP/initial-def-of-addresses
...
C++: Provide an initial SSA definition of the address of a variable
2024-03-11 10:42:01 +00:00
Geoffrey White
4bc272da73
C++: Doc correction and TODOs for interpretOutput, interpretInput.
2024-03-11 10:16:46 +00:00
Erik Krogh Kristensen
00c228540e
Merge pull request #15836 from github/dependabot/cargo/ql/chrono-0.4.35
...
Bump chrono from 0.4.34 to 0.4.35 in /ql
2024-03-11 11:13:15 +01:00
Tamás Vajk
35a8e7cbf0
Merge pull request #15854 from tamasvajk/buildless/change-assembly-id
...
C#: Change ID of buildless output assembly
2024-03-11 10:03:40 +01:00
Rasmus Wriedt Larsen
42acd9c22c
Merge pull request #15695 from github/tausbn/python-add-copy-method-as-copy-step
...
Python: Add `.copy()` method call as copy step
2024-03-11 09:43:34 +01:00
Michael Nebel
6485dcc0fc
Merge pull request #15859 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-03-11 09:10:52 +01:00
Tony Torralba
a09eb9f4c5
Update go/ql/src/Security/CWE-770/UncontrolledAllocationSize.ql
...
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com >
2024-03-11 08:58:59 +01:00
Edward Minnix III
7fe378e831
Merge pull request #15756 from egregius313/egregius313/csharp/dataflow/threat-model/remove-addlocalsource
...
C#: Remove `AddLocalSource` classes from queries
2024-03-10 22:56:28 -04:00
Ed Minnix
3fdc7e95df
Add local models to CodeInjection tests
2024-03-10 22:20:54 -04:00
Ed Minnix
8187b00562
Change note
2024-03-10 22:20:52 -04:00
Ed Minnix
d300736c7e
Remove AddLocalSource classes
2024-03-10 22:20:51 -04:00
Edward Minnix III
58f2777532
Merge pull request #15629 from egregius313/egregius313/csharp/dataflow/threat-modeling/remove-stored-query-variants
...
C#: Remove `Stored` variants of queries
2024-03-10 22:17:03 -04:00
github-actions[bot]
589a34241c
Add changed framework coverage reports
2024-03-11 00:16:32 +00:00
Owen Mansel-Chan
820c14577a
Merge pull request #13553 from am0o0/amammad-go-bombs
...
Go: Decompression Bombs
2024-03-10 13:48:04 +00:00
Edward Minnix III
e7852f520f
Merge pull request #15605 from egregius313/egregius313/csharp/dataflow/sources/commandargs-and-environment
...
C#: Add more `environment` and `commandargs` sources for the C# Standard Library
2024-03-08 14:10:09 -05:00
Geoffrey White
e8d0f1fa3e
C++: Comments.
2024-03-08 18:25:01 +00:00
Edward Minnix III
5440dbf70d
Merge pull request #15758 from egregius313/egregius313/csharp/docs/threat-modeling-in-mad-docs
...
C#: Add references to threat modeling to C# Models-as-Data documentation
2024-03-08 11:50:51 -05:00
am0o0
43df6a2c07
add comments for already implemented io.Read and io.WriteTo Sinks.
...
remove some sinks about `"decompressor"` which was added wrongly.
change `GeneralReadIoSink` type from module to class.
separate `KlauspostGzipAndPgzip` `KlauspostPgzip` and `KlauspostGzip`.
2024-03-08 20:05:46 +04:00
am0o0
66130d208e
convert abstract predicate isAdditionalFlowStep to non-abstract
2024-03-08 19:30:41 +04:00
Joe Farebrother
dbd33d1cf0
Model Argument[1] of ActiveRecord from
2024-03-08 14:04:01 +00:00
Tamas Vajk
9b5cfc9026
Change assembly population in buildless
2024-03-08 15:02:30 +01:00
Rasmus Lerchedahl Petersen
3601773856
python: support encoding lower bound
2024-03-08 14:59:28 +01:00
Rasmus Wriedt Larsen
adf5a4b1e4
Python: Fix internal consistency failures
2024-03-08 14:13:47 +01:00
Tom Hvitved
9ee2314ef6
Merge pull request #15847 from hvitved/ruby/orm-field-as-source-no-args
...
Ruby: Exclude calls with arguments from `OrmFieldAsSource`
2024-03-08 13:52:34 +01:00
Asger F
7c35309732
Merge pull request #15823 from asgerf/js/lift-cg-restriction
...
JS: Call graph improvements
2024-03-08 13:40:38 +01:00
Rasmus Wriedt Larsen
87b6592dbc
Python: Accept inconsistency for missing use-use flow
...
At least until we have a proper fix
2024-03-08 13:34:26 +01:00
Rasmus Wriedt Larsen
8fe483d9d8
Python: Add example of missing use-use flow
...
(see PR for more detailed description)
2024-03-08 13:26:01 +01:00
Asger F
245cd5c0b5
Merge pull request #15760 from asgerf/js/summarised-tt-store-steps
...
JS: Summarise store steps for type tracking
2024-03-08 13:16:25 +01:00
Asger F
ac4601cb8f
Update javascript/ql/lib/semmle/javascript/dataflow/internal/CallGraphs.qll
...
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com >
2024-03-08 13:01:38 +01:00
Ian Lynagh
a9bab18804
Merge pull request #15848 from igfoo/igfoo/deleg2
...
Kotlin 2: Accept some more loc changes in exprs test
2024-03-08 11:49:11 +00:00
Michael Nebel
36a775502f
Merge pull request #15851 from microsoft/54-csharp-add-missing-mad-for-httprequestmessage-upstream
...
csharp update MaD for HttpRequestMessage
2024-03-08 12:39:08 +01:00
Michael Nebel
7c46e9fcf4
Merge pull request #15838 from michaelnebel/csharp/deleteirqueries
...
C#: Remove IR queries.
2024-03-08 11:29:23 +01:00
Tamas Vajk
33eb69164c
C#: Change ID of buildless output assembly
2024-03-08 11:20:04 +01:00
Rasmus Lerchedahl Petersen
6d8d106d91
Python: add test for ReturnValue.TupleElement[n]
2024-03-08 11:18:51 +01:00
Asger F
546b0a9a89
Merge pull request #15763 from asgerf/js/escaping-instance-detection
...
JS: Improve detection of classes with escaping instances
2024-03-08 11:13:50 +01:00
Asger F
fc5b9e2796
JS: Expand test case
2024-03-08 10:34:39 +01:00
Tom Hvitved
24e35f6f3d
Update expected test output
2024-03-08 10:00:43 +01:00
Tom Hvitved
63bb772ef9
Variable capture: Avoid overlapping and false-positive data flow paths
2024-03-08 10:00:42 +01:00
Tom Hvitved
e793a1e9fe
Ruby: Add variable capture spurious flow test
2024-03-08 10:00:42 +01:00
Tom Hvitved
2896bfbd9f
Merge pull request #15821 from hvitved/dataflow/clears-content-store
...
Data flow: Allow for direct stores into nodes with `clearsContent`
2024-03-08 09:59:29 +01:00
Ed Minnix
7f950d8e0d
Fix ExpandEnvironmentVariables test case
2024-03-07 21:48:05 -05:00
Lindsay Simpkins
7dd175d938
change note
2024-03-07 17:16:17 -08:00
Mathias Vorreiter Pedersen
761f6d3a7e
C++: Disable field flow from the 'cpp/type-confusion' query to fix performance on ChakraCore.
2024-03-07 15:24:04 -08:00
Lindsay Simpkins
feb1ca29cc
csharp update MaD for HttpRequestMessage
2024-03-07 15:00:05 -08:00
Chris Smowton
e4f680d476
Merge pull request #15778 from smowton/smowton/admin/test-multi-release-jars
...
Java: Add tests for multi-release jars under Java 11 and 17
2024-03-07 22:59:35 +00:00
Mathias Vorreiter Pedersen
a548316747
C++: Accept test changes.
2024-03-07 13:55:31 -08:00
Mathias Vorreiter Pedersen
4f9bdca4f0
C++: Optimize.
2024-03-07 13:08:26 -08:00
Chris Smowton
2321eecb9e
Add tests for multi-release jars under Java 11 and 17
2024-03-07 21:07:49 +00:00
Mathias Vorreiter Pedersen
cedbfbe7ea
C++: Use a more generous definition of compatible types.
2024-03-07 10:50:20 -08:00
Ian Lynagh
e74606eba3
Kotlin 2: Accept some more loc changes
2024-03-07 18:40:59 +00:00
Ian Lynagh
79c5ad93b0
Kotlin 2: Accept a loc change
...
This is a bit of an odd location for the IrVariableImpl as it includes a
comment, but the comment is already included in the corrresponding
IrLocalDelegatedPropertyImpl so it's not clearly wrong:
Element: 16 59 (2:4 - 2:47) class org.jetbrains.kotlin.ir.declarations.impl.IrLocalDelegatedPropertyImpl
-Element: 29 42 (2:17 - 2:30) class org.jetbrains.kotlin.ir.declarations.impl.IrVariableImpl
+Element: 16 59 (2:4 - 2:47) class org.jetbrains.kotlin.ir.declarations.impl.IrVariableImpl
So just accept the change.
2024-03-07 18:37:00 +00:00
Michael Nebel
f2e467d8ea
C#: Cleanup identical-files.
2024-03-07 19:22:47 +01:00
Michael Nebel
5b48bc4a3e
C#: Delete the experimental IR queries.
2024-03-07 19:22:47 +01:00
Michael Nebel
48fcec82d6
Merge pull request #15736 from michaelnebel/csharp/disconnectfromdotnet
...
C#: Deprecate dotnet and CIL in QL.
2024-03-07 19:17:05 +01:00
Ed Minnix
608a3f907c
Add type signature for methods with no overloads
2024-03-07 12:32:06 -05:00
Ed Minnix
1f64f5f8c9
Change note
2024-03-07 12:32:05 -05:00
Ed Minnix
f8c805de6b
Microsoft.Extensions.Configuration models
2024-03-07 12:32:04 -05:00
Ed Minnix
ec6e17360d
Replace Main-method parameters with ThreatModelFlowSource
2024-03-07 12:30:08 -05:00
Ed Minnix
a3f6bfe1df
commandargs sources
2024-03-07 12:30:06 -05:00
Ed Minnix
51afe12ae1
Environment variable sources
2024-03-07 12:20:48 -05:00
Ed Minnix
b0eb0e1f1e
Move common source kinds to "shared"
2024-03-07 12:20:45 -05:00
Tom Hvitved
85782ff1d4
Ruby: Exclude calls with arguments from OrmFieldAsSource
2024-03-07 17:34:01 +01:00
Mathias Vorreiter Pedersen
9e77b89885
Update TypeConfusion.qhelp
...
Co-authored-by: hubwriter <hubwriter@github.com >
2024-03-07 08:33:49 -08:00
Tamás Vajk
1fa151db7c
Merge pull request #15844 from tamasvajk/buildless/sdk-version-parsing
...
C#: Improve `global.json` file parsing
2024-03-07 17:03:12 +01:00
Tom Hvitved
76564edc93
Address review comment
2024-03-07 16:50:28 +01:00
Edward Minnix III
92b086d36f
Merge pull request #15798 from egregius313/egregius313/csharp/mad/fix-textreader-models
...
C#: Change `System.IO.TextReader` models to transfer taint to out parameter
2024-03-07 10:40:28 -05:00
Chris Smowton
c9474050c8
Merge pull request #15839 from smowton/smowton/admin/jdk22-extractor-upgrade-test-changes
...
Java: Explicitly import Lock class
2024-03-07 15:05:50 +00:00
Tamas Vajk
ea38bf5ebc
C#: Improve global.json file parsing
2024-03-07 15:35:10 +01:00
Tony Torralba
138ce42cf6
Fix qhelp
2024-03-07 15:22:46 +01:00
Tony Torralba
7d74125508
Go: Promote go/uncontrolled-allocation-size
2024-03-07 15:17:49 +01:00
Taus
5202792163
Merge pull request #15754 from github/tausbn/python-copy-extractor-to-external-repo
...
Python: Copy Python extractor to `codeql` repo
2024-03-07 15:15:28 +01:00
Geoffrey White
b71b43a2fb
Merge pull request #15705 from geoffw0/qldoc3
...
Shared: Fill some QLDoc holes
2024-03-07 14:12:51 +00:00
Taus
4b0689b6ba
Python: Add warnOnImplicitThis: true to qlpack.yml
2024-03-07 13:59:16 +00:00
Taus
6dec323cfc
Python: Copy Python extractor to codeql repo
2024-03-07 13:59:16 +00:00
Rasmus Wriedt Larsen
4dd8f6e618
Python: Add example of missing use-use flow
...
(see PR for more detailed description)
2024-03-07 14:25:55 +01:00
Asger F
81b04863b2
JS: Change note
2024-03-07 13:35:50 +01:00
Tom Hvitved
22b168beee
Data flow: Allow for direct stores into nodes with clearsContent
2024-03-07 12:47:12 +01:00
Ian Lynagh
67612e60b5
Merge pull request #15829 from igfoo/igfoo/expr-del-2
...
Kotlin 2: Accept more loc changes in exprs test
2024-03-07 11:18:03 +00:00
Ian Lynagh
7bbc18f114
Merge pull request #15799 from igfoo/igfoo/kotlin-upper-bound
...
Kotlin: Docs: Give upper bound as 1.9.2x rather than 1.9.20
2024-03-07 11:17:51 +00:00
Asger F
c7295a09cd
JS: Benign test output update
2024-03-07 11:55:56 +01:00
Anders Schack-Mulligen
f3a381f10d
Merge pull request #15822 from aschackmull/dataflow/perf-fixes
...
Dataflow: Misc performance fixes
2024-03-07 11:47:36 +01:00
Chris Smowton
dae20ca50c
Explicitly import Lock
2024-03-07 09:54:17 +00:00
Tamás Vajk
6d5fd3c9de
Merge pull request #15827 from tamasvajk/buildless/impr-progress-reporting
...
C#: Improve buildless progress reporting
2024-03-07 10:00:06 +01:00
Michael Nebel
73040bd30f
C#: Use fully qualified name with types instead of label in IR queries.
2024-03-07 09:40:34 +01:00
Michael Nebel
990dec67d0
C#: Address more review comments.
2024-03-07 09:40:34 +01:00
Michael Nebel
43ee62ad64
C#: Update the NoDisposeCallOnLocalIDisposable and expected output.
2024-03-07 09:40:34 +01:00
Michael Nebel
eda345a5b8
C#: Address review comments.
2024-03-07 09:40:34 +01:00
Michael Nebel
e3380aa545
C#: Add change note.
2024-03-07 09:40:34 +01:00
Michael Nebel
7f6c84dda8
C#: Fix bad join order.
2024-03-07 09:40:34 +01:00
Michael Nebel
35b93063f9
C#: Deprecate dotnet and cil.
2024-03-07 09:40:34 +01:00
Michael Nebel
16375b0fe7
C#: Remove CIL dataflow tests.
2024-03-07 09:40:34 +01:00
Michael Nebel
37677142b9
C#: Update QL tests.
2024-03-07 09:40:33 +01:00
Michael Nebel
58a1353ddc
C#: Clean up implementation and remove CIL dataflow implementation.
2024-03-07 09:40:33 +01:00
Michael Nebel
1638183d18
C#: Copy dotnet.Variable implementation.
2024-03-07 09:40:33 +01:00
Michael Nebel
6178acc070
C#: Copy dotnet.Type implementation.
2024-03-07 09:40:33 +01:00
Michael Nebel
81ce8dc02d
C#: Copy dotnet.Parameterizable implementation.
2024-03-07 09:40:33 +01:00
Michael Nebel
92447dc743
C#: Copy dotnet.Namespace implementation.
2024-03-07 09:40:33 +01:00
Michael Nebel
7ba25b23a5
C#: Copy dotnet.Generics implementation.
2024-03-07 09:40:33 +01:00
Michael Nebel
eb5cb2a7bf
C#: Copy dotnet.Expr implementation.
2024-03-07 09:40:33 +01:00
Michael Nebel
215808d7e9
C#: Copy dotnet.Declaration implementation.
2024-03-07 09:40:33 +01:00
Michael Nebel
cdf3d47031
C#: Copy dotnet.Element implementation.
2024-03-07 09:40:32 +01:00
Michael Nebel
c606ab09a5
C#: Copy dotnet.Callable implementation.
2024-03-07 09:40:32 +01:00
Michael Nebel
d7dc73e18b
C#: Remove the CIL related parts of the Disposal tests.
2024-03-07 09:40:32 +01:00
Mathias Vorreiter Pedersen
b876117ecc
C++: Add more QLDoc.
2024-03-06 22:25:04 -08:00
Mathias Vorreiter Pedersen
01fc7432cb
C++: Add more tests.
2024-03-06 22:17:33 -08:00
Mathias Vorreiter Pedersen
bf84f3a936
C++: Add FN.
2024-03-06 21:19:17 -08:00
Mathias Vorreiter Pedersen
3295d5cb9f
C++: Add more QLDoc.
2024-03-06 21:17:57 -08:00
Mathias Vorreiter Pedersen
fc9919a5b6
C++: Add a test that exercise the 'last field' check.
2024-03-06 21:17:55 -08:00
Mathias Vorreiter Pedersen
c2db5f490e
C++: Add more FNs and FPs to show examples of where the 'successor typing' strategy fails.
2024-03-06 21:16:51 -08:00
Mathias Vorreiter Pedersen
cd57cd0d8a
C++: Add qhelp reference.
2024-03-06 21:15:27 -08:00
Mathias Vorreiter Pedersen
cf4c8eb517
C++: Add more tests.
2024-03-06 21:15:25 -08:00
Mathias Vorreiter Pedersen
6dc0fa515d
C++: Add change note.
2024-03-06 21:11:36 -08:00
Mathias Vorreiter Pedersen
8ae6fa5366
C++: Add a new query 'cpp/type-confusion' for detecting type confusion vulnerabilities.
2024-03-06 21:11:32 -08:00
dependabot[bot]
f0a5183a3f
Bump chrono from 0.4.34 to 0.4.35 in /ql
...
Bumps [chrono](https://github.com/chronotope/chrono ) from 0.4.34 to 0.4.35.
- [Release notes](https://github.com/chronotope/chrono/releases )
- [Changelog](https://github.com/chronotope/chrono/blob/main/CHANGELOG.md )
- [Commits](https://github.com/chronotope/chrono/compare/v0.4.34...v0.4.35 )
---
updated-dependencies:
- dependency-name: chrono
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-07 03:59:07 +00:00
Angela P Wen
31f1f50a64
Merge pull request #15834 from github/post-release-prep/codeql-cli-2.16.4
...
Post-release preparation for codeql-cli-2.16.4
2024-03-06 18:40:08 -08:00
Mathias Vorreiter Pedersen
4c9876b008
C++: Accept test changes.
2024-03-06 18:18:36 -08:00
Mathias Vorreiter Pedersen
cf162aa412
C++: Add an explicit definition of the address of an IRVariable.
2024-03-06 18:18:33 -08:00
Mathias Vorreiter Pedersen
84797b9091
C++: Refactor the address out of 'DefImpl' and into a new abstract class 'OperandBasedDef'.
2024-03-06 18:15:52 -08:00
Mathias Vorreiter Pedersen
cc754858c6
C++: Add a testcase with missing flow out of the address of 'a' and to the argument of 'sink'.
2024-03-06 18:15:49 -08:00
Mathias Vorreiter Pedersen
a60afef923
C++: Add a local flow test file for IR dataflow.
2024-03-06 18:10:08 -08:00
github-actions[bot]
dc9092c9ec
Post-release preparation for codeql-cli-2.16.4
2024-03-06 22:19:33 +00:00
Angela P Wen
2daf50500c
Merge pull request #15833 from github/release-prep/2.16.4
...
Release preparation for version 2.16.4
2024-03-06 13:00:06 -08:00
github-actions[bot]
2f058ffb4d
Release preparation for version 2.16.4
2024-03-06 20:56:51 +00:00
Angela P Wen
711c474049
Merge pull request #15832 from github/revert-15814-release-prep/2.16.4
...
Revert "Release preparation for version 2.16.4"
2024-03-06 12:53:52 -08:00
Angela P Wen
ce31f8641a
Revert "Release preparation for version 2.16.4"
2024-03-06 12:07:33 -08:00
Ian Lynagh
e58b6e86b2
Kotlin 2: Accept more loc changes in exprs test
2024-03-06 17:57:44 +00:00
Geoffrey White
23fd3f62ac
C++: Add models-as-data case to allowParameterReturnInSelf.
2024-03-06 16:12:46 +00:00
Geoffrey White
26ef1bc249
Swift: comment models-as-data implementation.
2024-03-06 16:12:46 +00:00
Geoffrey White
18d9573b6a
C++: Add summaryLocalStep as well.
2024-03-06 16:12:46 +00:00
Geoffrey White
0edfafeb06
Shared: Correct and clarify doc for SemBound.getExpr.
2024-03-06 16:00:36 +00:00
Ed Minnix
a87df5459f
Fix flow summary tests
2024-03-06 10:39:32 -05:00
Ed Minnix
527041348e
Add comment about Memory<T>
2024-03-06 10:39:31 -05:00
Ed Minnix
e065390185
Add .Element modifier to Memory<T> arguments in MaD models
2024-03-06 10:39:30 -05:00
Ed Minnix
27ba51cf9d
Change note
2024-03-06 10:39:28 -05:00
Ed Minnix
94a941115f
Fix FlowSummaries test results
2024-03-06 10:39:27 -05:00
Ed Minnix
ca55b92281
Change System.IO.TextReader models to transfer taint to out parameter instead of return value
...
Some of the `System.IO.TextReader` models transfered taint to
`ReturnValue`, when there is a more relevant out-parameter/array.
2024-03-06 10:39:25 -05:00
Owen Mansel-Chan
0ebe045cd8
Merge pull request #15819 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-03-06 15:35:14 +00:00
Tamas Vajk
c4f2bbda2a
Simplify task counter incrementing
2024-03-06 16:12:14 +01:00
Tamas Vajk
34308eee8d
C#: Improve buildless progress reporting
2024-03-06 16:11:19 +01:00
Geoffrey White
8c0f02ac4b
C++: Add summary jumpStep, readStep, storeStep.
2024-03-06 14:51:48 +00:00
Owen Mansel-Chan
4e5a6d770a
Merge branch 'main' into workflow/coverage/update
2024-03-06 13:43:05 +00:00
Owen Mansel-Chan
f1115af146
Merge pull request #15130 from Malayke/main
...
Go: new query for detect DOS vulnerability
2024-03-06 11:32:57 +00:00
Tony Torralba
f4c2e65614
Merge pull request #15812 from atorralba/atorralba/go/squirrel-sinks
...
Go: Add SQLi sinks for Squirrel
2024-03-06 12:09:19 +01:00
Asger F
a54a73c9a2
JS: Detect more FunctionStyleClasses
2024-03-06 11:37:20 +01:00
Anders Schack-Mulligen
caa45058ae
Dataflow: Improve join-order.
...
Join with the functional getApprox before filtering with revFlow as this
is always better.
2024-03-06 11:29:08 +01:00
Anders Schack-Mulligen
55e6255e05
Dataflow: Extend the first join to also include argApa.
...
Improves from
2024-03-04 13:29:20] Evaluated non-recursive predicate DataFlowImpl::Impl<TaintedPath::TaintedPath::C>::Stage5::flowThroughIntoCall/6#b44155c7@6dd478n9 in 126ms (size: 398332).
Evaluated relational algebra for predicate DataFlowImpl::Impl<TaintedPath::TaintedPath::C>::Stage5::flowThroughIntoCall/6#b44155c7@6dd478n9 with tuple counts:
1 ~0% {2} r1 = SCAN `DataFlowImpl::Impl<TaintedPath::TaintedPath::C>::TAccessPathApproxNone#dom#04382804` OUTPUT _, _
1 ~0% {0} | REWRITE WITH Tmp.0 := true, Tmp.1 := false, TEST Tmp.0 != Tmp.1 KEEPING 0
83798 ~0% {4} | JOIN WITH `project#DataFlowImpl::Impl<TaintedPath::TaintedPath::C>::Stage5::returnFlowsThrough/8#ffafcf14` CARTESIAN PRODUCT OUTPUT Rhs.0, Rhs.3, Rhs.1, Rhs.2
4044102 ~3% {7} | JOIN WITH `project#DataFlowImpl::Impl<TaintedPath::TaintedPath::C>::Stage5::flowIntoCallApaTaken/6#d989a8d1#cpe#12346_2013#join_rhs` ON FIRST 1 OUTPUT Rhs.2, Lhs.2, Lhs.3, Rhs.3, Lhs.1, Lhs.0, Rhs.1
398332 ~3% {6} | JOIN WITH `project#DataFlowImpl::Impl<TaintedPath::TaintedPath::C>::Stage5::fwdFlow/9#00ae2fc8#2` ON FIRST 4 OUTPUT Lhs.6, Lhs.0, Lhs.5, _, Lhs.2, Lhs.4
398332 ~1% {6} | REWRITE WITH Out.3 := true
return r1
to
[2024-03-04 15:20:26] Evaluated non-recursive predicate DataFlowImpl::Impl<TaintedPath::TaintedPath::C>::Stage5::flowThroughIntoCall/6#b44155c7@97bd358u in 35ms (size: 398332).
Evaluated relational algebra for predicate DataFlowImpl::Impl<TaintedPath::TaintedPath::C>::Stage5::flowThroughIntoCall/6#b44155c7@97bd358u with tuple counts:
83798 ~0% {7} r1 = SCAN `project#DataFlowImpl::Impl<TaintedPath::TaintedPath::C>::Stage5::returnFlowsThrough/9#53894c55` OUTPUT In.0, In.1, In.2, In.3, In.4, _, _
{5} | REWRITE WITH Tmp.5 := true, Tmp.6 := false, TEST Tmp.5 != Tmp.6 KEEPING 5
83798 ~3% {5} | SCAN OUTPUT In.0, In.3, In.4, In.1, In.2
416847 ~2% {7} | JOIN WITH `project#DataFlowImpl::Impl<TaintedPath::TaintedPath::C>::Stage5::flowIntoCallApaTaken/6#d989a8d1#cpe#12346_2301#join_rhs` ON FIRST 2 OUTPUT Rhs.3, Lhs.3, Lhs.4, Lhs.1, Lhs.2, Lhs.0, Rhs.2
398332 ~3% {6} | JOIN WITH `project#DataFlowImpl::Impl<TaintedPath::TaintedPath::C>::Stage5::fwdFlow/9#00ae2fc8#2` ON FIRST 4 OUTPUT Lhs.6, Lhs.0, Lhs.5, _, Lhs.2, Lhs.4
398332 ~1% {6} | REWRITE WITH Out.3 := true
return r1
2024-03-06 11:29:08 +01:00
Owen Mansel-Chan
316273c7f3
Merge branch 'main' into workflow/coverage/update
2024-03-06 10:14:46 +00:00
Jeroen Ketema
66d2a8499d
Merge pull request #15816 from MathiasVP/remove-ssa-pruning-stage
...
C++: Remove the pruning stage from dataflow SSA
2024-03-06 11:04:05 +01:00
Malayke
02bab4c15a
Update go/ql/src/experimental/CWE-770/DenialOfService.ql
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2024-03-06 17:57:20 +08:00
Anders Schack-Mulligen
0dbe8c3d8a
Merge pull request #15140 from hvitved/dataflow/pruned-ctx-sensitivity
...
Data flow: prune context-sensitivity relations
2024-03-06 10:04:48 +01:00
Jeroen Ketema
d13ea0b6c9
Merge pull request #15817 from github/rdmarsh2/suppress-expr-destructors
...
C++: Suppress implicit destructors on expr in preparation for destructors on temporaries
2024-03-06 09:54:50 +01:00
Jeroen Ketema
6972f9b31d
C++: Update syntax-zoo expected test results
2024-03-06 09:34:47 +01:00
Harry Maclean
350dab4621
Merge pull request #15722 from hmac/mad-sinks
2024-03-06 08:18:19 +00:00
Edward Minnix III
6ba6b12b9f
Docs review suggestion
...
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com >
2024-03-05 22:31:25 -05:00
github-actions[bot]
b71074f9c4
Add changed framework coverage reports
2024-03-06 00:16:26 +00:00
Robert Marsh
fbbd57b34f
C++: Suppress epxr destructors in preparation for temporaries
2024-03-05 21:12:12 +00:00
Mathias Vorreiter Pedersen
f400228037
C++: Remove the pruning stage from SSA.
2024-03-05 12:55:55 -08:00
Angela P Wen
727a38a409
Merge pull request #15814 from github/release-prep/2.16.4
...
Release preparation for version 2.16.4
2024-03-05 10:16:21 -08:00
github-actions[bot]
661e68dab5
Release preparation for version 2.16.4
2024-03-05 18:13:58 +00:00
Geoffrey White
3657269d3e
C++: Autoformat.
2024-03-05 17:35:05 +00:00
Geoffrey White
d1fc700735
C++: Fill out some QLDoc.
2024-03-05 17:34:48 +00:00
Geoffrey White
7675f153ce
C++: Add SummaryOutNode class.
2024-03-05 17:32:54 +00:00
Angela P Wen
7e2a775a2a
Merge pull request #15813 from github/revert-15801-release-prep/2.16.4
...
Revert "Release preparation for version 2.16.4"
2024-03-05 09:20:42 -08:00
Joe Farebrother
dcc6f83d3b
Merge pull request #15782 from joefarebrother/ruby-typhoeus
...
Ruby: Model `Typhoeus::Request.new`
2024-03-05 16:55:38 +00:00
Angela P Wen
967963a653
Revert "Release preparation for version 2.16.4"
2024-03-05 08:53:33 -08:00
Joe Farebrother
7027b7fe82
Apply review suggestions: Use getInstance and clarify predicate name/qldoc. Also fix changenote formatting.
2024-03-05 16:34:48 +00:00
Tamás Vajk
b4fdd4e222
Merge pull request #15808 from tamasvajk/buildless/package-source-telemetry
...
C#: Add package source error count to DB
2024-03-05 17:20:38 +01:00
Michael B. Gale
eaef544a26
Merge pull request #15810 from github/mbg/go/fix-initialised-module-names
2024-03-05 15:34:07 +00:00
Tony Torralba
e78e71c875
List Squirrel builders explicitly
2024-03-05 16:05:22 +01:00
Michael B. Gale
40ff75db07
Go: Update list of expected files for single-go-mod-and-go-files-not-under-it test
2024-03-05 14:56:51 +00:00
Ian Lynagh
edd383afc1
Merge pull request #15803 from igfoo/igfoo/del1
...
Kotlin 2: Accept more location changes
2024-03-05 14:41:05 +00:00
Tony Torralba
a264ea23c6
Go: Add SQLi sinks for Squirrel
2024-03-05 15:35:34 +01:00
Tamas Vajk
2b99b83857
C#: Add package source error count to DB
2024-03-05 15:32:08 +01:00
Michael B. Gale
a8d240dd72
Go: Add integration test for mixed layout project
2024-03-05 14:08:16 +00:00
Michael B. Gale
ac394dc80c
Go: Better check for path prefixes
2024-03-05 13:46:33 +00:00
Owen Mansel-Chan
8e43c5c683
Merge pull request #15811 from owen-mc/go/limit-password-heuristics
...
Go: Only check strings of length <= 100 for dummy password with <= 2 unique characters
2024-03-05 13:42:26 +00:00
Michael B. Gale
b1e0bc03ab
Go: Fix check for whether it is safe to initialise a go.mod file in a given directory
2024-03-05 12:48:21 +00:00
Michael B. Gale
367ecf75d5
Go: Use import path for auto-generated Go module names
2024-03-05 12:48:21 +00:00
Michael B. Gale
2aa093c95c
Go: Move getImportPath to shared util package
2024-03-05 12:48:19 +00:00
Owen Mansel-Chan
4dde1fb117
Only check strings of length <= 100 for dummy password with <= 2 unique characters
2024-03-05 11:45:17 +00:00
Harry Maclean
148241183a
Ruby: update changenote
2024-03-05 10:20:25 +00:00
Harry Maclean
91cb2a37fd
Ruby: Model Process.exec
2024-03-05 10:19:22 +00:00
Tom Hvitved
bd7b2c4cc6
Update expected output
2024-03-05 10:44:13 +01:00
Tom Hvitved
d5c34264ad
Data flow: Prune call-context sensitivity relations
2024-03-05 10:44:12 +01:00
Harry Maclean
179aaa1342
Ruby: model Open4.popen4ext
2024-03-05 09:35:18 +00:00
Tom Hvitved
5be75e91fc
Merge pull request #15796 from hvitved/csharp/variable-capture-follow-up
...
C#: Variable capture follow-up
2024-03-05 09:58:23 +01:00
Harry Maclean
87f3b43576
Ruby: remove deprecated private class
2024-03-05 08:28:16 +00:00
Tony Torralba
a78e04eb34
Merge pull request #15795 from atorralba/atorralba/go/macaron-sources
...
Go: Add Macaron sources
2024-03-05 09:08:58 +01:00
Tony Torralba
05aaf2bb67
Merge pull request #15805 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-03-05 08:53:41 +01:00
github-actions[bot]
84f3771cdd
Add changed framework coverage reports
2024-03-05 00:15:54 +00:00
Robert Marsh
28e1e3a13a
C++: remove skeleton for IR destructors on expressions
2024-03-04 21:54:18 +00:00
Ian Lynagh
6e09dcc16a
Kotlin 2: Accept more loc changes in exprs
2024-03-04 19:06:32 +00:00
Ian Lynagh
22e6c676c3
Kotlin 2: Accept loc change for a string literal in expr test
2024-03-04 19:02:40 +00:00
Ian Lynagh
b7d2e54bbd
Kotlin 2: exprs test: Accept loc change for ClassWithDelegate
2024-03-04 19:00:40 +00:00
Ian Lynagh
00ab1a3129
Kotlin 2: exprs test: Accept loc change for MyClass
2024-03-04 19:00:38 +00:00
Angela P Wen
92e91f596f
Merge pull request #15801 from github/release-prep/2.16.4
...
Release preparation for version 2.16.4
2024-03-04 10:57:55 -08:00
Tom Hvitved
a92e394a7c
C#: Variable capture follow-up
2024-03-04 19:36:30 +01:00
github-actions[bot]
a67218a027
Release preparation for version 2.16.4
2024-03-04 17:42:08 +00:00
Angela P Wen
19539ab6d8
Merge pull request #15800 from github/angelapwen/fix-ruby-changenotes
...
Fix Markdown formatting on Ruby changenotes
2024-03-04 08:52:13 -08:00
Angela P Wen
2b2ea597ce
Fix formatting on changenotes
2024-03-04 16:42:38 +00:00
Tony Torralba
7286f56718
Change tests to inline expectations
2024-03-04 17:29:12 +01:00
Owen Mansel-Chan
331f308997
Merge pull request #13692 from Marcono1234/patch-1
...
Mention needed imports at top of "Analyzing data flow in Java"
2024-03-04 15:32:18 +00:00
Ian Lynagh
97275157e6
Kotlin: Docs: Give upper bound as 1.9.2x rather than 1.9.20
...
I think that this will be clearer.
2024-03-04 15:21:05 +00:00
Owen Mansel-Chan
e124b07611
Merge branch 'main' into patch-1
2024-03-04 14:44:23 +00:00
Owen Mansel-Chan
dcc2b2c50d
Merge pull request #15057 from aydinnyunus/main
...
Web Cache Deception Vulnerability on Go Frameworks
2024-03-04 14:36:39 +00:00
Owen Mansel-Chan
c0974934bc
Fix test expectations again
2024-03-04 14:05:04 +00:00
Owen Mansel-Chan
39a802fb98
Add new columns to test expectations
2024-03-04 13:45:54 +00:00
yoff
00e77a3ddb
Merge pull request #15720 from RasmusWL/nosql-precision
...
Python: Add precision to NoSQL query
2024-03-04 14:44:46 +01:00
yoff
569bb991d4
Merge pull request #15775 from RasmusWL/scope-consistency
...
Python: Add consistency check for `PhaseDependentFlow`
2024-03-04 14:43:13 +01:00
Owen Mansel-Chan
6a1bb9bfb0
Merge branch 'main' into main
2024-03-04 13:42:53 +00:00
Tom Hvitved
357638baa8
C#: Update variable capture test
2024-03-04 14:39:48 +01:00
Owen Mansel-Chan
0bf0c069c6
Fix formatting
2024-03-04 13:39:44 +00:00
yoff
a9ce2e10ad
Merge pull request #15781 from RasmusWL/dict-update
...
Python: Fix missing DictionaryElementContents
2024-03-04 14:37:34 +01:00
Tony Torralba
fc12537699
Go: Add Macaron sources
2024-03-04 14:29:56 +01:00
Ian Lynagh
ab288d0d4c
Merge pull request #15712 from igfoo/igfoo/k2ref
...
Kotlin 2: Accept changes in library-tests/reflection
2024-03-04 13:19:56 +00:00
Michael B. Gale
e5de4f2d67
Merge pull request #15789 from github/mbg/go/autobuilder-review-comments
2024-03-04 13:19:29 +00:00
Ian Lynagh
73fe20f33b
Merge pull request #15713 from igfoo/igfoo/past
...
Kotlin 2: Accept some PrintAst changes in library-tests/exprs
2024-03-04 13:12:49 +00:00
Max Schaefer
1f3a3492ae
Merge pull request #15792 from github/max-schaefer-patch-1
...
Java: Fix sink type in hudson.model.yml
2024-03-04 13:08:47 +00:00
Owen Mansel-Chan
910725939f
Update QLDoc
2024-03-04 13:06:23 +00:00
Ian Lynagh
9bad1e60db
Merge pull request #15765 from igfoo/igfoo/deleg
...
Kotlin 2: Accept loc changes in library-tests/exprs/delegatedProperties
2024-03-04 13:02:34 +00:00
Michael B. Gale
9b5bf519a1
Update go/extractor/project/project.go
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2024-03-04 12:25:40 +00:00
Owen Mansel-Chan
279605b486
Merge pull request #15786 from owen-mc/java/sensitive-logging-query-exclude-null-in-variable-name
...
Java: sensitive logging query exclude null in variable name
2024-03-04 12:14:42 +00:00
Michael B. Gale
acf2f761a6
Go: Improve log message for InitGoModForLegacyProject
2024-03-04 12:14:24 +00:00
Michael B. Gale
1a13a0e4c9
Go: Log discovered Go modules in case workspace files can't be read/parsed
2024-03-04 12:14:24 +00:00
Michael B. Gale
52b273ae23
Go: Include workspace count in success message
2024-03-04 12:14:24 +00:00
Michael B. Gale
8055c5d9e3
Go: Avoid extra loop to track unsuccessfulProjects
2024-03-04 12:14:23 +00:00
Michael B. Gale
020eb4aed7
Go: Use slices.Concat for bazelPaths
2024-03-04 12:14:23 +00:00
Michael B. Gale
040a288bb3
Go: Update comment to replace Go.mod with go.mod
2024-03-04 12:14:23 +00:00
Michael B. Gale
37212737fb
Go: Delete unused AnyGoFilesOutsideDirs
2024-03-04 12:14:22 +00:00
Michael B. Gale
ac484e5a04
Merge pull request #15793 from github/mbg/go/autobuilder-refactor-changelog
...
Go: Add changenote for autobuilder refactor
2024-03-04 12:10:24 +00:00
Michael B. Gale
a8ae2e2525
Go: Add changenote for autobuilder refactor
2024-03-04 12:02:51 +00:00
Geoffrey White
50ad45944c
Update shared/dataflow/codeql/dataflow/DataFlow.qll
...
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com >
2024-03-04 12:02:01 +00:00
Geoffrey White
5def2887e7
Shared: Add an example for SemBound.getExpr.
2024-03-04 11:59:52 +00:00
Max Schaefer
52a36ce41c
Java: Fix sink type in hudson.model.yml
2024-03-04 11:53:37 +00:00
Michael B. Gale
4dd23d4767
Merge pull request #15791 from github/mbg/go/use-1.22-for-extractor
...
Go: Use Go 1.22 for the extractor
2024-03-04 11:53:37 +00:00
Michael B. Gale
726e0928ed
Merge pull request #15790 from github/mbg/go/allow-1.22
...
Go: Allow 1.22 as a supported version
2024-03-04 11:49:33 +00:00
Chris Smowton
83cef78200
Merge pull request #15783 from github/smowton/fix/extractor-information-fractional-percentage
...
Java: extractor information: tolerate fractional percentages
2024-03-04 11:09:42 +00:00
Michael B. Gale
0e9a7c84d1
Go: Update go.work.sum
2024-03-04 10:59:23 +00:00
Michael B. Gale
ff82eb95f5
Go: Use 1.22 in go.mod
2024-03-04 10:58:51 +00:00
Michael B. Gale
6563414370
Go: Allow 1.22 as a supported version
2024-03-04 10:56:03 +00:00
Rasmus Wriedt Larsen
fbf6727809
Python: Add change-note
2024-03-04 11:46:38 +01:00
Rasmus Wriedt Larsen
16cb6c2044
Python: Fix validTest expectations
...
Co-authored-by: yoff <lerchedahl@gmail.com >
2024-03-04 11:41:47 +01:00
Rasmus Wriedt Larsen
85a45b0155
Python: Fix comment
...
Co-authored-by: yoff <lerchedahl@gmail.com >
2024-03-04 11:40:17 +01:00
Michael B. Gale
0c93641b54
Merge pull request #15361 from github/mbg/go/legacy-gopath-mode-deprecated
...
Go: Update autobuilder to deal with the upcoming deprecation of the legacy GOPATH mode
2024-03-04 10:23:37 +00:00
Harry Maclean
ce1d0d2375
Merge pull request #15780 from p-/p--method-injection
...
Ruby: sinks for code injection via calls to `method`
2024-03-04 10:02:40 +00:00
Joe Farebrother
31687afd5d
Fix performance
2024-03-04 09:47:12 +00:00
Asger F
4ab7acedb6
JS: Do not track instance methods
2024-03-04 10:36:13 +01:00
Owen Mansel-Chan
038afc4008
Merge pull request #15772 from owen-mc/java/model-generator-exclude-tostring
...
Java: do not generate models for `toString` and lambda flow methods
2024-03-04 07:57:48 +00:00
Owen Mansel-Chan
037c76d840
Update change note
...
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2024-03-04 07:49:18 +00:00
Michael Nebel
11142df4d0
Merge pull request #15764 from michaelnebel/csharp/csharptracerrunapp
...
C#: Don't inject compiler flags when dotnet is used to execute an application.
2024-03-04 08:13:11 +01:00
Owen Mansel-Chan
7a96b11a0a
Add change note
2024-03-03 21:41:05 +00:00
Owen Mansel-Chan
19ac9e089a
Add test
2024-03-03 21:03:41 +00:00
Owen Mansel-Chan
c7efde3b7a
Remove variables with "null" in their name as sources
2024-03-03 20:55:04 +00:00
Merdan Aziz
72e6853792
address the review comments
2024-03-03 20:36:43 +08:00
Michael B. Gale
9c2322dd82
Merge pull request #15362 from github/mbg/go/add-go-work
2024-03-03 11:59:18 +00:00
Malayke
7072ab9364
Update go/ql/src/experimental/CWE-770/DenialOfServiceGood.go
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2024-03-03 18:09:33 +08:00
Owen Mansel-Chan
114c17ad57
Add more methods of java.util.Comparator
2024-03-02 20:55:30 +00:00
Chris Smowton
040395485e
Update ExtractorInformation.expected
2024-03-02 10:20:45 +00:00
Owen Mansel-Chan
bf22c6dae0
Merge pull request #15766 from owen-mc/java/add-neutral-models
...
Java: add neutral models
2024-03-02 06:00:33 +00:00
Asger F
f5d014baa5
JS: Remove allocation site restriction in CG
2024-03-01 23:20:35 +01:00
Ed Minnix
59b14f6a69
Fix test expectations (merge conflict)
2024-03-01 12:52:03 -05:00
Ed Minnix
45e1be875c
Fix test expectations
2024-03-01 12:52:00 -05:00
Ed Minnix
4dc605354c
Second-order SQL injection
2024-03-01 12:51:59 -05:00
Ed Minnix
1ba3efb111
Change note updates
2024-03-01 12:51:58 -05:00
Ed Minnix
e84a509976
Modify test cases
2024-03-01 12:51:56 -05:00
Ed Minnix
c3671c7625
Fix change note
2024-03-01 12:51:55 -05:00
Ed Minnix
be3c1ed0be
Change note
2024-03-01 12:51:53 -05:00
Ed Minnix
c95abd47ce
Remove stored variants of queries
2024-03-01 12:51:51 -05:00
Geoffrey White
cb1c68260e
Shared: QLDoc for ContentApprox and getContentApprox.
2024-03-01 17:36:53 +00:00
Geoffrey White
c663809cc7
Update shared/rangeanalysis/codeql/rangeanalysis/RangeAnalysis.qll
...
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com >
2024-03-01 17:06:48 +00:00
Geoffrey White
0e24ed14da
Apply suggestions from code review
...
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com >
2024-03-01 17:04:34 +00:00
Chris Smowton
0bb6a64e81
Java: extractor information: tolerate fractional percentages
2024-03-01 16:49:29 +00:00
Owen Mansel-Chan
0a8dfbafe4
Accept suggestion to put models under the right heading
...
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2024-03-01 16:05:28 +00:00
Geoffrey White
d1a2048134
C++: Add SummaryPostUpdateNode class.
2024-03-01 16:03:37 +00:00
Geoffrey White
340a17dd74
C++: Attempt to QLDoc OutNode better.
2024-03-01 16:03:37 +00:00
Geoffrey White
dbf0b98791
C++: Add some test cases involving function pointers.
2024-03-01 15:56:44 +00:00
Geoffrey White
f649939d78
C++: Allow flow through (previously missing) summary taint steps.
2024-03-01 15:56:44 +00:00
Ian Lynagh
fd82a06b93
Merge pull request #15777 from igfoo/igfoo/label-kot
...
CI: Kotlin: Label Kotlin test changes as "Kotlin"
2024-03-01 15:38:01 +00:00
Joe Farebrother
5a1c0f60e6
Fix qldoc typo
2024-03-01 15:12:16 +00:00
Peter Stöckli
4adc373dfe
Ruby: more test cases for code injection via method
2024-03-01 16:01:07 +01:00
Joe Farebrother
4b1626c83a
Add change note
2024-03-01 14:59:24 +00:00
Peter Stöckli
3418ec8a81
Ruby: Update method code injection sinks change note
...
Co-authored-by: Harry Maclean <hmac@github.com >
2024-03-01 15:54:58 +01:00
Michael B. Gale
bda8a804ec
Go: Add go.work file
2024-03-01 14:50:00 +00:00
Joe Farebrother
65b30c1dff
Add tests and qldoc
2024-03-01 14:46:55 +00:00
Rasmus Wriedt Larsen
d99a763ef7
Python: add change-note
2024-03-01 15:24:33 +01:00
Joe Farebrother
a08b292099
Add models for Typhoeus::Request
2024-03-01 14:23:24 +00:00
Owen Mansel-Chan
5399d88d15
Accept test change: slight change in gen vs man modelgen stats
2024-03-01 14:22:00 +00:00
Rasmus Wriedt Larsen
eeda4355f1
Python: Fix missing DictionaryElementContent
2024-03-01 15:21:13 +01:00
Peter Stöckli
e43c368222
Ruby: change note for methode code injection sinks
2024-03-01 15:20:32 +01:00
Rasmus Wriedt Larsen
30b7fadbb8
Python: Add test
2024-03-01 15:19:56 +01:00
Owen Mansel-Chan
6e63df9e32
Accept test change: toString method no longer generated
2024-03-01 14:16:14 +00:00
Owen Mansel-Chan
0e1c45e84b
Accept test change: some more APIs have manual models now
2024-03-01 14:08:42 +00:00
Owen Mansel-Chan
df64e0bc5f
Add neutral summary models for java.security.MessageDigest#digest
2024-03-01 14:08:31 +00:00
Owen Mansel-Chan
f89fedcbaf
Add some neutral models for java.util
2024-03-01 14:07:45 +00:00
Peter Stöckli
a693c6d9b4
Ruby: sinks for code injection via calls to method
2024-03-01 14:42:22 +01:00
Michael Nebel
a97510a2fc
Merge pull request #15419 from github/egregius313/csharp/dataflow/threat-modeling/refactor-to-threatmodelflowsource
...
C#: Refactor C# queries to use `ThreatModelFlowSource` instead of `RemoteFlowSource`
2024-03-01 14:40:40 +01:00
Tom Hvitved
15d1105d8d
Merge pull request #15779 from hvitved/csharp/build-mode-none
...
C#: Add `build_modes: none` to `codeql-extractor.yml`
2024-03-01 14:34:08 +01:00
Rasmus Wriedt Larsen
7c60562132
Python: Ignore IterableSequenceNode inconsistencies
2024-03-01 14:22:18 +01:00
Rasmus Wriedt Larsen
7e3e5db3db
Python: Add example of consistency failure
2024-03-01 14:21:16 +01:00
Rasmus Wriedt Larsen
bcd5c08ebd
Python: Ignore match-related inconsistencies
2024-03-01 14:15:32 +01:00
Rasmus Wriedt Larsen
5d212514c6
Python: Add example of consistency failure
2024-03-01 14:07:08 +01:00
Mathias Vorreiter Pedersen
9133a13fc7
Merge pull request #15628 from microsoft/cpp-non-constant-format-as-path-query
...
Cpp non constant format as path query
2024-03-01 13:05:44 +00:00
Rasmus Wriedt Larsen
1658a1cb80
Python: Ignore SynthDictSplatArgumentNode failures
2024-03-01 14:00:06 +01:00
Rasmus Wriedt Larsen
bff95c4c1b
Python: Add example of consistency failure
2024-03-01 13:58:33 +01:00
Tom Hvitved
6d9f3d4a3e
C#: Add build_modes: none to codeql-extractor.yml
2024-03-01 13:54:57 +01:00
Owen Mansel-Chan
10f6329b3e
Add manual neutral models for java.util.stream
...
See comment in java/ql/src/Metrics/Summaries/TopJdkApis.qll
* Note: the following top JDK APIs are not modeled with MaD:
* `java.util.stream.Collectors#joining(CharSequence)`: cannot be modeled completely without a model for `java.util.stream.Stream#collect(Collector)` as well
* `java.util.stream.Collectors#toMap(Function,Function)`: specialized collectors flow
* `java.util.stream.Stream#collect(Collector)`: handled separately on a case-by-case basis as it is too complex for MaD
2024-03-01 12:32:04 +00:00
Owen Mansel-Chan
f907fd21ad
Add manual neutral models for java.text.Format and java.text.MessageFormat
...
See comment in java/ql/src/Metrics/Summaries/TopJdkApis.qll
* Note: the following top JDK APIs are not modeled with MaD:
* `java.text.Format#format(Object)`: similar issue as `Object.toString`; depends on the object being passed as the argument
* `java.text.MessageFormat#format(String,Object[])`: similar issue as `Object.toString`; depends on the object being passed as the argument
2024-03-01 12:31:59 +00:00
Owen Mansel-Chan
0e95f41900
Add manual neutral models for java.lang
...
See comment in java/ql/src/Metrics/Summaries/TopJdkApis.qll
* Note: the following top JDK APIs are not modeled with MaD:
* `java.lang.System#getProperty(String)`: needs to be modeled by regular CodeQL matching the get and set keys to reduce FPs
* `java.lang.System#setProperty(String,String)`: needs to be modeled by regular CodeQL matching the get and set keys to reduce FPs
2024-03-01 12:31:49 +00:00
Michael Nebel
ac4ad0cbc0
C#: Add test where build should not be interpreted as a SDK sub command.
2024-03-01 13:24:04 +01:00
Michael Nebel
24572848f3
C#: Move helper function to other repo to allow sharing.
2024-03-01 13:24:04 +01:00
Michael Nebel
07fc84de8c
C#: Don't inject compiler flags when dotnet is used to execute an application.
2024-03-01 13:24:04 +01:00
Tom Hvitved
cb128da5aa
Merge pull request #15762 from hvitved/csharp/fetch-dotnet-dependency-fetching
...
C#: Fetch .NET in dependency manager instead of autobuilder
2024-03-01 13:19:20 +01:00
Owen Mansel-Chan
bb97df1d71
do not generate models for lambda flow methods
2024-03-01 12:11:40 +00:00
Tom Hvitved
20ff7def73
Address review comment
2024-03-01 12:54:47 +01:00
Ian Lynagh
86b4f27d12
CI: Kotlin: Label Kotlin test changes as "Kotlin"
2024-03-01 11:26:56 +00:00
Geoffrey White
1fece75f15
Apply suggestions from code review
...
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com >
2024-03-01 11:10:26 +00:00
Mathias Vorreiter Pedersen
a7547d516a
Merge branch 'main' into cpp-non-constant-format-as-path-query
2024-03-01 11:08:58 +00:00
Florin Coada
1719fd8acb
Merge pull request #15769 from github/coadaflorin/changelog-2.16.3-updates
...
Match changelog updates with public unified changelog
2024-03-01 10:57:02 +00:00
Joe Farebrother
0f1106b2f6
Merge pull request #15753 from joefarebrother/ruby-i18n-translation
...
Ruby: Model Rails translation methods
2024-03-01 10:35:12 +00:00
Geoffrey White
2e5f7dc8fc
C++: QLDoc (mostly placeholder).
2024-03-01 09:59:31 +00:00
Geoffrey White
8faad92cfd
C++: Define DataFlowCallable.getUnderlyingCallable and use it to fix some issues.
2024-03-01 09:59:31 +00:00
Owen Mansel-Chan
bbf3fa7506
do not generate models for toString
2024-03-01 09:59:27 +00:00
Joe Farebrother
abdae2c437
Apply reveiw suggestion - update change note
...
Co-authored-by: Harry Maclean <hmac@github.com >
2024-03-01 09:57:28 +00:00
Joe Farebrother
bf2174ffce
Add change note
2024-03-01 09:57:28 +00:00
Joe Farebrother
0b7b7ea1b8
Add test cases and improve controller model
2024-03-01 09:57:24 +00:00
Joe Farebrother
ef0a1d2873
Implement models for translation methods
2024-03-01 09:52:53 +00:00
Rasmus Wriedt Larsen
ff5f794750
Python: Exclude synth preupdate nodes from tt-consistency
...
... and that should be it 👍 (so that's why I'm allowing the tests to
run on all data-flow nodes again)
2024-03-01 10:27:29 +01:00
Tony Torralba
e0515269c5
Merge pull request #15774 from atorralba/atorralba/java/mapentry-copyof-provenance
...
Java: Fix provenance of Map.Entry.copyOf models
2024-03-01 10:26:22 +01:00
Mathias Vorreiter Pedersen
4e913592fa
Merge branch 'main' into cpp-non-constant-format-as-path-query
2024-03-01 09:26:00 +00:00
Mathias Vorreiter Pedersen
2eb8d13439
C++: Accept test changes.
2024-03-01 09:25:25 +00:00
Rasmus Wriedt Larsen
bbe8c6dcaa
Python: Remove synth postupdate nodes from tt-consistency
2024-03-01 10:23:50 +01:00
Rasmus Wriedt Larsen
9f01ea68f7
Python: Add type-tracking consistency query
...
For now I'm only ignoring stdlib nodes, so it's easy for reviewer to see
why we need to have more excludes :)
2024-03-01 10:19:49 +01:00
Florin Coada
a8816a6d1c
Update java/ql/src/change-notes/released/0.8.9.md
...
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2024-03-01 09:18:22 +00:00
Florin Coada
d54e3d73ab
Update java/ql/src/CHANGELOG.md
...
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2024-03-01 09:18:14 +00:00
Rasmus Wriedt Larsen
d182eae868
Python: Add consistency check for PhaseDependentFlow
...
This would have found the problem in
https://github.com/github/codeql/pull/15755 .
As highlighted in the comment in the code, it's not a perfect solution
since we don't have an automatic way to ensure we don't introduce a new
PhaseDependentFlow use with a new step relation and forget to add it to
this consistency check... but I think this consistency check still adds
value!
2024-03-01 10:01:08 +01:00
Tony Torralba
664dac6b28
Merge pull request #15773 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-03-01 09:22:47 +01:00
Tony Torralba
dd1dbdf4ec
Java: Fix provenance of Map.Entry.copyOf models
2024-03-01 09:00:13 +01:00
github-actions[bot]
148bc26b09
Add changed framework coverage reports
2024-03-01 00:17:57 +00:00
Owen Mansel-Chan
54031a8187
Merge pull request #15767 from owen-mc/java/add-summary-models
...
Java: add a few summary models
2024-02-29 21:21:23 +00:00
Tom Hvitved
a8468a6178
C#: Better handle multiple global.json files
2024-02-29 20:27:52 +01:00
Mathias Vorreiter Pedersen
1466f11a92
C++: Add change note.
2024-02-29 18:39:59 +00:00
Geoffrey White
a499919239
Shared: More helpful QLDoc for simpleLocalFlowStep.
2024-02-29 17:13:40 +00:00
Paolo Tranquilli
6d90877c52
Merge pull request #15536 from github/redsun82/bazel-cmake
...
Bazel/CMake: auto detect all `cc_binary`/`cc_test` targets
2024-02-29 18:13:40 +01:00
Geoffrey White
f834768720
Shared: Improve QLDoc for forceHighPrecision.
2024-02-29 17:09:31 +00:00
Geoffrey White
9d2dc7a3cc
Shared: Format.
2024-02-29 17:09:16 +00:00
Ed Minnix
f488f23a48
Add LocalFlowSource back to UncontrolledFormatString
2024-02-29 12:06:59 -05:00
Geoffrey White
88e3bc6865
Update shared/dataflow/codeql/dataflow/DataFlow.qll
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2024-02-29 17:03:30 +00:00
Edward Minnix III
89bdb7f437
Remove discussion of local flow in change note
...
Co-authored-by: Michael Nebel <michaelnebel@github.com >
2024-02-29 12:03:19 -05:00
Ed Minnix
86ceeebd89
Change handling of LocalSource in queries
...
1. Change `LocalSource` to extend `DataFlow::Node`, thus removed from
the definiton of `Source`
2. Add a private class `AddLocalSource` which extends `Source`. This
allows us to currently preserve the inclusion of local sources, while
making it easier to remove it in the future.
2024-02-29 12:03:17 -05:00
Ed Minnix
3563c7ef03
Modify deprecated RemoteSource classes to extend DataFlow::Node directly.
...
Since `ThreatModelFlowSource` contains `RemoteFlowSource` by default, we
can safely remove the `RemoteSource` from the default of the queries.
2024-02-29 12:03:16 -05:00
Ed Minnix
e64826db1b
Add threat-model configuration for UncontrolledFormatString test
2024-02-29 12:03:14 -05:00
Ed Minnix
af749e221b
Remove commented out code
2024-02-29 12:03:13 -05:00
Ed Minnix
f237d2aeda
Refactor to use ThreatModelFlowSource
2024-02-29 12:03:12 -05:00
Ed Minnix
5198f52351
Add references to changed queries in change note
2024-02-29 12:03:11 -05:00
Ed Minnix
22e8da2928
Update change note date
2024-02-29 12:03:09 -05:00
Ed Minnix
eb81946adc
Change note changes to mention local sources as well
2024-02-29 12:03:08 -05:00
Ed Minnix
b4dabee770
Remove unnecessary flowsources.Remote imports
...
Since `FlowSources` now re-exports `Remote`, these can be safely removed.
2024-02-29 12:03:07 -05:00
Ed Minnix
434fa20646
Refactor to using ThreatModelFlowSource
2024-02-29 12:03:05 -05:00
Ed Minnix
1086abca63
Refactor to using ThreatModelFlowSource
2024-02-29 12:03:04 -05:00
Ed Minnix
b76795fd28
Refactor to using ThreatModelFlowSource
2024-02-29 12:03:03 -05:00
Ed Minnix
fd3738b10e
Refactor to using SourceNode::getSourceType
2024-02-29 12:03:01 -05:00
Ed Minnix
31d4d0ca57
Move getSourceType to SourceNode
2024-02-29 12:03:00 -05:00
Ed Minnix
75772664f2
Change note
2024-02-29 12:02:58 -05:00
Ed Minnix
f388a0f10c
Deprecate direct uses of RemoteFlowSource and replace with ThreatModelFlowSource
2024-02-29 12:02:57 -05:00
Ed Minnix
bd0137a721
Deprecated direct use of RemoteFlowSource and use ThreatModelFlowSource instead
2024-02-29 12:02:55 -05:00
Chris Smowton
051d63a5a9
Merge pull request #15740 from smowton/smowton/feature/call-and-type-telemetry
...
Java: add extraction quality telemetry; improve stringification of some erroneous expressions
2024-02-29 16:51:51 +00:00
Tony Torralba
47bf556223
Merge pull request #15709 from atorralba/atorralba/java/enable-widget-taint-steps
...
Java: Re-enable Widget.qll flow steps
2024-02-29 17:33:05 +01:00
Owen Mansel-Chan
7b5f51b1e2
Change summary models to neutral models for javax.crypto.Cipher
2024-02-29 16:22:27 +00:00
Geoffrey White
445b82b4e1
Shared: Explain 'guard'.
2024-02-29 16:07:20 +00:00
Geoffrey White
70465b22c7
Shared: Remove @ annotations.
2024-02-29 16:00:43 +00:00
Geoffrey White
98289b52d6
Shared: Explain SsaPhiNode a bit more.
2024-02-29 15:45:43 +00:00
Geoffrey White
8151f3024d
Shared: Pinch better doc for isEquality from a related Guards class in csharp.
2024-02-29 15:41:51 +00:00
Chris Smowton
ef9544cbef
Adjust test expectations now signature type-accesses are named
2024-02-29 15:33:29 +00:00
Chris Smowton
903e4f59f0
Exclude error types from contradictory-type-check query
2024-02-29 14:59:46 +00:00
Chris Smowton
140c3189e3
Adjust test expectations
2024-02-29 14:59:46 +00:00
Chris Smowton
3bd0c3b2c2
Switch test to using a qlref to the real telemetry query
2024-02-29 14:59:46 +00:00
Chris Smowton
ef82ea7541
Add change note
2024-02-29 14:59:46 +00:00
Chris Smowton
551006c15e
Make predicate private
2024-02-29 14:59:46 +00:00
Chris Smowton
ffa998eb4a
Autoformat
2024-02-29 14:59:45 +00:00
Chris Smowton
b6507e795a
Add test for a buildless project that doesn't compile cleanly
2024-02-29 14:59:45 +00:00
Chris Smowton
5d55265910
Add telemetry for untyped expressions and missing call targets
2024-02-29 14:59:45 +00:00
Chris Smowton
1fd459e8fc
Improve stringification of some erroneous expressions
2024-02-29 14:59:45 +00:00
Alexander Eyers-Taylor
6c8105fd1c
Merge pull request #15568 from github/alexet/kotlin-jdk-change
...
Kotlin: Compile tests using the same jdk as the java tests.
2024-02-29 14:48:03 +00:00
Paolo Tranquilli
0a137c7b02
Bazel/Cmake: share build options
2024-02-29 15:35:21 +01:00
Florin Coada
8d1965db59
match changelog to unified changelog
2024-02-29 14:33:14 +00:00
Florin Coada
cfdf163b40
Update changelog to match unified changelog
2024-02-29 14:32:57 +00:00
Paolo Tranquilli
81facd2fd6
Merge branch 'main' into redsun82/bazel-cmake
2024-02-29 14:28:00 +01:00
Mathias Vorreiter Pedersen
e620bfa9c6
Merge pull request #15761 from MathiasVP/fewer-variablenodes
...
C++: Restrict `VariableNode`s to only be global-like variables
2024-02-29 13:12:20 +00:00
Asger F
13e3a5158e
JS: Fix qldoc
2024-02-29 13:59:25 +01:00
Alex Eyers-Taylor
d892a04506
Kotlin: Compile tests using the same jdk as the java tests.
2024-02-29 12:23:56 +00:00
Owen Mansel-Chan
939d6f973f
Add summary models for javax.crypto.Cipher
2024-02-29 12:20:47 +00:00
Owen Mansel-Chan
65bc62c10a
Add summary model for Map$Entry#copyOf
2024-02-29 12:20:43 +00:00
Ian Lynagh
b0a13fb661
Kotlin 2: Accept loc changes in library-tests/exprs/delegatedProperties
2024-02-29 12:11:07 +00:00
Mathias Vorreiter Pedersen
4474b54662
C++: Add more QLDoc.
2024-02-29 12:09:50 +00:00
Mathias Vorreiter Pedersen
46b47db78e
C++: Rename IPA branch.
2024-02-29 12:02:13 +00:00
yoff
7beafc933d
Merge pull request #15755 from RasmusWL/it-fix
...
Python: Fix module level flow for iterable unpacking
2024-02-29 12:52:44 +01:00
Tom Hvitved
0e93f5ac1a
Merge pull request #15733 from hvitved/ruby/desugar-hidden
...
Ruby: Rework hidden synthetic data-flow nodes
2024-02-29 11:24:01 +01:00
Tom Hvitved
62382fc5a2
C#: Fetch .NET in dependency manager instead of autobuilder
2024-02-29 11:23:36 +01:00
Asger F
6a0adff1dc
JS: More precise detection of classes with escaping instances
2024-02-29 11:15:37 +01:00
Asger F
eeaa2bcc55
JS: Add test for class instance escaping into dependency
2024-02-29 11:14:23 +01:00
Florin Coada
840ca9118e
Merge pull request #15750 from github/changedocs/2.16.3
...
Codeql 2.16.3 changelogs
2024-02-29 09:46:31 +00:00
Michael Nebel
a3b39c8210
Merge pull request #15752 from michaelnebel/csharp/updatesupportedlanguages
...
C#: Claim suppport for C# 12 / .NET 8.
2024-02-29 10:41:42 +01:00
Asger F
853397361f
JS: Do not treat AMD pseudo-dependencies as file paths
2024-02-29 10:23:28 +01:00
Asger F
052a8e7f81
JS: Avoid spurious recursion in AMD
2024-02-29 10:23:28 +01:00
Asger F
f384afbaf6
JS: Also summarize loadStore steps
2024-02-29 10:11:16 +01:00
Asger F
3ad83cc098
JS: Summarise store steps for type tracking
2024-02-29 10:10:39 +01:00
Asger F
7cd84c8f0a
JS: Add type-tracking test
2024-02-29 10:10:07 +01:00
Michael Nebel
14d046ef18
Merge pull request #15710 from michaelnebel/csharp/refreadonlyparameters
...
C# 12: Ref readonly parameters.
2024-02-29 09:59:12 +01:00
Tom Hvitved
c6426d8858
C#: Move BuildScript.cs and friends to Semmle.Util
2024-02-29 08:49:20 +01:00
Ed Minnix
6b310bb825
Fix reference
2024-02-28 21:39:16 -05:00
Florin Coada
0d017a9343
Update docs/codeql/codeql-overview/codeql-changelog/codeql-cli-2.16.3.rst
...
Co-authored-by: Felicity Chapman <felicitymay@github.com >
2024-02-28 22:07:04 +00:00
Florin Coada
62f4d8e53e
Update docs/codeql/codeql-overview/codeql-changelog/codeql-cli-2.16.3.rst
...
Co-authored-by: Felicity Chapman <felicitymay@github.com >
2024-02-28 22:06:46 +00:00
Florin Coada
b1deeaff05
Update docs/codeql/codeql-overview/codeql-changelog/codeql-cli-2.16.3.rst
...
Co-authored-by: Felicity Chapman <felicitymay@github.com >
2024-02-28 22:06:29 +00:00
Ed Minnix
2a70437a12
Add references to threat modeling
2024-02-28 14:34:01 -05:00
Mathias Vorreiter Pedersen
a7f0966fcb
C++: Restrict 'VariableNode's to only be global-like variables (which is the only place where use them for).
2024-02-28 19:12:38 +00:00
Ed Minnix
4b9340816c
Add threat-modeling section to C# MaD docs
2024-02-28 13:27:19 -05:00
Ed Minnix
9ab3837cdc
Make threat model beta notice more general
2024-02-28 13:26:01 -05:00
Mathias Vorreiter Pedersen
2fd57f6ee7
Shared: Remove cached annotation.
2024-02-28 16:24:21 +00:00
Felicity Chapman
ca1a27dc75
Merge pull request #15748 from github/13332-codeql-model-editor-csharp
...
Minor updates to CodeQL for VS Code docs for expansion of support for model editing
2024-02-28 15:56:32 +00:00
Rasmus Wriedt Larsen
8079788a5f
Python: Add change-note
2024-02-28 16:44:25 +01:00
Rasmus Wriedt Larsen
cdf4dd16f0
Python: Fix module level flow for iterable unpacking
...
(and for * patterns in match)
Since `PhaseDependentFlow` uses the following predicate, that relies on
.getScope() to be present for there to be any importTimeFlow (flow at
toplevel scope), it's important that data-flow nodes implement `.getScope`.
```
private predicate isTopLevel(Node node) { node.getScope() instanceof Module }
```
By implementing getScope, we can now rely on default implementation of
`getEnclosingCallable` in DataFlow::Node:
```
/** Gets the enclosing callable of this node. */
DataFlowCallable getEnclosingCallable() { result = getCallableScope(this.getScope()) }
```
2024-02-28 16:39:08 +01:00
Felicity Chapman
377ef59c3a
Merge branch 'main' into 13332-codeql-model-editor-csharp
2024-02-28 15:33:27 +00:00
Felicity Chapman
efff0149d0
Update formatting of 'tip'
2024-02-28 15:33:07 +00:00
Koen Vlaswinkel
ab11068d6d
Merge pull request #15749 from github/koesie10/update-testing-vscode-docs
...
Update documentation for testing CodeQL queries in VS Code
2024-02-28 16:29:54 +01:00
Rasmus Wriedt Larsen
e4699e092d
Python: Add test for iterable unpacking on module level
...
Currently doesn't work :O
2024-02-28 16:10:29 +01:00
Koen Vlaswinkel
6aeef17f99
Rename Test Explorer to Testing view
2024-02-28 16:00:15 +01:00
Tom Hvitved
297a17975d
Merge pull request #15665 from hvitved/csharp/variable-capture
...
C#: Adopt shared variable capture library
2024-02-28 15:13:03 +01:00
Michael Nebel
9563705eb3
C#: Add change note.
2024-02-28 14:53:15 +01:00
Michael Nebel
bb282b94dd
C#: Claim suppport for C# 12 / .NET 8.
2024-02-28 14:41:38 +01:00
Michael Nebel
f6b1d1f235
C#: Add upgrade and downgrade scripts.
2024-02-28 14:09:59 +01:00
Florin Coada
b76449714a
codeql 2.16.3 changelogs
2024-02-28 13:07:48 +00:00
Koen Vlaswinkel
5226c77abf
Update documentation for testing CodeQL queries in VS Code
2024-02-28 13:47:11 +01:00
Michael Nebel
00d311205b
C#: Update expected test output.
2024-02-28 13:44:28 +01:00
Michael Nebel
794bc44a41
C#: Add test query predicate for ref readonly parameters.
2024-02-28 13:44:28 +01:00
Michael Nebel
692d7036a0
C#: Add extractor and QL library support for ref readonly parameters.
2024-02-28 13:44:28 +01:00
Michael Nebel
a86de9de2f
C#: Update comment in DB Scheme.
2024-02-28 13:44:28 +01:00
Michael Nebel
18c7e73805
C#: Add test for parameter modifiers.
2024-02-28 13:44:28 +01:00
Michael Nebel
d8bff14365
C#: Adjust locations for the parameter default value tests.
2024-02-28 13:44:28 +01:00
Michael Nebel
4bbaf687ad
Merge pull request #15723 from michaelnebel/csharp/experimentalattribute
...
C# 12: Experimental attribute.
2024-02-28 13:06:09 +01:00
Jeroen Ketema
ae97a23c27
Merge pull request #15213 from jketema/frontend-update
...
C++: Accept test changes after frontend upgrade
2024-02-28 13:00:02 +01:00
Felicity Chapman
c247dee11a
Delete docs/codeql/reusables/beta-note-model-packs-java.rst
...
This was accidentally reintroduced during merge conflict resolution.
2024-02-28 11:49:50 +00:00
Felicity Chapman
053e172d94
Merge branch 'main' into 13332-codeql-model-editor-csharp
2024-02-28 11:43:02 +00:00
Felicity Chapman
897786dc99
Minor updates to model editor article
2024-02-28 11:28:59 +00:00
Michael Nebel
65ec80967e
Merge pull request #15696 from michaelnebel/csharp/compilergeneratedstmt
...
C#: Compiler generated statements.
2024-02-28 12:06:39 +01:00
Jeroen Ketema
00ad7854dc
C++: Accept test changes after frontend upgrade
...
* The `specifiers2` tests have a different result now due to the implementation
of CWG 2387.
* The `special_members/generated_copy` has improved results as the frontend has
improved support for deleted copy constructors.
2024-02-28 11:29:57 +01:00
Michael Nebel
3c15b21385
C#: Add change note.
2024-02-28 11:25:23 +01:00
Michael Nebel
7535a15fda
C#: Add tests and update expected test output.
2024-02-28 11:22:12 +01:00
Michael Nebel
95dc2f71d3
C#: Add ExperimentalAttribute class.
2024-02-28 11:20:43 +01:00
Mathias Vorreiter Pedersen
7be76405f5
Merge pull request #15741 from MathiasVP/fix-ir-inconsistencies-from-returning-routine-types
...
C++: Fix IR inconsistencies from routine types
2024-02-28 09:13:53 +00:00
Erik Krogh Kristensen
0358e81117
Merge pull request #15746 from github/dependabot/cargo/ql/rayon-1.9.0
...
Bump rayon from 1.8.1 to 1.9.0 in /ql
2024-02-28 10:11:50 +01:00
dependabot[bot]
cc178ab58f
Bump rayon from 1.8.1 to 1.9.0 in /ql
...
Bumps [rayon](https://github.com/rayon-rs/rayon ) from 1.8.1 to 1.9.0.
- [Changelog](https://github.com/rayon-rs/rayon/blob/main/RELEASES.md )
- [Commits](https://github.com/rayon-rs/rayon/compare/rayon-core-v1.8.1...rayon-core-v1.9.0 )
---
updated-dependencies:
- dependency-name: rayon
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-02-28 03:24:58 +00:00
Edward Minnix III
a743683d4f
Merge pull request #15563 from egregius313/egregius313/csharp/docs/mad-docs
...
C#: Models as Data Documentation
2024-02-27 13:45:09 -05:00
Mathias Vorreiter Pedersen
b8c141f292
C++: Accept test changes.
2024-02-27 17:58:52 +00:00
Mathias Vorreiter Pedersen
ddd5113c02
C++: Ensure that we can construct an 'IRType' from a 'RoutineType'.
2024-02-27 17:58:52 +00:00
Mathias Vorreiter Pedersen
892f97cd7a
C++: Add testcase with invalid IR from constructing a 'RoutineType'.
2024-02-27 17:58:52 +00:00
Mathias Vorreiter Pedersen
0335a4f4ce
Merge pull request #15735 from MathiasVP/ir-for-vacuous-destructor-calls
...
C++: IR construction for `VacuousDestructorCall`s
2024-02-27 17:58:30 +00:00
Geoffrey White
0df10bda0c
C++: Post-merge fixup.
2024-02-27 17:32:59 +00:00
Geoffrey White
1da611cc02
Merge branch 'main' into mad
2024-02-27 17:29:45 +00:00
Geoffrey White
bc42e2bc35
C++: Workaround to get the tests passing again.
2024-02-27 17:28:38 +00:00
Felicity Chapman
f9c2b4d23c
MVP changes for C# library expansion support
2024-02-27 16:47:13 +00:00
Chris Smowton
7c7c10ea11
Merge pull request #15739 from github/smowton-patch-1
...
Add change note for https://github.com/github/codeql/pull/15646
2024-02-27 16:07:29 +00:00
Max Schaefer
f2935caa5c
Merge pull request #15732 from github/max-schaefer/more-sink-types
...
Automodel: Add four more sink types.
2024-02-27 15:52:45 +00:00
Mathias Vorreiter Pedersen
bba152da13
Merge branch 'main' into ir-for-vacuous-destructor-calls
2024-02-27 15:42:46 +00:00
Chris Smowton
9f84653283
Merge pull request #15613 from smowton/smowton/fix/golang-map-range-read-dataflow
...
Golang: fix flow from a map value via a range statement
2024-02-27 15:42:43 +00:00
Chris Smowton
aedd3badf7
Add change note for https://github.com/github/codeql/pull/15646
2024-02-27 15:41:43 +00:00
Chris Smowton
5ea30e95a5
Merge pull request #15646 from smowton/smowton/fix/notice-self-sufficient-mvnw
...
Java: Add tests for Maven wrapper
2024-02-27 15:29:50 +00:00
Mathias Vorreiter Pedersen
f7b2de800b
Merge pull request #15506 from rdmarsh2/rdmarsh2/cpp/ir-synthetic-destructors
...
C++: Add implicit destructors for named variables to the IR
2024-02-27 15:12:46 +00:00
Tom Hvitved
914a605a87
Ruby: Rework hidden synthetic data-flow nodes
2024-02-27 15:33:58 +01:00
Tom Hvitved
994d990f37
Ruby: Add another data flow test
2024-02-27 15:33:58 +01:00
Mathias Vorreiter Pedersen
dc3b78dd7c
C++: Accept more test changes.
2024-02-27 14:30:19 +00:00
Chris Smowton
a6480a4ca1
Autoformat again / tabify
2024-02-27 13:55:26 +00:00
Mathias Vorreiter Pedersen
4a501e5b3c
C++: Accept test changes.
2024-02-27 13:53:43 +00:00
Mathias Vorreiter Pedersen
9eaa4e19ad
C++: Add IR construction for vacuous destructor calls.
2024-02-27 13:53:42 +00:00
Chris Smowton
74448c092a
Autoformat / uglify
2024-02-27 13:49:12 +00:00
Chris Smowton
e62a0805db
Add test for map literal
2024-02-27 13:44:52 +00:00
Mathias Vorreiter Pedersen
fbb0ffcadd
C++: Add testcase with invalid IR from vacuous destructor call.
2024-02-27 12:53:46 +00:00
Joe Farebrother
3ab6f222d0
Merge pull request #15718 from joefarebrother/ruby-arel-sqlliteral
...
Ruby: Model Arel::Nodes::SqlLiteral.new
2024-02-27 12:43:47 +00:00
Anders Schack-Mulligen
df5e753ee0
Merge pull request #15570 from aschackmull/java/cache-interpretelement
...
Java: Cache interpretElement.
2024-02-27 13:39:56 +01:00
Geoffrey White
540c20e143
Merge pull request #15700 from geoffw0/extensions
...
Swift: Workaround for TypeDecl.getFullName issue.
2024-02-27 11:14:33 +00:00
Harry Maclean
d0e7fbc871
Ruby: Add changenote
2024-02-27 09:47:51 +00:00
Anders Schack-Mulligen
699dddcfbe
Merge pull request #15725 from aschackmull/dataflow/summary-join-fix
...
Dataflow: Prevent bad join in FlowSummaryImpl::Private::Steps::summaryLocalStep.
2024-02-27 10:32:38 +01:00
erik-krogh
b4b5ae2a2c
add some request-forgery sanitizers, inspired from C#
2024-02-27 10:05:26 +01:00
Tom Hvitved
bbeee8f38d
Merge pull request #15717 from hvitved/csharp/view-cfg
...
Shared `View CFG` implementation
2024-02-27 09:13:18 +01:00
am0o0
b20b733172
better structure for pandas DataFrame, it is now much better readable and also we can find much more DataFrame objects
2024-02-27 09:38:43 +04:00
Chris Smowton
f7cdcd4981
Force Maven wrapper tests to run sequentially
2024-02-26 22:28:55 +00:00
Chris Smowton
03f01a0121
Add tests for Maven wrapper
2024-02-26 22:28:55 +00:00
Robert Marsh
a513598a4d
C++: Change note for IR named destructors.
2024-02-26 19:41:56 +00:00
Geoffrey White
408a550467
Merge pull request #15727 from geoffw0/qldoc4
...
C++: Mark internal files in the old dataflow library as deprecated
2024-02-26 17:45:05 +00:00
Mathias Vorreiter Pedersen
690fdc076d
Shared: Add change note.
2024-02-26 17:13:32 +00:00
Mathias Vorreiter Pedersen
1d4c889ab8
Java: Use the shared type-flow library.
2024-02-26 17:13:32 +00:00
Mathias Vorreiter Pedersen
9ec17e6338
Shared: Pull out the shared parts of Java's type flow library into a shared module.
2024-02-26 17:13:27 +00:00
Geoffrey White
2e66392353
C++: Update deprecated note to respect identical files.
2024-02-26 16:38:27 +00:00
Rasmus Lerchedahl Petersen
3eb9491cb4
python: rewrite HardcodedCredentials away from PointsTo
...
- `ModuleValue.attr` and `ClassValue.lookup` are approximated by `Function.getName`
- `ClassValue.getName` is apprximated by `Class.getName`
- `Module::named` is approximated by `Module.getName`
- `Value::named` is approximated by `Builtins::likelyBuiltin`
- `FunctionValue.getNamedArgumentForCall` is approximated by `ArgumentNode.argumentOf`
2024-02-26 17:18:40 +01:00
Joe Farebrother
cb733dcf85
Simplify model defenition
2024-02-26 14:59:03 +00:00
Cornelius Riemenschneider
4bb725cbf5
Merge pull request #15656 from github/criemen/ruby-bazel
...
Ruby: Start building the language pack using bazel.
2024-02-26 15:52:28 +01:00
Cornelius Riemenschneider
234623ec0d
Merge pull request #15726 from github/criemen/js
...
JS: Remove empty build target.
2024-02-26 15:50:31 +01:00
Geoffrey White
5c4543f167
C++: Mark internal files in the old dataflow library as deprecated (the public imports already are).
2024-02-26 14:49:10 +00:00
Cornelius Riemenschneider
e9b5394cd5
JS: Remove empty build target.
...
The `resources` folder never existed, this was probably introduced
as a copy-paste mistake. Remove the rule.
2024-02-26 15:26:44 +01:00
Harry Maclean
6ff0054e52
Merge pull request #13431 from am0o0/amammad-ruby-YAMLunsafeLoad
...
Ruby: add seperate additional steps between `YAML.parse*` methods and `to_ruby`
2024-02-26 13:40:48 +00:00
Tom Hvitved
f92c106972
Merge pull request #15724 from hvitved/csharp-change-note
...
C#: Add change note
2024-02-26 14:35:38 +01:00
Harry Maclean
8212f5de1b
Ruby: Update test
2024-02-26 13:10:27 +00:00
Harry Maclean
b86643fab2
Ruby: doc fixes
2024-02-26 12:57:21 +00:00
Michael Nebel
cba247788a
C#: Add change note.
2024-02-26 13:51:07 +01:00
Michael Nebel
f9934ed5e7
C#: Add downgrade script.
2024-02-26 13:51:07 +01:00
Michael Nebel
4dd368f7a6
C#: Add upgrade script.
2024-02-26 13:51:07 +01:00
Michael Nebel
80513d846d
C#: Update PrintAst test expected outputs.
2024-02-26 13:51:07 +01:00
Michael Nebel
ff32cf90fd
C#: Add a test for compiler generated statements.
2024-02-26 13:51:06 +01:00
Michael Nebel
e6f4263eff
C#: Do not print compiler generated statements.
2024-02-26 13:51:06 +01:00
Michael Nebel
bf4e3a7d1c
C#: Merge expr_compiler_generated and compiler_generated and add compiler generated statements.
2024-02-26 13:51:06 +01:00
Tom Hvitved
dd0c721e8c
C#: Add change note
2024-02-26 13:48:19 +01:00
Anders Schack-Mulligen
20bb631456
Dataflow: Prevent bad join.
2024-02-26 13:45:19 +01:00
Tom Hvitved
606a8fed0c
Merge pull request #15406 from hvitved/csharp/no-stats-experiment
...
C#: Remove all DB stats
2024-02-26 13:40:37 +01:00
Harry Maclean
8a670fe9a2
Ruby: formatting
2024-02-26 12:26:04 +00:00
Michael Nebel
e5e0b4c537
C#: Add some examples of uses of the Experimental attribute and update the expected test output.
2024-02-26 13:15:55 +01:00
Michael Nebel
bc98712da5
C#: Add one more using statement to the attributes test file.
2024-02-26 13:14:03 +01:00
amammad
32f5667bb6
revert YAML.qll and yaml sinks to previous PR, make a separate experimental query only for yaml
2024-02-26 12:12:03 +00:00
amammad
c582ea626d
update expected test file
2024-02-26 12:10:04 +00:00
amammad
1c1a6f13df
fix QLDoc style
2024-02-26 12:05:35 +00:00
amammad
9c5c8c8362
fix test file
2024-02-26 12:05:35 +00:00
amammad
464e2e4291
fix qldoc and test files
2024-02-26 12:04:52 +00:00
amammad
18fa91bde4
add transform method that is an alias for to_ruby
2024-02-26 11:59:41 +00:00
amammad
a75a004942
add more additional steps, change parse* sinks to reciever of them
2024-02-26 11:59:41 +00:00
amammad
474a4f8abd
thanks @asgerf for informing me that Successor wants to be deprecated and thank him that providing the solution
2024-02-26 11:59:41 +00:00
amammad
1410574f76
make seperate steps for YAML.parse* and use getAsuccessor*() to reach final to_ruby method call, All parts have Rewritten with API graphs exclusively
2024-02-26 11:59:35 +00:00
Harry Maclean
f7b8e8af41
Ruby: Include request forgery sinks from MaD
2024-02-26 11:34:11 +00:00
Harry Maclean
8bed3fbed4
Ruby: Add basic model for Terrapin library
2024-02-26 11:32:41 +00:00
Harry Maclean
9d13a1ff51
Ruby: Add model for Process.spawn
2024-02-26 11:26:38 +00:00
Harry Maclean
d1847566b6
Ruby: Ql4QL fix
2024-02-26 11:26:38 +00:00
Harry Maclean
beef9965cc
Ruby: Model Open4 library
...
Also remove duplicate modeling of Process.spawn.
2024-02-26 11:26:38 +00:00
Harry Maclean
a03c06802e
Ruby: Add some more command injection sinks
2024-02-26 11:26:38 +00:00
Cornelius Riemenschneider
1657b314c1
Re-pin ruby extractor deps.
2024-02-26 11:21:23 +00:00
Cornelius Riemenschneider
688b9955a0
Address review, start accomodating bzlmod.
2024-02-26 11:21:23 +00:00
Cornelius Riemenschneider
b82ffd40e7
Fix windows CI build.
...
As we're now checking out the `codeql` repo in a sub-path,
we need to enable long paths on Windows.
2024-02-26 11:21:23 +00:00
Cornelius Riemenschneider
fd85c44129
Ruby: Start building the language pack using bazel.
...
This PR introduces a bazel and `rules_rust`-based build system
for the ruby extractor and language pack.
This replacese the existing, `cargo` and `cross`-based build system.
For local development, nothing changes, and the existing `cargo`-based
build still keeps working as-is.
We no longer need to use `cross` to compile our Linux binaries,
as we now can link against our hermetic C++ toolchain, which ships
with an old enough glibc, so that we don't run into symbol version issues
when deploying the binaries to older systems.
Besides the one change in dependency (explained in detail in `Cargo.toml`
and in https://github.com/github/codeql/pull/15595 ), nothing ought to
change in how we build the extractor.
2024-02-26 11:21:22 +00:00
Joe Farebrother
386defc3c7
Update test output
2024-02-26 11:21:03 +00:00
Anders Schack-Mulligen
c22cbf5b01
Merge pull request #15721 from aschackmull/workflows/format-check-shared
...
Workflows: Run format check on shared.
2024-02-26 12:12:29 +01:00
Joe Farebrother
fb06e9f6b2
Merge pull request #15719 from joefarebrother/ruby-changenote-formatting
...
Ruby: Fix change note formatting
2024-02-26 11:12:01 +00:00
Harry Maclean
dd092fd18f
Ruby: Fix CSRF test
2024-02-26 11:02:54 +00:00
Jeroen Ketema
acf3a99dff
Merge pull request #15716 from jketema/command-line-options
...
C++: Update test after extractor changes
2024-02-26 12:01:03 +01:00
Rasmus Wriedt Larsen
4ede553b21
Merge pull request #15365 from RasmusWL/lgtm_index_filter_handling
...
Tree sitter extractor: Proper handling of `LGTM_INDEX_FILTERS`
2024-02-26 11:59:45 +01:00
Tom Hvitved
5f5bcf686d
Update csharp/ql/lib/semmle/code/csharp/AnnotatedType.qll
...
Co-authored-by: Michael Nebel <michaelnebel@github.com >
2024-02-26 11:35:28 +01:00
Anders Schack-Mulligen
dab8e237e6
Workflows: Run format check on shared.
2024-02-26 11:33:00 +01:00
Tom Hvitved
5b1fb8789a
C#: Implement View CFG query
2024-02-26 11:23:49 +01:00
Tom Hvitved
5b6e76c030
Move View CFG implementation from Ruby/Swift into shared library
2024-02-26 11:23:49 +01:00
Rasmus Wriedt Larsen
1cfac50749
Python: Add precision to NoSQL query
...
Due to this, it was not part of any query suite :O
2024-02-26 11:23:43 +01:00
Joe Farebrother
403a1ac483
Fix change note formatting
2024-02-26 10:21:26 +00:00
Joe Farebrother
2257df5c6f
Model Arel::Nodes::SqlLiteral.new
2024-02-26 10:09:33 +00:00
Tom Hvitved
8fbe62ccae
Swift: Implement getExtension and getStem
2024-02-26 10:33:57 +01:00
Jeroen Ketema
788100d475
C++: Update test after extractor changes
2024-02-26 10:04:42 +01:00
Tom Hvitved
03a125de38
Merge pull request #15562 from Marcono1234/patch-2
...
Ruby: Fix formatting in changelog
2024-02-26 10:03:29 +01:00
Tom Hvitved
4bd79c0eb3
Add change note
2024-02-26 09:58:23 +01:00
Rasmus Wriedt Larsen
07223031e8
Merge branch 'main' into lgtm_index_filter_handling
2024-02-26 09:56:02 +01:00
Tom Hvitved
acd52192d1
C#: Adopt shared variable capture library
2024-02-26 09:53:30 +01:00
Tom Hvitved
7197c64e2d
C#: Add more variable capture tests
2024-02-26 09:53:29 +01:00
erik-krogh
0056067a17
Merge branch 'main' into ts-54
2024-02-25 21:20:43 +01:00
erik-krogh
083f56921c
update to 5.4.1-rc
2024-02-25 21:20:41 +01:00
am0o0
a636c47c84
minor test cases change: remove unused dict
2024-02-25 23:57:58 +04:00
amammad
4321c5c2da
update Twisted document link
2024-02-25 17:53:19 +04:00
amammad
7dd1389b9e
add twisted SSH client as secondary server command injection sinks, add proper test cases
2024-02-25 17:52:24 +04:00
amammad
ab219902a9
add jsonpickle and pexpect libs in case of unsafe decoding and secondary command execution, add proper test cases
2024-02-25 17:15:35 +04:00
amammad
3e6b4a161b
finalize Secondary server command injection queries and tests.
2024-02-25 14:24:42 +04:00
amammad
95c9a3fc9a
add ssh client libraries, add SecondaryServerCmdInjectionCustomizations
2024-02-25 12:50:12 +04:00
amammad
385c3ba7ff
continue to convert paramiko query to a more general query,
...
the proxy command is not a secondary command execution
so we can add proxy command to SystemCommandExecution::Range, update QLDocs,
add a proper Paramiko test case
fix a typo
2024-02-25 01:18:34 +04:00
amammad
70282f9ebe
convert paramiko query to SecondaryServerCmdInjection query, Add inline tests
2024-02-24 18:10:13 +04:00
amammad
d234a53c50
update Fabric models, add new sink to Fabric, add proper test cases
2024-02-24 17:43:51 +04:00
amammad
076faa3a4e
add pyTorch :) code execution sinks, add proper tests
2024-02-24 15:55:33 +04:00
amammad
3d7db0e46b
add panas code execution sinks, add proper tests
2024-02-24 14:44:06 +04:00
Tom Hvitved
2683e40038
Merge pull request #15708 from hvitved/share-ide-contextual
...
Share `getFileBySourceArchiveName` implementation
2024-02-23 19:56:33 +01:00
Chris Smowton
12213a0a08
Add test
2024-02-23 18:39:16 +00:00
Ian Lynagh
bfea40fca0
Kotlin 2: Accept some PrintAst changes in library-tests/exprs
2024-02-23 18:39:06 +00:00
Chris Smowton
d57160db5c
Direct map stores via a post-update node
2024-02-23 16:37:26 +00:00
Robert Marsh
da5e3d64ac
C++: autoformat
2024-02-23 16:20:42 +00:00
Robert Marsh
dd97584eff
C++: fix for duplicated parent of ReturnVoid statements
2024-02-23 16:19:34 +00:00
Ian Lynagh
1abd81ec34
Kotlin 2: Accept loc changes in library-tests/reflection
2024-02-23 13:52:05 +00:00
Ian Lynagh
f43e929d1a
Kotlin: More generated elements in Kotlin 2 in library-tests/reflection
2024-02-23 13:45:58 +00:00
Paolo Tranquilli
6b63492d6b
Merge pull request #15699 from github/criemen/bazel7-2
...
Upgrade to bazel 7.0.2.
2024-02-23 14:15:00 +01:00
Tamás Vajk
72f73553ca
Merge pull request #15692 from tamasvajk/buildless/no-dotnet-sdk
...
C#: Download latest dotnet SDK when missing
2024-02-23 13:24:46 +01:00
Tony Torralba
759b74791c
Java: Re-enable Widget.qll flow steps
...
The library Widget.qll was accidentally removed from the global context when its sources were migrated to models-as-data in #13136 . This re-adds it so that its flow steps are enabled again.
2024-02-23 13:07:35 +01:00
Harry Maclean
f5be407989
Ruby: deprecate old ProtectFromForgeryCall class
2024-02-23 12:02:26 +00:00
Ian Lynagh
047a8b400e
Merge pull request #15703 from igfoo/igfoo/k2mf
...
Kotlin: Accept changes in library-tests/multiple_files
2024-02-23 11:49:05 +00:00
Ian Lynagh
ee967e62e1
Merge pull request #15704 from igfoo/igfoo/k2ministdlib
...
Kotlin: Remove the Kotlin 2 ministdlib test
2024-02-23 11:48:55 +00:00
Owen Mansel-Chan
3dc6918356
Merge pull request #15648 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-02-23 11:48:17 +00:00
Harry Maclean
7b3f1a0982
Ruby: fix comment
2024-02-23 11:14:52 +00:00
Harry Maclean
081c1201ed
Ruby: Make csrf query more specific
...
CSRF protection only needs to be explicitly enabled on Rails
applications < 5.2 _or_ those that don't include a `load_defaults` call
with a version >= 5.2.
2024-02-23 11:13:17 +00:00
Harry Maclean
3ee425cc47
Ruby: Identify ActionController::API
...
`ActionController::API < ActionController::Base` is a base controller
class, so we should recognise it as such.
2024-02-23 11:13:17 +00:00
Harry Maclean
32b775fdc3
Ruby: reduce duplicate alerts for csrf query
...
Only generate an alert on the top-most vulnerable Rails controller in
the controller tree.
2024-02-23 11:13:17 +00:00
Harry Maclean
1fbf177b54
Ruby: QLDoc fix
2024-02-23 11:13:16 +00:00
Harry Maclean
3499d169f9
Ruby: Add missing QLDoc
2024-02-23 11:13:16 +00:00
Harry Maclean
0597b2ed1b
Ruby: recognise csrf_meta_tag
...
csrf_meta_tag is an alias for csrf_meta_tags, retained for backwards
compatibility.
2024-02-23 11:13:16 +00:00
Harry Maclean
f19a5a9837
Ruby: Add tests for Gemfile modeling
2024-02-23 11:13:16 +00:00
Harry Maclean
3c69ab10f2
Ruby: Restrict rb/csrf-protection-not-enabled
...
This query only applies to codebases using Ruby on Rails < 5.2, or where
there is no call to `csrf_meta_tags` in the base ERb template.
2024-02-23 11:13:15 +00:00
Harry Maclean
581072721c
Ruby: Add change note
2024-02-23 11:13:15 +00:00
Harry Maclean
6d6f8ba512
Ruby: Make CSRF query more sensitive
...
Generate an alert for every controller class that doesn't have or
inherity a `protect_from_forgery` setting.
2024-02-23 11:13:15 +00:00
Harry Maclean
49d826f667
Ruby: Add a query for CSRF protection not enabled
...
Specifically in Rails apps, we look for root ActionController classes
without a call to `protect_from_forgery`.
2024-02-23 11:13:14 +00:00
Erik Krogh Kristensen
a0f91fbc15
Merge pull request #15706 from erik-krogh/pol-reg
...
ReDoS: Restrict some edges related to upper/lower-case when constructing possible attack strings for polynomial-redos.
2024-02-23 12:06:17 +01:00
Tom Hvitved
62b16c0fa3
Share getFileBySourceArchiveName implementation
2024-02-23 11:25:49 +01:00
Tamas Vajk
20f795c03a
Code quality improvements
2024-02-23 11:20:15 +01:00
Michael Nebel
1a155b3a30
Merge pull request #15667 from michaelnebel/csharp/syntheticconstructorbody
...
C#: Add synthetic bodies and inititializers for default constuctors.
2024-02-23 11:14:00 +01:00
Tom Hvitved
94113521d1
Merge pull request #15689 from hvitved/ruby/no-field-branch-limit-summarized-callable
...
Ruby: No `fieldFlowBranchLimit` for `SummarizedCallable`s
2024-02-23 10:47:22 +01:00
Tom Hvitved
d8645cc960
Merge pull request #15694 from hvitved/csharp/assignable-definition-node
...
C#: Use separate `newtype` branch for `AssignableDefinitionNode`
2024-02-23 10:45:04 +01:00
github-actions[bot]
b2b5aa18b2
Add changed framework coverage reports
2024-02-23 00:16:49 +00:00
Tom Hvitved
303a2bb63a
C#: Update expected test output
2024-02-22 21:04:55 +01:00
Tom Hvitved
ea7d9c97fd
C#: Use separate newtype branch for AssignableDefinitionNode
2024-02-22 21:04:55 +01:00
Ian Lynagh
8d358a9f64
Kotlin: Remove the Kotlin 2 ministdlib test
...
Upstream doesn't plan to fix it before the K2 release:
https://youtrack.jetbrains.com/issue/KT-62183/K2-no-stdlib-doesnt-behave-as-expected
I've made a ticket to remind us to return to this later.
2024-02-22 19:01:22 +00:00
Geoffrey White
573763a4b3
Shared: More revisions, manual and aided by further discussion with Copilot.
2024-02-22 18:59:35 +00:00
Ian Lynagh
cf441d1a30
Kotlin: Accept changes in library-tests/multiple_files
...
I think that this is a regression, but one that we're not likely to fix
soon, so let's just accept the output for now. I've opened a ticket to
remind us to return to this.
2024-02-22 18:57:12 +00:00
Robert Marsh
6f7f68fee8
Merge branch 'main' into rdmarsh2/cpp/ir-synthetic-destructors
2024-02-22 18:10:13 +00:00
Geoffrey White
797fee9c9e
Swift: Change note.
2024-02-22 17:54:53 +00:00
Mathias Vorreiter Pedersen
63a5b49846
Merge pull request #15633 from MathiasVP/model-experiments
...
C++: Assume modelled functions always override buffers by default
2024-02-22 18:48:24 +01:00
Geoffrey White
47a9a8b82a
Swift: MAke TypeDecl.getFullName robust to when there's an ExtensionDecl extending more than one thing.
2024-02-22 17:39:57 +00:00
Geoffrey White
515e93522f
Swift: Make ExtensionDecl.toString robust to when there's more than one extended thing.
2024-02-22 17:39:57 +00:00
Cornelius Riemenschneider
d2e6746e7f
Upgrade to bazel 7.0.2.
2024-02-22 17:51:17 +01:00
Robert Marsh
942a4ed925
C++: move handlesDestructorsExplicitly up to TranslatedReturnStmt
2024-02-22 16:46:19 +00:00
Robert Marsh
ebe6ee5257
C++: accept test changes from extractor fixes
2024-02-22 16:44:19 +00:00
Mathias Vorreiter Pedersen
c7ee5b2912
Merge branch 'main' into model-experiments
2024-02-22 16:40:17 +00:00
Harry Maclean
fbc689227d
Merge pull request #15604 from p-/p--rails-more-request-sources
...
Ruby: add additional sources on the request object of Rails
2024-02-22 16:35:59 +00:00
Tamas Vajk
50f9354ca8
Remove redundant using
2024-02-22 17:14:02 +01:00
Tamas Vajk
e176b32a83
Remove environment dictionary passing
2024-02-22 17:12:38 +01:00
Paolo Tranquilli
6c5e5966c3
Merge pull request #15583 from github/redsun82/bzlmod
...
Bazel: use bzlmod
2024-02-22 17:06:59 +01:00
Tamas Vajk
648c06ce27
Simplify dotnet SDK check in autobuilder
2024-02-22 16:44:46 +01:00
Mathias Vorreiter Pedersen
0bf29f0a62
Merge branch 'main' into model-experiments
2024-02-22 15:05:53 +00:00
Paolo Tranquilli
b7df26e6c9
Bazel: make codeql compatible with workspace setup
2024-02-22 15:50:02 +01:00
Paolo Tranquilli
b1e0287a7c
Merge branch 'main' into redsun82/bzlmod
2024-02-22 15:35:41 +01:00
Ben Rodes
47f94e2ebe
Merge branch 'main' into cpp-non-constant-format-as-path-query
2024-02-22 06:24:18 -08:00
Ian Lynagh
2b4b512611
Merge pull request #15693 from igfoo/igfoo/kot2b4
...
Kotlin: Update to 2.0.0-Beta4
2024-02-22 14:06:32 +00:00
Joe Farebrother
2ebb80b632
Merge pull request #15548 from joefarebrother/android-local-auth-keys
...
Java: Add query for insecurely generated keys for local authentication.
2024-02-22 14:04:17 +00:00
Joe Farebrother
67e8f17c4c
Merge pull request #15619 from joefarebrother/ruby-activerecord-connection
...
Ruby: Add additional sql sinks for ActiveRecord connection methods
2024-02-22 14:02:31 +00:00
Joe Farebrother
1f409b0456
Merge pull request #15671 from joefarebrother/ruby-activerecord-extra-args
...
Ruby: Consider additional arguments to certain `ActiveRecord` methods as sql injection sinks.
2024-02-22 14:01:56 +00:00
Tamas Vajk
c0d82cb73e
Minor improvement to not start dotnet process when it is known to fail
2024-02-22 14:58:00 +01:00
Tom Hvitved
c55354b544
Merge pull request #15688 from hvitved/ruby/multi-variable-capture
...
Ruby: Fix bug in `allowParameterReturnInSelf`
2024-02-22 14:51:09 +01:00
Mathias Vorreiter Pedersen
350d5bf0ce
C++: Update QLDoc on 'modeledFlowBarrier'.
2024-02-22 13:30:39 +00:00
Tamas Vajk
8e64880e86
Fix and add unit tests
2024-02-22 14:27:28 +01:00
Mathias Vorreiter Pedersen
671904d58c
C++: Fix QLoc on 'PartialFlowFunction'.
2024-02-22 13:27:10 +00:00
Mathias Vorreiter Pedersen
aca3970c33
C++: Fix QLoc on 'isPartialWrite'.
2024-02-22 13:25:13 +00:00
Taus
f1392712ee
Python: Add .copy() as a copy step
2024-02-22 13:09:27 +00:00
Taus
5125973f9b
Python: Add test case for .copy() as a copy step
2024-02-22 13:01:03 +00:00
Paolo Tranquilli
fe6b27bcf8
Merge branch 'main' into redsun82/bzlmod
2024-02-22 13:45:09 +01:00
Michael Nebel
a24a57c586
C#: Update most other test cases to reflect the synthesized constructor calls and bodies.
2024-02-22 13:33:30 +01:00
Michael Nebel
a4ab163532
C#: Update test output for cfg tests.
2024-02-22 13:33:29 +01:00
Michael Nebel
d19c83228e
C#: Do not bind comments to compiler generated statements.
2024-02-22 13:33:29 +01:00
Michael Nebel
cf9c3d5dd1
C#: Remove un-needed code as we extract synthetic default constructors.
2024-02-22 13:33:29 +01:00
Michael Nebel
14de39a854
C#: Also add synthetic bodies and inititializers for default constructors.
2024-02-22 13:33:29 +01:00
Ian Lynagh
245ce2208e
Kotlin: Update to 2.0.0-Beta4
2024-02-22 12:33:00 +00:00
erik-krogh
bf22f4a870
update expected output
2024-02-22 13:21:11 +01:00
Michael Nebel
7ce7b58ce0
Merge pull request #15657 from michaelnebel/csharp/recordflow
...
C#: Use primary constructors for record types for dataflow.
2024-02-22 13:18:29 +01:00
erik-krogh
e74e5b3613
try to restrict the edges we follow (related to upper/lower-case) when contructing possible attack-strings for polynomial-redos
2024-02-22 13:15:17 +01:00
Felicity Chapman
95ce0cd640
Merge pull request #15691 from github/felicitymay-patch-1
...
Remove period from 'name' for Java query
2024-02-22 11:50:21 +00:00
Tamas Vajk
976c627d52
C#: Download latest dotnet SDK when missing
2024-02-22 12:07:15 +01:00
Paolo Tranquilli
3bea642d5c
Bazel: fix typo
2024-02-22 11:58:02 +01:00
Paolo Tranquilli
fd485d06aa
Merge branch 'main' into redsun82/bzlmod
2024-02-22 11:54:14 +01:00
Paolo Tranquilli
0471287cdd
Bazel: remove unstable lock file
2024-02-22 11:53:47 +01:00
Felicity Chapman
4810657515
Remove period from 'name'
...
This is an error for the Docs content linter and does not match the style guide for query help.
2024-02-22 10:50:45 +00:00
Mathias Vorreiter Pedersen
d953a9a523
Merge pull request #15662 from jketema/destructors6
...
C++: Support destructors for range-based for-loops
2024-02-22 11:41:39 +01:00
Paolo Tranquilli
f1bdd6bdda
Bazel: switch to erroring out by default on outdated lock file
2024-02-22 11:26:39 +01:00
Michael Nebel
f2c849c737
C#: Simplify.
2024-02-22 11:19:34 +01:00
Michael Nebel
2afcc611ce
C#: Fix formatting.
2024-02-22 11:18:00 +01:00
Paolo Tranquilli
b66153be97
Merge branch 'main' into redsun82/bzlmod
2024-02-22 11:15:07 +01:00
Paolo Tranquilli
a14c2ae8ab
Bazel: bump rules_python to 0.31.0
2024-02-22 11:14:53 +01:00
Joe Farebrother
ef124695a5
Apply suggestions from documentation review
...
Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com >
2024-02-22 10:11:49 +00:00
Paolo Tranquilli
67222f8f7e
Bazel: add module lock file
2024-02-22 11:09:15 +01:00
Paolo Tranquilli
cda4ca68f8
Bazel: tweak .bazelrc
2024-02-22 11:08:50 +01:00
Paolo Tranquilli
7410522660
Bazel: bump version to 6.5.0
2024-02-22 11:08:33 +01:00
Ian Lynagh
b405c5fc02
Merge pull request #15683 from igfoo/igfoo/expr
...
Kotlin: Accept some Kotlin 2 location changes
2024-02-22 10:00:01 +00:00
Joe Farebrother
92bdd637a3
Address reveiw comment - add create nd remove select_insert
2024-02-22 09:55:46 +00:00
Michael Nebel
21aa025db2
Update csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll
...
Co-authored-by: Tom Hvitved <hvitved@github.com >
2024-02-22 10:40:54 +01:00
Tom Hvitved
ebee35b385
Ruby: No fieldFlowBranchLimit for SummarizedCallables
2024-02-22 10:27:25 +01:00
Tom Hvitved
23869fc8e6
Ruby: Fix bug in allowParameterReturnInSelf
2024-02-22 09:43:52 +01:00
Tom Hvitved
007d08ea63
Ruby: Add another variable capture test
2024-02-22 09:39:01 +01:00
Tamás Vajk
9ecac04709
Merge pull request #15680 from tamasvajk/buildless/no-mono-fallback-impr
...
C#: Improve fallback nuget package restore in buildless
2024-02-22 08:40:16 +01:00
Paolo Tranquilli
c15d3ab08a
Merge branch 'main' into redsun82/bzlmod
2024-02-22 06:05:37 +01:00
Robert Marsh
875ab74c28
Merge branch 'main' into rdmarsh2/cpp/ir-synthetic-destructors
...
Fixes conflicts in C++ IR tests and Stmt.qll
2024-02-21 21:34:49 +00:00
Robert Marsh
66743fb0db
C++: refactor TranslatedReturnStmt
2024-02-21 20:50:30 +00:00
Robert Marsh
e0c7849f52
C++: fix incorrect use of getChildInternal
2024-02-21 20:35:58 +00:00
Ian Lynagh
218a3877d2
Merge pull request #15682 from igfoo/igfoo/propStackOverflow
...
Java: Properties: Add a test that used to give a stack overflow
2024-02-21 19:35:32 +00:00
Asger F
db10c229de
Merge pull request #15663 from asgerf/js/endpoint-naming2
...
JS: Improvements to endpoint naming
2024-02-21 19:36:57 +01:00
amammad
1927530517
update tests after branch update
2024-02-21 22:15:23 +04:00
Am
376c6ea09a
Merge branch 'main' into amammad-go-bombs
2024-02-21 21:42:25 +03:30
Geoffrey White
7b85bb4c95
Shared: Autoformat.
2024-02-21 17:54:00 +00:00
Geoffrey White
4367b7813c
Shared: Use more standard QLDoc phrasing.
2024-02-21 17:54:00 +00:00
Geoffrey White
d1c0294551
Shared: Delete hallucinated return values.
2024-02-21 17:54:00 +00:00
Geoffrey White
5e401abccb
Shared: Undo changes to existing QLDoc.
2024-02-21 17:53:59 +00:00
Geoffrey White
2f1d4b923e
Shared: Generate some QLDoc using the "GitHub Copilot: Generate Docs" command.
2024-02-21 17:53:59 +00:00
Benjamin Rodes
8d35db0fe6
Making argv filter positional.
2024-02-21 12:25:35 -05:00
Ian Lynagh
e6f70385f4
Kotlin: Accept more loc changes in library-tests/exprs
2024-02-21 17:23:03 +00:00
Ian Lynagh
006b682333
Kotlin: Accept more loc changes in library-tests/exprs
2024-02-21 17:18:06 +00:00
Ian Lynagh
36b304d9a1
Kotlin: Accept some locations in library-tests/exprs
2024-02-21 17:13:50 +00:00
Ian Lynagh
212d5def16
Kotlin: Accept more loc changes in library-tests/exprs
...
These are more instances of the same changes as the previous 2 commits
2024-02-21 17:04:49 +00:00
Ian Lynagh
1b98dc16ba
Kotlin: Accept some more loc changes in library-tests/exprs
2024-02-21 17:02:59 +00:00
Ian Lynagh
5ecdc29808
Kotlin: Accept some loc changes in library-tests/exprs
...
These aren't ideal, but I think they will be improve once we handle
pre/post inc/decrement properly.
2024-02-21 17:00:23 +00:00
Jeroen Ketema
f9d391d087
C++: Support destructors for range-based for-loops
2024-02-21 17:26:32 +01:00
Paolo Tranquilli
3ca9d70100
Bazel: drop experimental from bzlmod flag
2024-02-21 16:53:08 +01:00
Paolo Tranquilli
61bfe7e520
Bazel: rename internal module to semmle_code
2024-02-21 16:51:39 +01:00
Paolo Tranquilli
cb5e3c336d
Merge branch 'main' into redsun82/bzlmod
2024-02-21 16:47:36 +01:00
Robert Marsh
339c89019a
Merge pull request #15681 from jketema/destructors6b
...
C++: Add IR test where the for loop should call destructors at the end of its body
2024-02-21 10:20:46 -05:00
Tamás Vajk
e13d6cdd57
Merge pull request #15678 from tamasvajk/fix/integration-test-paths
...
C#: Modify reported assembly paths in integration tests
2024-02-21 15:26:36 +01:00
Paolo Tranquilli
3df3fbc65b
Merge branch 'main' into redsun82/bzlmod
2024-02-21 15:01:19 +01:00
Ian Lynagh
9948052fb6
Java: Properties: Add a test that used to give a stack overflow
2024-02-21 13:51:53 +00:00
Jeroen Ketema
11dc467add
C++: Add test where the for loop should call destructors at the end of its body
2024-02-21 14:42:23 +01:00
Jeroen Ketema
8bbfb82f8e
Merge pull request #15670 from jketema/destructors7
...
C++: Add IR tests for destruction of static locals
2024-02-21 12:54:38 +01:00
Ian Lynagh
204be4a809
Merge pull request #15669 from igfoo/igfoo/operator-overloads
...
Kotlin 2: Accept changes in library-tests/operator-overloads
2024-02-21 11:36:16 +00:00
Ian Lynagh
3c35683e25
Merge pull request #15668 from igfoo/igfoo/interface-delegate
...
Kotlin 2: Accept location changes in library-tests/interface-delegate
2024-02-21 11:35:59 +00:00
Tamas Vajk
0c46b493c3
C#: Improve fallback nuget package restore in buildless
...
Fallback cases coming from `<PackageReference />` and `packages.config` are now differentiated. In the latter case we're restoring the package through projects that target `net481`.
2024-02-21 11:58:02 +01:00
Paolo Tranquilli
31959eaf1f
Merge branch 'main' into redsun82/bzlmod
2024-02-21 11:20:55 +01:00
Michael Nebel
a0b44c0fc1
C#: Update other tests expected output.
2024-02-21 10:57:22 +01:00
Michael Nebel
0d32192f62
C#: Update expected test output.
2024-02-21 10:57:22 +01:00
Michael Nebel
b76a27bba2
C#: Make a store step from explicit parameter nodes on primary constructors to the property of the same name for record types.
2024-02-21 10:57:22 +01:00
Anders Schack-Mulligen
71f8ccf45f
Merge pull request #15654 from aschackmull/java/static-init-vec-query-perf
...
Java: Switch helper flow from Global to SimpleGlobal in StaticInitializationVectorQuery.
2024-02-21 10:51:16 +01:00
Michael Nebel
132b8baa57
C#: Delete summarized callable implementation for record flow and update expected output.
2024-02-21 10:33:19 +01:00
Michael Nebel
009ea1bcfd
C#: Add test examples for record flow and update expected test output.
2024-02-21 10:31:07 +01:00
Jeroen Ketema
57cb7f8218
C++: Update tests after extractor changes related to static variables
2024-02-21 10:22:59 +01:00
Jeroen Ketema
c1f18edfed
C++: Add IR tests for destruction of static locals
2024-02-21 10:22:59 +01:00
Michael Nebel
f072e41d50
Merge pull request #15652 from michaelnebel/csharp/constructorflow
...
C#: Read-only property flow.
2024-02-21 10:12:46 +01:00
Tamas Vajk
e1e29f277c
C#: Modify reported assembly paths in integration tests
2024-02-21 09:39:19 +01:00
Michael Nebel
060133d3e9
C#: Add change note.
2024-02-21 09:34:21 +01:00
Tamás Vajk
70a2d16b1a
Merge pull request #15600 from tamasvajk/buildless/no-mono-dlls
...
C# Change desktop dotnet assembly lookup to fall back to nuget reference assemblies
2024-02-21 08:36:41 +01:00
Paolo Tranquilli
c5ed96b4f8
Merge branch 'main' into redsun82/bzlmod
2024-02-21 06:22:10 +01:00
Chris Smowton
f2e04c0cb2
Merge pull request #15672 from github/post-release-prep/codeql-cli-2.16.3
...
Post-release preparation for codeql-cli-2.16.3
2024-02-20 21:59:55 +00:00
amammad
4c769f2b09
update tests
2024-02-21 01:10:35 +04:00
amammad
3307457deb
use implements predicate for io interfaces,
...
so we can reduce many repetitive parts of query
2024-02-21 01:07:31 +04:00
amammad
13b0a9a842
New testcase 's2Reader.ReadByte()'
2024-02-21 01:05:57 +04:00
amammad
905420143b
call functions in the same order as the function declarations
2024-02-21 00:19:51 +04:00
Edward Minnix III
c5dbaa6bfd
Docs team review suggestions
...
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com >
2024-02-20 14:17:06 -05:00
Ed Minnix
8be9b8b818
Add note about collapsing multiple rows into one
2024-02-20 14:17:05 -05:00
Ed Minnix
e2511cdbe4
Add neutral model note to C# documentation
2024-02-20 14:17:04 -05:00
Ed Minnix
8058096d7d
Add note about neutrals to Java documentation
2024-02-20 14:17:02 -05:00
Edward Minnix III
6665248c19
Review suggestions
...
Co-authored-by: Michael Nebel <michaelnebel@github.com >
2024-02-20 14:17:01 -05:00
Ed Minnix
ae59ea3152
Oxford comma
2024-02-20 14:17:00 -05:00
Ed Minnix
3f10dd06f2
Correct indices in example
2024-02-20 14:16:59 -05:00
Ed Minnix
65db990c97
Remove threat model mentions
2024-02-20 14:16:57 -05:00
Ed Minnix
bb86ce5749
Remove references to model editor
2024-02-20 14:16:56 -05:00
Ed Minnix
698109ae10
Introduce C# MaD documentation
2024-02-20 14:16:55 -05:00
Ed Minnix
77ef63a051
Modify Java docs to use common models-as-data beta notice
2024-02-20 14:16:53 -05:00
Ed Minnix
54d7805e4a
Modify Java threat model link to be Java-specific
2024-02-20 14:16:51 -05:00
yoff
d3ee5f65db
Merge pull request #15550 from yoff/python/remove-pointsto-from-module-getAnExport
...
python: remove a use of points-to
2024-02-20 19:04:46 +01:00
github-actions[bot]
37f8fa3413
Post-release preparation for codeql-cli-2.16.3
2024-02-20 16:50:47 +00:00
Joe Farebrother
10da4d14d9
Add addtional arguments as sinks to certain methods
2024-02-20 16:35:29 +00:00
Pierre
2da00986c0
Merge pull request #15664 from alexrford/rb/rm-library-models-cust-docs
...
Ruby: remove `customizing-library-models-for-ruby.rst`
2024-02-20 17:03:18 +01:00
Ian Lynagh
fbf70c688f
Kotlin 2: Accept changes in library-tests/operator-overloads
...
This also brings the Kotlin 2 output back in line with the Kotlin 1
output.
2024-02-20 15:41:22 +00:00
Ian Lynagh
67d0415942
Kotlin 2: Accept loc changes in library-tests/interface-delegate
...
We lose a location here, but this makes the Kotlin 2 results more
similar to the Kotlin 1 results.
2024-02-20 15:27:43 +00:00
Pierre
0d734983b4
Merge branch 'main' into rb/rm-library-models-cust-docs
2024-02-20 16:20:41 +01:00
Chris Smowton
8a00a45b32
Merge pull request #15666 from github/release-prep/2.16.3
...
Release preparation for version 2.16.3
2024-02-20 15:15:41 +00:00
Michael Nebel
d6f657cfd7
C#: Update expected test output.
2024-02-20 15:55:19 +01:00
Michael Nebel
e4d41194b4
C#: Include store steps into readonly properties.
2024-02-20 15:55:19 +01:00
Michael Nebel
3112bf4682
C#: Add some test property inititialization test cases and update expected output.
2024-02-20 15:55:19 +01:00
Geoffrey White
5787dcc82d
C++: Make getStaticCallTarget() return a DataFlowCallable.
2024-02-20 14:49:51 +00:00
Geoffrey White
356214c11b
C++: Implement SummaryReturnNode.
2024-02-20 14:48:02 +00:00
Geoffrey White
5683092d6a
C++: Implement SummaryParameterNode.
2024-02-20 14:48:02 +00:00
Geoffrey White
1ace9ee50f
C++: Create a proper class for DataFlowCallable, that includes summarized callables.
2024-02-20 14:48:02 +00:00
Geoffrey White
e1a5a84253
C++: Create a proper class for DataFlowCall, that includes summarized callables.
2024-02-20 14:48:02 +00:00
github-actions[bot]
6d061fbc35
Release preparation for version 2.16.3
2024-02-20 14:26:23 +00:00
Michael Nebel
ed3dba8334
Merge pull request #15625 from michaelnebel/csharp/primaryconstructorinitializer
...
C# 12: Primary constructor inititalizers.
2024-02-20 15:12:19 +01:00
Max Schaefer
75f66c2191
Add four more sink types.
2024-02-20 13:48:20 +00:00
Anders Schack-Mulligen
5a348a5048
Dataflow: SimpleGlobal / Typetracker perf fix.
2024-02-20 14:40:28 +01:00
Tamás Vajk
029db218fe
Merge pull request #15650 from tamasvajk/buildless/fallback-nuget-install
...
C#: Add fallback logic to `nuget install`
2024-02-20 14:26:44 +01:00
Owen Mansel-Chan
e6f9ef5042
Merge pull request #15643 from owen-mc/java/sensitive-logging
...
Java: Sensitive Logging: Simplify definition of source and improve QLDoc
2024-02-20 13:24:23 +00:00
Alex Ford
5b46256fdb
Ruby: remove customizing-library-models-for-ruby.rst
2024-02-20 13:12:23 +00:00
Asger F
29ffeb6da5
JS: Fix qldoc
2024-02-20 14:00:32 +01:00
Paolo Tranquilli
2cc762b85a
Merge branch 'main' into redsun82/bzlmod
2024-02-20 13:55:57 +01:00
Michael B. Gale
ea676469bb
Merge pull request #15202 from github/mbg/go/1.22
...
Go: Update workflows and expected test results for Go 1.22
2024-02-20 12:32:57 +00:00
Michael Nebel
f246272b5f
C#: Code quality improvements.
2024-02-20 11:48:01 +01:00
Chris Smowton
2e479def89
Merge pull request #15445 from smowton/smowton/admin/java-buildless-classpath-ordering-tests
...
Java: test changes for making buildless' classpath ordering deterministic
2024-02-20 10:03:03 +00:00
Tamás Vajk
e257003641
Merge pull request #15660 from tamasvajk/feature/code-quality
...
C#: Use `nameof` in nullability attributes
2024-02-20 10:47:52 +01:00
Rasmus Lerchedahl Petersen
22e72d2fed
python: Move the rewrite out to Scope.qll
2024-02-20 10:39:29 +01:00
Mathias Vorreiter Pedersen
66622748d9
Merge pull request #15658 from jketema/destructors6a
...
C++: Add more range-based for-loop IR tests
2024-02-20 10:26:23 +01:00
Rasmus Lerchedahl Petersen
de727bf1b5
Revert "python: remove a use of points-to"
...
This reverts commit 5cb71ce7e5 .
2024-02-20 10:23:31 +01:00
Tamas Vajk
d3ba33d3a8
Code quality improvements
2024-02-20 10:22:08 +01:00
Tamas Vajk
b3f5beb076
C#: Use nameof in nullability attributes
2024-02-20 10:05:39 +01:00
Jeroen Ketema
7ec95fba6d
C++: Add more range-based for-loop IR tests
2024-02-20 09:22:13 +01:00
Chris Smowton
83509ce1f7
Test changes
2024-02-19 19:06:37 +00:00
Paolo Tranquilli
ec3cc6376f
Merge branch 'main' into redsun82/bzlmod
2024-02-19 16:42:08 +01:00
Jeroen Ketema
2becb3043e
Merge pull request #15638 from jketema/destructors5
...
C++: Support C++20 range-based for initializers
2024-02-19 16:22:23 +01:00
Max Schaefer
f4c6cf335b
Merge pull request #15651 from github/max-schaefer/release-automodel-query-pack
...
Automodel: Release query pack.
2024-02-19 14:55:49 +00:00
Tony Torralba
1704bfe2bf
Merge pull request #15585 from atorralba/atorralba/go/promote-jwt-unsafe-verification
...
Go: Promote `go/missing-jwt-signature-check` from experimental
2024-02-19 15:35:44 +01:00
Paolo Tranquilli
0787cc5e51
Merge branch 'main' into redsun82/bzlmod
2024-02-19 15:07:42 +01:00
Paolo Tranquilli
164250186a
Merge pull request #15593 from github/redsun82/swift-prebuilt-update
...
Swift: update swift prebuilt package
2024-02-19 15:05:13 +01:00
Paolo Tranquilli
434fd73823
Merge pull request #15653 from github/redsun82/swift-remove-test-sdk
...
Swift: remove test sdk
2024-02-19 15:04:13 +01:00
Paolo Tranquilli
f842eee784
Swift: use includes in picosha2
2024-02-19 14:06:18 +01:00
Paolo Tranquilli
d0e169ebda
Merge branch 'main' into redsun82/bzlmod
2024-02-19 14:05:43 +01:00
Anders Schack-Mulligen
66010b5c96
Java: Switch helper flow from Global to SimpleGlobal in StaticInitializationVectorQuery.
2024-02-19 14:04:43 +01:00
Anders Schack-Mulligen
2fa8c2f992
Merge pull request #15634 from aschackmull/dataflow/simpleglobal-fixreads
...
Dataflow: Bugfix for field reads in SimpleGlobal.
2024-02-19 14:02:38 +01:00
Asger F
c324b2aed8
JS: Refactor
2024-02-19 13:59:49 +01:00
Asger F
eb7d0244c2
JS: Global names don't have to be defined in externs
2024-02-19 13:59:49 +01:00
Asger F
493b37774f
JS: More precise isFunctionSource
2024-02-19 13:59:49 +01:00
Asger F
6d597bea0d
JS: Refactor
2024-02-19 13:59:49 +01:00
Asger F
8a5b907912
JS: Handle wrapper functions more gracefully
2024-02-19 13:59:48 +01:00
Asger F
d96f29d6c2
JS: Disallow return steps in getASinkNode
2024-02-19 13:59:48 +01:00
Asger F
51bed86778
Update EndpointNaming.expected
2024-02-19 13:59:46 +01:00
Asger F
29258ad8c2
WIP new aliasing rule
2024-02-19 13:59:15 +01:00
Asger F
4ef1ac9250
JS: Accept bad test output
2024-02-19 13:59:12 +01:00
Asger F
15bc3c282f
JS: Add test with wrapper function
2024-02-19 13:58:40 +01:00
Tamas Vajk
216d6c0827
Change separator character used in environment variable
2024-02-19 13:58:09 +01:00
Paolo Tranquilli
eb142184f3
Swift: accept test changes
2024-02-19 13:53:19 +01:00
Paolo Tranquilli
ccf7608850
Swift: update swift prebuilt package
2024-02-19 13:47:53 +01:00
Paolo Tranquilli
2b6f100d91
Swift: update qltest test
2024-02-19 13:39:27 +01:00
Paolo Tranquilli
2311e1c5ab
Swift: remove test sdk
...
The test sdk that we were prebuilding to run ql tests is actually not
needed, as the `resource-dir` we package for cross-version compatibility
is enough for running qltests as well.
2024-02-19 13:28:48 +01:00
Tamas Vajk
69c1895065
C#: Add fallback logic to nuget install
2024-02-19 13:08:45 +01:00
Ian Lynagh
ce07d6ad9f
Merge pull request #15645 from igfoo/igfoo/methods
...
Kotlin 2: Accept changes in library-tests/methods
2024-02-19 12:05:03 +00:00
Michael Nebel
feda6bc01b
C#: Update expected test output.
2024-02-19 13:04:13 +01:00
Michael Nebel
d83687125c
C#: Add postupdate nodes for all instance parameter accesses - otherwise we get missing post update nodes to to reverseRead in the data flow consistency queries.
2024-02-19 13:04:13 +01:00
Michael Nebel
28d5c11b6f
C#: Synthesize an empty body for primary constructors.
2024-02-19 13:04:13 +01:00
Michael Nebel
dcde6597bc
C#: Updated expected test output.
2024-02-19 13:04:13 +01:00
Michael Nebel
7a80205519
C#: Extract explicit and implicit primary constructor initializers.
2024-02-19 13:04:12 +01:00
Michael Nebel
c613851c2d
C#: Invert logic in ExtractInitializer.
2024-02-19 13:04:12 +01:00
Michael Nebel
6b38a81e50
C#: Add some test cases for primary constructor inititalizers and a failing dataflow test.
2024-02-19 13:04:12 +01:00
Max Schaefer
139ef60f69
Automodel: Release query pack.
2024-02-19 11:47:31 +00:00
Paolo Tranquilli
b174aa65a3
Bazel: empty out WORKSPACE.bazel
2024-02-19 10:30:48 +01:00
Anders Schack-Mulligen
d1d213d285
Merge pull request #15632 from aschackmull/dataflow/flowfeature-bugfix
...
Dataflow: Fix flow-feature bug for parameterless static functions
2024-02-19 09:24:43 +01:00
Tony Torralba
8b8cebd599
Apply suggestions from code review
...
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com >
2024-02-19 08:59:03 +01:00
Paolo Tranquilli
f41b70af78
Merge branch 'main' into redsun82/bzlmod
2024-02-19 08:35:55 +01:00
Mathias Vorreiter Pedersen
b927968e88
Merge pull request #15516 from microsoft/51-2cppnon-constant-format-alter-not-const-source
...
C++: Change sources in `NonConstantFormat.ql`
2024-02-17 00:01:58 +01:00
Robert Marsh
2494b7d801
C++: fix for IR CFG problem with return in if
2024-02-16 21:08:21 +00:00
Geoffrey White
6e13b877bb
C++: Add FlowSummaryNode and test it.
2024-02-16 18:06:57 +00:00
Robert Marsh
2c8ed6479a
C++: test for return in if
2024-02-16 17:55:34 +00:00
Michael B. Gale
0ad04d45a9
Disable setup-go caching
2024-02-16 17:48:12 +00:00
Michael B. Gale
25f0692e2c
Go: Update expected results for TypeParamType
2024-02-16 17:33:30 +00:00
Michael B. Gale
91ed7a8d79
Go: Use 1.22 in CI
2024-02-16 17:33:23 +00:00
Ian Lynagh
8235aed01a
Kotlin 2: Accept changes in library-tests/methods
...
Mostly location changes, and mostly improvements.
There are a couple of cases where we lose regressions, but this actually
makes those IR elements more consistent with the elements surrounding
them.
2024-02-16 17:18:49 +00:00
Pierre
c05431e08f
Merge pull request #15644 from github/sitedocs/2.16.2
...
Generate changelogs for 2.16.2
2024-02-16 18:15:33 +01:00
Pierre
98dac7573b
Generate changelogs for 2.16.2
2024-02-16 18:02:19 +01:00
Owen Mansel-Chan
22692b9d55
Simplify definition of source and improve QLDoc
...
This is also slightly faster to evaluate (217s instead of 228s on apache/geode on my machine).
2024-02-16 16:47:41 +00:00
Ian Lynagh
3f696c02ab
Merge pull request #15641 from igfoo/igfoo/controlflow-dom
...
Kotlin 2: Accept changes in library-tests/controlflow/dominance
2024-02-16 16:41:41 +00:00
Benjamin Rodes
639642fb67
Formatting.
2024-02-16 11:19:02 -05:00
Benjamin Rodes
0410ed734b
Adding exclusion for main's argv (I believe this and other changes were accidentally removed in prior merge with other non-const branches)
2024-02-16 11:18:06 -05:00
Benjamin Rodes
9f3dd6300f
Fixing query to use path graph.
2024-02-16 11:11:48 -05:00
Paolo Tranquilli
32d6c5ac3d
Javascript: fix project layout for bazel tests
...
On Windows, the project layout needs to match `codeql~override`, while
on POSIX we must keep on matching `ql`. We work around this by using
`*ql*` in the project layout, which matches both.
2024-02-16 17:10:20 +01:00
Paolo Tranquilli
1626344560
Merge branch 'main' into redsun82/bzlmod
2024-02-16 17:10:02 +01:00
Ian Lynagh
92009f515b
Merge pull request #15640 from igfoo/igfoo/controlflow
...
Kotlin 2: Accept changes in library-tests/controlflow/basic
2024-02-16 16:07:48 +00:00
Ian Lynagh
f0f1b043d5
Merge pull request #15639 from igfoo/igfoo/stmts
...
Kotlin 2: Accept changes in library-tests/stmts
2024-02-16 16:07:34 +00:00
Mathias Vorreiter Pedersen
7ea49b6a94
Merge pull request #15637 from MathiasVP/fix-joins-in-irguards
...
C++: Fix joins in `controlsBlock`
2024-02-16 16:56:21 +01:00
Benjamin Rodes
aa7c677e13
Merge branch '51-2cppnon-constant-format-alter-not-const-source' into cpp-non-constant-format-as-path-query
...
# Conflicts:
# cpp/ql/src/Likely Bugs/Format/NonConstantFormat.ql
2024-02-16 10:49:05 -05:00
Benjamin Rodes
c38376a264
Merge branch '51-2cppnon-constant-format-alter-not-const-source' of https://github.com/microsoft/codeql into 51-2cppnon-constant-format-alter-not-const-source
2024-02-16 10:42:04 -05:00
Mathias Vorreiter Pedersen
7c22146f46
C++: Accept query test changes.
2024-02-16 16:33:44 +01:00
Mathias Vorreiter Pedersen
096073d295
C++: Add change note.
2024-02-16 16:29:34 +01:00
Benjamin Rodes
93f2e856af
Formatting update.
2024-02-16 10:28:14 -05:00
Ian Lynagh
9069218f1a
Kotlin 2: Accept changes in library-tests/controlflow/dominance
...
Mostly location changes; also removal of a generated block:
https://youtrack.jetbrains.com/issue/KT-63781/K2-Generated-blocks-appear-in-the-IR
2024-02-16 15:18:56 +00:00
Benjamin Rodes
4a9b2d5027
Comment change.
2024-02-16 10:18:07 -05:00
Michael B. Gale
008585eeba
Go: Include arguments in RunCmd error messages
2024-02-16 15:17:24 +00:00
Michael B. Gale
8886092cd0
Go: Try to ignore errors in go mod vendor calls
2024-02-16 15:15:58 +00:00
Benjamin Rodes
5b0a3dcdbe
Accidental removal of an and.
2024-02-16 10:15:21 -05:00
Benjamin Rodes
95ebbb1bbd
Ql alterations for cleanup as part of merge suggestions.
2024-02-16 10:13:50 -05:00
Ben Rodes
1fb7f089ca
Update cpp/ql/src/Likely Bugs/Format/NonConstantFormat.ql
...
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com >
2024-02-16 10:06:34 -05:00
Ian Lynagh
a5a6020f18
Kotlin 2: Accept changes in library-tests/controlflow/basic
...
Mostly location changes, but also some removal of generated blocks:
https://youtrack.jetbrains.com/issue/KT-63781/K2-Generated-blocks-appear-in-the-IR
2024-02-16 14:37:10 +00:00
Jeroen Ketema
dd39fa0bde
C++: Support C++20 range-based for initializers
2024-02-16 15:20:14 +01:00
Ian Lynagh
5039acba53
Kotlin 2: Accept changes in library-tests/stmts/PrintAst.expected
2024-02-16 14:17:04 +00:00
Ian Lynagh
e8b8b11434
Kotlin 2: Accept changes in library-tests/stmts/exprs.expected
2024-02-16 14:16:18 +00:00
Mathias Vorreiter Pedersen
be54a41593
C++: Accept query test changes.
2024-02-16 15:01:50 +01:00
Mathias Vorreiter Pedersen
06ff46091d
C++: Fix joins in 'controlsBlock'.
2024-02-16 14:49:20 +01:00
Tamas Vajk
c68d36eb79
Remove restored framework packages when user specified framework folders
2024-02-16 14:42:39 +01:00
Ian Lynagh
d6b96c5c23
Kotlin 2: Accept loc changes in library-tests/stmts/stmts.expected
2024-02-16 13:40:44 +00:00
Anders Schack-Mulligen
53801e8efb
Dataflow: Bugfix for field reads in SimpleGlobal.
2024-02-16 14:00:04 +01:00
Mathias Vorreiter Pedersen
b407c86d03
C++: Make Code Scanning happy.
2024-02-16 13:51:34 +01:00
Mathias Vorreiter Pedersen
57c1bf5835
C++: Add file-level QLDoc.
2024-02-16 13:47:02 +01:00
Mathias Vorreiter Pedersen
497592a4d4
C++: Add change note.
2024-02-16 13:36:25 +01:00
Tamas Vajk
ce0159c005
Add dotnet core dependencies to the integration test
2024-02-16 13:35:18 +01:00
Geoffrey White
e187a4a7d6
C++: Add flow summaries to simpleLocalFlowStep.
2024-02-16 12:31:17 +00:00
Tamas Vajk
7e912f0de0
Rename integration test
2024-02-16 13:31:08 +01:00
Mathias Vorreiter Pedersen
9b2019db6b
C++: Accept test changes.
2024-02-16 13:10:41 +01:00
Mathias Vorreiter Pedersen
499ab0892f
C++: Currently, to catch flow in an example such as:
...
```cpp
char* source();
void sink(const char*);
int sprintf(char *, const char *, ...);
void call_sprintf(char* path, char* data) {
sprintf(path, "%s", "abc"); // (1)
sprintf(path, "%s", data); // (2)
}
void foo() {
char path[10];
call_sprintf(path, source()); // (3)
sink(path);
}
```
we identify that the `*path [post update]` node at `// (2)` is a
`ReturnNodeExt` and since `*data` flows to that node flow will be carried
out to `*path [post update]` at // (3) and thus reach `sink(path)`.
The reason `*path [post update]` at `// 2` is recognized as a `ReturnNodeExt`
is because it satisfies the following condition (which is identified by the
shared dataflow library):
There is flow from the parameter node `*path` to the pre-update node of the
post-update node `*path [post update]` at `// (2)`.
However, when we start recognizing that the call to `sprintf(path, ...)` at
`// (1)` overrides the value of `*path` and no longer provide use-use flow out
of `*path` the `*path [post update]` node at `// (2)` is no longer recognized
as a `ReturnNodeExt` (because it doesn't satisfy the above criteria).
Thus, we need to identify the flow above without relying on the dataflow
library's summary mechanism. That is, instead of relying on the dataflow
library's mechanism to summarize the `*data -> *path` flow for `call_sprintf`
we need to:
- Ensure that the write to `*path` at `// (2)` is recognized as the "final"
write to the parameter, and
- Ensure that there's flow out of that parameter and back to
`*path [post update]` at `// (3)`.
Luckiky, we do all of this already to support flow out of writes to parameters
that don't have post-update nodes. For example, in something like:
```cpp
void set(int* x, int y) {
*x = y;
}
void test() {
int x;
set(&x, source());
sink(x);
}
```
So in order to make the original example work, all we need to do is to remove
the restrictions on this mechanism so that the same mechanism that makes the
above example work also makes the original example work!
2024-02-16 13:09:45 +01:00
Joe Farebrother
9ad05fe51c
Address reveiws - Add BAD example to doc, add doc example to tests and fix typo.
2024-02-16 12:00:51 +00:00
Mathias Vorreiter Pedersen
7e9bf2a880
C++: Add a model for 'partial updating' and extend models appropriately.
2024-02-16 12:56:19 +01:00
Mathias Vorreiter Pedersen
24a63ae94d
C++: Block flow by default.
2024-02-16 12:56:19 +01:00
Mathias Vorreiter Pedersen
625c47fa9c
C++: Add a testcase.
2024-02-16 12:56:19 +01:00
Tamas Vajk
1e75c73825
Fix failing integration test
2024-02-16 12:50:13 +01:00
Tamas Vajk
f8b29ad70e
Introduce environment variable to specify framework assembly locations
2024-02-16 11:54:19 +01:00
Anders Schack-Mulligen
03f7968dbf
Dataflow: Fix flow-feature bug.
2024-02-16 11:38:30 +01:00
Angela P Wen
4291c75488
Merge pull request #15631 from github/angelapwen/extend-permissions
...
Add `security-events: write` permission in `ql-for-ql-build.yml`
2024-02-16 02:28:30 -08:00
Anders Schack-Mulligen
ba1a0bc320
Java: Add test highlighting problem.
2024-02-16 11:25:33 +01:00
Angela P Wen
c75111619e
Add security-events: write permission
2024-02-16 02:17:17 -08:00
Tamas Vajk
d358f8e4f2
Move undocumented environment variable names to a common location
2024-02-16 11:15:53 +01:00
Tamas Vajk
b996f7b3ce
Change environment variable for opt-out web view extraction
2024-02-16 11:15:53 +01:00
Tamas Vajk
8f0f6963bb
Change desktop dotnet assembly lookup to fall back to nuget reference assemblies
2024-02-16 11:15:53 +01:00
Tamas Vajk
04f0fb0483
Add integration test with mono assemblies as references
2024-02-16 11:15:52 +01:00
Cornelius Riemenschneider
4e022e2098
Merge pull request #15627 from github/criemen/java-test
...
Move the JS java tests to be a proper `java_test` target.
2024-02-16 11:15:18 +01:00
Erik Krogh Kristensen
037e64a4b5
Merge pull request #15623 from erik-krogh/cs-url
...
C#: update the QHelp for `cs/web/unvalidated-url-redirection`
2024-02-16 11:12:22 +01:00
Óscar San José
d46157135a
Merge pull request #15630 from tamasvajk/fix/change-coverage-updater-permissions
...
Extend permissions in `csv-coverage-update.yml`
2024-02-16 10:58:24 +01:00
Tamas Vajk
89384bb855
Extend permissions in csv-coverage-update.yml
2024-02-16 10:19:16 +01:00
Mathias Vorreiter Pedersen
c19ed4c17e
Merge pull request #15626 from MathiasVP/fix-constness-checking
...
C++: Don't strip specifiers away in `TFinalParameterUse`
2024-02-16 10:09:43 +01:00
Max Schaefer
a95f4128d9
Merge pull request #15554 from github/max-schaefer/automodel-candidate-fixes
...
Automodel: Improve handling of varargs and overriding in extraction queries
2024-02-16 08:51:54 +00:00
Benjamin Rodes
d6b0746b30
The non-constant format query is now a path query. Minor changes to the output alert to be more precise on what is being alerted. Minor changes to the query itself to avoid redundancies with argv.
2024-02-15 12:14:52 -05:00
Ian Lynagh
c6f4a204e9
Merge pull request #15616 from igfoo/igfoo/kt2-exprs
...
Kotlin 2: Accept more location changes
2024-02-15 16:49:28 +00:00
Jeroen Ketema
da3ff4813f
Merge pull request #15612 from jketema/destructors4a
...
C++: Support `constexpr if` in the IR
2024-02-15 17:29:56 +01:00
Max Schaefer
652b6bb8e1
Fix bugs revealed by omittable exists variables.
2024-02-15 16:29:20 +00:00
Max Schaefer
8d4a344d47
Merge pull request #15592 from github/max-schaefer/rephrase-negative-characteristics
...
Automodel: Make description of some negative characteristics more explicit.
2024-02-15 16:20:17 +00:00
Michael B. Gale
4d28c0d2a9
Go: Call go mod vendor to synchronise vendor directory when it exists
2024-02-15 16:19:07 +00:00
Cornelius Riemenschneider
798a1e250e
Move the JS java tests to be a proper java_test target.
...
Previously, we had a `sh_test` wrapping the `java_test` to do some setup.
This was extremely brittle on Windows, and relied on getting a deploy
jar from `java_test`. This breaks when updating to Bazel 7, where the
ability to get a deploy jar from `java_test` was removed.
Therefore, we now do all the test setup in `AllTests.java` instead.
This is much cleaner, and shouldn't break as easily.
2024-02-15 17:02:28 +01:00
Joe Farebrother
e36b9f4d3c
Add tests and change note
2024-02-15 15:26:20 +00:00
Benjamin Rodes
9e50fc6893
Updating tests to account for removing const char* heuristic.
2024-02-15 09:54:03 -05:00
Benjamin Rodes
caf2ee27fa
Adding false negative tests for future work.
2024-02-15 09:43:26 -05:00
Mathias Vorreiter Pedersen
532e8dac45
C++: Don't strip specifiers in 'TFinalParameterUse'.
2024-02-15 14:08:12 +01:00
Owen Mansel-Chan
9cd13cbf37
Merge pull request #15624 from owen-mc/go/update-library-coverage-frameworks
...
Add new libraries we cover to frameworks.csv
2024-02-15 12:55:19 +00:00
Owen Mansel-Chan
6cb4773188
Add new libraries we cover to frameworks.csv
2024-02-15 12:19:49 +00:00
erik-krogh
a5eb2dd906
update the QHelp for cs/web/unvalidated-url-redirection with examples inspired by the JS QHelp
2024-02-15 12:41:01 +01:00
Erik Krogh Kristensen
7c0557269a
Merge pull request #15596 from erik-krogh/url-san
...
C#: Add a few more sanitizers to `cs/web/unvalidated-url-redirection`
2024-02-15 12:09:06 +01:00
Angela P Wen
0643184a7e
Merge pull request #15493 from jsoref/declare-permissions
...
Declare permissions in workflows
2024-02-15 02:52:24 -08:00
Tony Torralba
f4c9052ba9
Merge pull request #15622 from atorralba/atorralba/java/path-sanitizer-equals
...
Java: Expand ExactPathSanitizer to work on the argument of 'equals' too
2024-02-15 11:29:09 +01:00
Tamás Vajk
a5e3643faf
Merge pull request #15621 from tamasvajk/buildless/cleanup
...
C#: Code quality improvements (fixed log message, removed unused interface)
2024-02-15 10:54:47 +01:00
Rasmus Wriedt Larsen
e4c30371f9
Merge pull request #13557 from am0o0/amammad-python-bombs
...
Python: Decompression Bombs
2024-02-15 10:43:12 +01:00
Tony Torralba
90a9d82b9d
Java: Expand ExactPathSanitizer to work on the argument of 'equals' too
2024-02-15 10:00:24 +01:00
Harry Maclean
a9abba5859
Merge pull request #15520 from hmac/hmac-erb-raw-output-directive
...
Ruby: Recognise raw Erb output as XSS sink
2024-02-15 08:05:16 +00:00
Harry Maclean
babae65e41
Merge pull request #15488 from hmac/ruby-mad-docs
...
Ruby: add docs for customizing library models with data extensions
2024-02-15 07:58:22 +00:00
Tamas Vajk
2f1472fa48
Code quality improvements (fixed log message, removed unused interface)
2024-02-15 08:52:44 +01:00
Tamás Vajk
8aff913c3c
Merge pull request #15614 from tamasvajk/buildless/razor-cleanup
...
C# Only remove temp files for MVC view generation if needed
2024-02-15 08:27:40 +01:00
Joe Farebrother
37eb81097f
Add additional sinks for connection methods
2024-02-14 22:42:03 +00:00
Chris Smowton
7e41a895d8
Merge pull request #15618 from JLLeitschuh/patch-6
...
Fix typo in NettyRequestSplitting.java
2024-02-14 20:44:40 +00:00
Josh Soref
b58c856756
Declare permissions
...
Repositories can be configured with Default access (restricted)
https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token
Best practice says that workflows should declare the minimal permissions they require.
Without declaring permissions, paranoid forks fail miserably.
2024-02-14 14:31:45 -05:00
Josh Soref
e468f4062f
use github/codeql-action...@main
2024-02-14 14:31:31 -05:00
amammad
09d8a75844
Fix QLDoc issues
2024-02-14 23:31:22 +04:00
Michael B. Gale
6267506a77
Go: Postpone go.mod creation until necessary
2024-02-14 19:12:36 +00:00
Michael B. Gale
1055e773ef
Go: Export InitGoModForLegacyProject
2024-02-14 19:12:35 +00:00
Michael B. Gale
4387c73d12
Go: Fix missing word in comment for discoverWorkspace
2024-02-14 19:12:35 +00:00
Michael B. Gale
6dbb5c5fdb
Go: Refactor Autobuild to use pairs of scripts and tools from a reusable array
2024-02-14 19:12:35 +00:00
Michael B. Gale
e2c673417f
Go: Only call EmitNewerGoVersionNeeded at most once
2024-02-14 19:12:35 +00:00
Michael B. Gale
6eac48caba
Go: Refactor greatest version logic into dedicated function
2024-02-14 19:12:34 +00:00
Michael B. Gale
a9d8643f5a
Go: check for extracted files in go-files-found-not-processed test
2024-02-14 19:12:34 +00:00
Michael B. Gale
a26d11bcea
Go: Revert expected diagnostics for go-files-found-not-processed
2024-02-14 19:12:34 +00:00
Michael B. Gale
058bf32ad0
Go: Initialise Go modules for stray source files outside of existing modules
2024-02-14 19:12:34 +00:00
Michael B. Gale
d99ad01efa
Go: Add module files which don't belong to a workspace, if there are workspaces
2024-02-14 19:12:34 +00:00
Michael B. Gale
251888a0bd
Go: Tell extractor to extract subdirectories as well
2024-02-14 19:12:33 +00:00
Michael B. Gale
925e99cdb2
Go: Use GoFilesOutsideDirs to find stray source files
2024-02-14 19:12:33 +00:00
Michael B. Gale
f0df7cd5c5
Go: Add GoFilesOutsideDirs function
2024-02-14 19:12:33 +00:00
Michael B. Gale
d4ea45bdaf
Go: Add comment to AnyGoFilesOutsideDirs and use slices.Contains
2024-02-14 19:12:33 +00:00
Michael B. Gale
843f7694fd
Go: Only relocate project to temp dir if there is only one workspace
2024-02-14 19:12:32 +00:00
Michael B. Gale
3a982de16f
Go: Workspaces only support mod=readonly
2024-02-14 19:12:32 +00:00
Michael B. Gale
9c3667dbf7
Go: Improve go.work file(s) found log message
2024-02-14 19:12:32 +00:00
Michael B. Gale
fd54350ba8
Go: Fix comment for getBuildRoots
2024-02-14 19:12:32 +00:00
Michael B. Gale
f084829154
Go: Only fail autobuilder if all projects cannot be extracted
2024-02-14 19:12:31 +00:00
Michael B. Gale
20836c7088
Go: Add test for multiple modules, where one cannot be extracted
2024-02-14 19:12:31 +00:00
Michael B. Gale
fbd7946cfd
Go: Fall back to ./... if there are no modules
...
Fixes issues for `dep` and `glide`
2024-02-14 19:12:31 +00:00
Michael B. Gale
0b8a917584
Go: Fix crash if WorkspaceFile.Go is nil
2024-02-14 19:12:30 +00:00
Michael B. Gale
46c553e802
Go: Add test case for go.mod file without a Go version
2024-02-14 19:12:30 +00:00
Michael B. Gale
a961e276c1
Go: Initialise filesToRemove to an empty array
2024-02-14 19:12:30 +00:00
Michael B. Gale
51eb487022
Go: Handle filepath.Rel failure
2024-02-14 19:12:30 +00:00
Michael B. Gale
c96735e17a
Go: Remove auto-generated go.mod files when done
2024-02-14 19:12:30 +00:00
Michael B. Gale
db1d24a900
Go: Update expected diagnostics for go-files-not-processed
2024-02-14 19:12:29 +00:00
Michael B. Gale
e79f5905e7
Go: Fix checks for dep and glide not working correctly
2024-02-14 19:12:29 +00:00
Michael B. Gale
ec902827f6
Go: Initialise go.mod for stray source files
2024-02-14 19:12:29 +00:00
Michael B. Gale
b9e96e4a27
Fixup: closing curly brace
2024-02-14 19:12:29 +00:00
Michael B. Gale
21fbb1b051
Go: Only initialise module if there are source files
2024-02-14 19:12:28 +00:00
Michael B. Gale
f48b1e57d7
Go: Check for relative paths warning even if go mod tidy is successful
2024-02-14 19:12:28 +00:00
Michael B. Gale
aa5e14f59f
Go: Replace BuildInfo with GoWorkspace
2024-02-14 19:12:28 +00:00
Michael B. Gale
8b376e7a35
Go: Include ModMode in GoWorkspace
2024-02-14 19:12:28 +00:00
Michael B. Gale
025fbc874f
Go: Move definition of GoVersionInfo
2024-02-14 19:12:28 +00:00
Michael B. Gale
bdae54714a
Go: Change getDepMode to return GoWorkspaces
2024-02-14 19:12:27 +00:00
Michael B. Gale
64122ba867
Go: Include DependencyInstallerMode in GoWorkspace
2024-02-14 19:12:27 +00:00
Michael B. Gale
7392440475
Go: Move DependencyInstallerMode up
2024-02-14 19:12:27 +00:00
Michael B. Gale
b5ae8ace0d
Go: Add a function for go mod init
2024-02-14 19:12:27 +00:00
Michael B. Gale
1bf747ef3a
Go: Create go.mod file if necessary in project discovery
2024-02-14 19:12:27 +00:00
Michael B. Gale
254634075f
Go: Add shared TidyModule function
2024-02-14 19:12:26 +00:00
Michael B. Gale
f013d9d373
Go: Use new workspace/module discovery
2024-02-14 19:12:26 +00:00
Michael B. Gale
fc75e44238
Go: Allow GetBuildInfo to return multiple BuildInfo objects
2024-02-14 19:12:26 +00:00
Michael B. Gale
4f5c43a3c6
Go: Add new functions for discovering workspaces and modules
2024-02-14 19:12:26 +00:00
Michael B. Gale
3f53186ad1
Go: Add helper functions for discovering go.work and go.mod files
2024-02-14 19:12:25 +00:00
Michael B. Gale
60879bd367
Go: Introduce new types for representing logical workspaces
2024-02-14 19:12:25 +00:00
Michael B. Gale
82bd1d7b0b
Go: Add SupportsWorkspaces function
2024-02-14 19:12:25 +00:00
Michael B. Gale
237bf5653a
Go: Move getEnvGoSemVer to toolchain.go
2024-02-14 19:12:25 +00:00
Michael B. Gale
bd36847ca2
Go: Emit relative path import diagnostic if prompted by go mod tidy
...
The corresponding integration test now successfully extracts the project
2024-02-14 19:12:25 +00:00
Michael B. Gale
c2571160c3
Go: Rename findGoModFiles to getBuildRoot
2024-02-14 19:12:24 +00:00
Michael B. Gale
0488d1d295
Go: Move getDirs into util and document/rename
2024-02-14 19:12:24 +00:00
Michael B. Gale
df212807a0
Go: Try to initialise go.mod file for legacy projects
2024-02-14 19:12:24 +00:00
Jonathan Leitschuh
50056d603e
Fix typo in NettyRequestSplitting.java
2024-02-14 14:03:33 -05:00
Ian Lynagh
f6d6a04ba2
Kotlin 2: Accept location changes in library-tests/exprs
2024-02-14 17:01:21 +00:00
Ian Lynagh
4fcc1c26d4
Kotlin 2: Accept location changes in library-tests/exprs
2024-02-14 16:56:22 +00:00
Ian Lynagh
b95c69dc66
Kotlin 2: Accept location changes in library-tests/exprs
2024-02-14 16:54:20 +00:00
Ian Lynagh
2fe4c8c519
Kotlin 2: Accept some loc changes in library-tests/exprs/exprs
2024-02-14 16:47:46 +00:00
Ian Lynagh
14979585c9
Kotlin 2: Accept loc changes for library-tests/exprs/funcExprs.kt
2024-02-14 16:40:54 +00:00
Tony Torralba
f5d9fe6b08
Merge pull request #15615 from atorralba/atorralba/go/hardcoded-credentials-test-fix
...
Go: Use less confusing name for hardcoded credentials tests
2024-02-14 17:33:43 +01:00
Tony Torralba
582f341d9e
Add references to qhelp
2024-02-14 17:25:09 +01:00
Tony Torralba
f9638760ff
Fix MaD rows
2024-02-14 17:25:08 +01:00
Tony Torralba
769ec16803
Apply suggestions from code review
...
Co-authored-by: Chris Smowton <smowton@github.com >
2024-02-14 17:25:08 +01:00
Tony Torralba
5a82d2188a
Fix double quotes in MaD row
2024-02-14 17:25:08 +01:00
Tony Torralba
551875cb5a
Add 'jwt' as valid sink kind
2024-02-14 17:25:08 +01:00
Tony Torralba
85b22a2b98
Fix QHelp
2024-02-14 17:25:08 +01:00
Tony Torralba
ad7d40f0af
Add missing QLDoc
2024-02-14 17:25:08 +01:00
Tony Torralba
2a30898af6
Go: Promote go/missing-jwt-signature-check from experimental
2024-02-14 17:25:03 +01:00
Ian Lynagh
efe5184a74
Kotlin 2: Accept loc change for fn in library-tests/exprs/funcExprs.kt
2024-02-14 16:09:14 +00:00
Tony Torralba
1202b5b429
Go: Use less confusing name for hardcoded credentials tests
...
We don't want name-based heuristics to pick these variable names, but also using something like 'safeName' may mislead readers into believing the test cases are intended to be GOOD cases (i.e. safe)
2024-02-14 17:06:05 +01:00
Ian Lynagh
18a28e2623
Kotlin 2: Accept loc changes in library-tests/exprs for kFunctionInvoke.kt
2024-02-14 16:04:10 +00:00
Ian Lynagh
c11bfb3c83
Kotlin 2: Accept loc changes in library-tests/exprs for localFunctionCalls.kt
2024-02-14 16:03:23 +00:00
Tamas Vajk
12663b58f1
C# Only remove temp files for MVC view generation if needed
2024-02-14 17:00:37 +01:00
Tony Torralba
99ac640536
Merge pull request #15527 from atorralba/atorralba/go/promote-hardcoded-key
...
Go: Promote `go/hardcoded-key` from experimental
2024-02-14 16:54:03 +01:00
Rasmus Wriedt Larsen
eb401a205d
Python: Fix test exclusion for stdlib Python 3.12
2024-02-14 16:53:19 +01:00
Ian Lynagh
1cc645b276
Kotlin 2: Accept location changes in library-tests/exprs for samConversion.kt
2024-02-14 15:49:44 +00:00
Ian Lynagh
9195be34a2
Kotlin 2: Accept location changes in library-tests/exprs/exprs for whenExpr.kt
2024-02-14 15:45:09 +00:00
Chris Smowton
7ed73bc4ed
change note
2024-02-14 15:45:03 +00:00
Ian Lynagh
5d0b780c06
Kotlin 2: Accept some location improvements in library-tests/exprs/exprs.expected
2024-02-14 15:37:37 +00:00
Ian Lynagh
2cc2a90880
Kotlin 2: Accept some location changes in library-tests/exprs/exprs.expected
2024-02-14 15:37:35 +00:00
Jeroen Ketema
9ef2c83d71
Merge pull request #15611 from jketema/destructors4
...
C++: For unnamed local variable declaration entries consider the name of the variable
2024-02-14 16:18:33 +01:00
Chris Smowton
9016997b51
Golang: fix flow from a map value via a range statement
2024-02-14 14:56:24 +00:00
Rasmus Wriedt Larsen
59014787a1
Python: Fix DataflowQueryTest
...
You're only allowed to have `result=OK` if there is a sink on that line...
2024-02-14 15:44:40 +01:00
Rasmus Wriedt Larsen
cd596f5d05
Python: Reformat test-file
...
All those newlines are not good for inline expectations
2024-02-14 15:44:06 +01:00
Asger F
d94d4591da
JS: Name instance methods using API nodes instead of special-casing
2024-02-14 15:08:19 +01:00
Asger F
c4a0f36a08
JS: Fix handling of unknown properties
...
These would shorten the expected distance to a node, but would never be usable as an edge, meaning we failed to pick a preferred predecessor.
2024-02-14 15:08:19 +01:00
Asger F
3ff950660b
JS: Add test with unknown property name
2024-02-14 15:08:19 +01:00
Asger F
9838da5395
JS: Simplify isExported
2024-02-14 15:08:19 +01:00
Asger F
a3dc19fd31
JS: Check privacy earlier
2024-02-14 15:08:19 +01:00
Asger F
5c454944a9
JS: Add test for private fields
2024-02-14 15:08:19 +01:00
Asger F
2a91bb8c54
JS: Add test showing ambiguous predecessor
2024-02-14 15:08:19 +01:00
Jeroen Ketema
33413129a5
C++: For unnamed local variable declaration entries consider the name of the variable
2024-02-14 15:03:04 +01:00
Ian Lynagh
c87b7b5f88
Merge pull request #15606 from igfoo/igfoo/kt2
...
Kotlin: Fix build with latest 2.0.255 snapshots
2024-02-14 14:00:50 +00:00
Rasmus Wriedt Larsen
e5bd633028
Python: Change name/id to Decompression Bomb
...
The old title/id matches how we used to write queries, but I think just
using the normal conversational name is easier for everyone :)
2024-02-14 14:54:25 +01:00
Rasmus Wriedt Larsen
69c8ef9898
Python: Use dataflow instead of taint-tracking
2024-02-14 14:52:37 +01:00
Rasmus Wriedt Larsen
ba7dd38fc9
Python: Delete duplicated file
2024-02-14 14:48:37 +01:00
Rasmus Wriedt Larsen
9ae3ea81ff
Python: Remove spurious results in stdlib
2024-02-14 14:47:28 +01:00
Rasmus Wriedt Larsen
d8fd457310
Python: Use helper predicate
...
Since the helper predicate had nice qldocs
2024-02-14 14:47:28 +01:00
Rasmus Wriedt Larsen
e7772f1062
Python: Use Unit class
2024-02-14 14:47:28 +01:00
Rasmus Wriedt Larsen
ad39b8c68b
Python: Accept .expected changes
2024-02-14 14:46:33 +01:00
erik-krogh
7c2465e7b7
add change-note
2024-02-14 13:53:43 +01:00
erik-krogh
a2bd45d0cb
apply suggestions from code review
2024-02-14 13:50:27 +01:00
Rasmus Wriedt Larsen
9399258e3b
Merge branch 'main' into amammad-python-bombs
2024-02-14 13:37:59 +01:00
Jeroen Ketema
46bc311111
C++: Support constexpr if in the IR
2024-02-14 13:37:56 +01:00
Tony Torralba
5ce35e47b9
Adjust a test case so that the key isn't considered dummy
...
(len < 4)
2024-02-14 13:06:31 +01:00
Ian Lynagh
48ea94ba23
Kotlin: Handle PsiSourceManager moving
2024-02-14 11:55:54 +00:00
Ian Lynagh
1b40b595fa
Kotlin: Handle forAllMethodsWithBody being removed
...
Per:
commit 28797a31b4d9b7f5c99d162ab19fc6b46f8e529d
Author: Alexander Udalov <alexander.udalov@jetbrains.com >
Date: Thu Feb 1 13:22:48 2024 +0100
JVM: refactor JvmDefaultMode, remove/rename some entries
[...]
- remove forAllMethodsWithBody because its behavior is now equivalent to
isEnabled
[...]
2024-02-14 11:55:54 +00:00
Óscar San José
cd00a4dacd
Merge pull request #15584 from jsoref/github-only
...
Limit xl runner jobs to github org
2024-02-14 12:49:07 +01:00
Asger F
75a95ffcd1
Merge pull request #15602 from asgerf/js/block-logical-and-flow
...
JS: Fix flow through &&
2024-02-14 12:29:40 +01:00
Tony Torralba
458bbb3581
Rename fwk module
2024-02-14 12:23:27 +01:00
Tony Torralba
16284fdd20
Discard sources that are obvious dummy values
2024-02-14 12:21:52 +01:00
Tony Torralba
a76de495e0
Simplify sanitizers
...
Use DataFlow::returnedWithError instead
2024-02-14 12:21:51 +01:00
Tony Torralba
6b74cb7e75
Remove unneeded $ANYVERSION
2024-02-14 12:21:51 +01:00
Tony Torralba
3fb422ca25
Split Jwt.qll into framework libraries, which makes more sense
2024-02-14 12:21:38 +01:00
Tony Torralba
8afaa231ee
Update go/ql/lib/semmle/go/security/Jwt.qll
2024-02-14 12:15:20 +01:00
Tony Torralba
304998d50e
Update go/ql/src/Security/CWE-798/HardcodedCredentials.ql
2024-02-14 12:15:20 +01:00
Tony Torralba
84d1d72497
Apply suggestions from code review
...
Co-authored-by: Chris Smowton <smowton@github.com >
2024-02-14 12:15:19 +01:00
Tony Torralba
750c8085cb
Remove duplicated main from tests
2024-02-14 12:15:19 +01:00
Tony Torralba
ba1faea630
Go: Promote go/hardcoded-key from experimental
2024-02-14 12:15:14 +01:00
Jeroen Ketema
337db6b29b
Merge pull request #15609 from jketema/destructors3
...
C++: Output the declaration entries used in range-based for-loops
2024-02-14 11:37:09 +01:00
Asger F
2172c4863f
Merge pull request #15380 from asgerf/js/endpoint-naming
...
JS: Add library for naming endpoints
2024-02-14 10:48:13 +01:00
Asger F
18db769d6d
JS: Update expected output
2024-02-14 10:45:51 +01:00
Asger F
bafe5e3d8e
JS: Add test case (with old expected data)
2024-02-14 10:45:51 +01:00
Anders Schack-Mulligen
393251dde6
Merge pull request #15582 from hvitved/dataflow/cache-viable-callable-ext
...
Data flow: Cache `viableCallableExt`
2024-02-14 10:31:43 +01:00
Óscar San José
96ed6597dd
Merge branch 'main' into github-only
2024-02-14 10:23:39 +01:00
Michael Nebel
bafea9190d
Merge pull request #15474 from michaelnebel/csharp/primaryconstructors
...
C# 12: Primary constructors.
2024-02-14 10:09:23 +01:00
Anders Schack-Mulligen
fb2d36ddac
Merge pull request #15451 from Marcono1234/marcono1234/java-assignment-doc
...
Java: Document which assignment type is covered by which class
2024-02-14 08:59:50 +01:00
Asger F
9a08c27ad4
JS: Change note
2024-02-13 22:43:41 +01:00
Jeroen Ketema
c79cc493e8
C++: Accept more test changes
2024-02-13 21:53:51 +01:00
Geoffrey White
0d6c141d72
Merge pull request #15607 from geoffw0/unsafeunpack
...
Swift: Trivial changes to swift/unsafe-unpacking
2024-02-13 20:49:57 +00:00
Jeroen Ketema
a3b3aa4f25
C++: Update tests after extractor changes
2024-02-13 21:31:21 +01:00
Jeroen Ketema
caf09e0735
C++: Update IR comment that no longer applies
2024-02-13 21:30:58 +01:00
Jeroen Ketema
b3aea0f893
C++: Do not print the qualifier of OverloadedPointerDereferenceExpr twice in PrintAST
2024-02-13 21:29:21 +01:00
Michael B. Gale
f7955db841
Merge pull request #15603 from github/mbg/go/fix-file-info-extraction
2024-02-13 20:02:13 +00:00
Jeroen Ketema
b776cbe668
Merge pull request #15597 from jketema/destructors2
...
C++: Update test results of `constexpr if` destructors
2024-02-13 19:59:19 +01:00
Geoffrey White
159080f133
Swift: Accept test changes.
2024-02-13 18:06:17 +00:00
Geoffrey White
65e3ae0c45
Swift: Move the two CWE-022 tests into a common directory.
2024-02-13 17:50:30 +00:00
Michael B. Gale
205847df64
Go: Add DummyFile class
2024-02-13 17:49:31 +00:00
Michael B. Gale
c6f4495ada
Go: Exclude dummy files from File
2024-02-13 17:46:41 +00:00
Geoffrey White
dfba6b97ac
Swift: Case consistency.
2024-02-13 17:45:55 +00:00
Geoffrey White
42e708b387
Swift: Tweak the change note.
2024-02-13 17:43:43 +00:00
Benjamin Rodes
5c508553f3
Efficiency improvement (force a better join order)
2024-02-13 09:42:08 -08:00
Asger F
f5c437694c
Update UselessConditional.expected
2024-02-13 18:31:24 +01:00
Asger F
f27fda801e
Update tests.expected
2024-02-13 18:30:23 +01:00
Geoffrey White
fd1314bea4
Merge pull request #14888 from maikypedia/maikypedia/swift-zip
...
Swift: Add Unsafe Unpacking Query (CWE-022)
2024-02-13 16:05:22 +00:00
Robert Marsh
7e23ccd383
Merge branch 'main' into rdmarsh2/cpp/ir-synthetic-destructors
2024-02-13 15:45:51 +00:00
Robert Marsh
128bc99f90
C++: delete some FIXMEs that turned out fine
2024-02-13 15:34:36 +00:00
Chris Smowton
7217dfa997
Merge pull request #15590 from github/dependabot/go_modules/go/extractor/extractor-dependencies-8b53c12dad
...
Bump the extractor-dependencies group in /go/extractor with 1 update
2024-02-13 15:21:53 +00:00
Peter Stöckli
2f7b946c9f
Ruby: add sources on request object of Rails
2024-02-13 15:52:18 +01:00
Michael B. Gale
be521508c2
Go: Do not add dummy files to CompilationCompilingFilesTable
2024-02-13 14:21:07 +00:00
Michael B. Gale
5e08bf0dbf
Go: Add missing call to extractFileInfo
2024-02-13 14:20:45 +00:00
Mathias Vorreiter Pedersen
7a7e0334c0
Merge pull request #15601 from MathiasVP/revert-new-barrier-interface
...
C++: Revert #15528
2024-02-13 14:10:29 +00:00
Ian Lynagh
ac001c37bd
Merge pull request #15561 from igfoo/igfoo/kt2-tests
...
Kotlin 2: Accept more test changes
2024-02-13 14:02:45 +00:00
Asger F
7122a7502a
JS: Fix flow through &&
...
This is a long-standing bug we've been unable to fix due to noise from type inference.
2024-02-13 14:43:03 +01:00
Mathias Vorreiter Pedersen
fb4bd53ec5
Revert "Merge pull request #15528 from MathiasVP/flow-barrier-interface"
...
This reverts commit c5dc88345d , reversing
changes made to 781486172e .
2024-02-13 13:42:58 +00:00
Mathias Vorreiter Pedersen
cb7fe16ced
Revert "Merge pull request #15537 from MathiasVP/swap-also-clears-first-argument"
...
This reverts commit 23677b23c2 , reversing
changes made to c5dc88345d .
2024-02-13 13:42:58 +00:00
Tom Hvitved
bc8761c51b
Data flow: Cache viableCallableExt
2024-02-13 14:12:50 +01:00
Tom Hvitved
7c59c7b28c
C#: Update QLdoc
2024-02-13 14:00:26 +01:00
Tom Hvitved
7bdc2c57f0
C#: Simplify primaryConstructorParameterStore
2024-02-13 13:59:14 +01:00
Tom Hvitved
3f43f45437
C#: Assume captured variables are live at exit in SSA construction
2024-02-13 13:59:08 +01:00
Tom Hvitved
ebd6853194
C#: Avoid overlapping output in data flow test
2024-02-13 13:59:03 +01:00
Jeroen Ketema
f3e55a46ee
C++: Update test results of constexpr if destructors
2024-02-13 13:37:59 +01:00
Michael Nebel
91bbbe262d
C#: Address more review comments.
2024-02-13 13:15:17 +01:00
erik-krogh
d31bfc06c2
add type requirement to the new Uri sanitizers
2024-02-13 13:13:43 +01:00
erik-krogh
4dae8d0bb4
add host comparisons as a sanitizer for url-redirect
2024-02-13 13:13:43 +01:00
erik-krogh
f4dd3e9aa1
treat relative URLs as safe for url-redirects
2024-02-13 13:13:18 +01:00
erik-krogh
3f8de82ea3
add a sanitizer for List.Contains() in url-redirect
2024-02-13 13:13:06 +01:00
erik-krogh
59792808d4
add new url-redirect test file
2024-02-13 13:13:06 +01:00
Michael Nebel
8efe34942f
C#: Add indirect assignment example.
2024-02-13 12:02:25 +01:00
Mathias Vorreiter Pedersen
048b3727f5
Merge pull request #15587 from MathiasVP/fix-memset-model
...
C++: Fix `memset` model
2024-02-13 10:45:08 +00:00
Michael Nebel
eaf129d519
C#: Update expected test output.
2024-02-13 11:40:46 +01:00
Michael Nebel
69c0f0cb6a
C#: Address review comments.
2024-02-13 11:39:21 +01:00
Jeroen Ketema
565f8e852c
Merge pull request #15594 from jketema/destructors
...
C++: Add additional IR tests for destructors
2024-02-13 11:09:07 +01:00
Jeroen Ketema
fb072a5156
C++: Add additional IR tests for init statements
2024-02-13 10:44:24 +01:00
Jeroen Ketema
8aeb75675a
C++: Add constructor and destructor for vector to IR test
2024-02-13 10:39:27 +01:00
Chris Smowton
4e1167697e
Merge pull request #15589 from jsoref/avoid-always
...
Use `!cancelled` in qhelp-pr-preview workflow
2024-02-13 09:36:40 +00:00
Cornelius Riemenschneider
e08946ec8d
Merge pull request #15586 from github/criemen/bazel-python-language-pack
...
Python: Update BUILD.bazel files.
2024-02-13 10:19:12 +01:00
Jeroen Ketema
b509645e02
C++: Bump language version in IR tests to C++20
2024-02-13 10:18:31 +01:00
Erik Krogh Kristensen
062f16e618
Merge pull request #15519 from erik-krogh/cs-path
...
C#: Improve the `cs/path-injection` QHelp
2024-02-13 10:02:11 +01:00
Harry Maclean
6cc5c09769
Ruby: Simplify ErbOutputDirective
2024-02-13 08:38:16 +00:00
Harry Maclean
11040d628b
Ruby: Add changenote
2024-02-13 08:38:15 +00:00
Asger F
6598a669a1
JS: Use set literal
2024-02-13 09:30:35 +01:00
Asger F
543e183d99
JS: Describe 1-step aliasing rule
2024-02-13 09:29:15 +01:00
Asger F
baa3c35d6f
JS: Refactor aliasing relation
2024-02-13 09:24:00 +01:00
Tamás Vajk
de13ff6afd
Merge pull request #15577 from tamasvajk/feature/missing-nuget-sources
...
C# - Add default nuget feed if there's none
2024-02-13 09:18:32 +01:00
Max Schaefer
104a8d980c
Automodel: Make description of some negative characteristics more explicit.
2024-02-13 08:18:13 +00:00
dependabot[bot]
a3008083ea
Bump the extractor-dependencies group in /go/extractor with 1 update
...
Bumps the extractor-dependencies group in /go/extractor with 1 update: [golang.org/x/tools](https://github.com/golang/tools ).
Updates `golang.org/x/tools` from 0.17.0 to 0.18.0
- [Release notes](https://github.com/golang/tools/releases )
- [Commits](https://github.com/golang/tools/compare/v0.17.0...v0.18.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/tools
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: extractor-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-02-13 03:58:21 +00:00
Robert Marsh
b9785ea7b2
C++: autoformat
2024-02-13 01:07:41 +00:00
Robert Marsh
f791b0ebbf
C++: Model for smart pointer destructors
2024-02-13 01:00:46 +00:00
Robert Marsh
b6cf64cff3
C++: simplify TranslatedBlock::getLastChild
2024-02-13 00:46:53 +00:00
Robert Marsh
7d8872bb99
C++: Fix for multiple for-loop variables with destructors
2024-02-13 00:40:19 +00:00
Robert Marsh
6663420d39
C++: test for multiple for loop variables with destructors
2024-02-13 00:35:56 +00:00
Robert Marsh
b94c4a6e1b
C++: fix for destructor of while-loop condition
2024-02-13 00:13:22 +00:00
Robert Marsh
bac7e46b0f
C++: tests for destructors after a while-loop condition
2024-02-12 23:55:42 +00:00
Josh Soref
a128161746
Use !cancelled in qhelp-pr-preview workflow
2024-02-12 16:59:42 -05:00
Asger F
faefa056eb
Merge pull request #15507 from asgerf/shared/outbarrier-bugfix
...
Shared: fix a bug in stateful outbarriers
2024-02-12 21:44:49 +01:00
Tom Hvitved
15cf695188
C#: Fix various bad joins
2024-02-12 19:49:53 +01:00
Tom Hvitved
90f3670f3d
C#: Remove all DB stats
2024-02-12 19:49:29 +01:00
Mathias Vorreiter Pedersen
a799399639
C++: Accept test changes.
2024-02-12 16:51:25 +00:00
Mathias Vorreiter Pedersen
70c7c1a5e7
C++: Add flow from the fill character to the output pointer.
2024-02-12 16:51:16 +00:00
Mathias Vorreiter Pedersen
8635b5d316
C++: Add test with missing flow.
2024-02-12 16:44:38 +00:00
Cornelius Riemenschneider
27ebebc24b
Python: Update BUILD.bazel files.
...
This allows us to (later) build the whole python language pack with
bazel.
2024-02-12 17:10:35 +01:00
Paolo Tranquilli
a944443d39
Merge branch 'main' into redsun82/bzlmod
2024-02-12 16:03:50 +01:00
Rasmus Wriedt Larsen
cbb9a64bbb
Merge pull request #15457 from RasmusWL/psycopg
...
Python: Model the `psycopg` package
2024-02-12 15:59:16 +01:00
Paolo Tranquilli
c0eeb7a34e
Bazel: reference (and locally stub) internal module
2024-02-12 15:58:43 +01:00
Benjamin Rodes
091416131b
Removing 'const' specifier filtering after discussions with the team. We will test if this causes undesirable cases in DCA and then choose which approach is best.
2024-02-12 09:38:00 -05:00
Harry Maclean
3d9f9afa77
Merge pull request #15566 from hmac/hmac-actioncontroller-regex
...
Ruby: Fix ActionController path regex
2024-02-12 14:14:57 +00:00
Michael Nebel
68b920f330
C#: Update other tests expected output.
2024-02-12 15:09:36 +01:00
Harry Maclean
99497e5f3c
Merge pull request #15521 from hmac/hmac-ar-connection
...
Ruby: Recognise more ActiveRecord connections
2024-02-12 14:06:50 +00:00
Tony Torralba
b6385f7938
Merge pull request #15533 from JLLeitschuh/patch-5
...
Reduce severity of `java/relative-path-command`
2024-02-12 15:04:05 +01:00
Joe Farebrother
3a4a841844
Add change note + update severity
2024-02-12 14:01:27 +00:00
Joe Farebrother
16a7d68780
Add documentation
2024-02-12 13:58:01 +00:00
Joe Farebrother
2eb93b7a3b
Add unit tests
2024-02-12 13:49:45 +00:00
Joe Farebrother
d8985f9f5b
Move tests for local auth to a folder
2024-02-12 13:49:45 +00:00
Joe Farebrother
c79a3eb6ae
Add query for insecure key generation
2024-02-12 13:49:44 +00:00
Joe Farebrother
75a2b9415c
Merge pull request #15481 from joefarebrother/android-local-auth
...
Java: Add query for insecure local authentication
2024-02-12 13:48:53 +00:00
Tony Torralba
db2eb202ee
Merge pull request #15565 from atorralba/atorralba/java/open-redirect-sanitizer
...
Java: Add extension point and default sanitizer to Open Redirect query
2024-02-12 14:42:52 +01:00
Ian Lynagh
931b27f76c
Merge pull request #15573 from igfoo/igfoo/k2-more
...
Kotlin 2: Accept loc changes in library-tests/parameter-defaults/defaults.expected
2024-02-12 13:29:19 +00:00
Ian Lynagh
a7eac1100b
Merge pull request #15569 from igfoo/igfoo/kt2-accept
...
Kotlin 2: Accept more location changes
2024-02-12 13:29:10 +00:00
Harry Maclean
5af58d24e0
Ruby: Recognise raw Erb output as XSS sink
2024-02-12 13:28:44 +00:00
Paolo Tranquilli
53539226a8
Bazel: use internal codeql module
2024-02-12 14:27:55 +01:00
Michael Nebel
aed5080142
C#: Add primary constructor change note.
2024-02-12 13:27:40 +01:00
Michael Nebel
4083348b3e
C#: Add a primary constructor QL library test.
2024-02-12 13:27:39 +01:00
Michael Nebel
ff29679317
C#: Update expected test output.
2024-02-12 13:27:39 +01:00
Michael Nebel
42f4656667
C#: Data flow for primary constructors.
2024-02-12 13:27:39 +01:00
Michael Nebel
f5d4c49b16
C#: Add some more constructor dataflow tests.
2024-02-12 13:13:06 +01:00
Michael Nebel
86212b24ba
C#: Move constructor data flow tests to a separate folder.
2024-02-12 13:13:06 +01:00
Michael Nebel
afe3c5ea8d
C#: Re-arrange the code in constructor data flow test and update expected output.
2024-02-12 13:13:06 +01:00
Tamas Vajk
888f47c6c8
Remove cil=false extractor option from integration tests
2024-02-12 12:02:43 +01:00
Tamas Vajk
70b6ae6876
Add comments to nuget.config file restore
2024-02-12 11:59:19 +01:00
Asger F
8d3a19aaad
JS: Fix termination criteria
...
Previously it was theoretically possible to create a cycle of preferred predecessors, since badness had higher precedence than depth. We now require the preferred predecessor to have lower depth.
With this criteria we can remove the arbitray cap on badness.
2024-02-12 11:44:52 +01:00
Asger F
0fbe530d9e
JS: Fix some broken comments
2024-02-12 11:39:40 +01:00
Asger F
6d01ba67f7
JS: Check isPrivateLike in isExported instead
2024-02-12 11:39:29 +01:00
Erik Krogh Kristensen
1520305ae1
Merge pull request #15523 from erik-krogh/exclude-tagged
...
JS: exclude tagged template literals from `js/superfluous-trailing-arguments`
2024-02-12 11:31:18 +01:00
Joe Farebrother
d3fea4044e
Apply suggestions from documentation review
...
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com >
2024-02-12 10:27:56 +00:00
Josh Soref
6779c667f6
Limit xl runner jobs to github org
2024-02-12 05:00:49 -05:00
Paolo Tranquilli
19bb8fe22d
Bazel: use bzlmod
2024-02-12 10:55:40 +01:00
Nick Rolfe
b2ee5808f0
Merge pull request #15496 from github/nickrolfe/loc-fresh-ids
...
Tree-sitter extractors: use fresh IDs for locations
2024-02-12 09:54:09 +00:00
Tamas Vajk
5be3993405
Preserve nuget.config file casing after cleanup
2024-02-12 10:40:33 +01:00
Tamas Vajk
26cea33cc6
C# - Add default nuget feed if there's none
2024-02-12 10:40:33 +01:00
Tamas Vajk
933a8e648d
Add integration test for missing nuget package sources
2024-02-12 10:35:49 +01:00
Tony Torralba
cf7091ae5f
Merge branch 'main' into atorralba/java/open-redirect-sanitizer
2024-02-12 10:31:52 +01:00
Harry Maclean
51a5c2bbba
Ruby: Address doc review comments
2024-02-12 09:16:13 +00:00
Tony Torralba
e6623ebe4c
Add change note
2024-02-12 10:10:42 +01:00
Tony Torralba
5f729d57fa
Merge pull request #15578 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-02-12 09:24:05 +01:00
Tom Hvitved
b27b89bff7
Merge pull request #15567 from hvitved/csharp/cache-module
...
C#: Actually cache module `Cached`
2024-02-12 09:15:49 +01:00
Tom Hvitved
9634511ac5
Merge pull request #15489 from hvitved/csharp/lambda-field-flow
...
C#: Additional tracking of lambdas through fields and properties
2024-02-12 09:14:21 +01:00
Erik Krogh Kristensen
4d65e4e985
Merge pull request #15579 from github/dependabot/cargo/ql/chrono-0.4.34
...
Bump chrono from 0.4.33 to 0.4.34 in /ql
2024-02-12 08:47:22 +01:00
dependabot[bot]
3212f80bea
Bump chrono from 0.4.33 to 0.4.34 in /ql
...
Bumps [chrono](https://github.com/chronotope/chrono ) from 0.4.33 to 0.4.34.
- [Release notes](https://github.com/chronotope/chrono/releases )
- [Changelog](https://github.com/chronotope/chrono/blob/main/CHANGELOG.md )
- [Commits](https://github.com/chronotope/chrono/compare/v0.4.33...v0.4.34 )
---
updated-dependencies:
- dependency-name: chrono
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-02-12 03:38:19 +00:00
github-actions[bot]
3cba1764e2
Add changed framework coverage reports
2024-02-12 00:16:45 +00:00
Tom Hvitved
e75f7dd7f9
Merge pull request #15540 from hvitved/variable-capture-overwrite
2024-02-10 10:25:29 +01:00
Marcono1234
d814decc17
Ruby: Fix formatting in changelog
2024-02-10 00:23:57 +01:00
Robert Marsh
d1160f86e1
C++: Autoformat for named destructors in IR
2024-02-09 22:35:12 +00:00
Robert Marsh
1b571f8992
C++: Accept test changes
2024-02-09 22:32:08 +00:00
Geoffrey White
0c3aa7b7f2
C++: Add an inline test for interpretElement matching.
2024-02-09 18:57:05 +00:00
Geoffrey White
8bdb67cc15
C++: Allow member variables to be picked as input nodes.
2024-02-09 14:24:37 +00:00
Mathias Vorreiter Pedersen
4eae191430
C++: Accept test changes.
2024-02-09 14:07:57 +00:00
Mathias Vorreiter Pedersen
4728cf5a12
C++: Allow the 'x' in 'x = source()' to be marked as a sink in MaD.
2024-02-09 14:07:48 +00:00
Joe Farebrother
16aed18821
Address reviews - Elaborate on docs and update severity
2024-02-09 13:53:36 +00:00
Ian Lynagh
ab758d5f1e
Kotlin 2: Accept loc changes in library-tests/parameter-defaults/defaults.expected
2024-02-09 13:53:05 +00:00
Tom Hvitved
37d774176b
Ruby: Fix SSA inconsistency
2024-02-09 14:49:26 +01:00
Tom Hvitved
1ea7717714
Capture flow: Take overwrites in nested scopes into account
2024-02-09 14:49:23 +01:00
Tom Hvitved
0c43ad45b4
Ruby: Add another captured variable data flow test
2024-02-09 14:48:36 +01:00
Anders Schack-Mulligen
8fc4fae7d2
Java: Cache interpretElement.
2024-02-09 14:43:36 +01:00
Ian Lynagh
0547c877c2
Kotlin 2: Accept some location changes in library-tests/methods/exprs.expected
2024-02-09 13:34:56 +00:00
Mathias Vorreiter Pedersen
cd41a1ca8c
C++: Accept test changes.
2024-02-09 13:27:40 +00:00
Mathias Vorreiter Pedersen
3719e10ce8
C++: Add a case for global or namespace variables in 'interpretElement0'.
2024-02-09 13:27:32 +00:00
Mathias Vorreiter Pedersen
52a1d905f1
C++: Qualified import of 'cpp' to make the file compile.
2024-02-09 13:25:17 +00:00
Ian Lynagh
be4413ffc8
Kotlin 2: Accept changes in library-tests/methods/parameters.expected
...
These mostly make things consistent with Kotlin 1.
2024-02-09 13:19:26 +00:00
Ian Lynagh
b836260b9a
Kotlin 2: Accept some test changes
...
I'm not sure these are an improvement, but they bring Kotlin 2 back in
line with Kotlin 1.
2024-02-09 13:15:02 +00:00
Rasmus Lerchedahl Petersen
580e68d5de
python: add support for lower bound position
2024-02-09 13:51:16 +01:00
Anders Schack-Mulligen
566351a49a
Merge pull request #15549 from aschackmull/dataflow/empty-provenance
...
Dataflow: Add empty provenance column to PathGraph.
2024-02-09 12:58:09 +01:00
Ian Lynagh
1b91695934
Kotlin 2: Accept some location changes in library-tests/methods
2024-02-09 11:57:23 +00:00
Tom Hvitved
9785ce4936
C#: Actually cache module Cached
2024-02-09 12:29:56 +01:00
Max Schaefer
93990ec9df
Merge pull request #15486 from github/java/update-mad-decls-after-triage-2024-01-31T11-16-45
...
Java: Update MaD Declarations after Triage
2024-02-09 11:18:17 +00:00
Mathias Vorreiter Pedersen
a42c845b32
Merge pull request #15559 from MathiasVP/fix-constness-type
...
C++: Don't strip specifiers in `Node.getType`
2024-02-09 11:00:13 +00:00
Anders Schack-Mulligen
4fcb90298d
Dataflow: Add change note.
2024-02-09 11:32:08 +01:00
Anders Schack-Mulligen
088a0a54ba
Python: Add empty provenance column to expected files.
2024-02-09 11:32:08 +01:00
Anders Schack-Mulligen
817aa7655f
Python: Remove redundant IncludePostUpdateFlow and PhaseDependentFlow application.
2024-02-09 11:32:08 +01:00
Anders Schack-Mulligen
0eaf117f37
Kotlin: Add empty provenance column to expected files.
2024-02-09 11:32:08 +01:00
Anders Schack-Mulligen
7eb5e1833d
C++: Add empty provenance column to expected files.
2024-02-09 11:32:08 +01:00
Anders Schack-Mulligen
35a3aa0a09
Ruby: Add empty provenance column to expected files.
2024-02-09 11:32:08 +01:00
Anders Schack-Mulligen
228a61ead3
Swift: Add empty provenance column to expected files.
2024-02-09 11:32:07 +01:00
Anders Schack-Mulligen
3b8af1e52a
Go: Add empty provenance column to expected files.
2024-02-09 11:32:07 +01:00
Anders Schack-Mulligen
21a6520cd3
C#: Add empty provenance column to expected files.
2024-02-09 11:32:07 +01:00
Anders Schack-Mulligen
e9e445b2ba
Java: Add empty provenance column to expected files.
2024-02-09 11:32:00 +01:00
Mathias Vorreiter Pedersen
dd3d70134c
C++: Undo a change that wasn't actually necessary.
2024-02-09 10:28:24 +00:00
Anders Schack-Mulligen
b7d4a6926f
Dataflow: Add empty provenance column to PathGraph.
2024-02-09 11:27:30 +01:00
Joe Farebrother
f4b6a85a48
Fix typo in qldoc
2024-02-09 10:09:24 +00:00
Tony Torralba
4c0d535cc2
Merge pull request #12886 from atorralba/atorralba/java/path-injection-mad-sinks
...
Java: Refactor path injection sinks
2024-02-09 10:48:49 +01:00
Harry Maclean
3a90d78c36
Ruby: Fix Rails view file regex
...
This picks up non-nested template files correctly.
2024-02-09 09:41:43 +00:00
Tamás Vajk
d46028f552
Merge pull request #15542 from tamasvajk/feature/relative-line-pragma
...
C#: Try resolve relative paths in line mappings
2024-02-09 10:36:53 +01:00
Harry Maclean
48890b446d
Ruby: Add more actioncontroller tests
2024-02-09 09:31:35 +00:00
Max Schaefer
fb109672b3
Address more review feedback.
2024-02-09 09:21:30 +00:00
Tony Torralba
34f74869c8
Java: Add extension point and default sanitizer to Open Redirect query
2024-02-09 09:11:07 +01:00
Ian Lynagh
2852f09a1a
Kotlin: Accept test changes in library-tests/java-kotlin-collection-type-generic-methods
...
I'm not sure exactly what's going on here in general, but I've made a
ticket to remind us to come back and look at this whole area.
2024-02-08 17:44:38 +00:00
Dave Bartolomeo
31cb308d4c
Merge pull request #15560 from github/post-release-prep/codeql-cli-2.16.2
...
Post-release preparation for codeql-cli-2.16.2
2024-02-08 09:42:26 -08:00
Dave Bartolomeo
331355d23f
Fix accidental blank line
2024-02-08 12:26:46 -05:00
Dave Bartolomeo
ea004c44f2
Update CHANGELOG.md
...
Fix accidental blank line
2024-02-08 12:26:21 -05:00
Dave Bartolomeo
9190b109e1
Merge branch 'main' into post-release-prep/codeql-cli-2.16.2
2024-02-08 09:21:18 -08:00
github-actions[bot]
7a2332c1ff
Post-release preparation for codeql-cli-2.16.2
2024-02-08 17:17:43 +00:00
Mathias Vorreiter Pedersen
f7d1544ccf
C++: Fix Code Scanning errors.
2024-02-08 17:01:07 +00:00
Mathias Vorreiter Pedersen
1dfddaf9ab
C++: Also mark indirections of glvalue instructions as glvalue nodes.
2024-02-08 16:52:09 +00:00
Mathias Vorreiter Pedersen
4d01a93107
C++: Use 'getUnderlyingType' instead of 'getUnspecifiedType'.
2024-02-08 16:49:15 +00:00
Mathias Vorreiter Pedersen
78ce857ef2
C++: Add consistency test and accept consistency failures.
2024-02-08 16:16:24 +00:00
Dave Bartolomeo
753d78a695
Merge pull request #15557 from github/release-prep/2.16.2
...
Release preparation for version 2.16.2
2024-02-08 08:16:00 -08:00
Koen Vlaswinkel
e596862074
Merge pull request #15541 from github/koesie10/ruby-access-path-constructor-returnvalue
...
Ruby: Remove `ReturnValue` as access path for constructors
2024-02-08 16:25:34 +01:00
github-actions[bot]
36f01ff31a
Release preparation for version 2.16.2
2024-02-08 15:25:24 +00:00
Dave Bartolomeo
a1395d5094
Merge pull request #15556 from github/dbartol/revert-release-prep
...
Revert "Merge pull request #15522 from github/release-prep/2.16.2"
2024-02-08 07:22:25 -08:00
Benjamin Rodes
d4bc2ceb37
Minor efficiency improvements and comments.
2024-02-08 10:11:50 -05:00
Ian Lynagh
f50dab3d93
Kotlin 2: Accept loc changes in library-tests/interface-delegate
2024-02-08 14:45:47 +00:00
Dave Bartolomeo
a58dd45d0b
Revert "Merge pull request #15522 from github/release-prep/2.16.2"
...
This reverts commit c4c8cd6b34 , reversing
changes made to 525f27173d .
2024-02-08 09:28:34 -05:00
Dave Bartolomeo
92bd550c55
Merge pull request #15531 from github/post-release-prep/codeql-cli-2.16.2
...
Post-release preparation for codeql-cli-2.16.2
2024-02-08 05:58:17 -08:00
Max Schaefer
48105db5b0
Fix isNeutral predicates.
2024-02-08 13:22:53 +00:00
Max Schaefer
4b9443eb15
Properly recognise existing models involving subtypes.
...
If an existing source/sink model specifies `subtypes=True` we should apply it to endpoints on overriding methods.
2024-02-08 13:22:53 +00:00
Max Schaefer
a9c0fed4f5
Add test showing spurious sink candidate from method overriding a method for which we have a model.
2024-02-08 13:22:53 +00:00
Max Schaefer
02547d3839
Improve representation of implicit varargs arrays to more reliably filter out known flow steps.
2024-02-08 13:22:52 +00:00
Maiky
ed030bc617
Merge branch 'main' into maikypedia/swift-zip
2024-02-08 14:17:37 +01:00
Ian Lynagh
e0a5efef0a
Merge pull request #15544 from igfoo/igfoo/k2tests
...
Kotlin 2: Some test fixes
2024-02-08 12:57:58 +00:00
Koen Vlaswinkel
87eb1ab103
Ruby: Include ReturnValue and exclude self for constructors
2024-02-08 13:40:10 +01:00
Rasmus Lerchedahl Petersen
45bb4a0ee5
python: remove TaintStepFromSummary
...
as it should be covered by `SummarizedCallableFromModel`
Also move things around, to look more like the Ruby code.
2024-02-08 12:48:15 +01:00
Maiky
62bd3ac748
Merge branch 'main' into maikypedia/swift-zip
2024-02-08 12:29:46 +01:00
Rasmus Lerchedahl Petersen
5cb71ce7e5
python: remove a use of points-to
...
This is used by `Scope::isPublic` which in turn is called by the framework model for `setuptools`.
On my current quesry, this had a dramatic effect on the most expensive predicates:
Before
```
Most expensive predicates for completed query FindUses.ql:
time | evals | max @ iter | predicate
------|-------|--------------|----------
1m9s | 2933 | 123ms @ 422 | PointsTo::Expressions::equalityEvaluatesTo/4#ebe72212@cab7d3xr
43.1s | | | FlowSummaryImpl::Private::Steps::summaryLocalStep/3#900fb25e#ffb@8aa78a38
41.3s | 2936 | 2.1s @ 409 | PointsTo::InterProceduralPointsTo::scope_entry_value_transfer_from_earlier/4#acb2199d@cab7ddxr
30.2s | 2946 | 67ms @ 847 | PointsTo::PointsToInternal::multi_assignment_points_to/4#28782e93@cab7d0yr
29.7s | 2930 | 1.9s @ 30 | Extensions::ReModulePointToExtension.pointsTo_helper/1#a84effde@cab7dn4w
24.9s | 2933 | 84ms @ 414 | PointsTo::Expressions::inequalityEvaluatesTo/4#f0ecfab4@cab7d2xr
17.9s | 2582 | 306ms @ 31 | MRO::ClassListList.getItem/1#b6c27115#reorder_2_0_1@cab7dw6r
9.4s | 661 | 991ms @ 1 | SsaCompute::AdjacentUses::varBlockReaches/3#1824ad86@2b6af692
9.2s | 2738 | 26ms @ 664 | MRO::ClassList.containsSpecial/0#c967dabb#fb@cab7dg4w
8.9s | 2946 | 12ms @ 917 | PointsTo::Types::getBase/2#0ab04984@cab7du1w
7.4s | 2946 | 287ms @ 3 | PointsTo::PointsToInternal::points_to_candidate/4#0a587a42@cab7d80w
7.1s | 2934 | 14ms @ 2 | Constants::ConstantObjectInternal.attribute/3#6d9e12fc@cab7d6zr
6.8s | 2946 | 9ms @ 48 | PointsTo::InterProceduralPointsTo::callsite_points_to/4#72419c70@cab7dqxr
6.6s | 234 | 341ms @ 17 | ApiGraphs::API::Impl::rhs/3#2255afc6@a41b31w3
6.6s | 2946 | 86ms @ 5 | PointsTo::Types::six_add_metaclass/4#f926a4cb@cab7da0w
6.2s | 2930 | 341ms @ 30 | Extensions::RangeIterationVariableFact.pointsTo/3#662720c9#cpe#124@cab7di2w
5.9s | 287 | 61ms @ 4 | DataFlowDispatch::TrackAttrReadInput::start/2#67f26627@cc7b56yn
5.8s | | | DataFlowImplCommon::LambdaFlow::viableParamNonLambda/3#3123cc52_201#join_rhs@415f35h0
5.6s | | | FlowSummaryImpl::Private::Steps::viableParam/4#49c13ab8@2c1fcdq1
5.3s | | | FlowSummaryImpl::Private::Steps::viableParam/4#49c13ab8@22590ca9
5.2s | 233 | 276ms @ 21 | ApiGraphs::API::Impl::use/3#e6c88b66@a41b30w3
5.1s | 2945 | 177ms @ 4 | PointsTo::PointsToInternal::pointsTo/4#d99f16c6@cab7dj0w
4.7s | | | Flow::ControlFlowNode.toString/0#dispred#e1af144b@410c23a7
4.6s | 277 | 2.2s @ 6 | DataFlowDispatch::getCallArg/5#21589076@cc7b5vxn
4.5s | | | DataFlowImplCommon::Cached::viableParam/3#61239ead@cc05a1fv
4.3s | | | DataFlowImplCommon::LambdaFlow::viableParamNonLambda/3#3123cc52@cb992b2h
4.1s | | | _AstExtended::AstNode.getLocation/0#dispred#6b4dcb62_10#join_rhs_DataFlowPublic::Node.getLocation/0#__#shared@6ae639js
4s | | | Files::Location.toString/0#dispred#7e7e0516@b72abbo2
3.7s | | | locations_ast_234501#join_rhs@0859685o
3.7s | 10 | 1.7s @ 1 | ObjectInternal::ObjectInternal.toString/0#dispred#0b2e9429@6e8a4yh7
3.6s | 2942 | 63ms @ 94 | PointsTo::InterProceduralPointsTo::call_points_to_from_callee/4#394022a8@cab7d90w
3.6s | 232 | 213ms @ 18 | ApiGraphs::API::Impl::trackDefNode/2#8e3c4e6d@a41b33w3
3.6s | 2933 | 7ms @ 884 | PointsTo::Types::getInheritedMetaclass/2#097d39df#bff@cab7dr1w
3.6s | 2946 | 1.3s @ 13 | PointsTo::PointsToInternal::ssa_node_refinement_points_to/4#8ea6486b@cab7dnxr
3.5s | 1319 | 387ms @ 3 | SsaCompute::SsaDefinitions::reachesEndOfBlock/4#214bd902@fce54web
3.5s | 1320 | 385ms @ 2 | SsaCompute::SsaDefinitions::reachesEndOfBlockRec/4#63bb2cd4@fce54xeb
3.4s | 4861 | 478ms @ 2 | SsaCompute::SsaComputeImpl::ssaDefReachesRank/4#f19c6fee@cc8515rd
3.3s | | | _AstExtended::AstNode.getLocation/0#dispred#6b4dcb62_10#join_rhs_DataFlowPublic::Node.getLocation/0#__#higher_order_body@47ba63n6
3.3s | | | DataFlowPublic::Node.toString/0#dispred#af9c307a@4d16e7m6
3.3s | 2946 | 28ms @ 3 | PointsTo::PointsToInternal::reachableEdge/3#d3f53c12@cab7do7w
2.9s | 233 | 110ms @ 19 | ApiGraphs::API::Impl::trackUseNode/2#a0b4384d@a41b32w3
2.8s | 31 | 2.2s @ 9 | _Class::Class.getAMethod/0#dispred#66416e47_DataFlowDispatch::findFunctionAccordingToMroKnownStartin__#antijoin_rhs@L6#cc7b5
2.8s | 2737 | 21ms @ 444 | MRO::ClassListList.removedClassParts/4#de59b06f#reorder_2_3_4_0_1@cab7d06w
2.8s | 1322 | 462ms @ 4 | SsaCompute::Liveness::liveAtExit/2#b6aa63f4@6fd4cx73
2.8s | 2946 | 187ms @ 5 | PointsTo::Expressions::builtinCallPointsTo/5#3aa7f48b@cab7dwwr
2.8s | 2939 | 41ms @ 7 | PointsTo::PointsToInternal::use_points_to/4#ff1d0edd@cab7df0w
2.7s | 2946 | 20ms @ 92 | PointsTo::Conditionals::evaluates/5#736734b2#fbffff#reorder_5_0_2_1_3_4@cab7dp5w
2.6s | 2946 | 152ms @ 5 | Constants::callToBool/2#0b9b1e8d@cab7dn7w
2.5s | 287 | 24ms @ 4 | DataFlowDispatch::resolveClassInstanceCall/3#6e09c292@cc7b53xn
2.4s | 2946 | 31ms @ 5 | PointsTo::AttributePointsTo::variableAttributePointsTo/5#60adcc49@cab7dpwr
[2024-02-08 10:44:37] Total evaluation times for this run:
* Wall-clock duration of evaluation run: 1231.1 seconds
* Total time spent evaluating predicates: 1167.1 seconds
```
After
```
Most expensive predicates for completed query FindUses.ql:
time | evals | max @ iter | predicate
------|-------|--------------|----------
41.6s | | | FlowSummaryImpl::Private::Steps::summaryLocalStep/3#900fb25e#ffb@85aaaac1
9.2s | 661 | 905ms @ 1 | SsaCompute::AdjacentUses::varBlockReaches/3#1824ad86@2b6af692
7.6s | 234 | 502ms @ 19 | ApiGraphs::API::Impl::rhs/3#2255afc6@ce6d11wc
6.7s | | | DataFlowImplCommon::LambdaFlow::viableParamNonLambda/3#3123cc52_201#join_rhs@fd1dc5mi
6s | 287 | 80ms @ 113 | DataFlowDispatch::TrackAttrReadInput::start/2#67f26627@925826yr
5.7s | | | FlowSummaryImpl::Private::Steps::viableParam/4#49c13ab8@851052bl
5.6s | 233 | 289ms @ 21 | ApiGraphs::API::Impl::use/3#e6c88b66@ce6d10wc
5.4s | | | FlowSummaryImpl::Private::Steps::viableParam/4#49c13ab8@f2c42d17
4.8s | 277 | 2.4s @ 6 | DataFlowDispatch::getCallArg/5#21589076@92582vxr
4.7s | | | DataFlowImplCommon::Cached::viableParam/3#61239ead@ac08e0nf
4.7s | | | DataFlowImplCommon::LambdaFlow::viableParamNonLambda/3#3123cc52@82ff50ql
4.6s | | | Files::Location.toString/0#dispred#7e7e0516@b72abbo2
4.3s | | | Flow::ControlFlowNode.toString/0#dispred#e1af144b@410c23a7
4.2s | 232 | 249ms @ 19 | ApiGraphs::API::Impl::trackDefNode/2#8e3c4e6d@ce6d13wc
3.8s | | | _AstExtended::AstNode.getLocation/0#dispred#6b4dcb62_10#join_rhs_DataFlowPublic::Node.getLocation/0#__#shared@0ac73425
3.6s | 1319 | 354ms @ 1 | SsaCompute::SsaDefinitions::reachesEndOfBlock/4#214bd902@fce54web
3.6s | 1320 | 381ms @ 2 | SsaCompute::SsaDefinitions::reachesEndOfBlockRec/4#63bb2cd4@fce54xeb
3.4s | | | _AstExtended::AstNode.getLocation/0#dispred#6b4dcb62_10#join_rhs_DataFlowPublic::Node.getLocation/0#__#higher_order_body@9e946ea8
3.4s | 4861 | 474ms @ 2 | SsaCompute::SsaComputeImpl::ssaDefReachesRank/4#f19c6fee@cc8515rd
3.1s | 31 | 2.5s @ 9 | _Class::Class.getAMethod/0#dispred#66416e47_DataFlowDispatch::findFunctionAccordingToMroKnownStartin__#antijoin_rhs@L6#92582
3s | 53 | 114ms @ 48 | DataFlowDispatch::TrackAttrReadInput::start/2#67f26627@9ab38jw0
3s | 233 | 126ms @ 20 | ApiGraphs::API::Impl::trackUseNode/2#a0b4384d@ce6d12wc
3s | | | locations_ast_234501#join_rhs@0859685o
3s | | | DataFlowPublic::Node.toString/0#dispred#af9c307a@a2145cqf
2.8s | 234 | 206ms @ 21 | _ApiGraphs::API::Impl::MkDef#51c2f877#prev_ApiGraphs::API::Impl::trackDefNode/1#7e78e336#prev_delta___#antijoin_rhs#1@L9#ce6d1
2.8s | 1322 | 447ms @ 4 | SsaCompute::Liveness::liveAtExit/2#b6aa63f4@6fd4cx73
2.7s | 230 | 176ms @ 28 | ApiGraphs::API::Impl::MkDef#51c2f877@ce6d1w9c
2.5s | 287 | 50ms @ 112 | DataFlowDispatch::resolveClassInstanceCall/3#6e09c292@925823xr
2.4s | 234 | 246ms @ 19 | _ApiGraphs::API::Impl::MkDef#51c2f877#prev_ApiGraphs::API::Impl::trackDefNode/1#7e78e336#prev_delta___#antijoin_rhs@L4#ce6d1
2.3s | | | TaintTrackingPrivate::localAdditionalTaintStep/2#a2ec8c9d@e31201hd
2.2s | 53 | 72ms @ 15 | DataFlowDispatch::TrackAttrReadInput::start/2#67f26627@96b28jwo
2.2s | | | SensitiveDataSources::SensitiveDataModeling::sensitiveString/1#fdc3ad40@41f6ee2g
2s | | | DataFlowImplCommon::Cached::viableParamArg/3#4c55eddb@8f7f25oq
2s | | | Flow::ControlFlowNode.getExprChild/1#e757d179#bbf@db51e8ed
1.9s | | | project#FlowSummaryImpl::Private::Steps::viableParam/4#49c13ab8#2@e36c2dr8
1.9s | | | DataFlowPublic::Node.hasLocationInfo/5#dispred#b79d995f@6e929dfv
1.7s | 15 | 433ms @ 1 | PoorMansFunctionResolution::poorMansFunctionTracker/2#75430e01@e5202dnv
1.7s | | | #ImportResolution::ImportResolution::allowedEssaImportStep/2#f4117c61Plus#swapped@60d9daea
1.7s | 29 | 633ms @ 6 | _Class::Class.getAMethod/0#dispred#66416e47_Function::Function.getName/0#dispred#033700ef_10#join_rh__#antijoin_rhs@L4#92582
1.5s | 233 | 79ms @ 24 | ApiGraphs::API::Impl::trackUseNode/1#1af3a9ea@ce6d16wc
1.5s | | | ApiGraphs::API::Impl::edge/3#8453bf65@1bd8a6ja
1.5s | | | ApiGraphs::API::Node.getAValueReachableFromSource/0#dispred#9a406fb1@5dbb806u
1.3s | 1323 | 178ms @ 13 | SsaCompute::Liveness::liveAtEntry/2#bab3ea7c@6fd4cw73
1.3s | | | SsaCompute::SsaComputeImpl::defUseRank/4#782a2f48@0f27919s
1.3s | | | DataFlowDispatch::LibraryCallable.getACall/0#dispred#66a01171#fb@96b65frd
1.3s | | | ApiGraphs::API::Node.getAValueReachableFromSource/0#dispred#9a406fb1_10#join_rhs@c1dd43nv
1.3s | | | FlowSummaryImpl::Private::SummaryNode.toString/0#dispred#d499e234@63bd684g
1.2s | | | DataFlowDispatch::LibraryCallable.getACall/0#dispred#66a01171#fb@eaebb27g
1.2s | | | _DataFlowPublic::Node#da3b6093_DataFlowPublic::Node.asExpr/0#dispred#2845197a_py_exprs#antijoin_rhs@fcd8c3kj
1.2s | | | #ImportResolution::ImportResolution::allowedEssaImportStep/2#f4117c61Plus#swapped@c3f634us
[2024-02-08 11:43:50] Total evaluation times for this run:
* Wall-clock duration of evaluation run: 636.9 seconds
* Total time spent evaluating predicates: 562.4 seconds
```
2024-02-08 12:20:56 +01:00
Anders Schack-Mulligen
bcfce56ef6
Merge pull request #15547 from aschackmull/csharp/contentdataflow
...
C#: Simplify, getASuccessor is pruned now.
2024-02-08 11:15:14 +01:00
Anders Schack-Mulligen
dfc9c4d079
C#: Simplify, getASuccessor is pruned now.
2024-02-08 10:36:55 +01:00
Michael Nebel
a54caeaf61
Merge pull request #15545 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-02-08 08:55:41 +01:00
Tamás Vajk
290c3454c8
Merge pull request #15535 from tamasvajk/buildless/winforms-usings
...
C# Add missing Windows Forms implicit usings
2024-02-08 08:20:05 +01:00
github-actions[bot]
070402d3ae
Add changed framework coverage reports
2024-02-08 00:15:53 +00:00
Tamas Vajk
1c7e6e769b
C#: Try resolve relative paths in line mappings
2024-02-07 23:48:58 +01:00
Benjamin Rodes
915aa94b13
Merge branch '51-2cppnon-constant-format-alter-not-const-source' of https://github.com/microsoft/codeql into 51-2cppnon-constant-format-alter-not-const-source
2024-02-07 14:15:40 -05:00
Benjamin Rodes
f12a1ecdf2
Simplifying the query.
2024-02-07 14:15:16 -05:00
Ben Rodes
2c962d51a9
Merge branch 'main' into 51-2cppnon-constant-format-alter-not-const-source
2024-02-07 10:57:31 -08:00
Benjamin Rodes
50134e644f
Merge branch '50-model-gettext-family-of-string-operations' into 51-2cppnon-constant-format-alter-not-const-source
...
# Conflicts:
# cpp/ql/src/Likely Bugs/Format/NonConstantFormat.ql
2024-02-07 13:56:39 -05:00
Benjamin Rodes
9fc2405681
Updating non-const source logic and associated tests and expected files.
2024-02-07 13:54:56 -05:00
Robert Marsh
174966164d
Merge branch 'main' into rdmarsh2/cpp/ir-synthetic-destructors
2024-02-07 18:25:12 +00:00
Geoffrey White
a354ab84e9
C++: More robust InterpretNode.asCall.
2024-02-07 18:00:57 +00:00
Geoffrey White
e98485df7f
Update cpp/ql/lib/semmle/code/cpp/dataflow/internal/FlowSummaryImpl.qll
...
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com >
2024-02-07 17:53:22 +00:00
Ian Lynagh
ef8e6c8805
Kotlin 2: Accept loc changes in library-tests/exprs/funcExprs.expected
2024-02-07 16:40:40 +00:00
Ian Lynagh
8a93133b81
Kotlin 2: Accept loc changes in library-tests/exprs/unaryOp.expected
2024-02-07 16:21:49 +00:00
Ian Lynagh
c314cc8b68
Kotlin 2: Accept some location changes in library-tests/exprs/binop.expected
2024-02-07 15:56:10 +00:00
Henry Mercer
23921afd8d
Merge pull request #15532 from github/henrymercer/add-build-modes
...
Add supported build modes to extractor metadata
2024-02-07 15:54:44 +00:00
Mathias Vorreiter Pedersen
ebefcb8d35
Merge pull request #15513 from microsoft/50-model-gettext-family-of-string-operations
...
Added model for gettext variants.
2024-02-07 15:48:16 +00:00
Ian Lynagh
c731251e61
Kotlin 2: Remove an unused diagnostic matcher in library-tests/dataflow/func
2024-02-07 15:32:04 +00:00
Paolo Tranquilli
b105d0cf9a
Bazel/CMake: be more lenient with aquery
...
It turns out `bazel aquery` is not so well behaved on Windows, so we
need to accept that it reports errors and exits with an error.
2024-02-07 16:25:54 +01:00
Mathias Vorreiter Pedersen
0ee3c9987f
Merge pull request #15539 from MathiasVP/fix-ir-gen-for-conditional-decl-expr-without-var-access
...
C++: Fix IR generation when `ConditionDeclExpr` does not have an immediate `VariableAccess`
2024-02-07 15:19:16 +00:00
Ian Lynagh
3d1f9a79fb
Kotlin 2: Accept location changes in test-kotlin2/library-tests/data-classes
2024-02-07 15:17:40 +00:00
Benjamin Rodes
5866fc1fd0
Updating expected file.
2024-02-07 10:12:25 -05:00
Ian Lynagh
1c6108028b
Kotlin 2: Accept some location changes for arrays
2024-02-07 15:12:17 +00:00
maikypedia
ed052ccc26
Change note
2024-02-07 15:58:10 +01:00
Mathias Vorreiter Pedersen
df181f2dc4
C++: Accept more test changes.
2024-02-07 14:50:18 +00:00
Mathias Vorreiter Pedersen
23677b23c2
Merge pull request #15537 from MathiasVP/swap-also-clears-first-argument
...
C++: Also clear the `0`'th argument of `swap`
2024-02-07 14:35:31 +00:00
Mathias Vorreiter Pedersen
950b5f2235
C++: Block flow out of 'gettext' in 'cpp/non-constant-format'. ( #52 )
2024-02-07 09:10:12 -05:00
Tamas Vajk
4eeca02da6
Change file content string comparisons to be case invariant
2024-02-07 14:58:19 +01:00
maikypedia
1a499cf388
Update expected
2024-02-07 14:38:21 +01:00
Koen Vlaswinkel
8646bffaea
Ruby: Remove ReturnValue as access path for constructors
2024-02-07 14:35:19 +01:00
Maiky
7c0f80ff7d
Apply suggestions from code review
...
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com >
2024-02-07 14:32:42 +01:00
Maiky
7fb72ea81f
Redundant import
2024-02-07 14:30:16 +01:00
Maiky
c6fb303d63
Suggested changes
...
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com >
2024-02-07 14:27:40 +01:00
Maiky
9ce75dac0e
Update UnsafeUnpackQuery.qll
2024-02-07 14:26:56 +01:00
Max Schaefer
082754a3d8
Remove problematic Kotlin model.
2024-02-07 13:21:59 +00:00
Mathias Vorreiter Pedersen
fe5eca4134
C++: Accept test changes.
2024-02-07 11:45:40 +00:00
Mathias Vorreiter Pedersen
edc7903c69
C++: Add a predicate for getting the 0'th child of a 'ConditionDeclExpr' without casting it to a 'VariableAccess' and use it in IR generation.
2024-02-07 11:45:13 +00:00
Mathias Vorreiter Pedersen
d0b0440427
C++: Add a testcase with failing IR generation.
2024-02-07 11:38:02 +00:00
Mathias Vorreiter Pedersen
4b046ad670
C++: Also clear the 0'th argument of 'swap'.
2024-02-07 10:31:18 +00:00
Paolo Tranquilli
9cfef6e42f
Bazel/CMake: auto detect all cc_binary/cc_test targets
2024-02-07 11:11:30 +01:00
Mathias Vorreiter Pedersen
c5dc88345d
Merge pull request #15528 from MathiasVP/flow-barrier-interface
...
C++: Add an interface for models to block flow
2024-02-07 09:58:08 +00:00
Tamas Vajk
b8dbb8c866
C# Add missing Windows Forms implicit usings
2024-02-07 10:41:21 +01:00
Michael B. Gale
781486172e
Merge pull request #15534 from github/dependabot/go_modules/go/extractor/extractor-dependencies-cd731e5d14
2024-02-07 08:35:11 +00:00
Michael Nebel
167a8f0e4a
Merge pull request #15459 from michaelnebel/csharp/spansummaries
...
C#: Add summaries for Span<T> and ReadOnlySpan<T>.
2024-02-07 08:54:19 +01:00
Tamás Vajk
54c9135936
Merge pull request #15518 from tamasvajk/feature/telemetry-dependency-manager
...
C#: Extract dependency restore telemetry data
2024-02-07 08:14:01 +01:00
dependabot[bot]
565426940c
Bump the extractor-dependencies group in /go/extractor with 1 update
...
Bumps the extractor-dependencies group in /go/extractor with 1 update: [golang.org/x/mod](https://github.com/golang/mod ).
Updates `golang.org/x/mod` from 0.14.0 to 0.15.0
- [Commits](https://github.com/golang/mod/compare/v0.14.0...v0.15.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/mod
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: extractor-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-02-07 03:32:07 +00:00
Robert Marsh
5653c3f972
C++: Update IR test expectations for named destructors
2024-02-06 21:04:52 +00:00
Jonathan Leitschuh
1484a169d7
Reduce severity of java/relative-path-command
...
Significantly reduces the severity of `java/relative-path-command` from 9.8 to 5.4
https://www.first.org/cvss/calculator/4.0#CVSS:4.0/AV:L/AC:L/AT:P/PR:H/UI:P/VC:H/VI:H/VA:H/SC:N/SI:N/SA:N
2024-02-06 15:43:19 -05:00
Mathias Vorreiter Pedersen
3b43f848c9
Merge pull request #15529 from MathiasVP/delete-get-interval-updated-by-chi
2024-02-06 19:55:24 +00:00
Henry Mercer
e71f0fc1ba
Add supported build modes to extractor metadata
2024-02-06 19:51:13 +00:00
github-actions[bot]
b5139078d0
Post-release preparation for codeql-cli-2.16.2
2024-02-06 19:22:35 +00:00
Benjamin Rodes
80bf38d8cc
Initial working draft of non-const source refactor.
2024-02-06 14:20:01 -05:00
Geoffrey White
f6b412e1c9
C++: Use hasQualifiedName.
2024-02-06 17:48:42 +00:00
Benjamin Rodes
5e5fea8ef3
Merge branch '50-model-gettext-family-of-string-operations' into 51-2cppnon-constant-format-alter-not-const-source
2024-02-06 12:47:08 -05:00
Geoffrey White
d1e040e27c
C++: Bug fix for subclasses.
2024-02-06 17:45:14 +00:00
Mathias Vorreiter Pedersen
b68824a337
C#: Sync identical files.
2024-02-06 17:41:11 +00:00
Mathias Vorreiter Pedersen
7948911415
C++: Delete dead code.
2024-02-06 17:38:22 +00:00
Geoffrey White
a9b2876b71
C++: Delete commented out code.
2024-02-06 17:34:15 +00:00
Geoffrey White
66d8943c08
C++: Minor bug fix.
2024-02-06 17:20:14 +00:00
Erik Krogh Kristensen
43f1189615
Merge pull request #15526 from github/erik-krogh/fix-jndi-typo
...
Java: fix typo in JndiInjection.qhelp
2024-02-06 17:39:25 +01:00
Geoffrey White
25200b47ea
C++: Implement the namespace field.
2024-02-06 16:35:48 +00:00
Geoffrey White
a5527903e9
C++: Fix some mistakes in the MAD definitions for the tests.
2024-02-06 16:34:07 +00:00
Mathias Vorreiter Pedersen
f7fe84adb4
C++: Add change note.
2024-02-06 16:23:59 +00:00
Mathias Vorreiter Pedersen
21b9b3b87f
C++: Accept test changes.
2024-02-06 16:15:22 +00:00
Mathias Vorreiter Pedersen
359b6e14c6
C++: Block flow out of 'swap'.
2024-02-06 16:15:21 +00:00
Mathias Vorreiter Pedersen
e539aca337
C++: Add an interface for blocking flow out of functions that reach a certain argument.
2024-02-06 16:15:21 +00:00
Robert Marsh
40e06b7877
C++: suppress destructor calls on delete in IR generation
...
This avoids an issue with duplicated qualifiers that was causing broken control flow
2024-02-06 14:55:00 +00:00
Dave Bartolomeo
c4c8cd6b34
Merge pull request #15522 from github/release-prep/2.16.2
...
Release preparation for version 2.16.2
2024-02-06 06:21:14 -08:00
Erik Krogh Kristensen
879d882fa4
Java: fix typo in JndiInjection.qhelp
2024-02-06 15:17:30 +01:00
Benjamin Rodes
fc509c2cbe
Added additional gettext variant test.
2024-02-06 09:17:10 -05:00
Ben Rodes
0023291903
Update cpp/ql/src/change-notes/2024-02-05-gettext-dataflows.md
...
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com >
2024-02-06 09:12:25 -05:00
Michael Nebel
2e4786c2ab
C#: Update flow summaries expected output test.
2024-02-06 14:06:07 +01:00
Michael Nebel
31b0da7639
C#: Update models for Except and DefaultIfEmpty.
2024-02-06 14:00:59 +01:00
Max Schaefer
705a377060
Address review comments.
2024-02-06 12:54:29 +00:00
Tamás Vajk
681c37d5fc
Code quality improvement
...
Co-authored-by: Michael Nebel <michaelnebel@github.com >
2024-02-06 13:49:08 +01:00
Geoffrey White
7514037464
C++: Add test cases for MAD sources, sinks and summaries in namespaces.
2024-02-06 12:12:28 +00:00
Mathias Vorreiter Pedersen
33cefabe27
Update cpp/ql/src/CHANGELOG.md
2024-02-06 11:05:22 +00:00
Mathias Vorreiter Pedersen
6c1e3b1ba6
Update cpp/ql/src/change-notes/released/0.9.4.md
2024-02-06 11:02:15 +00:00
Michael Nebel
b41758fb39
C#: Update summaries for Enumerable.DefaultIfEmpty to target elements in the return value.
2024-02-06 11:24:02 +01:00
Koen Vlaswinkel
8361efca4d
Merge pull request #15503 from github/koesie10/ruby-access-paths
...
Ruby: Add query for access paths in model editor
2024-02-06 10:12:26 +01:00
Erik Krogh Kristensen
cec124c0be
Merge pull request #15480 from ockers/ockers/certification_not_certificate
...
False positive in SensitiveDataHeuristics - exclude certification from maybeCertificate() regex
2024-02-06 09:40:25 +01:00
erik-krogh
94b7bda3dc
exclude tagged template literals from js/superfluous-trailing-arguments
2024-02-06 09:36:30 +01:00
erik-krogh
4e176236e7
add a definition of user
2024-02-06 09:21:35 +01:00
erik-krogh
44fe34a37d
use the correct string type in the tainted-path examples
2024-02-06 09:20:27 +01:00
Tamas Vajk
e4a4e3af39
Update DB stats
2024-02-06 08:18:27 +01:00
Jim Ockers
01e8109b71
Merge branch 'main' into ockers/certification_not_certificate
2024-02-05 13:42:00 -08:00
Robert Marsh
8013c2a074
C++: QLDoc and naming updates for implicit destructors in IR
2024-02-05 19:14:56 +00:00
Robert Marsh
bbabf1dfcc
C++: add test for constructors in C++17 decl-in-if
2024-02-05 18:41:18 +00:00
Benjamin Rodes
256554df06
Added change log
2024-02-05 13:04:16 -05:00
Benjamin Rodes
5b2d15265f
gettext variant dataflow tests
2024-02-05 13:01:51 -05:00
github-actions[bot]
c1b35fbf47
Release preparation for version 2.16.2
2024-02-05 17:58:57 +00:00
Harry Maclean
f792b58421
Ruby: Recognise more ActiveRecord connections
2024-02-05 16:45:59 +00:00
Joe Farebrother
525f27173d
Merge pull request #15396 from joefarebrother/android-sensitive-ui-text
...
Java: Add query for sensitive data exposed in text fields
2024-02-05 15:47:03 +00:00
Koen Vlaswinkel
6a098120e3
Rename details to node
2024-02-05 16:33:29 +01:00
Koen Vlaswinkel
49dbad96f9
Switch from details string to DataFlow::Node
2024-02-05 16:33:01 +01:00
Ben Rodes
e47df5c7bc
Update NonConstantFormat.ql
...
Removed dead comment
2024-02-05 09:39:05 -05:00
Ben Rodes
88a06ffc66
Update GetText.qll
...
Fixing issue based on review.
2024-02-05 09:18:30 -05:00
Tamas Vajk
809da54229
Revert unneeded changes and simplify code
2024-02-05 14:21:13 +01:00
erik-krogh
a6b094cf53
delete the rendered markdown again
2024-02-05 13:54:13 +01:00
Tamas Vajk
24a7a7644d
Remove superfluous conjunct to improve code quality
2024-02-05 13:50:20 +01:00
Tamas Vajk
397d814c8b
Add change note
2024-02-05 13:48:28 +01:00
Tamas Vajk
5d08dc748d
Add DB upgrade downgrade script
2024-02-05 13:45:31 +01:00
Tamas Vajk
c2c7826936
C#: Extract dependency restore telemetry data
2024-02-05 13:09:04 +01:00
erik-krogh
a240618ae4
generate the new rendered markdown
2024-02-05 13:09:02 +01:00
erik-krogh
8160291be1
copy (and adjust) the path-injection QHelp from Java to C#
2024-02-05 13:08:44 +01:00
Harry Maclean
03ab3c1a5d
Ruby: Fix title underline
2024-02-05 11:15:53 +00:00
Harry Maclean
6748f6e5c7
Ruby: Add docs for MaD
2024-02-05 11:07:23 +00:00
erik-krogh
9dfac3a4cc
move qhelp samples to an examples folder
2024-02-05 11:20:24 +01:00
erik-krogh
b8dc633864
add cs/path-injection as markdown to make nicer diffs
2024-02-05 11:16:16 +01:00
Tony Torralba
6fbbb82f68
Merge pull request #15517 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-02-05 08:45:57 +01:00
github-actions[bot]
ee5df7bf58
Add changed framework coverage reports
2024-02-05 00:16:44 +00:00
Jim Ockers
e477909200
Merge branch 'main' into ockers/certification_not_certificate
2024-02-02 15:39:29 -08:00
Benjamin Rodes
e8587d060d
Removing comments and formatting.
2024-02-02 16:23:14 -05:00
Benjamin Rodes
9577c35d85
Incremental update to NonConstantFormat.ql
2024-02-02 16:06:59 -05:00
James Ockers
9f7f9fcc6e
Updating change-notes to reflect what will be the visible change to end users
2024-02-02 11:38:17 -08:00
Robert Marsh
2d010f69c6
C++: Test for destructors in declaration as if condition
2024-02-02 17:39:27 +00:00
Robert Marsh
984c7ab85a
C++: test for declarations in if statement
2024-02-02 17:39:26 +00:00
Robert Marsh
4513fd1b52
C++: test for destructors in range-based for
2024-02-02 17:39:26 +00:00
Robert Marsh
820f4a5571
C++: custom destructor handling for for loops
2024-02-02 17:39:23 +00:00
Robert Marsh
85d1d079c8
C++: Add implicit named destructosrs to the IR CFG
2024-02-02 17:36:02 +00:00
Joe Farebrother
596f48ca95
Add change note
2024-02-02 17:35:07 +00:00
Joe Farebrother
5022adba56
Fixes to qhelp example
2024-02-02 17:26:00 +00:00
Joe Farebrother
3878192810
Apply suggestions from documentation review
...
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com >
2024-02-02 17:21:23 +00:00
Joe Farebrother
71852868ac
Add case for androidx.biometric api
2024-02-02 17:19:20 +00:00
Robert Marsh
3a404cec67
C++: Add getLastInstruction to IR generation
2024-02-02 17:10:47 +00:00
Benjamin Rodes
022276badc
Added model for gettext variants.
2024-02-02 12:05:52 -05:00
Robert Marsh
47720e0998
C++: generate instructions for destructor calls in IR
2024-02-02 17:05:40 +00:00
Ian Lynagh
643817e74e
Merge pull request #15477 from igfoo/igfoo/kot_path_trans
...
Kotlin: Add path transformer support
2024-02-02 15:34:14 +00:00
Mathias Vorreiter Pedersen
8d53bce842
Merge pull request #15476 from geoffw0/preprocblock
...
C++: Add PreprocBlock.qll library
2024-02-02 15:06:17 +00:00
Nick Rolfe
514a92d5bd
Tree-sitter extractors: use fresh IDs for locations
...
Since locations for any given source file are never referenced in any
TRAP files besides the one for that particular source file, it's not
necessary to use global IDs. Using fresh IDs will reduce the size of the
ID pool (both on disk and in memory) and the speed of multi-threaded
TRAP import.
The one exception is the empty location, which still uses a global ID.
2024-02-02 15:06:10 +00:00
Joe Farebrother
2a00375bb7
Add documentation
2024-02-02 14:34:43 +00:00
Max Schaefer
21c0422dc7
Merge pull request #15499 from github/max-schaefer/automodel-functional-interface-expr
...
Automodel: Do not consider `@FunctionalInterface`-typed expressions as candidates.
2024-02-02 14:28:41 +00:00
Michael Nebel
4acce3276a
C#: Update FlowSummaries expected output test.
2024-02-02 14:47:45 +01:00
Michael Nebel
f6e3027321
C#: Add summaries for Span<T> and ReadOnlySpan<T> extension methods.
2024-02-02 14:47:45 +01:00
Michael Nebel
91d844316a
C#: Add some tests with expected output.
2024-02-02 14:47:45 +01:00
Michael Nebel
7f5d2e1f44
C#: Update flowsummaries expected output.
2024-02-02 14:47:44 +01:00
Michael Nebel
6ff22622ca
C#: Add summaries for Span<T> and ReadOnlySpan<T>.
2024-02-02 14:47:44 +01:00
Jeroen Ketema
6b13a8c568
Merge pull request #15504 from MathiasVP/block-summary-flow-out-of-strdup-and-friends
...
C++: Block summary flow through `strdup` and friends
2024-02-02 14:47:05 +01:00
Anders Schack-Mulligen
f631c01fe2
Merge pull request #15511 from aschackmull/java/adjust-mad-abstractstringbuilder
...
Java: Remove two redundant models implied by CharSequence models.
2024-02-02 14:45:06 +01:00
Michael Nebel
bf94a75698
Merge pull request #15502 from michaelnebel/csharp/refstructdataflow
...
C#: Inter-procedural dataflow for `ref` structs when used as arguments.
2024-02-02 14:44:51 +01:00
Koen Vlaswinkel
f83d2a7d55
Ruby: Avoid using toString where possible
2024-02-02 14:18:21 +01:00
Koen Vlaswinkel
ac1ebf27a7
Ruby: Rename suggestion predicates
2024-02-02 14:18:16 +01:00
Tom Hvitved
6df313b9d1
Merge pull request #15509 from hvitved/csharp/node-reuse-dependency-fetching
...
C#: Disable msbuild node reuse in dependency fetcher
2024-02-02 13:54:53 +01:00
Geoffrey White
72948cbc46
C++: Remove all cached tags.
2024-02-02 12:23:06 +00:00
Anders Schack-Mulligen
49b00f3842
Java: Remove two redundant models implied by CharSequence models.
2024-02-02 13:17:26 +01:00
Mathias Vorreiter Pedersen
439d3d2438
C++: Add tests with higher level of indirection.
2024-02-02 12:09:46 +00:00
Rasmus Lerchedahl Petersen
3b1751dc8a
Update supported versions
2024-02-02 11:45:21 +01:00
Mathias Vorreiter Pedersen
0729c602c5
Update cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll
...
Co-authored-by: Jeroen Ketema <93738568+jketema@users.noreply.github.com >
2024-02-02 10:39:40 +00:00
Rasmus Lerchedahl Petersen
f433039a25
Add change note
2024-02-02 11:23:35 +01:00
Rasmus Lerchedahl Petersen
f275531542
Add support for TS 5.4-beta
2024-02-02 11:03:44 +01:00
Geoffrey White
56538472cf
C++: Update the change note.
2024-02-02 09:55:44 +00:00
Geoffrey White
7c37be2e88
C++: Address implicit this.
2024-02-02 09:49:13 +00:00
Mathias Vorreiter Pedersen
b0393287cd
Merge pull request #15421 from jketema/unique-function-fix
...
C++: Ensure that only one Function exists for every function - take 2
2024-02-02 09:42:32 +00:00
Tom Hvitved
fa3130cc95
C#: Disable msbuild node reuse in dependency fetcher
2024-02-02 10:15:33 +01:00
Tamás Vajk
5ab4ed1b3b
Merge pull request #15505 from tamasvajk/feature/improve-logs
...
C#: Improve messages in buildless extraction logs
2024-02-02 09:22:17 +01:00
Mathias Vorreiter Pedersen
6f5ed9ad3b
C++: Accept test changes.
2024-02-01 20:15:15 +00:00
Mathias Vorreiter Pedersen
5ad3e97798
C++: Fix TODO by blocking summary flow through functions that don't preserve identity.
2024-02-01 20:15:15 +00:00
Asger F
8a2485a22f
JS: Address some comments
2024-02-01 20:54:27 +01:00
Ian Lynagh
68f267798e
Kotlin: Add support for path transformers
2024-02-01 18:07:47 +00:00
Geoffrey White
649af822fd
C++: Fix the issue with missing return kinds when function bodies are not in the database.
2024-02-01 17:04:20 +00:00
Joe Farebrother
88c2ccbecf
Generate stubs
2024-02-01 16:59:50 +00:00
Joe Farebrother
5d1edd45c5
Add unit tests
2024-02-01 16:56:20 +00:00
Geoffrey White
5caa49aeab
C++: Remove unused case for now, and add QLDoc.
2024-02-01 15:51:50 +00:00
Tamas Vajk
7b554636ae
C#: Improve messages in buildless extraction logs
2024-02-01 16:45:59 +01:00
Koen Vlaswinkel
8853acb4dd
Ruby: Add query for access paths in model editor
2024-02-01 16:20:00 +01:00
Jeroen Ketema
6db68c067f
C++: Update stats file
2024-02-01 16:12:53 +01:00
Jeroen Ketema
05e78f14a4
C++: Add upgrade and downgrade scripts
2024-02-01 16:12:53 +01:00
Jeroen Ketema
a79754b696
C++: Resolve functions using complete mangled names
2024-02-01 16:12:53 +01:00
Jeroen Ketema
972d86c0a0
C++: Add column to mangled_name table with completeness information
2024-02-01 16:12:53 +01:00
Mathias Vorreiter Pedersen
1ac75def2b
C++: Add another testcase with spurious summary flow.
2024-02-01 15:11:52 +00:00
Joe Farebrother
9098428c2a
Add security severity
2024-02-01 14:28:14 +00:00
Michael Nebel
551a7f9577
C#: Update expected test output.
2024-02-01 15:04:06 +01:00
Michael Nebel
9191acc412
C#: Prevent flow out of non ref fields in ref structs used as arguments.
2024-02-01 15:04:06 +01:00
Michael Nebel
4a89cbe8ea
C#: Add postupdate nodes for arguments of struct type.
2024-02-01 15:04:06 +01:00
Michael Nebel
4dfeff38f9
C#: Add dataflow field test for ref structs with ref and ordinary fields.
2024-02-01 15:04:06 +01:00
Mathias Vorreiter Pedersen
2bea0adb92
C++: Solve non-monotonic issue by unfolding dataflow-related predicates until we get to the SSA implementations of them.
2024-02-01 13:14:02 +00:00
Geoffrey White
cfc1a3db22
C++: Document Node0Impl, remove a debug change.
2024-02-01 13:13:50 +00:00
Michael B. Gale
73d0b7ef49
Merge pull request #15492 from github/mbg/go/include-versions-in-newer-diagnostic
...
Go: Include versions in newer Go version needed diagnostic
2024-02-01 12:22:27 +00:00
Tom Hvitved
8972133d4b
Merge pull request #15498 from hvitved/ruby/ctx-sensitivity-test
...
Ruby: Add another dataflow test
2024-02-01 12:46:53 +01:00
Henti Smith
16e62e6649
Merge pull request #15475 from github/henti/update_dotnet
...
Updated dotnet version to 8.0.101
2024-02-01 11:25:21 +00:00
Max Schaefer
e47b021050
Do not consider expressions as candidates whose type is annotated with @FunctionalInterface.
2024-02-01 11:04:14 +00:00
Tom Hvitved
bfe4a4bf0b
C#: Additional tracking of lambdas through fields and properties
2024-02-01 11:51:00 +01:00
Tom Hvitved
817d04c087
C#: Add more delegate flow tests
2024-02-01 11:51:00 +01:00
Tom Hvitved
5080077038
Merge pull request #15484 from hvitved/csharp/qualified-delegate-extraction-fix
...
C#: Fix extraction of qualified delegate calls
2024-02-01 11:50:09 +01:00
Tom Hvitved
d1ed317832
C#: Add tests for qualified delegate pointer calls
2024-02-01 10:59:05 +01:00
Tom Hvitved
792f302bd4
Ruby: Add another dataflow test
2024-02-01 10:52:06 +01:00
Koen Vlaswinkel
ce4d8d6b51
Merge pull request #15490 from github/koesie10/ruby-model-constructor-on-new
...
Ruby: Model constructors in endpoint query on new instead of initialize
2024-02-01 09:31:49 +01:00
Tamás Vajk
1478709382
Merge pull request #15491 from tamasvajk/feature/node-reuse-autobuild
...
C#: Disable msbuild node reuse in autobuild
2024-02-01 09:26:32 +01:00
Asger F
aa5cccdddd
JS: Make sinkHasPrimaryName public
2024-01-31 20:39:25 +01:00
Michael B. Gale
90eba711a3
Go: Include versions in newer Go version log message
2024-01-31 17:45:58 +00:00
Harry Maclean
06334eee2e
Merge pull request #14554 from maikypedia/maikypedia/insecure-randomness
...
Ruby: Add Insecure Randomness Query
2024-01-31 17:16:32 +00:00
Tamas Vajk
a486481453
Fix integration test result after merge
2024-01-31 16:20:06 +01:00
Tamas Vajk
4608550e48
C#: Disable msbuild node reuse in autobuild
2024-01-31 16:14:40 +01:00
Tamas Vajk
3d25ebc13c
Revert "C#: Add /nodeReuse:false to autobuild build command"
...
This reverts commit bcee901fbd .
2024-01-31 16:12:21 +01:00
Henti Smith
96f366f819
Updated version from PR#15472
2024-01-31 14:07:22 +00:00
Michael B. Gale
84baea5df2
Go: Include versions in newer Go version needed diagnostic
2024-01-31 13:29:53 +00:00
Koen Vlaswinkel
d5f0a5ce72
Use predicate for isConstructor
2024-01-31 14:19:14 +01:00
Tamas Vajk
bcee901fbd
C#: Add /nodeReuse:false to autobuild build command
2024-01-31 14:12:49 +01:00
Koen Vlaswinkel
c1aaf5a574
Ruby: Model constructors in endpoint query on new
2024-01-31 13:54:48 +01:00
Tom Hvitved
e7676a00d2
Merge pull request #15370 from hvitved/ruby/erb-flow
...
Ruby: Model flow through `ViewComponent` render methods
2024-01-31 13:24:10 +01:00
Tom Hvitved
c74bc68287
C#: Fix extraction of qualified delegate calls
2024-01-31 13:21:16 +01:00
Max Schaefer
ab6cea14c8
Fix missing quotes.
2024-01-31 11:49:25 +00:00
Joe Farebrother
9130603334
Address reviews - use SimpleTypeSanitizer and alter qldoc style
2024-01-31 11:31:25 +00:00
Max Schaefer
6c6f402fa5
Merge branch 'main' into java/update-mad-decls-after-triage-2024-01-31T11-16-45
2024-01-31 11:29:33 +00:00
Max Schaefer
ad8038bade
Update MaD Declarations after Triage
2024-01-31 11:28:10 +00:00
Harry Maclean
abf015b142
Merge pull request #15485 from github/koesie10/ruby-model-only-relevant-types
...
Ruby: Only model relevant files for type models
2024-01-31 11:23:40 +00:00
Henti Smith
51f4179b77
Merge branch 'main' into henti/update_dotnet
2024-01-31 11:06:23 +00:00
Koen Vlaswinkel
817fd8c097
Ruby: Move TestFile to modeling Util module
...
The TestFile class in the ModelEditor module is more accurate than the
existing RelevantFile class in the Util module, so this moves the
TestFile class to Util and redefines RelevantFile in terms of the
TestFile.
2024-01-31 11:53:30 +01:00
Koen Vlaswinkel
b51379b533
Ruby: Only model relevant files for type models
2024-01-31 11:30:16 +01:00
Tamás Vajk
73f96fb66e
Merge pull request #15472 from tamasvajk/feature/compiler-args
...
C#: Extract expanded compiler arguments
2024-01-31 11:26:07 +01:00
Tom Hvitved
c21bf5d82c
C#: Add tests for qualified delegate calls
2024-01-31 11:22:35 +01:00
Mathias Vorreiter Pedersen
4b5a203b46
Merge pull request #15463 from microsoft/42-false-positive-cpp-uninitializedlocal
...
False positive fix for cpp/uninitialized-local
2024-01-31 09:31:31 +00:00
Harry Maclean
a298a395e6
Merge pull request #15473 from github/koesie10/ruby-model-only-public-methods
...
Ruby: Only generate models for public methods
2024-01-31 09:27:27 +00:00
Mathias Vorreiter Pedersen
f3eac550c3
Merge pull request #15461 from MathiasVP/propagate-edge-kinds
...
C++: Support function calls throwing exceptions in the IR
2024-01-31 09:25:46 +00:00
Michael Nebel
e575e97eb9
C#: Update cil attribute expected output.
2024-01-31 10:08:55 +01:00
Tamás Vajk
1d56a8a924
Apply suggestions from code review
...
Co-authored-by: Tom Hvitved <hvitved@github.com >
2024-01-31 09:46:57 +01:00
Michael Nebel
9a6751a6dd
C#: Update the RuntimeFrameworkVersion to 8.0.1.
2024-01-31 09:27:37 +01:00
Tamas Vajk
dabe63ce8b
Add change note
2024-01-31 08:44:43 +01:00
Tamas Vajk
1d525dd06c
Add new DB stats file
2024-01-31 08:32:17 +01:00
Tamas Vajk
8008152199
List compiler /analyzer arguments in cs/telemetry/extraction-information
2024-01-31 08:32:16 +01:00
Tamas Vajk
fb4315f1fc
Add DB upgrade/downgrade folders
2024-01-31 08:32:16 +01:00
Tamas Vajk
fddbb1a722
C#: Extract expanded compiler arguments
2024-01-31 08:32:16 +01:00
Tamas Vajk
0196d808c7
Update expected test results in integration tests
2024-01-31 08:30:43 +01:00
James Ockers
0f1e21aa09
Adding per-language change-notes
2024-01-30 17:28:34 -08:00
James Ockers
0ae1268f58
Add change-note
2024-01-30 13:31:35 -08:00
James Ockers
eb5e0123d6
exclude certification from maybeCertificate() regexes
2024-01-30 13:16:18 -08:00
Harry Maclean
4cfdf8b7a3
Ruby: Add test case for view without ERB template
2024-01-30 20:30:59 +01:00
Tom Hvitved
803513acc6
Add change note
2024-01-30 20:30:58 +01:00
Tom Hvitved
d2d017dd64
Ruby: Model flow through ViewComponent render methods
2024-01-30 20:30:58 +01:00
Tom Hvitved
817a2b71a8
Add more tests
2024-01-30 20:30:58 +01:00
Harry Maclean
557b49cfc5
Ruby: Add basic modeling for ViewComponent
2024-01-30 20:30:58 +01:00
Harry Maclean
5b3a2b35b7
Update expected file
2024-01-30 20:30:58 +01:00
Harry Maclean
75a37486c9
Add WIP query for erb flow
2024-01-30 20:30:58 +01:00
Harry Maclean
bf3b86b402
Add test for erb flow
2024-01-30 20:30:58 +01:00
Tom Hvitved
2d95ac9d5f
Merge pull request #15468 from hvitved/ruby/ctx-sensitivity-rework
2024-01-30 20:27:43 +01:00
Arthur Baars
4591560692
Merge pull request #14544 from p-/p--oj-ox-unsafe-deser
...
Ruby: additional unsafe deserialization sinks for ox and one for oj
2024-01-30 19:28:32 +01:00
Geoffrey White
1b433c7af3
C++: Add QLDoc comments.
2024-01-30 17:54:28 +00:00
Ian Lynagh
2eb9b61412
Kotlin: Add a test for path transformers
2024-01-30 17:40:43 +00:00
Geoffrey White
c29d0b78ce
C++: Add top of file doc comment.
2024-01-30 17:29:18 +00:00
Geoffrey White
8b2888c2de
C++: Change note.
2024-01-30 17:24:05 +00:00
Joe Farebrother
8bd79908a6
Implement local auth query
2024-01-30 16:49:55 +00:00
Geoffrey White
4ae8a9a6c4
C++: Add PreprocBlock tests.
2024-01-30 16:47:35 +00:00
Peter Stöckli
fb075a9e88
Rename 2023-10-19-unsafe-deserialization-sinks.md to 2024-01-30-unsafe-deserialization-sinks.md
2024-01-30 17:31:33 +01:00
Henti Smith
612256b760
Updated dotnet to 8.0.101
...
This is a corresponding PR to https://github.com/github/semmle-code/pull/48786
2024-01-30 16:23:07 +00:00
Asger F
19ba9fed99
Handle externs
2024-01-30 17:13:02 +01:00
Asger F
1737ba1a6b
JS: Add library for naming endpoints
2024-01-30 16:36:51 +01:00
Sid Shankar
f557110d9b
Merge pull request #15465 from sidshank/sidshank/rename-file-name-for-extracted-files-diagnostic
...
JS/TS/Python/Ruby: Renames diagnostic query files and tests
2024-01-30 10:19:00 -05:00
Koen Vlaswinkel
0442631c68
Ruby: Only generate models for public methods
2024-01-30 16:07:34 +01:00
Rasmus Wriedt Larsen
c265c15f3f
Merge pull request #15398 from RasmusWL/html-escape
...
Python: Add `html.escape` as HTML sanitizer
2024-01-30 16:06:01 +01:00
Koen Vlaswinkel
8aa3542d13
Merge pull request #15470 from github/koesie10/add-summary-neutral-ruby-supported
...
Ruby: Correctly report supported status of summary and neutral models
2024-01-30 15:46:45 +01:00
Peter Stöckli
1947dee46a
Merge branch 'main' into p--oj-ox-unsafe-deser
2024-01-30 15:33:39 +01:00
Benjamin Rodes
1a044fbbde
Merge branch '42-false-positive-cpp-uninitializedlocal' of https://github.com/microsoft/codeql into 42-false-positive-cpp-uninitializedlocal
2024-01-30 09:22:51 -05:00
Benjamin Rodes
f58f77de82
PR change suggestions.
2024-01-30 09:22:22 -05:00
Peter Stöckli
9596aebee3
Format: getValue now on one line
2024-01-30 15:22:16 +01:00
Ben Rodes
8c04bbfb57
Update cpp/ql/src/change-notes/2024-01-29-uninitialized-local-false-positive.md
...
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com >
2024-01-30 09:19:49 -05:00
Peter Stöckli
3c8bc96ab5
replace occurence of AssignExprCfgNode for Oj as well
2024-01-30 15:17:37 +01:00
Peter Stöckli
e87effc18c
Apply suggestions from code review
...
Co-authored-by: Arthur Baars <aibaars@github.com >
2024-01-30 15:14:35 +01:00
Harry Maclean
e5ba8fe625
Merge pull request #15467 from hmac/hmac-and-barrier
...
Ruby: Block flow from LHS of && expressions
2024-01-30 14:02:39 +00:00
Koen Vlaswinkel
b32071999b
Ruby: Correctly report supported status of summary and neutral models
2024-01-30 15:00:13 +01:00
Tony Torralba
e2bf9ea2eb
Consider File.exists() et al a path-injection sink
2024-01-30 14:51:36 +01:00
Geoffrey White
af17ae236f
C++: Autoformat.
2024-01-30 13:47:11 +00:00
Geoffrey White
310c78d1e7
C++: Add PreprocBlock.qll library.
2024-01-30 13:47:07 +00:00
Asger F
6cfdd7aec4
JS: Add InlineExpectationsTest
2024-01-30 13:20:57 +01:00
Asger F
8930ce74af
JS: Do not view packages as nested in a private package
2024-01-30 13:20:57 +01:00
Asger F
2d8d11fa78
JS: Restrict type-only exports in API graphs
2024-01-30 13:20:57 +01:00
Asger F
0e0fb0e52d
JS: Remove API graph edge causing ambiguity
2024-01-30 13:20:56 +01:00
Asger F
e441dd472b
JS: Expose hasBothNamedAndDefaultExports()
2024-01-30 13:20:55 +01:00
Mathias Vorreiter Pedersen
e2ae4a699c
C++: Add change note.
2024-01-30 11:44:46 +00:00
Mathias Vorreiter Pedersen
33e37536df
C++: Accept test changes.
2024-01-30 11:32:50 +00:00
Mathias Vorreiter Pedersen
1dfd32ee5c
C++: Model function calls throwing exceptions.
2024-01-30 11:32:50 +00:00
Mathias Vorreiter Pedersen
eb94203f04
C++: Add an 'EdgeKind' column to 'getExceptionSuccessorInstruction'.
2024-01-30 11:32:50 +00:00
Mathias Vorreiter Pedersen
8bb17a7127
C++: Add an 'EdgeKind' column to 'getInitializationSuccessor'.
2024-01-30 11:32:50 +00:00
Mathias Vorreiter Pedersen
4fb20e14f5
C++: Add an 'EdgeKind' column to 'getChildTrueSuccessor' and 'getChildFalseSuccessor'.
2024-01-30 11:32:47 +00:00
Mathias Vorreiter Pedersen
10ae793de5
C++: Add an 'EdgeKind' column to 'getFirstInstruction'.
2024-01-30 11:31:41 +00:00
Mathias Vorreiter Pedersen
d2e8b88b24
C++: Add an 'EdgeKind' column to 'getChildSuccessor'.
2024-01-30 11:26:46 +00:00
Rasmus Wriedt Larsen
c70b32f7eb
Python: Require quote escaping for html.escape
2024-01-30 12:17:01 +01:00
Harry Maclean
f230e618a3
Ruby: Update tests
2024-01-30 09:43:56 +00:00
Michael Nebel
41cca4711b
Merge pull request #15426 from michaelnebel/csharp/collectionexpressions
...
C# 12: Support for collection expressions.
2024-01-30 10:39:39 +01:00
Mathias Vorreiter Pedersen
78d5d9a7ab
Merge pull request #15448 from microsoft/false_positive_cpp_incorrect_string_type_conversion
...
cpp/incorrect-string-type-conversion false positive fixes
2024-01-30 09:37:01 +00:00
Mathias Vorreiter Pedersen
56e44f9b3c
Merge pull request #15458 from MathiasVP/dataflow-node-deduplication
...
C++: Fix more `asExpr` duplication
2024-01-30 09:34:57 +00:00
Mathias Vorreiter Pedersen
436a9ce604
Merge pull request #15460 from MathiasVP/fix-scanf-fp-2
...
C++: Fix another FP in `cpp/incorrectly-checked-scanf`
2024-01-30 09:32:32 +00:00
Tom Hvitved
503d2f7b95
Ruby: Rework mayBenefitFromCallContext
2024-01-30 09:57:29 +01:00
Harry Maclean
75b13da4e4
Ruby: Block flow from LHS of && expressions
...
The only values that can flow from the LHS of an && expression are
`false` and `nil`, neither of which seem relevant for any of our
queries.
2024-01-30 08:53:32 +00:00
Joe Farebrother
460ffc89b2
Add additional test cases
2024-01-29 22:43:28 +00:00
Sid Shankar
b1d7a635f5
Renames diagnostic query files and tests
...
This commit renames the files relating to the diagnostic query that produces information on the number of files extracted. The files have been renamed from "SuccessfullExtractedFiles.*" to "ExtractedFiles.*". All related tests and test files have been renamed too.
The `@tags` and `@id` attributes of the queries have been left untouched, consistent with the `@tags` and `@id` for similar queries in other languages.
2024-01-29 20:19:20 +00:00
Benjamin Rodes
13cf555cee
False positive fix for cpp/uninitialized-local
2024-01-29 13:21:05 -05:00
Joe Farebrother
3abd67064d
Add change note
2024-01-29 16:33:07 +00:00
Mathias Vorreiter Pedersen
5024df9c4e
C++: Add change note.
2024-01-29 16:30:55 +00:00
Joe Farebrother
94075ef148
Fix FPs - consider flow through fields when determining whether a view is masked, and find more instances of findViewById.
2024-01-29 16:25:38 +00:00
Joe Farebrother
8d201626e1
Add documentation
2024-01-29 16:25:38 +00:00
Joe Farebrother
aa78050933
Implement checks for elements hidden by their xml attributes
2024-01-29 16:25:38 +00:00
Joe Farebrother
6081f18089
Add unit tests + make some fixes
2024-01-29 16:25:37 +00:00
Joe Farebrother
8582093e65
Implement checks for parent views being hidden
2024-01-29 16:25:37 +00:00
Joe Farebrother
1b13597d72
Implement checks for calls that may safely mask information
2024-01-29 16:25:37 +00:00
Joe Farebrother
5dd0addfc2
Add sensitive text flow query
2024-01-29 16:25:36 +00:00
Mathias Vorreiter Pedersen
ea79a84c2e
C++: Accept test changes.
2024-01-29 16:24:44 +00:00
Mathias Vorreiter Pedersen
ebd1595fbe
C++: Fix FP by concluding that a less-than-zero check also implies a not-equal-to-EOF check.
2024-01-29 16:24:36 +00:00
Mathias Vorreiter Pedersen
7e29141196
C++: Add FP test.
2024-01-29 16:23:37 +00:00
Ben Rodes
308a3b533f
Update cpp/ql/src/change-notes/2024-01-29-false_positive_incorrect_string_type_conversion.md
...
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com >
2024-01-29 09:35:59 -05:00
Mathias Vorreiter Pedersen
aeae208dc3
Merge pull request #15456 from MathiasVP/fix-scanf-fp
...
C++: Fix FP in `cpp/incorrectly-checked-scanf`
2024-01-29 14:30:20 +00:00
Benjamin Rodes
6f17c432d9
Change log
2024-01-29 09:19:39 -05:00
Mathias Vorreiter Pedersen
320092092d
C++: Accept test changes.
2024-01-29 14:11:07 +00:00
Mathias Vorreiter Pedersen
a4727b5597
C++: Fix 'asExpr' duplication.
2024-01-29 14:11:01 +00:00
Mathias Vorreiter Pedersen
044d94c580
C++: Add change note
2024-01-29 13:47:17 +00:00
Michael Nebel
cda09478c5
C# Update expected test output and remove false positive.
2024-01-29 14:37:25 +01:00
Michael Nebel
63c06b72b1
C#: Chop dataflow of spread into smaller steps and make sure to only propagate element flow for the spread operator.
2024-01-29 14:34:57 +01:00
Michael Nebel
b6f94ea44a
C#: Add example test of field flow via the spread operator, which leads to a false positive.
2024-01-29 14:30:52 +01:00
Rasmus Wriedt Larsen
5867fb3d29
Python: Add change-note
2024-01-29 14:30:20 +01:00
Rasmus Wriedt Larsen
3f0dc2b022
Python: Model the psycopg package
2024-01-29 14:30:20 +01:00
Michael Nebel
cd5f678e1c
C#: Add IntegerCollection class to the CollectionFlow tests and update line numbers in expected test output.
2024-01-29 14:28:05 +01:00
yoff
391ca5d8a6
Merge pull request #15390 from Marcono1234/marcono1234/python-ascii-regex-flag
2024-01-29 14:27:50 +01:00
Tamás Vajk
39b32a9068
Merge pull request #15454 from tamasvajk/standalone/cshtml-default
...
C#: Change asp.net core view generation to be opt out
2024-01-29 13:22:44 +01:00
Tamas Vajk
4dffb3bfdd
Change integration test to specify .net 6.0 as target framework
2024-01-29 12:40:51 +01:00
Mathias Vorreiter Pedersen
a5794509ec
C++: Accept test changes.
2024-01-29 11:33:14 +00:00
Mathias Vorreiter Pedersen
41f44f598a
C++: Explicitly check that a check for EOF isn't present.
2024-01-29 11:33:14 +00:00
Tamas Vajk
f16aa034a2
Code quality improvement
2024-01-29 12:29:01 +01:00
Ian Lynagh
79d9109850
Merge pull request #15428 from igfoo/igfoo/catch_illegal_arg
...
Kotlin: Catch/ignore a IllegalArgumentException exception
2024-01-29 11:27:38 +00:00
Ian Lynagh
76e417c23e
Merge pull request #14940 from igfoo/igfoo/comments
...
Kotlin 2: Comment improvements
2024-01-29 11:27:19 +00:00
Mathias Vorreiter Pedersen
3a66fd7175
C++: Add FP test.
2024-01-29 10:59:38 +00:00
Tamas Vajk
7a8d83e859
C#: Add integration test with asp.net core view generation on dotnet 6
...
Source generators are needed for asp.net core view generation. Dotnet 6 is the first version where we support view generation. This commit adds an integration test for this.
2024-01-29 11:52:55 +01:00
Tamas Vajk
92fec66370
C#: Add integration test for disabled asp.net core view generation
2024-01-29 11:52:55 +01:00
Tamas Vajk
d7de5fcfcb
C#: Change asp.net core view generation to be opt out
2024-01-29 10:52:26 +01:00
Tony Torralba
49d6d3fa0c
Merge pull request #15449 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-01-29 10:27:32 +01:00
github-actions[bot]
6d06c9cb7d
Add changed framework coverage reports
2024-01-29 00:16:27 +00:00
Marcono1234
d8fe0f5bb8
Java: Document which assignment type is covered by which class
2024-01-28 19:03:36 +01:00
Maiky
c2c4d9e4d1
` change to <code>
...
Co-authored-by: intrigus-lgtm <60750685+intrigus-lgtm@users.noreply.github.com >
2024-01-27 14:08:55 +01:00
Mathias Vorreiter Pedersen
a391f7802d
C++: Add a test.
2024-01-27 13:08:52 +00:00
maikypedia
d7314a1689
File format
2024-01-27 14:07:36 +01:00
Marcono1234
1ad08efe08
Python: Support a (ASCII) inline regex flag
2024-01-26 22:18:49 +01:00
Ben Rodes
f79846467e
Update cpp/ql/src/Security/CWE/CWE-704/WcharCharConversion.ql
...
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com >
2024-01-26 15:25:08 -05:00
Benjamin Rodes
b7648bcf27
Adding test cases.
2024-01-26 15:19:07 -05:00
Benjamin Rodes
562221f48e
False positive fix.
2024-01-26 13:27:14 -05:00
Geoffrey White
d19ad49313
Merge pull request #15381 from geoffw0/cppfiles
...
C++: Report any extracted file as successfully extracted
2024-01-26 18:18:27 +00:00
Edward Minnix III
4602f8933d
Merge pull request #15292 from egregius313/egregius313/java/dataflow/common-sanitizers/uuid-and-date
...
Java: Add `java.util.UUID` and `java.util.Date` to the `SimpleTypeSanitizer` class
2024-01-26 13:16:18 -05:00
Geoffrey White
b125d2c9ab
Merge branch 'main' into cppfiles
2024-01-26 16:47:48 +00:00
Joe Farebrother
031bd8bd0c
Merge pull request #15281 from joefarebrother/android-sensitive-ui-notif
...
Java: Add query for exposure of sensitive information to android notifiactions
2024-01-26 16:42:55 +00:00
Max Schaefer
73130ec665
Merge pull request #15436 from github/max-schaefer-patch-1
...
Java: Add models for overloads of DatagramPacket constructor
2024-01-26 16:13:11 +00:00
Henry Mercer
452359f20e
Merge pull request #15446 from github/codeql-cli-2.16.1
...
Merge `codeql-cli-2.16.1` back to `main`
2024-01-26 15:52:56 +00:00
Henry Mercer
720d87391d
Merge pull request #15447 from github/henrymercer/2.16.0-mergeback
...
Merge `codeql-cli-2.16.0` back into `codeql-cli-2.16.1`
2024-01-26 15:42:05 +00:00
Tony Torralba
6e550d28af
Update more test expectations
2024-01-26 15:13:07 +01:00
Henry Mercer
6bef1404fd
Merge remote-tracking branch 'origin/codeql-cli-2.16.1' into henrymercer/2.16.0-mergeback
2024-01-26 13:53:13 +00:00
Florin Coada
b24dad6ac3
Merge pull request #15438 from github/changedocs/2.16.1
...
Generate changelog for 2.16.1
2024-01-26 13:46:14 +00:00
Michael Nebel
da4a9b620a
C#: Add change note.
2024-01-26 14:24:27 +01:00
Michael Nebel
13b8d57bff
C#: Add collection flow test cases for collection expressions.
2024-01-26 14:18:16 +01:00
Michael Nebel
168f5b5554
C#: Add dataflow support for collection expressions.
2024-01-26 14:18:16 +01:00
Michael Nebel
8eb89cf0bb
C#: Add test and expected output.
2024-01-26 14:18:16 +01:00
Tony Torralba
b8cb514dc4
Rename the other change note
2024-01-26 12:46:51 +01:00
Tony Torralba
19a6b7858b
Remove reference to PathCreation
...
ZipSlip no longer needs to make this exclusion, since PathCreation arguments are no longer path-injection sinks
2024-01-26 12:45:00 +01:00
Tony Torralba
2a146405ac
Adjust tests
2024-01-26 12:38:32 +01:00
Tamás Vajk
7a50d7a95f
Merge pull request #15437 from tamasvajk/feature/log-verbosity
...
C#: Introduce log verbosity extractor option
2024-01-26 12:33:06 +01:00
Tony Torralba
1d2a51c522
Rename change note
2024-01-26 12:20:47 +01:00
Tony Torralba
19cb7adb6d
Migrate path injection sinks to MaD
...
Deprecate and stop using PathCreation
Path creation sinks are now summaries
2024-01-26 12:19:54 +01:00
Michael Nebel
74cb1ea584
C#: Add QL library expression support for collection expressions.
2024-01-26 11:50:20 +01:00
Asger F
ee8e9a4e66
Shared: update test output
2024-01-26 11:14:23 +01:00
Asger F
f15ead6130
Shared: check stateful outBarrier as part of pathStep SCC
2024-01-26 11:14:23 +01:00
Asger F
d1310c74fc
Shared: remove old stateful outBarrier check
2024-01-26 11:14:23 +01:00
Asger F
ddbacc3d4a
Shared: add test case for stateful outBarrier bug
2024-01-26 11:14:11 +01:00
Tony Torralba
52d7bd93a5
Merge pull request #15420 from github/java/update-mad-decls-after-triage-2024-01-24T10-05-04
...
Java: Update MaD Declarations after Triage
2024-01-26 08:42:49 +01:00
Erik Krogh Kristensen
8e11c75745
Merge pull request #15441 from github/dependabot/cargo/ql/chrono-0.4.33
...
Bump chrono from 0.4.32 to 0.4.33 in /ql
2024-01-26 08:10:37 +01:00
dependabot[bot]
5fac945b33
Bump chrono from 0.4.32 to 0.4.33 in /ql
...
Bumps [chrono](https://github.com/chronotope/chrono ) from 0.4.32 to 0.4.33.
- [Release notes](https://github.com/chronotope/chrono/releases )
- [Changelog](https://github.com/chronotope/chrono/blob/main/CHANGELOG.md )
- [Commits](https://github.com/chronotope/chrono/compare/v0.4.32...v0.4.33 )
---
updated-dependencies:
- dependency-name: chrono
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-01-26 03:25:31 +00:00
Michael Nebel
1252d3ee89
C#: Rename CollectionExpr to EnumerableCollectionExpr.
2024-01-25 19:53:51 +01:00
Michael Nebel
5ab64f4a65
C#: Introduce extractor support for collection expressions.
2024-01-25 19:53:51 +01:00
Michael Nebel
0477bba34e
C#: Add database upgrade- and downgrade scripts.
2024-01-25 19:53:51 +01:00
Michael Nebel
e2614a1e4c
C#: Add some dummy db stats for the new expression kinds.
2024-01-25 19:45:56 +01:00
Michael Nebel
1ef8daf7cd
C#: Add some more collection and spread element expression kinds to the dbscheme.
2024-01-25 19:45:56 +01:00
Mathias Vorreiter Pedersen
863e6c8009
Merge pull request #15427 from MathiasVP/asexpr-and-asindirectexpr-tests
...
C++: Add `asExpr` and `asIndirectExpr` library tests (and fix more duplication)
2024-01-25 16:58:18 +00:00
Tony Torralba
d299971086
Fix code review mistake
2024-01-25 17:42:11 +01:00
Tamas Vajk
c4849f9a17
Add change note
2024-01-25 17:33:06 +01:00
Mathias Vorreiter Pedersen
2db76c7fad
Merge pull request #15434 from MathiasVP/fix-dataflow-join-order
...
DataFlow: Fix join order
2024-01-25 16:32:14 +00:00
Tamas Vajk
b8c8f52efc
C#: Introduce extractor option for logging verbosity
2024-01-25 17:20:47 +01:00
Tony Torralba
661c5cf6aa
Merge pull request #15409 from erik-krogh/path-java
...
Java: Improve the QHelp for `java/path-injection`.
2024-01-25 17:14:59 +01:00
Ian Lynagh
c0a9c11101
Kotlin: Catch/ignore a IllegalArgumentException exception
...
This works around
https://youtrack.jetbrains.com/issue/KT-63847/K2-IllegalStateException-IrFieldPublicSymbolImpl-for-java.time-Clock.OffsetClock.offset0-is-already-bound
2024-01-25 16:04:08 +00:00
Florin Coada
d884941b8a
restored settings file
2024-01-25 15:57:48 +00:00
Florin Coada
c3238743b1
Changedocs for 2.16.1
2024-01-25 15:55:32 +00:00
Tamas Vajk
bb4327294d
Rename verbosity property to legacy
2024-01-25 16:03:23 +01:00
Tamas Vajk
0e5e57dc56
Adjust 'silent' flag parsing
2024-01-25 16:00:44 +01:00
Max Schaefer
13f0df3588
Add two more models.
2024-01-25 15:00:22 +00:00
Paolo Tranquilli
b2489f7109
Merge pull request #15433 from github/redsun82/clang-format
...
Swift: update formatting to `clang-format` 17.0.6
2024-01-25 15:58:28 +01:00
Max Schaefer
5235291919
Add models for overloads of DatagramPacket constructor
2024-01-25 14:49:05 +00:00
Tamas Vajk
9b4cdd0d4f
Separate logging classes into separate files
2024-01-25 15:38:16 +01:00
Tamas Vajk
2c72d7ea1e
C#: Improve code quality
2024-01-25 15:18:55 +01:00
Henry Mercer
10343dd822
Merge pull request #15416 from github/post-release-prep/codeql-cli-2.16.1
...
Post-release preparation for codeql-cli-2.16.1
2024-01-25 14:15:25 +00:00
Tony Torralba
282632c33b
Add new snippets as tests
2024-01-25 15:11:11 +01:00
Erik Krogh Kristensen
fb11e4e14f
Merge pull request #15435 from erik-krogh/remove-at-to-z
...
remove an FP in overly-large-range for [@-Z]
2024-01-25 14:43:12 +01:00
erik-krogh
396da117bb
remove an FP in overly-large-range for [@-Z]
2024-01-25 14:15:06 +01:00
Tamás Vajk
2333b8db5b
Merge pull request #15432 from tamasvajk/fix/extraction-information
...
C#: Filter results of division by 0 from `cs/telemetry/extraction-information`
2024-01-25 14:07:19 +01:00
Stephan Brandauer
1f9a968774
Java: PR discussion
2024-01-25 13:59:47 +01:00
Paolo Tranquilli
33b6ce7365
Swift: update formatting to clang-format 17.0.6
...
Also, added a format check in `swift.yml`.
2024-01-25 13:58:14 +01:00
Mathias Vorreiter Pedersen
db929ccf9b
DataFlow: Fix join order.
2024-01-25 12:51:35 +00:00
erik-krogh
73e3fada44
add missing </p>
2024-01-25 12:14:10 +01:00
Tamas Vajk
055ead20e3
C#: Filter results of division by 0 from cs/telemetry/extraction-information
2024-01-25 12:08:15 +01:00
GitHub Security Lab
df10a7e7f0
Merge branch 'main' into amammad-js-bombs
2024-01-25 11:23:38 +01:00
erik-krogh
05a59d2a94
apply suggestions from doc review
2024-01-25 11:20:46 +01:00
Tamás Vajk
01b89508a8
Merge pull request #15424 from tamasvajk/standalone/logging
...
C#: Improve log messages in buildless mode + some cleanup/refactoring
2024-01-25 11:08:50 +01:00
GitHub Security Lab
00d1f8e84a
Merge branch 'main' into maikypedia/swift-zip
2024-01-25 11:05:46 +01:00
yoff
930f1b50b9
Merge pull request #15397 from github/tausbn/python-fix-deepcopy-mutable-default-fp
...
Python: Fix `deepcopy` mutable default FP
2024-01-25 10:32:58 +01:00
Stephan Brandauer
5d6ee9c0cb
Update java/ql/lib/ext/com.fasterxml.jackson.databind.model.yml
...
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2024-01-25 10:00:56 +01:00
Robert Marsh
67a86391a2
Merge pull request #15318 from rdmarsh2/rdmarsh2/cpp/first-class-destructors
...
C++: First-class destructors in AST
2024-01-24 16:19:10 -05:00
Robert Marsh
0bc023139b
C++: autoformat for first-class destructors
2024-01-24 18:52:54 +00:00
Robert Marsh
56c9566867
C++: more documentation for implict destructor calls
2024-01-24 18:52:54 +00:00
Robert Marsh
3970a9fe39
C++: switch to getImplicitDestructorCall
2024-01-24 18:52:54 +00:00
Robert Marsh
3a0290b1e8
C++: add destructors in PrintAST
2024-01-24 18:52:54 +00:00
Robert Marsh
1acc111b63
C++: add getSyntheticDestructor to Expr and Stmt
2024-01-24 18:52:54 +00:00
Chris Smowton
32a2ea1690
Merge pull request #15413 from smowton/smowton/admin/buildless-sibling-project-tests
...
Add tests for Java buildless w/sibling projects
2024-01-24 18:51:10 +00:00
Geoffrey White
e0d70e3008
C++: Resolve the TODO / unwanted change in shared code and get more results.
2024-01-24 18:09:34 +00:00
Chris Smowton
ed9abdd9bd
Mock Java 8 toolchain so sibling test works on arm runners
2024-01-24 16:51:38 +00:00
Chris Smowton
287fb8003d
Make all toolchains available to test
2024-01-24 16:51:38 +00:00
Chris Smowton
16d30d7335
Remove xml and properties tests
2024-01-24 16:51:38 +00:00
Chris Smowton
042a3b64bb
Use Java 11 to run old Gradle
2024-01-24 16:51:38 +00:00
Chris Smowton
b5429f1a50
Add test for buildless with sibling projects
2024-01-24 16:51:38 +00:00
Chris Smowton
e3ef8aa6f6
Adjust test expectations
2024-01-24 16:51:37 +00:00
Chris Smowton
96bf47fbd9
Remove accidentally-committed actual files
2024-01-24 16:51:37 +00:00
Tony Torralba
cbcc090a19
Merge pull request #15423 from atorralba/atorralba/go/awslambda-global-context
...
Go: Add AwsLambda to the global context
2024-01-24 17:40:00 +01:00
Mathias Vorreiter Pedersen
7916616ee1
C++: Fix duplication for indirect exprs similar to how we fixed it in #15410 .
2024-01-24 16:20:06 +00:00
Mathias Vorreiter Pedersen
4e18cca0f4
C++: Add a way to test the behavior of 'asExpr' and 'toString' on dataflow nodes.
2024-01-24 16:12:47 +00:00
Geoffrey White
a727255a82
C++: Add a couple more test cases and correct test models again.
2024-01-24 15:18:49 +00:00
Tamas Vajk
199b0578be
C#: Log number of restored dotnet framework variants
2024-01-24 15:23:38 +01:00
Stephan Brandauer
4e63cbc993
Merge branch 'main' into java/update-mad-decls-after-triage-2024-01-24T10-05-04
2024-01-24 14:55:20 +01:00
Tamas Vajk
30095e3179
Refactor dotnet restore calls
2024-01-24 13:56:40 +01:00
Ian Lynagh
67242278ee
Merge pull request #15384 from igfoo/igfoo/kt2
...
Kotlin: Support Kotlin 2.0.0-Beta3
2024-01-24 12:47:35 +00:00
Taus
96b1b8e402
Python: Remove empty lines from test file
2024-01-24 12:31:23 +00:00
Tamas Vajk
d742cd3e44
C#: Remove progress monitor from dependency fetcher, use logger directly
2024-01-24 12:29:02 +01:00
Tamas Vajk
13a8168c8e
C#: Improve log messages in standalone extractor
2024-01-24 12:28:00 +01:00
Tony Torralba
3b7d6a4806
Go: Add AwsLambda to the global context
2024-01-24 11:33:26 +01:00
Stephan Brandauer
d5bcbcddab
Update MaD Declarations after Triage
2024-01-24 11:05:07 +01:00
Michael B. Gale
514430e8b9
Merge pull request #15411 from github/mbg/go/refactor-go-autobuilder
2024-01-24 09:15:04 +00:00
Henry Mercer
3af42d57a0
Merge pull request #15402 from github/henrymercer/csharp-build-mode
...
C#: Enable standalone extraction via `--build-mode`
2024-01-24 09:01:03 +00:00
Tony Torralba
0bb0e52adb
Merge pull request #15418 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-01-24 09:23:55 +01:00
Michael Nebel
2be1ee8b34
Merge pull request #15394 from michaelnebel/csharp/urlredirect-sanitizer
...
C#: Add more santizers to the `cs/web/unvalidated-url-redirection` query.
2024-01-24 08:42:05 +01:00
Ed Minnix
ef884fa721
Change note
2024-01-23 22:35:05 -05:00
github-actions[bot]
465e8d3530
Add changed framework coverage reports
2024-01-24 00:17:20 +00:00
github-actions[bot]
d0b74c00fe
Post-release preparation for codeql-cli-2.16.1
2024-01-23 23:02:29 +00:00
Henry Mercer
0928c93989
Use TryGetValue
2024-01-23 20:43:19 +00:00
Henry Mercer
e73c1b7281
Be forgiving with casing of build mode environment variable
2024-01-23 20:35:43 +00:00
Henry Mercer
a75c8273f9
C#: Allow checking environment variables that may be undefined
...
The build mode environment variable for instance is only set when a build mode is specified.
2024-01-23 20:33:16 +00:00
Henry Mercer
766e0e61ed
Merge pull request #15414 from github/release-prep/2.16.1
...
Release preparation for version 2.16.1
2024-01-23 19:57:39 +00:00
github-actions[bot]
7ef611e6dc
Release preparation for version 2.16.1
2024-01-23 19:45:16 +00:00
Ed Minnix
dca24ded18
Add UUID and Date to the list of types in the SimpleTypeSanitizer class
2024-01-23 13:36:03 -05:00
Edward Minnix III
3c8b09307d
Merge pull request #15291 from egregius313/egregius313/java/dataflow/default-sanitizers
...
Java: Introduce a common sanitizer type for types which cannot realistically carry taint.
2024-01-23 13:28:03 -05:00
Mathias Vorreiter Pedersen
145b5a30bd
Merge pull request #15343 from microsoft/38-cpp-generalize-use-after-free-libraries
...
Generalization of FlowAfterFree
2024-01-23 16:49:29 +00:00
Ben Rodes
55fe8d376c
Update cpp/ql/lib/semmle/code/cpp/security/flowafterfree/UseAfterFree.qll
2024-01-23 10:49:47 -05:00
Benjamin Rodes
dfb3aec002
Removing unnecessary private modules and adding comments.
2024-01-23 10:47:38 -05:00
Mathias Vorreiter Pedersen
42fd3fc836
C++: Make more things 'private' and add QLDoc to public things. ( #40 )
2024-01-23 10:27:01 -05:00
Geoffrey White
c10f41b168
C++: Use getClassAndName.
2024-01-23 15:02:59 +00:00
Geoffrey White
4c1f433073
C++: Move getIndirectionIndex to ReturnKind.
2024-01-23 14:52:44 +00:00
Mathias Vorreiter Pedersen
b1b236d82d
Merge pull request #15410 from MathiasVP/less-dataflow-duplication
...
C++: Remove more `asExpr` duplication
2024-01-23 14:50:01 +00:00
Michael Nebel
10be0deeb5
C#: Add a couple more testcases.
2024-01-23 15:09:10 +01:00
Edward Minnix III
0e866a5447
Merge pull request #15359 from egregius313/egregius313/csharp/dataflow/threat-modeling/add-threatmodelflowsource
...
C#: Threat Modeling - Introduce `ThreatModelFlowSource`
2024-01-23 09:02:10 -05:00
Michael B. Gale
cf1aab0157
Go: Move identify environment code to separate file
2024-01-23 13:59:34 +00:00
Michael B. Gale
ee36e7424a
Go: Move project analysis code to separate file
2024-01-23 13:59:33 +00:00
Michael B. Gale
0dc3c847bc
Go: Move go invocations to separate file
2024-01-23 13:59:33 +00:00
erik-krogh
158ff0da0a
add a trailing slash to the folder check in the QHelp for java/path-injection
2024-01-23 14:46:02 +01:00
Tamás Vajk
df8d453058
Merge pull request #15395 from tamasvajk/feature/standalone-nuget-restore-retry
...
C#: Try fallback `dotnet restore` without nuget.config
2024-01-23 14:45:00 +01:00
Erik Krogh Kristensen
f1d6f56621
Merge pull request #15393 from erik-krogh/deps-jan-2024
...
All: delete outdated deprecations
2024-01-23 13:52:38 +01:00
Mathias Vorreiter Pedersen
8b172c133d
C++: Accept test changes.
2024-01-23 12:06:42 +00:00
Mathias Vorreiter Pedersen
5bc602a208
C++: Ensure that we don't create a result for 'asExpr' on an instruction node if a result also exists for an operand node (and vice versa).
2024-01-23 12:06:35 +00:00
erik-krogh
00dadeb3bf
delete the markdown file again
2024-01-23 12:57:15 +01:00
erik-krogh
57e0b3cceb
iterate on the java/path-injection qhelp
2024-01-23 12:56:43 +01:00
erik-krogh
4958c19c67
move the examples for the qhelps into an example/ folder
2024-01-23 12:56:23 +01:00
erik-krogh
6b66f5cbc5
check in the TaintedPath qhelp as markdown to get pretty diffs
2024-01-23 12:56:22 +01:00
Chris Smowton
43453fea52
Merge pull request #15408 from smowton/smowton/admin/log-setup-go-message
...
Log advice when a newer Go version is required under Actions
2024-01-23 11:32:38 +00:00
Mathias Vorreiter Pedersen
d29d060706
Merge pull request #15401 from alexet/make-intended-join-order
...
CPP: Fix join ordering hints to make them do what they intend.
2024-01-23 11:30:20 +00:00
Chris Smowton
7e96eaa273
Log advice when a newer Go version is required under Actions
2024-01-23 10:49:52 +00:00
Tony Torralba
77e724b3ba
Merge pull request #15188 from github/java/update-mad-decls-after-triage-2023-12-21T14-39-02
...
Java: Update MaD Declarations after Triage
2024-01-23 11:34:57 +01:00
Tony Torralba
fcd9a5ed71
Update java/ql/lib/change-notes/2023-12-21-new-models.md
2024-01-23 11:18:12 +01:00
Joe Farebrother
dedba1fc54
Address review comments - add barrierIn and fix a model for a PendingIntent sink
2024-01-23 09:51:42 +00:00
Joe Farebrother
0acb647e7d
Fix tests and add notification sink kind to model verification
2024-01-23 09:51:41 +00:00
Joe Farebrother
b23bbf93d4
Reorder sink models
2024-01-23 09:51:41 +00:00
Joe Farebrother
69faafa194
Add change note
2024-01-23 09:51:40 +00:00
Joe Farebrother
1190352b67
Add qhelp
2024-01-23 09:51:40 +00:00
Joe Farebrother
d806fcae3d
Remove sink models involving PendingIntent; as they do not carry sensitive data (including from the original intent they were created with)
2024-01-23 09:51:39 +00:00
Joe Farebrother
2ca164ce35
Generate androidx stubs and correct some models
2024-01-23 09:51:39 +00:00
Joe Farebrother
bafd65b1d2
Add tests to cover each modeled sink + some corrections to the models
2024-01-23 09:51:38 +00:00
Joe Farebrother
a1a2acd3ce
Add additional test cases
2024-01-23 09:51:38 +00:00
Joe Farebrother
f9bb004618
Add sink models to notification builder setters
2024-01-23 09:51:38 +00:00
Joe Farebrother
cd19a91704
Add unit test
2024-01-23 09:51:37 +00:00
Joe Farebrother
3aa27148de
Split existing tests under CWE-200 into separate folders
2024-01-23 09:51:37 +00:00
Joe Farebrother
143ce0b94a
Add sensitive notification query
2024-01-23 09:51:37 +00:00
Stephan Brandauer
95b439bf31
Merge branch 'main' into java/update-mad-decls-after-triage-2023-12-21T14-39-02
2024-01-23 09:40:50 +01:00
Stephan Brandauer
cd765e7c19
work on review comments
...
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2024-01-23 09:35:36 +01:00
Stephan Brandauer
8b34407ab7
Java: java.awt.Desktop::browse is a url-redirection sink
...
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2024-01-23 09:28:13 +01:00
Michael Nebel
95a200453b
Merge pull request #15404 from michaelnebel/csharp/inlinearraydummystats
...
C#: Add dummy stats for inline_array_type.
2024-01-23 09:17:18 +01:00
Michael Nebel
123e86e0e0
C#: Add dummy stats for inline_array_type.
2024-01-23 08:29:01 +01:00
Erik Krogh Kristensen
97071b0dc7
Merge pull request #15403 from github/dependabot/cargo/ql/chrono-0.4.32
...
Bump chrono from 0.4.31 to 0.4.32 in /ql
2024-01-23 08:20:28 +01:00
Ed Minnix
fcbee1994b
Update change note
2024-01-22 23:57:31 -05:00
Ed Minnix
fb80c5ea84
Rename SimpleScalarSanitizer to SimpleTypeSanitizer
2024-01-22 23:55:29 -05:00
Ed Minnix
696788e5b2
Rename semmle.code.java.security.dataflow.CommonSanitizers to semmle.code.java.security.Sanitizers
2024-01-22 23:52:19 -05:00
Ed Minnix
bb44277090
Make import of dataflow private
2024-01-22 23:40:24 -05:00
Ed Minnix
ec3d683186
Change change note category to feature
2024-01-22 23:39:23 -05:00
Ed Minnix
38828672a9
Update change note
2024-01-22 23:38:33 -05:00
Ed Minnix
32fe8e02fb
Change note
2024-01-22 23:38:31 -05:00
Ed Minnix
3311b3be8e
Convert experimental queries' isBarrier to use instanceof SimpleScalarSanitizer
2024-01-22 23:38:29 -05:00
Ed Minnix
67dfca2e58
Convert libraries to use instanceof SimpleScalarSanitizer
2024-01-22 23:38:26 -05:00
Ed Minnix
7f7c49d6ce
Add the SimpleScalarSanitizer class
...
The `SimpleScalarSanitizer` class represents common scalar types which
cannot realistically carry taint (e.g. primitives/numbers, and
eventually UUIDs and Dates)
2024-01-22 23:38:24 -05:00
dependabot[bot]
e9a1fa9592
Bump chrono from 0.4.31 to 0.4.32 in /ql
...
Bumps [chrono](https://github.com/chronotope/chrono ) from 0.4.31 to 0.4.32.
- [Release notes](https://github.com/chronotope/chrono/releases )
- [Changelog](https://github.com/chronotope/chrono/blob/main/CHANGELOG.md )
- [Commits](https://github.com/chronotope/chrono/compare/v0.4.31...v0.4.32 )
---
updated-dependencies:
- dependency-name: chrono
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-01-23 03:12:14 +00:00
Taus
24b37ffd36
Merge pull request #15187 from github/max-schaefer/py-url-redirection
...
Python: Add support for more URL redirect sanitisers.
2024-01-22 23:19:36 +01:00
Henry Mercer
6724dea54d
C#: Enable standalone extraction via --build-mode
2024-01-22 19:12:07 +00:00
Alex Eyers-Taylor
891d398c3f
CPP: Fix join ordering hints
2024-01-22 19:00:18 +00:00
erik-krogh
865df920f9
add change-notes
2024-01-22 19:30:57 +01:00
Ed Minnix
a6c977c169
Use appropriate pack for test models
2024-01-22 12:24:21 -05:00
Max Schaefer
5c43a0b1e4
Merge pull request #15356 from github/max-schaefer/automodel-void-source-candidates
...
Automodel: Switch tests to inline expectations
2024-01-22 17:05:10 +00:00
Rasmus Wriedt Larsen
00dc55d825
Python: Add change-note
2024-01-22 17:32:33 +01:00
Rasmus Wriedt Larsen
cbed6e861d
Python: Add html.escape as HTML sanitizer
2024-01-22 17:32:28 +01:00
Benjamin Rodes
da10e6ca5b
Moving FlowAfterFree and UseAfterFree.qll as a general purpose lib.
2024-01-22 11:18:03 -05:00
Ed Minnix
ff6d4c6ae6
Deprecation message
2024-01-22 11:09:53 -05:00
Ed Minnix
0ff12c07c7
Convert existing mapped-property classes to directly extend DatabaseInputSource
2024-01-22 11:09:51 -05:00
Ed Minnix
975327648c
Remove commented-out code
2024-01-22 11:09:50 -05:00
Ed Minnix
51564200a1
Documentation for FlowSources library
2024-01-22 11:09:48 -05:00
Ed Minnix
83e66136ce
Change note
2024-01-22 11:09:46 -05:00
Ed Minnix
c530fbd9f8
C# Threat Modeling Tests
2024-01-22 11:09:45 -05:00
Ed Minnix
3c9c07ec40
Rename SourceNode.qll to FlowSources.qll
2024-01-22 11:09:43 -05:00
Ed Minnix
392eac5f9a
Refactor source node classes to use SourceNode superclass
...
Refactor the existing flowsource classes to use the `SourceNode` class
to specify which threat model they support.
2024-01-22 11:09:41 -05:00
Ed Minnix
d29df68c97
Introduce the SourceNode and ThreatModelFlowSource classes
...
1. Introduces the `SourceNode` class which allows dataflow nodes
representing sources to indicate the threat model they are associated
with.
2. Introduces the `ThreatModelFlowSource` class which represents a
source node which respects the threat model configuration
2024-01-22 11:09:39 -05:00
Ed Minnix
ad093fde4f
Add dependency on codeql/threat-models shared library
2024-01-22 11:09:38 -05:00
Taus
d6d59377d3
Python: Fix flow through deepcopy
...
Or, more generally, any copy step, as these presumably do not preserve
object identity.
(Arguably, `copy` could still be susceptible to interior mutability, but
I think that's outside the scope of this query anyway.)
2024-01-22 15:40:30 +00:00
Benjamin Rodes
2181fcf284
Updating .expected to account for new free/deallocation sources.
2024-01-22 10:36:24 -05:00
Taus
14c958ac4d
Python: Remove mutable default sources from inside stdlib
2024-01-22 15:23:52 +00:00
Taus
411c107660
Python: Add tests for deepcopy FPs
...
There are two issues with `deepcopy` here. Firstly, the `deepcopy` function itself
has a mutable default value in its parameter `_nil` (set to the empty list by default).
Now, this value is never actually returned from `deepcopy`, as it is only used as a
sentinel, but our analysis is not clever enough to see this. Thus, it thinks that this
mutable default is returned, and hence the result of any call to `deepcopy` is a
potential source.
To remedy this, I opted to simply exclude all sources that originate from within the
standard library. It is very unlikely for any of the sources in the standard library
to be legit.
Secondly, `deepcopy` -- by virtue of being a function that we model as preserving
values -- admits data-flow through its calls, but this is not correct for the mutable
default query, as it is here the _identity_ of the default value in question that is
important. Thus, we get spurious flow through `deepcopy` for this specific query.
2024-01-22 15:21:57 +00:00
Tamas Vajk
de4e3963e7
C#: Try fallback nuget restore without nuget.config
2024-01-22 15:42:06 +01:00
Tamas Vajk
7c290ee2ba
C#: Add integration test with nuget.config
2024-01-22 15:36:38 +01:00
Geoffrey White
0a8869c636
Merge pull request #15385 from geoffw0/swiftfiles
...
Swift: Report any extracted file as successfully extracted
2024-01-22 14:24:05 +00:00
Taus
4742481070
Python: Consolidate "mutable default" tests
...
Moves the existing tests into the `ModificationOfParameterWithDefault` subdirectory
which already contained a bunch more tests. In the process, I also removed some
duplicated test cases.
2024-01-22 13:50:33 +00:00
Max Schaefer
a4639c7ff9
Update qhelp to mention solution using urlparse.
2024-01-22 13:36:12 +00:00
Max Schaefer
17e3a45ad7
Apply suggestions from code review
...
Co-authored-by: Taus <tausbn@github.com >
2024-01-22 13:36:12 +00:00
Max Schaefer
98178458d0
Python: Add support for more URL redirect sanitisers.
...
Since some sanitisers don't handle backslashes correctly, I updated the data-flow configuration to incorporate a flow state tracking whether or not backslashes have been eliminated or converted to forward slashes.
2024-01-22 13:24:18 +00:00
Max Schaefer
99c99145a2
Rename {source,sink}Model to {source,sink}ModelCandidate.
2024-01-22 13:10:51 +00:00
Michael Nebel
1bb6f4962d
C#: Match any {digit} in the format string.
2024-01-22 14:03:37 +01:00
Geoffrey White
58c4bf5915
Merge branch 'main' into cppfiles
2024-01-22 12:24:33 +00:00
Max Schaefer
a3816d75b3
Remove redundant imports.
2024-01-22 10:54:01 +00:00
Max Schaefer
78e5a1a546
Autoformat.
2024-01-22 10:45:33 +00:00
Michael Nebel
b006b28e8a
C#: Add change note.
2024-01-22 11:28:27 +01:00
Michael Nebel
5016113a0f
C#: Add a string.Format sanitizer to url redirect and update expected test output.
2024-01-22 11:21:35 +01:00
Michael Nebel
884f3f1505
C#: Add string interpolation expression sanitizer to url redirect and update expected test output.
2024-01-22 11:21:19 +01:00
Michael Nebel
e33d5b5fb6
C#: Add some test examples for UrlRedirect using string interpolation and string.Format.
2024-01-22 09:42:23 +01:00
erik-krogh
f60c01e3a8
Py: delete import that no longer exists
2024-01-22 09:22:50 +01:00
erik-krogh
0511786a22
delete typo files from list of synchronized files
2024-01-22 09:15:27 +01:00
erik-krogh
8be7eadace
delete outdated deprecations
2024-01-22 09:11:35 +01:00
Erik Krogh Kristensen
6533269387
Merge pull request #15392 from github/dependabot/cargo/ql/regex-1.10.3
...
Bump regex from 1.10.2 to 1.10.3 in /ql
2024-01-22 08:29:35 +01:00
dependabot[bot]
eb1a0fece8
Bump regex from 1.10.2 to 1.10.3 in /ql
...
Bumps [regex](https://github.com/rust-lang/regex ) from 1.10.2 to 1.10.3.
- [Release notes](https://github.com/rust-lang/regex/releases )
- [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/regex/compare/1.10.2...1.10.3 )
---
updated-dependencies:
- dependency-name: regex
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-01-22 03:54:51 +00:00
Geoffrey White
a39bb8c037
Swift: Rename the query file.
2024-01-19 17:58:58 +00:00
Geoffrey White
c515ea3f8a
Swift: Change note.
2024-01-19 17:58:58 +00:00
Geoffrey White
ed602642b6
Swift: Basic test for getRelativePath.
2024-01-19 17:58:58 +00:00
Geoffrey White
8cf691a477
Swift: Add File.getRelativePath and update swift/diagnostics/successfully-extracted-files.
2024-01-19 17:58:58 +00:00
Ian Lynagh
60a59cb89e
Kotlin: Update 2.0.0 version support
2024-01-19 17:52:38 +00:00
Geoffrey White
5127542677
C++: Rename the query file.
2024-01-19 16:31:34 +00:00
Geoffrey White
01ee61e5ea
C++: Change note.
2024-01-19 15:56:54 +00:00
Geoffrey White
4691bf2cb5
C++: Be more optimistic about successfully scanned files.
2024-01-19 15:55:54 +00:00
Geoffrey White
2eba3db1cb
C++: Add a test for SuccessfullyExtractedFiles.ql and friends.
2024-01-19 15:50:28 +00:00
Ian Lynagh
d40814d48a
Kotlin: Add 2.0.0 beta 3 and remove beta 1
2024-01-19 13:36:55 +00:00
Chris Smowton
7e1dd38623
Merge pull request #15378 from github/smowton/admin/document-aws-lambda
...
Note AWS Lambda support
2024-01-19 12:11:28 +00:00
Chris Smowton
79928b9f76
Be consistent
...
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2024-01-19 10:44:36 +00:00
Chris Smowton
e999e38b43
Note AWS Lambda support
...
JS/TS support is old; noting for symmetry with advertised support in Python. Golang support is new as of https://github.com/github/codeql/pull/15373
2024-01-19 10:33:40 +00:00
Tony Torralba
7e7175f49d
Merge pull request #15373 from atorralba/atorralba/go/aws-lambda-sources
...
Go: Add flow sources for AWS Lambda function handlers
2024-01-19 11:21:20 +01:00
Joe Farebrother
4de19b3ec9
Merge pull request #15039 from joefarebrother/csharp-razor-flow-page-models
...
C#: Add flow steps from a PageModel to cshtml page.
2024-01-19 10:07:25 +00:00
Tony Torralba
8d6aa281b9
Update go/ql/lib/semmle/go/frameworks/AwsLambda.qll
...
Co-authored-by: Chris Smowton <smowton@github.com >
2024-01-19 10:48:34 +01:00
Pierre
51a65f9794
Merge pull request #15376 from github/sitedocs/2.15.5-2
...
Regenerate 2.16.0 changelog with fixed changenote
2024-01-19 10:43:21 +01:00
Tony Torralba
9a0fb39382
Model StartWithContext
...
Co-authored-by: Chris Smowton <smowton@github.com >
2024-01-19 09:25:35 +01:00
Tony Torralba
d3a9a5ec3f
Update go/ql/lib/semmle/go/frameworks/AwsLambda.qll
...
Co-authored-by: Chris Smowton <smowton@github.com >
2024-01-19 09:22:46 +01:00
Michael Nebel
24855ddc64
Merge pull request #15328 from michaelnebel/csharp/inlinearrays
...
C# 12: Inline array support.
2024-01-19 09:11:26 +01:00
Michael Nebel
cb53ca4e1f
Merge pull request #15367 from michaelnebel/csharp/nullablesimpletypesanitizer
...
C#: Consider nullable simple types as sanitizers.
2024-01-19 09:09:36 +01:00
Aditya Sharad
a3c0425eb3
Merge pull request #15349 from github/remove-codeql-cli-docs
...
Remove outdated CodeQL CLI docs
2024-01-18 09:45:05 -08:00
Geoffrey White
963e0a730d
C++: Fix some off-by-one mistakes in the test.
2024-01-18 17:38:32 +00:00
Pierre
4922b7fd11
Regenerate 2.16.0 changelog with fixed changenote
2024-01-18 18:08:50 +01:00
Tony Torralba
716c6cd519
Merge pull request #15375 from atorralba/atorralba/docs/amend-change-note
...
Fix change note category for clarity
2024-01-18 17:49:00 +01:00
Benjamin Rodes
833ef9d6d6
Further reorg of libraries and predicates to allow for more reusable and consistent libraries.
2024-01-18 11:17:24 -05:00
Tony Torralba
736df6fb05
Fix change note category for clarity
2024-01-18 17:09:34 +01:00
Geoffrey White
42571069bf
C++: Autoformat.
2024-01-18 16:01:06 +00:00
Geoffrey White
017369c6f2
C++: Remove redundant import (identified by QL-for-QL).
2024-01-18 15:59:32 +00:00
Benjamin Rodes
967526b285
Separating out use after free logic into a library and a ql so the query can be expanded easily.
2024-01-18 10:59:17 -05:00
Benjamin Rodes
8bd682b3f2
Deallocation.qll formatting.
2024-01-18 10:49:23 -05:00
Benjamin Rodes
7e70b30772
Adding missing windows library free functions to deallocation set
2024-01-18 09:59:28 -05:00
Alex Ford
9536fb5cae
Merge pull request #15372 from github/rb/docs-ruby-3-3
...
Ruby: update supported version to 3.3
2024-01-18 14:47:15 +00:00
Tony Torralba
1d7dbec719
Go: Add flow sources for AWS Lambda function handlers
2024-01-18 15:17:21 +01:00
Michael B. Gale
d8eef2716b
Merge pull request #15360 from github/mbg/csharp/redefine-successfully-extracted-files
2024-01-18 14:09:20 +00:00
Geoffrey White
cc2b61186e
C++: Document TReturnKind, NormalReturnKind and IndirectReturnKind better.
2024-01-18 13:24:57 +00:00
Geoffrey White
dd27ef7d3c
C++: Add MAD source definitions for the new taint sources and update the (real) test.
2024-01-18 13:24:57 +00:00
Geoffrey White
833165f86c
C++: Update the (synthetic) test.
2024-01-18 13:24:57 +00:00
Geoffrey White
c85262cfd0
C++: Add the shared MAD pack to CPP.
2024-01-18 13:24:57 +00:00
Geoffrey White
a8863e44db
C++: Port implementation to CPP.
2024-01-18 13:24:57 +00:00
Geoffrey White
3aacc5ffde
C++: Copy FlowSummaryImpl.qll from Swift.
2024-01-18 13:01:16 +00:00
Geoffrey White
fbf9545338
C++: Copy ExternalFlow.qll from Swift.
2024-01-18 13:01:16 +00:00
Geoffrey White
303882350b
C++: Add some test cases for new (real) taint sources to be defined using models-as-data.
2024-01-18 13:01:16 +00:00
Geoffrey White
9611e4ce19
C++: Add tests for (synthetic) models-as-data sources and sinks.
2024-01-18 13:01:16 +00:00
Michael Nebel
43350b0664
C#: Add change note.
2024-01-18 13:55:18 +01:00
Rasmus Wriedt Larsen
f20d4e22fe
Handle only exclude
2024-01-18 13:54:45 +01:00
Michael Nebel
9e9b5292f2
C#: Add change note.
2024-01-18 13:50:52 +01:00
Michael B. Gale
d0003ce7be
C#: Rename query to ExtractedFiles
2024-01-18 12:47:11 +00:00
Michael Nebel
337ab611c9
C#: Update expected test output.
2024-01-18 12:53:48 +01:00
Michael Nebel
9460c91c8c
C#: Also consider nullable simple types (and datetime) as simple type sanitizers.
2024-01-18 12:53:29 +01:00
Michael Nebel
559842071a
C#: Add example of log forging alert for simple nullable types and updated expected test output.
2024-01-18 12:50:40 +01:00
Michael Nebel
f8f95e6a19
C#: Add models as data test for inline arrays.
2024-01-18 12:23:26 +01:00
Michael Nebel
1d88ca2388
C#: Add more InlineArray test cases.
2024-01-18 12:23:26 +01:00
Rasmus Wriedt Larsen
54c7c5e8be
Tree sitter extractor: Proper handling of LGTM_INDEX_FILTERS
...
If someone had used `LGTM_INDEX_FILTERS=exclude:**/*\ninclude:*.rb`
before, we would have mistakenly excluded all files :|
(LGTM_INDEX_FILTERS is a prioritized list where later matches take
priority over earlier ones)
This change is needed to support adding `exclude:**/*` as the first
filter if `paths` include a glob, which currently causes bad behavior in
the Python extractor. However, we can first introduce that change once
this PR has been merged.
I realize this change can cause more folders and files to be traversed
(since they are not just skipped with --exclude). We plan to make a
better long term fix which should bring back the previous performance.
2024-01-18 11:44:31 +01:00
Michael Nebel
70e7c92774
C#: Also check the namespace of the InlineArrayAttribute.
2024-01-18 11:09:01 +01:00
Michael Nebel
674838e698
C#: Add flow test for inline arrays.
2024-01-18 11:09:01 +01:00
Michael Nebel
f14b3265ab
C#: Move static methods in CollectionFlow as these impact result line numbers.
2024-01-18 11:09:00 +01:00
Michael Nebel
47505b3bfa
C#: Add array access test for an inline array.
2024-01-18 11:09:00 +01:00
Michael Nebel
0453bb86e0
C#: Update test output of existing expressions tests.
2024-01-18 11:09:00 +01:00
Michael Nebel
ae52779cf6
C#: Add inline array test to expressions.
2024-01-18 11:09:00 +01:00
Michael Nebel
de831d188f
C#: Add inline type array test.
2024-01-18 11:09:00 +01:00
Michael Nebel
8a97c8c28e
C#: Add QL support for InlineArrayType.
2024-01-18 11:09:00 +01:00
Erik Krogh Kristensen
cda2ef4db5
Merge pull request #15364 from github/dependabot/cargo/ql/rayon-1.8.1
...
Bump rayon from 1.8.0 to 1.8.1 in /ql
2024-01-18 09:24:30 +01:00
dependabot[bot]
7b574bb07a
Bump rayon from 1.8.0 to 1.8.1 in /ql
...
Bumps [rayon](https://github.com/rayon-rs/rayon ) from 1.8.0 to 1.8.1.
- [Changelog](https://github.com/rayon-rs/rayon/blob/master/RELEASES.md )
- [Commits](https://github.com/rayon-rs/rayon/compare/rayon-core-v1.8.0...rayon-core-v1.8.1 )
---
updated-dependencies:
- dependency-name: rayon
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-01-18 03:16:14 +00:00
Michael B. Gale
a30791833d
C#: Report any extracted file as successfully extracted
2024-01-17 20:57:39 +00:00
Michael B. Gale
4a71ddd8b6
Merge pull request #15355 from github/mbg/go/increase-test-robustness
...
Go: Improve robustness of integration tests
2024-01-17 16:45:30 +00:00
Ben Rodes
67e43ecc44
Merge branch 'main' into 38-cpp-generalize-use-after-free-libraries
2024-01-17 08:05:41 -08:00
Michael B. Gale
783f006d62
Go: Update go clean -modcache comment
2024-01-17 16:04:13 +00:00
Sid Shankar
2d71294f61
Merge pull request #15256 from sidshank/change/adjust-extracted-files-diagnostics
...
Js/Py/Rb: Report any extracted file as successfully extracted
2024-01-17 11:04:06 -05:00
Mathias Vorreiter Pedersen
39dafd6f6a
C++: Suggestions to #15343 ( #39 )
...
* C++: Change the interface of 'FlowAfterFree' so that the module it takes
a single module as a parameter.
* C++: Add another predicate to the module signature.
* C++: Convert the use-after-free and double-free libraries to use new interface.
* C++: Accept test changes.
2024-01-17 11:02:46 -05:00
Max Schaefer
7bc03040ec
Make tags for positive and negative examples more precise.
2024-01-17 15:57:27 +00:00
Max Schaefer
3ae484868a
Merge pull request #15326 from github/max-schaefer/automodel-negative-sink-models
...
Automodel: Apply negative characteristics only to endpoints of the right kind.
2024-01-17 15:54:28 +00:00
Calum Grant
4660a25d44
Merge pull request #15354 from github/calumgrant/shared-diagnostics
...
C++/Swift: Create shared library and share Diagnostics
2024-01-17 15:40:12 +00:00
Max Schaefer
ae23920a6d
Fix spurious source models for primitive types in framework mode.
2024-01-17 15:36:31 +00:00
Max Schaefer
9975f974ee
Autoformat.
2024-01-17 14:53:09 +00:00
Max Schaefer
6d2bf68a86
Use inline expectations for all framework-mode tests.
2024-01-17 14:52:42 +00:00
Max Schaefer
6c47a5d5f9
Refactor framework-mode queries to make them more easily testable.
2024-01-17 14:51:58 +00:00
Erik Krogh Kristensen
17466385e0
Merge pull request #15351 from erik-krogh/zero-to-question
...
JS/PY/JAVA/RB: mark the range [0-?] as good in the overly-large-range query
2024-01-17 15:51:42 +01:00
Michael B. Gale
c00520011c
Go: Install integration test dependencies to local GOPATH
2024-01-17 14:51:06 +00:00
Michael B. Gale
afc673324f
Go: Move integration test sources to subdirectories
2024-01-17 14:50:57 +00:00
Max Schaefer
adea805546
Refactor application-mode tests so we can reuse most of it for framework mode.
2024-01-17 14:49:19 +00:00
Max Schaefer
312dd16956
Consolidate application mode tests.
2024-01-17 14:48:27 +00:00
Max Schaefer
692d5e55a2
Use inline expectations for positive examples.
2024-01-17 14:48:22 +00:00
Max Schaefer
83c567385f
Use inline expectations for negative-example tests as well.
2024-01-17 14:47:39 +00:00
Max Schaefer
1ebd0747a8
Fix treatment of void method calls.
2024-01-17 14:40:47 +00:00
Max Schaefer
18e44b6f5c
Turn AutomodelApplicationModeExtractCandidates into an inline-expectations test.
2024-01-17 14:40:46 +00:00
Max Schaefer
587d69e88c
Refactor application-mode candidate-extraction query so we can test its results before sampling.
2024-01-17 14:40:46 +00:00
Max Schaefer
800a78d258
Treat unexploitable types more centrally.
...
The apparently missing test result is due to sampling.
2024-01-17 14:40:37 +00:00
Calum Grant
d57fc3d7db
C++: Remove unneeded includes
2024-01-17 14:34:28 +00:00
Sid Shankar
2c683c910f
Merge branch 'change/adjust-extracted-files-diagnostics' of https://github.com/sidshank/codeql into change/adjust-extracted-files-diagnostics
2024-01-17 14:32:36 +00:00
Sid Shankar
0824ab77e9
Adds change notes
2024-01-17 14:31:40 +00:00
Max Schaefer
8614d7bddb
Address review feedback.
2024-01-17 14:29:52 +00:00
Chad Bentz
b12f4d97f8
Merge branch 'main' into patch-1
2024-01-17 09:25:28 -05:00
Calum Grant
51c5afff8b
Create shared/cpp library and move Diagnostics there
2024-01-17 14:23:18 +00:00
AlexDenisov
8610c950e1
Merge pull request #15329 from github/alexdenisov/duplicate-destructor-calls
...
C++: update tests to pick up destructor changes
2024-01-17 15:05:30 +01:00
Michael Nebel
fcb9e473c0
C#: Add upgrade and downgrade scripts.
2024-01-17 14:08:18 +01:00
Michael Nebel
83c16ae993
C#: Extract structs representing inline arrays as inline arrays.
2024-01-17 14:01:05 +01:00
Michael Nebel
5e692a882e
C#: Update dbscheme with a typekind for inline arrays.
2024-01-17 14:01:05 +01:00
erik-krogh
1a8a70dc1b
mark the range [0-?] as good in the overly-large-range query
2024-01-17 13:11:57 +01:00
Mathias Vorreiter Pedersen
b7a7963d05
Merge pull request #15348 from MathiasVP/remove-bad-magic-swift
2024-01-17 12:00:22 +00:00
Alex Denisov
f1049a4431
C++: update tests to pick up destructor changes
2024-01-17 12:05:30 +01:00
Michael B. Gale
5cf9bc2a76
Merge pull request #15341 from github/mbg/go/simplify-tests
2024-01-17 10:56:34 +00:00
Felicity Chapman
e96585f777
Remove outdated CodeQL CLI docs
2024-01-17 09:29:53 +00:00
Sid Shankar
59098be8c4
Merge branch 'main' into change/adjust-extracted-files-diagnostics
2024-01-16 21:51:41 -05:00
Mathias Vorreiter Pedersen
6391346ade
Swift: Add 'nomagic'.
2024-01-16 23:08:20 +00:00
Mathias Vorreiter Pedersen
1fba345fb3
Merge pull request #15219 from rdmarsh2/rdmarsh2/swift/parameterized-cfg-library
...
Swift: switch to shared, parameterized CFG library
2024-01-16 21:54:05 +00:00
Benjamin Rodes
9a0e2e57ba
Updating .expected
2024-01-16 13:18:25 -05:00
Benjamin Rodes
a0ef7955b1
Updating FlowAfterFree to not enforce dominance of source/sink. DoubleFree and UseAfterFree queries now enforce dominance.
2024-01-16 13:15:36 -05:00
Pierre
d6030764aa
Merge pull request #15279 from github/sitedocs/2.15.5-2
...
Generate Changelogs for 2.15.5 & 2.16.0
2024-01-16 18:29:22 +01:00
Shati Patel
e50a0ee7f9
Merge pull request #15333 from github/shati-patel/settings-telemetry
...
Add note about telemetry for CodeQL extension settings
2024-01-16 17:05:45 +00:00
Pierre
4866c9c811
Add 2.16.0 changelog and move query list link to index
2024-01-16 17:07:14 +01:00
Michael B. Gale
08c4dc1ea5
Go: Exclude all FlowSummaryNodes from test results
2024-01-16 15:51:40 +00:00
Alexander Eyers-Taylor
934474681d
Merge pull request #15254 from github/post-release-prep/codeql-cli-2.16.0
...
Post-release preparation for codeql-cli-2.16.0
2024-01-16 14:50:40 +00:00
Calum Grant
e18ee790f2
Merge pull request #15322 from github/calumgrant/swift-diagnostics
...
Swift extractor: Generalise SwiftDiagnostics
2024-01-16 14:30:17 +00:00
Michael Nebel
8d64d71583
C#: Move the gen kind enum script.
2024-01-16 14:18:41 +01:00
Alex Ford
abbc80ac8a
Ruby: update supported version to 3.3
2024-01-16 12:55:58 +00:00
AlexDenisov
696a72a127
Merge pull request #15259 from github/alexdenisov/swift-5.9.2
...
Swift: upgrade to 5.9.2
2024-01-16 12:49:13 +01:00
Calum Grant
7cadb0a574
Swift extractor: Simplify declarations back
2024-01-16 11:31:15 +00:00
Calum Grant
f400a5f49f
Swift extractor: Fix Linux build
2024-01-16 11:05:05 +00:00
Calum Grant
2cc574dc70
Swift extractor: Use a global variable for the extractor name
2024-01-16 10:56:18 +00:00
Rasmus Wriedt Larsen
6f45de1095
Merge pull request #15325 from RasmusWL/c#-filter-order
...
C#: Respect order of `LGTM_INDEX_FILTERS` in buildless extraction
2024-01-16 09:28:44 +01:00
Tony Torralba
2246c969a3
Merge pull request #15244 from Marcono1234/marcono1234/regex-flags
...
Java: Improve Regex flag parsing
2024-01-16 08:25:49 +01:00
amammad
a47c702171
change TN to GOOD instead of using hasValueFlow
2024-01-15 22:08:35 +04:00
Shati Patel
c445b2b547
Add note about telemetry for CodeQL extension settings
2024-01-15 16:32:27 +00:00
Mathias Vorreiter Pedersen
c38ae93640
Swift: Fix import.
2024-01-15 15:42:51 +00:00
Mathias Vorreiter Pedersen
e735ced751
Swift: Autoformat.
2024-01-15 15:24:27 +00:00
Michael B. Gale
6c9f79cc32
Merge pull request #15327 from github/mbg/go/handle-pre-release-versions
...
Go: Better handle pre-release versions
2024-01-15 15:24:23 +00:00
github-actions[bot]
57df8b92df
Post-release preparation for codeql-cli-2.16.0
2024-01-15 15:00:50 +00:00
Rasmus Wriedt Larsen
13c236227f
C#: Apply suggestions from code review
...
Co-authored-by: Michael B. Gale <mbg@github.com >
2024-01-15 15:51:36 +01:00
Rasmus Wriedt Larsen
086e4f7f12
C#: Adjust test for LGTM_INDEX_FILTERS
2024-01-15 15:50:25 +01:00
Michael B. Gale
8c13429163
Go: Ensure getEnvGoSemVer returns a canonical SemVer
2024-01-15 14:20:48 +00:00
Michael B. Gale
a64c001637
Go: Remove unnecessary call to Canonical
2024-01-15 14:19:55 +00:00
Owen Mansel-Chan
63a914a324
Merge pull request #15324 from owen-mc/go/add-fasthttp-to-frameworks-for-coverage
...
Go: add fasthttp to frameworks for coverage
2024-01-15 14:15:19 +00:00
Michael B. Gale
42dcb5f94d
Go: Better handle pre-release versions
2024-01-15 14:00:56 +00:00
Max Schaefer
90a4552c4f
Fix omittable exists.
2024-01-15 13:45:03 +00:00
Max Schaefer
fee44074f7
Autoformat.
2024-01-15 13:44:45 +00:00
Max Schaefer
3befce98b3
When checking whether an endpoint has already been modelled, make sure to take the extensibleType into account.
2024-01-15 12:09:39 +00:00
Asger F
96f8a02a72
JS: Treat private-field methods as private
2024-01-15 13:00:39 +01:00
Max Schaefer
68cf9aca12
Remove a few getExtensibleType checks which are now unnecessary.
2024-01-15 11:50:59 +00:00
Rasmus Wriedt Larsen
59d239b230
C#: Respect order of LGTM_INDEX_FILTERS in buildless extraction
...
That is, using `exclude:**/*\ninclude:**/*` should include everything.
2024-01-15 11:45:58 +01:00
Owen Mansel-Chan
d85628e6a6
Update Go coverage reports
2024-01-15 10:17:48 +00:00
Owen Mansel-Chan
216464f382
Add fasthttp framework to the coverage reports
2024-01-15 10:14:06 +00:00
Calum Grant
39edfa3c14
Swift extractor: Rename a SwiftDiagnostic to Diagnostic
2024-01-15 09:34:28 +00:00
Calum Grant
f82c29ee37
Swift extractor: Generalize SwiftDiagnostics
2024-01-15 09:12:26 +00:00
amammad
65ac94320e
fix Typo in tests
2024-01-15 01:14:54 +04:00
amammad
073f65d586
Merge branch 'amammad-go-bombs' of https://github.com/amammad/codeql into amammad-go-bombs
2024-01-15 01:12:40 +04:00
amammad
3c79faf37a
minor change for resolving rebase conflicts
2024-01-15 01:06:36 +04:00
amammad
2fe10942da
minor change for resolving rebase conflicts
2024-01-15 01:02:55 +04:00
amammad
3fcb0ee228
move MultipartAndFormRemoteSource to DecompressionBombs.qll
2024-01-15 01:01:51 +04:00
amammad
b2edf6cf3e
add Inline Expectations Test, update tests accordingly
2024-01-15 00:27:06 +04:00
amammad
a1c384c57b
change Decompression bombs Query structure
2024-01-15 00:22:55 +04:00
Owen Mansel-Chan
057ee85cd0
Merge pull request #14123 from am0o0/amammad-go-fastHttp
...
Go: fasthttp
2024-01-14 20:12:31 +00:00
amammad
0efb00724d
Add hasFlowToComparison to all sinks as a sanitizer
2024-01-15 00:05:11 +04:00
Ian Lynagh
ff2b40a53d
Merge pull request #15315 from igfoo/igfoo/typo
...
C++: Fix typo
2024-01-12 18:28:32 +00:00
Ian Lynagh
e357d18d35
C++: Fix typo
2024-01-12 17:57:34 +00:00
Max Schaefer
919330fb53
Some more performance refactoring.
2024-01-12 17:38:58 +00:00
Max Schaefer
bb63fcde43
Refactor to avoid bad join order.
2024-01-12 15:24:24 +00:00
Michael Nebel
275822f80d
Merge pull request #15296 from michaelnebel/csharp/getruntimeargument
...
C#: Improve getRuntimeArgumentForParameter to consider named arguments.
2024-01-12 15:57:17 +01:00
Michael Nebel
9becd0876f
Merge pull request #15179 from michaelnebel/modelgenrespectmanual
...
C#/Java: Increase precision of model generation.
2024-01-12 15:12:21 +01:00
Max Schaefer
45ca301593
Rename a predicate.
2024-01-12 13:18:05 +00:00
Michael Nebel
dcce93ac4c
C#: Address more review comments.
2024-01-12 14:07:27 +01:00
Michael Nebel
37a21ec548
Java: Address review comments.
2024-01-12 13:36:23 +01:00
Michael Nebel
74cdcab6d8
Java: Update expected test output.
2024-01-12 13:36:23 +01:00
Michael Nebel
6af0bca777
Java: Avoid generating contradicting summary and neutral summary models.
2024-01-12 13:36:23 +01:00
Michael Nebel
03d4025b99
Java: Add a testcase where both a neutral summary and summary is being generated.
2024-01-12 13:36:23 +01:00
Michael Nebel
c7045fbb99
C#: Add some test cases for excluding methods for model generation.
2024-01-12 13:35:23 +01:00
Michael Nebel
8702293878
C#: Update expected test output for type based model generator.
2024-01-12 13:35:23 +01:00
Michael Nebel
81de9d35af
C#/Java: Don't generate models if there exist a manual summary or neutral summary.
2024-01-12 13:35:22 +01:00
Max Schaefer
ea26e21454
Extend negative characteristics for exceptions to source models.
2024-01-12 12:20:22 +00:00
Max Schaefer
06ba5ea9f8
Eliminate GetCallable modules and use getCallable instead.
2024-01-12 12:03:49 +00:00
Max Schaefer
76b84301e3
Share some code.
2024-01-12 12:03:49 +00:00
Max Schaefer
9f443d4f83
Make Unexploitable*Characteristic more precise.
2024-01-12 12:03:41 +00:00
Mathias Vorreiter Pedersen
6bd31deb00
Merge pull request #15282 from MathiasVP/fix-duplicate-final-global-value
...
C++: Fix duplicate "final global value" nodes
2024-01-12 11:05:19 +00:00
Max Schaefer
a8336328fd
Merge pull request #15176 from github/max-schaefer/py-url-redirection-qhelp
...
Python: Mention more sanitisation options in py/url-redirection qhelp.
2024-01-12 10:50:33 +00:00
Michael Nebel
c68f9b05cd
C#: Address review comments.
2024-01-12 11:24:37 +01:00
Mathias Vorreiter Pedersen
8f36584bd9
C++: Fix Code Scanning errors.
2024-01-12 10:20:20 +00:00
Mathias Vorreiter Pedersen
34980bfe20
C++: Add more QLDoc.
2024-01-12 10:12:34 +00:00
Tony Torralba
448439e76b
Merge pull request #15294 from atorralba/atorralba/go/insecure-randomness-index-flowstep
...
Go: Recognize unsafe candidate selection in `go/insecure-randomness`
2024-01-12 11:08:56 +01:00
Owen Mansel-Chan
6945289afc
Merge pull request #15246 from owen-mc/java/manual-neutral-overrides-generated
...
C#/Java: Manual neutral summaries should block generated summaries
2024-01-12 10:05:18 +00:00
Owen Mansel-Chan
ed4843f397
Merge pull request #15302 from github/dependabot/go_modules/go/extractor/extractor-dependencies-159a68acba
...
Bump the extractor-dependencies group in /go/extractor with 1 update
2024-01-12 10:03:58 +00:00
Michael Nebel
9f14c7c408
Merge pull request #15297 from michaelnebel/csharp/typealias
...
C# 12: Type alias [Test only]
2024-01-12 11:03:25 +01:00
Felicity Chapman
e408078eaa
Merge pull request #15235 from github/docs-11486-security-severity
...
Replace blog link with link to GitHub user docs
2024-01-12 09:21:08 +00:00
Tony Torralba
87c6a3e38c
Merge pull request #15301 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-01-12 09:31:27 +01:00
Tony Torralba
31c11add85
Updated change note
2024-01-12 08:55:24 +01:00
dependabot[bot]
dd08c31dc5
Bump the extractor-dependencies group in /go/extractor with 1 update
...
Bumps the extractor-dependencies group in /go/extractor with 1 update: [golang.org/x/tools](https://github.com/golang/tools ).
Updates `golang.org/x/tools` from 0.16.1 to 0.17.0
- [Release notes](https://github.com/golang/tools/releases )
- [Commits](https://github.com/golang/tools/compare/v0.16.1...v0.17.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/tools
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: extractor-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-01-12 03:24:29 +00:00
github-actions[bot]
add9c4e489
Add changed framework coverage reports
2024-01-12 00:16:38 +00:00
Jeroen Ketema
1c9f5b8b74
Merge pull request #15300 from github/sashabu/uuidof
...
C++: Add a test with `__uuidof` in a template.
2024-01-12 00:05:49 +01:00
Felicity Chapman
f06cca8eff
Merge branch 'main' into docs-11486-security-severity
2024-01-11 22:28:30 +00:00
Alexandre Boulgakov
3493252321
C++: Add a test with __uuidof in a template.
2024-01-11 22:11:50 +01:00
Andrew Eisenberg
42f6dbe0b1
Merge pull request #15288 from github/aeisenberg/problem.severity
...
Update query-metadata-style-guide.md clarify problem.severity
2024-01-11 12:53:13 -08:00
Asger F
59c9ac735a
Merge pull request #15295 from asgerf/js/type-model-export
...
JS: Include sink nodes as base-case when resolving types
2024-01-11 20:47:32 +01:00
Tony Torralba
12c5b46a0a
Reduce FPs
...
* Restrict allowed types in the flow step
* Discard more non-crypto-related TLS APIs
2024-01-11 16:20:46 +01:00
Michael Nebel
0fa2067c3f
C#: Update expected test output.
2024-01-11 16:19:24 +01:00
Michael Nebel
b03eecb5ab
C#: Add support for named arguments in getRuntimeArgumentForParameter.
2024-01-11 16:19:24 +01:00
Michael Nebel
85f0ad623b
C#: Add testexample of using named arguments when calling a delegate.
2024-01-11 16:19:24 +01:00
Michael Nebel
8b464fbc4a
Merge pull request #15249 from michaelnebel/csharp/lambdadefaultparams
...
C# 12: Support for lambda `param` parameter and parameter defaults.
2024-01-11 16:18:03 +01:00
Owen Mansel-Chan
5e9ddd8c63
Apply suggestions from code review on change notes
...
Co-authored-by: Michael Nebel <michaelnebel@github.com >
2024-01-11 15:15:21 +00:00
Michael Nebel
ef73fc3a6f
C#: Add a test for type alias.
2024-01-11 16:13:35 +01:00
Owen Mansel-Chan
3c369f88bb
Add change notes
2024-01-11 14:00:17 +00:00
Erik Krogh Kristensen
d782bd9b1f
Merge pull request #13624 from jorgectf/seclab/dotjs
...
JS: Add `dot.js` support
2024-01-11 14:57:19 +01:00
Owen Mansel-Chan
def957e814
Accept review suggestion fixing a comment
...
Co-authored-by: Michael Nebel <michaelnebel@github.com >
2024-01-11 13:56:27 +00:00
Tom Hvitved
a1036c81ee
Merge pull request #15273 from hvitved/ruby/captured-yield
...
Ruby: Handle captured `yield` calls
2024-01-11 14:34:34 +01:00
Owen Mansel-Chan
2f01688319
Merge pull request #15280 from owen-mc/java/add-manual-models-for-df-generation
...
Java: improve models for some important JDK methods
2024-01-11 12:47:37 +00:00
Asger F
82cee61999
JS: Include sink nodes as base-case when resolving types
2024-01-11 13:41:21 +01:00
Max Schaefer
6e9c90a6bb
Properly distinguish negative source and sink characteristics.
...
In particular, `IsSanitizerCharacteristic` is a negative _source_ characteristic (not a negative sink characteristic), while `NeutralModelCharacteristic` is both.
This eliminates the erroneous test results.
2024-01-11 12:36:48 +00:00
Max Schaefer
ff4555ac5b
Get rid of negative sink types.
...
Instead of positively implying the negative sink type, negative sink characteristics now negatively imply all sink types (but not source types). This is simpler and sice we will never have a huge number of sink types it doesn't impact performance either.
Changes to test results:
- The call to `createDirectories` at `Test.java:87` is now correctly classified as a source candidate, having previously been erroneously excluded by a negative _sink_ characteristic.
- The call to `compareTo` at `Test.java:48` is now erroneously classified as a source candidate; it should be suppressed by `IsSanitizerCharacteristic`, which is a negative sink characteristic, but should really be a negative source characteristic.
- In framework mode, several endpoints are now erroneously classified as source candidates even though they have neutral models, because `NeutralModelCharacteristic` is currently only a negative sink characteristic and not a negative source characteristic.
2024-01-11 12:19:53 +00:00
Max Schaefer
bcf4f4febd
Drop a conjunct which is now spurious.
2024-01-11 11:56:59 +00:00
Max Schaefer
03ca244df2
Associate endpoints with their potential endpoint types and check these when determining candidates.
...
This prevents us from associating a sink candidate with a source type and vice versa.
However, this does not fix the problem of negative characteristics for sink types excluding source candidates.
2024-01-11 11:44:14 +00:00
Max Schaefer
a6d996b478
Add an example of a missed source candidate.
...
`Files.list` has a taint step from its first argument to its result, so that first argument should not be considered a sink candidate (and it is not). However, due to a bug in `IsMaDTaintStepCharacteristic` it is also not considered a source candidate, which is wrong: as the example shows, if that argument is a call we do very much want to consider it as a source candidate.
2024-01-11 11:27:34 +00:00
Max Schaefer
8e429bd399
Rename isSinkCandidate (and a related predicate) to isCandidate.
...
This reflects the fact that these predicates also deal with source candidates.
2024-01-11 11:20:51 +00:00
Tony Torralba
05b487e3a6
Go: Recognize unsafe candidate selection in go/insecure-randomness
2024-01-11 11:58:12 +01:00
Max Schaefer
dba2e06a1d
Merge pull request #15283 from github/max-schaefer/release-automodel-query-pack
...
Release automodel extraction queries v0.0.12.
2024-01-11 10:28:55 +00:00
Tony Torralba
8ccacafb59
Merge pull request #15289 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-01-11 10:15:34 +01:00
Michael Nebel
1770beea25
C#: Update QL doc for getRuntimeArgumentForParameter.
2024-01-11 09:07:15 +01:00
Michael Nebel
4c1e84b992
C#: Address review comments.
2024-01-11 09:07:15 +01:00
Michael Nebel
4dedc454ae
C#: Add change-note.
2024-01-11 09:07:15 +01:00
Michael Nebel
e18534e748
C#: Force population of compiler generated delegates used for lambdas.
2024-01-11 09:07:15 +01:00
Michael Nebel
9a64e2a9b0
C#: Add test for lambda default parameters.
2024-01-11 09:07:15 +01:00
Michael Nebel
71c996a0be
C#: Update lambdaArgument expected output.
2024-01-11 09:07:14 +01:00
Michael Nebel
b2faf3618c
C#: Add support for params parameters in getRuntimeArgumentForParameter.
2024-01-11 09:07:14 +01:00
Michael Nebel
f0852c89bc
C#: Add test for lambda arguments.
2024-01-11 09:07:14 +01:00
Paolo Tranquilli
482b5f3b29
Merge pull request #15265 from github/redsun82/def-to-non-header-include-exceptions
...
C++: add `.def` to exceptions to AV rule 32
2024-01-11 08:34:43 +01:00
github-actions[bot]
7db46b6ab6
Add changed framework coverage reports
2024-01-11 00:16:44 +00:00
Andrew Eisenberg
2f190d6552
Update docs/query-metadata-style-guide.md
...
Co-authored-by: Angela P Wen <angelapwen@github.com >
2024-01-10 14:27:00 -08:00
Owen Mansel-Chan
3767348dec
Update test expectations
2024-01-10 22:25:08 +00:00
Owen Mansel-Chan
7824e60acd
Manual neutral summaries should block generated summaries
2024-01-10 22:25:06 +00:00
Owen Mansel-Chan
52563b01b7
Factor logic out into interpretNeutral
2024-01-10 22:25:04 +00:00
Owen Mansel-Chan
370a32da8b
Test summary models and neutral models, manual and generated
2024-01-10 22:25:02 +00:00
Andrew Eisenberg
303272d0d4
Update query-metadata-style-guide.md clarify problem.severity
2024-01-10 13:47:35 -08:00
Erik Krogh Kristensen
51fe477ed1
Merge pull request #15271 from erik-krogh/fastTS
...
JS: faster TypeScript extraction
2024-01-10 21:02:34 +01:00
Owen Mansel-Chan
9e2e01ff89
Update Top JDK APIs test expectation
2024-01-10 17:07:33 +00:00
Ian Lynagh
5d3166cfef
Kotlin: Tweak code formatting
2024-01-10 16:39:49 +00:00
Ian Lynagh
80163c5aac
Kotlin 2: Just accept the remaining comment differences for now
2024-01-10 16:39:47 +00:00
Ian Lynagh
ce4253c17f
Kotlin 2: Remove an expected diagnostic match
...
It is only generated when using the PSI comment extractor.
2024-01-10 16:39:04 +00:00
Ian Lynagh
20254fd71e
Kotlin: Accept a location change
2024-01-10 16:39:04 +00:00
Ian Lynagh
b3f8167973
Kotlin: Don't warn if we can't find a label for a fake owner
...
The fake owner probably just wasn't extracted
2024-01-10 16:39:02 +00:00
Owen Mansel-Chan
33030417b4
Add change note
2024-01-10 15:48:28 +00:00
Tony Torralba
52d3e3da31
Merge pull request #15268 from atorralba/atorralba/go/cleartext-logging-src-and-sink-improvs
...
Go: Adds sources and sinks to `go/clear-text-logging`
2024-01-10 15:52:40 +01:00
Tom Hvitved
ad75562b55
CPP: Update expected test output
2024-01-10 15:27:22 +01:00
Ian Wright
3534bfca9c
Merge pull request #15251 from github/z80coder/dry-run
...
Support dry-run of publishing script
2024-01-10 14:16:10 +00:00
Philip Ginsbach
a732199317
Merge pull request #15261 from github/ginsbach/WeakAliasesInLanguageReference
...
document weak aliases in the language reference
2024-01-10 13:55:10 +00:00
Ian Lynagh
f111fba4b7
Merge pull request #15269 from igfoo/igfoo/ktfmt
...
Kotlin: Reformat code
2024-01-10 13:35:35 +00:00
Tom Hvitved
295198744b
Ruby: Handle captured yield calls
2024-01-10 14:25:15 +01:00
Tom Hvitved
55be4c39ef
Ruby: Add data flow call sensitivity test
2024-01-10 14:25:12 +01:00
Paolo Tranquilli
1034c3d2f9
Merge pull request #15277 from github/redsun82/swift-fix-upgrade
...
Swift: fix upgrade and downgrade scripts
2024-01-10 14:19:25 +01:00
Tony Torralba
5e8c63c3aa
Use arg position instead of arg as class field to reduce number of instances
2024-01-10 14:12:29 +01:00
Owen Mansel-Chan
28aa9b2b3c
C#: Emulate that some methods don't have a body (so generated summaries will be applied)
2024-01-10 12:54:33 +00:00
erik-krogh
06c1fff770
address review comments
2024-01-10 13:53:54 +01:00
Tony Torralba
78c0cdfa2c
Apply suggestions from code review
...
co-authored-by: Owen Mansel-Chan <owen-mc@github.com >
2024-01-10 13:33:41 +01:00
Tony Torralba
3534f692dc
Fix test expectations
...
Barrier-in addition removes an overlapping path
2024-01-10 13:33:41 +01:00
Tony Torralba
80526e509e
Go: Adds sources and sinks to go/clear-text-logging
2024-01-10 13:33:41 +01:00
Tony Torralba
ca0a1dc7ae
Merge pull request #15267 from atorralba/atorralba/go/fmt-appenderorsprinter-mad
...
Go: Migrate AppenderOrSprinter model to models-as-data
2024-01-10 13:31:19 +01:00
Paolo Tranquilli
e64ce228bb
Merge pull request #15276 from github/redsun82/cmake-drop-internal-transition
...
Bazel/CMake: drop confusing `_INTERNAL_TRANSITION` suffix
2024-01-10 13:18:33 +01:00
Pierre
78f0aa971b
Fix historic changelogs (security coverage section)
2024-01-10 13:02:09 +01:00
Pierre
365cde36ae
Create 2.15.5 changelog
2024-01-10 13:01:49 +01:00
Mathias Vorreiter Pedersen
7a0cbb4e5a
C++: Accept test changes.
2024-01-10 11:55:53 +00:00
Mathias Vorreiter Pedersen
0c3ea6c5df
C++: Fix conflation issue.
2024-01-10 11:55:39 +00:00
Mathias Vorreiter Pedersen
259bf27334
C++: Add pointer/pointee conflation test.
2024-01-10 11:51:40 +00:00
Ian Wright
75545db97c
restore files, whether overriding or not
2024-01-10 11:40:31 +00:00
Tony Torralba
46df5857ec
Update test expectations
2024-01-10 12:31:02 +01:00
Max Schaefer
8d56ee4a56
Release automodel extraction queries v0.0.12.
2024-01-10 11:29:36 +00:00
Paolo Tranquilli
796c862623
Swift: fix downgrade script
2024-01-10 12:23:48 +01:00
Paolo Tranquilli
1d483cff1d
Swift: fix upgrade script
2024-01-10 12:09:11 +01:00
Ian Wright
f793ce1e49
remove temp testing comments
2024-01-10 11:07:06 +00:00
Ian Wright
ed8422a2da
remove need for CODEQL_DIST path
2024-01-10 11:07:06 +00:00
Ian Wright
0d2ec2d632
install codeql extension
2024-01-10 11:07:06 +00:00
Ian Wright
62bdaf069b
use gh tool to access codeql
2024-01-10 11:07:05 +00:00
Ian Wright
30e5be68c9
temp comment for testing
2024-01-10 11:07:05 +00:00
Ian Wright
9895114e05
temp comment for testing
2024-01-10 11:07:05 +00:00
Ian Wright
0f76fbad36
better processing of args
2024-01-10 11:07:05 +00:00
Ian Wright
749f8b9807
fix help message
2024-01-10 11:07:05 +00:00
Ian Wright
00f4991648
support dry-run
...
fix
fix
temp
temp
better support for dry-run
fix
fix
fix
fix
reinstate exits
2024-01-10 11:07:05 +00:00
Paolo Tranquilli
b93d108400
Bazel/CMake: drop confusing _INTERNAL_TRANSITION suffix
2024-01-10 12:00:40 +01:00
Tony Torralba
dc911c3f28
Apply suggestions from code review
...
co-authored-by: Owen Mansel-Chan <owen-mc@github.com >
2024-01-10 11:53:53 +01:00
Philip Ginsbach
d38d4aadf2
try to be clearer about weak and strong aliases in the language reference
2024-01-10 10:53:20 +00:00
Tom Hvitved
c9cf2a899c
Merge pull request #15260 from hvitved/dataflow/may-benefit-from-cctx-simplify
...
Data flow: Remove column from `mayBenefitFromCallContext`
2024-01-10 11:43:15 +01:00
Philip Ginsbach
29e4623d02
fix typos and other small improvements from review
2024-01-10 10:42:04 +00:00
Max Schaefer
ac8e92eec5
Merge pull request #15264 from github/max-schaefer/automodel-exclude-generated-calls
...
Automodel: Do not generate features for compiler-generated program elements.
2024-01-10 10:22:00 +00:00
Erik Krogh Kristensen
77b0c7f025
Merge pull request #15221 from erik-krogh/react-step
...
JS: promote `PropsTaintStep` to a `PreCallGraphStep`
2024-01-10 10:17:32 +01:00
Erik Krogh Kristensen
3000b4b9b3
rename PropsTaintStep to PropsFlowStep
...
Co-authored-by: Asger F <asgerf@github.com >
2024-01-10 09:45:29 +01:00
Tony Torralba
d6082f8446
Merge pull request #14926 from ebickle/fix/update-gson-model
...
Java: Improve Gson parse, get, and stream models
2024-01-10 09:11:01 +01:00
Michael Nebel
94bf5a41e6
Merge pull request #15225 from michaelnebel/java/modeldiffworkflow
...
Java: Bring the Model Diff workflow back into a working state.
2024-01-10 08:50:31 +01:00
Philip Ginsbach
1284fc529f
documentation: update definition of applicativeness in the specification
2024-01-09 17:09:05 +00:00
Philip Ginsbach
b393bc9a88
documentation: update definition of definite environment in the specification
2024-01-09 17:08:59 +00:00
Philip Ginsbach
805e9d8910
documentation: weak and strong aliases in the specification
2024-01-09 17:00:45 +00:00
Max Schaefer
9b7cfd88cd
Clarify relationship of isFromSource and Element::fromSource.
2024-01-09 16:21:36 +00:00
Tony Torralba
a0f6b5ea10
Update test expectations
2024-01-09 17:00:20 +01:00
Tony Torralba
da4049e25c
Go: Migrate AppenderOrSprinter model to models-as-data
2024-01-09 16:35:47 +01:00
Ian Lynagh
bf611feab3
Kotlin: Reformat code
...
Using:
java -jar ktfmt-0.46-jar-with-dependencies.jar --kotlinlang-style java/kotlin-extractor/**/*.kt
2024-01-09 15:33:41 +00:00
Paolo Tranquilli
27160b8861
C++: add change note
2024-01-09 15:31:43 +01:00
erik-krogh
d0fcb7d1ed
faster TypeScript extraction by not having to compute the "type-string" for a type every time
2024-01-09 15:30:55 +01:00
Paolo Tranquilli
0bfeadbf1f
C++: add .def to exception to test
2024-01-09 15:30:27 +01:00
Paolo Tranquilli
270df940ff
C++: add .def to exceptions to AV rule 32
...
This is used as textual includes in several projects for macro
metaprogramming, for example in `llvm-project` and in `swift` (and since
some time in our internal codebase as well).
2024-01-09 15:18:13 +01:00
Max Schaefer
3e8775daaa
Automodel: Do not generate features for compiler-generated program elements.
...
These have dummy locations, which breaks certain invariants that break downstream processing.
2024-01-09 13:39:46 +00:00
Ian Lynagh
0bc1463ab0
Merge pull request #14941 from igfoo/igfoo/dff
...
Kotlin 2: Accept some location changes
2024-01-09 12:20:37 +00:00
Ian Lynagh
95f336c05b
Merge pull request #14393 from igfoo/igfoo/no1.4
...
Kotlin: Remove 1.4 compatibility
2024-01-09 12:20:15 +00:00
Mathias Vorreiter Pedersen
1c81c9b6e3
Merge pull request #15262 from MathiasVP/fix-qldoc-on-cmpWithLinearBound
...
C++: Fix QLDoc on `cmpWithLinearBound`
2024-01-09 11:16:42 +00:00
Philip Ginsbach
225aff47ed
documentation: update section on applicativity
2024-01-09 10:39:18 +00:00
Philip Ginsbach
493158a3f5
documentation: add section no strong and weak aliases
2024-01-09 10:39:18 +00:00
Tom Hvitved
f90201eb56
Data flow: Remove column from mayBenefitFromCallContext
2024-01-09 11:34:43 +01:00
Mathias Vorreiter Pedersen
f5e1e49761
C++: Fix QLDoc on 'cmpWithLinearBound' as a response to #15248 .
2024-01-09 10:07:22 +00:00
Alex Denisov
0e73531aa9
Swift: upgrade to 5.9.2
2024-01-09 09:23:32 +01:00
Tony Torralba
3224b5c1b9
Merge pull request #15257 from github/workflow/coverage/update
...
Update CSV framework coverage reports
2024-01-09 08:57:28 +01:00
github-actions[bot]
384cf90e8f
Add changed framework coverage reports
2024-01-09 00:17:10 +00:00
maikypedia
6c8fbe877d
Changes
2024-01-09 00:46:41 +01:00
Eric Bickle
f6fa7120d9
Merge branch 'main' into fix/update-gson-model
2024-01-08 15:46:14 -08:00
Sid Shankar
b26fef816a
Rb: Report any extracted file as successfully extracted
2024-01-08 22:21:30 +00:00
Sid Shankar
fb660b8f05
Py: Report any extracted file as successfully extracted
2024-01-08 22:20:51 +00:00
Sid Shankar
e30a0d1e83
JS: Report any extracted file as successfully extracted
2024-01-08 22:19:33 +00:00
Robert Marsh
ec6d8da6b6
Swift: merge ControlFlowGraphParameter into ControlFlowGraphImplSpecific
2024-01-08 21:31:15 +00:00
Eric Bickle
929ce65af1
Remove zero width space characters.
2024-01-08 13:15:38 -08:00
Jeroen Ketema
9330afbe8a
Merge pull request #15252 from jketema/builtin-rm
...
C++: Remove test that is no longer relevant
2024-01-08 20:38:46 +01:00
Edward Minnix III
e9467fe2d6
Merge pull request #14724 from egregius313/egregius313/java/environment-variable-injection
...
Java: Environment variable injection query
2024-01-08 13:06:31 -05:00
Mathias Vorreiter Pedersen
18bd0d0ad0
Merge pull request #14954 from microsoft/32-cpp-string-concatenation-library
...
32 cpp string concatenation library
2024-01-08 18:42:31 +01:00
Geoffrey White
2f6f376d2d
Merge pull request #15230 from geoffw0/swiftui
...
Swift: Add dataflow tests for property wrappers and SwiftUI
2024-01-08 17:41:43 +00:00
Cornelius Riemenschneider
c84e85d35d
Merge pull request #15232 from github/criemen/bump-bazel-rules
...
Bazel: Bump dependant rules versions.
2024-01-08 17:49:21 +01:00
Ian Lynagh
d7cdad04dd
Merge pull request #14895 from igfoo/igfoo/kt-snap
...
Kotlin: Add a 2.0.255 snapshot
2024-01-08 16:13:03 +00:00
Ed Minnix
55da62e9cf
Remove stray comma
...
Co-authored-by: Felicity Chapman <felicitymay@github.com >
2024-01-08 11:09:11 -05:00
Alex Ford
ef8ca55d92
Merge pull request #15203 from pwntester/patch-3
...
Ruby: Update Kernel.qll to include `Object.send` aliases
2024-01-08 15:32:57 +00:00
Chuan-kai Lin
a743fca3a5
Merge pull request #15243 from github/cklin/upgrade-delete-fixes-ruby
...
Ruby: Fix upgrade delete directives
2024-01-08 07:27:59 -08:00
Chuan-kai Lin
c4e5506a2c
Merge pull request #15242 from github/cklin/upgrade-delete-fixes-csharp
...
C#: Fix upgrade delete directives
2024-01-08 07:27:40 -08:00
Chuan-kai Lin
d7e22b2ddd
Merge pull request #15241 from github/cklin/upgrade-delete-fixes-cpp
...
C++: Fix upgrade delete directives
2024-01-08 07:27:27 -08:00
Chris Smowton
b7158ab1d7
Merge pull request #15231 from github/smowton/admin/note-java-21-support
...
Note Java 21 support
2024-01-08 15:19:48 +00:00
Ed Minnix
b8466b45be
Update change note date
2024-01-08 09:39:11 -05:00
Edward Minnix III
2440075402
Remove off-topic reference
...
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2024-01-08 09:39:10 -05:00
Edward Minnix III
3816271b3e
Remove redundant CWE link
...
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2024-01-08 09:39:10 -05:00
Ed Minnix
2eff6b351c
Add comment
2024-01-08 09:39:09 -05:00
Ed Minnix
16bb19e176
Add OWASP and CERT references
2024-01-08 09:39:08 -05:00
Ed Minnix
9f974415c0
Add references to CWE-454 (External Initialization of Trusted Variables)
2024-01-08 09:39:07 -05:00
Ed Minnix
97b29bb965
Add Java Tutorial reference
2024-01-08 09:39:06 -05:00
Edward Minnix III
938d52b86f
Docs review suggestions
...
Co-authored-by: Felicity Chapman <felicitymay@github.com >
2024-01-08 09:39:05 -05:00
Ed Minnix
a528db8958
Use MapMutation instead of MethodCall
2024-01-08 09:39:05 -05:00
Ed Minnix
e14be0e971
Add BAD markers to samples
2024-01-08 09:39:04 -05:00
Ed Minnix
709649e9df
Model replace and putIfAbsent
2024-01-08 09:39:03 -05:00
Ed Minnix
1544330f3f
Minor fixes for code review
2024-01-08 09:38:53 -05:00
Ed Minnix
4b9b27c395
change note
2024-01-08 09:38:52 -05:00
Edward Minnix III
18e8a27fca
Reworded name and description
2024-01-08 09:38:51 -05:00
Edward Minnix III
1f37e70d83
Fix typos
...
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com >
2024-01-08 09:38:51 -05:00
Ed Minnix
51006aa088
Formatting fix
2024-01-08 09:38:50 -05:00
Ed Minnix
6eff72f99a
Include other map mutations
2024-01-08 09:38:49 -05:00
Ed Minnix
4fc6f710a4
Fix alert message
2024-01-08 09:38:48 -05:00
Ed Minnix
1550f5df2a
Environment variable injection query documentation
2024-01-08 09:38:47 -05:00
Ed Minnix
f1f0f50c92
TaintedEnvironmentVariableQuery docs
2024-01-08 09:38:47 -05:00
Ed Minnix
818c5de8d5
security-severity metadata
2024-01-08 09:38:46 -05:00
Ed Minnix
d4e2b84348
Cleanup helper dataflow configuration
2024-01-08 09:38:45 -05:00
Ed Minnix
f05f16116b
Testing for Environment variable injection
2024-01-08 09:38:45 -05:00
Ed Minnix
8ed3f3c865
Move to library
2024-01-08 09:38:44 -05:00
Ed Minnix
65d05bf3de
Add environment-injection to Model Validation
2024-01-08 09:38:43 -05:00
Ed Minnix
814885f7f6
Hudson environment variables models
2024-01-08 09:38:43 -05:00
Ed Minnix
028bd49211
org.apache.commons.exec models
2024-01-08 09:38:42 -05:00
Ed Minnix
b482b36b5f
Initial ProcessBuilder support
2024-01-08 09:38:41 -05:00
Ed Minnix
ad32b81492
environment-injection sink
2024-01-08 09:38:41 -05:00
Ed Minnix
93025cc8cf
Argument injection initial commit
2024-01-08 09:38:40 -05:00
Tony Torralba
7e6f2d1fc5
Merge pull request #14681 from atorralba/atorralba/java/weak-randomness-cve-coverage
...
Java: Add more sinks to the Insecure Randomness query
2024-01-08 15:33:03 +01:00
Robert Marsh
51acd1169c
Swift: accept test output
2024-01-08 14:29:51 +00:00
Jeroen Ketema
e772531bb3
C++: Remove test that is no longer relevant
2024-01-08 15:24:41 +01:00
Geoffrey White
6636c76af8
Merge pull request #15122 from geoffw0/pwhash
...
Swift: Query for Use of an inappropriate cryptographic hashing algorithm on passwords
2024-01-08 14:11:02 +00:00
Ian Lynagh
02734be287
Kotlin: Fix building with 2.0.255 snapshots
...
A couple of extension functions were moved
2024-01-08 13:25:25 +00:00
Ian Lynagh
9bc0167566
Kotlin: Add a 2.0.255 snapshot
...
The current master isn't compatible with the 2.0.0-Beta1
2024-01-08 13:25:25 +00:00
Cornelius Riemenschneider
b0599edb7e
Bazel: Bump dependant rules versions.
...
This doesn't bump rules_python, as there's some incompatible changes in that
which will need further addressing.
2024-01-08 11:21:02 +01:00
Alvaro Muñoz
dbefc132de
Apply suggestions from code review
...
Co-authored-by: Alex Ford <alexrford@users.noreply.github.com >
2024-01-07 10:31:50 +01:00
Marcono1234
3edfdc5ceb
Java: Improve Regex flag parsing
...
Fixes:
- Flag `d` not being recognized
- Syntax for disabling flags (`-`) not being recognized
- Non-capturing group with flags erroneously containing `:` as literal
2024-01-06 04:15:09 +01:00
Chuan-kai Lin
66d2b9b7d2
Ruby: Fix upgrade delete directives
2024-01-05 14:21:52 -08:00
Chuan-kai Lin
6e25fb129b
C#: Fix upgrade delete directives
2024-01-05 14:21:08 -08:00
Chuan-kai Lin
6f5bce046c
C++: Fix upgrade delete directives
2024-01-05 14:20:30 -08:00
Robert Marsh
80452cc9f7
Swift: redirect consistency queries to new module
2024-01-05 21:28:21 +00:00
Robert Marsh
2d457e17d6
Swift: autoformat for CFG library
2024-01-05 21:28:07 +00:00
Robert Marsh
86f59a1c13
Swift: add AnnotatedExitNode to cfg to match prior interface
2024-01-05 21:25:08 +00:00
Robert Marsh
ea4855bc06
Swift: add change note for parameterized CFG library
2024-01-05 21:24:44 +00:00
Robert Marsh
2f0d052558
Swift: header comment for ControlFlowGraphParameter
2024-01-05 21:19:46 +00:00
Felicity Chapman
8fdeb5691b
Fix bad table formatting
2024-01-05 14:50:16 +00:00
Felicity Chapman
222c498ded
Replace blog link with link to GitHub user docs
2024-01-05 14:13:38 +00:00
Geoffrey White
0aec2b1bf4
Swift: Improve consistency of phrasing arouaround 'computationally hard'.
2024-01-05 13:21:01 +00:00
Ben Rodes
250ed48bf3
Update cpp/ql/lib/semmle/code/cpp/commons/StringConcatenation.qll
...
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com >
2024-01-05 08:19:11 -05:00
Geoffrey White
a0ea7148cb
Swift: Add GOOD and BAD comments in the sensitive data hashing examples as well.
2024-01-05 13:17:21 +00:00
Geoffrey White
80afa65751
Swift: Add GOOD and BAD comments.
2024-01-05 13:16:41 +00:00
Geoffrey White
657e4d4132
Apply suggestions from code review
...
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com >
2024-01-05 13:04:47 +00:00
Chris Smowton
48d48c16ab
Note Java 21 support
...
Supported as of CodeQL release 2.15.4
2024-01-05 11:26:23 +00:00
Geoffrey White
2ab5e6f64c
Swift: Add link / reference to CryptoSwift.
2024-01-05 11:02:55 +00:00
Michael Nebel
04a724f373
Java: Update the model diff workflow.
2024-01-05 11:28:47 +01:00
Michael Nebel
8fe73f72cc
Java: Trigger Models as Data diff workflow on changes to the shared scripts.
2024-01-05 09:22:49 +01:00
Ben Rodes
2b325e99ce
Merge branch 'main' into 32-cpp-string-concatenation-library
2024-01-04 15:28:28 -05:00
Benjamin Rodes
ed788e0a7a
Updating test output.
2024-01-04 15:27:29 -05:00
Benjamin Rodes
e9bb3b4b28
Limiting << operator to ostream, and putting this check at the same location as the check for basic_string for + operator.
2024-01-04 15:25:47 -05:00
Geoffrey White
4016033f88
Swift: Add dataflow test cases for property wrappers.
2024-01-04 15:39:20 +00:00
Joe Farebrother
e8c0fceb81
Use post-update nodes for this access in void handler
2024-01-04 14:25:39 +00:00
Joe Farebrother
7d11e4486e
Adress reveiw comments - update tests to path-problem and support all this qualifiers
2024-01-04 14:25:39 +00:00
Joe Farebrother
cdeac9b7f8
Add change note + fix qldoc
2024-01-04 14:25:39 +00:00
Joe Farebrother
b9754df390
Add case for void-returning handler methods
2024-01-04 14:25:39 +00:00
Joe Farebrother
00892e127f
Add unit test + fix flow step
2024-01-04 14:25:38 +00:00
Joe Farebrother
c3cd40fc69
Add flow steps from page models
2024-01-04 14:25:38 +00:00
Ben Rodes
8d84540a54
Update cpp/ql/lib/semmle/code/cpp/commons/StringConcatenation.qll
...
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com >
2024-01-04 09:09:20 -05:00
Geoffrey White
fb77e3733b
Swift: Add a test of SwiftUI secure fields as a sensitive data source.
2024-01-04 12:34:33 +00:00
Owen Mansel-Chan
ce3097e9ce
Fix manual models for String.valueOf(Object)
...
Add a neutral model for it, but also a summary model for `String.valueOf(CharSequence)`
2024-01-04 11:31:20 +00:00
Owen Mansel-Chan
0076f06ce7
Improve manual models of java.lang.Exception
2024-01-04 11:31:18 +00:00
Owen Mansel-Chan
e415c54c5e
Reorder manual models of java.lang.Throwable
2024-01-04 11:31:16 +00:00
Owen Mansel-Chan
f52ea5c2fd
Improve manual models of java.lang.Throwable
2024-01-04 11:31:14 +00:00
erik-krogh
58dc14d5bb
update expected output
2024-01-04 11:38:58 +01:00
erik-krogh
a9f2b3fad6
promote PropsTaintStep to a PreCallGraphStep
2024-01-04 10:45:22 +01:00
Geoffrey White
31af8b9024
Swift: Test SwiftUI flow sources.
2024-01-04 09:28:10 +00:00
Robert Marsh
41ac0fca85
Swift: use toString and Location from shared CFG library
2024-01-03 21:11:15 +00:00
Eric Bickle
4fa5b2ae41
Add change nodes for GSON coverage
2024-01-02 14:17:23 -08:00
Eric Bickle
0cd89bf815
Merge branch 'main' into fix/update-gson-model
2024-01-02 14:05:33 -08:00
Alvaro Muñoz
2964aef083
Update Kernel.qll to include send aliases
...
Add `public_send` and `__send__` as Code Injection sinks as proposed by @vcsjones
2023-12-28 19:08:03 +01:00
Robert Marsh
a9c917010f
Swift: fix missing keypath CFGs
2023-12-22 17:55:00 +00:00
Stephan Brandauer
a9d21cef01
Update MaD Declarations after Triage
2023-12-21 15:39:03 +01:00
erik-krogh
fe3e768414
update expected output of tests
2023-12-20 14:10:36 +01:00
Max Schaefer
66fe32ab82
Python: Mention more sanitisation options in py/url-redirection qhelp.
2023-12-20 11:31:07 +00:00
Benjamin Rodes
f26330e6bd
Removing redundant/bad string type check.
2023-12-19 09:41:29 -05:00
Benjamin Rodes
6fb01925d0
Updating test ql file and applying formatting.
2023-12-19 09:39:46 -05:00
Benjamin Rodes
48866e5358
Updates to address PR comments.
2023-12-19 09:33:07 -05:00
Ben Rodes
387eddadad
Update cpp/ql/lib/semmle/code/cpp/commons/StringConcatenation.qll
...
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com >
2023-12-19 08:48:51 -05:00
Ben Rodes
29a0da6cd9
Update cpp/ql/lib/semmle/code/cpp/commons/StringConcatenation.qll
...
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com >
2023-12-19 08:48:20 -05:00
Ben Rodes
49728571cf
Update cpp/ql/lib/semmle/code/cpp/commons/StringConcatenation.qll
...
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com >
2023-12-19 08:47:58 -05:00
Ben Rodes
66f725dd05
Update cpp/ql/lib/semmle/code/cpp/commons/StringConcatenation.qll
...
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com >
2023-12-19 08:47:48 -05:00
Jorge
f8cfd698fa
Merge branch 'main' into seclab/dotjs
2023-12-19 10:44:52 +01:00
Malayke
22cb9ed063
Merge branch 'main' into main
2023-12-18 22:07:45 +08:00
Jorge
b81fbd7669
Add change note
2023-12-18 12:55:30 +01:00
amammad
79edc5c261
add sanitizer to all Read methods, add Inline tests, improve tests
2023-12-18 12:34:56 +01:00
maikypedia
a3ae8bd2c0
Add change note
2023-12-18 12:28:35 +01:00
maikypedia
8b2accca83
Add fixes and suggestions
2023-12-18 12:20:32 +01:00
Malayke
c90fcd19cc
Merge branch 'main' into main
2023-12-18 18:38:20 +08:00
Malayke
8d8126f849
Merge branch 'github:main' into main
2023-12-18 17:52:28 +08:00
amammad
a72bd7efcc
add GOOD and BAD comment to sinks, some chore improvements on tests
2023-12-17 20:07:16 +01:00
amammad
87b1028aab
fix pgzip missed sink, apply isBarrier directly to CopyN sink, add new flow state for pgzip
2023-12-17 19:55:50 +01:00
Malayke
ac465b9234
Merge branch 'github:main' into main
2023-12-16 18:02:14 +08:00
Eric Bickle
95ce7c9ba4
Merge branch 'main' into fix/update-gson-model
2023-12-15 10:15:53 -08:00
Geoffrey White
f6a4970012
Swift: Autoformat.
2023-12-15 14:58:11 +00:00
Geoffrey White
0b04e4abe5
Swift: Address QL-for-QL alerts.
2023-12-15 14:48:30 +00:00
Geoffrey White
034daa9b35
Swift: Address false positives.
2023-12-15 13:29:49 +00:00
Geoffrey White
326242a1fb
Swift: Change note.
2023-12-15 11:39:09 +00:00
Geoffrey White
b7a533f879
Swift: Update .qhelp for Swift.
2023-12-15 11:32:14 +00:00
Geoffrey White
0ff84b467f
Swift: Create examples for the .qhelp in Swift, and test them.
2023-12-15 11:14:05 +00:00
Yunus AYDIN
8a7c3c19fe
Merge branch 'main' into main
2023-12-15 09:05:50 +03:00
Yunus AYDIN
ec5a8b49c8
add httprouter example code and stub.go
2023-12-15 00:54:39 +03:00
Geoffrey White
363ec0a917
Swift: Update swift/summary/query-sinks.
2023-12-14 20:22:36 +00:00
Chad Bentz
ee3085e15e
Update generate-code-scanning-query-list.py
2023-12-14 14:09:14 -05:00
Geoffrey White
9ec08c1c4b
Swift: Add a couple of sinks missing from sensitive data hashing as well.
2023-12-14 18:04:35 +00:00
Geoffrey White
3a900f1f8b
Swift: Fix some inconsistencies in the test cases.
2023-12-14 18:04:34 +00:00
Geoffrey White
7ba18e64a0
Swift: Add sinks for algorithms that are OK for sensitive data hashing but not for password hashing.
2023-12-14 18:04:34 +00:00
Geoffrey White
c2d49c0fff
Swift: Address a weakness in the sensitive data regexs.
2023-12-14 18:04:34 +00:00
Geoffrey White
87eb96ed3b
Swift: Add more cases to test.
2023-12-14 18:04:34 +00:00
Geoffrey White
22ed20dd7c
Swift: Upgrade SecKeyCopyExternalRepresentation source to be considered a password / key rather than a miscellaneous credential.
2023-12-14 18:04:34 +00:00
Robert Marsh
3738e19db6
Swift: fix compilation failures outside CFG code
2023-12-14 16:39:51 +00:00
Geoffrey White
10b4c98e80
Swift: Move password sources to be reported by the new query.
2023-12-14 16:09:47 +00:00
Geoffrey White
5faa25fc6c
Swift: Make passwords their own sensitive data type.
2023-12-14 16:09:47 +00:00
Geoffrey White
b5a45c64ff
Swift: Define barriers, additional flow steps and sinks.
2023-12-14 16:09:47 +00:00
Geoffrey White
e5bf929cdb
Swift: Split off WeakPasswordHashingExtensions.qll as we normally do.
2023-12-14 16:09:46 +00:00
Geoffrey White
db1508d108
Swift: Trivial changes - query ID / metadata, imports.
2023-12-14 16:09:46 +00:00
Geoffrey White
9774c3cb4f
Swift: Copy WeakPasswordHashing query from csharp.
2023-12-14 16:09:45 +00:00
Geoffrey White
be7d0acfea
Swift: Minor fixes for the existing weak sensitive data hashing query (naming consistency, remove unused import).
2023-12-14 16:09:45 +00:00
amammad
4d9aad92a1
remove a duplicate test
2023-12-14 17:08:18 +01:00
amammad
d84333dad8
added *ReadBody* Methods as UntrustedFlowSource
2023-12-14 15:31:09 +01:00
Yunus AYDIN
ac3cb7f6c4
update camelcase
2023-12-14 15:29:28 +03:00
Yunus AYDIN
a17c704f46
update expected file
2023-12-14 15:27:27 +03:00
Yunus AYDIN
d899267acb
add httprouter example code
2023-12-14 00:23:09 +03:00
Yunus AYDIN
5f6de79c09
Fix select query, Add httprouter library and update test files
2023-12-14 00:19:11 +03:00
Robert Marsh
0e5255ea88
Swift: switch to shared, parameterized CFG library
2023-12-13 20:13:11 +00:00
Yunus AYDIN
a09505afc2
Update rules
2023-12-13 20:01:53 +03:00
Yunus AYDIN
5148054612
Update go/ql/src/experimental/CWE-525/WebCacheDeceptionLib.qll
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2023-12-13 19:36:07 +03:00
Yunus AYDIN
221e281f73
Update go/ql/src/experimental/CWE-525/WebCacheDeception.ql
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2023-12-13 19:35:59 +03:00
Yunus AYDIN
0ea27c6e9b
Update go/ql/src/experimental/CWE-525/WebCacheDeception.ql
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2023-12-13 19:35:53 +03:00
Yunus AYDIN
da275b374f
Update go/ql/src/experimental/CWE-525/WebCacheDeception.ql
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2023-12-13 19:35:36 +03:00
Tony Torralba
66b54f03b7
Rename test
2023-12-13 11:15:27 +01:00
Tony Torralba
d955dce72a
Improve source of randomness detection
...
Also sanitize flow out of sinks to avoid overlapping paths
2023-12-13 11:15:27 +01:00
Tony Torralba
fc45621ab1
Add pac4j JWT cryptographic key sinks
2023-12-13 11:15:27 +01:00
Tony Torralba
7bc907840c
Fix tests
2023-12-13 11:15:27 +01:00
Tony Torralba
3a5d711711
Add cookie sinks
2023-12-13 11:15:27 +01:00
Tony Torralba
435d1f97a3
Add sink for OpenSAML's RequestType.setID
2023-12-13 11:15:27 +01:00
Yunus AYDIN
a47ffc6833
Remove unnecessary rules
2023-12-13 01:52:06 +03:00
Yunus AYDIN
bb2083d10a
Remove database directory and add WebCacheDeceptionLib.qll
2023-12-13 01:50:56 +03:00
Yunus AYDIN
bc81201c2e
Update expected file
2023-12-12 00:07:51 +03:00
Malayke
7121282b27
add new query for detect DOS
2023-12-11 23:05:04 +08:00
amammad
572777f11b
fix a bug in stubs
2023-12-10 22:18:49 +01:00
amammad
bfa0fb6d74
remove a duplicate test
2023-12-10 22:08:12 +01:00
amammad
cc5416406f
added more sinks related to io.Writer of BodyWriter
2023-12-10 22:06:27 +01:00
Yunus AYDIN
cf8f2a38c3
Update expected file
2023-12-11 00:03:50 +03:00
amammad
102f09aa23
extend tests
2023-12-10 20:33:00 +01:00
amammad
18d0b28024
v1
2023-12-10 20:27:21 +01:00
Yunus AYDIN
a6b092d8c1
Update rules ids
2023-12-10 22:26:05 +03:00
Yunus AYDIN
4d97c42ee5
Remove debugging select on go-chi.ql
2023-12-10 22:18:48 +03:00
Yunus AYDIN
501f617eaa
Update qhelp and and go-chi
2023-12-10 22:07:17 +03:00
Yunus AYDIN
34fb1c4a9f
Add go-chi middleware stub to vendor
2023-12-10 22:06:23 +03:00
Am
59195cccdd
Merge branch 'main' into amammad-go-bombs
2023-12-10 18:12:10 +01:00
amammad
bb5017121f
Merge branch 'main' into amammad-go-bombs
2023-12-10 18:11:49 +01:00
amammad
737f3e8899
fix stubs
2023-12-10 18:10:23 +01:00
amammad
b6aaff2e64
use SimpleGlobal with source and sink to find BodyWriter successors globally
2023-12-10 15:45:42 +01:00
Yunus AYDIN
0813199c7f
Update vendor directory and go files
2023-12-10 01:24:29 +03:00
Yunus AYDIN
a925c23d14
Add go.mod and modules.txt
2023-12-09 23:36:50 +03:00
Yunus AYDIN
6bd3c8c07b
Format Document
2023-12-09 23:36:13 +03:00
Yunus AYDIN
6378c5e22f
Update Fiber Rule for checking files
2023-12-09 23:35:42 +03:00
Yunus AYDIN
63123f3984
Add GoChi Rule
2023-12-09 23:34:48 +03:00
Yunus AYDIN
ba4f8612eb
Add GoChi Test Cases
2023-12-09 23:33:18 +03:00
Yunus AYDIN
ad1284853b
remove unnecessary file
2023-12-09 19:49:21 +03:00
Yunus AYDIN
eb25d0df66
Add test cases
2023-12-09 19:44:58 +03:00
Yunus AYDIN
85636ccab7
Add Web Cache Deception QHelp and Example Code Snippet for Vulnerable Go Fiber usage
2023-12-09 19:12:20 +03:00
amammad
2cb0afee73
fix some qldocs and some spells
2023-12-08 11:12:57 +01:00
amammad
a3fbc3c20c
fix ResponseBody Class issues
2023-12-07 19:36:27 +01:00
amammad
5795c72a99
added inline tests
2023-12-07 14:04:33 +01:00
amammad
6ebdae3bab
Merge branch 'main' into amammad-python-bombs
2023-12-07 13:50:20 +01:00
amammad
2d0067d618
fix some qldocs, change Sink extenstion model, deduct some not necessarily checks :)
2023-12-07 13:45:28 +01:00
amammad
dbf01a9284
fix an issue in ResponseBody, change isHTMLEscape to isHtmlEscape
2023-12-07 08:52:55 +01:00
amammad
20a3211d06
move sanitizers from sharedxss::sanitizer to EscapeFunction::Range, added proper inline tests
2023-12-06 16:19:34 +01:00
amammad
3e0ed0090f
added BodyWriter Sink, added proper content-type header in tests to comply new changed xss strategy
2023-12-06 16:00:36 +01:00
amammad
d3099ff482
fix tests, move from SharedXss::Sink to Http::* classes
2023-12-06 15:52:50 +01:00
amammad
1547cd0546
added inline tests, move to experimental dir
2023-12-05 18:59:46 +01:00
amammad
2c4d2d3069
Merge branch 'main' into amammad-js-CodeInjection_execa
2023-12-05 18:38:09 +01:00
amammad
67fb802f29
fix conflict
2023-12-05 18:37:50 +01:00
Jorge
8abd1d9855
Merge branch 'main' into seclab/dotjs
2023-11-30 19:42:18 +01:00
Jorge
91bc043f30
Add .html.dot to Autobuild.java
2023-11-30 19:38:24 +01:00
Benjamin Rodes
94a0420040
Updated getResultExpr to getResultNode. Added strlcat. Added tests.
2023-11-29 16:03:41 -05:00
Benjamin Rodes
4919c4a424
Added StringConcatenation.qll
2023-11-29 13:00:57 -05:00
Ian Lynagh
429c550151
Kotlin 2: Accept some location changes
2023-11-28 15:57:48 +00:00
Eric Bickle
aab7ff919e
Java: Improve Gson parse, get, and stream models
2023-11-27 12:26:28 -08:00
amammad
ffe2e398c9
fix tests, add support for Response.BodyWriter() Thanks to @owen-mc
2023-11-25 15:36:37 +01:00
amammad
accc09fd8c
Lists of strings should be in alphabetical order. In a QLDoc, there should be a full stop at the end of each sentence. shorter model summary. change target from getACall() to getACall().getResult(.). better tests
2023-11-25 13:36:06 +01:00
amammad
48a9b107b9
add query to detect strapi CVe too
2023-11-24 10:47:17 +01:00
amammad
1aa4494dbc
stash
2023-11-24 10:09:21 +01:00
Maiky
6739750d2a
Add Unsafe Unpacking Query (CWE-022)
2023-11-23 12:48:33 +01:00
amammad
2097a001b9
apply code review suggestions, fix qldoc, add experimental additional taint steps that can improve performance
2023-11-22 10:01:51 +01:00
amammad
5cc4206e00
add a temporary Query file to demonstrate unsuccessful usage of two DataFlow configs
2023-11-22 08:30:59 +01:00
Owen Mansel-Chan
b147bacd48
Merge branch 'main' into amammad-go-fastHttp
2023-11-21 21:36:11 +00:00
amammad
fabde6e0ff
fix tests and remove tarfile tar.Reader as sink
2023-11-21 20:54:38 +01:00
amammad
75e01d3648
Thanks to @owen-mc that provided a good solution of that I couldn't solve that myself
2023-11-21 20:15:27 +01:00
amammad
2ad59a5403
fix SSRF sinks
2023-11-21 18:46:35 +01:00
amammad
c361caf0b0
fix tests for FileSystemAccess, add comments for adding some functions in future, remove old comments
2023-11-08 14:15:26 +01:00
amammad
0652afced3
update tests, updated qldoc and examples, upgrade all libraries to path-problem, update jsonwebtoken source and sinks
2023-11-07 08:25:25 +01:00
amammad
f58462bee9
fix tests
2023-11-07 06:32:15 +01:00
Jorge
b08d57a85f
Add {{! to TEMPLATE_EXPR_OPENING_TAG
2023-11-06 20:40:00 +00:00
amammad
b8c800608e
add an extended Class of string for FlowState
2023-11-06 11:01:01 +01:00
amammad
7af4b8de7b
fix isBarrier according to code review
2023-11-06 10:58:00 +01:00
amammad
e421c49440
fix multipart mistake :(
2023-11-06 10:53:52 +01:00
amammad
0d670f81fb
fix type assertion errors and create more source()s for better tests
2023-11-06 10:39:30 +01:00
amammad
ea40081204
Merge branch 'amammad-go-fastHttp' of https://github.com/amammad/codeql into amammad-go-fastHttp
2023-11-06 10:38:18 +01:00
amammad
2624f365c3
update inline flow tests of AddittionalTaintSteps
2023-11-05 17:49:32 +03:30
amammad
88e75a6ec8
add flow summary instead of additional flow steps
2023-11-05 17:49:32 +03:30
amammad
23f7f9a24a
fix some grammer mistakes, an unnecessary import, put blank like after go generate
2023-11-05 17:49:32 +03:30
amammad
2f86c2588b
fix autoformatting
2023-11-05 17:49:32 +03:30
amammad
56bcbf3a41
add additional taint steps to SSRF query
2023-11-05 17:49:32 +03:30
amammad
e38cb0f36e
fix a issue in fasthttp library, add SSRF inline queires
2023-11-05 17:49:32 +03:30
amammad
7bc07d959b
add additional taint steps inline tests
2023-11-05 17:49:32 +03:30
amammad
3bc24c3534
add inline tests for open redirect,xss, fix some issues in fasthttp.qll
2023-11-05 17:49:32 +03:30
amammad
29219922ac
add inline tests for UntrustedFlowSource, and fix some not necessarily flow sources
2023-11-05 17:49:32 +03:30
amammad
defe964f3a
update tests
2023-11-05 17:49:32 +03:30
amammad
5232d28617
fix a mistake: replaces tests after gofmt
2023-11-05 17:49:32 +03:30
amammad
c6acb1012c
perfomed gofmt on fasthttp.go
2023-11-05 17:49:32 +03:30
amammad
1ff1c5cfe0
fix two bugs, make package path more neat
2023-11-05 17:49:32 +03:30
amammad
345fdf12e5
added the go generate commands for depstubber
2023-11-05 17:49:32 +03:30
amammad
2048d8945b
fix qldoc and tests
2023-11-05 17:49:32 +03:30
amammad
8aba71f678
upgrade tests
2023-11-05 17:49:32 +03:30
amammad
1c657a62c1
fix stub
2023-11-05 17:49:32 +03:30
amammad
de391ffa4d
fix qlDOC one missed mistake
2023-11-05 17:49:32 +03:30
amammad
b7ef215504
fix change notes
2023-11-05 17:49:32 +03:30
amammad
693539a604
fix qhelps
2023-11-05 17:49:32 +03:30
amammad
2ac906395f
fix tests
2023-11-05 17:49:32 +03:30
amammad
1fc7758dfb
add change note
2023-11-05 17:49:32 +03:30
amammad
80e5fb81bc
fix library-tests
2023-11-05 17:49:32 +03:30
amammad
2ee2ac383d
fix some mistakes:(
2023-11-05 17:49:32 +03:30
amammad
377d1f55be
add proper test cases
2023-11-05 17:49:32 +03:30
amammad
543684904f
fix go.mod
2023-11-05 17:49:32 +03:30
amammad
c25bb3cde0
remove tmp test
2023-11-05 17:49:32 +03:30
amammad
3226184547
add tests
2023-11-05 17:49:32 +03:30
amammad
cddd27c5f8
V1
2023-11-05 17:49:32 +03:30
amammad
d1926f9061
update inline flow tests of AddittionalTaintSteps
2023-11-05 15:17:06 +01:00
amammad
bd1ee9b937
fix tests
2023-11-02 21:26:05 +01:00
amammad
1fc18bee5d
Merge branch 'main' into amammad-go-bombs
2023-11-02 23:33:27 +03:30
amammad
a1a49bdddf
Merge branch 'main' into amammad-go-bombs
2023-11-02 21:01:13 +01:00
amammad
761aede2df
perfomed review suggestions, make Decompression Sink simpler, uncomment the isBarrier, fix some naming issues in tests
2023-11-02 21:01:05 +01:00
amammad
9f8871746b
add flow summary instead of additional flow steps
2023-11-02 20:12:50 +01:00
amammad
fc3b90915b
fix some grammer mistakes, an unnecessary import, put blank like after go generate
2023-11-02 17:29:11 +01:00
amammad
a9c8bc082f
delete CWE-321
2023-11-02 16:27:31 +01:00
amammad
faa483a282
move to CWE-347, update comments of tests
2023-11-02 16:24:58 +01:00
amammad
9da815a5c0
move to new CWE-321 directory, make saparate query files for each JWT pkg, create a path query for jsonwebtoken package which is not work correctly
2023-11-02 14:13:52 +01:00
Chad Bentz
53e96e5adf
Merge branch 'main' into patch-1
2023-10-25 10:00:16 -04:00
Maiky
d8aa0e2d7e
Remove unnecessary import
2023-10-21 17:29:08 +02:00
Maiky
35d390ad06
Add Insecure Randomness Query (CWE-338)
2023-10-21 17:23:41 +02:00
Peter Stöckli
09cf76a880
Ruby: additional unsafe deserialization sinks for ox, oj
2023-10-19 14:04:48 +02:00
amammad
ee4d87bd96
remove hardcoded JWT secret-key query
2023-10-19 11:57:53 +02:00
amammad
2e4e5ef480
fix a comment
2023-10-17 10:42:40 +02:00
amammad
7891e64d3e
add sanitizers to hardcoded query
2023-10-17 10:37:27 +02:00
amammad
9d4a16750c
fix autoformatting
2023-10-17 01:02:16 +02:00
amammad
b3be2a4929
add additional taint steps to SSRF query
2023-10-17 01:00:25 +02:00
amammad
3899f2cdf3
upgrade execa scripts
2023-10-12 10:44:57 +02:00
amammad
cc1b8b2e02
fix a issue in fasthttp library, add SSRF inline queires
2023-10-12 09:55:14 +02:00
amammad
b5c4b5e482
add additional taint steps inline tests
2023-10-12 09:45:25 +02:00
amammad
acee50c9df
add inline tests for open redirect,xss, fix some issues in fasthttp.qll
2023-10-12 09:10:16 +02:00
amammad
720565f442
add inline tests for UntrustedFlowSource, and fix some not necessarily flow sources
2023-10-12 08:32:33 +02:00
amammad
ac5e9c75e1
fix a mistake: remove vendor dir from go root directory
2023-10-12 08:06:45 +02:00
amammad
3926fd7333
update tests
2023-10-11 19:27:57 +02:00
amammad
7d60f03131
fix tests
2023-10-11 18:04:35 +02:00
amammad
8e5be13466
fix conflict
2023-10-11 18:02:55 +02:00
amammad
261cabde67
better comments
2023-10-11 17:44:12 +02:00
amammad
b24c6fd579
for demonstration
2023-10-11 17:34:33 +02:00
amammad
46616d6b42
fix a qldoc isuse
2023-10-11 14:53:08 +02:00
amammad
de2ee4d289
stash I can't especify the argument and command differences with new API
2023-10-11 14:36:56 +02:00
amammad
4cd3618dcd
Merge branch 'main' into amammad-js-CodeInjection_execa
2023-10-11 13:27:26 +02:00
amammad
c630300374
fix a tests
2023-10-11 13:18:55 +02:00
amammad
d63b33bb08
fix a tests
2023-10-11 13:16:30 +02:00
amammad
8768eb64e6
Merge branch 'amammad-ruby-bombs' of https://github.com/amammad/codeql into amammad-ruby-bombs
2023-10-11 12:40:03 +02:00
amammad
609bb762fe
fix a bug,modularize
2023-10-11 12:04:11 +02:00
amammad
90017712a6
Merge remote-tracking branch 'origin/main' into amammad-ruby-bombs
2023-10-11 10:45:16 +02:00
amammad
32859eb057
move to experimental
2023-10-10 22:46:44 +02:00
amammad
14d1e08051
reformat
2023-10-10 22:34:26 +02:00
amammad
4198f61c16
fix a qldoc isuse
2023-10-10 22:21:43 +02:00
amammad
6f73e9c3ba
revert for in additional steps
2023-10-10 22:12:37 +02:00
amammad
9053ceb3b7
revert a unexpected test file
2023-10-10 21:37:59 +02:00
amammad
e13050b64e
revert a unexpected test file
2023-10-10 21:35:52 +02:00
amammad
4283bb7d48
clean up unused vars,fix tests
2023-10-09 23:15:58 +02:00
amammad
9d86e7946c
move library file to experimental lib directory
2023-10-09 23:10:30 +02:00
amammad
1318afdb27
modularize
2023-10-09 23:07:52 +02:00
amammad
3175db226e
upgrade fastAPI remote sources
2023-10-09 20:51:19 +02:00
amammad
3f41a42c38
remove unused classes
2023-10-08 11:08:05 +02:00
amammad
15671682c5
remove unused flowLable, update path query alert message
2023-10-08 11:06:13 +02:00
amammad
00b6e1f0b0
fix tests
2023-10-08 11:03:19 +02:00
amammad
41e7b91d78
fix flowLabels
2023-10-08 11:00:07 +02:00
amammad
6789273ab1
remove a test predicate
2023-10-07 12:05:44 +02:00
amammad
aff6f00450
comments improvement,separate module file, fix tests
2023-10-07 12:02:39 +02:00
Marcono1234
b8f6877aba
Merge branch 'main' into patch-1
2023-10-07 03:46:12 +02:00
amammad
13577f71d6
fix tests, add more comments
2023-10-06 22:34:31 +02:00
amammad
5a49f6bb9b
fix tests
2023-10-06 22:10:57 +02:00
amammad
f5efddc011
comments improvement
2023-10-06 21:12:59 +02:00
amammad
e45268cd4d
improve and fix bugs and add Form Flow Sources test files
2023-10-06 21:01:42 +02:00
amammad
21f477a674
revert go/vendor/ :(
2023-10-06 19:39:18 +02:00
amammad
d4b2ca5cee
add vendor for tests, update test results, revert go/vendor/modules.txt :(
2023-10-06 19:34:13 +02:00
amammad
31cae204f6
make DecompressionBombs module and extention points
2023-10-06 18:14:05 +02:00
Ian Lynagh
d34b85cf03
Kotlin: Remove 1.4 compatibility
...
We now only build with >= 1.5
2023-10-06 15:17:32 +01:00
amammad
5bc21a6178
delete old tests
2023-10-06 16:09:05 +02:00
amammad
7d961e1af2
do review improvements
2023-10-06 16:07:10 +02:00
amammad
eef8137166
add Dice package, add global taint steps by SharedTaintStep, use getASuccessor
2023-10-06 10:58:26 +02:00
amammad
faaddd4dfe
updates for FormParsers and ReadableStream modules, add separate module for Readable Streams, BusBoy RemoteFlowSources is covering more sources now!, modularize
2023-10-05 21:46:58 +02:00
amammad
e81a4fc330
remove CLI sources Library file and local sources for lower FPs
2023-10-01 05:44:13 +10:00
amammad
00d1b11b0b
chore fix document example
2023-10-01 02:45:51 +10:00
amammad
d99c0a2382
update tests
2023-10-01 02:25:38 +10:00
amammad
9245e1c2a4
remove CLI sources Library file & qldoc warnings
2023-10-01 00:37:56 +10:00
amammad
8ef969fcb9
fix a mistake: replaces tests after gofmt
2023-09-30 22:16:59 +10:00
amammad
2961b79fb9
add multipart sources
2023-09-30 03:09:02 +10:00
amammad
2e7529cc70
remove local sources
2023-09-30 02:41:47 +10:00
amammad
e3c89011a9
perfomed gofmt on fasthttp.go
2023-09-29 00:57:17 +10:00
amammad
f41bc1f631
revert nodeJSLib
2023-09-28 20:37:21 +10:00
amammad
75f0fc4a98
fix a mistake
2023-09-28 20:34:58 +10:00
amammad
921198ed30
add separate query for sinks that accepts data: URL
2023-09-28 20:33:38 +10:00
amammad
f2505eada8
fix two bugs, make package path more neat
2023-09-27 23:35:56 +10:00
amammad
32f41de3be
Merge branch 'main' into amammad-go-fastHttp
2023-09-27 23:33:51 +10:00
amammad
bb30689a6e
added the go generate commands for depstubber
2023-09-27 06:41:09 +10:00
amammad
ad999a0174
fix qldoc and tests
2023-09-27 04:21:49 +10:00
amammad
c3213e4de3
upgrade tests
2023-09-26 00:02:45 +10:00
amammad
c1398f2b60
fix stub
2023-09-25 21:48:10 +10:00
amammad
875817222c
fix qlDOC one missed mistake
2023-09-25 21:20:33 +10:00
amammad
f6737b3d90
fix FP
2023-09-25 21:09:19 +10:00
amammad
2c74dc23c9
add second order command execution sinks to tests
2023-09-22 20:00:36 +10:00
amammad
344869f0d7
change commandExecution sink to CodeInjection sink
2023-09-22 19:37:17 +10:00
amammad
a20ca78599
V1
2023-09-22 19:23:34 +10:00
amammad
f1a7f0a7e8
V1
2023-09-22 19:21:41 +10:00
amammad
06114d91d8
V1
2023-09-22 19:19:52 +10:00
amammad
69c2d9ed5c
fix change notes
2023-09-19 22:24:52 +10:00
amammad
3585459548
fix qhelps
2023-09-19 06:17:31 +10:00
amammad
a6996c5d21
fix tests
2023-09-19 03:48:31 +10:00
amammad
c195a9f05d
Merge branch 'main' into amammad-go-fastHttp
2023-09-19 03:07:27 +10:00
amammad
6f5aa58d82
add change note
2023-09-18 23:38:32 +10:00
amammad
09aee3081e
fix library-tests
2023-09-18 23:29:45 +10:00
amammad
e1d5c9d45b
fix grammar mistake
2023-09-15 06:32:23 +10:00
amammad
5a3a8d781a
fix some flowstate bug which Had caused to FP
2023-09-15 02:09:40 +10:00
amammad
08f78a2df4
fix some flowstate bug which Had caused to FP
2023-09-15 01:56:46 +10:00
amammad
0d3b944207
fix some mistakes:(
2023-09-14 23:39:28 +10:00
amammad
d44c9d3e74
stash
2023-09-08 05:51:21 +10:00
amammad
905fa10c88
Merge branch 'github:main' into amammad-ruby-bombs
2023-09-07 20:41:45 +10:00
amammad
6ee5865789
add sources to detect CVE completely
2023-09-07 18:27:40 +10:00
amammad
0f540f4c25
add sources to detect CVE completely
2023-09-07 18:25:48 +10:00
amammad
f6f99fb459
remove parameter as source
2023-09-07 17:47:55 +10:00
amammad
bcfc28aae0
add sources to detect CVE completely
2023-09-07 02:02:32 +10:00
amammad
4191b07b1f
Merge branch 'github:main' into amammad-ruby-bombs
2023-09-06 20:17:49 +10:00
amammad
c76d0d364d
fix a mistake ioutil => io/ioutil
2023-09-06 03:38:06 +10:00
amammad
b5a257ca7c
add proper test cases
2023-09-03 04:09:56 +10:00
amammad
8f11543e9d
fix go.mod
2023-09-02 22:47:35 +10:00
amammad
9b8f43bf63
remove tmp test
2023-09-02 22:41:39 +10:00
amammad
6af82526dc
add tests
2023-09-02 22:40:18 +10:00
amammad
a8a9edcacd
V1
2023-09-02 22:27:08 +10:00
amammad
77dcd68a86
v2
2023-08-31 21:26:25 +10:00
amammad
7a577ddd98
change Source to ConstantString, it seems that we have some duplicate results now, ConstantString is suggested as a better alternative for finding constant sources
2023-08-30 20:47:43 +10:00
amammad
d06444e639
upgrade additional steps
2023-08-30 05:03:19 +10:00
amammad
369bc50709
fix comments
2023-08-30 04:53:58 +10:00
amammad
3f64cc82eb
fix qhelps
2023-08-29 22:42:21 +10:00
amammad
4f04dc8f6e
add test cases
2023-08-29 21:34:02 +10:00
amammad
65b97745c2
V1
2023-08-29 21:23:02 +10:00
Chad Bentz
6f60eb9e1a
Merge branch 'main' into patch-1
2023-08-09 14:31:26 -04:00
amammad
f79bd2a071
added remote flow sources related to multipart upload, added flag package command line source
2023-08-06 06:49:35 +10:00
Chad Bentz
845f384df6
Merge branch 'main' into patch-1
2023-08-04 17:57:53 -04:00
Asger F
213cabccc0
JS: Test with file more extensions
2023-08-04 14:24:51 +02:00
Asger F
ea2ddf8905
JS: Do not parse the initial ! or = as part of the template expression
2023-08-04 14:24:38 +02:00
Kevin Stubbings
a36a555b7a
Quick change
2023-08-04 00:59:28 -07:00
Kevin Stubbings
9f4389cbb5
Search for html.dot extension instead of dot
2023-08-04 00:55:51 -07:00
amammad
7ce825c5ea
convert to module based dataflow
2023-07-31 22:43:45 +10:00
amammad
ab7e797fff
it seems that I must use both isSink and isSource with flow states!
2023-07-31 20:00:59 +10:00
amammad
26f1091d5f
fix a mistake :(
2023-07-31 19:48:21 +10:00
amammad
56d0254d2b
fix ReadAll argumrnt number
2023-07-31 19:37:28 +10:00
amammad
4ee54738fa
fix a mistake :(
2023-07-31 19:36:21 +10:00
amammad
260c111932
put comment about detecting https://github.com/advisories/GHSA-jpxj-2jvg-6jv9
2023-07-31 19:32:22 +10:00
amammad
1b598c8683
v1.2 make better sinks
2023-07-31 19:26:18 +10:00
amammad
f1918fb4e0
v1.1
2023-07-31 05:11:09 +10:00
Marcono1234
09fa2a7d50
Move imports to usage sections
2023-07-15 16:59:46 +02:00
Marcono1234
94e9848d61
Mention needed imports at top of "Analyzing data flow in Java"
...
Currently the guide just starts using the classes from these libraries
without having mentioned that you have to import the libraries first.
2023-07-08 18:56:37 +02:00
jorgectf
f1f3d8e18a
Add dot.jssupport
...
Co-authored-by: Kevin Stubbings <Kwstubbs@users.noreply.github.com >
2023-06-29 19:17:37 +02:00
amammad
7aa002fa2a
fix an accident :)
2023-06-29 22:20:46 +10:00
amammad
516fdf627a
update stream pipe
2023-06-28 00:09:39 +10:00
amammad
c7a7594821
merge all ql files into one
2023-06-27 01:56:23 +10:00
amammad
37af588492
update CVE instance in qhelp
2023-06-26 21:16:16 +10:00
amammad
9540c58c4a
make one ql file
2023-06-26 20:55:11 +10:00
amammad
8a80a734d8
fix an accident :)
2023-06-26 20:20:00 +10:00
amammad
9e33b47cbd
added more additional steps
2023-06-26 17:46:22 +10:00
amammad
e2fe0e11f0
fix formatting error/warnings
2023-06-26 17:14:46 +10:00
amammad
8fccd65d34
fix a mistake :(
2023-06-26 16:51:14 +10:00
amammad
b506b7d298
better documents, remove separate PyZipFile
2023-06-26 16:50:33 +10:00
amammad
a38405e490
fix formatting error/warnings
2023-06-26 16:43:18 +10:00
amammad
3bd45a8536
fix query identifier
2023-06-26 03:01:19 +10:00
amammad
effb8024a4
fix yargs bug
2023-06-25 23:30:24 +10:00
amammad
c16a2827d7
fix format warnings/errors
2023-06-25 23:24:12 +10:00
amammad
fbfc959f82
V1 Bombs
2023-06-25 01:21:09 +10:00
amammad
796075f9dc
V1 Bombs
2023-06-25 00:59:21 +10:00
amammad
307187f6c1
V1
2023-06-23 06:06:37 +10:00
amammad
748e96d852
V1 Bombs
2023-06-22 19:28:27 +10:00
Chad Bentz
39c52c9ecf
add security-severity to code scanning query list
2023-03-16 11:27:23 -04:00