mirror of
https://github.com/github/codeql.git
synced 2026-04-25 08:45:14 +02:00
Ruby: Add URI.open example to rb/kernel-open qhelp
This commit is contained in:
@@ -1,6 +1,9 @@
|
||||
class UsersController < ActionController::Base
|
||||
def create
|
||||
filename = params[:filename]
|
||||
File.open(filename)
|
||||
end
|
||||
end
|
||||
def create
|
||||
filename = params[:filename]
|
||||
File.open(filename)
|
||||
|
||||
web_page = params[:web_page]
|
||||
Net::HTTP.get(URI.parse(web_page))
|
||||
end
|
||||
end
|
||||
|
||||
@@ -1,6 +1,11 @@
|
||||
require "open-uri"
|
||||
|
||||
class UsersController < ActionController::Base
|
||||
def create
|
||||
filename = params[:filename]
|
||||
open(filename) # BAD
|
||||
|
||||
web_page = params[:web_page]
|
||||
URI.open(web_page) # BAD - calls `Kernel.open` internally
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user