hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 01:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Address (my own) review comments.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2024-04-16 13:53:27 +01:00
parent 8a92a4250f
commit 132bb9f1d6
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
cpp/ql/src/Critical/GlobalUseBeforeInit.ql
View File

@@ -98,16 +98,11 @@ predicate callReaches(Call call, ControlFlowNode successor) {
)
}
// To avoid many false alarms like `static int a = 1;`
predicate initialisedAtDeclaration(GlobalVariable v) {
exists(VariableDeclarationEntry vde |
vde = v.getDefinition() and
vde.isDefinition()
)
}
/** Holds if `v` has an initializer. */
predicate initialisedAtDeclaration(GlobalVariable v) { exists(v.getInitializer()) }
// No need to initialize those variables
predicate isStdlibVariable(GlobalVariable v) { v.getName() = ["stdin", "stdout", "stderr"] }
/** Holds if `v` is a global variable that does not need to be initialized. */
predicate isStdlibVariable(GlobalVariable v) { v.hasGlobalName(["stdin", "stdout", "stderr"]) }
from GlobalVariable v, Function f
where