hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 10:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Environment variable sources

Browse Source
This commit is contained in:
Ed Minnix
2024-01-25 11:36:03 -05:00
parent b0eb0e1f1e
commit 51afe12ae1
5 changed files with 50 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
csharp/ql/lib/ext/System.model.yml
View File

@@ -6,6 +6,9 @@ extensions:
- ["System", "Console", False, "Read", "", "", "ReturnValue", "local", "manual"]
- ["System", "Console", False, "ReadKey", "", "", "ReturnValue", "local", "manual"]
- ["System", "Console", False, "ReadLine", "", "", "ReturnValue", "local", "manual"]
- ["System", "Environment", False, "ExpandEnvironmentVariables", "", "", "ReturnValue", "environment", "manual"]
- ["System", "Environment", False, "GetEnvironmentVariable", "", "", "ReturnValue", "environment", "manual"]
- ["System", "Environment", False, "GetEnvironmentVariables", "", "", "ReturnValue", "environment", "manual"]
- addsTo:
pack: codeql/csharp-all
extensible: summaryModel

7
csharp/ql/lib/semmle/code/csharp/security/dataflow/flowsources/Local.qll
View File

@@ -29,3 +29,10 @@ class TextFieldSource extends LocalUserInputSource {
override string getSourceType() { result = "TextBox text" }
}
abstract class EnvironmentVariableSource extends LocalFlowSource {
override string getThreatModel() { result = "environment" }
override string getSourceType() { result = "environment variable" }
}

27
csharp/ql/test/library-tests/dataflow/flowsources/local/environment/EnvironmentVariables.cs Normal file
View File

@@ -0,0 +1,27 @@
using System;
using System.Collections;
namespace EnvironmentVariables
{
class EnvironmentVariables
{
public static void GetEnvironmentVariable(string environmnetVariable)
{
string value = Environment.GetEnvironmentVariable(environmnetVariable);
string valueFromRegistry = Environment.GetEnvironmentVariable(environmnetVariable, EnvironmentVariableTarget.Machine);
string valueFromProcess = Environment.GetEnvironmentVariable(environmnetVariable, EnvironmentVariableTarget.Process);
}
public static void GetEnvironmentVariables()
{
IDictionary environmentVariables = Environment.GetEnvironmentVariables();
IDictionary environmentVariablesFromRegistry = Environment.GetEnvironmentVariables(EnvironmentVariableTarget.Machine);
IDictionary environmentVariablesFromProcess = Environment.GetEnvironmentVariables(EnvironmentVariableTarget.Process);
}
public static void ExpandEnvironmentVariables(string environmentVariable)
{
string expanded = Environment.ExpandEnvironmentVariables("%PATH%");
}
}
}

7
csharp/ql/test/library-tests/dataflow/flowsources/local/environment/EnvironmentVariables.expected Normal file
View File

@@ -0,0 +1,7 @@
| EnvironmentVariables.cs:10:28:10:82 | call to method GetEnvironmentVariable |
| EnvironmentVariables.cs:11:40:11:129 | call to method GetEnvironmentVariable |
| EnvironmentVariables.cs:12:39:12:128 | call to method GetEnvironmentVariable |
| EnvironmentVariables.cs:17:48:17:84 | call to method GetEnvironmentVariables |
| EnvironmentVariables.cs:18:60:18:129 | call to method GetEnvironmentVariables |
| EnvironmentVariables.cs:19:59:19:128 | call to method GetEnvironmentVariables |
| EnvironmentVariables.cs:24:31:24:78 | call to method ExpandEnvironmentVariables |

6
csharp/ql/test/library-tests/dataflow/flowsources/local/environment/EnvironmentVariables.ql Normal file
View File

@@ -0,0 +1,6 @@
import csharp
import semmle.code.csharp.dataflow.internal.ExternalFlow
from DataFlow::Node source
where sourceNode(source, "environment")
select source