hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 08:45:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Code quality improvement

Browse Source
This commit is contained in:
Tamas Vajk
2024-03-21 11:26:45 +01:00
parent d0c09f43a9
commit 9d655520cc
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
csharp/ql/src/API Abuse/IncorrectCompareToSignature.ql
View File

@@ -33,12 +33,13 @@ predicate compareToMethod(Method m, Type paramType) {
paramType = m.getAParameter().getType()
}
from Method m, RefType declaringType, Type actualParamType
from Method m, RefType declaringType, Type actualParamType, string paramTypeName
where
m.isSourceDeclaration() and
declaringType = m.getDeclaringType() and
compareToMethod(m, actualParamType) and
not implementsIComparable(declaringType, actualParamType)
not implementsIComparable(declaringType, actualParamType) and
paramTypeName = actualParamType.getName()
select m,
"The parameter of this 'CompareTo' method is of type '" + actualParamType.getName() +
"', but the declaring type does not implement 'IComparable<" + actualParamType.getName() + ">'."
"The parameter of this 'CompareTo' method is of type '" + paramTypeName +
"', but the declaring type does not implement 'IComparable<" + paramTypeName + ">'."