hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-24 08:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Dataflow: Share getCallContextCall in DataFlowImplCommon::CallContextSensitivity.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2024-05-01 15:08:25 +02:00
parent b2e3d784f6
commit ace369faa8
2 changed files with 37 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
View File

@@ -2558,10 +2558,6 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
bindingset[call, ctx]
predicate noPrunedViableImplInCallContext(DataFlowCall call, CallContext ctx);
predicate recordDataFlowCallSiteDispatch(DataFlowCall call, DataFlowCallable callable);
predicate recordDataFlowCallSiteUnreachable(DataFlowCall call, DataFlowCallable callable);
predicate reducedViableImplInReturn(DataFlowCallable c, DataFlowCall call);
DataFlowCall prunedViableImplInCallContextReverse(
@@ -2592,38 +2588,6 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
Input::noPrunedViableImplInCallContext(call, ctx)
}
module NoLocalCallContext {
class LocalCc = Unit;
bindingset[c, cc]
LocalCc getLocalCc(DataFlowCallable c, Cc cc) { any() }
bindingset[call, c]
CcCall getCallContextCall(DataFlowCall call, DataFlowCallable c) {
if Input::recordDataFlowCallSiteDispatch(call, c)
then result = TSpecificCall(call)
else result = TSomeCall()
}
}
module LocalCallContext {
class LocalCc = LocalCallContext;
bindingset[c, cc]
LocalCc getLocalCc(DataFlowCallable c, Cc cc) {
result = getLocalCallContext(pragma[only_bind_into](pragma[only_bind_out](cc)), c)
}
bindingset[call, c]
CcCall getCallContextCall(DataFlowCall call, DataFlowCallable c) {
if
Input::recordDataFlowCallSiteDispatch(call, c) or
Input::recordDataFlowCallSiteUnreachable(call, c)
then result = TSpecificCall(call)
else result = TSomeCall()
}
}
DataFlowCall viableImplCallContextReducedReverse(DataFlowCallable c, CcNoCall ctx) {
result = Input::prunedViableImplInCallContextReverse(c, ctx)
}
@@ -4323,6 +4287,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
}
import CallContextSensitivity<CallContextSensitivityInput>
import LocalCallContext
}
pragma[nomagic]
@@ -4421,11 +4386,8 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
// never any reason to enter a callable except to find a summary. See also
// the comment in `PathNodeMid::isAtSink`.
not Config::getAFeature() instanceof FeatureEqualSourceSinkCallContext
)
|
if PrunedCallContextSensitivityStage5::recordDataFlowCallSite(call, callable)
then innercc = TSpecificCall(call)
else innercc = TSomeCall()
) and
innercc = PrunedCallContextSensitivityStage5::getCallContextCall(call, callable)
)
}
@@ -5454,11 +5416,9 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
sc1 = TSummaryCtx1Param(p) and
sc2 = TSummaryCtx2Some(state) and
sc3 = TSummaryCtx3Some(t) and
sc4 = TSummaryCtx4Some(ap)
|
if CachedCallContextSensitivity::recordDataFlowCallSite(call, callable)
then innercc = TSpecificCall(call)
else innercc = TSomeCall()
sc4 = TSummaryCtx4Some(ap) and
innercc =
CachedCallContextSensitivity::LocalCallContext::getCallContextCall(call, callable)
)
}

32
shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll
View File

@@ -615,7 +615,7 @@ module MakeImplCommon<LocationSig Location, InputSig<Location> Lang> {
* Holds if the call context `call` improves virtual dispatch in `callable`.
*/
pragma[nomagic]
predicate recordDataFlowCallSiteDispatch(DataFlowCall call, DataFlowCallable callable) {
private predicate recordDataFlowCallSiteDispatch(DataFlowCall call, DataFlowCallable callable) {
Input2::reducedViableImplInCallContext(_, callable, call)
}
@@ -627,6 +627,36 @@ module MakeImplCommon<LocationSig Location, InputSig<Location> Lang> {
Input2::recordDataFlowCallSiteUnreachable(call, c) or
recordDataFlowCallSiteDispatch(call, c)
}
module NoLocalCallContext {
class LocalCc = Unit;
bindingset[c, cc]
LocalCc getLocalCc(DataFlowCallable c, CallContext cc) { any() }
bindingset[call, c]
CallContextCall getCallContextCall(DataFlowCall call, DataFlowCallable c) {
if recordDataFlowCallSiteDispatch(call, c)
then result = TSpecificCall(call)
else result = TSomeCall()
}
}
module LocalCallContext {
class LocalCc = LocalCallContext;
bindingset[c, cc]
LocalCc getLocalCc(DataFlowCallable c, CallContext cc) {
result = getLocalCallContext(pragma[only_bind_into](pragma[only_bind_out](cc)), c)
}
bindingset[call, c]
CallContextCall getCallContextCall(DataFlowCall call, DataFlowCallable c) {
if recordDataFlowCallSite(call, c)
then result = TSpecificCall(call)
else result = TSomeCall()
}
}
}
private predicate reducedViableImplInCallContextAlias = reducedViableImplInCallContext/3;