hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 02:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Go: Avoid extra loop to track unsuccessfulProjects

Browse Source
This commit is contained in:
Michael B. Gale
2024-03-04 10:45:09 +00:00
parent 020eb4aed7
commit 8055c5d9e3
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
go/extractor/cli/go-autobuilder/go-autobuilder.go
View File

@@ -603,6 +603,9 @@ func installDependenciesAndBuild() {
}
}
// Track all projects which could not be extracted successfully
var unsuccessfulProjects = []string{}
// Attempt to extract all workspaces; we will tolerate individual extraction failures here
for i, workspace := range workspaces {
goVersionInfo := workspace.RequiredGoVersion()
@@ -639,13 +642,8 @@ func installDependenciesAndBuild() {
}
workspaces[i].Extracted = extract(workspace)
}
// Find all projects which could not be extracted successfully
var unsuccessfulProjects = []string{}
for _, workspace := range workspaces {
if !workspace.Extracted {
if !workspaces[i].Extracted {
unsuccessfulProjects = append(unsuccessfulProjects, workspace.BaseDir)
}
}