hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 00:35:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

Improve stringification of some erroneous expressions

Browse Source
This commit is contained in:
Chris Smowton
2024-02-27 16:33:19 +00:00
parent 6c8105fd1c
commit 1fd459e8fc
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
java/ql/lib/semmle/code/java/Expr.qll
View File

@@ -2065,7 +2065,11 @@ class MethodCall extends Expr, Call, @methodaccess {
override Stmt getEnclosingStmt() { result = Expr.super.getEnclosingStmt() }
/** Gets a printable representation of this expression. */
override string toString() { result = this.printAccess() }
override string toString() {
if exists(this.getMethod())
then result = this.printAccess()
else result = "<Call to unknown method>"
}
/** Gets a printable representation of this expression. */
string printAccess() { result = this.getMethod().getName() + "(...)" }
@@ -2128,13 +2132,19 @@ class TypeAccess extends Expr, Annotatable, @typeaccess {
/** Gets the compilation unit in which this type access occurs. */
override CompilationUnit getCompilationUnit() { result = Expr.super.getCompilationUnit() }
/** Gets a printable representation of this expression. */
override string toString() {
string toNormalString() {
result = this.getQualifier().toString() + "." + this.getType().toString()
or
not this.hasQualifier() and result = this.getType().toString()
}
/** Gets a printable representation of this expression. */
override string toString() {
if this.getType() instanceof ErrorType
then result = "<TypeAccess of ErrorType>"
else result = this.toNormalString()
}
override string getAPrimaryQlClass() { result = "TypeAccess" }
}