hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-20 14:34:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

Swift: Address QL-for-QL alerts.

Browse Source
This commit is contained in:
Geoffrey White
2023-12-15 14:42:47 +00:00
parent 034daa9b35
commit 0b04e4abe5
3 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
swift/ql/lib/codeql/swift/security/WeakPasswordHashingExtensions.qll
View File

@@ -42,9 +42,8 @@ class WeakPasswordHashingAdditionalFlowStep extends Unit {
* for the weak sensitive data hashing query is a sink for weak password
* hashing as well.
*/
private class InheritedWeakPasswordHashingSink extends WeakPasswordHashingSink {
InheritedWeakPasswordHashingSink() { this instanceof WeakSensitiveDataHashingSink }
private class InheritedWeakPasswordHashingSink extends WeakPasswordHashingSink instanceof WeakSensitiveDataHashingSink
{
override string getAlgorithm() { result = this.(WeakSensitiveDataHashingSink).getAlgorithm() }
}

1
swift/ql/lib/codeql/swift/security/WeakPasswordHashingQuery.qll
View File

@@ -5,7 +5,6 @@
import swift
import codeql.swift.security.SensitiveExprs
import codeql.swift.dataflow.DataFlow
import codeql.swift.dataflow.TaintTracking
import codeql.swift.security.WeakPasswordHashingExtensions

2
swift/ql/src/queries/Security/CWE-328/WeakPasswordHashing.qhelp
View File

@@ -26,7 +26,7 @@
<strong>Brute force</strong>. If you know a hash value <code>h(x)</code>,
you should not be able to find an input <code>y</code> that computes to that hash value
using brute force attacks without significant computational effort.
<li>
</li>
</ul>
<p>