Merge pull request #15360 from github/mbg/csharp/redefine-successfully-extracted-files

csharp/ql/lib/change-notes/2024-01-17-csharp-successfully-extracted.md

@@ -0,0 +1,4 @@
+---
+category: minorAnalysis
+---
+* The diagnostic query `cs/diagnostics/successfully-extracted-files`, and therefore the Code Scanning UI measure of scanned C# files, now considers any C# file seen during extraction, even one with some errors, to be extracted / scanned.

csharp/ql/src/Diagnostics/ExtractedFiles.ql

@@ -1,5 +1,5 @@
 /**
- * @name Successfully extracted files
+ * @name Extracted files
  * @description A list of all files in the source code directory that were extracted
  *              without encountering an extraction or compiler error in the file.
  * @kind diagnostic
@@ -11,8 +11,5 @@ import csharp
 import semmle.code.csharp.commons.Diagnostics
 
 from File file
-where
-  file.fromSource() and
-  not exists(ExtractorError e | e.getLocation().getFile() = file) and
-  not exists(CompilerError e | e.getLocation().getFile() = file)
+where file.fromSource()
 select file, ""

csharp/ql/test/library-tests/diagnostics/DiagnosticNoExtractorErrors.expected

@@ -1 +0,0 @@
-| A.cs:0:0:0:0 | A.cs |  |

csharp/ql/test/library-tests/diagnostics/DiagnosticNoExtractorErrors.qlref

@@ -1 +0,0 @@
-Diagnostics/DiagnosticNoExtractionErrors.ql

csharp/ql/test/library-tests/diagnostics/ExtractedFiles.expected

@@ -0,0 +1,2 @@
+| A.cs:0:0:0:0 | A.cs |  |
+| Program.cs:0:0:0:0 | Program.cs |  |

csharp/ql/test/library-tests/diagnostics/ExtractedFiles.qlref

@@ -0,0 +1 @@
+Diagnostics/ExtractedFiles.ql