hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-22 07:15:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Add example of log forging alert for simple nullable types and updated expected test output.

Browse Source
This commit is contained in:
Michael Nebel
2024-01-18 12:50:40 +01:00
parent 696a72a127
commit 559842071a
2 changed files with 28 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
csharp/ql/test/query-tests/Security Features/CWE-117/LogForging.expected
View File

@@ -7,6 +7,8 @@ edges
| LogForging.cs:18:27:18:61 | access to indexer : String | LogForging.cs:29:50:29:72 | ... + ... |
| LogForging.cs:18:27:18:61 | access to indexer : String | LogForging.cs:33:26:33:33 | access to local variable username |
| LogForgingAsp.cs:8:32:8:39 | username : String | LogForgingAsp.cs:12:21:12:43 | ... + ... |
| LogForgingAsp.cs:22:35:22:38 | date : Nullable<DateTime> | LogForgingAsp.cs:28:25:28:68 | $"..." |
| LogForgingAsp.cs:32:31:32:31 | b : Nullable<Boolean> | LogForgingAsp.cs:38:25:38:54 | $"..." |
nodes
| LogForging.cs:18:27:18:49 | access to property QueryString : NameValueCollection | semmle.label | access to property QueryString : NameValueCollection |
| LogForging.cs:18:27:18:61 | access to indexer : String | semmle.label | access to indexer : String |
@@ -15,9 +17,15 @@ nodes
| LogForging.cs:33:26:33:33 | access to local variable username | semmle.label | access to local variable username |
| LogForgingAsp.cs:8:32:8:39 | username : String | semmle.label | username : String |
| LogForgingAsp.cs:12:21:12:43 | ... + ... | semmle.label | ... + ... |
| LogForgingAsp.cs:22:35:22:38 | date : Nullable<DateTime> | semmle.label | date : Nullable<DateTime> |
| LogForgingAsp.cs:28:25:28:68 | $"..." | semmle.label | $"..." |
| LogForgingAsp.cs:32:31:32:31 | b : Nullable<Boolean> | semmle.label | b : Nullable<Boolean> |
| LogForgingAsp.cs:38:25:38:54 | $"..." | semmle.label | $"..." |
subpaths
#select
| LogForging.cs:21:21:21:43 | ... + ... | LogForging.cs:18:27:18:49 | access to property QueryString : NameValueCollection | LogForging.cs:21:21:21:43 | ... + ... | This log entry depends on a $@. | LogForging.cs:18:27:18:49 | access to property QueryString | user-provided value |
| LogForging.cs:29:50:29:72 | ... + ... | LogForging.cs:18:27:18:49 | access to property QueryString : NameValueCollection | LogForging.cs:29:50:29:72 | ... + ... | This log entry depends on a $@. | LogForging.cs:18:27:18:49 | access to property QueryString | user-provided value |
| LogForging.cs:33:26:33:33 | access to local variable username | LogForging.cs:18:27:18:49 | access to property QueryString : NameValueCollection | LogForging.cs:33:26:33:33 | access to local variable username | This log entry depends on a $@. | LogForging.cs:18:27:18:49 | access to property QueryString | user-provided value |
| LogForgingAsp.cs:12:21:12:43 | ... + ... | LogForgingAsp.cs:8:32:8:39 | username : String | LogForgingAsp.cs:12:21:12:43 | ... + ... | This log entry depends on a $@. | LogForgingAsp.cs:8:32:8:39 | username | user-provided value |
| LogForgingAsp.cs:28:25:28:68 | $"..." | LogForgingAsp.cs:22:35:22:38 | date : Nullable<DateTime> | LogForgingAsp.cs:28:25:28:68 | $"..." | This log entry depends on a $@. | LogForgingAsp.cs:22:35:22:38 | date | user-provided value |
| LogForgingAsp.cs:38:25:38:54 | $"..." | LogForgingAsp.cs:32:31:32:31 | b : Nullable<Boolean> | LogForgingAsp.cs:38:25:38:54 | $"..." | This log entry depends on a $@. | LogForgingAsp.cs:32:31:32:31 | b | user-provided value |

20
csharp/ql/test/query-tests/Security Features/CWE-117/LogForgingAsp.cs
View File

@@ -18,4 +18,24 @@ public class AspController : ControllerBase
// GOOD: DateTime is a sanitizer.
logger.Warn($"Warning about the date: {date:yyyy-MM-dd}");
}
public void Action2(DateTime? date)
{
var logger = new ILogger();
if (date is not null)
{
// GOOD: DateTime? is a sanitizer.
logger.Warn($"Warning about the date: {date:yyyy-MM-dd}");
}
}
public void Action2(bool? b)
{
var logger = new ILogger();
if (b is not null)
{
// GOOD: Boolean? is a sanitizer.
logger.Warn($"Warning about the bool: {b}");
}
}
}