hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #15618 from JLLeitschuh/patch-6

Browse Source 
Fix typo in NettyRequestSplitting.java
This commit is contained in:
Chris Smowton
2024-02-14 20:44:40 +00:00
committed by GitHub
parent f5d9fe6b08 50056d603e
commit 7e41a895d8
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/ql/src/Security/CWE/CWE-113/NettyRequestSplitting.java
View File

@@ -1,11 +1,11 @@
public class NettyRequestSplitting {
// BAD: Disables the internal response splitting verification
// BAD: Disables the internal request splitting verification
private final DefaultHttpHeaders badHeaders = new DefaultHttpHeaders(false);
// GOOD: Verifies headers passed don't contain CRLF characters
private final DefaultHttpHeaders goodHeaders = new DefaultHttpHeaders();
// BAD: Disables the internal response splitting verification
// BAD: Disables the internal request splitting verification
private final DefaultHttpRequest badRequest = new DefaultHttpRequest(httpVersion, method, uri, false);
// GOOD: Verifies headers passed don't contain CRLF characters