hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 00:35:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove environment dictionary passing

Browse Source
This commit is contained in:
Tamas Vajk
2024-02-22 17:12:38 +01:00
parent 648c06ce27
commit e176b32a83
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
csharp/autobuilder/Semmle.Autobuild.CSharp/CSharpAutobuilder.cs
View File

@@ -53,7 +53,7 @@ namespace Semmle.Autobuild.CSharp
attempt = DotNetRule.WithDotNet(this, ensureDotNetAvailable: true, (dotNetPath, env) =>
{
// No need to check that the extractor has been executed in buildless mode
return new StandaloneBuildRule(dotNetPath, env).Analyse(this, false);
return new StandaloneBuildRule(dotNetPath).Analyse(this, false);
});
break;
case CSharpBuildStrategy.MSBuild:

6
csharp/autobuilder/Semmle.Autobuild.CSharp/StandaloneBuildRule.cs
View File

@@ -9,12 +9,10 @@ namespace Semmle.Autobuild.CSharp
internal class StandaloneBuildRule : IBuildRule<CSharpAutobuildOptions>
{
private readonly string? dotNetPath;
private readonly IDictionary<string, string>? env;
internal StandaloneBuildRule(string? dotNetPath, IDictionary<string, string>? env)
internal StandaloneBuildRule(string? dotNetPath)
{
this.dotNetPath = dotNetPath;
this.env = env;
}
public BuildScript Analyse(IAutobuilder<CSharpAutobuildOptions> builder, bool auto)
@@ -27,7 +25,7 @@ namespace Semmle.Autobuild.CSharp
}
var standalone = builder.Actions.PathCombine(builder.CodeQLExtractorLangRoot, "tools", builder.CodeQlPlatform, "Semmle.Extraction.CSharp.Standalone");
var cmd = new CommandBuilder(builder.Actions, environment: this.env);
var cmd = new CommandBuilder(builder.Actions);
cmd.RunCommand(standalone);
if (!string.IsNullOrEmpty(this.dotNetPath))