hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-24 16:25:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: The model generator should consider System.Type and System.DateTime as sanitizers.

Browse Source
This commit is contained in:
Michael Nebel
2024-05-31 10:53:35 +02:00
parent 02f9aec517
commit 8b75bb2ba9
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
csharp/ql/src/utils/modelgenerator/internal/CaptureModelsSpecific.qll
View File

@@ -168,6 +168,8 @@ private predicate irrelevantCollectionType(CS::Type ct) {
predicate isRelevantType(CS::Type t) {
not t instanceof CS::SimpleType and
not t instanceof CS::Enum and
not t instanceof SystemDateTimeStruct and
not t instanceof SystemTypeClass and
not irrelevantCollectionType(t)
}

4
csharp/ql/test/utils/modelgenerator/dataflow/Summaries.cs
View File

@@ -431,13 +431,13 @@ public class SimpleTypes
return i;
}
// SPURIOUS-summary=Models;SimpleTypes;false;M5;(System.DateTime);;Argument[0];ReturnValue;taint;df-generated
// neutral=Models;SimpleTypes;M5;(System.DateTime);summary;df-generated
public DateTime M5(DateTime d)
{
return d;
}
// SPURIOUS-summary=Models;SimpleTypes;false;M6;(System.Type);;Argument[0];ReturnValue;taint;df-generated
// neutral=Models;SimpleTypes;M6;(System.Type);summary;df-generated
public Type M6(Type t)
{
return t;