hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-21 15:05:56 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: Add tests for comparison-with-wider-type.

Browse Source
This commit is contained in:
Max Schaefer
2024-05-15 12:45:19 +01:00
parent eb9c734120
commit d406646414
3 changed files with 30 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/test/query-tests/security/CWE-190/semmle/tests/ComparisonWithWiderType.expected Normal file
View File

@@ -0,0 +1,2 @@
| ComparisonWithWiderType.java:4:25:4:29 | ... < ... | Comparison between $@ of type int and $@ of wider type long. | ComparisonWithWiderType.java:4:25:4:25 | i | expression | ComparisonWithWiderType.java:4:29:4:29 | l | expression |
| ComparisonWithWiderType.java:16:26:16:30 | ... > ... | Comparison between $@ of type byte and $@ of wider type short. | ComparisonWithWiderType.java:16:30:16:30 | b | expression | ComparisonWithWiderType.java:16:26:16:26 | c | expression |

27
java/ql/test/query-tests/security/CWE-190/semmle/tests/ComparisonWithWiderType.java Normal file
View File

@@ -0,0 +1,27 @@
public class ComparisonWithWiderType {
public void testLt(long l) {
// BAD: loop variable is an int, but the upper bound is a long
for (int i = 0; i < l; i++) {
System.out.println(i);
}
// GOOD: loop variable is a long
for (long i = 0; i < l; i++) {
System.out.println(i);
}
}
public void testGt(short c) {
// BAD: loop variable is a byte, but the upper bound is a short
for (byte b = 0; c > b; b++) {
System.out.println(b);
}
}
public void testLe(int i) {
// GOOD: loop variable is a long, and the upper bound is an int
for (long l = 0; l <= i; l++) {
System.out.println(l);
}
}
}

1
java/ql/test/query-tests/security/CWE-190/semmle/tests/ComparisonWithWiderType.qlref Normal file
View File

@@ -0,0 +1 @@
Security/CWE/CWE-190/ComparisonWithWiderType.ql