XXX: Disable dynamic join in some cases

2026-05-26 17:11:24 +02:00 · 2024-05-23 18:18:11 +01:00
4 changed files with 5 additions and 2 deletions
--- a/cpp/ql/lib/semmle/code/cpp/ir/implementation/aliased_ssa/internal/SSAConstruction.qll
+++ b/cpp/ql/lib/semmle/code/cpp/ir/implementation/aliased_ssa/internal/SSAConstruction.qll
@@ -317,6 +317,7 @@ private module Cached {
  }

  cached
+  pragma[no_dynamic_join_order]
  Instruction getChiInstructionTotalOperand(ChiInstruction chiInstr) {
    exists(
      Alias::VirtualVariable vvar, OldInstruction oldInstr, OldBlock defBlock, int defRank,
--- a/cpp/ql/lib/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/SSAConstruction.qll
+++ b/cpp/ql/lib/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/SSAConstruction.qll
@@ -317,6 +317,7 @@ private module Cached {
  }

  cached
+  pragma[no_dynamic_join_order]
  Instruction getChiInstructionTotalOperand(ChiInstruction chiInstr) {
    exists(
      Alias::VirtualVariable vvar, OldInstruction oldInstr, OldBlock defBlock, int defRank,
--- a/csharp/ql/integration-tests/posix-only/standalone_dependencies_nuget_config_fallback/diagnostics.expected
+++ b/csharp/ql/integration-tests/posix-only/standalone_dependencies_nuget_config_fallback/diagnostics.expected
@@ -13,12 +13,12 @@
  }
 }
 {
-  "markdownMessage": "C# was extracted with build-mode set to 'none'. This means that all C# source in the working directory will be scanned, with build tools, such as Nuget and Dotnet CLIs, only contributing information about external dependencies.", 
+  "markdownMessage": "C# with build-mode set to 'none'. This means that all C# source in the working directory will be scanned, with build tools, such as Nuget and Dotnet CLIs, only contributing information about external dependencies.",
  "severity": "note",
  "source": {
    "extractorName": "csharp",
    "id": "csharp/autobuilder/buildless/mode-active",
-    "name": "C# was extracted with build-mode set to 'none'"
+    "name": "C# with build-mode set to 'none'"
  },
  "visibility": {
    "cliSummaryTable": true,
--- a/shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll
+++ b/shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll
@@ -659,6 +659,7 @@ module MakeImplCommon<LocationSig Location, InputSig<Location> Lang> {
    predicate expectsContentCached(Node n, ContentSet c) { expectsContent(n, c) }

    cached
+    pragma[no_dynamic_join_order]
    predicate isUnreachableInCallCached(Node n, DataFlowCall call) { isUnreachableInCall(n, call) }

    cached