Merge pull request #4782 from johnlugton/patch-1

Fix FlowVar overflow bug
2026-05-16 04:09:27 +02:00 · 2020-12-04 10:48:44 -08:00 · 2020-12-04 10:45:51 -08:00 · 2020-10-15 16:09:45 +02:00
1 changed files with 1 additions and 1 deletions
--- a/cpp/ql/src/semmle/code/cpp/dataflow/internal/FlowVar.qll
+++ b/cpp/ql/src/semmle/code/cpp/dataflow/internal/FlowVar.qll
@@ -598,7 +598,7 @@ module FlowVar_internal {
  private predicate largeVariable(Variable v, int liveBlocks, int defs) {
    liveBlocks = strictcount(SubBasicBlock sbb | variableLiveInSBB(sbb, v)) and
    defs = strictcount(SubBasicBlock sbb | exists(TBlockVar(sbb, v))) and
-    liveBlocks * defs > 1000000
+    liveBlocks.(float) * defs.(float) > 10000.0
  }

  /**
Author	SHA1	Message	Date
Aditya Sharad	d7a27c4c8e	Merge pull request #4782 from johnlugton/patch-1 Fix FlowVar overflow bug	2020-12-04 10:48:44 -08:00
John Lugton	897d66bea9	Fix FlowVar overflow bug Applies fix from https://github.com/github/codeql/pull/4677/files	2020-12-04 10:45:51 -08:00
Jonas Jensen	2d505636b4	C++: Reduce large variable threshold to 10k Attempted mitigation for performance issues in the data flow library on databases with a very large number of variable definitions.	2020-10-15 16:09:45 +02:00